Amit Miran
29d6420ecc
fix: exception when saving dash ( #13300 )
...
* fix: project None value
* fix: pre-commit
2021-02-24 12:08:28 +02:00
Daniel Vaz Gaspar
9e2455aab7
refactor(api): csrf token on the new REST API ( #13212 )
...
* refactor(api): csrf token on the new REST API
* improve OpenAPI spec description
* fix test
* remove public role like has default for all tests
* fix test
2021-02-23 09:50:22 +00:00
Jesse Yang
af3a46048d
fix(home): missing key and invalid dates in Recents cards ( #13291 )
2021-02-22 20:30:52 -08:00
ʈᵃᵢ
a646914493
fix(menu): links that result in 404s ( #13283 )
2021-02-22 12:15:12 -06:00
Beto Dealmeida
3d23adec5e
chore: use shillelagh instead of gsheetsdb ( #13185 )
...
* chore: use shillelagh instead of gsheetsdb
* Fix tests
* Clean up code and remove duplication
* Fix test
* Tighten dep
2021-02-18 09:48:18 -08:00
ʈᵃᵢ
6e09156598
fix(sqllab): menu link results in 404 ( #13180 )
2021-02-17 09:14:30 -08:00
ʈᵃᵢ
c787f46f10
perf: add lazy loading along react-router routes and router links in menu ( #13087 )
2021-02-16 14:48:35 -08:00
Duy Nguyen Hoang
56fca17e62
Update http error code from 400 to 403 ( #13061 )
2021-02-13 13:32:21 +02:00
Daniel Vaz Gaspar
0cf57756f0
fix: add config to disable dataset ownership on the old api ( #13051 )
...
* fix: add config to disable dataset ownership on the old api
* fix CI docker build
* fix logic
* add deprecation comment on the config
2021-02-11 18:18:27 +00:00
simcha90
c5781cde60
feat(style): hide dashboard header by url parameter ( #12918 )
...
* feat(native-filters): hide dashboard header bu url parameter
* lint: fix lint
* test: add tests
* test: fix test
* refactor: upgrade standalone param
* fix: pre-commit and extract to method is_standalone_mode
* test: fix tests
* test: fix tests
* fix: fix standalone statement
* refactor: fix CR notes
* chore: pre-commit
* fix: fix sticky tabs + update CR notes
* lint: fix lint
* lint: fix lint
* fix: fix CR notes
* fix: fix CR notes
* lint: fix lint
* refactor: fix cr notes
Co-authored-by: amitmiran137 <amit.miran@nielsen.com >
2021-02-11 15:05:35 +02:00
Amit Miran
b472d1841c
feat(dashboard_rbac): dashboard_view access enforcement ( #12875 )
...
* test: dashboard_view_test failing
* test: tests works first time
* fix: pre-commit and some refactoring
* fix: after CR
* fix: replace not_published with draft
* fix: after CR
* fix: pre-commit fixes
* fix: pre-commit and lint fixes
* fix: remove unused
* fix: remove unused import
* fix: wrap the decorator to not block others
* chore: reuse dashboard from decorator into function
2021-02-04 13:23:53 -05:00
Rob DiCiuccio
d7cbd53fce
fix(async queries): Remove "force" param on cached data retrieval ( #12103 )
...
* Async queries: remove force cache param on data retrieval
* Assert equal query_object cache keys
* Decouple etag_cache from permission checks
* Fix query_context test
* Use marshmallow EnumField for validation
2021-01-27 10:16:57 -08:00
Jesse Yang
55c8f9ba60
feat(explore): allow opening charts with missing dataset ( #12705 )
2021-01-25 15:09:03 -08:00
Yongjie Zhao
e7a5d0d01a
fix: return appropriate response when payload has error ( #12575 )
2021-01-19 14:57:25 +08:00
Kasia Kucharczyk
ad63823d6f
fix: Added message flash when chart with missing dataset is accessed. ( #12468 )
2021-01-18 22:42:03 -08:00
Beto Dealmeida
ce1abc98df
chore: rename variable for clarity ( #12159 )
2020-12-21 13:39:13 -08:00
Beto Dealmeida
6e7f276775
feat: initial custom error messages for SQL Lab ( #12080 )
2020-12-17 22:58:21 -08:00
Daniel Vaz Gaspar
dd5cdb1b5f
feat(dashboards): security permissions simplification ( #12012 )
...
* feat(dashboards): security perm simplification
* fix tests
* fix tests
* remove unnecessary mapping
* fix JS tests
* fix cypress test and explore endpoint
* update alembic down revision
* Merge branch 'master' into feat/security-converge-dashboards
# Conflicts:
# superset/constants.py
# tests/security_tests.py
2020-12-17 09:53:13 +00:00
Beto Dealmeida
8bda6b0bd9
feat: show missing parameters in query ( #12049 )
...
* feat: show missing parameters in query
* Fix lint
* Address comments
* Simplify error message
* Use f-string in helper function
2020-12-15 18:47:40 -08:00
Grace Guo
8da1900d8a
feat: add hook for dataset health check ( #11970 )
...
* feat: add hook for dataset health check
* add event log
* optimize datasource json data like certified data
* add unit test
* fix review comments
* extra code review comments
2020-12-15 18:12:06 -08:00
Jesse Yang
76f9f185fb
refactor: optimize backend log payload ( #11927 )
2020-12-15 17:22:23 -08:00
Daniel Vaz Gaspar
f79e52f48e
feat(charts): security perm simplification ( #11981 )
...
* feat(charts): security perm simplification
* fix superset explore
* fix JS test
* fix cypress test
* fix split heads
* fix favorite permission
* fix permission
* update with new async permission
* fix new permission coming from master
* fix core permission assert
* black
* update alembic down revision
2020-12-15 11:27:06 +00:00
Rob DiCiuccio
4d329071a1
feat(SIP-39): Async query support for charts ( #11499 )
...
* Generate JWT in Flask app
* Refactor chart data API query logic, add JWT validation and async worker
* Add redis stream implementation, refactoring
* Add chart data cache endpoint, refactor QueryContext caching
* Typing, linting, refactoring
* pytest fixes and openapi schema update
* Enforce caching be configured for async query init
* Async query processing for explore_json endpoint
* Add /api/v1/async_event endpoint
* Async frontend for dashboards [WIP]
* Chart async error message support, refactoring
* Abstract asyncEvent middleware
* Async chart loading for Explore
* Pylint fixes
* asyncEvent middleware -> TypeScript, JS linting
* Chart data API: enforce forced_cache, add tests
* Add tests for explore_json endpoints
* Add test for chart data cache enpoint (no login)
* Consolidate set_and_log_cache and add STORE_CACHE_KEYS_IN_METADATA_DB flag
* Add tests for tasks/async_queries and address PR comments
* Bypass non-JSON result formats for async queries
* Add tests for redux middleware
* Remove debug statement
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
* Skip force_cached if no queryObj
* SunburstViz: don't modify self.form_data
* Fix failing annotation test
* Resolve merge/lint issues
* Reduce polling delay
* Fix new getClientErrorObject reference
* Fix flakey unit tests
* /api/v1/async_event: increment redis stream ID, add tests
* PR feedback: refactoring, configuration
* Fixup: remove debugging
* Fix typescript errors due to redux upgrade
* Update UPDATING.md
* Fix failing py tests
* asyncEvent_spec.js -> asyncEvent_spec.ts
* Refactor flakey Python 3.7 mock assertions
* Fix another shared state issue in Py tests
* Use 'sub' claim in JWT for user_id
* Refactor async middleware config
* Fixup: restore FeatureFlag boolean type
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
2020-12-10 20:21:56 -08:00
Maxime Beauchemin
150c8e36b1
fix: always fetch database list on bootstrap payload ( #11934 )
...
There was this weird bug happening only when `SQLLAB_BACKEND_PERSISTENCE
= False` where if no database had been selected, there would be some
issue.
This makes sure that the store is populated consistently with the list
of database connections regardless of `SQLLAB_BACKEND_PERSISTENCE`. It
also uses the DAO to fetch database and will apply the RBAC-related
filters if any, the same way that the API does.
2020-12-09 09:36:18 -08:00
Erik Ritter
fa68288d61
fix: make sure we log the logs ( #11939 )
2020-12-04 16:50:16 -08:00
Will Barrett
1842c56209
Capture error when celery back-end does not support forgetting tasks ( #10770 )
2020-12-02 09:47:02 -08:00
ʈᵃᵢ
ffa32cde14
chore: remove SIP_34_QUERY_SEARCH_UI feature flag ( #11863 )
2020-12-01 09:29:16 -08:00
Maxime Beauchemin
0504cf1a00
chore: improve analytics ( #11714 )
...
* chore: improve analytics
* lint
* log more events, add note in UPDATING.md
* handling base class
* more events\!
* get ref through
* right before @expose
* fix context
* touchups
2020-11-25 08:45:02 -08:00
auxten
ac0dd3fa32
fix: attachment filename error in sqllab with i18n ( #11762 )
...
* Fix attachment filename error in sqllab
* Fix line too long lint
* Fix black lint
2020-11-25 13:05:30 +02:00
Erik Ritter
c0224aa928
feat: add certification info to table selector ( #11785 )
2020-11-24 12:13:52 -08:00
Hugh A. Miles II
1ef3a02e7a
feat: Add user info to sqllab via bootstrap data ( #11760 )
2020-11-19 18:32:51 -08:00
Jesse Yang
4cfcaebb61
feat: rename TABLE_NAMES_CACHE_CONFIG to DATA_CACHE_CONFIG ( #11509 )
...
* feat: rename TABLE_NAMES_CACHE_CONFIG to DATA_CACHE_CONFIG
The corresponding cache will now also cache the query results.
* Slice use DATA_CACHE_CONFIG CACHE_DEFAULT_TIMEOUT
* Add test for default cache timeout
* rename FAR_FUTURE to ONE_YEAR_IN_SECS
2020-11-13 22:35:10 -08:00
ʈᵃᵢ
432e5ab460
feat: Query History CRUD list view ( #11574 )
2020-11-12 11:55:13 -10:00
Beto Dealmeida
4a070cfceb
chore: consolidate dashboard import logic ( #11529 )
...
* Consolidate dash import logic
* Fix lint
* Remove Slice.import_obj
* Remove unused import
* Fix log
2020-11-11 14:50:18 -08:00
Grace Guo
b9284d3a3c
fix(dashboard): use server-side lastModifiedTime for co-edit check ( #11614 )
...
* fix: [dashboard][co-edit] Round client-side lastModifiedTime
* another try: server-side returns last_updated_time in save_dash response
2020-11-09 13:30:40 -08:00
Jesse Yang
29554a9f02
fix: show recent visited dashboards and charts in recent_activity ( #11481 )
2020-10-30 11:59:08 -07:00
Grace Guo
b1263ad568
Revert "fix: change chart title by clicking ( #11335 )" ( #11497 )
...
This reverts commit 1f04db79f7
2020-10-29 15:13:29 -07:00
David Aaron Suddjian
18658f45be
feat(dashboards): Filter status indicators ( #10936 )
...
* Initial commit of new filters badge.
* refactor applied/rejected filters code
* finished filter indicators
* filter badge tested
* unnecessary imports
* formatting and types
* fixes
* license
* code quality tweaks
* state management for showing focused filter scope
* clean up filter key extraction code
* remove unnecessary styles
* temp css to demonstrate highlighting
* fix focused filter logic
* no more color badges
* new toys for highlighting dash components (#11144 )
* tweak style for the filter chart when filter is focused
* style: Filters p0 css2 (#11151 )
* nixing background tweak
* src paths
* another quick theme color
* src paths, adjusting pill icon color, changing icons, showing applied/busted counts
* linting stuff
* fixing and tweaking tests
* show filter indicator when filters are not active
* chart title bar cleanup
* open the right panel when popover opens
* unused import
* fix EditableTitle tests
* margin on dashboard header
* show the chart dropdown menu
* fix blur filter breaking dropdowns
* style tweak - no pointer events when irrelevant charts are blurred
* fix box shadow on filter highlight
* it's an array
* attempt fixing e2e
* style: filters p0 icon churn (#11215 )
* new filters icon
* icon styling
* bigger icons in list views
* better sizing of table actions and favStars
* more icon sizing...
* fixing more button size jankiness
* linting
* Filters performance (#11255 )
* fixing time filter "ok" button
* making unset filter menu collapsible
* sort alphabetically
* fix highlighting when removing items
* try a flex layout (for browser render perf)
* more specific transitioning
* temp: comment out some code as a test
* temp: comment out more code
* temp: remove possibly expensive computations from ChartHolder
* Revert "temp: comment out some code as a test"
This reverts commit 309b880e9064c88b2cba37ce0214f0c3972ba486#11325 )
* fix: use dashboard id for stable cache key (#11293 )
* fix: button translations missing (#11187 )
* button translations missing
* blank space before text
* feat: update time_compare description and choices (#11294 )
* feat: update time_compare description and choices
* Update sections.jsx
* fix(extra-filters): add logic for identifying applied extra filters
* lint
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com >
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com >
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com >
* address design feedback
* slight tweak to panel logic, keep panels open that user has opened
* rearrange code to be more graceful
* fix: bump superset-ui/core (#11385 )
* use is_dttm instead of is_temporal
* types, names
* only show unset filter panel if there are unset filters
* fix highlighting the filter control
* fix filterbox layout
* translations
* fix cypress
* actually add the test attribute
* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* formatting
* add link comment to hack
* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* stop importing lodash
* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* skip broken test
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* adjust colors of titles
* linting
* no indicators when chart is loading
* support all time fields
* fix lock file
Co-authored-by: Natalie Ruhe <natalie@preset.io >
Co-authored-by: Evan Rusackas <evan@preset.io >
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com >
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com >
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com >
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com >
2020-10-28 15:46:24 -07:00
John Bodley
8ee6493233
chore: Update testconn logic ( #11315 )
...
* chore: Update testconn logic
* [databases] Address @dpgaspar's comments
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-10-27 09:15:05 +00:00
Daniel Vaz Gaspar
144b279aa2
feat: saved queries with execution info ( #11391 )
...
* feat: add rows and last_run info to saved queries
* feat: add rows to saved query
* refactor and tests
* lint
* fix tests
2020-10-26 11:20:07 -07:00
Lily Kuang
1f04db79f7
fix: change chart title by clicking ( #11335 )
2020-10-22 18:33:13 -07:00
Maxime Beauchemin
f6436b7652
fix: 'Save Chart' modal's dashboard dropdown isn't sticky ( #11338 )
...
It appears that the logic that makes the dashboard selection sticky
in the 'Save Chart' modal (explore) was broken at some time.
While working on a dashboard, it's nice if this modal can remember the
dashboard selection.
2020-10-21 17:30:19 -07:00
Jesse Yang
634676d467
refactor: use contextmanager for event_logger decorators ( #11222 )
2020-10-14 10:44:06 -07:00
Jesse Yang
2c649ac20f
perf: cache dashboard bootstrap data ( #11234 )
2020-10-13 18:43:06 -07:00
John Bodley
51fec1ab16
fix: Ensure consistent naming for testconn ( #11246 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-10-13 09:53:03 -07:00
Grace Guo
4f4367edf3
feat: prevent co-edit dashboard collision ( #11220 )
...
* feat: prevent co-edit dashboard collision
* fix comments
2020-10-12 17:58:32 -07:00
Erik Ritter
6cf698cc6a
chore: deprecate REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD ( #11244 )
2020-10-12 17:31:56 -07:00
Ville Brofeldt
e647286393
chore(sql-lab): catch PyArrow deserialization error ( #11201 )
2020-10-12 10:16:00 +03:00
John Bodley
513bf10a38
chore: Leverage SQLALchemy ping rather than explicit SELECT 1 for testconn ( #11223 )
2020-10-11 12:44:15 -07:00
Grace Guo
a10e86ab31
fix: revert eTag cache feature for dashboard ( #11203 )
...
* revert #11137
* revert #10963
2020-10-08 12:15:08 -07:00
