QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-21 09:04:38 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,833 Commits 447 Branches 542 Tags
9da7c1f7b83abea20e3620d5461a47dc4a2ab019
Commit Graph

61 Commits

Author SHA1 Message Date
Phillip Kelley-Dotson
9da7c1f7b8 feat: hack db connection modal ctabtns (#20017) 
* add flow for dbconnmodal to datasetmodal

* fix bug

* second part

* fix dataset to sql lab

* fix lint

* more lint

* add key value

* fix type

* add new styling

* remove undefined from types
 2022-07-05 08:56:12 -07:00
Antonio Rivero Martinez
850f5fa136 fix(database-modal): Refresh Data when importing (#20523) 
* Database Modal:

- Add missing invocation to onDatabaseAdd after importing DB from file
- Add keys to our IconButtons

* Database Modal:

- Reduce if clause so it's more concise
 2022-06-28 16:13:09 -06:00
Michael S. Molina
d6f9fb5af1 chore: Removes unused vars (#20194) 
* chore: Removes unused vars

* Fixes lint

* Disables no-unused-vars for the operators
 2022-06-15 11:01:45 -03:00
Phillip Kelley-Dotson
160e674b90 fix: update connection modal to use existing catalog (#20372) 
* fix: update connection modal to use existing catalog

* remove console
 2022-06-14 15:10:01 -04:00
Diego Medina
8345eb4644 fix: A newly connected database doesn't appear in the databases list if user connected database using the 'plus' button (#19967) 
* fix: A newly connected database doesn't appear in the databases list if user connected database using the 'plus' button

* include onDatabaseAdd on successful import
 2022-06-12 22:21:30 +08:00
Diego Medina
c6dd7fedbd fix: The dynamic form to connect to Snowflake DB is not returning any errors (#20013) 
* fix: The dynamic form to connect to Snowflake DB is not returning any errors

* PR comment
 2022-05-13 12:50:11 -06:00
Diego Medina
cc026e9fec fix: URI form is blank when trying to connect from sql lab (#20004) 2022-05-11 08:57:11 +08:00
smileydev
ea6753d27d fix(allow-db-explore): make to check the allow virtual table explore option by default (#19883) 
* fix(db & explore): make to check the allow-db-explore option by default

* fix(db-explore): make to remove console.log
 2022-04-28 12:52:33 -07:00
Phillip Kelley-Dotson
ad715429f9 chore: simplify error messaging in database modal (#19165) 
* testing for dbconn modal error message

* remove consoles and error alert mapping

* lint fix

* update url message

* add modal fix

* update comments

* fix err msg bugs

* fix pylint

* fix line

* fix tests

* fix assertions
 2022-04-21 12:44:21 -07:00
Smart-Codi
94075983f8 feat: Remove legacy sql alchemy db connection link from G Sheet connection (#19450) 
* feat: Remove legacy sql alchemy db connection link from G Sheet connection

* resolve comment
 2022-04-14 14:34:15 -06:00
Ville Brofeldt
f21ba68a30 chore: clean up dynamic translation strings (#19641) 2022-04-11 13:02:20 +03:00
Lyndsi Kay Williams
d52e3867ac feat: Move Database Import option into DB Connection modal (#19314) 
* rebase

* more progress

* Fix unintended changes

* DB import goes to step 3

* debugging

* DB list refreshing properly

* import screens flowing properly

* Code cleanup

* Fixed back button on import flow

* Remove import db tooltip test

* Fix test

* Password field resets properly

* Changed import modal state dictators and removed unneeded comment

* Removed unneeded param pass and corrected modal spelling

* Fixed typos

* Changed file to fileList

* Clarified import footer comment

* Cleaned passwordNeededField and confirmOverwriteField state checks

* debugging

* Import state flow fixed

* Removed unneeded importModal check in unreachable area

* Fixed import db footer behavior when pressing back on step 2

* Import db button now at 14px

* Removed animation from import db button

* Fixed doble-loading successToast

* Fixed errored import behavior

* Updated import password check info box text

* Connect button disables while importing db is loading

* Connect button disables while overwrite confirmation is still needed

* Connect button disables while password confirmation is still needed

* Removed gray line under upload filename

* Hide trashcan icon on import filename

* Modal scroll behavior fixed for importing filename

* Changed errored to failed

* RTL testing for db import
 2022-04-08 10:03:40 -07:00
Yongjie Zhao
761d5c4208 chore: cleanup as unknown conversion (#19587) 2022-04-08 17:32:29 +08:00
Diego Medina
634693b270 fix: Dynamic form to connect to Snowflake DB is not displaying authentication errors (#19491) 
* fix: Dynamic form to connect to Snowflake DB is not displaying authentication errors

* pr comments
 2022-04-05 13:11:33 -06:00
Beto Dealmeida
d304849b46 feat: disable edits on external assets (#19344) 
* feat: disable edits on external assets

* Update tests
 2022-03-28 16:32:57 -07:00
smileydev
5ae7e54999 fix(database): make to allow the expose db as default in sqlalchemy form db (#19337) 2022-03-25 15:47:14 -06:00
smileydev
8e7af79aa9 fix(dbs-dropdown): make to allow the search in supported db dropdown (#19125) 2022-03-15 23:09:56 -06:00
smileydev
62ad574c24 fix(allow-db-explore): make that the set the allow-db-explore option (#19030) 2022-03-09 14:59:57 -07:00
Michael S. Molina
329855170e refactor: Deletes the common/components folder (#18999) 2022-03-04 14:19:14 -03:00
Hugh A. Miles II
78e20e21ab feat: add prop to setDBEngine in DatabaseModal (#18653) 
* saving this now

* remove for testing

* added test

* remove this

* remove set

* remove log

* Update index.test.jsx
 2022-02-10 16:12:52 -08:00
Phillip Kelley-Dotson
ac564ea6b7 feat: add success message for database modal (#18183) 2022-01-26 15:52:15 -08:00
Beto Dealmeida
51090c3f1b feat: shorter timeout on test_connection (#18001) 
* feat: shorter timeout on test_connection

* pip-compile-multi --no-upgrade

* Fix for SQLite

* Return 408

* Add test
 2022-01-12 13:01:34 -08:00
Holger Bruch
6604a6ab28 chore(translations): Add missing i18n (#17525) 
* Add *.ts to babel.cfg

* Add missing i18n calls

* Update pot file

* Fix lint issues and review comment

* Incorparate review feedback

* Fix missing or non-extractable i18n calls

* Update pot file

* Fix syntax error in CommonParameters.tsx

* Fix introduced issues
 2021-11-27 14:50:33 +02:00
Yongjie Zhao
9070b6b19c refactor(monorepo): stage 1 (#17427) 
* skip geojson in pre-commit

update prettier

* update package.json

update package.json

u package

pkg

pkg2

* lint main repo 2

lint main repo

lint

* lintrc

lintrc 2

lintrc2

lintrc 3

lintrc

* fix import

* refresh lock file

* fix break line make @ts-ignore invalid

* update rat-excludes

rat-excludes

update rat-excludes

* update eslintrc.js

* lint lint lint
 2021-11-17 15:31:36 +08:00
Shiva Raisinghani
ef3afbde82 refactor: Repeated boilerplate code between upload to database forms (#16756) 
* abstract boilerplate code into class and rename csv to file

* add db migration

* fix some stuff

* more renaming of csv to file

* rename in translations

* update down revision

* update down revision

* bump chart version

* switch to alter column name approach in db migration

* fix db migration for MySQL

* db migration conflict
 2021-10-25 13:53:06 +03:00
AAfghahi
e32a12fa0b bug fix (#17019) 2021-10-08 10:19:04 -07:00
AAfghahi
50ad09bbdc removing paramProperties (#17024) 2021-10-07 15:28:41 -04:00
AAfghahi
aa747219ad feat: Add Private Google Sheets to dynamic form (#16628) 
* first pass private gsheets

* made encrypted extra into string, refactored onParametersChanged

* private sheets working, credential_info errors

* all but test connection working

* first pass private gsheets

* made encrypted extra into string, refactored onParametersChanged

* private sheets working, credential_info errors

* all but test connection working

* Regenerate package-lock.json

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-09-28 17:08:50 -07:00
Michael S. Molina
9b17e86b44 chore: Moves messageToasts to the components folder (#14431) 
* chore: Moves messageToasts to the components folder

* Rebases
 2021-09-22 07:44:54 -03:00
AAfghahi
376c685838 feat: adding logging to validation (#16527) 
* adding logging to validation

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-09-13 16:09:40 -07:00
AAfghahi
a6aad52e38 fix: regex for multi-region IPs (#16410) 
* regex for multi-region IPs

* Update index.tsx
 2021-08-23 13:54:25 -07:00
Beto Dealmeida
5d3d6b6eae fix: validate_parameters and query (#16241) 
* fix: validate_parameters and query

* add onQueryChange
 2021-08-12 18:05:27 -07:00
Hugh A. Miles II
171514360e feat: Allow users to connect via legacy SQLA form (#16201) 
* hugh/dbui-other

* remove extra condition

* add not callable

* Update .pylintrc

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-08-12 15:10:42 -04:00
AAfghahi
2dc0bdda5d feat: Added multi-regional IPs to Database Connections (#16170) 
* added google alert

* multi-regional IPs

* beto revisions

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-08-10 17:25:49 -07:00
Beto Dealmeida
9f52c103ac fix: isDynamic function (#16175) 
* fix: isDynamic function

* trigger tests
 2021-08-10 16:28:43 -07:00
Hugh A. Miles II
3f86a54ac1 fix: turn on SSL in database edit form show 500 error (#16151) 
* fix error for query.update

* converrt before making request

* fix query params

* remove unchanged files

* this

* update tsconfig
 2021-08-10 13:31:28 -04:00
Lyndsi Kay Williams
3712ee02fa additional params field fixed (#16161) 2021-08-09 19:13:37 -07:00
AAfghahi
a51851308b feat: added google alert to DB Connection Form (#16095) 
* added google alert

* using superset_text

* made google alert public and others private

* Hugh revisions
 2021-08-09 14:08:06 -04:00
Beto Dealmeida
ec22acb786 fix: handle schemas_allowed_for_csv_upload serde (#16038) 
* fix: handle schemas_allowed_for_csv_upload serde

* Add migration
 2021-08-03 09:10:32 -07:00
Beto Dealmeida
ce6bc3b598 fix: save DB with with query (#15991) 2021-07-31 10:48:15 -07:00
Beto Dealmeida
f1b57c0d88 fix: DB add modal (#15981) 2021-07-30 14:32:48 -04:00
Hugh A. Miles II
bfe7eb9a7b feat(dbc ui): Adding Google Sheets Dynamic Form (#15801) 
* feat: Make Google Sheets Dyanmic (#15576)

* first draft

* second draft

* added tests

* first draft

* added table_catalog

* remove console.log

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* revisions

* save this for now

* working form

* save disable on public sheets

* refactor somethings

* saving this for now

* working edit

* add back query to schema

* working add

* fix styling

* fixing x

* fix linting

* prettier

* fix some type issues

* more lint fixes

* remove unused dependency

* fix linint

* fix validation

* pylint bypass

* pylint bypass

* fix this

* fix mypy

* yerp

* fix test

* fix test

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* wrap add sheets

* fix linting issues

* fix unit test

* ignore typing

* fix editting and paste issues

* remove query

* fix this

* fix test

* add test back

* fix error messaging

* update url messaging on error

* change error type

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* add errors for sheets with no name

* fix

* fix messaging for gsheets

* stop pylint

* update line

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: Arash <arash.afghahi@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-07-28 15:00:27 -04:00
Hugh A. Miles II
7d0f6ab7f5 fix: Fixing schemas_allowed_for_upload field in database connection UX (#15750) 2021-07-19 12:12:37 -04:00
Hugh A. Miles II
2dc8bd6c30 fix: Fix test connection for extra fields (#15645) 
* create serialize json function

* remove console.log

* use function
 2021-07-12 20:19:45 -07:00
Hugh A. Miles II
2252f3396c fix: Remove default values for engine and schemas (#15635) 
* remove default values

* don't set initial value on save

* set defaults for engine_params

* update with JSON.parse
 2021-07-12 15:37:44 -07:00
Beto Dealmeida
5d86ffe768 fix: duplicate DB names (#15614) 2021-07-12 09:36:46 -07:00
AAfghahi
2ebba519c9 clears errors when closing out of modal (#15623) 2021-07-09 14:15:16 -07:00
AAfghahi
faf6fcd83e fix: Database List Sorted (#15619) 
* sorted the database list

* revisions

* cloned the array

* one more time with feeling

* added documentation link as well
 2021-07-09 13:06:17 -07:00
Lyndsi Kay Williams
b5fc03f964 fix: Database Connection Modal - corrected tooltip alignment and info alert width (#15612) 
* Added margins to info alerts

* Tooltips aligned
 2021-07-09 10:01:16 -07:00
AAfghahi
ad85e7be52 added isEditMode (#15594) 2021-07-08 13:00:21 -07:00