Commit Graph

282 Commits

Author SHA1 Message Date
Ville Brofeldt
9dfa33fedf fix(dnd): make clicked dnd metrics unique (#16632) 2021-09-08 13:21:21 +03:00
Yongjie Zhao
80c39daa85 fix: can't drop column when name overlap (#16482) 2021-09-01 13:52:10 +08:00
Erik Ritter
8adc31d14c Revert "chore: Changes the DatabaseSelector to use the new Select component (#16334)" (#16478)
This reverts commit c768941f2f.
2021-08-26 22:28:04 -03:00
Jesse Yang
a413f796a6 fix(explore): JS error for creating new metrics from columns (#16477) 2021-08-26 17:04:45 -07:00
Jesse Yang
ec087507e5 refactor(explore): improve typing for Dnd controls (#16362) 2021-08-26 01:23:14 -07:00
Geido
db11c3e6c8 feat: Draggable and Resizable Modal (#16394)
* Implement resizable prop

* Implement resizableConfig

* Implement fluid Syntax Highlighter

* Implement draggable

* Destroy on close

* Implement draggableConfig

* Enhance with footer calculation

* Add new line

* Make whole header draggable trigger
2021-08-25 16:11:16 +03:00
Michael S. Molina
c768941f2f chore: Changes the DatabaseSelector to use the new Select component (#16334) 2021-08-23 15:41:03 -03:00
Phillip Kelley-Dotson
3faf653e5f initial commit (#16366) 2021-08-20 17:46:55 -06:00
Kamil Gabryjelski
a547dcb73e fix(explore): reordering columns with dnd sometimes glitching (#16322)
* fix(explore): reordering columns with dnd sometimes glitching

* Fix metrics and filters popover being stale after reordering
2021-08-18 18:39:05 +02:00
Kamil Gabryjelski
203c311ca3 feat(explore): make dnd controls clickable (#16119)
* Make ghost buttons clickable

* Popover for column control

* Make column dnd ghost button clickable

* Prefill operator only if column is defined

* Remove data-tests

* lint fix

* Hide new features behind a feature flag

* Change ghost button texts

* Remove caret for non clickable columns
2021-08-17 14:56:39 +02:00
Geido
a1e18ed110 fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel (#16060)
* Implement dynamic tooltip

* Normalize and consolidate

* Clean up

* Refactor and clean up

* Remove unnecessary var

* Fix type import

* Update superset-frontend/src/explore/components/controls/OptionControls/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Remove unnecessary styled span

* Show full tooltip title

* Force show tooltip

* Force show tooltip D&D off

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-08-12 11:48:16 -06:00
Kamil Gabryjelski
a16e290765 fix(explore): conditional formatting value validators (#16230)
* fix(explore): conditional formatting value validators

* Fix typing, make validator more generic

* Remove commented code
2021-08-12 14:31:29 +02:00
Kamil Gabryjelski
ccfc95fbe6 fix(explore): adhoc metrics popover resets label after hovering outside (#16196)
* fix(explore): adhoc metrics popover resets label after hovering outside

* Remove irrelevant tests and skip rest

* Use ensureIsArray
2021-08-11 10:05:08 -06:00
Kamil Gabryjelski
98fc29cbbb fix(explore): metric label disappearing in some scenarios (#16190) 2021-08-11 14:05:44 +02:00
Junlin Chen
9841c78967 chore: switch back tag name to popular from highly-used (#16174)
* chore: switch back tag name to popular from highly-used

* new package lock

* new package lock with npm 7

* fix lint

* remove package changes

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-08-10 20:23:14 -07:00
Kamil Gabryjelski
6e1d16d956 feat(explore): each control can define its own canDrop for dnd (#16090)
* feat(explore): each control can define its own canDrop for dnd

* Make canDropValue optional

* Add onDropValue
2021-08-10 17:04:42 +02:00
Kamil Gabryjelski
b7cc89c6d4 fix(explore): dnd error when dragging metric if multi: false (#16088)
* fix(explore): dnd error when dragging metric if multi: false

* Fix error for non-dnd controls
2021-08-09 18:15:50 +02:00
Kamil Gabryjelski
6ac4f4ef2f chore(explore): change dnd placeholders (#16116)
* chore(explore): change dnd placeholders

* Fix tests and lint
2021-08-09 17:50:11 +02:00
Kamil Gabryjelski
772da8de63 fix(explore): revert dnd column dependency array change to fix infinite rerenders (#16115)
* fix(explore): revert dnd column dependency array change to fix infinite rerenders

* Remove console.log

* Remove comment
2021-08-06 17:59:22 +02:00
David Aaron Suddjian
e6292a89bb fix(explore): drag & drop column select component triggering onChange unnecessarily (#16073)
* fix(explore): avoid sync until after first render

* fix example
2021-08-05 15:38:28 -07:00
Kamil Gabryjelski
a59d458e41 chore(explore): Create new entrypoints for Echarts Timeseries (#15942)
* feat(explore): Create new entrypoints for Echarts Timeseries

* Change order of some charts

* bump superset-ui

* also bump echarts package

* fix UT

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-08-05 07:28:16 +02:00
Ville Brofeldt
7ef97a54e2 feat(explore): add automatic conditional formatter to pivot table v2 (#16045) 2021-08-04 22:12:20 +03:00
Kamil Gabryjelski
5917407b9c fix(explore): filter popover opening after removing a filter (#16024) 2021-08-02 22:01:17 +02:00
Geido
39913d286a Implement sectionId (#16022) 2021-08-02 12:12:36 -07:00
Kamil Gabryjelski
3061b6ad09 fix(explore): fix undefined error when using dnd (#16020) 2021-08-02 15:22:32 +02:00
Phillip Kelley-Dotson
5fd798afb7 chore: change dropdown icons from horizontal to vertical (#15958)
* change icons

* add size

* fix storybook

* fix favstar, add new icons, and others

* fix lint
2021-07-30 17:02:40 -06:00
Geido
c2e4290392 fix(dashboard): Add required message in the tooltip for the time range filter (#15941)
* Add required msg in tooltip

* Fix lint

* Keep red border on hover
2021-07-30 09:44:33 +02:00
Yongjie Zhao
11b0249803 fix: remove unused time column when update dataset (#14969)
* fix: remove unused time column when update dataset

* fix lint

* set dttm to first datatime column
2021-07-28 21:40:16 +08:00
David Aaron Suddjian
a3f54a6c7b chore: small viz gallery tweaks (#15900)
* allow passing styles to selector component

* make onClear optional

* remove broken font-size declarations

* fix bad hook dependency

* move all charts selector outside of Collapse

* stop hiding all charts button

* slight copy change

* remove x

* min left pane size

* remove default p bottom margin

* remove unused import

* fix test
2021-07-27 18:21:19 -07:00
Michael S. Molina
663dd3f853 chore: Improves the layout of the VizTypeGallery component (#15907)
* chore: Improves the layout of the VizTypeGallery component

* copy edit

* Enables search

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-07-27 15:17:36 -03:00
Kamil Gabryjelski
3f5237a3c1 feat(explore): new datasets have autocomplete filters enabled if UX_BETA is set (#15864)
* feat(explore): new datasets have autocomplete filters enabled if UX_BETA is set

* Lint fix

* Set autocomplete to True in example datasets

* Use "IN" as a default operator in dnd filters

* Default operator only if UX_BETA enabled
2021-07-27 17:40:10 +02:00
Yaozong Liu
fb5dce07b7 chore: implement new mockup to the new viz gallery (2nd iteration) (#15868)
* chore: implement new mockup to the new viz gallery

* fix: update package-lock

* fix: add license

* fix: reduce duplication and fit within the sidebar

* fix: ut
2021-07-26 11:10:39 -07:00
David Aaron Suddjian
7330aefeac feat: deprecate plugins by their metadata (#15882) 2021-07-24 16:52:07 +08:00
Kamil Gabryjelski
d408ff8466 fix(explore): show multi queries results in View query modal and data pane (#15840)
* fix(explore): show multiple queries in View query modal

* show multiple queries result in data pane

* fix tests

* lint fix
2021-07-23 17:04:22 +02:00
Geido
d4bec135e8 Render value immediately (#15820) 2021-07-22 11:46:01 -07:00
Kamil Gabryjelski
5e1c469f42 feat(explore): default aggregate for string/numeric columns when creating metric (#15798)
* feat(explore): default aggregate for string/numeric columns when creating metric

* Fix for editing items with the same label

* Replace componentDidUpdate with getDerivedStateFromProps

* Wrap changes in feature flag
2021-07-22 18:23:10 +02:00
Yongjie Zhao
3b7441663c chore: Add tags to the new viz gallery (#15734)
* chore: add tags to gallery

* fix UT

* fix lint

* redesign tags filter

* chore: change to Highly-used and fix some css

* fix UT

Co-authored-by: stephenLYZ <750188453@qq.com>
2021-07-20 17:59:59 +08:00
Kamil Gabryjelski
239336c3e8 fix(explore): dnd multiple columns doesn't work (#15781) 2021-07-19 20:18:10 +02:00
Geido
45c3ae0bf9 chore: Select component refactoring - ColorSchemeControl - Iteration 5 (#15555)
* Enhance Select

* Transition Select to Antd

* Update test

* Fix Cypress

* Change name to aria-label

* Update Cypress search val

* Test Cypress selection
2021-07-19 00:07:40 -06:00
Geido
5cc4f3c4b9 chore: Select component refactoring - DateFilterControl - Iteration 5 (#15571)
* Transition to Antd for DateFilterLabel

* Enhance styles

* Fix test

* Update superset-frontend/src/explore/components/controls/DateFilterControl/components/CustomFrame.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-07-19 00:04:07 -06:00
Kamil Gabryjelski
4234031cba feat(explore): UX improvements for drag'n'dropping time column (#15740) 2021-07-19 01:52:34 +08:00
Kamil Gabryjelski
71924eb40b fix(explore): wrong error message in conditional formatting (#15732) 2021-07-16 18:02:12 +02:00
Kamil Gabryjelski
66c28d653f fix(explore): DndColumnSelect sometimes not working with multi: false (#15731)
* fix(explore): DndColumnSelect not working with multi: false

* fix values not synchronized when dataset changes
2021-07-16 14:20:13 +02:00
gordern
22494b642e fix: remove form invalid title (#15679) (#15680) 2021-07-14 16:55:47 -06:00
Kamil Gabryjelski
a914e3c1cb feat(explore): Implement conditional formatting component (#15651)
* feat(explore): Implement conditional formatting

* Improved validation

* Fix undefined error

* Refactor after code review

* Add licenses

* Remove redundant div

* Remove formatters when corresponding column is removed
2021-07-13 18:05:16 +02:00
David Aaron Suddjian
257385e888 feat(explore): Upgraded viz select gallery (#15303)
* add modal layout with description, rework styles

* thirty percent

* test correctly

* avoid any changes in modal height

* typescriptify

* feat(viz): add categories to the viz picker (#15304)

* feat(viz): add categories to the viz picker

* fix test types

* add a catch-all category

* tweak layout

* upgrade superset-ui to get new metadata

* do i look like i know what a jpeg is

* fix tests

* lint

* remove script count test requirement

* fix e2e test

* feat(explore): Viz picker search improvements (#15399)

* upgrade superset-ui, install fuse.js

* add metadata to plugin context

* get search working

* layout improvements

* fix tests

* Update superset-frontend/src/explore/components/controls/VizTypeControl/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* use typography size instead of grid unit

* comments

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* feat(explore): Examples image gallery in the viz type control (#15489)

* feat(explore): add section for example images in viz type control

* fix jpg webpack config

* formatting

* feat(Explore): Viz gallery component tweaks (#15520)

* separate viz gallery from the modal

* use gallery directly in add slice view

* more formatting on the add slice container

* restyle the thumbnail list

* explicit thumbnail width and height

* remove crappy hack

* remove useless line

* comment

* sort categories

* comments

* tweak search behavior

* fix tests

* open gallery to the currently selected viz type

* null safety

* show all plugins when searching empty string

* get the new metadatas

* adjust categories scrolling behavior

* add time series table metadata

* upgrade superset-ui

* attempt fixing tests

* upgrade descriptions

* fix unit test

* attempt fixing e2e again

* max width for viz gallery

* update package lock

* undo unnecessary webpack changes

* don't show search results until something is entered

* force modal to open to selected viz type

* tweaks to search behavior

* gallery layout tweaks

* enshrine pivot table v2 in a place of honor

* feat(viz): Clear viz gallery when navigating between categories (#15577)

* start viz gallery with null selection, clear when switching categories

* fix AddSliceContainer tests

* show a message when there is no viz type selected

* composition > inheritance

* clarify searching code

* comment

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-07-12 10:59:10 -07:00
Phillip Kelley-Dotson
2be52c0659 refactor: icon to icons for controls (#15568)
* initial commit

* Update DateFilterLabel.tsx
2021-07-08 17:32:42 -06:00
Ajay M
352656a398 Fix issue #15335 (#15339) 2021-06-24 10:09:15 +08:00
Ben Reinhart
ab153e66cc feat: Synchronously return cached charts (#15157)
* feat: Synchronously return cached charts

* Fix lint issue

* Fix python lint error

* Change getChartDataRequest to return response

* Fix lint errors

* Add test

* explore_json: skip cached data check for forced refresh

Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
2021-06-22 10:00:57 -07:00
Ville Brofeldt
cef3dc0b02 fix(native-filters): improve time range filter performance (#15295)
* fix time range default value

* defer time filter rendering to inView event

* avoid double fetching of time ranges

* lint

* move set to resolved promise
2021-06-22 14:38:16 +03:00