Commit Graph

462 Commits

Author SHA1 Message Date
Geido
a0881fb157 Add filter_box full height (#14657) 2021-05-19 00:13:16 -07:00
Evan Rusackas
c2bd684454 fix(Explore): fixes broken layout of tooltips (#14529)
* fix: moves LESS styles into Emotion, fixes broken layout of tooltips

* fix: tests

* style: linting

* style: better styling location
2021-05-18 21:55:09 -07:00
Ajay M
90378ed94e fix(explore): #10098 boolean filter not working (#14567)
* Restrict operators when column is boolean

* refactor 'isOperatorRelevant' a little bit

* Include 'BOOLEAN' to handle presto

* Update tests

* number column should show bool operators

* fix test - some dbs translate true/false to 1/0

* Fix tests and add linting

* When column type is boolean, show bool operators

* Address PR comments - simplify conditions

* Fix a linting error

* Addressing PR comment - remove unused variables
2021-05-18 14:39:19 -07:00
Ajay M
84e8dc71f6 feat(dashboard): View query of the chart in dashboard (#14667)
* Extract view query component out

* Typo correction

* Fix and rename tests

* Remove logs, and test code

* Rename file - fix tests

* Fix a typo

* Linting errors, add Apache License Header
2021-05-18 13:17:11 -07:00
Geido
7a050c59e4 fix(explore): Fix column number calculation (#14665)
* Fixes columns calc

* Fix type
2021-05-17 15:30:12 -07:00
Michael S. Molina
fd8b2cb89b fix: Fixes group by control icon colors (#14674) 2021-05-17 13:53:32 -07:00
Michael S. Molina
9deb7aa3c1 chore: Replaces Icon with Icons component - iteration 1 (#14469) 2021-05-17 10:24:56 -07:00
David Aaron Suddjian
f16c708fab fix(dashboard): check edit permissions correctly on frontend (#14626)
* fix(dashboard): check edit permissions correctly on frontend

* fix types, appease linter

* handle nulls better
2021-05-14 12:18:38 -07:00
Geido
3466cb253e Fix class name (#14609) 2021-05-14 11:05:52 -07:00
Cedric Gampert
74473e2ad1 fix: do not render favorite favStars and filters for anonymous user (#14120)
* fix: do not render favorite favStar and filter for anonymous user

* fix: prevent anonymous user to trigger the favstar view route

* fix: lint over previous commit

* fix: linter follow-up
2021-05-14 08:05:50 -07:00
Michael S. Molina
d31958cbd2 fix: Fixes #12672 (#14525) 2021-05-13 12:53:24 -07:00
Geido
1e601483e3 fix(explore): Filters Tooltip is not showing the full content (#14618)
* Add getTooltipTitle

* Fix tests
2021-05-13 10:03:22 -07:00
Ville Brofeldt
3f6bd1e4a4 feat: add generic type to column payload (#14547)
* feat: add generic type to column payload

* feat: add generic type to column payload

* xit flaky test
2021-05-13 09:36:09 +03:00
Michael S. Molina
331eb10fb9 refactor: Bootstrap to AntD - Form - iteration 4 (#14546) 2021-05-12 23:01:43 -07:00
Phillip Kelley-Dotson
3eef38f309 refactor: change xsm Icons and dnd icons to new dynamic icons (#14419)
* intial commit

* fix test and add more icons

* fix lint
2021-05-12 22:52:25 -07:00
Phillip Kelley-Dotson
5f7722cb36 fix: error icon spacing in explore (#14597)
* fix error message icon

* lint
2021-05-12 22:42:40 -07:00
Geido
3a4536acac fix: Column name and icons alignment in the Datasource Panel (Explore) (#14551)
* Fix column name alignment

* Fix space wrap
2021-05-11 10:27:46 -07:00
Geido
e21beb76f1 fix: White space between Chart and Data panel in Explore (#14495)
* Adjust white space

* Adjust chart padding
2021-05-10 13:03:43 -07:00
Michael S. Molina
79ff96269b refactor: Bootstrap to AntD - Form - iteration 3 (#14502) 2021-05-08 12:34:52 -07:00
Evan Rusackas
4f000cc8d1 fix: bringing metric type icon styles into SelectControl (#14531) 2021-05-08 15:47:25 +08:00
Ville Brofeldt
680c96ec54 feat(explore): collapse time section if no ts columns (#14493)
* feat(explore): collapse time section if no ts columns

* fix viz change bug

* fix test
2021-05-07 11:55:54 +03:00
Michael S. Molina
331310db9b refactor: Bootstrap to AntD - Form - iteration 2 (#14379) 2021-05-05 22:00:37 -07:00
Michael S. Molina
f9567efe81 fix: Fix #13831 (#14490) 2021-05-05 13:48:48 -07:00
Evan Rusackas
8ccd19629a fix: explore flex layout is sometimes too short (#14481) 2021-05-05 10:21:15 -07:00
Kamil Gabryjelski
b030c9801c chore: Move styles from .less stylesheet to emotion in Explore (#14485)
* Move some styles from .less stylesheet to emotion in Explore

* Replace Global styles with local styled components

* Address comments
2021-05-05 15:36:52 +02:00
Jesse Yang
23014e9233 chore: upgrade @emotion (#14454) 2021-05-04 15:26:16 -07:00
Duy Nguyen Hoang
9a22fb00d9 fix: CSV Export permission is not consistent (#13713) 2021-05-04 10:19:58 +03:00
Geido
545e257537 feat: Dynamic imports for the Icons component (#14318)
* Add aria-label and twotone

* Enhance LazyIcon

* Fix tests and solve ject warnings

* Add new line

* Revert package-lock to master

* Fix failing test

* Implement icon overrides

* Fix failing storybook

* Clean up

* Improve var name
2021-04-29 11:49:39 -07:00
Michael S. Molina
d0be1ff79e chore: Moves Tabs to the components folder (#14136) 2021-04-27 00:15:21 -07:00
Michael S. Molina
4fbb572568 refactor: Bootstrap to AntD - Form - iteration 1 (#14106) 2021-04-26 15:03:53 -07:00
Yongjie Zhao
67535bb320 refactor: reorganize dateFilterUtils.tx (#14309)
* refactor: reorganize dateFilterUtils.tx

* move spec to src dirctory
2021-04-23 16:05:50 +08:00
Yongjie Zhao
d1afca4fa1 fix: custom TimeRange can not input value (#14084) 2021-04-23 15:20:37 +08:00
Michael S. Molina
b963624e12 refactor: Boostrap to AntD - Row/Col (#14100) 2021-04-22 20:57:17 -07:00
Yaozong Liu
852e840575 fix(explore): CUSTOM SQL tab should automatically update (#14194)
* fix(explore): CUSTOM SQL tab should automatically update

* fix(explore): CUSTOM SQL tab should automatically update

* fix: lint

* fix(explore): default value

Co-authored-by: Yongjie Zhao <yongjiezhao@apache.org>

Co-authored-by: liuyaozong <liuyaozong@baijiahulian.com>
Co-authored-by: stephenLYZ <vueact@gmail.com>
Co-authored-by: Yongjie Zhao <yongjiezhao@apache.org>
2021-04-21 14:30:18 +08:00
Michael S. Molina
d1b458c4c5 chore: Moves Radio to the components folder (#14133) 2021-04-20 08:48:10 -07:00
Michael S. Molina
8441590812 chore: Moves Tooltip to the components folder (#14137) 2021-04-20 08:47:47 -07:00
simcha90
7e5440a359 test(native-filters): Filter config modal test (#14245)
* test: add tests for filter bar

* test: merge filter bar tests with master

* test: add test for filter set

* test: filter set tests

* test: merge with master

* test: fix tests for filter bar

* test: filter config modal

* test: add select filter

* feat: filter config modal

* lint: fix lint

* lint: fix TS

* test: test testWithId
2021-04-20 14:07:08 +03:00
Kamil Gabryjelski
6119d8e998 Fix filter edit popover not opening in DnD mode (#14243) 2021-04-20 11:45:48 +02:00
simcha90
d386e66f59 test(native-filters): add integration tests for filter bar (#14098)
* test: add tests for filter bar

* test: merge filter bar tests with master

* test: add test for filter set

* test: filter set tests

* test: merge with master

* test: fix tests for filter bar

* fix: fix CR notes

* fix: fix CR notes
2021-04-20 12:24:12 +03:00
Michael S. Molina
77a9cc7088 chore: Moves Collapse to the components folder (#14124) 2021-04-16 15:55:04 -07:00
Michael S. Molina
b83ee46d0f chore: Moves Modal to the components folder (#14130) 2021-04-16 15:49:53 -07:00
simcha90
8ef572a412 refactor(native-filters): update dataMask and ExtraFormData schema (#13983)
* refactor: updates usage of `ownFilters` to `ownState`

* refactor: update dataMask (final)

* lint: fix lint

* refactor: revert feat

* fix: fix missed chart configuration

* add filter set migration

* apply new changes

* fix migration revision

* update migration

* fix jest mock

* js lint

* fix test types

* update tests and types

* remove append_form_data from tests

* fix findExistingFilterSet tests

* add migration test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-04-15 17:43:29 +03:00
Michael S. Molina
cfe927bebb test: Adds tests for the FixedOrMetricControl component (#13705) 2021-04-13 15:26:31 -07:00
Michael S. Molina
c8a794368d refactor: Bootstrap to AntD - ListGroup (#13996)
* refactor: Bootstrap to AntD - ListGroup

* Improves theme handling on touched files
2021-04-13 15:26:02 -07:00
Michael S. Molina
92a66921e0 refactor: Bootstrap to AntD - Slider (#13989) 2021-04-12 16:28:06 -07:00
Bruno Motta
95ed8735f1 chore: well component to card component(Updating PR #12200) (#14033)
* replace Well componenet with Card component

* Fix lint errors

* Fix lint

* Addressing comments

* Addressing comments

* Fix lint errors

* Exporting Card from index.tsx and adding storybook variants

* Fix some refactoring

* Fix errors

* solving conflicts and lint errors

* Update superset-frontend/src/common/components/Card.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/Card.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Nikola Gigic <nik.gigic@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 15:06:44 -07:00
Bruno Motta
dcb9f7cff1 test: DataTablesPane (#13736)
* Tests for DataTablesPane

* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Using factory for props

* replacing "data-test"

* removing "act" from tests and fix error

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-07 11:35:27 -07:00
Bruno Motta
284402c583 test: AdhocMetricEditPopover (#13787)
* tests for AdhocMetricEditPopover

* replace "factoryProps" for "createProps"

* removing unnecessary if

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-04-07 10:34:29 -07:00
Yongjie Zhao
56dc74e09f fix: Pie chart not displayed in viz (#13987) 2021-04-07 17:08:24 +08:00
Grace Guo
4b29789b64 fix: null exception from adhoc metric popover (#13955) 2021-04-06 13:36:59 +08:00