Commit Graph

462 Commits

Author SHA1 Message Date
Ville Brofeldt
9dfa33fedf fix(dnd): make clicked dnd metrics unique (#16632) 2021-09-08 13:21:21 +03:00
Yongjie Zhao
80c39daa85 fix: can't drop column when name overlap (#16482) 2021-09-01 13:52:10 +08:00
Erik Ritter
8adc31d14c Revert "chore: Changes the DatabaseSelector to use the new Select component (#16334)" (#16478)
This reverts commit c768941f2f.
2021-08-26 22:28:04 -03:00
Jesse Yang
a413f796a6 fix(explore): JS error for creating new metrics from columns (#16477) 2021-08-26 17:04:45 -07:00
Yongjie Zhao
577ede4b12 fix: prevent page crash when chart can't render (#16464) 2021-08-26 22:26:01 +08:00
Jesse Yang
ec087507e5 refactor(explore): improve typing for Dnd controls (#16362) 2021-08-26 01:23:14 -07:00
Ville Brofeldt
18be181946 fix(explore): update overwrite button on perm change (#16437)
* fix(explore): update overwrite on perm change

* remove redundant user_id prop

* fix types

* fix user type

* fix tests

* fix lint
2021-08-26 06:24:33 +03:00
Geido
db11c3e6c8 feat: Draggable and Resizable Modal (#16394)
* Implement resizable prop

* Implement resizableConfig

* Implement fluid Syntax Highlighter

* Implement draggable

* Destroy on close

* Implement draggableConfig

* Enhance with footer calculation

* Add new line

* Make whole header draggable trigger
2021-08-25 16:11:16 +03:00
AAfghahi
631ad02a76 fix: copy to Clipboard order (#16299)
* copy to Clipboard order

* centralized copyToClipboard

* fixed table order

* fixed tests

* added colnames to all viz types

* added colnames to all viz types

* added colnames to all viz types
2021-08-24 14:47:09 -07:00
Evan Rusackas
81241b6024 Revert "fix(explore): let admin overwrite slice (#16290)" (#16408)
This reverts commit d13b081cfe.
2021-08-24 09:38:41 -06:00
Michael S. Molina
c768941f2f chore: Changes the DatabaseSelector to use the new Select component (#16334) 2021-08-23 15:41:03 -03:00
Phillip Kelley-Dotson
3faf653e5f initial commit (#16366) 2021-08-20 17:46:55 -06:00
Kamil Gabryjelski
a547dcb73e fix(explore): reordering columns with dnd sometimes glitching (#16322)
* fix(explore): reordering columns with dnd sometimes glitching

* Fix metrics and filters popover being stale after reordering
2021-08-18 18:39:05 +02:00
Kamil Gabryjelski
2c595b09ea chore(explore): make metric/column search input clearable (#16320)
* chore(explore): make metric/column search input clearable

* Fix typo

* Fix test
2021-08-18 12:23:23 +02:00
Beto Dealmeida
7a284bb9e8 fix: allow reports to update query_context (#16303) 2021-08-17 16:39:27 -07:00
Kamil Gabryjelski
203c311ca3 feat(explore): make dnd controls clickable (#16119)
* Make ghost buttons clickable

* Popover for column control

* Make column dnd ghost button clickable

* Prefill operator only if column is defined

* Remove data-tests

* lint fix

* Hide new features behind a feature flag

* Change ghost button texts

* Remove caret for non clickable columns
2021-08-17 14:56:39 +02:00
Ville Brofeldt
d13b081cfe fix(explore): let admin overwrite slice (#16290) 2021-08-17 10:55:33 +03:00
Elizabeth Thompson
3709131089 check roles before fetching reports (#16260) 2021-08-13 20:41:03 -07:00
AAfghahi
9d0dc561fc Revert "feat: Changing Dataset names (#16199)" (#16235)
This reverts commit adb3ebbba3.
2021-08-12 13:59:44 -07:00
Geido
a1e18ed110 fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel (#16060)
* Implement dynamic tooltip

* Normalize and consolidate

* Clean up

* Refactor and clean up

* Remove unnecessary var

* Fix type import

* Update superset-frontend/src/explore/components/controls/OptionControls/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Remove unnecessary styled span

* Show full tooltip title

* Force show tooltip

* Force show tooltip D&D off

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-08-12 11:48:16 -06:00
Geido
2c5731aea3 Show/hide tooltips (#16192) 2021-08-12 11:42:48 -06:00
Kamil Gabryjelski
a16e290765 fix(explore): conditional formatting value validators (#16230)
* fix(explore): conditional formatting value validators

* Fix typing, make validator more generic

* Remove commented code
2021-08-12 14:31:29 +02:00
Kamil Gabryjelski
ccfc95fbe6 fix(explore): adhoc metrics popover resets label after hovering outside (#16196)
* fix(explore): adhoc metrics popover resets label after hovering outside

* Remove irrelevant tests and skip rest

* Use ensureIsArray
2021-08-11 10:05:08 -06:00
AAfghahi
6c304b83a9 feat: Changing Dataset names (#16199)
* added google alert

* changing Dataset Names
2021-08-11 08:59:59 -07:00
Kamil Gabryjelski
98fc29cbbb fix(explore): metric label disappearing in some scenarios (#16190) 2021-08-11 14:05:44 +02:00
Junlin Chen
9841c78967 chore: switch back tag name to popular from highly-used (#16174)
* chore: switch back tag name to popular from highly-used

* new package lock

* new package lock with npm 7

* fix lint

* remove package changes

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-08-10 20:23:14 -07:00
Elizabeth Thompson
a3102488a1 feat: add chart image info to reports from charts (#16158)
* refetch reports on props update

* add chart types to reports
2021-08-10 15:11:10 -07:00
Beto Dealmeida
7b3fce7e81 fix: revert data endpoint name (#16162) 2021-08-10 11:59:27 -07:00
Phillip Kelley-Dotson
f0e3b68cc2 fix: ensure that users viewing chart does not automatically save edit data (#16077)
* add last_change_at migration

* add last_saved_by db migration

* finish rest of api migration

* run precommit

* fix name

* run precommitt

* remove unused mods

* merge migrations

* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/migrations/versions/f6196627326f_update_chart_permissions.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* fix test

* precommit

* remove print

* fix test

* change test

* test commit

* test 2

* test 3

* third time the charm

* fix put req

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-08-10 10:29:49 -06:00
Kamil Gabryjelski
6e1d16d956 feat(explore): each control can define its own canDrop for dnd (#16090)
* feat(explore): each control can define its own canDrop for dnd

* Make canDropValue optional

* Add onDropValue
2021-08-10 17:04:42 +02:00
Michael S. Molina
273ab3d257 fix: Safari is not showing scroll bars in Explore (#16089) 2021-08-10 10:41:52 -03:00
AAfghahi
606a7bf429 fix: change Alert Permissions (#16118)
* added google alert

* reworked permissions
2021-08-09 13:33:04 -07:00
Kamil Gabryjelski
b7cc89c6d4 fix(explore): dnd error when dragging metric if multi: false (#16088)
* fix(explore): dnd error when dragging metric if multi: false

* Fix error for non-dnd controls
2021-08-09 18:15:50 +02:00
Kamil Gabryjelski
6ac4f4ef2f chore(explore): change dnd placeholders (#16116)
* chore(explore): change dnd placeholders

* Fix tests and lint
2021-08-09 17:50:11 +02:00
Kamil Gabryjelski
772da8de63 fix(explore): revert dnd column dependency array change to fix infinite rerenders (#16115)
* fix(explore): revert dnd column dependency array change to fix infinite rerenders

* Remove console.log

* Remove comment
2021-08-06 17:59:22 +02:00
David Aaron Suddjian
e6292a89bb fix(explore): drag & drop column select component triggering onChange unnecessarily (#16073)
* fix(explore): avoid sync until after first render

* fix example
2021-08-05 15:38:28 -07:00
AAfghahi
e6274e0764 change button color (#16093) 2021-08-05 10:38:30 -07:00
Kamil Gabryjelski
a59d458e41 chore(explore): Create new entrypoints for Echarts Timeseries (#15942)
* feat(explore): Create new entrypoints for Echarts Timeseries

* Change order of some charts

* bump superset-ui

* also bump echarts package

* fix UT

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-08-05 07:28:16 +02:00
Ville Brofeldt
7ef97a54e2 feat(explore): add automatic conditional formatter to pivot table v2 (#16045) 2021-08-04 22:12:20 +03:00
Kamil Gabryjelski
5917407b9c fix(explore): filter popover opening after removing a filter (#16024) 2021-08-02 22:01:17 +02:00
Geido
39913d286a Implement sectionId (#16022) 2021-08-02 12:12:36 -07:00
Elizabeth Thompson
e0576786c3 add feature flag to header bar (#16031) 2021-08-02 10:57:29 -07:00
Elizabeth Thompson
5031a67597 feat: Self subscribe reports (#16027)
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2021-08-02 09:12:09 -07:00
Kamil Gabryjelski
3061b6ad09 fix(explore): fix undefined error when using dnd (#16020) 2021-08-02 15:22:32 +02:00
David Aaron Suddjian
46188c1011 fix(explore): calculate query staleness correctly (#15994) 2021-07-31 19:46:34 -06:00
Phillip Kelley-Dotson
5fd798afb7 chore: change dropdown icons from horizontal to vertical (#15958)
* change icons

* add size

* fix storybook

* fix favstar, add new icons, and others

* fix lint
2021-07-30 17:02:40 -06:00
Geido
c2e4290392 fix(dashboard): Add required message in the tooltip for the time range filter (#15941)
* Add required msg in tooltip

* Fix lint

* Keep red border on hover
2021-07-30 09:44:33 +02:00
Yongjie Zhao
11b0249803 fix: remove unused time column when update dataset (#14969)
* fix: remove unused time column when update dataset

* fix lint

* set dttm to first datatime column
2021-07-28 21:40:16 +08:00
David Aaron Suddjian
a3f54a6c7b chore: small viz gallery tweaks (#15900)
* allow passing styles to selector component

* make onClear optional

* remove broken font-size declarations

* fix bad hook dependency

* move all charts selector outside of Collapse

* stop hiding all charts button

* slight copy change

* remove x

* min left pane size

* remove default p bottom margin

* remove unused import

* fix test
2021-07-27 18:21:19 -07:00
Beto Dealmeida
2ce676d20d feat: call screenshot to store query_context (#15846)
* feat: call screenshot to store query_context

* Add unit test

* Move updateQueryContext to ExploreChartPanel

* Add error handling

* Fix code

* Fix logic
2021-07-27 14:02:27 -07:00