Enzo Martellucci
f846e106b8
fix(database): tighten validate_parameters SSH and bypass-engine paths
...
Three correctness fixes to ValidateDatabaseParametersCommand:
1. Bypass engines (bigquery, datastore, snowflake) now also surface
database_name uniqueness errors and SSH tunnel field errors during
progressive validation, instead of silently passing.
2. The SSH feature-flag and database-port guards now fire when the UI
marks parameters.ssh, not just when the ssh_tunnel payload is
non-empty — the form sends an empty tunnel object in early stages.
3. The "parameters are missing" message for SSH tunnel fields now
interpolates the %(missing)s placeholder via gettext, so the
response surfaces the actual missing fields instead of the literal
token.
Adds unit tests for each branch and removes the now-unused
_validate_database_name helper.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com >
2026-05-06 12:32:35 +02:00
Enzo Martellucci
86b3d8922c
test(database): cover new validate command branches
...
Adds unit tests for the duplicate-database-name check (create + update
paths, plus the bypass-engine path), the SSH tunnel feature-flag and
db-port guards, and the SSH tunnel field-level error collection
(missing required fields, missing credentials, private key without
password). Brings patch coverage on commands/database/validate.py up
from ~44%.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com >
2026-05-06 11:21:53 +02:00
Beto Dealmeida
84f7b4a973
fix: do_ping takes a connection, not engine ( #39013 )
2026-04-15 11:10:24 -04:00
Alexandru Soare
5c782397bb
refactor(passwords): accept passwords via YAML file ( #38059 )
...
Co-authored-by: Mehmet Salih Yavuz <salih.yavuz@proton.me >
2026-03-27 14:37:34 +02:00
Felipe López
cedc35e39f
fix(SQLLab): remove error icon displayed when writing Jinja SQL even when the script is correct ( #36422 )
2026-01-06 16:58:40 +03:00
Beto Dealmeida
c458f99dd4
chore: cleanup ssh tunnel ( #34388 )
2025-12-03 14:26:35 -05:00
Gabriel Torres Ruiz
9d06a5888f
fix(csv-upload): log detailed errors during chunk concatenation for debugging ( #36108 )
2025-11-17 12:05:12 -08:00
Luiz Otavio
17ebbdd966
fix(csv upload): Correctly casting to string numbers with floating points (e+) ( #35586 )
2025-10-10 11:01:03 -07:00
Luiz Otavio
1c2b9db4f0
fix: Upload CSV as Dataset ( #34763 )
2025-09-08 11:48:23 -03:00
Beto Dealmeida
cb24737825
feat(bigquery): show materialized views ( #34766 )
2025-08-26 11:21:43 -04:00
Beto Dealmeida
a82e310600
feat: improve perf of CSV uploads ( #34603 )
2025-08-20 08:53:02 -04:00
Maxime Beauchemin
3f8472ca7b
chore: move some rules from ruff -> pylint ( #34292 )
2025-07-24 09:40:49 -07:00
Vitor Avila
a56d7252c2
fix: Consider default catalog when getting tables and view lists ( #33916 )
2025-06-26 13:55:10 -03:00
Beto Dealmeida
141d0252f2
fix: mask password on DB import ( #33267 )
2025-04-29 10:27:03 -04:00
Vitor Avila
de84a534ac
fix(DB update): Gracefully handle querry error during DB update ( #33250 )
2025-04-25 15:38:59 -03:00
Vitor Avila
a5a91d5e48
fix(OAuth2): Update connection should not fail if connection is missing OAuth2 token ( #33100 )
2025-04-14 11:19:55 -03:00
Beto Dealmeida
d88cba92c0
feat: optimize catalog permission sync ( #33000 )
2025-04-10 17:38:34 -07:00
Beto Dealmeida
68a81c3989
fix: update dataset/query catalog on DB changes ( #32829 )
2025-03-26 08:56:02 -04:00
Vitor Avila
e8ad096173
fix(sync perms): Avoid UnboundLocalError during perm sync for DBs that don't support catalogs ( #32658 )
2025-03-13 21:07:49 -03:00
Beto Dealmeida
8695239372
feat: OAuth2StoreTokenCommand ( #32546 )
2025-03-13 09:45:24 -04:00
Beto Dealmeida
5af4e61aff
feat: improve GSheets OAuth2 ( #32048 )
2025-03-03 12:55:54 -05:00
Vitor Avila
d79f7b28c2
feat: Update database permissions in async mode ( #32231 )
2025-02-28 21:25:47 -03:00
Beto Dealmeida
00883c395c
feat: allow importing encrypted_extra ( #32339 )
2025-02-24 19:29:04 -05:00
Evan Rusackas
90651dfe3e
fix(dev/ci): pre-commit fixes galore ( #32352 )
2025-02-24 11:26:45 -07:00
Vitor Avila
5fc11fb706
chore: Add more database-related tests (follow up to #31948 ) ( #32054 )
2025-01-31 08:36:09 -03:00
Vitor Avila
8050e351ed
fix(OAuth): Remove masked_encrypted_extra from DB update properties ( #31834 )
2025-01-14 11:45:21 -03:00
Vitor Avila
41ed37ab02
fix(oauth): Handle updates to the OAuth config ( #31777 )
2025-01-10 15:54:53 -03:00
Maxime Beauchemin
e51b95ffa8
chore: enforce more ruff rules ( #31447 )
...
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
2024-12-18 17:41:34 -08:00
Beto Dealmeida
68499a1199
feat: purge OAuth2 tokens when DB changes ( #31164 )
2024-11-26 15:57:01 -05:00
Beto Dealmeida
0415ed34ce
feat: allow create/update OAuth2 DB ( #30071 )
2024-09-03 19:22:38 -04:00
Beto Dealmeida
61c0970968
fix: create permissions on DB import ( #29802 )
2024-08-06 12:09:21 -04:00
John Bodley
8fb8199a55
chore(dao/command): Add transaction decorator to try to enforce "unit of work" ( #24969 )
2024-06-28 12:33:56 -07:00
Beto Dealmeida
e90246fd1f
feat(SIP-95): permissions for catalogs ( #28317 )
2024-05-06 11:41:58 -04:00
Daniel Vaz Gaspar
9a339f08a7
feat: new Columnar upload form and API ( #28192 )
2024-05-06 15:51:42 +01:00
Daniel Vaz Gaspar
de82d90b9c
chore: refactor file upload commands ( #28164 )
2024-04-23 08:42:19 +01:00
