Commit Graph

11786 Commits

Author SHA1 Message Date
Stephen Liu
aa4068048a fix(docs): prevent some symbols from being copied with (#20480) 2022-06-23 13:11:42 -04:00
stevetracvc
a45d011e74 fix: issue with sorting by multiple columns in a table (#19920)
Recent commit to sort alphanumeric columns via case insensitive
comparison broke the multi-column sort option. React-table only sorts
by the second (or third...) column if the first column matches.
Since the alphanumeric sort only returned -1 or 1, it never would move
to the subsequent columns when the earlier column values matched.
2022-06-23 08:39:46 -03:00
John Bodley
f5cb23e0a3 fix(migration): Ensure key_value LargeBinary is encoded as a MEDIUMBLOB as opposed to BLOB for MySQL (#20385)
* fix(migration): Ensure key_value LargeBinary is encoded as a MEDIUMBLOB as opposed to BLOB for MySQL

* Update 2022-06-14_15-28_e09b4ae78457_resize_key_value_blob.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-23 08:38:33 -03:00
Diego Medina
4dc30441b7 fix: alert & reports active toggle optimistic update (#20402) 2022-06-23 08:33:54 -03:00
Michael S. Molina
a169b60712 fix: Changes the return type of get_permissions to be JSON friendly (#20472)
* fix: Changes the return type of get_permissions to be JSON friendly

* Removes dangling comma

* Removes unused import

* Fixes typing errors
2022-06-22 15:28:59 -06:00
AAfghahi
2c16be42e1 async queries limit bug (#20468) 2022-06-22 16:21:34 -04:00
Eric Briscoe
9f9aae49c9 chore: Convert QueryAutoRefresh to TypeScript functional React component [sc-48362] (#20179)
* git commit -m 'Convert QueryAutoRefresh to functional component [sc-48362]'

* addressing PR comments [sc-48362]

Removes unneeded props and state tracking of offline, adds finally block to simplify clearing pending request, simplifies value comparison in array by using includes in place of indexOf

* Address PR comment to use enum for QueryState [sc-48362]

Original implementation had string literals used in multiple places representing Query.state value options.  This commit creates a formal TypeScript enum for QueryState so we can remove string literals and ensure better consistency

* Address PR comments for object type validation [sc-48362]

This commit resolves an issue why the TypeScript typing for queryList was marked as a Query[] but was actually a Dictionary (associative array) or Queries.  A new type QueryDictionary has been added and the QueryAutoRefresh code was adjusted to use QueryDictionary instead of Query[] in appropriate places as well as unit tests.  Commit also removes QueryAutoRefreshContainer by making the once component using QueryAutoRefresh (which is already redux connected) pass the needed values on props.  this simplifies the code base and reduce files that need unit testing while keeping QueryAutoRefresh out of needing a redux connection directly.

* Addresses PR comment to add QueryState.SCHEDULED to runningQueryStateList [sc-48362]

In previous implementation 'scheduled' was not included int he list of Query States.  Further investigation shows it should be added to as a running state.

* Fix prettier lint error [sc-48362]

* Adjust unit tests for props update hoisting callbacks out of actions wrapper object [sc-48362]

* Update with changes from master [sc-48362]

Merges in updates from master and resolves conflicts from relocation of some of the Query TypeScript definitions into core

* Removes logic setting user offline and relying on results panel error message [sc-48362]

* Fixes bad import after some TypeScript definitions were relocated to core [sc-48362]

* Fixes TypeScript errors [sc-48362]
2022-06-22 13:20:02 -07:00
cccs-Dustin
daded10992 feat(SQL Lab): Make SQL Lab explore use the default viz from the config file (#20056)
* Modified SQL Lab so it uses the default viz to explore a new dataset with

* Added a comment to the config file

* Remove trailing whitespace

* [CLDN-1312] Removed the 'viz_type' variable so that when it is undefinded in the back-end, it gets set to the default viz

* [CLDN-1312] Only sets the 'all_columns' variable if the default viz type is a 'table'

* Will only pop 'selectedColumns' out of 'form_data' if it is present

* [CLDN-1312] Updated files so that the default viz is now being used again in SQL Lab Explore
2022-06-22 11:33:44 -06:00
Elizabeth Thompson
b66a617ed9 remove label for new user (#20429) 2022-06-22 10:21:53 -07:00
Kyuhyun Byun(Bien)
cf4f05efbc docs(featureflags): add GENERIC_CHART_AXES flag (#20446)
* doc(featureflags): add GENERIC_CHART_AXES flag

* move GENERIC_CHART_AXES into testing stage
2022-06-22 09:14:24 -04:00
smileydev
a833674a8d fix(home): Show home page tabs as pills instead of links (#20257)
* fix(home): make to update the css style of links

* fix(home): make to fix lint issue

* fix(home): make to remove underline when tab is active

* fix(homes): make to fix the issue of tab

* fix(home): make to move styles to a tag
2022-06-21 17:44:48 -06:00
Michael S. Molina
ca526e63c8 feat: Adds support for clearing the Select cache (#20397)
* feat: Adds support for clearing the Select cache

* Fixes lint errors
2022-06-21 15:13:37 -03:00
Cody Leff
44c5e2879b chore(newchart): update chart creation dataset selection help text, styles (#20369)
* Update dataset selection help text.

* Update 'Create a new chart' flow styles.

* Add support for linking directly to Create Dataset modal via URL hash.

* Add support for linking directly to Create Dataset modal via URL hash.

* Update dataset help text to not include spaces in translated strings and only include an 'Add dataset' link when user has permission to add dataset.

* Clean up test file

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-06-21 14:01:43 -03:00
Beto Dealmeida
f3b289d3c3 fix: ensure column name in description is string (#20340)
* fix: ensure column name in description is string

* Add unit test
2022-06-21 10:10:46 -03:00
Diego Medina
5afeba34bd fix(viz): BigQuery time grain 'minute'/'second' throws an error (#20350) 2022-06-21 10:06:52 -03:00
smileydev
1ae935379f fix(chart & table): make to prevent dates from wrapping (#20384) 2022-06-21 09:58:50 -03:00
Yongjie Zhao
9fad26fa19 fix: suppress translation warning in jest (#20404) 2022-06-21 20:38:58 +08:00
Yongjie Zhao
8bbbd6f03f fix: should raise exception when apply a categorical axis (#20451) 2022-06-21 20:37:51 +08:00
Diego Medina
93774d1860 fix: table viz sort icon bottom aligned (#20447) 2022-06-21 09:10:37 -03:00
Daniel Vaz Gaspar
ba4ba0267e fix: RLS new db migration downgrade fails on SQLite (#20449) 2022-06-21 13:07:23 +01:00
Hugh A. Miles II
e3e37cb68f chore: switching out ConnectorRegistry references for DatasourceDAO (#20380)
* rename and move dao file

* Update dao.py

* add cachekey

* Update __init__.py

* change reference in query context test

* add utils ref

* more ref changes

* add helpers

* add todo in dashboard.py

* add cachekey

* circular import error in dar.py

* push rest of refs

* fix linting

* fix more linting

* update enum

* remove references for connector registry

* big reafctor

* take value

* fix

* test to see if removing value works

* delete connectregistry

* address concerns

* address comments

* fix merge conflicts

* address concern II

* address concern II

* fix test

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
2022-06-21 13:22:39 +02:00
Yongjie Zhao
c79b0d62d0 refactor: create echarts query section (#20445) 2022-06-21 11:38:07 +08:00
Samira El Aabidi
68af5980ea feat(chart): Enable caching per user when user impersonation is enabled (#20114)
* add username to extra cache keys when impersonation is enabled.

* don't put effective_user in extra_cache_key

* get_impersonation_key method in engine_spec class  to construct an impersonation key

* pass datasource when creating query objects

* adding an impersonation key when construction cache key

* add feature flag to control caching per user

* revert changes

* make precommit and pylint happy

* pass a User instance

* remove unnecessary import
2022-06-20 18:14:08 -07:00
Sam Firke
b7eb235440 style(typo): occured -> occurred (#20116)
* Occured -> Occurred

* Occured -> Occurred

* Occured -> Occurred

* Occured - > Occurred

* Update FallbackComponent.tsx

* Update FallbackComponent.tsx

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
2022-06-20 08:49:45 -07:00
Yongjie Zhao
111affdb02 chore: move xaxis to superset-ui (#20438) 2022-06-20 22:36:27 +08:00
Daniel Vaz Gaspar
60eb1094a4 feat: add name, description and non null tables to RLS (#20432)
* feat: add name, description and non null tables to RLS

* add validation

* add and fix tests

* fix sqlite migration

* improve default value for name
2022-06-20 13:52:05 +01:00
John Bodley
8b0bee5e8b [fbprophet] Fix frequencies (#20326) 2022-06-19 21:53:09 -07:00
Simon Thelin
8b7262fa90 fix(20428): Address-Presto/Trino-Poll-Issue-Refactor (#20434)
* fix(20428)-Address-Presto/Trino-Poll-Issue-Refacto
r

Update linter

* Update to only use BaseEngineSpec handle_cursor

* Fix CI

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
2022-06-19 16:28:59 -07:00
Diego Medina
c2f01a676c fix(dashboard): new created chart did not have high lighted effect when using the permalink of chart share in dashboard (#20411) 2022-06-19 08:17:06 -06:00
Lily Kuang
ab9f72f1a1 fix(embedded): CSV download for chart (#20261)
* move postForm to superset client

* lint

* fix lint

* fix type

* update tests

* add tests

* add test for form submit

* add test for request form

* lint

* fix test

* fix tests

* more tests

* more tests

* test

* lint

* more test for postForm

* lint

* Update superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* update tests

* remove useless test

* make test cover happy

* make test cover happy

* make test cover happy

* make codecov happy

* make codecov happy

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2022-06-17 20:01:08 -07:00
Lily Kuang
f53018c7c5 feat(embedded): enforce allow domains (#20251)
* feat(embedded): enforce allow domains

* check referrer in view

* remove frontend check
2022-06-17 12:57:51 -07:00
Cody Leff
9f74fb7a84 Skip flaky Cypress test. (#20417) 2022-06-17 10:24:58 -06:00
Neeraj-2307
a807290e3d docs: Added details to Druid connection string (#20264)
* Added details to Druid connection string 

While linking Superset to Druid the correct connection string is very important however in the docs it is not well explained , so I added a little description to it

* Update druid.mdx
2022-06-17 10:55:41 -04:00
jiAng
f6f93aad37 fix(cosmetic): cannot find m-r-10 class in superset.less (#20276)
* fix(cosmetic): cannot find m-r-10 class in superset.less

* fix: remove .m-r-10 class and use emotion instead

* Update superset-frontend/src/components/Datasource/CollectionTable.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Datasource/DatasourceEditor.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-06-17 08:54:27 -03:00
Stephen Liu
fa7f144a68 fix: rm eslint-plugin-translation-vars engine requirement (#20420) 2022-06-17 14:29:57 +08:00
Stephen Liu
b32288fddf fix(bar-chart-v2): remove marker from bar chart V2 (#20409) 2022-06-17 10:52:26 +08:00
mohittt8
41bbf62e58 fix(presto): use correct timespec for presto (#20333) 2022-06-16 16:43:17 -07:00
Beto Dealmeida
998624b1a5 feat: allow setting db UUID (#20412)
* WIP

* feat: allow passing UUID when creating a DB

* Test

* Fix field
2022-06-16 15:53:59 -07:00
Elizabeth Thompson
12436e47c9 fix key error on permalink fetch for old permalinks (#20414) 2022-06-16 15:51:17 -07:00
Cody Leff
fadf0ec5ad Update documentation on updating documentation. (#20400) 2022-06-16 15:05:37 -06:00
Smart-Codi
a8a6b732e9 adding extra metrics after chart configuration (#20410) 2022-06-16 12:55:14 -06:00
Cody Leff
467d8ef89e docs: add Matomo tracking to docs (#20398)
* Apply Prettier formatting.

* Add Matomo script to Docusaurus config.

* Add Apache license to Matomo script.
2022-06-16 10:18:59 -06:00
chuancy
11d94ce56c Chinese translation and English translation do not match (#20405) 2022-06-16 11:27:53 -03:00
Kamil Gabryjelski
c959d92dd1 feat(plugin-chart-echarts): Support stacking negative and positive values (#20408) 2022-06-16 13:58:58 +02:00
Stephen Liu
1665403484 fix(plugin-chart-pivot-table): color weight of Conditional formatting metrics not work (#20396)
* fix(plugin-chart-pivot-table): color weight of Conditional formatting metrics not work

* fix: test
2022-06-16 12:22:09 +08:00
Elizabeth Thompson
ccba5b2f69 chore: add action to welcome new users (#20401)
* add action to welcome new users

* fix typo
2022-06-15 16:27:55 -07:00
Reese
498987a1a0 Prevent dataset edit modal closing on click-away in edit mode (#20278) 2022-06-15 14:28:13 -06:00
Atticus White
1882c6d5cc Remove cache warming documentation (#20269)
The cache warming strategies perform unauthorized `GET` requests that are redirected to the login page #9597
2022-06-15 12:38:30 -07:00
Michael S. Molina
d6f9fb5af1 chore: Removes unused vars (#20194)
* chore: Removes unused vars

* Fixes lint

* Disables no-unused-vars for the operators
2022-06-15 11:01:45 -03:00
Yongjie Zhao
0a50a9b380 feat: setting limit value when Pie chart switches (#20392) 2022-06-15 21:49:00 +08:00