Commit Graph

60 Commits

Author SHA1 Message Date
Stephen Liu
ad72ea53a1 fix(legacy-plugin-chart-sunburst): chart broken when secondary metric is remove (#20223) 2022-05-31 21:18:49 +08:00
Diego Medina
7b5ba39029 fix: Fix auto-reversion of label/title in the Metrics popover (#19889) 2022-05-05 22:30:33 -06:00
Daniel Vaz Gaspar
4fdf230a56 feat: deprecate /superset/extra_table_metadata migrate to api v1 (#19921)
* feat: deprecate /superset/extra_table_metadata migrate to api v1

* use can_read to table_extra_metadata

* troubleshoot sqlite

* fix test

* fix test

* fix test

* fix frontend test on sqllab
2022-05-04 14:55:52 +01:00
Diego Medina
e4fca89217 fix: Cannot re-order metrics by drag and drop (#19876)
* fix: cannot-re-order-metrics-by-drag-and-drop

* add tests
2022-04-27 20:37:12 -06:00
Kamil Gabryjelski
b7759e6fd1 chore: Clean redundant dependency from useMemo dep array (#19732) 2022-04-15 14:56:34 +02:00
smileydev
c320c295dc fix(dnd&column): make to fix the blank state issue when only one column select (#19651) 2022-04-15 13:43:25 +02:00
Diego Medina
54f1b35161 chore: add missing keys to components inside lists (#19161) 2022-03-21 15:47:48 -06:00
Diego Medina
0277ebc225 fix: Popovers in Explore not attached to the fields they are triggered by (#19139)
* fix: Popovers in Explore not attached to the fields they are triggered by

* fix

* PR comment

* remove unused import
2022-03-16 20:46:52 -06:00
Kamil Gabryjelski
f9c7405e0e chore(explore): Set Drag&Drop feature flags to True by default (#19046)
* chore(explore): Set Drag&Drop feature flags to True by default

* fix tests
2022-03-08 18:50:51 +01:00
Michael S. Molina
fd4bd1edbc chore: Moves components out of the commons folder (#18931)
* refactor: Moves components out of the commons folder

* Fixes tests
2022-02-25 10:17:32 -03:00
Kamil Gabryjelski
c1205b5279 feat(explore): Implement metrics and columns popovers empty states (#18681)
* feat(explore): Implement empty states for column and metrics popovers

* Fix test

* Change copy
2022-02-14 15:26:56 +01:00
Yongjie Zhao
aa21a963a6 feat: smart tooltip in datasourcepanel (#18080) 2022-02-07 22:48:23 +08:00
Kamil Gabryjelski
6cad7b1d05 chore(explore): make adhoc columns available without UX BETA ff (#17921)
* chore(explore): make adhoc columns available without UX BETA ff

* Remove redundant imports
2022-02-04 14:01:16 +01:00
Michael S. Molina
53d8d383cc chore: Moves the hooks folder to the src folder (#17896) 2022-01-07 09:25:06 -03:00
Kamil Gabryjelski
7353a2bd75 fix(explore): Metric control breaks when saved metric deleted from dataset (#17503) 2021-11-24 13:06:11 +01:00
Yongjie Zhao
9070b6b19c refactor(monorepo): stage 1 (#17427)
* skip geojson in pre-commit

update prettier

* update package.json

update package.json

u package

pkg

pkg2

* lint main repo 2

lint main repo

lint

* lintrc

lintrc 2

lintrc2

lintrc 3

lintrc

* fix import

* refresh lock file

* fix break line make @ts-ignore invalid

* update rat-excludes

rat-excludes

update rat-excludes

* update eslintrc.js

* lint lint lint
2021-11-17 15:31:36 +08:00
Ville Brofeldt
e2a429b0c8 feat(explore): adhoc column expressions [ID-3] (#17379)
* add support for adhoc columns to api and sqla model

* fix some types

* fix duplicates in column names

* fix more lint

* fix schema and dedup

* clean up some logic

* first pass at fixing viz.py

* Add frontend support for adhoc columns

* Add title edit

* Fix showing custom title

* Use column name as default value in sql editor

* fix: Adds a loading message when needed in the Select component (#16531)

* fix(tests): make parquet select deterministic with order by (#16570)

* bump emotion to help with cache clobbering (#16559)

* fix: Support Jinja template functions in global async queries (#16412)

* Support Jinja template functions in async queries

* Pylint

* Add tests for async tasks

* Remove redundant has_request_context check

* fix: impersonate user label/tooltip (#16573)

* docs: update for small typos (#16568)

* feat: Add Aurora Data API engine spec (#16535)

* feat: Add Aurora Data API engine spec

* Fix lint

* refactor: sql_json view endpoint: encapsulate ctas parameters (#16548)

* refactor sql_json view endpoint: encapsulate ctas parameters

* fix failed tests

* fix failed tests and ci issues

* refactor sql_json view endpoint: separate concern into ad hod method (#16595)

* feat: Experimental cross-filter plugins (#16594)

* fix:fix get permission function

* feat: add cross filter chart in charts gallery under FF

* chore(deps): bump superset-ui to 0.18.2 (#16601)

* update type guard references

* fix imports

* update series_columns schema

* Add changes that got lost in rebase

* Use current columns name or expression as sql editor init value

* add integration test and do minor fixes

* Bump superset-ui

* fix linting issue

* bump superset-ui to 0.18.22

* resolve merge conflict

* lint

* fix select filter infinite loop

* bump superset-ui to 0.18.23

* Fix auto setting column popover title

* Enable adhoc columns only if UX_BETA enabled

* put back removed test

* Move popover height and width to constants

* Refactor big ternary expression

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: joeADSP <75027008+joeADSP@users.noreply.github.com>
Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com>
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
2021-11-15 12:50:08 +02:00
John Bodley
561d1ac9f2 feat(metrics): Provide override for disabling ad-hoc metrics (#17202)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-08 10:31:43 -08:00
Kamil Gabryjelski
fa44325a36 fix(explore): Metrics disappearing after removing metric from dataset (#17201)
* fix(explore): Metrics disappearing after removing metric from dataset

* fix test

* Apply fix to non-dnd controls

* Make adhoc metrics pick up changes from dataset columns

* Remove console log

* Fix bug in nondnd controls
2021-10-29 16:15:19 +02:00
Geido
e40ff3ada6 chore: Select component refactoring - DndColumnSelectControl - Iteration 5 (#16440)
* Refactor Select

* Update ariaLabel

* Reconcile with latest Select changes

* Fix lint

* Enhance labels
2021-09-27 17:27:14 +03:00
Ville Brofeldt
f703c12ae8 chore: bump superset-ui to 0.18.8 (#16850) 2021-09-27 11:54:05 +03:00
Ville Brofeldt
1d890f8913 fix(explore): make clicked dnd filters unique (#16700) 2021-09-14 18:01:21 +03:00
Ville Brofeldt
9dfa33fedf fix(dnd): make clicked dnd metrics unique (#16632) 2021-09-08 13:21:21 +03:00
Yongjie Zhao
80c39daa85 fix: can't drop column when name overlap (#16482) 2021-09-01 13:52:10 +08:00
Jesse Yang
a413f796a6 fix(explore): JS error for creating new metrics from columns (#16477) 2021-08-26 17:04:45 -07:00
Jesse Yang
ec087507e5 refactor(explore): improve typing for Dnd controls (#16362) 2021-08-26 01:23:14 -07:00
Kamil Gabryjelski
a547dcb73e fix(explore): reordering columns with dnd sometimes glitching (#16322)
* fix(explore): reordering columns with dnd sometimes glitching

* Fix metrics and filters popover being stale after reordering
2021-08-18 18:39:05 +02:00
Kamil Gabryjelski
203c311ca3 feat(explore): make dnd controls clickable (#16119)
* Make ghost buttons clickable

* Popover for column control

* Make column dnd ghost button clickable

* Prefill operator only if column is defined

* Remove data-tests

* lint fix

* Hide new features behind a feature flag

* Change ghost button texts

* Remove caret for non clickable columns
2021-08-17 14:56:39 +02:00
Geido
a1e18ed110 fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel (#16060)
* Implement dynamic tooltip

* Normalize and consolidate

* Clean up

* Refactor and clean up

* Remove unnecessary var

* Fix type import

* Update superset-frontend/src/explore/components/controls/OptionControls/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Remove unnecessary styled span

* Show full tooltip title

* Force show tooltip

* Force show tooltip D&D off

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-08-12 11:48:16 -06:00
Kamil Gabryjelski
98fc29cbbb fix(explore): metric label disappearing in some scenarios (#16190) 2021-08-11 14:05:44 +02:00
Kamil Gabryjelski
6e1d16d956 feat(explore): each control can define its own canDrop for dnd (#16090)
* feat(explore): each control can define its own canDrop for dnd

* Make canDropValue optional

* Add onDropValue
2021-08-10 17:04:42 +02:00
Kamil Gabryjelski
b7cc89c6d4 fix(explore): dnd error when dragging metric if multi: false (#16088)
* fix(explore): dnd error when dragging metric if multi: false

* Fix error for non-dnd controls
2021-08-09 18:15:50 +02:00
Kamil Gabryjelski
6ac4f4ef2f chore(explore): change dnd placeholders (#16116)
* chore(explore): change dnd placeholders

* Fix tests and lint
2021-08-09 17:50:11 +02:00
Kamil Gabryjelski
772da8de63 fix(explore): revert dnd column dependency array change to fix infinite rerenders (#16115)
* fix(explore): revert dnd column dependency array change to fix infinite rerenders

* Remove console.log

* Remove comment
2021-08-06 17:59:22 +02:00
David Aaron Suddjian
e6292a89bb fix(explore): drag & drop column select component triggering onChange unnecessarily (#16073)
* fix(explore): avoid sync until after first render

* fix example
2021-08-05 15:38:28 -07:00
Kamil Gabryjelski
5917407b9c fix(explore): filter popover opening after removing a filter (#16024) 2021-08-02 22:01:17 +02:00
Kamil Gabryjelski
3061b6ad09 fix(explore): fix undefined error when using dnd (#16020) 2021-08-02 15:22:32 +02:00
Kamil Gabryjelski
3f5237a3c1 feat(explore): new datasets have autocomplete filters enabled if UX_BETA is set (#15864)
* feat(explore): new datasets have autocomplete filters enabled if UX_BETA is set

* Lint fix

* Set autocomplete to True in example datasets

* Use "IN" as a default operator in dnd filters

* Default operator only if UX_BETA enabled
2021-07-27 17:40:10 +02:00
Kamil Gabryjelski
5e1c469f42 feat(explore): default aggregate for string/numeric columns when creating metric (#15798)
* feat(explore): default aggregate for string/numeric columns when creating metric

* Fix for editing items with the same label

* Replace componentDidUpdate with getDerivedStateFromProps

* Wrap changes in feature flag
2021-07-22 18:23:10 +02:00
Kamil Gabryjelski
239336c3e8 fix(explore): dnd multiple columns doesn't work (#15781) 2021-07-19 20:18:10 +02:00
Kamil Gabryjelski
4234031cba feat(explore): UX improvements for drag'n'dropping time column (#15740) 2021-07-19 01:52:34 +08:00
Kamil Gabryjelski
66c28d653f fix(explore): DndColumnSelect sometimes not working with multi: false (#15731)
* fix(explore): DndColumnSelect not working with multi: false

* fix values not synchronized when dataset changes
2021-07-16 14:20:13 +02:00
Ajay M
f8b270d419 fix(explore): Explore page boolean filter is broken for Presto DB (#14952)
* Front end update - modify OPERATORS, to have SQL operation and display value

* Updated tests

* More tests

* Remove OPERATOR imports

* Fix break tests

* PR comments

* fix issue with comparator loading

* rename a variable

* Linting
2021-06-10 09:08:04 -07:00
Ville Brofeldt
65714cc201 fix(dnd): add isExtra prop to Option (#15080) 2021-06-10 12:13:20 +03:00
Kamil Gabryjelski
d03c608ce1 fix(explore): DndColumnSelect not handling controls with "multi: false" (#14737)
* fix(explore): DndColumnSelect not handling controls with multi={false}

* Implement translations for singular and plural cases

* Fix test
2021-05-24 09:53:46 +02:00
Michael S. Molina
fd8b2cb89b fix: Fixes group by control icon colors (#14674) 2021-05-17 13:53:32 -07:00
Michael S. Molina
9deb7aa3c1 chore: Replaces Icon with Icons component - iteration 1 (#14469) 2021-05-17 10:24:56 -07:00
David Aaron Suddjian
f16c708fab fix(dashboard): check edit permissions correctly on frontend (#14626)
* fix(dashboard): check edit permissions correctly on frontend

* fix types, appease linter

* handle nulls better
2021-05-14 12:18:38 -07:00
Ville Brofeldt
3f6bd1e4a4 feat: add generic type to column payload (#14547)
* feat: add generic type to column payload

* feat: add generic type to column payload

* xit flaky test
2021-05-13 09:36:09 +03:00
Phillip Kelley-Dotson
3eef38f309 refactor: change xsm Icons and dnd icons to new dynamic icons (#14419)
* intial commit

* fix test and add more icons

* fix lint
2021-05-12 22:52:25 -07:00