Evan Rusackas
aebca03533
fix(types): add chartRenderingSucceeded to Actions type
...
Add missing chartRenderingSucceeded method to Actions type in Chart.tsx
to match the ChartActions interface expected by ChartRenderer.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-01 13:07:37 +01:00
Evan Rusackas
c2c50a2afc
fix(types): resolve TypeScript errors in Chart and chartActions tests
...
- Use ChartSource enum instead of string literals in Chart.tsx
- Add proper type casting for mock return types in chartActions.test.ts
- Add missing third argument (undefined) to ThunkAction calls
- Use AnnotationType/SourceType/Style enums instead of string literals
- Add `as unknown as` casting where mock types don't match actual types
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-01 13:07:37 +01:00
Evan Rusackas
b0b45cca04
fix(tests): add type casting for mock return types in chartActions tests
...
Add `as unknown as` casting to mock implementations to satisfy TypeScript's
strict type checking while preserving the original test behavior.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-01 13:07:37 +01:00
Evan Rusackas
5048433eab
fix(types): widen onCellChange id parameter to string | number
...
Collection item IDs can be either string or number.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-01 13:07:36 +01:00
Evan Rusackas
eca23a1277
fix: address code review feedback
...
- Add safety check for empty json.result array in chartAction.ts
- Fix grammar: "active" -> "activate" in ReportModal error message
- Fix error message to be generic: remove "attached to this dashboard"
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-01 13:07:36 +01:00
Evan Rusackas
0afbc3ea3d
fix(types): address code review feedback
...
- Add default value `inline = false` for Field component
- Fix onCellChange type from `boolean` to `unknown` in CollectionTable
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-01 13:07:36 +01:00
Evan Rusackas
8ccf4dfb75
fix(types): add type safety to DatasourceEditor and related components
...
- Add proper type definitions for DatabaseState and QueryResult interfaces
- Fix SpatialControl value type to use proper SpatialType union
- Fix DatabaseSelector and TableSelector db prop types
- Add proper type casts for itemRenderers in CollectionTable
- Remove non-existent props (controlId, canEdit, dbId, inline)
- Add missing sortColumns prop to CollectionTable
- Fix ResultTable props with proper defaults
- Add setCachedChanges to exploreUtils buildV1ChartDataPayload
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-01 13:07:36 +01:00
Evan Rusackas
9c3759a65d
fix(types): address code review feedback for TypeScript migrations
...
- Fix filterField type mismatch in ReportModal reducer - map 'dashboard_id'/'chart_id' to 'dashboard'/'chart' properties
- Fix chartAction.ts type errors: properly type getExploreUrl params, handle null URLs, fix waitForAsyncData types
- Fix SliceUpdatedAction owners type mismatch - handle both number[] and {value, label}[] formats
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-01 13:07:36 +01:00
Evan Rusackas
c6da8acbc7
fix: resolve remaining TypeScript errors and code review feedback
...
- actions.ts: add error handling to editReport, guard against empty charts
- chartAction.ts: fix RootState type, cast SupersetClient calls, add AnnotationLayerWithOverrides type
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-01 13:07:36 +01:00
Evan Rusackas
0a3babf41a
fix: resolve TypeScript errors in migrated files
...
- common.ts: wrap return in Boolean() for proper boolean type
- logger.test.ts: add dispatch property to MockStore interface
- exploreReducer.ts: use flexible ExtendedControlState interface, fix SliceUpdatedAction owners type
- ReportModal/actions.ts: use ThunkDispatch for thunk actions, add error handling to addReport
- ReportModal/reducer.ts: cast through unknown for dynamic property access
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-01 13:07:36 +01:00
Evan Rusackas
ff3b98e388
fix(chart): use setDataMask prop as fallback when actions.updateDataMask is absent
...
Ensures custom setDataMask handlers work in non-dashboard/embedded contexts.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-01 13:07:35 +01:00
Evan Rusackas
bef90c6283
fix(chart): remove unused POST_CHART_FORM_DATA constant
...
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-01 13:07:35 +01:00
Evan Rusackas
0da6adefa3
fix(chart): use derived vizType for drill-to-detail behavior check
...
Use vizType (derived from currentFormData) instead of formData.viz_type
so drill-to-detail props are correctly enabled/disabled when the user
changes visualization type without re-running the query.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-01 13:07:35 +01:00
Evan Rusackas
2a39dcfe16
fix(reports): only show success toast when delete succeeds
...
Move DELETE_REPORT dispatch and success toast from .finally() to .then()
so they only execute on successful deletion, not on failure.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-01 13:07:35 +01:00
Evan Rusackas
599e46ee21
fix: remove unused ChartDataResponse interface
...
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-01 13:07:35 +01:00
Evan Rusackas
574afe41c8
chore(frontend): migrate non-dashboard JS/JSX files to TypeScript
...
Migrates 15 core JavaScript/JSX files and 11 test files to TypeScript
as part of the ongoing frontend modernization effort.
Files migrated:
- src/utils/common.js → common.ts
- src/middleware/loggerMiddleware.js → loggerMiddleware.ts
- src/visualizations/presets/MainPreset.js → MainPreset.ts
- src/features/reports/ReportModal/actions.js → actions.ts
- src/features/reports/ReportModal/reducer.js → reducer.ts
- src/explore/exploreUtils/index.js → index.ts
- src/explore/reducers/exploreReducer.js → exploreReducer.ts
- src/explore/components/EmbedCodeContent.jsx → EmbedCodeContent.tsx
- src/explore/components/ExploreChartHeader/index.jsx → index.tsx
- src/explore/components/ExploreViewContainer/index.jsx → index.tsx
- src/explore/components/useExploreAdditionalActionsMenu/index.jsx → index.tsx
- src/components/Chart/chartAction.js → chartAction.ts
- src/components/Chart/ChartRenderer.jsx → ChartRenderer.tsx
- src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx → DatasourceEditor.tsx
- src/components/Datasource/utils/index.js → index.ts
Key improvements:
- Added proper TypeScript interfaces for all components and functions
- Replaced PropTypes with TypeScript interfaces
- Added typed Redux actions and state interfaces
- Zero `any` types used throughout
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-01 13:07:35 +01:00
Evan Rusackas
ae10e105c2
fix(chart): enable cross-filter on bar charts without dimensions ( #37407 )
...
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com >
2026-01-31 17:14:24 -08:00
dependabot[bot]
901dca58f7
chore(deps): bump JustinBeckwith/linkinator-action from 2.3 to 2.4 ( #37562 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-31 03:06:30 -08:00
dependabot[bot]
d95a3d8426
chore(deps-dev): bump @applitools/eyes-storybook from 3.63.9 to 3.63.10 in /superset-frontend ( #37566 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-31 03:06:09 -08:00
alok kumar priyadarshi
70b95ca1b9
fix(build): eliminate PostgreSQL extra installation on Python 3.12-based Superset Docker images ( #37587 )
2026-01-31 15:54:19 +07:00
Michael S. Molina
004f02746f
fix(build): Increase ForkTsCheckerWebpackPlugin memory limit to fix OOM error ( #37583 )
2026-01-31 14:22:17 +07:00
Beto Dealmeida
5d20dc57d7
feat(oauth2): add PKCE support for database OAuth2 authentication ( #37067 )
2026-01-30 23:28:10 -05:00
Beto Dealmeida
05c2354997
feat: AWS Cross-Account IAM Authentication for Aurora ( #37585 )
2026-01-30 19:18:34 -05:00
Vitor Avila
6043e7e7e3
fix: more DB OAuth2 fixes ( #37398 )
2026-01-30 21:11:26 -03:00
Amin Ghadersohi
1ee14c5993
fix(mcp): improve prompts, resources, and instructions clarity ( #37389 )
2026-01-30 12:25:38 -08:00
Felipe López
9764a84402
fix(charts): Table chart shows an error on row limit ( #37218 )
2026-01-30 11:45:50 -08:00
JUST.in DO IT
570cc3e5f8
feat(sqllab): treeview table selection ui ( #37298 )
2026-01-30 11:07:56 -08:00
dependabot[bot]
66519c3a85
chore(deps-dev): bump fetch-mock from 11.1.5 to 12.6.0 in /superset-frontend/packages/superset-ui-core ( #36662 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: hainenber <dotronghai96@gmail.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@rusackas.com >
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com >
Co-authored-by: hainenber <dotronghai96@gmail.com >
2026-01-30 21:27:35 +07:00
dependabot[bot]
1f43138888
chore(deps): bump babel-loader from 9.2.1 to 10.0.0 in /docs ( #37541 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-30 21:06:23 +07:00
dependabot[bot]
652d029a2d
chore(deps-dev): bump @types/node from 25.0.10 to 25.1.0 in /superset-frontend ( #37563 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-30 21:03:26 +07:00
dependabot[bot]
e67b1f5326
chore(deps-dev): bump baseline-browser-mapping from 2.9.18 to 2.9.19 in /superset-frontend ( #37565 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-30 20:56:46 +07:00
dependabot[bot]
fa79a467e4
chore(deps): bump googleapis from 170.1.0 to 171.0.0 in /superset-frontend ( #37564 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-30 16:57:04 +07:00
Pedro Rodrigues
2cce0308d4
fix: big number drill to details column data ( #37068 )
2026-01-30 12:32:49 +03:00
dependabot[bot]
c7fd1a2f65
chore(deps-dev): bump @types/node from 25.0.10 to 25.1.0 in /superset-websocket ( #37539 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-30 10:22:41 +07:00
dependabot[bot]
ab4f646ef6
chore(deps): bump @babel/core from 7.28.5 to 7.28.6 in /docs ( #37540 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-30 10:22:15 +07:00
Alejandro Solares
d6029f5c8a
chore(deps): bump dependencies to address security vulnerabilities ( #37552 )
2026-01-30 10:19:43 +07:00
dependabot[bot]
c16e8f747c
chore(deps-dev): bump css-loader from 7.1.2 to 7.1.3 in /superset-frontend ( #37544 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-30 10:18:20 +07:00
Evan Rusackas
9c0337d092
fix(explore): correct validationDependancies typo to validationDependencies ( #37554 )
...
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com >
2026-01-30 01:18:50 +03:00
Evan Rusackas
3ef33dcb76
feat(playwright): add documentation screenshot generator ( #37494 )
...
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com >
2026-01-29 10:14:53 -08:00
Jean Massucatto
5a99588f57
fix(themes): correct action icons size and restore missing tooltips ( #37409 )
2026-01-29 20:42:15 +03:00
Kamil Gabryjelski
0b34363654
fix(mcp): Instance not bound to session error ( #37548 )
2026-01-29 18:00:34 +01:00
Jean Massucatto
55ec1152ec
fix(deckgl): change deck gl Path default line width unit to meters ( #37248 )
2026-01-29 19:58:50 +03:00
Michael S. Molina
810d6ff480
fix(sqllab): Resolve stale closure bug causing text selection to break ( #37550 )
2026-01-29 13:09:26 -03:00
Mehmet Salih Yavuz
1501af06fe
fix(Multilayer): preserve dashboard context for embedded ( #37495 )
2026-01-29 18:06:12 +03:00
Michael S. Molina
6cb3cea960
feat(extensions): Allow replacing editors using extensions ( #37499 )
2026-01-29 08:22:32 -03:00
Felipe López
675a4c7a66
fix(charts): numerical column for the Point Radius field in mapbox ( #36962 )
2026-01-29 10:50:10 +01:00
Vanessa Giannoni
7110fc9cde
fix(explore): remove extra spacing when Advanced Analytics section is hidden ( #37456 )
2026-01-29 12:18:06 +03:00
Evan Rusackas
73e095db8e
docs(components): federate Storybook stories into Developer Portal MDX ( #37502 )
...
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com >
2026-01-28 21:33:01 -08:00
Evan Rusackas
5fedb65bc0
fix(docs): migrate deprecated antd v6 APIs to items prop pattern ( #37530 )
...
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com >
2026-01-28 18:47:20 -08:00
Evan Rusackas
b3526fc4ca
docs(community): redesign community page with card grid layout ( #37536 )
...
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com >
2026-01-28 17:58:05 -08:00