Evan Rusackas
c01a4ffd62
address review: drop unused _labelColors/_sharedLabelColors/_isFiltersInitialized destructuring
...
restProps is not spread anywhere, so destructuring these three props
with underscore prefixes served no purpose beyond silencing the lint
rule. Remove them outright per the dead-code review comment.
2026-04-23 12:16:41 -07:00
Evan Rusackas
998bb97f05
fix(lint): drop unused labelsColor/labelsColorMap/cacheBusterProp destructuring
...
Commit 08aac73 ("address review: replace side-effect useMemo with
idiomatic hooks") removed the shouldComponentUpdate-style useMemo that
was the only consumer of these three props, but left them in the
destructuring block. This caused TS6133 "declared but never read"
errors in lint-frontend (tsc --noEmit). Drop the destructuring; the
props remain declared on the ChartRendererProps interface so the
component's public API is unchanged.
2026-04-23 01:38:03 -07:00
Evan Rusackas
08aac73101
address review: replace side-effect useMemo with idiomatic hooks
...
The former shouldComponentUpdate was re-implemented as a useMemo whose return
value was ignored, which is a misuse of useMemo (it was being used purely for
ref mutation side effects). Since the component is already wrapped in memo(),
the shallow prop compare handles re-render gating; the custom matrixify /
shouldRender logic was dead code.
Replace with:
- useMemo to clone queriesResponse (legitimate memoization)
- A prev-ref + useEffect pattern to track queriesResponse changes for render
callbacks (safe to read refs during render when the value doesn't influence
render output)
Drop the now-unused PrevPropsRef interface and the dead matrixify comparator.
2026-04-22 12:49:06 -07:00
Evan Rusackas
814cf2d919
address review: restore matrixify_enable+mode_rows/mode_columns flag names
...
The hasMatrixifyChanges() check introduced matrixify_enable_vertical_layout /
matrixify_enable_horizontal_layout, but the rest of the codebase uses
matrixify_enable together with matrixify_mode_rows / matrixify_mode_columns.
Revert to the canonical flags so matrixify changes are actually detected,
and update the tests accordingly.
2026-04-22 12:45:01 -07:00
Evan Rusackas
3f59d774ba
address review: drop unused data-test prop from ChartRenderer call site
2026-04-22 12:43:28 -07:00
Evan Rusackas
43c1ae2278
address review: use useRef for stable contextMenuRef across renders
2026-04-22 12:42:55 -07:00
Evan Rusackas
c704cedd0b
address review: use typed useTheme from @apache-superset/core/theme in DrillByChart
2026-04-22 12:42:21 -07:00
Evan Rusackas
ca6e120678
address review: use typed useTheme from @apache-superset/core/theme in ChartRenderer
2026-04-22 12:41:09 -07:00
Evan Rusackas
21a089b4a0
fix(Chart): forward filterState and suppressLoadingSpinner
...
The explicit prop list in renderChartContainer omitted filterState and
suppressLoadingSpinner. Forward both to ChartRenderer so native filter
state reaches the chart and auto-refresh keeps the existing chart
visible instead of flashing a spinner.
2026-04-17 17:23:44 -07:00
Evan Rusackas
d2a48cd43e
fix(Chart): restore filterState prop removed during function component conversion
2026-04-17 12:16:26 -07:00
Evan Rusackas
83b754ad2b
fix(Chart): make setControlValue and queriesResponse optional in ChartProps
2026-04-17 11:58:52 -07:00
Evan Rusackas
575722f5d3
fix(imports): rewrite stale @apache-superset/core bare and api/core imports to correct subpaths
2026-04-17 11:35:27 -07:00
Evan Rusackas
08d8ceec0c
fix(imports): rewrite stale @apache-superset/core/ui to current subpaths
...
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-04-17 10:56:26 -07:00
Evan Rusackas
0f3bd396c4
chore(lint): convert ChartRenderer, Chart, and DrillByChart to function components
...
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-04-17 10:35:35 -07:00
dependabot[bot]
5106afb07f
chore(deps): bump d3-cloud from 1.2.8 to 1.2.9 in /superset-frontend ( #39145 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-07 15:16:28 -07:00
dependabot[bot]
2bd4131636
chore(deps): bump react-syntax-highlighter from 16.1.0 to 16.1.1 in /superset-frontend ( #39134 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-07 15:15:18 -07:00
dependabot[bot]
7e452df1cc
chore(deps): bump anthropics/claude-code-action from 1.0.87 to 1.0.89 ( #39132 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-07 15:14:30 -07:00
dependabot[bot]
a626d06415
chore(deps): bump caniuse-lite from 1.0.30001784 to 1.0.30001786 in /docs ( #39128 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-07 15:11:13 -07:00
dependabot[bot]
d159edc9a6
chore(deps-dev): bump @swc/core from 1.15.21 to 1.15.24 in /superset-frontend ( #39127 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-07 15:10:17 -07:00
dependabot[bot]
96fa2cbd2b
chore(deps): update @deck.gl/aggregation-layers requirement from ~9.2.9 to ~9.2.11 in /superset-frontend/plugins/legacy-preset-chart-deckgl ( #39126 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-07 15:09:49 -07:00
dependabot[bot]
9750881193
chore(deps-dev): bump @types/node from 25.5.0 to 25.5.2 in /superset-websocket ( #39125 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-07 15:09:25 -07:00
dependabot[bot]
3db92021c7
chore(deps-dev): bump eslint from 10.1.0 to 10.2.0 in /superset-websocket ( #39123 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-07 15:08:46 -07:00
dependabot[bot]
5ccfc530b2
chore(deps): bump geolib from 3.3.4 to 3.3.14 in /superset-frontend ( #39092 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-07 14:48:08 -07:00
Amin Ghadersohi
5f9fc31ae2
feat(mcp): add get_chart_type_schema tool for on-demand schema discovery ( #39142 )
2026-04-07 12:07:45 -04:00
dependabot[bot]
8e811de564
chore(deps): bump hot-shots from 14.2.0 to 14.3.1 in /superset-websocket ( #39147 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-07 22:43:50 +07:00
dependabot[bot]
027de6339b
chore(deps-dev): bump jsdom from 29.0.1 to 29.0.2 in /superset-frontend ( #39155 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-07 21:39:04 +07:00
Amin Ghadersohi
bf9aff19b5
fix(mcp): compress chart config schemas to reduce search_tools token usage ( #39018 )
2026-04-06 19:52:03 -04:00
SBIN2010
b05764d070
feat: Add currencies controls in country map ( #39016 )
2026-04-06 23:20:03 +03:00
Amin Ghadersohi
7be2acb2f3
fix(mcp): add description and certification fields to default list tool columns ( #39017 )
2026-04-06 13:37:52 -04:00
Amin Ghadersohi
83ad1eca26
fix(mcp): add dynamic response truncation for oversized info tool responses ( #39107 )
2026-04-06 12:36:03 -04:00
Amin Ghadersohi
92747246fc
fix(mcp): remove JWT ValueError g.user fallback in auth layer ( #39106 )
2026-04-06 12:35:46 -04:00
Amin Ghadersohi
7380a59ab8
fix(mcp): fix form_data null, dataset URL, ASCII preview, and chart rename ( #39109 )
2026-04-06 12:34:26 -04:00
Ville Brofeldt
e56f8cc4fb
fix(security_manager): custom auth_view issue ( #39098 )
2026-04-06 09:04:59 -07:00
Ville Brofeldt
7c79b9ab61
fix(migrations): check pre-existing foreign keys on create util ( #39099 )
2026-04-06 09:04:22 -07:00
Maxime Beauchemin
a62be684a0
feat(mcp): add database connection listing and info tools ( #39111 )
...
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
Co-authored-by: Amin Ghadersohi <amin.ghadersohi@gmail.com >
2026-04-06 11:34:10 -04:00
Michael S. Molina
a3dfbd7bff
fix(deps): revert simple-zstd from 2.1.0 back to 1.4.2 ( #39139 )
...
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-04-06 11:28:28 -03:00
Sam Firke
12eb40db01
fix(SQL Lab): handle columns without names ( #38986 )
2026-04-06 10:09:16 -04:00
dependabot[bot]
d796543f5a
chore(deps): update @deck.gl/react requirement from ~9.2.9 to ~9.2.11 in /superset-frontend/plugins/legacy-preset-chart-deckgl ( #39033 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-03 15:07:42 -07:00
dependabot[bot]
e5ae626433
chore(deps): bump dawidd6/action-download-artifact from 19 to 20 ( #39081 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-03 15:06:06 -07:00
dependabot[bot]
8195574345
chore(deps): bump anthropics/claude-code-action from 1.0.85 to 1.0.87 ( #39083 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-03 15:04:43 -07:00
dependabot[bot]
6b029997d9
chore(deps): bump react-syntax-highlighter from 16.1.0 to 16.1.1 in /superset-frontend ( #39087 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-03 15:04:04 -07:00
dependabot[bot]
7a64483e6b
chore(deps-dev): bump @swc/plugin-emotion from 14.7.0 to 14.8.0 in /superset-frontend ( #39088 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-03 15:03:44 -07:00
dependabot[bot]
e424b55036
chore(deps-dev): bump babel-loader from 10.1.0 to 10.1.1 in /superset-frontend ( #39090 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-03 15:02:57 -07:00
dependabot[bot]
613e6d6cde
chore(deps): bump d3-cloud from 1.2.8 to 1.2.9 in /superset-frontend ( #39093 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-03 15:02:11 -07:00
Amin Ghadersohi
b3a402d936
fix(mcp): handle stale SSL connections, heatmap duplicate labels, and session rollback ( #39015 )
2026-04-03 16:07:29 -04:00
JUST.in DO IT
c7d175b842
fix(dashboard): remove opacity on filter dropdown ( #39074 )
2026-04-03 09:31:23 -07:00
Amin Ghadersohi
851bbeea48
fix(mcp): improve execute_sql response-too-large error to suggest limit parameter ( #39003 )
2026-04-03 10:57:31 -04:00
dependabot[bot]
c5bce756f0
chore(deps): bump yeoman-generator from 7.5.1 to 8.1.2 in /superset-frontend ( #38671 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-02 22:13:20 -07:00
dependabot[bot]
3239f058c8
chore(deps-dev): bump baseline-browser-mapping from 2.10.10 to 2.10.13 in /superset-frontend ( #39044 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-02 22:10:35 -07:00
dependabot[bot]
7e0c634c3a
chore(deps-dev): bump typescript-eslint from 8.56.1 to 8.58.0 in /superset-websocket ( #38997 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-02 21:46:19 -07:00