Daniel Vaz Gaspar
7a95f8f839
fix: flaky test on reports ( #14544 )
2021-05-10 13:27:12 +01:00
Ville Brofeldt
66a4c94a1e
fix(chart-data): handle url_params in csv export and native filters ( #14526 )
2021-05-07 21:07:44 +03:00
Ville Brofeldt
d1d98d81b0
feat(dremio): implement convert_dttm method ( #14519 )
2021-05-07 15:31:58 +03:00
David Aaron Suddjian
21cf12a480
chore(dashboard): Integrate dashboard app into the SPA bundle ( #14356 )
...
* chore(dashboard): Integrate dashboard app into the SPA bundle
* fix url params
* change variable name
* change title correctly
* custom css
* lint
* remove unused file
* remove content assertions from dashboard tests
* fix case with missing bootstrap data
* fix: respect crud views flag
* crud views -> spa
* remove unused dashboard templates
* fix: remove unused variable
* fix: missed a spot with the crudViews -> spa
* router link to dashboard from dashboard list page
* link using the router when in card mode
* lint
* fix tests, add memory router
* remove dashboard app files
* split up the bundle a little more
* use webpack preload
2021-05-04 08:51:17 -07:00
Duy Nguyen Hoang
9a22fb00d9
fix: CSV Export permission is not consistent ( #13713 )
2021-05-04 10:19:58 +03:00
Erik Ritter
e05a70fc82
fix: dashboard changed on calculation ( #14450 )
2021-05-03 13:55:34 -07:00
Ville Brofeldt
2f9efb2e23
add migration ( #14446 )
2021-05-03 15:32:48 +03:00
AAfghahi
7466595563
fix: fixing mysql error message ( #14416 )
...
* fixing mysql error message
* Update tests/db_engine_specs/mysql_tests.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update tests/db_engine_specs/mysql_tests.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update tests/db_engine_specs/mysql_tests.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset/db_engine_specs/mysql.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* fixed broken test
* changed error type
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
2021-04-30 15:15:37 -07:00
AAfghahi
e507508b48
feat: Logic added to limiting factor column in Query model ( #13521 )
...
* Sqllab limit
* Add migration script
* Set default values
* initial push
* revisions
* Update superset/views/core.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* moving migration to separate PR
* with migration
* revisions
* Fix apply_limit_to_sql
* all but tests
* added unit tests
* revisions
* Update superset/sql_lab.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset/sql_parse.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* fixed black issue
* Update superset/views/core.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* updated logic
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
2021-04-30 15:15:18 -07:00
Erik Ritter
bc47bc8f66
feat: Add etag caching to dashboard APIs ( #14357 )
2021-04-29 14:14:26 -07:00
Daniel Vaz Gaspar
6541a03d0b
fix: SQLLab role permissions ( #14372 )
...
* fix: SQLLab role permissions
* add missing perm
* fix tests
* fix security test
* fix security test
* fix tests
2021-04-29 15:58:08 +01:00
Ben Reinhart
e7f5100833
fix: Fix unintended cache misses with async queries ( #14291 )
...
* bug: Fix unintended cache misses with async queries
* Ensure sort order
* Ensure columns are sorted
* Update failing tests
2021-04-28 12:14:55 -07:00
John Bodley
d8bb2d3e62
refactor(db_engine_specs): Removing top-level import of app ( #14366 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-04-28 15:47:32 +12:00
Ben Reinhart
2a1235c0c2
fix: Cleanup serialization and hashing code ( #14317 )
2021-04-26 14:04:40 -07:00
Daniel Vaz Gaspar
45e209d487
fix: flaky test for alerts and reports ( #14347 )
2021-04-26 18:56:48 +01:00
John Bodley
b0f8f6b6ad
fix(hive): Use parquet rather than textfile when uploading CSV files to Hive ( #14240 )
...
* fix(hive): Use parquet rather than textfile when uploading CSV files
* [csv/excel]: Use stream rather than temporary file
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-04-24 18:17:30 +12:00
John Bodley
a8781c5313
fix(hive): Update CSV to Hive upload prefix ( #14255 )
...
* fix(hive): Update CSV to Hive upload prefix
* Trigger notification
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-04-24 13:20:31 +12:00
Beto Dealmeida
e7ad03d44f
feat: add endpoint to fetch available DBs ( #14208 )
...
* feat: add endpoint to fetch available DBs
* Fix lint
2021-04-23 10:51:47 -07:00
Beto Dealmeida
ffcacc3393
fix: new import/export CLI ( #13921 )
...
* fix: CLI for import/export
* Add tests
* Remove debug
2021-04-23 10:50:49 -07:00
Daniel Vaz Gaspar
38a7c537ff
feat: add alerts & reports to docker compose ( #14267 )
...
* feat: add alerts & reports to docker compose
* change to firefox
* add missing package
2021-04-22 17:42:52 +01:00
Beto Dealmeida
5d3191bb61
feat: catch errors on do_ping ( #14250 )
2021-04-21 18:43:40 -04:00
Jesse Yang
2dd20df03d
fix(dashboard): draft dashboards should be viewable ( #14207 )
...
* fix(dashboard): draft dashboards should have open access
* Remove a duplicate test
2021-04-21 09:54:51 -07:00
Hugh A. Miles II
392d8a8107
fix: Handle bad permission errors for bigquery test connections ( #14147 )
...
* starter make file
* yea
* move messaging to config
* Delete Makefile
* remove
* checkout
* check for db generic errors
* checkout bad files
* add proper message
* add docs for new permissions codes
* Update superset/errors.py
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com >
* Update superset/errors.py
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com >
* rename var
* starter regex
* fix
* fix
* fix linting
* update test
* yerp
* fixed test
* added regex
* Apply suggestions from code review
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* address comments
* update docs
* prettier
* fux
* add space
* Update errors.py
* Update types.ts
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com >
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
2021-04-20 19:19:36 -04:00
Ville Brofeldt
55bf72aead
chore(prophet): bump prophet to 1.0.1 ( #14228 )
2021-04-20 15:55:55 +03:00
Ville Brofeldt
0807ab44a5
fix(native-filters): merge_extra_form_data extras processing ( #14244 )
...
* fix: merge_extra_form_data extras processing
* move props that are later moved back in viz.py
2021-04-20 14:24:33 +03:00
Beto Dealmeida
13bf023100
feat: improve engine spec discoverability ( #14204 )
...
* feat: improve engine spec discoverability
* Address comments
* Fix tests
2021-04-19 17:24:22 -07:00
Đặng Minh Dũng
11e0f4cb2d
feat: TrinoEngineSpec.adjust_database_uri ( #14122 )
...
* feat: TrinoEngine implement adjust_database_uri
Signed-off-by: Đặng Minh Dũng <dungdm93@live.com >
* test: TrinoEngine implement adjust_database_uri
Signed-off-by: Đặng Minh Dũng <dungdm93@live.com >
2021-04-19 13:10:12 +03:00
Beto Dealmeida
c7112d1c48
feat: error messages for Presto connections ( #14172 )
...
* chore: rename connection errors
* feat: error messages for Presto connections
* Add unit tests
* Update docs/src/pages/docs/Miscellaneous/issue_codes.mdx
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com >
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com >
2021-04-16 15:49:47 -04:00
AAfghahi
df04c3af21
feat: error messages when connecting to mssql ( #14171 )
...
* database errors for mssql
* revisions
2021-04-16 09:43:42 -07:00
Craig Rueda
a49e0b2037
feat: Adding encrypted field factory ( #14109 )
...
* First cut at adding enc type factory
* Finalized enc type factory
* Adding unit test
* PyLinting
* Adding license
* Apply suggestions from code review
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com >
* Moving things from enc -> encrypt
* CI commit
* One more fix
* Tweaking config name
* Fixing broken test
* Fixing broken test again
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com >
2021-04-16 09:01:18 -07:00
Lily Kuang
df7e2b6a8e
feat(alert/report): chart as csv format attachment for email and slack ( #13828 )
...
* add ui for setting report format
* refactor default notification format
* init csv data alert report
* add report format to report_schedule model
* add ALERTS_ATTACH_REPORTS feature flag
* fix lint
* update check image tag
* fix migrations
Co-authored-by: samtfm <sam@preset.io >
2021-04-15 14:07:49 -07:00
Beto Dealmeida
21c6efea67
chore: rename connection errors ( #14169 )
2021-04-15 10:57:02 -07:00
AAfghahi
eadff5f41e
feat: invalid DB name error messages (MySQL/Postgres/Redshift) ( #14146 )
...
* initial DB custom errors for mysql
* added redshift and postgres
2021-04-15 08:02:47 -07:00
simcha90
8ef572a412
refactor(native-filters): update dataMask and ExtraFormData schema ( #13983 )
...
* refactor: updates usage of `ownFilters` to `ownState`
* refactor: update dataMask (final)
* lint: fix lint
* refactor: revert feat
* fix: fix missed chart configuration
* add filter set migration
* apply new changes
* fix migration revision
* update migration
* fix jest mock
* js lint
* fix test types
* update tests and types
* remove append_form_data from tests
* fix findExistingFilterSet tests
* add migration test
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com >
2021-04-15 17:43:29 +03:00
Beto Dealmeida
21f973f0bd
feat: error messages when connecting to MSSQL ( #14093 )
...
* feat: error messages when connecting to MSSQL
* Address comments
2021-04-14 10:57:58 -07:00
AAfghahi
321db4674d
feat: invalid hostname and password error messages (Redshift) ( #14111 )
...
* custom errors for redshift
* added unit tests and custom errors
2021-04-13 21:20:47 -07:00
AAfghahi
b77477a9dd
feat: invalid hostname and password error messages (MySQL) ( #14089 )
...
* custom errors for mySQL
* initial custom errors and tests for MySQL
* revisions
2021-04-13 14:42:31 -07:00
Hugh A. Miles II
4b23d0ecca
fix: logs table - user_id is NULL ( #14057 )
...
* add user back to session
* add test for logging None on exceptions
* fix this updated test
* reformat
* reformat
* Update log.py
2021-04-13 10:08:34 -04:00
Amit Miran
8c5b6b1263
feat(dashboard_rbac): provide data access based on dashboard access ( #13992 )
...
* feat: provide data access based onb dashboard access
* chore: adjust code after CR comments
* fix: add brackets
* fix: type
* chore: add tests
* fix: pre-commit
* fix: pre-commit and lint
* fix: fix test
* fix: pre-commit
* fix: fix local pylint warnings
* revert: birth_names pylint change bc it affects tests
* Update superset/security/manager.py
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
* Update superset/security/manager.py
* Update tests/utils_tests.py
* fix: after CR
* fix: after CR from ville
* chore: update roles description
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
2021-04-13 16:23:31 +03:00
Ville Brofeldt
15ac075b78
fix(sqla): labels_expected contains mutated label ( #14095 )
2021-04-13 16:19:52 +03:00
Amit Miran
9c5264af0d
feat(can_share): can share chart and dashboard ( #14076 )
...
* feat: share chart - can_share_chart
share dashboard can_share_dashboard
* fix: pre-commit
* fix: userCanShare tests
* fix: after hugh CR
* fix: adjust after spa refactor
2021-04-13 13:54:14 +03:00
Phillip Kelley-Dotson
4bb29b6f04
chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata ( #13306 )
...
* add hook for future async api calls
* test to see conflict
* add async middleware and update reducers
* working async dashboard load
* implement getcharts api
* add user permissions to explore and dashboard bootstrap data
* integrate api calls with getinitial state
* update namings
* accept an id or a slug in the dashboard charts api
* add permissions function
* fix merge
* update state
* get dashboard charts by id or slug
* fix undefined states
* variable names
* stop using some more bootstrap data
* fix metadata reference
* remove unused bootstrap from the template
* add errorboundry to dashboard
* refactoring, fixing
* update permissions
* add just roles
* id is supposed to be a string
* unused vars
* get datasources from api
* make onError optional
* use resource hooks, better error boundary
* add loading state for dashboardroute
* remove console
* add conditional
* more conditionals
* testing out a possible fix for cypress
* convert edit/standalone test to cypress
* remove bootstrappy assertions
* lint
* fix dashboard edit history issue
* rename stuff
* address recent native filters schema change
* remove unused getInitialState
* remove .only from test
* hooksy redux usage
* Revert "more conditionals"
This reverts commit 25c8ed61b477dea1915bevan@preset.io >
* import style
* comment
* cleaner dashboardInfo
* remove debug code
* use memo for getPermissions
* fix lint
* adjust name/location of DashboardPage
* move logic for REMOVE_SLICE_LEVEL_LABEL_COLORS to DAO
* stop using full_data()
* remove unused (and now useless) json=true query param
Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com >
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com >
Co-authored-by: Evan Rusackas <evan@preset.io >
2021-04-12 16:10:29 -07:00
Beto Dealmeida
786dadc836
feat: invalid password error message (Postgres) ( #14038 )
2021-04-12 14:03:21 -07:00
Hugh A. Miles II
c563ea091e
fix: flacky test in test_update_dataset_item_w_override_columns ( #14082 )
...
* fix flack test
* fix flack test
2021-04-12 16:45:50 -04:00
Lily Kuang
7980b767c0
feat: Implement Celery SoftTimeLimit handling ( #13740 )
...
* log soft time limit error
* lint
* update test
2021-04-12 13:18:17 -07:00
Sam Faber-Manning
911462a148
feat: only send alert error emails to owners of the alert ( #13862 )
...
* only send alert error emails to owners of the alert
* reformat long lines
* fix send to owners and add tests
* fix pylint errors
* fix formatting
2021-04-12 08:51:32 -07:00
Hugh A. Miles II
a4fd6b8f33
fix: Use superset generic db to catch external_metadata queries ( #13974 )
2021-04-10 10:15:03 -04:00
Erik Ritter
3d357c661c
feat: handle chart/data API errors ( #14040 )
2021-04-09 09:39:02 -07:00
John Bodley
a3b41e2bac
fix: Issue 13956 ( #13980 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-04-09 15:21:58 +12:00
Beto Dealmeida
c60a93db9c
feat: add extract_errors to Postgres ( #13997 )
...
* feat: add extract_errors to Postgres
* Add unit tests
* Fix lint
* Fix unit tests
2021-04-08 13:24:54 -07:00
