QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-02 06:09:21 +00:00
Code Issues Packages Projects Releases Wiki Activity
8,539 Commits 534 Branches 545 Tags
fa44325a368dab45f24204c2f8241a1c7afa3d86
Commit Graph

42 Commits

Author SHA1 Message Date
Kamil Gabryjelski
fa44325a36 fix(explore): Metrics disappearing after removing metric from dataset (#17201) 
* fix(explore): Metrics disappearing after removing metric from dataset

* fix test

* Apply fix to non-dnd controls

* Make adhoc metrics pick up changes from dataset columns

* Remove console log

* Fix bug in nondnd controls
 2021-10-29 16:15:19 +02:00
Geido
e40ff3ada6 chore: Select component refactoring - DndColumnSelectControl - Iteration 5 (#16440) 
* Refactor Select

* Update ariaLabel

* Reconcile with latest Select changes

* Fix lint

* Enhance labels
 2021-09-27 17:27:14 +03:00
Ville Brofeldt
f703c12ae8 chore: bump superset-ui to 0.18.8 (#16850) 2021-09-27 11:54:05 +03:00
Ville Brofeldt
1d890f8913 fix(explore): make clicked dnd filters unique (#16700) 2021-09-14 18:01:21 +03:00
Ville Brofeldt
9dfa33fedf fix(dnd): make clicked dnd metrics unique (#16632) 2021-09-08 13:21:21 +03:00
Yongjie Zhao
80c39daa85 fix: can't drop column when name overlap (#16482) 2021-09-01 13:52:10 +08:00
Jesse Yang
a413f796a6 fix(explore): JS error for creating new metrics from columns (#16477) 2021-08-26 17:04:45 -07:00
Jesse Yang
ec087507e5 refactor(explore): improve typing for Dnd controls (#16362) 2021-08-26 01:23:14 -07:00
Kamil Gabryjelski
a547dcb73e fix(explore): reordering columns with dnd sometimes glitching (#16322) 
* fix(explore): reordering columns with dnd sometimes glitching

* Fix metrics and filters popover being stale after reordering
 2021-08-18 18:39:05 +02:00
Kamil Gabryjelski
203c311ca3 feat(explore): make dnd controls clickable (#16119) 
* Make ghost buttons clickable

* Popover for column control

* Make column dnd ghost button clickable

* Prefill operator only if column is defined

* Remove data-tests

* lint fix

* Hide new features behind a feature flag

* Change ghost button texts

* Remove caret for non clickable columns
 2021-08-17 14:56:39 +02:00
Geido
a1e18ed110 fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel (#16060) 
* Implement dynamic tooltip

* Normalize and consolidate

* Clean up

* Refactor and clean up

* Remove unnecessary var

* Fix type import

* Update superset-frontend/src/explore/components/controls/OptionControls/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Remove unnecessary styled span

* Show full tooltip title

* Force show tooltip

* Force show tooltip D&D off

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
 2021-08-12 11:48:16 -06:00
Kamil Gabryjelski
98fc29cbbb fix(explore): metric label disappearing in some scenarios (#16190) 2021-08-11 14:05:44 +02:00
Kamil Gabryjelski
6e1d16d956 feat(explore): each control can define its own canDrop for dnd (#16090) 
* feat(explore): each control can define its own canDrop for dnd

* Make canDropValue optional

* Add onDropValue
 2021-08-10 17:04:42 +02:00
Kamil Gabryjelski
b7cc89c6d4 fix(explore): dnd error when dragging metric if multi: false (#16088) 
* fix(explore): dnd error when dragging metric if multi: false

* Fix error for non-dnd controls
 2021-08-09 18:15:50 +02:00
Kamil Gabryjelski
6ac4f4ef2f chore(explore): change dnd placeholders (#16116) 
* chore(explore): change dnd placeholders

* Fix tests and lint
 2021-08-09 17:50:11 +02:00
Kamil Gabryjelski
772da8de63 fix(explore): revert dnd column dependency array change to fix infinite rerenders (#16115) 
* fix(explore): revert dnd column dependency array change to fix infinite rerenders

* Remove console.log

* Remove comment
 2021-08-06 17:59:22 +02:00
David Aaron Suddjian
e6292a89bb fix(explore): drag & drop column select component triggering onChange unnecessarily (#16073) 
* fix(explore): avoid sync until after first render

* fix example
 2021-08-05 15:38:28 -07:00
Kamil Gabryjelski
5917407b9c fix(explore): filter popover opening after removing a filter (#16024) 2021-08-02 22:01:17 +02:00
Kamil Gabryjelski
3061b6ad09 fix(explore): fix undefined error when using dnd (#16020) 2021-08-02 15:22:32 +02:00
Kamil Gabryjelski
3f5237a3c1 feat(explore): new datasets have autocomplete filters enabled if UX_BETA is set (#15864) 
* feat(explore): new datasets have autocomplete filters enabled if UX_BETA is set

* Lint fix

* Set autocomplete to True in example datasets

* Use "IN" as a default operator in dnd filters

* Default operator only if UX_BETA enabled
 2021-07-27 17:40:10 +02:00
Kamil Gabryjelski
5e1c469f42 feat(explore): default aggregate for string/numeric columns when creating metric (#15798) 
* feat(explore): default aggregate for string/numeric columns when creating metric

* Fix for editing items with the same label

* Replace componentDidUpdate with getDerivedStateFromProps

* Wrap changes in feature flag
 2021-07-22 18:23:10 +02:00
Kamil Gabryjelski
239336c3e8 fix(explore): dnd multiple columns doesn't work (#15781) 2021-07-19 20:18:10 +02:00
Kamil Gabryjelski
4234031cba feat(explore): UX improvements for drag'n'dropping time column (#15740) 2021-07-19 01:52:34 +08:00
Kamil Gabryjelski
66c28d653f fix(explore): DndColumnSelect sometimes not working with multi: false (#15731) 
* fix(explore): DndColumnSelect not working with multi: false

* fix values not synchronized when dataset changes
 2021-07-16 14:20:13 +02:00
Ajay M
f8b270d419 fix(explore): Explore page boolean filter is broken for Presto DB (#14952) 
* Front end update - modify OPERATORS, to have SQL operation and display value

* Updated tests

* More tests

* Remove OPERATOR imports

* Fix break tests

* PR comments

* fix issue with comparator loading

* rename a variable

* Linting
 2021-06-10 09:08:04 -07:00
Ville Brofeldt
65714cc201 fix(dnd): add isExtra prop to Option (#15080) 2021-06-10 12:13:20 +03:00
Kamil Gabryjelski
d03c608ce1 fix(explore): DndColumnSelect not handling controls with "multi: false" (#14737) 
* fix(explore): DndColumnSelect not handling controls with multi={false}

* Implement translations for singular and plural cases

* Fix test
 2021-05-24 09:53:46 +02:00
Michael S. Molina
fd8b2cb89b fix: Fixes group by control icon colors (#14674) 2021-05-17 13:53:32 -07:00
Michael S. Molina
9deb7aa3c1 chore: Replaces Icon with Icons component - iteration 1 (#14469) 2021-05-17 10:24:56 -07:00
David Aaron Suddjian
f16c708fab fix(dashboard): check edit permissions correctly on frontend (#14626) 
* fix(dashboard): check edit permissions correctly on frontend

* fix types, appease linter

* handle nulls better
 2021-05-14 12:18:38 -07:00
Ville Brofeldt
3f6bd1e4a4 feat: add generic type to column payload (#14547) 
* feat: add generic type to column payload

* feat: add generic type to column payload

* xit flaky test
 2021-05-13 09:36:09 +03:00
Phillip Kelley-Dotson
3eef38f309 refactor: change xsm Icons and dnd icons to new dynamic icons (#14419) 
* intial commit

* fix test and add more icons

* fix lint
 2021-05-12 22:52:25 -07:00
Kamil Gabryjelski
b030c9801c chore: Move styles from .less stylesheet to emotion in Explore (#14485) 
* Move some styles from .less stylesheet to emotion in Explore

* Replace Global styles with local styled components

* Address comments
 2021-05-05 15:36:52 +02:00
Michael S. Molina
8441590812 chore: Moves Tooltip to the components folder (#14137) 2021-04-20 08:47:47 -07:00
Kamil Gabryjelski
6119d8e998 Fix filter edit popover not opening in DnD mode (#14243) 2021-04-20 11:45:48 +02:00
Jesse Yang
65940770ac feat(explore): adhoc column formatting for Table chart (#13758) 2021-04-01 23:28:42 -07:00
Michael S. Molina
42c7e2cae6 test: Adds tests to dnd controls (#13650) 2021-04-01 09:11:33 -07:00
Michael S. Molina
6fd62e3f7e test: Adds tests to the OptionControls component (#13729) 2021-03-31 18:07:22 -07:00
Kamil Gabryjelski
ae66f5fa78 feat(explore): Drag and drop UX improvements (#13598) 
* Create a metric immediately when saved metric is dropped

* Display borders around control boxes when metric or column is dragged

* Fix imports

* Display ghost button

* Rename placeholder to ghostButton
 2021-03-15 12:47:13 +02:00
Kamil Gabryjelski
d439da2fe0 feat: Implement drag and drop for metrics (#13575) 
* Convert MetricsControl to functional component

* Implement drag and drop for metrics

* Implement customizable placeholder for DndSelectLabel
 2021-03-12 12:31:17 +08:00
Kamil Gabryjelski
7b370e6f17 feat: Implement drag and drop columns for filters (#13340) 
* Implement DnD feature for filters

* minor refactor

* Fix types

* Fix undefined error

* Refactor

* Fix ts errors

* Fix conflicting dnd types

* Bump superset-ui packages

* Change DndItemType case to PascalCase

* Remove redundant null check

* Fix

* Fix csrf mock api call
 2021-03-07 11:54:08 +02:00
Yongjie Zhao
1e3130d588 feat(explore): ColumnSelectControl with drag-and-drop (#13210) 
* initial dnd

* shift group by items

* lint

* fix shift options

* wip

* wip

* fix shift action

* support scalar dimentions

* control rename to DndColumnSelectControl

* remove unused files

* added feature flag

* ff to False by default

* fix ut

* lint

* improve code smell

* added indicator

* replace value when column is scalcar

* scalar to isArray

* var rename

* minor fix

* update dependence

* minor fix
 2021-02-26 16:48:23 +08:00