John Bodley
488ec02e70
chore(report): Use for/else clause ( #24107 )
2023-05-19 06:41:17 -07:00
John Bodley
d583ca9ef5
chore: Embrace the walrus operator ( #24127 )
2023-05-19 00:37:13 -07:00
Daniel Vaz Gaspar
694f93326d
fix: methods incorrect type and update deprecated targets ( #23935 )
2023-05-05 18:57:27 +01:00
EugeneTorap
689bc8ea04
chore: Use nh3 lib instead of bleach ( #23862 )
2023-04-28 14:36:51 +01:00
Sebastian Liebscher
b31efbae7c
chore: remove RemovedInMarshmallow4 warnings ( #23704 )
2023-04-21 09:11:46 +03:00
ʈᵃᵢ
350723bff8
fix: update log message for ALERT_REPORTS_NOTIFICATION_DRY_RUN ( #23604 )
2023-04-12 09:30:28 -06:00
Zef Lin
870bf6d0b9
fix: revert back to use security manager authz for dashboard when get by uuid ( #23330 )
2023-03-16 15:27:02 +00:00
Hugh A. Miles II
b820eb8235
chore: Update pre-commit packages ( #23173 )
2023-03-13 17:05:13 -06:00
Josh Soref
dec6ac49f6
chore(backend): Spelling ( #19677 )
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com >
Co-authored-by: Evan Rusackas <evan@preset.io >
2023-02-17 10:48:24 -07:00
Elizabeth Thompson
7160daecf3
chore: change AlertQueryError to 400 ( #23102 )
2023-02-16 16:31:16 -08:00
Elizabeth Thompson
4ddf67fc14
chore: move dashboard screenshot standalone logic ( #23003 )
2023-02-15 14:35:08 -08:00
Ville Brofeldt
577ac81686
chore(ci): fix numpy type errors and revert #22610 ( #22782 )
2023-01-19 14:53:48 +02:00
Elizabeth Thompson
c58dbf8b9c
fix: pass in slack error messages properly ( #22727 )
2023-01-17 13:30:51 -08:00
Cemre Mengu
0b22287ad9
feat: make CTA text in Alerts & Reports mails configurable ( #19779 )
2023-01-10 11:52:54 -07:00
Elizabeth Thompson
7591acba54
fix: change type of slack error ( #22443 )
2023-01-06 17:50:43 -05:00
Daniel Vaz Gaspar
7926a43aed
refactor: rename filter_rel_fields to base_related_field_filters ( #22508 )
2022-12-24 00:39:53 +00:00
Ville Brofeldt
aa0cae9b49
feat(thumbnails): add support for user specific thumbs ( #22328 )
2022-12-14 15:02:31 +02:00
Ville Brofeldt
c3f9f0bf69
fix(alerts): execute query as report executor ( #22167 )
2022-11-18 14:22:56 +02:00
Elizabeth Thompson
ce145c676c
refactor: use exception status for logging ( #21971 )
2022-11-14 14:14:24 -08:00
Ville Brofeldt
a02a778cc3
feat(reports): execute as other than selenium user ( #21931 )
...
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com >
2022-10-31 14:32:49 +02:00
AAfghahi
33fc57854d
fix: error_parsing ( #21946 )
2022-10-28 19:43:37 -04:00
AAfghahi
76c865fc56
chore: additional logging in alerts and reports ( #21802 )
2022-10-24 17:07:21 -04:00
Ville Brofeldt
4c1777f20d
fix(alerts): restrict list view and gamma perms ( #21765 )
2022-10-15 10:03:26 +03:00
Phillip Kelley-Dotson
f4fa2e1115
chore: add more logging for alerts and reports ( #21714 )
2022-10-13 15:53:02 -04:00
Erik Cederstrand
640628952e
chore(dep): Unpin slackclient dependency ( #21586 )
...
Co-authored-by: Erik Cederstrand <erik@adamatics.com >
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
2022-10-04 14:42:42 +03:00
Elizabeth Thompson
4417c6e3e2
chore: add 4xx error codes where applicable ( #21627 )
2022-10-03 15:19:47 -07:00
Phillip Kelley-Dotson
84c3cf66ea
fix: add logging to alerts and reports to find non-triggering issues ( #21684 )
2022-10-03 13:24:32 -07:00
Daniel Vaz Gaspar
ab7cfec975
feat: new config to filter specific users from dropdown lists ( #21515 )
2022-09-29 12:30:07 +01:00
AAfghahi
dda1dcf8ee
feat: add header_data into emails ( #20903 )
...
* test sparkpost
* added logging info
* header function implementation
* added test
* daniel revisions
* daniel revision
* elizabeth review
2022-08-18 10:32:25 -04:00
Jesse Yang
e739ff5076
feat: allow more HTML tags in report description ( #20908 )
2022-07-29 08:27:39 -07:00
Jesse Yang
4d192e6e4d
feat(report): capture dashboard reports in specific states ( #20552 )
2022-07-26 17:01:56 -07:00
John Bodley
7a1aa79c52
fix: Ensure consistent rollback logic ( #20811 )
2022-07-25 08:18:53 -07:00
Cody Leff
84d4302628
fix(explore): Fix chart standalone URL for report/thumbnail generation ( #20673 )
...
* Update explore URLs.
* More URL fixes.
* Make frontend accept true/false query params case-insensitively.
* Fix URL mistake.
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com >
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com >
2022-07-19 13:53:55 -03:00
John Bodley
f0ca158989
fix: Refactor ownership checks and ensure consistency ( #20499 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2022-07-07 11:04:27 -07:00
Rui Zhao
818962cc89
fix(embedded): Retry when executing alert queries to avoid sending transient errors to users as alert failure notifications ( #20419 )
...
Co-authored-by: Rui Zhao <zhaorui@dropbox.com >
2022-07-05 13:23:05 -07:00
Smart-Codi
ee06d3d113
Fix typo issue in Error handling message ( #20365 )
2022-06-13 14:29:18 -06:00
AAfghahi
c131f025f8
chore: add event logger to reports/alerts CRUD ( #20249 )
...
* add event logger to report CRUD
* added assert metric to tests
* added unique name to action
* testing
* with inline log context
2022-06-06 16:13:22 +02:00
Daniel Vaz Gaspar
77ccec50cc
feat: add statsd metrics for notifications ( #20158 )
...
* feat: add statsd metrics for notifications
* fix import
* fix lint
* add decorator arg for custom prefix
* add tests
2022-05-26 15:43:05 +01:00
John Bodley
89a844a40f
fix(reports): Clear last value when state is WORKING ( #19941 )
...
* fix(reports): Clear last value when state is WORKING
* Update cbe71abde154_fix_report_schedule_and_log.py
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2022-05-12 21:54:23 -07:00
John Bodley
449d08b25e
fix: Refactor SQL username logic ( #19914 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2022-05-12 21:03:05 -07:00
AAfghahi
fd611d7653
refactor: Refactor reports for Charts and Dashboards ( #19130 )
...
* bumping shillelagh
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Arash/new state report (#16987 )
* code dry (#16358 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor(reports): Arash/refactor reports (#16855 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* report pickup
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* refactor(reports): Arash/again refactor reports (#16872 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* it is still not working
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* next changes
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* refactor: Reports code clean 10-29 (#17424 )
* Add delete functionality
* Report schema restructure progress
* Fix lint
* Removed console.log
* fix(Explore): Remove changes to the properties on cancel (#17184 )
* Remove on close
* Fix lint
* Add tests
* fix(dashboard): don't show report modal for anonymous user (#17106 )
* Added sunburst echart
* fix(dashboard):Hide reports modal for anonymous users
* Address comments
* Make prettier happy
Co-authored-by: Mayur <mayurp@kpmg.com >
* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503 )
* Add functionality is now working (#17578 )
* Preset io ch28954 refactor reports (#19129 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Arash/new state report (#16987 )
* code dry (#16358 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor(reports): Arash/refactor reports (#16855 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* report pickup
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* refactor(reports): Arash/again refactor reports (#16872 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* it is still not working
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* next changes
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* refactor: Reports code clean 10-29 (#17424 )
* Add delete functionality
* Report schema restructure progress
* Fix lint
* Removed console.log
* fix(Explore): Remove changes to the properties on cancel (#17184 )
* Remove on close
* Fix lint
* Add tests
* fix(dashboard): don't show report modal for anonymous user (#17106 )
* Added sunburst echart
* fix(dashboard):Hide reports modal for anonymous users
* Address comments
* Make prettier happy
Co-authored-by: Mayur <mayurp@kpmg.com >
* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503 )
* Add functionality is now working (#17578 )
* refactoring reports
* ready for review
* added testing
* removed user reducer
* elizabeth suggestions
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
Co-authored-by: Geido <60598000+geido@users.noreply.github.com >
Co-authored-by: Mayur <mayurnewase111@gmail.com >
Co-authored-by: Mayur <mayurp@kpmg.com >
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com >
* deleted additional folder
* fixing tests
* all but styling
* bumping shillelagh
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Arash/new state report (#16987 )
* code dry (#16358 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor(reports): Arash/refactor reports (#16855 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* report pickup
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* refactor(reports): Arash/again refactor reports (#16872 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* it is still not working
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* next changes
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* refactor: Reports code clean 10-29 (#17424 )
* Add delete functionality
* Report schema restructure progress
* Fix lint
* Removed console.log
* fix(Explore): Remove changes to the properties on cancel (#17184 )
* Remove on close
* Fix lint
* Add tests
* fix(dashboard): don't show report modal for anonymous user (#17106 )
* Added sunburst echart
* fix(dashboard):Hide reports modal for anonymous users
* Address comments
* Make prettier happy
Co-authored-by: Mayur <mayurp@kpmg.com >
* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503 )
* Add functionality is now working (#17578 )
* Preset io ch28954 refactor reports (#19129 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Arash/new state report (#16987 )
* code dry (#16358 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor(reports): Arash/refactor reports (#16855 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* report pickup
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* refactor(reports): Arash/again refactor reports (#16872 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* it is still not working
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* next changes
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* refactor: Reports code clean 10-29 (#17424 )
* Add delete functionality
* Report schema restructure progress
* Fix lint
* Removed console.log
* fix(Explore): Remove changes to the properties on cancel (#17184 )
* Remove on close
* Fix lint
* Add tests
* fix(dashboard): don't show report modal for anonymous user (#17106 )
* Added sunburst echart
* fix(dashboard):Hide reports modal for anonymous users
* Address comments
* Make prettier happy
Co-authored-by: Mayur <mayurp@kpmg.com >
* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503 )
* Add functionality is now working (#17578 )
* refactoring reports
* ready for review
* added testing
* removed user reducer
* elizabeth suggestions
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
Co-authored-by: Geido <60598000+geido@users.noreply.github.com >
Co-authored-by: Mayur <mayurnewase111@gmail.com >
Co-authored-by: Mayur <mayurp@kpmg.com >
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com >
* deleted additional folder
* fixing tests
* all but styling
* fixed tests
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
Co-authored-by: Geido <60598000+geido@users.noreply.github.com >
Co-authored-by: Mayur <mayurnewase111@gmail.com >
Co-authored-by: Mayur <mayurp@kpmg.com >
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com >
2022-05-11 14:19:51 -04:00
Jesse Yang
7b88ec7e25
refactor(ReportModal): simplify state reducer and improve error handling ( #19942 )
2022-05-05 10:06:40 -07:00
Daniel Vaz Gaspar
5dd3ea154b
fix: OpenAPI docs small fixes ( #19936 )
2022-05-04 09:59:16 +01:00
Diego Medina
a05ff5e598
fix: alert/report created by filter inconsistency with table display ( #19518 )
...
* fix: alert/report created by filter inconsistency with table display
* Match column order to dashboard list
2022-04-18 17:41:07 -06:00
Ville Brofeldt
a619cb4ea9
chore: upgrade black ( #19410 )
2022-03-29 20:03:09 +03:00
Jesse Yang
92cd0a18e6
chore: upgrade mypy ( #19227 )
2022-03-17 10:35:53 -07:00
Hugh A. Miles II
8c52fe3476
feat: Allow users to bust cache in report dashboard + alerts charts + alert dashboards ( #18795 )
...
* wip
* add force cahce bypass option to alerts
* remove default for alerts to bypass cache
* save for now
* save for now
* fix
* commenting out for now
* fix linting
* remove link
* add back force id test
* add frontend test
* address
2022-03-04 12:30:40 -08:00
Hugh A. Miles II
5d2e726f76
fix: update standalone url for slack reports ( #18756 )
...
* update url for slack reports
* fix test
* update text to be dynamic
2022-02-17 15:48:57 -05:00
Grace Guo
59b811ac5b
fix: report list search by created_by ( #18725 )
2022-02-15 19:37:17 -08:00
Grace Guo
987237b928
fix: remove extra < character in email report ( #18224 )
2022-01-31 15:51:22 -08:00
