test(ssh_tunnel): assert socket connect in host-key mismatch test

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

.asf.yaml

@@ -77,17 +77,23 @@ github:
         # combination here.
         contexts:
           - lint-check
-          - cypress-matrix-required
+          - cypress-matrix (0, chrome)
+          - cypress-matrix (1, chrome)
+          - cypress-matrix (2, chrome)
+          - cypress-matrix (3, chrome)
+          - cypress-matrix (4, chrome)
+          - cypress-matrix (5, chrome)
           - dependency-review
           - frontend-build
-          - playwright-tests-required
+          - playwright-tests (chromium)
           - pre-commit (current)
+          - pre-commit (previous)
           - test-mysql
-          - test-postgres-required
+          - test-postgres (current)
           - test-postgres-hive
           - test-postgres-presto
           - test-sqlite
-          - unit-tests-required
+          - unit-tests (current)
 
       required_pull_request_reviews:
         dismiss_stale_reviews: false

.github/workflows/codeql-analysis.yml

@@ -15,35 +15,9 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  changes:
-    runs-on: ubuntu-24.04
-    timeout-minutes: 10
-    permissions:
-      contents: read
-      pull-requests: read
-    outputs:
-      python: ${{ steps.check.outputs.python }}
-      frontend: ${{ steps.check.outputs.frontend }}
-    steps:
-      - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
-        with:
-          persist-credentials: false
-      - name: Check for file changes
-        id: check
-        uses: ./.github/actions/change-detector/
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
-
   analyze:
     name: Analyze
-    needs: changes
-    # Skip on PRs that touch neither code group (e.g. docs-only) so the
-    # analysis runners don't spin up. push/schedule runs always proceed:
-    # the change-detector returns "all changed" for non-PR events.
-    if: needs.changes.outputs.python == 'true' || needs.changes.outputs.frontend == 'true'
     runs-on: ubuntu-24.04
-    timeout-minutes: 30
     permissions:
       actions: read
       contents: read
@@ -57,10 +31,16 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
         with:
           persist-credentials: false
 
+      - name: Check for file changes
+        id: check
+        uses: ./.github/actions/change-detector/
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
         uses: github/codeql-action/init@7211b7c8077ea37d8641b6271f6a365a22a5fbfa # v4
@@ -74,6 +54,7 @@ jobs:
           # queries: security-extended,security-and-quality
 
       - name: Perform CodeQL Analysis
+        if: steps.check.outputs.python || steps.check.outputs.frontend
         uses: github/codeql-action/analyze@7211b7c8077ea37d8641b6271f6a365a22a5fbfa # v4
         with:
           category: "/language:${{matrix.language}}"

.github/workflows/docker.yml

@@ -19,30 +19,8 @@ concurrency:
 
 jobs:
 
-  changes:
-    runs-on: ubuntu-24.04
-    timeout-minutes: 10
-    permissions:
-      contents: read
-      pull-requests: read
-    outputs:
-      python: ${{ steps.check.outputs.python }}
-      frontend: ${{ steps.check.outputs.frontend }}
-      docker: ${{ steps.check.outputs.docker }}
-    steps:
-      - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
-        with:
-          persist-credentials: false
-      - name: Check for file changes
-        id: check
-        uses: ./.github/actions/change-detector/
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
-
   setup_matrix:
     runs-on: ubuntu-24.04
-    timeout-minutes: 5
     outputs:
       matrix_config: ${{ steps.set_matrix.outputs.matrix_config }}
     steps:
@@ -54,13 +32,8 @@ jobs:
 
   docker-build:
     name: docker-build
-    needs: [setup_matrix, changes]
-    if: >-
-      needs.changes.outputs.python == 'true' ||
-      needs.changes.outputs.frontend == 'true' ||
-      needs.changes.outputs.docker == 'true'
+    needs: setup_matrix
     runs-on: ubuntu-24.04
-    timeout-minutes: 60
     strategy:
       matrix:
         build_preset: ${{fromJson(needs.setup_matrix.outputs.matrix_config)}}
@@ -77,7 +50,14 @@ jobs:
         with:
           persist-credentials: false
 
+      - name: Check for file changes
+        id: check
+        uses: ./.github/actions/change-detector/
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+
       - name: Setup Docker Environment
+        if: steps.check.outputs.python || steps.check.outputs.frontend || steps.check.outputs.docker
         uses: ./.github/actions/setup-docker
         with:
           dockerhub-user: ${{ secrets.DOCKERHUB_USER }}
@@ -85,9 +65,11 @@ jobs:
           build: "true"
 
       - name: Setup supersetbot
+        if: steps.check.outputs.python || steps.check.outputs.frontend || steps.check.outputs.docker
         uses: ./.github/actions/setup-supersetbot/
 
       - name: Build Docker Image
+        if: steps.check.outputs.python || steps.check.outputs.frontend || steps.check.outputs.docker
         shell: bash
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -113,7 +95,7 @@ jobs:
 
       # in the context of push (using multi-platform build), we need to pull the image locally
       - name: Docker pull
-        if: github.event_name == 'push'
+        if: github.event_name == 'push' && (steps.check.outputs.python || steps.check.outputs.frontend || steps.check.outputs.docker)
         run: |
           for i in 1 2 3; do
             docker pull $IMAGE_TAG && break
@@ -121,6 +103,7 @@ jobs:
           done
 
       - name: Print docker stats
+        if: steps.check.outputs.python || steps.check.outputs.frontend || steps.check.outputs.docker
         run: |
           echo "SHA: ${{ github.sha }}"
           echo "IMAGE: $IMAGE_TAG"
@@ -128,7 +111,7 @@ jobs:
           docker history $IMAGE_TAG
 
       - name: docker-compose sanity check
-        if: matrix.build_preset == 'dev'
+        if: (steps.check.outputs.python || steps.check.outputs.frontend || steps.check.outputs.docker) && matrix.build_preset == 'dev'
         shell: bash
         env:
           BUILD_PRESET: ${{ matrix.build_preset }}
@@ -141,16 +124,20 @@ jobs:
   docker-compose-image-tag:
     # Run this job only on pushes to master (not for PRs)
     # goal is to check that building the latest image works, not required for all PR pushes
-    needs: changes
-    if: github.event_name == 'push' && github.ref == 'refs/heads/master' && needs.changes.outputs.docker == 'true'
+    if: github.event_name == 'push' && github.ref == 'refs/heads/master'
     runs-on: ubuntu-24.04
-    timeout-minutes: 30
     steps:
       - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
         with:
           persist-credentials: false
+      - name: Check for file changes
+        id: check
+        uses: ./.github/actions/change-detector/
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
       - name: Setup Docker Environment
+        if: steps.check.outputs.docker
         uses: ./.github/actions/setup-docker
         with:
           dockerhub-user: ${{ secrets.DOCKERHUB_USER }}
@@ -158,6 +145,7 @@ jobs:
           build: "false"
           install-docker-compose: "true"
       - name: docker-compose sanity check
+        if: steps.check.outputs.docker
         shell: bash
         run: |
           docker compose -f docker-compose-image-tag.yml up superset-init --exit-code-from superset-init

.github/workflows/github-action-validator.yml

@@ -12,11 +12,6 @@ on:
 permissions:
   contents: read
 
-# cancel previous workflow jobs for PRs
-concurrency:
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
-  cancel-in-progress: true
-
 jobs:
 
   validate-all-ghas:

.github/workflows/labeler.yml

@@ -2,11 +2,6 @@ name: "Pull Request Labeler"
 on:
 - pull_request_target
 
-# cancel previous workflow jobs for PRs
-concurrency:
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
-  cancel-in-progress: true
-
 jobs:
   labeler:
     permissions:

.github/workflows/pr-lint.yml

@@ -8,11 +8,6 @@ on:
     # Possible values: https://help.github.com/en/actions/reference/events-that-trigger-workflows#pull-request-event-pull_request
     types: [opened, edited, reopened, synchronize]
 
-# cancel previous workflow jobs for PRs
-concurrency:
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
-  cancel-in-progress: true
-
 jobs:
   lint-check:
     runs-on: ubuntu-24.04

.github/workflows/pre-commit.yml

@@ -19,13 +19,9 @@ concurrency:
 jobs:
   pre-commit:
     runs-on: ubuntu-24.04
-    timeout-minutes: 20
     strategy:
       matrix:
-        # Run the full version spread on push (master/release) and nightly,
-        # but only the current version on PRs — lint/format/type results
-        # rarely differ across patch versions, so 3x per PR is wasteful.
-        python-version: ${{ github.event_name == 'pull_request' && fromJSON('["current"]') || fromJSON('["current", "previous", "next"]') }}
+        python-version: ["current", "previous", "next"]
     steps:
       - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
@@ -49,8 +45,6 @@ jobs:
         uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
         with:
           node-version: '20'
-          cache: 'npm'
-          cache-dependency-path: 'superset-frontend/package-lock.json'
 
       - name: Install Frontend Dependencies
         run: |

.github/workflows/superset-e2e.yml

@@ -29,7 +29,6 @@ concurrency:
 jobs:
   changes:
     runs-on: ubuntu-24.04
-    timeout-minutes: 10
     permissions:
       contents: read
       pull-requests: read
@@ -52,7 +51,6 @@ jobs:
     if: needs.changes.outputs.python == 'true' || needs.changes.outputs.frontend == 'true'
     # Somehow one test flakes on 24.04 for unknown reasons, this is the only GHA left on 22.04
     runs-on: ubuntu-22.04
-    timeout-minutes: 30
     permissions:
       contents: read
       pull-requests: read
@@ -63,14 +61,9 @@ jobs:
       # https://github.com/cypress-io/github-action/issues/48
       fail-fast: false
       matrix:
-        parallel_id: [0, 1]
+        parallel_id: [0, 1, 2, 3, 4, 5]
         browser: ["chrome"]
         app_root: ${{ github.event_name == 'push' && fromJSON('["", "/app/prefix"]') || fromJSON('[""]') }}
-        # The /app/prefix variant (push events only) is smoke-tested on a single
-        # shard rather than the full matrix, so exclude it from the other shards.
-        exclude:
-          - parallel_id: 1
-            app_root: "/app/prefix"
     env:
       SUPERSET_ENV: development
       SUPERSET_CONFIG: tests.integration_tests.superset_test_config
@@ -131,8 +124,6 @@ jobs:
         uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
         with:
           node-version-file: './superset-frontend/.nvmrc'
-          cache: 'npm'
-          cache-dependency-path: 'superset-frontend/package-lock.json'
       - name: Install npm dependencies
         uses: ./.github/actions/cached-dependencies
         with:
@@ -150,7 +141,7 @@ jobs:
         env:
           CYPRESS_BROWSER: ${{ matrix.browser }}
           PARALLEL_ID: ${{ matrix.parallel_id }}
-          PARALLELISM: 2
+          PARALLELISM: 6
           CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
           NODE_OPTIONS: "--max-old-space-size=4096"
         with:
@@ -174,7 +165,6 @@ jobs:
     needs: changes
     if: needs.changes.outputs.python == 'true' || needs.changes.outputs.frontend == 'true'
     runs-on: ubuntu-22.04
-    timeout-minutes: 30
     permissions:
       contents: read
       pull-requests: read
@@ -241,8 +231,6 @@ jobs:
         uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
         with:
           node-version-file: './superset-frontend/.nvmrc'
-          cache: 'npm'
-          cache-dependency-path: 'superset-frontend/package-lock.json'
       - name: Install npm dependencies
         uses: ./.github/actions/cached-dependencies
         with:
@@ -281,63 +269,3 @@ jobs:
             ${{ github.workspace }}/superset-frontend/playwright-results/
             ${{ github.workspace }}/superset-frontend/test-results/
           name: playwright-artifact-${{ github.run_id }}-${{ github.job }}-${{ matrix.browser }}--${{ steps.set-safe-app-root.outputs.safe_app_root }}
-
-  # Stable required-status-check anchors. cypress-matrix and playwright-tests
-  # are matrix jobs gated on change detection (python || frontend). On a PR
-  # that touches neither — e.g. a docs-only PR — they are skipped at the job
-  # level, which happens before matrix expansion, so the per-combination
-  # contexts (`cypress-matrix (0, chrome)`, `playwright-tests (chromium)`) are
-  # never produced and branch protection waits on them forever. These
-  # always-running jobs report a single stable context that passes when the
-  # underlying matrix job succeeded or was skipped, and fails only on a real
-  # failure. Require these in .asf.yaml instead of the matrix-expanded names.
-  #
-  # A matrix job reads as "skipped" in two distinct cases, and only the first
-  # is a legitimate pass: (a) change detection succeeded and gated the job off
-  # (docs-only PR); (b) the `changes` job itself failed or was cancelled, in
-  # which case GHA skips its dependents too. Accepting (b) would let a broken
-  # change-detector report a false green, so each anchor first requires
-  # `changes` to have succeeded before honouring a skip.
-  cypress-matrix-required:
-    needs: [changes, cypress-matrix]
-    if: always()
-    runs-on: ubuntu-24.04
-    timeout-minutes: 5
-    permissions: {}
-    steps:
-      - name: Check cypress-matrix result
-        env:
-          CHANGES: ${{ needs.changes.result }}
-          RESULT: ${{ needs.cypress-matrix.result }}
-        run: |
-          if [ "$CHANGES" != "success" ]; then
-            echo "change detection did not succeed (result: $CHANGES); refusing to pass on a skipped matrix"
-            exit 1
-          fi
-          if [ "$RESULT" != "success" ] && [ "$RESULT" != "skipped" ]; then
-            echo "cypress-matrix did not pass (result: $RESULT)"
-            exit 1
-          fi
-          echo "cypress-matrix result: $RESULT (changes: $CHANGES)"
-
-  playwright-tests-required:
-    needs: [changes, playwright-tests]
-    if: always()
-    runs-on: ubuntu-24.04
-    timeout-minutes: 5
-    permissions: {}
-    steps:
-      - name: Check playwright-tests result
-        env:
-          CHANGES: ${{ needs.changes.result }}
-          RESULT: ${{ needs.playwright-tests.result }}
-        run: |
-          if [ "$CHANGES" != "success" ]; then
-            echo "change detection did not succeed (result: $CHANGES); refusing to pass on a skipped matrix"
-            exit 1
-          fi
-          if [ "$RESULT" != "success" ] && [ "$RESULT" != "skipped" ]; then
-            echo "playwright-tests did not pass (result: $RESULT)"
-            exit 1
-          fi
-          echo "playwright-tests result: $RESULT (changes: $CHANGES)"

.github/workflows/superset-extensions-cli.yml

@@ -20,12 +20,9 @@ concurrency:
 jobs:
   test-superset-extensions-cli-package:
     runs-on: ubuntu-24.04
-    timeout-minutes: 30
     strategy:
       matrix:
-        # Full version spread on push (master/release) + nightly; current only
-        # on PRs to cut runner cost (cross-version breaks are caught at merge).
-        python-version: ${{ github.event_name == 'pull_request' && fromJSON('["current"]') || fromJSON('["previous", "current", "next"]') }}
+        python-version: ["previous", "current", "next"]
     defaults:
       run:
         working-directory: superset-extensions-cli

.github/workflows/superset-frontend.yml

@@ -22,7 +22,6 @@ permissions:
 jobs:
   frontend-build:
     runs-on: ubuntu-24.04
-    timeout-minutes: 30
     outputs:
       should-run: ${{ steps.check.outputs.frontend }}
     steps:
@@ -75,7 +74,6 @@ jobs:
         shard: [1, 2, 3, 4, 5, 6, 7, 8]
       fail-fast: false
     runs-on: ubuntu-24.04
-    timeout-minutes: 20
     steps:
       - name: Download Docker Image Artifact
         uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
@@ -105,7 +103,6 @@ jobs:
     needs: [sharded-jest-tests]
     if: needs.frontend-build.outputs.should-run == 'true'
     runs-on: ubuntu-24.04
-    timeout-minutes: 15
     permissions:
       id-token: write
     steps:
@@ -147,7 +144,6 @@ jobs:
     needs: frontend-build
     if: needs.frontend-build.outputs.should-run == 'true'
     runs-on: ubuntu-24.04
-    timeout-minutes: 20
     steps:
       - name: Download Docker Image Artifact
         uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
@@ -172,7 +168,6 @@ jobs:
     needs: frontend-build
     if: needs.frontend-build.outputs.should-run == 'true'
     runs-on: ubuntu-24.04
-    timeout-minutes: 20
     steps:
       - name: Download Docker Image Artifact
         uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
@@ -192,7 +187,6 @@ jobs:
     needs: frontend-build
     if: needs.frontend-build.outputs.should-run == 'true'
     runs-on: ubuntu-24.04
-    timeout-minutes: 25
     steps:
       - name: Download Docker Image Artifact
         uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8

.github/workflows/superset-playwright.yml

@@ -25,7 +25,6 @@ concurrency:
 jobs:
   changes:
     runs-on: ubuntu-24.04
-    timeout-minutes: 10
     permissions:
       contents: read
       pull-requests: read
@@ -49,7 +48,6 @@ jobs:
     needs: changes
     if: needs.changes.outputs.python == 'true' || needs.changes.outputs.frontend == 'true'
     runs-on: ubuntu-22.04
-    timeout-minutes: 30
     continue-on-error: true
     permissions:
       contents: read
@@ -117,8 +115,6 @@ jobs:
         uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
         with:
           node-version-file: './superset-frontend/.nvmrc'
-          cache: 'npm'
-          cache-dependency-path: 'superset-frontend/package-lock.json'
       - name: Install npm dependencies
         uses: ./.github/actions/cached-dependencies
         with:

.github/workflows/superset-python-integrationtest.yml

@@ -16,7 +16,6 @@ concurrency:
 jobs:
   changes:
     runs-on: ubuntu-24.04
-    timeout-minutes: 10
     permissions:
       contents: read
       pull-requests: read
@@ -37,7 +36,6 @@ jobs:
     needs: changes
     if: needs.changes.outputs.python == 'true'
     runs-on: ubuntu-24.04
-    timeout-minutes: 45
     permissions:
       id-token: write
     env:
@@ -51,6 +49,9 @@ jobs:
         image: mysql:8.0
         # Authenticated pulls use our higher Docker Hub rate limit. Empty on
         # fork PRs (secrets unavailable) -> runner falls back to anonymous.
+        credentials:
+          username: ${{ secrets.DOCKERHUB_USER }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
         env:
           MYSQL_ROOT_PASSWORD: root
         ports:
@@ -62,6 +63,9 @@ jobs:
           --health-retries=5
       redis:
         image: redis:7-alpine
+        credentials:
+          username: ${{ secrets.DOCKERHUB_USER }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
         options: --entrypoint redis-server
         ports:
           - 16379:6379
@@ -123,14 +127,11 @@ jobs:
     needs: changes
     if: needs.changes.outputs.python == 'true'
     runs-on: ubuntu-24.04
-    timeout-minutes: 45
     permissions:
       id-token: write
     strategy:
       matrix:
-        # Full version spread on push (master/release) + nightly; current only
-        # on PRs to cut runner cost (cross-version breaks are caught at merge).
-        python-version: ${{ github.event_name == 'pull_request' && fromJSON('["current"]') || fromJSON('["current", "previous", "next"]') }}
+        python-version: ["current", "previous", "next"]
     env:
       PYTHONPATH: ${{ github.workspace }}
       SUPERSET_CONFIG: tests.integration_tests.superset_test_config
@@ -139,6 +140,9 @@ jobs:
     services:
       postgres:
         image: postgres:17-alpine
+        credentials:
+          username: ${{ secrets.DOCKERHUB_USER }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
         env:
           POSTGRES_USER: superset
           POSTGRES_PASSWORD: superset
@@ -148,6 +152,9 @@ jobs:
           - 15432:5432
       redis:
         image: redis:7-alpine
+        credentials:
+          username: ${{ secrets.DOCKERHUB_USER }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
         ports:
           - 16379:6379
     steps:
@@ -184,7 +191,6 @@ jobs:
     needs: changes
     if: needs.changes.outputs.python == 'true'
     runs-on: ubuntu-24.04
-    timeout-minutes: 45
     permissions:
       id-token: write
     env:
@@ -198,6 +204,9 @@ jobs:
     services:
       redis:
         image: redis:7-alpine
+        credentials:
+          username: ${{ secrets.DOCKERHUB_USER }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
         ports:
           - 16379:6379
     steps:
@@ -228,25 +237,3 @@ jobs:
           verbose: true
           use_oidc: true
           slug: apache/superset
-
-  # Stable required-status-check anchor for the matrix-based test-postgres job.
-  # It is gated on change detection, so on non-Python PRs it is skipped and
-  # never produces its `test-postgres (current)` context (a job-level skip
-  # happens before matrix expansion). This always-running job reports a single
-  # context branch protection can require: it passes when test-postgres
-  # succeeded or was skipped, and fails only on a real failure.
-  test-postgres-required:
-    needs: [changes, test-postgres]
-    if: always()
-    runs-on: ubuntu-24.04
-    timeout-minutes: 5
-    steps:
-      - name: Check test-postgres result
-        env:
-          RESULT: ${{ needs.test-postgres.result }}
-        run: |
-          if [ "$RESULT" != "success" ] && [ "$RESULT" != "skipped" ]; then
-            echo "test-postgres did not pass (result: $RESULT)"
-            exit 1
-          fi
-          echo "test-postgres result: $RESULT"

.github/workflows/superset-python-presto-hive.yml

@@ -17,7 +17,6 @@ concurrency:
 jobs:
   changes:
     runs-on: ubuntu-24.04
-    timeout-minutes: 10
     permissions:
       contents: read
       pull-requests: read
@@ -38,7 +37,6 @@ jobs:
     needs: changes
     if: needs.changes.outputs.python == 'true'
     runs-on: ubuntu-24.04
-    timeout-minutes: 45
     permissions:
       id-token: write
     env:
@@ -101,7 +99,6 @@ jobs:
     needs: changes
     if: needs.changes.outputs.python == 'true'
     runs-on: ubuntu-24.04
-    timeout-minutes: 45
     permissions:
       id-token: write
     env:

.github/workflows/superset-python-unittest.yml

@@ -17,7 +17,6 @@ concurrency:
 jobs:
   changes:
     runs-on: ubuntu-24.04
-    timeout-minutes: 10
     permissions:
       contents: read
       pull-requests: read
@@ -38,14 +37,11 @@ jobs:
     needs: changes
     if: needs.changes.outputs.python == 'true'
     runs-on: ubuntu-24.04
-    timeout-minutes: 30
     permissions:
       id-token: write
     strategy:
       matrix:
-        # Full version spread on push (master/release) + nightly; current only
-        # on PRs to cut runner cost (cross-version breaks are caught at merge).
-        python-version: ${{ github.event_name == 'pull_request' && fromJSON('["current"]') || fromJSON('["previous", "current", "next"]') }}
+        python-version: ["previous", "current", "next"]
     env:
       PYTHONPATH: ${{ github.workspace }}
     steps:
@@ -78,25 +74,3 @@ jobs:
           verbose: true
           use_oidc: true
           slug: apache/superset
-
-  # Stable required-status-check anchor. `unit-tests` is a matrix job gated on
-  # change detection, so on non-Python PRs it is skipped and never produces its
-  # `unit-tests (current)` context (a job-level skip happens before matrix
-  # expansion). This always-running job reports a single context that branch
-  # protection can require: it passes when unit-tests succeeded or was skipped,
-  # and fails only on a real failure.
-  unit-tests-required:
-    needs: [changes, unit-tests]
-    if: always()
-    runs-on: ubuntu-24.04
-    timeout-minutes: 5
-    steps:
-      - name: Check unit-tests result
-        env:
-          RESULT: ${{ needs.unit-tests.result }}
-        run: |
-          if [ "$RESULT" != "success" ] && [ "$RESULT" != "skipped" ]; then
-            echo "unit-tests did not pass (result: $RESULT)"
-            exit 1
-          fi
-          echo "unit-tests result: $RESULT"

.github/workflows/superset-translations.yml

@@ -41,8 +41,6 @@ jobs:
         uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
         with:
           node-version-file:  './superset-frontend/.nvmrc'
-          cache: 'npm'
-          cache-dependency-path: 'superset-frontend/package-lock.json'
       - name: Install dependencies
         if: steps.check.outputs.frontend
         uses: ./.github/actions/cached-dependencies

.github/workflows/superset-websocket.yml

@@ -22,7 +22,6 @@ concurrency:
 jobs:
   app-checks:
     runs-on: ubuntu-24.04
-    timeout-minutes: 20
     steps:
       - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6

Dockerfile

@@ -55,13 +55,6 @@ WORKDIR /app/superset-frontend
 RUN mkdir -p /app/superset/static/assets \
              /app/superset/translations
 
-# Harden `npm ci` against transient npm-registry network blips (e.g. ECONNRESET),
-# which otherwise fail the entire multi-platform image build with no retry.
-ENV npm_config_fetch_retries=5 \
-    npm_config_fetch_retry_mintimeout=20000 \
-    npm_config_fetch_retry_maxtimeout=120000 \
-    npm_config_fetch_timeout=600000
-
 # Mount package files and install dependencies if not in dev mode
 # NOTE: we mount packages and plugins as they are referenced in package.json as workspaces
 # ideally we'd COPY only their package.json. Here npm ci will be cached as long

README.md

@@ -189,11 +189,6 @@ Try out Superset's [quickstart](https://superset.apache.org/docs/quickstart/) gu
 - [Join our community's Slack](http://bit.ly/join-superset-slack)
   and please read our [Slack Community Guidelines](https://github.com/apache/superset/blob/master/CODE_OF_CONDUCT.md#slack-community-guidelines)
 - [Join our dev@superset.apache.org Mailing list](https://lists.apache.org/list.html?dev@superset.apache.org). To join, simply send an email to [dev-subscribe@superset.apache.org](mailto:dev-subscribe@superset.apache.org)
-- Follow us on social media:
-  [X](https://x.com/apachesuperset) |
-  [LinkedIn](https://www.linkedin.com/company/apache-superset) |
-  [Bluesky](https://bsky.app/profile/apachesuperset.bsky.social) |
-  [Reddit](https://reddit.com/r/apache-superset)
 - If you want to help troubleshoot GitHub Issues involving the numerous database drivers that Superset supports, please consider adding your name and the databases you have access to on the [Superset Database Familiarity Rolodex](https://docs.google.com/spreadsheets/d/1U1qxiLvOX0kBTUGME1AHHi6Ywel6ECF8xk_Qy-V9R8c/edit#gid=0)
 - Join Superset's Town Hall and [Operational Model](https://preset.io/blog/the-superset-operational-model-wants-you/) recurring meetings. Meeting info is available on the [Superset Community Calendar](https://superset.apache.org/community)
 

UPDATING.md

@@ -24,16 +24,6 @@ assists people when migrating to a new version.
 
 ## Next
 
-### Duration formatter precision
-
-The `DURATION` number formatter now uses `Intl.DurationFormat` for locale-aware output. By default, sub-second fields are omitted, so values that previously displayed fractional seconds with `pretty-ms`, such as `10500` milliseconds rendering as `10.5s`, now render as `10s`.
-
-To preserve sub-second precision in custom duration formatters, enable `formatSubMilliseconds`.
-
-### Cache warmup authenticates via SUPERSET_CACHE_WARMUP_USER
-
-The `cache-warmup` Celery task now drives a real WebDriver session for reliable authentication and reads the user to authenticate as from the new `SUPERSET_CACHE_WARMUP_USER` config option. It no longer consults `CACHE_WARMUP_EXECUTORS` for the warmup path. `SUPERSET_CACHE_WARMUP_USER` defaults to `None`, so the task fails fast with a clear message until you set it. Operators who previously relied on `CACHE_WARMUP_EXECUTORS` for cache warmup must set `SUPERSET_CACHE_WARMUP_USER` to a dedicated least-privilege user with access to the dashboards they want warmed up before the next warmup run.
-
 ### YDB now uses a native sqlglot dialect
 
 YDB SQL parsing now relies on the dedicated [`ydb-sqlglot-plugin`](https://pypi.org/project/ydb-sqlglot-plugin/) dialect, which registers itself with sqlglot automatically. YDB users must install this plugin (e.g., via `pip install "apache-superset[ydb]"`) to avoid a `ValueError` when Superset parses YDB queries.
@@ -44,19 +34,19 @@ The embedded dashboard page now validates the origin of incoming `postMessage` e
 
 Enforcement only applies when the Allowed Domains list is non-empty. If the list is empty (the default), any origin is accepted, so there is no behavior change for embeds that did not configure Allowed Domains.
 
-### Default guest/async JWT secrets are rejected at startup
+### Opt-in SSH tunnel server host key verification
 
-Superset already refuses to start in production (non-debug, non-testing) when `SECRET_KEY` is left at its built-in default, and when `GUEST_TOKEN_JWT_SECRET` is left at its default while `EMBEDDED_SUPERSET` is enabled. This behavior is extended to `GLOBAL_ASYNC_QUERIES_JWT_SECRET`: if the `GLOBAL_ASYNC_QUERIES` feature flag is enabled and the secret is still the publicly known default (`test-secret-change-me`), Superset logs a clear error and refuses to start.
+SSH tunnels can now optionally pin the expected SSH server host key as a defense-in-depth measure against man-in-the-middle attacks. paramiko's transport performs no known-hosts checking by default, so previously the SSH server's identity was not verified. This feature is opt-in and off by default; existing tunnels are unaffected.
 
-As with the existing `SECRET_KEY` check, this only fails in production. In debug mode, testing mode, or under the test runner, a warning is logged instead of exiting, so local development is unaffected.
+- A new nullable `server_host_key` column on the `ssh_tunnels` table stores the expected host key in authorized-key form (e.g. `ssh-ed25519 AAAA...`). It is a public key and is stored in plaintext. It can be set via the SSH tunnel POST/PUT payloads (`ssh_tunnel.server_host_key`).
+- When a tunnel has `server_host_key` set, Superset connects to the SSH server, reads the host key it presents, and rejects the tunnel if it does not match.
+- A new config flag `SSH_TUNNEL_STRICT_HOST_KEY_CHECKING` (default `False`) controls fail-closed behavior. When `True`, every tunnel must declare a `server_host_key`; a tunnel without one is rejected.
 
-To resolve the error, set a strong random value in `superset_config.py`:
+Runbook to adopt:
 
-```python
-GLOBAL_ASYNC_QUERIES_JWT_SECRET = "<output of: openssl rand -base64 42>"
-```
-
-The check is only active when the relevant feature is enabled, so deployments that do not use global async queries (or embedding) are not affected.
+1. Capture the SSH server's host key, e.g. `ssh-keyscan -t ed25519 ssh.example.com` (verify it out-of-band).
+2. Set that value on the tunnel's `server_host_key` (via the database/SSH tunnel API or UI payload).
+3. Optionally set `SSH_TUNNEL_STRICT_HOST_KEY_CHECKING = True` in `superset_config.py` to require host-key verification on all tunnels.
 
 ### Dataset import validates catalog against the target connection
 
@@ -64,19 +54,6 @@ Importing a dataset now validates the `catalog` field against the target databas
 
 If you relied on importing datasets with a non-default catalog, enable "Allow changing catalogs" on the target connection, or set the dataset's catalog to the connection's default before importing.
 
-### Extension supply-chain controls (denylist + version policy)
-
-Two opt-in static gates control which extensions are allowed to load:
-
-- `EXTENSION_DENYLIST` refuses extensions matching an id (every version) or `id@version` (a single version), e.g. `["compromised-extension", "other-ext@1.2.3"]`.
-- `EXTENSION_VERSION_POLICY` enforces a minimum version per extension id, e.g. `{"acme.widget": "1.2.0"}` (PEP 440 comparison); a release below the minimum is refused.
-
-Both default to empty (no behavior change). They apply to both the `LOCAL_EXTENSIONS` and `EXTENSIONS_PATH` load paths.
-
-### Dynamic Group By respects the sort toggle for display values
-
-The Dynamic Group By chart customization now orders its display values according to the "Sort display control values" toggle: ascending (A–Z), descending (Z–A), or the dataset's source order when the toggle is unset. Previously the dropdown always sorted alphabetically. Existing dashboards where the toggle was never set will show options in source order instead of A–Z; open the customization and enable the toggle to restore alphabetical ordering.
-
 ### Granular Export Controls
 
 A new feature flag `GRANULAR_EXPORT_CONTROLS` introduces three fine-grained permissions that replace the legacy `can_csv` permission:

docker-compose.yml

@@ -61,31 +61,6 @@ services:
     volumes:
       - ./docker/nginx/nginx.conf:/etc/nginx/nginx.conf:ro
       - ./docker/nginx/templates:/etc/nginx/templates:ro
-    # Wait for the webpack dev server's manifest.json to be served before
-    # starting nginx. This prevents 404s on static assets at startup. The
-    # probe targets host.docker.internal so it works regardless of whether
-    # the dev server runs in the superset-node container
-    # (BUILD_SUPERSET_FRONTEND_IN_DOCKER=true, the default) or directly on
-    # the host (BUILD_SUPERSET_FRONTEND_IN_DOCKER=false).
-    command:
-      - /bin/bash
-      - -c
-      - |
-        url="http://host.docker.internal:9000/static/assets/manifest.json"
-        max_attempts=150  # ~5 minutes at 2s intervals
-        echo "Waiting for webpack dev server at $url..."
-        attempt=0
-        until curl -sf --max-time 5 -o /dev/null "$url"; do
-          attempt=$((attempt + 1))
-          if [ "$attempt" -ge "$max_attempts" ]; then
-            echo "ERROR: webpack dev server did not serve $url after $max_attempts attempts (~5 minutes)." >&2
-            echo "Is the dev server running? With BUILD_SUPERSET_FRONTEND_IN_DOCKER=false you must start it on the host (e.g. 'npm run dev' in superset-frontend)." >&2
-            exit 1
-          fi
-          sleep 2
-        done
-        echo "Webpack dev server is ready; starting nginx."
-        exec nginx -g 'daemon off;'
 
   redis:
     image: redis:7

docs/admin_docs/configuration/cache.mdx

@@ -86,39 +86,6 @@ instead requires a cachelib object.
 
 See [Async Queries via Celery](/admin-docs/configuration/async-queries-celery) for details.
 
-## Celery beat
-
-Superset has a Celery task that will periodically warm up the cache based on different strategies.
-To use it, add the following to your `superset_config.py`:
-
-```python
-from celery.schedules import crontab
-from superset.config import CeleryConfig
-
-# User that will be used to authenticate and render dashboards for cache warmup
-SUPERSET_CACHE_WARMUP_USER = "user_with_permission_to_dashboards"
-
-# Extend the default CeleryConfig to add cache warmup schedule
-class CustomCeleryConfig(CeleryConfig):
-    beat_schedule = {
-        **CeleryConfig.beat_schedule,
-        'cache-warmup-hourly': {
-            'task': 'cache-warmup',
-            'schedule': crontab(minute=0, hour='*'),  # hourly
-            'kwargs': {
-                'strategy_name': 'top_n_dashboards',
-                'top_n': 5,
-                'since': '7 days ago',
-            },
-        },
-    }
-
-CELERY_CONFIG = CustomCeleryConfig
-```
-
-This will cache the top 5 most popular dashboards every hour. For other
-strategies, check the `superset/tasks/cache.py` file.
-
 ## Caching Thumbnails
 
 This is an optional feature that can be turned on by activating its [feature flag](/admin-docs/configuration/configuring-superset#feature-flags) on config:

docs/docusaurus.config.ts

@@ -917,23 +917,6 @@ const config: Config = {
     footer: {
       links: [],
       copyright: `
-          <div class="footer__social-links">
-            <a href="https://bit.ly/join-superset-slack" target="_blank" rel="noopener noreferrer" title="Join us on Slack" aria-label="Slack">
-              <img src="/img/community/slack-symbol.svg" alt="Slack" />
-            </a>
-            <a href="https://x.com/apachesuperset" target="_blank" rel="noopener noreferrer" title="Follow us on X" aria-label="X">
-              <img src="/img/community/x-symbol.svg" alt="X" />
-            </a>
-            <a href="https://www.linkedin.com/company/apache-superset" target="_blank" rel="noopener noreferrer" title="Follow us on LinkedIn" aria-label="LinkedIn">
-              <img src="/img/community/linkedin-symbol.svg" alt="LinkedIn" />
-            </a>
-            <a href="https://bsky.app/profile/apachesuperset.bsky.social" target="_blank" rel="noopener noreferrer" title="Follow us on Bluesky" aria-label="Bluesky">
-              <img src="/img/community/bluesky-symbol.svg" alt="Bluesky" />
-            </a>
-            <a href="https://reddit.com/r/apache-superset" target="_blank" rel="noopener noreferrer" title="Follow us on Reddit" aria-label="Reddit">
-              <img src="/img/community/reddit-symbol.svg" alt="Reddit" />
-            </a>
-          </div>
           <div class="footer__ci-services">
             <span>CI powered by</span>
             <a href="https://www.netlify.com/" target="_blank" rel="nofollow noopener noreferrer"><img src="/img/netlify.png" alt="Netlify" title="Netlify - Deploy Previews" /></a>

docs/i18n/en/docusaurus-theme-classic/footer.json

@@ -1,6 +1,6 @@
 {
   "copyright": {
-    "message": "\n          <div class=\"footer__social-links\">\n            <a href=\"https://bit.ly/join-superset-slack\" target=\"_blank\" rel=\"noopener noreferrer\" title=\"Join us on Slack\" aria-label=\"Slack\">\n              <img src=\"/img/community/slack-symbol.svg\" alt=\"Slack\" />\n            </a>\n            <a href=\"https://x.com/apachesuperset\" target=\"_blank\" rel=\"noopener noreferrer\" title=\"Follow us on X\" aria-label=\"X\">\n              <img src=\"/img/community/x-symbol.svg\" alt=\"X\" />\n            </a>\n            <a href=\"https://www.linkedin.com/company/apache-superset\" target=\"_blank\" rel=\"noopener noreferrer\" title=\"Follow us on LinkedIn\" aria-label=\"LinkedIn\">\n              <img src=\"/img/community/linkedin-symbol.svg\" alt=\"LinkedIn\" />\n            </a>\n            <a href=\"https://bsky.app/profile/apachesuperset.bsky.social\" target=\"_blank\" rel=\"noopener noreferrer\" title=\"Follow us on Bluesky\" aria-label=\"Bluesky\">\n              <img src=\"/img/community/bluesky-symbol.svg\" alt=\"Bluesky\" />\n            </a>\n            <a href=\"https://reddit.com/r/apache-superset\" target=\"_blank\" rel=\"noopener noreferrer\" title=\"Follow us on Reddit\" aria-label=\"Reddit\">\n              <img src=\"/img/community/reddit-symbol.svg\" alt=\"Reddit\" />\n            </a>\n          </div>\n          <div class=\"footer__ci-services\">\n            <span>CI powered by</span>\n            <a href=\"https://www.netlify.com/\" target=\"_blank\" rel=\"nofollow noopener noreferrer\"><img src=\"/img/netlify.png\" alt=\"Netlify\" title=\"Netlify - Deploy Previews\" /></a>\n          </div>\n          <p>Copyright © 2026,\n          The <a href=\"https://www.apache.org/\" target=\"_blank\" rel=\"noreferrer\">Apache Software Foundation</a>,\n          Licensed under the Apache <a href=\"https://apache.org/licenses/LICENSE-2.0\" target=\"_blank\" rel=\"noreferrer\">License</a>.</p>\n          <p><small>Apache Superset, Apache, Superset, the Superset logo, and the Apache feather logo are either registered trademarks or trademarks of The Apache Software Foundation. All other products or name brands are trademarks of their respective holders, including The Apache Software Foundation.\n          <a href=\"https://www.apache.org/\" target=\"_blank\">Apache Software Foundation</a> resources</small></p>\n          <img class=\"footer__divider\" src=\"/img/community/line.png\" alt=\"Divider\" />\n          <p>\n            <small>\n              <a href=\"/admin-docs/security/\" target=\"_blank\" rel=\"noreferrer\">Security</a>&nbsp;|&nbsp;\n              <a href=\"https://www.apache.org/foundation/sponsorship.html\" target=\"_blank\" rel=\"noreferrer\">Donate</a>&nbsp;|&nbsp;\n              <a href=\"https://www.apache.org/foundation/thanks.html\" target=\"_blank\" rel=\"noreferrer\">Thanks</a>&nbsp;|&nbsp;\n              <a href=\"https://apache.org/events/current-event\" target=\"_blank\" rel=\"noreferrer\">Events</a>&nbsp;|&nbsp;\n              <a href=\"https://apache.org/licenses/\" target=\"_blank\" rel=\"noreferrer\">License</a>&nbsp;|&nbsp;\n              <a href=\"https://privacy.apache.org/policies/privacy-policy-public.html\" target=\"_blank\" rel=\"noreferrer\">Privacy</a>\n            </small>\n          </p>\n          <!-- telemetry/analytics pixel: -->\n          <img referrerPolicy=\"no-referrer-when-downgrade\" src=\"https://static.scarf.sh/a.png?x-pxid=39ae6855-95fc-4566-86e5-360d542b0a68\" />\n          ",
+    "message": "\n          <div class=\"footer__ci-services\">\n            <span>CI powered by</span>\n            <a href=\"https://www.netlify.com/\" target=\"_blank\" rel=\"nofollow noopener noreferrer\"><img src=\"/img/netlify.png\" alt=\"Netlify\" title=\"Netlify - Deploy Previews\" /></a>\n          </div>\n          <p>Copyright © 2026,\n          The <a href=\"https://www.apache.org/\" target=\"_blank\" rel=\"noreferrer\">Apache Software Foundation</a>,\n          Licensed under the Apache <a href=\"https://apache.org/licenses/LICENSE-2.0\" target=\"_blank\" rel=\"noreferrer\">License</a>.</p>\n          <p><small>Apache Superset, Apache, Superset, the Superset logo, and the Apache feather logo are either registered trademarks or trademarks of The Apache Software Foundation. All other products or name brands are trademarks of their respective holders, including The Apache Software Foundation.\n          <a href=\"https://www.apache.org/\" target=\"_blank\">Apache Software Foundation</a> resources</small></p>\n          <img class=\"footer__divider\" src=\"/img/community/line.png\" alt=\"Divider\" />\n          <p>\n            <small>\n              <a href=\"/docs/security/\" target=\"_blank\" rel=\"noreferrer\">Security</a>&nbsp;|&nbsp;\n              <a href=\"https://www.apache.org/foundation/sponsorship.html\" target=\"_blank\" rel=\"noreferrer\">Donate</a>&nbsp;|&nbsp;\n              <a href=\"https://www.apache.org/foundation/thanks.html\" target=\"_blank\" rel=\"noreferrer\">Thanks</a>&nbsp;|&nbsp;\n              <a href=\"https://apache.org/events/current-event\" target=\"_blank\" rel=\"noreferrer\">Events</a>&nbsp;|&nbsp;\n              <a href=\"https://apache.org/licenses/\" target=\"_blank\" rel=\"noreferrer\">License</a>&nbsp;|&nbsp;\n              <a href=\"https://privacy.apache.org/policies/privacy-policy-public.html\" target=\"_blank\" rel=\"noreferrer\">Privacy</a>\n            </small>\n          </p>\n          <!-- telemetry/analytics pixel: -->\n          <img referrerPolicy=\"no-referrer-when-downgrade\" src=\"https://static.scarf.sh/a.png?x-pxid=39ae6855-95fc-4566-86e5-360d542b0a68\" />\n          ",
     "description": "The footer copyright"
   }
 }

docs/package.json

@@ -43,7 +43,7 @@
     "version:remove:components": "node scripts/manage-versions.mjs remove components"
   },
   "dependencies": {
-    "@ant-design/icons": "^6.2.5",
+    "@ant-design/icons": "^6.2.3",
     "@docusaurus/core": "^3.10.1",
     "@docusaurus/faster": "^3.10.1",
     "@docusaurus/plugin-client-redirects": "^3.10.1",
@@ -72,11 +72,11 @@
     "@superset-ui/core": "^0.20.4",
     "@swc/core": "^1.15.40",
     "antd": "^6.4.3",
-    "baseline-browser-mapping": "^2.10.33",
+    "baseline-browser-mapping": "^2.10.32",
     "caniuse-lite": "^1.0.30001793",
     "docusaurus-plugin-openapi-docs": "^5.0.2",
     "docusaurus-theme-openapi-docs": "^5.0.2",
-    "js-yaml": "^4.2.0",
+    "js-yaml": "^4.1.1",
     "js-yaml-loader": "^1.2.2",
     "json-bigint": "^1.0.0",
     "prism-react-renderer": "^2.4.1",
@@ -104,7 +104,7 @@
     "@typescript-eslint/parser": "^8.60.0",
     "eslint": "^9.39.2",
     "eslint-config-prettier": "^10.1.8",
-    "eslint-plugin-prettier": "^5.5.6",
+    "eslint-plugin-prettier": "^5.5.5",
     "eslint-plugin-react": "^7.37.5",
     "globals": "^17.6.0",
     "prettier": "^3.8.3",

docs/src/styles/main.css

@@ -260,45 +260,10 @@ a > span > svg {
 
 .footer {
   position: relative;
-  padding-top: 130px;
+  padding-top: 90px;
   font-size: 15px;
 }
 
-.footer__social-links {
-  background-color: #173036;
-  position: absolute;
-  top: 52px;
-  left: 0;
-  width: 100%;
-  padding: 10px 0;
-  display: flex;
-  align-items: center;
-  justify-content: center;
-  gap: 24px;
-}
-
-.footer__social-links a {
-  display: inline-flex;
-  align-items: center;
-  transition: opacity 0.2s, transform 0.2s;
-}
-
-.footer__social-links a:hover {
-  opacity: 0.8;
-  transform: scale(1.1);
-}
-
-.footer__social-links img {
-  height: 24px;
-  width: 24px;
-  /* The brand SVGs ship in their native colors (e.g. Slack's dark aubergine,
-     X's near-black), which disappear on the dark footer. Render them all as
-     uniform white silhouettes. The icons are single-path glyphs whose
-     counters (the LinkedIn "in", Slack gaps, Reddit face) are transparent
-     cut-outs, so they stay legible against the footer background. */
-  filter: brightness(0) invert(1);
-}
-
 .footer__ci-services {
   background-color: #0d3e49;
   color: #e1e1e1;
@@ -344,21 +309,6 @@ a > span > svg {
 }
 
 @media only screen and (max-width: 996px) {
-  .footer {
-    padding-top: 120px;
-  }
-
-  .footer__social-links {
-    top: 44px;
-    gap: 20px;
-    padding: 8px 16px;
-  }
-
-  .footer__social-links img {
-    height: 20px;
-    width: 20px;
-  }
-
   .footer__ci-services {
     gap: 12px;
     padding: 10px 16px;

docs/static/img/community/reddit-symbol.svg

@@ -1,21 +0,0 @@
-<!--
-  Licensed to the Apache Software Foundation (ASF) under one
-  or more contributor license agreements.  See the NOTICE file
-  distributed with this work for additional information
-  regarding copyright ownership.  The ASF licenses this file
-  to you under the Apache License, Version 2.0 (the
-  "License"); you may not use this file except in compliance
-  with the License.  You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing,
-  software distributed under the License is distributed on an
-  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-  KIND, either express or implied.  See the License for the
-  specific language governing permissions and limitations
-  under the License.
--->
-<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" width="40" height="40" fill="#FF4500">
-  <path d="M12 0A12 12 0 0 0 0 12a12 12 0 0 0 12 12 12 12 0 0 0 12-12A12 12 0 0 0 12 0zm5.01 4.744c.688 0 1.25.561 1.25 1.249a1.25 1.25 0 0 1-2.498.056l-2.597-.547-.8 3.747c1.824.07 3.48.632 4.674 1.488.308-.309.73-.491 1.207-.491.968 0 1.754.786 1.754 1.754 0 .716-.435 1.333-1.01 1.614a3.111 3.111 0 0 1 .042.52c0 2.694-3.13 4.87-7.004 4.87-3.874 0-7.004-2.176-7.004-4.87 0-.183.015-.366.043-.534A1.748 1.748 0 0 1 4.028 12c0-.968.786-1.754 1.754-1.754.463 0 .898.196 1.207.49 1.207-.883 2.878-1.43 4.744-1.487l.885-4.182a.342.342 0 0 1 .14-.197.35.35 0 0 1 .238-.042l2.906.617a1.214 1.214 0 0 1 1.108-.701zM9.25 12c-.688 0-1.25.561-1.25 1.25 0 .687.562 1.248 1.25 1.248.687 0 1.248-.561 1.248-1.249 0-.688-.561-1.249-1.249-1.249zm5.5 0c-.687 0-1.248.561-1.248 1.25 0 .687.561 1.248 1.249 1.248.688 0 1.249-.561 1.249-1.249 0-.687-.562-1.249-1.25-1.249zm-5.466 3.99a.327.327 0 0 0-.231.094.33.33 0 0 0 0 .463c.842.842 2.484.913 2.961.913.477 0 2.105-.056 2.961-.913a.361.361 0 0 0 .029-.463.33.33 0 0 0-.464 0c-.547.533-1.684.73-2.512.73-.828 0-1.979-.196-2.512-.73a.326.326 0 0 0-.232-.095z"/>
-</svg>

docs/static/img/community/slack-symbol.svg

@@ -1,21 +0,0 @@
-<!--
-  Licensed to the Apache Software Foundation (ASF) under one
-  or more contributor license agreements.  See the NOTICE file
-  distributed with this work for additional information
-  regarding copyright ownership.  The ASF licenses this file
-  to you under the Apache License, Version 2.0 (the
-  "License"); you may not use this file except in compliance
-  with the License.  You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing,
-  software distributed under the License is distributed on an
-  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-  KIND, either express or implied.  See the License for the
-  specific language governing permissions and limitations
-  under the License.
--->
-<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" width="40" height="40" fill="#4A154B">
-  <path d="M5.042 15.165a2.528 2.528 0 0 1-2.52 2.523A2.528 2.528 0 0 1 0 15.165a2.527 2.527 0 0 1 2.522-2.52h2.52v2.52zm1.271 0a2.527 2.527 0 0 1 2.521-2.52 2.527 2.527 0 0 1 2.521 2.52v6.313A2.528 2.528 0 0 1 8.834 24a2.528 2.528 0 0 1-2.521-2.522v-6.313zM8.834 5.042a2.528 2.528 0 0 1-2.521-2.52A2.528 2.528 0 0 1 8.834 0a2.528 2.528 0 0 1 2.521 2.522v2.52H8.834zm0 1.271a2.528 2.528 0 0 1 2.521 2.521 2.528 2.528 0 0 1-2.521 2.521H2.522A2.528 2.528 0 0 1 0 8.834a2.528 2.528 0 0 1 2.522-2.521h6.312zm10.124 2.521a2.528 2.528 0 0 1 2.522-2.521A2.528 2.528 0 0 1 24 8.834a2.528 2.528 0 0 1-2.52 2.521h-2.522V8.834zm-1.271 0a2.528 2.528 0 0 1-2.521 2.521 2.528 2.528 0 0 1-2.521-2.521V2.522A2.528 2.528 0 0 1 15.166 0a2.528 2.528 0 0 1 2.521 2.522v6.312zm-2.521 10.124a2.528 2.528 0 0 1 2.521 2.522A2.528 2.528 0 0 1 15.166 24a2.528 2.528 0 0 1-2.521-2.52v-2.522h2.521zm0-1.271a2.528 2.528 0 0 1-2.521-2.521 2.528 2.528 0 0 1 2.521-2.521h6.312A2.528 2.528 0 0 1 24 15.165a2.528 2.528 0 0 1-2.52 2.521h-6.313z"/>
-</svg>

docs/yarn.lock

@@ -212,14 +212,14 @@
   resolved "https://registry.npmjs.org/@ant-design/icons-svg/-/icons-svg-4.4.2.tgz"
   integrity sha512-vHbT+zJEVzllwP+CM+ul7reTEfBR0vgxFe7+lREAsAA7YGsYpboiq2sQNeQeRvh09GfQgs/GyFEvZpJ9cLXpXA==
 
-"@ant-design/icons@^6.2.3", "@ant-design/icons@^6.2.5":
-  version "6.2.5"
-  resolved "https://registry.yarnpkg.com/@ant-design/icons/-/icons-6.2.5.tgz#31c142aa6ce5eaf99598aaead222f4c459693512"
-  integrity sha512-0hKtoKqTjGFOndUyJLJmC9Cg6k4rEO7rLo6xmgbNJH+/ZX1C57RVals2v1j1knHl9n7Q+sBOveTvn931wLOCKw==
+"@ant-design/icons@^6.2.3":
+  version "6.2.3"
+  resolved "https://registry.yarnpkg.com/@ant-design/icons/-/icons-6.2.3.tgz#66e1c7fdea009b9c3fab6964062bedc76f308ad8"
+  integrity sha512-Pl3aoAtxQeKryYnt6VvDJtOxMOtA8wrRSACe/pTjOAIG3fdHrWm6Ivb4ku9tsFjYroSXBKirvuxG4QkwBXD9gg==
   dependencies:
     "@ant-design/colors" "^8.0.1"
     "@ant-design/icons-svg" "^4.4.2"
-    "@rc-component/util" "^1.11.0"
+    "@rc-component/util" "^1.10.1"
     clsx "^2.1.1"
 
 "@ant-design/react-slick@~2.0.0":
@@ -3021,10 +3021,10 @@
     os-homedir "^1.0.1"
     regexpu-core "^4.5.4"
 
-"@pkgr/core@^0.3.6":
-  version "0.3.6"
-  resolved "https://registry.yarnpkg.com/@pkgr/core/-/core-0.3.6.tgz#3569708bd4be4d8870ba32bf1c456dac81600d97"
-  integrity sha512-SEeaJLb3qBNF/OaXnaR1NmmBbFYk1zC0ZH/52fATcRPLFg/p791YrcyFFy44Bo9sLaGuSuLp5Q6axbb/O+v/RA==
+"@pkgr/core@^0.2.9":
+  version "0.2.9"
+  resolved "https://registry.npmjs.org/@pkgr/core/-/core-0.2.9.tgz"
+  integrity sha512-QNqXyfVS2wm9hweSYD2O7F0G06uurj9kZ96TRQE5Y9hU7+tgdZwIkbAKc5Ocy1HxEY2kuDQa6cQ1WRs/O5LFKA==
 
 "@pnpm/config.env-replace@^1.1.0":
   version "1.1.0"
@@ -5578,10 +5578,10 @@ base64-js@^1.3.1, base64-js@^1.5.1:
   resolved "https://registry.npmjs.org/base64-js/-/base64-js-1.5.1.tgz"
   integrity sha512-AKpaYlHn8t4SVbOHCy+b5+KKgvR4vrsD8vbvrbiQJps7fKDTkjkDry6ji0rUJjC0kzbNePLwzxq8iypo41qeWA==
 
-baseline-browser-mapping@^2.10.33, baseline-browser-mapping@^2.9.0, baseline-browser-mapping@^2.9.19:
-  version "2.10.33"
-  resolved "https://registry.yarnpkg.com/baseline-browser-mapping/-/baseline-browser-mapping-2.10.33.tgz#27c299b096404978831958d429f48390424c4f9b"
-  integrity sha512-bA6+tcSLpz2tIEdDXZPpPTIuxBcC4+w6SieaYyfigIa4h8GlFxbA17v22Vx3JUtuZQj9SgOsnbK+aTBzyDyEuw==
+baseline-browser-mapping@^2.10.32, baseline-browser-mapping@^2.9.0, baseline-browser-mapping@^2.9.19:
+  version "2.10.32"
+  resolved "https://registry.yarnpkg.com/baseline-browser-mapping/-/baseline-browser-mapping-2.10.32.tgz#b6b553a4285fdd606327a617de36a5351e3aaa64"
+  integrity sha512-wbPvpyjJPC0zdfdKXxqEL3Ea+bOMD/87X4lftiJkkaBiuG6ALQy1SLmEd7BSmVCuwCQsBrCamgBoLyfFDD1EPg==
 
 batch@0.6.1:
   version "0.6.1"
@@ -7522,13 +7522,13 @@ eslint-config-prettier@^10.1.8:
   resolved "https://registry.npmjs.org/eslint-config-prettier/-/eslint-config-prettier-10.1.8.tgz"
   integrity sha512-82GZUjRS0p/jganf6q1rEO25VSoHH0hKPCTrgillPjdI/3bgBhAE1QzHrHTizjpRvy6pGAvKjDJtk2pF9NDq8w==
 
-eslint-plugin-prettier@^5.5.6:
-  version "5.5.6"
-  resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-5.5.6.tgz#363ebe4d769bce157ccdd8129ce3efd91dc62564"
-  integrity sha512-ifetmTcxWfz+4qRW3pH/ujdTq2jQIj59AxJMIN26K5avYgU8dxycUETQonWiW+wPrYXA0j3Try0l1CnwVQtDqQ==
+eslint-plugin-prettier@^5.5.5:
+  version "5.5.5"
+  resolved "https://registry.npmjs.org/eslint-plugin-prettier/-/eslint-plugin-prettier-5.5.5.tgz"
+  integrity sha512-hscXkbqUZ2sPithAuLm5MXL+Wph+U7wHngPBv9OMWwlP8iaflyxpjTYZkmdgB4/vPIhemRlBEoLrH7UC1n7aUw==
   dependencies:
     prettier-linter-helpers "^1.0.1"
-    synckit "^0.11.13"
+    synckit "^0.11.12"
 
 eslint-plugin-react@^7.37.5:
   version "7.37.5"
@@ -9341,7 +9341,7 @@ js-yaml@4.1.0:
   dependencies:
     argparse "^2.0.1"
 
-js-yaml@=4.1.1:
+js-yaml@=4.1.1, js-yaml@^4.1.0, js-yaml@^4.1.1:
   version "4.1.1"
   resolved "https://registry.yarnpkg.com/js-yaml/-/js-yaml-4.1.1.tgz#854c292467705b699476e1a2decc0c8a3458806b"
   integrity sha512-qQKT4zQxXl8lLwBtHMWwaTcGfFOZviOJet3Oy/xmGk2gZH677CJM9EvtfdSkgWcATZhj/55JZ0rmy3myCT5lsA==
@@ -9356,13 +9356,6 @@ js-yaml@^3.13.1:
     argparse "^1.0.7"
     esprima "^4.0.0"
 
-js-yaml@^4.1.0, js-yaml@^4.1.1, js-yaml@^4.2.0:
-  version "4.2.0"
-  resolved "https://registry.yarnpkg.com/js-yaml/-/js-yaml-4.2.0.tgz#2bd9e85682dd91bd469afb809d816043b3d49524"
-  integrity sha512-ePWsvanv0DWuDRsW8dnt+R4jQ31SCRCQ7hhNcPXZPsoBZiemuZNYGf7adZdqX2D86j6rvKp3RpCxVTSb8WQlOw==
-  dependencies:
-    argparse "^2.0.1"
-
 jsdoc-type-pratt-parser@^4.0.0:
   version "4.8.0"
   resolved "https://registry.npmjs.org/jsdoc-type-pratt-parser/-/jsdoc-type-pratt-parser-4.8.0.tgz"
@@ -14103,12 +14096,12 @@ swc-loader@^0.2.6, swc-loader@^0.2.7:
   dependencies:
     "@swc/counter" "^0.1.3"
 
-synckit@^0.11.13:
-  version "0.11.13"
-  resolved "https://registry.yarnpkg.com/synckit/-/synckit-0.11.13.tgz#062a5ea57d81befc35892f8254de5c567e97c80a"
-  integrity sha512-eNRKgb3z66Yp3D2CixVujOUvXLFUTij/zVnV8KRyvFdQwpz7I5DS8UfRkTeLzb64u+dkzDSdelE24izu+zSSUg==
+synckit@^0.11.12:
+  version "0.11.12"
+  resolved "https://registry.npmjs.org/synckit/-/synckit-0.11.12.tgz"
+  integrity sha512-Bh7QjT8/SuKUIfObSXNHNSK6WHo6J1tHCqJsuaFDP7gP0fkzSfTxI8y85JrppZ0h8l0maIgc2tfuZQ6/t3GtnQ==
   dependencies:
-    "@pkgr/core" "^0.3.6"
+    "@pkgr/core" "^0.2.9"
 
 tapable@^2.0.0, tapable@^2.2.1, tapable@^2.3.0, tapable@^2.3.3:
   version "2.3.3"

pyproject.toml

@@ -109,7 +109,7 @@ dependencies = [
     "watchdog>=6.0.0",
     "wtforms>=2.3.3, <4",
     "wtforms-json",
-    "xlsxwriter>=3.2.9, <3.3",
+    "xlsxwriter>=3.0.7, <3.3",
 ]
 
 [project.optional-dependencies]
@@ -154,7 +154,7 @@ fastmcp = [
 ]
 firebird = ["sqlalchemy-firebird>=0.7.0, <2.2"]
 firebolt = ["firebolt-sqlalchemy>=1.0.0, <2"]
-gevent = ["gevent>=26.4.0"]
+gevent = ["gevent>=23.9.1"]
 gsheets = ["shillelagh[gsheetsapi]>=1.4.4, <2"]
 hana = ["hdbcli==2.28.20", "sqlalchemy_hana==0.4.0"]
 hive = [
@@ -165,7 +165,7 @@ hive = [
     "thrift_sasl>=0.4.3, < 1.0.0",
 ]
 impala = ["impyla>0.16.2, <0.23"]
-kusto = ["sqlalchemy-kusto>=3.1.2, <4"]
+kusto = ["sqlalchemy-kusto>=3.0.0, <4"]
 kylin = ["kylinpy>=2.8.1, <2.9"]
 mssql = ["pymssql>=2.2.8, <3"]
 # motherduck is an alias for duckdb - MotherDuck works via the duckdb driver
@@ -180,7 +180,7 @@ ocient = [
 oracle = ["cx-Oracle>8.0.0, <8.4"]
 parseable = ["sqlalchemy-parseable>=0.1.3,<0.2.0"]
 pinot = ["pinotdb>=5.0.0, <10.0.0"]
-playwright = ["playwright>=1.60.0, <2"]
+playwright = ["playwright>=1.37.0, <2"]
 postgres = ["psycopg2-binary==2.9.12"]
 presto = ["pyhive[presto]>=0.6.5"]
 trino = ["trino>=0.328.0"]
@@ -199,15 +199,15 @@ spark = [
 ]
 tdengine = [
     "taospy>=2.7.21",
-    "taos-ws-py>=0.6.9"
+    "taos-ws-py>=0.3.8"
 ]
 teradata = ["teradatasql>=16.20.0.23"]
 thumbnails = [] # deprecated, will be removed in 7.0
-vertica = ["sqlalchemy-vertica-python>= 0.6.3, < 0.7"]
+vertica = ["sqlalchemy-vertica-python>= 0.5.9, < 0.7"]
 netezza = ["nzalchemy>=11.0.2"]
 starrocks = ["starrocks>=1.0.0"]
 doris = ["pydoris>=1.0.0, <2.0.0"]
-oceanbase = ["oceanbase_py>=0.0.1.2"]
+oceanbase = ["oceanbase_py>=0.0.1"]
 ydb = ["ydb-sqlalchemy>=0.1.2", "ydb-sqlglot-plugin>=0.2.5"]
 development = [
     # no bounds for apache-superset-extensions-cli until a stable version
@@ -231,7 +231,7 @@ development = [
     "pytest-asyncio",
     "pytest-cov",
     "pytest-mock",
-    "python-ldap>=3.4.7",
+    "python-ldap>=3.4.4",
     "ruff",
     "sqloxide",
     "statsd",
@@ -456,7 +456,6 @@ authorized_licenses = [
     "isc license (iscl)",
     "isc license",
     "mit",
-    "mit and psf-2.0",
     "mit-cmu",
     "mozilla public license 2.0 (mpl 2.0)",
     "osi approved",

requirements/base.txt

@@ -161,7 +161,7 @@ geopy==2.4.1
     # via apache-superset (pyproject.toml)
 google-auth==2.43.0
     # via shillelagh
-greenlet==3.5.0
+greenlet==3.1.1
     # via
     #   apache-superset (pyproject.toml)
     #   shillelagh
@@ -490,7 +490,7 @@ wtforms-json==0.3.5
     # via apache-superset (pyproject.toml)
 xlrd==2.0.1
     # via pandas
-xlsxwriter==3.2.9
+xlsxwriter==3.0.9
     # via
     #   apache-superset (pyproject.toml)
     #   pandas

requirements/development.txt

@@ -331,7 +331,7 @@ geopy==2.4.1
     # via
     #   -c requirements/base-constraint.txt
     #   apache-superset
-gevent==26.4.0
+gevent==24.2.1
     # via apache-superset
 google-api-core==2.23.0
     # via
@@ -373,7 +373,7 @@ googleapis-common-protos==1.66.0
     # via
     #   google-api-core
     #   grpcio-status
-greenlet==3.5.0
+greenlet==3.1.1
     # via
     #   -c requirements/base-constraint.txt
     #   apache-superset
@@ -838,7 +838,7 @@ python-dotenv==1.2.2
     #   apache-superset
     #   fastmcp
     #   pydantic-settings
-python-ldap==3.4.7
+python-ldap==3.4.5
     # via apache-superset
 python-multipart==0.0.29
     # via mcp
@@ -1140,7 +1140,7 @@ xlrd==2.0.1
     # via
     #   -c requirements/base-constraint.txt
     #   pandas
-xlsxwriter==3.2.9
+xlsxwriter==3.0.9
     # via
     #   -c requirements/base-constraint.txt
     #   apache-superset

scripts/translations/check_translation_regression.py

@@ -18,31 +18,14 @@
 """
 Check that source-code changes don't cause translation regressions.
 
-What counts as a regression
----------------------------
-A regression is an *existing translation that a source change invalidated* —
-i.e. a string was renamed/reworded so its committed translation no longer
-applies. ``babel_update.sh`` (``pybabel update --ignore-obsolete``) surfaces
-exactly these as **newly fuzzy** entries: the old translation is fuzzy-matched
-onto the new ``msgid`` and flagged ``#, fuzzy``.
-
-Crucially, *deleting* a translatable string is **not** a regression. With
-``--ignore-obsolete`` a removed string is dropped from the catalogs entirely;
-no fuzzy entry is created. So a PR that intentionally removes a string (e.g. a
-security fix that stops rendering a value) legitimately lowers the translated
-count without introducing any fuzzies, and must not be flagged. We therefore
-key the check on the **increase in fuzzy entries**, not on a drop in the
-translated count (a drop happens identically for a benign deletion and a real
-rename, so it cannot distinguish the two).
-
 Usage
 -----
-Count translated + fuzzy entries in all .po files and write JSON to stdout:
+Count non-fuzzy translated entries in all .po files and write JSON to stdout:
 
     python check_translation_regression.py --count
 
 Compare the current .po state against a previously-recorded baseline and fail
-if a source change invalidated existing translations (new fuzzies):
+if any language lost translations:
 
     python check_translation_regression.py --compare /path/to/before.json
 
@@ -67,8 +50,8 @@ Typical CI workflow
 
 Running babel_update on the base branch first isolates regressions caused by
 the PR's source diff from any pre-existing drift on the base branch, while the
-PR worktree run still allows committed .po updates to resolve the fuzzies (and
-thus clear the regression) before merging.
+PR worktree run still allows committed .po updates to restore lost
+translations.
 """
 
 import argparse
@@ -88,13 +71,8 @@ DEFAULT_TRANSLATIONS_DIR = (
 SKIP_LANGS = {"en"}
 
 
-def count_stats(po_file: Path) -> dict[str, int]:
-    """Return ``{"translated": int, "fuzzy": int}`` for a .po file.
-
-    ``translated`` is the number of non-fuzzy translated messages; ``fuzzy`` is
-    the number of fuzzy translations. The fuzzy count is what the regression
-    check keys on — a source rename invalidates an existing translation by
-    making it fuzzy, whereas a deletion simply drops it (``--ignore-obsolete``).
+def count_translated(po_file: Path) -> int:
+    """Return the number of non-fuzzy translated messages in a .po file.
 
     Raises:
         subprocess.CalledProcessError: if ``msgfmt`` fails (e.g. malformed
@@ -112,50 +90,29 @@ def count_stats(po_file: Path) -> dict[str, int]:
         check=True,
     )
     # stderr: "123 translated messages, 4 fuzzy translations, 56 untranslated messages."
-    # The fuzzy and untranslated clauses are omitted by msgfmt when they are 0.
-    translated_match = re.search(r"(\d+) translated message", result.stderr)
-    if not translated_match:
+    match = re.search(r"(\d+) translated message", result.stderr)
+    if not match:
         raise RuntimeError(
             f"Could not parse msgfmt --statistics output for {po_file}: "
             f"{result.stderr!r}"
         )
-    fuzzy_match = re.search(r"(\d+) fuzzy translation", result.stderr)
-    return {
-        "translated": int(translated_match.group(1)),
-        "fuzzy": int(fuzzy_match.group(1)) if fuzzy_match else 0,
-    }
+    return int(match.group(1))
 
 
-def get_counts(
-    translations_dir: Path,
-    failures: Optional[set[str]] = None,
-) -> dict[str, dict[str, int]]:
-    """Count translated/fuzzy entries for every ``.po`` file in a directory.
-
-    If ``failures`` is provided, the name of each language whose ``.po`` file
-    is present on disk but could not be counted (msgfmt non-zero exit, or
-    unparseable output) is added to it. Such a language is deliberately absent
-    from the returned mapping — but, unlike a language whose catalog was simply
-    deleted, it must not be mistaken for an intentional removal: a caller that
-    cares about the distinction (see :func:`cmd_compare`) can inspect
-    ``failures`` and treat it as a hard error.
-    """
-    counts: dict[str, dict[str, int]] = {}
+def get_counts(translations_dir: Path) -> dict[str, int]:
+    counts: dict[str, int] = {}
     for po_file in sorted(translations_dir.glob("*/LC_MESSAGES/messages.po")):
         lang = po_file.parent.parent.name
         if lang in SKIP_LANGS:
             continue
         try:
-            counts[lang] = count_stats(po_file)
+            counts[lang] = count_translated(po_file)
         except (subprocess.CalledProcessError, RuntimeError) as exc:
             # A malformed .po file (msgfmt non-zero exit, or stderr we
             # can't parse) is a real problem worth seeing, but it shouldn't
             # take the whole regression check down with it — that would
-            # hide every other language's status. Skip and warn here; the
-            # caller is told which langs failed via ``failures`` so it can
-            # decide whether a present-but-uncountable catalog is fatal.
-            if failures is not None:
-                failures.add(lang)
+            # hide every other language's status. Skip and warn instead;
+            # the missing lang will not appear in the comparison output.
             print(
                 f"WARNING: skipping {lang} — {po_file} could not be counted: {exc}",
                 file=sys.stderr,
@@ -163,42 +120,18 @@ def get_counts(
     return counts
 
 
-def _normalize(entry: object) -> dict[str, int]:
-    """Coerce a baseline entry into ``{"translated", "fuzzy"}``.
-
-    Tolerates the legacy baseline format where each language mapped directly to
-    an integer translated count (no fuzzy data); such entries contribute a
-    fuzzy baseline of 0.
-    """
-    if isinstance(entry, dict):
-        return {
-            "translated": int(entry.get("translated", 0)),
-            "fuzzy": int(entry.get("fuzzy", 0)),
-        }
-    if isinstance(entry, int):
-        return {"translated": entry, "fuzzy": 0}
-    raise TypeError(f"Unsupported baseline entry: {entry!r}")
-
-
 def build_regression_report(regressions: list[tuple[str, int, int]]) -> str:
-    """Build a markdown report for posting as a PR comment.
-
-    Each regression tuple is ``(lang, before_fuzzy, after_fuzzy)``.
-    """
+    """Build a markdown report for posting as a PR comment."""
     rows = "\n".join(
-        f"| `{lang}` | {b} | {a} | +{a - b} |" for lang, b, a in regressions
+        f"| `{lang}` | {b} | {a} | -{b - a} |" for lang, b, a in regressions
     )
     affected = ", ".join(f"`{lang}`" for lang, _, _ in regressions)
     return (
         "## ⚠️ Translation Regression Detected\n\n"
-        f"A source change in this PR renamed or reworded strings, invalidating "
-        f"existing translations (they are now `#, fuzzy`) in {affected}. Please "
-        f"resolve the affected `.po` files before merging.\n\n"
-        "_Note: intentionally **deleting** a translatable string is not a "
-        "regression and is not flagged here — only translations invalidated by "
-        "a renamed/reworded source string are._\n\n"
-        "| Language | Fuzzy before | Fuzzy after | New |\n"
-        "|----------|-------------:|------------:|----:|\n"
+        f"This PR causes existing translations to become fuzzy or be removed "
+        f"in {affected}. Please fix the affected `.po` files before merging.\n\n"
+        "| Language | Before | After | Lost |\n"
+        "|----------|-------:|------:|-----:|\n"
         f"{rows}\n\n"
         "### How to fix\n\n"
         "**1. Install dependencies** (if not already set up):\n\n"
@@ -236,49 +169,26 @@ def cmd_compare(
     report_path: Optional[str] = None,
 ) -> None:
     with open(before_path) as f:
-        before_raw: dict[str, object] = json.load(f)
-    before = {lang: _normalize(entry) for lang, entry in before_raw.items()}
+        before: dict[str, int] = json.load(f)
 
-    failures: set[str] = set()
-    after = get_counts(translations_dir, failures=failures)
+    after = get_counts(translations_dir)
 
-    # A baseline language whose catalog is *missing* from `after` is fine —
-    # that's an intentional catalog deletion (handled below like any other
-    # deletion). But a language whose .po file is still present yet could not
-    # be counted (msgfmt failed / output unparseable) is a hard error: leaving
-    # it out silently would let a corrupt catalog pass as "no regression".
-    broken = sorted(lang for lang in failures if lang in before)
-    if broken:
-        print("Translation check failed!\n")
-        for lang in broken:
-            print(f"  {lang}: catalog present but could not be counted (msgfmt error)")
-        print(
-            "\nFix the malformed .po file(s) above before merging — a catalog "
-            "that cannot be parsed must not be silently dropped."
-        )
-        sys.exit(1)
-
-    # A regression is an *increase* in fuzzy entries: the PR's source diff
-    # renamed/reworded strings, leaving their committed translations stranded.
-    # A plain drop in the translated count is NOT used — deleting a string
-    # lowers it identically to a rename but is a legitimate change, and with
-    # `pybabel update --ignore-obsolete` a deletion creates no fuzzy entry.
     regressions: list[tuple[str, int, int]] = []
-    for lang, before_stats in sorted(before.items()):
-        after_stats = after.get(lang, {"translated": 0, "fuzzy": 0})
-        if after_stats["fuzzy"] > before_stats["fuzzy"]:
-            regressions.append((lang, before_stats["fuzzy"], after_stats["fuzzy"]))
+    for lang, before_count in sorted(before.items()):
+        after_count = after.get(lang, 0)
+        if after_count < before_count:
+            regressions.append((lang, before_count, after_count))
 
     if regressions:
         print("Translation regression detected!\n")
         for lang, b, a in regressions:
-            print(
-                f"  {lang}: {a - b} translation(s) invalidated "
-                f"(fuzzy {b} -> {a}) by a renamed/reworded source string"
-            )
+            lost = b - a
+            print(f"  {lang}: {b} -> {a}  (-{lost} string(s) became fuzzy or removed)")
         print(
-            "\nResolve the newly-fuzzy entries in the affected .po files "
-            "before merging."
+            "\nStrings renamed or deleted by this PR invalidated existing translations."
+        )
+        print(
+            "Update the affected .po files to restore the lost entries before merging."
         )
         if report_path:
             Path(report_path).write_text(
@@ -289,15 +199,15 @@ def cmd_compare(
     # All good — print a summary so it's easy to read in CI logs.
     print("No translation regressions.\n")
     for lang in sorted(after):
-        before_stats = before.get(lang, {"translated": 0, "fuzzy": 0})
-        after_stats = after[lang]
-        t_delta = after_stats["translated"] - before_stats["translated"]
-        f_delta = after_stats["fuzzy"] - before_stats["fuzzy"]
-        print(
-            f"  {lang}: translated {before_stats['translated']} -> "
-            f"{after_stats['translated']} ({t_delta:+d}), fuzzy "
-            f"{before_stats['fuzzy']} -> {after_stats['fuzzy']} ({f_delta:+d})"
-        )
+        b = before.get(lang, 0)
+        a = after[lang]
+        if a > b:
+            delta = f"+{a - b}"
+        elif a == b:
+            delta = "no change"
+        else:
+            delta = f"-{b - a}"
+        print(f"  {lang}: {b} -> {a}  ({delta})")
 
 
 def main() -> None:

superset-embedded-sdk/README.md

@@ -29,8 +29,8 @@ Embedding is done by inserting an iframe, containing a Superset page, into the h
 
 ## Prerequisites
 
-- Activate the feature flag `EMBEDDED_SUPERSET`
-- Set a strong password in configuration variable `GUEST_TOKEN_JWT_SECRET` (see configuration file config.py). Be aware that its default value must be changed in production.
+* Activate the feature flag `EMBEDDED_SUPERSET`
+* Set a strong password in configuration variable `GUEST_TOKEN_JWT_SECRET` (see configuration file config.py). Be aware that its default value must be changed in production.
 
 ## Embedding a Dashboard
 
@@ -41,37 +41,32 @@ npm install --save @superset-ui/embedded-sdk
 ```
 
 ```js
-import { embedDashboard } from '@superset-ui/embedded-sdk';
+import { embedDashboard } from "@superset-ui/embedded-sdk";
 
 embedDashboard({
-  id: 'abc123', // given by the Superset embedding UI
-  supersetDomain: 'https://superset.example.com',
-  mountPoint: document.getElementById('my-superset-container'), // any html element that can contain an iframe
+  id: "abc123", // given by the Superset embedding UI
+  supersetDomain: "https://superset.example.com",
+  mountPoint: document.getElementById("my-superset-container"), // any html element that can contain an iframe
   fetchGuestToken: () => fetchGuestTokenFromBackend(),
-  dashboardUiConfig: {
-    // dashboard UI config: hideTitle, hideTab, hideChartControls, filters.visible, filters.expanded (optional), urlParams (optional)
-    hideTitle: true,
-    filters: {
-      expanded: true,
-    },
-    urlParams: {
-      foo: 'value1',
-      bar: 'value2',
-      // themeMode: 'dark', // set the initial theme: 'dark' | 'system' | 'default' (default: 'default')
-      // ...
-    },
+  dashboardUiConfig: { // dashboard UI config: hideTitle, hideTab, hideChartControls, filters.visible, filters.expanded (optional), urlParams (optional)
+      hideTitle: true,
+      filters: {
+          expanded: true,
+      },
+      urlParams: {
+          foo: 'value1',
+          bar: 'value2',
+          // ...
+      }
   },
   // optional additional iframe sandbox attributes
-  iframeSandboxExtras: [
-    'allow-top-navigation',
-    'allow-popups-to-escape-sandbox',
-  ],
+  iframeSandboxExtras: ['allow-top-navigation', 'allow-popups-to-escape-sandbox'],
   // optional Permissions Policy features
   iframeAllowExtras: ['clipboard-write', 'fullscreen'],
   // optional config to enforce a particular referrerPolicy
-  referrerPolicy: 'same-origin',
+  referrerPolicy: "same-origin",
   // optional callback to customize permalink URLs
-  resolvePermalinkUrl: ({ key }) => `https://my-app.com/analytics/share/${key}`,
+  resolvePermalinkUrl: ({ key }) => `https://my-app.com/analytics/share/${key}`
 });
 ```
 
@@ -102,7 +97,7 @@ Guest tokens can have Row Level Security rules which filter data for the user ca
 
 The agent making the `POST` request must be authenticated with the `can_grant_guest_token` permission.
 
-Within your app, using the Guest Token will then allow authentication to your Superset instance via creating an Anonymous user object. This guest anonymous user will default to the public role as per this setting `GUEST_ROLE_NAME = "Public"`.
+Within your app, using the Guest Token will then allow authentication to your Superset instance via creating an Anonymous user object.  This guest anonymous user will default to the public role as per this setting `GUEST_ROLE_NAME = "Public"`.
 
 The user parameters in the example below are optional and are provided as a means of passing user attributes that may be accessed in jinja templates inside your charts.
 
@@ -115,13 +110,13 @@ Example `POST /security/guest_token` payload:
     "first_name": "Stan",
     "last_name": "Lee"
   },
-  "resources": [
-    {
-      "type": "dashboard",
-      "id": "abc123"
-    }
-  ],
-  "rls": [{ "clause": "publisher = 'Nintendo'" }]
+  "resources": [{
+    "type": "dashboard",
+    "id": "abc123"
+  }],
+  "rls": [
+    { "clause": "publisher = 'Nintendo'" }
+  ]
 }
 ```
 
@@ -157,43 +152,15 @@ In this example, the configuration file includes the following setting:
 GUEST_TOKEN_JWT_AUDIENCE="superset"
 ```
 
-### Setting the Initial Theme Mode
-
-Use the `themeMode` URL parameter to control the embedded dashboard's initial colour scheme:
-
-```js
-embedDashboard({
-  id: 'abc123',
-  supersetDomain: 'https://superset.example.com',
-  mountPoint: document.getElementById('my-superset-container'),
-  fetchGuestToken: () => fetchGuestTokenFromBackend(),
-  dashboardUiConfig: {
-    urlParams: {
-      themeMode: 'dark', // 'dark' | 'system' | 'default' (default: 'default')
-    },
-  },
-});
-```
-
-The supported values are:
-
-| Value     | Behaviour                                                 |
-| --------- | --------------------------------------------------------- |
-| `default` | Light theme (Superset default)                            |
-| `dark`    | Dark theme                                                |
-| `system`  | Follows the user's OS preference (`prefers-color-scheme`) |
-
-The theme can also be changed at runtime via `embeddedDashboard.setThemeMode(mode)`.
 
 ### Sandbox iframe
 
 The Embedded SDK creates an iframe with [sandbox](https://developer.mozilla.org/es/docs/Web/HTML/Element/iframe#sandbox) mode by default
 which applies certain restrictions to the iframe's content.
 To pass additional sandbox attributes you can use `iframeSandboxExtras`:
-
 ```js
-// optional additional iframe sandbox attributes
-iframeSandboxExtras: ['allow-top-navigation', 'allow-popups-to-escape-sandbox'];
+  // optional additional iframe sandbox attributes
+  iframeSandboxExtras: ['allow-top-navigation', 'allow-popups-to-escape-sandbox']
 ```
 
 ### Permissions Policy
@@ -201,12 +168,11 @@ iframeSandboxExtras: ['allow-top-navigation', 'allow-popups-to-escape-sandbox'];
 To enable specific browser features within the embedded iframe, use `iframeAllowExtras` to set the iframe's [Permissions Policy](https://developer.mozilla.org/en-US/docs/Web/HTTP/Permissions_Policy) (the `allow` attribute):
 
 ```js
-// optional Permissions Policy features
-iframeAllowExtras: ['clipboard-write', 'fullscreen'];
+  // optional Permissions Policy features
+  iframeAllowExtras: ['clipboard-write', 'fullscreen']
 ```
 
 Common permissions you might need:
-
 - `clipboard-write` - Required for "Copy permalink to clipboard" functionality
 - `fullscreen` - Required for fullscreen chart viewing
 - `camera`, `microphone` - If your dashboards include media capture features
@@ -225,16 +191,16 @@ When users click share buttons inside an embedded dashboard, Superset generates
 
 ```js
 embedDashboard({
-  id: 'abc123',
-  supersetDomain: 'https://superset.example.com',
-  mountPoint: document.getElementById('my-superset-container'),
+  id: "abc123",
+  supersetDomain: "https://superset.example.com",
+  mountPoint: document.getElementById("my-superset-container"),
   fetchGuestToken: () => fetchGuestTokenFromBackend(),
 
   // Customize permalink URLs
   resolvePermalinkUrl: ({ key }) => {
     // key: the permalink key (e.g., "xyz789")
     return `https://my-app.com/analytics/share/${key}`;
-  },
+  }
 });
 ```
 
@@ -245,15 +211,15 @@ To restore the dashboard state from a permalink in your app:
 const permalinkKey = routeParams.key;
 
 embedDashboard({
-  id: 'abc123',
-  supersetDomain: 'https://superset.example.com',
-  mountPoint: document.getElementById('my-superset-container'),
+  id: "abc123",
+  supersetDomain: "https://superset.example.com",
+  mountPoint: document.getElementById("my-superset-container"),
   fetchGuestToken: () => fetchGuestTokenFromBackend(),
   resolvePermalinkUrl: ({ key }) => `https://my-app.com/analytics/share/${key}`,
   dashboardUiConfig: {
     urlParams: {
-      permalink_key: permalinkKey, // Restores filters, tabs, chart states, and scrolls to anchor
-    },
-  },
+      permalink_key: permalinkKey,  // Restores filters, tabs, chart states, and scrolls to anchor
+    }
+  }
 });
 ```

superset-embedded-sdk/src/guestTokenRefresh.test.ts

@@ -22,7 +22,6 @@ import {
   getGuestTokenRefreshTiming,
   MIN_REFRESH_WAIT_MS,
   DEFAULT_TOKEN_EXP_MS,
-  DEFAULT_TOKEN_REFRESH_RETRY_MS,
 } from "./guestTokenRefresh";
 
 describe("guest token refresh", () => {
@@ -94,11 +93,4 @@ describe("guest token refresh", () => {
     expect(timing).toBeGreaterThan(MIN_REFRESH_WAIT_MS);
     expect(timing).toBe(DEFAULT_TOKEN_EXP_MS - REFRESH_TIMING_BUFFER_MS);
   });
-
-  it("exposes a positive retry delay for failed token refreshes", () => {
-    // The refresh loop reschedules itself after this delay when a fetch
-    // fails or times out, so it must be a sane positive value.
-    expect(DEFAULT_TOKEN_REFRESH_RETRY_MS).toBe(10000);
-    expect(DEFAULT_TOKEN_REFRESH_RETRY_MS).toBeGreaterThan(0);
-  });
 });

superset-embedded-sdk/src/guestTokenRefresh.ts

@@ -21,7 +21,6 @@ import { jwtDecode } from "jwt-decode";
 export const REFRESH_TIMING_BUFFER_MS = 5000 // refresh guest token early to avoid failed superset requests
 export const MIN_REFRESH_WAIT_MS = 10000 // avoid blasting requests as fast as the cpu can handle
 export const DEFAULT_TOKEN_EXP_MS = 300000 // (5 min) used only when parsing guest token exp fails
-export const DEFAULT_TOKEN_REFRESH_RETRY_MS = 10000 // wait before retrying a failed/timed-out token refresh
 
 // when do we refresh the guest token?
 export function getGuestTokenRefreshTiming(currentGuestToken: string) {

superset-embedded-sdk/src/index.ts

@@ -24,11 +24,7 @@ import {
 
 // We can swap this out for the actual switchboard package once it gets published
 import { Switchboard } from '@superset-ui/switchboard';
-import {
-  getGuestTokenRefreshTiming,
-  DEFAULT_TOKEN_REFRESH_RETRY_MS,
-} from './guestTokenRefresh';
-import { withTimeout } from './withTimeout';
+import { getGuestTokenRefreshTiming } from './guestTokenRefresh';
 
 /**
  * The function to fetch a guest token from your Host App's backend server.
@@ -53,9 +49,6 @@ export type UiConfigType = {
   showRowLimitWarning?: boolean;
 };
 
-/** Default per-call timeout (ms) applied to the host `fetchGuestToken` callback. */
-const DEFAULT_GUEST_TOKEN_FETCH_TIMEOUT_MS = 30_000;
-
 export type EmbedDashboardParams = {
   /** The id provided by the embed configuration UI in Superset */
   id: string;
@@ -80,10 +73,6 @@ export type EmbedDashboardParams = {
   /** Callback to resolve permalink URLs. If provided, this will be called when generating permalinks
    * to allow the host app to customize the URL. If not provided, Superset's default URL is used. */
   resolvePermalinkUrl?: ResolvePermalinkUrlFn;
-  /** Timeout, in milliseconds, applied to each `fetchGuestToken` call so a host
-   * callback that never resolves cannot hang the embed/refresh cycle. Defaults
-   * to 30000ms. Set to 0 to disable the timeout. */
-  guestTokenFetchTimeoutMs?: number;
 };
 
 export type Size = {
@@ -138,7 +127,6 @@ export async function embedDashboard({
   iframeAllowExtras = [],
   referrerPolicy,
   resolvePermalinkUrl,
-  guestTokenFetchTimeoutMs = DEFAULT_GUEST_TOKEN_FETCH_TIMEOUT_MS,
 }: EmbedDashboardParams): Promise<EmbeddedDashboard> {
   function log(...info: unknown[]) {
     if (debug) {
@@ -146,16 +134,6 @@ export async function embedDashboard({
     }
   }
 
-  // Wrap the host-provided fetchGuestToken so a callback that never settles
-  // cannot hang the initial embed or a later refresh cycle.
-  function fetchGuestTokenWithTimeout(): Promise<string> {
-    return withTimeout(
-      fetchGuestToken(),
-      guestTokenFetchTimeoutMs,
-      'fetchGuestToken',
-    );
-  }
-
   log('embedding');
 
   if (supersetDomain.endsWith('/')) {
@@ -269,57 +247,21 @@ export async function embedDashboard({
     });
   }
 
-  let guestToken: string;
-  let ourPort: Switchboard;
-  try {
-    [guestToken, ourPort] = await Promise.all([
-      fetchGuestTokenWithTimeout(),
-      mountIframe(),
-    ]);
-  } catch (err) {
-    // If the initial token fetch (or timeout) rejects after the iframe has
-    // already been mounted, tear down the partially initialized iframe so the
-    // host isn't left with an orphaned embedded dashboard before rethrowing.
-    //@ts-ignore
-    mountPoint.replaceChildren();
-    throw err;
-  }
+  const [guestToken, ourPort]: [string, Switchboard] = await Promise.all([
+    fetchGuestToken(),
+    mountIframe(),
+  ]);
 
   ourPort.emit('guestToken', { guestToken });
   log('sent guest token');
 
-  // Track the pending refresh timer so it can be cancelled on unmount, and
-  // stop the cycle once unmounted so it cannot leak across mount/unmount cycles.
-  let refreshTimer: ReturnType<typeof setTimeout> | undefined;
-  let unmounted = false;
-
   async function refreshGuestToken() {
-    if (unmounted) return;
-    try {
-      const newGuestToken = await fetchGuestTokenWithTimeout();
-      if (unmounted) return;
-      ourPort.emit('guestToken', { guestToken: newGuestToken });
-      refreshTimer = setTimeout(
-        refreshGuestToken,
-        getGuestTokenRefreshTiming(newGuestToken),
-      );
-    } catch (err) {
-      // A transient fetch failure or timeout must not permanently stop the
-      // refresh cycle. Log it and retry so the session can recover once the
-      // host callback succeeds again.
-      log('failed to refresh guest token, will retry:', err);
-      if (unmounted) return;
-      refreshTimer = setTimeout(
-        refreshGuestToken,
-        DEFAULT_TOKEN_REFRESH_RETRY_MS,
-      );
-    }
+    const newGuestToken = await fetchGuestToken();
+    ourPort.emit('guestToken', { guestToken: newGuestToken });
+    setTimeout(refreshGuestToken, getGuestTokenRefreshTiming(newGuestToken));
   }
 
-  refreshTimer = setTimeout(
-    refreshGuestToken,
-    getGuestTokenRefreshTiming(guestToken),
-  );
+  setTimeout(refreshGuestToken, getGuestTokenRefreshTiming(guestToken));
 
   // Register the resolvePermalinkUrl method for the iframe to call
   // Returns null if no callback provided or on error, allowing iframe to use default URL
@@ -341,11 +283,6 @@ export async function embedDashboard({
 
   function unmount() {
     log('unmounting');
-    unmounted = true;
-    if (refreshTimer !== undefined) {
-      clearTimeout(refreshTimer);
-      refreshTimer = undefined;
-    }
     //@ts-ignore
     mountPoint.replaceChildren();
   }

superset-embedded-sdk/src/withTimeout.test.ts

@@ -1,39 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { withTimeout } from "./withTimeout";
-
-test("resolves with the value when the promise settles in time", async () => {
-  await expect(withTimeout(Promise.resolve("ok"), 1000, "fetch")).resolves.toBe(
-    "ok"
-  );
-});
-
-test("rejects when the promise does not settle within the timeout", async () => {
-  const never = new Promise<string>(() => {});
-  await expect(withTimeout(never, 10, "fetch")).rejects.toThrow(
-    /fetch did not resolve within 10ms/
-  );
-});
-
-test("passes the promise through unchanged when the timeout is disabled", async () => {
-  await expect(withTimeout(Promise.resolve("ok"), 0, "fetch")).resolves.toBe(
-    "ok"
-  );
-});

superset-embedded-sdk/src/withTimeout.ts

@@ -1,43 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * Rejects if `promise` does not settle within `ms` milliseconds. A non-positive
- * `ms` disables the timeout and returns the promise unchanged. The timer is
- * always cleared so it cannot keep the event loop alive.
- */
-export function withTimeout<T>(
-  promise: Promise<T>,
-  ms: number,
-  label: string,
-): Promise<T> {
-  if (!ms || ms <= 0) {
-    return promise;
-  }
-  let timer: ReturnType<typeof setTimeout>;
-  const timeout = new Promise<never>((_resolve, reject) => {
-    timer = setTimeout(
-      () => reject(new Error(`${label} did not resolve within ${ms}ms`)),
-      ms,
-    );
-  });
-  return Promise.race([promise, timeout]).finally(() =>
-    clearTimeout(timer),
-  ) as Promise<T>;
-}

superset-extensions-cli/src/superset_extensions_cli/cli.py

@@ -226,7 +226,7 @@ def copy_frontend_dist(cwd: Path) -> str:
 def copy_backend_files(cwd: Path) -> None:
     """Copy backend files based on pyproject.toml build configuration (validation already passed)."""
     dist_dir = cwd / "dist"
-    backend_dir = (cwd / "backend").resolve()
+    backend_dir = cwd / "backend"
 
     # Read build config from pyproject.toml
     pyproject = read_toml(backend_dir / "pyproject.toml")
@@ -239,31 +239,11 @@ def copy_backend_files(cwd: Path) -> None:
 
     # Process include patterns
     for pattern in include_patterns:
-        # Include patterns are only meant to select files within the backend
-        # directory. Reject absolute patterns or ones that walk outside it via
-        # parent ("..") components before handing them to glob().
-        pattern_parts = Path(pattern).parts
-        if Path(pattern).is_absolute() or ".." in pattern_parts:
-            raise click.ClickException(
-                f"Invalid include pattern {pattern!r}: patterns must be "
-                "relative to the backend directory and may not contain '..'."
-            )
         for f in backend_dir.glob(pattern):
             if not f.is_file():
                 continue
 
-            # Defense in depth: confirm the matched file resolves to a location
-            # inside the backend directory before copying it into the bundle.
-            resolved = f.resolve()
-            if not resolved.is_relative_to(backend_dir):
-                raise click.ClickException(
-                    f"Refusing to copy {f}: resolved path is outside the "
-                    f"backend directory {backend_dir}."
-                )
-
-            # Use the matched path (not the resolved target) for the bundle
-            # layout and exclude evaluation so symlinked files are staged at
-            # their configured path rather than their symlink target.
+            # Check exclude patterns
             relative_path = f.relative_to(backend_dir)
             should_exclude = any(
                 relative_path.match(excl_pattern) for excl_pattern in exclude_patterns

superset-extensions-cli/tests/test_cli_build.py

@@ -20,7 +20,6 @@ from __future__ import annotations
 import json
 from unittest.mock import Mock, patch
 
-import click
 import pytest
 from superset_extensions_cli.cli import (
     app,
@@ -626,155 +625,6 @@ exclude = []
     )
 
 
-@pytest.mark.unit
-def test_copy_backend_files_supports_legitimate_nested_patterns(isolated_filesystem):
-    """Test copy_backend_files copies deeply nested files via recursive globs."""
-    backend_dir = isolated_filesystem / "backend"
-    nested = backend_dir / "src" / "test_org" / "test_ext" / "deep" / "deeper"
-    nested.mkdir(parents=True)
-    (nested / "module.py").write_text("# nested module")
-
-    pyproject_content = """[project]
-name = "test_org-test_ext"
-version = "1.0.0"
-license = "Apache-2.0"
-
-[tool.apache_superset_extensions.build]
-include = [
-    "src/test_org/test_ext/**/*.py",
-]
-exclude = []
-"""
-    (backend_dir / "pyproject.toml").write_text(pyproject_content)
-
-    extension_data = {
-        "publisher": "test-org",
-        "name": "test-ext",
-        "displayName": "Test Extension",
-        "version": "1.0.0",
-        "permissions": [],
-    }
-    (isolated_filesystem / "extension.json").write_text(json.dumps(extension_data))
-
-    clean_dist(isolated_filesystem)
-    copy_backend_files(isolated_filesystem)
-
-    dist_dir = isolated_filesystem / "dist"
-    assert_file_exists(
-        dist_dir
-        / "backend"
-        / "src"
-        / "test_org"
-        / "test_ext"
-        / "deep"
-        / "deeper"
-        / "module.py"
-    )
-
-
-@pytest.mark.unit
-@pytest.mark.parametrize(
-    "bad_pattern",
-    [
-        "../../.ssh/*",
-        "../config",
-        "src/../../secret.txt",
-        "/etc/passwd",
-    ],
-)
-def test_copy_backend_files_rejects_patterns_escaping_backend_dir(
-    isolated_filesystem, bad_pattern
-):
-    """Test copy_backend_files refuses include patterns that escape backend_dir."""
-    # Create a sensitive file outside the backend directory.
-    (isolated_filesystem / "secret.txt").write_text("SECRET")
-    (isolated_filesystem / "config").write_text("SECRET")
-
-    backend_dir = isolated_filesystem / "backend"
-    backend_src = backend_dir / "src" / "test_org" / "test_ext"
-    backend_src.mkdir(parents=True)
-    (backend_src / "__init__.py").write_text("# init")
-
-    pyproject_content = f"""[project]
-name = "test_org-test_ext"
-version = "1.0.0"
-license = "Apache-2.0"
-
-[tool.apache_superset_extensions.build]
-include = [
-    "{bad_pattern}",
-]
-exclude = []
-"""
-    (backend_dir / "pyproject.toml").write_text(pyproject_content)
-
-    extension_data = {
-        "publisher": "test-org",
-        "name": "test-ext",
-        "displayName": "Test Extension",
-        "version": "1.0.0",
-        "permissions": [],
-    }
-    (isolated_filesystem / "extension.json").write_text(json.dumps(extension_data))
-
-    clean_dist(isolated_filesystem)
-
-    with pytest.raises(click.ClickException):
-        copy_backend_files(isolated_filesystem)
-
-    # Nothing outside the backend directory should have been staged into dist,
-    # including paths reachable via ".." from inside dist/backend.
-    dist_dir = isolated_filesystem / "dist"
-    assert not (dist_dir / "secret.txt").exists()
-    assert not (dist_dir / "config").exists()
-
-
-@pytest.mark.unit
-def test_copy_backend_files_stages_symlink_at_matched_path(isolated_filesystem):
-    """Symlinked files inside backend are staged at the matched path, not the target."""
-    backend_dir = isolated_filesystem / "backend"
-    target_dir = backend_dir / "src" / "common"
-    target_dir.mkdir(parents=True)
-    (target_dir / "module.py").write_text("# shared module")
-
-    link_dir = backend_dir / "src" / "test_org" / "test_ext" / "common"
-    link_dir.mkdir(parents=True)
-    link = link_dir / "module.py"
-    link.symlink_to(target_dir / "module.py")
-
-    pyproject_content = """[project]
-name = "test_org-test_ext"
-version = "1.0.0"
-license = "Apache-2.0"
-
-[tool.apache_superset_extensions.build]
-include = [
-    "src/test_org/test_ext/**/*.py",
-]
-exclude = []
-"""
-    (backend_dir / "pyproject.toml").write_text(pyproject_content)
-
-    extension_data = {
-        "publisher": "test-org",
-        "name": "test-ext",
-        "displayName": "Test Extension",
-        "version": "1.0.0",
-        "permissions": [],
-    }
-    (isolated_filesystem / "extension.json").write_text(json.dumps(extension_data))
-
-    clean_dist(isolated_filesystem)
-    copy_backend_files(isolated_filesystem)
-
-    dist_dir = isolated_filesystem / "dist"
-    # Staged at the configured (symlink) path, not the resolved target path.
-    assert_file_exists(
-        dist_dir / "backend" / "src" / "test_org" / "test_ext" / "common" / "module.py"
-    )
-    assert not (dist_dir / "backend" / "src" / "common" / "module.py").exists()
-
-
 # Removed obsolete tests:
 # - test_copy_backend_files_handles_no_backend_config: This scenario can't happen since copy_backend_files is only called when backend exists
 # - test_copy_backend_files_exits_when_extension_json_missing: Validation catches this before copy_backend_files is called

superset-frontend/cypress-base/cypress/e2e/dashboard/actions.test.js

@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { SAMPLE_DASHBOARD_1 } from 'cypress/utils/urls';
+import { interceptFav, interceptUnfav } from './utils';
+
+describe('Dashboard actions', () => {
+  beforeEach(() => {
+    cy.createSampleDashboards([0]);
+    cy.visit(SAMPLE_DASHBOARD_1);
+  });
+  it('should allow to favorite/unfavorite dashboard', () => {
+    interceptFav();
+    interceptUnfav();
+
+    // Find and click StarOutlined (adds to favorites)
+    cy.getBySel('dashboard-header-container')
+      .find("[aria-label='unstarred']")
+      .as('starIconOutlined')
+      .should('exist')
+      .click();
+
+    cy.wait('@select');
+
+    // After clicking, StarFilled should appear
+    cy.getBySel('dashboard-header-container')
+      .find("[aria-label='starred']")
+      .as('starIconFilled')
+      .should('exist');
+
+    // Verify the color of the filled star (gold)
+    cy.get('@starIconFilled')
+      .should('have.css', 'color')
+      .and('eq', 'rgb(252, 199, 0)');
+
+    // Click on StarFilled (removes from favorites)
+    cy.get('@starIconFilled').click();
+
+    cy.wait('@unselect');
+
+    // After clicking, StarOutlined should reappear
+    cy.getBySel('dashboard-header-container')
+      .find("[aria-label='unstarred']")
+      .as('starIconOutlinedAfter')
+      .should('exist');
+
+    // Verify the color of the outlined star (gray)
+    cy.get('@starIconOutlinedAfter')
+      .should('have.css', 'color')
+      .and('eq', 'rgba(0, 0, 0, 0.45)');
+  });
+});

superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts

@@ -160,6 +160,18 @@ export function interceptLog() {
   cy.intercept('**/superset/log/?explode=events&dashboard_id=*').as('logs');
 }
 
+export function interceptFav() {
+  cy.intercept({ url: `**/api/v1/dashboard/*/favorites/`, method: 'POST' }).as(
+    'select',
+  );
+}
+
+export function interceptUnfav() {
+  cy.intercept({ url: `**/api/v1/dashboard/*/favorites/`, method: 'POST' }).as(
+    'unselect',
+  );
+}
+
 export function interceptDataset() {
   cy.intercept('GET', `**/api/v1/dataset/*`).as('getDataset');
 }

superset-frontend/jest.config.js

@@ -69,7 +69,7 @@ module.exports = {
   ],
   coverageReporters: ['lcov', 'json-summary', 'html', 'text'],
   transformIgnorePatterns: [
-    'node_modules/(?!@formatjs/.*|d3-(array|interpolate|color|time|scale|time-format|format)|internmap|@mapbox/tiny-sdf|remark-gfm|(?!@ngrx|(?!deck.gl)|d3-scale)|markdown-table|micromark-*.|decode-named-character-reference|character-entities|mdast-util-*.|unist-util-*.|ccount|escape-string-regexp|nanoid|uuid|@rjsf/*.|echarts|zrender|fetch-mock|pretty-ms|parse-ms|ol|@babel/runtime|@emotion|cheerio|cheerio/lib|parse5|dom-serializer|entities|htmlparser2|rehype-sanitize|hast-util-sanitize|unified|unist-.*|hast-.*|rehype-.*|remark-.*|mdast-.*|micromark-.*|parse-entities|property-information|space-separated-tokens|comma-separated-tokens|bail|devlop|zwitch|longest-streak|geostyler|geostyler-.*|(?!geostyler)lodash|react-error-boundary|react-json-tree|react-base16-styling|lodash-es|rbush|quickselect|react-diff-viewer-continued)',
+    'node_modules/(?!d3-(array|interpolate|color|time|scale|time-format|format)|internmap|@mapbox/tiny-sdf|remark-gfm|(?!@ngrx|(?!deck.gl)|d3-scale)|markdown-table|micromark-*.|decode-named-character-reference|character-entities|mdast-util-*.|unist-util-*.|ccount|escape-string-regexp|nanoid|uuid|@rjsf/*.|echarts|zrender|fetch-mock|pretty-ms|parse-ms|ol|@babel/runtime|@emotion|cheerio|cheerio/lib|parse5|dom-serializer|entities|htmlparser2|rehype-sanitize|hast-util-sanitize|unified|unist-.*|hast-.*|rehype-.*|remark-.*|mdast-.*|micromark-.*|parse-entities|property-information|space-separated-tokens|comma-separated-tokens|bail|devlop|zwitch|longest-streak|geostyler|geostyler-.*|(?!geostyler)lodash|react-error-boundary|react-json-tree|react-base16-styling|lodash-es|rbush|quickselect|react-diff-viewer-continued)',
   ],
   preset: 'ts-jest',
   transform: {

superset-frontend/package.json

@@ -82,7 +82,7 @@
     "prune": "rm -rf ./{packages,plugins}/*/{node_modules,lib,esm,tsconfig.tsbuildinfo,package-lock.json} ./.temp_cache",
     "storybook": "cross-env NODE_ENV=development BABEL_ENV=development storybook dev -p 6006",
     "test-storybook": "test-storybook",
-    "test-storybook:ci": "concurrently --kill-others --success first --names \"SB,TEST\" --prefix-colors \"magenta,blue\" \"npx http-server storybook-static --port 6006 --silent\" \"npx wait-on tcp:127.0.0.1:6006 && npm run test-storybook -- --maxWorkers=2\"",
+    "test-storybook:ci": "concurrently -k -s first -n \"SB,TEST\" -c \"magenta,blue\" \"npx http-server storybook-static --port 6006 --silent\" \"npx wait-on tcp:127.0.0.1:6006 && npm run test-storybook -- --maxWorkers=2\"",
     "tdd": "cross-env NODE_ENV=test NODE_OPTIONS=\"--max-old-space-size=8192\" jest --watch",
     "test": "cross-env NODE_ENV=test NODE_OPTIONS=\"--max-old-space-size=8192\" jest --max-workers=80% --silent",
     "test-loud": "cross-env NODE_ENV=test NODE_OPTIONS=\"--max-old-space-size=8192\" jest --max-workers=80%",
@@ -169,10 +169,10 @@
     "antd": "^5.26.0",
     "chrono-node": "^2.9.1",
     "classnames": "^2.2.5",
-    "content-disposition": "^2.0.1",
+    "content-disposition": "^2.0.0",
     "d3-color": "^3.1.0",
     "d3-scale": "^4.0.2",
-    "dayjs": "^1.11.21",
+    "dayjs": "^1.11.20",
     "dom-to-image-more": "^3.7.2",
     "dom-to-pdf": "^0.3.2",
     "echarts": "^5.6.0",
@@ -201,7 +201,8 @@
     "mustache": "^4.2.0",
     "nanoid": "^5.1.11",
     "ol": "^10.9.0",
-    "query-string": "9.4.0",
+    "pretty-ms": "^9.3.0",
+    "query-string": "9.3.1",
     "re-resizable": "^6.11.2",
     "react": "^18.2.0",
     "react-arborist": "^3.8.0",
@@ -245,9 +246,9 @@
   "devDependencies": {
     "@babel/cli": "^7.29.7",
     "@babel/compat-data": "^7.28.4",
-    "@babel/core": "^7.29.7",
+    "@babel/core": "^7.29.0",
     "@babel/eslint-parser": "^7.29.7",
-    "@babel/node": "^7.29.7",
+    "@babel/node": "^7.29.0",
     "@babel/plugin-syntax-dynamic-import": "^7.8.3",
     "@babel/plugin-transform-export-namespace-from": "^7.29.7",
     "@babel/plugin-transform-modules-commonjs": "^7.29.7",
@@ -255,13 +256,12 @@
     "@babel/preset-env": "^7.29.7",
     "@babel/preset-react": "^7.29.7",
     "@babel/preset-typescript": "^7.29.7",
-    "@babel/register": "^7.29.7",
-    "@babel/runtime": "^7.29.7",
-    "@babel/runtime-corejs3": "^7.29.7",
+    "@babel/register": "^7.29.3",
+    "@babel/runtime": "^7.29.2",
+    "@babel/runtime-corejs3": "^7.29.2",
     "@babel/types": "^7.29.7",
     "@emotion/babel-plugin": "^11.13.5",
     "@emotion/jest": "^11.14.2",
-    "@formatjs/intl-durationformat": "^0.10.3",
     "@istanbuljs/nyc-config-typescript": "^1.0.1",
     "@mihkeleidast/storybook-addon-source": "^1.0.1",
     "@playwright/test": "^1.60.0",
@@ -279,7 +279,7 @@
     "@storybook/test-runner": "^0.17.0",
     "@svgr/webpack": "^8.1.0",
     "@swc/core": "^1.15.40",
-    "@swc/plugin-emotion": "^14.12.0",
+    "@swc/plugin-emotion": "^14.10.0",
     "@swc/plugin-transform-imports": "^12.5.0",
     "@testing-library/dom": "^9.3.4",
     "@testing-library/jest-dom": "^6.9.1",
@@ -313,9 +313,9 @@
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "babel-plugin-jsx-remove-data-test-id": "^3.0.0",
     "babel-plugin-lodash": "^3.3.4",
-    "baseline-browser-mapping": "^2.10.33",
+    "baseline-browser-mapping": "^2.10.32",
     "cheerio": "1.2.0",
-    "concurrently": "^10.0.3",
+    "concurrently": "^9.2.1",
     "copy-webpack-plugin": "^14.0.0",
     "cross-env": "^10.1.0",
     "css-loader": "^7.1.4",
@@ -331,9 +331,9 @@
     "eslint-plugin-jest-dom": "^5.5.0",
     "eslint-plugin-lodash": "^7.4.0",
     "eslint-plugin-no-only-tests": "^3.4.0",
-    "eslint-plugin-prettier": "^5.5.6",
+    "eslint-plugin-prettier": "^5.5.5",
     "eslint-plugin-react-prefer-function-component": "^5.0.0",
-    "eslint-plugin-react-you-might-not-need-an-effect": "^0.10.4",
+    "eslint-plugin-react-you-might-not-need-an-effect": "^0.10.2",
     "eslint-plugin-storybook": "^0.8.0",
     "eslint-plugin-testing-library": "^7.16.2",
     "eslint-plugin-theme-colors": "file:eslint-rules/eslint-plugin-theme-colors",
@@ -353,7 +353,7 @@
     "lightningcss": "^1.32.0",
     "mini-css-extract-plugin": "^2.10.2",
     "open-cli": "^9.0.0",
-    "oxlint": "^1.67.0",
+    "oxlint": "^1.66.0",
     "po2json": "^0.4.5",
     "prettier": "3.8.3",
     "prettier-plugin-packagejson": "^3.0.2",
@@ -367,15 +367,15 @@
     "storybook": "8.6.18",
     "style-loader": "^4.0.0",
     "swc-loader": "^0.2.7",
-    "terser-webpack-plugin": "^5.6.1",
+    "terser-webpack-plugin": "^5.6.0",
     "ts-jest": "^29.4.11",
     "tscw-config": "^1.1.2",
-    "tsx": "^4.22.4",
+    "tsx": "^4.22.3",
     "typescript": "5.4.5",
     "unzipper": "^0.12.3",
     "vm-browserify": "^1.1.2",
     "wait-on": "^9.0.10",
-    "webpack": "^5.107.2",
+    "webpack": "^5.107.1",
     "webpack-bundle-analyzer": "^5.3.0",
     "webpack-cli": "^6.0.1",
     "webpack-dev-server": "^5.2.4",

superset-frontend/packages/superset-core/package.json

@@ -74,7 +74,7 @@
   "license": "Apache-2.0",
   "devDependencies": {
     "@babel/cli": "^7.29.7",
-    "@babel/core": "^7.29.7",
+    "@babel/core": "^7.29.0",
     "@babel/preset-env": "^7.29.7",
     "@babel/preset-react": "^7.29.7",
     "@babel/preset-typescript": "^7.29.7",

superset-frontend/packages/superset-core/src/theme/types.ts

@@ -508,12 +508,6 @@ export interface ThemeContextType {
   clearLocalOverrides: () => void;
   getCurrentCrudThemeId: () => string | null;
   hasDevOverride: () => boolean;
-  /**
-   * True when an explicit theme config override is active (e.g. supplied via
-   * the Embedded SDK). Such an override takes precedence over a
-   * dashboard-level theme.
-   */
-  hasThemeConfigOverride: boolean;
   canSetMode: () => boolean;
   canSetTheme: () => boolean;
   canDetectOSPreference: () => boolean;

superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/matrixifyControls.tsx

@@ -118,6 +118,7 @@ const matrixifyControls: Record<string, SharedControlConfig<any>> = {};
     description: t(`Select dimension and values`),
     default: { dimension: '', values: [] },
     validators: [], // No validation - rely on visibility
+    renderTrigger: true,
     tabOverride: 'matrixify',
     shouldMapStateToProps: (prevState, state) => {
       // Recalculate when any relevant form_data field changes

superset-frontend/packages/superset-ui-chart-controls/src/utils/D3Formatting.ts

@@ -57,7 +57,7 @@ export const D3_FORMAT_OPTIONS: [string, string][] = [
   ...d3Formatted,
   ['DURATION', t('Duration in ms (66000 => 1m 6s)')],
   ['DURATION_SUB', t('Duration in ms (1.40008 => 1ms 400µs 80ns)')],
-  ['DURATION_COL', t('Duration in ms (10500 => 0:00:10.5)')],
+  ['DURATION_COL', t('Duration in ms (10500 => 0:10.5)')],
   ['MEMORY_DECIMAL', t('Memory in bytes - decimal (1024B => 1.024kB)')],
   ['MEMORY_BINARY', t('Memory in bytes - binary (1024B => 1KiB)')],
   [

superset-frontend/packages/superset-ui-core/package.json

@@ -24,7 +24,7 @@
     "lib"
   ],
   "dependencies": {
-    "@ant-design/icons": "^6.2.5",
+    "@ant-design/icons": "^6.2.3",
     "@apache-superset/core": "*",
     "@babel/runtime": "^7.29.7",
     "@braintree/sanitize-url": "^7.1.2",
@@ -42,17 +42,17 @@
     "d3-scale": "^4.0.2",
     "d3-time": "^3.1.0",
     "d3-time-format": "^4.1.0",
-    "dayjs": "^1.11.21",
-    "dompurify": "^3.4.7",
+    "dayjs": "^1.11.20",
+    "dompurify": "^3.4.5",
     "fetch-retry": "^6.0.0",
     "handlebars": "^4.7.9",
     "jed": "^1.1.1",
     "lodash": "^4.18.1",
     "math-expression-evaluator": "^2.0.7",
-    "parse-ms": "^4.0.0",
+    "pretty-ms": "^9.3.0",
     "re-resizable": "^6.11.2",
     "react-ace": "^14.0.1",
-    "react-draggable": "^4.6.0",
+    "react-draggable": "^4.5.0",
     "react-error-boundary": "6.0.0",
     "react-js-cron": "^5.2.0",
     "react-markdown": "^8.0.7",

superset-frontend/packages/superset-ui-core/src/components/DropdownContainer/DropdownContainer.tsx

@@ -72,15 +72,6 @@ export const DropdownContainer = forwardRef(
 
     const [showOverflow, setShowOverflow] = useState(false);
 
-    // When the item set changes, the overflow index is briefly reset while the
-    // new widths are measured (see the layout effect below). During that window
-    // the dropdown content momentarily becomes empty, which would hide and then
-    // re-show the trigger, causing a flicker. We track whether a recalculation
-    // is pending so the trigger can stay mounted across the transient (when it
-    // was showing content just before) without lingering in the steady state
-    // when nothing actually overflows.
-    const [recalculating, setRecalculating] = useState(false);
-
     // callback to update item widths so that the useLayoutEffect runs whenever
     // width of any of the child changes
     const recalculateItemWidths = useCallback(() => {
@@ -180,7 +171,6 @@ export const DropdownContainer = forwardRef(
             );
           } else {
             setOverflowingIndex(-1);
-            setRecalculating(true);
             return;
           }
         }
@@ -221,7 +211,6 @@ export const DropdownContainer = forwardRef(
         }
 
         setOverflowingIndex(newOverflowingIndex);
-        setRecalculating(false);
       }
     }, [
       current,
@@ -272,15 +261,6 @@ export const DropdownContainer = forwardRef(
       ],
     );
 
-    // The trigger had content in the previous render if popoverContent was
-    // truthy then. During the brief mid-recalculation render where
-    // popoverContent flips to null, this still reflects the prior (non-empty)
-    // value, letting us keep the trigger mounted across the transient.
-    const hadPopoverContent = usePrevious(!!popoverContent, false);
-
-    const showDropdownButton =
-      !!popoverContent || (recalculating && hadPopoverContent);
-
     useLayoutEffect(() => {
       if (popoverVisible) {
         // Measures scroll height after rendering the elements
@@ -334,7 +314,7 @@ export const DropdownContainer = forwardRef(
         >
           {notOverflowedItems.map(item => item.element)}
         </div>
-        {showDropdownButton && (
+        {popoverContent && (
           <>
             <Global
               styles={css`
@@ -368,13 +348,8 @@ export const DropdownContainer = forwardRef(
               }}
               content={popoverContent}
               trigger="click"
-              open={popoverVisible && !!popoverContent}
-              onOpenChange={visible => {
-                // While a recalculation keeps the trigger mounted but there is
-                // no content yet, ignore open attempts so it stays visible
-                // without opening an empty popover.
-                if (popoverContent) setPopoverVisible(visible);
-              }}
+              open={popoverVisible}
+              onOpenChange={visible => setPopoverVisible(visible)}
               placement="bottom"
               forceRender={forceRender}
               fresh // This prop prevents caching and stale data for filter scoping.

superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx

@@ -16,35 +16,21 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import {
-  isValidElement,
-  cloneElement,
-  useMemo,
-  useRef,
-  useState,
-  type ComponentType,
-} from 'react';
+import { isValidElement, cloneElement, useMemo, useRef, useState } from 'react';
 import { isNil } from 'lodash';
 import { t } from '@apache-superset/core/translation';
 import { css, styled, useTheme } from '@apache-superset/core/theme';
 import { Modal as AntdModal, ModalProps as AntdModalProps } from 'antd';
 import { Resizable } from 're-resizable';
-import RawDraggable, {
+import Draggable, {
   DraggableBounds,
   DraggableData,
   DraggableEvent,
-  DraggableProps,
 } from 'react-draggable';
 import { Icons } from '../Icons';
 import { Button } from '../Button';
 import type { ModalProps, StyledModalProps } from './types';
 
-// react-draggable 4.6.0 ships generated types that mark every Draggable prop as
-// required (its LibraryManagedAttributes no longer honors defaultProps), even
-// though the component accepts a Partial<DraggableProps> at runtime. Re-type the
-// component so optional props stay optional, preserving the prior behavior.
-const Draggable = RawDraggable as ComponentType<Partial<DraggableProps>>;
-
 const MODAL_HEADER_HEIGHT = 55;
 const MODAL_MIN_CONTENT_HEIGHT = 54;
 const MODAL_FOOTER_HEIGHT = 65;
@@ -260,7 +246,7 @@ const CustomModal = ({
     [bodyStyle, stylesProp],
   );
   const draggableRef = useRef<HTMLDivElement>(null);
-  const [bounds, setBounds] = useState<DraggableBounds>({});
+  const [bounds, setBounds] = useState<DraggableBounds>();
   const [dragDisabled, setDragDisabled] = useState<boolean>(true);
   const theme = useTheme();
 
@@ -369,7 +355,7 @@ const CustomModal = ({
         resizable || draggable ? (
           <Draggable
             disabled={!draggable || dragDisabled}
-            bounds={bounds ?? false}
+            bounds={bounds}
             onStart={(event, uiData) => onDragStart(event, uiData)}
             {...draggableConfig}
           >

superset-frontend/packages/superset-ui-core/src/components/Modal/types.ts

@@ -47,7 +47,7 @@ export interface ModalProps {
   resizable?: boolean;
   resizableConfig?: ResizableProps;
   draggable?: boolean;
-  draggableConfig?: Partial<DraggableProps>;
+  draggableConfig?: DraggableProps;
   destroyOnHidden?: boolean;
   maskClosable?: boolean;
   zIndex?: number;

superset-frontend/packages/superset-ui-core/src/components/SafeMarkdown/SafeMarkdown.tsx

@@ -31,53 +31,6 @@ interface SafeMarkdownProps {
   htmlSchemaOverrides?: typeof defaultSchema;
 }
 
-// Link protocols that can execute script when used as an href.
-const DANGEROUS_LINK_PROTOCOLS = ['javascript', 'vbscript', 'data'];
-
-/**
- * Sanitize link hrefs without using react-markdown's default protocol
- * allowlist, which would strip the custom link schemes that Superset markdown
- * is expected to support (see #26211). Instead of allowlisting known-safe
- * protocols, this blocks the protocols that enable script execution and leaves
- * everything else (http(s), mailto, relative URLs, anchors and custom schemes)
- * untouched. Applied regardless of the EscapeMarkdownHtml feature flag.
- */
-export function transformLinkUri(uri: string): string {
-  // Per the WHATWG URL parser, browsers strip leading C0 control
-  // characters (\x00-\x1f) and space before resolving the scheme, so e.g.
-  // "\x01javascript:alert(1)" executes on click. Strip them here too,
-  // otherwise the blocklist check below could be bypassed with a leading
-  // control character. The pattern is anchored at the start so it runs in
-  // linear time; trailing whitespace does not affect the scheme and is
-  // left for the renderer to handle.
-  // eslint-disable-next-line no-control-regex
-  const url = (uri || '').replace(/^[\u0000-\u0020]+/, '');
-  const first = url.charAt(0);
-  // Anchors and absolute/relative paths have no protocol.
-  if (first === '#' || first === '/') {
-    return url;
-  }
-  const colon = url.indexOf(':');
-  if (colon === -1) {
-    return url;
-  }
-  // A ':' after a '?' or '#' belongs to the query/fragment, not a scheme.
-  const queryIndex = url.indexOf('?');
-  if (queryIndex !== -1 && colon > queryIndex) {
-    return url;
-  }
-  const hashIndex = url.indexOf('#');
-  if (hashIndex !== -1 && colon > hashIndex) {
-    return url;
-  }
-  // Whitespace and C0 control characters inside the scheme (e.g.
-  // "java\tscript:" or "java\x01script:") are ignored by browsers, so strip
-  // them before comparing against the blocklist.
-  // eslint-disable-next-line no-control-regex
-  const scheme = url.slice(0, colon).replace(/[\u0000-\u0020]/g, '').toLowerCase();
-  return DANGEROUS_LINK_PROTOCOLS.includes(scheme) ? '' : url;
-}
-
 export function getOverrideHtmlSchema(
   originalSchema: typeof defaultSchema,
   htmlSchemaOverrides: SafeMarkdownProps['htmlSchemaOverrides'],
@@ -129,7 +82,7 @@ export function SafeMarkdown({
       rehypePlugins={rehypePlugins}
       remarkPlugins={[remarkGfm]}
       skipHtml={false}
-      transformLinkUri={transformLinkUri}
+      transformLinkUri={null}
     >
       {source}
     </ReactMarkdown>

superset-frontend/packages/superset-ui-core/src/components/Table/index.tsx

@@ -295,7 +295,6 @@ export function Table<RecordType extends object>(
     onRow,
     allowHTML = false,
     childrenColumnName,
-    expandable: expandableProp,
     ...rest
   } = props;
 
@@ -428,7 +427,6 @@ export function Table<RecordType extends object>(
     bordered,
     expandable: {
       childrenColumnName,
-      ...expandableProp,
     },
   };
 

superset-frontend/packages/superset-ui-core/src/components/TableCollection/TableCollection.test.tsx

@@ -214,12 +214,6 @@ test('Bulk selection should work with pagination', () => {
   // Check that selection checkboxes are rendered
   const checkboxes = screen.getAllByRole('checkbox');
   expect(checkboxes.length).toBeGreaterThan(0);
-
-  // Guard: the select-all column header carries `data-test="header-toggle-all"`,
-  // which the `header.cell` slot keys on antd's internal `ant-table-selection-column`
-  // class. If antd renames that class, this assertion fails fast at the unit level
-  // instead of leaking into Playwright as a flake.
-  expect(screen.getByTestId('header-toggle-all')).toBeInTheDocument();
 });
 
 test('should call setSortBy when clicking sortable column header', () => {

superset-frontend/packages/superset-ui-core/src/components/TableCollection/index.tsx

@@ -30,7 +30,7 @@ import { Table, TableSize } from '@superset-ui/core/components/Table';
 import { TableRowSelection, SorterResult } from 'antd/es/table/interface';
 import { mapColumns, mapRows } from './utils';
 
-export interface TableCollectionProps<T extends object> {
+interface TableCollectionProps<T extends object> {
   getTableProps: TablePropGetter<T>;
   getTableBodyProps: TableBodyPropGetter<T>;
   prepareRow: (row: Row<T>) => void;
@@ -53,7 +53,6 @@ export interface TableCollectionProps<T extends object> {
   onPageChange?: (page: number, pageSize: number) => void;
   isPaginationSticky?: boolean;
   showRowCount?: boolean;
-  expandable?: Record<string, unknown>;
 }
 
 const StyledTable = styled(Table)<{
@@ -178,7 +177,6 @@ function TableCollection<T extends object>({
   onPageChange,
   isPaginationSticky = false,
   showRowCount = true,
-  expandable,
 }: TableCollectionProps<T>) {
   const mappedColumns = useMemo(
     () => mapColumns<T>(columns, headerGroups, columnsForWrapText),
@@ -198,14 +196,6 @@ function TableCollection<T extends object>({
   const rowSelection: TableRowSelection | undefined = useMemo(() => {
     if (!bulkSelectEnabled) return undefined;
 
-    // antd Table's `rowSelection` API renders its own checkbox column.
-    // The select-all `data-test` lives on the `<th>` via `header.cell`
-    // below (keyed on antd's `ant-table-selection-column` className), NOT
-    // via `columnTitle` — rc-table's MeasureCell renders the column
-    // `title` verbatim inside `<tbody>`, so a `columnTitle` wrapper leaks
-    // any `data-test` attr into the measure row and breaks Playwright
-    // strict-mode selectors. `renderCell` only renders in real body rows,
-    // so wrapping per-row checkboxes there is safe.
     return {
       selectedRowKeys,
       onSelect: (record, selected) => {
@@ -214,9 +204,6 @@ function TableCollection<T extends object>({
       onSelectAll: (selected: boolean) => {
         toggleAllRowsSelected?.(selected);
       },
-      renderCell: (_value, _record, _index, originNode) => (
-        <span data-test="row-select-checkbox">{originNode}</span>
-      ),
     };
   }, [
     bulkSelectEnabled,
@@ -317,21 +304,11 @@ function TableCollection<T extends object>({
       isPaginationSticky={isPaginationSticky}
       showRowCount={showRowCount}
       rowClassName={getRowClassName}
-      expandable={expandable}
       components={{
         header: {
-          cell: (props: HTMLAttributes<HTMLTableCellElement>) => {
-            const isSelectionColumn =
-              props.className?.includes('ant-table-selection-column') ?? false;
-            return (
-              <th
-                {...props}
-                data-test={
-                  isSelectionColumn ? 'header-toggle-all' : 'sort-header'
-                }
-              />
-            );
-          },
+          cell: (props: HTMLAttributes<HTMLTableCellElement>) => (
+            <th {...props} data-test="sort-header" />
+          ),
         },
         body: {
           row: (props: HTMLAttributes<HTMLTableRowElement>) => (

superset-frontend/packages/superset-ui-core/src/number-format/README.md

@@ -64,15 +64,15 @@ NumberFormats.PERCENT; // ,.2%
 NumberFormats.PERCENT_3_POINT; // ,.3%
 ```
 
-There is also a formatter based on [Intl.DurationFormat](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DurationFormat) that can be
+There is also a formatter based on [pretty-ms](https://www.npmjs.com/package/pretty-ms) that can be
 used to format time durations:
 
 ```js
 import { createDurationFormatter, formatNumber, getNumberFormatterRegistry } from '@superset-ui-number-format';
 
-getNumberFormatterRegistry().registerValue('my_duration_format', createDurationFormatter({ style: 'digital' }));
+getNumberFormatterRegistry().registerValue('my_duration_format', createDurationFormatter({ colonNotation: true });
 console.log(formatNumber('my_duration_format', 95500))
-// prints '0:01:35'
+// prints '1:35.5'
 ```
 
 #### API

superset-frontend/packages/superset-ui-core/src/number-format/factories/createDurationFormatter.ts

@@ -17,9 +17,8 @@
  * under the License.
  */
 
+import prettyMilliseconds, { Options } from 'pretty-ms';
 import NumberFormatter from '../NumberFormatter';
-import { getIntlDurationFormatter } from '../utils/getIntlDurationFormatter';
-import { parseMilliseconds } from '../utils/parseMilliseconds';
 
 export default function createDurationFormatter(
   config: {
@@ -27,48 +26,14 @@ export default function createDurationFormatter(
     id?: string;
     label?: string;
     multiplier?: number;
-    locale?: string;
-    formatSubMilliseconds?: boolean;
-  } & Intl.DurationFormatOptions = {},
+  } & Options = {},
 ) {
-  const {
-    description,
-    id,
-    label,
-    multiplier = 1,
-    locale,
-    formatSubMilliseconds = false,
-    ...intlOptions
-  } = config;
-  const durationFormatter = getIntlDurationFormatter(locale, {
-    secondsDisplay: 'auto',
-    style: 'narrow',
-    ...intlOptions,
-  });
-  const zeroDurationFormatter = getIntlDurationFormatter(locale, {
-    secondsDisplay: 'always',
-    style: 'narrow',
-    ...intlOptions,
-  });
+  const { description, id, label, multiplier = 1, ...prettyMsOptions } = config;
+
   return new NumberFormatter({
     description,
-    formatFunc: value => {
-      const durObject = parseMilliseconds(value * multiplier);
-
-      if (!formatSubMilliseconds) {
-        durObject.milliseconds = 0;
-        durObject.microseconds = 0;
-        durObject.nanoseconds = 0;
-      }
-
-      const isAllUnitsZero = Object.values(durObject).every(
-        value => value === 0,
-      );
-
-      return (
-        isAllUnitsZero ? zeroDurationFormatter : durationFormatter
-      ).format(durObject);
-    },
+    formatFunc: value =>
+      prettyMilliseconds(value * multiplier, prettyMsOptions),
     id: id ?? 'duration_format',
     label: label ?? `Duration formatter`,
   });

superset-frontend/packages/superset-ui-core/src/number-format/utils/getIntlDurationFormatter.ts

@@ -1,30 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-export function getIntlDurationFormatter(
-  locale?: string,
-  options?: Intl.DurationFormatOptions,
-): Intl.DurationFormat {
-  const normalizedLocale = locale?.replace(/_/g, '-');
-  try {
-    return new Intl.DurationFormat(normalizedLocale, options);
-  } catch {
-    return new Intl.DurationFormat('en', options);
-  }
-}

superset-frontend/packages/superset-ui-core/src/number-format/utils/parseMilliseconds.ts

@@ -1,57 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import parseMs from 'parse-ms';
-
-interface Duration {
-  years: number;
-  days: number;
-  hours: number;
-  minutes: number;
-  seconds: number;
-  milliseconds: number;
-  microseconds: number;
-  nanoseconds: number;
-}
-
-const DAYS_IN_YEAR = 365;
-
-/**
- * Parses milliseconds into a duration object.
-
- * @param ms - The number of milliseconds to parse
- * @returns A duration object containing years, days, hours, minutes, seconds,
- *          milliseconds, microseconds, and nanoseconds (1 year = 365 days)
- * @example
- * // Parse a complex duration
- * parseMilliseconds(90061000);
- * // { years: 0, days: 1, hours: 1, minutes: 1, seconds: 1, milliseconds: 0, ... }
- */
-export function parseMilliseconds(ms: number): Duration {
-  const parsed = parseMs(ms);
-  const totalDays = parsed.days;
-  const years = Math.trunc(totalDays / DAYS_IN_YEAR);
-  const remainingDays = totalDays % DAYS_IN_YEAR;
-
-  return {
-    ...parsed,
-    years,
-    days: remainingDays,
-  };
-}

superset-frontend/packages/superset-ui-core/src/query/types/Dashboard.ts

@@ -102,6 +102,7 @@ export type ChartCustomization = {
   defaultDataMask: DataMask;
   controlValues: {
     sortAscending?: boolean;
+    sortMetric?: string;
     [key: string]: any;
   };
   description?: string;

superset-frontend/packages/superset-ui-core/test/components/SafeMarkdown.test.tsx

@@ -20,7 +20,6 @@ import { render } from '@testing-library/react';
 import {
   getOverrideHtmlSchema,
   SafeMarkdown,
-  transformLinkUri,
 } from '../../src/components/SafeMarkdown/SafeMarkdown';
 
 /**
@@ -53,63 +52,6 @@ describe('getOverrideHtmlSchema', () => {
   });
 });
 
-describe('transformLinkUri', () => {
-  // Build script-executing protocols via concatenation so the literal URLs
-  // don't trip the no-script-url lint rule.
-  const js = `java${'script'}`;
-  const vbs = `vb${'script'}`;
-
-  // Cases are [label, uri] pairs: the raw URIs contain C0 control characters
-  // (\x00, \x01, \x1F) that are invalid in XML, so they must not be
-  // interpolated into the test name (the HTML/JUnit reporters serialize names
-  // to XML and would crash). The label keeps the reported name printable while
-  // the uri is exercised in the body.
-  test.each([
-    ['javascript', `${js}:alert(1)`],
-    ['mixed-case JavaScript', `Java${'Script'}:alert(1)`],
-    ['leading whitespace', `  ${js}:alert(document.cookie)`],
-    ['tab inside scheme', `java\t${'script'}:alert(1)`],
-    // Leading C0 control characters are stripped by the WHATWG URL parser
-    // before the scheme is resolved, so they must not bypass the blocklist.
-    ['leading 0x01 control', `\x01${js}:alert(1)`],
-    ['leading NUL (0x00)', `\x00${js}:alert(1)`],
-    ['leading 0x1F control', `\x1F${js}:alert(1)`],
-    // C0 control characters inside the scheme are ignored by browsers too.
-    ['0x01 control inside scheme', `java\x01${'script'}:alert(1)`],
-    ['vbscript', `${vbs}:msgbox(1)`],
-    ['data: text/html', 'data:text/html,<script>alert(1)</script>'],
-  ])(
-    'blocks the script-executing protocol (%s)',
-    (_label: string, uri: string) => {
-      expect(transformLinkUri(uri)).toBe('');
-    },
-  );
-
-  test.each([
-    'https://superset.apache.org',
-    'http://example.com/path?q=1',
-    'mailto:someone@example.com',
-    '/relative/path',
-    '#section',
-  ])('keeps the safe URL %p unchanged', uri => {
-    expect(transformLinkUri(uri)).toBe(uri);
-  });
-
-  test.each([
-    'custom-scheme://open/thing',
-    'slack://channel?id=1',
-    `foo:bar?${js}:alert(1)`,
-  ])('preserves custom link scheme %p (see #26211)', uri => {
-    expect(transformLinkUri(uri)).toBe(uri);
-  });
-
-  test('handles empty and nullish input', () => {
-    expect(transformLinkUri('')).toBe('');
-    // @ts-expect-error -- guarding runtime nullish input
-    expect(transformLinkUri(undefined)).toBe('');
-  });
-});
-
 describe('SafeMarkdown', () => {
   describe('remark-gfm compatibility tests', () => {
     /**

superset-frontend/packages/superset-ui-core/test/number-format/factories/createDurationFormatter.test.ts

@@ -26,31 +26,34 @@ test('creates an instance of NumberFormatter', () => {
 test('format milliseconds in human readable format with default options', () => {
   const formatter = createDurationFormatter();
   expect(formatter(-1000)).toBe('-1s');
-  expect(formatter(0)).toBe('0s');
+  expect(formatter(0)).toBe('0ms');
   expect(formatter(1000)).toBe('1s');
-  expect(formatter(1337)).toBe('1s');
-  expect(formatter(10500)).toBe('10s');
+  expect(formatter(1337)).toBe('1.3s');
+  expect(formatter(10500)).toBe('10.5s');
   expect(formatter(60 * 1000)).toBe('1m');
   expect(formatter(90 * 1000)).toBe('1m 30s');
 });
 test('format seconds in human readable format with default options', () => {
   const formatter = createDurationFormatter({ multiplier: 1000 });
-  expect(formatter(-0.5)).toBe('-0s');
-  expect(formatter(0.5)).toBe('0s');
+  expect(formatter(-0.5)).toBe('-500ms');
+  expect(formatter(0.5)).toBe('500ms');
   expect(formatter(1)).toBe('1s');
   expect(formatter(30)).toBe('30s');
   expect(formatter(60)).toBe('1m');
   expect(formatter(90)).toBe('1m 30s');
 });
-test('format milliseconds in human readable format with additional options', () => {
+test('format milliseconds in human readable format with additional pretty-ms options', () => {
   const colonNotationFormatter = createDurationFormatter({
-    style: 'digital',
-    formatSubMilliseconds: true,
-    fractionalDigits: 1,
+    colonNotation: true,
   });
-  expect(colonNotationFormatter(10500)).toBe('0:00:10.5');
+  expect(colonNotationFormatter(-10500)).toBe('-0:10.5');
+  expect(colonNotationFormatter(10500)).toBe('0:10.5');
+  const zeroDecimalFormatter = createDurationFormatter({
+    secondsDecimalDigits: 0,
+  });
+  expect(zeroDecimalFormatter(10500)).toBe('10s');
   const subMillisecondFormatter = createDurationFormatter({
     formatSubMilliseconds: true,
   });
-  expect(subMillisecondFormatter(100.40008)).toBe('100ms 400μs 80ns');
+  expect(subMillisecondFormatter(100.40008)).toBe('100ms 400µs 80ns');
 });

superset-frontend/packages/superset-ui-core/test/number-format/utils/getIntlDurationFormatter.test.ts

@@ -1,38 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { getIntlDurationFormatter } from '@superset-ui/core/number-format/utils/getIntlDurationFormatter';
-
-test('getIntlDurationFormatter creates formatter with fallback locale when passed locale is invalid', () => {
-  const formatter = getIntlDurationFormatter('invalid-locale-xyz');
-  expect(formatter).toBeInstanceOf(Intl.DurationFormat);
-  expect(formatter.format({ seconds: 60 })).toBe('60 sec');
-});
-
-test('getIntlDurationFormatter creates formatter with custom options', () => {
-  const formatter = getIntlDurationFormatter('en', { style: 'digital' });
-  expect(formatter).toBeInstanceOf(Intl.DurationFormat);
-  expect(formatter.format({ minutes: 5, seconds: 30 })).toContain(':');
-});
-
-test('getIntlDurationFormatter normalizes locale underscores', () => {
-  const formatter = getIntlDurationFormatter('zh_Hans_CN');
-  expect(formatter).toBeInstanceOf(Intl.DurationFormat);
-  expect(formatter.resolvedOptions().locale).toMatch(/^zh/);
-});

superset-frontend/packages/superset-ui-core/test/number-format/utils/parseMilliseconds.test.ts

@@ -1,148 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { parseMilliseconds } from '@superset-ui/core/number-format/utils/parseMilliseconds';
-
-test('parseMilliseconds should parse basic time units correctly', () => {
-  expect(parseMilliseconds(500)).toEqual({
-    years: 0,
-    days: 0,
-    hours: 0,
-    minutes: 0,
-    seconds: 0,
-    milliseconds: 500,
-    microseconds: 0,
-    nanoseconds: 0,
-  });
-  expect(parseMilliseconds(5000)).toEqual({
-    years: 0,
-    days: 0,
-    hours: 0,
-    minutes: 0,
-    seconds: 5,
-    milliseconds: 0,
-    microseconds: 0,
-    nanoseconds: 0,
-  });
-  expect(parseMilliseconds(120000)).toEqual({
-    years: 0,
-    days: 0,
-    hours: 0,
-    minutes: 2,
-    seconds: 0,
-    milliseconds: 0,
-    microseconds: 0,
-    nanoseconds: 0,
-  });
-  expect(parseMilliseconds(7200000)).toEqual({
-    years: 0,
-    days: 0,
-    hours: 2,
-    minutes: 0,
-    seconds: 0,
-    milliseconds: 0,
-    microseconds: 0,
-    nanoseconds: 0,
-  });
-  expect(parseMilliseconds(172800000)).toEqual({
-    years: 0,
-    days: 2,
-    hours: 0,
-    minutes: 0,
-    seconds: 0,
-    milliseconds: 0,
-    microseconds: 0,
-    nanoseconds: 0,
-  });
-  expect(parseMilliseconds(31536000000)).toEqual({
-    years: 1,
-    days: 0,
-    hours: 0,
-    minutes: 0,
-    seconds: 0,
-    milliseconds: 0,
-    microseconds: 0,
-    nanoseconds: 0,
-  });
-});
-
-test('parseMilliseconds should handle complex duration', () => {
-  expect(parseMilliseconds(90061234)).toEqual({
-    years: 0,
-    days: 1,
-    hours: 1,
-    minutes: 1,
-    seconds: 1,
-    milliseconds: 234,
-    microseconds: 0,
-    nanoseconds: 0,
-  });
-});
-
-test('parseMilliseconds should handle fractional milliseconds', () => {
-  expect(parseMilliseconds(1.001001)).toEqual({
-    years: 0,
-    days: 0,
-    hours: 0,
-    minutes: 0,
-    seconds: 0,
-    milliseconds: 1,
-    microseconds: 1,
-    nanoseconds: 1,
-  });
-});
-
-test('parseMilliseconds should handle zero', () => {
-  expect(parseMilliseconds(0)).toEqual({
-    years: 0,
-    days: 0,
-    hours: 0,
-    minutes: 0,
-    seconds: 0,
-    milliseconds: 0,
-    microseconds: 0,
-    nanoseconds: 0,
-  });
-});
-
-test('parseMilliseconds should handle negative duration', () => {
-  expect(parseMilliseconds(-1000)).toEqual({
-    years: -0,
-    days: -0,
-    hours: -0,
-    minutes: -0,
-    seconds: -1,
-    milliseconds: -0,
-    microseconds: -0,
-    nanoseconds: -0,
-  });
-});
-
-test('parseMilliseconds should handle negative days without overflowing into years', () => {
-  expect(parseMilliseconds(-31449600000)).toEqual({
-    years: -0,
-    days: -364,
-    hours: -0,
-    minutes: -0,
-    seconds: -0,
-    milliseconds: -0,
-    microseconds: -0,
-    nanoseconds: -0,
-  });
-});

superset-frontend/packages/superset-ui-core/types/intl.d.ts

@@ -1,73 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-declare namespace Intl {
-  class DurationFormat {
-    constructor(locale?: string | string[], options?: DurationFormatOptions);
-    format(duration: DurationObject): string;
-    formatToParts(
-      duration: DurationObject,
-    ): { type: string; value: string; unit?: string }[];
-    resolvedOptions(): ResolvedDurationFormatOptions;
-  }
-
-  interface DurationObject {
-    years?: number;
-    months?: number;
-    weeks?: number;
-    days?: number;
-    hours?: number;
-    minutes?: number;
-    seconds?: number;
-    milliseconds?: number;
-    microseconds?: number;
-    nanoseconds?: number;
-  }
-
-  interface DurationFormatOptions {
-    localeMatcher?: 'lookup' | 'best fit';
-    numberingSystem?: string;
-    style?: 'long' | 'short' | 'narrow' | 'digital';
-    years?: 'long' | 'short' | 'narrow';
-    yearsDisplay?: 'always' | 'auto';
-    months?: 'long' | 'short' | 'narrow';
-    monthsDisplay?: 'always' | 'auto';
-    weeks?: 'long' | 'short' | 'narrow';
-    weeksDisplay?: 'always' | 'auto';
-    days?: 'long' | 'short' | 'narrow';
-    daysDisplay?: 'always' | 'auto';
-    hours?: 'long' | 'short' | 'narrow' | 'numeric' | '2-digit';
-    hoursDisplay?: 'always' | 'auto';
-    minutes?: 'long' | 'short' | 'narrow' | 'numeric' | '2-digit';
-    minutesDisplay?: 'always' | 'auto';
-    seconds?: 'long' | 'short' | 'narrow' | 'numeric' | '2-digit';
-    secondsDisplay?: 'always' | 'auto';
-    milliseconds?: 'long' | 'short' | 'narrow' | 'numeric';
-    millisecondsDisplay?: 'always' | 'auto';
-    microseconds?: 'long' | 'short' | 'narrow' | 'numeric';
-    microsecondsDisplay?: 'always' | 'auto';
-    nanoseconds?: 'long' | 'short' | 'narrow' | 'numeric';
-    nanosecondsDisplay?: 'always' | 'auto';
-    fractionalDigits?: number;
-  }
-
-  interface ResolvedDurationFormatOptions extends DurationFormatOptions {
-    locale: string;
-  }
-}

superset-frontend/playwright/components/ListView/BulkSelect.ts

@@ -17,24 +17,14 @@
  * under the License.
  */
 
-import { Locator, Page, expect } from '@playwright/test';
+import { Locator, Page } from '@playwright/test';
 import { Button, Checkbox, Table } from '../core';
 
 const BULK_SELECT_SELECTORS = {
   CONTROLS: '[data-test="bulk-select-controls"]',
   ACTION: '[data-test="bulk-select-action"]',
-  HEADER_TOGGLE: '[data-test="header-toggle-all"]',
-  ROW_CHECKBOX: '[data-test="row-select-checkbox"]',
 } as const;
 
-/**
- * Stable keys for ListView bulk actions, matching `action.key` in the
- * `bulkActions` prop passed to `ListView` (see `src/pages/*List`). Using
- * the key — not the localized button text — keeps selectors valid across
- * locales.
- */
-export type BulkSelectActionKey = 'delete' | 'export';
-
 /**
  * BulkSelect component for Superset ListView bulk operations.
  * Provides a reusable interface for bulk selection and actions across list pages.
@@ -44,7 +34,7 @@ export type BulkSelectActionKey = 'delete' | 'export';
  * await bulkSelect.enable();
  * await bulkSelect.selectRow('my-dataset');
  * await bulkSelect.selectRow('another-dataset');
- * await bulkSelect.clickAction('delete');
+ * await bulkSelect.clickAction('Delete');
  */
 export class BulkSelect {
   private readonly page: Page;
@@ -66,67 +56,35 @@ export class BulkSelect {
   }
 
   /**
-   * Enables bulk selection mode by clicking the toggle button.
-   *
-   * Waits for the bulk-select column header to render so the next row
-   * interaction does not race the table re-render that adds the checkbox
-   * column. The `data-test="header-toggle-all"` attribute is on the
-   * select-all `<th>` itself (see `TableCollection`'s `components.header.cell`
-   * slot, which keys on antd's `ant-table-selection-column` className).
-   * It deliberately is NOT injected via `rowSelection.columnTitle` because
-   * rc-table's measure row in `<tbody>` clones `columnTitle` and any
-   * `data-test` would duplicate, breaking Playwright strict mode.
+   * Enables bulk selection mode by clicking the toggle button
    */
   async enable(): Promise<void> {
     await this.getToggleButton().click();
-    await this.page.locator(BULK_SELECT_SELECTORS.HEADER_TOGGLE).waitFor();
   }
 
   /**
-   * Gets the bulk-select checkbox for a row by name.
-   *
-   * The `data-test="row-select-checkbox"` attribute is on the `<span>`
-   * wrapper that `TableCollection`'s `rowSelection.renderCell` puts around
-   * antd's checkbox originNode (the attribute can't be moved directly
-   * onto antd's `<input>` from `renderCell` because the originNode is
-   * opaque). We drill into `input[type="checkbox"]` so Playwright's
-   * `.check()` operates on the real input — `.check()` on the wrapper
-   * `<span>` throws "Not a checkbox or radio button".
-   *
+   * Gets the checkbox for a row by name
    * @param rowName - The name/text identifying the row
    */
   getRowCheckbox(rowName: string): Checkbox {
     const row = this.table.getRow(rowName);
-    return new Checkbox(
-      this.page,
-      row.locator(
-        `${BULK_SELECT_SELECTORS.ROW_CHECKBOX} input[type="checkbox"]`,
-      ),
-    );
+    return new Checkbox(this.page, row.getByRole('checkbox'));
   }
 
   /**
-   * Selects a row's checkbox in bulk select mode.
-   * Asserts the checkbox is checked afterwards so any state-update race
-   * surfaces here rather than as a missing bulk-action button later.
+   * Selects a row's checkbox in bulk select mode
    * @param rowName - The name/text identifying the row to select
    */
   async selectRow(rowName: string): Promise<void> {
-    const checkbox = this.getRowCheckbox(rowName);
-    await checkbox.check();
-    await expect(checkbox.element).toBeChecked();
+    await this.getRowCheckbox(rowName).check();
   }
 
   /**
-   * Deselects a row's checkbox in bulk select mode.
-   * Mirrors selectRow: asserts the unchecked state so any lingering selection
-   * surfaces here rather than as a stale bulk-action count later.
+   * Deselects a row's checkbox in bulk select mode
    * @param rowName - The name/text identifying the row to deselect
    */
   async deselectRow(rowName: string): Promise<void> {
-    const checkbox = this.getRowCheckbox(rowName);
-    await checkbox.uncheck();
-    await expect(checkbox.element).not.toBeChecked();
+    await this.getRowCheckbox(rowName).uncheck();
   }
 
   /**
@@ -137,30 +95,22 @@ export class BulkSelect {
   }
 
   /**
-   * Gets a bulk action button by its stable action key.
-   *
-   * Scoping by `data-test-action-key` (rendered from `action.key`) instead
-   * of visible text keeps this selector valid across locales — the
-   * button's label is localized via i18n, but the action key is not.
-   *
-   * @param actionKey - The stable key of the bulk action (e.g., "delete", "export")
+   * Gets a bulk action button by name
+   * @param actionName - The name of the bulk action (e.g., "Export", "Delete")
    */
-  getActionButton(actionKey: BulkSelectActionKey): Button {
+  getActionButton(actionName: string): Button {
     const controls = this.getControls();
     return new Button(
       this.page,
-      controls.locator(
-        `${BULK_SELECT_SELECTORS.ACTION}[data-test-action-key="${actionKey}"]`,
-      ),
+      controls.locator(BULK_SELECT_SELECTORS.ACTION, { hasText: actionName }),
     );
   }
 
   /**
-   * Clicks a bulk action button by its stable action key.
-   * @param actionKey - The stable key of the bulk action to click
+   * Clicks a bulk action button by name (e.g., "Export", "Delete")
+   * @param actionName - The name of the bulk action to click
    */
-  async clickAction(actionKey: BulkSelectActionKey): Promise<void> {
-    const button = this.getActionButton(actionKey);
-    await button.click();
+  async clickAction(actionName: string): Promise<void> {
+    await this.getActionButton(actionName).click();
   }
 }

superset-frontend/playwright/components/ListView/index.ts

@@ -19,4 +19,3 @@
 
 // ListView-specific Playwright Components for Superset
 export { BulkSelect } from './BulkSelect';
-export type { BulkSelectActionKey } from './BulkSelect';

superset-frontend/playwright/components/modals/DeleteConfirmationModal.ts

@@ -17,7 +17,6 @@
  * under the License.
  */
 
-import { expect } from '@playwright/test';
 import { Modal, Input } from '../core';
 
 /**
@@ -28,8 +27,7 @@ import { Modal, Input } from '../core';
  */
 export class DeleteConfirmationModal extends Modal {
   private static readonly SELECTORS = {
-    CONFIRMATION_INPUT: '[data-test="delete-modal-input"]',
-    CONFIRM_BUTTON: '[data-test="modal-confirm-button"]',
+    CONFIRMATION_INPUT: 'input[type="text"]',
   };
 
   /**
@@ -38,16 +36,12 @@ export class DeleteConfirmationModal extends Modal {
   private get confirmationInput(): Input {
     return new Input(
       this.page,
-      this.element.locator(
-        DeleteConfirmationModal.SELECTORS.CONFIRMATION_INPUT,
-      ),
+      this.body.locator(DeleteConfirmationModal.SELECTORS.CONFIRMATION_INPUT),
     );
   }
 
   /**
    * Fills the confirmation input with the specified text.
-   * Waits for the input to be visible before filling so callers don't race
-   * with the modal's open animation / focus effect.
    *
    * @param confirmationText - The text to type
    * @param options - Optional fill options (timeout, force)
@@ -63,25 +57,11 @@ export class DeleteConfirmationModal extends Modal {
     confirmationText: string,
     options?: { timeout?: number; force?: boolean },
   ): Promise<void> {
-    await this.confirmationInput.element.waitFor({
-      state: 'visible',
-      timeout: options?.timeout,
-    });
     await this.confirmationInput.fill(confirmationText, options);
   }
 
   /**
-   * Clicks the Delete button in the footer.
-   *
-   * Targets the confirm button by data-test rather than going through
-   * Modal.clickFooterButton, which finds buttons by their visible text. The
-   * button label is i18n'd ("Delete" / "Supprimer" / …) so name-based lookups
-   * break in non-English locales.
-   *
-   * Also waits for the button to become enabled before clicking: it is
-   * disabled until the confirmation text matches "DELETE", and React's state
-   * update from fillConfirmationInput is asynchronous, so an immediate click
-   * can race the disabled→enabled transition.
+   * Clicks the Delete button in the footer
    *
    * @param options - Optional click options (timeout, force, delay)
    */
@@ -90,10 +70,6 @@ export class DeleteConfirmationModal extends Modal {
     force?: boolean;
     delay?: number;
   }): Promise<void> {
-    const confirmButton = this.element.locator(
-      DeleteConfirmationModal.SELECTORS.CONFIRM_BUTTON,
-    );
-    await expect(confirmButton).toBeEnabled({ timeout: options?.timeout });
-    await confirmButton.click(options);
+    await this.clickFooterButton('Delete', options);
   }
 }

superset-frontend/playwright/pages/ChartListPage.ts

@@ -19,7 +19,7 @@
 
 import { Page, Locator } from '@playwright/test';
 import { Table } from '../components/core';
-import { BulkSelect, BulkSelectActionKey } from '../components/ListView';
+import { BulkSelect } from '../components/ListView';
 import { gotoWithRetry } from '../helpers/navigation';
 import { URL } from '../utils/urls';
 
@@ -32,12 +32,13 @@ export class ChartListPage {
   readonly bulkSelect: BulkSelect;
 
   /**
-   * Stable data-test keys for the row action buttons in ChartList.
+   * Action button names for getByRole('button', { name })
+   * Verified: ChartList uses Icons.DeleteOutlined, Icons.UploadOutlined, Icons.EditOutlined
    */
-  private static readonly ACTION_TEST_IDS = {
-    DELETE: 'chart-row-delete',
-    EDIT: 'chart-row-edit',
-    EXPORT: 'chart-row-export',
+  private static readonly ACTION_BUTTONS = {
+    DELETE: 'delete',
+    EDIT: 'edit',
+    EXPORT: 'upload',
   } as const;
 
   constructor(page: Page) {
@@ -97,7 +98,9 @@ export class ChartListPage {
    */
   async clickDeleteAction(chartName: string): Promise<void> {
     const row = this.table.getRow(chartName);
-    await row.getByTestId(ChartListPage.ACTION_TEST_IDS.DELETE).click();
+    await row
+      .getByRole('button', { name: ChartListPage.ACTION_BUTTONS.DELETE })
+      .click();
   }
 
   /**
@@ -106,7 +109,9 @@ export class ChartListPage {
    */
   async clickEditAction(chartName: string): Promise<void> {
     const row = this.table.getRow(chartName);
-    await row.getByTestId(ChartListPage.ACTION_TEST_IDS.EDIT).click();
+    await row
+      .getByRole('button', { name: ChartListPage.ACTION_BUTTONS.EDIT })
+      .click();
   }
 
   /**
@@ -115,7 +120,9 @@ export class ChartListPage {
    */
   async clickExportAction(chartName: string): Promise<void> {
     const row = this.table.getRow(chartName);
-    await row.getByTestId(ChartListPage.ACTION_TEST_IDS.EXPORT).click();
+    await row
+      .getByRole('button', { name: ChartListPage.ACTION_BUTTONS.EXPORT })
+      .click();
   }
 
   /**
@@ -134,11 +141,11 @@ export class ChartListPage {
   }
 
   /**
-   * Clicks a bulk action button by its stable action key (e.g., "delete", "export").
-   * @param actionKey - The stable key of the bulk action to click
+   * Clicks a bulk action button by name (e.g., "Export", "Delete")
+   * @param actionName - The name of the bulk action to click
    */
-  async clickBulkAction(actionKey: BulkSelectActionKey): Promise<void> {
-    await this.bulkSelect.clickAction(actionKey);
+  async clickBulkAction(actionName: string): Promise<void> {
+    await this.bulkSelect.clickAction(actionName);
   }
 
   // --- Card view methods ---

superset-frontend/playwright/pages/DashboardListPage.ts

@@ -19,7 +19,7 @@
 
 import { Page, Locator } from '@playwright/test';
 import { Button, Table } from '../components/core';
-import { BulkSelect, BulkSelectActionKey } from '../components/ListView';
+import { BulkSelect } from '../components/ListView';
 import { gotoWithRetry } from '../helpers/navigation';
 import { URL } from '../utils/urls';
 
@@ -32,12 +32,13 @@ export class DashboardListPage {
   readonly bulkSelect: BulkSelect;
 
   /**
-   * Stable data-test keys for the row action buttons in DashboardList.
+   * Action button names for getByRole('button', { name })
+   * DashboardList uses Icons.DeleteOutlined, Icons.UploadOutlined, Icons.EditOutlined
    */
-  private static readonly ACTION_TEST_IDS = {
-    DELETE: 'dashboard-row-delete',
-    EDIT: 'dashboard-row-edit',
-    EXPORT: 'dashboard-row-export',
+  private static readonly ACTION_BUTTONS = {
+    DELETE: 'delete',
+    EDIT: 'edit',
+    EXPORT: 'upload',
   } as const;
 
   constructor(page: Page) {
@@ -80,7 +81,9 @@ export class DashboardListPage {
    */
   async clickDeleteAction(dashboardName: string): Promise<void> {
     const row = this.table.getRow(dashboardName);
-    await row.getByTestId(DashboardListPage.ACTION_TEST_IDS.DELETE).click();
+    await row
+      .getByRole('button', { name: DashboardListPage.ACTION_BUTTONS.DELETE })
+      .click();
   }
 
   /**
@@ -89,7 +92,9 @@ export class DashboardListPage {
    */
   async clickEditAction(dashboardName: string): Promise<void> {
     const row = this.table.getRow(dashboardName);
-    await row.getByTestId(DashboardListPage.ACTION_TEST_IDS.EDIT).click();
+    await row
+      .getByRole('button', { name: DashboardListPage.ACTION_BUTTONS.EDIT })
+      .click();
   }
 
   /**
@@ -98,7 +103,9 @@ export class DashboardListPage {
    */
   async clickExportAction(dashboardName: string): Promise<void> {
     const row = this.table.getRow(dashboardName);
-    await row.getByTestId(DashboardListPage.ACTION_TEST_IDS.EXPORT).click();
+    await row
+      .getByRole('button', { name: DashboardListPage.ACTION_BUTTONS.EXPORT })
+      .click();
   }
 
   /**
@@ -117,11 +124,11 @@ export class DashboardListPage {
   }
 
   /**
-   * Clicks a bulk action button by its stable action key (e.g., "delete", "export").
-   * @param actionKey - The stable key of the bulk action to click
+   * Clicks a bulk action button by name (e.g., "Export", "Delete")
+   * @param actionName - The name of the bulk action to click
    */
-  async clickBulkAction(actionKey: BulkSelectActionKey): Promise<void> {
-    await this.bulkSelect.clickAction(actionKey);
+  async clickBulkAction(actionName: string): Promise<void> {
+    await this.bulkSelect.clickAction(actionName);
   }
 
   /**

superset-frontend/playwright/pages/DatasetListPage.ts

@@ -19,7 +19,7 @@
 
 import { Page, Locator } from '@playwright/test';
 import { Button, Table } from '../components/core';
-import { BulkSelect, BulkSelectActionKey } from '../components/ListView';
+import { BulkSelect } from '../components/ListView';
 import { gotoWithRetry } from '../helpers/navigation';
 import { URL } from '../utils/urls';
 
@@ -36,14 +36,13 @@ export class DatasetListPage {
   } as const;
 
   /**
-   * Stable data-test keys for the row action buttons in DatasetList
-   * (shared with the semantic-view rendering since only one renders per row).
+   * Action button names for getByRole('button', { name })
    */
-  private static readonly ACTION_TEST_IDS = {
-    DELETE: 'dataset-row-delete',
-    EDIT: 'dataset-row-edit',
-    EXPORT: 'dataset-row-export',
-    DUPLICATE: 'dataset-row-duplicate',
+  private static readonly ACTION_BUTTONS = {
+    DELETE: 'delete',
+    EDIT: 'edit',
+    EXPORT: 'upload', // Export button uses upload icon
+    DUPLICATE: 'copy',
   } as const;
 
   constructor(page: Page) {
@@ -98,7 +97,9 @@ export class DatasetListPage {
    */
   async clickDeleteAction(datasetName: string): Promise<void> {
     const row = this.table.getRow(datasetName);
-    await row.getByTestId(DatasetListPage.ACTION_TEST_IDS.DELETE).click();
+    await row
+      .getByRole('button', { name: DatasetListPage.ACTION_BUTTONS.DELETE })
+      .click();
   }
 
   /**
@@ -107,7 +108,9 @@ export class DatasetListPage {
    */
   async clickEditAction(datasetName: string): Promise<void> {
     const row = this.table.getRow(datasetName);
-    await row.getByTestId(DatasetListPage.ACTION_TEST_IDS.EDIT).click();
+    await row
+      .getByRole('button', { name: DatasetListPage.ACTION_BUTTONS.EDIT })
+      .click();
   }
 
   /**
@@ -116,7 +119,9 @@ export class DatasetListPage {
    */
   async clickExportAction(datasetName: string): Promise<void> {
     const row = this.table.getRow(datasetName);
-    await row.getByTestId(DatasetListPage.ACTION_TEST_IDS.EXPORT).click();
+    await row
+      .getByRole('button', { name: DatasetListPage.ACTION_BUTTONS.EXPORT })
+      .click();
   }
 
   /**
@@ -125,7 +130,9 @@ export class DatasetListPage {
    */
   async clickDuplicateAction(datasetName: string): Promise<void> {
     const row = this.table.getRow(datasetName);
-    await row.getByTestId(DatasetListPage.ACTION_TEST_IDS.DUPLICATE).click();
+    await row
+      .getByRole('button', { name: DatasetListPage.ACTION_BUTTONS.DUPLICATE })
+      .click();
   }
 
   /**
@@ -144,11 +151,11 @@ export class DatasetListPage {
   }
 
   /**
-   * Clicks a bulk action button by its stable action key (e.g., "delete", "export").
-   * @param actionKey - The stable key of the bulk action to click
+   * Clicks a bulk action button by name (e.g., "Export", "Delete")
+   * @param actionName - The name of the bulk action to click
    */
-  async clickBulkAction(actionKey: BulkSelectActionKey): Promise<void> {
-    await this.bulkSelect.clickAction(actionKey);
+  async clickBulkAction(actionName: string): Promise<void> {
+    await this.bulkSelect.clickAction(actionName);
   }
 
   /**

superset-frontend/playwright/tests/chart/chart-list.spec.ts

@@ -32,7 +32,6 @@ import {
   expectStatusOneOf,
   expectValidExportZip,
 } from '../../helpers/api/assertions';
-import { TIMEOUT } from '../../utils/constants';
 
 /**
  * Extend testWithAssets with chartListPage navigation (beforeEach equivalent).
@@ -63,11 +62,8 @@ test('should delete a chart with confirmation', async ({
   await chartListPage.goto();
   await chartListPage.waitForTableLoad();
 
-  // The list query is asynchronous; allow extra time on slow CI before the
-  // freshly-created chart appears.
-  await expect(chartListPage.getChartRow(chartName)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify chart is visible in list
+  await expect(chartListPage.getChartRow(chartName)).toBeVisible();
 
   // Click delete action button
   await chartListPage.clickDeleteAction(chartName);
@@ -85,14 +81,12 @@ test('should delete a chart with confirmation', async ({
   // Modal should close
   await deleteModal.waitForHidden();
 
-  // Verify success toast appears.
+  // Verify success toast appears
   const toast = new Toast(page);
   await expect(toast.getSuccess()).toBeVisible();
 
-  // Verify chart is removed from list (deleted rows are removed from the DOM, so assert count rather than visibility)
-  await expect(chartListPage.getChartRow(chartName)).toHaveCount(0, {
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify chart is removed from list
+  await expect(chartListPage.getChartRow(chartName)).not.toBeVisible();
 
   // Backend verification: API returns 404
   await expectDeleted(page, ENDPOINTS.CHART, chartId, {
@@ -117,11 +111,8 @@ test('should edit chart name via properties modal', async ({
   await chartListPage.goto();
   await chartListPage.waitForTableLoad();
 
-  // The list query is asynchronous; allow extra time on slow CI before the
-  // freshly-created chart appears.
-  await expect(chartListPage.getChartRow(chartName)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify chart is visible in list
+  await expect(chartListPage.getChartRow(chartName)).toBeVisible();
 
   // Click edit action to open properties modal
   await chartListPage.clickEditAction(chartName);
@@ -146,7 +137,7 @@ test('should edit chart name via properties modal', async ({
   // Modal should close
   await propertiesModal.waitForHidden();
 
-  // Verify success toast appears.
+  // Verify success toast appears
   const toast = new Toast(page);
   await expect(toast.getSuccess()).toBeVisible();
 
@@ -173,11 +164,8 @@ test('should export a chart as a zip file', async ({
   await chartListPage.goto();
   await chartListPage.waitForTableLoad();
 
-  // The list query is asynchronous; allow extra time on slow CI before the
-  // freshly-created chart appears.
-  await expect(chartListPage.getChartRow(chartName)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify chart is visible in list
+  await expect(chartListPage.getChartRow(chartName)).toBeVisible();
 
   // Set up API response intercept for export endpoint
   const exportResponsePromise = waitForGet(page, ENDPOINTS.CHART_EXPORT);
@@ -198,7 +186,7 @@ test('should bulk delete multiple charts', async ({
   chartListPage,
   testAssets,
 }) => {
-  test.setTimeout(TIMEOUT.SLOW_TEST);
+  test.setTimeout(60_000);
 
   // Create 2 throwaway charts for bulk delete
   const [chart1, chart2] = await Promise.all([
@@ -214,14 +202,9 @@ test('should bulk delete multiple charts', async ({
   await chartListPage.goto();
   await chartListPage.waitForTableLoad();
 
-  // The list query is asynchronous; allow extra time on slow CI before the
-  // freshly-created charts appear.
-  await expect(chartListPage.getChartRow(chart1.name)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
-  await expect(chartListPage.getChartRow(chart2.name)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify both charts are visible in list
+  await expect(chartListPage.getChartRow(chart1.name)).toBeVisible();
+  await expect(chartListPage.getChartRow(chart2.name)).toBeVisible();
 
   // Enable bulk select mode
   await chartListPage.clickBulkSelectButton();
@@ -231,7 +214,7 @@ test('should bulk delete multiple charts', async ({
   await chartListPage.selectChartCheckbox(chart2.name);
 
   // Click bulk delete action
-  await chartListPage.clickBulkAction('delete');
+  await chartListPage.clickBulkAction('Delete');
 
   // Delete confirmation modal should appear
   const deleteModal = new DeleteConfirmationModal(page);
@@ -246,17 +229,13 @@ test('should bulk delete multiple charts', async ({
   // Modal should close
   await deleteModal.waitForHidden();
 
-  // Verify success toast appears.
+  // Verify success toast appears
   const toast = new Toast(page);
   await expect(toast.getSuccess()).toBeVisible();
 
-  // Verify both charts are removed from list (deleted rows are removed from the DOM, so assert count rather than visibility)
-  await expect(chartListPage.getChartRow(chart1.name)).toHaveCount(0, {
-    timeout: TIMEOUT.API_RESPONSE,
-  });
-  await expect(chartListPage.getChartRow(chart2.name)).toHaveCount(0, {
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify both charts are removed from list
+  await expect(chartListPage.getChartRow(chart1.name)).not.toBeVisible();
+  await expect(chartListPage.getChartRow(chart2.name)).not.toBeVisible();
 
   // Backend verification: Both return 404
   for (const chart of [chart1, chart2]) {
@@ -280,11 +259,8 @@ test('should edit chart name from card view', async ({ page, testAssets }) => {
   await cardListPage.gotoCardView();
   await cardListPage.waitForCardLoad();
 
-  // The list query is asynchronous; allow extra time on slow CI before the
-  // freshly-created chart card appears.
-  await expect(cardListPage.getChartCard(chartName)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify chart card is visible
+  await expect(cardListPage.getChartCard(chartName)).toBeVisible();
 
   // Open card dropdown and click edit
   await cardListPage.clickCardEditAction(chartName);
@@ -309,18 +285,13 @@ test('should edit chart name from card view', async ({ page, testAssets }) => {
   // Modal should close
   await propertiesModal.waitForHidden();
 
-  // Verify success toast appears.
+  // Verify success toast appears
   const toast = new Toast(page);
   await expect(toast.getSuccess()).toBeVisible();
 
   // Verify the renamed card appears in card view and old name is gone
-  // (the old card name is removed from the DOM after the rename re-render).
-  await expect(cardListPage.getChartCard(newName)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
-  await expect(cardListPage.getChartCard(chartName)).toHaveCount(0, {
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  await expect(cardListPage.getChartCard(newName)).toBeVisible();
+  await expect(cardListPage.getChartCard(chartName)).not.toBeVisible();
 
   // Backend verification: API returns updated name
   const response = await apiGetChart(page, chartId);
@@ -333,11 +304,6 @@ test('should bulk export multiple charts', async ({
   chartListPage,
   testAssets,
 }) => {
-  // Chains create×2 → refresh → bulk select → export. Matches the
-  // sibling bulk-delete test's budget so the export response wait below
-  // can exceed the 30s default without hitting the test timeout.
-  test.setTimeout(TIMEOUT.SLOW_TEST);
-
   // Create 2 throwaway charts for bulk export
   const [chart1, chart2] = await Promise.all([
     createTestChart(page, testAssets, test.info(), {
@@ -352,14 +318,9 @@ test('should bulk export multiple charts', async ({
   await chartListPage.goto();
   await chartListPage.waitForTableLoad();
 
-  // The list query is asynchronous; allow extra time on slow CI before the
-  // freshly-created charts appear.
-  await expect(chartListPage.getChartRow(chart1.name)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
-  await expect(chartListPage.getChartRow(chart2.name)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify both charts are visible in list
+  await expect(chartListPage.getChartRow(chart1.name)).toBeVisible();
+  await expect(chartListPage.getChartRow(chart2.name)).toBeVisible();
 
   // Enable bulk select mode
   await chartListPage.clickBulkSelectButton();
@@ -368,15 +329,11 @@ test('should bulk export multiple charts', async ({
   await chartListPage.selectChartCheckbox(chart1.name);
   await chartListPage.selectChartCheckbox(chart2.name);
 
-  // Set up API response intercept BEFORE the click that triggers it.
-  // Exports of multiple charts can take longer than 30s under load,
-  // so use SLOW_TEST instead of the default test-timeout-bound budget.
-  const exportResponsePromise = waitForGet(page, ENDPOINTS.CHART_EXPORT, {
-    timeout: TIMEOUT.SLOW_TEST,
-  });
+  // Set up API response intercept for export endpoint
+  const exportResponsePromise = waitForGet(page, ENDPOINTS.CHART_EXPORT);
 
   // Click bulk export action
-  await chartListPage.clickBulkAction('export');
+  await chartListPage.clickBulkAction('Export');
 
   // Wait for export API response and validate zip contains both charts
   const exportResponse = expectStatusOneOf(await exportResponsePromise, [200]);

superset-frontend/playwright/tests/dashboard/dashboard-list.spec.ts

@@ -68,11 +68,8 @@ test('should delete a dashboard with confirmation', async ({
   await dashboardListPage.goto();
   await dashboardListPage.waitForTableLoad();
 
-  // The list query is asynchronous; allow extra time on slow CI before the
-  // freshly-created dashboard appears.
-  await expect(dashboardListPage.getDashboardRow(dashboardName)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify dashboard is visible in list
+  await expect(dashboardListPage.getDashboardRow(dashboardName)).toBeVisible();
 
   // Click delete action button
   await dashboardListPage.clickDeleteAction(dashboardName);
@@ -84,25 +81,20 @@ test('should delete a dashboard with confirmation', async ({
   // Type "DELETE" to confirm
   await deleteModal.fillConfirmationInput('DELETE');
 
-  // Click the Delete button (waits for it to become enabled)
+  // Click the Delete button
   await deleteModal.clickDelete();
 
   // Modal should close
   await deleteModal.waitForHidden();
 
-  // Verify success toast appears.
+  // Verify success toast appears
   const toast = new Toast(page);
   await expect(toast.getSuccess()).toBeVisible();
 
-  // Verify dashboard is removed from list (extended timeout for slow CI
-  // post-delete propagation — the default 8s expect.timeout intermittently
-  // expires before the listview re-fetch lands).
-  await expect(dashboardListPage.getDashboardRow(dashboardName)).toHaveCount(
-    0,
-    {
-      timeout: TIMEOUT.API_RESPONSE,
-    },
-  );
+  // Verify dashboard is removed from list
+  await expect(
+    dashboardListPage.getDashboardRow(dashboardName),
+  ).not.toBeVisible();
 
   // Backend verification: API returns 404
   await expectDeleted(page, ENDPOINTS.DASHBOARD, dashboardId, {
@@ -127,11 +119,8 @@ test('should export a dashboard as a zip file', async ({
   await dashboardListPage.goto();
   await dashboardListPage.waitForTableLoad();
 
-  // The list query is asynchronous; allow extra time on slow CI before the
-  // freshly-created dashboard appears.
-  await expect(dashboardListPage.getDashboardRow(dashboardName)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify dashboard is visible in list
+  await expect(dashboardListPage.getDashboardRow(dashboardName)).toBeVisible();
 
   // Set up API response intercept for export endpoint
   const exportResponsePromise = waitForGet(page, ENDPOINTS.DASHBOARD_EXPORT);
@@ -152,7 +141,7 @@ test('should bulk delete multiple dashboards', async ({
   dashboardListPage,
   testAssets,
 }) => {
-  test.setTimeout(TIMEOUT.SLOW_TEST);
+  test.setTimeout(60_000);
 
   // Create 2 throwaway dashboards for bulk delete
   const [dashboard1, dashboard2] = await Promise.all([
@@ -168,14 +157,13 @@ test('should bulk delete multiple dashboards', async ({
   await dashboardListPage.goto();
   await dashboardListPage.waitForTableLoad();
 
-  // The list query is asynchronous; allow extra time on slow CI before the
-  // freshly-created dashboards appear.
-  await expect(dashboardListPage.getDashboardRow(dashboard1.name)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
-  await expect(dashboardListPage.getDashboardRow(dashboard2.name)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify both dashboards are visible in list
+  await expect(
+    dashboardListPage.getDashboardRow(dashboard1.name),
+  ).toBeVisible();
+  await expect(
+    dashboardListPage.getDashboardRow(dashboard2.name),
+  ).toBeVisible();
 
   // Enable bulk select mode
   await dashboardListPage.clickBulkSelectButton();
@@ -185,7 +173,7 @@ test('should bulk delete multiple dashboards', async ({
   await dashboardListPage.selectDashboardCheckbox(dashboard2.name);
 
   // Click bulk delete action
-  await dashboardListPage.clickBulkAction('delete');
+  await dashboardListPage.clickBulkAction('Delete');
 
   // Delete confirmation modal should appear
   const deleteModal = new DeleteConfirmationModal(page);
@@ -200,19 +188,17 @@ test('should bulk delete multiple dashboards', async ({
   // Modal should close
   await deleteModal.waitForHidden();
 
-  // Verify success toast appears.
+  // Verify success toast appears
   const toast = new Toast(page);
   await expect(toast.getSuccess()).toBeVisible();
 
-  // Verify both dashboards are removed from list (deleted rows are removed from the DOM, so assert count rather than visibility)
-  await expect(dashboardListPage.getDashboardRow(dashboard1.name)).toHaveCount(
-    0,
-    { timeout: TIMEOUT.API_RESPONSE },
-  );
-  await expect(dashboardListPage.getDashboardRow(dashboard2.name)).toHaveCount(
-    0,
-    { timeout: TIMEOUT.API_RESPONSE },
-  );
+  // Verify both dashboards are removed from list
+  await expect(
+    dashboardListPage.getDashboardRow(dashboard1.name),
+  ).not.toBeVisible();
+  await expect(
+    dashboardListPage.getDashboardRow(dashboard2.name),
+  ).not.toBeVisible();
 
   // Backend verification: Both return 404
   for (const dashboard of [dashboard1, dashboard2]) {
@@ -227,11 +213,6 @@ test('should bulk export multiple dashboards', async ({
   dashboardListPage,
   testAssets,
 }) => {
-  // Chains create×2 → refresh → bulk select → export. Matches the
-  // sibling bulk-delete test's budget so the export response wait below
-  // can exceed the 30s default without hitting the test timeout.
-  test.setTimeout(TIMEOUT.SLOW_TEST);
-
   // Create 2 throwaway dashboards for bulk export
   const [dashboard1, dashboard2] = await Promise.all([
     createTestDashboard(page, testAssets, test.info(), {
@@ -246,31 +227,26 @@ test('should bulk export multiple dashboards', async ({
   await dashboardListPage.goto();
   await dashboardListPage.waitForTableLoad();
 
-  // The list query is asynchronous; allow extra time on slow CI before the
-  // freshly-created dashboards appear.
-  await expect(dashboardListPage.getDashboardRow(dashboard1.name)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
-  await expect(dashboardListPage.getDashboardRow(dashboard2.name)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify both dashboards are visible in list
+  await expect(
+    dashboardListPage.getDashboardRow(dashboard1.name),
+  ).toBeVisible();
+  await expect(
+    dashboardListPage.getDashboardRow(dashboard2.name),
+  ).toBeVisible();
 
-  // Enable bulk select mode (waits for the checkbox column to render)
+  // Enable bulk select mode
   await dashboardListPage.clickBulkSelectButton();
 
-  // Select both dashboards (each call asserts the checkbox is checked)
+  // Select both dashboards
   await dashboardListPage.selectDashboardCheckbox(dashboard1.name);
   await dashboardListPage.selectDashboardCheckbox(dashboard2.name);
 
-  // Set up API response intercept BEFORE the click that triggers it.
-  // Exports of multiple dashboards can take longer than 30s under load,
-  // so use SLOW_TEST instead of the default test-timeout-bound budget.
-  const exportResponsePromise = waitForGet(page, ENDPOINTS.DASHBOARD_EXPORT, {
-    timeout: TIMEOUT.SLOW_TEST,
-  });
+  // Set up API response intercept for export endpoint
+  const exportResponsePromise = waitForGet(page, ENDPOINTS.DASHBOARD_EXPORT);
 
-  // Click bulk export action (waits for the action button to render)
-  await dashboardListPage.clickBulkAction('export');
+  // Click bulk export action
+  await dashboardListPage.clickBulkAction('Export');
 
   // Wait for export API response and validate zip contains both dashboards
   const exportResponse = expectStatusOneOf(await exportResponsePromise, [200]);
@@ -286,15 +262,14 @@ test('should bulk export multiple dashboards', async ({
 // this prevents race conditions when parallel workers import the same dashboard.
 // (Deviation from "avoid describe" guideline is necessary for functional reasons)
 test.describe('import dashboard', () => {
-  // `timeout` on describe.configure also bounds fixture setup, so the
-  // `dashboardListPage` navigation gets the SLOW_TEST budget too —
-  // inline `test.setTimeout()` only applies once the test body runs.
-  test.describe.configure({ mode: 'serial', timeout: TIMEOUT.SLOW_TEST });
+  test.describe.configure({ mode: 'serial' });
   test('should import a dashboard from a zip file', async ({
     page,
     dashboardListPage,
     testAssets,
   }) => {
+    test.setTimeout(60_000);
+
     // Create a dashboard, export it via API, then delete it, then reimport via UI
     const { id: dashboardId, name: dashboardName } = await createTestDashboard(
       page,
@@ -318,13 +293,12 @@ test.describe('import dashboard', () => {
       label: `Dashboard ${dashboardId}`,
     });
 
-    // Refresh to confirm dashboard is no longer in the list (deleted rows are removed from the DOM, so assert count rather than visibility)
+    // Refresh to confirm dashboard is no longer in the list
     await dashboardListPage.goto();
     await dashboardListPage.waitForTableLoad();
-    await expect(dashboardListPage.getDashboardRow(dashboardName)).toHaveCount(
-      0,
-      { timeout: TIMEOUT.API_RESPONSE },
-    );
+    await expect(
+      dashboardListPage.getDashboardRow(dashboardName),
+    ).not.toBeVisible();
 
     // Click the import button
     await dashboardListPage.clickImportButton();
@@ -354,7 +328,7 @@ test.describe('import dashboard', () => {
     // Handle overwrite confirmation if dashboard already exists
     const overwriteInput = importModal.getOverwriteInput();
     await overwriteInput
-      .waitFor({ state: 'visible', timeout: TIMEOUT.CONFIRM_DIALOG })
+      .waitFor({ state: 'visible', timeout: 3000 })
       .catch(error => {
         if (!(error instanceof Error) || error.name !== 'TimeoutError') {
           throw error;
@@ -376,21 +350,18 @@ test.describe('import dashboard', () => {
     // Modal should close on success
     await importModal.waitForHidden({ timeout: TIMEOUT.FILE_IMPORT });
 
-    // Verify success toast appears.
+    // Verify success toast appears
     const toast = new Toast(page);
-    await expect(toast.getSuccess()).toBeVisible({
-      timeout: TIMEOUT.PAGE_LOAD,
-    });
+    await expect(toast.getSuccess()).toBeVisible({ timeout: 10000 });
 
     // Refresh to see the imported dashboard
     await dashboardListPage.goto();
     await dashboardListPage.waitForTableLoad();
 
-    // The list query is asynchronous; allow extra time on slow CI before the
-    // freshly-imported dashboard appears.
-    await expect(dashboardListPage.getDashboardRow(dashboardName)).toBeVisible({
-      timeout: TIMEOUT.API_RESPONSE,
-    });
+    // Verify dashboard appears in list
+    await expect(
+      dashboardListPage.getDashboardRow(dashboardName),
+    ).toBeVisible();
 
     // Track for cleanup: look up the reimported dashboard by title
     const reimported = await getDashboardByName(page, dashboardName);

superset-frontend/playwright/tests/dashboard/mixed-chart-dashboard-filters.spec.ts

@@ -1,203 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * Regression for #29519: a dashboard-level filter that is in scope for a Mixed
- * (mixed_timeseries) chart should apply to BOTH of the chart's queries — Query
- * A and Query B — not just Query A.
- *
- * A Mixed chart issues a single query context with two queries
- * (queries[0] = A, queries[1] = B). This test creates a Mixed chart, puts it on
- * a dashboard behind a native filter scoped to the chart, loads the dashboard,
- * and inspects the outgoing POST /api/v1/chart/data payload to assert the filter
- * is present in both queries.
- *
- * CI green => both queries inherit the dashboard filter (contract holds);
- *             merging closes #29519 and guards against regressions.
- * CI red   => Query B dropped the filter; the bug is live in the Mixed chart
- *             query-building path (plugin-chart-echarts/src/MixedTimeseries).
- */
-import { testWithAssets, expect } from '../../helpers/fixtures';
-import { apiPost, apiPut } from '../../helpers/api/requests';
-import { apiPostDashboard } from '../../helpers/api/dashboard';
-import { DashboardPage } from '../../pages/DashboardPage';
-
-const DATASET_NAME = 'birth_names';
-const FILTER_COLUMN = 'gender';
-const FILTER_VALUE = 'boy';
-
-async function findDatasetIdByName(page: any, name: string): Promise<number> {
-  const query = `(filters:!((col:table_name,opr:eq,value:'${name}')))`;
-  const resp = await page.request.get(`api/v1/dataset/?q=${query}`);
-  const body = await resp.json();
-  if (!body.result?.length) {
-    throw new Error(`Dataset ${name} not found`);
-  }
-  return body.result[0].id;
-}
-
-testWithAssets(
-  'Mixed chart applies dashboard filter to both queries (#29519)',
-  async ({ page, testAssets }) => {
-    const datasetId = await findDatasetIdByName(page, DATASET_NAME);
-
-    const chartParams = {
-      datasource: `${datasetId}__table`,
-      viz_type: 'mixed_timeseries',
-      x_axis: 'ds',
-      time_grain_sqla: 'P1Y',
-      metrics: ['count'],
-      groupby: [],
-      adhoc_filters: [],
-      metrics_b: ['count'],
-      groupby_b: [],
-      adhoc_filters_b: [],
-      row_limit: 100,
-      row_limit_b: 100,
-      truncate_metric: true,
-      truncate_metric_b: true,
-      comparison_type: 'values',
-      color_scheme: 'supersetColors',
-    };
-    const chartResp = await apiPost(page, 'api/v1/chart/', {
-      slice_name: `mixed_filter_repro_${Date.now()}`,
-      viz_type: 'mixed_timeseries',
-      datasource_id: datasetId,
-      datasource_type: 'table',
-      params: JSON.stringify(chartParams),
-    });
-    expect(chartResp.ok()).toBe(true);
-    const chartId: number = (await chartResp.json()).id;
-    testAssets.trackChart(chartId);
-
-    const chartLayoutKey = `CHART-${chartId}`;
-    const filterId = `NATIVE_FILTER-${Math.random().toString(36).slice(2, 10)}`;
-    const positionJson = {
-      DASHBOARD_VERSION_KEY: 'v2',
-      ROOT_ID: { type: 'ROOT', id: 'ROOT_ID', children: ['GRID_ID'] },
-      GRID_ID: {
-        type: 'GRID',
-        id: 'GRID_ID',
-        children: ['ROW-1'],
-        parents: ['ROOT_ID'],
-      },
-      'ROW-1': {
-        type: 'ROW',
-        id: 'ROW-1',
-        children: [chartLayoutKey],
-        parents: ['ROOT_ID', 'GRID_ID'],
-        meta: { background: 'BACKGROUND_TRANSPARENT' },
-      },
-      [chartLayoutKey]: {
-        type: 'CHART',
-        id: chartLayoutKey,
-        children: [],
-        parents: ['ROOT_ID', 'GRID_ID', 'ROW-1'],
-        meta: { chartId, width: 8, height: 60, sliceName: 'mixed_filter_repro' },
-      },
-    };
-    const jsonMetadata = {
-      native_filter_configuration: [
-        {
-          id: filterId,
-          name: 'Gender',
-          filterType: 'filter_select',
-          type: 'NATIVE_FILTER',
-          targets: [{ datasetId, column: { name: FILTER_COLUMN } }],
-          controlValues: {
-            multiSelect: false,
-            enableEmptyFilter: false,
-            defaultToFirstItem: false,
-            inverseSelection: false,
-            searchAllOptions: false,
-          },
-          defaultDataMask: {
-            filterState: { value: [FILTER_VALUE] },
-            extraFormData: {
-              filters: [
-                { col: FILTER_COLUMN, op: 'IN', val: [FILTER_VALUE] },
-              ],
-            },
-          },
-          cascadeParentIds: [],
-          scope: { rootPath: ['ROOT_ID'], excluded: [] },
-          chartsInScope: [chartId],
-        },
-      ],
-      chart_configuration: {},
-      cross_filters_enabled: false,
-      global_chart_configuration: {
-        scope: { rootPath: ['ROOT_ID'], excluded: [] },
-        chartsInScope: [chartId],
-      },
-    };
-    const dashResp = await apiPostDashboard(page, {
-      dashboard_title: `mixed_filter_repro_${Date.now()}`,
-      published: true,
-      position_json: JSON.stringify(positionJson),
-      json_metadata: JSON.stringify(jsonMetadata),
-    });
-    expect(dashResp.ok()).toBe(true);
-    const dashBody = await dashResp.json();
-    const dashboardId: number = dashBody.result?.id ?? dashBody.id;
-    testAssets.trackDashboard(dashboardId);
-
-    await apiPut(page, `api/v1/chart/${chartId}`, { dashboards: [dashboardId] });
-
-    // Capture the Mixed chart's data request (the one with two queries).
-    const twoQueryPayloads: any[] = [];
-    page.on('request', req => {
-      if (
-        req.url().includes('/api/v1/chart/data') &&
-        req.method() === 'POST'
-      ) {
-        try {
-          const body = req.postDataJSON();
-          if (body?.queries?.length === 2) {
-            twoQueryPayloads.push(body);
-          }
-        } catch {
-          // ignore non-JSON bodies
-        }
-      }
-    });
-
-    const dashboardPage = new DashboardPage(page);
-    await dashboardPage.gotoById(dashboardId);
-    await dashboardPage.waitForLoad();
-    await dashboardPage.waitForChartsToLoad();
-
-    await expect
-      .poll(() => twoQueryPayloads.length, { timeout: 15_000 })
-      .toBeGreaterThan(0);
-
-    const payload = twoQueryPayloads[twoQueryPayloads.length - 1];
-    const filtersA = JSON.stringify(payload.queries[0].filters || []);
-    const filtersB = JSON.stringify(payload.queries[1].filters || []);
-
-    expect(
-      filtersA.includes(FILTER_COLUMN),
-      'Query A should inherit the dashboard filter',
-    ).toBe(true);
-    expect(
-      filtersB.includes(FILTER_COLUMN),
-      'Query B should inherit the dashboard filter (see #29519)',
-    ).toBe(true);
-  },
-);

superset-frontend/playwright/tests/dataset/dataset-list.spec.ts

@@ -107,11 +107,8 @@ test('should delete a dataset with confirmation', async ({
   await datasetListPage.goto();
   await datasetListPage.waitForTableLoad();
 
-  // The list query is asynchronous; allow extra time on slow CI before the
-  // freshly-created dataset appears.
-  await expect(datasetListPage.getDatasetRow(datasetName)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify dataset is visible in list
+  await expect(datasetListPage.getDatasetRow(datasetName)).toBeVisible();
 
   // Click delete action button
   await datasetListPage.clickDeleteAction(datasetName);
@@ -129,15 +126,14 @@ test('should delete a dataset with confirmation', async ({
   // Modal should close
   await deleteModal.waitForHidden();
 
-  // Verify success toast appears with correct message.
+  // Verify success toast appears with correct message
   const toast = new Toast(page);
-  await expect(toast.getSuccess()).toBeVisible();
+  const successToast = toast.getSuccess();
+  await expect(successToast).toBeVisible();
   await expect(toast.getMessage()).toContainText('Deleted');
 
-  // Verify dataset is removed from list (deleted rows are removed from the DOM, so assert count rather than visibility)
-  await expect(datasetListPage.getDatasetRow(datasetName)).toHaveCount(0, {
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify dataset is removed from list
+  await expect(datasetListPage.getDatasetRow(datasetName)).not.toBeVisible();
 
   // Verify via API that dataset no longer exists (404)
   await expectDeleted(page, ENDPOINTS.DATASET, datasetId, {
@@ -159,13 +155,10 @@ test('should duplicate a dataset with new name', async ({
   );
   const duplicateName = `duplicate_${Date.now()}_${test.info().parallelIndex}`;
 
-  // Navigate to list and verify original dataset is visible.
-  // The list query is asynchronous; allow extra time on slow CI.
+  // Navigate to list and verify original dataset is visible
   await datasetListPage.goto();
   await datasetListPage.waitForTableLoad();
-  await expect(datasetListPage.getDatasetRow(originalName)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  await expect(datasetListPage.getDatasetRow(originalName)).toBeVisible();
 
   // Set up response intercept to capture duplicate dataset ID
   const duplicateResponsePromise = waitForPost(
@@ -208,14 +201,9 @@ test('should duplicate a dataset with new name', async ({
   await datasetListPage.goto();
   await datasetListPage.waitForTableLoad();
 
-  // The list query is asynchronous; allow extra time on slow CI before the
-  // duplicate appears alongside the original.
-  await expect(datasetListPage.getDatasetRow(originalName)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
-  await expect(datasetListPage.getDatasetRow(duplicateName)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify both datasets exist in list
+  await expect(datasetListPage.getDatasetRow(originalName)).toBeVisible();
+  await expect(datasetListPage.getDatasetRow(duplicateName)).toBeVisible();
 
   // API Verification: Fetch both datasets via detail API for consistent comparison
   // (list API may return undefined for fields that detail API returns as null)
@@ -268,11 +256,6 @@ test('should export multiple datasets via bulk select action', async ({
   datasetListPage,
   testAssets,
 }) => {
-  // Chains create×2 → refresh → bulk select → export. Matches the
-  // sibling bulk-delete test's budget so the export response wait below
-  // can exceed the 30s default without hitting the test timeout.
-  test.setTimeout(TIMEOUT.SLOW_TEST);
-
   // Create 2 throwaway datasets for bulk export
   const [dataset1, dataset2] = await Promise.all([
     createTestDataset(page, testAssets, test.info(), {
@@ -287,14 +270,9 @@ test('should export multiple datasets via bulk select action', async ({
   await datasetListPage.goto();
   await datasetListPage.waitForTableLoad();
 
-  // The list query is asynchronous; allow extra time on slow CI before the
-  // freshly-created datasets appear.
-  await expect(datasetListPage.getDatasetRow(dataset1.name)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
-  await expect(datasetListPage.getDatasetRow(dataset2.name)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify both datasets are visible in list
+  await expect(datasetListPage.getDatasetRow(dataset1.name)).toBeVisible();
+  await expect(datasetListPage.getDatasetRow(dataset2.name)).toBeVisible();
 
   // Enable bulk select mode
   await datasetListPage.clickBulkSelectButton();
@@ -303,15 +281,11 @@ test('should export multiple datasets via bulk select action', async ({
   await datasetListPage.selectDatasetCheckbox(dataset1.name);
   await datasetListPage.selectDatasetCheckbox(dataset2.name);
 
-  // Set up API response intercept BEFORE the click that triggers it.
-  // Exports of multiple datasets can take longer than 30s under load,
-  // so use SLOW_TEST instead of the default test-timeout-bound budget.
-  const exportResponsePromise = waitForGet(page, ENDPOINTS.DATASET_EXPORT, {
-    timeout: TIMEOUT.SLOW_TEST,
-  });
+  // Set up API response intercept for export endpoint
+  const exportResponsePromise = waitForGet(page, ENDPOINTS.DATASET_EXPORT);
 
   // Click bulk export action
-  await datasetListPage.clickBulkAction('export');
+  await datasetListPage.clickBulkAction('Export');
 
   // Wait for export API response and validate zip contains multiple datasets
   const exportResponse = expectStatusOneOf(await exportResponsePromise, [200]);
@@ -338,11 +312,8 @@ test('should edit dataset name via modal', async ({
   await datasetListPage.goto();
   await datasetListPage.waitForTableLoad();
 
-  // The list query is asynchronous; allow extra time on slow CI before the
-  // freshly-created dataset appears.
-  await expect(datasetListPage.getDatasetRow(datasetName)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify dataset is visible in list
+  await expect(datasetListPage.getDatasetRow(datasetName)).toBeVisible();
 
   // Click edit action to open modal
   await datasetListPage.clickEditAction(datasetName);
@@ -377,9 +348,9 @@ test('should edit dataset name via modal', async ({
   // Modal should close
   await editModal.waitForHidden();
 
-  // Verify success toast appears.
+  // Verify success toast appears
   const toast = new Toast(page);
-  await expect(toast.getSuccess()).toBeVisible({ timeout: TIMEOUT.PAGE_LOAD });
+  await expect(toast.getSuccess()).toBeVisible({ timeout: 10000 });
 
   // Verify via API that name was saved
   const updatedDatasetRes = await apiGetDataset(page, datasetId);
@@ -392,8 +363,6 @@ test('should bulk delete multiple datasets', async ({
   datasetListPage,
   testAssets,
 }) => {
-  test.setTimeout(TIMEOUT.SLOW_TEST);
-
   // Create 2 throwaway datasets for bulk delete
   const [dataset1, dataset2] = await Promise.all([
     createTestDataset(page, testAssets, test.info(), {
@@ -408,14 +377,9 @@ test('should bulk delete multiple datasets', async ({
   await datasetListPage.goto();
   await datasetListPage.waitForTableLoad();
 
-  // The list query is asynchronous; allow extra time on slow CI before the
-  // freshly-created datasets appear.
-  await expect(datasetListPage.getDatasetRow(dataset1.name)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
-  await expect(datasetListPage.getDatasetRow(dataset2.name)).toBeVisible({
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify both datasets are visible in list
+  await expect(datasetListPage.getDatasetRow(dataset1.name)).toBeVisible();
+  await expect(datasetListPage.getDatasetRow(dataset2.name)).toBeVisible();
 
   // Enable bulk select mode
   await datasetListPage.clickBulkSelectButton();
@@ -425,7 +389,7 @@ test('should bulk delete multiple datasets', async ({
   await datasetListPage.selectDatasetCheckbox(dataset2.name);
 
   // Click bulk delete action
-  await datasetListPage.clickBulkAction('delete');
+  await datasetListPage.clickBulkAction('Delete');
 
   // Delete confirmation modal should appear
   const deleteModal = new DeleteConfirmationModal(page);
@@ -440,17 +404,13 @@ test('should bulk delete multiple datasets', async ({
   // Modal should close
   await deleteModal.waitForHidden();
 
-  // Verify success toast appears.
+  // Verify success toast appears
   const toast = new Toast(page);
   await expect(toast.getSuccess()).toBeVisible();
 
-  // Verify both datasets are removed from list (deleted rows are removed from the DOM, so assert count rather than visibility)
-  await expect(datasetListPage.getDatasetRow(dataset1.name)).toHaveCount(0, {
-    timeout: TIMEOUT.API_RESPONSE,
-  });
-  await expect(datasetListPage.getDatasetRow(dataset2.name)).toHaveCount(0, {
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Verify both datasets are removed from list
+  await expect(datasetListPage.getDatasetRow(dataset1.name)).not.toBeVisible();
+  await expect(datasetListPage.getDatasetRow(dataset2.name)).not.toBeVisible();
 
   // Verify via API that datasets no longer exist (404)
   await expectDeleted(page, ENDPOINTS.DATASET, dataset1.id, {
@@ -466,15 +426,14 @@ test('should bulk delete multiple datasets', async ({
 // this prevents race conditions when parallel workers import the same dataset.
 // (Deviation from "avoid describe" guideline is necessary for functional reasons)
 test.describe('import dataset', () => {
-  // `timeout` on describe.configure also bounds fixture setup, so the
-  // `datasetListPage` navigation gets the SLOW_TEST budget too —
-  // inline `test.setTimeout()` only applies once the test body runs.
-  test.describe.configure({ mode: 'serial', timeout: TIMEOUT.SLOW_TEST });
+  test.describe.configure({ mode: 'serial' });
   test('should import a dataset from a zip file', async ({
     page,
     datasetListPage,
     testAssets,
   }) => {
+    test.setTimeout(60_000);
+
     // Create a dataset, export it via API, then delete it, then reimport via UI
     const { id: datasetId, name: datasetName } = await createTestDataset(
       page,
@@ -496,12 +455,10 @@ test.describe('import dataset', () => {
       label: `Dataset ${datasetId}`,
     });
 
-    // Refresh to confirm dataset is no longer in the list (deleted rows are removed from the DOM, so assert count rather than visibility)
+    // Refresh to confirm dataset is no longer in the list
     await datasetListPage.goto();
     await datasetListPage.waitForTableLoad();
-    await expect(datasetListPage.getDatasetRow(datasetName)).toHaveCount(0, {
-      timeout: TIMEOUT.API_RESPONSE,
-    });
+    await expect(datasetListPage.getDatasetRow(datasetName)).not.toBeVisible();
 
     // Click the import button
     await datasetListPage.clickImportButton();
@@ -528,7 +485,7 @@ test.describe('import dataset', () => {
     // First response may be 409/422 indicating overwrite is required
     const overwriteInput = importModal.getOverwriteInput();
     await overwriteInput
-      .waitFor({ state: 'visible', timeout: TIMEOUT.CONFIRM_DIALOG })
+      .waitFor({ state: 'visible', timeout: 3000 })
       .catch(error => {
         if (!(error instanceof Error) || error.name !== 'TimeoutError') {
           throw error;
@@ -550,21 +507,16 @@ test.describe('import dataset', () => {
     // Modal should close on success
     await importModal.waitForHidden({ timeout: TIMEOUT.FILE_IMPORT });
 
-    // Verify success toast appears.
+    // Verify success toast appears
     const toast = new Toast(page);
-    await expect(toast.getSuccess()).toBeVisible({
-      timeout: TIMEOUT.PAGE_LOAD,
-    });
+    await expect(toast.getSuccess()).toBeVisible({ timeout: 10000 });
 
     // Refresh to see the imported dataset
     await datasetListPage.goto();
     await datasetListPage.waitForTableLoad();
 
-    // The list query is asynchronous; allow extra time on slow CI before the
-    // freshly-imported dataset appears.
-    await expect(datasetListPage.getDatasetRow(datasetName)).toBeVisible({
-      timeout: TIMEOUT.API_RESPONSE,
-    });
+    // Verify dataset appears in list
+    await expect(datasetListPage.getDatasetRow(datasetName)).toBeVisible();
 
     // Track for cleanup: the dataset import API returns {"message": "OK"}
     // with no ID, so look up the reimported dataset by name.

superset-frontend/playwright/utils/constants.ts

@@ -65,12 +65,9 @@ export const TIMEOUT = {
   UI_TRANSITION: 5000, // 5s ceiling for Ant Design animations (~300-500ms actual)
 
   /**
-   * SQL query execution (query → backend processing → results).
-   * 30s matches Playwright's default test timeout — cold-start CI on the
-   * /app/prefix variant has been observed running trivial SELECTs in
-   * ~25s before results render, which exceeded the previous 15s budget.
+   * SQL query execution (query → backend processing → results)
    */
-  QUERY_EXECUTION: 30000, // 30s for SQL queries
+  QUERY_EXECUTION: 15000, // 15s for SQL queries that may take longer than default expect timeout
 
   /**
    * Extended test timeout for multi-step tests (page load + query execution + assertions).

superset-frontend/plugins/legacy-plugin-chart-calendar/src/utils.ts

@@ -19,9 +19,7 @@
 
 import { getTimeFormatter } from '@superset-ui/core';
 
-// Cal-Heatmap provides local timestamps (UTC shifted by the browser's timezone
-// offset). We subtract that offset so the formatter displays the correct UTC
-// date regardless of the browser's timezone.
+// Cal-Heatmap provides local timestamps. We subtract the offset so that utcFormat displays the correct local date.
 export const getFormattedUTCTime = (
   ts: number | string,
   timeFormat?: string,

superset-frontend/plugins/legacy-plugin-chart-calendar/src/vendor/cal-heatmap.ts

@@ -299,23 +299,18 @@ var CalHeatMap = function () {
     // Takes the fetched "data" object as argument, must return a json object
     // formatted like {timestamp:count, timestamp2:count2},
     afterLoadData: function (timestamps) {
-      // Use the DST-aware timezone offset for each individual timestamp so that
-      // every data point is shifted by its own local offset (not a fixed
-      // standard-time offset). This prevents data from landing in phantom hours
-      // during DST transitions and keeps the offset consistent with what
-      // getFormattedUTCTime undoes when formatting the tooltip.
-      //
-      // Around DST transitions two distinct UTC timestamps can shift to the
-      // same adjusted key (e.g. the "spring forward" hour that doesn't exist
-      // locally). Accumulate values on collision so no datapoints are silently
-      // dropped in hourly/minutely views.
+      // See https://github.com/wa0x6e/cal-heatmap/issues/126#issuecomment-373301803
+      const stdTimezoneOffset = date => {
+        const jan = new Date(date.getFullYear(), 0, 1);
+        const jul = new Date(date.getFullYear(), 6, 1);
+        return Math.max(jan.getTimezoneOffset(), jul.getTimezoneOffset());
+      };
+      const offset = stdTimezoneOffset(new Date()) * 60;
       let results = {};
       for (let timestamp in timestamps) {
         const value = timestamps[timestamp];
-        const ts = parseInt(timestamp, 10);
-        const offset = new Date(ts * 1000).getTimezoneOffset() * 60;
-        const adjustedTs = ts + offset;
-        results[adjustedTs] = (results[adjustedTs] || 0) + value;
+        timestamp = parseInt(timestamp, 10);
+        results[timestamp + offset] = value;
       }
       return results;
     },

superset-frontend/plugins/legacy-plugin-chart-calendar/test/utils.test.ts

@@ -19,71 +19,78 @@
 
 import { getFormattedUTCTime, convertUTCTimestampToLocal } from '../src/utils';
 
-test('getFormattedUTCTime formats local timestamp for display as UTC date', () => {
-  const utcTimestamp = 1420070400000; // 2015-01-01 00:00:00 UTC
-  const localTimestamp = convertUTCTimestampToLocal(utcTimestamp);
-  // Cal-Heatmap's afterLoadData adjusts timestamps similarly, so
-  // getFormattedUTCTime receives already-adjusted timestamps and
-  // formats them directly. The date component should be correct.
-  const formattedTime = getFormattedUTCTime(localTimestamp, '%Y-%m-%d');
+describe('getFormattedUTCTime', () => {
+  test('formats local timestamp for display as UTC date', () => {
+    const utcTimestamp = 1420070400000; // 2015-01-01 00:00:00 UTC
+    const localTimestamp = convertUTCTimestampToLocal(utcTimestamp);
+    const formattedTime = getFormattedUTCTime(
+      localTimestamp,
+      '%Y-%m-%d %H:%M:%S',
+    );
 
-  expect(formattedTime).toEqual('2015-01-01');
+    expect(formattedTime).toEqual('2015-01-01 00:00:00');
+  });
 });
 
-test('convertUTCTimestampToLocal adjusts timestamp so local Date shows UTC date', () => {
-  const utcTimestamp = 1704067200000;
-  const adjustedTimestamp = convertUTCTimestampToLocal(utcTimestamp);
-  const adjustedDate = new Date(adjustedTimestamp);
+describe('convertUTCTimestampToLocal', () => {
+  test('adjusts timestamp so local Date shows UTC date', () => {
+    const utcTimestamp = 1704067200000;
+    const adjustedTimestamp = convertUTCTimestampToLocal(utcTimestamp);
+    const adjustedDate = new Date(adjustedTimestamp);
 
-  expect(adjustedDate.getFullYear()).toEqual(2024);
-  expect(adjustedDate.getMonth()).toEqual(0);
-  expect(adjustedDate.getDate()).toEqual(1);
+    expect(adjustedDate.getFullYear()).toEqual(2024);
+    expect(adjustedDate.getMonth()).toEqual(0);
+    expect(adjustedDate.getDate()).toEqual(1);
+  });
+
+  test('handles month boundaries', () => {
+    const utcTimestamp = 1706745600000;
+    const adjustedDate = new Date(convertUTCTimestampToLocal(utcTimestamp));
+
+    expect(adjustedDate.getFullYear()).toEqual(2024);
+    expect(adjustedDate.getMonth()).toEqual(1);
+    expect(adjustedDate.getDate()).toEqual(1);
+  });
+
+  test('handles year boundaries', () => {
+    const utcTimestamp = 1735689600000;
+    const adjustedDate = new Date(convertUTCTimestampToLocal(utcTimestamp));
+
+    expect(adjustedDate.getFullYear()).toEqual(2025);
+    expect(adjustedDate.getMonth()).toEqual(0);
+    expect(adjustedDate.getDate()).toEqual(1);
+  });
+
+  test('adds timezone offset to timestamp', () => {
+    const utcTimestamp = 1704067200000;
+    const adjustedTimestamp = convertUTCTimestampToLocal(utcTimestamp);
+    const expectedOffset =
+      new Date(utcTimestamp).getTimezoneOffset() * 60 * 1000;
+
+    expect(adjustedTimestamp - utcTimestamp).toEqual(expectedOffset);
+  });
 });
 
-test('convertUTCTimestampToLocal handles month boundaries', () => {
-  const utcTimestamp = 1706745600000;
-  const adjustedDate = new Date(convertUTCTimestampToLocal(utcTimestamp));
+describe('integration', () => {
+  test('fixes timezone bug for CalHeatMap', () => {
+    const febFirst2024UTC = 1706745600000;
+    const adjustedDate = new Date(convertUTCTimestampToLocal(febFirst2024UTC));
 
-  expect(adjustedDate.getFullYear()).toEqual(2024);
-  expect(adjustedDate.getMonth()).toEqual(1);
-  expect(adjustedDate.getDate()).toEqual(1);
-});
-
-test('convertUTCTimestampToLocal handles year boundaries', () => {
-  const utcTimestamp = 1735689600000;
-  const adjustedDate = new Date(convertUTCTimestampToLocal(utcTimestamp));
-
-  expect(adjustedDate.getFullYear()).toEqual(2025);
-  expect(adjustedDate.getMonth()).toEqual(0);
-  expect(adjustedDate.getDate()).toEqual(1);
-});
-
-test('convertUTCTimestampToLocal adds timezone offset to timestamp', () => {
-  const utcTimestamp = 1704067200000;
-  const adjustedTimestamp = convertUTCTimestampToLocal(utcTimestamp);
-  const expectedOffset = new Date(utcTimestamp).getTimezoneOffset() * 60 * 1000;
-
-  expect(adjustedTimestamp - utcTimestamp).toEqual(expectedOffset);
-});
-
-test('convertUTCTimestampToLocal fixes timezone bug for CalHeatMap', () => {
-  const febFirst2024UTC = 1706745600000;
-  const adjustedDate = new Date(convertUTCTimestampToLocal(febFirst2024UTC));
-
-  expect(adjustedDate.getMonth()).toEqual(1);
-  expect(adjustedDate.getDate()).toEqual(1);
-});
-
-test('convertUTCTimestampToLocal and getFormattedUTCTime work together to display dates correctly', () => {
-  const utcTimestamp = 1704067200000;
-
-  // convertUTCTimestampToLocal adjusts UTC for Cal-Heatmap (which interprets as local)
-  const localTimestamp = convertUTCTimestampToLocal(utcTimestamp);
-  const calHeatmapDate = new Date(localTimestamp);
-  expect(calHeatmapDate.getMonth()).toEqual(0);
-  expect(calHeatmapDate.getDate()).toEqual(1);
-
-  // getFormattedUTCTime receives LOCAL timestamp (from Cal-Heatmap) and formats it
-  const formattedTime = getFormattedUTCTime(localTimestamp, '%Y-%m-%d');
-  expect(formattedTime).toContain('2024-01-01');
+    expect(adjustedDate.getMonth()).toEqual(1);
+    expect(adjustedDate.getDate()).toEqual(1);
+  });
+
+  test('both functions work together to display dates correctly', () => {
+    const utcTimestamp = 1704067200000;
+
+    // convertUTCTimestampToLocal adjusts UTC for Cal-Heatmap (which interprets as local)
+    const localTimestamp = convertUTCTimestampToLocal(utcTimestamp);
+    const calHeatmapDate = new Date(localTimestamp);
+    expect(calHeatmapDate.getMonth()).toEqual(0);
+    expect(calHeatmapDate.getDate()).toEqual(1);
+
+    // getFormattedUTCTime receives LOCAL timestamp (from Cal-Heatmap) and formats it
+    const formattedTime = getFormattedUTCTime(localTimestamp, '%Y-%m-%d');
+    expect(formattedTime).toContain('2024-01-01');
+  });
 });

superset-frontend/plugins/legacy-preset-chart-nvd3/package.json

@@ -34,7 +34,7 @@
     "fast-safe-stringify": "^2.1.1",
     "lodash": "^4.18.1",
     "nvd3-fork": "^2.0.5",
-    "dompurify": "^3.4.7",
+    "dompurify": "^3.4.5",
     "prop-types": "^15.8.1",
     "urijs": "^1.19.11"
   },
@@ -42,7 +42,7 @@
     "@apache-superset/core": "*",
     "@superset-ui/chart-controls": "*",
     "@superset-ui/core": "*",
-    "dayjs": "^1.11.21",
+    "dayjs": "^1.11.19",
     "react": "^18.2.0"
   }
 }

superset-frontend/plugins/legacy-preset-chart-nvd3/src/utils.ts

@@ -275,29 +275,29 @@ export function wrapTooltip(chart) {
   });
 }
 
-// Builds the sanitized HTML for an annotation layer's tooltip. Title and
-// description values come from the annotation data source, so the output is
-// run through dompurify before being inserted into the DOM by d3-tip.
-export function generateAnnotationTooltipContent(layer, d) {
-  const title =
-    d[layer.titleColumn] && d[layer.titleColumn].length > 0
-      ? `${d[layer.titleColumn]} - ${layer.name}`
-      : layer.name;
-  const body = Array.isArray(layer.descriptionColumns)
-    ? layer.descriptionColumns.map(c => d[c])
-    : Object.values(d);
-
-  return dompurify.sanitize(
-    `<div><strong>${title}</strong></div><br/><div>${body.join(', ')}</div>`,
-  );
-}
-
 export function tipFactory(layer) {
   return d3tip()
     .attr('class', `d3-tip ${layer.annotationTipClass || ''}`)
     .direction('n')
     .offset([-5, 0])
-    .html(d => (d ? generateAnnotationTooltipContent(layer, d) : ''));
+    .html(d => {
+      if (!d) {
+        return '';
+      }
+      const rawTitle =
+        d[layer.titleColumn] && d[layer.titleColumn].length > 0
+          ? `${d[layer.titleColumn]} - ${layer.name}`
+          : layer.name;
+      const rawBody = Array.isArray(layer.descriptionColumns)
+        ? layer.descriptionColumns.map(c => d[c])
+        : Object.values(d);
+
+      return dompurify.sanitize(
+        `<div><strong>${rawTitle}</strong></div><br/><div>${rawBody.join(
+          ', ',
+        )}</div>`,
+      );
+    });
 }
 
 export function getMaxLabelSize(svg, axisClass) {

superset-frontend/plugins/legacy-preset-chart-nvd3/test/utils.test.ts

@@ -24,7 +24,6 @@ import {
 
 import {
   computeYDomain,
-  generateAnnotationTooltipContent,
   generateBubbleTooltipContent,
   generateMultiLineTooltipContent,
   getTimeOrNumberFormatter,
@@ -126,42 +125,6 @@ describe('nvd3/utils', () => {
     );
   });
 
-  describe('generateMultiLineTooltipContent()', () => {
-    const identity = (value: any) => value;
-
-    test('renders the series key in the tooltip markup', () => {
-      const tooltip = generateMultiLineTooltipContent(
-        {
-          value: 'x-value',
-          series: [{ key: 'Region A', color: '#fff', value: 1 }],
-        },
-        identity,
-        [identity],
-      );
-      expect(tooltip).toContain('Region A');
-    });
-
-    test('strips a script payload from a malicious series key', () => {
-      const tooltip = generateMultiLineTooltipContent(
-        {
-          value: 'x-value',
-          series: [
-            {
-              key: '<img src=x onerror="alert(1)">',
-              color: '#fff',
-              value: 1,
-            },
-          ],
-        },
-        identity,
-        [identity],
-      );
-      // DOMPurify removes the event handler that would execute on render.
-      expect(tooltip).not.toContain('onerror');
-      expect(tooltip).not.toContain('alert(1)');
-    });
-  });
-
   describe('getTimeOrNumberFormatter(format)', () => {
     test('is a function', () => {
       expect(typeof getTimeOrNumberFormatter).toBe('function');
@@ -313,46 +276,4 @@ describe('nvd3/utils', () => {
       expect(html).toContain('payload');
     });
   });
-
-  describe('generateAnnotationTooltipContent()', () => {
-    const layer = {
-      name: 'My annotations',
-      titleColumn: 'title',
-      descriptionColumns: ['description'],
-    };
-
-    test('renders the annotation title and description', () => {
-      const html = generateAnnotationTooltipContent(layer, {
-        title: 'Release',
-        description: 'Shipped v1',
-      });
-      expect(html).toContain('Release - My annotations');
-      expect(html).toContain('Shipped v1');
-    });
-
-    test('falls back to the layer name when the title column is empty', () => {
-      const html = generateAnnotationTooltipContent(layer, {
-        title: '',
-        description: 'Shipped v1',
-      });
-      expect(html).toContain('My annotations');
-    });
-
-    test('strips an event-handler payload from the title column', () => {
-      const html = generateAnnotationTooltipContent(layer, {
-        title: '<img src=x onerror="alert(1)">',
-        description: 'ok',
-      });
-      expect(html).not.toContain('onerror');
-      expect(html).not.toContain('alert(1)');
-    });
-
-    test('strips a script payload from a description column', () => {
-      const html = generateAnnotationTooltipContent(layer, {
-        title: 'Release',
-        description: '<script>alert(document.cookie)</script>',
-      });
-      expect(html).not.toContain('<script>');
-    });
-  });
 });

superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/agGridFilterConverter.ts

@@ -165,26 +165,6 @@ function escapeSQLString(value: string): string {
   return value.replace(/'/g, "''");
 }
 
-/**
- * Coerce a range-filter bound to a finite number, or null if it is not a valid
- * numeric value. Unlike a bare Number() call, empty and whitespace-only strings
- * are rejected (Number('') === 0), so they never get interpolated into SQL.
- * @param value - Raw bound value from the AG Grid filter model
- * @returns The finite number, or null if the value is not numeric
- */
-function toFiniteNumber(value: FilterValue | undefined): number | null {
-  // Number(null) and Number('') both coerce to 0 and pass Number.isFinite,
-  // so reject nullish and empty/whitespace-only strings before coercing.
-  if (value === null || value === undefined) {
-    return null;
-  }
-  if (typeof value === 'string' && value.trim() === '') {
-    return null;
-  }
-  const coerced = Number(value);
-  return Number.isFinite(coerced) ? coerced : null;
-}
-
 // Maximum column name length - conservative upper bound that exceeds all common
 // database identifier limits (MySQL: 64, PostgreSQL: 63, SQL Server: 128, Oracle: 128)
 const MAX_COLUMN_NAME_LENGTH = 255;
@@ -398,17 +378,8 @@ function simpleFilterToWhereClause(
     return '';
   }
 
-  // Handle IN_RANGE unconditionally so a missing/cleared upper bound can never
-  // fall through to the generic clause below and emit an invalid single-operand
-  // BETWEEN. Range bounds are interpolated into the clause without quoting, so
-  // both ends must coerce to finite numbers; otherwise the clause is dropped.
-  if (type === FILTER_OPERATORS.IN_RANGE) {
-    const lowerBound = toFiniteNumber(value);
-    const upperBound = toFiniteNumber(filterTo);
-    if (lowerBound === null || upperBound === null) {
-      return '';
-    }
-    return `${columnName} ${SQL_OPERATORS.BETWEEN} ${lowerBound} AND ${upperBound}`;
+  if (type === FILTER_OPERATORS.IN_RANGE && filterTo !== undefined) {
+    return `${columnName} ${SQL_OPERATORS.BETWEEN} ${value} AND ${filterTo}`;
   }
 
   const formattedValue = formatValueForOperator(type, value!);

superset-frontend/plugins/plugin-chart-ag-grid-table/test/utils/agGridFilterConverter.test.ts

@@ -284,67 +284,6 @@ describe('agGridFilterConverter', () => {
         val: 18,
       });
     });
-
-    test('should emit a numeric BETWEEN clause for a metric range filter', () => {
-      const filterModel: AgGridFilterModel = {
-        revenue: {
-          filterType: 'number',
-          type: 'inRange',
-          filter: 10,
-          filterTo: 20,
-        },
-      };
-
-      // revenue is a metric, so the range filter renders as a HAVING clause
-      const result = convertAgGridFiltersToSQL(filterModel, ['revenue']);
-
-      expect(result.havingClause).toContain('BETWEEN 10 AND 20');
-    });
-
-    test('should drop a metric range filter whose bounds are not numeric', () => {
-      const filterModel = {
-        revenue: {
-          filterType: 'number',
-          type: 'inRange',
-          filter: '0',
-          filterTo: '100 OR 1=1',
-        },
-      } as unknown as AgGridFilterModel;
-
-      const result = convertAgGridFiltersToSQL(filterModel, ['revenue']);
-
-      // a non-numeric bound must never be interpolated into the clause
-      expect(result.havingClause).toBeUndefined();
-
-      const emptyBoundFilterModel = {
-        revenue: {
-          filterType: 'number',
-          type: 'inRange',
-          filter: '0',
-          filterTo: '',
-        },
-      } as unknown as AgGridFilterModel;
-
-      const result2 = convertAgGridFiltersToSQL(emptyBoundFilterModel, [
-        'revenue',
-      ]);
-      expect(result2.havingClause).toBeUndefined();
-
-      // A missing upper bound must drop the clause rather than fall through
-      // to a generic single-operand BETWEEN.
-      const missingBoundFilterModel = {
-        revenue: {
-          filterType: 'number',
-          type: 'inRange',
-          filter: '0',
-        },
-      } as unknown as AgGridFilterModel;
-
-      const result3 = convertAgGridFiltersToSQL(missingBoundFilterModel, [
-        'revenue',
-      ]);
-      expect(result3.havingClause).toBeUndefined();
-    });
   });
 
   describe('Null/blank filters', () => {

superset-frontend/plugins/plugin-chart-echarts/package.json

@@ -35,7 +35,7 @@
     "@apache-superset/core": "*",
     "@superset-ui/chart-controls": "*",
     "@superset-ui/core": "*",
-    "dayjs": "^1.11.21",
+    "dayjs": "^1.11.19",
     "echarts": "*",
     "memoize-one": "*",
     "react": "^18.2.0"

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts

@@ -1016,12 +1016,8 @@ export default function transformProps(
       trigger: richTooltip ? 'axis' : 'item',
       formatter: (params: any) => {
         const [xIndex, yIndex] = isHorizontal ? [1, 0] : [0, 1];
-        // For axis tooltips, prefer axisValue/axisValueLabel which contains the full label
-        // even when the axis label is visually truncated
         const xValue: number = richTooltip
-          ? (params[0].axisValue ??
-            params[0].axisValueLabel ??
-            params[0].value[xIndex])
+          ? params[0].value[xIndex]
           : params.value[xIndex];
         const forecastValue: CallbackDataParams[] = richTooltip
           ? params

superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts

@@ -1657,100 +1657,3 @@ test('should assign distinct dash patterns for multiple time offsets consistentl
   // must be different patterns
   expect(symbol1).not.toEqual(symbol2);
 });
-
-describe('Tooltip with long labels', () => {
-  test('should use axisValue for tooltip when available (richTooltip)', () => {
-    const longLabelData: ChartDataResponseResult[] = [
-      createTestQueryData([
-        {
-          'This is a very long category name that would normally be truncated': 100,
-          __timestamp: 599616000000,
-        },
-        {
-          'Another extremely long category name for testing purposes': 200,
-          __timestamp: 599916000000,
-        },
-      ]),
-    ];
-
-    const chartProps = createTestChartProps({
-      formData: {
-        richTooltip: true,
-      },
-      queriesData: longLabelData,
-    });
-
-    const transformedProps = transformProps(chartProps);
-
-    // Get the tooltip formatter function
-    const tooltipFormatter = (transformedProps.echartOptions as any).tooltip
-      .formatter;
-
-    // Simulate params from ECharts with axisValue containing full label
-    // Use distinct values for axisValue and seriesName to verify axisValue is used
-    const mockParams = [
-      {
-        axisValue:
-          'This is a very long category name that would normally be truncated',
-        value: [599616000000, 100],
-        seriesName: 'Some Series Name',
-      },
-    ];
-
-    // Call the formatter and check it uses the full label from axisValue
-    const result = tooltipFormatter(mockParams);
-    expect(result).toContain(
-      'This is a very long category name that would normally be truncated',
-    );
-  });
-
-  test('should fallback to value when axisValue is not available', () => {
-    const chartProps = createTestChartProps({
-      formData: {
-        richTooltip: true,
-      },
-    });
-
-    const transformedProps = transformProps(chartProps);
-
-    const tooltipFormatter = (transformedProps.echartOptions as any).tooltip
-      .formatter;
-
-    // Simulate params without axisValue
-    const mockParams = [
-      {
-        value: [599616000000, 1],
-        seriesName: 'San Francisco',
-      },
-    ];
-
-    // Should fall back to the x-value (value[xIndex]) and render it in the title
-    const result = tooltipFormatter(mockParams);
-    expect(typeof result).toBe('string');
-    expect(result).toContain('599616000000');
-  });
-
-  test('should handle item tooltips correctly', () => {
-    const chartProps = createTestChartProps({
-      formData: {
-        richTooltip: false,
-      },
-    });
-
-    const transformedProps = transformProps(chartProps);
-
-    const tooltipFormatter = (transformedProps.echartOptions as any).tooltip
-      .formatter;
-
-    // For item tooltips, params is a single object
-    const mockParams = {
-      value: [599616000000, 1],
-      seriesName: 'San Francisco',
-    };
-
-    // The item-tooltip x-value (value[xIndex]) should appear in the title
-    const result = tooltipFormatter(mockParams);
-    expect(typeof result).toBe('string');
-    expect(result).toContain('599616000000');
-  });
-});

superset-frontend/plugins/plugin-chart-handlebars/package.json

@@ -38,7 +38,7 @@
     "ace-builds": "^1.4.14",
     "handlebars": "^4.7.8",
     "lodash": "^4.18.1",
-    "dayjs": "^1.11.21",
+    "dayjs": "^1.11.19",
     "react": "^18.2.0",
     "react-ace": "^10.1.0",
     "react-dom": "^18.2.0"

superset-frontend/plugins/preset-chart-deckgl/package.json

@@ -65,7 +65,7 @@
     "@apache-superset/core": "*",
     "@superset-ui/chart-controls": "*",
     "@superset-ui/core": "*",
-    "dayjs": "^1.11.21",
+    "dayjs": "^1.11.19",
     "mapbox-gl": ">=1.0.0",
     "react": "^18.2.0",
     "react-dom": "^18.2.0"

superset-frontend/spec/helpers/setup.ts

@@ -23,10 +23,6 @@ import React from 'react';
 import { configure as configureTestingLibrary } from '@testing-library/react';
 import { matchers } from '@emotion/jest';
 
-if (typeof Intl.DurationFormat === 'undefined') {
-  require('@formatjs/intl-durationformat/polyfill.js');
-}
-
 configureTestingLibrary({
   testIdAttribute: 'data-test',
 });

superset-frontend/spec/helpers/testing-library.tsx

@@ -37,7 +37,6 @@ import { BrowserRouter } from 'react-router-dom';
 import { Provider } from 'react-redux';
 import { DndProvider } from 'react-dnd';
 import { HTML5Backend } from 'react-dnd-html5-backend';
-import { DndContext } from '@dnd-kit/core';
 import reducerIndex from 'spec/helpers/reducerIndex';
 import { QueryParamProvider } from 'use-query-params';
 import { ReactRouter5Adapter } from 'use-query-params/adapters/react-router-5';
@@ -48,7 +47,6 @@ import userEvent from '@testing-library/user-event';
 type Options = Omit<RenderOptions, 'queries'> & {
   useRedux?: boolean;
   useDnd?: boolean;
-  useDndKit?: boolean; // Use @dnd-kit instead of react-dnd
   useQueryParams?: boolean;
   useRouter?: boolean;
   useTheme?: boolean;
@@ -76,7 +74,6 @@ export const defaultStore = createStore();
 export function createWrapper(options?: Options) {
   const {
     useDnd,
-    useDndKit,
     useRedux,
     useQueryParams,
     useRouter,
@@ -99,10 +96,6 @@ export function createWrapper(options?: Options) {
       );
     }
 
-    if (useDndKit) {
-      result = <DndContext>{result}</DndContext>;
-    }
-
     if (useDnd) {
       // @ts-ignore react-dnd's DndProviderProps omits `children` under React 18 types
       result = <DndProvider backend={HTML5Backend}>{result}</DndProvider>;

superset-frontend/src/SqlLab/components/TabbedSqlEditors/index.tsx

@@ -25,7 +25,6 @@ import { FeatureFlag, isFeatureEnabled } from '@superset-ui/core';
 import { styled } from '@apache-superset/core/theme';
 import { Logger } from 'src/logger/LogUtils';
 import { EmptyState, Tooltip } from '@superset-ui/core/components';
-import { ErrorBoundary } from 'src/components/ErrorBoundary';
 import { detectOS } from 'src/utils/common';
 import * as Actions from 'src/SqlLab/actions/sqlLab';
 import { Icons } from '@superset-ui/core/components/Icons';
@@ -177,16 +176,14 @@ class TabbedSqlEditors extends PureComponent<TabbedSqlEditorsProps> {
       key: qe.id,
       label: <SqlEditorTabHeader queryEditor={qe} />,
       children: (
-        <ErrorBoundary>
-          <SqlEditor
-            queryEditor={qe}
-            defaultQueryLimit={this.props.defaultQueryLimit}
-            maxRow={this.props.maxRow}
-            displayLimit={this.props.displayLimit}
-            saveQueryWarning={this.props.saveQueryWarning}
-            scheduleQueryWarning={this.props.scheduleQueryWarning}
-          />
-        </ErrorBoundary>
+        <SqlEditor
+          queryEditor={qe}
+          defaultQueryLimit={this.props.defaultQueryLimit}
+          maxRow={this.props.maxRow}
+          displayLimit={this.props.displayLimit}
+          saveQueryWarning={this.props.saveQueryWarning}
+          scheduleQueryWarning={this.props.scheduleQueryWarning}
+        />
       ),
     }));
 

superset-frontend/src/chartCustomizations/components/DynamicGroupBy/DynamicGroupByPlugin.test.tsx

@@ -1,81 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import { ChartProps } from '@superset-ui/core';
-import { supersetTheme } from '@apache-superset/core/theme';
-import { render, screen, userEvent } from 'spec/helpers/testing-library';
-import PluginFilterDynamicGroupBy from './DynamicGroupByPlugin';
-import transformProps from './transformProps';
-import { PluginFilterGroupByProps } from './types';
-
-const baseProps = {
-  width: 220,
-  height: 20,
-  hooks: {},
-  filterState: { value: [] },
-  queriesData: [
-    {
-      data: [
-        { column_name: 'banana' },
-        { column_name: 'apple' },
-        { column_name: 'cherry' },
-      ],
-    },
-  ],
-  formData: {
-    datasource: '1__table',
-    vizType: 'filter_groupby',
-    nativeFilterId: 'test-filter',
-    defaultValue: [],
-    inputRef: { current: null },
-  },
-};
-
-const renderPlugin = (sortAscending?: boolean) => {
-  const chartProps = new ChartProps({
-    ...baseProps,
-    formData: { ...baseProps.formData, sortAscending },
-    theme: supersetTheme,
-  });
-  return render(
-    <PluginFilterDynamicGroupBy
-      {...(transformProps(chartProps) as unknown as PluginFilterGroupByProps)}
-    />,
-  );
-};
-
-const getOpenedOptionOrder = async () => {
-  userEvent.click(screen.getAllByRole('combobox')[0]);
-  const options = await screen.findAllByRole('option');
-  return options.map(option => option.textContent);
-};
-
-test('sorts display control values A-Z when sortAscending is true', async () => {
-  renderPlugin(true);
-  expect(await getOpenedOptionOrder()).toEqual(['apple', 'banana', 'cherry']);
-});
-
-test('sorts display control values Z-A when sortAscending is false', async () => {
-  renderPlugin(false);
-  expect(await getOpenedOptionOrder()).toEqual(['cherry', 'banana', 'apple']);
-});
-
-test('preserves source order when sorting is disabled', async () => {
-  renderPlugin(undefined);
-  expect(await getOpenedOptionOrder()).toEqual(['banana', 'apple', 'cherry']);
-});

superset-frontend/src/chartCustomizations/components/DynamicGroupBy/DynamicGroupByPlugin.tsx

@@ -18,15 +18,13 @@
  */
 import { t, tn } from '@apache-superset/core/translation';
 import { ensureIsArray, ExtraFormData } from '@superset-ui/core';
-import { useCallback, useEffect, useState, useMemo } from 'react';
+import { useEffect, useState, useMemo } from 'react';
 import {
   FormItem,
   type FormItemProps,
-  LabeledValue,
   Select,
   type SelectValue,
 } from '@superset-ui/core/components';
-import { propertyComparator } from '@superset-ui/core/components/Select/utils';
 import { FilterPluginStyle, StatusMessage } from '../common';
 import { PluginFilterGroupByProps, ColumnOption, ColumnData } from './types';
 
@@ -118,20 +116,6 @@ export default function PluginFilterDynamicGroupBy(
     [data],
   );
 
-  const sortComparator = useCallback(
-    (a: LabeledValue, b: LabeledValue) => {
-      if (formData.sortAscending === undefined) {
-        return 0;
-      }
-      const labelComparator = propertyComparator('label');
-      if (formData.sortAscending) {
-        return labelComparator(a, b);
-      }
-      return labelComparator(b, a);
-    },
-    [formData.sortAscending],
-  );
-
   return (
     <FilterPluginStyle height={height} width={width}>
       <FormItem validateStatus={filterState.validateStatus} {...formItemData}>
@@ -148,7 +132,6 @@ export default function PluginFilterDynamicGroupBy(
             ref={inputRef}
             options={options}
             onOpenChange={setFilterActive}
-            sortComparator={sortComparator}
           />
         </div>
       </FormItem>

superset-frontend/src/chartCustomizations/components/DynamicGroupBy/types.ts

@@ -76,6 +76,7 @@ export const DEFAULT_FORM_DATA: PluginFilterGroupByCustomizeProps = {
   dataset: null,
   column: null,
   sortFilter: false,
+  sortAscending: true,
   canSelectMultiple: true,
   defaultValue: null,
 };

superset-frontend/src/components/Chart/Chart.tsx

@@ -16,9 +16,9 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { ErrorInfo, useCallback, useEffect, useRef } from 'react';
-import { t } from '@apache-superset/core/translation';
+import { ErrorInfo, PureComponent } from 'react';
 import { logging } from '@apache-superset/core/utils';
+import { t } from '@apache-superset/core/translation';
 import {
   ensureIsArray,
   FeatureFlag,
@@ -60,7 +60,7 @@ export interface ChartProps {
   sharedLabelColors?: string;
   width: number;
   height: number;
-  setControlValue?: (name: string, value: unknown) => void;
+  setControlValue: (name: string, value: unknown) => void;
   timeout?: number;
   vizType: string;
   triggerRender?: boolean;
@@ -69,7 +69,7 @@ export interface ChartProps {
   chartAlert?: string;
   chartStatus?: ChartStatus;
   chartStackTrace?: string;
-  queriesResponse?: ChartState['queriesResponse'];
+  queriesResponse: ChartState['queriesResponse'];
   latestQueryFormData?: ChartState['latestQueryFormData'];
   triggerQuery?: boolean;
   chartIsStale?: boolean;
@@ -126,6 +126,19 @@ const NONEXISTENT_DATASET = t(
   'The dataset associated with this chart no longer exists',
 );
 
+const defaultProps: Partial<ChartProps> = {
+  addFilter: () => BLANK,
+  onFilterMenuOpen: () => BLANK,
+  onFilterMenuClose: () => BLANK,
+  initialValues: BLANK,
+  setControlValue: () => BLANK,
+  triggerRender: false,
+  dashboardId: undefined,
+  chartStackTrace: undefined,
+  force: false,
+  isInView: true,
+};
+
 const Styles = styled.div<{ height: number; width?: number }>`
   min-height: ${p => p.height}px;
   position: relative;
@@ -173,321 +186,252 @@ const MessageSpan = styled.span`
   color: ${({ theme }) => theme.colorText};
 `;
 
-function Chart({
-  addFilter = () => BLANK,
-  onFilterMenuOpen = () => BLANK,
-  onFilterMenuClose = () => BLANK,
-  initialValues = BLANK,
-  setControlValue = () => BLANK,
-  triggerRender = false,
-  dashboardId,
-  chartStackTrace,
-  force = false,
-  isInView = true,
-  ...restProps
-}: ChartProps): JSX.Element {
-  const {
-    actions,
-    chartId,
-    datasource,
-    formData,
-    timeout,
-    ownState,
-    chartAlert,
-    chartStatus,
-    queriesResponse = [],
-    errorMessage,
-    chartIsStale,
-    width,
-    height,
-    datasetsStatus,
-    onQuery,
-    annotationData,
-    vizType,
-    latestQueryFormData,
-    triggerQuery,
-    postTransformProps,
-    emitCrossFilters,
-    onChartStateChange,
-    suppressLoadingSpinner,
-    filterState,
-  } = restProps;
+class Chart extends PureComponent<ChartProps, {}> {
+  static defaultProps = defaultProps;
 
-  const renderStartTimeRef = useRef<number>(Logger.getTimestamp());
-  // Update on each render to accurately track render duration
-  renderStartTimeRef.current = Logger.getTimestamp();
+  renderStartTime: number;
 
-  const shouldRenderChart = useCallback(
-    () =>
-      isInView ||
+  constructor(props: ChartProps) {
+    super(props);
+    this.renderStartTime = Logger.getTimestamp();
+    this.handleRenderContainerFailure =
+      this.handleRenderContainerFailure.bind(this);
+  }
+
+  componentDidMount() {
+    if (this.props.triggerQuery) {
+      this.runQuery();
+    }
+  }
+
+  componentDidUpdate() {
+    if (this.props.triggerQuery) {
+      this.runQuery();
+    }
+  }
+
+  shouldRenderChart() {
+    return (
+      this.props.isInView ||
       !isFeatureEnabled(FeatureFlag.DashboardVirtualization) ||
-      isCurrentUserBot(),
-    [isInView],
-  );
+      isCurrentUserBot()
+    );
+  }
 
-  const runQuery = useCallback(() => {
+  runQuery() {
     if (
       isFeatureEnabled(FeatureFlag.DashboardVirtualizationDeferData) &&
-      !shouldRenderChart()
+      !this.shouldRenderChart()
     ) {
       return;
     }
     // Create chart with POST request
-    actions.postChartFormData(
-      formData,
-      Boolean(force || getUrlParam(URL_PARAMS.force)), // allow override via url params force=true
-      timeout,
-      chartId,
-      dashboardId,
-      ownState,
+    this.props.actions.postChartFormData(
+      this.props.formData,
+      Boolean(this.props.force || getUrlParam(URL_PARAMS.force)), // allow override via url params force=true
+      this.props.timeout,
+      this.props.chartId,
+      this.props.dashboardId,
+      this.props.ownState,
     );
-  }, [
-    actions,
-    chartId,
-    dashboardId,
-    formData,
-    force,
-    ownState,
-    shouldRenderChart,
-    timeout,
-  ]);
+  }
 
-  const handleRenderContainerFailure = useCallback(
-    (error: Error, info: ErrorInfo) => {
-      logging.warn(error);
-      actions.chartRenderingFailed(
-        error.toString(),
-        chartId,
-        info?.componentStack ?? null,
-      );
-
-      actions.logEvent(LOG_ACTIONS_RENDER_CHART, {
-        slice_id: chartId,
-        has_err: true,
-        error_details: error.toString(),
-        start_offset: renderStartTimeRef.current,
-        ts: new Date().getTime(),
-        duration: Logger.getTimestamp() - renderStartTimeRef.current,
-      });
-    },
-    [actions, chartId],
-  );
-
-  // componentDidMount and componentDidUpdate combined
-  useEffect(() => {
-    if (triggerQuery) {
-      runQuery();
-    }
-  }, [triggerQuery, runQuery]);
-
-  const renderErrorMessage = useCallback(
-    (queryResponse: ChartErrorType) => {
-      const error = queryResponse?.errors?.[0];
-      const message = chartAlert || queryResponse?.message;
-
-      // if datasource is still loading, don't render JS errors
-      // but always show backend API errors (which have an errors array)
-      // so users can see real issues like auth failures
-      if (
-        !error &&
-        chartAlert !== undefined &&
-        chartAlert !== NONEXISTENT_DATASET &&
-        datasource === PLACEHOLDER_DATASOURCE &&
-        datasetsStatus !== ResourceStatus.Error
-      ) {
-        return (
-          <Styles
-            key={chartId}
-            data-ui-anchor="chart"
-            className="chart-container"
-            data-test="chart-container"
-            height={height}
-          >
-            <Loading size={dashboardId ? 's' : 'm'} muted={!!dashboardId} />
-          </Styles>
-        );
-      }
-
-      return (
-        <ChartErrorMessage
-          key={chartId}
-          chartId={chartId}
-          error={error}
-          subtitle={message}
-          link={queryResponse ? queryResponse.link : undefined}
-          source={dashboardId ? ChartSource.Dashboard : ChartSource.Explore}
-          stackTrace={chartStackTrace}
-        />
-      );
-    },
-    [
-      chartAlert,
+  handleRenderContainerFailure(error: Error, info: ErrorInfo) {
+    const { actions, chartId } = this.props;
+    logging.warn(error);
+    actions.chartRenderingFailed(
+      error.toString(),
       chartId,
+      info?.componentStack ?? null,
+    );
+
+    actions.logEvent(LOG_ACTIONS_RENDER_CHART, {
+      slice_id: chartId,
+      has_err: true,
+      error_details: error.toString(),
+      start_offset: this.renderStartTime,
+      ts: new Date().getTime(),
+      duration: Logger.getTimestamp() - this.renderStartTime,
+    });
+  }
+
+  renderErrorMessage(queryResponse: ChartErrorType) {
+    const {
+      chartId,
+      chartAlert,
       chartStackTrace,
-      dashboardId,
-      datasetsStatus,
       datasource,
+      dashboardId,
       height,
-    ],
-  );
-
-  const renderSpinner = useCallback(
-    (databaseName: string | undefined) => {
-      const message = databaseName
-        ? t('Waiting on %s', databaseName)
-        : t('Waiting on database...');
+      datasetsStatus,
+    } = this.props;
+    const error = queryResponse?.errors?.[0];
+    const message = chartAlert || queryResponse?.message;
 
+    // if datasource is still loading, don't render JS errors
+    // but always show backend API errors (which have an errors array)
+    // so users can see real issues like auth failures
+    if (
+      !error &&
+      chartAlert !== undefined &&
+      chartAlert !== NONEXISTENT_DATASET &&
+      datasource === PLACEHOLDER_DATASOURCE &&
+      datasetsStatus !== ResourceStatus.Error
+    ) {
       return (
-        <LoadingDiv>
+        <Styles
+          key={chartId}
+          data-ui-anchor="chart"
+          className="chart-container"
+          data-test="chart-container"
+          height={height}
+        >
           <Loading
-            position="inline-centered"
-            size={dashboardId ? 's' : 'm'}
-            muted={!!dashboardId}
+            size={this.props.dashboardId ? 's' : 'm'}
+            muted={!!this.props.dashboardId}
           />
-          <MessageSpan>{message}</MessageSpan>
-        </LoadingDiv>
+        </Styles>
       );
-    },
-    [dashboardId],
-  );
+    }
 
-  const renderChartContainer = useCallback(
-    () => (
+    return (
+      <ChartErrorMessage
+        key={chartId}
+        chartId={chartId}
+        error={error}
+        subtitle={message}
+        link={queryResponse ? queryResponse.link : undefined}
+        source={dashboardId ? ChartSource.Dashboard : ChartSource.Explore}
+        stackTrace={chartStackTrace}
+      />
+    );
+  }
+
+  renderSpinner(databaseName: string | undefined) {
+    const message = databaseName
+      ? t('Waiting on %s', databaseName)
+      : t('Waiting on database...');
+
+    return (
+      <LoadingDiv>
+        <Loading
+          position="inline-centered"
+          size={this.props.dashboardId ? 's' : 'm'}
+          muted={!!this.props.dashboardId}
+        />
+        <MessageSpan>{message}</MessageSpan>
+      </LoadingDiv>
+    );
+  }
+
+  renderChartContainer() {
+    return (
       <div className="slice_container" data-test="slice-container">
-        {shouldRenderChart() ? (
+        {this.shouldRenderChart() ? (
           <ChartRenderer
-            annotationData={annotationData}
-            actions={actions}
-            chartId={chartId}
-            datasource={datasource}
-            initialValues={initialValues}
-            formData={formData}
-            height={height}
-            width={width}
-            setControlValue={setControlValue}
-            vizType={vizType}
-            triggerRender={triggerRender}
-            chartAlert={chartAlert}
-            chartStatus={chartStatus}
-            queriesResponse={queriesResponse}
-            triggerQuery={triggerQuery}
-            chartIsStale={chartIsStale}
-            addFilter={addFilter}
-            onFilterMenuOpen={onFilterMenuOpen}
-            onFilterMenuClose={onFilterMenuClose}
-            ownState={ownState}
-            postTransformProps={postTransformProps}
-            emitCrossFilters={emitCrossFilters}
-            onChartStateChange={onChartStateChange}
-            latestQueryFormData={latestQueryFormData}
-            filterState={filterState}
-            suppressLoadingSpinner={suppressLoadingSpinner}
-            source={dashboardId ? ChartSource.Dashboard : ChartSource.Explore}
+            {...this.props}
+            source={
+              this.props.dashboardId
+                ? ChartSource.Dashboard
+                : ChartSource.Explore
+            }
+            data-test={this.props.vizType}
           />
         ) : (
-          <Loading size={dashboardId ? 's' : 'm'} muted={!!dashboardId} />
+          <Loading
+            size={this.props.dashboardId ? 's' : 'm'}
+            muted={!!this.props.dashboardId}
+          />
         )}
       </div>
-    ),
-    [
-      actions,
-      addFilter,
-      annotationData,
-      chartAlert,
-      chartId,
-      chartIsStale,
-      chartStatus,
-      dashboardId,
-      datasource,
-      emitCrossFilters,
-      filterState,
-      formData,
+    );
+  }
+
+  render() {
+    const {
       height,
-      initialValues,
-      latestQueryFormData,
-      onChartStateChange,
-      onFilterMenuClose,
-      onFilterMenuOpen,
-      ownState,
-      postTransformProps,
-      queriesResponse,
-      setControlValue,
-      shouldRenderChart,
-      suppressLoadingSpinner,
-      triggerQuery,
-      triggerRender,
-      vizType,
+      chartAlert,
+      chartStatus,
+      datasource,
+      errorMessage,
+      chartIsStale,
+      queriesResponse = [],
       width,
-    ],
-  );
+    } = this.props;
 
-  const databaseName =
-    datasource?.parent?.name ??
-    (datasource?.database?.name as string | undefined);
+    const databaseName =
+      datasource?.parent?.name ??
+      (datasource?.database?.name as string | undefined);
 
-  const isLoading = chartStatus === 'loading';
-  // Suppress spinner during auto-refresh to avoid visual flicker
-  const showSpinner = isLoading && !suppressLoadingSpinner;
+    const isLoading = chartStatus === 'loading';
+    // Suppress spinner during auto-refresh to avoid visual flicker
+    const showSpinner = isLoading && !this.props.suppressLoadingSpinner;
 
-  if (chartStatus === 'failed') {
-    return (
-      <ErrorContainer height={height}>
-        {queriesResponse?.map(item =>
-          renderErrorMessage(item as ChartErrorType),
-        )}
-      </ErrorContainer>
-    );
-  }
+    if (chartStatus === 'failed') {
+      return (
+        <ErrorContainer height={height}>
+          {queriesResponse?.map(item =>
+            this.renderErrorMessage(item as ChartErrorType),
+          )}
+        </ErrorContainer>
+      );
+    }
 
-  if (errorMessage && ensureIsArray(queriesResponse).length === 0) {
-    return (
-      <EmptyState
-        size="large"
-        title={t('Add required control values to preview chart')}
-        description={getChartRequiredFieldsMissingMessage(true)}
-        image="chart.svg"
-      />
-    );
-  }
-  if (
-    !isLoading &&
-    !chartAlert &&
-    !errorMessage &&
-    chartIsStale &&
-    ensureIsArray(queriesResponse).length === 0
-  ) {
-    return (
-      <EmptyState
-        size="large"
-        title={t('Your chart is ready to go!')}
-        description={
-          <span>
-            {t(
-              'Click on "Create chart" button in the control panel on the left to preview a visualization or',
-            )}{' '}
-            <span role="button" tabIndex={0} onClick={onQuery}>
-              {t('click here')}
+    if (errorMessage && ensureIsArray(queriesResponse).length === 0) {
+      return (
+        <EmptyState
+          size="large"
+          title={t('Add required control values to preview chart')}
+          description={getChartRequiredFieldsMissingMessage(true)}
+          image="chart.svg"
+        />
+      );
+    }
+    if (
+      !isLoading &&
+      !chartAlert &&
+      !errorMessage &&
+      chartIsStale &&
+      ensureIsArray(queriesResponse).length === 0
+    ) {
+      return (
+        <EmptyState
+          size="large"
+          title={t('Your chart is ready to go!')}
+          description={
+            <span>
+              {t(
+                'Click on "Create chart" button in the control panel on the left to preview a visualization or',
+              )}{' '}
+              <span role="button" tabIndex={0} onClick={this.props.onQuery}>
+                {t('click here')}
+              </span>
+              .
             </span>
-            .
-          </span>
-        }
-        image="chart.svg"
-      />
+          }
+          image="chart.svg"
+        />
+      );
+    }
+
+    return (
+      <ErrorBoundary
+        onError={this.handleRenderContainerFailure}
+        showMessage={false}
+      >
+        <Styles
+          data-ui-anchor="chart"
+          className="chart-container"
+          data-test="chart-container"
+          height={height}
+          width={width}
+        >
+          {showSpinner
+            ? this.renderSpinner(databaseName)
+            : this.renderChartContainer()}
+        </Styles>
+      </ErrorBoundary>
     );
   }
-
-  return (
-    <ErrorBoundary onError={handleRenderContainerFailure} showMessage={false}>
-      <Styles
-        data-ui-anchor="chart"
-        className="chart-container"
-        data-test="chart-container"
-        height={height}
-        width={width}
-      >
-        {showSpinner ? renderSpinner(databaseName) : renderChartContainer()}
-      </Styles>
-    </ErrorBoundary>
-  );
 }
 export default Chart;

superset-frontend/src/components/Chart/ChartRenderer.test.tsx

@@ -82,7 +82,7 @@ const mockActions: MockActions = {
   ) => Dispatch,
 };
 
-const requiredProps: ChartRendererProps = {
+const requiredProps: Partial<ChartRendererProps> = {
   chartId: 1,
   datasource: {} as ChartRendererProps['datasource'],
   formData: {
@@ -111,14 +111,17 @@ afterAll(() => {
 
 test('should render SuperChart', () => {
   const { getByTestId } = render(
-    <ChartRenderer {...requiredProps} chartIsStale={false} />,
+    <ChartRenderer
+      {...(requiredProps as ChartRendererProps)}
+      chartIsStale={false}
+    />,
   );
   expect(getByTestId('mock-super-chart')).toBeInTheDocument();
 });
 
 test('should use latestQueryFormData instead of formData when chartIsStale is true', () => {
   const { getByTestId } = render(
-    <ChartRenderer {...requiredProps} chartIsStale />,
+    <ChartRenderer {...(requiredProps as ChartRendererProps)} chartIsStale />,
   );
   expect(getByTestId('mock-super-chart')).toHaveTextContent(
     JSON.stringify({
@@ -128,7 +131,9 @@ test('should use latestQueryFormData instead of formData when chartIsStale is tr
 });
 
 test('should render chart context menu', () => {
-  const { getByTestId } = render(<ChartRenderer {...requiredProps} />);
+  const { getByTestId } = render(
+    <ChartRenderer {...(requiredProps as ChartRendererProps)} />,
+  );
   expect(getByTestId('mock-chart-context-menu')).toBeInTheDocument();
 });
 
@@ -143,13 +148,16 @@ test('should not render chart context menu if the context menu is suppressed for
     }),
   );
   const { queryByTestId } = render(
-    <ChartRenderer {...requiredProps} vizType="chart_without_context_menu" />,
+    <ChartRenderer
+      {...(requiredProps as ChartRendererProps)}
+      vizType="chart_without_context_menu"
+    />,
   );
   expect(queryByTestId('mock-chart-context-menu')).not.toBeInTheDocument();
 });
 
 test('should detect changes in matrixify properties', () => {
-  const initialProps: ChartRendererProps = {
+  const initialProps: Partial<ChartRendererProps> = {
     ...requiredProps,
     formData: {
       ...requiredProps.formData,
@@ -165,34 +173,41 @@ test('should detect changes in matrixify properties', () => {
     chartStatus: 'success',
   };
 
-  const { getByTestId } = render(<ChartRenderer {...initialProps} />);
+  render(<ChartRenderer {...(initialProps as ChartRendererProps)} />);
 
-  // Verify matrixify-related formData is forwarded through to the chart
-  expect(getByTestId('mock-super-chart')).toHaveTextContent(
-    JSON.stringify(initialProps.formData),
+  // Since we can't directly test shouldComponentUpdate, we verify the component
+  // correctly identifies matrixify-related properties by checking the implementation
+  expect((initialProps.formData as JsonObject).matrixify_mode_rows).toBe(
+    'metrics',
   );
+  expect((initialProps.formData as JsonObject).matrixify_dimension_x).toEqual({
+    dimension: 'country',
+    values: ['USA'],
+  });
 });
 
 test('should detect changes in postTransformProps', () => {
   const postTransformProps = jest.fn((x: JsonObject) => x);
-  const initialProps: ChartRendererProps = {
+  const initialProps: Partial<ChartRendererProps> = {
     ...requiredProps,
     queriesResponse: [{ data: 'initial' } as unknown as JsonObject],
     chartStatus: 'success',
   };
-  const { rerender } = render(<ChartRenderer {...initialProps} />);
-  const updatedProps: ChartRendererProps = {
+  const { rerender } = render(
+    <ChartRenderer {...(initialProps as ChartRendererProps)} />,
+  );
+  const updatedProps: Partial<ChartRendererProps> = {
     ...initialProps,
     postTransformProps,
   };
   expect(postTransformProps).toHaveBeenCalledTimes(0);
-  rerender(<ChartRenderer {...updatedProps} />);
+  rerender(<ChartRenderer {...(updatedProps as ChartRendererProps)} />);
   expect(postTransformProps).toHaveBeenCalledTimes(1);
 });
 
 test('should identify matrixify property changes correctly', () => {
   // Test that formData with different matrixify properties triggers updates
-  const initialProps: ChartRendererProps = {
+  const initialProps: Partial<ChartRendererProps> = {
     ...requiredProps,
     formData: {
       datasource: '',
@@ -206,14 +221,16 @@ test('should identify matrixify property changes correctly', () => {
     chartStatus: 'success',
   };
 
-  const { rerender, getByTestId } = render(<ChartRenderer {...initialProps} />);
+  const { rerender, getByTestId } = render(
+    <ChartRenderer {...(initialProps as ChartRendererProps)} />,
+  );
 
   expect(getByTestId('mock-super-chart')).toHaveTextContent(
     JSON.stringify(initialProps.formData),
   );
 
   // Update with changed matrixify_dimension_x values
-  const updatedProps: ChartRendererProps = {
+  const updatedProps: Partial<ChartRendererProps> = {
     ...initialProps,
     formData: {
       datasource: '',
@@ -228,7 +245,7 @@ test('should identify matrixify property changes correctly', () => {
     },
   };
 
-  rerender(<ChartRenderer {...updatedProps} />);
+  rerender(<ChartRenderer {...(updatedProps as ChartRendererProps)} />);
 
   // Verify the component re-rendered with new props
   expect(getByTestId('mock-super-chart')).toHaveTextContent(
@@ -237,7 +254,7 @@ test('should identify matrixify property changes correctly', () => {
 });
 
 test('should handle matrixify-related form data changes', () => {
-  const initialProps: ChartRendererProps = {
+  const initialProps: Partial<ChartRendererProps> = {
     ...requiredProps,
     formData: {
       datasource: '',
@@ -248,14 +265,16 @@ test('should handle matrixify-related form data changes', () => {
     chartStatus: 'success',
   };
 
-  const { rerender, getByTestId } = render(<ChartRenderer {...initialProps} />);
+  const { rerender, getByTestId } = render(
+    <ChartRenderer {...(initialProps as ChartRendererProps)} />,
+  );
 
   expect(getByTestId('mock-super-chart')).toHaveTextContent(
     JSON.stringify(initialProps.formData),
   );
 
   // Enable matrixify
-  const updatedProps: ChartRendererProps = {
+  const updatedProps: Partial<ChartRendererProps> = {
     ...initialProps,
     formData: {
       datasource: '',
@@ -266,7 +285,7 @@ test('should handle matrixify-related form data changes', () => {
     },
   };
 
-  rerender(<ChartRenderer {...updatedProps} />);
+  rerender(<ChartRenderer {...(updatedProps as ChartRendererProps)} />);
 
   // Verify the component re-rendered with matrixify enabled
   expect(getByTestId('mock-super-chart')).toHaveTextContent(
@@ -275,7 +294,7 @@ test('should handle matrixify-related form data changes', () => {
 });
 
 test('should detect matrixify property addition', () => {
-  const initialProps: ChartRendererProps = {
+  const initialProps: Partial<ChartRendererProps> = {
     ...requiredProps,
     formData: {
       datasource: '',
@@ -288,14 +307,16 @@ test('should detect matrixify property addition', () => {
     chartStatus: 'success',
   };
 
-  const { rerender, getByTestId } = render(<ChartRenderer {...initialProps} />);
+  const { rerender, getByTestId } = render(
+    <ChartRenderer {...(initialProps as ChartRendererProps)} />,
+  );
 
   expect(getByTestId('mock-super-chart')).toHaveTextContent(
     JSON.stringify(initialProps.formData),
   );
 
   // Add matrixify_dimension_x
-  const updatedProps: ChartRendererProps = {
+  const updatedProps: Partial<ChartRendererProps> = {
     ...initialProps,
     formData: {
       datasource: '',
@@ -306,7 +327,7 @@ test('should detect matrixify property addition', () => {
     },
   };
 
-  rerender(<ChartRenderer {...updatedProps} />);
+  rerender(<ChartRenderer {...(updatedProps as ChartRendererProps)} />);
 
   // Verify the component re-rendered with the new property
   expect(getByTestId('mock-super-chart')).toHaveTextContent(
@@ -315,7 +336,7 @@ test('should detect matrixify property addition', () => {
 });
 
 test('should detect nested matrixify property changes', () => {
-  const initialProps: ChartRendererProps = {
+  const initialProps: Partial<ChartRendererProps> = {
     ...requiredProps,
     formData: {
       datasource: '',
@@ -332,14 +353,16 @@ test('should detect nested matrixify property changes', () => {
     chartStatus: 'success',
   };
 
-  const { rerender, getByTestId } = render(<ChartRenderer {...initialProps} />);
+  const { rerender, getByTestId } = render(
+    <ChartRenderer {...(initialProps as ChartRendererProps)} />,
+  );
 
   expect(getByTestId('mock-super-chart')).toHaveTextContent(
     JSON.stringify(initialProps.formData),
   );
 
   // Change nested topN value
-  const updatedProps: ChartRendererProps = {
+  const updatedProps: Partial<ChartRendererProps> = {
     ...initialProps,
     formData: {
       datasource: '',
@@ -354,7 +377,7 @@ test('should detect nested matrixify property changes', () => {
     },
   };
 
-  rerender(<ChartRenderer {...updatedProps} />);
+  rerender(<ChartRenderer {...(updatedProps as ChartRendererProps)} />);
 
   // Verify the component re-rendered with the nested change
   expect(getByTestId('mock-super-chart')).toHaveTextContent(

superset-frontend/src/components/Chart/ChartRenderer.tsx

@@ -16,17 +16,8 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { snakeCase, cloneDeep } from 'lodash';
-import {
-  useCallback,
-  useEffect,
-  useState,
-  useRef,
-  useMemo,
-  MouseEvent,
-  ReactNode,
-  memo,
-} from 'react';
+import { snakeCase, isEqual, cloneDeep } from 'lodash';
+import { createRef, Component, RefObject, MouseEvent, ReactNode } from 'react';
 import {
   SuperChart,
   Behavior,
@@ -37,7 +28,6 @@ import {
   QueryFormData,
   AnnotationData,
   DataMask,
-  FilterState,
   QueryData,
   JsonObject,
   LatestQueryFormData,
@@ -47,7 +37,6 @@ import {
 } from '@superset-ui/core';
 import { logging } from '@apache-superset/core/utils';
 import { t } from '@apache-superset/core/translation';
-import { useTheme } from '@apache-superset/core/theme';
 import { Logger, LOG_ACTIONS_RENDER_CHART } from 'src/logger/LogUtils';
 import { EmptyState } from '@superset-ui/core/components';
 import { ChartSource } from 'src/types/ChartSource';
@@ -102,6 +91,12 @@ interface OwnState {
   [key: string]: unknown;
 }
 
+// Types for filter state
+interface FilterState {
+  value?: FilterValue[];
+  [key: string]: unknown;
+}
+
 // Props interface
 export interface ChartRendererProps {
   annotationData?: AnnotationData;
@@ -129,6 +124,7 @@ export interface ChartRendererProps {
     merge?: boolean,
     refresh?: boolean,
   ) => void;
+  setDataMask?: (dataMask: DataMask) => void;
   onFilterMenuOpen?: (chartId: number, column: string) => void;
   onFilterMenuClose?: (chartId: number, column: string) => void;
   ownState?: OwnState;
@@ -141,6 +137,14 @@ export interface ChartRendererProps {
   suppressLoadingSpinner?: boolean;
 }
 
+// State interface
+interface ChartRendererState {
+  showContextMenu: boolean;
+  inContextMenu: boolean;
+  legendState: LegendState | undefined;
+  legendIndex: number;
+}
+
 // Hooks interface
 interface ChartHooks {
   onAddFilter: (
@@ -171,376 +175,402 @@ const BIG_NO_RESULT_MIN_HEIGHT = 220;
 
 const behaviors = [Behavior.InteractiveChart];
 
-interface ChartRendererState {
-  inContextMenu: boolean;
-  legendState: LegendState | undefined;
-  legendIndex: number;
-}
+const defaultProps: Partial<ChartRendererProps> = {
+  addFilter: () => BLANK,
+  onFilterMenuOpen: () => BLANK,
+  onFilterMenuClose: () => BLANK,
+  initialValues: BLANK,
+  setControlValue: () => {},
+  triggerRender: false,
+};
 
-function ChartRendererComponent({
-  addFilter = () => BLANK,
-  onFilterMenuOpen = () => BLANK,
-  onFilterMenuClose = () => BLANK,
-  initialValues = BLANK,
-  setControlValue = () => {},
-  triggerRender = false,
-  ...restProps
-}: ChartRendererProps): JSX.Element | null {
-  const {
-    annotationData,
-    actions,
-    chartId,
-    datasource,
-    formData,
-    latestQueryFormData,
-    height,
-    width,
-    vizType: propVizType,
-    chartAlert,
-    chartStatus,
-    queriesResponse,
-    chartIsStale,
-    ownState,
-    filterState,
-    postTransformProps,
-    source,
-    emitCrossFilters,
-    onChartStateChange,
-  } = restProps;
+class ChartRenderer extends Component<ChartRendererProps, ChartRendererState> {
+  static defaultProps = defaultProps;
 
-  const theme = useTheme();
+  private hasQueryResponseChange: boolean;
 
-  const suppressContextMenu = getChartMetadataRegistry().get(
-    formData.viz_type ?? propVizType,
-  )?.suppressContextMenu;
+  private contextMenuRef: RefObject<ChartContextMenuRef>;
 
-  // Derived from props/feature-flags: must NOT live in state, otherwise a
-  // `source` or viz-type change on the same mounted instance would leave
-  // it stale. (Pre-refactor this was a class-instance field recomputed on
-  // every render — preserve that semantic by using a memo here.)
-  const showContextMenu = useMemo(
-    () =>
-      source === ChartSource.Dashboard &&
-      !suppressContextMenu &&
-      isFeatureEnabled(FeatureFlag.DrillToDetail),
-    [source, suppressContextMenu],
-  );
+  private hooks: ChartHooks;
 
-  const [state, setState] = useState<ChartRendererState>({
-    inContextMenu: false,
-    legendState: undefined,
-    legendIndex: 0,
-  });
+  private mutableQueriesResponse: QueryData[] | null | undefined;
 
-  const hasQueryResponseChangeRef = useRef(false);
-  const renderStartTimeRef = useRef(0);
-  const contextMenuRef = useRef<ChartContextMenuRef>(null);
+  private renderStartTime: number;
 
-  // Results are "ready" when we have a non-error queriesResponse and the
-  // chartStatus reflects it. This mirrors the gating logic from the former
-  // shouldComponentUpdate implementation.
-  const resultsReady =
-    queriesResponse &&
-    ['success', 'rendered'].indexOf(chartStatus as string) > -1 &&
-    !queriesResponse?.[0]?.error;
+  constructor(props: ChartRendererProps) {
+    super(props);
+    const suppressContextMenu = getChartMetadataRegistry().get(
+      props.formData.viz_type ?? props.vizType,
+    )?.suppressContextMenu;
+    this.state = {
+      showContextMenu:
+        props.source === ChartSource.Dashboard &&
+        !suppressContextMenu &&
+        isFeatureEnabled(FeatureFlag.DrillToDetail),
+      inContextMenu: false,
+      legendState: undefined,
+      legendIndex: 0,
+    };
+    this.hasQueryResponseChange = false;
+    this.renderStartTime = 0;
 
-  // Track whether queriesResponse changed since the previous render so that
-  // handleRenderSuccess / handleRenderFailure know whether to log render time.
-  // Updating a ref during render is safe when the value doesn't affect the
-  // render output (here it's read asynchronously from SuperChart callbacks).
-  const prevQueriesResponseRef = useRef<QueryData[] | null | undefined>(
-    queriesResponse,
-  );
-  if (resultsReady) {
-    hasQueryResponseChangeRef.current =
-      queriesResponse !== prevQueriesResponseRef.current;
+    this.contextMenuRef = createRef<ChartContextMenuRef>();
+
+    this.handleAddFilter = this.handleAddFilter.bind(this);
+    this.handleRenderSuccess = this.handleRenderSuccess.bind(this);
+    this.handleRenderFailure = this.handleRenderFailure.bind(this);
+    this.handleSetControlValue = this.handleSetControlValue.bind(this);
+    this.handleOnContextMenu = this.handleOnContextMenu.bind(this);
+    this.handleContextMenuSelected = this.handleContextMenuSelected.bind(this);
+    this.handleContextMenuClosed = this.handleContextMenuClosed.bind(this);
+    this.handleLegendStateChanged = this.handleLegendStateChanged.bind(this);
+    this.onContextMenuFallback = this.onContextMenuFallback.bind(this);
+    this.handleLegendScroll = this.handleLegendScroll.bind(this);
+
+    this.hooks = {
+      onAddFilter: this.handleAddFilter,
+      onContextMenu: this.state.showContextMenu
+        ? this.handleOnContextMenu
+        : undefined,
+      onError: this.handleRenderFailure,
+      setControlValue: this.handleSetControlValue,
+      onFilterMenuOpen: this.props.onFilterMenuOpen,
+      onFilterMenuClose: this.props.onFilterMenuClose,
+      onLegendStateChanged: this.handleLegendStateChanged,
+      setDataMask: (dataMask: DataMask) => {
+        this.props.actions?.updateDataMask?.(this.props.chartId, dataMask);
+      },
+      onLegendScroll: this.handleLegendScroll,
+      onChartStateChange: this.props.onChartStateChange,
+    };
+
+    // TODO: queriesResponse comes from Redux store but it's being edited by
+    // the plugins, hence we need to clone it to avoid state mutation
+    // until we change the reducers to use Redux Toolkit with Immer
+    this.mutableQueriesResponse = cloneDeep(this.props.queriesResponse);
   }
-  useEffect(() => {
-    prevQueriesResponseRef.current = queriesResponse;
-  }, [queriesResponse]);
 
-  // Clone queriesResponse to protect against plugin mutation of Redux state.
-  // Gate on `resultsReady` so the deep clone doesn't run for every
-  // queriesResponse identity change during loading/idle (only when results
-  // are actually about to render). Matches the pre-refactor gating.
-  // TODO: remove once reducers use Redux Toolkit with Immer.
-  const mutableQueriesResponse = useMemo(
-    () => (resultsReady ? cloneDeep(queriesResponse) : undefined),
-    [queriesResponse, resultsReady],
-  );
+  shouldComponentUpdate(
+    nextProps: ChartRendererProps,
+    nextState: ChartRendererState,
+  ): boolean {
+    const resultsReady =
+      nextProps.queriesResponse &&
+      ['success', 'rendered'].indexOf(nextProps.chartStatus as string) > -1 &&
+      !nextProps.queriesResponse?.[0]?.error;
 
-  // Handler functions
-  const handleAddFilter = useCallback(
-    (col: string, vals: FilterValue[], merge = true, refresh = true): void => {
-      addFilter?.(col, vals, merge, refresh);
-    },
-    [addFilter],
-  );
+    if (resultsReady) {
+      if (!isEqual(this.state, nextState)) {
+        return true;
+      }
+      this.hasQueryResponseChange =
+        nextProps.queriesResponse !== this.props.queriesResponse;
 
-  const handleRenderSuccess = useCallback((): void => {
+      if (this.hasQueryResponseChange) {
+        this.mutableQueriesResponse = cloneDeep(nextProps.queriesResponse);
+      }
+
+      // Check if any matrixify-related properties have changed
+      const hasMatrixifyChanges = (): boolean => {
+        const nextFormData = nextProps.formData as JsonObject;
+        const currentFormData = this.props.formData as JsonObject;
+        const isMatrixifyEnabled =
+          nextFormData.matrixify_enable === true &&
+          ((nextFormData.matrixify_mode_rows !== undefined &&
+            nextFormData.matrixify_mode_rows !== 'disabled') ||
+            (nextFormData.matrixify_mode_columns !== undefined &&
+              nextFormData.matrixify_mode_columns !== 'disabled'));
+        if (!isMatrixifyEnabled) return false;
+
+        // Check all matrixify-related properties
+        const matrixifyKeys = Object.keys(nextFormData).filter(key =>
+          key.startsWith('matrixify_'),
+        );
+
+        return matrixifyKeys.some(
+          key => !isEqual(nextFormData[key], currentFormData[key]),
+        );
+      };
+
+      const nextFormData = nextProps.formData as JsonObject;
+      const currentFormData = this.props.formData as JsonObject;
+
+      return (
+        this.hasQueryResponseChange ||
+        !isEqual(nextProps.datasource, this.props.datasource) ||
+        nextProps.annotationData !== this.props.annotationData ||
+        nextProps.ownState !== this.props.ownState ||
+        nextProps.filterState !== this.props.filterState ||
+        nextProps.height !== this.props.height ||
+        nextProps.width !== this.props.width ||
+        nextProps.triggerRender === true ||
+        nextProps.labelsColor !== this.props.labelsColor ||
+        nextProps.labelsColorMap !== this.props.labelsColorMap ||
+        nextFormData.color_scheme !== currentFormData.color_scheme ||
+        nextFormData.stack !== currentFormData.stack ||
+        nextFormData.subcategories !== currentFormData.subcategories ||
+        nextProps.cacheBusterProp !== this.props.cacheBusterProp ||
+        nextProps.emitCrossFilters !== this.props.emitCrossFilters ||
+        nextProps.postTransformProps !== this.props.postTransformProps ||
+        hasMatrixifyChanges()
+      );
+    }
+    return false;
+  }
+
+  handleAddFilter(
+    col: string,
+    vals: FilterValue[],
+    merge = true,
+    refresh = true,
+  ): void {
+    this.props.addFilter?.(col, vals, merge, refresh);
+  }
+
+  handleRenderSuccess(): void {
+    const { actions, chartStatus, chartId, vizType } = this.props;
     if (['loading', 'rendered'].indexOf(chartStatus as string) < 0) {
       actions.chartRenderingSucceeded(chartId);
     }
 
     // only log chart render time which is triggered by query results change
-    if (hasQueryResponseChangeRef.current) {
+    // currently we don't log chart re-render time, like window resize etc
+    if (this.hasQueryResponseChange) {
       actions.logEvent(LOG_ACTIONS_RENDER_CHART, {
         slice_id: chartId,
-        viz_type: propVizType,
-        start_offset: renderStartTimeRef.current,
+        viz_type: vizType,
+        start_offset: this.renderStartTime,
         ts: new Date().getTime(),
-        duration: Logger.getTimestamp() - renderStartTimeRef.current,
+        duration: Logger.getTimestamp() - this.renderStartTime,
       });
     }
-  }, [actions, chartId, chartStatus, propVizType]);
+  }
 
-  const handleRenderFailure = useCallback(
-    (error: Error, info: { componentStack: string } | null): void => {
-      logging.warn(error);
-      actions.chartRenderingFailed(
-        error.toString(),
-        chartId,
-        info ? info.componentStack : null,
-      );
+  handleRenderFailure(
+    error: Error,
+    info: { componentStack: string } | null,
+  ): void {
+    const { actions, chartId } = this.props;
+    logging.warn(error);
+    actions.chartRenderingFailed(
+      error.toString(),
+      chartId,
+      info ? info.componentStack : null,
+    );
 
-      // only trigger render log when query is changed
-      if (hasQueryResponseChangeRef.current) {
-        actions.logEvent(LOG_ACTIONS_RENDER_CHART, {
-          slice_id: chartId,
-          has_err: true,
-          error_details: error.toString(),
-          start_offset: renderStartTimeRef.current,
-          ts: new Date().getTime(),
-          duration: Logger.getTimestamp() - renderStartTimeRef.current,
-        });
-      }
-    },
-    [actions, chartId],
-  );
+    // only trigger render log when query is changed
+    if (this.hasQueryResponseChange) {
+      actions.logEvent(LOG_ACTIONS_RENDER_CHART, {
+        slice_id: chartId,
+        has_err: true,
+        error_details: error.toString(),
+        start_offset: this.renderStartTime,
+        ts: new Date().getTime(),
+        duration: Logger.getTimestamp() - this.renderStartTime,
+      });
+    }
+  }
 
-  const handleSetControlValue = useCallback(
-    (name: string, value: unknown): void => {
-      if (setControlValue) {
-        setControlValue(name, value);
-      }
-    },
-    [setControlValue],
-  );
+  handleSetControlValue(name: string, value: unknown): void {
+    const { setControlValue } = this.props;
+    if (setControlValue) {
+      setControlValue(name, value);
+    }
+  }
 
-  const handleOnContextMenu = useCallback(
-    (offsetX: number, offsetY: number, filters?: ContextMenuFilters): void => {
-      contextMenuRef.current?.open(offsetX, offsetY, filters);
-      setState(prev => ({ ...prev, inContextMenu: true }));
-    },
-    [contextMenuRef],
-  );
+  handleOnContextMenu(
+    offsetX: number,
+    offsetY: number,
+    filters?: ContextMenuFilters,
+  ): void {
+    this.contextMenuRef.current?.open(offsetX, offsetY, filters);
+    this.setState({ inContextMenu: true });
+  }
 
-  const handleContextMenuSelected = useCallback((): void => {
-    setState(prev => ({ ...prev, inContextMenu: false }));
-  }, []);
+  handleContextMenuSelected(): void {
+    this.setState({ inContextMenu: false });
+  }
 
-  const handleContextMenuClosed = useCallback((): void => {
-    setState(prev => ({ ...prev, inContextMenu: false }));
-  }, []);
+  handleContextMenuClosed(): void {
+    this.setState({ inContextMenu: false });
+  }
 
-  const handleLegendStateChanged = useCallback(
-    (legendState: LegendState): void => {
-      setState(prev => ({ ...prev, legendState }));
-    },
-    [],
-  );
-
-  const handleLegendScroll = useCallback((legendIndex: number): void => {
-    setState(prev => ({ ...prev, legendIndex }));
-  }, []);
+  handleLegendStateChanged(legendState: LegendState): void {
+    this.setState({ legendState });
+  }
 
   // When viz plugins don't handle `contextmenu` event, fallback handler
   // calls `handleOnContextMenu` with no `filters` param.
-  const onContextMenuFallback = useCallback(
-    (event: MouseEvent<HTMLDivElement>): void => {
-      if (!state.inContextMenu) {
-        event.preventDefault();
-        handleOnContextMenu(event.clientX, event.clientY);
-      }
-    },
-    [handleOnContextMenu, state.inContextMenu],
-  );
-
-  const setDataMaskCallback = useCallback(
-    (dataMask: DataMask) => {
-      actions?.updateDataMask?.(chartId, dataMask);
-    },
-    [actions, chartId],
-  );
-
-  // Hooks object - memoized
-  const hooks = useMemo<ChartHooks>(
-    () => ({
-      onAddFilter: handleAddFilter,
-      onContextMenu: showContextMenu ? handleOnContextMenu : undefined,
-      onError: handleRenderFailure,
-      setControlValue: handleSetControlValue,
-      onFilterMenuOpen,
-      onFilterMenuClose,
-      onLegendStateChanged: handleLegendStateChanged,
-      setDataMask: setDataMaskCallback,
-      onLegendScroll: handleLegendScroll,
-      onChartStateChange,
-    }),
-    [
-      handleAddFilter,
-      handleLegendScroll,
-      handleLegendStateChanged,
-      handleOnContextMenu,
-      handleRenderFailure,
-      handleSetControlValue,
-      onChartStateChange,
-      onFilterMenuClose,
-      onFilterMenuOpen,
-      setDataMaskCallback,
-      showContextMenu,
-    ],
-  );
-
-  const hasAnyErrors = queriesResponse?.some(item => item?.error);
-  const hasValidPreviousData =
-    (queriesResponse?.length ?? 0) > 0 && !hasAnyErrors;
-
-  if (!!chartAlert || chartStatus === null) {
-    return null;
-  }
-
-  if (chartStatus === 'loading') {
-    if (!restProps.suppressLoadingSpinner || !hasValidPreviousData) {
-      return null;
+  onContextMenuFallback(event: MouseEvent<HTMLDivElement>): void {
+    if (!this.state.inContextMenu) {
+      event.preventDefault();
+      this.handleOnContextMenu(event.clientX, event.clientY);
     }
   }
 
-  renderStartTimeRef.current = Logger.getTimestamp();
-
-  const currentFormData =
-    chartIsStale && latestQueryFormData ? latestQueryFormData : formData;
-  const vizType = currentFormData.viz_type || propVizType;
-
-  // It's bad practice to use unprefixed `vizType` as classnames for chart
-  // container. It may cause css conflicts as in the case of legacy table chart.
-  // When migrating charts, we should gradually add a `superset-chart-` prefix
-  // to each one of them.
-  const snakeCaseVizType = snakeCase(vizType);
-  const chartClassName =
-    vizType === VizType.Table
-      ? `superset-chart-${snakeCaseVizType}`
-      : snakeCaseVizType;
-
-  const webpackHash =
-    process.env.WEBPACK_MODE === 'development'
-      ? `-${
-          // eslint-disable-next-line camelcase
-          typeof __webpack_require__ !== 'undefined' &&
-          // eslint-disable-next-line camelcase, no-undef
-          typeof __webpack_require__.h === 'function' &&
-          // eslint-disable-next-line no-undef, camelcase
-          __webpack_require__.h()
-        }`
-      : '';
-
-  let noResultsComponent: ReactNode;
-  const noResultTitle = t('No results were returned for this query');
-  const noResultDescription =
-    source === ChartSource.Explore
-      ? t(
-          'Make sure that the controls are configured properly and the datasource contains data for the selected time range',
-        )
-      : undefined;
-  const noResultImage = 'chart.svg';
-  if (
-    (width ?? 0) > BIG_NO_RESULT_MIN_WIDTH &&
-    (height ?? 0) > BIG_NO_RESULT_MIN_HEIGHT
-  ) {
-    noResultsComponent = (
-      <EmptyState
-        size="large"
-        title={noResultTitle}
-        description={noResultDescription}
-        image={noResultImage}
-      />
-    );
-  } else {
-    noResultsComponent = (
-      <EmptyState title={noResultTitle} image={noResultImage} size="small" />
-    );
+  handleLegendScroll(legendIndex: number): void {
+    this.setState({ legendIndex });
   }
 
-  // Check for Behavior.DRILL_TO_DETAIL to tell if chart can receive Drill to
-  // Detail props or if it'll cause side-effects (e.g. excessive re-renders).
-  const drillToDetailProps = getChartMetadataRegistry()
-    .get(vizType)
-    ?.behaviors.find(behavior => behavior === Behavior.DrillToDetail)
-    ? { inContextMenu: state.inContextMenu }
-    : {};
-  // By pass no result component when server pagination is enabled & the table has:
-  // - a backend search query, OR
-  // - non-empty AG Grid filter model
-  const hasSearchText = (ownState?.searchText?.length || 0) > 0;
-  const hasAgGridFilters =
-    ownState?.agGridFilterModel &&
-    Object.keys(ownState.agGridFilterModel).length > 0;
+  render(): ReactNode {
+    const { chartAlert, chartStatus, chartId, emitCrossFilters } = this.props;
 
-  const currentFormDataExtended = currentFormData as JsonObject;
-  const bypassNoResult = !(
-    currentFormDataExtended?.server_pagination &&
-    (hasSearchText || hasAgGridFilters)
-  );
+    const hasAnyErrors = this.props.queriesResponse?.some(item => item?.error);
+    const hasValidPreviousData =
+      (this.props.queriesResponse?.length ?? 0) > 0 && !hasAnyErrors;
 
-  return (
-    <>
-      {showContextMenu && (
-        <ChartContextMenu
-          ref={contextMenuRef}
-          id={chartId}
-          formData={currentFormData as QueryFormData}
-          onSelection={handleContextMenuSelected}
-          onClose={handleContextMenuClosed}
+    if (!!chartAlert || chartStatus === null) {
+      return null;
+    }
+
+    if (chartStatus === 'loading') {
+      if (!this.props.suppressLoadingSpinner || !hasValidPreviousData) {
+        return null;
+      }
+    }
+
+    this.renderStartTime = Logger.getTimestamp();
+
+    const {
+      width,
+      height,
+      datasource,
+      annotationData,
+      initialValues,
+      ownState,
+      filterState,
+      chartIsStale,
+      formData,
+      latestQueryFormData,
+      postTransformProps,
+    } = this.props;
+
+    const currentFormData =
+      chartIsStale && latestQueryFormData ? latestQueryFormData : formData;
+    const vizType = currentFormData.viz_type || this.props.vizType;
+
+    // It's bad practice to use unprefixed `vizType` as classnames for chart
+    // container. It may cause css conflicts as in the case of legacy table chart.
+    // When migrating charts, we should gradually add a `superset-chart-` prefix
+    // to each one of them.
+    const snakeCaseVizType = snakeCase(vizType);
+    const chartClassName =
+      vizType === VizType.Table
+        ? `superset-chart-${snakeCaseVizType}`
+        : snakeCaseVizType;
+
+    const webpackHash =
+      process.env.WEBPACK_MODE === 'development'
+        ? `-${
+            // eslint-disable-next-line camelcase
+            typeof __webpack_require__ !== 'undefined' &&
+            // eslint-disable-next-line camelcase, no-undef
+            typeof __webpack_require__.h === 'function' &&
+            // eslint-disable-next-line no-undef, camelcase
+            __webpack_require__.h()
+          }`
+        : '';
+
+    let noResultsComponent: ReactNode;
+    const noResultTitle = t('No results were returned for this query');
+    const noResultDescription =
+      this.props.source === ChartSource.Explore
+        ? t(
+            'Make sure that the controls are configured properly and the datasource contains data for the selected time range',
+          )
+        : undefined;
+    const noResultImage = 'chart.svg';
+    if (
+      (width ?? 0) > BIG_NO_RESULT_MIN_WIDTH &&
+      (height ?? 0) > BIG_NO_RESULT_MIN_HEIGHT
+    ) {
+      noResultsComponent = (
+        <EmptyState
+          size="large"
+          title={noResultTitle}
+          description={noResultDescription}
+          image={noResultImage}
         />
-      )}
-      <div onContextMenu={showContextMenu ? onContextMenuFallback : undefined}>
-        <SuperChart
-          disableErrorBoundary
-          key={`${chartId}${webpackHash}`}
-          id={`chart-id-${chartId}`}
-          className={chartClassName}
-          chartType={vizType}
-          width={width}
-          height={height}
-          theme={theme}
-          annotationData={annotationData}
-          datasource={datasource}
-          initialValues={initialValues}
-          formData={currentFormData}
-          ownState={ownState}
-          filterState={filterState}
-          hooks={hooks as unknown as Parameters<typeof SuperChart>[0]['hooks']}
-          behaviors={behaviors}
-          queriesData={mutableQueriesResponse ?? undefined}
-          onRenderSuccess={handleRenderSuccess}
-          onRenderFailure={handleRenderFailure}
-          noResults={noResultsComponent}
-          postTransformProps={postTransformProps}
-          emitCrossFilters={emitCrossFilters}
-          legendState={state.legendState}
-          enableNoResults={bypassNoResult}
-          legendIndex={state.legendIndex}
-          isRefreshing={
-            Boolean(restProps.suppressLoadingSpinner) &&
-            chartStatus === 'loading'
+      );
+    } else {
+      noResultsComponent = (
+        <EmptyState title={noResultTitle} image={noResultImage} size="small" />
+      );
+    }
+
+    // Check for Behavior.DRILL_TO_DETAIL to tell if chart can receive Drill to
+    // Detail props or if it'll cause side-effects (e.g. excessive re-renders).
+    const drillToDetailProps = getChartMetadataRegistry()
+      .get(vizType)
+      ?.behaviors.find(behavior => behavior === Behavior.DrillToDetail)
+      ? { inContextMenu: this.state.inContextMenu }
+      : {};
+    // By pass no result component when server pagination is enabled & the table has:
+    // - a backend search query, OR
+    // - non-empty AG Grid filter model
+    const hasSearchText = (ownState?.searchText?.length || 0) > 0;
+    const hasAgGridFilters =
+      ownState?.agGridFilterModel &&
+      Object.keys(ownState.agGridFilterModel).length > 0;
+
+    const currentFormDataExtended = currentFormData as JsonObject;
+    const bypassNoResult = !(
+      currentFormDataExtended?.server_pagination &&
+      (hasSearchText || hasAgGridFilters)
+    );
+
+    return (
+      <>
+        {this.state.showContextMenu && (
+          <ChartContextMenu
+            ref={this.contextMenuRef}
+            id={chartId}
+            formData={currentFormData as QueryFormData}
+            onSelection={this.handleContextMenuSelected}
+            onClose={this.handleContextMenuClosed}
+          />
+        )}
+        <div
+          onContextMenu={
+            this.state.showContextMenu ? this.onContextMenuFallback : undefined
           }
-          {...drillToDetailProps}
-        />
-      </div>
-    </>
-  );
+        >
+          <SuperChart
+            disableErrorBoundary
+            key={`${chartId}${webpackHash}`}
+            id={`chart-id-${chartId}`}
+            className={chartClassName}
+            chartType={vizType}
+            width={width}
+            height={height}
+            annotationData={annotationData}
+            datasource={datasource}
+            initialValues={initialValues}
+            formData={currentFormData}
+            ownState={ownState}
+            filterState={filterState}
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            hooks={this.hooks as any}
+            behaviors={behaviors}
+            queriesData={this.mutableQueriesResponse ?? undefined}
+            onRenderSuccess={this.handleRenderSuccess}
+            onRenderFailure={this.handleRenderFailure}
+            noResults={noResultsComponent}
+            postTransformProps={postTransformProps}
+            emitCrossFilters={emitCrossFilters}
+            legendState={this.state.legendState}
+            enableNoResults={bypassNoResult}
+            legendIndex={this.state.legendIndex}
+            isRefreshing={
+              Boolean(this.props.suppressLoadingSpinner) &&
+              chartStatus === 'loading'
+            }
+            {...drillToDetailProps}
+          />
+        </div>
+      </>
+    );
+  }
 }
 
-const ChartRenderer = memo(ChartRendererComponent);
-
 export default ChartRenderer;