chore(helm): bump chart version to 0.17.0

The chart lint requires a version bump when chart files change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

.github/ISSUE_TEMPLATE/bug-report.yml

@@ -41,8 +41,8 @@ body:
       label: Superset version
       options:
         - master / latest-dev
-        - "6.1.0"
         - "6.0.0"
+        - "5.0.0"
     validations:
       required: true
   - type: dropdown

.github/actions/setup-backend/action.yml

@@ -42,7 +42,7 @@ runs:
         fi
         echo "python-version=$RESOLVED_VERSION" >> "$GITHUB_OUTPUT"
     - name: Set up Python ${{ steps.set-python-version.outputs.python-version }}
-      uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
+      uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
       with:
         python-version: ${{ steps.set-python-version.outputs.python-version }}
         cache: ${{ inputs.cache }}

.github/workflows/codeql-analysis.yml

@@ -63,7 +63,7 @@ jobs:
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@8aad20d150bbac5944a9f9d289da16a4b0d87c1e # v4
+        uses: github/codeql-action/init@87557b9c84dde89fdd9b10e88954ac2f4248e463 # v4
         with:
           languages: ${{ matrix.language }}
           # If you wish to specify custom queries, you can do so here or in a config file.
@@ -74,6 +74,6 @@ jobs:
           # queries: security-extended,security-and-quality
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@8aad20d150bbac5944a9f9d289da16a4b0d87c1e # v4
+        uses: github/codeql-action/analyze@87557b9c84dde89fdd9b10e88954ac2f4248e463 # v4
         with:
           category: "/language:${{matrix.language}}"

.github/workflows/pre-commit.yml

@@ -48,7 +48,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
         with:
-          node-version-file: "superset-frontend/.nvmrc"
+          node-version: "20"
           cache: "npm"
           cache-dependency-path: "superset-frontend/package-lock.json"
 

.github/workflows/superset-extensions-cli.yml

@@ -56,7 +56,7 @@ jobs:
 
       - name: Upload coverage reports to Codecov
         if: steps.check.outputs.superset-extensions-cli
-        uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
+        uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6.0.1
         with:
           file: ./coverage.xml
           flags: superset-extensions-cli

.github/workflows/superset-frontend.yml

@@ -134,7 +134,7 @@ jobs:
         run: npx nyc merge coverage/ merged-output/coverage-summary.json
 
       - name: Upload Code Coverage
-        uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
+        uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6.0.1
         with:
           flags: javascript
           use_oidc: true

.github/workflows/superset-python-integrationtest.yml

@@ -85,7 +85,7 @@ jobs:
         run: |
           ./scripts/python_tests.sh
       - name: Upload code coverage
-        uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
+        uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6.0.1
         with:
           flags: python,mysql
           verbose: true
@@ -173,7 +173,7 @@ jobs:
         run: |
           ./scripts/python_tests.sh
       - name: Upload code coverage
-        uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
+        uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6.0.1
         with:
           flags: python,postgres
           verbose: true
@@ -222,7 +222,7 @@ jobs:
         run: |
           ./scripts/python_tests.sh
       - name: Upload code coverage
-        uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
+        uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6.0.1
         with:
           flags: python,sqlite
           verbose: true

.github/workflows/superset-python-presto-hive.yml

@@ -90,7 +90,7 @@ jobs:
         run: |
           ./scripts/python_tests.sh -m 'chart_data_flow or sql_json_flow'
       - name: Upload code coverage
-        uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
+        uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6.0.1
         with:
           flags: python,presto
           verbose: true
@@ -152,7 +152,7 @@ jobs:
           pip install -e .[hive]
           ./scripts/python_tests.sh -m 'chart_data_flow or sql_json_flow'
       - name: Upload code coverage
-        uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
+        uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6.0.1
         with:
           flags: python,hive
           verbose: true

.github/workflows/superset-python-unittest.yml

@@ -72,7 +72,7 @@ jobs:
           pytest --durations-min=0.5 --cov=superset/sql/ ./tests/unit_tests/sql/ --cache-clear --cov-fail-under=100
           pytest --durations-min=0.5 --cov=superset/semantic_layers/ ./tests/unit_tests/semantic_layers/ --cache-clear --cov-fail-under=100
       - name: Upload code coverage
-        uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
+        uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6.0.1
         with:
           flags: python,unit
           verbose: true

Dockerfile

@@ -29,7 +29,7 @@ ARG BUILD_TRANSLATIONS="false"
 ######################################################################
 # superset-node-ci used as a base for building frontend assets and CI
 ######################################################################
-FROM --platform=${BUILDPLATFORM} node:24-trixie-slim AS superset-node-ci
+FROM --platform=${BUILDPLATFORM} node:22-trixie-slim AS superset-node-ci
 ARG BUILD_TRANSLATIONS
 ENV BUILD_TRANSLATIONS=${BUILD_TRANSLATIONS}
 ARG DEV_MODE="false"           # Skip frontend build in dev mode

UPDATING.md

@@ -24,53 +24,6 @@ assists people when migrating to a new version.
 
 ## Next
 
-### Webhook alerts/reports block private/internal hosts by default
-
-Webhook alert/report dispatch (`WebhookNotification.send`) now validates the target URL's host against the same private/internal-IP block applied to dataset import URLs. If the resolved host is in a loopback, link-local, private (RFC-1918), shared-CGNAT, or multicast range, the webhook is rejected with `NotificationParamException`.
-
-Deployments that intentionally point webhooks at internal targets (chatops bridges, internal automation servers, on-premises Mattermost/Rocket.Chat, etc.) can opt out by setting `ALERT_REPORTS_WEBHOOK_ALLOW_INTERNAL_HOSTS = True` in `superset_config.py`. This mirrors the existing `DATASET_IMPORT_ALLOW_INTERNAL_DATA_URLS` opt-out for dataset imports.
-
-### Impala cancel_query blocks private/internal hosts by default
-
-The Impala engine spec's `cancel_query` issues an HTTP request from the Superset backend to the host configured on the Impala database connection. That host is now validated before the request: if it resolves to a private/internal IP range, the cancel call is refused and a warning is logged. Operators whose Impala cluster runs on an internal network can opt out by setting `IMPALA_CANCEL_QUERY_ALLOW_INTERNAL_HOSTS = True` in `superset_config.py`. This mirrors the dataset-import and webhook opt-out flags.
-### Map chart renderer and OpenStreetMap migration behavior
-
-The MapLibre migration for deck.gl charts preserves saved non-Mapbox styles on
-the MapLibre-compatible path. Saved styles such as OpenStreetMap, `tile://`
-tile templates, generic HTTPS style URLs, and charts without a saved style are
-not reclassified as Mapbox during migration and do not require
-`MAPBOX_API_KEY` only because of the migration.
-
-Saved true Mapbox styles whose value starts with `mapbox://` remain
-Mapbox-backed. If a Superset deployment does not configure `MAPBOX_API_KEY`,
-those saved Mapbox charts keep the existing missing-key message instead of
-silently falling back to MapLibre or another provider. In Explore, deck.gl and
-point-cluster renderer controls preserve saved Mapbox state, but the Mapbox
-choice is not available as a new working renderer without a configured key.
-
-The MapLibre style choices include `Streets (OSM)`, backed by
-`https://tile.openstreetmap.org/{z}/{x}/{y}.png`. This OpenStreetMap tile
-service requires visible `© OpenStreetMap contributors` attribution and should
-be used through normal browser map tile requests and caching; it is not intended
-for bulk prefetch or offline tile downloads.
-
-### Password complexity policy enabled by default
-
-Superset now ships a default password-complexity policy, enforced (via Flask-AppBuilder) across self-registration, the user create/edit/reset forms, and the User REST API. The policy requires a minimum password length of 8 characters and rejects a built-in blocklist of common/guessable passwords.
-
-This is enabled by default (`FAB_PASSWORD_COMPLEXITY_ENABLED = True`), so new or reset passwords that are too short or appear in the blocklist will be rejected where they were previously accepted. Existing stored passwords are unaffected until they are next changed.
-
-Operators can tune or disable the policy via config:
-
-- `AUTH_PASSWORD_MIN_LENGTH` — minimum length (default `8`).
-- `AUTH_PASSWORD_COMMON_BLOCKLIST` — extra passwords to reject, in addition to the built-in list.
-- `FAB_PASSWORD_COMPLEXITY_VALIDATOR` — replace with your own callable for custom rules.
-- `FAB_PASSWORD_COMPLEXITY_ENABLED = False` — disable enforcement entirely.
-
-### Data uploads bounded by UPLOAD_MAX_FILE_SIZE_BYTES
-
-Single data-file uploads (CSV, Excel, columnar) are now bounded by the `UPLOAD_MAX_FILE_SIZE_BYTES` config option, which defaults to `100 * 1024 * 1024` (100 MB). Files larger than this are rejected with a `413` before their contents are buffered into memory. Set `UPLOAD_MAX_FILE_SIZE_BYTES = None` to disable the check and restore unbounded uploads.
-
 ### Duration formatter precision
 
 The `DURATION` number formatter now uses `Intl.DurationFormat` for locale-aware output. By default, sub-second fields are omitted, so values that previously displayed fractional seconds with `pretty-ms`, such as `10500` milliseconds rendering as `10.5s`, now render as `10s`.
@@ -117,10 +70,6 @@ superset revoke-guest-tokens
 
 This change is backward compatible. The feature is off by default, and even when enabled nothing is revoked until an admin explicitly bumps the version: the expected version starts at `0`, and tokens minted before this change (which carry no version claim) are treated as version `0`. No database migration is required.
 
-### Sessions are terminated when an account is disabled
-
-Disabling a user account (setting `active` to `False`, via the admin UI, REST API, or CLI) now terminates that user's outstanding sessions on their next request, instead of relying on a passive check. This works for both client-side cookie sessions and server-side session stores via a per-user invalidation epoch (`user_attribute.sessions_invalidated_at`, added by a migration). The mechanism is inert for users that were never disabled (NULL epoch), so there is no behavior change for active users. Re-enabling an account and logging in again starts a fresh, valid session. The migration backfills the epoch for accounts that are already disabled at upgrade time, so re-enabling such an account does not revive a session that predates this feature.
-
 ### Dataset import validates catalog against the target connection
 
 Importing a dataset now validates the `catalog` field against the target database connection. When the connection has multi-catalog disabled (`allow_multi_catalog` off) and the dataset's catalog is not the connection's default catalog, the import fails instead of silently persisting the non-default catalog. This matches the validation already enforced on the dataset update path and prevents imported datasets from querying an unintended database.
@@ -140,36 +89,6 @@ Both default to empty (no behavior change). They apply to both the `LOCAL_EXTENS
 
 The Dynamic Group By chart customization now orders its display values according to the "Sort display control values" toggle: ascending (A–Z), descending (Z–A), or the dataset's source order when the toggle is unset. Previously the dropdown always sorted alphabetically. Existing dashboards where the toggle was never set will show options in source order instead of A–Z; open the customization and enable the toggle to restore alphabetical ordering.
 
-### Selectable encryption engine for app-encrypted fields (AES-GCM)
-
-App-encrypted fields (database passwords, SSH tunnel credentials, OAuth tokens, etc.) can now use authenticated **AES-GCM** encryption instead of the historical unauthenticated **AES-CBC**. A new config selects the engine for the default adapter:
-
-```python
-# "aes" (AES-CBC, historical default) | "aes-gcm" (authenticated, recommended for new installs)
-SQLALCHEMY_ENCRYPTED_FIELD_ENGINE = "aes"
-```
-
-**No action required / no behavior change:** the default remains `"aes"`, so existing installs are unaffected.
-
-**Opting in on an existing install:** flipping the engine on a populated database without re-encrypting first will make stored secrets undecryptable, because the two ciphertext formats are not compatible. A migrator is provided. Recommended runbook:
-
-1. Take a metadata-DB backup.
-2. Re-encrypt existing secrets into the new engine (the `SECRET_KEY` is unchanged):
-   ```bash
-   superset re-encrypt-secrets --engine aes-gcm
-   ```
-3. Set `SQLALCHEMY_ENCRYPTED_FIELD_ENGINE = "aes-gcm"` in your config.
-4. Restart Superset.
-5. Re-run the migrator once more after the restart:
-   ```bash
-   superset re-encrypt-secrets --engine aes-gcm
-   ```
-   A live instance keeps writing *new* secrets as AES-CBC during the window between step 2 and the restart in step 4; this second pass sweeps those up (it is idempotent, so already-migrated values are skipped).
-
-Schedule the cutover in a quiet window. Runtime reads use only the single configured engine, so in a multi-worker deployment there is an unavoidable brief decrypt-outage between the migration commit and the last worker restarting with the new config — each migrator run is transactional, but the fleet-wide cutover is not zero-downtime.
-
-The migration is transactional (all-or-nothing) and idempotent — it can be safely re-run or resumed. Note that AES-GCM, unlike AES-CBC, does not support querying directly over encrypted columns; audit any code that filters on an encrypted column before switching. See the SIP at `docs/sip/authenticated-encryption-at-rest.md` for details.
-
 ### Granular Export Controls
 
 A new feature flag `GRANULAR_EXPORT_CONTROLS` introduces three fine-grained permissions that replace the legacy `can_csv` permission:

docs/.nvmrc

@@ -1 +1 @@
-v24.16.0
+v22.22.0

docs/package.json

@@ -72,8 +72,8 @@
     "@superset-ui/core": "^0.20.4",
     "@swc/core": "^1.15.40",
     "antd": "^6.4.3",
-    "baseline-browser-mapping": "^2.10.34",
-    "caniuse-lite": "^1.0.30001797",
+    "baseline-browser-mapping": "^2.10.33",
+    "caniuse-lite": "^1.0.30001793",
     "docusaurus-plugin-openapi-docs": "^5.0.2",
     "docusaurus-theme-openapi-docs": "^5.0.2",
     "js-yaml": "^4.2.0",

docs/sip/authenticated-encryption-at-rest.md

@@ -1,136 +0,0 @@
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements.  See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership.  The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License.  You may obtain a copy of the License at
-
-  http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied.  See the License for the
-specific language governing permissions and limitations
-under the License.
--->
-
-# SIP: Authenticated encryption (AES-GCM) for app-encrypted fields
-
-## [DRAFT — proposal for discussion]
-
-This document is a draft proposal accompanying the code in this PR. It is
-intended to seed the formal SIP discussion. The code here ships the
-backward-compatible engine selection **and** the re-encryption migrator
-(Phases 1–2 below); both are opt-in and change nothing for existing installs by
-default. Flipping the default for fresh installs (Phase 3) remains future work.
-
-## Motivation
-
-Superset app-encrypts a number of sensitive fields before persisting them to
-the metadata database, including:
-
-- database connection passwords and `encrypted_extra` (`superset/models/core.py`),
-- SSH tunnel credentials — password, private key, private-key password
-  (`superset/databases/ssh_tunnel/models.py`),
-- OAuth2 tokens and other secrets stored via `EncryptedType`.
-
-These fields are encrypted with `sqlalchemy_utils.EncryptedType`, which
-**defaults to `AesEngine` (AES-CBC)**. AES-CBC provides confidentiality but is
-**unauthenticated**: it has no integrity tag. An attacker with write access to
-the ciphertext (e.g. direct metadata-DB access, a backup, or a compromised
-replica) can perform **bit-flipping / chosen-ciphertext manipulation** to
-silently alter the decrypted plaintext of a secret without detection.
-
-`AesGcmEngine` (AES-GCM) is authenticated encryption: tampering causes
-decryption to fail loudly rather than yielding attacker-influenced plaintext.
-Using authenticated encryption for secrets at rest is an ASVS L1 expectation
-(11.3.2 / cryptography best practice).
-
-`config.py` already documents that operators *can* switch to GCM by writing a
-custom `AbstractEncryptedFieldAdapter`, but:
-
-1. it is opt-in, undocumented as a security recommendation, and easy to miss;
-2. there is **no migration path** — flipping the engine on a populated database
-   makes every existing secret undecryptable, because GCM ciphertext is not
-   format-compatible with CBC.
-
-## Proposed change
-
-A three-part change, delivered incrementally so existing deployments are never
-broken:
-
-### Phase 1 — engine selection (this PR)
-
-- Add a `SQLALCHEMY_ENCRYPTED_FIELD_ENGINE` config (`"aes"` | `"aes-gcm"`),
-  **defaulting to `"aes"`** (no behavior change for existing installs).
-- Teach the default `SQLAlchemyUtilsAdapter` to honor it (an explicit `engine`
-  kwarg still wins, so the migrator can pin an engine).
-- This lets **new** deployments choose AES-GCM from day one with a one-line
-  config, instead of writing a custom adapter.
-
-### Phase 2 — CBC→GCM re-encryption migrator (this PR)
-
-The existing `SecretsMigrator` (previously only used for `SECRET_KEY` rotation)
-gains an **engine migration** mode that:
-
-1. discovers every `EncryptedType` column (via `discover_encrypted_fields()`),
-2. decrypts each value with the **source** engine (AES-CBC) under the current
-   `SECRET_KEY`,
-3. re-encrypts with the **target** engine (AES-GCM),
-4. runs transactionally per the existing all-or-nothing semantics, and is
-   idempotent per column (already-migrated values are skipped), so a run can be
-   safely repeated or resumed.
-
-Exposed via a new `--engine` option on the existing CLI command:
-`superset re-encrypt-secrets --engine aes-gcm`, runnable by operators with a DB
-backup in hand. The `SECRET_KEY` is unchanged; an engine change and a key
-rotation can also be combined (pass `--previous_secret_key` as well).
-
-### Phase 3 — flip the default for new installs
-
-Once the migrator and docs are in place, change the default to `"aes-gcm"` for
-**fresh** installs only (e.g. keyed off an empty metadata DB / documented in
-`UPDATING.md`), keeping existing installs on `"aes"` until they run Phase 2.
-
-## New or changed public interfaces
-
-- New config: `SQLALCHEMY_ENCRYPTED_FIELD_ENGINE: Literal["aes", "aes-gcm"]`.
-- New (Phase 2) CLI: `superset re-encrypt-secrets --engine <name>`.
-- No schema changes; ciphertext format changes per migrated column.
-
-## Migration plan and compatibility
-
-- **Backward compatible by default.** Phase 1 changes nothing unless the
-  operator opts in.
-- Switching an existing deployment to `"aes-gcm"` **without** running the Phase
-  2 migrator will make existing secrets undecryptable — this is called out in
-  the config comment and must be in `UPDATING.md`.
-- Recommended operator runbook: take a metadata-DB backup → run
-  `re-encrypt-secrets --engine aes-gcm` → set
-  `SQLALCHEMY_ENCRYPTED_FIELD_ENGINE = "aes-gcm"` → restart → re-run
-  `re-encrypt-secrets --engine aes-gcm` once more to sweep up any secrets a live
-  instance wrote as AES-CBC during the cutover window. The canonical, more
-  detailed version of this runbook lives in `UPDATING.md`; this is a summary.
-- `AesEngine` allows queryability over encrypted fields; AES-GCM does not.
-  Any code that filters/queries on an encrypted column directly must be audited
-  before Phase 3 (none is expected, but it must be verified).
-
-## Rejected alternatives
-
-- **Flip the default immediately.** Rejected: bricks every existing
-  deployment's secrets with no migration path.
-- **Document-only (custom adapter).** Status quo; high friction and no
-  migration tooling — most operators will never do it.
-
-## Open questions
-
-- GCM→CBC rollback (for operators who need queryability) already works via the
-  same command (`re-encrypt-secrets --engine aes`), since the migrator is
-  engine-symmetric. Should rollback be documented as a supported path or
-  discouraged?
-- The migrator already supports a concurrent `SECRET_KEY` rotation + engine
-  change in a single pass (pass `--previous_secret_key` alongside `--engine`).
-  Is that combination worth calling out in the operator docs, or kept advanced?

docs/yarn.lock

@@ -5578,10 +5578,10 @@ base64-js@^1.3.1, base64-js@^1.5.1:
   resolved "https://registry.npmjs.org/base64-js/-/base64-js-1.5.1.tgz"
   integrity sha512-AKpaYlHn8t4SVbOHCy+b5+KKgvR4vrsD8vbvrbiQJps7fKDTkjkDry6ji0rUJjC0kzbNePLwzxq8iypo41qeWA==
 
-baseline-browser-mapping@^2.10.34, baseline-browser-mapping@^2.9.0, baseline-browser-mapping@^2.9.19:
-  version "2.10.34"
-  resolved "https://registry.yarnpkg.com/baseline-browser-mapping/-/baseline-browser-mapping-2.10.34.tgz#dedb606362446777cfe328d30d4ee15056d06303"
-  integrity sha512-IMDedajPifLnHNY0X9n8hKxRTQ6/eTHwr5bDo04WnuqxyKw6LYtQywCuuqPZwhl3aBXMvQpJov42GLCwRRdQzw==
+baseline-browser-mapping@^2.10.33, baseline-browser-mapping@^2.9.0, baseline-browser-mapping@^2.9.19:
+  version "2.10.33"
+  resolved "https://registry.yarnpkg.com/baseline-browser-mapping/-/baseline-browser-mapping-2.10.33.tgz#27c299b096404978831958d429f48390424c4f9b"
+  integrity sha512-bA6+tcSLpz2tIEdDXZPpPTIuxBcC4+w6SieaYyfigIa4h8GlFxbA17v22Vx3JUtuZQj9SgOsnbK+aTBzyDyEuw==
 
 batch@0.6.1:
   version "0.6.1"
@@ -5824,10 +5824,10 @@ caniuse-api@^3.0.0:
     lodash.memoize "^4.1.2"
     lodash.uniq "^4.5.0"
 
-caniuse-lite@^1.0.0, caniuse-lite@^1.0.30001702, caniuse-lite@^1.0.30001759, caniuse-lite@^1.0.30001797:
-  version "1.0.30001797"
-  resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001797.tgz#1332709e1439f01ff92085dd17001e0a45897ec0"
-  integrity sha512-l8xKG+gwAIExZGl9FrF7KUwuOmk6wbEPC9Xoy/RtnWv1XG0Q4LFlagaLpUv3Kiza3W/wm27zy0yWJEieYKAP6w==
+caniuse-lite@^1.0.0, caniuse-lite@^1.0.30001702, caniuse-lite@^1.0.30001759, caniuse-lite@^1.0.30001793:
+  version "1.0.30001793"
+  resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001793.tgz#238887ddf5fcfc8c36d872394d0a78a517312a72"
+  integrity sha512-iwSsYWaCOoh26cV8NwNRViHlrfUvYsHDfRVcbtmw0Kg6PJIZZXwMkj1442FYLBGkeUf1juAsU3DTfxW579mrPA==
 
 ccount@^2.0.0:
   version "2.0.1"
@@ -9300,9 +9300,9 @@ jiti@^1.20.0:
   integrity sha512-/imKNG4EbWNrVjoNC/1H5/9GFy+tqjGBHCaSsN+P2RnPqjsLmv6UD3Ej+Kj8nBWaRAwyk7kK5ZUc+OEatnTR3A==
 
 joi@^17.9.2:
-  version "17.13.4"
-  resolved "https://registry.yarnpkg.com/joi/-/joi-17.13.4.tgz#ad6153d97ce558eb3a3b593e0d43eab51df1c474"
-  integrity sha512-1RuuER6kmt8K8I3nIWvPZKi5RQCb568ZPyY4Pwjlua+yo+63ZTmIwxLZH0heBmiKN4uxjvCiarDrjaeH84xicQ==
+  version "17.13.3"
+  resolved "https://registry.npmjs.org/joi/-/joi-17.13.3.tgz"
+  integrity sha512-otDA4ldcIx+ZXsKHWmp0YizCweVRZG96J10b0FevjfuncLO1oX59THoAmHkNubYJ+9gWsYsp5k8v4ib6oDv1fA==
   dependencies:
     "@hapi/hoek" "^9.3.0"
     "@hapi/topo" "^5.1.0"

helm/superset/Chart.yaml

@@ -29,7 +29,7 @@ maintainers:
   - name: craig-rueda
     email: craig@craigrueda.com
     url: https://github.com/craig-rueda
-version: 0.16.0 # See [README](https://github.com/apache/superset/blob/master/helm/superset/README.md#versioning) for version details.
+version: 0.17.0 # See [README](https://github.com/apache/superset/blob/master/helm/superset/README.md#versioning) for version details.
 dependencies:
   - name: postgresql
     version: 16.7.27

helm/superset/README.md

@@ -23,7 +23,7 @@ NOTE: This file is generated by helm-docs: https://github.com/norwoodj/helm-docs
 
 # superset
 
-![Version: 0.16.0](https://img.shields.io/badge/Version-0.16.0-informational?style=flat-square)
+![Version: 0.17.0](https://img.shields.io/badge/Version-0.17.0-informational?style=flat-square)
 
 Apache Superset is a modern, enterprise-ready business intelligence web application
 
@@ -111,9 +111,6 @@ On helm this can be set on `extraSecretEnv.SUPERSET_SECRET_KEY` or `configOverri
 | init.resources | object | `{}` |  |
 | init.tolerations | list | `[]` |  |
 | init.topologySpreadConstraints | list | `[]` | TopologySpreadConstrains to be added to init job |
-| initImage.pullPolicy | string | `"IfNotPresent"` |  |
-| initImage.repository | string | `"apache/superset"` |  |
-| initImage.tag | string | `"dockerize"` |  |
 | nameOverride | string | `nil` | Provide a name to override the name of the chart |
 | nodeSelector | object | `{}` |  |
 | postgresql | object | see `values.yaml` | Configuration values for the postgresql dependency. ref: https://github.com/bitnami/charts/tree/main/bitnami/postgresql |

helm/superset/values.yaml

@@ -194,11 +194,6 @@ image:
 
 imagePullSecrets: []
 
-initImage:
-  repository: apache/superset
-  tag: dockerize
-  pullPolicy: IfNotPresent
-
 service:
   type: ClusterIP
   port: 8088
@@ -303,15 +298,28 @@ supersetNode:
   # @default -- a container waiting for postgres
   initContainers:
     - name: wait-for-postgres
-      image: "{{ .Values.initImage.repository }}:{{ .Values.initImage.tag }}"
-      imagePullPolicy: "{{ .Values.initImage.pullPolicy }}"
+      image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
+      imagePullPolicy: "{{ .Values.image.pullPolicy }}"
       envFrom:
         - secretRef:
             name: "{{ tpl .Values.envFromSecret . }}"
       command:
-        - /bin/sh
+        - /bin/bash
         - -c
-        - dockerize -wait "tcp://$DB_HOST:$DB_PORT" -timeout 120s
+        - |
+          # bash's /dev/tcp redirect performs a TCP connect; no external
+          # `dockerize`, `nc`, or busybox needed. SECONDS-based deadline
+          # mirrors the prior `dockerize -timeout 120s` behaviour.
+          SECONDS=0
+          until (echo > /dev/tcp/"$DB_HOST"/"$DB_PORT") 2>/dev/null; do
+            if [ "$SECONDS" -ge 120 ]; then
+              echo "timeout waiting for postgres at $DB_HOST:$DB_PORT after 120s" >&2
+              exit 1
+            fi
+            echo "waiting for postgres at $DB_HOST:$DB_PORT (elapsed ${SECONDS}s)"
+            sleep 2
+          done
+          echo "postgres at $DB_HOST:$DB_PORT is up"
       resources:
         limits:
           memory: "256Mi"
@@ -407,15 +415,31 @@ supersetWorker:
   # @default -- a container waiting for postgres and redis
   initContainers:
     - name: wait-for-postgres-redis
-      image: "{{ .Values.initImage.repository }}:{{ .Values.initImage.tag }}"
-      imagePullPolicy: "{{ .Values.initImage.pullPolicy }}"
+      image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
+      imagePullPolicy: "{{ .Values.image.pullPolicy }}"
       envFrom:
         - secretRef:
             name: "{{ tpl .Values.envFromSecret . }}"
       command:
-        - /bin/sh
+        - /bin/bash
         - -c
-        - dockerize -wait "tcp://$DB_HOST:$DB_PORT" -wait "tcp://$REDIS_HOST:$REDIS_PORT" -timeout 120s
+        - |
+          # See supersetNode.initContainers for the rationale.
+          SECONDS=0
+          wait_for() {
+            local host=$1 port=$2 name=$3
+            until (echo > /dev/tcp/"$host"/"$port") 2>/dev/null; do
+              if [ "$SECONDS" -ge 120 ]; then
+                echo "timeout waiting for $name at $host:$port after 120s" >&2
+                exit 1
+              fi
+              echo "waiting for $name at $host:$port (elapsed ${SECONDS}s)"
+              sleep 2
+            done
+            echo "$name at $host:$port is up"
+          }
+          wait_for "$DB_HOST" "$DB_PORT" postgres
+          wait_for "$REDIS_HOST" "$REDIS_PORT" redis
       resources:
         limits:
           memory: "256Mi"
@@ -495,15 +519,31 @@ supersetCeleryBeat:
   # @default -- a container waiting for postgres
   initContainers:
     - name: wait-for-postgres-redis
-      image: "{{ .Values.initImage.repository }}:{{ .Values.initImage.tag }}"
-      imagePullPolicy: "{{ .Values.initImage.pullPolicy }}"
+      image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
+      imagePullPolicy: "{{ .Values.image.pullPolicy }}"
       envFrom:
         - secretRef:
             name: "{{ tpl .Values.envFromSecret . }}"
       command:
-        - /bin/sh
+        - /bin/bash
         - -c
-        - dockerize -wait "tcp://$DB_HOST:$DB_PORT" -wait "tcp://$REDIS_HOST:$REDIS_PORT" -timeout 120s
+        - |
+          # See supersetNode.initContainers for the rationale.
+          SECONDS=0
+          wait_for() {
+            local host=$1 port=$2 name=$3
+            until (echo > /dev/tcp/"$host"/"$port") 2>/dev/null; do
+              if [ "$SECONDS" -ge 120 ]; then
+                echo "timeout waiting for $name at $host:$port after 120s" >&2
+                exit 1
+              fi
+              echo "waiting for $name at $host:$port (elapsed ${SECONDS}s)"
+              sleep 2
+            done
+            echo "$name at $host:$port is up"
+          }
+          wait_for "$DB_HOST" "$DB_PORT" postgres
+          wait_for "$REDIS_HOST" "$REDIS_PORT" redis
       resources:
         limits:
           memory: "256Mi"
@@ -594,15 +634,31 @@ supersetCeleryFlower:
   # @default -- a container waiting for postgres and redis
   initContainers:
     - name: wait-for-postgres-redis
-      image: "{{ .Values.initImage.repository }}:{{ .Values.initImage.tag }}"
-      imagePullPolicy: "{{ .Values.initImage.pullPolicy }}"
+      image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
+      imagePullPolicy: "{{ .Values.image.pullPolicy }}"
       envFrom:
         - secretRef:
             name: "{{ tpl .Values.envFromSecret . }}"
       command:
-        - /bin/sh
+        - /bin/bash
         - -c
-        - dockerize -wait "tcp://$DB_HOST:$DB_PORT" -wait "tcp://$REDIS_HOST:$REDIS_PORT" -timeout 120s
+        - |
+          # See supersetNode.initContainers for the rationale.
+          SECONDS=0
+          wait_for() {
+            local host=$1 port=$2 name=$3
+            until (echo > /dev/tcp/"$host"/"$port") 2>/dev/null; do
+              if [ "$SECONDS" -ge 120 ]; then
+                echo "timeout waiting for $name at $host:$port after 120s" >&2
+                exit 1
+              fi
+              echo "waiting for $name at $host:$port (elapsed ${SECONDS}s)"
+              sleep 2
+            done
+            echo "$name at $host:$port is up"
+          }
+          wait_for "$DB_HOST" "$DB_PORT" postgres
+          wait_for "$REDIS_HOST" "$REDIS_PORT" redis
       resources:
         limits:
           memory: "256Mi"
@@ -764,15 +820,26 @@ init:
   # @default -- a container waiting for postgres
   initContainers:
     - name: wait-for-postgres
-      image: "{{ .Values.initImage.repository }}:{{ .Values.initImage.tag }}"
-      imagePullPolicy: "{{ .Values.initImage.pullPolicy }}"
+      image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
+      imagePullPolicy: "{{ .Values.image.pullPolicy }}"
       envFrom:
         - secretRef:
             name: "{{ tpl .Values.envFromSecret . }}"
       command:
-        - /bin/sh
+        - /bin/bash
         - -c
-        - dockerize -wait "tcp://$DB_HOST:$DB_PORT" -timeout 120s
+        - |
+          # See supersetNode.initContainers for the rationale.
+          SECONDS=0
+          until (echo > /dev/tcp/"$DB_HOST"/"$DB_PORT") 2>/dev/null; do
+            if [ "$SECONDS" -ge 120 ]; then
+              echo "timeout waiting for postgres at $DB_HOST:$DB_PORT after 120s" >&2
+              exit 1
+            fi
+            echo "waiting for postgres at $DB_HOST:$DB_PORT (elapsed ${SECONDS}s)"
+            sleep 2
+          done
+          echo "postgres at $DB_HOST:$DB_PORT is up"
       resources:
         limits:
           memory: "256Mi"

pyproject.toml

@@ -55,7 +55,7 @@ dependencies = [
     "flask-login>=0.6.0, < 1.0",
     "flask-migrate>=3.1.0, <5.0",
     "flask-session>=0.4.0, <1.0",
-    "flask-wtf>=1.3.0, <2.0",
+    "flask-wtf>=1.1.0, <2.0",
     "geopy",
     "greenlet>=3.0.3, <=3.5.0",
     "gunicorn>=25.3.0, <26; sys_platform != 'win32'",
@@ -80,7 +80,7 @@ dependencies = [
     "bottleneck", # recommended performance dependency for pandas, see https://pandas.pydata.org/docs/getting_started/install.html#performance-dependencies-recommended
     # --------------------------
     "parsedatetime",
-    "paramiko>=3.4.0, <4.0", # 4.0 removed DSSKey, still referenced by sshtunnel
+    "paramiko>=3.4.0",
     "pgsanity",
     "Pillow>=11.0.0, <13",
     "polyline>=2.0.0, <3.0",
@@ -118,7 +118,7 @@ athena = ["pyathena[pandas]>=2, <4"]
 aurora-data-api = ["preset-sqlalchemy-aurora-data-api>=0.2.8,<0.3"]
 bigquery = [
     "pandas-gbq>=0.19.1",
-    "sqlalchemy-bigquery>=1.17.0",
+    "sqlalchemy-bigquery>=1.15.0",
     "google-cloud-bigquery>=3.10.0",
 ]
 clickhouse = ["clickhouse-connect>=1.1.1, <2.0"]
@@ -143,14 +143,14 @@ duckdb = ["duckdb>=1.5.2,<2", "duckdb-engine>=0.17.0"]
 dynamodb = ["pydynamodb>=0.4.2"]
 solr = ["sqlalchemy-solr >= 0.2.0"]
 elasticsearch = ["elasticsearch-dbapi>=0.2.13, <0.3.0"]
-exasol = ["sqlalchemy-exasol>=2.4.0, <8.0"]
+exasol = ["sqlalchemy-exasol >= 2.4.0, < 8.0"]
 excel = ["xlrd>=1.2.0, <1.3"]
 fastmcp = [
     "fastmcp>=3.2.4,<4.0",
     # tiktoken backs the response-size-guard token estimator. Without
     # it, the middleware falls back to a coarser character-based
     # heuristic that under-counts JSON-heavy MCP responses.
-    "tiktoken>=0.13.0,<1.0",
+    "tiktoken>=0.7.0,<1.0",
 ]
 firebird = ["sqlalchemy-firebird>=0.7.0, <2.2"]
 firebolt = ["firebolt-sqlalchemy>=1.0.0, <2"]
@@ -167,7 +167,7 @@ hive = [
 impala = ["impyla>0.16.2, <0.23"]
 kusto = ["sqlalchemy-kusto>=3.1.2, <4"]
 kylin = ["kylinpy>=2.8.1, <2.9"]
-mssql = ["pymssql>=2.3.13, <3"]
+mssql = ["pymssql>=2.2.8, <3"]
 # motherduck is an alias for duckdb - MotherDuck works via the duckdb driver
 motherduck = ["apache-superset[duckdb]"]
 mysql = ["mysqlclient>=2.1.0, <3"]
@@ -205,7 +205,7 @@ teradata = ["teradatasql>=16.20.0.23"]
 thumbnails = [] # deprecated, will be removed in 7.0
 vertica = ["sqlalchemy-vertica-python>= 0.6.3, < 0.7"]
 netezza = ["nzalchemy>=11.0.2"]
-starrocks = ["starrocks>=1.3.3, <2"]
+starrocks = ["starrocks>=1.0.0"]
 doris = ["pydoris>=1.0.0, <2.0.0"]
 oceanbase = ["oceanbase_py>=0.0.1.2"]
 ydb = ["ydb-sqlalchemy>=0.1.2", "ydb-sqlglot-plugin>=0.2.5"]
@@ -222,7 +222,7 @@ development = [
     "pip",
     "polib",  # used by scripts/translations/ and their unit tests
     "pre-commit",
-    "progress>=1.6.1,<2",
+    "progress>=1.5,<2",
     "psutil",
     "pyfakefs",
     "pyinstrument>=5.1.2,<6",

requirements/base.txt

@@ -151,7 +151,7 @@ flask-sqlalchemy==2.5.1
     #   flask-migrate
 flask-talisman==1.1.0
     # via apache-superset (pyproject.toml)
-flask-wtf==1.3.0
+flask-wtf==1.2.2
     # via
     #   apache-superset (pyproject.toml)
     #   flask-appbuilder

requirements/development.txt

@@ -312,7 +312,7 @@ flask-talisman==1.1.0
     #   apache-superset
 flask-testing==0.8.1
     # via apache-superset
-flask-wtf==1.3.0
+flask-wtf==1.2.2
     # via
     #   -c requirements/base-constraint.txt
     #   apache-superset
@@ -686,7 +686,7 @@ prison==0.2.1
     # via
     #   -c requirements/base-constraint.txt
     #   flask-appbuilder
-progress==1.6.1
+progress==1.6
     # via apache-superset
 prompt-toolkit==3.0.51
     # via
@@ -976,7 +976,7 @@ sqlalchemy==1.4.54
     #   shillelagh
     #   sqlalchemy-bigquery
     #   sqlalchemy-utils
-sqlalchemy-bigquery==1.17.0
+sqlalchemy-bigquery==1.15.0
     # via apache-superset
 sqlalchemy-utils==0.42.0
     # via
@@ -1007,7 +1007,7 @@ tabulate==0.10.0
     # via
     #   -c requirements/base-constraint.txt
     #   apache-superset
-tiktoken==0.13.0
+tiktoken==0.12.0
     # via apache-superset
 tomli-w==1.2.0
     # via apache-superset-extensions-cli

superset-embedded-sdk/.nvmrc

@@ -1 +1 @@
-v24.16.0
+v22.22.0

superset-frontend/.eslintignore

@@ -0,0 +1,34 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+**/*{.,-}min.js
+**/*.sh
+coverage/**
+dist/*
+src/assets/images/*
+node_modules/*
+node_modules*/*
+vendor/*
+docs/*
+src/dashboard/deprecated/*
+src/temp/*
+**/node_modules
+*.d.ts
+coverage/
+esm/
+lib/
+tmp/
+storybook-static/

superset-frontend/.eslintrc.js

@@ -0,0 +1,523 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+// Register TypeScript require hook so ESLint can load .ts plugin files
+require('tsx/cjs');
+
+const packageConfig = require('./package.json');
+
+const importCoreModules = [];
+Object.entries(packageConfig.dependencies).forEach(([pkg]) => {
+  if (/@superset-ui/.test(pkg)) {
+    importCoreModules.push(pkg);
+  }
+});
+
+// ignore files in production mode
+let ignorePatterns = [];
+if (process.env.NODE_ENV === 'production') {
+  ignorePatterns = [
+    '*.test.{js,ts,jsx,tsx}',
+    'plugins/**/test/**/*',
+    'packages/**/test/**/*',
+    'packages/generator-superset/**/*',
+  ];
+}
+
+const restrictedImportsRules = {
+  'no-design-icons': {
+    name: '@ant-design/icons',
+    message:
+      'Avoid importing icons directly from @ant-design/icons. Use the src/components/Icons component instead.',
+  },
+  'no-moment': {
+    name: 'moment',
+    message:
+      'Please use the dayjs library instead of moment.js. See https://day.js.org',
+  },
+  'no-lodash-memoize': {
+    name: 'lodash/memoize',
+    message: 'Lodash Memoize is unsafe! Please use memoize-one instead',
+  },
+  'no-testing-library-react': {
+    name: '@superset-ui/core/spec',
+    message: 'Please use spec/helpers/testing-library instead',
+  },
+  'no-testing-library-react-dom-utils': {
+    name: '@testing-library/react-dom-utils',
+    message: 'Please use spec/helpers/testing-library instead',
+  },
+  'no-antd': {
+    name: 'antd',
+    message: 'Please import Ant components from the index of src/components',
+  },
+  'no-superset-theme': {
+    name: '@superset-ui/core',
+    importNames: ['supersetTheme'],
+    message:
+      'Please use the theme directly from the ThemeProvider rather than importing supersetTheme.',
+  },
+  'no-query-string': {
+    name: 'query-string',
+    message: 'Please use the URLSearchParams API instead of query-string.',
+  },
+  'no-jest-mock-console': {
+    name: 'jest-mock-console',
+    message: 'Please use native Jest spies, i.e. jest.spyOn(console, "warn")',
+  },
+};
+
+module.exports = {
+  extends: [
+    'eslint:recommended',
+    'plugin:import/recommended',
+    'plugin:react-prefer-function-component/recommended',
+    'plugin:storybook/recommended',
+    'prettier',
+  ],
+  parser: '@babel/eslint-parser',
+  parserOptions: {
+    ecmaVersion: 2020,
+    sourceType: 'module',
+    ecmaFeatures: {
+      jsx: true,
+    },
+    requireConfigFile: false,
+    babelOptions: {
+      presets: ['@babel/preset-react', '@babel/preset-env'],
+    },
+  },
+  env: {
+    browser: true,
+    node: true,
+    es2020: true,
+  },
+  settings: {
+    'import/resolver': {
+      node: {
+        extensions: ['.js', '.jsx', '.ts', '.tsx', '.json'],
+        moduleDirectory: ['node_modules', '.'],
+      },
+      typescript: {
+        alwaysTryTypes: true,
+        project: [
+          './tsconfig.json',
+          './packages/superset-ui-core/tsconfig.json',
+          './packages/superset-ui-chart-controls/',
+          './plugins/*/tsconfig.json',
+        ],
+      },
+    },
+    'import/core-modules': importCoreModules,
+    react: {
+      version: 'detect',
+    },
+  },
+  plugins: [
+    'import',
+    'lodash',
+    'theme-colors',
+    'icons',
+    'i18n-strings',
+    'react-prefer-function-component',
+    'react-you-might-not-need-an-effect',
+    'prettier',
+  ],
+  rules: {
+    // === Essential Superset customizations ===
+
+    // Prettier integration
+    'prettier/prettier': 'error',
+
+    // Custom Superset rules
+    'theme-colors/no-literal-colors': 'error',
+    'icons/no-fa-icons-usage': 'error',
+    'i18n-strings/no-template-vars': 'error',
+
+    // Core ESLint overrides for Superset
+    'no-console': 'warn',
+    'no-unused-vars': 'off', // TypeScript handles this
+    camelcase: [
+      'error',
+      {
+        allow: ['^UNSAFE_', '__REDUX_DEVTOOLS_EXTENSION_COMPOSE__'],
+        properties: 'never',
+      },
+    ],
+    'prefer-destructuring': ['error', { object: true, array: false }],
+    'no-prototype-builtins': 0,
+    curly: 'off',
+
+    // Import plugin overrides
+    'import/extensions': [
+      'error',
+      'ignorePackages',
+      {
+        js: 'never',
+        jsx: 'never',
+        ts: 'never',
+        tsx: 'never',
+      },
+    ],
+    'import/no-cycle': 0,
+    'import/prefer-default-export': 0,
+    'import/no-named-as-default-member': 0,
+    'import/no-extraneous-dependencies': [
+      'error',
+      {
+        devDependencies: [
+          'test/**',
+          'tests/**',
+          'spec/**',
+          '**/__tests__/**',
+          '**/__mocks__/**',
+          '*.test.{js,jsx,ts,tsx}',
+          '*.spec.{js,jsx,ts,tsx}',
+          '**/*.test.{js,jsx,ts,tsx}',
+          '**/*.spec.{js,jsx,ts,tsx}',
+          '**/jest.config.js',
+          '**/jest.setup.js',
+          '**/webpack.config.js',
+          '**/webpack.config.*.js',
+          '**/.eslintrc*.js',
+        ],
+        optionalDependencies: false,
+      },
+    ],
+
+    // React plugin overrides
+    'react-prefer-function-component/react-prefer-function-component': 1,
+
+    // React effect best practices
+    'react-you-might-not-need-an-effect/no-empty-effect': 'error',
+    'react-you-might-not-need-an-effect/no-pass-live-state-to-parent': 'error',
+    'react-you-might-not-need-an-effect/no-initialize-state': 'error',
+
+    // Lodash
+    'lodash/import-scope': [2, 'member'],
+
+    // React effect best practices
+    'react-you-might-not-need-an-effect/no-reset-all-state-on-prop-change':
+      'error',
+    'react-you-might-not-need-an-effect/no-chain-state-updates': 'error',
+    'react-you-might-not-need-an-effect/no-event-handler': 'error',
+    'react-you-might-not-need-an-effect/no-derived-state': 'error',
+
+    // Storybook
+    'storybook/prefer-pascal-case': 'error',
+
+    // File progress
+    'file-progress/activate': 1,
+
+    // React effect rules
+    'react-you-might-not-need-an-effect/no-adjust-state-on-prop-change':
+      'error',
+    'react-you-might-not-need-an-effect/no-pass-data-to-parent': 'error',
+
+    // Restricted imports
+    'no-restricted-imports': [
+      'error',
+      {
+        paths: Object.values(restrictedImportsRules).filter(Boolean),
+        patterns: ['antd/*'],
+      },
+    ],
+
+    // Temporarily disabled for migration
+    'no-unsafe-optional-chaining': 0,
+    'no-import-assign': 0,
+    'import/no-relative-packages': 0,
+    'no-promise-executor-return': 0,
+    'import/no-import-module-exports': 0,
+
+    // Restrict certain syntax patterns
+    'no-restricted-syntax': [
+      'error',
+      {
+        selector:
+          "ImportDeclaration[source.value='react'] :matches(ImportDefaultSpecifier, ImportNamespaceSpecifier)",
+        message:
+          'Default React import is not required due to automatic JSX runtime in React 16.4',
+      },
+      {
+        selector: 'ImportNamespaceSpecifier[parent.source.value!=/^(\\.|src)/]',
+        message: 'Wildcard imports are not allowed',
+      },
+    ],
+  },
+  overrides: [
+    // Ban JavaScript files in src/ - all new code must be TypeScript
+    {
+      files: ['src/**/*.js', 'src/**/*.jsx'],
+      rules: {
+        'no-restricted-syntax': [
+          'error',
+          {
+            selector: 'Program',
+            message:
+              'JavaScript files are not allowed in src/. Please use TypeScript (.ts/.tsx) instead.',
+          },
+        ],
+      },
+    },
+    // Ban JavaScript files in plugins/ - all plugin source code must be TypeScript
+    {
+      files: ['plugins/**/src/**/*.js', 'plugins/**/src/**/*.jsx'],
+      rules: {
+        'no-restricted-syntax': [
+          'error',
+          {
+            selector: 'Program',
+            message:
+              'JavaScript files are not allowed in plugins/. Please use TypeScript (.ts/.tsx) instead.',
+          },
+        ],
+      },
+    },
+    // Ban JavaScript files in packages/ - with exceptions for config files and generators
+    {
+      files: ['packages/**/src/**/*.js', 'packages/**/src/**/*.jsx'],
+      excludedFiles: [
+        'packages/generator-superset/**/*', // Yeoman generator templates run via Node
+        'packages/**/__mocks__/**/*', // Test mocks
+      ],
+      rules: {
+        'no-restricted-syntax': [
+          'error',
+          {
+            selector: 'Program',
+            message:
+              'JavaScript files are not allowed in packages/. Please use TypeScript (.ts/.tsx) instead.',
+          },
+        ],
+      },
+    },
+    {
+      files: ['*.ts', '*.tsx'],
+      parser: '@typescript-eslint/parser',
+      parserOptions: {
+        ecmaFeatures: {
+          jsx: true,
+        },
+        tsconfigRootDir: __dirname,
+        project: ['./tsconfig.json'],
+      },
+      extends: ['plugin:@typescript-eslint/recommended', 'prettier'],
+      plugins: ['@typescript-eslint/eslint-plugin'],
+      rules: {
+        // TypeScript-specific rule overrides
+        '@typescript-eslint/ban-ts-ignore': 0,
+        '@typescript-eslint/ban-ts-comment': 0,
+        '@typescript-eslint/ban-types': 0,
+        '@typescript-eslint/naming-convention': [
+          'error',
+          {
+            selector: 'enum',
+            format: ['PascalCase'],
+          },
+          {
+            selector: 'enumMember',
+            format: ['PascalCase'],
+          },
+        ],
+        '@typescript-eslint/no-empty-function': 0,
+        '@typescript-eslint/no-explicit-any': 0,
+        '@typescript-eslint/no-use-before-define': 'error',
+        '@typescript-eslint/no-non-null-assertion': 0,
+        '@typescript-eslint/explicit-function-return-type': 0,
+        '@typescript-eslint/explicit-module-boundary-types': 0,
+        '@typescript-eslint/no-unused-vars': 'warn',
+        '@typescript-eslint/prefer-optional-chain': 'error',
+
+        // Disable base rules that conflict with TS versions
+        'no-unused-vars': 'off',
+        'no-use-before-define': 'off',
+        'no-shadow': 'off',
+
+        // Import overrides for TypeScript
+        'import/extensions': [
+          'error',
+          'ignorePackages',
+          {
+            js: 'never',
+            jsx: 'never',
+            ts: 'never',
+            tsx: 'never',
+          },
+        ],
+      },
+      settings: {
+        'import/resolver': {
+          typescript: {},
+        },
+      },
+    },
+    {
+      files: ['packages/**'],
+      rules: {
+        'import/no-extraneous-dependencies': [
+          'error',
+          { devDependencies: true },
+        ],
+        'no-restricted-imports': [
+          'error',
+          {
+            paths: [
+              restrictedImportsRules['no-moment'],
+              restrictedImportsRules['no-lodash-memoize'],
+              restrictedImportsRules['no-superset-theme'],
+            ],
+            patterns: [],
+          },
+        ],
+      },
+    },
+    {
+      files: ['plugins/**'],
+      rules: {
+        'no-restricted-imports': [
+          'error',
+          {
+            paths: [
+              restrictedImportsRules['no-moment'],
+              restrictedImportsRules['no-lodash-memoize'],
+            ],
+            patterns: [],
+          },
+        ],
+      },
+    },
+    {
+      files: ['src/components/**', 'src/theme/**'],
+      rules: {
+        'no-restricted-imports': [
+          'error',
+          {
+            paths: Object.values(restrictedImportsRules).filter(
+              r => r.name !== 'antd',
+            ),
+            patterns: [],
+          },
+        ],
+      },
+    },
+    {
+      files: [
+        '*.test.ts',
+        '*.test.tsx',
+        '*.test.js',
+        '*.test.jsx',
+        '*.stories.tsx',
+        '*.stories.jsx',
+        'fixtures.*',
+        '**/test/**/*',
+        '**/tests/**/*',
+        'spec/**/*',
+        '**/fixtures/**/*',
+        '**/__mocks__/**/*',
+        '**/spec/**/*',
+      ],
+      excludedFiles: 'cypress-base/cypress/**/*',
+      plugins: ['jest-dom', 'no-only-tests', 'testing-library'],
+      extends: ['plugin:jest-dom/recommended', 'plugin:testing-library/react'],
+      rules: {
+        'import/no-extraneous-dependencies': [
+          'error',
+          { devDependencies: true },
+        ],
+        'prefer-promise-reject-errors': 0,
+        'max-classes-per-file': 0,
+
+        // Temporary for migration
+        'testing-library/await-async-queries': 0,
+        'testing-library/await-async-utils': 0,
+        'testing-library/no-await-sync-events': 0,
+        'testing-library/no-render-in-lifecycle': 0,
+        'testing-library/no-unnecessary-act': 0,
+        'testing-library/no-wait-for-multiple-assertions': 0,
+        'testing-library/prefer-screen-queries': 0,
+        'testing-library/await-async-events': 0,
+        'testing-library/no-node-access': 0,
+        'testing-library/no-wait-for-side-effects': 0,
+        'testing-library/prefer-presence-queries': 0,
+        'testing-library/render-result-naming-convention': 0,
+        'testing-library/no-container': 0,
+        'testing-library/prefer-find-by': 0,
+        'testing-library/no-manual-cleanup': 0,
+
+        'no-restricted-syntax': [
+          'error',
+          {
+            selector:
+              "ImportDeclaration[source.value='react'] :matches(ImportDefaultSpecifier, ImportNamespaceSpecifier)",
+            message:
+              'Default React import is not required due to automatic JSX runtime in React 16.4',
+          },
+        ],
+        'no-restricted-imports': 0,
+      },
+    },
+    {
+      files: [
+        '*.test.ts',
+        '*.test.tsx',
+        '*.test.js',
+        '*.test.jsx',
+        '*.stories.tsx',
+        '*.stories.jsx',
+        'fixtures.*',
+        '**/test/**/*',
+        '**/tests/**/*',
+        'spec/**/*',
+        '**/fixtures/**/*',
+        '**/__mocks__/**/*',
+        '**/spec/**/*',
+        'cypress-base/cypress/**/*',
+        'Stories.tsx',
+        'packages/superset-ui-core/src/theme/index.tsx',
+      ],
+      rules: {
+        'theme-colors/no-literal-colors': 0,
+        'icons/no-fa-icons-usage': 0,
+        'i18n-strings/no-template-vars': 0,
+        'no-restricted-imports': 0,
+      },
+    },
+    {
+      files: [
+        'packages/**/*.stories.*',
+        'packages/**/*.overview.*',
+        'packages/**/fixtures.*',
+      ],
+      rules: {
+        'import/no-extraneous-dependencies': 'off',
+      },
+    },
+    {
+      files: ['playwright/**/*.ts', 'playwright/**/*.js'],
+      rules: {
+        'import/no-extraneous-dependencies': [
+          'error',
+          { devDependencies: true },
+        ],
+      },
+    },
+  ],
+  ignorePatterns,
+};

superset-frontend/.eslintrc.minimal.js

@@ -0,0 +1,124 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+// Register TypeScript require hook so ESLint can load .ts plugin files
+require('tsx/cjs');
+
+/**
+ * MINIMAL ESLint config - ONLY for rules OXC doesn't support
+ * This config is designed to be run alongside OXC linter
+ *
+ * Only covers:
+ * - Custom Superset plugins (theme-colors, icons, i18n)
+ * - Prettier formatting
+ * - File progress indicator
+ */
+
+module.exports = {
+  root: true,
+  // Don't report on eslint-disable comments for rules we don't have
+  reportUnusedDisableDirectives: false,
+  // Simple parser - no TypeScript needed since OXC handles that
+  parser: '@babel/eslint-parser',
+  parserOptions: {
+    ecmaVersion: 2020,
+    sourceType: 'module',
+    ecmaFeatures: {
+      jsx: true,
+    },
+    requireConfigFile: false,
+    babelOptions: {
+      presets: ['@babel/preset-react', '@babel/preset-env'],
+    },
+  },
+  env: {
+    browser: true,
+    node: true,
+    es2020: true,
+  },
+  plugins: [
+    // ONLY custom Superset plugins that OXC doesn't support
+    'theme-colors',
+    'icons',
+    'i18n-strings',
+    'file-progress',
+    'prettier',
+  ],
+  rules: {
+    // === ONLY rules that OXC cannot handle ===
+
+    // Prettier integration (formatting)
+    'prettier/prettier': 'error',
+
+    // Custom Superset plugins
+    'theme-colors/no-literal-colors': 'error',
+    'icons/no-fa-icons-usage': 'error',
+    'i18n-strings/no-template-vars': 'error',
+    'file-progress/activate': 1,
+
+    // Explicitly turn off all other rules to avoid conflicts
+    // when the config gets merged with other configs
+    'import/no-unresolved': 'off',
+    'import/extensions': 'off',
+    '@typescript-eslint/naming-convention': 'off',
+  },
+  overrides: [
+    {
+      // Disable custom rules in test/story files
+      files: [
+        '**/*.test.*',
+        '**/*.spec.*',
+        '**/*.stories.*',
+        '**/test/**',
+        '**/tests/**',
+        '**/spec/**',
+        '**/__tests__/**',
+        '**/__mocks__/**',
+        'cypress-base/**',
+        'packages/superset-ui-core/src/theme/index.tsx',
+      ],
+      rules: {
+        'theme-colors/no-literal-colors': 0,
+        'icons/no-fa-icons-usage': 0,
+        'i18n-strings/no-template-vars': 0,
+        'file-progress/activate': 0,
+      },
+    },
+  ],
+  // Only check src/ files where theme/icon rules matter
+  ignorePatterns: [
+    'node_modules',
+    'dist',
+    'build',
+    '.next',
+    'coverage',
+    '*.min.js',
+    'vendor',
+    // Skip packages/plugins since they have different theming rules
+    'packages/**',
+    'plugins/**',
+    // Skip generated/external files
+    '*.generated.*',
+    '*.config.js',
+    'webpack.*',
+    // Temporary analysis files
+    '*.js', // Skip all standalone JS files in root
+    '*.json',
+  ],
+};

superset-frontend/.nvmrc

@@ -1 +1 @@
-v24.16.0
+v22.22.0

superset-frontend/cypress-base/package-lock.json

@@ -2058,24 +2058,6 @@
         "node": ">=8"
       }
     },
-    "node_modules/@istanbuljs/load-nyc-config/node_modules/argparse": {
-      "version": "2.0.1",
-      "resolved": "https://registry.npmjs.org/argparse/-/argparse-2.0.1.tgz",
-      "integrity": "sha512-8+9WqebbFzpX9OR+Wa6O29asIogeRMzcGtAINdpMHHyAg10f05aSFVBbcEqGf/PXw1EjAZ+q2/bEBg3DvurK3Q==",
-      "license": "Python-2.0"
-    },
-    "node_modules/@istanbuljs/load-nyc-config/node_modules/js-yaml": {
-      "version": "4.1.1",
-      "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-4.1.1.tgz",
-      "integrity": "sha512-qQKT4zQxXl8lLwBtHMWwaTcGfFOZviOJet3Oy/xmGk2gZH677CJM9EvtfdSkgWcATZhj/55JZ0rmy3myCT5lsA==",
-      "license": "MIT",
-      "dependencies": {
-        "argparse": "^2.0.1"
-      },
-      "bin": {
-        "js-yaml": "bin/js-yaml.js"
-      }
-    },
     "node_modules/@istanbuljs/schema": {
       "version": "0.1.2",
       "resolved": "https://registry.npmjs.org/@istanbuljs/schema/-/schema-0.1.2.tgz",
@@ -2952,8 +2934,6 @@
       "version": "1.0.10",
       "resolved": "https://registry.npmjs.org/argparse/-/argparse-1.0.10.tgz",
       "integrity": "sha512-o5Roy6tNG4SL/FOkCAN6RzjiakZS25RLYFrcMttJqbdd8BWrnA+fGz57iN5Pb06pvBGvl5gQ0B48dJlslXvoTg==",
-      "dev": true,
-      "peer": true,
       "dependencies": {
         "sprintf-js": "~1.0.2"
       }
@@ -4373,8 +4353,6 @@
       "version": "4.0.1",
       "resolved": "https://registry.npmjs.org/esprima/-/esprima-4.0.1.tgz",
       "integrity": "sha512-eGuFFw7Upda+g4p+QHvnW0RyTX/SVeJBDM/gCtMARO0cLuT2HcEKnTPvhjV6aGeqrCB/sbNop0Kszm0jsaWU4A==",
-      "dev": true,
-      "peer": true,
       "bin": {
         "esparse": "bin/esparse.js",
         "esvalidate": "bin/esvalidate.js"
@@ -5616,9 +5594,7 @@
       "version": "3.14.2",
       "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-3.14.2.tgz",
       "integrity": "sha512-PMSmkqxr106Xa156c2M265Z+FTrPl+oxd/rgOQy2tijQeK5TxQ43psO1ZCwhVOSdnn+RzkzlRz/eY4BgJBYVpg==",
-      "dev": true,
       "license": "MIT",
-      "peer": true,
       "dependencies": {
         "argparse": "^1.0.7",
         "esprima": "^4.0.0"
@@ -7780,9 +7756,7 @@
     "node_modules/sprintf-js": {
       "version": "1.0.3",
       "resolved": "https://registry.npmjs.org/sprintf-js/-/sprintf-js-1.0.3.tgz",
-      "integrity": "sha1-BOaSb2YolTVPPdAVIDYzuFcpfiw=",
-      "dev": true,
-      "peer": true
+      "integrity": "sha1-BOaSb2YolTVPPdAVIDYzuFcpfiw="
     },
     "node_modules/sshpk": {
       "version": "1.18.0",
@@ -10228,23 +10202,8 @@
         "camelcase": "^5.3.1",
         "find-up": "^4.1.0",
         "get-package-type": "^0.1.0",
-        "js-yaml": "4.1.1",
+        "js-yaml": "^3.13.1",
         "resolve-from": "^5.0.0"
-      },
-      "dependencies": {
-        "argparse": {
-          "version": "2.0.1",
-          "resolved": "https://registry.npmjs.org/argparse/-/argparse-2.0.1.tgz",
-          "integrity": "sha512-8+9WqebbFzpX9OR+Wa6O29asIogeRMzcGtAINdpMHHyAg10f05aSFVBbcEqGf/PXw1EjAZ+q2/bEBg3DvurK3Q=="
-        },
-        "js-yaml": {
-          "version": "4.1.1",
-          "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-4.1.1.tgz",
-          "integrity": "sha512-qQKT4zQxXl8lLwBtHMWwaTcGfFOZviOJet3Oy/xmGk2gZH677CJM9EvtfdSkgWcATZhj/55JZ0rmy3myCT5lsA==",
-          "requires": {
-            "argparse": "^2.0.1"
-          }
-        }
       }
     },
     "@istanbuljs/schema": {
@@ -11047,8 +11006,6 @@
       "version": "1.0.10",
       "resolved": "https://registry.npmjs.org/argparse/-/argparse-1.0.10.tgz",
       "integrity": "sha512-o5Roy6tNG4SL/FOkCAN6RzjiakZS25RLYFrcMttJqbdd8BWrnA+fGz57iN5Pb06pvBGvl5gQ0B48dJlslXvoTg==",
-      "dev": true,
-      "peer": true,
       "requires": {
         "sprintf-js": "~1.0.2"
       }
@@ -12094,9 +12051,7 @@
     "esprima": {
       "version": "4.0.1",
       "resolved": "https://registry.npmjs.org/esprima/-/esprima-4.0.1.tgz",
-      "integrity": "sha512-eGuFFw7Upda+g4p+QHvnW0RyTX/SVeJBDM/gCtMARO0cLuT2HcEKnTPvhjV6aGeqrCB/sbNop0Kszm0jsaWU4A==",
-      "dev": true,
-      "peer": true
+      "integrity": "sha512-eGuFFw7Upda+g4p+QHvnW0RyTX/SVeJBDM/gCtMARO0cLuT2HcEKnTPvhjV6aGeqrCB/sbNop0Kszm0jsaWU4A=="
     },
     "esquery": {
       "version": "1.4.0",
@@ -12998,8 +12953,6 @@
       "version": "3.14.2",
       "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-3.14.2.tgz",
       "integrity": "sha512-PMSmkqxr106Xa156c2M265Z+FTrPl+oxd/rgOQy2tijQeK5TxQ43psO1ZCwhVOSdnn+RzkzlRz/eY4BgJBYVpg==",
-      "dev": true,
-      "peer": true,
       "requires": {
         "argparse": "^1.0.7",
         "esprima": "^4.0.0"
@@ -14510,9 +14463,7 @@
     "sprintf-js": {
       "version": "1.0.3",
       "resolved": "https://registry.npmjs.org/sprintf-js/-/sprintf-js-1.0.3.tgz",
-      "integrity": "sha1-BOaSb2YolTVPPdAVIDYzuFcpfiw=",
-      "dev": true,
-      "peer": true
+      "integrity": "sha1-BOaSb2YolTVPPdAVIDYzuFcpfiw="
     },
     "sshpk": {
       "version": "1.18.0",

superset-frontend/eslint-rules/eslint-plugin-i18n-strings/index.ts

@@ -65,86 +65,6 @@ const plugin: { rules: Record<string, Rule.RuleModule> } = {
         };
       },
     },
-    'no-eager-t-in-config': {
-      meta: {
-        type: 'problem',
-        fixable: 'code',
-        docs: {
-          description:
-            'Disallow eager t()/tn() calls for `label` and `description` in config objects evaluated at module load (e.g., controlPanel files). The translation is captured at module-evaluation time, before i18n has loaded, and never updates when the user switches language. Wrap the call in an arrow function so it is evaluated at render time.',
-        },
-        schema: [
-          {
-            type: 'object',
-            properties: {
-              properties: {
-                type: 'array',
-                items: { type: 'string' },
-              },
-            },
-            additionalProperties: false,
-          },
-        ],
-        messages: {
-          eager:
-            'Eager `{{property}}: {{fn}}(...)` is evaluated at module load, before i18n is initialized. Wrap in an arrow function: `{{property}}: () => {{fn}}(...)`.',
-        },
-      },
-      create(context: Rule.RuleContext): Rule.RuleListener {
-        const watchedProps: string[] = context.options[0]?.properties ?? [
-          'label',
-          'description',
-        ];
-        const TRANSLATE_FNS = new Set(['t', 'tn']);
-
-        function handler(node: Node): void {
-          const prop = node as Node & {
-            key: { type: string; name?: string; value?: string };
-            value: Node & {
-              type: string;
-              callee?: { type: string; name?: string };
-            };
-            shorthand?: boolean;
-            computed?: boolean;
-          };
-          if (prop.shorthand || prop.computed) return;
-
-          const keyName =
-            prop.key.type === 'Identifier'
-              ? prop.key.name
-              : prop.key.type === 'Literal'
-                ? prop.key.value
-                : undefined;
-          if (typeof keyName !== 'string' || !watchedProps.includes(keyName)) {
-            return;
-          }
-
-          const callee = prop.value;
-          if (
-            callee.type !== 'CallExpression' ||
-            callee.callee?.type !== 'Identifier' ||
-            !callee.callee.name ||
-            !TRANSLATE_FNS.has(callee.callee.name)
-          ) {
-            return;
-          }
-
-          context.report({
-            node: prop.value,
-            messageId: 'eager',
-            data: { property: keyName, fn: callee.callee.name },
-            fix(fixer) {
-              const source = context.getSourceCode().getText(prop.value);
-              return fixer.replaceText(prop.value, `() => ${source}`);
-            },
-          });
-        }
-
-        return {
-          Property: handler,
-        };
-      },
-    },
     'sentence-case-buttons': {
       meta: {
         type: 'suggestion',

superset-frontend/eslint-rules/eslint-plugin-i18n-strings/no-eager-t-in-config.test.ts

@@ -1,86 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import type { Rule } from 'eslint';
-
-const { RuleTester } = require('eslint');
-const plugin: { rules: Record<string, Rule.RuleModule> } = require('.');
-
-const ruleTester = new RuleTester({
-  parserOptions: { ecmaVersion: 2020, sourceType: 'module' },
-});
-const rule: Rule.RuleModule = plugin.rules['no-eager-t-in-config'];
-
-ruleTester.run('no-eager-t-in-config', rule, {
-  valid: [
-    // Lazy form — the recommended pattern
-    "const c = { label: () => t('Foo') };",
-    "const c = { description: () => t('Foo') };",
-    "const c = { label: () => tn('one', 'many', n) };",
-    // Static strings — no translation, no issue
-    "const c = { label: 'Foo' };",
-    // Other property names — unaffected
-    "const c = { name: t('Foo') };",
-    "const c = { title: t('Foo') };",
-    // Computed keys are too dynamic to lint usefully
-    "const c = { [labelKey]: t('Foo') };",
-    // Shorthand: `{ label }` — no value to inspect
-    'const label = t("Foo"); const c = { label };',
-    // t() called inside a function body — already lazy
-    "const c = { label: state => t('Foo') };",
-    // Non-t() call expressions are fine
-    "const c = { label: someOtherFn('Foo') };",
-  ],
-  invalid: [
-    {
-      code: "const c = { label: t('Foo') };",
-      output: "const c = { label: () => t('Foo') };",
-      errors: [{ messageId: 'eager' }],
-    },
-    {
-      code: "const c = { description: t('Foo bar') };",
-      output: "const c = { description: () => t('Foo bar') };",
-      errors: [{ messageId: 'eager' }],
-    },
-    {
-      code: "const c = { label: tn('one', 'many', 2) };",
-      output: "const c = { label: () => tn('one', 'many', 2) };",
-      errors: [{ messageId: 'eager' }],
-    },
-    // String-literal keys are equivalent to identifier keys
-    {
-      code: "const c = { 'label': t('Foo') };",
-      output: "const c = { 'label': () => t('Foo') };",
-      errors: [{ messageId: 'eager' }],
-    },
-    // Custom watched-property list via rule option
-    {
-      code: "const c = { headerTitle: t('Foo') };",
-      output: "const c = { headerTitle: () => t('Foo') };",
-      options: [{ properties: ['headerTitle'] }],
-      errors: [{ messageId: 'eager' }],
-    },
-    // Nested config — fires per occurrence
-    {
-      code: "const c = { foo: { label: t('A'), description: t('B') } };",
-      output:
-        "const c = { foo: { label: () => t('A'), description: () => t('B') } };",
-      errors: [{ messageId: 'eager' }, { messageId: 'eager' }],
-    },
-  ],
-});

superset-frontend/eslint-rules/eslint-plugin-i18n-strings/no-template-vars.test.ts

@@ -31,13 +31,12 @@ const plugin: { rules: Record<string, Rule.RuleModule> } = require('.');
 // Tests
 //------------------------------------------------------------------------------
 
-const ruleTester = new RuleTester({ languageOptions: { ecmaVersion: 6 } });
+const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 6 } });
 const rule: Rule.RuleModule = plugin.rules['no-template-vars'];
 
-const errors: Array<{ message: string }> = [
+const errors: Array<{ type: string }> = [
   {
-    message:
-      "Don't use variables in translation string templates. Flask-babel is a static translation service, so it can't handle strings that include variables",
+    type: 'CallExpression',
   },
 ];
 

superset-frontend/eslint-rules/eslint-plugin-icons/no-fontawesome.test.ts

@@ -31,10 +31,7 @@ const plugin: { rules: Record<string, Rule.RuleModule> } = require('.');
 // Tests
 //------------------------------------------------------------------------------
 const ruleTester = new RuleTester({
-  languageOptions: {
-    ecmaVersion: 6,
-    parserOptions: { ecmaFeatures: { jsx: true } },
-  },
+  parserOptions: { ecmaVersion: 6, ecmaFeatures: { jsx: true } },
 });
 const rule: Rule.RuleModule = plugin.rules['no-fa-icons-usage'];
 

superset-frontend/eslint.config.minimal.js

@@ -1,137 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * MINIMAL ESLint flat config - ONLY for rules OXC doesn't support.
- *
- * This config is run alongside the OXC (oxlint) linter, which handles the
- * bulk of linting. ESLint here only covers the custom Superset plugins and
- * Prettier formatting that oxlint cannot express. It is consumed by
- * `scripts/oxlint-metrics-uploader.js` (`npm run lint-stats`).
- *
- * Migrated from the legacy `.eslintrc.minimal.js` (eslintrc) format to flat
- * config for ESLint v9+/v10, where eslintrc is no longer supported.
- *
- * Only covers:
- * - Custom Superset plugins (theme-colors, icons, i18n-strings)
- * - Prettier formatting
- */
-
-// Register the TypeScript require hook so ESLint can load the .ts plugin files
-// from eslint-rules/*.
-require('tsx/cjs');
-
-const tsParser = require('@typescript-eslint/parser');
-const prettierPlugin = require('eslint-plugin-prettier');
-const themeColorsPlugin = require('eslint-plugin-theme-colors');
-const iconsPlugin = require('eslint-plugin-icons');
-const i18nStringsPlugin = require('eslint-plugin-i18n-strings');
-
-module.exports = [
-  // Files this config applies to. Flat config has no `--ext`; globs live here.
-  // Only check src/ files where the theme/icon/i18n rules matter.
-  {
-    ignores: [
-      'node_modules/**',
-      'dist/**',
-      'build/**',
-      '.next/**',
-      'coverage/**',
-      '**/*.min.js',
-      'vendor/**',
-      // Skip packages/plugins since they have different theming rules
-      'packages/**',
-      'plugins/**',
-      // Skip generated/external/config files
-      '**/*.generated.*',
-      '**/*.config.js',
-      '**/webpack.*',
-      '*.json',
-    ],
-  },
-  {
-    files: ['**/*.{js,jsx,ts,tsx}'],
-    languageOptions: {
-      ecmaVersion: 2020,
-      sourceType: 'module',
-      // The @typescript-eslint parser handles both TS/TSX and plain JS/JSX and
-      // is compatible with ESLint v10's scope manager. (The legacy
-      // @babel/eslint-parser does not support ESLint v10.) The custom rules
-      // here are pure AST visitors and do not require type information, so no
-      // `project` is configured — this keeps parsing fast.
-      parser: tsParser,
-      parserOptions: {
-        ecmaFeatures: {
-          jsx: true,
-        },
-      },
-    },
-    // Don't report on eslint-disable comments for rules we don't have.
-    linterOptions: {
-      reportUnusedDisableDirectives: false,
-    },
-    plugins: {
-      prettier: prettierPlugin,
-      'theme-colors': themeColorsPlugin,
-      icons: iconsPlugin,
-      'i18n-strings': i18nStringsPlugin,
-    },
-    rules: {
-      // Prettier integration (formatting)
-      'prettier/prettier': 'error',
-
-      // Custom Superset plugins
-      'theme-colors/no-literal-colors': 'error',
-      'icons/no-fa-icons-usage': 'error',
-      'i18n-strings/no-template-vars': 'error',
-      // Enabled only for controlPanel files via the override below.
-      'i18n-strings/no-eager-t-in-config': 'off',
-    },
-  },
-  {
-    // Eager t()/tn() in `label`/`description` config props is captured at
-    // module-load time, before i18n initializes — labels stay in the fallback
-    // language even after the user switches. Surfaced as a warning (with
-    // autofix to `() => t(...)`) wherever this is a real foot-gun:
-    // controlPanel files. Promote to `'error'` once the codebase is clean.
-    files: ['**/controlPanel.{ts,tsx,js,jsx}'],
-    rules: {
-      'i18n-strings/no-eager-t-in-config': 'warn',
-    },
-  },
-  {
-    // Disable custom rules in test/story files
-    files: [
-      '**/*.test.*',
-      '**/*.spec.*',
-      '**/*.stories.*',
-      '**/test/**',
-      '**/tests/**',
-      '**/spec/**',
-      '**/__tests__/**',
-      '**/__mocks__/**',
-      'cypress-base/**',
-    ],
-    rules: {
-      'theme-colors/no-literal-colors': 'off',
-      'icons/no-fa-icons-usage': 'off',
-      'i18n-strings/no-template-vars': 'off',
-    },
-  },
-];

superset-frontend/oxlint.json

@@ -287,15 +287,13 @@
   "ignorePatterns": [
     "packages/generator-superset/**/*",
     "cypress-base/**",
-    "**/node_modules/**",
+    "node_modules/**",
     "build/**",
-    "**/dist/**",
-    "**/lib/**",
-    "**/esm/**",
-    "**/*.min.js",
-    "**/*.d.ts",
+    "dist/**",
+    "lib/**",
+    "esm/**",
+    "*.min.js",
     "coverage/**",
-    "storybook-static/**",
     ".git/**",
     "**/*.config.js",
     "**/*.config.ts"

superset-frontend/package.json

@@ -204,7 +204,7 @@
     "query-string": "9.4.0",
     "re-resizable": "^6.11.2",
     "react": "^18.2.0",
-    "react-arborist": "^3.10.1",
+    "react-arborist": "^3.8.0",
     "react-checkbox-tree": "^1.8.0",
     "react-diff-viewer-continued": "^4.2.2",
     "react-dnd": "^11.1.3",
@@ -280,11 +280,11 @@
     "@types/content-disposition": "^0.5.9",
     "@types/dom-to-image": "^2.6.7",
     "@types/jest": "^30.0.0",
-    "@types/jquery": "^4.0.1",
+    "@types/jquery": "^4.0.0",
     "@types/js-levenshtein": "^1.1.3",
     "@types/json-bigint": "^1.0.4",
     "@types/mousetrap": "^1.6.15",
-    "@types/node": "^25.9.2",
+    "@types/node": "^25.9.1",
     "@types/react": "^18.2.0",
     "@types/react-dom": "^18.2.0",
     "@types/react-loadable": "^5.5.11",
@@ -297,22 +297,22 @@
     "@types/rison": "0.1.0",
     "@types/tinycolor2": "^1.4.3",
     "@types/unzipper": "^0.10.11",
-    "@typescript-eslint/eslint-plugin": "^8.61.0",
-    "@typescript-eslint/parser": "^8.61.0",
+    "@typescript-eslint/eslint-plugin": "^8.60.1",
+    "@typescript-eslint/parser": "^8.59.4",
     "babel-jest": "^30.4.1",
     "babel-loader": "^10.1.1",
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "babel-plugin-jsx-remove-data-test-id": "^3.0.0",
     "babel-plugin-lodash": "^3.3.4",
-    "baseline-browser-mapping": "^2.10.34",
+    "baseline-browser-mapping": "^2.10.33",
     "cheerio": "1.2.0",
     "concurrently": "^10.0.3",
     "copy-webpack-plugin": "^14.0.0",
     "cross-env": "^10.1.0",
     "css-loader": "^7.1.4",
     "css-minimizer-webpack-plugin": "^8.0.0",
-    "eslint": "^10.4.1",
-    "eslint-config-prettier": "^10.1.8",
+    "eslint": "^8.56.0",
+    "eslint-config-prettier": "^7.2.0",
     "eslint-import-resolver-alias": "^1.1.2",
     "eslint-import-resolver-typescript": "^4.4.5",
     "eslint-plugin-cypress": "^3.6.0",
@@ -320,11 +320,11 @@
     "eslint-plugin-icons": "file:eslint-rules/eslint-plugin-icons",
     "eslint-plugin-import": "^2.32.0",
     "eslint-plugin-jest-dom": "^5.5.0",
-    "eslint-plugin-lodash": "^8.0.0",
+    "eslint-plugin-lodash": "^7.4.0",
     "eslint-plugin-no-only-tests": "^3.4.0",
     "eslint-plugin-prettier": "^5.5.6",
     "eslint-plugin-react-prefer-function-component": "^5.0.0",
-    "eslint-plugin-react-you-might-not-need-an-effect": "^1.0.0",
+    "eslint-plugin-react-you-might-not-need-an-effect": "^0.10.4",
     "eslint-plugin-storybook": "10.4.2",
     "eslint-plugin-testing-library": "^7.16.2",
     "eslint-plugin-theme-colors": "file:eslint-rules/eslint-plugin-theme-colors",
@@ -368,9 +368,9 @@
     "wait-on": "^9.0.10",
     "webpack": "^5.107.2",
     "webpack-bundle-analyzer": "^5.3.0",
-    "webpack-cli": "^7.0.3",
+    "webpack-cli": "^6.0.1",
     "webpack-dev-server": "^5.2.4",
-    "webpack-manifest-plugin": "^6.0.1",
+    "webpack-manifest-plugin": "^5.0.1",
     "webpack-sources": "^3.5.0",
     "webpack-visualizer-plugin2": "^2.0.0"
   },
@@ -382,8 +382,8 @@
     "regenerator-runtime": "^0.14.1"
   },
   "engines": {
-    "node": "^24.16.0",
-    "npm": "^11.13.0"
+    "node": "^22.22.0",
+    "npm": "^10.8.1"
   },
   "overrides": {
     "uuid": "$uuid",
@@ -414,16 +414,7 @@
     "@jest/types": "^30.4.0",
     "jest-util": "^30.4.0",
     "jest-circus": "^30.4.0",
-    "jest-environment-node": "^30.4.0",
-    "@babel/eslint-parser": {
-      "eslint": "$eslint"
-    },
-    "eslint-plugin-import": {
-      "eslint": "$eslint"
-    },
-    "eslint-plugin-jest-dom": {
-      "eslint": "$eslint"
-    }
+    "jest-environment-node": "^30.4.0"
   },
   "readme": "ERROR: No README data found!",
   "scarfSettings": {

superset-frontend/packages/superset-core/src/translation/TranslatorSingleton.test.ts

@@ -26,7 +26,7 @@ test('t() warns and creates a default translator when called before configure',
     const { t } = require('./TranslatorSingleton');
     const result = t('hello');
     expect(consoleSpy).toHaveBeenCalledWith(
-      expect.stringMatching(/was called before configure\(\)/),
+      'You should call configure(...) before calling other methods',
     );
     expect(result).toBe('hello');
     consoleSpy.mockRestore();
@@ -54,7 +54,7 @@ test('resetTranslation resets the configured singleton', () => {
     // After reset, calling t() should warn again
     t('hello');
     expect(consoleSpy).toHaveBeenCalledWith(
-      expect.stringMatching(/was called before configure\(\)/),
+      'You should call configure(...) before calling other methods',
     );
     consoleSpy.mockRestore();
   });
@@ -96,69 +96,6 @@ test('tn() calls translateWithNumber on the singleton', () => {
   });
 });
 
-test('pre-configure warning fires once per unique key', () => {
-  jest.isolateModules(() => {
-    const consoleSpy = jest.spyOn(console, 'warn').mockImplementation(() => {});
-    const { t } = require('./TranslatorSingleton');
-    t('apple');
-    t('apple');
-    t('apple');
-    t('banana');
-    expect(consoleSpy).toHaveBeenCalledTimes(2);
-    expect(consoleSpy).toHaveBeenNthCalledWith(
-      1,
-      expect.stringContaining('"apple"'),
-    );
-    expect(consoleSpy).toHaveBeenNthCalledWith(
-      2,
-      expect.stringContaining('"banana"'),
-    );
-    consoleSpy.mockRestore();
-  });
-});
-
-test('pre-configure warning suggests the lazy-function fix', () => {
-  jest.isolateModules(() => {
-    const consoleSpy = jest.spyOn(console, 'warn').mockImplementation(() => {});
-    const { t } = require('./TranslatorSingleton');
-    t('Sort ascending');
-    expect(consoleSpy).toHaveBeenCalledWith(
-      expect.stringContaining('() => t("Sort ascending")'),
-    );
-    consoleSpy.mockRestore();
-  });
-});
-
-test('pre-configure warning is suppressed in production', () => {
-  jest.isolateModules(() => {
-    const originalEnv = process.env.NODE_ENV;
-    process.env.NODE_ENV = 'production';
-    const consoleSpy = jest.spyOn(console, 'warn').mockImplementation(() => {});
-    const { t } = require('./TranslatorSingleton');
-    t('hello');
-    expect(consoleSpy).not.toHaveBeenCalled();
-    consoleSpy.mockRestore();
-    if (originalEnv !== undefined) {
-      process.env.NODE_ENV = originalEnv;
-    } else {
-      delete process.env.NODE_ENV;
-    }
-  });
-});
-
-test('resetTranslation clears the warned-keys dedupe set', () => {
-  jest.isolateModules(() => {
-    const consoleSpy = jest.spyOn(console, 'warn').mockImplementation(() => {});
-    const { t, resetTranslation } = require('./TranslatorSingleton');
-    t('hello');
-    expect(consoleSpy).toHaveBeenCalledTimes(1);
-    resetTranslation();
-    t('hello');
-    expect(consoleSpy).toHaveBeenCalledTimes(2);
-    consoleSpy.mockRestore();
-  });
-});
-
 test('resetTranslation does nothing when not yet configured', () => {
   jest.isolateModules(() => {
     const consoleSpy = jest.spyOn(console, 'warn').mockImplementation(() => {});
@@ -168,7 +105,7 @@ test('resetTranslation does nothing when not yet configured', () => {
     // The singleton is still unconfigured, so t() warns
     t('hello');
     expect(consoleSpy).toHaveBeenCalledWith(
-      expect.stringMatching(/was called before configure\(\)/),
+      'You should call configure(...) before calling other methods',
     );
     consoleSpy.mockRestore();
   });

superset-frontend/packages/superset-core/src/translation/TranslatorSingleton.ts

@@ -25,10 +25,6 @@ import { TranslatorConfig, Translations, LocaleData } from './types';
 let singleton: Translator | undefined;
 let isConfigured = false;
 
-// Tracks which keys have already triggered a pre-configure warning so the
-// logs don't drown in repeated calls from large module-load fan-outs.
-const warnedPreConfigureKeys = new Set<string>();
-
 function configure(config?: TranslatorConfig) {
   singleton = new Translator(config);
   isConfigured = true;
@@ -37,6 +33,10 @@ function configure(config?: TranslatorConfig) {
 }
 
 function getInstance() {
+  if (!isConfigured) {
+    console.warn('You should call configure(...) before calling other methods');
+  }
+
   if (typeof singleton === 'undefined') {
     singleton = new Translator();
   }
@@ -44,32 +44,11 @@ function getInstance() {
   return singleton;
 }
 
-function warnPreConfigure(fn: 't' | 'tn', key: string) {
-  // Only warn in non-production builds — production callers may legitimately
-  // tolerate the fallback, and the noise isn't useful at runtime.
-  if (
-    typeof process !== 'undefined' &&
-    process.env?.NODE_ENV === 'production'
-  ) {
-    return;
-  }
-  if (warnedPreConfigureKeys.has(key)) return;
-  warnedPreConfigureKeys.add(key);
-  console.warn(
-    `[i18n] ${fn}(${JSON.stringify(key)}) was called before configure() — ` +
-      `the result is the fallback language and will not update when the ` +
-      `user switches language. If this call is at module load (e.g., a ` +
-      `controlPanel \`label\`/\`description\`), wrap it in an arrow ` +
-      `function: \`() => ${fn}(${JSON.stringify(key)})\`.`,
-  );
-}
-
 function resetTranslation() {
   if (isConfigured) {
     isConfigured = false;
     singleton = undefined;
   }
-  warnedPreConfigureKeys.clear();
 }
 
 function addTranslation(key: string, translations: string[]) {
@@ -85,12 +64,10 @@ function addLocaleData(data: LocaleData) {
 }
 
 function t(input: string, ...args: unknown[]) {
-  if (!isConfigured) warnPreConfigure('t', input);
   return getInstance().translate(input, ...args);
 }
 
 function tn(key: string, ...args: unknown[]) {
-  if (!isConfigured) warnPreConfigure('tn', key);
   return getInstance().translateWithNumber(key, ...args);
 }
 

superset-frontend/packages/superset-ui-chart-controls/src/types.ts

@@ -204,14 +204,8 @@ export type TabOverride = 'data' | 'customize' | 'matrixify' | boolean;
  * these configs will be passed to the UI component for control as props.
  *
  * - type: the control type, referencing a React component of the same name
- * - label: the label as shown in the control's header. When the value involves
- *   `t()`/`tn()`, prefer the arrow-function form (`label: () => t('Foo')`) so
- *   the lookup runs at render time rather than at module load — eager
- *   `label: t('Foo')` captures the fallback language before i18n initializes
- *   and does not update on runtime language change. The
- *   `i18n-strings/no-eager-t-in-config` lint rule autofixes this.
- * - description: shown in the info tooltip of the control's header. Same
- *   lazy-form guidance as `label`.
+ * - label: the label as shown in the control's header
+ * - description: shown in the info tooltip of the control's header
  * - default: the default value when opening a new chart, or changing visualization type
  * - renderTrigger: a bool that defines whether the visualization should be re-rendered
  *    when changed. This should `true` for controls that only affect the rendering (client side)

superset-frontend/packages/superset-ui-core/package.json

@@ -75,9 +75,9 @@
     "@types/d3-scale": "^2.1.1",
     "@types/d3-time": "^3.0.4",
     "@types/d3-time-format": "^4.0.3",
-    "@types/jquery": "^4.0.1",
+    "@types/jquery": "^4.0.0",
     "@types/lodash": "^4.17.24",
-    "@types/node": "^25.9.2",
+    "@types/node": "^25.9.1",
     "@types/prop-types": "^15.7.15",
     "@types/react-syntax-highlighter": "^15.5.13",
     "@types/react-table": "^7.7.20",

superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridGenerator.test.ts

@@ -72,7 +72,6 @@ test('should generate a 2x2 grid for metrics mode', () => {
     createAdhocMetric('Revenue'),
     createSqlMetric('Q1', 'SUM(CASE WHEN quarter = 1 THEN value END)'),
   ]);
-  expect(firstCell!.formData.metric).toEqual(createAdhocMetric('Revenue'));
 });
 
 test('should generate grid for dimensions mode', () => {
@@ -214,9 +213,6 @@ test('should skip missing column metrics when generating cell form data', () =>
   expect(grid!.cells[0][0]!.formData.metrics).toEqual([
     createAdhocMetric('Revenue'),
   ]);
-  expect(grid!.cells[0][0]!.formData.metric).toEqual(
-    createAdhocMetric('Revenue'),
-  );
 });
 
 test('should not escape HTML entities in cell titles', () => {
@@ -475,51 +471,6 @@ test('should handle metrics without labels', () => {
   expect(grid!.colHeaders).toEqual(['count']);
 });
 
-test('should set singular metric for singular-metric chart types like Pie', () => {
-  const rowMetricFormData: TestFormData = {
-    viz_type: 'pie',
-    datasource: '1__table',
-    matrixify_enable: true,
-    matrixify_mode_rows: 'metrics',
-    matrixify_rows: [createAdhocMetric('Revenue'), createAdhocMetric('Profit')],
-  };
-
-  const grid = generateMatrixifyGrid(rowMetricFormData);
-
-  expect(grid).not.toBeNull();
-  expect(grid!.cells[0][0]!.formData.metrics).toEqual([
-    createAdhocMetric('Revenue'),
-  ]);
-  expect(grid!.cells[0][0]!.formData.metric).toEqual(
-    createAdhocMetric('Revenue'),
-  );
-  expect(grid!.cells[1][0]!.formData.metrics).toEqual([
-    createAdhocMetric('Profit'),
-  ]);
-  expect(grid!.cells[1][0]!.formData.metric).toEqual(
-    createAdhocMetric('Profit'),
-  );
-});
-
-test('should not overwrite singular metric in dimension-only mode', () => {
-  const dimensionFormData: TestFormData = {
-    viz_type: 'pie',
-    datasource: '1__table',
-    matrixify_enable: true,
-    matrixify_mode_rows: 'dimensions',
-    matrixify_dimension_rows: {
-      dimension: 'country',
-      values: ['USA', 'Canada'],
-    },
-    metric: 'existing_metric',
-  };
-
-  const grid = generateMatrixifyGrid(dimensionFormData);
-
-  expect(grid).not.toBeNull();
-  expect(grid!.cells[0][0]!.formData.metric).toBe('existing_metric');
-});
-
 test('should preserve slice_id and dashboardId for embedded dashboard permissions', () => {
   const formDataWithDashboardContext: TestFormData = {
     ...baseFormData,

superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridGenerator.ts

@@ -197,7 +197,6 @@ function generateCellFormData(
   // If we have metrics from the matrix, use them; otherwise keep original
   if (metrics.length > 0) {
     cellFormData.metrics = metrics;
-    cellFormData.metric = metrics[0];
   }
 
   return cellFormData;

superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/AsyncAceEditor.test.tsx

@@ -18,7 +18,6 @@
  */
 import { createRef } from 'react';
 import { render, screen, waitFor } from '@superset-ui/core/spec';
-import { supersetTheme } from '@apache-superset/core/theme';
 import type AceEditor from 'react-ace';
 import {
   AsyncAceEditor,
@@ -29,7 +28,6 @@ import {
   CssEditor,
   JsonEditor,
   ConfigEditor,
-  aceCompletionHighlightStyles,
 } from '.';
 
 import type { AceModule, AsyncAceEditorOptions } from './types';
@@ -44,17 +42,6 @@ test('renders SQLEditor', async () => {
   });
 });
 
-test('themes the autocomplete completion highlight from the theme', () => {
-  // Ace ships a hardcoded `color: #000` for the matched-prefix highlight, which
-  // is invisible on the dark autocomplete popup. The shared editor overrides it
-  // from the theme so every Ace editor (SQL Lab, Explore Custom SQL, ...) stays
-  // consistent.
-  const { styles } = aceCompletionHighlightStyles(supersetTheme);
-
-  expect(styles).toContain('.ace_completion-highlight');
-  expect(styles).toContain(supersetTheme.colorPrimaryText);
-});
-
 test('SQLEditor uses fontFamilyCode from theme', async () => {
   const ref = createRef<AceEditor>();
   const { container } = render(<SQLEditor ref={ref as React.Ref<never>} />);

superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/index.tsx

@@ -32,7 +32,7 @@ import {
   AsyncEsmComponent,
   PlaceholderProps,
 } from '@superset-ui/core/components/AsyncEsmComponent';
-import { useTheme, css, type SupersetTheme } from '@apache-superset/core/theme';
+import { useTheme, css } from '@apache-superset/core/theme';
 import { Global } from '@emotion/react';
 
 export { getTooltipHTML } from './Tooltip';
@@ -105,19 +105,6 @@ export type AsyncAceEditorOptions = {
   > | null;
 };
 
-/**
- * Theme-aware styling for the matched-prefix highlight in the autocomplete
- * popup. Ace ships a hardcoded `color: #000` that is invisible on the dark
- * popup, so the override needs `!important` to win. Lives in the shared editor
- * so every Ace editor (SQL Lab, Explore Custom SQL, ...) stays consistent.
- */
-export const aceCompletionHighlightStyles = (token: SupersetTheme) => css`
-  .ace_completion-highlight {
-    color: ${token.colorPrimaryText} !important;
-    background-color: ${token.colorPrimaryBgHover};
-  }
-`;
-
 /**
  * Get an async AceEditor with automatical loading of specified ace modules.
  */
@@ -383,8 +370,6 @@ export function AsyncAceEditor(
                   display: flex !important;
                 }
 
-                ${aceCompletionHighlightStyles(token)}
-
                 &&& .tooltip-detail {
                   display: flex;
                   justify-content: center;

superset-frontend/packages/superset-ui-core/src/components/DynamicEditableTitle/DynamicEditableTitle.regression.test.tsx

@@ -70,46 +70,11 @@ test('a change event that arrives before isEditing flips is not dropped', () =>
 });
 
 test('prop changes mid-edit do not clobber unsaved typing', async () => {
-  // Rerender DynamicEditableTitle directly with a changed title prop so the
-  // sync effect actually runs. Going through Harness would not exercise the
-  // bug because Harness owns its own state and only reads initialTitle once.
-  const onSave = jest.fn();
-  const props = {
-    placeholder: 'placeholder',
-    canEdit: true,
-    label: 'Title',
-    onSave,
-  };
-  const { rerender } = render(<DynamicEditableTitle {...props} title="Foo" />);
+  const { rerender } = render(<Harness initialTitle="Foo" />);
   const input = screen.getByRole('textbox') as HTMLInputElement;
   userEvent.click(input);
   await userEvent.type(input, 'X', { delay: 1 });
   expect(input.value).toBe('FooX');
-  rerender(<DynamicEditableTitle {...props} title="Bar" />);
+  rerender(<Harness initialTitle="Foo" />);
   expect(input.value).toBe('FooX');
-  // Locks in commit semantics: blur after a real edit must persist the
-  // user's typed value, even when a competing parent-driven title arrived
-  // mid-edit.
-  fireEvent.blur(input);
-  expect(onSave).toHaveBeenCalledWith('FooX');
-});
-
-test('passive focus then parent-driven title change then blur does not revert', () => {
-  // Phantom-revert scenario: user clicks the input but does not type, the
-  // parent autosaves a new title from elsewhere, then the user blurs. The
-  // component must NOT call onSave with the stale local value, otherwise it
-  // would silently overwrite the parent's update.
-  const onSave = jest.fn();
-  const props = {
-    placeholder: 'placeholder',
-    canEdit: true,
-    label: 'Title',
-    onSave,
-  };
-  const { rerender } = render(<DynamicEditableTitle {...props} title="Foo" />);
-  const input = screen.getByRole('textbox') as HTMLInputElement;
-  userEvent.click(input);
-  rerender(<DynamicEditableTitle {...props} title="Bar" />);
-  fireEvent.blur(input);
-  expect(onSave).not.toHaveBeenCalled();
 });

superset-frontend/packages/superset-ui-core/src/components/DynamicEditableTitle/index.tsx

@@ -81,25 +81,12 @@ export const DynamicEditableTitle = memo(
 
     const sizerRef = useRef<HTMLSpanElement>(null);
     const inputRef = useRef<InputRef>(null);
-    // Tracks whether the user has actually typed since entering edit mode.
-    // Gates onSave so that passive focus (click without typing) followed by a
-    // parent-driven title change and blur does not silently revert the
-    // parent's update with our stale currentTitle.
-    const dirtyRef = useRef(false);
     const { width: containerWidth, ref: containerRef } = useResizeDetector({
       refreshMode: 'debounce',
     });
 
     useEffect(() => {
-      // Don't overwrite in-flight user input when the parent re-renders with a
-      // new title prop mid-edit. handleBlur already syncs currentTitle on commit;
-      // re-running this effect when isEditing flips would resync to a stale
-      // title prop, so isEditing is intentionally read via closure rather than
-      // listed as a dep.
-      if (!isEditing) {
-        setCurrentTitle(title);
-      }
-      // eslint-disable-next-line react-hooks/exhaustive-deps
+      setCurrentTitle(title);
     }, [title]);
     useEffect(() => {
       if (isEditing) {
@@ -151,19 +138,10 @@ export const DynamicEditableTitle = memo(
         return;
       }
       const formattedTitle = currentTitle.trim();
-      // Only commit when the user actually typed. Passive focus must not
-      // overwrite a parent-driven title change that landed mid-edit.
-      if (dirtyRef.current && title !== formattedTitle) {
-        setCurrentTitle(formattedTitle);
+      setCurrentTitle(formattedTitle);
+      if (title !== formattedTitle) {
         onSave(formattedTitle);
-      } else if (!dirtyRef.current) {
-        // Drop any stale local state and resync to the latest title prop so a
-        // subsequent edit starts from the current parent value.
-        setCurrentTitle(title);
-      } else {
-        setCurrentTitle(formattedTitle);
       }
-      dirtyRef.current = false;
       setIsEditing(false);
     }, [canEdit, currentTitle, onSave, title]);
 
@@ -180,7 +158,6 @@ export const DynamicEditableTitle = memo(
         if (!isEditing) {
           setIsEditing(true);
         }
-        dirtyRef.current = true;
         setCurrentTitle(ev.target.value);
       },
       [canEdit, isEditing],

superset-frontend/packages/superset-ui-core/src/utils/index.ts

@@ -35,4 +35,3 @@ export * from './typedMemo';
 export * from './html';
 export * from './tooltip';
 export * from './merge';
-export * from './mapStyles';

superset-frontend/packages/superset-ui-core/src/utils/mapStyles.test.ts

@@ -1,295 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import {
-  getBootstrapDataFromDocument,
-  getDefaultMapRenderer,
-  getMapProviderMapStyle,
-  getMapboxApiKeyFromBootstrap,
-  getMapRendererOptions,
-  hasMapboxApiKey,
-  isRasterTileTemplate,
-  OSM_TILE_ATTRIBUTION,
-  OSM_TILE_STYLE_URL,
-  resolveMapStyle,
-} from './mapStyles';
-
-test('OSM style metadata uses the approved URL and attribution', () => {
-  expect(OSM_TILE_STYLE_URL).toBe(
-    'https://tile.openstreetmap.org/{z}/{x}/{y}.png',
-  );
-  expect(OSM_TILE_ATTRIBUTION).toBe('© OpenStreetMap contributors');
-});
-
-test('Mapbox key helpers report absence and presence from bootstrap data', () => {
-  expect(getMapboxApiKeyFromBootstrap({ common: { conf: {} } })).toBe('');
-  expect(hasMapboxApiKey({ common: { conf: {} } })).toBe(false);
-  expect(
-    getMapboxApiKeyFromBootstrap({
-      common: { conf: { MAPBOX_API_KEY: 'pk.test' } },
-    }),
-  ).toBe('pk.test');
-  expect(
-    getMapboxApiKeyFromBootstrap({
-      common: { conf: { MAPBOX_API_KEY: '  pk.test  ' } },
-    }),
-  ).toBe('pk.test');
-  expect(hasMapboxApiKey({ common: { conf: { MAPBOX_API_KEY: '   ' } } })).toBe(
-    false,
-  );
-  expect(
-    hasMapboxApiKey({ common: { conf: { MAPBOX_API_KEY: 'pk.test' } } }),
-  ).toBe(true);
-});
-
-test('bootstrap data helper parses document data safely', () => {
-  document.body.innerHTML = `<div id="app" data-bootstrap='${JSON.stringify({
-    common: { conf: { MAPBOX_API_KEY: 'pk.document' } },
-  })}'></div>`;
-
-  expect(getBootstrapDataFromDocument()).toEqual({
-    common: { conf: { MAPBOX_API_KEY: 'pk.document' } },
-  });
-
-  document.body.innerHTML = `<div id="app" data-bootstrap='not-json'></div>`;
-  expect(getBootstrapDataFromDocument()).toBeUndefined();
-
-  document.body.innerHTML = '';
-  expect(getBootstrapDataFromDocument()).toBeUndefined();
-});
-
-test('bootstrap data helper returns undefined without a document', () => {
-  // jsdom defines `document` as a non-configurable global, so the SSR guard
-  // cannot be exercised by deleting it. Instead, re-evaluate the function's
-  // own source in a scope where `document` is shadowed with undefined. When
-  // running under coverage, the source is istanbul-instrumented and references
-  // its module-scoped counter, so the counter is injected to keep the guard's
-  // execution attributed to mapStyles.ts.
-  const source = getBootstrapDataFromDocument.toString();
-  const counterName = source.match(/cov_\w+/)?.[0] ?? 'unusedCoverageCounter';
-  const coverage = (globalThis as { __coverage__?: Record<string, unknown> })
-    .__coverage__;
-  const coverageEntry =
-    coverage?.[
-      Object.keys(coverage).find(file => file.endsWith('mapStyles.ts')) ?? ''
-    ];
-  // eslint-disable-next-line no-new-func
-  const callWithoutDocument = new Function(
-    counterName,
-    'document',
-    `return (${source})();`,
-  );
-  expect(callWithoutDocument(() => coverageEntry, undefined)).toBeUndefined();
-});
-
-test('renderer options enable Mapbox only when a key is available', () => {
-  expect(getMapRendererOptions({ hasMapboxKey: true })).toEqual([
-    { value: 'maplibre' },
-    { value: 'mapbox' },
-  ]);
-  expect(getMapRendererOptions({ hasMapboxKey: false })).toEqual([
-    { value: 'maplibre' },
-  ]);
-});
-
-test('renderer options preserve saved Mapbox without API-key labels', () => {
-  expect(
-    getMapRendererOptions({ hasMapboxKey: false, currentValue: 'mapbox' }),
-  ).toEqual([{ value: 'maplibre' }, { value: 'mapbox', disabled: true }]);
-});
-
-test('map provider style helper preserves legacy non-Mapbox styles for MapLibre', () => {
-  expect(
-    getMapProviderMapStyle({
-      mapProvider: 'maplibre',
-      maplibreStyle: undefined,
-      mapboxStyle: OSM_TILE_STYLE_URL,
-      legacyMapStyle: 'https://example.com/fallback-style.json',
-    }),
-  ).toEqual({
-    mapProvider: 'maplibre',
-    mapStyle: OSM_TILE_STYLE_URL,
-  });
-});
-
-test('map provider style helper does not send Mapbox URLs to MapLibre', () => {
-  expect(
-    getMapProviderMapStyle({
-      mapProvider: 'maplibre',
-      mapboxStyle: 'mapbox://styles/mapbox/dark-v11',
-      legacyMapStyle: 'https://example.com/fallback-style.json',
-    }),
-  ).toEqual({
-    mapProvider: 'maplibre',
-    mapStyle: 'https://example.com/fallback-style.json',
-  });
-});
-
-test('map provider style helper uses Mapbox style when Mapbox is selected', () => {
-  expect(
-    getMapProviderMapStyle({
-      mapProvider: 'mapbox',
-      mapboxStyle: 'mapbox://styles/mapbox/dark-v11',
-      legacyMapStyle: 'https://example.com/fallback-style.json',
-    }),
-  ).toEqual({
-    mapProvider: 'mapbox',
-    mapStyle: 'mapbox://styles/mapbox/dark-v11',
-  });
-});
-
-test('default renderer uses configured Mapbox only when a key is available', () => {
-  expect(
-    getDefaultMapRenderer({
-      common: {
-        conf: {
-          DEFAULT_MAP_RENDERER: 'mapbox',
-          MAPBOX_API_KEY: 'pk.test',
-        },
-      },
-    }),
-  ).toBe('mapbox');
-  expect(
-    getDefaultMapRenderer({
-      common: { conf: { DEFAULT_MAP_RENDERER: 'mapbox' } },
-    }),
-  ).toBe('maplibre');
-  expect(
-    getDefaultMapRenderer({
-      common: {
-        conf: {
-          DEFAULT_MAP_RENDERER: 'invalid',
-          MAPBOX_API_KEY: 'pk.test',
-        },
-      },
-    }),
-  ).toBe('maplibre');
-});
-
-test('raster tile templates resolve to MapLibre raster style objects with attribution', () => {
-  const style = resolveMapStyle(OSM_TILE_STYLE_URL, 'default-style.json');
-
-  expect(style).toEqual({
-    version: 8,
-    sources: {
-      'osm-raster-tiles': {
-        type: 'raster',
-        tiles: [OSM_TILE_STYLE_URL],
-        tileSize: 256,
-        attribution: OSM_TILE_ATTRIBUTION,
-      },
-    },
-    layers: [
-      {
-        id: 'osm-raster-layer',
-        type: 'raster',
-        source: 'osm-raster-tiles',
-        minzoom: 0,
-        maxzoom: 22,
-      },
-    ],
-  });
-});
-
-test('tile protocol raster templates are unwrapped before style resolution', () => {
-  const style = resolveMapStyle(
-    `tile://${OSM_TILE_STYLE_URL}`,
-    'default-style.json',
-  );
-
-  expect(typeof style).toBe('object');
-  if (typeof style !== 'string') {
-    expect(style.sources['osm-raster-tiles'].tiles).toEqual([
-      OSM_TILE_STYLE_URL,
-    ]);
-    expect(style.sources['osm-raster-tiles'].attribution).toBe(
-      OSM_TILE_ATTRIBUTION,
-    );
-  }
-});
-
-test('OpenStreetMap subdomain raster templates receive OSM attribution', () => {
-  const osmSubdomainTileUrl =
-    'https://c.tile.openstreetmap.org/{z}/{x}/{y}.png';
-  const style = resolveMapStyle(
-    `tile://${osmSubdomainTileUrl}`,
-    'default-style.json',
-  );
-
-  expect(typeof style).toBe('object');
-  if (typeof style !== 'string') {
-    expect(style.sources['osm-raster-tiles'].tiles).toEqual([
-      osmSubdomainTileUrl,
-    ]);
-    expect(style.sources['osm-raster-tiles'].attribution).toBe(
-      OSM_TILE_ATTRIBUTION,
-    );
-  }
-});
-
-test('custom raster tile templates do not receive OSM attribution', () => {
-  const customTileUrl = 'https://tiles.example.com/{z}/{x}/{y}.png';
-  const style = resolveMapStyle(
-    `tile://${customTileUrl}`,
-    'default-style.json',
-  );
-
-  expect(typeof style).toBe('object');
-  if (typeof style !== 'string') {
-    expect(style.sources['osm-raster-tiles'].tiles).toEqual([customTileUrl]);
-    expect(style.sources['osm-raster-tiles']).not.toHaveProperty('attribution');
-  }
-});
-
-test('relative raster tile templates do not receive OSM attribution', () => {
-  const relativeTileUrl = '/tiles/{z}/{x}/{y}.png';
-  const style = resolveMapStyle(relativeTileUrl, 'default-style.json');
-
-  expect(typeof style).toBe('object');
-  if (typeof style !== 'string') {
-    expect(style.sources['osm-raster-tiles'].tiles).toEqual([relativeTileUrl]);
-    expect(style.sources['osm-raster-tiles']).not.toHaveProperty('attribution');
-  }
-});
-
-test('lookalike OpenStreetMap hostnames do not receive OSM attribution', () => {
-  const lookalikeTileUrl =
-    'https://openstreetmap.org.example.com/{z}/{x}/{y}.png';
-  const style = resolveMapStyle(
-    `tile://${lookalikeTileUrl}`,
-    'default-style.json',
-  );
-
-  expect(typeof style).toBe('object');
-  if (typeof style !== 'string') {
-    expect(style.sources['osm-raster-tiles'].tiles).toEqual([lookalikeTileUrl]);
-    expect(style.sources['osm-raster-tiles']).not.toHaveProperty('attribution');
-  }
-});
-
-test('style JSON URLs pass through without raster wrapping', () => {
-  const styleUrl = 'https://example.com/styles/custom-style.json';
-
-  expect(isRasterTileTemplate(undefined)).toBe(false);
-  expect(isRasterTileTemplate(styleUrl)).toBe(false);
-  expect(resolveMapStyle(styleUrl, 'default-style.json')).toBe(styleUrl);
-  expect(resolveMapStyle(undefined, 'default-style.json')).toBe(
-    'default-style.json',
-  );
-});

superset-frontend/packages/superset-ui-core/src/utils/mapStyles.ts

@@ -1,251 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-export type MapProvider = 'maplibre' | 'mapbox';
-
-export type MapRendererOption = {
-  value: MapProvider;
-  disabled?: boolean;
-};
-
-export type MapProviderMapStyle = {
-  mapProvider?: unknown;
-  maplibreStyle?: unknown;
-  mapboxStyle?: unknown;
-  legacyMapStyle?: unknown;
-};
-
-export type SelectedMapProviderMapStyle = {
-  mapProvider: MapProvider;
-  mapStyle?: string;
-};
-
-export type RasterTileMapStyle = {
-  version: 8;
-  sources: {
-    [sourceId: string]: {
-      type: 'raster';
-      tiles: string[];
-      tileSize: 256;
-      attribution?: string;
-    };
-  };
-  layers: [
-    {
-      id: string;
-      type: 'raster';
-      source: string;
-      minzoom: 0;
-      maxzoom: 22;
-    },
-  ];
-};
-
-export type ResolvedMapStyle = string | RasterTileMapStyle;
-
-export const OSM_TILE_STYLE_URL =
-  'https://tile.openstreetmap.org/{z}/{x}/{y}.png';
-export const OSM_TILE_ATTRIBUTION = '© OpenStreetMap contributors';
-
-export const MAPLIBRE_RENDERER_OPTION: MapRendererOption = {
-  value: 'maplibre',
-};
-export const MAPBOX_RENDERER_OPTION: MapRendererOption = {
-  value: 'mapbox',
-};
-export const DISABLED_MAPBOX_RENDERER_OPTION: MapRendererOption = {
-  ...MAPBOX_RENDERER_OPTION,
-  disabled: true,
-};
-
-const TILE_PROTOCOL = 'tile://';
-const RASTER_SOURCE_ID = 'osm-raster-tiles';
-const RASTER_LAYER_ID = 'osm-raster-layer';
-
-type BootstrapData = {
-  common?: {
-    conf?: {
-      DEFAULT_MAP_RENDERER?: unknown;
-      MAPBOX_API_KEY?: unknown;
-    };
-  };
-};
-
-export function getBootstrapDataFromDocument(): unknown {
-  if (typeof document === 'undefined') {
-    return undefined;
-  }
-
-  try {
-    const appContainer = document.getElementById('app');
-    const dataBootstrap = appContainer?.getAttribute('data-bootstrap');
-    return dataBootstrap ? JSON.parse(dataBootstrap) : undefined;
-  } catch {
-    return undefined;
-  }
-}
-
-export function getMapboxApiKeyFromBootstrap(
-  bootstrapData: unknown = getBootstrapDataFromDocument(),
-): string {
-  const mapboxApiKey = (bootstrapData as BootstrapData | undefined)?.common
-    ?.conf?.MAPBOX_API_KEY;
-  return typeof mapboxApiKey === 'string' ? mapboxApiKey.trim() : '';
-}
-
-export function hasMapboxApiKey(
-  bootstrapData: unknown = getBootstrapDataFromDocument(),
-): boolean {
-  return getMapboxApiKeyFromBootstrap(bootstrapData).trim().length > 0;
-}
-
-export function getDefaultMapRenderer(
-  bootstrapData: unknown = getBootstrapDataFromDocument(),
-): MapProvider {
-  const conf = (bootstrapData as BootstrapData | undefined)?.common?.conf;
-  const defaultRenderer = conf?.DEFAULT_MAP_RENDERER;
-
-  if (defaultRenderer === 'mapbox' && hasMapboxApiKey(bootstrapData)) {
-    return 'mapbox';
-  }
-
-  return 'maplibre';
-}
-
-export function getMapRendererOptions({
-  hasMapboxKey,
-  currentValue,
-}: {
-  hasMapboxKey: boolean;
-  currentValue?: MapProvider;
-}): MapRendererOption[] {
-  if (!hasMapboxKey && currentValue !== 'mapbox') {
-    return [MAPLIBRE_RENDERER_OPTION];
-  }
-
-  return [
-    MAPLIBRE_RENDERER_OPTION,
-    hasMapboxKey ? MAPBOX_RENDERER_OPTION : DISABLED_MAPBOX_RENDERER_OPTION,
-  ];
-}
-
-function getNonEmptyString(value: unknown): string | undefined {
-  return typeof value === 'string' && value.trim().length > 0
-    ? value
-    : undefined;
-}
-
-function isMapboxStyle(value: unknown): boolean {
-  return getNonEmptyString(value)?.startsWith('mapbox://') ?? false;
-}
-
-export function getMapProviderMapStyle({
-  mapProvider,
-  maplibreStyle,
-  mapboxStyle,
-  legacyMapStyle,
-}: MapProviderMapStyle): SelectedMapProviderMapStyle {
-  const selectedMapProvider: MapProvider =
-    mapProvider === 'mapbox' ? 'mapbox' : 'maplibre';
-  const maplibreStyleValue = getNonEmptyString(maplibreStyle);
-  const mapboxStyleValue = getNonEmptyString(mapboxStyle);
-  const legacyMapStyleValue = getNonEmptyString(legacyMapStyle);
-
-  if (selectedMapProvider === 'mapbox') {
-    return {
-      mapProvider: selectedMapProvider,
-      mapStyle: mapboxStyleValue ?? legacyMapStyleValue,
-    };
-  }
-
-  return {
-    mapProvider: selectedMapProvider,
-    mapStyle:
-      maplibreStyleValue ??
-      (isMapboxStyle(mapboxStyleValue) ? undefined : mapboxStyleValue) ??
-      legacyMapStyleValue,
-  };
-}
-
-function unwrapTileProtocol(value: string): string {
-  return value.startsWith(TILE_PROTOCOL)
-    ? value.slice(TILE_PROTOCOL.length)
-    : value;
-}
-
-export function isRasterTileTemplate(value: unknown): value is string {
-  if (typeof value !== 'string') {
-    return false;
-  }
-  const tileUrl = unwrapTileProtocol(value);
-  return ['{z}', '{x}', '{y}'].every(templateParam =>
-    tileUrl.includes(templateParam),
-  );
-}
-
-function isOpenStreetMapTileUrl(value: string): boolean {
-  try {
-    const hostname = new URL(value).hostname.toLowerCase();
-    return (
-      hostname === 'openstreetmap.org' ||
-      hostname.endsWith('.openstreetmap.org')
-    );
-  } catch {
-    return false;
-  }
-}
-
-export function buildRasterTileMapStyle(value: string): RasterTileMapStyle {
-  const tileUrl = unwrapTileProtocol(value);
-  const attribution = isOpenStreetMapTileUrl(tileUrl)
-    ? { attribution: OSM_TILE_ATTRIBUTION }
-    : {};
-
-  return {
-    version: 8,
-    sources: {
-      [RASTER_SOURCE_ID]: {
-        type: 'raster',
-        tiles: [tileUrl],
-        tileSize: 256,
-        ...attribution,
-      },
-    },
-    layers: [
-      {
-        id: RASTER_LAYER_ID,
-        type: 'raster',
-        source: RASTER_SOURCE_ID,
-        minzoom: 0,
-        maxzoom: 22,
-      },
-    ],
-  };
-}
-
-export function resolveMapStyle(
-  value: string | undefined,
-  defaultStyle: string,
-): ResolvedMapStyle {
-  if (!value) {
-    return defaultStyle;
-  }
-
-  return isRasterTileTemplate(value) ? buildRasterTileMapStyle(value) : value;
-}

superset-frontend/playwright/pages/ExplorePage.ts

@@ -29,33 +29,12 @@ export class ExplorePage {
   private static readonly SELECTORS = {
     DATASOURCE_CONTROL: '[data-test="datasource-control"]',
     VIZ_SWITCHER: '[data-test="fast-viz-switcher"]',
-    CHART_CONTAINER: '[data-test="chart-container"]',
   } as const;
 
   constructor(page: Page) {
     this.page = page;
   }
 
-  /**
-   * Navigates to the Explore page for a given chart and waits for it to load.
-   *
-   * @param chartId - ID of the chart (slice) to open
-   * @param options - Optional wait options
-   */
-  async goto(chartId: number, options?: { timeout?: number }): Promise<void> {
-    await this.page.goto(`explore/?slice_id=${chartId}`);
-    await this.waitForPageLoad(options);
-  }
-
-  /**
-   * Gets the chart container locator (where the rendered viz appears).
-   *
-   * @returns Locator for the chart container
-   */
-  getChartContainer(): Locator {
-    return this.page.locator(ExplorePage.SELECTORS.CHART_CONTAINER);
-  }
-
   /**
    * Waits for the Explore page to load.
    * Validates URL contains /explore/ and datasource control is visible.

superset-frontend/playwright/tests/chart/handlebars-format-date.spec.ts

@@ -1,104 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * Regression for #32960: the `formatDate` Handlebars helper (provided by
- * just-handlebars-helpers) stopped working after 4.1.2, rendering
- * "i is not a function" (minified) / "moment is not a function" (dev) instead
- * of the formatted date. The library helper resolves `moment` lazily via
- * `global.moment` / `require('moment/min/moment-with-locales')`, which the
- * bundled HandlebarsViewer no longer satisfies (it switched to dayjs).
- *
- * The fix registers a dayjs-backed `formatDate` override in HandlebarsViewer
- * (superset-frontend/plugins/plugin-chart-handlebars). This spec guards it: it
- * creates a Handlebars chart whose template uses `{{formatDate 'DD.MM.YYYY' ds}}`
- * and asserts the chart renders a real formatted date rather than the helper
- * error. Because the failure was a bundling/minification artifact (moment
- * resolves fine under Jest's Node `require`), an E2E test is required to cover it.
- */
-import { testWithAssets, expect } from '../../helpers/fixtures';
-import { apiPostChart } from '../../helpers/api/chart';
-import { getDatasetByName } from '../../helpers/api/dataset';
-import { ExplorePage } from '../../pages/ExplorePage';
-import { TIMEOUT } from '../../utils/constants';
-
-const DATASET_NAME = 'birth_names';
-
-testWithAssets(
-  'Handlebars formatDate helper renders a formatted date (#32960)',
-  async ({ page, testAssets }) => {
-    testWithAssets.setTimeout(TIMEOUT.SLOW_TEST);
-
-    const dataset = await getDatasetByName(page, DATASET_NAME);
-    if (!dataset) {
-      throw new Error(`Dataset ${DATASET_NAME} not found`);
-    }
-    const datasetId = dataset.id;
-
-    const params = {
-      datasource: `${datasetId}__table`,
-      viz_type: 'handlebars',
-      query_mode: 'aggregate',
-      groupby: ['ds'],
-      metrics: ['count'],
-      adhoc_filters: [],
-      row_limit: 5,
-      // Note: HTML_SANITIZATION (on by default) strips non-allowlisted
-      // attributes such as `class`, so the rendered markup is plain
-      // <ul>/<li> elements. The assertions below target `li` directly.
-      handlebarsTemplate:
-        '<ul>{{#each data}}' +
-        "<li>{{formatDate 'DD.MM.YYYY' ds}}</li>" +
-        '{{/each}}</ul>',
-      styleTemplate: '',
-    };
-
-    const chartResp = await apiPostChart(page, {
-      slice_name: `handlebars_format_date_${Date.now()}`,
-      viz_type: 'handlebars',
-      datasource_id: datasetId,
-      datasource_type: 'table',
-      params: JSON.stringify(params),
-    });
-    expect(chartResp.ok()).toBe(true);
-    // The chart API may return either a top-level `{ id }` or a wrapped
-    // `{ result: { id } }` shape; handle both and fail explicitly otherwise.
-    const chartBody = await chartResp.json();
-    const chartId: number = chartBody.result?.id ?? chartBody.id;
-    expect(chartId, 'chart creation should return an id').toBeTruthy();
-    testAssets.trackChart(chartId);
-
-    const explorePage = new ExplorePage(page);
-    await explorePage.goto(chartId);
-
-    const panel = explorePage.getChartContainer();
-    await panel.waitFor({ state: 'visible', timeout: TIMEOUT.PAGE_LOAD });
-
-    // The helper error surfaces as a "... is not a function" message rendered
-    // in place of the chart content.
-    await expect(panel).not.toContainText('is not a function', {
-      timeout: TIMEOUT.API_RESPONSE,
-    });
-
-    // At least one list item should contain a DD.MM.YYYY formatted date.
-    await expect(panel.locator('li').first()).toHaveText(/\d{2}\.\d{2}\.\d{4}/, {
-      timeout: TIMEOUT.API_RESPONSE,
-    });
-  },
-);

superset-frontend/playwright/tests/dashboard/gauge-interval-colors.spec.ts

@@ -1,202 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * Regression for #28766: a Gauge chart configured with interval bounds and
- * interval colors (mapped to a categorical color scheme) sometimes renders the
- * wrong interval colors when first loaded on a dashboard — a refresh fixes it.
- *
- * The gauge renders to a <canvas>, so this test reads pixels back from the
- * rendered gauge and asserts the configured interval colors are present in the
- * correct mapping. With `color_scheme: supersetColors` and
- * `interval_color_indices: '1,2'`, the gauge axis must paint the scheme's 1st
- * and 2nd colors (#1FA8C9 and #454E7C) and must NOT paint the 3rd (#5AC189),
- * which would indicate a shifted / fallback palette.
- *
- * CI green => the gauge paints the configured interval colors on first load;
- *             merging closes #28766 and guards against regressions.
- * CI red   => the interval colors are wrong on first load; the bug is live in
- *             plugin-chart-echarts/src/Gauge (color-scheme resolution).
- */
-import { testWithAssets, expect } from '../../helpers/fixtures';
-import { apiPostChart, apiPutChart } from '../../helpers/api/chart';
-import { apiPostDashboard } from '../../helpers/api/dashboard';
-import { getDatasetByName } from '../../helpers/api/dataset';
-import { DashboardPage } from '../../pages/DashboardPage';
-
-const DATASET_NAME = 'birth_names';
-
-// supersetColors palette (1-based, matching interval_color_indices):
-// index 1 = #1FA8C9, index 2 = #454E7C, index 3 = #5AC189
-const COLOR_INTERVAL_1: [number, number, number] = [31, 168, 201];
-const COLOR_INTERVAL_2: [number, number, number] = [69, 78, 124];
-const COLOR_UNUSED_3: [number, number, number] = [90, 193, 137];
-
-testWithAssets(
-  'Gauge renders configured interval colors on a dashboard (#28766)',
-  async ({ page, testAssets }) => {
-    const dataset = await getDatasetByName(page, DATASET_NAME);
-    if (!dataset) {
-      throw new Error(`Dataset ${DATASET_NAME} not found`);
-    }
-    const datasetId = dataset.id;
-
-    const sliceName = `gauge_interval_colors_${Date.now()}`;
-    const chartParams = {
-      datasource: `${datasetId}__table`,
-      viz_type: 'gauge_chart',
-      metric: 'count',
-      adhoc_filters: [],
-      row_limit: 10,
-      color_scheme: 'supersetColors',
-      min_val: 0,
-      max_val: 100,
-      start_angle: 225,
-      end_angle: -45,
-      intervals: '50,100',
-      interval_color_indices: '1,2',
-      show_pointer: true,
-      number_format: 'SMART_NUMBER',
-      value_formatter: '{value}',
-    };
-    const chartResp = await apiPostChart(page, {
-      slice_name: sliceName,
-      viz_type: 'gauge_chart',
-      datasource_id: datasetId,
-      datasource_type: 'table',
-      params: JSON.stringify(chartParams),
-    });
-    expect(chartResp.ok()).toBe(true);
-    const chartBody = await chartResp.json();
-    // Normalize: API may return id at top level or inside result.
-    const chartId: number = chartBody.result?.id ?? chartBody.id;
-    if (!chartId) {
-      throw new Error(
-        `Chart creation returned no id. Response: ${JSON.stringify(chartBody)}`,
-      );
-    }
-    testAssets.trackChart(chartId);
-
-    const chartLayoutKey = `CHART-${chartId}`;
-    const positionJson = {
-      DASHBOARD_VERSION_KEY: 'v2',
-      ROOT_ID: { type: 'ROOT', id: 'ROOT_ID', children: ['GRID_ID'] },
-      GRID_ID: {
-        type: 'GRID',
-        id: 'GRID_ID',
-        children: ['ROW-1'],
-        parents: ['ROOT_ID'],
-      },
-      'ROW-1': {
-        type: 'ROW',
-        id: 'ROW-1',
-        children: [chartLayoutKey],
-        parents: ['ROOT_ID', 'GRID_ID'],
-        meta: { background: 'BACKGROUND_TRANSPARENT' },
-      },
-      [chartLayoutKey]: {
-        type: 'CHART',
-        id: chartLayoutKey,
-        children: [],
-        parents: ['ROOT_ID', 'GRID_ID', 'ROW-1'],
-        meta: {
-          chartId,
-          width: 6,
-          height: 60,
-          sliceName,
-        },
-      },
-    };
-    const dashResp = await apiPostDashboard(page, {
-      dashboard_title: `gauge_interval_colors_${Date.now()}`,
-      published: true,
-      position_json: JSON.stringify(positionJson),
-      json_metadata: JSON.stringify({ color_scheme: 'supersetColors' }),
-    });
-    expect(dashResp.ok()).toBe(true);
-    const dashBody = await dashResp.json();
-    const dashboardId: number = dashBody.result?.id ?? dashBody.id;
-    testAssets.trackDashboard(dashboardId);
-
-    await apiPutChart(page, chartId, { dashboards: [dashboardId] });
-
-    const dashboardPage = new DashboardPage(page);
-    await dashboardPage.gotoById(dashboardId);
-    await dashboardPage.waitForLoad();
-    await dashboardPage.waitForChartsToLoad();
-
-    const canvas = page.locator('[data-test="chart-container"] canvas').first();
-    await canvas.waitFor({ state: 'visible', timeout: 30_000 });
-
-    // Read the configured interval colors back from the rendered canvas.
-    // Poll because the gauge paints shortly after the chart container appears.
-    const countColors = () =>
-      canvas.evaluate(
-        (el: HTMLCanvasElement, targets: Array<[number, number, number]>) => {
-          const ctx = el.getContext('2d');
-          if (!ctx) return targets.map(() => 0);
-          const { data } = ctx.getImageData(0, 0, el.width, el.height);
-          const counts = targets.map(() => 0);
-          for (let i = 0; i < data.length; i += 4) {
-            if (data[i + 3] < 200) continue;
-            for (let t = 0; t < targets.length; t += 1) {
-              const [r, g, b] = targets[t];
-              if (
-                Math.abs(data[i] - r) < 12 &&
-                Math.abs(data[i + 1] - g) < 12 &&
-                Math.abs(data[i + 2] - b) < 12
-              ) {
-                counts[t] += 1;
-              }
-            }
-          }
-          return counts;
-        },
-        [COLOR_INTERVAL_1, COLOR_INTERVAL_2, COLOR_UNUSED_3],
-      );
-
-    // Capture the counts inside the poll so the assertions below run against the
-    // exact paint snapshot that satisfied the poll, not a second canvas read.
-    let counts: number[] = [0, 0, 0];
-    await expect
-      .poll(
-        async () => {
-          counts = await countColors();
-          return counts[0];
-        },
-        { timeout: 20_000 },
-      )
-      .toBeGreaterThan(50);
-
-    const [interval1, interval2, unused3] = counts;
-
-    expect(
-      interval1,
-      'Gauge should paint the 1st interval color (#1FA8C9)',
-    ).toBeGreaterThan(50);
-    expect(
-      interval2,
-      'Gauge should paint the 2nd interval color (#454E7C)',
-    ).toBeGreaterThan(50);
-    expect(
-      unused3,
-      'Gauge must not paint the 3rd palette color (#5AC189) — indicates a shifted/fallback palette (#28766)',
-    ).toBe(0);
-  },
-);

superset-frontend/playwright/tests/embedded/pivot-collapse-state.spec.ts

@@ -1,309 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * Regression for #33406: in a Pivot Table (v2) with nested rows, collapsing a
- * row group with the [-] toggle should stay collapsed after the collapsed rows
- * scroll out of the viewport and back. The bug reproduces specifically when the
- * dashboard is embedded via an iframe — the collapse/expand state lives in the
- * pivot renderer's local React state (`collapsedRows` initialised to `{}`), so
- * anything that remounts the chart resets it and the rows re-expand.
- *
- * This spec runs on the embedded harness (the only place the bug is reported to
- * reproduce). It collapses a top-level row, scrolls the embedded dashboard so
- * the pivot leaves and re-enters the viewport, and asserts the row is still
- * collapsed.
- *
- * CI green => collapse state survives the scroll round-trip; merging closes
- *             #33406 and guards against regressions.
- * CI red   => the rows re-expanded; the bug is live and the fix belongs in
- *             plugin-chart-pivot-table (lift collapse state out of transient
- *             component state, e.g. persist `collapsedRows`/`collapsedCols`).
- *
- * NOTE: the embedded suite only runs when the embedded SDK bundle is built and
- * INCLUDE_EMBEDDED=true (CI sets both). It is skipped otherwise.
- */
-import { test, expect, Browser, BrowserContext, Page } from '@playwright/test';
-import { createServer, IncomingMessage, ServerResponse, Server } from 'http';
-import { AddressInfo, Socket } from 'net';
-import { readFileSync, existsSync } from 'fs';
-import { join } from 'path';
-import {
-  apiEnableEmbedding,
-  getAccessToken,
-  getGuestToken,
-} from '../../helpers/api/embedded';
-import { apiPost, apiPut } from '../../helpers/api/requests';
-import { apiPostDashboard, apiDeleteDashboard } from '../../helpers/api/dashboard';
-import { apiDeleteChart } from '../../helpers/api/chart';
-import { EmbeddedPage } from '../../pages/EmbeddedPage';
-import { EMBEDDED } from '../../utils/constants';
-
-const SUPERSET_DOMAIN = (() => {
-  const url = process.env.PLAYWRIGHT_BASE_URL || 'http://localhost:8088';
-  return url.replace(/\/+$/, '');
-})();
-const SUPERSET_BASE_URL = SUPERSET_DOMAIN.endsWith('/')
-  ? SUPERSET_DOMAIN
-  : `${SUPERSET_DOMAIN}/`;
-
-const SDK_BUNDLE_PATH = join(
-  __dirname,
-  '../../../../superset-embedded-sdk/bundle/index.js',
-);
-const EMBED_APP_DIR = join(__dirname, '../../embedded-app');
-const INDEX_HTML_PATH = join(EMBED_APP_DIR, 'index.html');
-const DATASET_NAME = 'birth_names';
-
-interface EmbedAppServer {
-  server: Server;
-  url: string;
-  close: () => Promise<void>;
-}
-
-async function startEmbedAppServer(): Promise<EmbedAppServer> {
-  const sockets = new Set<Socket>();
-  const server = createServer((req: IncomingMessage, res: ServerResponse) => {
-    const urlPath = req.url?.split('?')[0] || '/';
-    if (urlPath === '/sdk/index.js') {
-      if (!existsSync(SDK_BUNDLE_PATH)) {
-        res.writeHead(404);
-        res.end(
-          'SDK bundle not found. Run: cd superset-embedded-sdk && npm ci && npm run build',
-        );
-        return;
-      }
-      res.writeHead(200, { 'Content-Type': 'text/javascript' });
-      res.end(readFileSync(SDK_BUNDLE_PATH));
-      return;
-    }
-    if (urlPath === '/' || urlPath === '/index.html') {
-      res.writeHead(200, { 'Content-Type': 'text/html' });
-      res.end(readFileSync(INDEX_HTML_PATH));
-      return;
-    }
-    res.writeHead(404);
-    res.end('Not found');
-  });
-  server.on('connection', socket => {
-    sockets.add(socket);
-    socket.once('close', () => sockets.delete(socket));
-  });
-  await new Promise<void>((resolve, reject) => {
-    server.once('error', reject);
-    server.listen(0, '127.0.0.1', () => {
-      server.removeListener('error', reject);
-      resolve();
-    });
-  });
-  const address = server.address() as AddressInfo;
-  return {
-    server,
-    url: `http://127.0.0.1:${address.port}`,
-    close: () =>
-      new Promise<void>(resolve => {
-        for (const socket of sockets) socket.destroy();
-        sockets.clear();
-        server.close(() => resolve());
-      }),
-  };
-}
-
-function createAdminContext(browser: Browser): Promise<BrowserContext> {
-  return browser.newContext({
-    storageState: 'playwright/.auth/user.json',
-    baseURL: SUPERSET_BASE_URL,
-  });
-}
-
-async function findDatasetIdByName(page: Page, name: string): Promise<number> {
-  const query = `(filters:!((col:table_name,opr:eq,value:'${name}')))`;
-  const resp = await page.request.get(`api/v1/dataset/?q=${query}`);
-  const body = await resp.json();
-  if (!body.result?.length) {
-    throw new Error(`Dataset ${name} not found`);
-  }
-  return body.result[0].id;
-}
-
-test.describe('Embedded Pivot Table collapse state (#33406)', () => {
-  test.describe.configure({ mode: 'serial' });
-  test.setTimeout(90000);
-
-  let appServer: EmbedAppServer;
-  let accessToken: string;
-  let embedUuid: string;
-  let dashboardId: number;
-  let chartId: number;
-
-  test.beforeAll(async ({ browser }) => {
-    test.skip(
-      !existsSync(SDK_BUNDLE_PATH),
-      'Embedded SDK bundle not found. Build it with: cd superset-embedded-sdk && npm ci && npm run build',
-    );
-
-    appServer = await startEmbedAppServer();
-    const context = await createAdminContext(browser);
-    const setupPage = await context.newPage();
-    try {
-      const datasetId = await findDatasetIdByName(setupPage, DATASET_NAME);
-
-      const params = {
-        datasource: `${datasetId}__table`,
-        viz_type: 'pivot_table_v2',
-        groupbyRows: ['state', 'name'],
-        groupbyColumns: [],
-        metrics: ['count'],
-        metricsLayout: 'COLUMNS',
-        aggregateFunction: 'Count',
-        rowSubTotals: true,
-        rowTotals: true,
-        valueFormat: 'SMART_NUMBER',
-        row_limit: 1000,
-        order_desc: true,
-      };
-      const chartResp = await apiPost(setupPage, 'api/v1/chart/', {
-        slice_name: `pivot_collapse_repro_${Date.now()}`,
-        viz_type: 'pivot_table_v2',
-        datasource_id: datasetId,
-        datasource_type: 'table',
-        params: JSON.stringify(params),
-      });
-      chartId = (await chartResp.json()).id;
-
-      const chartLayoutKey = `CHART-${chartId}`;
-      const positionJson = {
-        DASHBOARD_VERSION_KEY: 'v2',
-        ROOT_ID: { type: 'ROOT', id: 'ROOT_ID', children: ['GRID_ID'] },
-        GRID_ID: {
-          type: 'GRID',
-          id: 'GRID_ID',
-          children: ['ROW-1'],
-          parents: ['ROOT_ID'],
-        },
-        'ROW-1': {
-          type: 'ROW',
-          id: 'ROW-1',
-          children: [chartLayoutKey],
-          parents: ['ROOT_ID', 'GRID_ID'],
-          meta: { background: 'BACKGROUND_TRANSPARENT' },
-        },
-        [chartLayoutKey]: {
-          type: 'CHART',
-          id: chartLayoutKey,
-          children: [],
-          parents: ['ROOT_ID', 'GRID_ID', 'ROW-1'],
-          meta: {
-            chartId,
-            width: 6,
-            height: 80,
-            sliceName: 'pivot_collapse_repro',
-          },
-        },
-      };
-      const dashResp = await apiPostDashboard(setupPage, {
-        dashboard_title: `pivot_collapse_repro_${Date.now()}`,
-        published: true,
-        position_json: JSON.stringify(positionJson),
-      });
-      const dashBody = await dashResp.json();
-      dashboardId = dashBody.id;
-      await apiPut(setupPage, `api/v1/chart/${chartId}`, {
-        dashboards: [dashboardId],
-      });
-
-      const embedded = await apiEnableEmbedding(setupPage, dashboardId);
-      embedUuid = embedded.uuid;
-      accessToken = await getAccessToken(setupPage);
-    } finally {
-      await context.close();
-    }
-  });
-
-  test.afterAll(async ({ browser }) => {
-    const context = await createAdminContext(browser);
-    try {
-      const cleanupPage = await context.newPage();
-      if (dashboardId !== undefined) {
-        await apiDeleteDashboard(cleanupPage, dashboardId, {
-          failOnStatusCode: false,
-        });
-      }
-      if (chartId !== undefined) {
-        await apiDeleteChart(cleanupPage, chartId, { failOnStatusCode: false });
-      }
-    } catch (err) {
-      // eslint-disable-next-line no-console
-      console.error('[pivot-collapse teardown] cleanup failed:', err);
-    } finally {
-      await context.close();
-    }
-    if (appServer) await appServer.close();
-  });
-
-  test('collapsed rows stay collapsed after a scroll round-trip', async ({
-    page,
-  }) => {
-    const embeddedPage = new EmbeddedPage(page);
-    await embeddedPage.exposeTokenFetcher(async () =>
-      getGuestToken(page, dashboardId, { accessToken }),
-    );
-    await embeddedPage.goto({
-      appUrl: appServer.url,
-      uuid: embedUuid,
-      supersetDomain: SUPERSET_DOMAIN,
-    });
-    await embeddedPage.waitForIframe();
-    await embeddedPage.waitForDashboardContent();
-    await embeddedPage.waitForChartRendered();
-
-    const rowLabels = embeddedPage.iframe.locator('.pvtRowLabel');
-    await expect
-      .poll(() => rowLabels.count(), { timeout: EMBEDDED.CHART_RENDER })
-      .toBeGreaterThan(1);
-    const expandedCount = await rowLabels.count();
-
-    // Collapse the first top-level row group via its [-] toggle. Scope to
-    // `.pvtTable` so we never match a stray `toggle` class elsewhere in the DOM.
-    await embeddedPage.iframe.locator('.pvtTable .toggle').first().click();
-    await expect
-      .poll(() => embeddedPage.iframe.locator('.pvtRowLabel').count(), {
-        timeout: EMBEDDED.CHART_RENDER,
-      })
-      .toBeLessThan(expandedCount);
-    const collapsedCount = await embeddedPage.iframe
-      .locator('.pvtRowLabel')
-      .count();
-
-    // Scroll the embedded dashboard so the pivot leaves the viewport, then back.
-    await embeddedPage.iframe.locator('body').evaluate(() => {
-      window.scrollTo(0, document.body.scrollHeight);
-    });
-    await page.waitForTimeout(800);
-    await embeddedPage.iframe.locator('body').evaluate(() => {
-      window.scrollTo(0, 0);
-    });
-    await page.waitForTimeout(1200);
-
-    // The collapsed group must remain collapsed (row-label count unchanged).
-    await expect(embeddedPage.iframe.locator('.pvtRowLabel')).toHaveCount(
-      collapsedCount,
-    );
-  });
-});

superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.ts

@@ -165,16 +165,6 @@ function CountryMap(element: HTMLElement, props: CountryMapProps) {
     return '';
   };
 
-  const updatePopupPosition = () => {
-    const svgHeight = svg.node().getBoundingClientRect().height;
-    const [x, y] = d3.mouse(svg.node());
-    hoverPopup
-      .style('display', 'block')
-      .style('top', `${y + 30}px`)
-      .style('left', `${x}px`)
-      .classed('popup-at-bottom', y > (svgHeight * 2) / 3);
-  };
-
   const mouseenter = function mouseenter(this: SVGPathElement, d: GeoFeature) {
     // Darken color
     let c: string = colorFn(d);
@@ -187,14 +177,21 @@ function CountryMap(element: HTMLElement, props: CountryMapProps) {
       region => region.country_id === d.properties.ISO,
     );
 
-    hoverPopup.style('display', 'block').html(
-      `<div><strong>${getNameOfRegion(d)}</strong><br>${result.length > 0 ? formatter(result[0].metric) : ''}</div>`,
-    );
-    updatePopupPosition();
+    const position = d3.mouse(svg.node());
+    hoverPopup
+      .style('display', 'block')
+      .style('top', `${position[1] + 30}px`)
+      .style('left', `${position[0]}px`)
+      .html(
+        `<div><strong>${getNameOfRegion(d)}</strong><br>${result.length > 0 ? formatter(result[0].metric) : ''}</div>`,
+      );
   };
 
   const mousemove = function mousemove() {
-    updatePopupPosition();
+    const position = d3.mouse(svg.node());
+    hoverPopup
+      .style('top', `${position[1] + 30}px`)
+      .style('left', `${position[0]}px`);
   };
 
   const mouseout = function mouseout(this: SVGPathElement) {

superset-frontend/plugins/legacy-plugin-chart-country-map/src/ReactCountryMap.tsx

@@ -86,10 +86,5 @@ export default styled(CountryMap)`
       cursor: pointer;
       stroke: ${theme.colorSplit};
     }
-
-    .superset-legacy-chart-country-map .hover-popup.popup-at-bottom {
-      transform: translateY(-150%);
-    }
-
   `}
 `;

superset-frontend/plugins/plugin-chart-echarts/src/Radar/transformProps.ts

@@ -126,7 +126,7 @@ export default function transformProps(
     ...DEFAULT_RADAR_FORM_DATA,
     ...formData,
   };
-  const { setDataMask = () => {}, onContextMenu } = hooks ?? {};
+  const { setDataMask = () => {}, onContextMenu } = hooks;
   const colorFn = CategoricalColorNamespace.getScale(colorScheme as string);
   const numberFormatter = getNumberFormatter(numberFormat);
   const denormalizedSeriesValues: SeriesNormalizedMap = {};
@@ -140,7 +140,7 @@ export default function transformProps(
 
   const metricLabels = metrics.map(getMetricLabel);
 
-  const metricsWithCustomBounds = new Set<string>(
+  const metricsWithCustomBounds = new Set(
     metricLabels.filter(metricLabel => {
       const config = columnConfig?.[metricLabel];
       const hasMax = !!isDefined(config?.radarMetricMaxValue);
@@ -358,7 +358,6 @@ export default function transformProps(
       metricLabels,
       getDenormalizedSeriesValue,
       metricsWithCustomBounds,
-      numberFormatter,
     );
 
   const echartOptions: EChartsCoreOption = {

superset-frontend/plugins/plugin-chart-echarts/src/Radar/utils.ts

@@ -16,8 +16,6 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { NumberFormatter } from '@superset-ui/core';
-
 /*
  function for finding the max metric values among all series data for Radar Chart
 */
@@ -49,7 +47,7 @@ interface TooltipParams {
 
 interface TooltipMetricValue {
   metric: string;
-  value: number | string;
+  value: number;
 }
 
 export const renderNormalizedTooltip = (
@@ -57,7 +55,6 @@ export const renderNormalizedTooltip = (
   metrics: string[],
   getDenormalizedValue: (seriesName: string, value: string) => number,
   metricsWithCustomBounds: Set<string>,
-  formatter?: NumberFormatter,
 ): string => {
   const { color, name = '', value: values } = params;
   const seriesName = name || 'series0';
@@ -73,7 +70,7 @@ export const renderNormalizedTooltip = (
 
     return {
       metric,
-      value: formatter ? formatter(originalValue) : originalValue,
+      value: originalValue,
     };
   });
 

superset-frontend/plugins/plugin-chart-echarts/src/utils/tooltip.test.tsx

@@ -1,87 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/** @jest-environment jsdom */
-import '@testing-library/jest-dom';
-import React from 'react';
-import { getDefaultTooltip } from './tooltip';
-import type { Refs } from '../types';
-
-test('getDefaultTooltip computes height and sets scroll styles', () => {
-  const div = document.createElement('div');
-  jest.spyOn(div, 'getBoundingClientRect').mockReturnValue({
-    x: 0,
-    y: 0,
-    width: 100,
-    height: 100,
-    top: 0,
-    right: 100,
-    bottom: 100,
-    left: 0,
-    toJSON: () => ({}),
-  } as DOMRect);
-
-  const divRef = React.createRef<HTMLDivElement>();
-  Object.defineProperty(divRef, 'current', { value: div });
-
-  const refs: Refs = { divRef };
-
-  // Set viewport dimensions
-  Object.defineProperty(document.documentElement, 'clientWidth', {
-    value: 1200,
-    configurable: true,
-  });
-  Object.defineProperty(document.documentElement, 'clientHeight', {
-    value: 1000,
-    configurable: true,
-  });
-
-  const tooltip = getDefaultTooltip(refs);
-
-  // Test behavioral properties
-  expect(tooltip.enterable).toBe(true);
-  expect(tooltip.confine).toBe(true);
-  expect(tooltip.hideDelay).toBe(50);
-
-  // Test that position function exists and is callable
-  expect(typeof tooltip.position).toBe('function');
-
-  // Test position function behavior - returns coordinates
-  const tooltipDom = document.createElement('div');
-  const result = tooltip.position(
-    [200, 300],
-    {} as any,
-    tooltipDom,
-    {} as any,
-    { contentSize: [300, 600], viewSize: [1200, 1000] },
-  );
-
-  // Verify the actual computed position, not just its shape. The cursor sits
-  // in the right half of the chart, so the tooltip is placed to its left;
-  // that pushes it past the left edge, so it clamps to the overflow margin.
-  // Vertically it would overflow the top, so it flips to just below the cursor.
-  expect(result).toEqual([5, 310]);
-
-  const computedMaxHeight = parseInt(tooltipDom.style.maxHeight, 10);
-  const viewportHeight = 1000;
-  const expectedMaxHeight = Math.min(800, viewportHeight * 0.8);
-
-  expect(computedMaxHeight).toBe(expectedMaxHeight);
-  expect(tooltipDom).toHaveStyle({ overflow: 'auto' });
-});

superset-frontend/plugins/plugin-chart-echarts/src/utils/tooltip.ts

@@ -34,12 +34,6 @@ export function getDefaultTooltip(refs: Refs) {
     borderColor: 'transparent',
     // CSS hack applied on this class to resolve https://github.com/apache/superset/issues/30058
     className: 'echarts-tooltip',
-    // allow scrolling inside tooltip without re-triggering the chart
-    enterable: true,
-    // keep within viewport and above header; enable internal scroll
-    confine: true,
-    // optional: reduce flicker when moving in/out of tooltip
-    hideDelay: 50,
     position: (
       canvasMousePos: [number, number],
       params: CallbackDataParams,
@@ -47,76 +41,43 @@ export function getDefaultTooltip(refs: Refs) {
       rect: any,
       sizes: { contentSize: [number, number]; viewSize: [number, number] },
     ) => {
-      // Algorithm partially based on this snippet:
+      // algorithm partially based on this snippet:
       // https://github.com/apache/echarts/issues/5004#issuecomment-559668309
 
+      // The chart canvas position
       const divRect = refs.divRef?.current?.getBoundingClientRect();
+
+      // The mouse coordinates relative to the whole window
+      // The first parameter to the position function is the mouse position relative to the canvas
       const mouseX = canvasMousePos[0] + (divRect?.x || 0);
       const mouseY = canvasMousePos[1] + (divRect?.y || 0);
-      const viewportWidth = document.documentElement.clientWidth;
-      const viewportHeight = document.documentElement.clientHeight;
+
+      // The width and height of the tooltip dom element
       const tooltipWidth = sizes.contentSize[0];
       const tooltipHeight = sizes.contentSize[1];
 
-      // Cap tooltip height to reduce blocking adjacent elements
-      const maxAllowedHeight = Math.min(800, Math.floor(viewportHeight * 0.8));
-      const needsScrolling = tooltipHeight > maxAllowedHeight;
+      // Start by placing the tooltip top and right relative to the mouse position
+      let xPos = mouseX + TOOLTIP_POINTER_MARGIN;
+      let yPos = mouseY - TOOLTIP_POINTER_MARGIN - tooltipHeight;
 
-      if (tooltipDom) {
-        tooltipDom.style.maxHeight = `${maxAllowedHeight}px`;
-        tooltipDom.style.overflow = 'auto';
-        // Only enable pointer events when tooltip is scrollable
-        // This prevents blocking adjacent chart elements when scrolling isn't needed
-        tooltipDom.style.pointerEvents = needsScrolling ? 'auto' : 'none';
-      }
+      // The tooltip is overflowing past the right edge of the window
+      if (xPos + tooltipWidth >= document.documentElement.clientWidth) {
+        // Attempt to place the tooltip to the left of the mouse position
+        xPos = mouseX - TOOLTIP_POINTER_MARGIN - tooltipWidth;
 
-      const effectiveTooltipHeight = Math.min(tooltipHeight, maxAllowedHeight);
-      let xPos: number;
-      let yPos: number;
-
-      // For scrollable tooltips, position further away horizontally to avoid blocking chart navigation
-      const horizontalMargin = needsScrolling
-        ? TOOLTIP_POINTER_MARGIN * 3
-        : TOOLTIP_POINTER_MARGIN;
-
-      // Determine if cursor is in the right half of the chart to intelligently position tooltip
-      const chartWidth = divRect?.width || viewportWidth;
-      const cursorXInChart = canvasMousePos[0];
-      const isInRightHalfOfChart = cursorXInChart > chartWidth / 2;
-
-      // Position tooltip on the left when in right half, right when in left half
-      // This prevents blocking chart navigation
-      if (isInRightHalfOfChart) {
-        xPos = mouseX - horizontalMargin - tooltipWidth;
-
-        // If tooltip would go off left edge of viewport, push it back in
-        if (xPos <= 0) {
+        // The tooltip is overflowing past the left edge of the window
+        if (xPos <= 0)
+          // Place the tooltip a fixed distance from the left edge of the window
           xPos = TOOLTIP_OVERFLOW_MARGIN;
-        }
-      } else {
-        xPos = mouseX + horizontalMargin;
-
-        // If tooltip would go off right edge of viewport, position on left instead
-        if (xPos + tooltipWidth >= viewportWidth) {
-          xPos = mouseX - horizontalMargin - tooltipWidth;
-
-          // If still overflowing left edge, clamp to margin
-          if (xPos <= 0) {
-            xPos = TOOLTIP_OVERFLOW_MARGIN;
-          }
-        }
       }
 
-      // Position tooltip above cursor, or below if no space
-      yPos = mouseY - TOOLTIP_POINTER_MARGIN - effectiveTooltipHeight;
-
       // The tooltip is overflowing past the top edge of the window
       if (yPos <= 0) {
         // Attempt to place the tooltip to the bottom of the mouse position
         yPos = mouseY + TOOLTIP_POINTER_MARGIN;
 
         // The tooltip is overflowing past the bottom edge of the window
-        if (yPos + effectiveTooltipHeight >= viewportHeight)
+        if (yPos + tooltipHeight >= document.documentElement.clientHeight)
           // Place the tooltip a fixed distance from the top edge of the window
           yPos = TOOLTIP_OVERFLOW_MARGIN;
       }

superset-frontend/plugins/plugin-chart-echarts/test/Pie/transformProps.test.ts

@@ -86,49 +86,6 @@ describe('Pie transformProps', () => {
     );
   });
 
-  test('renders every slice when a NULL group value is mixed with named ones', () => {
-    // Regression guard for https://github.com/apache/superset/issues/33174:
-    // a Pie chart whose groupby dimension contains a NULL/empty value alongside
-    // named values reportedly dropped the named slices (or rendered only the
-    // NULL one). This asserts the transform keeps one slice per row, mapping the
-    // NULL group to the `<NULL>` placeholder and preserving every other slice.
-    const nullMixedChartProps = new ChartProps({
-      formData: {
-        colorScheme: 'bnbColors',
-        datasource: '3__table',
-        granularity_sqla: 'ds',
-        metric: 'sum__num',
-        groupby: ['region'],
-        viz_type: 'pie',
-      } as SqlaFormData,
-      width: 800,
-      height: 600,
-      queriesData: [
-        {
-          data: [
-            { region: '국내', sum__num: 817280006121 },
-            { region: '해외', sum__num: 118777753521 },
-            { region: null, sum__num: 20596314924 },
-          ],
-        },
-      ],
-      theme: supersetTheme,
-    });
-
-    const series = (
-      transformProps(nullMixedChartProps as EchartsPieChartProps).echartOptions
-        .series as PieSeriesOption[]
-    )[0];
-    const data = series.data as PieChartDataItem[];
-
-    // every input row must still produce a slice -- none are dropped
-    expect(data).toHaveLength(3);
-    expect(data.map(d => d.name)).toEqual(['국내', '해외', '<NULL>']);
-    expect(data.map(d => d.value)).toEqual([
-      817280006121, 118777753521, 20596314924,
-    ]);
-  });
-
   test('falls back to scroll for plain legends with overlong labels', () => {
     const longLegendChartProps = new ChartProps({
       formData: {

superset-frontend/plugins/plugin-chart-echarts/test/Radar/utils.test.ts

@@ -1,55 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import { getNumberFormatter } from '@superset-ui/core';
-import { renderNormalizedTooltip } from '../../src/Radar/utils';
-
-describe('renderNormalizedTooltip', () => {
-  const mockGetDenormalizedValue = jest.fn((_, value) => Number(value));
-  const metrics = ['metric1', 'metric2'];
-  const params = {
-    color: 'red',
-    name: 'series1',
-    value: [100, 200],
-  };
-  const metricsWithCustomBounds = new Set<string>();
-
-  test('should render tooltip with formatted values when formatter is provided', () => {
-    const formatter = getNumberFormatter(',.2f');
-    const tooltip = renderNormalizedTooltip(
-      params,
-      metrics,
-      mockGetDenormalizedValue,
-      metricsWithCustomBounds,
-      formatter,
-    );
-    expect(tooltip).toContain(formatter(100));
-    expect(tooltip).toContain(formatter(200));
-  });
-
-  test('should render tooltip with raw values when formatter is not provided', () => {
-    const tooltip = renderNormalizedTooltip(
-      params,
-      metrics,
-      mockGetDenormalizedValue,
-      metricsWithCustomBounds,
-    );
-    expect(tooltip).toContain('100');
-    expect(tooltip).toContain('200');
-  });
-});

superset-frontend/plugins/plugin-chart-handlebars/src/components/Handlebars/HandlebarsViewer.tsx

@@ -116,22 +116,3 @@ Handlebars.registerHelper('parseJson', (jsonString: string) => {
 
 Helpers.registerHelpers(Handlebars);
 HandlebarsGroupBy.register(Handlebars);
-
-// `just-handlebars-helpers` registers a `formatDate` helper that lazily
-// resolves `moment` via `global.moment` / `require('moment/min/moment-with-locales')`.
-// The bundled viewer switched to dayjs and never satisfies that lookup, so the
-// original helper throws "... is not a function" (see #32960). Re-register a
-// dayjs-backed `formatDate` with the same `{{formatDate formatString date [locale]}}`
-// signature so existing templates keep rendering.
-Handlebars.registerHelper('formatDate', (formatString, date, localeString) => {
-  const format = typeof formatString === 'string' ? formatString : '';
-  const instance = dayjs(date ?? new Date());
-  // Handlebars always passes its options object as the final argument, so a
-  // locale is only present when the caller supplied an explicit string.
-  // Note: `extendedDayjs` only loads the `en` locale, so passing a non-English
-  // locale here quietly falls back to English unless that locale bundle has
-  // been imported elsewhere; dayjs's instance `.locale()` is a no-op otherwise.
-  return typeof localeString === 'string'
-    ? instance.locale(localeString).format(format)
-    : instance.format(format);
-});

superset-frontend/plugins/plugin-chart-handlebars/test/components/formatDateHelper.test.ts

@@ -1,70 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import Handlebars from 'handlebars';
-
-// Importing the viewer registers the dayjs-backed `formatDate` override (#32960).
-// The end-to-end behavior (the bundling/minification regression) is covered by a
-// Playwright spec; these unit tests guard the helper's edge cases, which run fine
-// under Jest's Node environment without a browser.
-import '../../src/components/Handlebars/HandlebarsViewer';
-
-// Handlebars passes its options object as the trailing argument, so callers that
-// omit the optional locale still get a non-string final arg. Mimic that here.
-const options = {} as unknown as string;
-
-const formatDate = (
-  format: string,
-  date: unknown,
-  locale: string = options,
-): string =>
-  (Handlebars.helpers.formatDate as (...args: unknown[]) => string)(
-    format,
-    date,
-    locale,
-  );
-
-test('formats a valid date string with the supplied format', () => {
-  expect(formatDate('DD.MM.YYYY', '2024-06-14')).toBe('14.06.2024');
-});
-
-test('renders "Invalid date" for an unparseable date string', () => {
-  expect(formatDate('DD.MM.YYYY', 'not-a-date')).toBe('Invalid date');
-});
-
-test('coerces a non-string format to dayjs default output without throwing', () => {
-  // The helper guards against a non-string format by passing '' to dayjs,
-  // which renders its default ISO 8601 representation rather than throwing.
-  expect(() =>
-    formatDate(undefined as unknown as string, '2024-06-14'),
-  ).not.toThrow();
-  expect(formatDate(undefined as unknown as string, '2024-06-14')).toContain(
-    '2024-06-14',
-  );
-});
-
-test('preserves the epoch-0 timestamp instead of falling back to now', () => {
-  // 1970-01-01 in UTC, which is 1969 or 1970 locally depending on tz offset;
-  // the point is it is NOT coerced to the current date.
-  expect(formatDate('YYYY', 0)).toMatch(/^(1969|1970)$/);
-});
-
-test('silently falls back to English for a locale that is not loaded', () => {
-  // extendedDayjs only loads the `en` locale, so a non-English locale no-ops.
-  expect(formatDate('MMMM', '2024-06-14', 'fr')).toBe('June');
-});

superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/utilities.ts

@@ -92,29 +92,6 @@ const numberFormat = function (optsIn?: NumberFormatOptions): Formatter {
   };
 };
 
-/**
- * Safely converts any value to a number for aggregation purposes
- * Handles null/undefined, strings, and non-numeric values
- */
-function toAggregationNumber(value: unknown): number {
-  if (value == null) return 0;
-  if (typeof value === 'number') {
-    return Number.isNaN(value) ? 0 : value;
-  }
-  if (typeof value === 'string') {
-    const num = parseFloat(value.trim());
-    return Number.isNaN(num) ? 0 : num;
-  }
-  return 0;
-}
-
-type DataFunction = (key: string[], context: never[]) => unknown;
-
-interface GroupNode {
-  auto_agg_sum: number;
-  [childKey: string]: GroupNode | number;
-}
-
 const rx = /(\d+)|(\D+)/g;
 const rd = /\d/;
 const rz = /^0/;
@@ -190,125 +167,6 @@ const naturalSort: SortFunction = (as, bs) => {
   return aArr.length - bArr.length;
 };
 
-/**
- * Precomputes aggregate sums for all group levels using safe numeric conversion
- */
-function buildGroupAggregates(
-  keys: string[][],
-  dataFunc: DataFunction,
-): GroupNode {
-  const root: GroupNode = { auto_agg_sum: 0 } as GroupNode;
-
-  const terminalKeys = keys.filter(
-    key =>
-      !keys.some(
-        ancestorKey =>
-          ancestorKey.length > key.length &&
-          key.every((segment, idx) => ancestorKey[idx] === segment),
-      ),
-  );
-  for (const key of terminalKeys) {
-    let current: GroupNode = root;
-
-    for (let i = 0; i < key.length - 1; i += 1) {
-      const segment = key[i];
-
-      if (!current[segment]) {
-        current[segment] = { auto_agg_sum: 0 } as GroupNode;
-      }
-
-      const childNode = current[segment] as GroupNode;
-      childNode.auto_agg_sum += toAggregationNumber(dataFunc(key, []));
-      current = childNode;
-    }
-  }
-
-  return root;
-}
-
-/**
- * Creates a comparator function for hierarchical keys with subtotal awareness
- */
-function createHierarchicalComparator(
-  groups: GroupNode,
-  top: boolean | undefined,
-  asc: boolean,
-  dataFunc: DataFunction,
-): (a: string[], b: string[]) => number {
-  const hierarchyMultiplier = top ? 1 : -1;
-  const valueMultiplier = asc ? 1 : -1;
-
-  return (a: string[], b: string[]) => {
-    const minLen = Math.min(a.length, b.length);
-    let currentGroup: GroupNode = groups;
-    let diffIndex = -1;
-
-    for (let i = 0; i < minLen; i += 1) {
-      if (a[i] !== b[i]) {
-        diffIndex = i;
-        break;
-      }
-      currentGroup = currentGroup[a[i]] as GroupNode;
-    }
-
-    if (diffIndex === -1 && a.length !== b.length) {
-      return (a.length < b.length ? -1 : 1) * hierarchyMultiplier;
-    }
-
-    const isLastLevelComparison =
-      diffIndex === -1 ||
-      (diffIndex === a.length - 1 && diffIndex === b.length - 1);
-
-    if (isLastLevelComparison) {
-      const valA = dataFunc(a, []) as string | number | null;
-      const valB = dataFunc(b, []) as string | number | null;
-
-      const result = naturalSort(valA, valB) * valueMultiplier;
-
-      if (result === 0) {
-        const lastA = a[a.length - 1] ?? '';
-        const lastB = b[b.length - 1] ?? '';
-        return lastA.localeCompare(lastB) * valueMultiplier;
-      }
-      return result;
-    }
-
-    const segmentA = a[diffIndex];
-    const segmentB = b[diffIndex];
-
-    const nodeA = currentGroup[segmentA] as GroupNode | undefined;
-    const nodeB = currentGroup[segmentB] as GroupNode | undefined;
-
-    const sumA = nodeA?.auto_agg_sum ?? 0;
-    const sumB = nodeB?.auto_agg_sum ?? 0;
-
-    if (sumA === sumB) {
-      return segmentA.localeCompare(segmentB) * valueMultiplier;
-    }
-    return (sumA > sumB ? 1 : -1) * valueMultiplier;
-  };
-}
-
-/**
- * @param keys Hierarchical keys to sort ([[row1, row2], [row1, row3], ...])
- * @param dataFunc Function to retrieve aggregate value (may return string/number/null)
- * @param top true = subtotals at top/left, false = subtotals at bottom/right
- * @param asc true = ascending sort, false = descending sort
- *
- * @see https://github.com/apache/superset/issues/20564
- */
-export function groupingValueSort(
-  keys: string[][],
-  dataFunc: DataFunction,
-  top: boolean | undefined,
-  asc: boolean,
-): void {
-  const groups = buildGroupAggregates(keys, dataFunc);
-
-  const comparator = createHierarchicalComparator(groups, top, asc, dataFunc);
-  keys.sort(comparator);
-}
-
 const sortAs = function (order: (string | number)[]): SortFunction {
   const mapping: Record<string | number, number> = {};
 
@@ -1039,8 +897,7 @@ class PivotData {
       this.sorted = true;
       const rows = this.props.rows as string[];
       const cols = this.props.cols as string[];
-      const vr = (r: string[], c: string[]) => this.getAggregator(r, c).value();
-      const vc = (c: string[], r: string[]) => this.getAggregator(r, c).value();
+      const v = (r: string[], c: string[]) => this.getAggregator(r, c).value();
       switch (this.props.rowOrder) {
         case 'key_z_to_a':
           this.rowKeys.sort(
@@ -1048,20 +905,10 @@ class PivotData {
           );
           break;
         case 'value_a_to_z':
-          groupingValueSort(
-            this.rowKeys,
-            vr,
-            this.subtotals.rowPartialOnTop,
-            true,
-          );
+          this.rowKeys.sort((a, b) => naturalSort(v(a, []), v(b, [])));
           break;
         case 'value_z_to_a':
-          groupingValueSort(
-            this.rowKeys,
-            vr,
-            this.subtotals.rowPartialOnTop,
-            false,
-          );
+          this.rowKeys.sort((a, b) => -naturalSort(v(a, []), v(b, [])));
           break;
         default:
           this.rowKeys.sort(this.arrSort(rows, this.subtotals.rowPartialOnTop));
@@ -1073,20 +920,10 @@ class PivotData {
           );
           break;
         case 'value_a_to_z':
-          groupingValueSort(
-            this.colKeys,
-            vc,
-            this.subtotals.colPartialOnTop,
-            true,
-          );
+          this.colKeys.sort((a, b) => naturalSort(v([], a), v([], b)));
           break;
         case 'value_z_to_a':
-          groupingValueSort(
-            this.colKeys,
-            vc,
-            this.subtotals.colPartialOnTop,
-            false,
-          );
+          this.colKeys.sort((a, b) => -naturalSort(v([], a), v([], b)));
           break;
         default:
           this.colKeys.sort(this.arrSort(cols, this.subtotals.colPartialOnTop));

superset-frontend/plugins/plugin-chart-pivot-table/test/react-pivottable/tableRenders.test.tsx

@@ -17,8 +17,6 @@
  * under the License.
  */
 
-import { groupingValueSort } from '../../src/react-pivottable/utilities';
-
 import type { ReactElement } from 'react';
 import '@testing-library/jest-dom';
 import { fireEvent, render, screen } from '@testing-library/react';
@@ -355,197 +353,6 @@ test('TableRenderer coerces numeric timestamp strings to numbers for column head
   expect(screen.getByText('col:square')).toBeInTheDocument();
 });
 
-type TestData = {
-  [key: string]: number | string | null;
-};
-
-const createMockAggregator =
-  (data: TestData) =>
-  (key: string[], _context: never[]): unknown => {
-    const keyStr = key.join('|');
-    return data[keyStr] ?? null;
-  };
-
-test('should sort flat keys in ascending order', () => {
-  const keys: string[][] = [['A'], ['C'], ['B']];
-  const data = {
-    A: 30,
-    B: 10,
-    C: 20,
-  };
-
-  groupingValueSort(keys, createMockAggregator(data), false, true);
-
-  expect(keys).toEqual([['B'], ['C'], ['A']]);
-});
-
-test('should sort flat keys in descending order', () => {
-  const keys: string[][] = [['A'], ['C'], ['B']];
-  const data = {
-    A: 30,
-    B: 10,
-    C: 20,
-  };
-
-  groupingValueSort(keys, createMockAggregator(data), false, false);
-
-  expect(keys).toEqual([['A'], ['C'], ['B']]);
-});
-
-test('should place subtotal at top when top=true and ascending', () => {
-  const keys: string[][] = [
-    ['Region', 'City1'],
-    ['Region'],
-    ['Region', 'City2'],
-  ];
-  const data = {
-    Region: 150,
-    'Region|City1': 100,
-    'Region|City2': 50,
-  };
-
-  groupingValueSort(keys, createMockAggregator(data), true, true);
-
-  expect(keys[0]).toEqual(['Region']);
-  expect(keys[1]).toEqual(['Region', 'City2']);
-  expect(keys[2]).toEqual(['Region', 'City1']);
-});
-
-test('should place subtotal at bottom when top=false and descending', () => {
-  const keys: string[][] = [
-    ['Region', 'City1'],
-    ['Region'],
-    ['Region', 'City2'],
-  ];
-  const data = {
-    'Region|City1': 100,
-    'Region|City2': 50,
-    Region: 150,
-  };
-
-  groupingValueSort(keys, createMockAggregator(data), false, false);
-
-  expect(keys[0]).toEqual(['Region', 'City1']);
-  expect(keys[1]).toEqual(['Region', 'City2']);
-  expect(keys[2]).toEqual(['Region']);
-});
-
-test('should use alphabetical order for terminals with equal values', () => {
-  const keys: string[][] = [
-    ['Group', 'Apple'],
-    ['Group', 'Banana'],
-    ['Group', 'Cherry'],
-  ];
-  const data = {
-    'Group|Apple': 50,
-    'Group|Banana': 50,
-    'Group|Cherry': 50,
-  };
-
-  groupingValueSort(keys, createMockAggregator(data), false, true);
-
-  expect(keys).toEqual([
-    ['Group', 'Apple'],
-    ['Group', 'Banana'],
-    ['Group', 'Cherry'],
-  ]);
-});
-
-test('should handle null values gracefully', () => {
-  const keys: string[][] = [['A'], ['B'], ['C']];
-  const data = {
-    A: 100,
-    B: null,
-    C: 50,
-  };
-
-  groupingValueSort(keys, createMockAggregator(data), false, true);
-  expect(keys).toEqual([['B'], ['C'], ['A']]);
-});
-
-test('should handle string numbers', () => {
-  const keys: string[][] = [['A'], ['B'], ['C']];
-  const data = {
-    A: '100',
-    B: '50',
-    C: '200',
-  };
-
-  groupingValueSort(keys, createMockAggregator(data), false, false);
-  expect(keys).toEqual([['C'], ['A'], ['B']]);
-});
-
-test('should handle NaN values', () => {
-  const keys: string[][] = [['A'], ['B'], ['C']];
-  const data = {
-    A: 100,
-    B: NaN,
-    C: 50,
-  };
-
-  groupingValueSort(keys, createMockAggregator(data), false, true);
-  expect(keys).toEqual([['B'], ['C'], ['A']]);
-});
-
-test('should handle single key', () => {
-  const keys: string[][] = [['OnlyKey']];
-  const data = { OnlyKey: 42 };
-
-  groupingValueSort(keys, createMockAggregator(data), false, true);
-  expect(keys).toEqual([['OnlyKey']]);
-});
-
-test('should handle empty keys array', () => {
-  const keys: string[][] = [];
-  const data = {};
-
-  groupingValueSort(keys, createMockAggregator(data), false, true);
-  expect(keys).toEqual([]);
-});
-
-test('should handle product categories with subcategories', () => {
-  const keys: string[][] = [
-    ['Electronics'],
-    ['Electronics', 'Phones'],
-    ['Electronics', 'Phones', 'iPhone'],
-    ['Electronics', 'Phones', 'Samsung'],
-    ['Electronics', 'Laptops'],
-    ['Electronics', 'Laptops', 'MacBook'],
-    ['Clothing'],
-    ['Clothing', 'Shirts'],
-    ['Clothing', 'Shirts', 'T-Shirt'],
-    ['Clothing', 'Pants'],
-    ['Clothing', 'Pants', 'Jeans'],
-  ];
-  const data = {
-    Electronics: 2100,
-    'Electronics|Phones': 900,
-    'Electronics|Phones|iPhone': 500,
-    'Electronics|Phones|Samsung': 400,
-    'Electronics|Laptops': 1200,
-    'Electronics|Laptops|MacBook': 1200,
-    Clothing: 2550,
-    'Clothing|Shirts': 1400,
-    'Clothing|Shirts|T-Shirt': 1400,
-    'Clothing|Pants': 1150,
-    'Clothing|Pants|Jeans': 1150,
-  };
-
-  groupingValueSort(keys, createMockAggregator(data), true, true);
-
-  expect(keys[0]).toEqual(['Electronics']);
-  expect(keys[1]).toEqual(['Electronics', 'Phones']);
-  expect(keys[2]).toEqual(['Electronics', 'Phones', 'Samsung']);
-  expect(keys[3]).toEqual(['Electronics', 'Phones', 'iPhone']);
-  expect(keys[4]).toEqual(['Electronics', 'Laptops']);
-  expect(keys[5]).toEqual(['Electronics', 'Laptops', 'MacBook']);
-  expect(keys[6]).toEqual(['Clothing']);
-  expect(keys[7]).toEqual(['Clothing', 'Pants']);
-  expect(keys[8]).toEqual(['Clothing', 'Pants', 'Jeans']);
-  expect(keys[9]).toEqual(['Clothing', 'Shirts']);
-  expect(keys[10]).toEqual(['Clothing', 'Shirts', 'T-Shirt']);
-});
-
 test('TableRenderer coerces numeric timestamp strings to numbers for row header date formatters', () => {
   const dateFormatter = jest.fn((val: unknown) => `row:${String(val)}`);
   const data = [

superset-frontend/plugins/plugin-chart-point-cluster-map/src/MapLibre.tsx

@@ -20,10 +20,6 @@ import { memo, useCallback, useEffect, useState } from 'react';
 import { Map as MapLibreMap } from 'react-map-gl/maplibre';
 import { Map as MapboxMap } from 'react-map-gl/mapbox';
 import { WebMercatorViewport } from '@math.gl/web-mercator';
-import {
-  resolveMapStyle,
-  type ResolvedMapStyle,
-} from '@superset-ui/core/utils/mapStyles';
 import { useTheme } from '@apache-superset/core/theme';
 import { t } from '@apache-superset/core/translation';
 import ScatterPlotOverlay from './components/ScatterPlotOverlay';
@@ -164,10 +160,7 @@ function MapLibre({
   const clusters = clusterer.getClusters(bbox, Math.round(viewport.zoom));
 
   const theme = useTheme();
-  const resolvedMapStyle: ResolvedMapStyle =
-    mapProvider === 'mapbox'
-      ? mapStyle || DEFAULT_MAP_STYLE
-      : resolveMapStyle(mapStyle, DEFAULT_MAP_STYLE);
+  const resolvedMapStyle = mapStyle || DEFAULT_MAP_STYLE;
   const mapboxApiKey = mapProvider === 'mapbox' ? getMapboxApiKey() : '';
 
   if (mapProvider === 'mapbox' && !mapboxApiKey) {

superset-frontend/plugins/plugin-chart-point-cluster-map/src/controlPanel.ts

@@ -19,19 +19,11 @@
 import { t } from '@apache-superset/core/translation';
 import {
   columnChoices,
-  ControlPanelState,
   ControlPanelConfig,
   formatSelectOptions,
   sharedControls,
   getStandardizedControls,
 } from '@superset-ui/chart-controls';
-import type { QueryFormData } from '@superset-ui/core';
-import type { MapProvider } from '@superset-ui/core/utils/mapStyles';
-import { getDefaultMapRenderer } from '@superset-ui/core/utils/mapStyles';
-import {
-  getPointClusterMapRendererProps,
-  POINT_CLUSTER_MAPLIBRE_STYLE_CHOICES,
-} from './utils/mapControls';
 
 const columnsConfig = sharedControls.entity;
 
@@ -43,11 +35,6 @@ const colorChoices = [
   ['#dc143c', t('Crimson')],
   ['#228b22', t('Forest Green')],
 ];
-type MapStyleVisibilityProps = {
-  controls?: {
-    map_renderer?: { value?: unknown };
-  };
-};
 
 const config: ControlPanelConfig = {
   controlPanelSections: [
@@ -122,7 +109,7 @@ const config: ControlPanelConfig = {
                   'Either a numerical column or `Auto`, which scales the point based ' +
                   'on the largest cluster',
               ),
-              mapStateToProps: (state: ControlPanelState) => {
+              mapStateToProps: (state: any) => {
                 const datasourceChoices = columnChoices(state.datasource);
                 const choices: [string, string][] = [['Auto', t('Auto')]];
                 return {
@@ -169,7 +156,7 @@ const config: ControlPanelConfig = {
                   'Non-numerical columns will be used to label points. ' +
                   'Leave empty to get a count of points in each cluster.',
               ),
-              mapStateToProps: (state: ControlPanelState) => ({
+              mapStateToProps: (state: any) => ({
                 choices: columnChoices(state.datasource),
               }),
             },
@@ -213,17 +200,14 @@ const config: ControlPanelConfig = {
               label: t('Map Renderer'),
               clearable: false,
               renderTrigger: true,
-              options: getPointClusterMapRendererProps().options,
+              choices: [
+                ['maplibre', t('MapLibre (open-source)')],
+                ['mapbox', t('Mapbox (API key required)')],
+              ],
               default: 'maplibre',
               description: t(
                 'MapLibre is open-source and requires no API key. Mapbox requires MAPBOX_API_KEY to be configured on the server.',
               ),
-              mapStateToProps: (state: ControlPanelState) => ({
-                ...getPointClusterMapRendererProps(
-                  state.form_data?.map_renderer as MapProvider | undefined,
-                ),
-                default: getDefaultMapRenderer(),
-              }),
             },
           },
         ],
@@ -236,13 +220,30 @@ const config: ControlPanelConfig = {
               clearable: false,
               renderTrigger: true,
               freeForm: true,
-              choices: POINT_CLUSTER_MAPLIBRE_STYLE_CHOICES,
+              choices: [
+                [
+                  'https://tiles.openfreemap.org/styles/liberty',
+                  t('Liberty (OpenFreeMap)'),
+                ],
+                [
+                  'https://basemaps.cartocdn.com/gl/positron-gl-style/style.json',
+                  t('Light (Carto)'),
+                ],
+                [
+                  'https://basemaps.cartocdn.com/gl/dark-matter-gl-style/style.json',
+                  t('Dark (Carto)'),
+                ],
+                [
+                  'https://basemaps.cartocdn.com/gl/voyager-gl-style/style.json',
+                  t('Streets (Carto)'),
+                ],
+              ],
               default: 'https://tiles.openfreemap.org/styles/liberty',
               description: t(
                 'Base layer map style. See MapLibre documentation: %s',
                 'https://maplibre.org/maplibre-style-spec/',
               ),
-              visibility: ({ controls }: MapStyleVisibilityProps) =>
+              visibility: ({ controls }: any) =>
                 controls?.map_renderer?.value !== 'mapbox',
             },
           },
@@ -271,7 +272,7 @@ const config: ControlPanelConfig = {
               description: t(
                 'Base layer map style. Accepts a Mapbox style URL (mapbox://styles/...).',
               ),
-              visibility: ({ controls }: MapStyleVisibilityProps) =>
+              visibility: ({ controls }: any) =>
                 controls?.map_renderer?.value === 'mapbox',
             },
           },
@@ -386,7 +387,7 @@ const config: ControlPanelConfig = {
       ),
     },
   },
-  formDataOverrides: (formData: QueryFormData) => ({
+  formDataOverrides: (formData: any) => ({
     ...formData,
     groupby: getStandardizedControls().popAllColumns(),
   }),

superset-frontend/plugins/plugin-chart-point-cluster-map/src/transformProps.ts

@@ -19,7 +19,7 @@
 import Supercluster, {
   type Options as SuperclusterOptions,
 } from 'supercluster';
-import { ChartProps, getMapProviderMapStyle } from '@superset-ui/core';
+import { ChartProps } from '@superset-ui/core';
 import { t } from '@apache-superset/core/translation';
 import { DEFAULT_POINT_RADIUS, DEFAULT_MAX_ZOOM } from './MapLibre';
 import roundDecimal from './utils/roundDecimal';
@@ -152,7 +152,6 @@ export default function transformProps(chartProps: ChartProps) {
     map_renderer: mapProvider,
     maplibre_style: maplibreStyle,
     mapbox_style: mapboxStyle = '',
-    map_style: legacyMapStyle,
     pandas_aggfunc: pandasAggfunc,
     point_radius: pointRadius,
     point_radius_unit: pointRadiusUnit,
@@ -243,12 +242,6 @@ export default function transformProps(chartProps: ChartProps) {
   const clusterer = new Supercluster<PointProperties, ClusterProperties>(opts);
   // Disable strict typecheck on load since Supercluster typings have namespace issues with esModuleInterop
   clusterer.load(geoJSON.features as any);
-  const selectedMap = getMapProviderMapStyle({
-    mapProvider,
-    maplibreStyle,
-    mapboxStyle,
-    legacyMapStyle,
-  });
 
   return {
     width,
@@ -258,8 +251,11 @@ export default function transformProps(chartProps: ChartProps) {
     clusterer,
     globalOpacity: Math.min(1, Math.max(0, toFiniteNumber(globalOpacity) ?? 1)),
     hasCustomMetric,
-    mapProvider: selectedMap.mapProvider,
-    mapStyle: selectedMap.mapStyle,
+    mapProvider,
+    mapStyle:
+      mapProvider === 'mapbox'
+        ? (mapboxStyle as string)
+        : (maplibreStyle as string),
     onViewportChange({
       latitude,
       longitude,

superset-frontend/plugins/plugin-chart-point-cluster-map/src/utils/mapControls.ts

@@ -1,60 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { t } from '@apache-superset/core/translation';
-import {
-  getMapRendererOptions,
-  OSM_TILE_STYLE_URL,
-  type MapRendererOption,
-  type MapProvider,
-} from '@superset-ui/core/utils/mapStyles';
-import { hasMapboxApiKey } from './mapbox';
-
-export const POINT_CLUSTER_MAPLIBRE_STYLE_CHOICES = [
-  ['https://tiles.openfreemap.org/styles/liberty', t('Liberty (OpenFreeMap)')],
-  [
-    'https://basemaps.cartocdn.com/gl/positron-gl-style/style.json',
-    t('Light (Carto)'),
-  ],
-  [
-    'https://basemaps.cartocdn.com/gl/dark-matter-gl-style/style.json',
-    t('Dark (Carto)'),
-  ],
-  [
-    'https://basemaps.cartocdn.com/gl/voyager-gl-style/style.json',
-    t('Streets (Carto)'),
-  ],
-  [OSM_TILE_STYLE_URL, t('Streets (OSM)')],
-];
-
-export function getPointClusterMapRendererProps(currentValue?: MapProvider) {
-  const hasKey = hasMapboxApiKey();
-  return {
-    options: getMapRendererOptions({
-      hasMapboxKey: hasKey,
-      currentValue,
-    }).map((option: MapRendererOption) => ({
-      ...option,
-      label:
-        option.value === 'maplibre'
-          ? t('MapLibre (open-source)')
-          : t('Mapbox (API key required)'),
-    })),
-  };
-}

superset-frontend/plugins/plugin-chart-point-cluster-map/src/utils/mapbox.ts

@@ -17,15 +17,19 @@
  * under the License.
  */
 
-import {
-  getMapboxApiKeyFromBootstrap,
-  hasMapboxApiKey as hasBootstrapMapboxApiKey,
-} from '@superset-ui/core/utils/mapStyles';
-
 export function getMapboxApiKey(): string {
-  return getMapboxApiKeyFromBootstrap();
-}
-
-export function hasMapboxApiKey(): boolean {
-  return hasBootstrapMapboxApiKey();
+  if (typeof document === 'undefined') {
+    return '';
+  }
+  try {
+    const appContainer = document.getElementById('app');
+    const dataBootstrap = appContainer?.getAttribute('data-bootstrap');
+    if (dataBootstrap) {
+      const bootstrapData = JSON.parse(dataBootstrap);
+      return bootstrapData?.common?.conf?.MAPBOX_API_KEY || '';
+    }
+  } catch {
+    // If bootstrap data is unavailable or malformed, return empty string
+  }
+  return '';
 }

superset-frontend/plugins/plugin-chart-point-cluster-map/test/MapLibre.test.tsx

@@ -18,12 +18,7 @@
  */
 
 import { type ReactNode } from 'react';
-import { render, screen } from '@testing-library/react';
-import '@testing-library/jest-dom';
-import {
-  OSM_TILE_ATTRIBUTION,
-  OSM_TILE_STYLE_URL,
-} from '@superset-ui/core/utils/mapStyles';
+import { render } from '@testing-library/react';
 
 // Capture the most recent viewport props passed to the Map component
 let lastMapProps: Record<string, unknown> = {};
@@ -96,7 +91,6 @@ const defaultProps = {
 
 beforeEach(() => {
   lastMapProps = {};
-  document.body.innerHTML = '';
   jest.clearAllMocks();
   mockFitBounds.mockImplementation(
     (
@@ -189,65 +183,6 @@ test('passes globalOpacity to ScatterPlotOverlay', () => {
   expect(overlay!.getAttribute('data-opacity')).toBe('0.5');
 });
 
-test('converts OSM raster tile templates into MapLibre style objects', () => {
-  render(<MapLibre {...defaultProps} mapStyle={OSM_TILE_STYLE_URL} />);
-
-  expect(lastMapProps.mapStyle).toEqual({
-    version: 8,
-    sources: {
-      'osm-raster-tiles': {
-        type: 'raster',
-        tiles: [OSM_TILE_STYLE_URL],
-        tileSize: 256,
-        attribution: OSM_TILE_ATTRIBUTION,
-      },
-    },
-    layers: [
-      {
-        id: 'osm-raster-layer',
-        type: 'raster',
-        source: 'osm-raster-tiles',
-        minzoom: 0,
-        maxzoom: 22,
-      },
-    ],
-  });
-});
-
-test('keeps the missing Mapbox key signal for saved Mapbox charts', () => {
-  render(
-    <MapLibre
-      {...defaultProps}
-      mapProvider="mapbox"
-      mapStyle="mapbox://styles/mapbox/dark-v11"
-    />,
-  );
-
-  expect(
-    screen.getByText(
-      'Mapbox requires a MAPBOX_API_KEY to be configured on the server.',
-    ),
-  ).toBeInTheDocument();
-  expect(lastMapProps.mapStyle).toBeUndefined();
-});
-
-test('passes Mapbox styles through when a key exists', () => {
-  document.body.innerHTML = `<div id="app" data-bootstrap='${JSON.stringify({
-    common: { conf: { MAPBOX_API_KEY: 'pk.test' } },
-  })}'></div>`;
-
-  render(
-    <MapLibre
-      {...defaultProps}
-      mapProvider="mapbox"
-      mapStyle="mapbox://styles/mapbox/dark-v11"
-    />,
-  );
-
-  expect(lastMapProps.mapStyle).toBe('mapbox://styles/mapbox/dark-v11');
-  expect(lastMapProps.mapboxAccessToken).toBe('pk.test');
-});
-
 test('handles undefined bounds gracefully', () => {
   render(<MapLibre {...defaultProps} bounds={undefined} />);
   expect(lastMapProps.longitude).toBe(0);

superset-frontend/plugins/plugin-chart-point-cluster-map/test/controlPanel.test.ts

@@ -17,11 +17,9 @@
  * under the License.
  */
 import type {
-  ControlPanelState,
   ControlPanelConfig,
   CustomControlItem,
 } from '@superset-ui/chart-controls';
-import { OSM_TILE_STYLE_URL } from '@superset-ui/core/utils/mapStyles';
 import controlPanel from '../src/controlPanel';
 
 type ControlConfig = Required<CustomControlItem['config']>;
@@ -56,27 +54,6 @@ function getControl(
   return item;
 }
 
-type RendererControlConfig = ControlConfig & {
-  mapStateToProps: (state: ControlPanelState) => {
-    options?: unknown;
-    warning?: string;
-    default?: unknown;
-  };
-};
-
-const setBootstrap = (conf: Record<string, unknown>) => {
-  document.body.innerHTML = `<div id="app" data-bootstrap='${JSON.stringify({
-    common: { conf },
-  })}'></div>`;
-};
-
-const getMapRendererProps = (value?: string) =>
-  (
-    getControl(controlPanel, 'map_renderer').config as RendererControlConfig
-  ).mapStateToProps({
-    form_data: { map_renderer: value },
-  } as unknown as ControlPanelState);
-
 test('viewport controls default to empty values and rerender without query refresh', () => {
   const longitudeControl = getControl(controlPanel, 'viewport_longitude');
   const latitudeControl = getControl(controlPanel, 'viewport_latitude');
@@ -102,63 +79,3 @@ test('opacity control rerenders immediately when changed', () => {
   expect(opacityControl.config.renderTrigger).toBe(true);
   expect(opacityControl.config.isFloat).toBe(true);
 });
-
-test('MapLibre style choices expose Streets (OSM)', () => {
-  expect(
-    getControl(controlPanel, 'maplibre_style').config.choices,
-  ).toContainEqual([OSM_TILE_STYLE_URL, 'Streets (OSM)']);
-});
-
-test('map renderer hides Mapbox when no key exists for new selections', () => {
-  setBootstrap({});
-
-  const props = getMapRendererProps('maplibre');
-
-  expect(props.options).toEqual([
-    { value: 'maplibre', label: 'MapLibre (open-source)' },
-  ]);
-});
-
-test('map renderer keeps saved Mapbox visible while disabled without a key', () => {
-  setBootstrap({});
-
-  const props = getMapRendererProps('mapbox');
-
-  expect(props.options).toContainEqual({
-    value: 'mapbox',
-    label: 'Mapbox (API key required)',
-    disabled: true,
-  });
-});
-
-test('map renderer enables Mapbox when a key exists', () => {
-  setBootstrap({ MAPBOX_API_KEY: 'pk.test' });
-
-  const props = getMapRendererProps('maplibre');
-
-  expect(props.options).toEqual([
-    { value: 'maplibre', label: 'MapLibre (open-source)' },
-    { value: 'mapbox', label: 'Mapbox (API key required)' },
-  ]);
-});
-
-test('map renderer keeps the original explanatory description', () => {
-  expect(getControl(controlPanel, 'map_renderer').config.description).toBe(
-    'MapLibre is open-source and requires no API key. Mapbox requires MAPBOX_API_KEY to be configured on the server.',
-  );
-});
-
-test('map renderer defaults to configured Mapbox when a key exists', () => {
-  setBootstrap({
-    DEFAULT_MAP_RENDERER: 'mapbox',
-    MAPBOX_API_KEY: 'pk.test',
-  });
-
-  expect(getMapRendererProps('maplibre').default).toBe('mapbox');
-});
-
-test('map renderer falls back from configured Mapbox default without a key', () => {
-  setBootstrap({ DEFAULT_MAP_RENDERER: 'mapbox' });
-
-  expect(getMapRendererProps('maplibre').default).toBe('maplibre');
-});

superset-frontend/plugins/plugin-chart-point-cluster-map/test/transformProps.test.ts

@@ -34,8 +34,6 @@ import transformProps from '../src/transformProps';
 
 type TransformPropsResult = {
   globalOpacity?: number;
-  mapProvider?: string;
-  mapStyle?: string;
   onViewportChange?: (viewport: {
     latitude: number;
     longitude: number;
@@ -217,41 +215,6 @@ test('passes through numeric values unchanged', () => {
   expect(result.globalOpacity).toBe(0.8);
 });
 
-test('uses the MapLibre style when maplibre renderer is selected', () => {
-  const result = getTransformPropsResult({
-    map_renderer: 'maplibre',
-    maplibre_style: 'https://example.com/maplibre-style.json',
-    mapbox_style: 'mapbox://styles/mapbox/dark-v11',
-  });
-
-  expect(result.mapProvider).toBe('maplibre');
-  expect(result.mapStyle).toBe('https://example.com/maplibre-style.json');
-});
-
-test('uses legacy non-Mapbox style for MapLibre when provider style is absent', () => {
-  const result = getTransformPropsResult({
-    map_renderer: 'maplibre',
-    maplibre_style: undefined,
-    mapbox_style: 'https://tile.openstreetmap.org/{z}/{x}/{y}.png',
-  });
-
-  expect(result.mapProvider).toBe('maplibre');
-  expect(result.mapStyle).toBe(
-    'https://tile.openstreetmap.org/{z}/{x}/{y}.png',
-  );
-});
-
-test('uses the Mapbox style when mapbox renderer is selected', () => {
-  const result = getTransformPropsResult({
-    map_renderer: 'mapbox',
-    maplibre_style: 'https://example.com/maplibre-style.json',
-    mapbox_style: 'mapbox://styles/mapbox/dark-v11',
-  });
-
-  expect(result.mapProvider).toBe('mapbox');
-  expect(result.mapStyle).toBe('mapbox://styles/mapbox/dark-v11');
-});
-
 test('calls onError and falls back to black for invalid color', () => {
   const onError = jest.fn();
   const chartProps = new ChartProps({

superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx

@@ -1371,12 +1371,7 @@ export default function TableChart<D extends DataRecord = DataRecord>(
           )
         ) : undefined,
         sortDescFirst: sortDesc,
-        // Metrics and percent metrics always have numeric values; use numeric sort
-        // even if the backend reports the column type as String.
-        sortType:
-          isMetric || isPercentMetric
-            ? 'basic'
-            : getSortTypeByDataType(dataType),
+        sortType: getSortTypeByDataType(dataType),
       };
     },
     [

superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx

@@ -2457,80 +2457,3 @@ describe('Drill-to-Detail Temporal Range Logic', () => {
     expect(filter.val).toBeNull();
   });
 });
-
-// Numeric values with String dataType (e.g. backend mis-reports type for computed columns)
-// get 'alphanumeric' sort, which treats raw numbers as non-strings and produces unstable order.
-// They should sort numerically regardless of display format.
-test('sorts numeric-backed percentage column numerically when dataType is String', async () => {
-  const props = transformProps({
-    ...testData.raw,
-    rawFormData: {
-      ...testData.raw.rawFormData,
-      order_desc: false,
-      metrics: ['pct'],
-      column_config: {
-        pct: { d3NumberFormat: '.1%' },
-      },
-    },
-    queriesData: [
-      {
-        ...testData.raw.queriesData[0],
-        colnames: ['pct'],
-        coltypes: [GenericDataType.String],
-        data: [
-          { pct: 0.4 },
-          { pct: 0.056 },
-          { pct: 0.506 },
-          { pct: 0.066 },
-          { pct: 0.41 },
-        ],
-      },
-    ],
-  });
-
-  render(
-    ProviderWrapper({
-      children: <TableChart {...props} sticky={false} />,
-    }),
-  );
-
-  const header = screen.getByText('pct');
-  fireEvent.click(header);
-
-  const cells = document.querySelectorAll('tbody td');
-  const values = Array.from(cells).map(td => td.textContent);
-  expect(values).toEqual(['5.6%', '6.6%', '40.0%', '41.0%', '50.6%']);
-});
-
-test('sorts genuinely string columns alphanumerically', () => {
-  const props = transformProps({
-    ...testData.raw,
-    rawFormData: {
-      ...testData.raw.rawFormData,
-      order_desc: false,
-      metrics: [],
-      columns: ['label'],
-    },
-    queriesData: [
-      {
-        ...testData.raw.queriesData[0],
-        colnames: ['label'],
-        coltypes: [GenericDataType.String],
-        data: [{ label: 'banana' }, { label: 'apple' }, { label: 'cherry' }],
-      },
-    ],
-  });
-
-  render(
-    ProviderWrapper({
-      children: <TableChart {...props} sticky={false} />,
-    }),
-  );
-
-  const header = screen.getByText('label');
-  fireEvent.click(header);
-
-  const cells = document.querySelectorAll('tbody td');
-  const values = Array.from(cells).map(td => td.textContent);
-  expect(values).toEqual(['apple', 'banana', 'cherry']);
-});

superset-frontend/plugins/preset-chart-deckgl/src/CategoricalDeckGLContainer.tsx

@@ -34,7 +34,6 @@ import {
   JsonValue,
   QueryFormData,
   SetDataMaskHook,
-  getMapProviderMapStyle,
 } from '@superset-ui/core';
 import type { Layer } from '@deck.gl/core';
 import Legend from './components/Legend';
@@ -319,12 +318,6 @@ const CategoricalDeckGLContainer = (props: CategoricalDeckGLContainerProps) => {
     },
     [categories],
   );
-  const selectedMap = getMapProviderMapStyle({
-    mapProvider: props.formData.map_renderer,
-    maplibreStyle: props.formData.maplibre_style,
-    mapboxStyle: props.formData.mapbox_style,
-    legacyMapStyle: props.formData.map_style,
-  });
 
   return (
     <div style={{ position: 'relative' }}>
@@ -333,8 +326,14 @@ const CategoricalDeckGLContainer = (props: CategoricalDeckGLContainerProps) => {
         viewport={viewport}
         layers={getLayers()}
         setControlValue={props.setControlValue}
-        mapStyle={selectedMap.mapStyle}
-        mapProvider={selectedMap.mapProvider}
+        mapStyle={
+          props.formData.map_renderer === 'mapbox'
+            ? props.formData.mapbox_style
+            : props.formData.maplibre_style
+        }
+        mapProvider={
+          props.formData.map_renderer === 'mapbox' ? 'mapbox' : 'maplibre'
+        }
         mapboxApiKey={getMapboxApiKey()}
         width={props.width}
         height={props.height}

superset-frontend/plugins/preset-chart-deckgl/src/DeckGLContainer.test.tsx

@@ -1,240 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { ComponentProps, createRef, ReactNode } from 'react';
-import { act, fireEvent, render, screen } from '@testing-library/react';
-import '@testing-library/jest-dom';
-import type { Layer } from '@deck.gl/core';
-import { supersetTheme, ThemeProvider } from '@apache-superset/core/theme';
-import {
-  OSM_TILE_ATTRIBUTION,
-  OSM_TILE_STYLE_URL,
-} from '@superset-ui/core/utils/mapStyles';
-import mapboxgl from 'mapbox-gl';
-import { DeckGLContainer, DeckGLContainerHandle } from './DeckGLContainer';
-
-jest.mock('react-map-gl/maplibre', () => ({
-  Map: ({
-    children,
-    mapStyle,
-    onMove,
-  }: {
-    children: ReactNode;
-    mapStyle: unknown;
-    onMove: (evt: { viewState: Record<string, number> }) => void;
-  }) => (
-    <div data-test="maplibre-map" data-map-style={JSON.stringify(mapStyle)}>
-      <button
-        type="button"
-        data-test="maplibre-move"
-        onClick={() =>
-          onMove({ viewState: { longitude: 1, latitude: 2, zoom: 3 } })
-        }
-      />
-      {children}
-    </div>
-  ),
-}));
-
-jest.mock('react-map-gl/mapbox', () => ({
-  Map: ({ children, mapStyle }: { children: ReactNode; mapStyle: unknown }) => (
-    <div data-test="mapbox-map" data-map-style={JSON.stringify(mapStyle)}>
-      {children}
-    </div>
-  ),
-}));
-
-jest.mock('mapbox-gl', () => ({ accessToken: '' }));
-
-jest.mock(
-  './components/DeckGLOverlayMapLibre',
-  () =>
-    ({ layers }: { layers: unknown[] }) => (
-      <div data-test="maplibre-overlay" data-layers-count={layers.length} />
-    ),
-);
-
-jest.mock(
-  './components/DeckGLOverlayMapbox',
-  () =>
-    ({ layers }: { layers: unknown[] }) => (
-      <div data-test="mapbox-overlay" data-layers-count={layers.length} />
-    ),
-);
-
-jest.mock('./components/Tooltip', () => ({
-  __esModule: true,
-  default: ({ variant = 'default' }: { variant?: 'default' | 'custom' }) => (
-    <div data-test={`tooltip-${variant}`} />
-  ),
-}));
-
-const baseProps = {
-  viewport: { longitude: 0, latitude: 0, zoom: 1, bearing: 0, pitch: 0 },
-  width: 800,
-  height: 600,
-  layers: [],
-};
-
-const renderContainer = (
-  props: Partial<ComponentProps<typeof DeckGLContainer>>,
-) =>
-  render(
-    <ThemeProvider theme={supersetTheme}>
-      <DeckGLContainer {...baseProps} {...props} />
-    </ThemeProvider>,
-  );
-
-afterEach(() => {
-  jest.useRealTimers();
-  jest.clearAllMocks();
-});
-
-test('DeckGLContainer converts OSM raster tile templates into MapLibre style objects', () => {
-  renderContainer({ mapProvider: 'maplibre', mapStyle: OSM_TILE_STYLE_URL });
-
-  const style = JSON.parse(
-    screen.getByTestId('maplibre-map').getAttribute('data-map-style') || '{}',
-  );
-
-  expect(style.sources['osm-raster-tiles']).toEqual({
-    type: 'raster',
-    tiles: [OSM_TILE_STYLE_URL],
-    tileSize: 256,
-    attribution: OSM_TILE_ATTRIBUTION,
-  });
-  expect(style.layers[0]).toMatchObject({
-    id: 'osm-raster-layer',
-    type: 'raster',
-    source: 'osm-raster-tiles',
-  });
-});
-
-test('DeckGLContainer passes style JSON URLs through to MapLibre', () => {
-  const styleUrl = 'https://example.com/styles/custom-style.json';
-
-  renderContainer({ mapProvider: 'maplibre', mapStyle: styleUrl });
-
-  expect(screen.getByTestId('maplibre-map')).toHaveAttribute(
-    'data-map-style',
-    JSON.stringify(styleUrl),
-  );
-});
-
-test('DeckGLContainer keeps the missing Mapbox key signal for saved Mapbox charts', () => {
-  renderContainer({
-    mapProvider: 'mapbox',
-    mapStyle: 'mapbox://styles/mapbox/dark-v9',
-    mapboxApiKey: '',
-  });
-
-  expect(
-    screen.getByText(
-      'Mapbox requires a MAPBOX_API_KEY to be configured on the server.',
-    ),
-  ).toBeInTheDocument();
-  expect(screen.queryByTestId('maplibre-map')).not.toBeInTheDocument();
-  expect(screen.queryByTestId('mapbox-map')).not.toBeInTheDocument();
-});
-
-test('DeckGLContainer passes Mapbox styles through when a key exists', () => {
-  renderContainer({
-    mapProvider: 'mapbox',
-    mapStyle: 'mapbox://styles/mapbox/dark-v9',
-    mapboxApiKey: 'pk.test',
-  });
-
-  expect(mapboxgl.accessToken).toBe('pk.test');
-  expect(screen.getByTestId('mapbox-map')).toHaveAttribute(
-    'data-map-style',
-    JSON.stringify('mapbox://styles/mapbox/dark-v9'),
-  );
-});
-
-test('DeckGLContainer supports layer factories for MapLibre overlays', () => {
-  const layer = { id: 'layer-1' } as unknown as Layer;
-  const layerFactory = () => layer;
-
-  renderContainer({ mapProvider: 'maplibre', layers: [layerFactory] });
-
-  expect(screen.getByTestId('maplibre-overlay')).toHaveAttribute(
-    'data-layers-count',
-    '1',
-  );
-});
-
-test('DeckGLContainer updates viewport controls after map movement is throttled', () => {
-  jest.useFakeTimers();
-  jest.setSystemTime(1000);
-  const setControlValue = jest.fn();
-
-  renderContainer({ mapProvider: 'maplibre', setControlValue });
-  fireEvent.click(screen.getByTestId('maplibre-move'));
-
-  jest.setSystemTime(1301);
-  act(() => {
-    jest.advanceTimersByTime(250);
-  });
-
-  expect(setControlValue).toHaveBeenCalledWith('viewport', {
-    longitude: 1,
-    latitude: 2,
-    zoom: 3,
-  });
-});
-
-test('DeckGLContainer suppresses the native context menu', () => {
-  renderContainer({ mapProvider: 'maplibre' });
-
-  const event = new MouseEvent('contextmenu', {
-    bubbles: true,
-    cancelable: true,
-  });
-  const preventDefaultSpy = jest.spyOn(event, 'preventDefault');
-  const stopPropagationSpy = jest.spyOn(event, 'stopPropagation');
-
-  screen.getByTestId('maplibre-map').parentElement?.dispatchEvent(event);
-
-  expect(preventDefaultSpy).toHaveBeenCalled();
-  expect(stopPropagationSpy).toHaveBeenCalled();
-});
-
-test('DeckGLContainer renders default and custom tooltip variants through its ref', () => {
-  const ref = createRef<DeckGLContainerHandle>();
-
-  render(
-    <ThemeProvider theme={supersetTheme}>
-      <DeckGLContainer {...baseProps} mapProvider="maplibre" ref={ref} />
-    </ThemeProvider>,
-  );
-
-  act(() => {
-    ref.current?.setTooltip({ x: 0, y: 0, content: 'Default tooltip' });
-  });
-  expect(screen.getByTestId('tooltip-default')).toBeInTheDocument();
-
-  act(() => {
-    ref.current?.setTooltip({
-      x: 0,
-      y: 0,
-      content: <span data-tooltip-type="custom">Custom tooltip</span>,
-    });
-  });
-  expect(screen.getByTestId('tooltip-custom')).toBeInTheDocument();
-});

superset-frontend/plugins/preset-chart-deckgl/src/DeckGLContainer.tsx

@@ -33,11 +33,6 @@ import { Map as MapboxMap } from 'react-map-gl/mapbox';
 import mapboxgl from 'mapbox-gl';
 import type { Layer } from '@deck.gl/core';
 import { JsonObject, JsonValue, usePrevious } from '@superset-ui/core';
-import {
-  resolveMapStyle,
-  type MapProvider,
-  type ResolvedMapStyle,
-} from '@superset-ui/core/utils/mapStyles';
 import { styled, useTheme } from '@apache-superset/core/theme';
 import { t } from '@apache-superset/core/translation';
 import DeckGLOverlayMapLibre from './components/DeckGLOverlayMapLibre';
@@ -55,7 +50,7 @@ export type DeckGLContainerProps = {
   viewport: Viewport;
   setControlValue?: (control: string, value: JsonValue) => void;
   mapStyle?: string;
-  mapProvider?: MapProvider;
+  mapProvider?: 'maplibre' | 'mapbox';
   mapboxApiKey?: string;
   children?: ReactNode;
   width: number;
@@ -128,9 +123,7 @@ export const DeckGLContainer = memo(
     const theme = useTheme();
     const { children = null, height, width } = props;
     const isMapbox = props.mapProvider === 'mapbox';
-    const mapStyle: ResolvedMapStyle = isMapbox
-      ? props.mapStyle || DEFAULT_MAP_STYLE
-      : resolveMapStyle(props.mapStyle, DEFAULT_MAP_STYLE);
+    const mapStyle = props.mapStyle || DEFAULT_MAP_STYLE;
 
     if (isMapbox && !props.mapboxApiKey) {
       return (

superset-frontend/plugins/preset-chart-deckgl/src/Multi/Multi.tsx

@@ -38,7 +38,6 @@ import {
   QueryFormData,
   QueryObjectFilterClause,
   SupersetClient,
-  getMapProviderMapStyle,
   usePrevious,
 } from '@superset-ui/core';
 import { styled } from '@apache-superset/core/theme';
@@ -398,12 +397,6 @@ const DeckMulti = (props: DeckMultiProps) => {
         .filter(layer => layer !== undefined),
     [layerOrder, subSlicesLayers],
   );
-  const selectedMap = getMapProviderMapStyle({
-    mapProvider: formData.map_renderer,
-    maplibreStyle: formData.maplibre_style,
-    mapboxStyle: formData.mapbox_style,
-    legacyMapStyle: formData.map_style,
-  });
 
   return (
     <MultiWrapper height={height} width={width}>
@@ -411,8 +404,12 @@ const DeckMulti = (props: DeckMultiProps) => {
         ref={containerRef}
         viewport={viewport}
         layers={layers}
-        mapStyle={selectedMap.mapStyle}
-        mapProvider={selectedMap.mapProvider}
+        mapStyle={
+          formData.map_renderer === 'mapbox'
+            ? formData.mapbox_style
+            : formData.maplibre_style
+        }
+        mapProvider={formData.map_renderer === 'mapbox' ? 'mapbox' : 'maplibre'}
         mapboxApiKey={getMapboxApiKey()}
         setControlValue={setControlValue}
         onViewportChange={setViewport}

superset-frontend/plugins/preset-chart-deckgl/src/factory.tsx

@@ -31,7 +31,6 @@ import {
   FilterState,
   JsonValue,
   ContextMenuFilters,
-  getMapProviderMapStyle,
 } from '@superset-ui/core';
 
 import {
@@ -185,12 +184,6 @@ export function createDeckGLComponent(
     }, [computeLayers, prevFormData, prevFilterState, prevPayload, props]);
 
     const { formData, setControlValue, height, width } = props;
-    const selectedMap = getMapProviderMapStyle({
-      mapProvider: formData.map_renderer,
-      maplibreStyle: formData.maplibre_style,
-      mapboxStyle: formData.mapbox_style,
-      legacyMapStyle: formData.map_style,
-    });
 
     return (
       <div style={{ position: 'relative' }}>
@@ -198,8 +191,14 @@ export function createDeckGLComponent(
           ref={containerRef}
           viewport={viewport}
           layers={layers}
-          mapStyle={selectedMap.mapStyle}
-          mapProvider={selectedMap.mapProvider}
+          mapStyle={
+            formData.map_renderer === 'mapbox'
+              ? formData.mapbox_style
+              : formData.maplibre_style
+          }
+          mapProvider={
+            formData.map_renderer === 'mapbox' ? 'mapbox' : 'maplibre'
+          }
           mapboxApiKey={getMapboxApiKey()}
           setControlValue={setControlValue}
           width={width}

superset-frontend/plugins/preset-chart-deckgl/src/layers/Geojson/Geojson.test.ts

@@ -0,0 +1,122 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { SqlaFormData } from '@superset-ui/core';
+import {
+  computeGeoJsonTextOptionsFromJsOutput,
+  computeGeoJsonTextOptionsFromFormData,
+  computeGeoJsonIconOptionsFromJsOutput,
+  computeGeoJsonIconOptionsFromFormData,
+} from './Geojson';
+
+jest.mock('react-map-gl/maplibre', () => ({
+  __esModule: true,
+  Map: () => null,
+  useControl: () => null,
+}));
+
+test('computeGeoJsonTextOptionsFromJsOutput returns an empty object for non-object input', () => {
+  expect(computeGeoJsonTextOptionsFromJsOutput(null)).toEqual({});
+  expect(computeGeoJsonTextOptionsFromJsOutput(42)).toEqual({});
+  expect(computeGeoJsonTextOptionsFromJsOutput([1, 2, 3])).toEqual({});
+  expect(computeGeoJsonTextOptionsFromJsOutput('string')).toEqual({});
+});
+
+test('computeGeoJsonTextOptionsFromJsOutput extracts valid text options from the input object', () => {
+  const input = {
+    getText: 'name',
+    getTextColor: [1, 2, 3, 255],
+    invalidOption: true,
+  };
+  const expectedOutput = {
+    getText: 'name',
+    getTextColor: [1, 2, 3, 255],
+  };
+  expect(computeGeoJsonTextOptionsFromJsOutput(input)).toEqual(expectedOutput);
+});
+
+test('computeGeoJsonTextOptionsFromFormData computes text options based on form data', () => {
+  const formData: SqlaFormData = {
+    label_property_name: 'name',
+    label_color: { r: 1, g: 2, b: 3, a: 1 },
+    label_size: 123,
+    label_size_unit: 'pixels',
+    datasource: 'test_datasource',
+    viz_type: 'deck_geojson',
+  };
+
+  const expectedOutput = {
+    getText: expect.any(Function),
+    getTextColor: [1, 2, 3, 255],
+    getTextSize: 123,
+    textSizeUnits: 'pixels',
+  };
+
+  const actualOutput = computeGeoJsonTextOptionsFromFormData(formData);
+  expect(actualOutput).toEqual(expectedOutput);
+
+  const sampleFeature = { properties: { name: 'Test' } };
+  expect(actualOutput.getText(sampleFeature)).toBe('Test');
+});
+
+test('computeGeoJsonIconOptionsFromJsOutput returns an empty object for non-object input', () => {
+  expect(computeGeoJsonIconOptionsFromJsOutput(null)).toEqual({});
+  expect(computeGeoJsonIconOptionsFromJsOutput(42)).toEqual({});
+  expect(computeGeoJsonIconOptionsFromJsOutput([1, 2, 3])).toEqual({});
+  expect(computeGeoJsonIconOptionsFromJsOutput('string')).toEqual({});
+});
+
+test('computeGeoJsonIconOptionsFromJsOutput extracts valid icon options from the input object', () => {
+  const input = {
+    getIcon: 'icon_name',
+    getIconColor: [1, 2, 3, 255],
+    invalidOption: false,
+  };
+
+  const expectedOutput = {
+    getIcon: 'icon_name',
+    getIconColor: [1, 2, 3, 255],
+  };
+
+  expect(computeGeoJsonIconOptionsFromJsOutput(input)).toEqual(expectedOutput);
+});
+
+test('computeGeoJsonIconOptionsFromFormData computes icon options based on form data', () => {
+  const formData: SqlaFormData = {
+    icon_url: 'https://example.com/icon.png',
+    icon_size: 123,
+    icon_size_unit: 'pixels',
+    datasource: 'test_datasource',
+    viz_type: 'deck_geojson',
+  };
+
+  const expectedOutput = {
+    getIcon: expect.any(Function),
+    getIconSize: 123,
+    iconSizeUnits: 'pixels',
+  };
+
+  const actualOutput = computeGeoJsonIconOptionsFromFormData(formData);
+  expect(actualOutput).toEqual(expectedOutput);
+
+  expect(actualOutput.getIcon()).toEqual({
+    url: 'https://example.com/icon.png',
+    height: 128,
+    width: 128,
+  });
+});

superset-frontend/plugins/preset-chart-deckgl/src/layers/Geojson/Geojson.test.tsx

@@ -1,297 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import type { ReactElement } from 'react';
-import type { ControlPanelSectionConfig } from '@superset-ui/chart-controls';
-// eslint-disable-next-line import/no-extraneous-dependencies
-import { render } from '@testing-library/react';
-import { SqlaFormData } from '@superset-ui/core';
-import { supersetTheme, ThemeProvider } from '@apache-superset/core/theme';
-import DeckGLGeoJson, {
-  computeGeoJsonTextOptionsFromJsOutput,
-  computeGeoJsonTextOptionsFromFormData,
-  computeGeoJsonIconOptionsFromJsOutput,
-  computeGeoJsonIconOptionsFromFormData,
-  getPoints,
-} from './Geojson';
-import controlPanel from './controlPanel';
-
-const mockDeckGLContainerProps: Array<Record<string, unknown>> = [];
-
-jest.mock('../../DeckGLContainer', () => ({
-  DeckGLContainerStyledWrapper: (props: Record<string, unknown>) => {
-    mockDeckGLContainerProps.push(props);
-    const React = jest.requireActual('react');
-    return React.createElement(
-      'div',
-      { 'data-testid': 'deckgl-container' },
-      props.children,
-    );
-  },
-}));
-
-jest.mock('../../utils/mapbox', () => ({
-  getMapboxApiKey: () => 'bootstrap-mapbox-key',
-  hasMapboxApiKey: () => true,
-}));
-
-jest.mock('react-map-gl/maplibre', () => ({
-  __esModule: true,
-  Map: () => null,
-  useControl: () => null,
-}));
-
-test('computeGeoJsonTextOptionsFromJsOutput returns an empty object for non-object input', () => {
-  expect(computeGeoJsonTextOptionsFromJsOutput(null)).toEqual({});
-  expect(computeGeoJsonTextOptionsFromJsOutput(42)).toEqual({});
-  expect(computeGeoJsonTextOptionsFromJsOutput([1, 2, 3])).toEqual({});
-  expect(computeGeoJsonTextOptionsFromJsOutput('string')).toEqual({});
-});
-
-test('computeGeoJsonTextOptionsFromJsOutput extracts valid text options from the input object', () => {
-  const input = {
-    getText: 'name',
-    getTextColor: [1, 2, 3, 255],
-    invalidOption: true,
-  };
-  const expectedOutput = {
-    getText: 'name',
-    getTextColor: [1, 2, 3, 255],
-  };
-  expect(computeGeoJsonTextOptionsFromJsOutput(input)).toEqual(expectedOutput);
-});
-
-test('computeGeoJsonTextOptionsFromFormData computes text options based on form data', () => {
-  const formData: SqlaFormData = {
-    label_property_name: 'name',
-    label_color: { r: 1, g: 2, b: 3, a: 1 },
-    label_size: 123,
-    label_size_unit: 'pixels',
-    datasource: 'test_datasource',
-    viz_type: 'deck_geojson',
-  };
-
-  const expectedOutput = {
-    getText: expect.any(Function),
-    getTextColor: [1, 2, 3, 255],
-    getTextSize: 123,
-    textSizeUnits: 'pixels',
-  };
-
-  const actualOutput = computeGeoJsonTextOptionsFromFormData(formData);
-  expect(actualOutput).toEqual(expectedOutput);
-
-  const sampleFeature = { properties: { name: 'Test' } };
-  expect(actualOutput.getText(sampleFeature)).toBe('Test');
-});
-
-test('computeGeoJsonIconOptionsFromJsOutput returns an empty object for non-object input', () => {
-  expect(computeGeoJsonIconOptionsFromJsOutput(null)).toEqual({});
-  expect(computeGeoJsonIconOptionsFromJsOutput(42)).toEqual({});
-  expect(computeGeoJsonIconOptionsFromJsOutput([1, 2, 3])).toEqual({});
-  expect(computeGeoJsonIconOptionsFromJsOutput('string')).toEqual({});
-});
-
-test('computeGeoJsonIconOptionsFromJsOutput extracts valid icon options from the input object', () => {
-  const input = {
-    getIcon: 'icon_name',
-    getIconColor: [1, 2, 3, 255],
-    invalidOption: false,
-  };
-
-  const expectedOutput = {
-    getIcon: 'icon_name',
-    getIconColor: [1, 2, 3, 255],
-  };
-
-  expect(computeGeoJsonIconOptionsFromJsOutput(input)).toEqual(expectedOutput);
-});
-
-test('computeGeoJsonIconOptionsFromFormData computes icon options based on form data', () => {
-  const formData: SqlaFormData = {
-    icon_url: 'https://example.com/icon.png',
-    icon_size: 123,
-    icon_size_unit: 'pixels',
-    datasource: 'test_datasource',
-    viz_type: 'deck_geojson',
-  };
-
-  const expectedOutput = {
-    getIcon: expect.any(Function),
-    getIconSize: 123,
-    iconSizeUnits: 'pixels',
-  };
-
-  const actualOutput = computeGeoJsonIconOptionsFromFormData(formData);
-  expect(actualOutput).toEqual(expectedOutput);
-
-  expect(actualOutput.getIcon()).toEqual({
-    url: 'https://example.com/icon.png',
-    height: 128,
-    width: 128,
-  });
-});
-
-test('controlPanel expands Map section so renderer controls are visible', () => {
-  const mapSection = controlPanel.controlPanelSections.find(
-    (
-      section: ControlPanelSectionConfig | null,
-    ): section is ControlPanelSectionConfig =>
-      section !== null && section.label === 'Map',
-  );
-
-  expect(mapSection).toBeDefined();
-  expect(mapSection?.expanded).toBe(true);
-});
-
-test('getPoints skips malformed GeoJSON entries instead of throwing', () => {
-  const features = [
-    {
-      type: 'Feature',
-      geometry: { type: 'Point', coordinates: [1, 2] },
-      properties: {},
-    },
-    [[0, 0]],
-    null,
-  ] as unknown as Parameters<typeof getPoints>[0];
-
-  expect(getPoints(features)).toEqual([
-    [1, 2],
-    [1, 2],
-  ]);
-  expect(getPoints()).toEqual([]);
-});
-
-const renderWithTheme = (component: ReactElement) =>
-  render(<ThemeProvider theme={supersetTheme}>{component}</ThemeProvider>);
-
-const geoJsonProps = {
-  formData: {
-    datasource: 'test_datasource',
-    viz_type: 'deck_geojson',
-    slice_id: 1,
-    autozoom: false,
-    map_style: 'legacy-map-style',
-    extruded: false,
-    filled: true,
-    stroked: true,
-    line_width: 1,
-    line_width_unit: 'pixels',
-    point_radius_scale: 1,
-    enable_labels: false,
-    enable_icons: false,
-  },
-  payload: {
-    data: {
-      features: [
-        {
-          type: 'Feature',
-          geometry: { type: 'Point', coordinates: [0, 0] },
-          properties: { name: 'Test point' },
-        },
-      ],
-    },
-  },
-  setControlValue: jest.fn(),
-  viewport: { longitude: 0, latitude: 0, zoom: 1 },
-  onAddFilter: jest.fn(),
-  height: 600,
-  width: 800,
-  filterState: {},
-  onContextMenu: jest.fn(),
-  setDataMask: jest.fn(),
-  emitCrossFilters: false,
-};
-
-const lastDeckGLContainerProps = () =>
-  mockDeckGLContainerProps
-    .slice()
-    .reverse()
-    .find(props => props?.viewport !== undefined);
-
-test('DeckGLGeoJson passes selected MapLibre renderer props to the container', () => {
-  mockDeckGLContainerProps.length = 0;
-
-  renderWithTheme(
-    <DeckGLGeoJson
-      {...geoJsonProps}
-      formData={{
-        ...geoJsonProps.formData,
-        map_renderer: 'maplibre',
-        maplibre_style: 'https://example.com/maplibre-style.json',
-        mapbox_style: 'mapbox://styles/mapbox/dark-v9',
-      }}
-    />,
-  );
-
-  expect(lastDeckGLContainerProps()).toEqual(
-    expect.objectContaining({
-      mapProvider: 'maplibre',
-      mapStyle: 'https://example.com/maplibre-style.json',
-      mapboxApiKey: 'bootstrap-mapbox-key',
-    }),
-  );
-});
-
-test('DeckGLGeoJson passes selected Mapbox renderer props to the container', () => {
-  mockDeckGLContainerProps.length = 0;
-
-  renderWithTheme(
-    <DeckGLGeoJson
-      {...geoJsonProps}
-      formData={{
-        ...geoJsonProps.formData,
-        map_renderer: 'mapbox',
-        maplibre_style: 'https://example.com/maplibre-style.json',
-        mapbox_style: 'mapbox://styles/mapbox/satellite-v9',
-      }}
-    />,
-  );
-
-  expect(lastDeckGLContainerProps()).toEqual(
-    expect.objectContaining({
-      mapProvider: 'mapbox',
-      mapStyle: 'mapbox://styles/mapbox/satellite-v9',
-      mapboxApiKey: 'bootstrap-mapbox-key',
-    }),
-  );
-});
-
-test('DeckGLGeoJson falls back to legacy map_style when provider-specific style is absent', () => {
-  mockDeckGLContainerProps.length = 0;
-
-  renderWithTheme(
-    <DeckGLGeoJson
-      {...geoJsonProps}
-      formData={{
-        ...geoJsonProps.formData,
-        map_renderer: 'maplibre',
-        maplibre_style: undefined,
-        map_style: 'legacy-map-style',
-      }}
-    />,
-  );
-
-  expect(lastDeckGLContainerProps()).toEqual(
-    expect.objectContaining({
-      mapProvider: 'maplibre',
-      mapStyle: 'legacy-map-style',
-      mapboxApiKey: 'bootstrap-mapbox-key',
-    }),
-  );
-});

superset-frontend/plugins/preset-chart-deckgl/src/layers/Geojson/Geojson.tsx

@@ -30,7 +30,6 @@ import {
   QueryFormData,
   SetDataMaskHook,
   SqlaFormData,
-  getMapProviderMapStyle,
 } from '@superset-ui/core';
 
 import {
@@ -47,7 +46,6 @@ import { Point } from '../../types';
 import { GetLayerType } from '../../factory';
 import { HIGHLIGHT_COLOR_ARRAY } from '../../utils';
 import { BLACK_COLOR, PRIMARY_COLOR } from '../../utilities/controls';
-import { getMapboxApiKey } from '../../utils/mapbox';
 
 type ProcessedFeature = Feature<Geometry, GeoJsonProperties> & {
   properties: JsonObject;
@@ -359,19 +357,9 @@ export type DeckGLGeoJsonProps = {
   emitCrossFilters?: boolean;
 };
 
-export function getPoints(data?: Point[]) {
-  if (!Array.isArray(data)) {
-    return [];
-  }
-
+export function getPoints(data: Point[]) {
   return data.reduce((acc: Array<any>, feature: any) => {
-    let bounds;
-    try {
-      bounds = geojsonExtent(feature);
-    } catch {
-      return acc;
-    }
-
+    const bounds = geojsonExtent(feature);
     if (bounds) {
       return [...acc, [bounds[0], bounds[1]], [bounds[2], bounds[3]]];
     }
@@ -394,13 +382,13 @@ const DeckGLGeoJson = (props: DeckGLGeoJsonProps) => {
 
   const viewport: Viewport = useMemo(() => {
     if (formData.autozoom) {
-      const points = getPoints(payload?.data?.features);
+      const points = getPoints(payload.data.features) || [];
 
       if (points.length) {
         return fitViewport(props.viewport, {
           width,
           height,
-          points,
+          points: getPoints(payload.data.features) || [],
         });
       }
     }
@@ -424,21 +412,12 @@ const DeckGLGeoJson = (props: DeckGLGeoJsonProps) => {
     emitCrossFilters: props.emitCrossFilters,
   });
 
-  const selectedMap = getMapProviderMapStyle({
-    mapProvider: formData.map_renderer,
-    maplibreStyle: formData.maplibre_style,
-    mapboxStyle: formData.mapbox_style,
-    legacyMapStyle: formData.map_style,
-  });
-
   return (
     <DeckGLContainerStyledWrapper
       ref={containerRef}
       viewport={viewport}
       layers={[layer]}
-      mapProvider={selectedMap.mapProvider}
-      mapStyle={selectedMap.mapStyle}
-      mapboxApiKey={getMapboxApiKey()}
+      mapStyle={formData.map_style}
       setControlValue={setControlValue}
       height={height}
       width={width}

superset-frontend/plugins/preset-chart-deckgl/src/layers/Geojson/controlPanel.ts

@@ -82,7 +82,6 @@ const config: ControlPanelConfig = {
     },
     {
       label: t('Map'),
-      expanded: true,
       controlSetRows: [
         [mapProvider],
         [mapboxStyle],

superset-frontend/plugins/preset-chart-deckgl/src/layers/Polygon/Polygon.test.tsx

@@ -16,7 +16,6 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import type { ReactElement } from 'react';
 // eslint-disable-next-line import/no-extraneous-dependencies
 import { render, screen } from '@testing-library/react';
 // eslint-disable-next-line import/no-extraneous-dependencies
@@ -34,23 +33,10 @@ const mockGetColorBreakpointsBuckets = jest.spyOn(
 );
 
 // Mock DeckGL container and Legend
-const mockDeckGLContainerProps: Array<Record<string, unknown>> = [];
-
 jest.mock('../../DeckGLContainer', () => ({
-  DeckGLContainerStyledWrapper: (props: Record<string, unknown>) => {
-    mockDeckGLContainerProps.push(props);
-    const React = jest.requireActual('react');
-    return React.createElement(
-      'div',
-      { 'data-testid': 'deckgl-container' },
-      props.children,
-    );
-  },
-}));
-
-jest.mock('../../utils/mapbox', () => ({
-  getMapboxApiKey: () => 'bootstrap-mapbox-key',
-  hasMapboxApiKey: () => true,
+  DeckGLContainerStyledWrapper: ({ children }: any) => (
+    <div data-testid="deckgl-container">{children}</div>
+  ),
 }));
 
 jest.mock('../../components/Legend', () => ({ categories, position }: any) => (
@@ -123,95 +109,6 @@ const mockProps = {
   emitCrossFilters: false,
 };
 
-describe('DeckGLPolygon renderer propagation', () => {
-  beforeEach(() => {
-    jest.clearAllMocks();
-    mockGetBuckets.mockReturnValue({});
-    mockGetColorBreakpointsBuckets.mockReturnValue({});
-  });
-
-  const renderWithTheme = (component: ReactElement) =>
-    render(<ThemeProvider theme={supersetTheme}>{component}</ThemeProvider>);
-
-  const lastDeckGLContainerProps = () =>
-    mockDeckGLContainerProps
-      .slice()
-      .reverse()
-      .find(props => props?.viewport !== undefined);
-
-  test('passes selected MapLibre renderer props to the container', () => {
-    mockDeckGLContainerProps.length = 0;
-
-    renderWithTheme(
-      <DeckGLPolygon
-        {...mockProps}
-        formData={{
-          ...mockProps.formData,
-          map_renderer: 'maplibre',
-          maplibre_style: 'https://example.com/polygon-maplibre-style.json',
-          mapbox_style: 'mapbox://styles/mapbox/dark-v9',
-        }}
-      />,
-    );
-
-    expect(lastDeckGLContainerProps()).toEqual(
-      expect.objectContaining({
-        mapProvider: 'maplibre',
-        mapStyle: 'https://example.com/polygon-maplibre-style.json',
-        mapboxApiKey: 'bootstrap-mapbox-key',
-      }),
-    );
-  });
-
-  test('passes selected Mapbox renderer props to the container', () => {
-    mockDeckGLContainerProps.length = 0;
-
-    renderWithTheme(
-      <DeckGLPolygon
-        {...mockProps}
-        formData={{
-          ...mockProps.formData,
-          map_renderer: 'mapbox',
-          maplibre_style: 'https://example.com/polygon-maplibre-style.json',
-          mapbox_style: 'mapbox://styles/mapbox/satellite-v9',
-        }}
-      />,
-    );
-
-    expect(lastDeckGLContainerProps()).toEqual(
-      expect.objectContaining({
-        mapProvider: 'mapbox',
-        mapStyle: 'mapbox://styles/mapbox/satellite-v9',
-        mapboxApiKey: 'bootstrap-mapbox-key',
-      }),
-    );
-  });
-
-  test('falls back to legacy map_style when provider-specific style is absent', () => {
-    mockDeckGLContainerProps.length = 0;
-
-    renderWithTheme(
-      <DeckGLPolygon
-        {...mockProps}
-        formData={{
-          ...mockProps.formData,
-          map_renderer: 'maplibre',
-          maplibre_style: undefined,
-          map_style: 'legacy-map-style',
-        }}
-      />,
-    );
-
-    expect(lastDeckGLContainerProps()).toEqual(
-      expect.objectContaining({
-        mapProvider: 'maplibre',
-        mapStyle: 'legacy-map-style',
-        mapboxApiKey: 'bootstrap-mapbox-key',
-      }),
-    );
-  });
-});
-
 describe('DeckGLPolygon bucket generation logic', () => {
   beforeEach(() => {
     jest.clearAllMocks();
@@ -222,7 +119,7 @@ describe('DeckGLPolygon bucket generation logic', () => {
     mockGetColorBreakpointsBuckets.mockReturnValue({});
   });
 
-  const renderWithTheme = (component: ReactElement) =>
+  const renderWithTheme = (component: React.ReactElement) =>
     render(<ThemeProvider theme={supersetTheme}>{component}</ThemeProvider>);
 
   test('should use getBuckets for linear_palette color scheme', () => {
@@ -330,7 +227,7 @@ describe('DeckGLPolygon Error Handling and Edge Cases', () => {
     mockGetColorBreakpointsBuckets.mockReturnValue({});
   });
 
-  const renderWithTheme = (component: ReactElement) =>
+  const renderWithTheme = (component: React.ReactElement) =>
     render(<ThemeProvider theme={supersetTheme}>{component}</ThemeProvider>);
 
   test('handles empty features data gracefully', () => {
@@ -394,7 +291,7 @@ describe('DeckGLPolygon Legend Integration', () => {
     });
   });
 
-  const renderWithTheme = (component: ReactElement) =>
+  const renderWithTheme = (component: React.ReactElement) =>
     render(<ThemeProvider theme={supersetTheme}>{component}</ThemeProvider>);
 
   test('renders legend with non-empty categories when metric and linear_palette are defined', () => {

superset-frontend/plugins/preset-chart-deckgl/src/layers/Polygon/Polygon.tsx

@@ -31,7 +31,6 @@ import {
   JsonValue,
   QueryFormData,
   SetDataMaskHook,
-  getMapProviderMapStyle,
 } from '@superset-ui/core';
 
 import { PolygonLayer } from '@deck.gl/layers';
@@ -58,7 +57,6 @@ import { TooltipProps } from '../../components/Tooltip';
 import { GetLayerType } from '../../factory';
 import { COLOR_SCHEME_TYPES } from '../../utilities/utils';
 import { DEFAULT_DECKGL_COLOR } from '../../utilities/Shared_DeckGL';
-import { getMapboxApiKey } from '../../utils/mapbox';
 import {
   createTooltipContent,
   CommonTooltipRows,
@@ -341,12 +339,6 @@ const DeckGLPolygon = (props: DeckGLPolygonProps) => {
     colorSchemeType === COLOR_SCHEME_TYPES.color_breakpoints
       ? getColorBreakpointsBuckets(formData.color_breakpoints)
       : getBuckets(formData, payload.data.features, accessor);
-  const selectedMap = getMapProviderMapStyle({
-    mapProvider: formData.map_renderer,
-    maplibreStyle: formData.maplibre_style,
-    mapboxStyle: formData.mapbox_style,
-    legacyMapStyle: formData.map_style,
-  });
 
   return (
     <div style={{ position: 'relative' }}>
@@ -355,9 +347,7 @@ const DeckGLPolygon = (props: DeckGLPolygonProps) => {
         viewport={viewport}
         layers={getLayers()}
         setControlValue={setControlValue}
-        mapProvider={selectedMap.mapProvider}
-        mapStyle={selectedMap.mapStyle}
-        mapboxApiKey={getMapboxApiKey()}
+        mapStyle={formData.map_style}
         width={props.width}
         height={props.height}
       />

superset-frontend/plugins/preset-chart-deckgl/src/utilities/Shared_DeckGL.test.ts

@@ -1,161 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { ControlPanelState } from '@superset-ui/chart-controls';
-import { OSM_TILE_STYLE_URL } from '@superset-ui/core/utils/mapStyles';
-import { mapProvider, maplibreStyle } from './Shared_DeckGL';
-
-const setBootstrap = ({
-  conf = {},
-  deckglTiles,
-}: {
-  conf?: Record<string, unknown>;
-  deckglTiles?: unknown;
-}) => {
-  document.body.innerHTML = `<div id="app" data-bootstrap='${JSON.stringify({
-    common: {
-      conf,
-      ...(deckglTiles === undefined ? {} : { deckgl_tiles: deckglTiles }),
-    },
-  })}'></div>`;
-};
-
-type MapProviderControlConfig = typeof mapProvider.config & {
-  mapStateToProps: (state: ControlPanelState) => {
-    options?: unknown;
-    warning?: string;
-    default?: unknown;
-  };
-};
-
-const getMapProviderProps = (value?: string) =>
-  (mapProvider.config as MapProviderControlConfig).mapStateToProps({
-    form_data: { map_renderer: value },
-  } as unknown as ControlPanelState);
-
-type MapLibreStyleControlConfig = typeof maplibreStyle.config & {
-  mapStateToProps: () => {
-    choices: unknown;
-    default: unknown;
-  };
-};
-
-const getMapLibreStyleProps = () =>
-  (maplibreStyle.config as MapLibreStyleControlConfig).mapStateToProps();
-
-test('deck.gl MapLibre style choices expose Streets (OSM)', () => {
-  expect(maplibreStyle.config.choices).toContainEqual([
-    OSM_TILE_STYLE_URL,
-    'Streets (OSM)',
-  ]);
-});
-
-test('deck.gl map renderer hides Mapbox when no key exists for new selections', () => {
-  setBootstrap({ conf: {} });
-
-  const props = getMapProviderProps('maplibre');
-
-  expect(props.options).toEqual([
-    { value: 'maplibre', label: 'MapLibre (open-source)' },
-  ]);
-});
-
-test('deck.gl map renderer keeps saved Mapbox visible while disabled without a key', () => {
-  setBootstrap({ conf: {} });
-
-  const props = getMapProviderProps('mapbox');
-
-  expect(props.options).toContainEqual({
-    value: 'mapbox',
-    label: 'Mapbox (API key required)',
-    disabled: true,
-  });
-});
-
-test('deck.gl map renderer enables Mapbox when a key exists', () => {
-  setBootstrap({ conf: { MAPBOX_API_KEY: 'pk.test' } });
-
-  const props = getMapProviderProps('maplibre');
-
-  expect(props.options).toEqual([
-    { value: 'maplibre', label: 'MapLibre (open-source)' },
-    { value: 'mapbox', label: 'Mapbox (API key required)' },
-  ]);
-});
-
-test('deck.gl map renderer keeps the original explanatory description', () => {
-  expect(mapProvider.config.description).toBe(
-    'Select the map tile provider. MapLibre is open-source and requires no API key. Mapbox requires MAPBOX_API_KEY to be configured in Superset.',
-  );
-});
-
-test('deck.gl map renderer defaults to configured Mapbox when a key exists', () => {
-  setBootstrap({
-    conf: { DEFAULT_MAP_RENDERER: 'mapbox', MAPBOX_API_KEY: 'pk.test' },
-  });
-
-  expect(getMapProviderProps('maplibre').default).toBe('mapbox');
-});
-
-test('deck.gl map renderer falls back from configured Mapbox default without a key', () => {
-  setBootstrap({ conf: { DEFAULT_MAP_RENDERER: 'mapbox' } });
-
-  expect(getMapProviderProps('maplibre').default).toBe('maplibre');
-});
-
-test('deck.gl map style falls back to default tiles for empty overrides', () => {
-  setBootstrap({ deckglTiles: [] });
-
-  const props = getMapLibreStyleProps();
-
-  expect(props.choices).toContainEqual([OSM_TILE_STYLE_URL, 'Streets (OSM)']);
-  expect(props.default).toBe(
-    'https://basemaps.cartocdn.com/gl/positron-gl-style/style.json',
-  );
-});
-
-test('deck.gl map style falls back to default tiles for malformed overrides', () => {
-  setBootstrap({
-    deckglTiles: [
-      ['https://tiles.example.com/{z}/{x}/{y}.png'],
-      ['https://tiles.example.com/{z}/{x}/{y}.png', 'Custom', 'Extra'],
-      ['', 'Empty URL'],
-    ],
-  });
-
-  const props = getMapLibreStyleProps();
-
-  expect(props.choices).toContainEqual([OSM_TILE_STYLE_URL, 'Streets (OSM)']);
-  expect(props.default).toBe(
-    'https://basemaps.cartocdn.com/gl/positron-gl-style/style.json',
-  );
-});
-
-test('deck.gl map style accepts well-formed tile overrides', () => {
-  setBootstrap({
-    deckglTiles: [['https://tiles.example.com/style.json', 'Custom']],
-  });
-
-  const props = getMapLibreStyleProps();
-
-  expect(props.choices).toEqual([
-    ['https://tiles.example.com/style.json', 'Custom'],
-  ]);
-  expect(props.default).toBe('https://tiles.example.com/style.json');
-});

superset-frontend/plugins/preset-chart-deckgl/src/utilities/Shared_DeckGL.tsx

@@ -25,20 +25,9 @@ import {
   getCategoricalSchemeRegistry,
   getSequentialSchemeRegistry,
   SequentialScheme,
-  type QueryFormData,
 } from '@superset-ui/core';
-import {
-  getDefaultMapRenderer,
-  getBootstrapDataFromDocument,
-  getMapRendererOptions,
-  OSM_TILE_STYLE_URL,
-  type MapRendererOption,
-  type MapProvider,
-} from '@superset-ui/core/utils/mapStyles';
 import {
   ControlPanelState,
-  ControlStateMapping,
-  ControlState,
   CustomControlItem,
   D3_FORMAT_OPTIONS,
   getColorControlsProps,
@@ -51,23 +40,15 @@ import {
   isColorSchemeTypeVisible,
 } from './utils';
 import { TooltipTemplateControl } from './TooltipTemplateControl';
-import { hasMapboxApiKey } from '../utils/mapbox';
 
 const categoricalSchemeRegistry = getCategoricalSchemeRegistry();
 const sequentialSchemeRegistry = getSequentialSchemeRegistry();
 
 export const DEFAULT_DECKGL_COLOR = { r: 158, g: 158, b: 158, a: 1 };
 
-type DeckGLTileChoice = [string, string];
-type MapStyleVisibilityProps = {
-  controls?: ControlStateMapping;
-};
-type MetricControlValue = {
-  type?: unknown;
-  value?: unknown;
-};
+let deckglTiles: string[][];
 
-export const DEFAULT_DECKGL_TILES: DeckGLTileChoice[] = [
+export const DEFAULT_DECKGL_TILES = [
   [
     'https://basemaps.cartocdn.com/gl/positron-gl-style/style.json',
     'Light (Carto)',
@@ -81,10 +62,9 @@ export const DEFAULT_DECKGL_TILES: DeckGLTileChoice[] = [
     'Streets (Carto)',
   ],
   ['https://tiles.openfreemap.org/styles/liberty', 'Liberty (OpenFreeMap)'],
-  [OSM_TILE_STYLE_URL, 'Streets (OSM)'],
 ];
 
-export const DEFAULT_MAPBOX_TILES: DeckGLTileChoice[] = [
+export const DEFAULT_MAPBOX_TILES = [
   ['mapbox://styles/mapbox/streets-v9', 'Streets (Mapbox)'],
   ['mapbox://styles/mapbox/dark-v9', 'Dark (Mapbox)'],
   ['mapbox://styles/mapbox/light-v9', 'Light (Mapbox)'],
@@ -93,56 +73,17 @@ export const DEFAULT_MAPBOX_TILES: DeckGLTileChoice[] = [
   ['mapbox://styles/mapbox/outdoors-v9', 'Outdoors (Mapbox)'],
 ];
 
-const isDeckGLTileChoices = (value: unknown): value is DeckGLTileChoice[] =>
-  Array.isArray(value) &&
-  value.length > 0 &&
-  value.every(
-    choice =>
-      Array.isArray(choice) &&
-      choice.length === 2 &&
-      typeof choice[0] === 'string' &&
-      choice[0].trim().length > 0 &&
-      typeof choice[1] === 'string' &&
-      choice[1].trim().length > 0,
-  );
-
 const getDeckGLTiles = () => {
-  const bootstrapData = getBootstrapDataFromDocument();
-  const deckglTilesOverride = (
-    bootstrapData as {
-      common?: { deckgl_tiles?: unknown };
-    } | null
-  )?.common?.deckgl_tiles;
-  return isDeckGLTileChoices(deckglTilesOverride)
-    ? deckglTilesOverride
-    : DEFAULT_DECKGL_TILES;
+  if (!deckglTiles) {
+    const appContainer = document.getElementById('app');
+    const { common } = JSON.parse(
+      appContainer?.getAttribute('data-bootstrap') || '{}',
+    );
+    deckglTiles = common?.deckgl_tiles ?? DEFAULT_DECKGL_TILES;
+  }
+  return deckglTiles;
 };
 
-const getMapLibreStyleProps = () => {
-  const choices = getDeckGLTiles();
-  return {
-    choices,
-    default: choices[0][0],
-  };
-};
-
-const getLabeledMapRendererOptions = ({
-  hasMapboxKey,
-  currentValue,
-}: {
-  hasMapboxKey: boolean;
-  currentValue?: MapProvider;
-}) =>
-  getMapRendererOptions({ hasMapboxKey, currentValue }).map(
-    (option: MapRendererOption) => ({
-      ...option,
-      label:
-        option.value === 'maplibre'
-          ? t('MapLibre (open-source)')
-          : t('Mapbox (API key required)'),
-    }),
-  );
-
 const DEFAULT_VIEWPORT = {
   longitude: 6.85236157047845,
   latitude: 31.222656842808707,
@@ -515,26 +456,15 @@ export const mapProvider = {
     label: t('Map Renderer'),
     clearable: false,
     renderTrigger: true,
-    options: getLabeledMapRendererOptions({
-      hasMapboxKey: hasMapboxApiKey(),
-    }),
+    choices: [
+      ['maplibre', t('MapLibre (open-source)')],
+      ['mapbox', t('Mapbox (API key required)')],
+    ],
     default: 'maplibre',
     description: t(
       'Select the map tile provider. MapLibre is open-source and requires no API key. ' +
         'Mapbox requires MAPBOX_API_KEY to be configured in Superset.',
     ),
-    mapStateToProps: (state: ControlPanelState) => {
-      const hasKey = hasMapboxApiKey();
-      return {
-        options: getLabeledMapRendererOptions({
-          hasMapboxKey: hasKey,
-          currentValue: state.form_data?.map_renderer as
-            | MapProvider
-            | undefined,
-        }),
-        default: getDefaultMapRenderer(),
-      };
-    },
   },
 };
 
@@ -546,14 +476,13 @@ export const maplibreStyle = {
     clearable: false,
     renderTrigger: true,
     freeForm: true,
-    choices: DEFAULT_DECKGL_TILES,
-    default: DEFAULT_DECKGL_TILES[0][0],
+    choices: getDeckGLTiles(),
+    default: getDeckGLTiles()[0][0],
     description: t(
       'Base layer map style. Accepts a MapLibre-compatible style URL.',
     ),
-    visibility: ({ controls }: MapStyleVisibilityProps) =>
+    visibility: ({ controls }: ControlPanelState) =>
       controls?.map_renderer?.value !== 'mapbox',
-    mapStateToProps: getMapLibreStyleProps,
   },
 };
 
@@ -570,7 +499,7 @@ export const mapboxStyle = {
     description: t(
       'Base layer map style. Accepts a Mapbox style URL (mapbox://styles/...).',
     ),
-    visibility: ({ controls }: MapStyleVisibilityProps) =>
+    visibility: ({ controls }: ControlPanelState) =>
       controls?.map_renderer?.value === 'mapbox',
   },
 };
@@ -588,14 +517,14 @@ export const geojsonColumn = {
   },
 };
 
-const extractMetricsFromFormData = (formData: QueryFormData) => {
-  const metrics = new Set<unknown>();
+const extractMetricsFromFormData = (formData: any) => {
+  const metrics = new Set<string>();
 
   if (formData.metrics) {
     (Array.isArray(formData.metrics)
       ? formData.metrics
       : [formData.metrics]
-    ).forEach((metric: unknown) => metrics.add(metric));
+    ).forEach((metric: any) => metrics.add(metric));
   }
 
   if (formData.point_radius_fixed?.value) {
@@ -604,9 +533,8 @@ const extractMetricsFromFormData = (formData: QueryFormData) => {
 
   Object.entries(formData).forEach(([, value]) => {
     if (!value || typeof value !== 'object') return;
-    const controlValue = value as MetricControlValue;
-    if (controlValue.type === 'metric' && controlValue.value) {
-      metrics.add(controlValue.value);
+    if ((value as any).type === 'metric' && (value as any).value) {
+      metrics.add((value as any).value);
     }
   });
 
@@ -627,7 +555,7 @@ export const tooltipContents = {
     ),
     ghostButtonText: t('Drop columns/metrics here or click'),
     disabledTabs: new Set(['saved', 'sqlExpression']),
-    mapStateToProps: (state: ControlPanelState) => {
+    mapStateToProps: (state: any) => {
       const { datasource, form_data: formData } = state;
 
       const selectedMetrics = formData
@@ -636,8 +564,7 @@ export const tooltipContents = {
 
       return {
         columns: datasource?.columns || [],
-        savedMetrics:
-          datasource && 'metrics' in datasource ? datasource.metrics || [] : [],
+        savedMetrics: datasource?.metrics || [],
         datasource,
         selectedMetrics,
         disabledTabs: new Set(['saved', 'sqlExpression']),
@@ -657,7 +584,7 @@ export const tooltipTemplate = {
     default: '',
     description: '',
     placeholder: '',
-    mapStateToProps: (_state: ControlPanelState, control: ControlState) => ({
+    mapStateToProps: (_state: any, control: any) => ({
       value: control.value,
     }),
   },
@@ -775,13 +702,8 @@ export const deckGLBreakpointMetric: CustomControlItem = {
     // mapStateToProps: (state: ControlPanelState) => ({
     //   datasource: state.datasource,
     // }),
-    visibility: ({ controls }: MapStyleVisibilityProps) =>
-      controls
-        ? isColorSchemeTypeVisible(
-            controls,
-            COLOR_SCHEME_TYPES.color_breakpoints,
-          )
-        : false,
+    visibility: ({ controls }: { controls: any }) =>
+      isColorSchemeTypeVisible(controls, COLOR_SCHEME_TYPES.color_breakpoints),
   },
 };
 

superset-frontend/plugins/preset-chart-deckgl/src/utils/mapbox.test.ts

@@ -1,38 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { getMapboxApiKey, hasMapboxApiKey } from './mapbox';
-
-const setBootstrap = (conf: Record<string, unknown>) => {
-  document.body.innerHTML = `<div id="app" data-bootstrap='${JSON.stringify({
-    common: { conf },
-  })}'></div>`;
-};
-
-test('deck.gl Mapbox helpers read key presence from bootstrap data', () => {
-  setBootstrap({ MAPBOX_API_KEY: 'pk.test' });
-
-  expect(getMapboxApiKey()).toBe('pk.test');
-  expect(hasMapboxApiKey()).toBe(true);
-
-  setBootstrap({});
-
-  expect(getMapboxApiKey()).toBe('');
-  expect(hasMapboxApiKey()).toBe(false);
-});

superset-frontend/plugins/preset-chart-deckgl/src/utils/mapbox.ts

@@ -17,15 +17,19 @@
  * under the License.
  */
 
-import {
-  getMapboxApiKeyFromBootstrap,
-  hasMapboxApiKey as hasBootstrapMapboxApiKey,
-} from '@superset-ui/core/utils/mapStyles';
-
 export function getMapboxApiKey(): string {
-  return getMapboxApiKeyFromBootstrap();
-}
-
-export function hasMapboxApiKey(): boolean {
-  return hasBootstrapMapboxApiKey();
+  if (typeof document === 'undefined') {
+    return '';
+  }
+  try {
+    const appContainer = document.getElementById('app');
+    const dataBootstrap = appContainer?.getAttribute('data-bootstrap');
+    if (dataBootstrap) {
+      const bootstrapData = JSON.parse(dataBootstrap);
+      return bootstrapData?.common?.conf?.MAPBOX_API_KEY || '';
+    }
+  } catch {
+    // If bootstrap data is unavailable or malformed, return empty string
+  }
+  return '';
 }

superset-frontend/scripts/check-custom-rules.js

@@ -197,62 +197,6 @@ function checkI18nTemplates(ast, filepath) {
   });
 }
 
-/**
- * Check for eager t()/tn() calls in `label` / `description` properties of
- * config objects evaluated at module load (e.g., controlPanel files). The
- * translation is captured at module-evaluation time, before i18n has loaded,
- * and never updates when the user switches language. The fix is to wrap the
- * call in an arrow function: `label: () => t('Foo')`.
- *
- * Limited to controlPanel files because that's where this pattern is
- * problematic at scale; t() inside JSX or component bodies is evaluated at
- * render time and works fine.
- */
-const EAGER_T_WATCHED_PROPS = new Set(['label', 'description']);
-
-function checkEagerTranslationsInConfig(ast, filepath) {
-  if (!/controlPanel\.(ts|tsx|js|jsx)$/.test(filepath)) return;
-
-  traverse(ast, {
-    ObjectProperty(path) {
-      const { node } = path;
-      if (node.computed || node.shorthand) return;
-
-      const keyName =
-        node.key.type === 'Identifier'
-          ? node.key.name
-          : node.key.type === 'StringLiteral'
-            ? node.key.value
-            : null;
-      if (!keyName || !EAGER_T_WATCHED_PROPS.has(keyName)) return;
-
-      const { value } = node;
-      if (
-        value.type !== 'CallExpression' ||
-        value.callee.type !== 'Identifier' ||
-        (value.callee.name !== 't' && value.callee.name !== 'tn')
-      ) {
-        return;
-      }
-
-      if (hasEslintDisable(path, 'i18n-strings/no-eager-t-in-config')) return;
-
-      // Warn (not error) because there are many pre-existing violations.
-      // The ESLint plugin provides an autofix so authors can sweep files
-      // as they touch them. Promote to error once the codebase is clean.
-      // eslint-disable-next-line no-console
-      console.warn(
-        `${YELLOW}⚠${RESET} ${filepath}:${node.loc?.start.line ?? '?'}: ` +
-          `Eager \`${keyName}: ${value.callee.name}(...)\` is evaluated at ` +
-          `module load, before i18n is initialized. Wrap in an arrow ` +
-          `function: \`${keyName}: () => ${value.callee.name}(...)\`. ` +
-          `Run \`eslint --fix\` to autofix.`,
-      );
-      warningCount += 1;
-    },
-  });
-}
-
 /**
  * Props that should contain translated strings
  */
@@ -621,7 +565,6 @@ function processFile(filepath) {
     checkNoLiteralColors(ast, filepath);
     checkNoFaIcons(ast, filepath);
     checkI18nTemplates(ast, filepath);
-    checkEagerTranslationsInConfig(ast, filepath);
     checkUntranslatedStrings(ast, filepath);
   } catch (error) {
     // eslint-disable-next-line no-console

superset-frontend/scripts/oxlint-metrics-uploader.js

@@ -134,11 +134,9 @@ async function runOxlintAndProcess() {
     console.log('Running minimal ESLint for custom rules...');
     let eslintOutput = '[]';
     try {
-      // Run ESLint and capture output directly.
-      // Flat config (eslint.config.minimal.js) is explicitly selected via
-      // --config; ESLint v9+/v10 no longer support eslintrc or --no-eslintrc.
+      // Run ESLint and capture output directly
       eslintOutput = execSync(
-        'npx eslint --config eslint.config.minimal.js --no-inline-config --format json src',
+        'npx eslint --no-eslintrc --config .eslintrc.minimal.js --no-inline-config --format json src',
         {
           encoding: 'utf8',
           maxBuffer: 50 * 1024 * 1024,

superset-frontend/src/SqlLab/components/EditorWrapper/index.tsx

@@ -349,6 +349,11 @@ const EditorWrapper = ({
           width: ${theme.sizeUnit * 130}px !important;
         }
 
+        .ace_completion-highlight {
+          color: ${theme.colorPrimaryText} !important;
+          background-color: ${theme.colorPrimaryBgHover};
+        }
+
         .ace_tooltip {
           max-width: ${SQL_EDITOR_LEFTBAR_WIDTH}px;
         }

superset-frontend/src/SqlLab/components/ResultSet/index.tsx

@@ -425,7 +425,6 @@ const ResultSet = ({
                     url: makeUrl('/api/v1/sqllab/export_streaming/'),
                     payload: { client_id: query.id },
                     exportType: 'csv',
-                    exportSource: 'sqllab',
                     expectedRows: rows,
                   });
                 } else {

superset-frontend/src/components/Chart/urlParamsForwarding.integration.test.ts

@@ -1,113 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import fetchMock from 'fetch-mock';
-import { JsonObject, QueryFormData, VizType } from '@superset-ui/core';
-import { getChartDataRequest } from 'src/components/Chart/chartAction';
-
-/**
- * Integration (mocked-network) port of the deprecated Cypress spec
- * `cypress/e2e/dashboard/_skip.url_params.test.ts` (sc-107448).
- *
- * The original test loaded a dashboard with query-string params, intercepted
- * `/api/v1/chart/data`, and asserted each query in the request body carried
- * `url_params`. That assertion is request-construction logic — the form_data
- * → query-context pipeline — which is exercised here without a backend.
- *
- * Intentional narrowing: the URL-string → `form_data.url_params` hop (handled
- * in `src/dashboard/actions/hydrate.ts` via `extractUrlParams`) is not covered
- * here. This file verifies the chart-data side of the contract only; the
- * dashboard hydration side is covered by its own unit tests.
- */
-const CHART_DATA_GLOB = 'glob:*/api/v1/chart/data*';
-const CHART_DATA_ROUTE = 'urlParamsForwarding-chartData';
-const URL_PARAMS = { param1: '123', param2: 'abc' };
-
-type ChartDataRequestBody = {
-  queries: JsonObject[];
-  form_data: JsonObject;
-};
-
-const buildFormData = (
-  overrides: Partial<QueryFormData> = {},
-): QueryFormData => ({
-  datasource: '1__table',
-  granularity_sqla: 'ds',
-  viz_type: VizType.Table,
-  url_params: URL_PARAMS,
-  ...overrides,
-});
-
-const lastChartDataBody = (): ChartDataRequestBody => {
-  const calls = fetchMock.callHistory.calls(CHART_DATA_ROUTE);
-  expect(calls.length).toBeGreaterThan(0);
-  return JSON.parse(
-    calls[calls.length - 1].options.body as string,
-  ) as ChartDataRequestBody;
-};
-
-beforeEach(() => {
-  fetchMock.post(
-    CHART_DATA_GLOB,
-    { result: [{ data: [] }] },
-    {
-      name: CHART_DATA_ROUTE,
-    },
-  );
-});
-
-// Remove only this file's route so global routes registered in
-// setupSupersetClient (e.g. CSRF) survive into the next test.
-afterEach(() => {
-  fetchMock.clearHistory();
-  fetchMock.removeRoutes({ names: [CHART_DATA_ROUTE] });
-});
-
-test('forwards url_params from form_data onto each query in the chart-data request body', async () => {
-  await getChartDataRequest({ formData: buildFormData() });
-
-  const body = lastChartDataBody();
-  expect(Array.isArray(body.queries)).toBe(true);
-  expect(body.queries.length).toBeGreaterThan(0);
-  body.queries.forEach(query => {
-    expect(query.url_params).toEqual(URL_PARAMS);
-  });
-});
-
-test('preserves url_params on form_data echoed back in the chart-data request body', async () => {
-  await getChartDataRequest({ formData: buildFormData() });
-
-  const body = lastChartDataBody();
-  expect(body.form_data.url_params).toEqual(URL_PARAMS);
-});
-
-// buildQueryObject defaults missing url_params to `{}` (see
-// packages/superset-ui-core/src/query/buildQueryObject.ts), so the chart-data
-// request body carries an empty object — not `undefined`. This test documents
-// that contract; a future change that flips the default should update both.
-test('emits an empty url_params object on each query when form_data has none', async () => {
-  await getChartDataRequest({
-    formData: buildFormData({ url_params: undefined }),
-  });
-
-  const body = lastChartDataBody();
-  expect(body.queries.length).toBeGreaterThan(0);
-  body.queries.forEach(query => {
-    expect(query.url_params).toEqual({});
-  });
-});

superset-frontend/src/components/StreamingExportModal/useStreamingExport.test.ts

@@ -48,11 +48,11 @@ global.URL.revokeObjectURL = jest.fn();
 
 global.fetch = jest.fn();
 
+const { SupersetClient } = jest.requireMock('@superset-ui/core');
+
 beforeEach(() => {
   jest.clearAllMocks();
   global.fetch = jest.fn();
-  const { SupersetClient } = jest.requireMock('@superset-ui/core');
-  SupersetClient.getCSRFToken.mockResolvedValue('mock-csrf-token');
   SupersetClient.getGuestToken.mockReturnValue(undefined);
 });
 
@@ -228,7 +228,6 @@ test('sets ERROR status and calls onError when fetch rejects', async () => {
 // URL prefix guard tests - prevent regression of missing app root prefix
 const { applicationRoot } = jest.requireMock('src/utils/getBootstrapData');
 const { makeUrl } = jest.requireMock('src/utils/pathUtils');
-const { SupersetClient } = jest.requireMock('@superset-ui/core');
 
 const createPrefixTestMockFetch = () =>
   jest.fn().mockResolvedValue({
@@ -243,107 +242,6 @@ const createPrefixTestMockFetch = () =>
     },
   });
 
-test('guest-token chart exports skip CSRF fetch and include guest_token form field', async () => {
-  applicationRoot.mockReturnValue('');
-  SupersetClient.getGuestToken.mockReturnValue('guest-token');
-  SupersetClient.getCSRFToken.mockRejectedValue(new Error('CSRF forbidden'));
-
-  const csvData = new TextEncoder().encode('id,name\n1,Alice\n');
-  let readCount = 0;
-  const mockFetch = jest.fn().mockResolvedValue({
-    ok: true,
-    headers: new Headers({
-      'Content-Disposition': 'attachment; filename="embedded.csv"',
-    }),
-    body: {
-      getReader: () => ({
-        read: jest.fn().mockImplementation(() => {
-          readCount += 1;
-          if (readCount === 1) {
-            return Promise.resolve({ done: false, value: csvData });
-          }
-          return Promise.resolve({ done: true, value: undefined });
-        }),
-      }),
-    },
-  });
-  global.fetch = mockFetch;
-
-  const { result } = renderHook(() => useStreamingExport());
-
-  act(() => {
-    result.current.startExport({
-      url: '/api/v1/chart/data',
-      payload: { datasource: '1__table', viz_type: 'table' },
-      exportType: 'csv',
-      exportSource: 'chart',
-      expectedRows: 100000,
-    });
-  });
-
-  await waitFor(() => {
-    expect(result.current.progress.status).toBe(ExportStatus.COMPLETED);
-  });
-
-  expect(SupersetClient.getCSRFToken).not.toHaveBeenCalled();
-  expect(mockFetch).toHaveBeenCalledTimes(1);
-  const [, requestInit] = mockFetch.mock.calls[0];
-  const body = requestInit.body as URLSearchParams;
-
-  expect(body.get('guest_token')).toBe('guest-token');
-  expect(body.get('expected_rows')).toBe('100000');
-  expect(body.get('form_data')).toBe(
-    JSON.stringify({ datasource: '1__table', viz_type: 'table' }),
-  );
-});
-
-test('non-guest chart exports fetch CSRF and include X-CSRFToken header', async () => {
-  applicationRoot.mockReturnValue('');
-
-  const csvData = new TextEncoder().encode('id,name\n1,Alice\n');
-  let readCount = 0;
-  const mockFetch = jest.fn().mockResolvedValue({
-    ok: true,
-    headers: new Headers({
-      'Content-Disposition': 'attachment; filename="chart.csv"',
-    }),
-    body: {
-      getReader: () => ({
-        read: jest.fn().mockImplementation(() => {
-          readCount += 1;
-          if (readCount === 1) {
-            return Promise.resolve({ done: false, value: csvData });
-          }
-          return Promise.resolve({ done: true, value: undefined });
-        }),
-      }),
-    },
-  });
-  global.fetch = mockFetch;
-
-  const { result } = renderHook(() => useStreamingExport());
-
-  act(() => {
-    result.current.startExport({
-      url: '/api/v1/chart/data',
-      payload: { datasource: '1__table', viz_type: 'table' },
-      exportType: 'csv',
-      exportSource: 'chart',
-    });
-  });
-
-  await waitFor(() => {
-    expect(result.current.progress.status).toBe(ExportStatus.COMPLETED);
-  });
-
-  expect(SupersetClient.getCSRFToken).toHaveBeenCalledTimes(1);
-  const [, requestInit] = mockFetch.mock.calls[0];
-  expect(requestInit.headers).toMatchObject({
-    'X-CSRFToken': 'mock-csrf-token',
-  });
-  expect((requestInit.body as URLSearchParams).has('guest_token')).toBe(false);
-});
-
 test('chart streaming export includes guest token in form body when configured', async () => {
   SupersetClient.getGuestToken.mockReturnValue('guest-token');
   const mockFetch = createPrefixTestMockFetch();
@@ -356,7 +254,6 @@ test('chart streaming export includes guest token in form body when configured',
       url: '/api/v1/chart/data',
       payload: { datasource: '1__table', viz_type: 'table' },
       exportType: 'csv',
-      exportSource: 'chart',
     });
   });
 
@@ -371,70 +268,6 @@ test('chart streaming export includes guest token in form body when configured',
   );
 });
 
-test('SQL Lab exports fetch CSRF and omit guest_token even when guest token exists', async () => {
-  applicationRoot.mockReturnValue('');
-  SupersetClient.getGuestToken.mockReturnValue('guest-token');
-
-  const mockFetch = createPrefixTestMockFetch();
-  global.fetch = mockFetch;
-
-  const { result } = renderHook(() => useStreamingExport());
-
-  act(() => {
-    result.current.startExport({
-      url: '/api/v1/sqllab/export_streaming/',
-      payload: { client_id: 'test-id' },
-      exportType: 'csv',
-      exportSource: 'sqllab',
-    });
-  });
-
-  await waitFor(() => {
-    expect(mockFetch).toHaveBeenCalledTimes(1);
-  });
-
-  expect(SupersetClient.getCSRFToken).toHaveBeenCalledTimes(1);
-  const [, requestInit] = mockFetch.mock.calls[0];
-  const body = requestInit.body as URLSearchParams;
-
-  expect(requestInit.headers).toMatchObject({
-    'X-CSRFToken': 'mock-csrf-token',
-  });
-  expect(body.get('client_id')).toBe('test-id');
-  expect(body.has('guest_token')).toBe(false);
-});
-
-test('guest tokens do not bypass CSRF for unclassified non-client exports', async () => {
-  applicationRoot.mockReturnValue('');
-  SupersetClient.getGuestToken.mockReturnValue('guest-token');
-
-  const mockFetch = createPrefixTestMockFetch();
-  global.fetch = mockFetch;
-
-  const { result } = renderHook(() => useStreamingExport());
-
-  act(() => {
-    result.current.startExport({
-      url: '/api/v1/other/export_streaming/',
-      payload: { export_id: 'test-id' },
-      exportType: 'csv',
-    });
-  });
-
-  await waitFor(() => {
-    expect(mockFetch).toHaveBeenCalledTimes(1);
-  });
-
-  expect(SupersetClient.getCSRFToken).toHaveBeenCalledTimes(1);
-  const [, requestInit] = mockFetch.mock.calls[0];
-  const body = requestInit.body as URLSearchParams;
-
-  expect(requestInit.headers).toMatchObject({
-    'X-CSRFToken': 'mock-csrf-token',
-  });
-  expect(body.has('guest_token')).toBe(false);
-});
-
 test('URL prefix guard applies prefix to unprefixed relative URL when app root is configured', async () => {
   const appRoot = '/superset';
   applicationRoot.mockReturnValue(appRoot);

superset-frontend/src/components/StreamingExportModal/useStreamingExport.ts

@@ -31,8 +31,6 @@ interface StreamingExportPayload {
   [key: string]: any;
 }
 
-type StreamingExportSource = 'chart' | 'sqllab';
-
 interface StreamingExportParams {
   /**
    * The API endpoint URL for the export request.
@@ -48,7 +46,6 @@ interface StreamingExportParams {
   payload: StreamingExportPayload;
   filename?: string;
   exportType: 'csv' | 'xlsx';
-  exportSource?: StreamingExportSource;
   expectedRows?: number;
 }
 
@@ -98,7 +95,6 @@ const createFetchRequest = async (
   payload: StreamingExportPayload,
   filename: string | undefined,
   _exportType: string,
-  exportSource: StreamingExportSource | undefined,
   expectedRows: number | undefined,
   signal: AbortSignal,
 ): Promise<RequestInit> => {
@@ -106,19 +102,10 @@ const createFetchRequest = async (
     'Content-Type': 'application/x-www-form-urlencoded',
   };
 
-  const guestToken = SupersetClient.getGuestToken();
-  const isGuestTokenChartExport =
-    Boolean(guestToken) &&
-    exportSource === 'chart' &&
-    !('client_id' in payload);
-
-  // Embedded guest sessions cannot fetch CSRF tokens. Guest chart exports are
-  // safe because chart data is CSRF-exempt and auth is carried by guest_token.
-  if (!isGuestTokenChartExport) {
-    const csrfToken = await SupersetClient.getCSRFToken();
-    if (csrfToken) {
-      headers['X-CSRFToken'] = csrfToken;
-    }
+  // Get CSRF token using SupersetClient
+  const csrfToken = await SupersetClient.getCSRFToken();
+  if (csrfToken) {
+    headers['X-CSRFToken'] = csrfToken;
   }
 
   const formParams: Record<string, string> = {};
@@ -131,7 +118,8 @@ const createFetchRequest = async (
     formParams.expected_rows = expectedRows.toString();
   }
 
-  if (guestToken && isGuestTokenChartExport) {
+  const guestToken = SupersetClient.getGuestToken();
+  if (guestToken) {
     formParams.guest_token = guestToken;
   }
 
@@ -197,8 +185,7 @@ export const useStreamingExport = (options: UseStreamingExportOptions = {}) => {
 
   const executeExport = useCallback(
     async (params: StreamingExportParams) => {
-      const { url, payload, filename, exportType, exportSource, expectedRows } =
-        params;
+      const { url, payload, filename, exportType, expectedRows } = params;
       if (isExportingRef.current) {
         return;
       }
@@ -223,7 +210,6 @@ export const useStreamingExport = (options: UseStreamingExportOptions = {}) => {
           payload,
           filename,
           exportType,
-          exportSource,
           expectedRows,
           abortControllerRef.current.signal,
         );

superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.test.tsx

@@ -165,62 +165,6 @@ describe('DashboardBuilder', () => {
     expect(header).toBeInTheDocument();
   });
 
-  test('should hide DashboardHeader when standalone mode hides nav and title (?standalone=2)', () => {
-    // React-level equivalent of the legacy `cy.get('#app-menu').should('not.exist')`
-    // Cypress assertion. The `#app-menu` node lives in Flask's spa.html template,
-    // gated by `{% if standalone_mode %}`, so RTL cannot reach it directly.
-    // `?standalone=2` maps to DashboardStandaloneMode.HideNavAndTitle, which the
-    // DashboardBuilder honours by suppressing the React-side DashboardHeader.
-    const originalHref = window.location.href;
-    window.history.replaceState({}, '', '/?standalone=2');
-    try {
-      const { queryByTestId } = setup();
-      expect(
-        queryByTestId('dashboard-header-container'),
-      ).not.toBeInTheDocument();
-    } finally {
-      window.history.replaceState({}, '', originalHref);
-    }
-  });
-
-  test('should keep the DashboardHeader when standalone mode only hides nav (?standalone=1)', () => {
-    // `?standalone=1` maps to DashboardStandaloneMode.HideNav, which only hides the
-    // Flask-rendered global app menu (#app-menu) — it must NOT suppress the React-side
-    // DashboardHeader. This pins the boundary against HideNavAndTitle (?standalone=2).
-    const originalHref = window.location.href;
-    window.history.replaceState({}, '', '/?standalone=1');
-    try {
-      const { queryByTestId } = setup();
-      expect(queryByTestId('dashboard-header-container')).toBeInTheDocument();
-    } finally {
-      window.history.replaceState({}, '', originalHref);
-    }
-  });
-
-  test('should keep the header hidden in standalone mode (?standalone=2) while editMode is active', () => {
-    // Orthogonality analogue of the legacy `?edit=true&standalone=true` Cypress mount.
-    // editMode is sourced from Redux (state.dashboardState.editMode), not the URL —
-    // DashboardBuilder only reads URL_PARAMS.standalone — so the legacy `edit=true`
-    // param is inert here and is intentionally omitted. Contract under test:
-    // standalone=2 (HideNavAndTitle) suppresses DashboardHeader even while editMode
-    // drives the `dashboard--editing` class on the wrapper.
-    const originalHref = window.location.href;
-    window.history.replaceState({}, '', '/?standalone=2');
-    try {
-      const { getByTestId, queryByTestId } = setup({
-        dashboardState: { ...mockState.dashboardState, editMode: true },
-      });
-      expect(getByTestId('dashboard-content-wrapper')).toHaveClass(
-        'dashboard dashboard--editing',
-      );
-      expect(
-        queryByTestId('dashboard-header-container'),
-      ).not.toBeInTheDocument();
-    } finally {
-      window.history.replaceState({}, '', originalHref);
-    }
-  });
-
   test('should render a Sticky top-level Tabs if the dashboard has tabs', async () => {
     const { findAllByTestId } = setup({
       dashboardLayout: undoableDashboardLayoutWithTabs,

superset-frontend/src/explore/components/SaveModal.test.tsx

@@ -319,22 +319,6 @@ test('disables overwrite option for externally managed slice', () => {
   ).toBeInTheDocument();
 });
 
-test('enables overwrite option for admin non-owner', () => {
-  const { getByRole } = setup(
-    {},
-    mockStore({
-      ...initialState,
-      user: {
-        userId: 2,
-        username: 'Admin2',
-        roles: { Admin: Array(173) },
-        permissions: {},
-      },
-    }),
-  );
-  expect(getByRole('radio', { name: 'Save (Overwrite)' })).toBeEnabled();
-});
-
 test('updates slice name and selected dashboard', async () => {
   const dashboardId = mockEvent.value;
   const saveDataset = jest.fn().mockResolvedValue(undefined);

superset-frontend/src/explore/components/SaveModal.tsx

@@ -49,10 +49,7 @@ import {
 } from '@apache-superset/core/theme';
 import { Radio } from '@superset-ui/core/components/Radio';
 import { GRID_COLUMN_COUNT } from 'src/dashboard/util/constants';
-import {
-  canUserEditDashboard,
-  isUserAdmin,
-} from 'src/dashboard/util/permissionUtils';
+import { canUserEditDashboard } from 'src/dashboard/util/permissionUtils';
 import { setSaveChartModalVisibility } from 'src/explore/actions/saveModalActions';
 import { SaveActionType, ChartStatusType } from 'src/explore/types';
 import { UserWithPermissionsAndRoles } from 'src/types/bootstrapTypes';
@@ -128,8 +125,7 @@ class SaveModal extends Component<SaveModalProps, SaveModalState> {
 
   canOverwriteSlice(): boolean {
     return (
-      (isUserAdmin(this.props.user) ||
-        this.props.slice?.owners?.includes(this.props.user.userId)) &&
+      this.props.slice?.owners?.includes(this.props.user.userId) &&
       !this.props.slice?.is_managed_externally
     );
   }

superset-frontend/src/explore/exploreUtils/index.ts

@@ -99,7 +99,6 @@ interface ExportChartParams {
         url: string | null;
         payload: QueryFormData | ReturnType<typeof buildQueryContext>;
         exportType: string;
-        exportSource: 'chart';
       }) => void)
     | null;
 }
@@ -395,7 +394,6 @@ export const exportChart = async ({
       url: url ? ensureAppRoot(url) : url,
       payload,
       exportType: resultFormat,
-      exportSource: 'chart',
     });
   } else {
     // SupersetClient.postForm calls getUrl({ endpoint }) internally, which prepends