Compare commits

...

11 Commits

Author SHA1 Message Date
Amin Ghadersohi
93b693c92f fix(mcp): re-read json_metadata from re-fetched dashboard before cleanup
Moves the json_metadata read from before UpdateDashboardCommand.run() to
after the re-fetch so cleanup is applied to the latest persisted state.
The old approach read a pre-command snapshot and wrote it back after the
re-fetch, silently overwriting any concurrent edits to dashboard metadata.

Updates test_json_metadata_cleanup to place json_metadata on the re-fetched
dashboard mock (updated_dashboard), reflecting the new read path.
2026-06-29 17:27:00 +00:00
Amin Ghadersohi
fe7cdc4345 fix(mcp): clean default_filters and make metadata commit non-fatal
- _clean_json_metadata now also removes the chart's entry from
  default_filters (stored as a JSON-encoded string inside json_metadata),
  matching the pruning done by DashboardDAO.set_dash_metadata when
  the positions branch runs.
- The secondary json_metadata commit (written directly to avoid the
  set_dash_metadata positions-branch slices overwrite) is now wrapped
  in its own try/except: if it fails, the chart removal is still
  reported as successful and the error is logged as a warning, since
  the chart has already been detached from layout and slices.
- Update docstrings and module-level description to mention default_filters.
- Add test_clean_json_metadata_cleans_default_filters unit test.
- Extend test_json_metadata_cleanup to cover default_filters cleanup.
2026-06-29 16:39:50 +00:00
Amin Ghadersohi
283fb13393 fix(mcp): bypass set_dash_metadata positions branch when cleaning json_metadata
When remove_chart_from_dashboard cleaned stale references from
json_metadata and routed the updated blob through UpdateDashboardCommand,
DashboardDAO.set_dash_metadata's positions branch ran and overwrote
dashboard.slices from layout data — silently dropping charts that were
in the slices relationship but absent from position_json. Instead, write
the cleaned metadata directly to updated_dashboard.json_metadata and
commit, bypassing the positions branch entirely.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-26 15:55:31 +00:00
Amin Ghadersohi
ababf2a6dd fix(mcp): address review feedback on remove_chart_from_dashboard
- Fix ruff E501: shorten _call_remove docstring to ≤88 chars
- Add remove_chart_from_dashboard to FieldPermissionsMiddleware
  TOOL_OBJECT_TYPE_MAP (was missing, unlike add_chart_to_existing_dashboard)
- Add remove_chart_from_dashboard to tool-search-optimization.md mutate
  tools list for documentation consistency
- Add created_on/changed_on to the re-fetch-fallback DashboardInfo path
  so its shape matches the successful re-fetch path
- Add removed_layout_keys=[] and permission_denied=False to the exception
  handler response for a consistent schema across all code paths
2026-06-26 15:55:31 +00:00
Amin Ghadersohi
c7b6b31ed0 fix(mcp): handle string chartId in layout and non-dict position_json
- _find_chart_keys now matches chartId as both int and str to handle
  imported/hand-edited layouts where chartId may be stored as a string
- validate position_json parses to a dict before passing to layout helpers,
  preventing AttributeError on malformed-but-valid JSON (e.g. "[]")
- test: add return type annotation to mock_auth fixture; add docstrings
  to _chart_node and _call_remove test helpers

Addresses CodeAnt AI review findings on #40958.
2026-06-26 15:55:31 +00:00
Amin Ghadersohi
ca542f9ef4 feat(mcp): add remove_chart_from_dashboard tool 2026-06-26 15:55:31 +00:00
Gabriel Torres Ruiz
f49db9e536 fix(dashboard): restore page scrolling (#41439) 2026-06-26 12:54:19 -03:00
dependabot[bot]
84e07df735 chore(deps): bump react-draggable from 4.6.0 to 4.7.0 in /superset-frontend (#41446)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-06-26 08:31:37 -07:00
dependabot[bot]
b8f3918bcf chore(deps-dev): bump react-resizable from 4.0.1 to 4.0.2 in /superset-frontend (#41448)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-06-26 08:31:23 -07:00
dependabot[bot]
ee43d8869f chore(deps): bump nanoid from 5.1.11 to 5.1.14 in /superset-frontend (#41450)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-06-26 08:31:11 -07:00
Evan Rusackas
01a0c66c79 fix(sunburst): make "Show Null Values" non-breaking and cover all layers (#41442)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-06-26 08:30:09 -07:00
17 changed files with 1505 additions and 99 deletions

View File

@@ -115,7 +115,7 @@
"memoize-one": "^6.0.0",
"mousetrap": "^1.6.5",
"mustache": "^4.2.0",
"nanoid": "^5.1.11",
"nanoid": "^5.1.14",
"ol": "^10.9.0",
"query-string": "9.4.0",
"re-resizable": "^6.11.2",
@@ -267,7 +267,7 @@
"process": "^0.11.10",
"react-dnd-test-backend": "^16.0.1",
"react-refresh": "^0.18.0",
"react-resizable": "^4.0.1",
"react-resizable": "^4.0.2",
"redux-mock-store": "^1.5.4",
"source-map": "^0.7.6",
"source-map-support": "^0.5.21",
@@ -26533,21 +26533,6 @@
}
}
},
"node_modules/jsdom/node_modules/@noble/hashes": {
"version": "2.2.0",
"resolved": "https://registry.npmjs.org/@noble/hashes/-/hashes-2.2.0.tgz",
"integrity": "sha512-IYqDGiTXab6FniAgnSdZwgWbomxpy9FtYvLKs7wCUs2a8RkITG+DFGO1DM9cr+E3/RgADRpFjrKVaJ1z6sjtEg==",
"dev": true,
"license": "MIT",
"optional": true,
"peer": true,
"engines": {
"node": ">= 20.19.0"
},
"funding": {
"url": "https://paulmillr.com/funding/"
}
},
"node_modules/jsdom/node_modules/css-tree": {
"version": "3.2.1",
"resolved": "https://registry.npmjs.org/css-tree/-/css-tree-3.2.1.tgz",
@@ -31452,9 +31437,9 @@
}
},
"node_modules/nanoid": {
"version": "5.1.11",
"resolved": "https://registry.npmjs.org/nanoid/-/nanoid-5.1.11.tgz",
"integrity": "sha512-v+KEsUv2ps74PaSKv0gHTxTCgMXOIfBEbaqa6w6ISIGC7ZsvHN4N9oJ8d4cmf0n5oTzQz2SLmThbQWhjd/8eKg==",
"version": "5.1.14",
"resolved": "https://registry.npmjs.org/nanoid/-/nanoid-5.1.14.tgz",
"integrity": "sha512-5c8l8kVzqpnDPaicbEop/fV0Q1w16FmbWtVhMqugTozAwYdlIQojWH5a/M7UfziFmGdQRrUdV+EPzc9Xng3VAQ==",
"funding": [
{
"type": "github",
@@ -36305,9 +36290,9 @@
}
},
"node_modules/react-resizable": {
"version": "4.0.1",
"resolved": "https://registry.npmjs.org/react-resizable/-/react-resizable-4.0.1.tgz",
"integrity": "sha512-FR25Rcfxpi1iKiC7taIrqc1Tz6VnslqM94/IrA1LxoM5C3ap2EqaKLnCit/aKrcn3H4wfzO0nFBadFBc+SzEWA==",
"version": "4.0.2",
"resolved": "https://registry.npmjs.org/react-resizable/-/react-resizable-4.0.2.tgz",
"integrity": "sha512-jZD9ghYRmyJCw0+awYctSZ+9pmX1WXQvzDrTovELYc8obC/BShTI2r4c14LIVzeQ+vJZNb0yKM7bG2eqv7Vfyg==",
"dev": true,
"license": "MIT",
"dependencies": {
@@ -43585,21 +43570,6 @@
}
}
},
"node_modules/whatwg-url/node_modules/@noble/hashes": {
"version": "2.2.0",
"resolved": "https://registry.npmjs.org/@noble/hashes/-/hashes-2.2.0.tgz",
"integrity": "sha512-IYqDGiTXab6FniAgnSdZwgWbomxpy9FtYvLKs7wCUs2a8RkITG+DFGO1DM9cr+E3/RgADRpFjrKVaJ1z6sjtEg==",
"dev": true,
"license": "MIT",
"optional": true,
"peer": true,
"engines": {
"node": ">= 20.19.0"
},
"funding": {
"url": "https://paulmillr.com/funding/"
}
},
"node_modules/whatwg-url/node_modules/webidl-conversions": {
"version": "8.0.1",
"resolved": "https://registry.npmjs.org/webidl-conversions/-/webidl-conversions-8.0.1.tgz",
@@ -44851,7 +44821,7 @@
"parse-ms": "^4.0.0",
"re-resizable": "^6.11.2",
"react-ace": "^14.0.1",
"react-draggable": "^4.6.0",
"react-draggable": "^4.7.0",
"react-error-boundary": "6.0.0",
"react-js-cron": "^5.2.0",
"react-markdown": "^8.0.7",
@@ -44970,9 +44940,9 @@
}
},
"packages/superset-ui-core/node_modules/react-draggable": {
"version": "4.6.0",
"resolved": "https://registry.npmjs.org/react-draggable/-/react-draggable-4.6.0.tgz",
"integrity": "sha512-g4vqY53xhmPrBnZvGP+1YQV0eYnB3o0VLzoi6q2IpwnQrxIZ34tYRKpVtsWIXPg4D/pvLn+oYCW5gOK2cWIrgA==",
"version": "4.7.0",
"resolved": "https://registry.npmjs.org/react-draggable/-/react-draggable-4.7.0.tgz",
"integrity": "sha512-kTpANmKWVnFXiZ76Ag2ZowiFStuBYnJ606PI1TbUsOg29/400/JNIxI9+CuenhiAqFuXWJffz6F4UI3R51kUug==",
"license": "MIT",
"dependencies": {
"clsx": "^2.1.1",
@@ -45681,6 +45651,36 @@
"version": "1.0.0",
"extraneous": true,
"license": "Apache-2.0"
},
"node_modules/jsdom/node_modules/@noble/hashes": {
"version": "2.2.0",
"resolved": "https://registry.npmjs.org/@noble/hashes/-/hashes-2.2.0.tgz",
"integrity": "sha512-IYqDGiTXab6FniAgnSdZwgWbomxpy9FtYvLKs7wCUs2a8RkITG+DFGO1DM9cr+E3/RgADRpFjrKVaJ1z6sjtEg==",
"dev": true,
"license": "MIT",
"optional": true,
"peer": true,
"engines": {
"node": ">= 20.19.0"
},
"funding": {
"url": "https://paulmillr.com/funding/"
}
},
"node_modules/whatwg-url/node_modules/@noble/hashes": {
"version": "2.2.0",
"resolved": "https://registry.npmjs.org/@noble/hashes/-/hashes-2.2.0.tgz",
"integrity": "sha512-IYqDGiTXab6FniAgnSdZwgWbomxpy9FtYvLKs7wCUs2a8RkITG+DFGO1DM9cr+E3/RgADRpFjrKVaJ1z6sjtEg==",
"dev": true,
"license": "MIT",
"optional": true,
"peer": true,
"engines": {
"node": ">= 20.19.0"
},
"funding": {
"url": "https://paulmillr.com/funding/"
}
}
}
}

View File

@@ -198,7 +198,7 @@
"memoize-one": "^6.0.0",
"mousetrap": "^1.6.5",
"mustache": "^4.2.0",
"nanoid": "^5.1.11",
"nanoid": "^5.1.14",
"ol": "^10.9.0",
"query-string": "9.4.0",
"re-resizable": "^6.11.2",
@@ -350,7 +350,7 @@
"process": "^0.11.10",
"react-dnd-test-backend": "^16.0.1",
"react-refresh": "^0.18.0",
"react-resizable": "^4.0.1",
"react-resizable": "^4.0.2",
"redux-mock-store": "^1.5.4",
"source-map": "^0.7.6",
"source-map-support": "^0.5.21",

View File

@@ -52,7 +52,7 @@
"parse-ms": "^4.0.0",
"re-resizable": "^6.11.2",
"react-ace": "^14.0.1",
"react-draggable": "^4.6.0",
"react-draggable": "^4.7.0",
"react-error-boundary": "6.0.0",
"react-js-cron": "^5.2.0",
"react-markdown": "^8.0.7",

View File

@@ -186,7 +186,9 @@ export default function transformProps(
showLabels,
showLabelsThreshold,
showTotal,
showNullValues,
// Default to true so charts saved before this control existed keep
// showing null values instead of silently hiding them on upgrade.
showNullValues = true,
sliceId,
} = formData;
const {

View File

@@ -40,7 +40,7 @@ export function treeBuilder(
): TreeNode[] {
const [curGroupBy, ...restGroupby] = groupBy;
const curData = _groupBy(data, curGroupBy);
return transform(
const nodes = transform(
curData,
(result, value, key) => {
const name = curData[key][0][curGroupBy]!;
@@ -59,6 +59,9 @@ export function treeBuilder(
result.push(item);
});
} else {
// Children are already null-filtered by the recursive call, so the
// parent's value/secondaryValue exclude hidden nulls. This keeps the
// parent arc sized to its visible children (no empty gap).
const children = treeBuilder(
value,
restGroupby,
@@ -76,12 +79,9 @@ export function treeBuilder(
0,
)
: metricValue;
const validChildren = filterNullNames
? children.filter(child => child.name !== null)
: children;
result.push({
name,
children: validChildren,
children,
value: metricValue,
secondaryValue,
groupBy: curGroupBy,
@@ -90,4 +90,13 @@ export function treeBuilder(
},
[] as TreeNode[],
);
// Filter at every level so single-level charts and root nodes are covered,
// not just nested children. A parent whose children were all null-filtered
// is dropped too: keeping it would leave a zero-value arc that yields a NaN
// secondaryValue/value ratio for coloring and tooltips.
return filterNullNames
? nodes.filter(
node => node.name !== null && node.children?.length !== 0,
)
: nodes;
}

View File

@@ -21,6 +21,13 @@ import { supersetTheme } from '@apache-superset/core/theme';
import { EchartsSunburstChartProps } from '../../src/Sunburst/types';
import transformProps from '../../src/Sunburst/transformProps';
type SunburstSeries = {
label?: Record<string, unknown>;
data: { value: number }[];
};
const firstSeries = (echartOptions: unknown) =>
(echartOptions as { series: SunburstSeries[] }).series[0];
const formData = {
colorScheme: 'bnbColors',
datasource: '3__table',
@@ -47,7 +54,52 @@ test('series label has no textBorderColor or textBorderWidth', () => {
const { echartOptions } = transformProps(
chartProps as EchartsSunburstChartProps,
);
const series = (echartOptions as any).series[0];
const series = firstSeries(echartOptions);
expect(series.label).not.toHaveProperty('textBorderColor');
expect(series.label).not.toHaveProperty('textBorderWidth');
});
const nullValueProps = (showNullValues?: boolean) =>
new ChartProps({
formData: {
colorScheme: 'bnbColors',
datasource: '3__table',
columns: ['category'],
metric: 'sum__value',
...(showNullValues === undefined ? {} : { showNullValues }),
},
width: 800,
height: 600,
queriesData: [
{
data: [
{ category: 'A', sum__value: 10 },
{ category: 'B', sum__value: 20 },
{ category: null, sum__value: 5 },
],
},
],
theme: supersetTheme,
});
const seriesValues = (props: ChartProps) => {
const { echartOptions } = transformProps(props as EchartsSunburstChartProps);
return firstSeries(echartOptions)
.data.map(node => node.value)
.sort((a, b) => a - b);
};
// Charts saved before the "Show Null Values" control existed have no
// `showNullValues` in form data; they must keep showing nulls (non-breaking).
test('keeps null values when showNullValues is unset (legacy charts)', () => {
expect(seriesValues(nullValueProps(undefined))).toEqual([5, 10, 20]);
});
test('keeps null values when showNullValues is true', () => {
expect(seriesValues(nullValueProps(true))).toEqual([5, 10, 20]);
});
// Single-column sunburst: the toggle must actually drop the null node.
test('removes null values when showNullValues is false', () => {
expect(seriesValues(nullValueProps(false))).toEqual([10, 20]);
});

View File

@@ -394,7 +394,7 @@ describe('test treeBuilder', () => {
]);
});
test('filter null values', () => {
test('filter null values in a nested layer (parent total excludes hidden nulls)', () => {
const tree = treeBuilder(
[
...data,
@@ -426,6 +426,8 @@ describe('test treeBuilder', () => {
value: 2,
},
{
// The null `bar` child is removed AND its value is excluded from the
// parent total, so the arc stays sized to its visible children (no gap).
children: [
{
groupBy: 'bar',
@@ -436,8 +438,8 @@ describe('test treeBuilder', () => {
],
groupBy: 'foo',
name: 'a-2',
secondaryValue: 4,
value: 4,
secondaryValue: 2,
value: 2,
},
{
children: [
@@ -511,4 +513,137 @@ describe('test treeBuilder', () => {
},
]);
});
// Regression: a single-level (single column) sunburst previously never
// filtered, because filtering only happened in the multi-level branch.
test('single-level: shows null nodes when filtering is off', () => {
const tree = treeBuilder(
[
{ foo: 'a', count: 2, count2: 3 },
{ foo: null, count: 5, count2: 7 },
],
['foo'],
'count',
);
expect(tree).toEqual([
{ groupBy: 'foo', name: 'a', secondaryValue: 2, value: 2 },
{ groupBy: 'foo', name: null, secondaryValue: 5, value: 5 },
]);
});
test('single-level: removes null nodes when filtering is on', () => {
const tree = treeBuilder(
[
{ foo: 'a', count: 2, count2: 3 },
{ foo: null, count: 5, count2: 7 },
],
['foo'],
'count',
undefined,
true,
);
expect(tree).toEqual([
{ groupBy: 'foo', name: 'a', secondaryValue: 2, value: 2 },
]);
});
// Regression: a null in the *root* (first) column previously slipped through
// because the top-level result array was never filtered.
test('multi-level: shows null root node when filtering is off', () => {
const tree = treeBuilder(
[
{ foo: 'a-1', bar: 'a', count: 2, count2: 3 },
{ foo: null, bar: 'x', count: 5, count2: 7 },
],
['foo', 'bar'],
'count',
);
expect(tree).toEqual([
{
children: [{ groupBy: 'bar', name: 'a', secondaryValue: 2, value: 2 }],
groupBy: 'foo',
name: 'a-1',
secondaryValue: 2,
value: 2,
},
{
children: [{ groupBy: 'bar', name: 'x', secondaryValue: 5, value: 5 }],
groupBy: 'foo',
name: null,
secondaryValue: 5,
value: 5,
},
]);
});
test('multi-level: removes null root node (and its subtree) when filtering is on', () => {
const tree = treeBuilder(
[
{ foo: 'a-1', bar: 'a', count: 2, count2: 3 },
{ foo: null, bar: 'x', count: 5, count2: 7 },
],
['foo', 'bar'],
'count',
undefined,
true,
);
expect(tree).toEqual([
{
children: [{ groupBy: 'bar', name: 'a', secondaryValue: 2, value: 2 }],
groupBy: 'foo',
name: 'a-1',
secondaryValue: 2,
value: 2,
},
]);
});
// With a secondary metric, the parent's secondaryValue must also exclude the
// hidden null child rather than leaving a stale (inflated) total.
test('filtering excludes hidden nulls from secondary-metric totals', () => {
const tree = treeBuilder(
[
{ foo: 'p', bar: 'a', count: 2, count2: 3 },
{ foo: 'p', bar: null, count: 2, count2: 7 },
],
['foo', 'bar'],
'count',
'count2',
true,
);
expect(tree).toEqual([
{
children: [{ groupBy: 'bar', name: 'a', secondaryValue: 3, value: 2 }],
groupBy: 'foo',
name: 'p',
secondaryValue: 3,
value: 2,
},
]);
});
// A parent whose children are all null must be dropped, not kept as a
// zero-value arc: a retained `value: 0` node yields NaN for the
// secondaryValue/value ratio used in linear coloring and tooltips.
test('filtering drops parents left with no children', () => {
const tree = treeBuilder(
[
{ foo: 'keep', bar: 'a', count: 2, count2: 3 },
{ foo: 'drop', bar: null, count: 5, count2: 7 },
],
['foo', 'bar'],
'count',
'count2',
true,
);
expect(tree).toEqual([
{
children: [{ groupBy: 'bar', name: 'a', secondaryValue: 3, value: 2 }],
groupBy: 'foo',
name: 'keep',
secondaryValue: 3,
value: 2,
},
]);
});
});

View File

@@ -32,11 +32,7 @@ fetchMock.put('glob:*/api/v1/dashboard/*/colors*', {});
fetchMock.post('glob:*/superset/log/?*', {});
jest.mock('@visx/responsive', () => ({
ParentSize: ({
children,
}: {
children: (props: { width: number }) => JSX.Element;
}) => children({ width: 800 }),
useParentSize: () => ({ parentRef: { current: null }, width: 800 }),
}));
jest.mock('src/dashboard/containers/DashboardGrid', () => ({

View File

@@ -38,7 +38,7 @@ import {
NativeFilterType,
getLabelsColorMap,
} from '@superset-ui/core';
import { ParentSize } from '@visx/responsive';
import { useParentSize } from '@visx/responsive';
import Tabs from '@superset-ui/core/components/Tabs';
import DashboardGrid from 'src/dashboard/containers/DashboardGrid';
import {
@@ -374,9 +374,13 @@ const DashboardContainer: FC<DashboardContainerProps> = ({ topLevelTabs }) => {
[activeKey, childIds, dashboardLayout, handleFocus, renderTabBar, tabIndex],
);
// Hook form, not <ParentSize>: @visx 4.0.0's component clips content taller
// than the viewport, which breaks dashboard page scrolling.
const { parentRef, width } = useParentSize();
return (
<div className="grid-container" data-test="grid-container">
<ParentSize>{renderParentSizeChildren}</ParentSize>
<div className="grid-container" data-test="grid-container" ref={parentRef}>
{renderParentSizeChildren({ width })}
</div>
);
};

View File

@@ -123,13 +123,24 @@ const contentCss = css`
position: relative;
`;
/**
* Renders the main content area. When the chat panel is open in panel mode,
* wraps <Layout> and <ChatPanelContent> in a Splitter so they sit side-by-side
* with a lazy drag bar (blue preview line, resize committed on mouseup).
* The full <Layout> tree lives inside the first panel so its internal flex
* context is preserved — SQL Lab, Explore, and other pages are unaffected.
*/
// Chat panel mode locks the shell (content scrolls inside its panel); every
// other state page-scrolls so the navbar hides on scroll.
const lockedShellCss = css`
height: 100vh;
overflow: hidden;
`;
const pageScrollShellCss = css`
min-height: 100vh;
`;
const pageScrollContentCss = css`
display: flex;
flex-direction: column;
`;
// Renders the app shell and picks the scroll model: in chat panel mode <Layout>
// sits in a Splitter beside the chat panel; otherwise the page scrolls normally.
const AppContent = () => {
const isAuthenticated =
isUser(bootstrapData.user) && !bootstrapData.user.isAnonymous;
@@ -145,23 +156,14 @@ const AppContent = () => {
);
const layoutContent = (
<Layout css={layoutCss}>
<Layout.Content css={contentCss}>
<Layout css={isPanelOpen ? layoutCss : undefined}>
<Layout.Content css={isPanelOpen ? contentCss : pageScrollContentCss}>
<RouteSwitch />
</Layout.Content>
</Layout>
);
if (!isPanelOpen) {
return (
<>
{layoutContent}
{hasChatExtension && <ChatFloatingHost />}
</>
);
}
return (
const content = isPanelOpen ? (
<Splitter
lazy
onResizeEnd={sizes => {
@@ -194,6 +196,21 @@ const AppContent = () => {
<ChatPanelHost />
</Splitter.Panel>
</Splitter>
) : (
<>
{layoutContent}
{hasChatExtension && <ChatFloatingHost />}
</>
);
return (
<Flex vertical css={isPanelOpen ? lockedShellCss : pageScrollShellCss}>
<Menu
data={bootstrapData.common.menu_data}
isFrontendRoute={isFrontendRoute}
/>
<ExtensionsStartup>{content}</ExtensionsStartup>
</Flex>
);
};
@@ -202,21 +219,7 @@ const App = () => (
<ScrollToTop />
<LocationPathnameLogger />
<RootContextProviders>
<Flex
vertical
css={css`
height: 100vh;
overflow: hidden;
`}
>
<Menu
data={bootstrapData.common.menu_data}
isFrontendRoute={isFrontendRoute}
/>
<ExtensionsStartup>
<AppContent />
</ExtensionsStartup>
</Flex>
<AppContent />
<ToastContainer />
</RootContextProviders>
</Router>

View File

@@ -131,6 +131,7 @@ Dashboard Management:
- generate_dashboard: Create a dashboard from chart IDs (requires write access)
- update_dashboard: Update an existing dashboard's title/description/slug/published/layout/theme/CSS (requires write access; ownership-checked per-instance)
- add_chart_to_existing_dashboard: Add a chart to an existing dashboard (requires write access)
- remove_chart_from_dashboard: Remove a chart from an existing dashboard (requires write access)
Annotation Layers:
- list_annotation_layers: List annotation layers with advanced filters (1-based pagination)
@@ -425,7 +426,8 @@ Input format:
{_instance_info_role_bullet}- ALWAYS check the user's roles BEFORE suggesting write operations (creating datasets,
charts, or dashboards). SQL execution is a separate permission — see execute_sql below.
- Write tools (generate_chart, generate_dashboard, update_chart, create_dataset, create_virtual_dataset,
save_sql_query, add_chart_to_existing_dashboard, update_chart_preview) require write
save_sql_query, add_chart_to_existing_dashboard, remove_chart_from_dashboard,
update_chart_preview) require write
permissions. These tools are only listed for users who have the necessary access.
If a write tool does not appear in the tool list, the current user lacks write access.
- execute_sql requires SQL Lab access (execute_sql_query permission), which is separate
@@ -695,6 +697,7 @@ from superset.mcp_service.dashboard.tool import ( # noqa: F401, E402
get_dashboard_info,
get_dashboard_layout,
list_dashboards,
remove_chart_from_dashboard,
update_dashboard,
)
from superset.mcp_service.database.tool import ( # noqa: F401, E402

View File

@@ -600,6 +600,58 @@ class AddChartToDashboardResponse(BaseModel):
return sanitize_for_llm_context(value, field_path=("error",))
class RemoveChartFromDashboardRequest(BaseModel):
"""Request schema for removing a chart from an existing dashboard."""
dashboard_id: int = Field(
..., description="ID of the dashboard to remove the chart from"
)
chart_id: int = Field(
..., description="ID of the chart to remove from the dashboard"
)
class RemoveChartFromDashboardResponse(BaseModel):
"""Response schema for removing a chart from a dashboard."""
dashboard: DashboardInfo | None = Field(
None, description="The updated dashboard info, if successful"
)
dashboard_url: str | None = Field(
None, description="URL to view the updated dashboard"
)
removed_layout_keys: list[str] = Field(
default_factory=list,
description=(
"Layout component IDs that were removed from position_json "
"(the CHART components plus any ROW/COLUMN containers that "
"became empty as a result)."
),
)
error: str | None = Field(None, description="Error message, if operation failed")
permission_denied: bool = Field(
default=False,
description=(
"True when the operation failed because the current user does not "
"have edit rights on the target dashboard. When True, inform the "
"user — do NOT attempt a workaround without confirming first."
),
)
@field_validator("error")
@classmethod
def sanitize_error_for_llm_context(cls, value: str | None) -> str | None:
"""Wrap error text before it is exposed to LLM context.
The error may echo dashboard-controlled text (e.g. the dashboard
title), which must be wrapped so the LLM treats it as data, not
instructions.
"""
if value is None:
return value
return sanitize_for_llm_context(value, field_path=("error",))
class GenerateDashboardRequest(BaseModel):
"""Request schema for generating a dashboard."""

View File

@@ -20,6 +20,7 @@ from .generate_dashboard import generate_dashboard
from .get_dashboard_info import get_dashboard_info
from .get_dashboard_layout import get_dashboard_layout
from .list_dashboards import list_dashboards
from .remove_chart_from_dashboard import remove_chart_from_dashboard
from .update_dashboard import update_dashboard
__all__ = [
@@ -28,5 +29,6 @@ __all__ = [
"get_dashboard_layout",
"generate_dashboard",
"add_chart_to_existing_dashboard",
"remove_chart_from_dashboard",
"update_dashboard",
]

View File

@@ -0,0 +1,491 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
"""
MCP tool: remove_chart_from_dashboard
This tool removes a chart from an existing dashboard. It is the inverse of
add_chart_to_existing_dashboard: it deletes the chart's CHART component(s)
from position_json (pruning ROW/COLUMN containers that become empty),
removes the chart from the dashboard's slices relationship, and cleans
stale references to the chart from json_metadata (expanded_slices,
timed_refresh_immune_slices, filter_scopes, default_filters).
"""
import logging
from typing import Any, Dict
from fastmcp import Context
from sqlalchemy.exc import SQLAlchemyError
from superset_core.mcp.decorators import tool, ToolAnnotations
from superset.commands.exceptions import CommandException
from superset.extensions import event_logger
from superset.mcp_service.dashboard.schemas import (
DashboardInfo,
RemoveChartFromDashboardRequest,
RemoveChartFromDashboardResponse,
serialize_chart_summary,
)
from superset.mcp_service.privacy import user_can_view_data_model_metadata
from superset.mcp_service.utils.url_utils import get_superset_base_url
from superset.utils import json
logger = logging.getLogger(__name__)
# Container types that should be deleted once they have no children left.
# TAB/TABS/GRID/ROOT containers are intentionally kept even when empty —
# deleting a TAB would silently change the dashboard's visible structure.
_PRUNABLE_TYPES = ("ROW", "COLUMN")
def _find_chart_keys(layout: Dict[str, Any], chart_id: int) -> list[str]:
"""Return all layout keys of CHART components referencing *chart_id*.
A chart can legitimately appear more than once in a layout (e.g. under
multiple tabs), so all occurrences are returned.
"""
# Accept both int and string chartId — position_json is user/frontend-authored
# and imported or hand-edited layouts may store chartId as a string.
return [
key
for key, node in layout.items()
if isinstance(node, dict)
and node.get("type") == "CHART"
and (node.get("meta") or {}).get("chartId") in (chart_id, str(chart_id))
]
def _find_parent_key(layout: Dict[str, Any], component_key: str) -> str | None:
"""Find the component whose children list contains *component_key*.
The reverse lookup scans children lists instead of trusting the
``parents`` metadata on the node, which can be stale in hand-edited or
programmatically generated layouts.
"""
for key, node in layout.items():
if not isinstance(node, dict):
continue
children = node.get("children")
if isinstance(children, list) and component_key in children:
return key
return None
def _remove_component_and_prune(
layout: Dict[str, Any], component_key: str
) -> list[str]:
"""Remove *component_key* from the layout and prune empty containers.
Walks up the parent chain deleting ROW/COLUMN containers that become
empty as a result of the removal, so no orphaned wrapper nodes are left
behind. Returns the list of removed layout keys.
"""
removed: list[str] = []
parent_key = _find_parent_key(layout, component_key)
layout.pop(component_key, None)
removed.append(component_key)
child_key = component_key
while parent_key is not None:
parent = layout.get(parent_key)
if not isinstance(parent, dict):
break
children = parent.get("children")
if isinstance(children, list):
parent["children"] = [c for c in children if c != child_key]
if parent.get("type") in _PRUNABLE_TYPES and not parent.get("children"):
grandparent_key = _find_parent_key(layout, parent_key)
layout.pop(parent_key, None)
removed.append(parent_key)
child_key = parent_key
parent_key = grandparent_key
else:
break
return removed
def _remove_chart_from_layout(layout: Dict[str, Any], chart_id: int) -> list[str]:
"""Remove every CHART component for *chart_id* from the layout.
Returns all removed layout keys (charts plus pruned containers).
"""
removed: list[str] = []
for chart_key in _find_chart_keys(layout, chart_id):
# The chart key may already be gone if it shared a pruned container.
if chart_key in layout:
removed.extend(_remove_component_and_prune(layout, chart_key))
return removed
def _remove_id_from_list(values: Any, chart_id: int) -> tuple[Any, bool]:
"""Return (new_list, changed) with *chart_id* removed from a list of IDs.
Handles both int and str representations since json_metadata is
user/frontend-authored and not strictly typed.
"""
if not isinstance(values, list):
return values, False
filtered = [v for v in values if v != chart_id and v != str(chart_id)]
return filtered, len(filtered) != len(values)
def _clean_json_metadata(metadata: Dict[str, Any], chart_id: int) -> bool:
"""Remove stale references to *chart_id* from a json_metadata dict.
Cleans ``expanded_slices`` (dict keyed by chart ID), ``filter_scopes``
(dict keyed by filter chart ID, with per-column ``immune`` ID lists),
``timed_refresh_immune_slices`` (list of chart IDs), and
``default_filters`` (a JSON-encoded string whose keys are chart IDs).
Mutates *metadata* in place and returns True when anything changed.
"""
changed = False
chart_key = str(chart_id)
expanded_slices = metadata.get("expanded_slices")
if isinstance(expanded_slices, dict) and chart_key in expanded_slices:
del expanded_slices[chart_key]
changed = True
immune_slices, immune_changed = _remove_id_from_list(
metadata.get("timed_refresh_immune_slices"), chart_id
)
if immune_changed:
metadata["timed_refresh_immune_slices"] = immune_slices
changed = True
filter_scopes = metadata.get("filter_scopes")
if isinstance(filter_scopes, dict):
if chart_key in filter_scopes:
del filter_scopes[chart_key]
changed = True
for column_scopes in filter_scopes.values():
if not isinstance(column_scopes, dict):
continue
for column_config in column_scopes.values():
if not isinstance(column_config, dict):
continue
immune, immune_changed = _remove_id_from_list(
column_config.get("immune"), chart_id
)
if immune_changed:
column_config["immune"] = immune
changed = True
# default_filters is stored as a JSON-encoded string within json_metadata,
# with chart IDs as string keys (mirrors DashboardDAO.set_dash_metadata).
default_filters_raw = metadata.get("default_filters")
if isinstance(default_filters_raw, str):
try:
default_filters = json.loads(default_filters_raw)
if isinstance(default_filters, dict) and chart_key in default_filters:
del default_filters[chart_key]
metadata["default_filters"] = json.dumps(default_filters)
changed = True
except (json.JSONDecodeError, TypeError):
pass
elif isinstance(default_filters_raw, dict) and chart_key in default_filters_raw:
del default_filters_raw[chart_key]
changed = True
return changed
def _find_and_authorize_dashboard(
dashboard_id: int,
) -> tuple[Any, RemoveChartFromDashboardResponse | None]:
"""Return (dashboard, None) on success or (None, error_response) on failure.
Handles both the not-found case and the ownership check so the main tool
function doesn't need two separate branches for these pre-conditions.
"""
from superset import security_manager
from superset.daos.dashboard import DashboardDAO
from superset.exceptions import SupersetSecurityException
dashboard = DashboardDAO.find_by_id(dashboard_id)
if not dashboard:
return None, RemoveChartFromDashboardResponse(
dashboard=None,
dashboard_url=None,
error=(
f"Dashboard with ID {dashboard_id} not found."
" Use list_dashboards to get valid dashboard IDs."
),
)
try:
security_manager.raise_for_ownership(dashboard)
except SupersetSecurityException:
return None, RemoveChartFromDashboardResponse(
dashboard=None,
dashboard_url=None,
permission_denied=True,
error=(
f"You don't have permission to edit dashboard "
f"'{dashboard.dashboard_title}' (ID: {dashboard_id}). "
"Inform the user and do not attempt a workaround without "
"their confirmation."
),
)
return dashboard, None
@tool(
tags=["mutate"],
class_permission_name="Dashboard",
method_permission_name="write",
annotations=ToolAnnotations(
title="Remove chart from dashboard",
readOnlyHint=False,
destructiveHint=True,
),
)
def remove_chart_from_dashboard( # noqa: C901 — complexity is structural (layout traversal + multi-step authorization), not accidental
request: RemoveChartFromDashboardRequest, ctx: Context
) -> RemoveChartFromDashboardResponse:
"""
Remove a chart from an existing dashboard.
Deletes the chart's layout component(s) from the dashboard (all
occurrences, including under tabs), prunes rows/columns left empty by
the removal, detaches the chart from the dashboard, and cleans stale
chart references from dashboard metadata (expanded_slices,
timed_refresh_immune_slices, filter_scopes, default_filters). The chart
itself is NOT deleted and remains available to other dashboards.
"""
try:
from superset import db
from superset.commands.dashboard.update import UpdateDashboardCommand
# Validate dashboard exists and user has edit permission
with event_logger.log_context(
action="mcp.remove_chart_from_dashboard.validation"
):
dashboard, auth_error = _find_and_authorize_dashboard(request.dashboard_id)
if auth_error is not None:
return auth_error
# Remove the chart from the layout tree
with event_logger.log_context(action="mcp.remove_chart_from_dashboard.layout"):
try:
current_layout = json.loads(dashboard.position_json or "{}")
except (json.JSONDecodeError, TypeError):
current_layout = {}
if not isinstance(current_layout, dict):
current_layout = {}
remaining_slices = [
slc for slc in dashboard.slices if slc.id != request.chart_id
]
chart_in_slices = len(remaining_slices) != len(dashboard.slices)
removed_keys = _remove_chart_from_layout(current_layout, request.chart_id)
if not removed_keys and not chart_in_slices:
return RemoveChartFromDashboardResponse(
dashboard=None,
dashboard_url=None,
error=(
f"Chart {request.chart_id} is not in dashboard "
f"{request.dashboard_id}. Use get_dashboard_info to "
"see which charts the dashboard contains."
),
)
# Update the dashboard
with event_logger.log_context(
action="mcp.remove_chart_from_dashboard.db_write"
):
update_data: dict[str, Any] = {
"position_json": json.dumps(current_layout),
"slices": remaining_slices, # Pass ORM objects, not IDs
}
command = UpdateDashboardCommand(request.dashboard_id, update_data)
updated_dashboard = command.run()
# Re-fetch the dashboard with eager-loaded relationships to avoid
# "Instance is not bound to a Session" errors when serializing
# chart tags. The preceding command.run() commit may
# invalidate the session in multi-tenant environments; on failure,
# return a minimal response using only scalar attributes that are
# already loaded — relationship fields (tags, slices) would
# trigger lazy-loading on the same dead session.
from sqlalchemy.orm import subqueryload
from superset.daos.dashboard import DashboardDAO
from superset.models.dashboard import Dashboard
from superset.models.slice import Slice
try:
updated_dashboard = (
DashboardDAO.find_by_id(
updated_dashboard.id,
query_options=[
subqueryload(Dashboard.slices).subqueryload(Slice.tags),
subqueryload(Dashboard.tags),
],
)
or updated_dashboard
)
except SQLAlchemyError:
logger.warning(
"Re-fetch of dashboard %s failed; returning minimal response",
updated_dashboard.id,
exc_info=True,
)
try:
db.session.rollback() # pylint: disable=consider-using-transaction
except SQLAlchemyError:
logger.warning(
"Database rollback failed during dashboard re-fetch error handling",
exc_info=True,
)
dashboard_url = (
f"{get_superset_base_url()}/superset/dashboard/{updated_dashboard.id}/"
)
return RemoveChartFromDashboardResponse(
dashboard=DashboardInfo(
id=updated_dashboard.id,
dashboard_title=updated_dashboard.dashboard_title,
published=updated_dashboard.published,
created_on=updated_dashboard.created_on,
changed_on=updated_dashboard.changed_on,
chart_count=len(remaining_slices),
url=dashboard_url,
),
dashboard_url=dashboard_url,
removed_layout_keys=removed_keys,
error=None,
)
# Clean stale chart references from json_metadata without routing
# through UpdateDashboardCommand: that path calls
# DashboardDAO.set_dash_metadata which, when "positions" is
# present in the metadata blob, overwrites dashboard.slices from
# layout data and silently drops charts attached via the slices
# relationship but absent from position_json.
#
# Read from the re-fetched dashboard so cleanup is applied to the
# latest persisted state rather than the pre-command snapshot,
# avoiding silent overwrites of concurrent metadata edits.
try:
metadata = json.loads(updated_dashboard.json_metadata or "{}")
except (json.JSONDecodeError, TypeError):
metadata = None
metadata_changed = isinstance(metadata, dict) and _clean_json_metadata(
metadata, request.chart_id
)
# Best-effort secondary write: the chart has already been removed from
# layout and slices (committed above). If this commit fails, log a
# warning but return success — stale metadata is preferable to
# reporting failure after a successful removal.
if metadata_changed and isinstance(metadata, dict):
from superset import db
try:
updated_dashboard.json_metadata = json.dumps(metadata)
db.session.commit() # pylint: disable=consider-using-transaction
except SQLAlchemyError:
logger.warning(
"json_metadata cleanup commit failed for dashboard %s after "
"removing chart %s; chart removal succeeded",
request.dashboard_id,
request.chart_id,
exc_info=True,
)
try:
db.session.rollback() # pylint: disable=consider-using-transaction
except SQLAlchemyError:
logger.warning(
"Rollback failed during json_metadata cleanup", exc_info=True
)
# Convert to response format
from superset.mcp_service.dashboard.schemas import (
serialize_tag_object,
)
include_data_model_metadata = user_can_view_data_model_metadata()
dashboard_info = DashboardInfo(
id=updated_dashboard.id,
dashboard_title=updated_dashboard.dashboard_title,
slug=updated_dashboard.slug,
description=updated_dashboard.description,
published=updated_dashboard.published,
created_on=updated_dashboard.created_on,
changed_on=updated_dashboard.changed_on,
uuid=str(updated_dashboard.uuid) if updated_dashboard.uuid else None,
url=f"{get_superset_base_url()}/superset/dashboard/{updated_dashboard.id}/",
chart_count=len(updated_dashboard.slices),
tags=[
serialize_tag_object(tag)
for tag in getattr(updated_dashboard, "tags", [])
if serialize_tag_object(tag) is not None
],
charts=[
obj
for chart in getattr(updated_dashboard, "slices", [])
if (
obj := serialize_chart_summary(
chart,
include_data_model_metadata=include_data_model_metadata,
)
)
is not None
],
)
dashboard_url = (
f"{get_superset_base_url()}/superset/dashboard/{updated_dashboard.id}/"
)
logger.info(
"Removed chart %s from dashboard %s",
request.chart_id,
request.dashboard_id,
)
return RemoveChartFromDashboardResponse(
dashboard=dashboard_info,
dashboard_url=dashboard_url,
removed_layout_keys=removed_keys,
error=None,
)
except (CommandException, SQLAlchemyError, KeyError, ValueError) as e:
from superset import db
try:
db.session.rollback() # pylint: disable=consider-using-transaction
except SQLAlchemyError:
logger.warning(
"Database rollback failed during error handling", exc_info=True
)
logger.error("Error removing chart from dashboard: %s", e)
return RemoveChartFromDashboardResponse(
dashboard=None,
dashboard_url=None,
removed_layout_keys=[],
permission_denied=False,
error=f"Failed to remove chart from dashboard: {str(e)}",
)

View File

@@ -34,7 +34,7 @@ Superset MCP tools are categorized with tags to help clients configure optimal l
| `core` | Essential discovery and health tools | `health_check`, `get_instance_info`, `list_charts`, `list_dashboards`, `list_datasets` | Always load |
| `discovery` | Detailed resource information and schema | `get_chart_info`, `get_dashboard_info`, `get_dataset_info`, `get_schema` | Can defer |
| `data` | Data retrieval and previews | `get_chart_preview`, `get_chart_data` | Defer |
| `mutate` | Create/modify resources | `generate_chart`, `update_chart`, `update_chart_preview`, `generate_dashboard`, `add_chart_to_existing_dashboard`, `execute_sql` | Defer |
| `mutate` | Create/modify resources | `generate_chart`, `update_chart`, `update_chart_preview`, `generate_dashboard`, `add_chart_to_existing_dashboard`, `remove_chart_from_dashboard`, `execute_sql` | Defer |
| `explore` | URL generation for exploration | `generate_explore_link`, `open_sql_lab_with_context` | Defer |
## Client Configuration

View File

@@ -1056,6 +1056,7 @@ class FieldPermissionsMiddleware(Middleware):
"get_dashboard_info": "dashboard",
"generate_dashboard": "dashboard",
"add_chart_to_existing_dashboard": "dashboard",
"remove_chart_from_dashboard": "dashboard",
}
async def on_call_tool(

View File

@@ -0,0 +1,656 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
"""
Unit tests for remove_chart_from_dashboard MCP tool.
Follows the same pattern used in test_add_chart_to_existing_dashboard.py:
- Tool flows run through the async MCP Client (not direct function calls)
- Patches applied at source locations (superset.daos.dashboard.*, etc.)
- auth is mocked via the autouse mock_auth fixture
Covers:
- Dashboard not found
- Permission denied (user does not own the dashboard) -> permission_denied=True
- Chart not present in the dashboard
- Simple grid removal (chart directly inside a ROW) with empty-row pruning
- Chart inside a COLUMN (sibling survives; lone chart prunes COLUMN + ROW)
- Tabbed layout where the chart appears under multiple tabs
- json_metadata cleanup (expanded_slices, timed_refresh_immune_slices,
filter_scopes, default_filters)
"""
import logging
from collections.abc import Generator
from typing import Any
from unittest.mock import Mock, patch
import pytest
from fastmcp import Client
from superset.mcp_service.app import mcp
from superset.mcp_service.dashboard.tool.remove_chart_from_dashboard import (
_clean_json_metadata,
_remove_chart_from_layout,
)
from superset.utils import json
logging.basicConfig(level=logging.DEBUG)
logger = logging.getLogger(__name__)
# ---------------------------------------------------------------------------
# Fixtures
# ---------------------------------------------------------------------------
@pytest.fixture
def mcp_server() -> object:
"""Return the FastMCP app instance for use in MCP client tests."""
return mcp
@pytest.fixture(autouse=True)
def mock_auth() -> Generator[Mock, None, None]:
"""Mock authentication for all tests."""
with patch("superset.mcp_service.auth.get_user_from_request") as mock_get_user:
mock_user = Mock()
mock_user.id = 1
mock_user.username = "admin"
mock_get_user.return_value = mock_user
yield mock_get_user
# ---------------------------------------------------------------------------
# Helpers
# ---------------------------------------------------------------------------
def _mock_chart(id: int = 10, slice_name: str = "Test Chart") -> Mock:
"""Create a minimal mock Slice object with the given ID and name."""
chart = Mock()
chart.id = id
chart.slice_name = slice_name
chart.uuid = f"chart-uuid-{id}"
chart.tags = []
chart.owners = []
chart.viz_type = "table"
chart.datasource_name = None
chart.description = None
return chart
def _mock_dashboard(
id: int = 1,
title: str = "Sales Dashboard",
slices: list[Mock] | None = None,
position_json: str = "{}",
json_metadata: str | None = None,
) -> Mock:
"""Create a minimal mock Dashboard object."""
dashboard = Mock()
dashboard.id = id
dashboard.dashboard_title = title
dashboard.slug = f"test-dashboard-{id}"
dashboard.description = None
dashboard.published = True
dashboard.created_on = None
dashboard.changed_on = None
dashboard.created_by_name = "test_user"
dashboard.changed_by_name = "test_user"
dashboard.uuid = f"dashboard-uuid-{id}"
dashboard.slices = slices or []
dashboard.owners = []
dashboard.tags = []
dashboard.roles = []
dashboard.position_json = position_json
dashboard.json_metadata = json_metadata
dashboard.css = None
dashboard.certified_by = None
dashboard.certification_details = None
dashboard.is_managed_externally = False
dashboard.external_url = None
return dashboard
def _chart_node(key: str, chart_id: int, parents: list[str]) -> dict[str, Any]:
"""Build a minimal CHART layout node dict for use in test layouts."""
return {
"children": [],
"id": key,
"meta": {"chartId": chart_id, "height": 50, "width": 4},
"parents": parents,
"type": "CHART",
}
def _simple_grid_layout() -> dict[str, Any]:
"""ROOT > GRID > [ROW-1 > CHART-10, ROW-2 > CHART-20]."""
return {
"DASHBOARD_VERSION_KEY": "v2",
"ROOT_ID": {"children": ["GRID_ID"], "id": "ROOT_ID", "type": "ROOT"},
"GRID_ID": {
"children": ["ROW-1", "ROW-2"],
"id": "GRID_ID",
"parents": ["ROOT_ID"],
"type": "GRID",
},
"ROW-1": {
"children": ["CHART-aaa"],
"id": "ROW-1",
"meta": {},
"parents": ["ROOT_ID", "GRID_ID"],
"type": "ROW",
},
"CHART-aaa": _chart_node("CHART-aaa", 10, ["ROOT_ID", "GRID_ID", "ROW-1"]),
"ROW-2": {
"children": ["CHART-bbb"],
"id": "ROW-2",
"meta": {},
"parents": ["ROOT_ID", "GRID_ID"],
"type": "ROW",
},
"CHART-bbb": _chart_node("CHART-bbb", 20, ["ROOT_ID", "GRID_ID", "ROW-2"]),
}
def _column_layout(column_children: list[tuple[str, int]]) -> dict[str, Any]:
"""ROOT > GRID > ROW-1 > COLUMN-1 > [charts]."""
layout = {
"DASHBOARD_VERSION_KEY": "v2",
"ROOT_ID": {"children": ["GRID_ID"], "id": "ROOT_ID", "type": "ROOT"},
"GRID_ID": {
"children": ["ROW-1"],
"id": "GRID_ID",
"parents": ["ROOT_ID"],
"type": "GRID",
},
"ROW-1": {
"children": ["COLUMN-1"],
"id": "ROW-1",
"meta": {},
"parents": ["ROOT_ID", "GRID_ID"],
"type": "ROW",
},
"COLUMN-1": {
"children": [key for key, _ in column_children],
"id": "COLUMN-1",
"meta": {},
"parents": ["ROOT_ID", "GRID_ID", "ROW-1"],
"type": "COLUMN",
},
}
for key, chart_id in column_children:
layout[key] = _chart_node(
key, chart_id, ["ROOT_ID", "GRID_ID", "ROW-1", "COLUMN-1"]
)
return layout
def _tabbed_layout() -> dict[str, Any]:
"""ROOT > TABS > [TAB-1 > ROW-1 > CHART(10), TAB-2 > ROW-2 > CHART(10)]."""
return {
"DASHBOARD_VERSION_KEY": "v2",
"ROOT_ID": {"children": ["TABS-1"], "id": "ROOT_ID", "type": "ROOT"},
"TABS-1": {
"children": ["TAB-1", "TAB-2"],
"id": "TABS-1",
"meta": {},
"parents": ["ROOT_ID"],
"type": "TABS",
},
"TAB-1": {
"children": ["ROW-1"],
"id": "TAB-1",
"meta": {"text": "First"},
"parents": ["ROOT_ID", "TABS-1"],
"type": "TAB",
},
"ROW-1": {
"children": ["CHART-aaa"],
"id": "ROW-1",
"meta": {},
"parents": ["ROOT_ID", "TABS-1", "TAB-1"],
"type": "ROW",
},
"CHART-aaa": _chart_node(
"CHART-aaa", 10, ["ROOT_ID", "TABS-1", "TAB-1", "ROW-1"]
),
"TAB-2": {
"children": ["ROW-2"],
"id": "TAB-2",
"meta": {"text": "Second"},
"parents": ["ROOT_ID", "TABS-1"],
"type": "TAB",
},
"ROW-2": {
"children": ["CHART-ccc", "CHART-bbb"],
"id": "ROW-2",
"meta": {},
"parents": ["ROOT_ID", "TABS-1", "TAB-2"],
"type": "ROW",
},
"CHART-ccc": _chart_node(
"CHART-ccc", 10, ["ROOT_ID", "TABS-1", "TAB-2", "ROW-2"]
),
"CHART-bbb": _chart_node(
"CHART-bbb", 20, ["ROOT_ID", "TABS-1", "TAB-2", "ROW-2"]
),
}
async def _call_remove(
mcp_server: object, dashboard_id: int = 1, chart_id: int = 10
) -> dict[str, Any]:
"""Call remove_chart_from_dashboard via MCP client; return structured content."""
async with Client(mcp_server) as client:
result = await client.call_tool(
"remove_chart_from_dashboard",
{"request": {"dashboard_id": dashboard_id, "chart_id": chart_id}},
)
return result.structured_content
# ---------------------------------------------------------------------------
# Error-path tests
# ---------------------------------------------------------------------------
@patch("superset.daos.dashboard.DashboardDAO.find_by_id")
@pytest.mark.asyncio
async def test_dashboard_not_found(mock_find_by_id: Mock, mcp_server: object) -> None:
"""Returns a clear error when the target dashboard does not exist."""
mock_find_by_id.return_value = None
content = await _call_remove(mcp_server, dashboard_id=999)
assert content["dashboard"] is None
assert content["dashboard_url"] is None
assert content["permission_denied"] is False
assert "not found" in (content["error"] or "").lower()
@patch("superset.security_manager.raise_for_ownership")
@patch("superset.daos.dashboard.DashboardDAO.find_by_id")
@pytest.mark.asyncio
async def test_permission_denied(
mock_find_by_id: Mock, mock_raise_for_ownership: Mock, mcp_server: object
) -> None:
"""Returns permission_denied=True when the user cannot edit the dashboard."""
from superset.errors import ErrorLevel, SupersetError, SupersetErrorType
from superset.exceptions import SupersetSecurityException
dashboard = _mock_dashboard(id=1, title="Sales Dashboard")
mock_find_by_id.return_value = dashboard
mock_raise_for_ownership.side_effect = SupersetSecurityException(
SupersetError(
message="Changing this Dashboard is forbidden",
error_type=SupersetErrorType.GENERIC_BACKEND_ERROR,
level=ErrorLevel.ERROR,
)
)
content = await _call_remove(mcp_server)
assert content["dashboard"] is None
assert content["permission_denied"] is True
assert content["error"] is not None
assert "Sales Dashboard" in content["error"]
assert "permission" in content["error"].lower()
@patch("superset.security_manager.raise_for_ownership")
@patch("superset.daos.dashboard.DashboardDAO.find_by_id")
@pytest.mark.asyncio
async def test_chart_not_in_dashboard(
mock_find_by_id: Mock, mock_raise_for_ownership: Mock, mcp_server: object
) -> None:
"""Returns an error when the chart is in neither layout nor slices."""
other_chart = _mock_chart(id=20)
dashboard = _mock_dashboard(
slices=[other_chart], position_json=json.dumps(_simple_grid_layout())
)
mock_find_by_id.return_value = dashboard
mock_raise_for_ownership.return_value = None
content = await _call_remove(mcp_server, chart_id=99)
assert content["dashboard"] is None
assert content["permission_denied"] is False
assert "99" in (content["error"] or "")
assert "not in dashboard" in (content["error"] or "")
# ---------------------------------------------------------------------------
# Success-path tests (layout + slices + json_metadata assertions via the
# captured UpdateDashboardCommand payload)
# ---------------------------------------------------------------------------
@patch("superset.commands.dashboard.update.UpdateDashboardCommand")
@patch("superset.security_manager.raise_for_ownership")
@patch("superset.daos.dashboard.DashboardDAO.find_by_id")
@pytest.mark.asyncio
async def test_simple_grid_removal_prunes_empty_row(
mock_find_by_id: Mock,
mock_raise_for_ownership: Mock,
mock_update_cmd_cls: Mock,
mcp_server: object,
) -> None:
"""Removing a chart that is the only child of a ROW also prunes the ROW."""
chart_10 = _mock_chart(id=10)
chart_20 = _mock_chart(id=20)
dashboard = _mock_dashboard(
slices=[chart_10, chart_20],
position_json=json.dumps(_simple_grid_layout()),
)
updated_dashboard = _mock_dashboard(id=1, slices=[chart_20])
mock_find_by_id.side_effect = [dashboard, updated_dashboard]
mock_raise_for_ownership.return_value = None
mock_update_cmd = Mock()
mock_update_cmd.run.return_value = updated_dashboard
mock_update_cmd_cls.return_value = mock_update_cmd
content = await _call_remove(mcp_server, chart_id=10)
assert content["error"] is None
assert content["permission_denied"] is False
assert content["dashboard_url"] is not None
assert "/superset/dashboard/1/" in content["dashboard_url"]
assert set(content["removed_layout_keys"]) == {"CHART-aaa", "ROW-1"}
dashboard_id, update_data = mock_update_cmd_cls.call_args.args
assert dashboard_id == 1
new_layout = json.loads(update_data["position_json"])
assert "CHART-aaa" not in new_layout
assert "ROW-1" not in new_layout
assert new_layout["GRID_ID"]["children"] == ["ROW-2"]
assert "CHART-bbb" in new_layout
assert update_data["slices"] == [chart_20]
# No stale metadata references -> json_metadata untouched
assert "json_metadata" not in update_data
@patch("superset.commands.dashboard.update.UpdateDashboardCommand")
@patch("superset.security_manager.raise_for_ownership")
@patch("superset.daos.dashboard.DashboardDAO.find_by_id")
@pytest.mark.asyncio
async def test_chart_in_column_keeps_sibling(
mock_find_by_id: Mock,
mock_raise_for_ownership: Mock,
mock_update_cmd_cls: Mock,
mcp_server: object,
) -> None:
"""Removing one chart from a COLUMN keeps the COLUMN and its sibling."""
chart_10 = _mock_chart(id=10)
chart_20 = _mock_chart(id=20)
layout = _column_layout([("CHART-aaa", 10), ("CHART-bbb", 20)])
dashboard = _mock_dashboard(
slices=[chart_10, chart_20], position_json=json.dumps(layout)
)
updated_dashboard = _mock_dashboard(id=1, slices=[chart_20])
mock_find_by_id.side_effect = [dashboard, updated_dashboard]
mock_raise_for_ownership.return_value = None
mock_update_cmd = Mock()
mock_update_cmd.run.return_value = updated_dashboard
mock_update_cmd_cls.return_value = mock_update_cmd
content = await _call_remove(mcp_server, chart_id=10)
assert content["error"] is None
assert content["removed_layout_keys"] == ["CHART-aaa"]
_, update_data = mock_update_cmd_cls.call_args.args
new_layout = json.loads(update_data["position_json"])
assert "CHART-aaa" not in new_layout
assert new_layout["COLUMN-1"]["children"] == ["CHART-bbb"]
assert new_layout["ROW-1"]["children"] == ["COLUMN-1"]
@patch("superset.commands.dashboard.update.UpdateDashboardCommand")
@patch("superset.security_manager.raise_for_ownership")
@patch("superset.daos.dashboard.DashboardDAO.find_by_id")
@pytest.mark.asyncio
async def test_lone_chart_in_column_prunes_column_and_row(
mock_find_by_id: Mock,
mock_raise_for_ownership: Mock,
mock_update_cmd_cls: Mock,
mcp_server: object,
) -> None:
"""Removing the only chart in a COLUMN prunes the COLUMN and its ROW."""
chart_10 = _mock_chart(id=10)
layout = _column_layout([("CHART-aaa", 10)])
dashboard = _mock_dashboard(slices=[chart_10], position_json=json.dumps(layout))
updated_dashboard = _mock_dashboard(id=1, slices=[])
mock_find_by_id.side_effect = [dashboard, updated_dashboard]
mock_raise_for_ownership.return_value = None
mock_update_cmd = Mock()
mock_update_cmd.run.return_value = updated_dashboard
mock_update_cmd_cls.return_value = mock_update_cmd
content = await _call_remove(mcp_server, chart_id=10)
assert content["error"] is None
assert set(content["removed_layout_keys"]) == {"CHART-aaa", "COLUMN-1", "ROW-1"}
_, update_data = mock_update_cmd_cls.call_args.args
new_layout = json.loads(update_data["position_json"])
for key in ("CHART-aaa", "COLUMN-1", "ROW-1"):
assert key not in new_layout
assert new_layout["GRID_ID"]["children"] == []
# GRID/ROOT containers are never pruned
assert "GRID_ID" in new_layout
assert "ROOT_ID" in new_layout
assert update_data["slices"] == []
@patch("superset.commands.dashboard.update.UpdateDashboardCommand")
@patch("superset.security_manager.raise_for_ownership")
@patch("superset.daos.dashboard.DashboardDAO.find_by_id")
@pytest.mark.asyncio
async def test_tabbed_layout_removes_all_occurrences(
mock_find_by_id: Mock,
mock_raise_for_ownership: Mock,
mock_update_cmd_cls: Mock,
mcp_server: object,
) -> None:
"""A chart appearing under multiple tabs is removed everywhere; tabs stay."""
chart_10 = _mock_chart(id=10)
chart_20 = _mock_chart(id=20)
dashboard = _mock_dashboard(
slices=[chart_10, chart_20], position_json=json.dumps(_tabbed_layout())
)
updated_dashboard = _mock_dashboard(id=1, slices=[chart_20])
mock_find_by_id.side_effect = [dashboard, updated_dashboard]
mock_raise_for_ownership.return_value = None
mock_update_cmd = Mock()
mock_update_cmd.run.return_value = updated_dashboard
mock_update_cmd_cls.return_value = mock_update_cmd
content = await _call_remove(mcp_server, chart_id=10)
assert content["error"] is None
# CHART-aaa was ROW-1's only child (ROW-1 pruned); CHART-ccc shared
# ROW-2 with CHART-bbb (ROW-2 kept).
assert set(content["removed_layout_keys"]) == {"CHART-aaa", "ROW-1", "CHART-ccc"}
_, update_data = mock_update_cmd_cls.call_args.args
new_layout = json.loads(update_data["position_json"])
for key in ("CHART-aaa", "ROW-1", "CHART-ccc"):
assert key not in new_layout
# Tabs are never pruned, even when emptied
assert "TAB-1" in new_layout
assert new_layout["TAB-1"]["children"] == []
assert "TAB-2" in new_layout
assert new_layout["ROW-2"]["children"] == ["CHART-bbb"]
assert update_data["slices"] == [chart_20]
@patch("superset.commands.dashboard.update.UpdateDashboardCommand")
@patch("superset.security_manager.raise_for_ownership")
@patch("superset.daos.dashboard.DashboardDAO.find_by_id")
@pytest.mark.asyncio
async def test_json_metadata_cleanup(
mock_find_by_id: Mock,
mock_raise_for_ownership: Mock,
mock_update_cmd_cls: Mock,
mcp_server: object,
) -> None:
"""Stale chart references are removed from json_metadata on removal."""
chart_10 = _mock_chart(id=10)
chart_20 = _mock_chart(id=20)
metadata = {
"expanded_slices": {"10": True, "20": True},
"timed_refresh_immune_slices": [10, 20],
"filter_scopes": {
"10": {"col": {"scope": ["ROOT_ID"], "immune": []}},
"30": {"region": {"scope": ["ROOT_ID"], "immune": [10, 20]}},
},
"default_filters": json.dumps({"10": {"col": ["val"]}, "20": {"col": ["v2"]}}),
"refresh_frequency": 300,
}
dashboard = _mock_dashboard(
slices=[chart_10, chart_20],
position_json=json.dumps(_simple_grid_layout()),
)
# json_metadata is read from the re-fetched dashboard (updated_dashboard)
# to avoid overwriting concurrent metadata edits.
updated_dashboard = _mock_dashboard(
id=1, slices=[chart_20], json_metadata=json.dumps(metadata)
)
mock_find_by_id.side_effect = [dashboard, updated_dashboard]
mock_raise_for_ownership.return_value = None
mock_update_cmd = Mock()
mock_update_cmd.run.return_value = updated_dashboard
mock_update_cmd_cls.return_value = mock_update_cmd
content = await _call_remove(mcp_server, chart_id=10)
assert content["error"] is None
_, update_data = mock_update_cmd_cls.call_args.args
# json_metadata is NOT routed through UpdateDashboardCommand to avoid
# set_dash_metadata overwriting slices from layout data.
assert "json_metadata" not in update_data
# Cleaned metadata is written directly to updated_dashboard.json_metadata.
new_metadata = json.loads(updated_dashboard.json_metadata)
assert new_metadata["expanded_slices"] == {"20": True}
assert new_metadata["timed_refresh_immune_slices"] == [20]
assert "10" not in new_metadata["filter_scopes"]
assert new_metadata["filter_scopes"]["30"]["region"]["immune"] == [20]
# default_filters entry for chart 10 is removed; entry for 20 survives
new_default_filters = json.loads(new_metadata["default_filters"])
assert "10" not in new_default_filters
assert "20" in new_default_filters
# Unrelated keys are preserved
assert new_metadata["refresh_frequency"] == 300
# "positions" is never injected into json_metadata.
assert "positions" not in new_metadata
@patch("superset.commands.dashboard.update.UpdateDashboardCommand")
@patch("superset.security_manager.raise_for_ownership")
@patch("superset.daos.dashboard.DashboardDAO.find_by_id")
@pytest.mark.asyncio
async def test_chart_in_slices_but_not_in_layout(
mock_find_by_id: Mock,
mock_raise_for_ownership: Mock,
mock_update_cmd_cls: Mock,
mcp_server: object,
) -> None:
"""A chart attached to the dashboard but absent from the layout is
still detached from the slices relationship."""
chart_10 = _mock_chart(id=10)
dashboard = _mock_dashboard(slices=[chart_10], position_json="{}")
updated_dashboard = _mock_dashboard(id=1, slices=[])
mock_find_by_id.side_effect = [dashboard, updated_dashboard]
mock_raise_for_ownership.return_value = None
mock_update_cmd = Mock()
mock_update_cmd.run.return_value = updated_dashboard
mock_update_cmd_cls.return_value = mock_update_cmd
content = await _call_remove(mcp_server, chart_id=10)
assert content["error"] is None
assert content["removed_layout_keys"] == []
_, update_data = mock_update_cmd_cls.call_args.args
assert update_data["slices"] == []
# ---------------------------------------------------------------------------
# Synchronous helper tests
# ---------------------------------------------------------------------------
def test_remove_chart_from_layout_ignores_other_charts() -> None:
"""Removing a chart ID that is not in the layout is a no-op."""
layout = _simple_grid_layout()
removed = _remove_chart_from_layout(layout, 99)
assert removed == []
assert layout == _simple_grid_layout()
def test_clean_json_metadata_no_changes_returns_false() -> None:
"""Metadata without references to the chart is left untouched."""
metadata = {
"expanded_slices": {"20": True},
"timed_refresh_immune_slices": [20],
"color_scheme": "supersetColors",
}
assert _clean_json_metadata(metadata, 10) is False
assert metadata == {
"expanded_slices": {"20": True},
"timed_refresh_immune_slices": [20],
"color_scheme": "supersetColors",
}
def test_clean_json_metadata_handles_string_ids_in_lists() -> None:
"""timed_refresh_immune_slices entries may be string-typed IDs."""
metadata = {"timed_refresh_immune_slices": ["10", 20]}
assert _clean_json_metadata(metadata, 10) is True
assert metadata["timed_refresh_immune_slices"] == [20]
def test_clean_json_metadata_cleans_default_filters() -> None:
"""default_filters entries for the removed chart are pruned."""
metadata = {
"default_filters": json.dumps({"10": {"col": ["v"]}, "20": {"col": ["v2"]}}),
}
assert _clean_json_metadata(metadata, 10) is True
remaining = json.loads(metadata["default_filters"])
assert "10" not in remaining
assert "20" in remaining
def test_clean_json_metadata_handles_malformed_sections() -> None:
"""Malformed metadata sections are skipped without raising."""
metadata = {
"expanded_slices": "not-a-dict",
"timed_refresh_immune_slices": {"not": "a-list"},
"filter_scopes": {"10": "not-a-dict", "30": {"col": "not-a-dict"}},
}
assert _clean_json_metadata(metadata, 10) is True # filter_scopes["10"] removed
assert "10" not in metadata["filter_scopes"]
assert metadata["expanded_slices"] == "not-a-dict"