ci: cache apt packages with awalsh128/cache-apt-pkgs-action (#42499)

setup-backend (used in 17 job steps across 13 workflows) bootstrapped uv
via `pip install --upgrade pip setuptools wheel uv` on every run, and only
cached pip's download dir via actions/setup-python's `cache: pip` -- pip
wasn't doing the actual installs (uv was), so that cache bought nothing.

astral-sh/setup-uv ships a prebuilt uv binary instead of installing it via
pip, and its own GitHub Actions cache (enable-cache: true) persists uv's
resolution/wheel cache across runs, keyed on requirements/*.txt and
pyproject.toml by default. Also drops the now-redundant pip/setuptools/wheel
upgrade -- uv's build isolation installs anything a package's build backend
declares (pyproject.toml's [build-system] already requires setuptools/wheel)
without needing them preinstalled in the target environment.

Also swaps the same `pip install uv` bootstrap in bump-python-package.yml.

The uv step is skipped when install-superset: false (helm-lint-test), since
otherwise there's nothing for it to install or cache and it fails the job.

.github/actions/setup-backend/action.yml

@@ -5,10 +5,6 @@ inputs:
     description: 'Python version to set up. Accepts a version number, "current", or "next".'
     required: true
     default: 'current'
-  cache:
-    description: 'Cache dependencies. Options: pip'
-    required: false
-    default: 'pip'
   requirements-type:
     description: 'Type of requirements to install. Options: base, development, default'
     required: false
@@ -43,17 +39,24 @@ runs:
       uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
       with:
         python-version: ${{ steps.set-python-version.outputs.python-version }}
-        cache: ${{ inputs.cache }}
+    - name: Install uv
+      if: inputs.install-superset == 'true'
+      uses: astral-sh/setup-uv@c771a70e6277c0a99b617c7a806ffedaca235ff9 # v9.0.0
+      with:
+        python-version: ${{ steps.set-python-version.outputs.python-version }}
+        enable-cache: true
+    - name: Install apt packages
+      if: inputs.install-superset == 'true'
+      uses: awalsh128/cache-apt-pkgs-action@553a35bb8ebd9fcabcb1c9451aa4c98e1b4ca8a9 # v1.6.3
+      with:
+        packages: libldap2-dev libsasl2-dev
+        version: 1.0
     - name: Install dependencies
       env:
         INPUT_INSTALL_SUPERSET: ${{ inputs.install-superset }}
         INPUT_REQUIREMENTS_TYPE: ${{ inputs.requirements-type }}
       run: |
         if [ "$INPUT_INSTALL_SUPERSET" = "true" ]; then
-          sudo apt-get update && sudo apt-get -y install libldap2-dev libsasl2-dev
-
-          pip install --upgrade pip setuptools wheel uv
-
           if [ "$INPUT_REQUIREMENTS_TYPE" = "dev" ]; then
             uv pip install --system -r requirements/development.txt
           elif [ "$INPUT_REQUIREMENTS_TYPE" = "base" ]; then

.github/workflows/bump-python-package.yml

@@ -45,7 +45,10 @@ jobs:
           python-version: "3.11"
 
       - name: Install uv
-        run: pip install uv
+        uses: astral-sh/setup-uv@c771a70e6277c0a99b617c7a806ffedaca235ff9 # v9.0.0
+        with:
+          python-version: "3.11"
+          enable-cache: true
 
       - name: supersetbot bump-python -p "${{ github.event.inputs.package }}"
         env:

.github/workflows/codeql-analysis.yml

@@ -75,6 +75,6 @@ jobs:
           # queries: security-extended,security-and-quality
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@e0647621c2984b5ed2f768cb892365bf2a616ad1 # v4.37.2
+        uses: github/codeql-action/analyze@7188fc363630916deb702c7fdcf4e481b751f97a # v4.37.1
         with:
           category: "/language:${{matrix.language}}"

.github/workflows/superset-docs-deploy.yml

@@ -76,7 +76,10 @@ jobs:
           distribution: "zulu"
           java-version: "21"
       - name: Install Graphviz
-        run: sudo apt-get install -y graphviz
+        uses: awalsh128/cache-apt-pkgs-action@553a35bb8ebd9fcabcb1c9451aa4c98e1b4ca8a9 # v1.6.3
+        with:
+          packages: graphviz
+          version: 1.0
       - name: Compute Entity Relationship diagram (ERD)
         env:
           SUPERSET_SECRET_KEY: not-a-secret

.github/workflows/superset-translations.yml

@@ -78,7 +78,10 @@ jobs:
 
       - name: Install gettext tools
         if: steps.check.outputs.python == 'true' || steps.check.outputs.frontend == 'true'
-        run: sudo apt-get update && sudo apt-get install -y gettext
+        uses: awalsh128/cache-apt-pkgs-action@553a35bb8ebd9fcabcb1c9451aa4c98e1b4ca8a9 # v1.6.3
+        with:
+          packages: gettext
+          version: 1.0
 
       # Fetch the base ref so we can compare PR-introduced regressions
       # against a fair baseline (also runs babel_update against the base

superset/daos/dashboard.py

@@ -397,8 +397,7 @@ class DashboardDAO(BaseDAO[Dashboard]):
             md["color_namespace"] = data.get("color_namespace")
 
         md["expanded_slices"] = data.get("expanded_slices", {})
-        if "refresh_frequency" in data:
-            md["refresh_frequency"] = data["refresh_frequency"]
+        md["refresh_frequency"] = data.get("refresh_frequency", 0)
         md["color_scheme"] = data.get("color_scheme", "")
         md["label_colors"] = data.get("label_colors", {})
         md["shared_label_colors"] = data.get("shared_label_colors", [])

tests/unit_tests/dao/dashboard_test.py

@@ -24,7 +24,6 @@ from superset.connectors.sqla.models import Database, SqlaTable
 from superset.daos.dashboard import DashboardDAO
 from superset.models.dashboard import Dashboard
 from superset.models.slice import Slice
-from superset.utils import json
 from tests.unit_tests.conftest import with_feature_flags
 
 
@@ -118,53 +117,3 @@ def test_set_dash_metadata_preserves_soft_deleted_members(
     )
     # And the position slot kept its UUID rather than being nulled.
     assert positions["CHART-trashed"]["meta"]["uuid"] == str(trashed_chart.uuid)
-
-
-def test_set_dash_metadata_preserves_refresh_frequency(session: Session) -> None:
-    """set_dash_metadata must not reset refresh_frequency when absent from data.
-
-    Regression test for #42116: ``data.get("refresh_frequency", 0)`` would
-    unconditionally overwrite the existing value with 0 whenever the caller
-    did not include ``refresh_frequency`` in the data dict.
-    """
-    Dashboard.metadata.create_all(session.get_bind())
-
-    dashboard = Dashboard(
-        dashboard_title="refresh_test_dash",
-        json_metadata=json.dumps({"refresh_frequency": 30}),
-    )
-    db.session.add(dashboard)
-    db.session.flush()
-
-    # Simulate a save that does NOT include refresh_frequency
-    # (e.g. changing only the title via the PropertiesModal).
-    DashboardDAO.set_dash_metadata(dashboard, {"color_scheme": "superset"})
-
-    md = json.loads(dashboard.json_metadata)
-    assert md["refresh_frequency"] == 30, (
-        "refresh_frequency should be preserved when not present in data"
-    )
-
-
-def test_set_dash_metadata_updates_refresh_frequency_when_present(
-    session: Session,
-) -> None:
-    """set_dash_metadata must update refresh_frequency when it IS in data."""
-    Dashboard.metadata.create_all(session.get_bind())
-
-    dashboard = Dashboard(
-        dashboard_title="refresh_test_dash_2",
-        json_metadata=json.dumps({"refresh_frequency": 30}),
-    )
-    db.session.add(dashboard)
-    db.session.flush()
-
-    # Simulate a save that explicitly sets refresh_frequency to 0.
-    DashboardDAO.set_dash_metadata(
-        dashboard, {"refresh_frequency": 0, "color_scheme": "superset"}
-    )
-
-    md = json.loads(dashboard.json_metadata)
-    assert md["refresh_frequency"] == 0, (
-        "refresh_frequency should be updated when present in data"
-    )

tests/unit_tests/result_set_test.py

@@ -571,53 +571,3 @@ def test_stringify_values_non_serializable_dict_falls_back_to_str() -> None:
     # Must not raise — falls back to str()
     result = stringify_values(data)
     assert result[0] == str({"key": _Unserializable()})
-
-
-def test_empty_result_set_preserves_column_metadata() -> None:
-    """
-    Test that column metadata is preserved when query returns zero rows.
-
-    When a query returns no data but has a valid cursor description, the
-    column names and types from cursor_description should be preserved
-    in the result set. This allows downstream consumers (like the UI)
-    to display column headers even for empty result sets.
-    """
-    data: DbapiResult = []
-    description = [
-        ("id", "int", None, None, None, None, True),
-        ("name", "varchar", None, None, None, None, True),
-        ("created_at", "timestamp", None, None, None, None, True),
-    ]
-
-    result_set = SupersetResultSet(
-        data,
-        description,  # type: ignore
-        BaseEngineSpec,
-    )
-
-    # Verify column count
-    assert len(result_set.columns) == 3
-
-    # Verify column names are preserved
-    column_names = [col["column_name"] for col in result_set.columns]
-    assert column_names == ["id", "name", "created_at"]
-
-    assert result_set.columns[0]["type"] == BaseEngineSpec.get_datatype(
-        description[0][1]
-    )
-    assert result_set.columns[1]["type"] == BaseEngineSpec.get_datatype(
-        description[1][1]
-    )
-    assert result_set.columns[2]["type"] == BaseEngineSpec.get_datatype(
-        description[2][1]
-    )
-
-    # Verify the PyArrow table has the correct schema
-    assert result_set.table.num_rows == 0
-    assert len(result_set.table.column_names) == 3
-    assert list(result_set.table.column_names) == ["id", "name", "created_at"]
-
-    # Verify DataFrame conversion works
-    df = result_set.to_pandas_df()
-    assert len(df) == 0
-    assert list(map(str, df.columns)) == ["id", "name", "created_at"]