Merge remote-tracking branch 'origin/master' into docs/testing-guidelines-test-function

docs(testing): add guidelines for using test() instead of describe()/it()
Added comprehensive testing structure guidelines to LLMS.md that explain why and how to use test() instead of describe() and it(), following the "avoid nesting when testing" principle for better test isolation and readability. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
2026-06-22 16:09:20 +00:00 · 2025-09-29 13:13:49 -07:00 · 2025-09-29 10:25:15 -07:00 · 2025-09-29 13:37:30 +03:00 · 2025-09-28 11:45:33 -07:00 · 2025-09-27 12:46:16 +03:00
500 changed files with 2361 additions and 2147 deletions
--- a/.github/copilot-instructions.md
+++ b/.github/copilot-instructions.md
@@ -1 +1 @@
-../LLMS.md
+../AGENTS.md
--- a/.rat-excludes
+++ b/.rat-excludes
@@ -82,6 +82,7 @@ intro_header.txt

 # for LLMs
 llm-context.md
+AGENTS.md
 LLMS.md
 CLAUDE.md
 CURSOR.md
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -68,7 +68,7 @@ superset/

 ### Apache License Headers
 - **New files require ASF license headers** - When creating new code files, include the standard Apache Software Foundation license header
- **LLM instruction files are excluded** - Files like LLMS.md, CLAUDE.md, etc. are in `.rat-excludes` to avoid header token overhead
+- **LLM instruction files are excluded** - Files like AGENTS.md, CLAUDE.md, etc. are in `.rat-excludes` to avoid header token overhead

 ### Code Comments
 - **Avoid time-specific language** - Don't use words like "now", "currently", "today" in code comments as they become outdated
@@ -102,6 +102,17 @@ superset/
 - **`selectOption()`** - Select component helper
 - **React Testing Library** - NO Enzyme (removed)

+### Test Structure Guidelines
+- **Use `test()` instead of `describe()` and `it()`** - Follow the [avoid nesting when testing](https://kentcdodds.com/blog/avoid-nesting-when-youre-testing) principle
+  - **Why**: Reduces unnecessary nesting, improves test isolation, and makes tests more readable
+  - **Pattern**: Write flat test files with descriptive test names that fully describe what's being tested
+  - **Example**: Instead of nested `describe('Component', () => { it('should render', ...) })`, use `test('Component renders correctly', ...)`
+  - **Benefits**:
+    - Each test stands alone with a clear, searchable name
+    - Easier to run individual tests
+    - Forces you to write more descriptive test names
+    - Reduces cognitive overhead from nested context switching
+
 ### Test Database Patterns
 - **Mock patterns**: Use `MagicMock()` for config objects, avoid `AsyncMock` for synchronous code
 - **API tests**: Update expected columns when adding new model fields
--- a/CLAUDE.md
+++ b/CLAUDE.md
@@ -1 +1 @@
-LLMS.md
+AGENTS.md
--- a/GEMINI.md
+++ b/GEMINI.md
@@ -1 +1 @@
-LLMS.md
+AGENTS.md
--- a/GPT.md
+++ b/GPT.md
@@ -1 +1 @@
-LLMS.md
+AGENTS.md
--- a/superset-frontend/.eslintrc.js
+++ b/superset-frontend/.eslintrc.js
@@ -349,14 +349,6 @@ module.exports = {
          },
        ],
        'no-only-tests/no-only-tests': 'error',
-        'no-restricted-globals': [
-          'error',
-          {
-            name: 'describe',
-            message:
-              'Use test() instead of describe() for better test organization',
-          },
-        ],
        'max-classes-per-file': 0,
        // temporary rules to help with migration - please re-enable!
        'testing-library/await-async-queries': 0,
--- a/superset-frontend/packages/superset-ui-chart-controls/src/utils/metricColumnFilter.test.ts
+++ b/superset-frontend/packages/superset-ui-chart-controls/src/utils/metricColumnFilter.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-chart-controls/test/components/ColumnTypeLabel.test.tsx
+++ b/superset-frontend/packages/superset-ui-chart-controls/test/components/ColumnTypeLabel.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-chart-controls/test/index.test.ts
+++ b/superset-frontend/packages/superset-ui-chart-controls/test/index.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-chart-controls/test/operators/aggregateOperator.test.ts
+++ b/superset-frontend/packages/superset-ui-chart-controls/test/operators/aggregateOperator.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-chart-controls/test/utils/colorControls.test.ts
+++ b/superset-frontend/packages/superset-ui-chart-controls/test/utils/colorControls.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-chart-controls/test/utils/columnChoices.test.tsx
+++ b/superset-frontend/packages/superset-ui-chart-controls/test/utils/columnChoices.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-chart-controls/test/utils/defineSavedMetrics.test.tsx
+++ b/superset-frontend/packages/superset-ui-chart-controls/test/utils/defineSavedMetrics.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-chart-controls/test/utils/expandControlConfig.test.tsx
+++ b/superset-frontend/packages/superset-ui-chart-controls/test/utils/expandControlConfig.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-chart-controls/test/utils/getColorFormatters.test.ts
+++ b/superset-frontend/packages/superset-ui-chart-controls/test/utils/getColorFormatters.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-chart-controls/test/utils/mainMetric.test.ts
+++ b/superset-frontend/packages/superset-ui-chart-controls/test/utils/mainMetric.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-chart-controls/test/utils/selectOptions.test.ts
+++ b/superset-frontend/packages/superset-ui-chart-controls/test/utils/selectOptions.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/useJsonValidation.test.ts
+++ b/superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/useJsonValidation.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/AutoComplete/AutoComplete.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/AutoComplete/AutoComplete.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/Breadcrumb/Breadcrumb.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Breadcrumb/Breadcrumb.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/CachedLabel/CachedLabel.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/CachedLabel/CachedLabel.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/Checkbox/Checkbox.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Checkbox/Checkbox.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/CodeSyntaxHighlighter/index.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/CodeSyntaxHighlighter/index.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/Dropdown/Dropdown.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Dropdown/Dropdown.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/DynamicEditableTitle/DynamicEditableTitle.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/DynamicEditableTitle/DynamicEditableTitle.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/EditableTitle/EditableTitle.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/EditableTitle/EditableTitle.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/Form/LabeledErrorBoundInput.test.jsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Form/LabeledErrorBoundInput.test.jsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/Grid/Grid.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Grid/Grid.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/IconButton/IconButton.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/IconButton/IconButton.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/Layout/Layout.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Layout/Layout.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/ListViewCard/ImageLoader.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/ListViewCard/ImageLoader.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/ListViewCard/ListViewCard.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/ListViewCard/ListViewCard.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/Modal/FormModal.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Modal/FormModal.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/Radio/Radio.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Radio/Radio.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/Select/Select.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Select/Select.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/Skeleton/Skeleton.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Skeleton/Skeleton.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/Tabs/Tabs.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Tabs/Tabs.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/Timer/Timer.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Timer/Timer.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/Tree/Tree.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Tree/Tree.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/TreeSelect/TreeSelect.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/TreeSelect/TreeSelect.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/Typography/Typography.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Typography/Typography.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/components/Upload/Upload.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Upload/Upload.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/theme/Theme.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/theme/Theme.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/theme/utils.test.ts
+++ b/superset-frontend/packages/superset-ui-core/src/theme/utils.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/theme/utils/themeUtils.test.ts
+++ b/superset-frontend/packages/superset-ui-core/src/theme/utils/themeUtils.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/utils/dates.test.ts
+++ b/superset-frontend/packages/superset-ui-core/src/utils/dates.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/utils/html.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/utils/html.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/src/utils/merge.test.ts
+++ b/superset-frontend/packages/superset-ui-core/src/utils/merge.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/chart-composition/legend/WithLegend.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/test/chart-composition/legend/WithLegend.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/chart-composition/tooltip/TooltipFrame.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/test/chart-composition/tooltip/TooltipFrame.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/chart-composition/tooltip/TooltipTable.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/test/chart-composition/tooltip/TooltipTable.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/chart/clients/ChartClient.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/chart/clients/ChartClient.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/chart/components/ChartDataProvider.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/test/chart/components/ChartDataProvider.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/chart/components/SuperChart.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/test/chart/components/SuperChart.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/chart/components/SuperChartCore.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/test/chart/components/SuperChartCore.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/chart/components/createLoadableRenderer.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/test/chart/components/createLoadableRenderer.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/chart/components/reactify.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/test/chart/components/reactify.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/chart/index.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/chart/index.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/chart/models/ChartMetadata.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/chart/models/ChartMetadata.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/chart/models/ChartPlugin.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/test/chart/models/ChartPlugin.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/chart/models/ChartProps.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/chart/models/ChartProps.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/color/CategoricalColorNameSpace.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/color/CategoricalColorNameSpace.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/color/CategoricalColorScale.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/color/CategoricalColorScale.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/color/CategoricalSchemeRegistrySingleton.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/color/CategoricalSchemeRegistrySingleton.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/color/ColorScheme.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/color/ColorScheme.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/color/ColorSchemeRegistry.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/color/ColorSchemeRegistry.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/color/LabelsColorMapSingleton.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/color/LabelsColorMapSingleton.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/color/SequentialScheme.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/color/SequentialScheme.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/color/SequentialSchemeRegistrySingleton.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/color/SequentialSchemeRegistrySingleton.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/color/colorSchemes.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/color/colorSchemes.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/color/index.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/color/index.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/color/utils.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/color/utils.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/components/Icons/AsyncIcon.integration.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/test/components/Icons/AsyncIcon.integration.test.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/components/SafeMarkdown.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/components/SafeMarkdown.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/connection/SupersetClient.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/connection/SupersetClient.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/connection/callApi/callApi.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/connection/callApi/callApi.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/connection/callApi/callApiAndParseWithTimeout.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/connection/callApi/callApiAndParseWithTimeout.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/connection/callApi/parseResponse.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/connection/callApi/parseResponse.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/connection/callApi/rejectAfterTimeout.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/connection/callApi/rejectAfterTimeout.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/dimension/computeMaxFontSize.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/dimension/computeMaxFontSize.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/dimension/getMultipleTextDimensions.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/dimension/getMultipleTextDimensions.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/dimension/getTextDimension.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/dimension/getTextDimension.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/dimension/mergeMargin.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/dimension/mergeMargin.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/dimension/parseLength.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/dimension/parseLength.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/dimension/svg/LazyFactory.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/dimension/svg/LazyFactory.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/dimension/svg/getBBoxCeil.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/dimension/svg/getBBoxCeil.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/dimension/svg/updateTextNode.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/dimension/svg/updateTextNode.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/dynamic-plugins/shared-modules.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/dynamic-plugins/shared-modules.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/index.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/index.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/models/ExtensibleFunction.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/models/ExtensibleFunction.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/models/Plugin.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/models/Plugin.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/models/Preset.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/models/Preset.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/models/Registry.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/models/Registry.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/models/RegistryWithDefaultKey.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/models/RegistryWithDefaultKey.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/models/TypedRegistry.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/models/TypedRegistry.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/number-format/NumberFormatter.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/number-format/NumberFormatter.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/number-format/NumberFormatterRegistry.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/number-format/NumberFormatterRegistry.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/superset-frontend/packages/superset-ui-core/test/number-format/NumberFormatterRegistrySingleton.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/number-format/NumberFormatterRegistrySingleton.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-restricted-globals */
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
Elizabeth Thompson	3d2c332165	Merge remote-tracking branch 'origin/master' into docs/testing-guidelines-test-function	2025-09-29 13:13:49 -07:00
Elizabeth Thompson	572f3392d7	docs(testing): add guidelines for using test() instead of describe()/it() Added comprehensive testing structure guidelines to LLMS.md that explain why and how to use test() instead of describe() and it(), following the "avoid nesting when testing" principle for better test isolation and readability. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>	2025-09-29 10:25:15 -07:00
Geidō	90f281f585	fix: AceEditor Autocomplete Highlight (#35316 )	2025-09-29 13:37:30 +03:00
Evan Rusackas	d62249d13f	test(frontend): Migrate from describe/it to flat test() pattern (#35305 ) Co-authored-by: Claude <noreply@anthropic.com>	2025-09-28 11:45:33 -07:00
Maxime Beauchemin	ff102aadb3	refactor(llm): rename LLMS.md to AGENTS.md for modern AI tools (#35314 ) Co-authored-by: Claude <noreply@anthropic.com>	2025-09-27 12:46:16 +03:00
Elizabeth Thompson	82e2bc6181	fix(DatasourceModal): replace imperative modal updates with declarative state (#35256 ) Co-authored-by: Claude <noreply@anthropic.com>	2025-09-26 17:54:17 -07:00
Gabriel Torres Ruiz	784ff82847	fix(sqllab): fix blank bottom section in SQL Lab left panel (#35309 )	2025-09-26 20:07:20 +03:00
Mehmet Salih Yavuz	027b25e6b8	fix(DateFilterControl): remove modal overlay style to fix z-index issues (#35292 )	2025-09-26 15:42:46 +02:00
SBIN2010	b652fab042	fix(table): New ad-hoc columns retain the name of previous columns (#35274 )	2025-09-26 10:34:55 -03:00