test(auth): add comprehensive test coverage for OAuth/LDAP APP_ROOT fix

Significantly improved test quality from 6/10 to 9/10 by adding comprehensive test coverage:

✅ Critical Improvements:
- Fixed SupersetClient mock issue using jest.spyOn() pattern
- Enabled critical regression test that verifies no double-prefixing occurs
- Added full APP_ROOT test coverage for Register component

📊 Test Statistics:
- Login tests: increased from 8 to 28 tests (250% increase)
- Register tests: increased from 3 to 7 tests (133% increase)
- Total: 35 comprehensive tests (218% increase from 11)

🧪 New Test Categories Added:

1. Edge Cases:
   - Empty providers array handling
   - Invalid provider objects (null names, missing icons)
   - Special characters in provider names
   - Very long provider names
   - Mixed auth types
   - Null/undefined configurations

2. Integration Tests:
   - Full login flow with session storage verification
   - Loading state during form submission
   - Form validation (required fields)
   - Password visibility toggle
   - Form reset on navigation

3. User Interaction Tests:
   - Keyboard navigation for accessibility
   - Tab order verification
   - Uses @testing-library/user-event for better simulation

4. Error State Tests:
   - Network error handling
   - Malformed bootstrap data
   - Missing sessionStorage handling
   - OAuth providers with malformed URLs
   - Error message display from session storage

This ensures the OAuth/LDAP APP_ROOT fix is thoroughly tested and prevents regressions.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

.github/copilot-instructions.md

@@ -1 +1 @@
-../AGENTS.md
+../LLMS.md

.rat-excludes

@@ -82,7 +82,6 @@ intro_header.txt
 
 # for LLMs
 llm-context.md
-AGENTS.md
 LLMS.md
 CLAUDE.md
 CURSOR.md

CLAUDE.md

@@ -1 +1 @@
-AGENTS.md
+LLMS.md

GEMINI.md

@@ -1 +1 @@
-AGENTS.md
+LLMS.md

GPT.md

@@ -1 +1 @@
-AGENTS.md
+LLMS.md

LLMS.md

@@ -68,7 +68,7 @@ superset/
 
 ### Apache License Headers
 - **New files require ASF license headers** - When creating new code files, include the standard Apache Software Foundation license header
-- **LLM instruction files are excluded** - Files like AGENTS.md, CLAUDE.md, etc. are in `.rat-excludes` to avoid header token overhead
+- **LLM instruction files are excluded** - Files like LLMS.md, CLAUDE.md, etc. are in `.rat-excludes` to avoid header token overhead
 
 ### Code Comments
 - **Avoid time-specific language** - Don't use words like "now", "currently", "today" in code comments as they become outdated
@@ -102,17 +102,6 @@ superset/
 - **`selectOption()`** - Select component helper
 - **React Testing Library** - NO Enzyme (removed)
 
-### Test Structure Guidelines
-- **Use `test()` instead of `describe()` and `it()`** - Follow the [avoid nesting when testing](https://kentcdodds.com/blog/avoid-nesting-when-youre-testing) principle
-  - **Why**: Reduces unnecessary nesting, improves test isolation, and makes tests more readable
-  - **Pattern**: Write flat test files with descriptive test names that fully describe what's being tested
-  - **Example**: Instead of nested `describe('Component', () => { it('should render', ...) })`, use `test('Component renders correctly', ...)`
-  - **Benefits**:
-    - Each test stands alone with a clear, searchable name
-    - Easier to run individual tests
-    - Forces you to write more descriptive test names
-    - Reduces cognitive overhead from nested context switching
-
 ### Test Database Patterns
 - **Mock patterns**: Use `MagicMock()` for config objects, avoid `AsyncMock` for synchronous code
 - **API tests**: Update expected columns when adding new model fields

superset-frontend/src/.eslintrc.json

@@ -1,11 +0,0 @@
-{
-  "overrides": [
-    {
-      "files": ["*.test.ts", "*.test.tsx", "*.test.js", "*.test.jsx"],
-      "rules": {
-        "jest/consistent-test-it": ["error", {"fn": "test"}],
-        "no-restricted-globals": ["error", "describe", "it"]
-      }
-    }
-  ]
-}

superset-frontend/src/SqlLab/actions/sqlLab.test.js

@@ -49,7 +49,6 @@ jest.mock('@superset-ui/core', () => ({
   isFeatureEnabled: jest.fn(),
 }));
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('getUpToDateQuery', () => {
   test('should return the up to date query editor state', () => {
     const outOfUpdatedQueryEditor = {
@@ -73,7 +72,6 @@ describe('getUpToDateQuery', () => {
   });
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('async actions', () => {
   const mockBigNumber = '9223372036854775807';
   const queryEditor = {
@@ -102,7 +100,6 @@ describe('async actions', () => {
   const runQueryEndpoint = 'glob:*/api/v1/sqllab/execute/';
   fetchMock.post(runQueryEndpoint, `{ "data": ${mockBigNumber} }`);
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('saveQuery', () => {
     const saveQueryEndpoint = 'glob:*/api/v1/saved_query/';
     fetchMock.post(saveQueryEndpoint, { results: { json: {} } });
@@ -112,7 +109,7 @@ describe('async actions', () => {
       return request(dispatch, () => initialState);
     };
 
-    test('posts to the correct url', () => {
+    it('posts to the correct url', () => {
       expect.assertions(1);
 
       const store = mockStore(initialState);
@@ -121,7 +118,7 @@ describe('async actions', () => {
       });
     });
 
-    test('posts the correct query object', () => {
+    it('posts the correct query object', () => {
       const store = mockStore(initialState);
       return store.dispatch(actions.saveQuery(query, queryId)).then(() => {
         const call = fetchMock.calls(saveQueryEndpoint)[0];
@@ -134,7 +131,7 @@ describe('async actions', () => {
       });
     });
 
-    test('calls 3 dispatch actions', () => {
+    it('calls 3 dispatch actions', () => {
       expect.assertions(1);
 
       return makeRequest().then(() => {
@@ -142,7 +139,7 @@ describe('async actions', () => {
       });
     });
 
-    test('calls QUERY_EDITOR_SAVED after making a request', () => {
+    it('calls QUERY_EDITOR_SAVED after making a request', () => {
       expect.assertions(1);
 
       return makeRequest().then(() => {
@@ -150,7 +147,7 @@ describe('async actions', () => {
       });
     });
 
-    test('onSave calls QUERY_EDITOR_SAVED and QUERY_EDITOR_SET_TITLE', () => {
+    it('onSave calls QUERY_EDITOR_SAVED and QUERY_EDITOR_SET_TITLE', () => {
       expect.assertions(1);
 
       const store = mockStore(initialState);
@@ -166,7 +163,6 @@ describe('async actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('formatQuery', () => {
     const formatQueryEndpoint = 'glob:*/api/v1/sqllab/format_sql/';
     const expectedSql = 'SELECT 1';
@@ -183,7 +179,6 @@ describe('async actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('fetchQueryResults', () => {
     const makeRequest = () => {
       const store = mockStore(initialState);
@@ -191,7 +186,7 @@ describe('async actions', () => {
       return request(dispatch, store.getState);
     };
 
-    test('makes the fetch request', () => {
+    it('makes the fetch request', () => {
       expect.assertions(1);
 
       return makeRequest().then(() => {
@@ -199,7 +194,7 @@ describe('async actions', () => {
       });
     });
 
-    test('calls requestQueryResults', () => {
+    it('calls requestQueryResults', () => {
       expect.assertions(1);
 
       return makeRequest().then(() => {
@@ -207,7 +202,7 @@ describe('async actions', () => {
       });
     });
 
-    test.skip('parses large number result without losing precision', () =>
+    it.skip('parses large number result without losing precision', () =>
       makeRequest().then(() => {
         expect(fetchMock.calls(fetchQueryEndpoint)).toHaveLength(1);
         expect(dispatch.callCount).toBe(2);
@@ -216,7 +211,7 @@ describe('async actions', () => {
         );
       }));
 
-    test('calls querySuccess on fetch success', () => {
+    it('calls querySuccess on fetch success', () => {
       expect.assertions(1);
 
       const store = mockStore({});
@@ -231,7 +226,7 @@ describe('async actions', () => {
       });
     });
 
-    test('calls queryFailed on fetch error', () => {
+    it('calls queryFailed on fetch error', () => {
       expect.assertions(1);
 
       fetchMock.get(
@@ -253,14 +248,13 @@ describe('async actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('runQuery without query params', () => {
     const makeRequest = () => {
       const request = actions.runQuery(query);
       return request(dispatch, () => initialState);
     };
 
-    test('makes the fetch request', () => {
+    it('makes the fetch request', () => {
       expect.assertions(1);
 
       return makeRequest().then(() => {
@@ -268,7 +262,7 @@ describe('async actions', () => {
       });
     });
 
-    test('calls startQuery', () => {
+    it('calls startQuery', () => {
       expect.assertions(1);
 
       return makeRequest().then(() => {
@@ -276,7 +270,7 @@ describe('async actions', () => {
       });
     });
 
-    test.skip('parses large number result without losing precision', () =>
+    it.skip('parses large number result without losing precision', () =>
       makeRequest().then(() => {
         expect(fetchMock.calls(runQueryEndpoint)).toHaveLength(1);
         expect(dispatch.callCount).toBe(2);
@@ -285,7 +279,7 @@ describe('async actions', () => {
         );
       }));
 
-    test('calls querySuccess on fetch success', () => {
+    it('calls querySuccess on fetch success', () => {
       expect.assertions(1);
 
       const store = mockStore({});
@@ -299,7 +293,7 @@ describe('async actions', () => {
       });
     });
 
-    test('calls queryFailed on fetch error and logs the error details', () => {
+    it('calls queryFailed on fetch error and logs the error details', () => {
       expect.assertions(2);
 
       fetchMock.post(
@@ -330,7 +324,6 @@ describe('async actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('runQuery with query params', () => {
     const { location } = window;
 
@@ -349,7 +342,7 @@ describe('async actions', () => {
       return request(dispatch, () => initialState);
     };
 
-    test('makes the fetch request', async () => {
+    it('makes the fetch request', async () => {
       const runQueryEndpointWithParams =
         'glob:*/api/v1/sqllab/execute/?foo=bar';
       fetchMock.post(
@@ -362,9 +355,8 @@ describe('async actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('reRunQuery', () => {
-    test('creates new query with a new id', () => {
+    it('creates new query with a new id', () => {
       const id = 'id';
       const state = {
         sqlLab: {
@@ -380,7 +372,6 @@ describe('async actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('postStopQuery', () => {
     const stopQueryEndpoint = 'glob:*/api/v1/query/stop';
     fetchMock.post(stopQueryEndpoint, {});
@@ -394,7 +385,7 @@ describe('async actions', () => {
       return request(dispatch);
     };
 
-    test('makes the fetch request', () => {
+    it('makes the fetch request', () => {
       expect.assertions(1);
 
       return makeRequest().then(() => {
@@ -402,7 +393,7 @@ describe('async actions', () => {
       });
     });
 
-    test('calls stopQuery', () => {
+    it('calls stopQuery', () => {
       expect.assertions(1);
 
       return makeRequest().then(() => {
@@ -410,7 +401,7 @@ describe('async actions', () => {
       });
     });
 
-    test('sends the correct data', () => {
+    it('sends the correct data', () => {
       expect.assertions(1);
 
       return makeRequest().then(() => {
@@ -421,9 +412,8 @@ describe('async actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('cloneQueryToNewTab', () => {
-    test('creates new query editor', () => {
+    it('creates new query editor', () => {
       expect.assertions(1);
 
       const id = 'id';
@@ -465,7 +455,6 @@ describe('async actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('popSavedQuery', () => {
     const supersetClientGetSpy = jest.spyOn(SupersetClient, 'get');
     const store = mockStore({});
@@ -519,7 +508,7 @@ describe('async actions', () => {
       supersetClientGetSpy.mockRestore();
     });
 
-    test('calls API endpint with correct params', async () => {
+    it('calls API endpint with correct params', async () => {
       supersetClientGetSpy.mockResolvedValue({
         json: { result: mockSavedQueryApiResponse },
       });
@@ -531,7 +520,7 @@ describe('async actions', () => {
       });
     });
 
-    test('dispatches addQueryEditor with correct params on successful API call', async () => {
+    it('dispatches addQueryEditor with correct params on successful API call', async () => {
       supersetClientGetSpy.mockResolvedValue({
         json: { result: mockSavedQueryApiResponse },
       });
@@ -558,7 +547,7 @@ describe('async actions', () => {
       );
     });
 
-    test('should dispatch addDangerToast on API error', async () => {
+    it('should dispatch addDangerToast on API error', async () => {
       supersetClientGetSpy.mockResolvedValue(new Error());
 
       await makeRequest(1);
@@ -572,9 +561,8 @@ describe('async actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('addQueryEditor', () => {
-    test('creates new query editor', () => {
+    it('creates new query editor', () => {
       expect.assertions(1);
 
       const store = mockStore(initialState);
@@ -594,9 +582,8 @@ describe('async actions', () => {
       expect(store.getActions()).toEqual(expectedActions);
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('addNewQueryEditor', () => {
-      test('creates new query editor with new tab name', () => {
+      it('creates new query editor with new tab name', () => {
         const store = mockStore({
           ...initialState,
           sqlLab: {
@@ -634,7 +621,7 @@ describe('async actions', () => {
     });
   });
 
-  test('set current query editor', () => {
+  it('set current query editor', () => {
     expect.assertions(1);
 
     const store = mockStore(initialState);
@@ -649,9 +636,8 @@ describe('async actions', () => {
     expect(store.getActions()).toEqual(expectedActions);
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('swithQueryEditor', () => {
-    test('switch to the next tab editor', () => {
+    it('switch to the next tab editor', () => {
       const store = mockStore(initialState);
       const expectedActions = [
         {
@@ -664,7 +650,7 @@ describe('async actions', () => {
       expect(store.getActions()).toEqual(expectedActions);
     });
 
-    test('switch to the first tab editor once it reaches the rightmost tab', () => {
+    it('switch to the first tab editor once it reaches the rightmost tab', () => {
       const store = mockStore({
         ...initialState,
         sqlLab: {
@@ -687,7 +673,7 @@ describe('async actions', () => {
       expect(store.getActions()).toEqual(expectedActions);
     });
 
-    test('switch to the previous tab editor', () => {
+    it('switch to the previous tab editor', () => {
       const store = mockStore({
         ...initialState,
         sqlLab: {
@@ -706,7 +692,7 @@ describe('async actions', () => {
       expect(store.getActions()).toEqual(expectedActions);
     });
 
-    test('switch to the last tab editor once it reaches the leftmost tab', () => {
+    it('switch to the last tab editor once it reaches the leftmost tab', () => {
       const store = mockStore({
         ...initialState,
         sqlLab: {
@@ -729,7 +715,6 @@ describe('async actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('backend sync', () => {
     const updateTabStateEndpoint = 'glob:*/tabstateview/*';
     fetchMock.put(updateTabStateEndpoint, {});
@@ -760,9 +745,8 @@ describe('async actions', () => {
 
     afterEach(() => fetchMock.resetHistory());
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('addQueryEditor', () => {
-      test('creates the tab state in the local storage', () => {
+      it('creates the tab state in the local storage', () => {
         expect.assertions(2);
 
         const store = mockStore({});
@@ -785,9 +769,8 @@ describe('async actions', () => {
       });
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('removeQueryEditor', () => {
-      test('updates the tab state in the backend', () => {
+      it('updates the tab state in the backend', () => {
         expect.assertions(1);
 
         const store = mockStore({});
@@ -802,9 +785,8 @@ describe('async actions', () => {
       });
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('queryEditorSetDb', () => {
-      test('updates the tab state in the backend', () => {
+      it('updates the tab state in the backend', () => {
         expect.assertions(1);
 
         const dbId = 42;
@@ -821,9 +803,8 @@ describe('async actions', () => {
       });
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('queryEditorSetCatalog', () => {
-      test('updates the tab state in the backend', () => {
+      it('updates the tab state in the backend', () => {
         expect.assertions(1);
 
         const catalog = 'public';
@@ -840,9 +821,8 @@ describe('async actions', () => {
       });
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('queryEditorSetSchema', () => {
-      test('updates the tab state in the backend', () => {
+      it('updates the tab state in the backend', () => {
         expect.assertions(1);
 
         const schema = 'schema';
@@ -859,9 +839,8 @@ describe('async actions', () => {
       });
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('queryEditorSetAutorun', () => {
-      test('updates the tab state in the backend', () => {
+      it('updates the tab state in the backend', () => {
         expect.assertions(1);
 
         const autorun = true;
@@ -878,9 +857,8 @@ describe('async actions', () => {
       });
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('queryEditorSetTitle', () => {
-      test('updates the tab state in the backend', () => {
+      it('updates the tab state in the backend', () => {
         expect.assertions(1);
 
         const name = 'name';
@@ -899,7 +877,6 @@ describe('async actions', () => {
       });
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('queryEditorSetAndSaveSql', () => {
       const sql = 'SELECT * ';
       const expectedActions = [
@@ -909,9 +886,8 @@ describe('async actions', () => {
           sql,
         },
       ];
-      // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
       describe('with backend persistence flag on', () => {
-        test('updates the tab state in the backend', () => {
+        it('updates the tab state in the backend', () => {
           expect.assertions(2);
 
           const store = mockStore({
@@ -928,9 +904,8 @@ describe('async actions', () => {
           });
         });
       });
-      // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
       describe('with backend persistence flag off', () => {
-        test('does not update the tab state in the backend', () => {
+        it('does not update the tab state in the backend', () => {
           isFeatureEnabled.mockImplementation(
             feature => !(feature === 'SQLLAB_BACKEND_PERSISTENCE'),
           );
@@ -952,9 +927,8 @@ describe('async actions', () => {
       });
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('queryEditorSetQueryLimit', () => {
-      test('updates the tab state in the backend', () => {
+      it('updates the tab state in the backend', () => {
         expect.assertions(1);
 
         const queryLimit = 10;
@@ -973,9 +947,8 @@ describe('async actions', () => {
       });
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('queryEditorSetTemplateParams', () => {
-      test('updates the tab state in the backend', () => {
+      it('updates the tab state in the backend', () => {
         expect.assertions(1);
 
         const templateParams = '{"foo": "bar"}';
@@ -995,9 +968,8 @@ describe('async actions', () => {
       });
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('addTable', () => {
-      test('dispatches table state from unsaved change', () => {
+      it('dispatches table state from unsaved change', () => {
         const tableName = 'table';
         const catalogName = null;
         const schemaName = 'schema';
@@ -1031,7 +1003,7 @@ describe('async actions', () => {
         );
       });
 
-      test('uses tabViewId when available', () => {
+      it('uses tabViewId when available', () => {
         const tableName = 'table';
         const catalogName = null;
         const schemaName = 'schema';
@@ -1071,7 +1043,7 @@ describe('async actions', () => {
         );
       });
 
-      test('falls back to id when tabViewId is not available', () => {
+      it('falls back to id when tabViewId is not available', () => {
         const tableName = 'table';
         const catalogName = null;
         const schemaName = 'schema';
@@ -1111,9 +1083,8 @@ describe('async actions', () => {
       });
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('syncTable', () => {
-      test('updates the table schema state in the backend', () => {
+      it('updates the table schema state in the backend', () => {
         expect.assertions(4);
 
         const tableName = 'table';
@@ -1136,7 +1107,6 @@ describe('async actions', () => {
       });
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('runTablePreviewQuery', () => {
       const results = {
         data: mockBigNumber,
@@ -1167,7 +1137,7 @@ describe('async actions', () => {
         fetchMock.resetHistory();
       });
 
-      test('updates and runs data preview query when configured', () => {
+      it('updates and runs data preview query when configured', () => {
         expect.assertions(3);
 
         const expectedActionTypes = [
@@ -1191,7 +1161,7 @@ describe('async actions', () => {
         });
       });
 
-      test('runs data preview query only', () => {
+      it('runs data preview query only', () => {
         const expectedActionTypes = [
           actions.START_QUERY, // runQuery (data preview)
           actions.QUERY_SUCCESS, // querySuccess
@@ -1216,9 +1186,8 @@ describe('async actions', () => {
       });
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('expandTable', () => {
-      test('updates the table schema state in the backend', () => {
+      it('updates the table schema state in the backend', () => {
         expect.assertions(2);
 
         const table = { id: 1 };
@@ -1236,9 +1205,8 @@ describe('async actions', () => {
       });
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('collapseTable', () => {
-      test('updates the table schema state in the backend', () => {
+      it('updates the table schema state in the backend', () => {
         expect.assertions(2);
 
         const table = { id: 1 };
@@ -1256,9 +1224,8 @@ describe('async actions', () => {
       });
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('removeTables', () => {
-      test('updates the table schema state in the backend', () => {
+      it('updates the table schema state in the backend', () => {
         expect.assertions(2);
 
         const table = { id: 1, initialized: true };
@@ -1275,7 +1242,7 @@ describe('async actions', () => {
         });
       });
 
-      test('deletes multiple tables and updates the table schema state in the backend', () => {
+      it('deletes multiple tables and updates the table schema state in the backend', () => {
         expect.assertions(2);
 
         const tables = [
@@ -1295,7 +1262,7 @@ describe('async actions', () => {
         });
       });
 
-      test('only updates the initialized table schema state in the backend', () => {
+      it('only updates the initialized table schema state in the backend', () => {
         expect.assertions(2);
 
         const tables = [{ id: 1 }, { id: 2, initialized: true }];
@@ -1313,9 +1280,8 @@ describe('async actions', () => {
       });
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('syncQueryEditor', () => {
-      test('updates the tab state in the backend', () => {
+      it('updates the tab state in the backend', () => {
         expect.assertions(3);
 
         const results = {

superset-frontend/src/SqlLab/components/AceEditorWrapper/AceEditorWrapper.test.tsx

@@ -68,13 +68,12 @@ const setup = (queryEditor: QueryEditor, store?: Store) =>
     },
   );
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('AceEditorWrapper', () => {
   beforeEach(() => {
     (FullSQLEditor as any as jest.Mock).mockClear();
   });
 
-  test('renders ace editor including sql value', async () => {
+  it('renders ace editor including sql value', async () => {
     const store = createStore(initialState, reducerIndex);
     const { getByTestId } = setup(defaultQueryEditor, store);
     await waitFor(() => expect(getByTestId('react-ace')).toBeInTheDocument());
@@ -84,7 +83,7 @@ describe('AceEditorWrapper', () => {
     );
   });
 
-  test('renders current sql for unrelated unsaved changes', () => {
+  it('renders current sql for unrelated unsaved changes', () => {
     const expectedSql = 'SELECT updated_column\nFROM updated_table\nWHERE';
     const store = createStore(
       {
@@ -109,7 +108,7 @@ describe('AceEditorWrapper', () => {
     );
   });
 
-  test('skips rerendering for updating cursor position', () => {
+  it('skips rerendering for updating cursor position', () => {
     const store = createStore(initialState, reducerIndex);
     setup(defaultQueryEditor, store);
 

superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx

@@ -193,11 +193,6 @@ const AceEditorWrapper = ({
             width: ${theme.sizeUnit * 130}px !important;
           }
 
-          .ace_completion-highlight {
-            color: ${theme.colorPrimaryText} !important;
-            background-color: ${theme.colorPrimaryBgHover};
-          }
-
           .ace_tooltip {
             max-width: ${SQL_EDITOR_LEFTBAR_WIDTH}px;
           }

superset-frontend/src/SqlLab/components/App/App.test.tsx

@@ -47,7 +47,6 @@ const sqlLabReducer = combineReducers({
 });
 const mockAction = {} as AnyAction;
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('SqlLab App', () => {
   const middlewares = [thunk];
   const mockStore = configureStore(middlewares);
@@ -61,23 +60,23 @@ describe('SqlLab App', () => {
     jest.useRealTimers();
   });
 
-  test('is valid', () => {
+  it('is valid', () => {
     expect(isValidElement(<App />)).toBe(true);
   });
 
-  test('should render', () => {
+  it('should render', () => {
     const { getByTestId } = render(<App />, { useRedux: true, store });
     expect(getByTestId('SqlLabApp')).toBeInTheDocument();
     expect(getByTestId('mock-tabbed-sql-editors')).toBeInTheDocument();
   });
 
-  test('reset hotkey events on unmount', () => {
+  it('reset hotkey events on unmount', () => {
     const { unmount } = render(<App />, { useRedux: true, store });
     unmount();
     expect(Mousetrap.reset).toHaveBeenCalled();
   });
 
-  test('logs current usage warning', () => {
+  it('logs current usage warning', () => {
     const localStorageUsageInKilobytes = LOCALSTORAGE_MAX_USAGE_KB + 10;
     const initialState = {
       localStorageUsageInKilobytes,
@@ -101,7 +100,7 @@ describe('SqlLab App', () => {
     );
   });
 
-  test('logs current local storage usage', async () => {
+  it('logs current local storage usage', async () => {
     const localStorageUsageInKilobytes = LOCALSTORAGE_MAX_USAGE_KB - 10;
     const storeExceedLocalStorage = mockStore(
       sqlLabReducer(

superset-frontend/src/SqlLab/components/ColumnElement/ColumnElement.test.tsx

@@ -21,23 +21,22 @@ import { render } from 'spec/helpers/testing-library';
 import ColumnElement from 'src/SqlLab/components/ColumnElement';
 import { mockedActions, table } from 'src/SqlLab/fixtures';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('ColumnElement', () => {
   const mockedProps = {
     actions: mockedActions,
     column: table.columns[0],
   };
-  test('is valid with props', () => {
+  it('is valid with props', () => {
     expect(isValidElement(<ColumnElement {...mockedProps} />)).toBe(true);
   });
-  test('renders a proper primary key', () => {
+  it('renders a proper primary key', () => {
     const { container } = render(<ColumnElement column={table.columns[0]} />);
     expect(container.querySelector('i.fa-key')).toBeInTheDocument();
     expect(
       container.querySelector('[data-test="col-name"]')?.firstChild,
     ).toHaveTextContent('id');
   });
-  test('renders a multi-key column', () => {
+  it('renders a multi-key column', () => {
     const { container } = render(<ColumnElement column={table.columns[1]} />);
     expect(container.querySelector('i.fa-link')).toBeInTheDocument();
     expect(container.querySelector('i.fa-bookmark')).toBeInTheDocument();
@@ -45,7 +44,7 @@ describe('ColumnElement', () => {
       container.querySelector('[data-test="col-name"]')?.firstChild,
     ).toHaveTextContent('first_name');
   });
-  test('renders a column with no keys', () => {
+  it('renders a column with no keys', () => {
     const { container } = render(<ColumnElement column={table.columns[2]} />);
     expect(container.querySelector('i')).not.toBeInTheDocument();
     expect(

superset-frontend/src/SqlLab/components/EstimateQueryCostButton/EstimateQueryCostButton.test.tsx

@@ -53,15 +53,14 @@ const setup = (props: Partial<EstimateQueryCostButtonProps>, store?: Store) =>
     },
   );
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('EstimateQueryCostButton', () => {
-  test('renders EstimateQueryCostButton', async () => {
+  it('renders EstimateQueryCostButton', async () => {
     const { queryByText } = setup({}, mockStore(initialState));
 
     expect(queryByText('Estimate cost')).toBeInTheDocument();
   });
 
-  test('renders label for selected query', async () => {
+  it('renders label for selected query', async () => {
     const { queryByText } = setup(
       { queryEditorId: extraQueryEditor1.id },
       mockStore(initialState),
@@ -70,7 +69,7 @@ describe('EstimateQueryCostButton', () => {
     expect(queryByText('Estimate selected query cost')).toBeInTheDocument();
   });
 
-  test('renders label for selected query from unsaved', async () => {
+  it('renders label for selected query from unsaved', async () => {
     const { queryByText } = setup(
       {},
       mockStore({
@@ -88,7 +87,7 @@ describe('EstimateQueryCostButton', () => {
     expect(queryByText('Estimate selected query cost')).toBeInTheDocument();
   });
 
-  test('renders estimation error result', async () => {
+  it('renders estimation error result', async () => {
     const { queryByText, getByText } = setup(
       {},
       mockStore({
@@ -110,7 +109,7 @@ describe('EstimateQueryCostButton', () => {
     expect(queryByText('Estimate error')).toBeInTheDocument();
   });
 
-  test('renders estimation success result', async () => {
+  it('renders estimation success result', async () => {
     const { queryByText, getByText } = setup(
       {},
       mockStore({

superset-frontend/src/SqlLab/components/ExploreCtasResultsButton/ExploreCtasResultsButton.test.tsx

@@ -47,18 +47,17 @@ const setup = (props: Partial<ExploreCtasResultsButtonProps>, store?: Store) =>
     },
   );
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('ExploreCtasResultsButton', () => {
   const postFormSpy = jest.spyOn(SupersetClientClass.prototype, 'postForm');
   postFormSpy.mockImplementation(jest.fn());
 
-  test('renders', async () => {
+  it('renders', async () => {
     const { queryByText } = setup({}, mockStore(initialState));
 
     expect(queryByText('Explore')).toBeInTheDocument();
   });
 
-  test('visualize results', async () => {
+  it('visualize results', async () => {
     const { getByText } = setup({}, mockStore(initialState));
 
     postFormSpy.mockClear();
@@ -76,7 +75,7 @@ describe('ExploreCtasResultsButton', () => {
     });
   });
 
-  test('visualize results fails', async () => {
+  it('visualize results fails', async () => {
     const { getByText } = setup({}, mockStore(initialState));
 
     postFormSpy.mockClear();

superset-frontend/src/SqlLab/components/ExploreResultsButton/ExploreResultsButton.test.tsx

@@ -31,9 +31,8 @@ const setup = (
     useRedux: true,
   });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('ExploreResultsButton', () => {
-  test('renders', async () => {
+  it('renders', async () => {
     const { queryByText } = setup(jest.fn(), {
       database: { allows_subquery: true },
     });
@@ -42,7 +41,7 @@ describe('ExploreResultsButton', () => {
     expect(screen.getByRole('button', { name: /Create chart/i })).toBeEnabled();
   });
 
-  test('renders disabled if subquery not allowed', async () => {
+  it('renders disabled if subquery not allowed', async () => {
     const { queryByText } = setup(jest.fn());
     expect(queryByText('Create chart')).toBeInTheDocument();
     // Updated line to match the actual button name that includes the icon

superset-frontend/src/SqlLab/components/QueryAutoRefresh/QueryAutoRefresh.test.tsx

@@ -43,7 +43,6 @@ const mockState = {
   databases: mockDatabases,
 };
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('QueryAutoRefresh', () => {
   const runningQueries: QueryDictionary = { [runningQuery.id]: runningQuery };
   const successfulQueries: QueryDictionary = {
@@ -63,15 +62,15 @@ describe('QueryAutoRefresh', () => {
     jest.useRealTimers();
   });
 
-  test('isQueryRunning returns true for valid running query', () => {
+  it('isQueryRunning returns true for valid running query', () => {
     expect(isQueryRunning(runningQuery)).toBe(true);
   });
 
-  test('isQueryRunning returns false for valid not-running query', () => {
+  it('isQueryRunning returns false for valid not-running query', () => {
     expect(isQueryRunning(successfulQuery)).toBe(false);
   });
 
-  test('isQueryRunning returns false for invalid query', () => {
+  it('isQueryRunning returns false for invalid query', () => {
     // @ts-ignore
     expect(isQueryRunning(null)).toBe(false);
     // @ts-ignore
@@ -82,15 +81,15 @@ describe('QueryAutoRefresh', () => {
     expect(isQueryRunning({ state: { badFormat: true } })).toBe(false);
   });
 
-  test('shouldCheckForQueries is true for valid running query', () => {
+  it('shouldCheckForQueries is true for valid running query', () => {
     expect(shouldCheckForQueries(runningQueries)).toBe(true);
   });
 
-  test('shouldCheckForQueries is false for valid completed query', () => {
+  it('shouldCheckForQueries is false for valid completed query', () => {
     expect(shouldCheckForQueries(successfulQueries)).toBe(false);
   });
 
-  test('shouldCheckForQueries is false for invalid inputs', () => {
+  it('shouldCheckForQueries is false for invalid inputs', () => {
     // @ts-ignore
     expect(shouldCheckForQueries(null)).toBe(false);
     // @ts-ignore
@@ -110,7 +109,7 @@ describe('QueryAutoRefresh', () => {
     ).toBe(false);
   });
 
-  test('Attempts to refresh when given pending query', async () => {
+  it('Attempts to refresh when given pending query', async () => {
     const store = mockStore({ sqlLab: { ...mockState } });
 
     fetchMock.get(refreshApi, {
@@ -136,7 +135,7 @@ describe('QueryAutoRefresh', () => {
     );
   });
 
-  test('Attempts to clear inactive queries when updated queries are empty', async () => {
+  it('Attempts to clear inactive queries when updated queries are empty', async () => {
     const store = mockStore({ sqlLab: { ...mockState } });
 
     fetchMock.get(refreshApi, { result: [] });
@@ -165,7 +164,7 @@ describe('QueryAutoRefresh', () => {
     expect(fetchMock.calls(refreshApi)).toHaveLength(1);
   });
 
-  test('Does not fail and attempts to refresh with mixed valid/invalid queries', async () => {
+  it('Does not fail and attempts to refresh with mixed valid/invalid queries', async () => {
     const store = mockStore({ sqlLab: { ...mockState } });
 
     fetchMock.get(refreshApi, {
@@ -192,7 +191,7 @@ describe('QueryAutoRefresh', () => {
     );
   });
 
-  test('Does NOT Attempt to refresh when given only completed queries', async () => {
+  it('Does NOT Attempt to refresh when given only completed queries', async () => {
     const store = mockStore({ sqlLab: { ...mockState } });
 
     fetchMock.get(refreshApi, {
@@ -220,7 +219,7 @@ describe('QueryAutoRefresh', () => {
     expect(fetchMock.calls(refreshApi)).toHaveLength(0);
   });
 
-  test('logs the failed error for async queries', async () => {
+  it('logs the failed error for async queries', async () => {
     const store = mockStore({ sqlLab: { ...mockState } });
 
     fetchMock.get(refreshApi, {

superset-frontend/src/SqlLab/components/QueryLimitSelect/QueryLimitSelect.test.tsx

@@ -58,9 +58,8 @@ const setup = (props?: Partial<QueryLimitSelectProps>, store?: Store) =>
     },
   );
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('QueryLimitSelect', () => {
-  test('renders current query limit size', () => {
+  it('renders current query limit size', () => {
     const queryLimit = 10;
     const { getByText } = setup(
       {
@@ -82,12 +81,12 @@ describe('QueryLimitSelect', () => {
     expect(getByText(queryLimit)).toBeInTheDocument();
   });
 
-  test('renders default query limit for initial queryEditor', () => {
+  it('renders default query limit for initial queryEditor', () => {
     const { getByText } = setup({}, mockStore(initialState));
     expect(getByText(defaultQueryLimit)).toBeInTheDocument();
   });
 
-  test('renders queryLimit from unsavedQueryEditor', () => {
+  it('renders queryLimit from unsavedQueryEditor', () => {
     const queryLimit = 10000;
     const { getByText } = setup(
       {},
@@ -105,7 +104,7 @@ describe('QueryLimitSelect', () => {
     expect(getByText(convertToNumWithSpaces(queryLimit))).toBeInTheDocument();
   });
 
-  test('renders dropdown select', async () => {
+  it('renders dropdown select', async () => {
     const { baseElement, getAllByRole, getByRole } = setup(
       { maxRow: 50000 },
       mockStore(initialState),
@@ -127,7 +126,7 @@ describe('QueryLimitSelect', () => {
     expect(actualLabels).toEqual(expectedLabels);
   });
 
-  test('renders dropdown select correctly when maxRow is less than 10', async () => {
+  it('renders dropdown select correctly when maxRow is less than 10', async () => {
     const { baseElement, getAllByRole, getByRole } = setup(
       { maxRow: 5 },
       mockStore(initialState),
@@ -147,7 +146,7 @@ describe('QueryLimitSelect', () => {
     expect(actualLabels).toEqual(expectedLabels);
   });
 
-  test('renders dropdown select correctly when maxRow is a multiple of 10', async () => {
+  it('renders dropdown select correctly when maxRow is a multiple of 10', async () => {
     const { baseElement, getAllByRole, getByRole } = setup(
       { maxRow: 10000 },
       mockStore(initialState),
@@ -169,7 +168,7 @@ describe('QueryLimitSelect', () => {
     expect(actualLabels).toEqual(expectedLabels);
   });
 
-  test('dispatches QUERY_EDITOR_SET_QUERY_LIMIT action on dropdown menu click', async () => {
+  it('dispatches QUERY_EDITOR_SET_QUERY_LIMIT action on dropdown menu click', async () => {
     const store = mockStore(initialState);
     const expectedIndex = 1;
     const { baseElement, getAllByRole, getByRole } = setup({}, store);

superset-frontend/src/SqlLab/components/QueryTable/QueryTable.test.tsx

@@ -29,7 +29,6 @@ const mockedProps = {
   latestQueryId: 'ryhMUZCGb',
 };
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('QueryTable', () => {
   test('is valid', () => {
     expect(isValidElement(<QueryTable displayLimit={100} />)).toBe(true);

superset-frontend/src/SqlLab/components/ResultSet/ResultSet.test.tsx

@@ -150,7 +150,6 @@ const setup = (props?: any, store?: Store) =>
     ...(store && { store }),
   });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('ResultSet', () => {
   beforeAll(() => {
     setupAGGridModules();

superset-frontend/src/SqlLab/components/RunQueryActionButton/RunQueryActionButton.test.tsx

@@ -53,17 +53,17 @@ const setup = (props?: Partial<RunQueryActionButtonProps>, store?: Store) =>
     ...(store && { store }),
   });
 
-test('renders a single Button', () => {
+it('renders a single Button', () => {
   const { getByRole } = setup({}, mockStore(initialState));
   expect(getByRole('button')).toBeInTheDocument();
 });
 
-test('renders a label for Run Query', () => {
+it('renders a label for Run Query', () => {
   const { getByText } = setup({}, mockStore(initialState));
   expect(getByText('Run')).toBeInTheDocument();
 });
 
-test('renders a label for Selected Query', () => {
+it('renders a label for Selected Query', () => {
   const { getByText } = setup(
     {},
     mockStore({
@@ -80,7 +80,7 @@ test('renders a label for Selected Query', () => {
   expect(getByText('Run selection')).toBeInTheDocument();
 });
 
-test('disable button when sql from unsaved changes is empty', () => {
+it('disable button when sql from unsaved changes is empty', () => {
   const { getByRole } = setup(
     {},
     mockStore({
@@ -98,7 +98,7 @@ test('disable button when sql from unsaved changes is empty', () => {
   expect(button).toBeDisabled();
 });
 
-test('disable button when selectedText only contains blank contents', () => {
+it('disable button when selectedText only contains blank contents', () => {
   const { getByRole } = setup(
     {},
     mockStore({
@@ -116,7 +116,7 @@ test('disable button when selectedText only contains blank contents', () => {
   expect(button).toBeDisabled();
 });
 
-test('enable default button for unrelated unsaved changes', () => {
+it('enable default button for unrelated unsaved changes', () => {
   const { getByRole } = setup(
     {},
     mockStore({
@@ -134,7 +134,7 @@ test('enable default button for unrelated unsaved changes', () => {
   expect(button).toBeEnabled();
 });
 
-test('dispatch runQuery on click', async () => {
+it('dispatch runQuery on click', async () => {
   const runQuery = jest.fn();
   const { getByRole } = setup({ runQuery }, mockStore(initialState));
   const button = getByRole('button');
@@ -143,7 +143,7 @@ test('dispatch runQuery on click', async () => {
   await waitFor(() => expect(runQuery).toHaveBeenCalledTimes(1));
 });
 
-test('dispatch stopQuery on click while running state', async () => {
+it('dispatch stopQuery on click while running state', async () => {
   const stopQuery = jest.fn();
   const { getByRole } = setup(
     { queryState: 'running', stopQuery },

superset-frontend/src/SqlLab/components/SaveDatasetActionButton/SaveDatasetActionButton.test.tsx

@@ -24,7 +24,6 @@ const overlayMenu = (
   <Menu items={[{ label: 'Save dataset', key: 'save-dataset' }]} />
 );
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('SaveDatasetActionButton', () => {
   test('renders a split save button', async () => {
     render(

superset-frontend/src/SqlLab/components/SaveDatasetModal/SaveDatasetModal.test.tsx

@@ -62,9 +62,8 @@ jest.mock('src/explore/exploreUtils/formData', () => ({
   postFormData: jest.fn(),
 }));
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('SaveDatasetModal', () => {
-  test('renders a "Save as new" field', () => {
+  it('renders a "Save as new" field', () => {
     render(<SaveDatasetModal {...mockedProps} />, { useRedux: true });
 
     const saveRadioBtn = screen.getByRole('radio', {
@@ -81,7 +80,7 @@ describe('SaveDatasetModal', () => {
     expect(inputFieldText).toBeInTheDocument();
   });
 
-  test('renders an "Overwrite existing" field', () => {
+  it('renders an "Overwrite existing" field', () => {
     render(<SaveDatasetModal {...mockedProps} />, { useRedux: true });
 
     const overwriteRadioBtn = screen.getByRole('radio', {
@@ -97,20 +96,20 @@ describe('SaveDatasetModal', () => {
     expect(placeholderText).toBeInTheDocument();
   });
 
-  test('renders a close button', () => {
+  it('renders a close button', () => {
     render(<SaveDatasetModal {...mockedProps} />, { useRedux: true });
 
     expect(screen.getByRole('button', { name: /close/i })).toBeInTheDocument();
   });
 
-  test('renders a save button when "Save as new" is selected', () => {
+  it('renders a save button when "Save as new" is selected', () => {
     render(<SaveDatasetModal {...mockedProps} />, { useRedux: true });
 
     // "Save as new" is selected when the modal opens by default
     expect(screen.getByRole('button', { name: /save/i })).toBeInTheDocument();
   });
 
-  test('renders an overwrite button when "Overwrite existing" is selected', () => {
+  it('renders an overwrite button when "Overwrite existing" is selected', () => {
     render(<SaveDatasetModal {...mockedProps} />, { useRedux: true });
 
     // Click the overwrite radio button to reveal the overwrite confirmation and back buttons
@@ -124,7 +123,7 @@ describe('SaveDatasetModal', () => {
     ).toBeInTheDocument();
   });
 
-  test('renders the overwrite button as disabled until an existing dataset is selected', async () => {
+  it('renders the overwrite button as disabled until an existing dataset is selected', async () => {
     useSelectorMock.mockReturnValue({ ...user });
     render(<SaveDatasetModal {...mockedProps} />, { useRedux: true });
 
@@ -156,7 +155,7 @@ describe('SaveDatasetModal', () => {
     expect(overwriteConfirmationBtn).toBeEnabled();
   });
 
-  test('renders a confirm overwrite screen when overwrite is clicked', async () => {
+  it('renders a confirm overwrite screen when overwrite is clicked', async () => {
     useSelectorMock.mockReturnValue({ ...user });
     render(<SaveDatasetModal {...mockedProps} />, { useRedux: true });
 
@@ -197,7 +196,7 @@ describe('SaveDatasetModal', () => {
     ).toBeInTheDocument();
   });
 
-  test('sends the schema when creating the dataset', async () => {
+  it('sends the schema when creating the dataset', async () => {
     const dummyDispatch = jest.fn().mockResolvedValue({});
     useDispatchMock.mockReturnValue(dummyDispatch);
     useSelectorMock.mockReturnValue({ ...user });
@@ -222,7 +221,7 @@ describe('SaveDatasetModal', () => {
     });
   });
 
-  test('sends the catalog when creating the dataset', async () => {
+  it('sends the catalog when creating the dataset', async () => {
     const dummyDispatch = jest.fn().mockResolvedValue({});
     useDispatchMock.mockReturnValue(dummyDispatch);
     useSelectorMock.mockReturnValue({ ...user });
@@ -253,12 +252,12 @@ describe('SaveDatasetModal', () => {
     });
   });
 
-  test('does not renders a checkbox button when template processing is disabled', () => {
+  it('does not renders a checkbox button when template processing is disabled', () => {
     render(<SaveDatasetModal {...mockedProps} />, { useRedux: true });
     expect(screen.queryByRole('checkbox')).not.toBeInTheDocument();
   });
 
-  test('renders a checkbox button when template processing is enabled', () => {
+  it('renders a checkbox button when template processing is enabled', () => {
     // @ts-ignore
     global.featureFlags = {
       [FeatureFlag.EnableTemplateProcessing]: true,
@@ -267,7 +266,7 @@ describe('SaveDatasetModal', () => {
     expect(screen.getByRole('checkbox')).toBeInTheDocument();
   });
 
-  test('correctly includes template parameters when template processing is enabled', () => {
+  it('correctly includes template parameters when template processing is enabled', () => {
     // @ts-ignore
     global.featureFlags = {
       [FeatureFlag.EnableTemplateProcessing]: true,
@@ -302,7 +301,7 @@ describe('SaveDatasetModal', () => {
     });
   });
 
-  test('correctly excludes template parameters when template processing is enabled', () => {
+  it('correctly excludes template parameters when template processing is enabled', () => {
     // @ts-ignore
     global.featureFlags = {
       [FeatureFlag.EnableTemplateProcessing]: true,

superset-frontend/src/SqlLab/components/SaveQuery/SaveQuery.test.tsx

@@ -64,9 +64,8 @@ const splitSaveBtnProps = {
 const middlewares = [thunk];
 const mockStore = configureStore(middlewares);
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('SavedQuery', () => {
-  test('doesnt render save button when allows_virtual_table_explore is undefined', async () => {
+  it('doesnt render save button when allows_virtual_table_explore is undefined', async () => {
     const noRenderProps = {
       ...mockedProps,
       database: {
@@ -85,7 +84,7 @@ describe('SavedQuery', () => {
     );
   });
 
-  test('renders a non-split save button when allows_virtual_table_explore is not enabled', () => {
+  it('renders a non-split save button when allows_virtual_table_explore is not enabled', () => {
     render(<SaveQuery {...mockedProps} />, {
       useRedux: true,
       store: mockStore(mockState),
@@ -96,7 +95,7 @@ describe('SavedQuery', () => {
     expect(saveBtn).toBeVisible();
   });
 
-  test('renders a save query modal when user clicks save button', () => {
+  it('renders a save query modal when user clicks save button', () => {
     render(<SaveQuery {...mockedProps} />, {
       useRedux: true,
       store: mockStore(mockState),
@@ -112,7 +111,7 @@ describe('SavedQuery', () => {
     expect(saveQueryModalHeader).toBeInTheDocument();
   });
 
-  test('renders the save query modal UI', () => {
+  it('renders the save query modal UI', () => {
     render(<SaveQuery {...mockedProps} />, {
       useRedux: true,
       store: mockStore(mockState),
@@ -147,7 +146,7 @@ describe('SavedQuery', () => {
     expect(cancelBtn).toBeInTheDocument();
   });
 
-  test('renders a "save as new" and "update" button if query already exists', () => {
+  it('renders a "save as new" and "update" button if query already exists', () => {
     render(<SaveQuery {...mockedProps} />, {
       useRedux: true,
       store: mockStore({
@@ -172,7 +171,7 @@ describe('SavedQuery', () => {
     expect(updateBtn).toBeInTheDocument();
   });
 
-  test('renders a split save button when allows_virtual_table_explore is enabled', async () => {
+  it('renders a split save button when allows_virtual_table_explore is enabled', async () => {
     render(<SaveQuery {...splitSaveBtnProps} />, {
       useRedux: true,
       store: mockStore(mockState),
@@ -187,7 +186,7 @@ describe('SavedQuery', () => {
     });
   });
 
-  test('renders a save dataset modal when user clicks "save dataset" menu item', async () => {
+  it('renders a save dataset modal when user clicks "save dataset" menu item', async () => {
     render(<SaveQuery {...splitSaveBtnProps} />, {
       useRedux: true,
       store: mockStore(mockState),
@@ -206,7 +205,7 @@ describe('SavedQuery', () => {
     expect(saveDatasetHeader).toBeInTheDocument();
   });
 
-  test('renders the save dataset modal UI', async () => {
+  it('renders the save dataset modal UI', async () => {
     render(<SaveQuery {...splitSaveBtnProps} />, {
       useRedux: true,
       store: mockStore(mockState),
@@ -247,7 +246,7 @@ describe('SavedQuery', () => {
     expect(overwritePlaceholderText).toBeInTheDocument();
   });
 
-  test('modal stays open while save is in progress and closes after completion', async () => {
+  it('modal stays open while save is in progress and closes after completion', async () => {
     let resolveSave: () => void;
     const savePromise = new Promise<void>(resolve => {
       resolveSave = resolve;
@@ -291,7 +290,7 @@ describe('SavedQuery', () => {
     expect(mockOnSave).toHaveBeenCalledTimes(1);
   });
 
-  test('handles save with a new tab that has no changes', async () => {
+  it('handles save with a new tab that has no changes', async () => {
     const mockOnSave = jest.fn().mockResolvedValue(undefined);
 
     // Mock state for a new tab with default SQL

superset-frontend/src/SqlLab/components/ShareSqlLabQuery/ShareSqlLabQuery.test.tsx

@@ -76,7 +76,6 @@ const unsavedQueryEditor = {
   templateParams: '{ "my_value": "foo" }',
 };
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('ShareSqlLabQuery', () => {
   const storeQueryUrl = 'glob:*/api/v1/sqllab/permalink';
   const storeQueryMockId = 'ci39c3';
@@ -95,7 +94,6 @@ describe('ShareSqlLabQuery', () => {
 
   afterAll(() => fetchMock.reset());
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('via permalink api', () => {
     beforeAll(() => {
       mockedIsFeatureEnabled.mockImplementation(() => true);
@@ -105,7 +103,7 @@ describe('ShareSqlLabQuery', () => {
       mockedIsFeatureEnabled.mockReset();
     });
 
-    test('calls storeQuery() with the query when getCopyUrl() is called', async () => {
+    it('calls storeQuery() with the query when getCopyUrl() is called', async () => {
       await act(async () => {
         render(<ShareSqlLabQuery {...defaultProps} />, {
           useRedux: true,
@@ -123,7 +121,7 @@ describe('ShareSqlLabQuery', () => {
       ).toEqual(expected);
     });
 
-    test('calls storeQuery() with unsaved changes', async () => {
+    it('calls storeQuery() with unsaved changes', async () => {
       await act(async () => {
         render(<ShareSqlLabQuery {...defaultProps} />, {
           useRedux: true,

superset-frontend/src/SqlLab/components/SqlEditor/SqlEditor.test.tsx

@@ -149,7 +149,6 @@ const createStore = (initState: object) =>
       getDefaultMiddleware().concat(api.middleware, logAction),
   });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('SqlEditor', () => {
   beforeAll(() => {
     jest.setTimeout(30000);
@@ -193,7 +192,7 @@ describe('SqlEditor', () => {
     });
   });
 
-  test('does not render SqlEditor if no db selected', async () => {
+  it('does not render SqlEditor if no db selected', async () => {
     const queryEditor = initialState.sqlLab.queryEditors[2];
     const { findByText } = setup({ ...mockedProps, queryEditor }, store);
     expect(
@@ -201,7 +200,7 @@ describe('SqlEditor', () => {
     ).toBeInTheDocument();
   });
 
-  test('renders db unavailable message', async () => {
+  it('renders db unavailable message', async () => {
     const queryEditor = initialState.sqlLab.queryEditors[1];
     const { findByText } = setup({ ...mockedProps, queryEditor }, store);
     expect(
@@ -211,7 +210,7 @@ describe('SqlEditor', () => {
     ).toBeInTheDocument();
   });
 
-  test('render a SqlEditorLeftBar', async () => {
+  it('render a SqlEditorLeftBar', async () => {
     const { getByTestId, unmount } = setup(mockedProps, store);
 
     await waitFor(
@@ -223,7 +222,7 @@ describe('SqlEditor', () => {
   }, 15000);
 
   // Update other similar tests with timeouts
-  test('render an AceEditorWrapper', async () => {
+  it('render an AceEditorWrapper', async () => {
     const { findByTestId, unmount } = setup(mockedProps, store);
 
     await waitFor(
@@ -234,7 +233,7 @@ describe('SqlEditor', () => {
     unmount();
   }, 15000);
 
-  test('skip rendering an AceEditorWrapper when the current tab is inactive', async () => {
+  it('skip rendering an AceEditorWrapper when the current tab is inactive', async () => {
     const { findByTestId, queryByTestId } = setup(
       {
         ...mockedProps,
@@ -246,7 +245,7 @@ describe('SqlEditor', () => {
     expect(queryByTestId('react-ace')).not.toBeInTheDocument();
   });
 
-  test('avoids rerendering EditorLeftBar and ResultSet while typing', async () => {
+  it('avoids rerendering EditorLeftBar and ResultSet while typing', async () => {
     const { findByTestId } = setup(mockedProps, store);
     const editor = await findByTestId('react-ace');
     const sql = 'select *';
@@ -261,7 +260,7 @@ describe('SqlEditor', () => {
     expect(ResultSet).toHaveBeenCalledTimes(renderCountForSouthPane);
   });
 
-  test('renders sql from unsaved change', async () => {
+  it('renders sql from unsaved change', async () => {
     const expectedSql = 'SELECT updated_column\nFROM updated_table\nWHERE';
     store = createStore({
       ...initialState,
@@ -294,12 +293,12 @@ describe('SqlEditor', () => {
     expect(editor).toHaveValue(expectedSql);
   });
 
-  test('render a SouthPane', async () => {
+  it('render a SouthPane', async () => {
     const { findByTestId } = setup(mockedProps, store);
     expect(await findByTestId('mock-result-set')).toBeInTheDocument();
   });
 
-  test('runs query action with ctas false', async () => {
+  it('runs query action with ctas false', async () => {
     store = createStore({
       ...initialState,
       sqlLab: {
@@ -339,7 +338,7 @@ describe('SqlEditor', () => {
     );
   });
 
-  test('render a Limit Dropdown', async () => {
+  it('render a Limit Dropdown', async () => {
     const defaultQueryLimit = 101;
     const updatedProps = { ...mockedProps, defaultQueryLimit };
     const { findByText } = setup(updatedProps, store);
@@ -347,7 +346,7 @@ describe('SqlEditor', () => {
     expect(await findByText('10 000')).toBeInTheDocument();
   });
 
-  test('renders an Extension if provided', async () => {
+  it('renders an Extension if provided', async () => {
     const extensionsRegistry = getExtensionsRegistry();
 
     extensionsRegistry.set('sqleditor.extension.form', () => (
@@ -361,7 +360,6 @@ describe('SqlEditor', () => {
     ).toBeInTheDocument();
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('with EstimateQueryCost enabled', () => {
     beforeEach(() => {
       mockIsFeatureEnabled.mockImplementation(
@@ -372,7 +370,7 @@ describe('SqlEditor', () => {
       mockIsFeatureEnabled.mockClear();
     });
 
-    test('sends the catalog and schema to the endpoint', async () => {
+    it('sends the catalog and schema to the endpoint', async () => {
       const estimateApi = 'http://localhost/api/v1/sqllab/estimate/';
       fetchMock.post(estimateApi, {});
 
@@ -438,7 +436,6 @@ describe('SqlEditor', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('with SqllabBackendPersistence enabled', () => {
     beforeEach(() => {
       mockIsFeatureEnabled.mockImplementation(
@@ -449,7 +446,7 @@ describe('SqlEditor', () => {
       mockIsFeatureEnabled.mockClear();
     });
 
-    test('should render loading state when its Editor is not loaded', async () => {
+    it('should render loading state when its Editor is not loaded', async () => {
       const switchTabApi = `glob:*/tabstateview/${defaultQueryEditor.id}/activate`;
       fetchMock.post(switchTabApi, {});
       const { getByTestId } = setup(

superset-frontend/src/SqlLab/components/SqlEditor/index.tsx

@@ -168,9 +168,6 @@ const StyledToolbar = styled.div`
 
 const StyledSidebar = styled.div`
   padding: ${({ theme }) => theme.sizeUnit * 2.5}px;
-  height: 100%;
-  display: flex;
-  flex-direction: column;
 `;
 
 const StyledSqlEditor = styled.div`

superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx

@@ -47,6 +47,7 @@ import TableElement from '../TableElement';
 
 export interface SqlEditorLeftBarProps {
   queryEditorId: string;
+  height?: number;
   database?: DatabaseObject;
 }
 
@@ -71,6 +72,7 @@ const LeftBarStyles = styled.div`
 const SqlEditorLeftBar = ({
   database,
   queryEditorId,
+  height = 500,
 }: SqlEditorLeftBarProps) => {
   const allSelectedTables = useSelector<SqlLabRootState, Table[]>(
     ({ sqlLab }) =>
@@ -169,6 +171,7 @@ const SqlEditorLeftBar = ({
   };
 
   const shouldShowReset = window.location.search === '?reset=1';
+  const tableMetaDataHeight = height - 130; // 130 is the height of the selects above
 
   const handleCatalogChange = useCallback(
     (catalog: string | null) => {
@@ -225,16 +228,22 @@ const SqlEditorLeftBar = ({
       />
       <div className="divider" />
       <StyledScrollbarContainer>
-        {tables.map(table => (
-          <TableElement
-            table={table}
-            key={table.id}
-            activeKey={tables
-              .filter(({ expanded }) => expanded)
-              .map(({ id }) => id)}
-            onChange={onToggleTable}
-          />
-        ))}
+        <div
+          css={css`
+            height: ${tableMetaDataHeight}px;
+          `}
+        >
+          {tables.map(table => (
+            <TableElement
+              table={table}
+              key={table.id}
+              activeKey={tables
+                .filter(({ expanded }) => expanded)
+                .map(({ id }) => id)}
+              onChange={onToggleTable}
+            />
+          ))}
+        </div>
       </StyledScrollbarContainer>
       {shouldShowReset && (
         <Button

superset-frontend/src/SqlLab/components/SqlEditorTabHeader/SqlEditorTabHeader.test.tsx

@@ -56,16 +56,15 @@ const setup = (queryEditor: QueryEditor, store?: Store) =>
     ...(store && { store }),
   });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('SqlEditorTabHeader', () => {
-  test('renders name', () => {
+  it('renders name', () => {
     const { queryByText } = setup(defaultQueryEditor, mockStore(initialState));
     expect(queryByText(defaultQueryEditor.name)).toBeInTheDocument();
     expect(queryByText(extraQueryEditor1.name)).not.toBeInTheDocument();
     expect(queryByText(extraQueryEditor2.name)).not.toBeInTheDocument();
   });
 
-  test('renders name from unsaved changes', () => {
+  it('renders name from unsaved changes', () => {
     const expectedTitle = 'updated title';
     const { queryByText } = setup(
       defaultQueryEditor,
@@ -86,7 +85,7 @@ describe('SqlEditorTabHeader', () => {
     expect(queryByText(extraQueryEditor2.name)).not.toBeInTheDocument();
   });
 
-  test('renders current name for unrelated unsaved changes', () => {
+  it('renders current name for unrelated unsaved changes', () => {
     const unrelatedTitle = 'updated title';
     const { queryByText } = setup(
       defaultQueryEditor,
@@ -107,7 +106,6 @@ describe('SqlEditorTabHeader', () => {
     expect(queryByText(extraQueryEditor2.name)).not.toBeInTheDocument();
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('with dropdown menus', () => {
     let store = mockStore();
     beforeEach(async () => {
@@ -118,7 +116,7 @@ describe('SqlEditorTabHeader', () => {
       userEvent.click(dropdown);
     });
 
-    test('should dispatch removeQueryEditor action', async () => {
+    it('should dispatch removeQueryEditor action', async () => {
       await waitFor(() =>
         expect(screen.getByTestId('close-tab-menu-option')).toBeInTheDocument(),
       );
@@ -134,7 +132,7 @@ describe('SqlEditorTabHeader', () => {
       );
     });
 
-    test('should dispatch queryEditorSetTitle action', async () => {
+    it('should dispatch queryEditorSetTitle action', async () => {
       await waitFor(() =>
         expect(screen.getByTestId('close-tab-menu-option')).toBeInTheDocument(),
       );
@@ -157,7 +155,7 @@ describe('SqlEditorTabHeader', () => {
       mockPrompt.mockClear();
     });
 
-    test('should dispatch toggleLeftBar action', async () => {
+    it('should dispatch toggleLeftBar action', async () => {
       await waitFor(() =>
         expect(screen.getByTestId('close-tab-menu-option')).toBeInTheDocument(),
       );
@@ -175,7 +173,7 @@ describe('SqlEditorTabHeader', () => {
       );
     });
 
-    test('should dispatch removeAllOtherQueryEditors action', async () => {
+    it('should dispatch removeAllOtherQueryEditors action', async () => {
       await waitFor(() =>
         expect(screen.getByTestId('close-tab-menu-option')).toBeInTheDocument(),
       );
@@ -196,7 +194,7 @@ describe('SqlEditorTabHeader', () => {
       );
     });
 
-    test('should dispatch cloneQueryToNewTab action', async () => {
+    it('should dispatch cloneQueryToNewTab action', async () => {
       await waitFor(() =>
         expect(screen.getByTestId('close-tab-menu-option')).toBeInTheDocument(),
       );

superset-frontend/src/SqlLab/components/TabbedSqlEditors/TabbedSqlEditors.test.tsx

@@ -56,7 +56,6 @@ afterEach(() => {
   pathStub.mockReset();
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('componentDidMount', () => {
   let uriStub = jest.spyOn(URI.prototype, 'search');
   let replaceState = jest.spyOn(window.history, 'replaceState');

superset-frontend/src/SqlLab/components/TablePreview/TablePreview.test.tsx

@@ -135,7 +135,6 @@ test('renders preview', async () => {
   );
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('table actions', () => {
   test('refreshes table metadata when triggered', async () => {
     const { getByRole, getByText } = render(<TablePreview {...mockedProps} />, {

superset-frontend/src/SqlLab/components/TemplateParamsEditor/TemplateParamsEditor.test.tsx

@@ -64,14 +64,13 @@ const setup = (
     },
   );
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('TemplateParamsEditor', () => {
-  test('should render with a title', () => {
+  it('should render with a title', () => {
     const { container } = setup();
     expect(container.querySelector('div[role="button"]')).toBeInTheDocument();
   });
 
-  test('should open a modal with the ace editor', async () => {
+  it('should open a modal with the ace editor', async () => {
     const { container, getByTestId } = setup();
     fireEvent.click(getByText(container, 'Parameters'));
     await waitFor(() => {
@@ -79,7 +78,7 @@ describe('TemplateParamsEditor', () => {
     });
   });
 
-  test('renders templateParams', async () => {
+  it('renders templateParams', async () => {
     const { container, getByTestId } = setup();
     fireEvent.click(getByText(container, 'Parameters'));
     await waitFor(() => {
@@ -90,7 +89,7 @@ describe('TemplateParamsEditor', () => {
     );
   });
 
-  test('renders code from unsaved changes', async () => {
+  it('renders code from unsaved changes', async () => {
     const expectedCode = 'custom code value';
     const { container, getByTestId } = setup(
       {},

superset-frontend/src/SqlLab/reducers/getInitialState.test.ts

@@ -52,25 +52,23 @@ const apiDataWithTabState = {
     latest_query: null,
   },
 };
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('getInitialState', () => {
   afterEach(() => {
     localStorage.clear();
   });
 
-  test('should output the user that is passed in', () => {
+  it('should output the user that is passed in', () => {
     expect(getInitialState(apiData).user?.userId).toEqual(1);
   });
-  test('should return undefined instead of null for templateParams', () => {
+  it('should return undefined instead of null for templateParams', () => {
     expect(
       getInitialState(apiDataWithTabState).sqlLab?.queryEditors?.[0]
         ?.templateParams,
     ).toBeUndefined();
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('dedupeTabHistory', () => {
-    test('should dedupe the tab history', () => {
+    it('should dedupe the tab history', () => {
       [
         { value: [], expected: [] },
         {
@@ -138,9 +136,8 @@ describe('getInitialState', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('dedupe tables schema', () => {
-    test('should dedupe the table schema', () => {
+    it('should dedupe the table schema', () => {
       localStorage.setItem(
         'redux',
         JSON.stringify({
@@ -198,7 +195,7 @@ describe('getInitialState', () => {
       expect(initializedTables.map(({ id }) => id)).toEqual([1, 2, 6]);
     });
 
-    test('should parse the float dttm value', () => {
+    it('should parse the float dttm value', () => {
       const startDttmInStr = '1693433503447.166992';
       const endDttmInStr = '1693433503500.23132';
 
@@ -252,7 +249,6 @@ describe('getInitialState', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('restore unsaved changes for PERSISTENCE mode', () => {
     const lastUpdatedTime = Date.now();
     const expectedValue = 'updated editor value';
@@ -288,7 +284,7 @@ describe('getInitialState', () => {
       );
     });
 
-    test('restore unsaved changes for PERSISTENCE mode', () => {
+    it('restore unsaved changes for PERSISTENCE mode', () => {
       const apiDataWithLocalStorage = {
         ...apiData,
         active_tab: {
@@ -325,7 +321,7 @@ describe('getInitialState', () => {
       ).toEqual(apiDataWithTabState.active_tab.id.toString());
     });
 
-    test('skip unsaved changes for expired data', () => {
+    it('skip unsaved changes for expired data', () => {
       const apiDataWithLocalStorage = {
         ...apiData,
         active_tab: {
@@ -349,7 +345,7 @@ describe('getInitialState', () => {
       );
     });
 
-    test('skip unsaved changes for legacy cache data', () => {
+    it('skip unsaved changes for legacy cache data', () => {
       const apiDataWithLocalStorage = {
         ...apiData,
         active_tab: {

superset-frontend/src/SqlLab/reducers/sqlLab.test.js

@@ -23,9 +23,7 @@ import { table, initialState as mockState } from '../fixtures';
 
 const initialState = mockState.sqlLab;
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('sqlLabReducer', () => {
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('Query editors actions', () => {
     let newState;
     let defaultQueryEditor;
@@ -40,12 +38,12 @@ describe('sqlLabReducer', () => {
       newState = sqlLabReducer(newState, action);
       qe = newState.queryEditors.find(e => e.id === 'abcd');
     });
-    test('should add a query editor', () => {
+    it('should add a query editor', () => {
       expect(newState.queryEditors).toHaveLength(
         initialState.queryEditors.length + 1,
       );
     });
-    test('should merge the current unsaved changes when adding a query editor', () => {
+    it('should merge the current unsaved changes when adding a query editor', () => {
       const expectedTitle = 'new updated title';
       const updateAction = {
         type: actions.QUERY_EDITOR_SET_TITLE,
@@ -64,7 +62,7 @@ describe('sqlLabReducer', () => {
         newState.queryEditors[newState.queryEditors.length - 1].id,
       ).toEqual('efgh');
     });
-    test('should remove a query editor', () => {
+    it('should remove a query editor', () => {
       expect(newState.queryEditors).toHaveLength(
         initialState.queryEditors.length + 1,
       );
@@ -77,7 +75,7 @@ describe('sqlLabReducer', () => {
         initialState.queryEditors.length,
       );
     });
-    test('should select the latest query editor when tabHistory is empty', () => {
+    it('should select the latest query editor when tabHistory is empty', () => {
       const currentQE = newState.queryEditors[0];
       newState = {
         ...initialState,
@@ -96,7 +94,7 @@ describe('sqlLabReducer', () => {
       );
       expect(newState.tabHistory).toEqual([initialState.queryEditors[2].id]);
     });
-    test('should remove a query editor including unsaved changes', () => {
+    it('should remove a query editor including unsaved changes', () => {
       expect(newState.queryEditors).toHaveLength(
         initialState.queryEditors.length + 1,
       );
@@ -118,7 +116,7 @@ describe('sqlLabReducer', () => {
       expect(newState.unsavedQueryEditor.dbId).toBeUndefined();
       expect(newState.unsavedQueryEditor.id).toBeUndefined();
     });
-    test('should set q query editor active', () => {
+    it('should set q query editor active', () => {
       const expectedTitle = 'new updated title';
       const addQueryEditorAction = {
         type: actions.ADD_QUERY_EDITOR,
@@ -141,7 +139,7 @@ describe('sqlLabReducer', () => {
       );
       expect(newState.queryEditors[1].name).toEqual(expectedTitle);
     });
-    test('should not fail while setting DB', () => {
+    it('should not fail while setting DB', () => {
       const dbId = 9;
       const action = {
         type: actions.QUERY_EDITOR_SETDB,
@@ -152,7 +150,7 @@ describe('sqlLabReducer', () => {
       expect(newState.unsavedQueryEditor.dbId).toBe(dbId);
       expect(newState.unsavedQueryEditor.id).toBe(qe.id);
     });
-    test('should not fail while setting schema', () => {
+    it('should not fail while setting schema', () => {
       const schema = 'foo';
       const action = {
         type: actions.QUERY_EDITOR_SET_SCHEMA,
@@ -163,7 +161,7 @@ describe('sqlLabReducer', () => {
       expect(newState.unsavedQueryEditor.schema).toBe(schema);
       expect(newState.unsavedQueryEditor.id).toBe(qe.id);
     });
-    test('should not fail while setting autorun', () => {
+    it('should not fail while setting autorun', () => {
       const action = {
         type: actions.QUERY_EDITOR_SET_AUTORUN,
         queryEditor: qe,
@@ -175,7 +173,7 @@ describe('sqlLabReducer', () => {
       expect(newState.unsavedQueryEditor.autorun).toBe(true);
       expect(newState.unsavedQueryEditor.id).toBe(qe.id);
     });
-    test('should not fail while setting title', () => {
+    it('should not fail while setting title', () => {
       const title = 'Untitled Query 1';
       const action = {
         type: actions.QUERY_EDITOR_SET_TITLE,
@@ -186,7 +184,7 @@ describe('sqlLabReducer', () => {
       expect(newState.unsavedQueryEditor.name).toBe(title);
       expect(newState.unsavedQueryEditor.id).toBe(qe.id);
     });
-    test('should not fail while setting Sql', () => {
+    it('should not fail while setting Sql', () => {
       const sql = 'SELECT nothing from dev_null';
       const action = {
         type: actions.QUERY_EDITOR_SET_SQL,
@@ -197,7 +195,7 @@ describe('sqlLabReducer', () => {
       expect(newState.unsavedQueryEditor.sql).toBe(sql);
       expect(newState.unsavedQueryEditor.id).toBe(qe.id);
     });
-    test('should not fail while setting queryLimit', () => {
+    it('should not fail while setting queryLimit', () => {
       const queryLimit = 101;
       const action = {
         type: actions.QUERY_EDITOR_SET_QUERY_LIMIT,
@@ -208,7 +206,7 @@ describe('sqlLabReducer', () => {
       expect(newState.unsavedQueryEditor.queryLimit).toBe(queryLimit);
       expect(newState.unsavedQueryEditor.id).toBe(qe.id);
     });
-    test('should set selectedText', () => {
+    it('should set selectedText', () => {
       const selectedText = 'TEST';
       const action = {
         type: actions.QUERY_EDITOR_SET_SELECTED_TEXT,
@@ -220,7 +218,7 @@ describe('sqlLabReducer', () => {
       expect(newState.unsavedQueryEditor.selectedText).toBe(selectedText);
       expect(newState.unsavedQueryEditor.id).toBe(qe.id);
     });
-    test('should not wiped out unsaved changes while delayed async call intercepted', () => {
+    it('should not wiped out unsaved changes while delayed async call intercepted', () => {
       const expectedSql = 'Updated SQL WORKING IN PROGRESS--';
       const action = {
         type: actions.QUERY_EDITOR_SET_SQL,
@@ -241,7 +239,7 @@ describe('sqlLabReducer', () => {
         interceptedAction.northPercent,
       );
     });
-    test('should migrate query editor by new query editor id', () => {
+    it('should migrate query editor by new query editor id', () => {
       const { length } = newState.queryEditors;
       const index = newState.queryEditors.findIndex(({ id }) => id === qe.id);
       const newQueryEditor = {
@@ -269,7 +267,7 @@ describe('sqlLabReducer', () => {
         newQueryEditor.tabViewId,
       );
     });
-    test('should clear the destroyed query editors', () => {
+    it('should clear the destroyed query editors', () => {
       const expectedQEId = '1233289';
       const action = {
         type: actions.CLEAR_DESTROYED_QUERY_EDITOR,
@@ -287,7 +285,6 @@ describe('sqlLabReducer', () => {
       expect(newState.destroyedQueryEditors).toEqual({});
     });
   });
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('Tables', () => {
     let newState;
     let newTable;
@@ -300,12 +297,12 @@ describe('sqlLabReducer', () => {
       newState = sqlLabReducer(initialState, action);
       newTable = newState.tables[0];
     });
-    test('should add a table', () => {
+    it('should add a table', () => {
       // Testing that beforeEach actually added the table
       expect(newState.tables).toHaveLength(1);
       expect(newState.tables[0].expanded).toBe(true);
     });
-    test('should merge the table attributes', () => {
+    it('should merge the table attributes', () => {
       // Merging the extra attribute
       newTable.extra = true;
       const action = {
@@ -316,7 +313,7 @@ describe('sqlLabReducer', () => {
       expect(newState.tables).toHaveLength(1);
       expect(newState.tables[0].extra).toBe(true);
     });
-    test('should overwrite table ID be ignored when the existing table is already initialized', () => {
+    it('should overwrite table ID be ignored when the existing table is already initialized', () => {
       const action = {
         type: actions.MERGE_TABLE,
         table: newTable,
@@ -348,7 +345,7 @@ describe('sqlLabReducer', () => {
       expect(newState.tables).toHaveLength(1);
       expect(newState.tables[0].id).toBe(remoteId);
     });
-    test('should expand and collapse a table', () => {
+    it('should expand and collapse a table', () => {
       const collapseTableAction = {
         type: actions.COLLAPSE_TABLE,
         table: newTable,
@@ -362,7 +359,7 @@ describe('sqlLabReducer', () => {
       newState = sqlLabReducer(newState, expandTableAction);
       expect(newState.tables[0].expanded).toBe(true);
     });
-    test('should remove a table', () => {
+    it('should remove a table', () => {
       const action = {
         type: actions.REMOVE_TABLES,
         tables: [newTable],
@@ -371,7 +368,6 @@ describe('sqlLabReducer', () => {
       expect(newState.tables).toHaveLength(0);
     });
   });
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('Run Query', () => {
     const DENORMALIZED_CHANGED_ON = '2023-06-26T07:53:05.439';
     const CHANGED_ON_TIMESTAMP = 1687765985439;
@@ -389,7 +385,7 @@ describe('sqlLabReducer', () => {
         sqlEditorId: 'dfsadfs',
       };
     });
-    test('should start a query', () => {
+    it('should start a query', () => {
       const action = {
         type: actions.START_QUERY,
         query: {
@@ -405,7 +401,7 @@ describe('sqlLabReducer', () => {
       newState = sqlLabReducer(newState, action);
       expect(Object.keys(newState.queries)).toHaveLength(1);
     });
-    test('should stop the query', () => {
+    it('should stop the query', () => {
       const startQueryAction = {
         type: actions.START_QUERY,
         query,
@@ -419,7 +415,7 @@ describe('sqlLabReducer', () => {
       const q = newState.queries[Object.keys(newState.queries)[0]];
       expect(q.state).toBe('stopped');
     });
-    test('should remove a query', () => {
+    it('should remove a query', () => {
       const startQueryAction = {
         type: actions.START_QUERY,
         query,
@@ -432,7 +428,7 @@ describe('sqlLabReducer', () => {
       newState = sqlLabReducer(newState, removeQueryAction);
       expect(Object.keys(newState.queries)).toHaveLength(0);
     });
-    test('should refresh queries when polling returns new results', () => {
+    it('should refresh queries when polling returns new results', () => {
       const startDttmInStr = '1693433503447.166992';
       const endDttmInStr = '1693433503500.23132';
       newState = sqlLabReducer(
@@ -453,7 +449,7 @@ describe('sqlLabReducer', () => {
       expect(newState.queries.abcd.endDttm).toBe(Number(endDttmInStr));
       expect(newState.queriesLastUpdate).toBe(CHANGED_ON_TIMESTAMP);
     });
-    test('should skip refreshing queries when polling contains existing results', () => {
+    it('should skip refreshing queries when polling contains existing results', () => {
       const completedQuery = {
         ...query,
         extra: {
@@ -482,11 +478,10 @@ describe('sqlLabReducer', () => {
       expect(newState.queries.abcd).toBe(query);
       expect(newState.queries.def).toBe(completedQuery);
     });
-    test('should refresh queries when polling returns empty', () => {
+    it('should refresh queries when polling returns empty', () => {
       newState = sqlLabReducer(newState, actions.refreshQueries({}));
     });
   });
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('CLEAR_INACTIVE_QUERIES', () => {
     let newState;
     let query;
@@ -501,7 +496,7 @@ describe('sqlLabReducer', () => {
         cached: false,
       };
     });
-    test('updates queries that have already been completed', () => {
+    it('updates queries that have already been completed', () => {
       newState = sqlLabReducer(
         {
           ...newState,

superset-frontend/src/SqlLab/utils/emptyQueryResults.test.ts

@@ -29,7 +29,6 @@ import {
 } from 'src/SqlLab/constants';
 import { queries, defaultQueryEditor } from '../fixtures';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('reduxStateToLocalStorageHelper', () => {
   const queriesObj: Record<string, any> = {};
   beforeEach(() => {
@@ -38,7 +37,7 @@ describe('reduxStateToLocalStorageHelper', () => {
     });
   });
 
-  test('should empty query.results if query.startDttm is > LOCALSTORAGE_MAX_QUERY_AGE_MS', () => {
+  it('should empty query.results if query.startDttm is > LOCALSTORAGE_MAX_QUERY_AGE_MS', () => {
     // make sure sample data contains old query
     const oldQuery = queries[0];
     const { id, startDttm } = oldQuery;
@@ -52,7 +51,7 @@ describe('reduxStateToLocalStorageHelper', () => {
     expect(emptiedQuery[id].results).toEqual({});
   });
 
-  test('should empty query.results if query,.results size is greater than LOCALSTORAGE_MAX_QUERY_RESULTS_KB', () => {
+  it('should empty query.results if query,.results size is greater than LOCALSTORAGE_MAX_QUERY_RESULTS_KB', () => {
     const reasonableSizeQuery = {
       ...queries[0],
       startDttm: Date.now(),
@@ -84,7 +83,7 @@ describe('reduxStateToLocalStorageHelper', () => {
     );
   });
 
-  test('should only return selected keys for query editor', () => {
+  it('should only return selected keys for query editor', () => {
     const queryEditors = [{ ...defaultQueryEditor, dummy: 'value' }];
     expect(Object.keys(queryEditors[0])).toContain('dummy');
 

superset-frontend/src/SqlLab/utils/newQueryTabName.test.ts

@@ -29,14 +29,13 @@ const emptyEditor = {
   remoteId: null,
 };
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('newQueryTabName', () => {
-  test("should return default title if queryEditor's length is 0", () => {
+  it("should return default title if queryEditor's length is 0", () => {
     const defaultTitle = 'default title';
     const title = newQueryTabName([], defaultTitle);
     expect(title).toEqual(defaultTitle);
   });
-  test('should return next available number if there are unsaved editors', () => {
+  it('should return next available number if there are unsaved editors', () => {
     const untitledQueryText = 'Untitled Query';
     const unsavedEditors = [
       { ...emptyEditor, name: `${untitledQueryText} 1` },

superset-frontend/src/components/AlteredSliceTag/utils/utils.test.ts

@@ -20,40 +20,38 @@
 import { alterForComparison, formatValueHandler, getRowsFromDiffs } from '.';
 import { RowType } from '../types';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('alterForComparison', () => {
-  test('returns null for undefined value', () => {
+  it('returns null for undefined value', () => {
     expect(alterForComparison(undefined)).toBeNull();
   });
 
-  test('returns null for null value', () => {
+  it('returns null for null value', () => {
     expect(alterForComparison(null)).toBeNull();
   });
 
-  test('returns null for empty string value', () => {
+  it('returns null for empty string value', () => {
     expect(alterForComparison('')).toBeNull();
   });
 
-  test('returns null for empty array value', () => {
+  it('returns null for empty array value', () => {
     expect(alterForComparison([])).toBeNull();
   });
 
-  test('returns null for empty object value', () => {
+  it('returns null for empty object value', () => {
     expect(alterForComparison({})).toBeNull();
   });
 
-  test('returns value for non-empty array', () => {
+  it('returns value for non-empty array', () => {
     const value = [1, 2, 3];
     expect(alterForComparison(value)).toEqual(value);
   });
 
-  test('returns value for non-empty object', () => {
+  it('returns value for non-empty object', () => {
     const value = { key: 'value' };
     expect(alterForComparison(value)).toEqual(value);
   });
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('formatValueHandler', () => {
   const controlsMap = {
     b: { type: 'BoundsControl', label: 'Bounds' },
@@ -63,7 +61,7 @@ describe('formatValueHandler', () => {
     other_control: { type: 'OtherControl', label: 'Other' },
   };
 
-  test('handles undefined value', () => {
+  it('handles undefined value', () => {
     const value = undefined;
     const key = 'b';
 
@@ -76,7 +74,7 @@ describe('formatValueHandler', () => {
     expect(formattedValue).toBe('N/A');
   });
 
-  test('handles null value', () => {
+  it('handles null value', () => {
     const value = null;
     const key = 'b';
 
@@ -89,7 +87,7 @@ describe('formatValueHandler', () => {
     expect(formattedValue).toBe('null');
   });
 
-  test('returns "[]" for empty filters', () => {
+  it('returns "[]" for empty filters', () => {
     const value: unknown[] = [];
     const key = 'adhoc_filters';
 
@@ -102,7 +100,7 @@ describe('formatValueHandler', () => {
     expect(formattedValue).toBe('[]');
   });
 
-  test('formats filters with array values', () => {
+  it('formats filters with array values', () => {
     const filters = [
       {
         clause: 'WHERE',
@@ -131,7 +129,7 @@ describe('formatValueHandler', () => {
     expect(formattedValue).toBe(expected);
   });
 
-  test('formats filters with string values', () => {
+  it('formats filters with string values', () => {
     const filters = [
       {
         clause: 'WHERE',
@@ -160,7 +158,7 @@ describe('formatValueHandler', () => {
     expect(formattedValue).toBe(expected);
   });
 
-  test('formats "Min" and "Max" for BoundsControl', () => {
+  it('formats "Min" and "Max" for BoundsControl', () => {
     const value: number[] = [1, 2];
     const key = 'b';
 
@@ -169,7 +167,7 @@ describe('formatValueHandler', () => {
     expect(result).toEqual('Min: 1, Max: 2');
   });
 
-  test('formats stringified objects for CollectionControl', () => {
+  it('formats stringified objects for CollectionControl', () => {
     const value = [{ a: 1 }, { b: 2 }];
     const key = 'column_collection';
 
@@ -180,7 +178,7 @@ describe('formatValueHandler', () => {
     );
   });
 
-  test('formats MetricsControl values correctly', () => {
+  it('formats MetricsControl values correctly', () => {
     const value = [{ label: 'SUM(Sales)' }, { label: 'Metric2' }];
     const key = 'metrics';
 
@@ -189,7 +187,7 @@ describe('formatValueHandler', () => {
     expect(result).toEqual('SUM(Sales), Metric2');
   });
 
-  test('formats boolean values as string', () => {
+  it('formats boolean values as string', () => {
     const value1 = true;
     const value2 = false;
     const key = 'b';
@@ -209,7 +207,7 @@ describe('formatValueHandler', () => {
     expect(formattedValue2).toBe('false');
   });
 
-  test('formats array values correctly', () => {
+  it('formats array values correctly', () => {
     const value = [
       { label: 'Label1' },
       { label: 'Label2' },
@@ -231,7 +229,7 @@ describe('formatValueHandler', () => {
     expect(result).toEqual(expected);
   });
 
-  test('formats string values correctly', () => {
+  it('formats string values correctly', () => {
     const value = 'test';
     const key = 'other_control';
 
@@ -240,7 +238,7 @@ describe('formatValueHandler', () => {
     expect(result).toEqual('test');
   });
 
-  test('formats number values correctly', () => {
+  it('formats number values correctly', () => {
     const value = 123;
     const key = 'other_control';
 
@@ -249,7 +247,7 @@ describe('formatValueHandler', () => {
     expect(result).toEqual(123);
   });
 
-  test('formats object values correctly', () => {
+  it('formats object values correctly', () => {
     const value = { 1: 2, alpha: 'bravo' };
     const key = 'other_control';
     const expected = '{"1":2,"alpha":"bravo"}';
@@ -260,9 +258,8 @@ describe('formatValueHandler', () => {
   });
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('getRowsFromDiffs', () => {
-  test('returns formatted rows for diffs', () => {
+  it('returns formatted rows for diffs', () => {
     const diffs = {
       metric: { before: [{ label: 'old' }], after: [{ label: 'new' }] },
       limit: { before: 10, after: 20 },
@@ -281,7 +278,7 @@ describe('getRowsFromDiffs', () => {
     ]);
   });
 
-  test('falls back to key if label is missing', () => {
+  it('falls back to key if label is missing', () => {
     const diffs = {
       unknown: { before: 'a', after: 'b' },
     };

superset-frontend/src/components/Chart/ChartErrorMessage.test.tsx

@@ -42,7 +42,6 @@ const ERROR_MESSAGE_COMPONENT = (props: ErrorMessageComponentProps) => (
   </>
 );
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('ChartErrorMessage', () => {
   const defaultProps = {
     chartId: 1,
@@ -50,7 +49,7 @@ describe('ChartErrorMessage', () => {
     source: 'test_source' as ChartSource,
   };
 
-  test('renders the default error message when error is null', () => {
+  it('renders the default error message when error is null', () => {
     mockUseChartOwnerNames.mockReturnValue({
       result: null,
       status: ResourceStatus.Loading,
@@ -62,7 +61,7 @@ describe('ChartErrorMessage', () => {
     expect(screen.getByText('Test subtitle')).toBeInTheDocument();
   });
 
-  test('renders the error message that is passed in from the error', () => {
+  it('renders the error message that is passed in from the error', () => {
     getErrorMessageComponentRegistry().registerValue(
       'VALID_KEY',
       ERROR_MESSAGE_COMPONENT,

superset-frontend/src/components/Chart/DrillBy/DrillByModal.test.tsx

@@ -281,7 +281,6 @@ test('should render "Edit chart" enabled with can_explore permission', async ()
   expect(screen.getByRole('button', { name: 'Edit chart' })).toBeEnabled();
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('Embedded mode behavior', () => {
   // eslint-disable-next-line global-require, @typescript-eslint/no-var-requires
   const { isEmbedded } = require('src/dashboard/util/isEmbedded');
@@ -358,7 +357,6 @@ describe('Embedded mode behavior', () => {
   });
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('Table view with pagination', () => {
   beforeEach(() => {
     // Mock a large dataset response for pagination testing

superset-frontend/src/components/Chart/chartActions.test.js

@@ -59,7 +59,6 @@ jest.mock('@superset-ui/core', () => ({
   getChartBuildQueryRegistry: jest.fn(),
 }));
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('chart actions', () => {
   const MOCK_URL = '/mockURL';
   let dispatch;
@@ -122,13 +121,12 @@ describe('chart actions', () => {
     };
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('v1 API', () => {
     beforeEach(() => {
       fakeMetadata = { viz_type: 'my_viz', useLegacyApi: false };
     });
 
-    test('should query with the built query', async () => {
+    it('should query with the built query', async () => {
       const actionThunk = actions.postChartFormData({}, null);
       await actionThunk(dispatch, mockGetState);
 
@@ -143,7 +141,7 @@ describe('chart actions', () => {
       expect(dispatch.args[0][0].type).toBe(actions.CHART_UPDATE_STARTED);
     });
 
-    test('should handle the bigint without regression', async () => {
+    it('should handle the bigint without regression', async () => {
       getChartDataUriStub.restore();
       const mockBigIntUrl = '/mock/chart/data/bigint';
       const expectedBigNumber = '9223372036854775807';
@@ -162,7 +160,7 @@ describe('chart actions', () => {
       expect(json.value.toString()).toEqual(expectedBigNumber);
     });
 
-    test('handleChartDataResponse should return result if GlobalAsyncQueries flag is disabled', async () => {
+    it('handleChartDataResponse should return result if GlobalAsyncQueries flag is disabled', async () => {
       const result = await handleChartDataResponse(
         { status: 200 },
         { result: [1, 2, 3] },
@@ -170,7 +168,7 @@ describe('chart actions', () => {
       expect(result).toEqual([1, 2, 3]);
     });
 
-    test('handleChartDataResponse should handle responses when GlobalAsyncQueries flag is enabled and results are returned synchronously', async () => {
+    it('handleChartDataResponse should handle responses when GlobalAsyncQueries flag is enabled and results are returned synchronously', async () => {
       global.featureFlags = {
         [FeatureFlag.GlobalAsyncQueries]: true,
       };
@@ -181,7 +179,7 @@ describe('chart actions', () => {
       expect(result).toEqual([1, 2, 3]);
     });
 
-    test('handleChartDataResponse should handle responses when GlobalAsyncQueries flag is enabled and query is running asynchronously', async () => {
+    it('handleChartDataResponse should handle responses when GlobalAsyncQueries flag is enabled and query is running asynchronously', async () => {
       global.featureFlags = {
         [FeatureFlag.GlobalAsyncQueries]: true,
       };
@@ -193,13 +191,12 @@ describe('chart actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('legacy API', () => {
     beforeEach(() => {
       fakeMetadata = { useLegacyApi: true };
     });
 
-    test('should dispatch CHART_UPDATE_STARTED action before the query', () => {
+    it('should dispatch CHART_UPDATE_STARTED action before the query', () => {
       const actionThunk = actions.postChartFormData({});
 
       return actionThunk(dispatch, mockGetState).then(() => {
@@ -210,7 +207,7 @@ describe('chart actions', () => {
       });
     });
 
-    test('should dispatch TRIGGER_QUERY action with the query', () => {
+    it('should dispatch TRIGGER_QUERY action with the query', () => {
       const actionThunk = actions.postChartFormData({});
       return actionThunk(dispatch, mockGetState).then(() => {
         // chart update, trigger query, update form data, success
@@ -220,7 +217,7 @@ describe('chart actions', () => {
       });
     });
 
-    test('should dispatch UPDATE_QUERY_FORM_DATA action with the query', () => {
+    it('should dispatch UPDATE_QUERY_FORM_DATA action with the query', () => {
       const actionThunk = actions.postChartFormData({});
       return actionThunk(dispatch, mockGetState).then(() => {
         // chart update, trigger query, update form data, success
@@ -230,7 +227,7 @@ describe('chart actions', () => {
       });
     });
 
-    test('should dispatch logEvent async action', () => {
+    it('should dispatch logEvent async action', () => {
       const actionThunk = actions.postChartFormData({});
       return actionThunk(dispatch, mockGetState).then(() => {
         // chart update, trigger query, update form data, success
@@ -244,7 +241,7 @@ describe('chart actions', () => {
       });
     });
 
-    test('should dispatch CHART_UPDATE_SUCCEEDED action upon success', () => {
+    it('should dispatch CHART_UPDATE_SUCCEEDED action upon success', () => {
       const actionThunk = actions.postChartFormData({});
       return actionThunk(dispatch, mockGetState).then(() => {
         // chart update, trigger query, update form data, success
@@ -254,7 +251,7 @@ describe('chart actions', () => {
       });
     });
 
-    test('should dispatch CHART_UPDATE_FAILED action upon query timeout', () => {
+    it('should dispatch CHART_UPDATE_FAILED action upon query timeout', () => {
       const unresolvingPromise = new Promise(() => {});
       fetchMock.post(MOCK_URL, () => unresolvingPromise, {
         overwriteRoutes: true,
@@ -272,7 +269,7 @@ describe('chart actions', () => {
       });
     });
 
-    test('should dispatch CHART_UPDATE_FAILED action upon non-timeout non-abort failure', () => {
+    it('should dispatch CHART_UPDATE_FAILED action upon non-timeout non-abort failure', () => {
       fetchMock.post(
         MOCK_URL,
         { throws: { statusText: 'misc error' } },
@@ -293,7 +290,7 @@ describe('chart actions', () => {
       });
     });
 
-    test('should handle the bigint without regression', async () => {
+    it('should handle the bigint without regression', async () => {
       getExploreUrlStub.restore();
       const mockBigIntUrl = '/mock/chart/data/bigint';
       const expectedBigNumber = '9223372036854775807';
@@ -313,14 +310,13 @@ describe('chart actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('runAnnotationQuery', () => {
     const mockDispatch = jest.fn();
     beforeEach(() => {
       jest.clearAllMocks();
     });
 
-    test('should dispatch annotationQueryStarted and annotationQuerySuccess on successful query', async () => {
+    it('should dispatch annotationQueryStarted and annotationQuerySuccess on successful query', async () => {
       const annotation = {
         name: 'Holidays',
         annotationType: 'EVENT',
@@ -370,13 +366,12 @@ describe('chart actions', () => {
   });
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('chart actions timeout', () => {
   beforeEach(() => {
     jest.clearAllMocks();
   });
 
-  test('should use the timeout from arguments when given', async () => {
+  it('should use the timeout from arguments when given', async () => {
     const postSpy = jest.spyOn(SupersetClient, 'post');
     postSpy.mockImplementation(() => Promise.resolve({ json: { result: [] } }));
     const timeout = 10; // Set the timeout value here
@@ -408,7 +403,7 @@ describe('chart actions timeout', () => {
     expect(postSpy).toHaveBeenCalledWith(expectedPayload);
   });
 
-  test('should use the timeout from common.conf when not passed as an argument', async () => {
+  it('should use the timeout from common.conf when not passed as an argument', async () => {
     const postSpy = jest.spyOn(SupersetClient, 'post');
     postSpy.mockImplementation(() => Promise.resolve({ json: { result: [] } }));
     const formData = { datasource: 'table__1' }; // Set the formData here

superset-frontend/src/components/Chart/chartReducers.test.js

@@ -19,7 +19,6 @@
 import chartReducer, { chart } from 'src/components/Chart/chartReducer';
 import * as actions from 'src/components/Chart/chartAction';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('chart reducers', () => {
   const chartKey = 1;
   let testChart;
@@ -32,13 +31,13 @@ describe('chart reducers', () => {
     charts = { [chartKey]: testChart };
   });
 
-  test('should update endtime on fail', () => {
+  it('should update endtime on fail', () => {
     const newState = chartReducer(charts, actions.chartUpdateStopped(chartKey));
     expect(newState[chartKey].chartUpdateEndTime).toBeGreaterThan(0);
     expect(newState[chartKey].chartStatus).toEqual('stopped');
   });
 
-  test('should update endtime on timeout', () => {
+  it('should update endtime on timeout', () => {
     const newState = chartReducer(
       charts,
       actions.chartUpdateFailed(

superset-frontend/src/components/Datasource/DatasourceModal/DatasourceModal.test.jsx

@@ -73,25 +73,24 @@ beforeEach(() => {
   fetchMock.get(GET_DATABASE_ENDPOINT, { result: [] });
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('DatasourceModal', () => {
-  test('renders', async () => {
+  it('renders', async () => {
     expect(container).toBeDefined();
   });
 
-  test('renders the component', () => {
+  it('renders the component', () => {
     expect(screen.getByText('Edit Dataset')).toBeInTheDocument();
   });
 
-  test('renders a Modal', async () => {
+  it('renders a Modal', async () => {
     expect(screen.getByRole('dialog')).toBeInTheDocument();
   });
 
-  test('renders a DatasourceEditor', async () => {
+  it('renders a DatasourceEditor', async () => {
     expect(screen.getByTestId('datasource-editor')).toBeInTheDocument();
   });
 
-  test('disables the save button when the datasource is managed externally', () => {
+  it('disables the save button when the datasource is managed externally', () => {
     // the render is currently in a before operation, so it needs to be cleaned up
     // we could alternatively move all the renders back into the tests or find a better
     // way to automatically render but still allow to pass in props with the tests
@@ -105,7 +104,7 @@ describe('DatasourceModal', () => {
     expect(saveButton).toBeDisabled();
   });
 
-  test('calls the onDatasourceSave function when the save button is clicked', async () => {
+  it('calls the onDatasourceSave function when the save button is clicked', async () => {
     cleanup();
     const onDatasourceSave = jest.fn();
 
@@ -121,7 +120,7 @@ describe('DatasourceModal', () => {
     });
   });
 
-  test('should render error dialog', async () => {
+  it('should render error dialog', async () => {
     jest
       .spyOn(SupersetClient, 'put')
       .mockRejectedValue(new Error('Something went wrong'));

superset-frontend/src/components/Datasource/DatasourceModal/DatasourceModal.useModal.test.tsx

@@ -1,110 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import {
-  render,
-  screen,
-  fireEvent,
-  act,
-  defaultStore as store,
-} from 'spec/helpers/testing-library';
-import fetchMock from 'fetch-mock';
-import { Modal } from '@superset-ui/core/components';
-import mockDatasource from 'spec/fixtures/mockDatasource';
-import DatasourceModal from '.';
-
-const mockedProps = {
-  datasource: mockDatasource['7__table'],
-  addSuccessToast: jest.fn(),
-  addDangerToast: jest.fn(),
-  onChange: jest.fn(),
-  onHide: jest.fn(),
-  show: true,
-  onDatasourceSave: jest.fn(),
-};
-
-beforeEach(() => {
-  fetchMock.reset();
-  fetchMock.put('glob:*/api/v1/dataset/7?override_columns=*', {});
-  fetchMock.get('glob:*/api/v1/dataset/7', { result: {} });
-  fetchMock.get('glob:*/api/v1/database/?q=*', { result: [] });
-});
-
-afterEach(() => {
-  fetchMock.reset();
-  jest.clearAllMocks();
-});
-
-test('DatasourceModal - should use Modal.useModal hook instead of Modal.confirm directly', () => {
-  const useModalSpy = jest.spyOn(Modal, 'useModal');
-  const confirmSpy = jest.spyOn(Modal, 'confirm');
-
-  render(<DatasourceModal {...mockedProps} />, { store });
-
-  // Should use the useModal hook
-  expect(useModalSpy).toHaveBeenCalled();
-
-  // Should not call Modal.confirm during initial render
-  expect(confirmSpy).not.toHaveBeenCalled();
-
-  useModalSpy.mockRestore();
-  confirmSpy.mockRestore();
-});
-
-test('DatasourceModal - should handle sync columns state without imperative modal updates', async () => {
-  // Test that we can successfully click the save button without DOM errors
-  // The actual checkbox is only visible when SQL has changed
-  render(<DatasourceModal {...mockedProps} />, { store });
-
-  const saveButton = screen.getByTestId('datasource-modal-save');
-
-  // This should not throw any DOM errors
-  await act(async () => {
-    fireEvent.click(saveButton);
-  });
-
-  // Should show confirmation modal
-  expect(screen.getByText('Confirm save')).toBeInTheDocument();
-
-  // Should show the confirmation message
-  expect(
-    screen.getByText('Are you sure you want to save and apply changes?'),
-  ).toBeInTheDocument();
-});
-
-test('DatasourceModal - should not store modal instance in state', () => {
-  // Mock console.warn to catch any warnings about refs or imperatives
-  const consoleWarn = jest.spyOn(console, 'warn').mockImplementation();
-
-  render(<DatasourceModal {...mockedProps} />, { store });
-
-  // No warnings should be generated about improper React patterns
-  const reactWarnings = consoleWarn.mock.calls.filter(call =>
-    call.some(
-      arg =>
-        typeof arg === 'string' &&
-        (arg.includes('findDOMNode') ||
-          arg.includes('ref') ||
-          arg.includes('instance')),
-    ),
-  );
-
-  expect(reactWarnings).toHaveLength(0);
-
-  consoleWarn.mockRestore();
-});

superset-frontend/src/components/Datasource/DatasourceModal/index.tsx

@@ -16,7 +16,13 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { FunctionComponent, useState, useEffect, useCallback } from 'react';
+import {
+  FunctionComponent,
+  useState,
+  useRef,
+  useEffect,
+  useCallback,
+} from 'react';
 import { useSelector } from 'react-redux';
 import {
   styled,
@@ -95,7 +101,8 @@ const DatasourceModal: FunctionComponent<DatasourceModalProps> = ({
 }) => {
   const theme = useTheme();
   const [currentDatasource, setCurrentDatasource] = useState(datasource);
-  const [syncColumns, setSyncColumns] = useState(false);
+  const syncColumnsRef = useRef(false);
+  const [confirmModal, setConfirmModal] = useState<any>(null);
   const currencies = useSelector<
     {
       common: {
@@ -107,6 +114,7 @@ const DatasourceModal: FunctionComponent<DatasourceModalProps> = ({
   const [errors, setErrors] = useState<any[]>([]);
   const [isSaving, setIsSaving] = useState(false);
   const [isEditing, setIsEditing] = useState<boolean>(false);
+  const dialog = useRef<any>(null);
   const [modal, contextHolder] = Modal.useModal();
   const buildPayload = (datasource: Record<string, any>) => {
     const payload: Record<string, any> = {
@@ -188,7 +196,7 @@ const DatasourceModal: FunctionComponent<DatasourceModalProps> = ({
     setIsSaving(true);
     try {
       await SupersetClient.put({
-        endpoint: `/api/v1/dataset/${currentDatasource.id}?override_columns=${syncColumns}`,
+        endpoint: `/api/v1/dataset/${currentDatasource.id}?override_columns=${syncColumnsRef.current}`,
         jsonPayload: buildPayload(currentDatasource),
       });
 
@@ -273,9 +281,14 @@ const DatasourceModal: FunctionComponent<DatasourceModalProps> = ({
               impact the column definitions, you might want to skip this step.`)}
             />
             <Checkbox
-              checked={syncColumns}
+              checked={syncColumnsRef.current}
               onChange={() => {
-                setSyncColumns(!syncColumns);
+                syncColumnsRef.current = !syncColumnsRef.current;
+                if (confirmModal) {
+                  confirmModal.update({
+                    content: getSaveDialog(),
+                  });
+                }
               }}
             />
             <span
@@ -290,17 +303,25 @@ const DatasourceModal: FunctionComponent<DatasourceModalProps> = ({
         {t('Are you sure you want to save and apply changes?')}
       </div>
     ),
-    [currentDatasource.sql, datasource.sql, syncColumns],
+    [currentDatasource.sql, datasource.sql, confirmModal],
   );
 
+  useEffect(() => {
+    if (confirmModal) {
+      confirmModal.update({
+        content: getSaveDialog(),
+      });
+    }
+  }, [confirmModal, getSaveDialog]);
+
   useEffect(() => {
     if (datasource.sql !== currentDatasource.sql) {
-      setSyncColumns(true);
+      syncColumnsRef.current = true;
     }
   }, [datasource.sql, currentDatasource.sql]);
 
   const onClickSave = () => {
-    modal.confirm({
+    const modalInstance = modal.confirm({
       title: t('Confirm save'),
       content: getSaveDialog(),
       onOk: onConfirmSave,
@@ -308,6 +329,8 @@ const DatasourceModal: FunctionComponent<DatasourceModalProps> = ({
       okText: t('OK'),
       cancelText: t('Cancel'),
     });
+    setConfirmModal(modalInstance);
+    dialog.current = modalInstance;
   };
 
   return (

superset-frontend/src/components/Datasource/components/DatasourceEditor/components/DashboardLinksExternal/DashboardLinksExternal.test.tsx

@@ -46,7 +46,6 @@ const setupTest = (dashboards = mockDashboards) =>
     }),
   });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('DashboardLinksExternal', () => {
   test('renders empty state when no dashboards provided', () => {
     setupTest([]);

superset-frontend/src/components/Datasource/components/DatasourceEditor/tests/DatasourceEditor.test.jsx

@@ -63,7 +63,6 @@ export const asyncRender = props =>
     }),
   );
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('DatasourceEditor', () => {
   beforeAll(() => {
     jest.clearAllMocks();
@@ -81,11 +80,11 @@ describe('DatasourceEditor', () => {
     // jest.clearAllMocks();
   });
 
-  test('renders Tabs', () => {
+  it('renders Tabs', () => {
     expect(screen.getByTestId('edit-dataset-tabs')).toBeInTheDocument();
   });
 
-  test('can sync columns from source', async () => {
+  it('can sync columns from source', async () => {
     const columnsTab = screen.getByTestId('collection-tab-Columns');
     userEvent.click(columnsTab);
 
@@ -112,7 +111,7 @@ describe('DatasourceEditor', () => {
   });
 
   // to add, remove and modify columns accordingly
-  test('can modify columns', async () => {
+  it('can modify columns', async () => {
     const columnsTab = screen.getByTestId('collection-tab-Columns');
     userEvent.click(columnsTab);
 
@@ -139,7 +138,7 @@ describe('DatasourceEditor', () => {
     userEvent.type(inputCertDetails, 'test');
   }, 40000);
 
-  test('can delete columns', async () => {
+  it('can delete columns', async () => {
     const columnsTab = screen.getByTestId('collection-tab-Columns');
     userEvent.click(columnsTab);
 
@@ -163,7 +162,7 @@ describe('DatasourceEditor', () => {
     });
   }, 60000); // 60 seconds timeout to avoid timeouts
 
-  test('can add new columns', async () => {
+  it('can add new columns', async () => {
     const calcColsTab = screen.getByTestId('collection-tab-Calculated columns');
     userEvent.click(calcColsTab);
 
@@ -181,7 +180,7 @@ describe('DatasourceEditor', () => {
     });
   }, 60000);
 
-  test('renders isSqla fields', async () => {
+  it('renders isSqla fields', async () => {
     const columnsTab = screen.getByRole('tab', {
       name: /settings/i,
     });
@@ -196,7 +195,6 @@ describe('DatasourceEditor', () => {
   });
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('DatasourceEditor Source Tab', () => {
   beforeAll(() => {
     isFeatureEnabled.mockImplementation(() => false);
@@ -218,7 +216,7 @@ describe('DatasourceEditor Source Tab', () => {
     isFeatureEnabled.mockRestore();
   });
 
-  test('Source Tab: edit mode', async () => {
+  it('Source Tab: edit mode', async () => {
     const getLockBtn = screen.getByRole('img', { name: /lock/i });
     userEvent.click(getLockBtn);
 
@@ -233,7 +231,7 @@ describe('DatasourceEditor Source Tab', () => {
     expect(virtualRadioBtn).toBeEnabled();
   });
 
-  test('Source Tab: readOnly mode', () => {
+  it('Source Tab: readOnly mode', () => {
     const getLockBtn = screen.getByRole('img', { name: /lock/i });
     expect(getLockBtn).toBeInTheDocument();
 
@@ -248,7 +246,7 @@ describe('DatasourceEditor Source Tab', () => {
     expect(virtualRadioBtn).toBeDisabled();
   });
 
-  test('calls onChange with empty SQL when switching to physical dataset', async () => {
+  it('calls onChange with empty SQL when switching to physical dataset', async () => {
     // Clean previous render
     cleanup();
 

superset-frontend/src/components/Datasource/components/DatasourceEditor/tests/DatasourceEditorCurrency.test.jsx

@@ -30,7 +30,6 @@ const fastRender = props =>
     initialState: { common: { currencies: ['USD', 'GBP', 'EUR'] } },
   });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('DatasourceEditor Currency Tests', () => {
   beforeEach(() => {
     fetchMock.get(DATASOURCE_ENDPOINT, [], { overwriteRoutes: true });
@@ -41,7 +40,7 @@ describe('DatasourceEditor Currency Tests', () => {
   });
 
   // The problematic test, now optimized
-  test('renders currency controls', async () => {
+  it('renders currency controls', async () => {
     // Setup a metric with currency data
     const propsWithCurrency = {
       ...props,

superset-frontend/src/components/Datasource/components/DatasourceEditor/tests/DatasourceEditorRTL.test.jsx

@@ -24,7 +24,6 @@ import {
   DATASOURCE_ENDPOINT,
 } from './DatasourceEditor.test';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('DatasourceEditor RTL Metrics Tests', () => {
   beforeEach(() => {
     fetchMock.get(DATASOURCE_ENDPOINT, [], { overwriteRoutes: true });
@@ -35,7 +34,7 @@ describe('DatasourceEditor RTL Metrics Tests', () => {
     fetchMock.restore();
   });
 
-  test('properly renders the metric information', async () => {
+  it('properly renders the metric information', async () => {
     await asyncRender(props);
 
     const metricButton = screen.getByTestId('collection-tab-Metrics');
@@ -53,7 +52,7 @@ describe('DatasourceEditor RTL Metrics Tests', () => {
     expect(warningMarkdown.value).toEqual('someone');
   });
 
-  test('properly updates the metric information', async () => {
+  it('properly updates the metric information', async () => {
     await asyncRender(props);
 
     const metricButton = screen.getByTestId('collection-tab-Metrics');
@@ -83,7 +82,6 @@ describe('DatasourceEditor RTL Metrics Tests', () => {
   });
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('DatasourceEditor RTL Columns Tests', () => {
   beforeEach(() => {
     fetchMock.get(DATASOURCE_ENDPOINT, [], { overwriteRoutes: true });
@@ -94,7 +92,7 @@ describe('DatasourceEditor RTL Columns Tests', () => {
     fetchMock.restore();
   });
 
-  test('shows the default datetime column', async () => {
+  it('shows the default datetime column', async () => {
     await asyncRender(props);
 
     const columnsButton = screen.getByTestId('collection-tab-Columns');
@@ -109,7 +107,7 @@ describe('DatasourceEditor RTL Columns Tests', () => {
     expect(genderDefaultDatetimeRadio).not.toBeChecked();
   });
 
-  test('allows choosing only temporal columns as the default datetime', async () => {
+  it('allows choosing only temporal columns as the default datetime', async () => {
     await asyncRender(props);
 
     const columnsButton = screen.getByTestId('collection-tab-Columns');

superset-frontend/src/components/Datasource/utils/utils.test.tsx

@@ -20,7 +20,6 @@
 import { tn } from '@superset-ui/core';
 import { updateColumns } from '.';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('updateColumns', () => {
   let addSuccessToast: jest.Mock;
 
@@ -28,7 +27,7 @@ describe('updateColumns', () => {
     addSuccessToast = jest.fn();
   });
 
-  test('adds new columns when prevCols is empty', () => {
+  it('adds new columns when prevCols is empty', () => {
     interface Column {
       column_name: string;
       type: string;
@@ -57,7 +56,7 @@ describe('updateColumns', () => {
     );
   });
 
-  test('modifies columns when type or is_dttm changes', () => {
+  it('modifies columns when type or is_dttm changes', () => {
     const prevCols = [
       { column_name: 'col1', type: 'string', is_dttm: false },
       { column_name: 'col2', type: 'number', is_dttm: false },
@@ -95,7 +94,7 @@ describe('updateColumns', () => {
     );
   });
 
-  test('removes columns not present in newCols', () => {
+  it('removes columns not present in newCols', () => {
     const prevCols = [
       { column_name: 'col1', type: 'string', is_dttm: false },
       { column_name: 'col2', type: 'number', is_dttm: true },
@@ -122,7 +121,7 @@ describe('updateColumns', () => {
     );
   });
 
-  test('handles combined additions, modifications, and removals', () => {
+  it('handles combined additions, modifications, and removals', () => {
     const prevCols = [
       { column_name: 'col1', type: 'string', is_dttm: false },
       { column_name: 'col2', type: 'number', is_dttm: false },
@@ -171,7 +170,7 @@ describe('updateColumns', () => {
       ],
     ]);
   });
-  test('should not remove columns with expressions', () => {
+  it('should not remove columns with expressions', () => {
     const prevCols = [
       { column_name: 'col1', type: 'string', is_dttm: false },
       { column_name: 'col2', type: 'number', is_dttm: false },

superset-frontend/src/components/ErrorMessage/ErrorAlert.test.tsx

@@ -20,71 +20,72 @@
 import { screen, fireEvent, render } from 'spec/helpers/testing-library';
 import { ErrorAlert } from './ErrorAlert';
 
-// ErrorAlert
-test('ErrorAlert renders the error message correctly', () => {
-  render(
-    <ErrorAlert
-      errorType="Error"
-      message="Something went wrong"
-      type="error"
-    />,
-  );
+describe('ErrorAlert', () => {
+  it('renders the error message correctly', () => {
+    render(
+      <ErrorAlert
+        errorType="Error"
+        message="Something went wrong"
+        type="error"
+      />,
+    );
 
-  expect(screen.getByText('Error')).toBeInTheDocument();
-  expect(screen.getByText('Something went wrong')).toBeInTheDocument();
-});
-
-test('ErrorAlert renders the description when provided', () => {
-  const description = 'This is a detailed description';
-  render(
-    <ErrorAlert
-      errorType="Error"
-      message="Something went wrong"
-      type="error"
-      description={description}
-    />,
-  );
-
-  expect(screen.getByText(description)).toBeInTheDocument();
-});
-
-test('ErrorAlert toggles description details visibility when show more/less is clicked', () => {
-  const descriptionDetails = 'Additional details about the error.';
-  render(
-    <ErrorAlert
-      errorType="Error"
-      message="Something went wrong"
-      type="error"
-      descriptionDetails={descriptionDetails}
-      descriptionDetailsCollapsed
-    />,
-  );
-
-  const showMoreButton = screen.getByText('See more');
-  expect(showMoreButton).toBeInTheDocument();
-
-  fireEvent.click(showMoreButton);
-  expect(screen.getByText(descriptionDetails)).toBeInTheDocument();
-
-  const showLessButton = screen.getByText('See less');
-  fireEvent.click(showLessButton);
-  expect(screen.queryByText(descriptionDetails)).not.toBeInTheDocument();
-});
-
-test('ErrorAlert renders compact mode with a tooltip and modal', () => {
-  render(
-    <ErrorAlert
-      errorType="Error"
-      message="Compact mode example"
-      type="error"
-      compact
-      descriptionDetails="Detailed description in compact mode."
-    />,
-  );
-
-  const iconTrigger = screen.getByText('Error');
-  expect(iconTrigger).toBeInTheDocument();
-
-  fireEvent.click(iconTrigger);
-  expect(screen.getByText('Compact mode example')).toBeInTheDocument();
+    expect(screen.getByText('Error')).toBeInTheDocument();
+    expect(screen.getByText('Something went wrong')).toBeInTheDocument();
+  });
+
+  it('renders the description when provided', () => {
+    const description = 'This is a detailed description';
+    render(
+      <ErrorAlert
+        errorType="Error"
+        message="Something went wrong"
+        type="error"
+        description={description}
+      />,
+    );
+
+    expect(screen.getByText(description)).toBeInTheDocument();
+  });
+
+  it('toggles description details visibility when show more/less is clicked', () => {
+    const descriptionDetails = 'Additional details about the error.';
+    render(
+      <ErrorAlert
+        errorType="Error"
+        message="Something went wrong"
+        type="error"
+        descriptionDetails={descriptionDetails}
+        descriptionDetailsCollapsed
+      />,
+    );
+
+    const showMoreButton = screen.getByText('See more');
+    expect(showMoreButton).toBeInTheDocument();
+
+    fireEvent.click(showMoreButton);
+    expect(screen.getByText(descriptionDetails)).toBeInTheDocument();
+
+    const showLessButton = screen.getByText('See less');
+    fireEvent.click(showLessButton);
+    expect(screen.queryByText(descriptionDetails)).not.toBeInTheDocument();
+  });
+
+  it('renders compact mode with a tooltip and modal', () => {
+    render(
+      <ErrorAlert
+        errorType="Error"
+        message="Compact mode example"
+        type="error"
+        compact
+        descriptionDetails="Detailed description in compact mode."
+      />,
+    );
+
+    const iconTrigger = screen.getByText('Error');
+    expect(iconTrigger).toBeInTheDocument();
+
+    fireEvent.click(iconTrigger);
+    expect(screen.getByText('Compact mode example')).toBeInTheDocument();
+  });
 });

superset-frontend/src/components/ErrorMessage/InvalidSQLErrorMessage.test.tsx

@@ -54,7 +54,6 @@ const missingExtraProps = {
 const renderComponent = (overrides = {}) =>
   render(<InvalidSQLErrorMessage {...defaultProps} {...overrides} />);
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('InvalidSQLErrorMessage', () => {
   beforeAll(() => {
     jest.setTimeout(30000);
@@ -65,7 +64,7 @@ describe('InvalidSQLErrorMessage', () => {
     await new Promise(resolve => setTimeout(resolve, 0));
   });
 
-  test('renders the error message with correct properties', async () => {
+  it('renders the error message with correct properties', async () => {
     const { getByText, unmount } = renderComponent();
 
     // Validate main properties
@@ -76,13 +75,13 @@ describe('InvalidSQLErrorMessage', () => {
     unmount();
   });
 
-  test('renders the error message with the empty extra properties', () => {
+  it('renders the error message with the empty extra properties', () => {
     const { getByText } = renderComponent(missingExtraProps);
     expect(getByText('Unable to parse SQL')).toBeInTheDocument();
     expect(getByText(missingExtraProps.error.message)).toBeInTheDocument();
   });
 
-  test('displays the SQL error line and column indicator', async () => {
+  it('displays the SQL error line and column indicator', async () => {
     const { getByText, container, unmount } = renderComponent();
 
     // Validate SQL and caret indicator
@@ -96,7 +95,7 @@ describe('InvalidSQLErrorMessage', () => {
     unmount();
   });
 
-  test('handles missing line number gracefully', async () => {
+  it('handles missing line number gracefully', async () => {
     const overrides = {
       error: {
         ...defaultProps.error,
@@ -115,7 +114,7 @@ describe('InvalidSQLErrorMessage', () => {
     unmount();
   });
 
-  test('handles missing column number gracefully', async () => {
+  it('handles missing column number gracefully', async () => {
     const overrides = {
       error: {
         ...defaultProps.error,

superset-frontend/src/components/ErrorMessage/MarshmallowErrorMessage.test.tsx

@@ -21,7 +21,6 @@ import { render, screen, fireEvent } from 'spec/helpers/testing-library';
 import { ErrorLevel, ErrorTypeEnum } from '@superset-ui/core';
 import { MarshmallowErrorMessage } from './MarshmallowErrorMessage';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('MarshmallowErrorMessage', () => {
   const mockError = {
     extra: {

superset-frontend/src/components/ErrorMessage/OAuth2RedirectMessage.test.tsx

@@ -99,16 +99,15 @@ const setup = (overrides = {}) => (
   </Provider>
 );
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('OAuth2RedirectMessage Component', () => {
-  test('renders without crashing and displays the correct initial UI elements', () => {
+  it('renders without crashing and displays the correct initial UI elements', () => {
     const { getByText } = render(setup());
 
     expect(getByText(/Authorization needed/i)).toBeInTheDocument();
     expect(getByText(/provide authorization/i)).toBeInTheDocument();
   });
 
-  test('opens a new window with the correct URL when the link is clicked', () => {
+  it('opens a new window with the correct URL when the link is clicked', () => {
     const { getByText } = render(setup());
 
     const linkElement = getByText(/provide authorization/i);
@@ -117,7 +116,7 @@ describe('OAuth2RedirectMessage Component', () => {
     expect(mockOpen).toHaveBeenCalledWith('https://example.com', '_blank');
   });
 
-  test('cleans up the message event listener on unmount', () => {
+  it('cleans up the message event listener on unmount', () => {
     const { unmount } = render(setup());
 
     expect(mockAddEventListener).toHaveBeenCalled();
@@ -125,7 +124,7 @@ describe('OAuth2RedirectMessage Component', () => {
     expect(mockRemoveEventListener).toHaveBeenCalled();
   });
 
-  test('dispatches reRunQuery action when a message with correct tab ID is received for SQL Lab', async () => {
+  it('dispatches reRunQuery action when a message with correct tab ID is received for SQL Lab', async () => {
     render(setup());
 
     simulateMessageEvent({ tabId: 'tabId' }, 'https://redirect.example.com');
@@ -135,7 +134,7 @@ describe('OAuth2RedirectMessage Component', () => {
     });
   });
 
-  test('dispatches triggerQuery action for explore source upon receiving a correct message', async () => {
+  it('dispatches triggerQuery action for explore source upon receiving a correct message', async () => {
     render(setup({ source: 'explore' }));
 
     simulateMessageEvent({ tabId: 'tabId' }, 'https://redirect.example.com');
@@ -145,7 +144,7 @@ describe('OAuth2RedirectMessage Component', () => {
     });
   });
 
-  test('dispatches onRefresh action for dashboard source upon receiving a correct message', async () => {
+  it('dispatches onRefresh action for dashboard source upon receiving a correct message', async () => {
     render(setup({ source: 'dashboard' }));
 
     simulateMessageEvent({ tabId: 'tabId' }, 'https://redirect.example.com');

superset-frontend/src/components/FacePile/FacePile.test.tsx

@@ -57,16 +57,15 @@ afterEach(() => {
   cleanup();
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('FacePile', () => {
-  test('renders empty state with no users', () => {
+  it('renders empty state with no users', () => {
     const { container } = render(<FacePile users={[]} />, { store });
 
     expect(container.querySelector('.ant-avatar-group')).toBeInTheDocument();
     expect(container.querySelectorAll('.ant-avatar')).toHaveLength(0);
   });
 
-  test('renders single user without truncation', () => {
+  it('renders single user without truncation', () => {
     const { container } = render(<FacePile users={users.slice(0, 1)} />, {
       store,
     });
@@ -77,7 +76,7 @@ describe('FacePile', () => {
     expect(within(container).queryByText(/\+/)).not.toBeInTheDocument();
   });
 
-  test('renders multiple users no truncation', () => {
+  it('renders multiple users no truncation', () => {
     const { container } = render(<FacePile users={users.slice(0, 4)} />, {
       store,
     });
@@ -91,7 +90,7 @@ describe('FacePile', () => {
     expect(within(container).queryByText(/\+/)).not.toBeInTheDocument();
   });
 
-  test('renders multiple users with truncation', () => {
+  it('renders multiple users with truncation', () => {
     const { container } = render(<FacePile users={users} />, { store });
 
     // Should show 4 avatars + 1 overflow indicator = 5 total elements
@@ -108,7 +107,7 @@ describe('FacePile', () => {
     expect(within(container).getByText('+6')).toBeInTheDocument();
   });
 
-  test('displays user tooltip on hover', () => {
+  it('displays user tooltip on hover', () => {
     const { container } = render(<FacePile users={users.slice(0, 2)} />, {
       store,
     });
@@ -120,7 +119,7 @@ describe('FacePile', () => {
     expect(screen.getByRole('tooltip')).toHaveTextContent('user 0');
   });
 
-  test('displays avatar images when Slack avatars are enabled', () => {
+  it('displays avatar images when Slack avatars are enabled', () => {
     // Enable Slack avatars feature flag
     mockIsFeatureEnabled.mockImplementation(
       feature => feature === 'SLACK_ENABLE_AVATARS',
@@ -144,26 +143,24 @@ describe('FacePile', () => {
   });
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('utils', () => {
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('getRandomColor', () => {
     const colors = ['color1', 'color2', 'color3'];
 
-    test('produces the same color for the same input values', () => {
+    it('produces the same color for the same input values', () => {
       const name = 'foo';
       expect(getRandomColor(name, colors)).toEqual(
         getRandomColor(name, colors),
       );
     });
 
-    test('produces a different color for different input values', () => {
+    it('produces a different color for different input values', () => {
       expect(getRandomColor('foo', colors)).not.toEqual(
         getRandomColor('bar', colors),
       );
     });
 
-    test('handles non-ascii input values', () => {
+    it('handles non-ascii input values', () => {
       expect(getRandomColor('泰', colors)).toMatchInlineSnapshot(`"color1"`);
       expect(getRandomColor('مُحَمَّد‎', colors)).toMatchInlineSnapshot(
         `"color2"`,

superset-frontend/src/components/FilterableTable/FilterableTable.test.tsx

@@ -26,7 +26,6 @@ import {
 import { setupAGGridModules } from '@superset-ui/core/components/ThemedAgGridReact';
 import { FilterableTable } from '.';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('FilterableTable', () => {
   beforeAll(() => {
     setupAGGridModules();
@@ -41,10 +40,10 @@ describe('FilterableTable', () => {
     ],
     height: 500,
   };
-  test('is valid element', () => {
+  it('is valid element', () => {
     expect(isValidElement(<FilterableTable {...mockedProps} />)).toBe(true);
   });
-  test('renders a grid with 3 Table rows', () => {
+  it('renders a grid with 3 Table rows', () => {
     const { getByRole, getByText } = render(
       <FilterableTable {...mockedProps} />,
     );
@@ -53,7 +52,7 @@ describe('FilterableTable', () => {
       expect(getByText(columnBContent)).toBeInTheDocument();
     });
   });
-  test('filters on a string', () => {
+  it('filters on a string', () => {
     const props = {
       ...mockedProps,
       filterText: 'b1',
@@ -63,7 +62,7 @@ describe('FilterableTable', () => {
     expect(queryByText('b2')).not.toBeInTheDocument();
     expect(queryByText('b3')).not.toBeInTheDocument();
   });
-  test('filters on a number', () => {
+  it('filters on a number', () => {
     const props = {
       ...mockedProps,
       filterText: '100',
@@ -75,13 +74,12 @@ describe('FilterableTable', () => {
   });
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('FilterableTable sorting - RTL', () => {
   beforeAll(() => {
     setupAGGridModules();
   });
 
-  test('sorts strings correctly', () => {
+  it('sorts strings correctly', () => {
     const stringProps = {
       orderedColumnKeys: ['columnA'],
       data: [
@@ -130,7 +128,7 @@ describe('FilterableTable sorting - RTL', () => {
     );
   });
 
-  test('sorts integers correctly', () => {
+  it('sorts integers correctly', () => {
     const integerProps = {
       orderedColumnKeys: ['columnB'],
       data: [{ columnB: 21 }, { columnB: 0 }, { columnB: 623 }],
@@ -165,7 +163,7 @@ describe('FilterableTable sorting - RTL', () => {
     expect(gridCells?.textContent).toEqual(['21', '0', '623'].join(''));
   });
 
-  test('sorts floating numbers correctly', () => {
+  it('sorts floating numbers correctly', () => {
     const floatProps = {
       orderedColumnKeys: ['columnC'],
       data: [{ columnC: 45.67 }, { columnC: 1.23 }, { columnC: 89.0000001 }],
@@ -208,7 +206,7 @@ describe('FilterableTable sorting - RTL', () => {
     );
   });
 
-  test('sorts rows properly when floating numbers have mixed types', () => {
+  it('sorts rows properly when floating numbers have mixed types', () => {
     const mixedFloatProps = {
       orderedColumnKeys: ['columnD'],
       data: [
@@ -310,7 +308,7 @@ describe('FilterableTable sorting - RTL', () => {
     );
   });
 
-  test('sorts YYYY-MM-DD properly', () => {
+  it('sorts YYYY-MM-DD properly', () => {
     const dsProps = {
       orderedColumnKeys: ['columnDS'],
       data: [

superset-frontend/src/components/GridTable/HeaderMenu.test.tsx

@@ -152,7 +152,6 @@ test('renders unhide when invisible column exists', async () => {
   expect(mockGridApi.setColumnsVisible).toHaveBeenCalledWith(['column2'], true);
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('for main menu', () => {
   test('renders Copy to Clipboard', async () => {
     const { getByText } = setup({ ...mockedProps, isMain: true });

superset-frontend/src/components/ListView/ListView.test.jsx

@@ -130,7 +130,6 @@ const factory = (props = mockedProps) =>
     { store: mockStore() },
   );
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('ListView', () => {
   beforeEach(() => {
     fetchMock.reset();
@@ -147,7 +146,7 @@ describe('ListView', () => {
   });
 
   // Example of converted test:
-  test('calls fetchData on mount', () => {
+  it('calls fetchData on mount', () => {
     expect(mockedProps.fetchData).toHaveBeenCalledWith({
       filters: [],
       pageIndex: 0,
@@ -156,7 +155,7 @@ describe('ListView', () => {
     });
   });
 
-  test('calls fetchData on sort', async () => {
+  it('calls fetchData on sort', async () => {
     const sortHeader = screen.getAllByTestId('sort-header')[1];
     await userEvent.click(sortHeader);
 
@@ -174,7 +173,7 @@ describe('ListView', () => {
   });
 
   // Update pagination control tests for Ant Design pagination
-  test('renders pagination controls', () => {
+  it('renders pagination controls', () => {
     const paginationList = screen.getByRole('list');
     expect(paginationList).toBeInTheDocument();
 
@@ -182,7 +181,7 @@ describe('ListView', () => {
     expect(pageOneItem).toBeInTheDocument();
   });
 
-  test('calls fetchData on page change', async () => {
+  it('calls fetchData on page change', async () => {
     const pageTwoItem = screen.getByRole('listitem', { name: '2' });
     await userEvent.click(pageTwoItem);
 
@@ -198,7 +197,7 @@ describe('ListView', () => {
     });
   });
 
-  test('handles bulk actions on 1 row', async () => {
+  it('handles bulk actions on 1 row', async () => {
     const checkboxes = screen.getAllByRole('checkbox');
     await userEvent.click(checkboxes[1]); // Index 1 is the first row checkbox
 
@@ -218,12 +217,12 @@ describe('ListView', () => {
   });
 
   // Update UI filters test to use more specific selector
-  test('renders UI filters', () => {
+  it('renders UI filters', () => {
     const filterControls = screen.getAllByRole('combobox');
     expect(filterControls).toHaveLength(2);
   });
 
-  test('calls fetchData on filter', async () => {
+  it('calls fetchData on filter', async () => {
     // Handle select filter
     const selectFilter = screen.getAllByRole('combobox')[0];
     await userEvent.click(selectFilter);
@@ -253,7 +252,7 @@ describe('ListView', () => {
     );
   });
 
-  test('calls fetchData on card view sort', async () => {
+  it('calls fetchData on card view sort', async () => {
     factory({
       ...mockedProps,
       renderCard: jest.fn(),

superset-frontend/src/components/MessageToasts/reducers.test.js

@@ -19,25 +19,26 @@
 import { ADD_TOAST, REMOVE_TOAST } from 'src/components/MessageToasts/actions';
 import messageToastsReducer from 'src/components/MessageToasts/reducers';
 
-// messageToasts reducer
-test('messageToasts reducer should return initial state', () => {
-  expect(messageToastsReducer(undefined, {})).toEqual([]);
-});
+describe('messageToasts reducer', () => {
+  it('should return initial state', () => {
+    expect(messageToastsReducer(undefined, {})).toEqual([]);
+  });
 
-test('messageToasts reducer should add a toast', () => {
-  expect(
-    messageToastsReducer([], {
-      type: ADD_TOAST,
-      payload: { text: 'test', id: 'id', type: 'test_type' },
-    }),
-  ).toEqual([{ text: 'test', id: 'id', type: 'test_type' }]);
-});
+  it('should add a toast', () => {
+    expect(
+      messageToastsReducer([], {
+        type: ADD_TOAST,
+        payload: { text: 'test', id: 'id', type: 'test_type' },
+      }),
+    ).toEqual([{ text: 'test', id: 'id', type: 'test_type' }]);
+  });
 
-test('messageToasts reducer should remove a toast', () => {
-  expect(
-    messageToastsReducer([{ id: 'id' }, { id: 'id2' }], {
-      type: REMOVE_TOAST,
-      payload: { id: 'id' },
-    }),
-  ).toEqual([{ id: 'id2' }]);
+  it('should remove a toast', () => {
+    expect(
+      messageToastsReducer([{ id: 'id' }, { id: 'id2' }], {
+        type: REMOVE_TOAST,
+        payload: { id: 'id' },
+      }),
+    ).toEqual([{ id: 'id2' }]);
+  });
 });

superset-frontend/src/components/ModalTitleWithIcon/ModalTitleWithIcon.test.tsx

@@ -20,40 +20,41 @@ import { render, screen } from 'spec/helpers/testing-library';
 import { Icons } from '@superset-ui/core/components';
 import { ModalTitleWithIcon } from '.';
 
-// ModalTitleWithIcon
-test('ModalTitleWithIcon renders the title without icon if none is passed and isEditMode is undefined', () => {
-  render(<ModalTitleWithIcon title="My Title" />);
-  expect(screen.getByText('My Title')).toBeInTheDocument();
+describe('ModalTitleWithIcon', () => {
+  it('renders the title without icon if none is passed and isEditMode is undefined', () => {
+    render(<ModalTitleWithIcon title="My Title" />);
+    expect(screen.getByText('My Title')).toBeInTheDocument();
 
-  expect(screen.queryByRole('img')).not.toBeInTheDocument();
-});
+    expect(screen.queryByRole('img')).not.toBeInTheDocument();
+  });
 
-test('ModalTitleWithIcon renders Edit icon if isEditMode is true', () => {
-  render(<ModalTitleWithIcon title="Edit Mode" isEditMode />);
-  expect(screen.getByText('Edit Mode')).toBeInTheDocument();
-  expect(screen.getByRole('img', { name: /edit/i })).toBeInTheDocument();
-});
+  it('renders Edit icon if isEditMode is true', () => {
+    render(<ModalTitleWithIcon title="Edit Mode" isEditMode />);
+    expect(screen.getByText('Edit Mode')).toBeInTheDocument();
+    expect(screen.getByRole('img', { name: /edit/i })).toBeInTheDocument();
+  });
 
-test('ModalTitleWithIcon renders Plus icon if isEditMode is false', () => {
-  render(<ModalTitleWithIcon title="Add Mode" isEditMode={false} />);
-  expect(screen.getByText('Add Mode')).toBeInTheDocument();
-  expect(screen.getByRole('img', { name: /plus/i })).toBeInTheDocument();
-});
+  it('renders Plus icon if isEditMode is false', () => {
+    render(<ModalTitleWithIcon title="Add Mode" isEditMode={false} />);
+    expect(screen.getByText('Add Mode')).toBeInTheDocument();
+    expect(screen.getByRole('img', { name: /plus/i })).toBeInTheDocument();
+  });
 
-test('ModalTitleWithIcon renders custom icon when passed explicitly', () => {
-  render(
-    <ModalTitleWithIcon
-      title="Custom Icon"
-      icon={<Icons.DownOutlined data-test="custom-icon" />}
-    />,
-  );
-  expect(screen.getByText('Custom Icon')).toBeInTheDocument();
-  expect(screen.getByTestId('custom-icon')).toBeInTheDocument();
-});
+  it('renders custom icon when passed explicitly', () => {
+    render(
+      <ModalTitleWithIcon
+        title="Custom Icon"
+        icon={<Icons.DownOutlined data-test="custom-icon" />}
+      />,
+    );
+    expect(screen.getByText('Custom Icon')).toBeInTheDocument();
+    expect(screen.getByTestId('custom-icon')).toBeInTheDocument();
+  });
 
-test('ModalTitleWithIcon respects the level prop (e.g., renders h3 for level=3)', () => {
-  const { container } = render(
-    <ModalTitleWithIcon title="Header Level 3" level={3} />,
-  );
-  expect(container.querySelector('h3')).toHaveTextContent('Header Level 3');
+  it('respects the level prop (e.g., renders h3 for level=3)', () => {
+    const { container } = render(
+      <ModalTitleWithIcon title="Header Level 3" level={3} />,
+    );
+    expect(container.querySelector('h3')).toHaveTextContent('Header Level 3');
+  });
 });

superset-frontend/src/components/ResizableSidebar/useStoredSidebarWidth.test.ts

@@ -26,7 +26,6 @@ import useStoredSidebarWidth from './useStoredSidebarWidth';
 
 const INITIAL_WIDTH = 300;
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('useStoredSidebarWidth', () => {
   beforeEach(() => {
     localStorage.clear();
@@ -36,7 +35,7 @@ describe('useStoredSidebarWidth', () => {
     localStorage.clear();
   });
 
-  test('returns a default filterBar width by initialWidth', () => {
+  it('returns a default filterBar width by initialWidth', () => {
     const id = '123';
     const { result } = renderHook(() =>
       useStoredSidebarWidth(id, INITIAL_WIDTH),
@@ -46,7 +45,7 @@ describe('useStoredSidebarWidth', () => {
     expect(actualWidth).toEqual(INITIAL_WIDTH);
   });
 
-  test('returns a stored filterBar width from localStorage', () => {
+  it('returns a stored filterBar width from localStorage', () => {
     const id = '123';
     const expectedWidth = 378;
     setItem(LocalStorageKeys.CommonResizableSidebarWidths, {
@@ -62,7 +61,7 @@ describe('useStoredSidebarWidth', () => {
     expect(actualWidth).not.toEqual(250);
   });
 
-  test('returns a setter for filterBar width that stores the state in localStorage together', () => {
+  it('returns a setter for filterBar width that stores the state in localStorage together', () => {
     const id = '123';
     const expectedWidth = 378;
     const otherDashboardId = '456';

superset-frontend/src/components/SQLEditorWithValidation/SQLEditorWithValidation.test.tsx

@@ -41,13 +41,12 @@ const defaultProps = {
   datasourceType: 'table',
 };
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('SQLEditorWithValidation', () => {
   beforeEach(() => {
     jest.clearAllMocks();
   });
 
-  test('renders SQLEditor with validation bar when showValidation is true', () => {
+  it('renders SQLEditor with validation bar when showValidation is true', () => {
     render(<SQLEditorWithValidation {...defaultProps} />);
 
     expect(screen.getByText('Unverified')).toBeInTheDocument();
@@ -56,7 +55,7 @@ describe('SQLEditorWithValidation', () => {
     ).toBeInTheDocument();
   });
 
-  test('does not render validation bar when showValidation is false', () => {
+  it('does not render validation bar when showValidation is false', () => {
     render(
       <SQLEditorWithValidation {...defaultProps} showValidation={false} />,
     );
@@ -67,7 +66,7 @@ describe('SQLEditorWithValidation', () => {
     ).not.toBeInTheDocument();
   });
 
-  test('shows primary button style when unverified', () => {
+  it('shows primary button style when unverified', () => {
     render(<SQLEditorWithValidation {...defaultProps} />);
 
     const validateButton = screen.getByRole('button', {
@@ -77,7 +76,7 @@ describe('SQLEditorWithValidation', () => {
     // Button should have primary styling (this would need to check actual class or style)
   });
 
-  test('disables validate button when no value or datasourceId', () => {
+  it('disables validate button when no value or datasourceId', () => {
     render(
       <SQLEditorWithValidation
         {...defaultProps}
@@ -92,7 +91,7 @@ describe('SQLEditorWithValidation', () => {
     expect(validateButton).toBeDisabled();
   });
 
-  test('shows validating state when validation is in progress', async () => {
+  it('shows validating state when validation is in progress', async () => {
     const mockPost = SupersetClient.post as jest.MockedFunction<
       typeof SupersetClient.post
     >;
@@ -118,7 +117,7 @@ describe('SQLEditorWithValidation', () => {
     });
   });
 
-  test('shows success state when validation passes', async () => {
+  it('shows success state when validation passes', async () => {
     const mockPost = SupersetClient.post as jest.MockedFunction<
       typeof SupersetClient.post
     >;
@@ -139,7 +138,7 @@ describe('SQLEditorWithValidation', () => {
     expect(validateButton).toBeInTheDocument();
   });
 
-  test('shows error state when validation fails', async () => {
+  it('shows error state when validation fails', async () => {
     const mockPost = SupersetClient.post as jest.MockedFunction<
       typeof SupersetClient.post
     >;
@@ -170,7 +169,7 @@ describe('SQLEditorWithValidation', () => {
     });
   });
 
-  test('handles API errors gracefully', async () => {
+  it('handles API errors gracefully', async () => {
     const mockPost = SupersetClient.post as jest.MockedFunction<
       typeof SupersetClient.post
     >;
@@ -190,7 +189,7 @@ describe('SQLEditorWithValidation', () => {
     });
   });
 
-  test('sends correct payload for column expression', async () => {
+  it('sends correct payload for column expression', async () => {
     const mockPost = SupersetClient.post as jest.MockedFunction<
       typeof SupersetClient.post
     >;
@@ -222,7 +221,7 @@ describe('SQLEditorWithValidation', () => {
     });
   });
 
-  test('sends correct payload for WHERE expression', async () => {
+  it('sends correct payload for WHERE expression', async () => {
     const mockPost = SupersetClient.post as jest.MockedFunction<
       typeof SupersetClient.post
     >;
@@ -253,7 +252,7 @@ describe('SQLEditorWithValidation', () => {
     });
   });
 
-  test('sends correct payload for HAVING expression', async () => {
+  it('sends correct payload for HAVING expression', async () => {
     const mockPost = SupersetClient.post as jest.MockedFunction<
       typeof SupersetClient.post
     >;
@@ -284,7 +283,7 @@ describe('SQLEditorWithValidation', () => {
     });
   });
 
-  test('resets validation state when value changes', () => {
+  it('resets validation state when value changes', () => {
     const { rerender } = render(<SQLEditorWithValidation {...defaultProps} />);
 
     // Simulate having a validation result
@@ -305,7 +304,7 @@ describe('SQLEditorWithValidation', () => {
     expect(screen.getByText('Unverified')).toBeInTheDocument();
   });
 
-  test('calls onChange when editor value changes', () => {
+  it('calls onChange when editor value changes', () => {
     const onChange = jest.fn();
     render(<SQLEditorWithValidation {...defaultProps} onChange={onChange} />);
 
@@ -314,7 +313,7 @@ describe('SQLEditorWithValidation', () => {
     expect(onChange).toBeDefined();
   });
 
-  test('calls onValidationComplete callback when provided', async () => {
+  it('calls onValidationComplete callback when provided', async () => {
     const onValidationComplete = jest.fn();
     const mockPost = SupersetClient.post as jest.MockedFunction<
       typeof SupersetClient.post
@@ -338,7 +337,7 @@ describe('SQLEditorWithValidation', () => {
     });
   });
 
-  test('calls onValidationComplete with errors when validation fails', async () => {
+  it('calls onValidationComplete with errors when validation fails', async () => {
     const onValidationComplete = jest.fn();
     const mockPost = SupersetClient.post as jest.MockedFunction<
       typeof SupersetClient.post
@@ -372,7 +371,7 @@ describe('SQLEditorWithValidation', () => {
     });
   });
 
-  test('shows tooltip with full error message when error is truncated', async () => {
+  it('shows tooltip with full error message when error is truncated', async () => {
     const longErrorMessage =
       'This is a very long error message that should be truncated in the display but shown in full in the tooltip when user hovers over it';
 
@@ -411,7 +410,7 @@ describe('SQLEditorWithValidation', () => {
     expect(errorElement.parentElement).toBeTruthy();
   });
 
-  test('handles empty response gracefully', async () => {
+  it('handles empty response gracefully', async () => {
     const mockPost = SupersetClient.post as jest.MockedFunction<
       typeof SupersetClient.post
     >;

superset-frontend/src/components/Tag/utils.test.tsx

@@ -20,7 +20,6 @@ import fetchMock from 'fetch-mock';
 import rison from 'rison';
 import { tagToSelectOption, loadTags } from 'src/components/Tag/utils';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('tagToSelectOption', () => {
   test('converts a Tag object with table_name to a SelectTagsValue', () => {
     const tag = {
@@ -39,7 +38,6 @@ describe('tagToSelectOption', () => {
   });
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('loadTags', () => {
   beforeEach(() => {
     fetchMock.reset();

superset-frontend/src/components/TagsList/TagsList.test.tsx

@@ -79,7 +79,6 @@ test('should render 3 elements when maxTags is set to 3', async () => {
   expect(tagsListItems[2]).toHaveTextContent('+3...');
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('Tag type filtering', () => {
   test('should render only custom type tags (type: 1)', async () => {
     const mixedTypeTags = [

superset-frontend/src/dashboard/actions/dashboardLayout.test.js

@@ -58,7 +58,6 @@ import {
   NEW_ROW_ID,
 } from 'src/dashboard/util/constants';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('dashboardLayout actions', () => {
   const mockState = {
     dashboardState: {
@@ -86,9 +85,8 @@ describe('dashboardLayout actions', () => {
     dashboardFilters.updateLayoutComponents.restore();
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('updateComponents', () => {
-    test('should dispatch an updateLayout action', () => {
+    it('should dispatch an updateLayout action', () => {
       const { getState, dispatch } = setup();
       const nextComponents = { 1: {} };
       const thunk = updateComponents(nextComponents);
@@ -103,7 +101,7 @@ describe('dashboardLayout actions', () => {
       expect(dashboardFilters.updateLayoutComponents.callCount).toEqual(0);
     });
 
-    test('should dispatch a setUnsavedChanges action if hasUnsavedChanges=false', () => {
+    it('should dispatch a setUnsavedChanges action if hasUnsavedChanges=false', () => {
       const { getState, dispatch } = setup({
         dashboardState: { hasUnsavedChanges: false },
       });
@@ -117,9 +115,8 @@ describe('dashboardLayout actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('deleteComponents', () => {
-    test('should dispatch an deleteComponent action', () => {
+    it('should dispatch an deleteComponent action', () => {
       const { getState, dispatch } = setup();
       const thunk = deleteComponent('id', 'parentId');
       thunk(dispatch, getState);
@@ -132,7 +129,7 @@ describe('dashboardLayout actions', () => {
       expect(dashboardFilters.updateLayoutComponents.callCount).toEqual(1);
     });
 
-    test('should dispatch a setUnsavedChanges action if hasUnsavedChanges=false', () => {
+    it('should dispatch a setUnsavedChanges action if hasUnsavedChanges=false', () => {
       const { getState, dispatch } = setup({
         dashboardState: { hasUnsavedChanges: false },
       });
@@ -145,9 +142,8 @@ describe('dashboardLayout actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('updateDashboardTitle', () => {
-    test('should dispatch an updateComponent action for the header component', () => {
+    it('should dispatch an updateComponent action for the header component', () => {
       const { getState, dispatch } = setup();
       const thunk1 = updateDashboardTitle('new text');
       thunk1(dispatch, getState);
@@ -171,9 +167,8 @@ describe('dashboardLayout actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('createTopLevelTabs', () => {
-    test('should dispatch a createTopLevelTabs action', () => {
+    it('should dispatch a createTopLevelTabs action', () => {
       const { getState, dispatch } = setup();
       const dropResult = {};
       const thunk = createTopLevelTabs(dropResult);
@@ -187,7 +182,7 @@ describe('dashboardLayout actions', () => {
       expect(dashboardFilters.updateLayoutComponents.callCount).toEqual(1);
     });
 
-    test('should dispatch a setUnsavedChanges action if hasUnsavedChanges=false', () => {
+    it('should dispatch a setUnsavedChanges action if hasUnsavedChanges=false', () => {
       const { getState, dispatch } = setup({
         dashboardState: { hasUnsavedChanges: false },
       });
@@ -201,9 +196,8 @@ describe('dashboardLayout actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('deleteTopLevelTabs', () => {
-    test('should dispatch a deleteTopLevelTabs action', () => {
+    it('should dispatch a deleteTopLevelTabs action', () => {
       const { getState, dispatch } = setup();
       const dropResult = {};
       const thunk = deleteTopLevelTabs(dropResult);
@@ -217,7 +211,7 @@ describe('dashboardLayout actions', () => {
       expect(dashboardFilters.updateLayoutComponents.callCount).toEqual(1);
     });
 
-    test('should dispatch a setUnsavedChanges action if hasUnsavedChanges=false', () => {
+    it('should dispatch a setUnsavedChanges action if hasUnsavedChanges=false', () => {
       const { getState, dispatch } = setup({
         dashboardState: { hasUnsavedChanges: false },
       });
@@ -231,7 +225,6 @@ describe('dashboardLayout actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('resizeComponent', () => {
     const dashboardLayout = {
       ...mockState.dashboardLayout,
@@ -247,7 +240,7 @@ describe('dashboardLayout actions', () => {
       },
     };
 
-    test('should update the size of the component', () => {
+    it('should update the size of the component', () => {
       const { getState, dispatch } = setup({
         dashboardLayout,
       });
@@ -278,7 +271,7 @@ describe('dashboardLayout actions', () => {
       expect(dispatch.callCount).toBe(2);
     });
 
-    test('should dispatch a setUnsavedChanges action if hasUnsavedChanges=false', () => {
+    it('should dispatch a setUnsavedChanges action if hasUnsavedChanges=false', () => {
       const { getState, dispatch } = setup({
         dashboardState: { hasUnsavedChanges: false },
         dashboardLayout,
@@ -296,9 +289,8 @@ describe('dashboardLayout actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('handleComponentDrop', () => {
-    test('should create a component if it is new', () => {
+    it('should create a component if it is new', () => {
       const { getState, dispatch } = setup();
       const dropResult = {
         source: { id: NEW_COMPONENTS_SOURCE_ID },
@@ -323,7 +315,7 @@ describe('dashboardLayout actions', () => {
       expect(dashboardFilters.updateLayoutComponents.callCount).toEqual(1);
     });
 
-    test('should move a component if the component is not new', () => {
+    it('should move a component if the component is not new', () => {
       const { getState, dispatch } = setup({
         dashboardLayout: {
           // if 'dragging' is not only child will dispatch deleteComponent thunk
@@ -353,7 +345,7 @@ describe('dashboardLayout actions', () => {
       expect(dashboardFilters.updateLayoutComponents.callCount).toEqual(1);
     });
 
-    test('should dispatch a toast if the drop overflows the destination', () => {
+    it('should dispatch a toast if the drop overflows the destination', () => {
       const { getState, dispatch } = setup({
         dashboardLayout: {
           present: {
@@ -382,7 +374,7 @@ describe('dashboardLayout actions', () => {
       expect(dispatch.callCount).toBe(1);
     });
 
-    test('should delete a parent Row or Tabs if the moved child was the only child', () => {
+    it('should delete a parent Row or Tabs if the moved child was the only child', () => {
       const { getState, dispatch } = setup({
         dashboardLayout: {
           present: {
@@ -419,7 +411,7 @@ describe('dashboardLayout actions', () => {
       });
     });
 
-    test('should create top-level tabs if dropped on root', () => {
+    it('should create top-level tabs if dropped on root', () => {
       const { getState, dispatch } = setup();
       const dropResult = {
         source: { id: NEW_COMPONENTS_SOURCE_ID },
@@ -441,7 +433,7 @@ describe('dashboardLayout actions', () => {
       });
     });
 
-    test('should dispatch a toast if drop top-level tab into nested tab', () => {
+    it('should dispatch a toast if drop top-level tab into nested tab', () => {
       const { getState, dispatch } = setup({
         dashboardLayout: {
           present: {
@@ -496,9 +488,8 @@ describe('dashboardLayout actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('undoLayoutAction', () => {
-    test('should dispatch a redux-undo .undo() action', () => {
+    it('should dispatch a redux-undo .undo() action', () => {
       const { getState, dispatch } = setup({
         dashboardLayout: { past: ['non-empty'] },
       });
@@ -509,7 +500,7 @@ describe('dashboardLayout actions', () => {
       expect(dispatch.getCall(0).args[0]).toEqual(UndoActionCreators.undo());
     });
 
-    test('should dispatch a setUnsavedChanges(false) action history length is zero', () => {
+    it('should dispatch a setUnsavedChanges(false) action history length is zero', () => {
       const { getState, dispatch } = setup({
         dashboardLayout: { past: [] },
       });
@@ -521,9 +512,8 @@ describe('dashboardLayout actions', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('redoLayoutAction', () => {
-    test('should dispatch a redux-undo .redo() action', () => {
+    it('should dispatch a redux-undo .redo() action', () => {
       const { getState, dispatch } = setup();
       const thunk = redoLayoutAction();
       thunk(dispatch, getState);
@@ -534,7 +524,7 @@ describe('dashboardLayout actions', () => {
       expect(dashboardFilters.updateLayoutComponents.callCount).toEqual(1);
     });
 
-    test('should dispatch a setUnsavedChanges(true) action if hasUnsavedChanges=false', () => {
+    it('should dispatch a setUnsavedChanges(true) action if hasUnsavedChanges=false', () => {
       const { getState, dispatch } = setup({
         dashboardState: { hasUnsavedChanges: false },
       });

superset-frontend/src/dashboard/actions/dashboardState.test.js

@@ -43,7 +43,6 @@ jest.mock('@superset-ui/core', () => ({
   isFeatureEnabled: jest.fn(),
 }));
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('dashboardState actions', () => {
   const mockState = {
     dashboardState: {
@@ -102,9 +101,8 @@ describe('dashboardState actions', () => {
     return { getState, dispatch, state };
   }
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('saveDashboardRequest', () => {
-    test('should dispatch UPDATE_COMPONENTS_PARENTS_LIST action', () => {
+    it('should dispatch UPDATE_COMPONENTS_PARENTS_LIST action', () => {
       const { getState, dispatch } = setup({
         dashboardState: { hasUnsavedChanges: false },
       });
@@ -117,7 +115,7 @@ describe('dashboardState actions', () => {
       expect(dispatch.getCall(1).args[0].type).toBe(SAVE_DASHBOARD_STARTED);
     });
 
-    test('should post dashboard data with updated redux state', () => {
+    it('should post dashboard data with updated redux state', () => {
       const { getState, dispatch } = setup({
         dashboardState: { hasUnsavedChanges: false },
       });
@@ -146,7 +144,6 @@ describe('dashboardState actions', () => {
       ).toStrictEqual(mockParentsList);
     });
 
-    // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
     describe('FeatureFlag.CONFIRM_DASHBOARD_DIFF', () => {
       beforeEach(() => {
         isFeatureEnabled.mockImplementation(
@@ -158,7 +155,7 @@ describe('dashboardState actions', () => {
         isFeatureEnabled.mockRestore();
       });
 
-      test('dispatches SET_OVERRIDE_CONFIRM when an inspect value has diff', async () => {
+      it('dispatches SET_OVERRIDE_CONFIRM when an inspect value has diff', async () => {
         const id = 192;
         const { getState, dispatch } = setup();
         const thunk = saveDashboardRequest(
@@ -177,7 +174,7 @@ describe('dashboardState actions', () => {
         ).toBe(id);
       });
 
-      test('should post dashboard data with after confirm the overwrite values', async () => {
+      it('should post dashboard data with after confirm the overwrite values', async () => {
         const id = 192;
         const { getState, dispatch } = setup();
         const confirmedDashboardData = {

superset-frontend/src/dashboard/components/AnchorLink/AnchorLink.test.tsx

@@ -19,7 +19,6 @@
 import { render, act } from 'spec/helpers/testing-library';
 import AnchorLink from 'src/dashboard/components/AnchorLink';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('AnchorLink', () => {
   const props = {
     id: 'CHART-123',
@@ -31,7 +30,7 @@ describe('AnchorLink', () => {
     window.location = globalLocation;
   });
 
-  test('should scroll the AnchorLink into view upon mount if id matches hash', async () => {
+  it('should scroll the AnchorLink into view upon mount if id matches hash', async () => {
     const callback = jest.fn();
     jest.spyOn(document, 'getElementById').mockReturnValue({
       scrollIntoView: callback,
@@ -50,7 +49,7 @@ describe('AnchorLink', () => {
     expect(callback).toHaveBeenCalledTimes(1);
   });
 
-  test('should render anchor link without short link button', () => {
+  it('should render anchor link without short link button', () => {
     const { container, queryByRole } = render(
       <AnchorLink showShortLinkButton={false} {...props} />,
       { useRedux: true },
@@ -59,7 +58,7 @@ describe('AnchorLink', () => {
     expect(queryByRole('button')).not.toBeInTheDocument();
   });
 
-  test('should render short link button', () => {
+  it('should render short link button', () => {
     const { getByRole } = render(
       <AnchorLink {...props} showShortLinkButton />,
       { useRedux: true },

superset-frontend/src/dashboard/components/Dashboard.test.jsx

@@ -39,7 +39,6 @@ import { getRelatedCharts } from 'src/dashboard/util/getRelatedCharts';
 
 jest.mock('src/dashboard/util/getRelatedCharts');
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('Dashboard', () => {
   const mockAddSlice = jest.fn();
   const mockRemoveSlice = jest.fn();
@@ -92,19 +91,18 @@ describe('Dashboard', () => {
     jest.clearAllMocks();
   });
 
-  test('should render the children component', () => {
+  it('should render the children component', () => {
     renderDashboard();
     expect(screen.getByText('Test')).toBeInTheDocument();
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('layout changes', () => {
     const layoutWithExtraChart = {
       ...props.layout,
       1001: newComponentFactory(CHART_TYPE, { chartId: 1001 }),
     };
 
-    test('should call addSliceToDashboard if a new slice is added to the layout', () => {
+    it('should call addSliceToDashboard if a new slice is added to the layout', () => {
       const { rerender } = renderDashboard();
 
       rerender(
@@ -118,7 +116,7 @@ describe('Dashboard', () => {
       expect(mockAddSlice).toHaveBeenCalled();
     });
 
-    test('should call removeSliceFromDashboard if a slice is removed from the layout', () => {
+    it('should call removeSliceFromDashboard if a slice is removed from the layout', () => {
       const { rerender } = renderDashboard({ layout: layoutWithExtraChart });
 
       const nextLayout = { ...layoutWithExtraChart };
@@ -136,9 +134,8 @@ describe('Dashboard', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('filter updates', () => {
-    test('should not call refresh when in editMode', () => {
+    it('should not call refresh when in editMode', () => {
       const { rerender } = renderDashboard({ activeFilters: OVERRIDE_FILTERS });
 
       rerender(
@@ -159,7 +156,7 @@ describe('Dashboard', () => {
       expect(mockTriggerQuery).not.toHaveBeenCalled();
     });
 
-    test('should not call refresh when there is no change', () => {
+    it('should not call refresh when there is no change', () => {
       const { rerender } = renderDashboard({ activeFilters: OVERRIDE_FILTERS });
 
       rerender(
@@ -173,7 +170,7 @@ describe('Dashboard', () => {
       expect(mockTriggerQuery).not.toHaveBeenCalled();
     });
 
-    test('should call refresh when native filters changed', () => {
+    it('should call refresh when native filters changed', () => {
       getRelatedCharts.mockReturnValue([230]);
       const { rerender } = renderDashboard({ activeFilters: OVERRIDE_FILTERS });
 
@@ -198,7 +195,7 @@ describe('Dashboard', () => {
       expect(mockTriggerQuery).toHaveBeenCalled();
     });
 
-    test('should call refresh if a filter is added', () => {
+    it('should call refresh if a filter is added', () => {
       getRelatedCharts.mockReturnValue([1]);
       const { rerender } = renderDashboard({ activeFilters: OVERRIDE_FILTERS });
 
@@ -217,7 +214,7 @@ describe('Dashboard', () => {
       expect(mockTriggerQuery).toHaveBeenCalled();
     });
 
-    test('should call refresh if a filter is removed', () => {
+    it('should call refresh if a filter is removed', () => {
       getRelatedCharts.mockReturnValue([1]); // Ensure we return some charts to refresh
       const { rerender } = renderDashboard({ activeFilters: OVERRIDE_FILTERS });
 
@@ -236,7 +233,7 @@ describe('Dashboard', () => {
       expect(mockTriggerQuery).toHaveBeenCalledWith(true, 1);
     });
 
-    test('should call refresh if a filter is changed', () => {
+    it('should call refresh if a filter is changed', () => {
       getRelatedCharts.mockReturnValue([1]);
       const { rerender } = renderDashboard({ activeFilters: OVERRIDE_FILTERS });
 
@@ -256,7 +253,7 @@ describe('Dashboard', () => {
       expect(mockTriggerQuery).toHaveBeenCalled();
     });
 
-    test('should call refresh with multiple chart ids', () => {
+    it('should call refresh with multiple chart ids', () => {
       getRelatedCharts.mockReturnValue([1, 2]);
       const { rerender } = renderDashboard({ activeFilters: OVERRIDE_FILTERS });
 
@@ -276,7 +273,7 @@ describe('Dashboard', () => {
       expect(mockTriggerQuery).toHaveBeenCalled();
     });
 
-    test('should call refresh if a filter scope is changed', () => {
+    it('should call refresh if a filter scope is changed', () => {
       getRelatedCharts.mockReturnValue([2]);
       const { rerender } = renderDashboard({ activeFilters: OVERRIDE_FILTERS });
 
@@ -296,7 +293,7 @@ describe('Dashboard', () => {
       expect(mockTriggerQuery).toHaveBeenCalled();
     });
 
-    test('should call refresh with empty [] if a filter is changed but scope is not applicable', () => {
+    it('should call refresh with empty [] if a filter is changed but scope is not applicable', () => {
       getRelatedCharts.mockReturnValue([]);
       const { rerender } = renderDashboard({
         activeFilters: OVERRIDE_FILTERS,

superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.test.tsx

@@ -83,7 +83,6 @@ jest.mock('src/dashboard/containers/DashboardGrid', () => () => (
   <div data-test="mock-dashboard-grid" />
 ));
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('DashboardBuilder', () => {
   let favStarStub: jest.Mock;
   let activeTabsStub: jest.Mock;
@@ -121,13 +120,13 @@ describe('DashboardBuilder', () => {
     });
   }
 
-  test('should render a StickyContainer with class "dashboard"', () => {
+  it('should render a StickyContainer with class "dashboard"', () => {
     const { getByTestId } = setup();
     const stickyContainer = getByTestId('dashboard-content-wrapper');
     expect(stickyContainer).toHaveClass('dashboard');
   });
 
-  test('should add the "dashboard--editing" class if editMode=true', () => {
+  it('should add the "dashboard--editing" class if editMode=true', () => {
     const { getByTestId } = setup({
       dashboardState: { ...mockState.dashboardState, editMode: true },
     });
@@ -135,13 +134,13 @@ describe('DashboardBuilder', () => {
     expect(stickyContainer).toHaveClass('dashboard dashboard--editing');
   });
 
-  test('should render a DragDroppable DashboardHeader', () => {
+  it('should render a DragDroppable DashboardHeader', () => {
     const { queryByTestId } = setup();
     const header = queryByTestId('dashboard-header-container');
     expect(header).toBeInTheDocument();
   });
 
-  test('should render a Sticky top-level Tabs if the dashboard has tabs', async () => {
+  it('should render a Sticky top-level Tabs if the dashboard has tabs', async () => {
     const { findAllByTestId } = setup({
       dashboardLayout: undoableDashboardLayoutWithTabs,
     });
@@ -163,7 +162,7 @@ describe('DashboardBuilder', () => {
     });
   });
 
-  test('should render one Tabs and two TabPane', async () => {
+  it('should render one Tabs and two TabPane', async () => {
     const { findAllByRole } = setup({
       dashboardLayout: undoableDashboardLayoutWithTabs,
     });
@@ -173,7 +172,7 @@ describe('DashboardBuilder', () => {
     expect(tabPanels.length).toBe(2);
   });
 
-  test('should render a TabPane and DashboardGrid for first Tab', async () => {
+  it('should render a TabPane and DashboardGrid for first Tab', async () => {
     const { findByTestId } = setup({
       dashboardLayout: undoableDashboardLayoutWithTabs,
     });
@@ -189,7 +188,7 @@ describe('DashboardBuilder', () => {
     ).toBe(1);
   });
 
-  test('should render a TabPane and DashboardGrid for second Tab', async () => {
+  it('should render a TabPane and DashboardGrid for second Tab', async () => {
     const { findByTestId } = setup({
       dashboardLayout: undoableDashboardLayoutWithTabs,
       dashboardState: {
@@ -210,13 +209,13 @@ describe('DashboardBuilder', () => {
     ).toBe(1);
   });
 
-  test('should render a BuilderComponentPane if editMode=false and user selects "Insert Components" pane', () => {
+  it('should render a BuilderComponentPane if editMode=false and user selects "Insert Components" pane', () => {
     const { queryAllByTestId } = setup();
     const builderComponents = queryAllByTestId('mock-builder-component-pane');
     expect(builderComponents.length).toBe(0);
   });
 
-  test('should render a BuilderComponentPane if editMode=true and user selects "Insert Components" pane', () => {
+  it('should render a BuilderComponentPane if editMode=true and user selects "Insert Components" pane', () => {
     const { queryAllByTestId } = setup({
       dashboardState: { ...mockState.dashboardState, editMode: true },
     });
@@ -224,7 +223,7 @@ describe('DashboardBuilder', () => {
     expect(builderComponents.length).toBeGreaterThanOrEqual(1);
   });
 
-  test('should change redux state if a top-level Tab is clicked', async () => {
+  it('should change redux state if a top-level Tab is clicked', async () => {
     (setDirectPathToChild as jest.Mock).mockImplementation(arg0 => ({
       type: 'type',
       arg0,
@@ -244,13 +243,13 @@ describe('DashboardBuilder', () => {
     (setDirectPathToChild as jest.Mock).mockReset();
   });
 
-  test('should not display a loading spinner when saving is not in progress', () => {
+  it('should not display a loading spinner when saving is not in progress', () => {
     const { queryByTestId } = setup();
 
     expect(queryByTestId('loading-indicator')).not.toBeInTheDocument();
   });
 
-  test('should display a loading spinner when saving is in progress', async () => {
+  it('should display a loading spinner when saving is in progress', async () => {
     const { findByTestId } = setup({
       dashboardState: { ...mockState.dashboardState, dashboardIsSaving: true },
     });
@@ -258,7 +257,7 @@ describe('DashboardBuilder', () => {
     expect(await findByTestId('loading-indicator')).toBeVisible();
   });
 
-  test('should set FilterBar width by useStoredSidebarWidth', () => {
+  it('should set FilterBar width by useStoredSidebarWidth', () => {
     const expectedValue = 200;
     const setter = jest.fn();
     (useStoredSidebarWidth as jest.Mock).mockImplementation(() => [
@@ -275,7 +274,7 @@ describe('DashboardBuilder', () => {
     expect(filterbar).toHaveStyleRule('width', `${expectedValue}px`);
   });
 
-  test('filter panel state when featureflag is true', () => {
+  it('filter panel state when featureflag is true', () => {
     window.featureFlags = {
       [FeatureFlag.FilterBarClosedByDefault]: true,
     };
@@ -295,7 +294,7 @@ describe('DashboardBuilder', () => {
     expect(filterbar).toHaveStyleRule('width', `${CLOSED_FILTER_BAR_WIDTH}px`);
   });
 
-  test('filter panel state when featureflag is false', () => {
+  it('filter panel state when featureflag is false', () => {
     window.featureFlags = {
       [FeatureFlag.FilterBarClosedByDefault]: false,
     };
@@ -315,7 +314,7 @@ describe('DashboardBuilder', () => {
     expect(filterbar).toHaveStyleRule('width', `${OPEN_FILTER_BAR_WIDTH}px`);
   });
 
-  test('should not render the filter bar when nativeFiltersEnabled is false', () => {
+  it('should not render the filter bar when nativeFiltersEnabled is false', () => {
     jest.spyOn(useNativeFiltersModule, 'useNativeFilters').mockReturnValue({
       showDashboard: true,
       missingInitialFilters: [],
@@ -328,7 +327,7 @@ describe('DashboardBuilder', () => {
     expect(queryByTestId('dashboard-filters-panel')).not.toBeInTheDocument();
   });
 
-  test('should render the filter bar when nativeFiltersEnabled is true and not in edit mode', () => {
+  it('should render the filter bar when nativeFiltersEnabled is true and not in edit mode', () => {
     jest.spyOn(useNativeFiltersModule, 'useNativeFilters').mockReturnValue({
       showDashboard: true,
       missingInitialFilters: [],
@@ -341,7 +340,7 @@ describe('DashboardBuilder', () => {
     expect(queryByTestId('dashboard-filters-panel')).toBeInTheDocument();
   });
 
-  test('should not render the filter bar when in edit mode even if nativeFiltersEnabled is true', () => {
+  it('should not render the filter bar when in edit mode even if nativeFiltersEnabled is true', () => {
     jest.spyOn(useNativeFiltersModule, 'useNativeFilters').mockReturnValue({
       showDashboard: true,
       missingInitialFilters: [],

superset-frontend/src/dashboard/components/FiltersBadge/FiltersBadge.test.tsx

@@ -54,7 +54,6 @@ buildActiveFilters({
   components: dashboardWithFilter,
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('for dashboard filters', () => {
   test('does not show number when there are no active filters', () => {
     const store = getMockStoreWithFilters();
@@ -97,7 +96,6 @@ describe('for dashboard filters', () => {
   });
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('for native filters', () => {
   test('does not show number when there are no active filters', () => {
     const store = getMockStoreWithNativeFilters();

superset-frontend/src/dashboard/components/MissingChart.test.tsx

@@ -28,9 +28,8 @@ const setup = (overrides?: MissingChartProps) => (
   <MissingChart height={100} {...overrides} />
 );
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('MissingChart', () => {
-  test('renders a .missing-chart-container', () => {
+  it('renders a .missing-chart-container', () => {
     const rendered = render(setup());
 
     const missingChartContainer = rendered.container.querySelector(
@@ -39,7 +38,7 @@ describe('MissingChart', () => {
     expect(missingChartContainer).toBeVisible();
   });
 
-  test('renders a .missing-chart-body', () => {
+  it('renders a .missing-chart-body', () => {
     const rendered = render(setup());
 
     const missingChartBody = rendered.container.querySelector(

superset-frontend/src/dashboard/components/PropertiesModal/PropertiesModal.test.tsx

@@ -180,7 +180,6 @@ afterAll(() => {
   fetchMock.restore();
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('PropertiesModal', () => {
   jest.setTimeout(60000); // Increased timeout for complex modal rendering
 

superset-frontend/src/dashboard/components/PropertiesModal/sections/StylingSection.test.tsx

@@ -157,7 +157,6 @@ test('displays current color scheme value', () => {
 });
 
 // CSS Template Tests
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('CSS Template functionality', () => {
   test('does not show CSS template select when feature flag is disabled', () => {
     mockIsFeatureEnabled.mockReturnValue(false);

superset-frontend/src/dashboard/components/SliceAdder.test.tsx

@@ -77,34 +77,33 @@ const defaultProps: Omit<SliceAdderProps, 'theme'> = {
 const renderSliceAdder = (props = defaultProps) =>
   render(<SliceAdder {...props} />, { store: mockStore });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('SliceAdder', () => {
   beforeEach(() => {
     jest.clearAllMocks();
   });
 
-  test('renders the create new chart button', () => {
+  it('renders the create new chart button', () => {
     renderSliceAdder();
     expect(screen.getByText('Create new chart')).toBeInTheDocument();
   });
 
-  test('renders loading state', () => {
+  it('renders loading state', () => {
     renderSliceAdder({ ...defaultProps, isLoading: true });
     expect(screen.getByRole('status')).toBeInTheDocument();
   });
 
-  test('renders error message', () => {
+  it('renders error message', () => {
     const errorMessage = 'Error loading charts';
     renderSliceAdder({ ...defaultProps, errorMessage });
     expect(screen.getByText(errorMessage)).toBeInTheDocument();
   });
 
-  test('fetches slices on mount', () => {
+  it('fetches slices on mount', () => {
     renderSliceAdder();
     expect(defaultProps.fetchSlices).toHaveBeenCalledWith(1, '', 'changed_on');
   });
 
-  test('handles search input changes', async () => {
+  it('handles search input changes', async () => {
     renderSliceAdder();
     const searchInput = screen.getByPlaceholderText('Filter your charts');
     await userEvent.type(searchInput, 'test search');
@@ -115,7 +114,7 @@ describe('SliceAdder', () => {
     );
   });
 
-  test('handles sort selection changes', async () => {
+  it('handles sort selection changes', async () => {
     renderSliceAdder();
     // Update selector to match the actual rendered element
     const sortSelect = screen.getByText('Sort by recent');
@@ -125,7 +124,7 @@ describe('SliceAdder', () => {
     expect(defaultProps.fetchSlices).toHaveBeenCalledWith(1, '', 'viz_type');
   });
 
-  test('handles show only my charts toggle', async () => {
+  it('handles show only my charts toggle', async () => {
     renderSliceAdder();
     const checkbox = screen.getByRole('checkbox');
     await userEvent.click(checkbox);
@@ -136,7 +135,7 @@ describe('SliceAdder', () => {
     );
   });
 
-  test('opens new chart in new tab when create new chart is clicked', () => {
+  it('opens new chart in new tab when create new chart is clicked', () => {
     const windowSpy = jest.spyOn(window, 'open').mockImplementation();
     renderSliceAdder();
     const createButton = screen.getByText('Create new chart');
@@ -149,7 +148,6 @@ describe('SliceAdder', () => {
     windowSpy.mockRestore();
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('sortByComparator', () => {
     const baseSlice = {
       slice_url: '/superset/explore/',
@@ -172,7 +170,7 @@ describe('SliceAdder', () => {
       query_context: null,
     };
 
-    test('should sort by changed_on in descending order', () => {
+    it('should sort by changed_on in descending order', () => {
       const input = [
         {
           ...baseSlice,
@@ -200,7 +198,7 @@ describe('SliceAdder', () => {
       expect(sorted[2].changed_on).toBe(1577836800000);
     });
 
-    test('should sort by other fields in ascending order', () => {
+    it('should sort by other fields in ascending order', () => {
       const input = [
         {
           ...baseSlice,
@@ -230,7 +228,7 @@ describe('SliceAdder', () => {
     });
   });
 
-  test('should update selectedSliceIdsSet when props change', () => {
+  it('should update selectedSliceIdsSet when props change', () => {
     const { rerender } = renderSliceAdder();
     rerender(<SliceAdder {...defaultProps} selectedSliceIds={[129]} />);
     // Verify the internal state was updated by checking if new charts are available

superset-frontend/src/dashboard/components/dnd/DragDroppable.test.jsx

@@ -27,7 +27,6 @@ import {
 } from 'src/dashboard/util/componentTypes';
 import { UnwrappedDragDroppable as DragDroppable } from 'src/dashboard/components/dnd/DragDroppable';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('DragDroppable', () => {
   const props = {
     component: newComponentFactory(CHART_TYPE),
@@ -61,7 +60,7 @@ describe('DragDroppable', () => {
     };
   }
 
-  test('should call its child function', () => {
+  it('should call its child function', () => {
     const renderChild = jest.fn(provided => (
       <div data-test="child-content" {...provided}>
         Test Content
@@ -77,7 +76,7 @@ describe('DragDroppable', () => {
     );
   });
 
-  test('should call its child function with "dragSourceRef" if editMode=true', () => {
+  it('should call its child function with "dragSourceRef" if editMode=true', () => {
     const renderChild = jest.fn().mockImplementation(provided => (
       <div data-test="child-content" {...provided}>
         Test Content
@@ -101,7 +100,7 @@ describe('DragDroppable', () => {
     );
   });
 
-  test('should call its child function with "dropIndicatorProps" dependent on editMode and isDraggingOver', () => {
+  it('should call its child function with "dropIndicatorProps" dependent on editMode and isDraggingOver', () => {
     const renderChild = jest.fn(provided => (
       <div data-test="child-content" {...provided}>
         Test Content
@@ -136,7 +135,7 @@ describe('DragDroppable', () => {
     });
   });
 
-  test('should call props.dragPreviewRef and props.droppableRef on mount', () => {
+  it('should call props.dragPreviewRef and props.droppableRef on mount', () => {
     const dragPreviewRef = jest.fn();
     const droppableRef = jest.fn();
 
@@ -145,7 +144,7 @@ describe('DragDroppable', () => {
     expect(droppableRef).toHaveBeenCalledTimes(1);
   });
 
-  test('should handle forbidden drops correctly', () => {
+  it('should handle forbidden drops correctly', () => {
     const renderChild = jest.fn(provided => (
       <div data-test="child-content" {...provided}>
         Test Content
@@ -179,7 +178,7 @@ describe('DragDroppable', () => {
     });
   });
 
-  test('should handle orientation prop correctly', () => {
+  it('should handle orientation prop correctly', () => {
     const { container } = setup({ orientation: 'column' });
     expect(container.firstChild).toHaveClass('dragdroppable-column');
 
@@ -187,7 +186,7 @@ describe('DragDroppable', () => {
     expect(container2.firstChild).toHaveClass('dragdroppable-row');
   });
 
-  test('should handle disabled drag and drop', () => {
+  it('should handle disabled drag and drop', () => {
     const renderChild = jest.fn(provided => (
       <div data-test="child-content" {...provided}>
         Test Content
@@ -222,7 +221,7 @@ describe('DragDroppable', () => {
   });
 
   // Later in the file, remove the require and use the imported getEmptyImage
-  test('should handle empty drag preview correctly', () => {
+  it('should handle empty drag preview correctly', () => {
     const dragPreviewRef = jest.fn();
 
     setup({
@@ -238,7 +237,7 @@ describe('DragDroppable', () => {
     );
   });
 
-  test('should call onDropIndicatorChange when appropriate', () => {
+  it('should call onDropIndicatorChange when appropriate', () => {
     const onDropIndicatorChange = jest.fn();
     const { rerender } = setup({
       component: newComponentFactory(TAB_TYPE),

superset-frontend/src/dashboard/components/gridComponents/ChartHolder/ChartHolder.test.tsx

@@ -45,7 +45,6 @@ import { GRID_BASE_UNIT, GRID_GUTTER_SIZE } from '../../../util/constants';
 
 const DEFAULT_HEADER_HEIGHT = 22;
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('ChartHolder', () => {
   let scrollViewBase: any;
 
@@ -111,7 +110,7 @@ describe('ChartHolder', () => {
       store,
     });
 
-  test('should render empty state', async () => {
+  it('should render empty state', async () => {
     renderWrapper();
 
     expect(
@@ -125,7 +124,7 @@ describe('ChartHolder', () => {
     expect(screen.getByRole('img', { name: 'empty' })).toBeVisible();
   });
 
-  test('should render anchor link when not editing', async () => {
+  it('should render anchor link when not editing', async () => {
     const store = createMockStore();
     const { rerender } = renderWrapper(store, { editMode: false });
 
@@ -156,7 +155,7 @@ describe('ChartHolder', () => {
     ).toEqual(0);
   });
 
-  test('should highlight when path matches', async () => {
+  it('should highlight when path matches', async () => {
     const store = createMockStore({
       dashboardState: {
         ...mockState.dashboardState,
@@ -203,7 +202,7 @@ describe('ChartHolder', () => {
     );
   });
 
-  test('should calculate the default widthMultiple', async () => {
+  it('should calculate the default widthMultiple', async () => {
     const widthMultiple = 5;
     renderWrapper(createMockStore(), {
       editMode: true,
@@ -232,7 +231,7 @@ describe('ChartHolder', () => {
     expect(computedWidth).toEqual(`${expectedWidth}px`);
   });
 
-  test('should set the resizable width to auto when parent component type is column', async () => {
+  it('should set the resizable width to auto when parent component type is column', async () => {
     renderWrapper(createMockStore(), {
       editMode: true,
       parentComponent: {
@@ -256,7 +255,7 @@ describe('ChartHolder', () => {
     expect(computedWidth).toEqual('auto');
   });
 
-  test("should override the widthMultiple if there's a column in the parent chain whose width is less than the chart", async () => {
+  it("should override the widthMultiple if there's a column in the parent chain whose width is less than the chart", async () => {
     const widthMultiple = 10;
     const parentColumnWidth = 6;
     renderWrapper(createMockStore(), {
@@ -289,7 +288,7 @@ describe('ChartHolder', () => {
     expect(computedWidth).toEqual(`${expectedWidth}px`);
   });
 
-  test('should calculate the chartWidth', async () => {
+  it('should calculate the chartWidth', async () => {
     const widthMultiple = 7;
     const columnWidth = 250;
     renderWrapper(createMockStore(), {
@@ -320,7 +319,7 @@ describe('ChartHolder', () => {
     expect(computedWidth).toEqual(expectedWidth);
   });
 
-  test('should calculate the chartWidth on full screen mode', async () => {
+  it('should calculate the chartWidth on full screen mode', async () => {
     const widthMultiple = 7;
     const columnWidth = 250;
     renderWrapper(createMockStore(), {
@@ -346,7 +345,7 @@ describe('ChartHolder', () => {
     expect(computedWidth).toEqual(expectedWidth);
   });
 
-  test('should calculate the chartHeight', async () => {
+  it('should calculate the chartHeight', async () => {
     const heightMultiple = 12;
     renderWrapper(createMockStore(), {
       fullSizeChartId: null,
@@ -373,7 +372,7 @@ describe('ChartHolder', () => {
     expect(computedWidth).toEqual(expectedWidth);
   });
 
-  test('should calculate the chartHeight on full screen mode', async () => {
+  it('should calculate the chartHeight on full screen mode', async () => {
     const heightMultiple = 12;
     renderWrapper(createMockStore(), {
       component: {
@@ -398,7 +397,7 @@ describe('ChartHolder', () => {
     expect(computedWidth).toEqual(expectedWidth);
   });
 
-  test('should call deleteComponent when deleted', async () => {
+  it('should call deleteComponent when deleted', async () => {
     const deleteComponent = sinon.spy();
     const store = createMockStore();
     const { rerender } = renderWrapper(store, {

superset-frontend/src/dashboard/components/gridComponents/Divider/Divider.test.jsx

@@ -26,7 +26,6 @@ import {
 import { screen, render, userEvent } from 'spec/helpers/testing-library';
 import Divider from './Divider';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('Divider', () => {
   const props = {
     id: 'id',
@@ -47,19 +46,19 @@ describe('Divider', () => {
       useDnd: true,
     });
 
-  test('should render a Draggable', () => {
+  it('should render a Draggable', () => {
     setup();
     expect(screen.getByTestId('dragdroppable-object')).toBeInTheDocument();
   });
 
-  test('should render a div with class "dashboard-component-divider"', () => {
+  it('should render a div with class "dashboard-component-divider"', () => {
     const { container } = setup();
     expect(
       container.querySelector('.dashboard-component-divider'),
     ).toBeInTheDocument();
   });
 
-  test('should render a HoverMenu with DeleteComponentButton in editMode', () => {
+  it('should render a HoverMenu with DeleteComponentButton in editMode', () => {
     setup();
     expect(screen.queryByTestId('hover-menu')).not.toBeInTheDocument();
     expect(screen.queryByRole('button')).not.toBeInTheDocument();
@@ -73,7 +72,7 @@ describe('Divider', () => {
     );
   });
 
-  test('should call deleteComponent when deleted', () => {
+  it('should call deleteComponent when deleted', () => {
     const deleteComponent = sinon.spy();
     setup({ editMode: true, deleteComponent });
     userEvent.click(screen.getByRole('button'));

superset-frontend/src/dashboard/components/gridComponents/DynamicComponent/DynamicComponent.test.tsx

@@ -132,7 +132,6 @@ const renderWithRedux = (component: React.ReactElement) =>
     },
   });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('DynamicComponent', () => {
   beforeEach(() => {
     jest.clearAllMocks();

superset-frontend/src/dashboard/components/gridComponents/Header/Header.test.jsx

@@ -31,7 +31,6 @@ import {
 import { mockStoreWithTabs } from 'spec/fixtures/mockStore';
 import Header from './Header';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('Header', () => {
   const props = {
     id: 'id',
@@ -58,17 +57,17 @@ describe('Header', () => {
     );
   }
 
-  test('should render a Draggable', () => {
+  it('should render a Draggable', () => {
     setup();
     expect(screen.getByTestId('dragdroppable-object')).toBeInTheDocument();
   });
 
-  test('should render a WithPopoverMenu', () => {
+  it('should render a WithPopoverMenu', () => {
     setup();
     expect(screen.getByRole('none')).toBeInTheDocument();
   });
 
-  test('should render a HoverMenu in editMode', () => {
+  it('should render a HoverMenu in editMode', () => {
     setup();
     expect(screen.queryByTestId('hover-menu')).not.toBeInTheDocument();
 
@@ -77,14 +76,14 @@ describe('Header', () => {
     expect(hoverMenus[0]).toBeInTheDocument();
   });
 
-  test('should render an EditableTitle with meta.text', () => {
+  it('should render an EditableTitle with meta.text', () => {
     setup();
     const titleElement = screen.getByTestId('editable-title');
     expect(titleElement).toBeInTheDocument();
     expect(titleElement).toHaveTextContent(props.component.meta.text);
   });
 
-  test('should call updateComponents when EditableTitle changes', () => {
+  it('should call updateComponents when EditableTitle changes', () => {
     const updateComponents = sinon.spy();
     setup({ editMode: true, updateComponents });
 
@@ -104,13 +103,13 @@ describe('Header', () => {
     );
   });
 
-  test('should render a DeleteComponentButton when focused in editMode', () => {
+  it('should render a DeleteComponentButton when focused in editMode', () => {
     setup({ editMode: true });
     const trashButton = screen.getByRole('img', { name: 'delete' });
     expect(trashButton).toBeInTheDocument();
   });
 
-  test('should call deleteComponent when deleted', () => {
+  it('should call deleteComponent when deleted', () => {
     const deleteComponent = sinon.spy();
     setup({ editMode: true, deleteComponent });
 
@@ -120,17 +119,17 @@ describe('Header', () => {
     expect(deleteComponent.callCount).toBe(1);
   });
 
-  test('should render the AnchorLink in view mode', () => {
+  it('should render the AnchorLink in view mode', () => {
     setup();
     expect(screen.getByTestId('anchor-link')).toBeInTheDocument();
   });
 
-  test('should not render the AnchorLink in edit mode', () => {
+  it('should not render the AnchorLink in edit mode', () => {
     setup({ editMode: true });
     expect(screen.queryByTestId('anchor-link')).not.toBeInTheDocument();
   });
 
-  test('should not render the AnchorLink in embedded mode', () => {
+  it('should not render the AnchorLink in embedded mode', () => {
     setup({ embeddedMode: true });
     expect(screen.queryByTestId('anchor-link')).not.toBeInTheDocument();
   });

superset-frontend/src/dashboard/components/gridComponents/Markdown/Markdown.test.jsx

@@ -22,7 +22,6 @@ import { mockStore } from 'spec/fixtures/mockStore';
 import { dashboardLayout as mockLayout } from 'spec/fixtures/mockDashboardLayout';
 import MarkdownConnected from './Markdown';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('Markdown', () => {
   const props = {
     id: 'id',
@@ -82,12 +81,12 @@ describe('Markdown', () => {
     jest.clearAllMocks();
   });
 
-  test('should render the markdown component', async () => {
+  it('should render the markdown component', async () => {
     await setup();
     expect(screen.getByTestId('dashboard-markdown-editor')).toBeInTheDocument();
   });
 
-  test('should render the markdown content in preview mode by default', async () => {
+  it('should render the markdown content in preview mode by default', async () => {
     await setup();
     expect(screen.queryByRole('textbox')).not.toBeInTheDocument();
     expect(
@@ -95,7 +94,7 @@ describe('Markdown', () => {
     ).toBeInTheDocument();
   });
 
-  test('should render editor when in edit mode and clicked', async () => {
+  it('should render editor when in edit mode and clicked', async () => {
     await setup({ editMode: true });
     const container = screen.getByTestId('dashboard-component-chart-holder');
     await act(async () => {
@@ -105,7 +104,7 @@ describe('Markdown', () => {
     expect(await screen.findByRole('textbox')).toBeInTheDocument();
   });
 
-  test('should switch between edit and preview modes', async () => {
+  it('should switch between edit and preview modes', async () => {
     await setup({ editMode: true });
     const container = screen.getByTestId('dashboard-component-chart-holder');
 
@@ -130,7 +129,7 @@ describe('Markdown', () => {
     expect(screen.queryByRole('textbox')).not.toBeInTheDocument();
   });
 
-  test('should call updateComponents when switching from edit to preview with changes', async () => {
+  it('should call updateComponents when switching from edit to preview with changes', async () => {
     const updateComponents = jest.fn();
     const mockCode = 'new markdown!';
 
@@ -202,7 +201,7 @@ describe('Markdown', () => {
     });
   });
 
-  test('should show placeholder text when markdown is empty', async () => {
+  it('should show placeholder text when markdown is empty', async () => {
     await setup({
       component: {
         ...mockLayout.present.MARKDOWN_ID,
@@ -215,7 +214,7 @@ describe('Markdown', () => {
     ).toBeInTheDocument();
   });
 
-  test('should handle markdown errors gracefully', async () => {
+  it('should handle markdown errors gracefully', async () => {
     const addDangerToast = jest.fn();
     const { container } = await setup({
       addDangerToast,
@@ -251,7 +250,7 @@ describe('Markdown', () => {
     });
   });
 
-  test('should resize editor when width changes', async () => {
+  it('should resize editor when width changes', async () => {
     const { rerender } = await setup({ editMode: true });
 
     await act(async () => {
@@ -279,7 +278,7 @@ describe('Markdown', () => {
     });
   });
 
-  test('should update content when undo/redo changes occur', async () => {
+  it('should update content when undo/redo changes occur', async () => {
     const { rerender } = await setup({
       editMode: true,
       component: {
@@ -306,7 +305,7 @@ describe('Markdown', () => {
     expect(screen.getByText('updated')).toBeInTheDocument();
   });
 
-  test('should adjust width based on parent type', async () => {
+  it('should adjust width based on parent type', async () => {
     const { rerender } = await setup();
 
     // Check ROW_TYPE width

superset-frontend/src/dashboard/components/gridComponents/Row/Row.test.jsx

@@ -202,7 +202,6 @@ test('should increment the depth of its children', () => {
   );
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('visibility handling for intersection observers', () => {
   const mockIntersectionObserver = jest.fn();
   const mockObserve = jest.fn();

superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.test.tsx

@@ -48,7 +48,6 @@ const mockProps: TabsRendererProps = {
   tabBarPaddingLeft: 16,
 };
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('TabsRenderer', () => {
   beforeEach(() => {
     jest.clearAllMocks();

superset-frontend/src/dashboard/components/gridComponents/new/DraggableNewComponent.test.jsx

@@ -25,7 +25,6 @@ import DraggableNewComponent from 'src/dashboard/components/gridComponents/new/D
 import { CHART_TYPE } from 'src/dashboard/util/componentTypes';
 
 // TODO: rewrite to rtl
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('DraggableNewComponent', () => {
   const props = {
     id: 'id',
@@ -46,27 +45,27 @@ describe('DraggableNewComponent', () => {
     setup();
   });
 
-  test('should render a DragDroppable', () => {
+  it('should render a DragDroppable', () => {
     expect(screen.getByTestId('dragdroppable-object')).toBeInTheDocument();
   });
 
-  test('should pass component={ type, id } to DragDroppable', () => {
+  it('should pass component={ type, id } to DragDroppable', () => {
     const dragComponent = screen.getByTestId('dragdroppable-object');
     expect(dragComponent).toHaveClass(
       'dragdroppable dragdroppable--edit-mode dragdroppable-row',
     );
   });
 
-  test('should pass appropriate parent source and id to DragDroppable', () => {
+  it('should pass appropriate parent source and id to DragDroppable', () => {
     const dragComponent = screen.getByTestId('new-component');
     expect(dragComponent).toHaveAttribute('draggable', 'true');
   });
 
-  test('should render the passed label', () => {
+  it('should render the passed label', () => {
     expect(screen.getByText(props.label)).toBeInTheDocument();
   });
 
-  test('should add the passed className', () => {
+  it('should add the passed className', () => {
     const component = screen
       .getByTestId('new-component')
       .querySelector('.new-component-placeholder');

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/ActionButtons.test.tsx

@@ -77,9 +77,8 @@ test('should apply', () => {
   expect(mockedProps.onApply).toHaveBeenCalled();
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('custom width', () => {
-  test('sets its default width with OPEN_FILTER_BAR_WIDTH', () => {
+  it('sets its default width with OPEN_FILTER_BAR_WIDTH', () => {
     const mockedProps = createProps();
     render(<ActionButtons {...mockedProps} />, { useRedux: true });
     const container = screen.getByTestId('filterbar-action-buttons');
@@ -88,7 +87,7 @@ describe('custom width', () => {
     });
   });
 
-  test('sets custom width', () => {
+  it('sets custom width', () => {
     const mockedProps = createProps();
     const expectedWidth = 423;
     const { getByTestId } = render(

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CrossFilters/ScopingModal/ChartsScopingListPanel.test.tsx

@@ -119,7 +119,7 @@ const setup = (props = DEFAULT_PROPS) =>
     initialState: INITIAL_STATE,
   });
 
-test('Renders charts scoping list panel', () => {
+it('Renders charts scoping list panel', () => {
   setup();
   expect(screen.getByText('Add custom scoping')).toBeVisible();
   expect(screen.getByText('All charts/global scoping')).toBeVisible();
@@ -131,7 +131,7 @@ test('Renders charts scoping list panel', () => {
   expect(screen.queryByText('[new custom scoping]')).not.toBeInTheDocument();
 });
 
-test('Renders custom scoping item', () => {
+it('Renders custom scoping item', () => {
   setup({
     ...DEFAULT_PROPS,
     activeChartId: -1,
@@ -158,7 +158,7 @@ test('Renders custom scoping item', () => {
   expect(screen.getByText('[new custom scoping]')).toHaveClass('active');
 });
 
-test('Uses callbacks on click', () => {
+it('Uses callbacks on click', () => {
   setup();
 
   userEvent.click(screen.getByText('Add custom scoping'));
@@ -177,7 +177,7 @@ test('Uses callbacks on click', () => {
   expect(DEFAULT_PROPS.removeCustomScope).toHaveBeenCalledWith(4);
 });
 
-test('Renders charts scoping list panel with FilterTitle rendered with role="button"', () => {
+it('Renders charts scoping list panel with FilterTitle rendered with role="button"', () => {
   setup();
   expect(screen.getByText('All charts/global scoping')).toBeVisible();
   expect(screen.getByText('All charts/global scoping')).toHaveAttribute(

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CrossFilters/ScopingModal/ScopingModal.test.tsx

@@ -158,14 +158,14 @@ afterEach(() => {
   fetchMock.restore();
 });
 
-test('renders modal', () => {
+it('renders modal', () => {
   setup();
   expect(screen.getByRole('dialog')).toBeInTheDocument();
   expect(screen.getByTestId('scoping-tree-panel')).toBeInTheDocument();
   expect(screen.getByTestId('scoping-list-panel')).toBeInTheDocument();
 });
 
-test('switch currently edited chart scoping', async () => {
+it('switch currently edited chart scoping', async () => {
   setup();
   const withinScopingList = within(screen.getByTestId('scoping-list-panel'));
   expect(withinScopingList.getByText('All charts/global scoping')).toHaveClass(
@@ -180,7 +180,7 @@ test('switch currently edited chart scoping', async () => {
   });
 });
 
-test('scoping tree global and custom checks', () => {
+it('scoping tree global and custom checks', () => {
   setup();
 
   expect(
@@ -200,7 +200,7 @@ test('scoping tree global and custom checks', () => {
   ).toHaveLength(2);
 });
 
-test('add new custom scoping', async () => {
+it('add new custom scoping', async () => {
   setup();
 
   userEvent.click(screen.getByText('Add custom scoping'));
@@ -226,7 +226,7 @@ test('add new custom scoping', async () => {
   ).toHaveLength(2);
 });
 
-test('edit scope and save', async () => {
+it('edit scope and save', async () => {
   setup();
 
   // unselect chart 2 in global scoping

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx

@@ -89,7 +89,6 @@ const addFilterFlow = async () => {
   // await screen.findByText('All filters (1)');
 };
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('FilterBar', () => {
   new MainPreset().register();
   const toggleFiltersBar = jest.fn();
@@ -179,39 +178,39 @@ describe('FilterBar', () => {
       },
     );
 
-  test('should render', () => {
+  it('should render', () => {
     const { container } = renderWrapper();
     expect(container).toBeInTheDocument();
   });
 
-  test('should render the "Filters" heading', () => {
+  it('should render the "Filters" heading', () => {
     renderWrapper();
     expect(screen.getByText('Filters')).toBeInTheDocument();
   });
 
-  test('should render the "Clear all" option', () => {
+  it('should render the "Clear all" option', () => {
     renderWrapper();
     expect(screen.getByText('Clear all')).toBeInTheDocument();
   });
 
-  test('should render the "Apply filters" option', () => {
+  it('should render the "Apply filters" option', () => {
     renderWrapper();
     expect(screen.getByText('Apply filters')).toBeInTheDocument();
   });
 
-  test('should render the collapse icon', () => {
+  it('should render the collapse icon', () => {
     renderWrapper();
     expect(
       screen.getByRole('img', { name: 'vertical-align' }),
     ).toBeInTheDocument();
   });
 
-  test('should render the filter icon', () => {
+  it('should render the filter icon', () => {
     renderWrapper();
     expect(screen.getByRole('img', { name: 'filter' })).toBeInTheDocument();
   });
 
-  test('should toggle', () => {
+  it('should toggle', () => {
     renderWrapper();
     const collapse = screen.getByRole('img', {
       name: 'vertical-align',
@@ -221,7 +220,7 @@ describe('FilterBar', () => {
     expect(toggleFiltersBar).toHaveBeenCalled();
   });
 
-  test('open filter bar', () => {
+  it('open filter bar', () => {
     renderWrapper();
     expect(screen.getByTestId(getTestId('filter-icon'))).toBeInTheDocument();
     expect(screen.getByTestId(getTestId('expand-button'))).toBeInTheDocument();
@@ -230,7 +229,7 @@ describe('FilterBar', () => {
     expect(toggleFiltersBar).toHaveBeenCalledWith(true);
   });
 
-  test('no edit filter button by disabled permissions', () => {
+  it('no edit filter button by disabled permissions', () => {
     renderWrapper(openedBarProps, {
       ...stateWithoutNativeFilters,
       dashboardInfo: { metadata: {} },
@@ -241,7 +240,7 @@ describe('FilterBar', () => {
     ).not.toBeInTheDocument();
   });
 
-  test('close filter bar', () => {
+  it('close filter bar', () => {
     renderWrapper(openedBarProps);
     const collapseButton = screen.getByTestId(getTestId('collapse-button'));
 
@@ -251,14 +250,14 @@ describe('FilterBar', () => {
     expect(toggleFiltersBar).toHaveBeenCalledWith(false);
   });
 
-  test('no filters', () => {
+  it('no filters', () => {
     renderWrapper(openedBarProps, stateWithoutNativeFilters);
 
     expect(screen.getByTestId(getTestId('clear-button'))).toBeDisabled();
     expect(screen.getByTestId(getTestId('apply-button'))).toBeDisabled();
   });
 
-  test('renders dividers', async () => {
+  it('renders dividers', async () => {
     const divider = {
       id: 'NATIVE_FILTER_DIVIDER-1',
       type: 'DIVIDER',
@@ -296,7 +295,7 @@ describe('FilterBar', () => {
     expect(screen.getByTestId(getTestId('apply-button'))).toBeDisabled();
   });
 
-  test('create filter and apply it flow', async () => {
+  it('create filter and apply it flow', async () => {
     renderWrapper(openedBarProps, stateWithoutNativeFilters);
     expect(screen.getByTestId(getTestId('apply-button'))).toBeDisabled();
 
@@ -305,7 +304,7 @@ describe('FilterBar', () => {
     expect(screen.getByTestId(getTestId('apply-button'))).toBeDisabled();
   });
 
-  test('should render without errors with proper state setup', () => {
+  it('should render without errors with proper state setup', () => {
     const stateWithFilter = {
       ...stateWithoutNativeFilters,
       dashboardInfo: {

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/utils.test.ts

@@ -24,9 +24,7 @@ import {
   checkIsMissingRequiredValue,
 } from './utils';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('FilterBar Utils - Validation and Apply Logic', () => {
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('checkIsValidateError', () => {
     test('should return true when no filters have validation errors', () => {
       const dataMask: DataMaskStateWithId = {
@@ -91,7 +89,6 @@ describe('FilterBar Utils - Validation and Apply Logic', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('checkIsMissingRequiredValue', () => {
     test('should return true for required filter with undefined value', () => {
       const filter = {
@@ -168,7 +165,6 @@ describe('FilterBar Utils - Validation and Apply Logic', () => {
     });
   });
 
-  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('checkIsApplyDisabled', () => {
     test('should return true when filters have validation errors', () => {
       const dataMaskSelected: DataMaskStateWithId = {

superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/CollapsibleControl.test.tsx

@@ -29,16 +29,15 @@ const defaultProps = {
 const renderCollapsibleControl = (props = {}) =>
   render(<CollapsibleControl {...defaultProps} {...props} />);
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('CollapsibleControl', () => {
-  test('renders title correctly', () => {
+  it('renders title correctly', () => {
     const { getByRole } = renderCollapsibleControl();
     expect(
       getByRole('checkbox', { name: /test control/i }),
     ).toBeInTheDocument();
   });
 
-  test('renders tooltip when provided', () => {
+  it('renders tooltip when provided', () => {
     const tooltipText = 'Test tooltip';
     renderCollapsibleControl({ tooltip: tooltipText });
 
@@ -46,18 +45,18 @@ describe('CollapsibleControl', () => {
     expect(tooltip).toBeInTheDocument();
   });
 
-  test('starts collapsed when initialValue is false', () => {
+  it('starts collapsed when initialValue is false', () => {
     renderCollapsibleControl({ initialValue: false });
     expect(screen.queryByTestId('child-content')).not.toBeInTheDocument();
   });
 
-  test('starts expanded when initialValue is true', () => {
+  it('starts expanded when initialValue is true', () => {
     renderCollapsibleControl({ initialValue: true });
 
     expect(screen.getByTestId('child-content')).toBeInTheDocument();
   });
 
-  test('toggles content when clicked', async () => {
+  it('toggles content when clicked', async () => {
     renderCollapsibleControl();
     const checkbox = screen.getByRole('checkbox', { name: /Test Control/i });
 
@@ -70,7 +69,7 @@ describe('CollapsibleControl', () => {
     expect(screen.queryByTestId('child-content')).not.toBeInTheDocument();
   });
 
-  test('calls onChange handler when toggled', async () => {
+  it('calls onChange handler when toggled', async () => {
     const onChangeMock = jest.fn();
     renderCollapsibleControl({ onChange: onChangeMock });
     const checkbox = screen.getByRole('checkbox', { name: /Test Control/i });
@@ -82,7 +81,7 @@ describe('CollapsibleControl', () => {
     expect(onChangeMock).toHaveBeenCalledWith(false);
   });
 
-  test('respects disabled prop', async () => {
+  it('respects disabled prop', async () => {
     const onChangeMock = jest.fn();
     renderCollapsibleControl({
       disabled: true,
@@ -96,7 +95,7 @@ describe('CollapsibleControl', () => {
     expect(onChangeMock).not.toHaveBeenCalled();
   });
 
-  test('updates when controlled checked prop changes', () => {
+  it('updates when controlled checked prop changes', () => {
     const { rerender } = renderCollapsibleControl({ checked: false });
     expect(screen.queryByTestId('child-content')).not.toBeInTheDocument();
 
@@ -104,7 +103,7 @@ describe('CollapsibleControl', () => {
     expect(screen.getByTestId('child-content')).toBeInTheDocument();
   });
 
-  test('maintains local state when in uncontrolled mode', async () => {
+  it('maintains local state when in uncontrolled mode', async () => {
     renderCollapsibleControl({ initialValue: false });
     const checkbox = screen.getByRole('checkbox', { name: /Test Control/i });
 

superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/__tests__/TreeInitialization.test.tsx

@@ -26,7 +26,6 @@ import {
 import type { FormInstance } from '@superset-ui/core/components';
 import { createMockModal } from './utils';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('FilterScope TreeInitialization', () => {
   let formRef: { current: FormInstance | null };
 
@@ -41,7 +40,7 @@ describe('FilterScope TreeInitialization', () => {
     jest.useRealTimers();
   });
 
-  test('correct init tree with values', async () => {
+  it('correct init tree with values', async () => {
     const { MockModalComponent } = createMockModal({
       scope: {
         rootPath: ['TAB_ID'],

superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/__tests__/TreeSelection.test.tsx

@@ -26,7 +26,6 @@ import {
 import type { FormInstance } from '@superset-ui/core/components';
 import { createMockModal, getTreeSwitcher } from './utils';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('FilterScope TreeSelection', () => {
   let formRef: { current: FormInstance | null };
 
@@ -41,7 +40,7 @@ describe('FilterScope TreeSelection', () => {
     jest.useRealTimers();
   });
 
-  test('select tree values with 1 excluded', async () => {
+  it('select tree values with 1 excluded', async () => {
     const { MockModalComponent } = createMockModal({ formRef });
     const modal = render(<MockModalComponent />);
 
@@ -82,7 +81,7 @@ describe('FilterScope TreeSelection', () => {
     modal.unmount();
   });
 
-  test('select 1 value only', async () => {
+  it('select 1 value only', async () => {
     const { MockModalComponent } = createMockModal({ formRef });
     const modal = render(<MockModalComponent />);
 

superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/utils.test.ts

@@ -24,7 +24,6 @@ import { buildTree } from './utils';
 // This test file is using data from a real example dashboard to test real world data sets.  ts-ignore is set for this entire file
 // until we can reconcile adjusting types to match the actual data structures used
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('Ensure buildTree does not throw runtime errors when encountering an invalid node', () => {
   const node = {
     children: ['TABS-97PVJa11D_'],
@@ -18048,7 +18047,7 @@ describe('Ensure buildTree does not throw runtime errors when encountering an in
   ];
 
   const initiallyExcludedCharts: number[] = [];
-  test('Succeeds with valid', () => {
+  it('Succeeds with valid', () => {
     expect(() => {
       buildTree(
         // @ts-ignore
@@ -18063,7 +18062,7 @@ describe('Ensure buildTree does not throw runtime errors when encountering an in
     }).not.toThrow();
   });
 
-  test('Avoids runtime error with invalid inputs', () => {
+  it('Avoids runtime error with invalid inputs', () => {
     expect(() => {
       buildTree(
         // @ts-expect-error

superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/getControlItemsMap.test.tsx

@@ -209,7 +209,6 @@ test('Clicking on checkbox when resetConfig:false', () => {
   expect(setNativeFilterFieldValues).not.toHaveBeenCalled();
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('ColumnSelect filterValues behavior', () => {
   beforeEach(() => {
     (getControlItems as jest.Mock).mockReturnValue([

superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/NativeFiltersModal.test.tsx

@@ -85,7 +85,6 @@ test('the form validates required fields', async () => {
   expect(onSave).toHaveBeenCalledTimes(0);
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('createNewOnOpen', () => {
   test('does not show alert when there is no unsaved filters', async () => {
     const onCancel = jest.fn();

superset-frontend/src/dashboard/components/nativeFilters/selectors.test.ts

@@ -19,7 +19,6 @@
 import { CHART_TYPE } from 'src/dashboard/util/componentTypes';
 import { getCrossFilterIndicator } from './selectors';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('getCrossFilterIndicator', () => {
   const chartId = 123;
   const chartLayoutItems = [
@@ -38,7 +37,7 @@ describe('getCrossFilterIndicator', () => {
     },
   ];
 
-  test('returns correct indicator with label from filterState.label', () => {
+  it('returns correct indicator with label from filterState.label', () => {
     const dataMask = {
       filterState: { label: 'foo', value: 'bar' },
       extraFormData: {},
@@ -52,7 +51,7 @@ describe('getCrossFilterIndicator', () => {
     });
   });
 
-  test('returns correct indicator with label from filterState.value', () => {
+  it('returns correct indicator with label from filterState.value', () => {
     const dataMask = {
       filterState: { value: ['bar', 'baz'] },
       extraFormData: {},
@@ -66,7 +65,7 @@ describe('getCrossFilterIndicator', () => {
     });
   });
 
-  test('returns correct indicator with column and customColumnLabel', () => {
+  it('returns correct indicator with column and customColumnLabel', () => {
     const dataMask = {
       filterState: {
         value: 'valA',
@@ -85,7 +84,7 @@ describe('getCrossFilterIndicator', () => {
     });
   });
 
-  test('returns correct indicator with column from extraFormData.filters', () => {
+  it('returns correct indicator with column from extraFormData.filters', () => {
     const filterClause = { col: 'colB', op: 'IS NOT NULL' as const };
     const dataMask = {
       filterState: { value: 'valB' },
@@ -100,7 +99,7 @@ describe('getCrossFilterIndicator', () => {
     });
   });
 
-  test('returns correct indicator with column from filterState.filters', () => {
+  it('returns correct indicator with column from filterState.filters', () => {
     const dataMask = {
       filterState: { value: 'valC', filters: { colC: 'something' } },
       extraFormData: {},
@@ -114,7 +113,7 @@ describe('getCrossFilterIndicator', () => {
     });
   });
 
-  test('returns empty name and path if chartLayoutItem is not found', () => {
+  it('returns empty name and path if chartLayoutItem is not found', () => {
     const dataMask = {
       filterState: { value: 'valD' },
       extraFormData: {},
@@ -128,7 +127,7 @@ describe('getCrossFilterIndicator', () => {
     });
   });
 
-  test('returns null value if no label or value in filterState', () => {
+  it('returns null value if no label or value in filterState', () => {
     const dataMask = {
       filterState: {},
       extraFormData: {},

superset-frontend/src/dashboard/components/nativeFilters/state.test.ts

@@ -39,9 +39,8 @@ beforeEach(() => {
   });
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('useIsFilterInScope', () => {
-  test('should return true for dividers (always in scope)', () => {
+  it('should return true for dividers (always in scope)', () => {
     const divider: Divider = {
       id: 'divider_1',
       type: NativeFilterType.Divider,
@@ -53,7 +52,7 @@ describe('useIsFilterInScope', () => {
     expect(result.current(divider)).toBe(true);
   });
 
-  test('should return true for filters with charts in active tabs', () => {
+  it('should return true for filters with charts in active tabs', () => {
     const filter: Filter = {
       id: 'filter_1',
       name: 'Test Filter',
@@ -72,7 +71,7 @@ describe('useIsFilterInScope', () => {
     expect(result.current(filter)).toBe(true);
   });
 
-  test('should return false for filters with inactive rootPath', () => {
+  it('should return false for filters with inactive rootPath', () => {
     const filter: Filter = {
       id: 'filter_3',
       name: 'Test Filter 3',
@@ -91,9 +90,8 @@ describe('useIsFilterInScope', () => {
   });
 });
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('useSelectFiltersInScope', () => {
-  test('should return all filters in scope when no tabs exist', () => {
+  it('should return all filters in scope when no tabs exist', () => {
     const filters: Filter[] = [
       {
         id: 'filter_1',

superset-frontend/src/dashboard/components/nativeFilters/utils.test.ts

@@ -21,23 +21,22 @@ import { DashboardLayout } from 'src/dashboard/types';
 import { CHART_TYPE } from 'src/dashboard/util/componentTypes';
 import { nativeFilterGate, findTabsWithChartsInScope } from './utils';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('nativeFilterGate', () => {
-  test('should return true for regular chart', () => {
+  it('should return true for regular chart', () => {
     expect(nativeFilterGate([])).toEqual(true);
   });
 
-  test('should return true for cross filter chart', () => {
+  it('should return true for cross filter chart', () => {
     expect(nativeFilterGate([Behavior.InteractiveChart])).toEqual(true);
   });
 
-  test('should return true for native filter chart with cross filter support', () => {
+  it('should return true for native filter chart with cross filter support', () => {
     expect(
       nativeFilterGate([Behavior.NativeFilter, Behavior.InteractiveChart]),
     ).toEqual(true);
   });
 
-  test('should return false for native filter behavior', () => {
+  it('should return false for native filter behavior', () => {
     expect(nativeFilterGate([Behavior.NativeFilter])).toEqual(false);
   });
 });

superset-frontend/src/dashboard/components/resizable/ResizableContainer.test.tsx

@@ -22,7 +22,6 @@ import ResizableContainer, {
   ResizableContainerProps,
 } from 'src/dashboard/components/resizable/ResizableContainer';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('ResizableContainer', () => {
   const props = {
     editMode: false,
@@ -35,7 +34,7 @@ describe('ResizableContainer', () => {
     <ResizableContainer {...props} {...overrides} />
   );
 
-  test('should render a Resizable container', () => {
+  it('should render a Resizable container', () => {
     const rendered = render(setup());
     const resizableContainer = rendered.container.querySelector(
       '.resizable-container',

superset-frontend/src/dashboard/components/resizable/ResizableHandle.test.tsx

@@ -21,23 +21,22 @@ import { render } from 'spec/helpers/testing-library';
 import ResizableHandle from 'src/dashboard/components/resizable/ResizableHandle';
 
 /* eslint-disable react/jsx-pascal-case */
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('ResizableHandle', () => {
-  test('should render a right resize handle', () => {
+  it('should render a right resize handle', () => {
     const rendered = render(<ResizableHandle.right />);
     expect(
       rendered.container.querySelector('.resize-handle.resize-handle--right'),
     ).toBeVisible();
   });
 
-  test('should render a bottom resize handle', () => {
+  it('should render a bottom resize handle', () => {
     const rendered = render(<ResizableHandle.bottom />);
     expect(
       rendered.container.querySelector('.resize-handle.resize-handle--bottom'),
     ).toBeVisible();
   });
 
-  test('should render a bottomRight resize handle', () => {
+  it('should render a bottomRight resize handle', () => {
     const rendered = render(<ResizableHandle.bottomRight />);
     expect(
       rendered.container.querySelector(

superset-frontend/src/dashboard/reducers/dashboardFilters.test.js

@@ -33,14 +33,13 @@ import {
 } from 'spec/fixtures/mockSliceEntities';
 import { filterComponent } from 'spec/fixtures/mockDashboardLayout';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('dashboardFilters reducer', () => {
   const { form_data } = sliceEntitiesForDashboard.slices[filterId];
   const component = filterComponent;
   const directPathToFilter = (component.parents || []).slice();
   directPathToFilter.push(component.id);
 
-  test('should overwrite a filter if merge is false', () => {
+  it('should overwrite a filter if merge is false', () => {
     expect(
       dashboardFiltersReducer(dashboardFilters, {
         type: CHANGE_FILTER,
@@ -73,7 +72,7 @@ describe('dashboardFilters reducer', () => {
     });
   });
 
-  test('should merge a filter if merge is true', () => {
+  it('should merge a filter if merge is true', () => {
     expect(
       dashboardFiltersReducer(dashboardFilters, {
         type: CHANGE_FILTER,
@@ -106,7 +105,7 @@ describe('dashboardFilters reducer', () => {
     });
   });
 
-  test('should buildActiveFilters on UPDATE_DASHBOARD_FILTERS_SCOPE', () => {
+  it('should buildActiveFilters on UPDATE_DASHBOARD_FILTERS_SCOPE', () => {
     const regionScope = {
       scope: ['TAB-1'],
       immune: [],

superset-frontend/src/dashboard/reducers/dashboardLayout.test.js

@@ -46,13 +46,12 @@ import {
   NEW_ROW_ID,
 } from 'src/dashboard/util/constants';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('dashboardLayout reducer', () => {
-  test('should return initial state for unrecognized actions', () => {
+  it('should return initial state for unrecognized actions', () => {
     expect(layoutReducer(undefined, {})).toEqual({});
   });
 
-  test('should delete a component, remove its reference in its parent, and recursively all of its children', () => {
+  it('should delete a component, remove its reference in its parent, and recursively all of its children', () => {
     expect(
       layoutReducer(
         {
@@ -88,7 +87,7 @@ describe('dashboardLayout reducer', () => {
     });
   });
 
-  test('should delete a parent if the parent was a row and no longer has children', () => {
+  it('should delete a parent if the parent was a row and no longer has children', () => {
     expect(
       layoutReducer(
         {
@@ -123,7 +122,7 @@ describe('dashboardLayout reducer', () => {
     });
   });
 
-  test('should update components', () => {
+  it('should update components', () => {
     expect(
       layoutReducer(
         {
@@ -174,7 +173,7 @@ describe('dashboardLayout reducer', () => {
     });
   });
 
-  test('should move a component', () => {
+  it('should move a component', () => {
     const layout = {
       source: {
         id: 'source',
@@ -223,7 +222,7 @@ describe('dashboardLayout reducer', () => {
     });
   });
 
-  test('should wrap a moved component in a row if need be', () => {
+  it('should wrap a moved component in a row if need be', () => {
     const layout = {
       source: {
         id: 'source',
@@ -263,7 +262,7 @@ describe('dashboardLayout reducer', () => {
     expect(Object.keys(result)).toHaveLength(4);
   });
 
-  test('should add top-level tabs from a new tabs component, moving grid children to new tab', () => {
+  it('should add top-level tabs from a new tabs component, moving grid children to new tab', () => {
     const layout = {
       [DASHBOARD_ROOT_ID]: {
         id: DASHBOARD_ROOT_ID,
@@ -309,7 +308,7 @@ describe('dashboardLayout reducer', () => {
     expect(result[DASHBOARD_GRID_ID].children).toHaveLength(0);
   });
 
-  test('should add top-level tabs from an existing tabs component, moving grid children to new tab', () => {
+  it('should add top-level tabs from an existing tabs component, moving grid children to new tab', () => {
     const layout = {
       [DASHBOARD_ROOT_ID]: {
         id: DASHBOARD_ROOT_ID,
@@ -361,7 +360,7 @@ describe('dashboardLayout reducer', () => {
     expect(result[DASHBOARD_GRID_ID].children).toHaveLength(0);
   });
 
-  test('should remove top-level tabs, moving children to the grid', () => {
+  it('should remove top-level tabs, moving children to the grid', () => {
     const layout = {
       [DASHBOARD_ROOT_ID]: {
         id: DASHBOARD_ROOT_ID,
@@ -426,7 +425,7 @@ describe('dashboardLayout reducer', () => {
     });
   });
 
-  test('should create a component', () => {
+  it('should create a component', () => {
     const layout = {
       [DASHBOARD_ROOT_ID]: {
         id: DASHBOARD_ROOT_ID,
@@ -459,7 +458,7 @@ describe('dashboardLayout reducer', () => {
     expect(result[newId].type).toBe(ROW_TYPE);
   });
 
-  test('recursivelyDeleteChildren should be error proof with bad inputs', () => {
+  it('recursivelyDeleteChildren should be error proof with bad inputs', () => {
     /*
      ** The recursivelyDeleteChildren function was missing runtime safety checks before operating
      ** on sub properties of object causing runtime errors when a componentId lookup returned and unexpected value

superset-frontend/src/dashboard/reducers/dashboardState.test.js

@@ -33,13 +33,12 @@ import {
 
 import dashboardStateReducer from 'src/dashboard/reducers/dashboardState';
 
-// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
 describe('dashboardState reducer', () => {
-  test('should return initial state', () => {
+  it('should return initial state', () => {
     expect(dashboardStateReducer(undefined, {})).toEqual({});
   });
 
-  test('should add a slice', () => {
+  it('should add a slice', () => {
     expect(
       dashboardStateReducer(
         { sliceIds: [1] },
@@ -48,7 +47,7 @@ describe('dashboardState reducer', () => {
     ).toEqual({ sliceIds: [1, 2] });
   });
 
-  test('should remove a slice', () => {
+  it('should remove a slice', () => {
     expect(
       dashboardStateReducer(
         { sliceIds: [1, 2], filters: {} },
@@ -57,7 +56,7 @@ describe('dashboardState reducer', () => {
     ).toEqual({ sliceIds: [1], filters: {} });
   });
 
-  test('should toggle fav star', () => {
+  it('should toggle fav star', () => {
     expect(
       dashboardStateReducer(
         { isStarred: false },
@@ -66,7 +65,7 @@ describe('dashboardState reducer', () => {
     ).toEqual({ isStarred: true });
   });
 
-  test('should toggle edit mode', () => {
+  it('should toggle edit mode', () => {
     expect(
       dashboardStateReducer(
         { editMode: false },
@@ -77,7 +76,7 @@ describe('dashboardState reducer', () => {
     });
   });
 
-  test('should toggle expanded slices', () => {
+  it('should toggle expanded slices', () => {
     expect(
       dashboardStateReducer(
         { expandedSlices: { 1: true, 2: false } },
@@ -93,7 +92,7 @@ describe('dashboardState reducer', () => {
     ).toEqual({ expandedSlices: { 1: true, 2: true } });
   });
 
-  test('should set hasUnsavedChanges', () => {
+  it('should set hasUnsavedChanges', () => {
     expect(dashboardStateReducer({}, { type: ON_CHANGE })).toEqual({
       hasUnsavedChanges: true,
     });
@@ -108,7 +107,7 @@ describe('dashboardState reducer', () => {
     });
   });
 
-  test('should set maxUndoHistoryExceeded', () => {
+  it('should set maxUndoHistoryExceeded', () => {
     expect(
       dashboardStateReducer(
         {},
@@ -122,7 +121,7 @@ describe('dashboardState reducer', () => {
     });
   });
 
-  test('should set unsaved changes, max undo history, and editMode to false on save', () => {
+  it('should set unsaved changes, max undo history, and editMode to false on save', () => {
     const result = dashboardStateReducer(
       { hasUnsavedChanges: true },
       { type: ON_SAVE },
@@ -133,7 +132,7 @@ describe('dashboardState reducer', () => {
     expect(result.updatedColorScheme).toBe(false);
   });
 
-  test('should reset lastModifiedTime on save', () => {
+  it('should reset lastModifiedTime on save', () => {
     const initTime = new Date().getTime() / 1000;
     dashboardStateReducer(
       {
@@ -151,7 +150,7 @@ describe('dashboardState reducer', () => {
     ).toBeGreaterThanOrEqual(initTime);
   });
 
-  test('should clear the focused filter field', () => {
+  it('should clear the focused filter field', () => {
     const initState = {
       focusedFilterField: {
         chartId: 1,
@@ -168,7 +167,7 @@ describe('dashboardState reducer', () => {
     expect(cleared.focusedFilterField).toBeNull();
   });
 
-  test('should only clear focused filter when the fields match', () => {
+  it('should only clear focused filter when the fields match', () => {
     // dashboard only has 1 focused filter field at a time,
     // but when user switch different filter boxes,
     // browser didn't always fire onBlur and onFocus events in order.
@@ -200,7 +199,7 @@ describe('dashboardState reducer', () => {
     });
   });
 
-  test('should toggle native filters bar', () => {
+  it('should toggle native filters bar', () => {
     expect(
       dashboardStateReducer(
         { nativeFiltersBarOpen: false },