fix(testcontainers): also monkeypatch oceanbase_py's get_columns

Fixing has_table() alone wasn't enough: get_columns() -- the actual
column-introspection call OceanBaseEngineSpec.get_columns() needs, and
what this test's second half exercises -- has the identical
connection.execute(raw string) bug, confirmed on real CI as the same
ObjectNotExecutableError. Patched the same way, reusing has_table()
correctly since self.has_table already resolves to the earlier patch.

.github/workflows/codeql-analysis.yml

@@ -67,7 +67,7 @@ jobs:
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4.37.8
+        uses: github/codeql-action/init@ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd # v4.37.7
         with:
           languages: ${{ matrix.language }}
           # If you wish to specify custom queries, you can do so here or in a config file.
@@ -78,6 +78,6 @@ jobs:
           # queries: security-extended,security-and-quality
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4.37.8
+        uses: github/codeql-action/analyze@ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd # v4.37.7
         with:
           category: "/language:${{matrix.language}}"

.github/workflows/testcontainers.yml

@@ -0,0 +1,188 @@
+# db_engine_specs tests against real databases (testcontainers)
+name: Testcontainers
+
+# Spins up real Docker containers (see tests/testcontainers/ for the current
+# dialect list) via testcontainers-python, which catches real dialect/driver
+# regressions -- the kind mocked db_engine_specs unit tests structurally
+# cannot, e.g. apache/superset#42899 (Trino emitting OFFSET before LIMIT).
+# Runs on a nightly cron (catches drift from a driver's own releases, not
+# just from Superset's changes) and on pull_request, scoped via `paths` to
+# only PRs that actually touch this test suite or the workflow itself, so
+# unrelated PRs across the repo are never affected.
+#
+# A matrix entry can set `nightly_only: true` to run only on the cron (or a
+# manual workflow_dispatch), never on pull_request -- for a dialect whose
+# image is too heavy (a multi-service cluster, a many-GB image, a slow
+# licensed installer) to justify adding its wall-clock/resource cost to
+# every PR that merely touches this suite. Omit the field entirely for a
+# normal dialect; it isn't nightly-only by default.
+permissions:
+  contents: read
+
+on:
+  schedule:
+    - cron: "0 5 * * *"
+  workflow_dispatch: {}
+  pull_request:
+    paths:
+      - ".github/workflows/testcontainers.yml"
+      - "tests/testcontainers/**"
+      - "superset/db_engine_specs/**"
+      - "pyproject.toml"
+      - "requirements/development.in"
+      - "requirements/development.txt"
+
+concurrency:
+  # Scoped by ref, not just workflow name -- otherwise every PR run and the
+  # nightly cron share one group, and starting the workflow on another PR
+  # (or the nightly firing mid-PR-run) cancels an unrelated in-progress run.
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  testcontainers:
+    runs-on: ubuntu-26.04
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          # One job per dialect rather than one job for the whole suite: a
+          # single slow container would otherwise inflate the wall-clock
+          # time for every dialect, not just its own. Running in parallel
+          # means the suite's total time is bounded by the slowest dialect,
+          # not the sum of all of them. Db2's first-boot init is documented
+          # upstream as notably slow (a real instance bring-up, not just a
+          # process start) and untested locally here (no arm64 image), so
+          # it gets a wider timeout margin than the rest until real CI data
+          # says otherwise.
+          - dialect: cockroachdb
+            timeout: 10
+          - dialect: crate
+            timeout: 10
+          - dialect: trino
+            timeout: 10
+          - dialect: mssql
+            timeout: 10
+          - dialect: elasticsearch
+            timeout: 10
+          - dialect: oracle
+            timeout: 15
+          - dialect: db2
+            timeout: 25
+          - dialect: mariadb
+            timeout: 10
+          - dialect: timescaledb
+            timeout: 10
+          - dialect: yugabytedb
+            timeout: 10
+          - dialect: monetdb
+            timeout: 10
+          - dialect: mongodb
+            timeout: 10
+          - dialect: postgres
+            timeout: 10
+          - dialect: mysql
+            timeout: 10
+          - dialect: clickhouse
+            timeout: 10
+          # StarRocks' allin1-ubuntu image brings up both FE and BE in one
+          # container, which is a heavier bring-up than a single-process
+          # database -- wider margin until real CI data says otherwise.
+          - dialect: starrocks
+            timeout: 15
+          - dialect: databend
+            timeout: 10
+          - dialect: risingwave
+            timeout: 10
+          - dialect: firebird
+            timeout: 10
+          - dialect: ydb
+            timeout: 10
+          # OceanBase bootstraps a distributed-style cluster even in
+          # single-node MODE=MINI -- too heavy for every PR's CI budget, so
+          # it runs on the nightly cron / manual dispatch only.
+          - dialect: oceanbase
+            timeout: 20
+            nightly_only: true
+    timeout-minutes: ${{ matrix.timeout }}
+    env:
+      PYTHONPATH: ${{ github.workspace }}
+      SUPERSET_TESTENV: true
+      SUPERSET_SECRET_KEY: not-a-secret
+      # This job's matrix installs exactly one dialect's testcontainers
+      # driver for exactly this job, so treat that driver as required: a
+      # broken/missing import should fail the job, not silently skip to a
+      # misleadingly green, zero-tests-run result. See _driver.py.
+      SUPERSET_TESTCONTAINERS_STRICT: true
+    steps:
+      - name: Checkout
+        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+        with:
+          persist-credentials: false
+      - name: Setup Python
+        uses: ./.github/actions/setup-backend/
+        with:
+          python-version: current
+      - name: Install db2 driver (ibm-db-sa)
+        # ibm-db (the db2 DBAPI) ships no Linux arm64 wheel, so it's kept out
+        # of the baseline dev install (requirements/development.in) to avoid
+        # breaking the multi-platform dev Docker image build. Install it here
+        # instead, only for this leg of the matrix.
+        if: matrix.dialect == 'db2'
+        run: uv pip install --system -e .[db2]
+      - name: Install oceanbase driver (oceanbase_py)
+        # oceanbase_py pins sqlalchemy-utils>=0.38.3,<0.39, which conflicts
+        # outright with Superset's own sqlalchemy-utils==0.42.1 pin -- kept
+        # out of the baseline dev install for the same reason as db2 above.
+        # Installed as its own standalone package (not via `-e .[oceanbase]`)
+        # so --no-deps only skips *oceanbase_py's* dependencies -- applied
+        # to `-e .[oceanbase]` instead, --no-deps blocks pip from installing
+        # anything the extras marker pulls in, including oceanbase_py
+        # itself, which "succeeds" without actually installing it
+        # (confirmed on real CI: the install step reported success, but the
+        # module was still missing). This job only needs oceanbase_py's
+        # dialect module importable, not its sqlalchemy-utils dependency
+        # satisfied, since nothing here calls into it.
+        if: matrix.dialect == 'oceanbase'
+        run: uv pip install --system --no-deps "oceanbase_py>=0.0.1.2"
+      - name: Install Firebird client library (libfbclient2)
+        # sqlalchemy-firebird's driver (firebird-driver) is a pure-Python
+        # ctypes wrapper (its wheel is py3-none-any) that dynamically loads
+        # the native Firebird client library from the host at import time
+        # -- it doesn't bundle that library itself, so it has to come from
+        # the system package manager, only for this leg of the matrix.
+        if: matrix.dialect == 'firebird'
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y libfbclient2
+      - name: Run testcontainers db_engine_specs tests (${{ matrix.dialect }})
+        # A job-level `if:` can't reference `matrix` (only github/inputs/
+        # needs/vars are available there), so the nightly_only skip has to
+        # live on the step instead. A dialect without `nightly_only` set
+        # evaluates the left side true (unset is null, and `null != true`
+        # is true) and always runs; one WITH it set only runs on the cron
+        # or a manual dispatch, never on pull_request.
+        if: >-
+          matrix.nightly_only != true ||
+          github.event_name == 'schedule' ||
+          github.event_name == 'workflow_dispatch'
+        run: |
+          pytest --durations-min=2 -v -m testcontainers \
+            ./tests/testcontainers/db_engine_specs/test_${{ matrix.dialect }}.py \
+            --junit-xml=test-results/junit-testcontainers-${{ matrix.dialect }}.xml
+      - name: Upload JUnit test results
+        if: always()
+        uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
+        with:
+          name: junit-results-testcontainers-${{ matrix.dialect }}
+          path: test-results/
+          retention-days: 7
+
+  actions-timeline:
+    needs: [testcontainers]
+    if: always()
+    runs-on: ubuntu-26.04
+    permissions:
+      actions: read
+    steps:
+      - uses: Kesin11/actions-timeline@57fc93f20c6da7fbc14063c6d24a2a5627c799ad # v3.2.0

.rat-excludes

@@ -10,7 +10,6 @@
 .stylelintignore
 .flake8
 .nvmrc
-.npmrc
 .rat-excludes
 .swcrc
 .*log

UPDATING.md

@@ -25,7 +25,7 @@ assists people when migrating to a new version.
 ## Next
 
 - `SAMPLES_ROW_LIMIT` is now the default for `/datasource/samples` requests without a valid explicit `per_page`, rather than a hard per-request ceiling; explicit limits are honored up to the existing global row-limit ceiling, matching `/chart/data` SAMPLES requests.
-- The `cockroachdb` extra (`pip install apache-superset[cockroachdb]`) now installs `sqlalchemy-cockroachdb` instead of the abandoned `cockroachdb` package, whose SQLAlchemy dialect could not be imported under SQLAlchemy 2.0. Existing environments with the old package installed should `pip uninstall cockroachdb && pip install sqlalchemy-cockroachdb` (or simply reinstall the extra) to restore CockroachDB connectivity.
+- The `cockroachdb` extra (`pip install apache-superset[cockroachdb]`) now installs `sqlalchemy-cockroachdb` instead of the abandoned `cockroachdb` package, whose SQLAlchemy dialect could not be imported under SQLAlchemy 2.0. Existing environments with the old package installed must `pip uninstall cockroachdb` before reinstalling the extra -- both packages register the same `cockroachdb` SQLAlchemy dialect entry point, so leaving the old one in place can still load the abandoned implementation.
 
 ### MCP tool results preserve stored string values
 

docs/developer_docs/contributing/development-setup.md

@@ -493,8 +493,8 @@ Frontend assets (TypeScript, JavaScript, CSS, and images) must be compiled in or
 
 First, be sure you are using the following versions of Node.js and npm:
 
-- `Node.js`: Version 24 (see `superset-frontend/.nvmrc` for the exact version)
-- `npm`: Version 11
+- `Node.js`: Version 22 (LTS)
+- `npm`: Version 10
 
 We recommend using [nvm](https://github.com/nvm-sh/nvm) to manage your node environment:
 
@@ -507,8 +507,8 @@ export NVM_DIR="$HOME/.nvm"
 [ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion
 
 cd superset-frontend
-nvm install
-nvm use
+nvm install --lts
+nvm use --lts
 ```
 
 Or if you use the default macOS starting with Catalina shell `zsh`, try:

pyproject.toml

@@ -148,10 +148,9 @@ clickhouse = ["clickhouse-connect>=1.7.2, <2.0"]
 # 2.0). sqlalchemy-cockroachdb is the actively maintained replacement,
 # already linked from CockroachDbEngineSpec.metadata's docs_url, and
 # registers the same `cockroachdb` SQLAlchemy dialect entry point.
-# sqlalchemy-cockroachdb depends only on SQLAlchemy itself, not on a DBAPI
-# driver, so psycopg2-binary is pinned alongside it (matching the `postgres`
-# extra) to keep this extra self-contained -- CockroachDB speaks the
-# PostgreSQL wire protocol, so psycopg2 is what actually opens connections.
+# sqlalchemy-cockroachdb itself declares no DBAPI dependency (its own docs
+# require picking one), so pull in the same psycopg2-binary pin as the
+# `postgres` extra -- CockroachDB speaks the Postgres wire protocol.
 cockroachdb = ["sqlalchemy-cockroachdb>=2.0.0, <3", "psycopg2-binary==2.9.12"]
 crate = ["sqlalchemy-cratedb>=0.43.1, <1"]
 # sqlalchemy-d1's only release (0.1.0, Nov 2025) pins sqlalchemy<2,>=1.4,
@@ -196,7 +195,7 @@ excel = ["xlrd>=2.0.2, <2.1"]
 excel-export = ["boto3"]
 fastmcp = [
     "fastmcp>=3.4.7,<4.0",
-    "mcp>=1.29.1,<3.0",
+    "mcp>=1.29.1,<2.0",
     # tiktoken backs the response-size-guard token estimator. Without
     # it, the middleware falls back to a coarser character-based
     # heuristic that under-counts JSON-heavy MCP responses.
@@ -223,6 +222,11 @@ impala = ["impyla>=0.24.0, <0.25"]
 # superset/db_engine_specs/kusto.py's known_incompatibilities metadata.
 kusto = ["sqlalchemy-kusto>=3.1.2, <4"]
 kylin = ["kylinpy>=2.8.4, <2.9"]
+# MariaDB is a MySQL fork implementing the same wire protocol - connects via
+# the plain mysql dialect, same driver as mysql.
+mariadb = ["apache-superset[mysql]"]
+monetdb = ["sqlalchemy-monetdb>=2.1.0, <3", "pymonetdb>=1.9.1, <2"]
+mongodb = ["pymongosql>=0.7.3, <1"]
 mssql = ["pymssql>=2.3.13, <3"]
 # motherduck is an alias for duckdb - MotherDuck works via the duckdb driver
 motherduck = ["apache-superset[duckdb]"]
@@ -271,6 +275,9 @@ tdengine = [
     "taos-ws-py>=0.7.0"
 ]
 teradata = ["teradatasql>=20.0.0.66"]
+# TimescaleDB is a genuine Postgres extension, not a fork - connects via the
+# plain postgresql dialect, same driver as postgres.
+timescaledb = ["apache-superset[postgres]"]
 thumbnails = [] # deprecated, will be removed in 7.0
 vertica = ["sqlalchemy-vertica-python>= 0.6.3, < 0.7"]
 netezza = ["nzalchemy>= 11.1.2, < 11.2"]
@@ -278,11 +285,18 @@ starrocks = ["starrocks>=1.3.4, <2"]
 doris = ["pydoris>=1.2.0, <2.0.0"]
 oceanbase = ["oceanbase_py>=0.0.1.2"]
 ydb = ["ydb-sqlalchemy>=0.1.22", "ydb-sqlglot-plugin>=0.2.8"]
+# YugabyteDB's YSQL layer is fully Postgres-wire compatible - connects via
+# the plain postgresql dialect, same driver as postgres.
+yugabytedb = ["apache-superset[postgres]"]
 development = [
     # no bounds for apache-superset-extensions-cli until a stable version
     "apache-superset-extensions-cli",
     "boto3",
-    "docker",
+    # 7.0.0 raises `docker.errors.DockerException: ... Not supported URL
+    # scheme http+docker` against the requests/urllib3 versions pinned
+    # elsewhere in this file -- breaks testcontainers (tests/testcontainers/)
+    # before any container even starts. 7.2.0 is confirmed working.
+    "docker>=7.2.0",
     "flask-testing",
     "freezegun",
     "grpcio>=1.82.1",

pytest.ini

@@ -19,7 +19,13 @@ testpaths =
     tests
 python_files = *_test.py test_*.py *_tests.py *viz/utils.py
 # `-p no:warnings` temporarily disabled in favor of more finely tuned `filterwarnings`.
-#addopts = -p no:warnings
+# `not testcontainers` excludes tests/testcontainers/ by default: those spin up
+# real Docker containers, and `testpaths = tests` would otherwise pull them into
+# every plain `pytest` run. The dedicated CI job (testcontainers.yml) overrides
+# this with an explicit `-m testcontainers` to run them.
+addopts = -m "not testcontainers"
+markers =
+    testcontainers: exercises a real database via testcontainers-python (needs Docker); excluded by default, see .github/workflows/testcontainers.yml
 asyncio_mode = auto
 
 # `ignore` is effectively equivalent to `-p no:warnings`.

requirements/development.in

@@ -16,5 +16,32 @@
 # specific language governing permissions and limitations
 # under the License.
 #
--e .[development,bigquery,cockroachdb,druid,duckdb,fastmcp,gevent,gsheets,mysql,postgres,presto,prophet,trino,thumbnails]
+-e .[development,bigquery,clickhouse,cockroachdb,crate,databend,druid,duckdb,elasticsearch,fastmcp,firebird,gevent,gsheets,monetdb,mongodb,mssql,mysql,oracle,postgres,presto,prophet,risingwave,starrocks,trino,thumbnails,ydb]
 -e ./superset-extensions-cli[test]
+# testcontainers-backed db_engine_specs tests (tests/testcontainers/) --
+# see .github/workflows/testcontainers.yml
+#
+# `db2` (the `ibm-db-sa`/`ibm-db` driver) and `oceanbase` (the `oceanbase_py`
+# driver) are both deliberately left out of the baseline dev install above:
+# `ibm-db` ships no Linux arm64 wheel, breaking the multi-platform
+# (amd64+arm64) dev Docker image build; `oceanbase_py` pins
+# `sqlalchemy-utils>=0.38.3,<0.39`, which conflicts outright with Superset's
+# own `sqlalchemy-utils==0.42.1` pin -- there's no version of both that can
+# coexist in one resolved environment. Both testcontainers CI jobs install
+# their driver on demand instead, only for their own matrix leg -- see
+# .github/workflows/testcontainers.yml.
+#
+# mariadb/timescaledb/yugabytedb need no testcontainers extra of their own:
+# they reuse the postgres/mysql container classes pointed at a different
+# image, and psycopg2-binary/mysqlclient are already pulled in above via
+# the postgres/mysql extras. Plain postgres/mysql obviously need nothing
+# extra either. clickhouse and starrocks also need no testcontainers extra:
+# ClickHouseContainer has no driver import of its own (clickhouse-connect,
+# pulled in above via the clickhouse extra, is all the test needs), and
+# StarRocks has no dedicated testcontainers module at all -- its test uses
+# a generic DockerContainer plus the same mysqlclient the mysql extra
+# already provides. databend/risingwave/firebird/ydb are the same story:
+# none has a dedicated testcontainers module, so each test uses a generic
+# DockerContainer plus whatever driver its own extra above already
+# provides.
+testcontainers[cockroachdb,cratedb,mongodb,mssql,mysql,oracle,postgres,trino]>=4.15.0,<5

requirements/development.txt

@@ -12,10 +12,17 @@
     #   apache-superset
 aiofile==3.9.0
     # via py-key-value-aio
+aiohappyeyeballs==2.7.1
+    # via aiohttp
+aiohttp==3.14.3
+    # via ydb
+aiosignal==1.4.0
+    # via aiohttp
 alembic==1.15.2
     # via
     #   -c requirements/base-constraint.txt
     #   flask-migrate
+    #   starrocks
 amqp==5.3.1
     # via
     #   -c requirements/base-constraint.txt
@@ -24,6 +31,8 @@ annotated-types==0.7.0
     # via
     #   -c requirements/base-constraint.txt
     #   pydantic
+antlr4-python3-runtime==4.13.2
+    # via pymongosql
 anyio==4.11.0
     # via
     #   httpx
@@ -42,9 +51,12 @@ apsw==3.50.1.0
     #   shillelagh
 astroid==3.3.10
     # via pylint
+asyncmy2==0.2.21
+    # via starrocks
 attrs==25.3.0
     # via
     #   -c requirements/base-constraint.txt
+    #   aiohttp
     #   cattrs
     #   cyclopts
     #   jsonschema
@@ -65,6 +77,7 @@ backports-tarfile==1.2.0
 backports-zstd==1.6.0
     # via
     #   -c requirements/base-constraint.txt
+    #   clickhouse-connect
     #   flask-compress
 bcrypt==4.3.0
     # via
@@ -117,8 +130,11 @@ celery==5.6.3
 certifi==2026.5.20
     # via
     #   -c requirements/base-constraint.txt
+    #   clickhouse-connect
+    #   elasticsearch
     #   httpcore
     #   httpx
+    #   opensearch-py
     #   requests
 cffi==2.0.0
     # via
@@ -160,6 +176,8 @@ click-repl==0.3.0
     # via
     #   -c requirements/base-constraint.txt
     #   celery
+clickhouse-connect==1.7.2
+    # via apache-superset
 cmdstanpy==1.1.0
     # via prophet
 colorama==0.4.6
@@ -171,6 +189,8 @@ contourpy==1.0.7
     # via matplotlib
 coverage==7.6.8
     # via pytest-cov
+crate==2.2.1
+    # via sqlalchemy-cratedb
 cron-descriptor==1.4.5
     # via
     #   -c requirements/base-constraint.txt
@@ -186,14 +206,20 @@ cryptography==50.0.0
     #   authlib
     #   google-auth
     #   joserfc
+    #   oracledb
     #   paramiko
     #   pyjwt
+    #   pymysql
     #   pyopenssl
     #   secretstorage
 cycler==0.12.1
     # via matplotlib
 cyclopts==4.2.4
     # via fastmcp-slim
+databend-driver==0.34.2
+    # via databend-sqlalchemy
+databend-sqlalchemy==0.5.5
+    # via apache-superset
 db-dtypes==1.3.1
     # via pandas-gbq
 defusedxml==0.7.1
@@ -216,8 +242,11 @@ dnspython==2.7.0
     # via
     #   -c requirements/base-constraint.txt
     #   email-validator
-docker==7.0.0
-    # via apache-superset
+    #   pymongo
+docker==7.2.0
+    # via
+    #   apache-superset
+    #   testcontainers
 docstring-parser==0.17.0
     # via cyclopts
 docutils==0.22.2
@@ -228,6 +257,10 @@ duckdb==1.5.5
     #   duckdb-engine
 duckdb-engine==0.17.0
     # via apache-superset
+elasticsearch==7.17.13
+    # via elasticsearch-dbapi
+elasticsearch-dbapi==0.2.13
+    # via apache-superset
 email-validator==2.2.0
     # via
     #   -c requirements/base-constraint.txt
@@ -237,6 +270,8 @@ et-xmlfile==2.0.0
     # via
     #   -c requirements/base-constraint.txt
     #   openpyxl
+events==0.5
+    # via opensearch-py
 exceptiongroup==1.3.0
     # via fastmcp-slim
 fastmcp==3.4.7
@@ -247,6 +282,10 @@ filelock==3.20.3
     # via
     #   -c requirements/base-constraint.txt
     #   virtualenv
+firebird-base==2.0.3
+    # via firebird-driver
+firebird-driver==2.0.3
+    # via sqlalchemy-firebird
 flask==2.3.3
     # via
     #   -c requirements/base-constraint.txt
@@ -327,12 +366,18 @@ fonttools==4.60.2
     # via matplotlib
 freezegun==1.5.1
     # via apache-superset
+frozenlist==1.8.0
+    # via
+    #   aiohttp
+    #   aiosignal
 future==1.0.0
     # via pyhive
 geographiclib==2.0
     # via
     #   -c requirements/base-constraint.txt
     #   geopy
+geojson==3.3.0
+    # via sqlalchemy-cratedb
 geopy==2.4.1
     # via
     #   -c requirements/base-constraint.txt
@@ -389,6 +434,7 @@ grpcio==1.83.0
     #   apache-superset
     #   google-api-core
     #   grpcio-status
+    #   ydb
 grpcio-status==1.60.1
     # via google-api-core
 gunicorn==26.2.0
@@ -414,6 +460,7 @@ httpx==0.28.1
     # via
     #   fastmcp-slim
     #   mcp
+    #   testcontainers
 httpx-sse==0.4.1
     # via mcp
 humanize==4.12.3
@@ -430,6 +477,7 @@ idna==3.15
     #   httpx
     #   requests
     #   url-normalize
+    #   yarl
 importlib-metadata==8.7.0
     # via
     #   keyring
@@ -468,6 +516,7 @@ jmespath==1.1.0
     # via
     #   boto3
     #   botocore
+    #   pymongosql
 joserfc==1.7.2
     # via fastmcp-slim
 jsonpath-ng==1.8.0
@@ -500,6 +549,8 @@ kombu==5.6.2
     # via
     #   -c requirements/base-constraint.txt
     #   celery
+lark==1.3.1
+    # via starrocks
 lazy-object-proxy==1.10.0
     # via openapi-spec-validator
 limits==5.1.0
@@ -507,7 +558,9 @@ limits==5.1.0
     #   -c requirements/base-constraint.txt
     #   flask-limiter
 lz4==4.4.5
-    # via trino
+    # via
+    #   clickhouse-connect
+    #   trino
 mako==1.4.1
     # via
     #   -c requirements/base-constraint.txt
@@ -567,6 +620,10 @@ msgspec==0.19.0
     # via
     #   -c requirements/base-constraint.txt
     #   flask-session
+multidict==6.7.1
+    # via
+    #   aiohttp
+    #   yarl
 mysqlclient==2.2.8
     # via apache-superset
 nh3==0.3.6
@@ -605,14 +662,22 @@ openpyxl==3.1.5
     # via
     #   -c requirements/base-constraint.txt
     #   pandas
+opensearch-py==2.8.0
+    # via elasticsearch-dbapi
 opentelemetry-api==1.39.1
     # via fastmcp-slim
+oracledb==4.0.2
+    # via
+    #   apache-superset
+    #   testcontainers
 ordered-set==4.1.0
     # via
     #   -c requirements/base-constraint.txt
     #   flask-limiter
 orjson==3.11.9
-    # via trino
+    # via
+    #   crate
+    #   trino
 packaging==25.0
     # via
     #   -c requirements/base-constraint.txt
@@ -620,8 +685,8 @@ packaging==25.0
     #   apispec
     #   db-dtypes
     #   deprecation
-    #   docker
     #   duckdb-engine
+    #   elasticsearch-dbapi
     #   fastmcp-slim
     #   google-cloud-bigquery
     #   kombu
@@ -631,6 +696,8 @@ packaging==25.0
     #   pytest
     #   shillelagh
     #   sqlalchemy-bigquery
+    #   sqlalchemy-firebird
+    #   ydb
 pandas==2.3.3
     # via
     #   -c requirements/base-constraint.txt
@@ -692,16 +759,22 @@ prompt-toolkit==3.0.51
     # via
     #   -c requirements/base-constraint.txt
     #   click-repl
+propcache==0.5.2
+    # via
+    #   aiohttp
+    #   yarl
 prophet==1.4.0
     # via apache-superset
 proto-plus==1.25.0
     # via google-api-core
 protobuf==5.29.6
     # via
+    #   firebird-base
     #   google-api-core
     #   googleapis-common-protos
     #   grpcio-status
     #   proto-plus
+    #   ydb
 psutil==6.1.0
     # via
     #   apache-superset
@@ -775,6 +848,24 @@ pyjwt==2.13.0
     #   mcp
 pylint==3.3.7
     # via apache-superset
+pymonetdb==1.9.1
+    # via
+    #   apache-superset
+    #   sqlalchemy-monetdb
+pymongo==4.17.0
+    # via
+    #   pymongosql
+    #   testcontainers
+pymongosql==0.7.3
+    # via apache-superset
+pymssql==2.3.13
+    # via
+    #   apache-superset
+    #   testcontainers
+pymysql==1.2.0
+    # via
+    #   starrocks
+    #   testcontainers
 pynacl==1.6.2
     # via
     #   -c requirements/base-constraint.txt
@@ -819,11 +910,13 @@ python-dateutil==2.9.0.post0
     #   botocore
     #   celery
     #   croniter
+    #   firebird-driver
     #   flask-appbuilder
     #   freezegun
     #   google-cloud-bigquery
     #   holidays
     #   matplotlib
+    #   opensearch-py
     #   pandas
     #   pyhive
     #   shillelagh
@@ -834,6 +927,7 @@ python-dotenv==1.2.2
     #   apache-superset
     #   fastmcp-slim
     #   pydantic-settings
+    #   testcontainers
 python-ldap==3.4.7
     # via apache-superset
 python-multipart==0.0.29
@@ -877,6 +971,7 @@ requests==2.33.0
     #   google-api-core
     #   google-cloud-bigquery
     #   jsonschema-path
+    #   opensearch-py
     #   pydruid
     #   pyhive
     #   requests-cache
@@ -955,7 +1050,9 @@ sqlalchemy==2.0.52
     #   alembic
     #   apache-superset
     #   apache-superset-core
+    #   databend-sqlalchemy
     #   duckdb-engine
+    #   elasticsearch-dbapi
     #   flask-appbuilder
     #   flask-sqlalchemy
     #   marshmallow-sqlalchemy
@@ -963,7 +1060,14 @@ sqlalchemy==2.0.52
     #   sqlalchemy-bigquery
     #   sqlalchemy-cockroachdb
     #   sqlalchemy-continuum
+    #   sqlalchemy-cratedb
+    #   sqlalchemy-firebird
+    #   sqlalchemy-monetdb
+    #   sqlalchemy-risingwave
     #   sqlalchemy-utils
+    #   starrocks
+    #   testcontainers
+    #   ydb-sqlalchemy
 sqlalchemy-bigquery==1.17.2
     # via apache-superset
 sqlalchemy-cockroachdb==2.0.4
@@ -972,6 +1076,16 @@ sqlalchemy-continuum==1.7.0
     # via
     #   -c requirements/base-constraint.txt
     #   apache-superset
+sqlalchemy-cratedb==0.43.1
+    # via
+    #   apache-superset
+    #   testcontainers
+sqlalchemy-firebird==2.2.0
+    # via apache-superset
+sqlalchemy-monetdb==2.1.0
+    # via apache-superset
+sqlalchemy-risingwave==2.1.0
+    # via apache-superset
 sqlalchemy-utils==0.42.1
     # via
     #   -c requirements/base-constraint.txt
@@ -983,6 +1097,7 @@ sqlglot==30.17.0
     #   -c requirements/base-constraint.txt
     #   apache-superset
     #   apache-superset-core
+    #   ydb-sqlglot-plugin
 sqloxide==0.1.51
     # via apache-superset
 sse-starlette==3.0.2
@@ -995,6 +1110,8 @@ starlette==1.3.1
     # via
     #   fastmcp-slim
     #   mcp
+starrocks==1.3.4
+    # via apache-superset
 statsd==4.0.1
     # via apache-superset
 syntaqlite==0.9.0
@@ -1003,6 +1120,8 @@ tabulate==0.10.0
     # via
     #   -c requirements/base-constraint.txt
     #   apache-superset
+testcontainers==4.15.0
+    # via -r requirements/development.in
 tiktoken==0.14.0
     # via apache-superset
 tomli-w==1.2.0
@@ -1014,10 +1133,14 @@ tqdm==4.67.1
     #   cmdstanpy
     #   prophet
 trino==0.339.0
-    # via apache-superset
+    # via
+    #   apache-superset
+    #   testcontainers
 typing-extensions==4.16.0
     # via
     #   -c requirements/base-constraint.txt
+    #   aiohttp
+    #   aiosignal
     #   alembic
     #   anyio
     #   apache-superset
@@ -1029,6 +1152,7 @@ typing-extensions==4.16.0
     #   limits
     #   mcp
     #   opentelemetry-api
+    #   oracledb
     #   py-key-value-aio
     #   pydantic
     #   pydantic-core
@@ -1037,6 +1161,7 @@ typing-extensions==4.16.0
     #   shillelagh
     #   sqlalchemy
     #   starlette
+    #   testcontainers
     #   typing-inspection
 typing-inspection==0.4.2
     # via
@@ -1064,13 +1189,22 @@ urllib3==2.7.0
     # via
     #   -c requirements/base-constraint.txt
     #   botocore
+    #   clickhouse-connect
+    #   crate
     #   docker
+    #   elasticsearch
+    #   opensearch-py
     #   requests
     #   requests-cache
+    #   testcontainers
 uvicorn==0.37.0
     # via
     #   fastmcp-slim
     #   mcp
+verlib2==0.3.2
+    # via
+    #   crate
+    #   sqlalchemy-cratedb
 vine==5.1.0
     # via
     #   -c requirements/base-constraint.txt
@@ -1104,6 +1238,7 @@ wrapt==1.17.2
     # via
     #   -c requirements/base-constraint.txt
     #   deprecated
+    #   testcontainers
 wtforms==3.2.2
     # via
     #   -c requirements/base-constraint.txt
@@ -1124,6 +1259,18 @@ xlsxwriter==3.2.9
     #   -c requirements/base-constraint.txt
     #   apache-superset
     #   pandas
+yarl==1.24.5
+    # via aiohttp
+ydb==3.31.4
+    # via
+    #   ydb-dbapi
+    #   ydb-sqlalchemy
+ydb-dbapi==0.1.23
+    # via ydb-sqlalchemy
+ydb-sqlalchemy==0.1.22
+    # via apache-superset
+ydb-sqlglot-plugin==0.2.8
+    # via apache-superset
 zipp==3.23.0
     # via importlib-metadata
 zope-event==5.0

superset-core/src/superset_core/common/models.py

@@ -390,3 +390,19 @@ def get_session() -> scoped_session:
     :returns: The SQLAlchemy scoped session instance.
     """
     raise NotImplementedError("Function will be replaced during initialization")
+
+
+__all__ = [
+    "Dataset",
+    "Database",
+    "Chart",
+    "Dashboard",
+    "User",
+    "Role",
+    "Group",
+    "Tag",
+    "KeyValue",
+    "Subject",
+    "CoreModel",
+    "get_session",
+]

superset-core/src/superset_core/mcp/decorators.py

@@ -183,3 +183,10 @@ def prompt(
         "MCP prompt decorator not initialized. "
         "This decorator should be replaced during Superset startup."
     )
+
+
+__all__ = [
+    "tool",
+    "prompt",
+    "ToolAnnotations",
+]

superset-core/src/superset_core/queries/daos.py

@@ -55,3 +55,9 @@ class SavedQueryDAO(BaseDAO[SavedQuery]):
     model_cls = None
     base_filter = None
     id_column_name = "id"
+
+
+__all__ = [
+    "QueryDAO",
+    "SavedQueryDAO",
+]

superset-core/src/superset_core/queries/models.py

@@ -71,3 +71,9 @@ class SavedQuery(CoreModel):
     database_id: int | None
     description: str | None
     user_id: int | None
+
+
+__all__ = [
+    "Query",
+    "SavedQuery",
+]

superset-core/src/superset_core/queries/query.py

@@ -46,3 +46,6 @@ def get_sqlglot_dialect(database: "Database") -> Dialects:
     :returns: The SQLGlot dialect enum corresponding to the database.
     """
     raise NotImplementedError("Function will be replaced during initialization")
+
+
+__all__ = ["get_sqlglot_dialect"]

superset-core/src/superset_core/queries/types.py

@@ -165,3 +165,13 @@ class AsyncQueryHandle:
         :returns: True if cancellation was successful
         """
         raise NotImplementedError("Method will be replaced during initialization")
+
+
+__all__ = [
+    "QueryStatus",
+    "QueryOptions",
+    "QueryResult",
+    "StatementResult",
+    "AsyncQueryHandle",
+    "CacheOptions",
+]

superset-core/src/superset_core/rest_api/api.py

@@ -27,3 +27,6 @@ class RestApi(BaseApi):
     """
 
     allow_browser_login = True
+
+
+__all__ = ["RestApi"]

superset-core/src/superset_core/rest_api/decorators.py

@@ -98,3 +98,6 @@ def api(
         "API decorator not initialized. "
         "This decorator should be replaced during Superset startup."
     )
+
+
+__all__ = ["api"]

superset-core/src/superset_core/semantic_layers/daos.py

@@ -164,3 +164,6 @@ class AbstractSemanticViewDAO(BaseDAO[SemanticViewModel]):
         :return: SemanticViewModel instance or None
         """
         ...
+
+
+__all__ = ["AbstractSemanticLayerDAO", "AbstractSemanticViewDAO"]

superset-core/src/superset_core/semantic_layers/decorators.py

@@ -97,3 +97,6 @@ def semantic_layer(
         "Semantic layer decorator not initialized. "
         "This decorator should be replaced during Superset startup."
     )
+
+
+__all__ = ["semantic_layer"]

superset-core/src/superset_core/semantic_layers/layer.py

@@ -21,7 +21,6 @@ from abc import ABC, abstractmethod
 from typing import Any, Generic, TypeVar
 
 from pydantic import BaseModel
-
 from superset_core.semantic_layers.view import SemanticView
 
 ConfigT = TypeVar("ConfigT", bound=BaseModel)

superset-core/src/superset_core/semantic_layers/models.py

@@ -80,3 +80,6 @@ class SemanticViewModel(CoreModel):
     semantic_layer_uuid: UUID
     created_on: datetime | None
     changed_on: datetime | None
+
+
+__all__ = ["SemanticLayerModel", "SemanticViewModel"]

superset-core/src/superset_core/tasks/daos.py

@@ -71,3 +71,6 @@ class TaskDAO(BaseDAO[Task]):
         :returns: Task instance or None if not found or not active
         """
         ...
+
+
+__all__ = ["TaskDAO"]

superset-core/src/superset_core/tasks/decorators.py

@@ -144,3 +144,9 @@ def get_context() -> TaskContext:
             )
     """
     raise NotImplementedError("Function will be replaced during initialization")
+
+
+__all__ = [
+    "task",
+    "get_context",
+]

superset-core/src/superset_core/tasks/models.py

@@ -161,3 +161,9 @@ class TaskSubscriber(CoreModel):
     changed_on: datetime | None
     created_by_fk: int | None
     changed_by_fk: int | None
+
+
+__all__ = [
+    "Task",
+    "TaskSubscriber",
+]

superset-core/src/superset_core/tasks/types.py

@@ -226,3 +226,12 @@ class TaskContext(ABC):
                 cleanup_partial_work()
         """
         ...
+
+
+__all__ = [
+    "TaskStatus",
+    "TaskScope",
+    "TaskProperties",
+    "TaskContext",
+    "TaskOptions",
+]

superset-embedded-sdk/.npmrc

@@ -1 +0,0 @@
-../superset-frontend/.npmrc

superset-frontend/.npmrc

@@ -1 +0,0 @@
-min-release-age=3

superset-frontend/package-lock.json

@@ -108,7 +108,7 @@
         "json-stringify-pretty-compact": "^4.0.0",
         "lodash": "^4.18.1",
         "lodash-es": "^4.18.1",
-        "mapbox-gl": "^3.29.0",
+        "mapbox-gl": "^3.28.1",
         "markdown-to-jsx": "^9.10.2",
         "match-sorter": "^8.3.0",
         "memoize-one": "^6.0.0",
@@ -234,7 +234,7 @@
         "eslint-plugin-lodash": "^8.0.0",
         "eslint-plugin-no-only-tests": "^3.4.0",
         "eslint-plugin-react-prefer-function-component": "^5.0.0",
-        "eslint-plugin-react-you-might-not-need-an-effect": "^1.0.2",
+        "eslint-plugin-react-you-might-not-need-an-effect": "^1.0.1",
         "eslint-plugin-storybook": "10.5.10",
         "eslint-plugin-testing-library": "^7.16.2",
         "eslint-plugin-theme-colors": "file:eslint-rules/eslint-plugin-theme-colors",
@@ -20208,9 +20208,9 @@
       "license": "MIT"
     },
     "node_modules/eslint-plugin-react-you-might-not-need-an-effect": {
-      "version": "1.0.2",
-      "resolved": "https://registry.npmjs.org/eslint-plugin-react-you-might-not-need-an-effect/-/eslint-plugin-react-you-might-not-need-an-effect-1.0.2.tgz",
-      "integrity": "sha512-HgYol2zhH3KbnW9Q4FY/FcIINbsYVL6rwQESChqBC2s9SLWtw1wg05+J7SCrr3BfQpNY2ReYhf8xjpd2JhKJOQ==",
+      "version": "1.0.1",
+      "resolved": "https://registry.npmjs.org/eslint-plugin-react-you-might-not-need-an-effect/-/eslint-plugin-react-you-might-not-need-an-effect-1.0.1.tgz",
+      "integrity": "sha512-oOhQTYhor88Xp8RVytq25tvBfiAjU0r9SCDC51Qop+3Wg5BR1xGMAkM+/dV4MZbcMhdaU1L9bkv6LC95JmiTig==",
       "dev": true,
       "license": "MIT",
       "dependencies": {
@@ -28488,9 +28488,9 @@
       }
     },
     "node_modules/mapbox-gl": {
-      "version": "3.29.0",
-      "resolved": "https://registry.npmjs.org/mapbox-gl/-/mapbox-gl-3.29.0.tgz",
-      "integrity": "sha512-Fnh1WLsZMfihwRZY5scp456iQuZo9G97tTpb26bf/Ejsi/L7O+4dE9+I03VoOor2ul3DEOp6F2P3273omyVsNw==",
+      "version": "3.28.1",
+      "resolved": "https://registry.npmjs.org/mapbox-gl/-/mapbox-gl-3.28.1.tgz",
+      "integrity": "sha512-f8bCHFzZ51bKig7rnD7e08aoFLOV3MNFZduspZ4lgOgiaNVp9sw4NSWcgo3IWTyekYKKXjiICD2BP2o4DiYfxw==",
       "license": "SEE LICENSE IN LICENSE.txt",
       "workspaces": [
         "src/style-spec",
@@ -43490,7 +43490,7 @@
       "license": "Apache-2.0",
       "dependencies": {
         "@math.gl/web-mercator": "^4.1.0",
-        "mapbox-gl": "^3.29.0",
+        "mapbox-gl": "^3.28.1",
         "maplibre-gl": "^5.24.0",
         "react-map-gl": "^8.1.2",
         "supercluster": "^9.0.0"

superset-frontend/package.json

@@ -185,7 +185,7 @@
     "json-stringify-pretty-compact": "^4.0.0",
     "lodash": "^4.18.1",
     "lodash-es": "^4.18.1",
-    "mapbox-gl": "^3.29.0",
+    "mapbox-gl": "^3.28.1",
     "markdown-to-jsx": "^9.10.2",
     "match-sorter": "^8.3.0",
     "memoize-one": "^6.0.0",
@@ -311,7 +311,7 @@
     "eslint-plugin-lodash": "^8.0.0",
     "eslint-plugin-no-only-tests": "^3.4.0",
     "eslint-plugin-react-prefer-function-component": "^5.0.0",
-    "eslint-plugin-react-you-might-not-need-an-effect": "^1.0.2",
+    "eslint-plugin-react-you-might-not-need-an-effect": "^1.0.1",
     "eslint-plugin-storybook": "10.5.10",
     "eslint-plugin-testing-library": "^7.16.2",
     "eslint-plugin-theme-colors": "file:eslint-rules/eslint-plugin-theme-colors",
@@ -392,7 +392,7 @@
     "@luma.gl/shadertools": "~9.2.5",
     "@luma.gl/webgl": "~9.2.5",
     "core-js": "^3.38.1",
-    "dompurify": "^3.4.13",
+    "dompurify": "^3.4.11",
     "esbuild": "^0.28.1",
     "eslint-plugin-import": {
       "eslint": "$eslint"

superset-frontend/packages/superset-ui-core/src/components/Select/types.ts

@@ -65,7 +65,6 @@ export type AntdExposedProps = Pick<
   | 'onOpenChange'
   | 'optionRender'
   | 'placeholder'
-  | 'prefix'
   | 'showArrow'
   | 'showSearch'
   | 'tokenSeparators'

superset-frontend/packages/superset-ui-core/src/number-format/factories/createMemoryFormatter.ts

@@ -38,21 +38,11 @@ function formatMemory(
         : ['B', 'kB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB', 'RB', 'QB'];
       const base = binary ? 1024 : 1000;
 
-      let i = Math.max(
-        0,
-        Math.min(
-          suffixes.length - 1,
-          Math.floor(Math.log(absValue) / Math.log(base)),
-        ),
+      const i = Math.min(
+        suffixes.length - 1,
+        Math.floor(Math.log(absValue) / Math.log(base)),
       );
-      let scaled = parseFloat((absValue / Math.pow(base, i)).toFixed(decimals));
-
-      if (scaled >= base && i < suffixes.length - 1) {
-        i += 1;
-        scaled = parseFloat((absValue / Math.pow(base, i)).toFixed(decimals));
-      }
-
-      formatted = `${sign}${scaled}${suffixes[i]}`;
+      formatted = `${sign}${parseFloat((absValue / Math.pow(base, i)).toFixed(decimals))}${suffixes[i]}`;
     }
 
     if (transfer) {

superset-frontend/packages/superset-ui-core/src/query/getClientErrorObject.ts

@@ -119,20 +119,6 @@ export function retrieveErrorMessage(
   return statusError || parseStringResponse(str);
 }
 
-function getFirstValidationError(message: JsonObject): string | undefined {
-  const [firstError] = Object.values(message);
-
-  if (typeof firstError === 'string') {
-    return firstError;
-  }
-
-  if (Array.isArray(firstError)) {
-    return firstError.find((item): item is string => typeof item === 'string');
-  }
-
-  return undefined;
-}
-
 export function parseErrorJson(responseJson: JsonObject): ClientErrorObject {
   let error = { ...responseJson };
   // Backwards compatibility for old error renderers with the new error object
@@ -140,12 +126,13 @@ export function parseErrorJson(responseJson: JsonObject): ClientErrorObject {
     error.error = error.description = error.errors[0].message;
     error.link = error.errors[0]?.extra?.link;
   }
-  // Marshmallow field validation returns arrays for string messages, but
-  // serializes lazy translation messages as strings instead.
+  // Marshmallow field validation returns the error message in the format
+  // of { message: { field1: [msg1, msg2], field2: [msg], } }
   if (!error.error && error.message) {
     if (typeof error.message === 'object') {
       error.error =
-        getFirstValidationError(error.message) || t('Invalid input');
+        Object.values(error.message as Record<string, string[]>)[0]?.[0] ||
+        t('Invalid input');
     }
     if (typeof error.message === 'string') {
       if (checkForHtml(error.message)) {

superset-frontend/packages/superset-ui-core/test/number-format/factories/createMemoryFormatter.test.ts

@@ -60,31 +60,6 @@ test('formats float bytes in human readable format with default options', () =>
   expect(formatter(1200.666)).toBe('1.2kB');
 });
 
-test('formats values below one byte without dropping the unit', () => {
-  const formatter = createMemoryFormatter();
-  expect(formatter(0.5)).toBe('0.5B');
-  expect(formatter(0.004)).toBe('0B');
-  expect(formatter(-0.25)).toBe('-0.25B');
-
-  const binaryFormatter = createMemoryFormatter({ binary: true });
-  expect(binaryFormatter(0.5)).toBe('0.5B');
-});
-
-test('rolls over to the next unit when rounding reaches the base', () => {
-  const formatter = createMemoryFormatter();
-  expect(formatter(999999)).toBe('1MB');
-  expect(formatter(999995)).toBe('1MB');
-  expect(formatter(999994)).toBe('999.99kB');
-  expect(formatter(-999999)).toBe('-1MB');
-
-  const binaryFormatter = createMemoryFormatter({ binary: true });
-  expect(binaryFormatter(1024 * 1024 - 1)).toBe('1MiB');
-
-  // the largest unit has nothing to roll over into
-  const largest = createMemoryFormatter();
-  expect(largest(Math.pow(1000, 11))).toBe('1000QB');
-});
-
 test('formats bytes in human readable format with additional binary option', () => {
   const formatter = createMemoryFormatter({ binary: true });
   expect(formatter(0)).toBe('0B');

superset-frontend/packages/superset-ui-core/test/query/getClientErrorObject.test.ts

@@ -244,24 +244,6 @@ test('parseErrorJson with message', () => {
   });
 });
 
-test('parseErrorJson preserves string-valued validation messages', () => {
-  const calculatedColumnError =
-    'Custom SQL fields cannot be parsed as a single SQL statement.';
-
-  expect(
-    parseErrorJson({
-      message: {
-        'columns.0.expression': calculatedColumnError,
-      },
-    }),
-  ).toEqual({
-    message: {
-      'columns.0.expression': calculatedColumnError,
-    },
-    error: calculatedColumnError,
-  });
-});
-
 test('parseErrorJson with HTML message', () => {
   expect(
     parseErrorJson({

superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx

@@ -38,8 +38,6 @@ import { EchartsTimeseriesSeriesType } from '../Timeseries/types';
 import {
   legendSection,
   minorTicks,
-  axisTicks,
-  gridlines,
   richTooltipSection,
   truncateXAxis,
   xAxisBounds,
@@ -393,8 +391,6 @@ const config: ControlPanelConfig = {
         ...createCustomizeSection(t('Query B'), 'B'),
         ['zoomable'],
         [minorTicks],
-        [axisTicks],
-        [gridlines],
         ...legendSection,
         [<ControlSubSectionHeader>{t('X Axis')}</ControlSubSectionHeader>],
         ['x_axis_time_format'],

superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts

@@ -184,8 +184,6 @@ export default function transformProps(
     opacityB,
     minorSplitLine,
     minorTicks,
-    gridlines,
-    axisTicks,
     seriesType,
     seriesTypeB,
     showLegend,
@@ -790,8 +788,6 @@ export default function transformProps(
         }),
       },
       minorTick: { show: minorTicks },
-      axisTick: { show: axisTicks ? 'auto' : false },
-      ...(gridlines ? {} : { splitLine: { show: false } }),
       minInterval:
         xAxisType === AxisType.Time && resolvedTimeGrain && !forceMaxInterval
           ? (TIMEGRAIN_TO_TIMESTAMP[
@@ -822,8 +818,6 @@ export default function transformProps(
         min: yAxisMin,
         max: yAxisMax,
         minorTick: { show: minorTicks },
-        axisTick: { show: axisTicks ? 'auto' : false },
-        splitLine: { show: gridlines },
         minorSplitLine: { show: minorSplitLine },
         axisLabel: {
           formatter: getYAxisFormatter(
@@ -846,7 +840,6 @@ export default function transformProps(
         min: minSecondary,
         max: maxSecondary,
         minorTick: { show: minorTicks },
-        axisTick: { show: axisTicks ? 'auto' : false },
         splitLine: { show: false },
         minorSplitLine: { show: minorSplitLine },
         axisLabel: {

superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/types.ts

@@ -48,8 +48,6 @@ export type EchartsMixedTimeseriesFormData = QueryFormData & {
   // shared properties
   minorSplitLine: boolean;
   minorTicks: boolean;
-  gridlines: boolean;
-  axisTicks: boolean;
   logAxis: boolean;
   logAxisSecondary: boolean;
   yAxisFormat?: string;
@@ -115,8 +113,6 @@ export const DEFAULT_FORM_DATA: EchartsMixedTimeseriesFormData = {
   ...DEFAULT_LEGEND_FORM_DATA,
   annotationLayers: [],
   minorSplitLine: TIMESERIES_DEFAULTS.minorSplitLine,
-  gridlines: TIMESERIES_DEFAULTS.gridlines,
-  axisTicks: TIMESERIES_DEFAULTS.axisTicks,
   truncateYAxis: TIMESERIES_DEFAULTS.truncateYAxis,
   truncateYAxisSecondary: TIMESERIES_DEFAULTS.truncateYAxis,
   logAxis: TIMESERIES_DEFAULTS.logAxis,

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Area/controlPanel.tsx

@@ -44,8 +44,6 @@ import {
   truncateXAxis,
   xAxisBounds,
   minorTicks,
-  axisTicks,
-  gridlines,
   forceMaxInterval,
 } from '../../controls';
 import { AreaChartStackControlOptions } from '../../constants';
@@ -176,8 +174,6 @@ const config: ControlPanelConfig = {
           },
         ],
         [minorTicks],
-        [axisTicks],
-        [gridlines],
         ['zoomable'],
         ...legendSection,
         [<ControlSubSectionHeader>{t('X Axis')}</ControlSubSectionHeader>],

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.test.tsx

@@ -133,8 +133,6 @@ const defaultFormData: EchartsTimeseriesFormData & {
   metrics: [],
   minorSplitLine: false,
   minorTicks: false,
-  gridlines: true,
-  axisTicks: true,
   opacity: 1,
   orderDesc: false,
   rowLimit: 0,

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx

@@ -40,8 +40,6 @@ import {
 import {
   legendSection,
   minorTicks,
-  axisTicks,
-  gridlines,
   richTooltipSection,
   seriesOrderSection,
   showValueSectionWithoutStream,
@@ -390,8 +388,6 @@ const config: ControlPanelConfig = {
           },
         ],
         [minorTicks],
-        [axisTicks],
-        [gridlines],
         ['zoomable'],
         ...legendSection,
         [<ControlSubSectionHeader>{t('X Axis')}</ControlSubSectionHeader>],

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/controlPanel.tsx

@@ -37,8 +37,6 @@ import {
 import {
   legendSection,
   minorTicks,
-  axisTicks,
-  gridlines,
   richTooltipSection,
   seriesOrderSection,
   showValueSection,
@@ -158,8 +156,6 @@ const config: ControlPanelConfig = {
         ],
         ['zoomable'],
         [minorTicks],
-        [axisTicks],
-        [gridlines],
         ...legendSection,
         [<ControlSubSectionHeader>{t('X Axis')}</ControlSubSectionHeader>],
         [

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Scatter/controlPanel.tsx

@@ -42,8 +42,6 @@ import {
 import {
   legendSection,
   minorTicks,
-  axisTicks,
-  gridlines,
   richTooltipSection,
   seriesOrderSection,
   showValueSection,
@@ -482,8 +480,6 @@ const config: ControlPanelConfig = {
         ],
         ['zoomable'],
         [minorTicks],
-        [axisTicks],
-        [gridlines],
         ...legendSection,
         [<ControlSubSectionHeader>{t('X Axis')}</ControlSubSectionHeader>],
         ...createAxisControl('x'),

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/SmoothLine/controlPanel.tsx

@@ -37,8 +37,6 @@ import {
 import {
   legendSection,
   minorTicks,
-  axisTicks,
-  gridlines,
   richTooltipSection,
   seriesOrderSection,
   showValueSectionWithoutStack,
@@ -107,8 +105,6 @@ const config: ControlPanelConfig = {
         ],
         ['zoomable'],
         [minorTicks],
-        [axisTicks],
-        [gridlines],
         ...legendSection,
         [<ControlSubSectionHeader>{t('X Axis')}</ControlSubSectionHeader>],
         [

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Step/controlPanel.tsx

@@ -35,8 +35,6 @@ import { DEFAULT_FORM_DATA, TIME_SERIES_DESCRIPTION_TEXT } from '../constants';
 import {
   legendSection,
   minorTicks,
-  axisTicks,
-  gridlines,
   richTooltipSection,
   seriesOrderSection,
   showValueSection,
@@ -159,8 +157,6 @@ const config: ControlPanelConfig = {
         ],
         ['zoomable'],
         [minorTicks],
-        [axisTicks],
-        [gridlines],
         ...legendSection,
         [<ControlSubSectionHeader>{t('X Axis')}</ControlSubSectionHeader>],
         [

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/constants.ts

@@ -67,8 +67,6 @@ export const DEFAULT_FORM_DATA: EchartsTimeseriesFormData = {
   maxMarkerSize: 30,
   minMarkerSize: 5,
   minorSplitLine: false,
-  gridlines: true,
-  axisTicks: true,
   opacity: 0.2,
   orderDesc: true,
   rowLimit: 10000,

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts

@@ -283,8 +283,6 @@ export default function transformProps(
     metrics,
     minorSplitLine,
     minorTicks,
-    gridlines,
-    axisTicks,
     onlyTotal,
     opacity,
     orientation,
@@ -1282,8 +1280,6 @@ export default function transformProps(
       }),
     },
     minorTick: { show: minorTicks },
-    axisTick: { show: axisTicks ? 'auto' : false },
-    ...(gridlines ? {} : { splitLine: { show: false } }),
     minInterval:
       xAxisType === AxisType.Time && resolvedTimeGrain && !forceMaxInterval
         ? (TIMEGRAIN_TO_TIMESTAMP[
@@ -1328,7 +1324,7 @@ export default function transformProps(
     max: yAxisMax,
     minorTick: { show: isSmallChart ? false : minorTicks },
     minorSplitLine: { show: isSmallChart ? false : minorSplitLine },
-    splitLine: { show: isSmallChart ? false : gridlines },
+    splitLine: { show: !isSmallChart },
     axisLabel: {
       show: !isMicroChart,
       showMinLabel: !isMicroChart,
@@ -1342,7 +1338,7 @@ export default function transformProps(
         yAxisFormat,
       ),
     },
-    axisTick: { show: isSmallChart ? false : axisTicks },
+    axisTick: { show: !isSmallChart },
     scale: truncateYAxis,
     name: isSmallChart ? undefined : yAxisTitle,
     nameGap: convertInteger(yAxisTitleMargin),

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/types.ts

@@ -73,8 +73,6 @@ export type EchartsTimeseriesFormData = QueryFormData & {
   metrics: QueryFormMetric[];
   minorSplitLine: boolean;
   minorTicks: boolean;
-  gridlines: boolean;
-  axisTicks: boolean;
   opacity: number;
   orderDesc: boolean;
   rowLimit: number;

superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx

@@ -495,28 +495,6 @@ export const minorTicks: ControlSetItem = {
   },
 };
 
-export const axisTicks: ControlSetItem = {
-  name: 'axisTicks',
-  config: {
-    type: 'CheckboxControl',
-    label: t('Axis ticks'),
-    default: true,
-    renderTrigger: true,
-    description: t('Show the main ticks on axes.'),
-  },
-};
-
-export const gridlines: ControlSetItem = {
-  name: 'gridlines',
-  config: {
-    type: 'CheckboxControl',
-    label: t('Gridlines'),
-    default: true,
-    renderTrigger: true,
-    description: t('Draw split lines for the main value axis ticks.'),
-  },
-};
-
 export const forceCategorical: ControlSetItem = {
   name: 'forceCategorical',
   config: {

superset-frontend/plugins/plugin-chart-echarts/src/utils/eventHandlers.ts

@@ -47,9 +47,6 @@ const getCrossFilterDataMask =
   ) =>
   (value: string) => {
     const selected = Object.values(selectedValues);
-    if (!labelMap[value] && !selected.includes(value)) {
-      return undefined;
-    }
     let values: string[];
     if (selected.includes(value)) {
       values = selected.filter(v => v !== value);

superset-frontend/plugins/plugin-chart-echarts/test/MixedTimeseries/transformProps.test.ts

@@ -116,8 +116,6 @@ const formData: EchartsMixedTimeseriesFormData = {
   markerSizeB: 0,
   minorSplitLine: false,
   minorTicks: false,
-  gridlines: true,
-  axisTicks: true,
   opacity: 0,
   opacityB: 0,
   orderDesc: false,
@@ -1511,56 +1509,3 @@ describe('EchartsMixedTimeseries tooltip truncation', () => {
     expect(html).not.toContain(longSeriesName);
   });
 });
-
-function transformWithChrome(
-  overrides: Partial<EchartsMixedTimeseriesFormData>,
-) {
-  const chartProps = createEchartsTimeseriesTestChartProps<
-    EchartsMixedTimeseriesFormData,
-    EchartsMixedTimeseriesProps
-  >({
-    ...MIXED_TIMESERIES_CHART_PROPS_DEFAULTS,
-    defaultQueriesData: queriesData,
-    formData: { ...formData, ...overrides },
-    queriesData,
-  });
-  const { echartOptions } = transformProps(chartProps);
-  return {
-    xAxis: echartOptions.xAxis as any,
-    yAxis: echartOptions.yAxis as any[],
-  };
-}
-
-test('draws gridlines and axis ticks when both are enabled', () => {
-  const { xAxis, yAxis } = transformWithChrome({});
-
-  expect(yAxis[0].splitLine.show).toBe(true);
-  // Both axes keep ECharts' own default, which the Mixed chart never overrode.
-  expect(yAxis[0].axisTick.show).toBe('auto');
-  expect(xAxis.axisTick.show).toBe('auto');
-});
-
-test('hides the gridlines on the primary axis', () => {
-  const { xAxis, yAxis } = transformWithChrome({ gridlines: false });
-
-  expect(yAxis[0].splitLine.show).toBe(false);
-  // The secondary axis never draws gridlines, so the two grids cannot double up.
-  expect(yAxis[1].splitLine.show).toBe(false);
-  expect(xAxis.splitLine.show).toBe(false);
-});
-
-test('never turns the secondary axis gridlines on', () => {
-  const { xAxis, yAxis } = transformWithChrome({ gridlines: true });
-
-  expect(yAxis[0].splitLine.show).toBe(true);
-  expect(yAxis[1].splitLine.show).toBe(false);
-  expect(xAxis.splitLine).toBeUndefined();
-});
-
-test('hides the ticks on the x axis and both y axes', () => {
-  const { xAxis, yAxis } = transformWithChrome({ axisTicks: false });
-
-  expect(xAxis.axisTick.show).toBe(false);
-  expect(yAxis[0].axisTick.show).toBe(false);
-  expect(yAxis[1].axisTick.show).toBe(false);
-});

superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts

@@ -2766,76 +2766,3 @@ describe('tooltip for metrics whose labels end in forecast suffixes', () => {
     expect(html).toContain('>ci<');
   });
 });
-
-test('shows gridlines and axis ticks by default', () => {
-  const { echartOptions } = transformProps(createTestChartProps({}));
-  const xAxis = echartOptions.xAxis as any;
-  const yAxis = echartOptions.yAxis as any;
-
-  expect(yAxis.splitLine.show).toBe(true);
-  expect(yAxis.axisTick.show).toBe(true);
-  // Left to ECharts, which draws no ticks on a banded category axis. Forcing
-  // true would add ticks the chart does not have today.
-  expect(xAxis.axisTick.show).toBe('auto');
-});
-
-test('hides gridlines without touching the minor split lines', () => {
-  const { echartOptions } = transformProps(
-    createTestChartProps({ formData: { gridlines: false } }),
-  );
-  const yAxis = echartOptions.yAxis as any;
-
-  expect(yAxis.splitLine.show).toBe(false);
-  expect(yAxis.minorSplitLine.show).toBe(DEFAULT_FORM_DATA.minorSplitLine);
-  expect(yAxis.axisTick.show).toBe(true);
-});
-
-test('leaves the category axis split lines alone until gridlines are turned off', () => {
-  const shown = transformProps(createTestChartProps({}));
-  // Writing show:true here would draw gridlines on axis types that default to
-  // none, so the key is only ever added to hide them.
-  expect((shown.echartOptions.xAxis as any).splitLine).toBeUndefined();
-
-  const hidden = transformProps(
-    createTestChartProps({ formData: { gridlines: false } }),
-  );
-  expect((hidden.echartOptions.xAxis as any).splitLine.show).toBe(false);
-});
-
-test('hides the ticks on both axes', () => {
-  const { echartOptions } = transformProps(
-    createTestChartProps({ formData: { axisTicks: false } }),
-  );
-
-  expect((echartOptions.yAxis as any).axisTick.show).toBe(false);
-  expect((echartOptions.xAxis as any).axisTick.show).toBe(false);
-  expect((echartOptions.yAxis as any).splitLine.show).toBe(true);
-});
-
-test('keeps gridlines and ticks off on a compact chart even when both are enabled', () => {
-  const { echartOptions } = transformProps(
-    createTestChartProps({
-      height: TIMESERIES_CONSTANTS.compactChartHeight - 1,
-      formData: { gridlines: true, axisTicks: true },
-    }),
-  );
-  const yAxis = echartOptions.yAxis as any;
-
-  expect(yAxis.splitLine.show).toBe(false);
-  expect(yAxis.axisTick.show).toBe(false);
-});
-
-test('applies gridlines to the value axis after a horizontal orientation swaps it', () => {
-  const { echartOptions } = transformProps(
-    createTestChartProps({
-      formData: {
-        orientation: OrientationType.Horizontal,
-        gridlines: false,
-      },
-    }),
-  );
-
-  // The transform swaps the axes for a horizontal chart, so the value axis —
-  // and the gridlines belonging to it — end up on xAxis.
-  expect((echartOptions.xAxis as any).splitLine.show).toBe(false);
-});

superset-frontend/plugins/plugin-chart-echarts/test/utils/eventHandlers.test.ts

@@ -180,46 +180,3 @@ test('cross-filter does nothing when emitCrossFilters is false', () => {
 
   expect(setDataMask).not.toHaveBeenCalled();
 });
-
-test('cross-filter does nothing when name is missing from labelMap', () => {
-  const setDataMask = jest.fn();
-  const props = buildProps({
-    groupby: ['topics'],
-    labelMap: {
-      cancellations: ['cancellations'],
-    },
-    selectedValues: {},
-    setDataMask,
-  });
-
-  const handlers = allEventHandlers(props);
-  // e.g. Pie "Other" category is not present in labelMap
-  handlers.click({ name: 'Other' });
-
-  expect(setDataMask).not.toHaveBeenCalled();
-});
-
-test('cross-filter still deselects a previously selected value that is missing from labelMap', () => {
-  const setDataMask = jest.fn();
-  const props = buildProps({
-    groupby: ['topics'],
-    labelMap: {
-      cancellations: ['cancellations'],
-    },
-    // "Other" was selected before it dropped out of labelMap (e.g. a stale
-    // cross-filter from an earlier render or dashboard state).
-    selectedValues: { 0: 'Other' },
-    setDataMask,
-  });
-
-  const handlers = allEventHandlers(props);
-  handlers.click({ name: 'Other' });
-
-  expect(setDataMask).toHaveBeenCalledWith(
-    expect.objectContaining({
-      extraFormData: {
-        filters: [],
-      },
-    }),
-  );
-});

superset-frontend/plugins/plugin-chart-point-cluster-map/package.json

@@ -30,7 +30,7 @@
   },
   "dependencies": {
     "@math.gl/web-mercator": "^4.1.0",
-    "mapbox-gl": "^3.29.0",
+    "mapbox-gl": "^3.28.1",
     "maplibre-gl": "^5.24.0",
     "react-map-gl": "^8.1.2",
     "supercluster": "^9.0.0"

superset-frontend/src/SqlLab/components/SqlEditor/SqlEditor.test.tsx

@@ -355,31 +355,25 @@ describe('SqlEditor', () => {
       }),
     );
 
-  // findByRole('button', { name }) walks every stylesheet rule via nwsapi to
-  // compute the accessible name, which can crash on an unrelated antd Tabs
-  // "more" button style; findByLabelText matches the same aria-label without
-  // that traversal.
   test('enables the save dataset button when the latest query succeeded', async () => {
-    const { findByLabelText } = setupWithLatestQuery({
-      state: QueryState.Success,
-    });
-    expect(await findByLabelText('Save dataset')).toBeEnabled();
+    const { findByRole } = setupWithLatestQuery({ state: QueryState.Success });
+    expect(await findByRole('button', { name: 'Save dataset' })).toBeEnabled();
   });
 
   test('disables the save dataset button when the latest query failed', async () => {
-    const { findByLabelText } = setupWithLatestQuery({
+    const { findByRole } = setupWithLatestQuery({
       state: QueryState.Failed,
       results: undefined,
     });
-    expect(await findByLabelText('Save dataset')).toBeDisabled();
+    expect(await findByRole('button', { name: 'Save dataset' })).toBeDisabled();
   });
 
   test('disables the save dataset button when the results are not loaded', async () => {
-    const { findByLabelText } = setupWithLatestQuery({
+    const { findByRole } = setupWithLatestQuery({
       state: QueryState.Success,
       results: undefined,
     });
-    expect(await findByLabelText('Save dataset')).toBeDisabled();
+    expect(await findByRole('button', { name: 'Save dataset' })).toBeDisabled();
   });
 
   test('renders an Extension if provided', async () => {

superset-frontend/src/components/RowCountLabel/RowCountLabel.test.tsx

@@ -53,22 +53,6 @@ test('RowCountLabel renders limit with danger and tooltip', async () => {
   expect(tooltip).toHaveTextContent('The row limit');
 });
 
-test('RowCountLabel uses a caller-provided limitReachedMessage instead of the default', async () => {
-  render(
-    <RowCountLabel
-      rowcount={100}
-      limit={100}
-      limitReachedMessage="Custom limit message"
-    />,
-  );
-  const expectedText = '100 rows';
-  expect(screen.getByText(expectedText)).toBeInTheDocument();
-  userEvent.hover(screen.getByText(expectedText));
-  const tooltip = await screen.findByRole('tooltip');
-  expect(tooltip).toHaveTextContent('Custom limit message');
-  expect(tooltip).not.toHaveTextContent('The row limit set for the chart');
-});
-
 test('RowCountLabel renders loading', () => {
   render(<RowCountLabel loading />);
   const expectedText = 'Loading...';

superset-frontend/src/components/RowCountLabel/index.tsx

@@ -26,9 +26,6 @@ type RowCountLabelProps = {
   limit?: number;
   loading?: boolean;
   label?: JSX.Element;
-  // Overrides the default "chart" wording for panes (e.g. samples) where the
-  // limit reached isn't the chart's own row_limit.
-  limitReachedMessage?: React.ReactNode;
 };
 
 const limitReachedMsg = t(
@@ -36,13 +33,7 @@ const limitReachedMsg = t(
 );
 
 export default function RowCountLabel(props: RowCountLabelProps) {
-  const {
-    rowcount = 0,
-    limit = null,
-    loading,
-    label,
-    limitReachedMessage,
-  } = props;
+  const { rowcount = 0, limit = null, loading, label } = props;
   const limitReached = limit && rowcount >= limit;
   const type =
     limitReached || (rowcount === 0 && !loading) ? 'error' : 'default';
@@ -59,10 +50,7 @@ export default function RowCountLabel(props: RowCountLabelProps) {
     </Label>
   );
   return limitReached ? (
-    <Tooltip
-      id="tt-rowcount-tooltip"
-      title={<span>{limitReachedMessage ?? limitReachedMsg}</span>}
-    >
+    <Tooltip id="tt-rowcount-tooltip" title={<span>{limitReachedMsg}</span>}>
       {label || labelText}
     </Tooltip>
   ) : (

superset-frontend/src/dashboard/actions/dashboardLayout.ts

@@ -312,7 +312,7 @@ export function handleComponentDrop(dropResult: DropResult) {
       source &&
       !(
         // ensure it has moved
-        destination.id === source.id && destination.index === source.index
+        (destination.id === source.id && destination.index === source.index)
       )
     ) {
       dispatch(moveComponent(dropResult));

superset-frontend/src/dashboard/components/DashboardBuilder/DashboardWrapper.tsx

@@ -117,7 +117,7 @@ const StyledDiv = styled.div`
     ${
       isMobileConsumptionEnabled()
         ? `@media (max-width: ${theme.screenSMMax}px) {
-      .slice-header .header-title {
+      [data-test='slice-header'] .header-title {
         -webkit-line-clamp: unset;
         display: block;
         white-space: normal;

superset-frontend/src/dashboard/components/PropertiesModal/index.tsx

@@ -79,15 +79,6 @@ type PropertiesModalProps = {
   addSuccessToast: (message: string) => void;
   addDangerToast: (message: string) => void;
   onlyApply?: boolean;
-  renderExtraFields?: (context: {
-    assetId: number;
-    assetType: 'dashboard';
-    accessorCount: number;
-  }) => {
-    content: React.ReactNode;
-    saveDisabled?: boolean;
-    saveTooltip?: string;
-  };
 };
 
 type DashboardInfo = {
@@ -116,7 +107,6 @@ const PropertiesModal = ({
   onlyApply = false,
   onSubmit = () => {},
   show = false,
-  renderExtraFields,
 }: PropertiesModalProps) => {
   const dispatch = useDispatch();
   const [form] = Form.useForm();
@@ -133,17 +123,6 @@ const PropertiesModal = ({
   });
   const [editors, setEditors] = useState<Subject[]>([]);
   const [viewers, setViewers] = useState<Subject[]>([]);
-
-  const extraFields = useMemo(
-    () =>
-      renderExtraFields?.({
-        assetId: dashboardId,
-        assetType: 'dashboard',
-        accessorCount: editors.length + viewers.length,
-      }),
-    [renderExtraFields, dashboardId, editors.length, viewers.length],
-  );
-
   const saveLabel = onlyApply ? t('Apply') : t('Save');
   const [tags, setTags] = useState<TagType[]>([]);
   const [customCss, setCustomCss] = useState('');
@@ -719,21 +698,15 @@ const PropertiesModal = ({
       }}
       title={t('Dashboard properties')}
       isEditMode
-      saveDisabled={
-        dashboardInfo?.isManagedExternally ||
-        hasErrors ||
-        extraFields?.saveDisabled
-      }
+      saveDisabled={dashboardInfo?.isManagedExternally || hasErrors}
       saveLoading={isApplying}
       contentLoading={isLoading}
       errorTooltip={
-        extraFields?.saveDisabled && extraFields?.saveTooltip
-          ? extraFields.saveTooltip
-          : dashboardInfo?.isManagedExternally
-            ? t(
-                "This dashboard is managed externally, and can't be edited in Superset",
-              )
-            : errorTooltip
+        dashboardInfo?.isManagedExternally
+          ? t(
+              "This dashboard is managed externally, and can't be edited in Superset",
+            )
+          : errorTooltip
       }
       saveText={saveLabel}
       wrapProps={{ 'data-test': 'properties-edit-modal' }}
@@ -796,7 +769,6 @@ const PropertiesModal = ({
                   onChangeViewers={handleOnChangeViewers}
                   onChangeTags={handleChangeTags}
                   onClearTags={handleClearTags}
-                  renderExtraFields={extraFields}
                 />
               ),
             },

superset-frontend/src/dashboard/components/PropertiesModal/sections/AccessSection.tsx

@@ -38,11 +38,6 @@ interface AccessSectionProps {
   onChangeViewers: (viewers: SubjectPickerValue[]) => void;
   onChangeTags: (tags: { label: string; value: number }[]) => void;
   onClearTags: () => void;
-  renderExtraFields?: {
-    content: React.ReactNode;
-    saveDisabled?: boolean;
-    saveTooltip?: string;
-  };
 }
 
 const AccessSection = ({
@@ -54,7 +49,6 @@ const AccessSection = ({
   onChangeViewers,
   onChangeTags,
   onClearTags,
-  renderExtraFields,
 }: AccessSectionProps) => {
   const enableViewers = isFeatureEnabled(FeatureFlag.EnableViewers);
 
@@ -140,7 +134,6 @@ const AccessSection = ({
           />
         </ModalFormField>
       )}
-      {renderExtraFields?.content}
     </>
   );
 };

superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

@@ -208,18 +208,6 @@ test('Should render', () => {
   expect(screen.getByTestId('slice-header')).toBeInTheDocument();
 });
 
-test('Should expose a class hook, not just data-test, for fullscreen styling', () => {
-  const props = createProps();
-  render(<SliceHeader {...props} />, {
-    useRedux: true,
-    useRouter: true,
-    initialState,
-  });
-  // The production build strips data-test attributes, so CSS that targets the
-  // header must hang off a class instead.
-  expect(screen.getByTestId('slice-header')).toHaveClass('slice-header');
-});
-
 test('Should render - default props', () => {
   const props = createProps();
 

superset-frontend/src/dashboard/components/SliceHeader/index.tsx

@@ -270,11 +270,7 @@ const SliceHeader = forwardRef<HTMLDivElement, SliceHeaderProps>(
     );
 
     return (
-      <ChartHeaderStyles
-        className="slice-header"
-        data-test="slice-header"
-        ref={ref}
-      >
+      <ChartHeaderStyles data-test="slice-header" ref={ref}>
         <div className="header-title" ref={headerRef}>
           <Tooltip title={headerTooltip}>
             {/* this div ensures the hover event triggers correctly and prevents flickering */}

superset-frontend/src/dashboard/components/SliceHeaderControls/Styles.tsx

@@ -19,13 +19,20 @@
 import { css, SupersetTheme } from '@apache-superset/core/theme';
 
 export const fullscreenStyles = (theme: SupersetTheme) => css`
-  .dashboard-component-chart-holder:fullscreen {
+  [data-test='dashboard-component-chart-holder']:fullscreen {
     background-color: ${theme.colorBgBase};
+    width: 100vw;
+    height: 100vh;
+    box-sizing: border-box;
     display: flex;
     flex-direction: column;
     padding: ${theme.sizeUnit * 4}px;
     overflow: visible;
+    position: relative;
     pointer-events: auto;
+    z-index: ${theme.zIndexPopupBase};
+    opacity: 1;
+    visibility: visible;
 
     /* Ensure children take up available space */
     .dashboard-chart,
@@ -51,8 +58,13 @@ export const fullscreenStyles = (theme: SupersetTheme) => css`
     }
   }
 
-  /* Keep the header above the chart it shares the fullscreen layer with */
-  .dashboard-component-chart-holder:fullscreen .slice-header {
+  /* Interaction and Header fixes */
+  [data-test='dashboard-component-chart-holder']:fullscreen * {
+    pointer-events: auto;
+  }
+
+  [data-test='dashboard-component-chart-holder']:fullscreen
+    [data-test='slice-header'] {
     z-index: ${theme.zIndexPopupBase};
     position: relative;
   }

superset-frontend/src/dashboard/components/gridComponents/ChartHolder/ChartHolder.tsx

@@ -337,17 +337,13 @@ const ChartHolder = ({
           )}
         >
           <AntdThemeProvider
-            getPopupContainer={(triggerNode?: HTMLElement) => {
-              // Only the fullscreen element's subtree is painted, so popups
-              // have to be portaled into it rather than to document.body.
-              // Resolve it directly instead of matching a selector: the
-              // production build strips data-test attributes.
-              const fullscreenElement =
-                document.fullscreenElement as HTMLElement | null;
-              return triggerNode && fullscreenElement?.contains(triggerNode)
-                ? fullscreenElement
-                : document.body;
-            }}
+            getPopupContainer={(triggerNode: HTMLElement) =>
+              document.fullscreenElement
+                ? (triggerNode?.closest?.(
+                    '[data-test="dashboard-component-chart-holder"]',
+                  ) as HTMLElement) || document.body
+                : document.body
+            }
           >
             {!editMode && (
               <AnchorLink

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.test.tsx

@@ -97,29 +97,3 @@ test('does not render DeckglLayerVisibilityTooltip for standard filter type', ()
     screen.queryByTestId('deckgl-layer-visibility-tooltip-icon'),
   ).not.toBeInTheDocument();
 });
-
-test('does not mark a defaultToFirstItem-only filter as required', () => {
-  render(
-    <FilterControl
-      filter={{
-        ...nativeFilter,
-        controlValues: { defaultToFirstItem: true },
-      }}
-      onFilterSelectionChange={jest.fn()}
-    />,
-  );
-  expect(screen.queryByText('*')).not.toBeInTheDocument();
-});
-
-test('marks an enableEmptyFilter filter as required', () => {
-  render(
-    <FilterControl
-      filter={{
-        ...nativeFilter,
-        controlValues: { enableEmptyFilter: true },
-      }}
-      onFilterSelectionChange={jest.fn()}
-    />,
-  );
-  expect(screen.getByText('*')).toBeInTheDocument();
-});

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx

@@ -65,7 +65,9 @@ const FilterControl = ({
     isFilterInScope(filter) &&
     checkIsMissingRequiredValue(filter, filter.dataMask?.filterState);
   const validateStatus = isMissingRequiredValue ? 'error' : undefined;
-  const isRequired = !!filter.controlValues?.enableEmptyFilter;
+  const isRequired =
+    !!filter.controlValues?.enableEmptyFilter ||
+    !!filter.controlValues?.defaultToFirstItem;
   const inverseSelection = !!filter.controlValues?.inverseSelection;
 
   const {

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/utils.test.ts

@@ -211,16 +211,6 @@ test('checkIsMissingRequiredValue returns false for non-required filter with und
   expect(checkIsMissingRequiredValue(filter, filterState)).toBe(false);
 });
 
-test('checkIsMissingRequiredValue returns false when only defaultToFirstItem is set', () => {
-  const filter = createFilter('test-filter', {
-    enableEmptyFilter: false,
-    controlValues: { defaultToFirstItem: true },
-  });
-
-  expect(checkIsMissingRequiredValue(filter, { value: null })).toBe(false);
-  expect(checkIsMissingRequiredValue(filter, { value: undefined })).toBe(false);
-});
-
 test('checkIsMissingRequiredValue returns falsy for filter without controlValues', () => {
   const filter = { id: 'test-filter' } as Filter;
   const filterState: FilterState = { value: undefined };
@@ -309,48 +299,6 @@ test('checkIsApplyDisabled returns true when required filter is missing value in
   );
 });
 
-test('checkIsApplyDisabled enables Apply after clearing a cascading defaultToFirstItem child', () => {
-  // Regression: a child filter that is dependent on a parent and configured with
-  // "Select first filter value by default" but NOT "Filter value is required"
-  // must stay clearable — clearing it may not disable Apply.
-  const parent = createFilter('parent', {
-    enableEmptyFilter: true,
-    controlValues: { defaultToFirstItem: true },
-  });
-  const child = createFilter('child', {
-    enableEmptyFilter: false,
-    controlValues: { defaultToFirstItem: true },
-  });
-  const dataMaskSelected: DataMaskStateWithId = {
-    parent: {
-      id: 'parent',
-      filterState: { value: ['USA'] },
-      extraFormData: createExtraFormDataWithFilter('country', ['USA']),
-    },
-    child: {
-      id: 'child',
-      filterState: { value: null },
-      extraFormData: {},
-    },
-  };
-  const dataMaskApplied: DataMaskStateWithId = {
-    parent: {
-      id: 'parent',
-      filterState: { value: ['USA'] },
-      extraFormData: createExtraFormDataWithFilter('country', ['USA']),
-    },
-    child: {
-      id: 'child',
-      filterState: { value: ['CA'] },
-      extraFormData: createExtraFormDataWithFilter('state', ['CA']),
-    },
-  };
-
-  expect(
-    checkIsApplyDisabled(dataMaskSelected, dataMaskApplied, [parent, child]),
-  ).toBe(false);
-});
-
 test('checkIsApplyDisabled enables Apply when Selected has a filter value not yet in Applied', () => {
   // Regression: when a required filter's default isn't applied (Applied missing
   // the entry) and the user types a value, Selected gains an entry Applied

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/utils.ts

@@ -48,10 +48,9 @@ export const checkIsMissingRequiredValue = (
   filter: FilterElement,
   filterState?: FilterState,
 ) => {
-  // Only `enableEmptyFilter` ("Filter value is required") makes a value
-  // mandatory. `defaultToFirstItem` merely seeds an initial selection, so a
-  // filter cleared by the user must stay clearable, with Apply enabled.
-  const isRequired = !!filter.controlValues?.enableEmptyFilter;
+  const isRequired =
+    !!filter.controlValues?.enableEmptyFilter ||
+    !!filter.controlValues?.defaultToFirstItem;
 
   if (!isRequired) return false;
 

superset-frontend/src/dataMask/reducer.ts

@@ -126,7 +126,7 @@ function fillNativeFilters(
       !(
         // Treat all-null arrays (range filters use [null, null] as their
         // canonical cleared value) and empty arrays as "no value".
-        Array.isArray(loadedValue) && loadedValue.every(v => v === null)
+        (Array.isArray(loadedValue) && loadedValue.every(v => v === null))
       );
     const loadedHasExtraFormData =
       !!loaded?.extraFormData && Object.keys(loaded.extraFormData).length > 0;

superset-frontend/src/explore/components/Control.test.tsx

@@ -16,13 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import {
-  render,
-  screen,
-  waitFor,
-  userEvent,
-  fireEvent,
-} from 'spec/helpers/testing-library';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
 import Control, { ControlProps } from 'src/explore/components/Control';
 
 const defaultProps: ControlProps = {
@@ -83,72 +77,3 @@ test('call setControlValue if isVisible is false', async () => {
     expect(defaultProps.actions.setControlValue).toHaveBeenCalled(),
   );
 });
-
-test('shows the description icon while the control is hovered', async () => {
-  render(
-    setup({
-      label: 'My checkbox',
-      description: 'Help text',
-    }),
-  );
-
-  expect(
-    screen.queryByRole('button', { name: 'Show info tooltip' }),
-  ).not.toBeInTheDocument();
-
-  await userEvent.hover(screen.getByTestId('checkbox'));
-  expect(
-    screen.getByRole('button', { name: 'Show info tooltip' }),
-  ).toBeInTheDocument();
-
-  await userEvent.unhover(screen.getByTestId('checkbox'));
-  expect(
-    screen.queryByRole('button', { name: 'Show info tooltip' }),
-  ).not.toBeInTheDocument();
-});
-
-test('shows the description icon while the control has keyboard focus', () => {
-  render(
-    setup({
-      label: 'My checkbox',
-      description: 'Help text',
-    }),
-  );
-
-  expect(
-    screen.queryByRole('button', { name: 'Show info tooltip' }),
-  ).not.toBeInTheDocument();
-
-  fireEvent.focus(screen.getByRole('checkbox'));
-  const infoIcon = screen.getByRole('button', { name: 'Show info tooltip' });
-  expect(infoIcon).toBeInTheDocument();
-
-  fireEvent.blur(screen.getByRole('checkbox'), { relatedTarget: infoIcon });
-  expect(
-    screen.getByRole('button', { name: 'Show info tooltip' }),
-  ).toBeInTheDocument();
-
-  fireEvent.blur(infoIcon, { relatedTarget: document.body });
-  expect(
-    screen.queryByRole('button', { name: 'Show info tooltip' }),
-  ).not.toBeInTheDocument();
-});
-
-test('keeps the description icon visible when the pointer leaves a focused control', () => {
-  render(
-    setup({
-      label: 'My checkbox',
-      description: 'Help text',
-    }),
-  );
-
-  fireEvent.focus(screen.getByRole('checkbox'));
-  expect(
-    screen.getByRole('button', { name: 'Show info tooltip' }),
-  ).toBeInTheDocument();
-
-  fireEvent.mouseLeave(screen.getByTestId('checkbox'));
-  expect(
-    screen.getByRole('button', { name: 'Show info tooltip' }),
-  ).toBeInTheDocument();
-});

superset-frontend/src/explore/components/Control.tsx

@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { ReactNode, useCallback, useState, useEffect, FocusEvent } from 'react';
+import { ReactNode, useCallback, useState, useEffect } from 'react';
 import { isEqual } from 'lodash-es';
 import {
   ControlType,
@@ -70,18 +70,7 @@ export default function Control(props: ControlProps) {
   } = props;
 
   const [hovered, setHovered] = useState(false);
-  const [focused, setFocused] = useState(false);
   const wasVisible = usePrevious(isVisible);
-
-  const handleBlur = (event: FocusEvent<HTMLDivElement>) => {
-    if (
-      !(event.relatedTarget instanceof Node) ||
-      !event.currentTarget.contains(event.relatedTarget)
-    ) {
-      setFocused(false);
-    }
-  };
-
   const onChange = useCallback(
     (value: any, errors: any[]) => setControlValue(name, value, errors),
     [name, setControlValue],
@@ -130,15 +119,9 @@ export default function Control(props: ControlProps) {
       style={hidden ? { display: 'none' } : undefined}
       onMouseEnter={() => setHovered(true)}
       onMouseLeave={() => setHovered(false)}
-      onFocus={() => setFocused(true)}
-      onBlur={handleBlur}
     >
       <ErrorBoundary>
-        <ControlComponent
-          onChange={onChange}
-          hovered={hovered || focused}
-          {...props}
-        />
+        <ControlComponent onChange={onChange} hovered={hovered} {...props} />
       </ErrorBoundary>
     </StyledControl>
   );

superset-frontend/src/explore/components/ControlHeader.test.tsx

@@ -1,112 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import {
-  render,
-  screen,
-  userEvent,
-  fireEvent,
-} from 'spec/helpers/testing-library';
-import ControlHeader from './ControlHeader';
-
-const description = 'This control filters the whole chart.';
-
-test('does not render the description icon until the control is hovered', () => {
-  const { rerender } = render(
-    <ControlHeader
-      name="time_range"
-      label="Date Range"
-      description={description}
-    />,
-  );
-
-  expect(
-    screen.queryByRole('button', { name: 'Show info tooltip' }),
-  ).not.toBeInTheDocument();
-
-  rerender(
-    <ControlHeader
-      name="time_range"
-      label="Date Range"
-      description={description}
-      hovered
-    />,
-  );
-
-  expect(
-    screen.getByRole('button', { name: 'Show info tooltip' }),
-  ).toBeInTheDocument();
-});
-
-test('notifies onDescriptionHoverChange when the info icon is hovered', async () => {
-  const onDescriptionHoverChange = jest.fn();
-  render(
-    <ControlHeader
-      name="time_range"
-      label="Date Range"
-      description={description}
-      hovered
-      onDescriptionHoverChange={onDescriptionHoverChange}
-    />,
-  );
-
-  const infoIcon = screen.getByRole('button', { name: 'Show info tooltip' });
-  await userEvent.hover(infoIcon);
-  expect(onDescriptionHoverChange).toHaveBeenCalledWith(true);
-
-  await userEvent.unhover(infoIcon);
-  expect(onDescriptionHoverChange).toHaveBeenCalledWith(false);
-});
-
-test('notifies onDescriptionHoverChange when the info icon is focused', () => {
-  const onDescriptionHoverChange = jest.fn();
-  render(
-    <ControlHeader
-      name="time_range"
-      label="Date Range"
-      description={description}
-      hovered
-      onDescriptionHoverChange={onDescriptionHoverChange}
-    />,
-  );
-
-  const infoIcon = screen.getByRole('button', { name: 'Show info tooltip' });
-  fireEvent.focus(infoIcon);
-  expect(onDescriptionHoverChange).toHaveBeenCalledWith(true);
-
-  fireEvent.blur(infoIcon);
-  expect(onDescriptionHoverChange).toHaveBeenCalledWith(false);
-});
-
-test('activates tooltipOnClick from the keyboard', () => {
-  const tooltipOnClick = jest.fn();
-  render(
-    <ControlHeader
-      name="time_range"
-      label="Date Range"
-      description={description}
-      hovered
-      tooltipOnClick={tooltipOnClick}
-    />,
-  );
-
-  fireEvent.keyDown(screen.getByRole('button', { name: 'Show info tooltip' }), {
-    key: 'Enter',
-  });
-  expect(tooltipOnClick).toHaveBeenCalledTimes(1);
-});

superset-frontend/src/explore/components/ControlHeader.tsx

@@ -38,7 +38,6 @@ export type ControlHeaderProps = {
   tooltipOnClick?: () => void;
   warning?: string;
   danger?: string;
-  onDescriptionHoverChange?: (hovered: boolean) => void;
   // Allow extra props from control spread patterns (e.g. {...this.props})
   [key: string]: unknown;
 };
@@ -72,7 +71,6 @@ const ControlHeader: FC<ControlHeaderProps> = ({
   tooltipOnClick = () => {},
   warning,
   danger,
-  onDescriptionHoverChange,
 }) => {
   const theme = useTheme();
 
@@ -91,44 +89,24 @@ const ControlHeader: FC<ControlHeaderProps> = ({
           position: absolute;
           top: 50%;
           right: 0;
-          z-index: 1;
           padding-left: ${theme.sizeUnit}px;
           transform: translate(100%, -50%);
           white-space: nowrap;
-          pointer-events: auto;
         `}
       >
         {description && (
-          <>
+          <span>
             <Tooltip
               id="description-tooltip"
               title={description}
               placement="top"
-              mouseLeaveDelay={0}
-              trigger={['hover', 'focus']}
             >
-              {/* Same role="button" pattern as the label text: a real <button>
-                  is not valid inside FormLabel's <label>. */}
-              <span
-                // eslint-disable-next-line jsx-a11y/prefer-tag-over-role
-                role="button"
-                tabIndex={0}
-                data-test={`${name}-description-icon`}
-                aria-label={t('Show info tooltip')}
-                onMouseEnter={() => onDescriptionHoverChange?.(true)}
-                onMouseLeave={() => onDescriptionHoverChange?.(false)}
-                onFocus={() => onDescriptionHoverChange?.(true)}
-                onBlur={() => onDescriptionHoverChange?.(false)}
+              <Icons.InfoCircleOutlined
+                css={iconStyles}
                 onClick={tooltipOnClick}
-                onKeyDown={handleKeyboardActivation(tooltipOnClick)}
-                css={css`
-                  cursor: pointer;
-                `}
-              >
-                <Icons.InfoCircleOutlined css={iconStyles} />
-              </span>
+              />
             </Tooltip>{' '}
-          </>
+          </span>
         )}
         {renderTrigger && (
           <span>

superset-frontend/src/explore/components/DataTablesPane/components/DataTableControls.tsx

@@ -68,8 +68,6 @@ export const TableControls = ({
   canDownload,
   rowLimit,
   rowLimitOptions,
-  effectiveRowLimit,
-  limitReachedMessage,
   onRowLimitChange,
   onDownloadCSV,
   onDownloadXLSX,
@@ -113,19 +111,14 @@ export const TableControls = ({
             value={rowLimit}
             onChange={onRowLimitChange}
             options={rowLimitOptions ?? []}
-            // Labelled as the applied limit to avoid a second row count next to RowCountLabel.
-            prefix={t('Limit')}
             css={css`
-              min-width: 160px;
+              min-width: 110px;
             `}
           />
         )}
-        <RowCountLabel
-          rowcount={rowcount}
-          limit={effectiveRowLimit ?? rowLimit}
-          limitReachedMessage={limitReachedMessage}
-          loading={isLoading}
-        />
+        {(!onRowLimitChange || rowcount < (rowLimit ?? Infinity)) && (
+          <RowCountLabel rowcount={rowcount} loading={isLoading} />
+        )}
         {canDownload && onDownloadCSV && onDownloadXLSX && (
           <DownloadDropdown
             onDownloadCSV={onDownloadCSV}

superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx

@@ -28,6 +28,14 @@ const Wrapper = styled.div`
   flex-direction: column;
   height: 100%;
 
+  .ant-tabs {
+    height: 100%;
+  }
+
+  .ant-tabs-body {
+    height: 100%;
+  }
+
   .ant-tabs-content {
     display: flex;
     flex-direction: column;
@@ -80,12 +88,7 @@ export const ResultsPaneOnDashboard = ({
 
   return (
     <Wrapper>
-      <Tabs
-        fullHeight
-        activeKey={activeTabKey}
-        onChange={setActiveTabKey}
-        items={items}
-      />
+      <Tabs activeKey={activeTabKey} onChange={setActiveTabKey} items={items} />
     </Wrapper>
   );
 };

superset-frontend/src/explore/components/DataTablesPane/components/SamplesPane.tsx

@@ -136,12 +136,6 @@ export const SamplesPane = ({
 
   const columns = useGridColumns(colnames, coltypes, data);
   const keywordFilter = useKeywordFilter(filterText);
-  // Samples aren't capped by a chart's row_limit, just this pane's own
-  // page-size selector, so RowCountLabel's default "chart" wording is wrong here.
-  const limitReachedMessage = t(
-    'The sample row limit was reached. This %s may contain more rows.',
-    datasetLabelLower(),
-  );
 
   const handleInputChange = useCallback(
     (input: string) => setFilterText(input),
@@ -167,7 +161,6 @@ export const SamplesPane = ({
           canDownload={canDownload}
           rowLimit={rowLimit}
           rowLimitOptions={ROW_LIMIT_OPTIONS}
-          limitReachedMessage={limitReachedMessage}
           onRowLimitChange={handleRowLimitChange}
         />
         <ErrorAlertWrapper>
@@ -204,7 +197,6 @@ export const SamplesPane = ({
         canDownload={canDownload}
         rowLimit={rowLimit}
         rowLimitOptions={ROW_LIMIT_OPTIONS}
-        limitReachedMessage={limitReachedMessage}
         onRowLimitChange={handleRowLimitChange}
       />
       <GridContainer>

superset-frontend/src/explore/components/DataTablesPane/components/SingleQueryResultPane.tsx

@@ -56,8 +56,6 @@ export const SingleQueryResultPane = ({
   columnDisplayNames,
   rowLimit,
   rowLimitOptions,
-  effectiveRowLimit,
-  limitReachedMessage,
   onRowLimitChange,
   onDownloadCSV,
   onDownloadXLSX,
@@ -88,8 +86,6 @@ export const SingleQueryResultPane = ({
         canDownload={canDownload}
         rowLimit={rowLimit}
         rowLimitOptions={rowLimitOptions}
-        effectiveRowLimit={effectiveRowLimit}
-        limitReachedMessage={limitReachedMessage}
         onRowLimitChange={onRowLimitChange}
         onDownloadCSV={onDownloadCSV}
         onDownloadXLSX={onDownloadXLSX}

superset-frontend/src/explore/components/DataTablesPane/components/useResultsPane.tsx

@@ -84,17 +84,6 @@ export const useResultsPane = ({
   // Never exceed the chart's own row_limit
   const effectiveRowLimit = Math.min(rowLimit, chartRowLimit);
 
-  // When this pane's own row-limit selector is stricter than the chart's
-  // row_limit, it - not the chart - is what caps the result, so
-  // RowCountLabel's default "chart" wording would be misleading (the chart's
-  // configured row_limit was never actually reached).
-  const limitReachedMessage =
-    rowLimit < chartRowLimit
-      ? t(
-          'The row limit selected for this pane was reached. There may be more matching rows.',
-        )
-      : undefined;
-
   const cappedFormData = useMemo(
     () => ({ ...queryFormData, row_limit: effectiveRowLimit }),
     [queryFormData, effectiveRowLimit],
@@ -247,8 +236,6 @@ export const useResultsPane = ({
         columnDisplayNames={columnDisplayNames}
         rowLimit={rowLimit}
         rowLimitOptions={ROW_LIMIT_OPTIONS}
-        effectiveRowLimit={effectiveRowLimit}
-        limitReachedMessage={limitReachedMessage}
         onRowLimitChange={handleRowLimitChange}
       />
     </StyledDiv>

superset-frontend/src/explore/components/DataTablesPane/test/DataTableControls.test.tsx

@@ -1,94 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import {
-  act,
-  render,
-  screen,
-  sleep,
-  userEvent,
-} from 'spec/helpers/testing-library';
-import { GenericDataType } from '@apache-superset/core/common';
-import {
-  TableControls,
-  ROW_LIMIT_OPTIONS,
-} from '../components/DataTableControls';
-import { TableControlsProps } from '../types';
-
-const setup = (overrides: Partial<TableControlsProps> = {}) =>
-  render(
-    <TableControls
-      data={[]}
-      columnNames={['name']}
-      columnTypes={[GenericDataType.String]}
-      rowcount={0}
-      onInputChange={jest.fn()}
-      isLoading={false}
-      canDownload
-      rowLimit={100}
-      rowLimitOptions={ROW_LIMIT_OPTIONS}
-      onRowLimitChange={jest.fn()}
-      {...overrides}
-    />,
-    { useRedux: true },
-  );
-
-test('shows the row count when the result fills the selected row limit', () => {
-  setup({ rowcount: 100, rowLimit: 100 });
-
-  expect(screen.getByTestId('row-count-label')).toHaveTextContent('100 rows');
-});
-
-test('warns that the row limit was reached when the result fills it', async () => {
-  setup({ rowcount: 100, rowLimit: 100 });
-
-  userEvent.hover(screen.getByTestId('row-count-label'));
-
-  expect(await screen.findByRole('tooltip')).toHaveTextContent(
-    'The row limit set for the chart was reached',
-  );
-});
-
-test('does not warn when the result is smaller than the selected row limit', async () => {
-  setup({ rowcount: 42, rowLimit: 100 });
-
-  expect(screen.getByTestId('row-count-label')).toHaveTextContent('42 rows');
-  userEvent.hover(screen.getByTestId('row-count-label'));
-
-  // Wait past antd's 0.1s mouseEnterDelay so a regression that made the
-  // tooltip appear would be caught here instead of racing the delay.
-  await act(() => sleep(150));
-
-  expect(screen.queryByRole('tooltip')).not.toBeInTheDocument();
-});
-
-test("warns when the chart's own row limit truncates below the selected row limit", async () => {
-  setup({ rowcount: 250, rowLimit: 1000, effectiveRowLimit: 250 });
-
-  userEvent.hover(screen.getByTestId('row-count-label'));
-
-  expect(await screen.findByRole('tooltip')).toHaveTextContent(
-    'The row limit set for the chart was reached',
-  );
-});
-
-test('labels the row limit selector so it is not read as a second row count', () => {
-  setup({ rowcount: 100, rowLimit: 100 });
-
-  expect(screen.getByText('Limit')).toBeInTheDocument();
-});

superset-frontend/src/explore/components/DataTablesPane/test/ResultsPaneOnDashboard.test.tsx

@@ -25,15 +25,9 @@ import {
 } from 'spec/helpers/testing-library';
 import { ChartMetadata, ChartPlugin, VizType } from '@superset-ui/core';
 import { setupAGGridModules } from '@superset-ui/core/components/ThemedAgGridReact';
-import Tabs from '@superset-ui/core/components/Tabs';
 import { ResultsPaneOnDashboard } from '../components';
 import { createResultsPaneOnDashboardProps } from './fixture';
 
-jest.mock('@superset-ui/core/components/Tabs', () => {
-  const actual = jest.requireActual('@superset-ui/core/components/Tabs');
-  return { __esModule: true, ...actual, default: jest.fn(actual.default) };
-});
-
 beforeAll(() => {
   setupAGGridModules();
 });
@@ -112,8 +106,6 @@ describe('ResultsPaneOnDashboard', () => {
     expect(
       await findByText('No results were returned for this query'),
     ).toBeVisible();
-    const [tabsProps] = (Tabs as unknown as jest.Mock).mock.calls[0];
-    expect(tabsProps).toEqual(expect.objectContaining({ fullHeight: true }));
   });
 
   test('render errorMessage', async () => {

superset-frontend/src/explore/components/DataTablesPane/test/useResultsPane.test.tsx

@@ -16,12 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import {
-  screen,
-  render,
-  waitFor,
-  userEvent,
-} from 'spec/helpers/testing-library';
+import { screen, render, waitFor } from 'spec/helpers/testing-library';
 import { setupAGGridModules } from '@superset-ui/core/components/ThemedAgGridReact';
 import { getChartDataRequest } from 'src/components/Chart/chartAction';
 import { ResultsPaneOnDashboard } from '../components';
@@ -162,42 +157,6 @@ describe('useResultsPane query data reuse', () => {
     expect(screen.queryByText('Sci-Fi')).not.toBeInTheDocument();
     expect(screen.getByText('2 rows')).toBeVisible();
     expect(mockedGetChartDataRequest).not.toHaveBeenCalled();
-
-    userEvent.hover(screen.getByText('2 rows'));
-    expect(await screen.findByRole('tooltip')).toHaveTextContent(
-      'The row limit set for the chart was reached',
-    );
-  });
-
-  test("warns about this pane's own row limit, not the chart's, when the pane's selector is what caps the result", async () => {
-    // chart row_limit (2000) is well above this pane's default 1000-row
-    // selector, so the selector - not the chart - is what truncates here.
-    const props = createResultsPaneOnDashboardProps({
-      sliceId: 208,
-      rowLimit: 2000,
-      queriesResponse: [
-        {
-          colnames: ['genre'],
-          coltypes: [1],
-          data: Array.from({ length: 1500 }, (_, i) => ({
-            genre: `genre-${i}`,
-          })),
-          rowcount: 1500,
-        },
-      ],
-    });
-
-    render(<ResultsPaneOnDashboard {...props} />, { useRedux: true });
-
-    const rowCountLabel = await screen.findByTestId('row-count-label');
-    expect(rowCountLabel).toHaveTextContent('1k rows');
-
-    userEvent.hover(rowCountLabel);
-    const tooltip = await screen.findByRole('tooltip');
-    expect(tooltip).toHaveTextContent(
-      'The row limit selected for this pane was reached',
-    );
-    expect(tooltip).not.toHaveTextContent('for the chart');
   });
 
   test('renders an empty (0 rows) result from reused data without an API call', async () => {

superset-frontend/src/explore/components/DataTablesPane/types.ts

@@ -84,12 +84,6 @@ export interface TableControlsProps extends DrillControlsProps {
   canDownload: boolean;
   rowLimit?: number;
   rowLimitOptions?: { value: number; label: string }[];
-  // Effective result limit, capped by the chart's row limit.
-  // Defaults to `rowLimit` and controls the "row limit reached" warning.
-  effectiveRowLimit?: number;
-  // Overrides RowCountLabel's default "chart" wording for panes (e.g.
-  // samples) where the limit reached isn't the chart's own row_limit.
-  limitReachedMessage?: React.ReactNode;
   onRowLimitChange?: (limit: number) => void;
 }
 
@@ -110,9 +104,5 @@ export interface SingleQueryResultPaneProp
   columnDisplayNames?: Record<string, string>;
   rowLimit?: number;
   rowLimitOptions?: { value: number; label: string }[];
-  effectiveRowLimit?: number;
-  // Overrides RowCountLabel's default "chart" wording when the pane's own
-  // row-limit selector, not the chart's row_limit, is what capped the result.
-  limitReachedMessage?: React.ReactNode;
   onRowLimitChange?: (limit: number) => void;
 }

superset-frontend/src/explore/components/PropertiesModal/index.tsx

@@ -16,14 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import {
-  type ReactNode,
-  ChangeEvent,
-  useMemo,
-  useState,
-  useCallback,
-  useEffect,
-} from 'react';
+import { ChangeEvent, useMemo, useState, useCallback, useEffect } from 'react';
 
 import {
   Input,
@@ -63,12 +56,6 @@ export type PropertiesModalProps = {
   permissionsError?: string;
   addSuccessToast: (msg: string) => void;
   addDangerToast: (msg: string) => void;
-  /** Optional render prop for injecting extra fields (e.g. folder selector). */
-  renderExtraFields?: (context: {
-    assetId: number;
-    assetType: 'chart';
-    accessorCount: number;
-  }) => { content: ReactNode; saveDisabled?: boolean; saveTooltip?: string };
 };
 
 function PropertiesModal({
@@ -78,7 +65,6 @@ function PropertiesModal({
   show,
   addSuccessToast,
   addDangerToast,
-  renderExtraFields,
 }: PropertiesModalProps) {
   const [submitting, setSubmitting] = useState(false);
   // values of form inputs
@@ -101,25 +87,6 @@ function PropertiesModal({
   >(null);
   const [tags, setTags] = useState<TagType[]>([]);
 
-  const chartId = slice.slice_id;
-  const extraFields = useMemo(
-    () =>
-      chartId
-        ? renderExtraFields?.({
-            assetId: chartId,
-            assetType: 'chart',
-            accessorCount:
-              (selectedEditors?.length ?? 0) + (selectedViewers?.length ?? 0),
-          })
-        : undefined,
-    [
-      chartId,
-      renderExtraFields,
-      selectedEditors?.length,
-      selectedViewers?.length,
-    ],
-  );
-
   // Validation setup
   const modalSections = useMemo(
     () => [
@@ -314,20 +281,14 @@ function PropertiesModal({
       title={t('Chart properties')}
       isEditMode
       saveDisabled={
-        submitting ||
-        !name ||
-        slice.is_managed_externally ||
-        hasErrors ||
-        extraFields?.saveDisabled
+        submitting || !name || slice.is_managed_externally || hasErrors
       }
       errorTooltip={
-        extraFields?.saveDisabled && extraFields?.saveTooltip
-          ? extraFields.saveTooltip
-          : slice.is_managed_externally
-            ? t(
-                "This chart is managed externally, and can't be edited in Superset",
-              )
-            : errorTooltip
+        slice.is_managed_externally
+          ? t(
+              "This chart is managed externally, and can't be edited in Superset",
+            )
+          : errorTooltip
       }
       wrapProps={{ 'data-test': 'properties-edit-modal' }}
     >
@@ -434,7 +395,6 @@ function PropertiesModal({
                     />
                   </ModalFormField>
                 )}
-                {extraFields?.content}
               </>
             ),
           },

superset-frontend/src/explore/components/controls/ColumnConfigControl/types.ts

@@ -29,9 +29,7 @@ import { ControlFormItemComponents } from './ControlForm';
  * Column formatting configs.
  */
 export type ColumnConfig = {
-  [
-    key in SharedColumnConfigProp
-  ]?: (typeof SHARED_COLUMN_CONFIG_PROPS)[key]['value'];
+  [key in SharedColumnConfigProp]?: (typeof SHARED_COLUMN_CONFIG_PROPS)[key]['value'];
 } & Record<string, StrictJsonValue>;
 
 /**

superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx

@@ -147,7 +147,6 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
     onOpenPopover = noOp,
     onClosePopover = noOp,
     isOverflowingFilterBar = false,
-    hovered: isControlHovered = false,
   } = props;
   const defaultTimeFilter = useDefaultTimeFilter();
 
@@ -162,16 +161,9 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
   const [validTimeRange, setValidTimeRange] = useState<boolean>(false);
   const [evalResponse, setEvalResponse] = useState<string>(value);
   const [tooltipTitle, setTooltipTitle] = useState<ReactNode | null>(t(value));
-  const [isDescriptionHovered, setIsDescriptionHovered] = useState(false);
   const theme = useTheme();
   const [labelRef, labelIsTruncated] = useCSSTextTruncation<HTMLSpanElement>();
 
-  useEffect(() => {
-    if (!isControlHovered) {
-      setIsDescriptionHovered(false);
-    }
-  }, [isControlHovered]);
-
   useEffect(() => {
     if (value === NO_TIME_RANGE) {
       setActualTimeRange(NO_TIME_RANGE);
@@ -376,12 +368,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
       }
       overlayClassName="time-range-popover"
     >
-      <Tooltip
-        placement="top"
-        title={isDescriptionHovered ? null : tooltipTitle}
-        mouseLeaveDelay={0}
-        overlayStyle={{ pointerEvents: 'none' }}
-      >
+      <Tooltip placement="top" title={tooltipTitle}>
         {/* Wrap in a span so the Popover gets a stable DOM ref target;
             DateLabel forwards its ref to an inner span used for measuring
             text truncation, which would otherwise become the popover's
@@ -403,10 +390,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
 
   return (
     <>
-      <ControlHeader
-        {...props}
-        onDescriptionHoverChange={setIsDescriptionHovered}
-      />
+      <ControlHeader {...props} />
       {popoverContent}
     </>
   );

superset-frontend/src/explore/components/controls/DateFilterControl/tests/DateFilterLabel.test.tsx

@@ -18,35 +18,16 @@
  */
 import thunk from 'redux-thunk';
 import { Provider } from 'react-redux';
-import configureMockStore from 'redux-mock-store';
+import configureStore from 'redux-mock-store';
 
-import {
-  render,
-  screen,
-  userEvent,
-  waitFor,
-  fireEvent,
-} from 'spec/helpers/testing-library';
+import { render, screen, userEvent } from 'spec/helpers/testing-library';
 
-import { NO_TIME_RANGE, fetchTimeRange } from '@superset-ui/core';
+import { NO_TIME_RANGE } from '@superset-ui/core';
 import DateFilterLabel from '..';
 import { DateFilterControlProps } from '../types';
 import { DateFilterTestKey } from '../utils';
 
-jest.mock('@superset-ui/core', () => ({
-  ...jest.requireActual('@superset-ui/core'),
-  fetchTimeRange: jest.fn(),
-}));
-
-const mockedFetchTimeRange = fetchTimeRange as jest.MockedFunction<
-  typeof fetchTimeRange
->;
-
-const FIELD_TOOLTIP = '2024-01-01 ≤ col < 2024-01-08';
-const DESCRIPTION_TOOLTIP =
-  'This control filters the whole chart based on the selected time range.';
-
-const mockStore = configureMockStore([thunk]);
+const mockStore = configureStore([thunk]);
 
 const defaultProps = {
   onChange: jest.fn(),
@@ -54,11 +35,6 @@ const defaultProps = {
   onOpenPopover: jest.fn(),
 };
 
-beforeEach(() => {
-  mockedFetchTimeRange.mockReset();
-  mockedFetchTimeRange.mockResolvedValue({ value: FIELD_TOOLTIP });
-});
-
 function setup(
   props: Omit<DateFilterControlProps, 'name'> = defaultProps,
   store: any = mockStore({}),
@@ -160,61 +136,3 @@ test('DateFilter should properly handle isOverflowingFilterBar prop changes', ()
   expect(popoverAfterRerender?.parentElement).toBe(trigger.parentElement);
   expect(popoverAfterRerender?.parentElement).not.toBe(document.body);
 });
-
-test('hovering the description icon does not show the date range tooltip', async () => {
-  const tooltipOnClick = jest.fn();
-  render(
-    setup({
-      ...defaultProps,
-      value: 'Last week',
-      label: 'Date Range',
-      description: DESCRIPTION_TOOLTIP,
-      hovered: true,
-      tooltipOnClick,
-    }),
-  );
-
-  await waitFor(() => {
-    expect(screen.getByText('Last week')).toBeInTheDocument();
-  });
-
-  await userEvent.hover(screen.getByText('Last week'));
-  expect(await screen.findByRole('tooltip')).toHaveTextContent(FIELD_TOOLTIP);
-
-  const descriptionIcon = screen.getByRole('button', {
-    name: 'Show info tooltip',
-  });
-  fireEvent.focus(descriptionIcon);
-
-  await waitFor(() => {
-    expect(screen.getByRole('tooltip')).toHaveTextContent(DESCRIPTION_TOOLTIP);
-    expect(screen.getByRole('tooltip')).not.toHaveTextContent(FIELD_TOOLTIP);
-    expect(screen.getAllByRole('tooltip')).toHaveLength(1);
-  });
-
-  fireEvent.blur(descriptionIcon);
-  await waitFor(() => {
-    expect(screen.getByRole('tooltip')).toHaveTextContent(FIELD_TOOLTIP);
-    expect(screen.getAllByRole('tooltip')).toHaveLength(1);
-  });
-
-  await userEvent.unhover(screen.getByText('Last week'));
-  await waitFor(() => {
-    expect(screen.queryByRole('tooltip')).not.toBeInTheDocument();
-  });
-
-  await userEvent.hover(descriptionIcon);
-
-  const tooltip = await screen.findByRole('tooltip');
-  expect(tooltip).toHaveTextContent(DESCRIPTION_TOOLTIP);
-  expect(tooltip).not.toHaveTextContent(FIELD_TOOLTIP);
-  expect(screen.getAllByRole('tooltip')).toHaveLength(1);
-
-  await userEvent.unhover(descriptionIcon);
-  await waitFor(() => {
-    expect(screen.queryByRole('tooltip')).not.toBeInTheDocument();
-  });
-
-  fireEvent.keyDown(descriptionIcon, { key: 'Enter' });
-  expect(tooltipOnClick).toHaveBeenCalled();
-});

superset-frontend/src/explore/components/controls/DateFilterControl/types.ts

@@ -16,8 +16,6 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { ReactNode } from 'react';
-
 export type SelectOptionType = {
   value: string;
   label: string;
@@ -115,8 +113,4 @@ export interface DateFilterControlProps {
   onOpenPopover?: () => void;
   onClosePopover?: () => void;
   isOverflowingFilterBar?: boolean;
-  hovered?: boolean;
-  description?: ReactNode;
-  label?: ReactNode;
-  tooltipOnClick?: () => void;
 }

superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/AdhocFilterEditPopoverSimpleTabContent.test.tsx

@@ -951,167 +951,3 @@ test('filters the subject select by column verbose_name as well as column_name',
   expect(within(dropdown).getByText('total_count')).toBeInTheDocument();
   expect(within(dropdown).queryByText('Full Name')).not.toBeInTheDocument();
 });
-
-const COLUMN_VALUES_ENDPOINT =
-  'glob:*/api/v1/datasource/*/column/value/values/*';
-
-let columnValues: { result: unknown[]; limit: number } = {
-  result: [],
-  limit: 10000,
-};
-fetchMock.get(COLUMN_VALUES_ENDPOINT, () => columnValues);
-
-const setupWithFilterValues = (result: unknown[], limit = 10000) => {
-  columnValues = { result, limit };
-  const onChange = jest.fn();
-  const validHandler = jest.fn();
-  const spy = jest.spyOn(redux, 'useSelector');
-  spy.mockReturnValue({});
-  const props = {
-    adhocFilter: new AdhocFilter({
-      expressionType: ExpressionTypes.Simple,
-      subject: 'value',
-      operatorId: Operators.In,
-      operator: OPERATOR_ENUM_TO_OPERATOR_TYPE[Operators.In].operation,
-      comparator: [],
-      clause: Clauses.Where,
-    }),
-    onChange,
-    options,
-    datasource: {
-      ...TestDataset,
-      columns: [{ column_name: 'value', type: 'VARCHAR', id: 3 }],
-      filter_select: true,
-    },
-    partitionColumn: 'test',
-    validHandler,
-  };
-  render(
-    <AdhocFilterEditPopoverSimpleTabContent {...(props as unknown as Props)} />,
-  );
-  return props;
-};
-
-const openComparator = async () => {
-  const comparator = screen.getByRole('combobox', {
-    name: 'Comparator option',
-  });
-  userEvent.click(comparator);
-  return comparator;
-};
-
-test('loads comparator values from the server', async () => {
-  setupWithFilterValues(['alpha', 'beta']);
-  await openComparator();
-  expect(await screen.findByTitle('alpha')).toBeInTheDocument();
-});
-
-test('sends the typed text to the server rather than filtering the loaded page', async () => {
-  // The loaded page is bounded, so matching client-side cannot reach a value
-  // beyond the row limit. The search has to reach the database.
-  setupWithFilterValues(['alpha']);
-  const comparator = await openComparator();
-  userEvent.type(comparator, 'gamma');
-
-  await waitFor(
-    () => {
-      const searched = fetchMock.callHistory
-        .calls(COLUMN_VALUES_ENDPOINT)
-        .map(call => String(call.url));
-      expect(searched.some(url => url.includes('q=gamma'))).toBe(true);
-    },
-    { timeout: 3000 },
-  );
-});
-
-test('lets a value the server did not return still be selected', async () => {
-  // Even with server-side search a match can fall outside the page; typing the
-  // exact value has to remain a way through.
-  setupWithFilterValues([]);
-  const comparator = await openComparator();
-  userEvent.type(comparator, 'not-in-the-page');
-  expect(await screen.findByTitle('not-in-the-page')).toBeInTheDocument();
-});
-
-test('does not query for values when the dataset disables them', async () => {
-  fetchMock.clearHistory();
-  setup({
-    adhocFilter: new AdhocFilter({
-      expressionType: ExpressionTypes.Simple,
-      subject: 'value',
-      operatorId: Operators.In,
-      operator: OPERATOR_ENUM_TO_OPERATOR_TYPE[Operators.In].operation,
-      comparator: [],
-      clause: Clauses.Where,
-    }),
-  });
-  await openComparator();
-  expect(fetchMock.callHistory.calls(COLUMN_VALUES_ENDPOINT)).toHaveLength(0);
-});
-
-test('stores the picked value, not the option object', async () => {
-  // AsyncSelect is labelInValue: taking its argument at face value puts
-  // {label, value} into the comparator, and the engine then fails to render it
-  // as a literal.
-  const props = setupWithFilterValues(['Michael']);
-  await openComparator();
-  userEvent.click(await screen.findByTitle('Michael'));
-
-  await waitFor(() => expect(props.onChange).toHaveBeenCalled());
-  const [filter] = props.onChange.mock.calls.at(-1);
-  expect(filter.comparator).toEqual(['Michael']);
-});
-
-test('can remove a value that was saved earlier', async () => {
-  // Reopening the popover restores the comparator from the saved filter, and
-  // the value is not in the freshly loaded page. Removing it has to still work.
-  columnValues = { result: [], limit: 10000 };
-  const onChange = jest.fn();
-  const validHandler = jest.fn();
-  jest.spyOn(redux, 'useSelector').mockReturnValue({});
-  render(
-    <AdhocFilterEditPopoverSimpleTabContent
-      {...({
-        adhocFilter: new AdhocFilter({
-          expressionType: ExpressionTypes.Simple,
-          subject: 'value',
-          operatorId: Operators.In,
-          operator: OPERATOR_ENUM_TO_OPERATOR_TYPE[Operators.In].operation,
-          comparator: ['Michael'],
-          clause: Clauses.Where,
-        }),
-        onChange,
-        options,
-        datasource: {
-          ...TestDataset,
-          columns: [{ column_name: 'value', type: 'VARCHAR', id: 3 }],
-          filter_select: true,
-        },
-        partitionColumn: 'test',
-        validHandler,
-      } as unknown as Props)}
-    />,
-  );
-
-  // Remove it the way a user does: the tag's own close control.
-  userEvent.click(await screen.findByLabelText('close'));
-
-  await waitFor(() => expect(onChange).toHaveBeenCalled());
-  const [filter] = onChange.mock.calls.at(-1);
-  expect(filter.comparator).toEqual([]);
-});
-
-test('says the list is partial when the server capped it', async () => {
-  setupWithFilterValues(['alpha', 'beta'], 2);
-  await openComparator();
-  expect(
-    await screen.findByText(/Only the first 2 values are listed/),
-  ).toBeInTheDocument();
-});
-
-test('does not say the list is partial when it is complete', async () => {
-  setupWithFilterValues(['alpha', 'beta'], 10000);
-  await openComparator();
-  expect(await screen.findByTitle('alpha')).toBeInTheDocument();
-  expect(screen.queryByText(/Only the first/)).not.toBeInTheDocument();
-});

superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.tsx

@@ -16,25 +16,13 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import {
-  FC,
-  ChangeEvent,
-  useCallback,
-  useEffect,
-  useMemo,
-  useState,
-  useRef,
-} from 'react';
+import { FC, ChangeEvent, useEffect, useState, useRef } from 'react';
 
 import {
-  AsyncSelect,
   Input,
   InputRef,
   Select,
   Tooltip,
-  type AsyncSelectRef,
-  type LabeledValue,
-  type SelectOptionsTypePage,
   type SelectValue,
 } from '@superset-ui/core/components';
 import { t } from '@apache-superset/core/translation';
@@ -69,7 +57,7 @@ import { useDatePickerInAdhocFilter } from '../utils';
 import { useDefaultTimeFilter } from '../../DateFilterControl/utils';
 import { Clauses, ExpressionTypes } from '../types';
 
-const SelectWithLabel = styled(AsyncSelect)<{ labelText: string }>`
+const SelectWithLabel = styled(Select)<{ labelText: string }>`
   .ant-select-content::after {
     content: ${({ labelText }) => labelText || '\\A0'};
     display: inline-block;
@@ -79,30 +67,6 @@ const SelectWithLabel = styled(AsyncSelect)<{ labelText: string }>`
   }
 `;
 
-// The server answers with one bounded page, not an offset window: paging would
-// need a stable ORDER BY, and ordering a high-cardinality column is the full
-// scan this search exists to avoid. A page size no response can reach keeps
-// AsyncSelect from asking for a second page.
-const COMPARATOR_PAGE_SIZE = 1_000_000;
-
-const toLabeledValue = (value: unknown): LabeledValue => ({
-  value: value as LabeledValue['value'],
-  label: optionLabel(value as null | number | boolean | string),
-});
-
-// The reverse of toLabeledValue: what AsyncSelect emits is labelled, and the
-// comparator has to be the raw value or the engine cannot render it as a
-// literal.
-const unwrapComparator = (value: unknown): unknown => {
-  if (Array.isArray(value)) {
-    return value.map(unwrapComparator);
-  }
-  if (value !== null && typeof value === 'object' && 'value' in value) {
-    return (value as LabeledValue).value;
-  }
-  return value;
-};
-
 export interface SimpleExpressionType {
   expressionType: keyof typeof ExpressionTypes;
   column: ColumnMeta;
@@ -383,9 +347,11 @@ const AdhocFilterEditPopoverSimpleTabContent: FC<Props> = props => {
   } = useSimpleTabFilterProps(props);
   const [comparator, setComparator] = useState(props.adhocFilter.comparator);
   const comparatorInputRef = useRef<InputRef | null>(null);
-  const comparatorSelectRef = useRef<AsyncSelectRef>(null);
-  const [loadedOptionCount, setLoadedOptionCount] = useState(0);
-  const [optionsTruncated, setOptionsTruncated] = useState(false);
+  const [suggestions, setSuggestions] = useState<
+    Record<'label' | 'value', any>[]
+  >([]);
+  const [loadingComparatorSuggestions, setLoadingComparatorSuggestions] =
+    useState<boolean>(false);
   const [hasFocusedComparator, setHasFocusedComparator] =
     useState<boolean>(false);
 
@@ -421,8 +387,18 @@ const AdhocFilterEditPopoverSimpleTabContent: FC<Props> = props => {
     />
   );
 
-  const createSuggestionsPlaceholder = () =>
-    loadedOptionCount ? t('%s option(s)', loadedOptionCount) : '';
+  const getOptionsRemaining = () => {
+    // if select is multi/value is array, we show the options not selected
+    const valuesFromSuggestionsLength = Array.isArray(comparator)
+      ? comparator.filter(v => suggestions.includes(v)).length
+      : 0;
+    return suggestions ? suggestions.length - valuesFromSuggestionsLength : 0;
+  };
+  const createSuggestionsPlaceholder = () => {
+    const optionsRemaining = getOptionsRemaining();
+    const placeholder = t('%s option(s)', optionsRemaining);
+    return optionsRemaining ? placeholder : '';
+  };
 
   const handleSubjectChange = (subject: string) => {
     setComparator(undefined);
@@ -479,63 +455,21 @@ const AdhocFilterEditPopoverSimpleTabContent: FC<Props> = props => {
     operatorId !== undefined &&
     DISABLE_INPUT_OPERATORS.includes(operatorId as Operators);
 
-  const canSuggestComparatorValues = Boolean(
-    subjectString &&
-    props.datasource?.filter_select &&
-    props.adhocFilter.clause !== Clauses.Having,
-  );
-
   const hasComparatorOptions =
     (operatorId && MULTI_OPERATORS.has(operatorId as Operators)) ||
-    canSuggestComparatorValues;
-
-  // AsyncSelect is labelInValue, so the value it is given has to be labelled
-  // too. Handed a bare value it still renders, but `handleOnDeselect` then
-  // compares `element.value` against entries that have no `.value`, matches
-  // nothing, and the tag cannot be removed.
-  //
-  // Memoised because AsyncSelect resets its internal selection whenever the
-  // identity of `value` changes. A fresh array every render would wipe out
-  // each pick as soon as it was made.
-  const comparatorSelectValue = useMemo(
-    () =>
-      Array.isArray(comparator)
-        ? comparator.map(toLabeledValue)
-        : isDefined(comparator) && comparator !== ''
-          ? toLabeledValue(comparator)
-          : undefined,
-    [comparator],
-  );
-
-  const handleComparatorChange = useCallback(
-    (value: unknown) => {
-      onComparatorChange(unwrapComparator(value) as string);
-    },
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-    [props.adhocFilter, props.onChange],
-  );
+    suggestions.length > 0;
 
   const comparatorSelectProps = {
     allowClear: true,
     allowNewOptions: true,
     ariaLabel: t('Comparator option'),
-    pageSize: COMPARATOR_PAGE_SIZE,
-    // A capped list reads as the whole set unless it says otherwise, so an
-    // absent value looks like a value that does not exist. Only shown when the
-    // list is actually cut short.
-    helperText: optionsTruncated
-      ? t(
-          'Only the first %s values are listed. Type to search all of them, ' +
-            'or enter a value that is not listed.',
-          loadedOptionCount,
-        )
-      : undefined,
     mode:
       operatorId && MULTI_OPERATORS.has(operatorId as Operators)
         ? ('multiple' as const)
         : ('single' as const),
-    value: comparatorSelectValue as SelectValue,
-    onChange: handleComparatorChange,
+    loading: loadingComparatorSuggestions,
+    value: comparator as SelectValue,
+    onChange: onComparatorChange,
     notFoundContent: t('Type a value here'),
     placeholder: createSuggestionsPlaceholder(),
   };
@@ -561,89 +495,76 @@ const AdhocFilterEditPopoverSimpleTabContent: FC<Props> = props => {
     onChange: onDatePickerChange,
   });
 
-  // Element-level array operators (Contains any / Contains all) search inside
-  // the array, so suggest individual elements; whole-array operators (=, In, …)
-  // keep the default distinct-array suggestions.
-  const arrayElements =
-    props.adhocFilter.operatorId === Operators.ContainsAny ||
-    props.adhocFilter.operatorId === Operators.ContainsAll;
-
-  // AsyncSelect throws away every loaded option when the identity of its
-  // `options` callback changes, so this depends on plain values rather than on
-  // `props.datasource`, whose identity the parent does not guarantee.
-  const datasourceType = props.datasource?.type;
-  const datasourceId = props.datasource?.id;
-
-  const loadComparatorOptions = useCallback(
-    async (search: string): Promise<SelectOptionsTypePage> => {
-      const col = subjectString;
-      if (!col || !canSuggestComparatorValues) {
-        return { data: [], totalCount: 0 };
-      }
-
-      const params = new URLSearchParams();
-      if (arrayElements) {
-        params.set('array_elements', 'true');
-      }
-      if (search) {
-        params.set('q', search);
-      }
-      const query = params.toString();
-
-      try {
-        const { json } = await SupersetClient.get({
-          endpoint:
-            `/api/v1/datasource/${datasourceType}/${datasourceId}` +
-            `/column/${encodeURIComponent(col)}/values/${query ? `?${query}` : ''}`,
-        });
-        const data = json.result.map((suggestion: unknown) => {
-          // Complex column values arrive as JS arrays or objects: whole arrays
-          // for MULTI_VALUE columns (e.g. [5, 6, 7]) and Map/Tuple objects for
-          // nested-container columns (e.g. {"a": ["x","y"]}). A raw
-          // array/object is neither a valid single-select value (antd collapses
-          // an array to its first element) nor renderable as a React child (an
-          // object throws). Render it as its literal string, which is also
-          // exactly what the backend's parse_array_literal expects for the
-          // whole-array operators.
-          if (suggestion !== null && typeof suggestion === 'object') {
-            const literal = JSON.stringify(suggestion);
-            return { value: literal, label: literal };
-          }
-          return {
-            value: suggestion as null | number | boolean | string,
-            label: optionLabel(suggestion as null | number | boolean | string),
-          };
-        });
-
-        setLoadedOptionCount(data.length);
-        setOptionsTruncated(isDefined(json.limit) && data.length >= json.limit);
-
-        // The count has to exceed what was returned. AsyncSelect treats
-        // `loaded >= totalCount` as "that is every value", sets allValuesLoaded
-        // and from then on serves searches by filtering the loaded page
-        // client-side -- which is the behaviour this whole change exists to
-        // replace. Pagination is held off by COMPARATOR_PAGE_SIZE instead.
-        return { data, totalCount: data.length + 1 };
-      } catch {
-        setLoadedOptionCount(0);
-        setOptionsTruncated(false);
-        return { data: [], totalCount: 0 };
-      }
-    },
-    [
-      subjectString,
-      canSuggestComparatorValues,
-      datasourceType,
-      datasourceId,
-      arrayElements,
-    ],
-  );
-
-  // Options are cached per search term inside AsyncSelect; a different column
-  // or a switch to element-level suggestions invalidates all of them.
   useEffect(() => {
-    comparatorSelectRef.current?.clearCache();
-  }, [subjectString, arrayElements]);
+    const refreshComparatorSuggestions = () => {
+      const { datasource } = props;
+      const col = props.adhocFilter.subject;
+      const having = props.adhocFilter.clause === Clauses.Having;
+
+      if (col && datasource && datasource.filter_select && !having) {
+        const controller = new AbortController();
+        const { signal } = controller;
+        if (loadingComparatorSuggestions) {
+          controller.abort();
+        }
+        // Element-level array operators (Contains any / Contains all) search
+        // inside the array, so suggest individual elements; whole-array
+        // operators (=, In, …) keep the default distinct-array suggestions.
+        const { operatorId } = props.adhocFilter;
+        const arrayElements =
+          operatorId === Operators.ContainsAny ||
+          operatorId === Operators.ContainsAll;
+        setLoadingComparatorSuggestions(true);
+        SupersetClient.get({
+          signal,
+          endpoint: `/api/v1/datasource/${datasource.type}/${datasource.id}/column/${col}/values/${
+            arrayElements ? '?array_elements=true' : ''
+          }`,
+        })
+          .then(({ json }) => {
+            setSuggestions(
+              json.result.map((suggestion: unknown) => {
+                // Complex column values arrive as JS arrays or objects: whole
+                // arrays for MULTI_VALUE columns (e.g. [5, 6, 7]) and Map/Tuple
+                // objects for nested-container columns (e.g. {"a": ["x","y"]}).
+                // A raw array/object is neither a valid single-select value
+                // (antd collapses an array to its first element) nor renderable
+                // as a React child (an object throws). Render it as its literal
+                // string, which is also exactly what the backend's
+                // parse_array_literal expects for the whole-array operators.
+                if (suggestion !== null && typeof suggestion === 'object') {
+                  const literal = JSON.stringify(suggestion);
+                  return { value: literal, label: literal };
+                }
+                return {
+                  value: suggestion as null | number | boolean | string,
+                  label: optionLabel(
+                    suggestion as null | number | boolean | string,
+                  ),
+                };
+              }),
+            );
+            setLoadingComparatorSuggestions(false);
+          })
+          .catch(() => {
+            setSuggestions([]);
+            setLoadingComparatorSuggestions(false);
+          });
+      }
+    };
+
+    if (!datePicker) {
+      refreshComparatorSuggestions();
+    }
+    // loadingComparatorSuggestions intentionally omitted - set inside effect, would cause infinite loop
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [
+    props.adhocFilter.subject,
+    props.adhocFilter.clause,
+    props.adhocFilter.operatorId,
+    props.datasource,
+    datePicker,
+  ]);
 
   useEffect(() => {
     if (isFeatureEnabled(FeatureFlag.EnableAdvancedDataTypes)) {
@@ -749,12 +670,11 @@ const AdhocFilterEditPopoverSimpleTabContent: FC<Props> = props => {
             }
           >
             <SelectWithLabel
-              ref={comparatorSelectRef}
               css={css`
                 margin-top: ${theme.marginXS}px;
               `}
               labelText={labelText}
-              options={loadComparatorOptions}
+              options={suggestions}
               {...comparatorSelectProps}
             />
           </Tooltip>

superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx

@@ -16,12 +16,10 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { useCallback, useState } from 'react';
 import {
   AppSection,
   Behavior,
   ChartProps,
-  type DataMask,
   type FilterState,
 } from '@superset-ui/core';
 import { supersetTheme } from '@apache-superset/core/theme';
@@ -879,41 +877,10 @@ describe('SelectFilterPlugin', () => {
     expect(await screen.findByTitle('brand-new')).toBeInTheDocument();
   });
 
-  test('says the list is capped when it hits the row limit', async () => {
-    // 3 rows of data against a limit of 3: the user is looking at a page, not
-    // at every value the column has.
-    getWrapper({ rowLimit: 3 });
-    userEvent.click(screen.getAllByRole('combobox')[0]);
-    expect(
-      await screen.findByText(/Only the first 3 values are listed/),
-    ).toBeInTheDocument();
-  });
-
-  test('offers the ways out that the filter actually supports', async () => {
-    getWrapper({ rowLimit: 3, creatable: true, searchAllOptions: true });
-    userEvent.click(screen.getAllByRole('combobox')[0]);
-    expect(
-      await screen.findByText(/Type to search all of them/),
-    ).toBeInTheDocument();
-    expect(
-      screen.getByText(/You can enter a value that is not listed/),
-    ).toBeInTheDocument();
-  });
-
-  test('says nothing when the whole column fits under the limit', async () => {
-    getWrapper();
-    userEvent.click(screen.getAllByRole('combobox')[0]);
-    expect(await screen.findByRole('combobox')).toBeInTheDocument();
-    expect(screen.queryByText(/Only the first/)).not.toBeInTheDocument();
-  });
-
-  test('shows create option when searchAllOptions is true', async () => {
-    // Server-side search returns a bounded page, so a value that exists in the
-    // data can still be missing from the dropdown. Suppressing the create
-    // option there leaves the user with no way to apply it at all.
+  test('does not show create option when searchAllOptions is true', () => {
     getWrapper({ creatable: true, searchAllOptions: true });
     userEvent.type(screen.getByRole('combobox'), 'brand-new');
-    expect(await screen.findByTitle('brand-new')).toBeInTheDocument();
+    expect(screen.queryByTitle('brand-new')).not.toBeInTheDocument();
   });
 });
 
@@ -1426,153 +1393,6 @@ test('preserves dependent filter value restored from URL when it exists in data'
   });
 });
 
-test('keeps a dependent filter empty after the user clears it', async () => {
-  // Regression: a dependent filter with "Select first filter value by default"
-  // used to re-apply the first option as soon as the cleared value round-tripped
-  // through the filter bar, making it impossible to clear.
-  jest.useRealTimers();
-  const setDataMaskMock = jest.fn();
-  const testProps = {
-    ...selectMultipleProps,
-    formData: {
-      ...selectMultipleProps.formData,
-      multiSelect: false,
-      enableEmptyFilter: false,
-      defaultToFirstItem: true,
-      // Non-empty extraFormData is what marks this filter as dependent
-      extraFormData: {
-        filters: [{ col: 'region', op: 'IN', val: ['North America'] }],
-      },
-    },
-  };
-
-  // The filter bar feeds every dispatched dataMask back into the plugin as the
-  // controlled `filterState` prop; the harness reproduces that round-trip.
-  const ControlledSelectFilter = () => {
-    const [filterState, setFilterState] = useState<FilterState>({
-      value: ['boy'],
-    });
-    const handleDataMask = useCallback((dataMask: DataMask) => {
-      setDataMaskMock(dataMask);
-      setFilterState(prev => ({ ...prev, ...dataMask.filterState }));
-    }, []);
-    return (
-      // @ts-expect-error
-      <SelectFilterPlugin
-        // @ts-expect-error
-        {...transformProps({ ...testProps, filterState })}
-        setDataMask={handleDataMask}
-        showOverflow={false}
-      />
-    );
-  };
-
-  render(<ControlledSelectFilter />, {
-    useRedux: true,
-    initialState: {
-      nativeFilters: {
-        filters: {
-          'test-filter': {
-            name: 'Test Filter',
-          },
-        },
-      },
-      dataMask: {
-        'test-filter': {
-          extraFormData: {},
-          filterState: { value: ['boy'] },
-        },
-      },
-    },
-  });
-
-  userEvent.click(
-    screen.getByRole('img', {
-      name: /close-circle/i,
-      hidden: true,
-    }),
-  );
-
-  await waitFor(() =>
-    expect(setDataMaskMock).toHaveBeenLastCalledWith(
-      expect.objectContaining({
-        extraFormData: {},
-        filterState: expect.objectContaining({ value: null }),
-      }),
-    ),
-  );
-
-  // Let the re-validation effects settle: the value must not come back
-  await act(async () => {
-    await Promise.resolve();
-  });
-  expect(setDataMaskMock).toHaveBeenLastCalledWith(
-    expect.objectContaining({
-      filterState: expect.objectContaining({ value: null }),
-    }),
-  );
-  expect(screen.queryByTitle('boy')).not.toBeInTheDocument();
-});
-
-test('keeps a dependent filter empty when it mounts with a cleared value', async () => {
-  // Regression: after a reload the cleared state comes back as `value: null` on
-  // a fresh component, so the in-memory "user cleared this" ref is gone. The
-  // first item must still not be re-applied.
-  const setDataMaskMock = jest.fn();
-  const testProps = {
-    ...selectMultipleProps,
-    formData: {
-      ...selectMultipleProps.formData,
-      multiSelect: false,
-      enableEmptyFilter: false,
-      defaultToFirstItem: true,
-      extraFormData: {
-        filters: [{ col: 'region', op: 'IN', val: ['North America'] }],
-      },
-    },
-    filterState: { value: null },
-  };
-
-  render(
-    // @ts-expect-error
-    <SelectFilterPlugin
-      // @ts-expect-error
-      {...transformProps(testProps)}
-      setDataMask={setDataMaskMock}
-      showOverflow={false}
-    />,
-    {
-      useRedux: true,
-      initialState: {
-        nativeFilters: {
-          filters: {
-            'test-filter': {
-              name: 'Test Filter',
-            },
-          },
-        },
-        dataMask: {
-          'test-filter': {
-            extraFormData: {},
-            filterState: { value: null },
-          },
-        },
-      },
-    },
-  );
-
-  // Let the re-validation effect run before asserting it did nothing
-  await act(async () => {
-    await Promise.resolve();
-  });
-  expect(setDataMaskMock).toHaveBeenCalled();
-  expect(setDataMaskMock).not.toHaveBeenCalledWith(
-    expect.objectContaining({
-      filterState: expect.objectContaining({ value: ['boy'] }),
-    }),
-  );
-});
-
 test('resets dependent filter to first item when value does not exist in data', async () => {
   const setDataMaskMock = jest.fn();
   const testProps = {

superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx

@@ -157,6 +157,7 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
   const [col] = groupby;
   const [initialColtypeMap] = useState(coltypeMap);
   const [search, setSearch] = useState('');
+  const prevDataRef = useRef(data);
   const userClearedRef = useRef(false);
   const [dataMask, dispatchDataMask] = useImmerReducer(reducer, {
     extraFormData: {},
@@ -271,10 +272,7 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
             type: 'ownState',
             ownState: {
               coltypeMap: initialColtypeMap,
-              // The dropdown offers `stripSurroundingQuotes(search)` as the
-              // creatable option, so the server has to be asked for the same
-              // string or the two disagree about what was searched for.
-              search: stripSurroundingQuotes(search).trim(),
+              search,
             },
           });
         }
@@ -284,10 +282,8 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
 
   const handleBlur = useCallback(() => {
     unsetFocusedFilter();
-    if (search) {
-      onSearch('');
-    }
-  }, [onSearch, search, unsetFocusedFilter]);
+    onSearch('');
+  }, [onSearch, unsetFocusedFilter]);
 
   const handleChange = useCallback(
     (value?: SelectValue | number | string) => {
@@ -309,25 +305,6 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
       ? t('No data')
       : tn('%s option', '%s options', data.length, data.length);
 
-  // A capped list reads as the whole set, so a value sitting past the row
-  // limit looks like a value that does not exist. Each sentence is only added
-  // when it is actually true of this filter's configuration.
-  const rowLimit = Number(formData.rowLimit) || 0;
-  const helperText = useMemo(() => {
-    if (!rowLimit || data.length < rowLimit) {
-      return undefined;
-    }
-    return [
-      t('Only the first %s values are listed.', data.length),
-      searchAllOptions ? t('Type to search all of them.') : undefined,
-      creatable !== false
-        ? t('You can enter a value that is not listed.')
-        : undefined,
-    ]
-      .filter(Boolean)
-      .join(' ');
-  }, [creatable, data.length, rowLimit, searchAllOptions]);
-
   const formItemExtra = useMemo(() => {
     if (filterState.validateMessage) {
       return (
@@ -360,6 +337,7 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
     const unquotedSearch = stripSurroundingQuotes(search);
     if (
       unquotedSearch &&
+      !searchAllOptions &&
       creatable !== false &&
       !hasOption(unquotedSearch, uniqueOptions, true)
     ) {
@@ -369,7 +347,7 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
       ];
     }
     return uniqueOptions;
-  }, [search, uniqueOptions, creatable]);
+  }, [search, uniqueOptions, creatable, searchAllOptions]);
 
   const sortComparator = useCallback(
     (a: LabeledValue, b: LabeledValue) => {
@@ -452,6 +430,26 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
     clearAllTrigger,
   ]);
 
+  useEffect(() => {
+    const prev = prevDataRef.current;
+    const curr = data;
+
+    const hasDataChanged =
+      prev?.length !== curr?.length ||
+      prev?.some((row, i) => {
+        const prevVal = row[col];
+        const currVal = curr[i][col];
+        return typeof prevVal === 'bigint' || typeof currVal === 'bigint'
+          ? prevVal?.toString() !== currVal?.toString()
+          : prevVal !== currVal;
+      });
+
+    // If data actually changed (e.g., due to parent filter), reset flag
+    if (hasDataChanged) {
+      prevDataRef.current = data;
+    }
+  }, [data, col]);
+
   useEffect(() => {
     if (
       filterState.value?.every((value?: any) =>
@@ -464,17 +462,13 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
       ? (groupby.map(col => data[0][col]) as string[])
       : null;
 
-    // Skip default value update when clearAllTrigger is active.
-    // `null` is a persisted "user cleared this" state, as opposed to
-    // `undefined` for "never set", so it must not be re-defaulted either —
-    // `userClearedRef` alone would not survive a reload.
+    // Skip default value update when clearAllTrigger is active
     if (
       !clearAllTrigger &&
       defaultToFirstItem &&
       !userClearedRef.current &&
       Object.keys(formData?.extraFormData || {}).length &&
       filterState.value !== undefined &&
-      filterState.value !== null &&
       firstItem !== null &&
       filterState.value !== firstItem
     ) {
@@ -640,7 +634,7 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
               name={formData.nativeFilterId}
               allowClear
               autoClearSearchValue
-              allowNewOptions={creatable !== false}
+              allowNewOptions={!searchAllOptions && creatable !== false}
               allowNewOptionsOnPaste={multiSelect && searchAllOptions}
               allowSelectAll={!searchAllOptions}
               value={multiSelect ? filterState.value || [] : filterState.value}
@@ -649,7 +643,6 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
               showSearch={showSearch}
               mode={multiSelect ? 'multiple' : 'single'}
               placeholder={placeholderText}
-              helperText={helperText}
               onClear={() => onSearch('')}
               onSearch={onSearch}
               onBlur={handleBlur}

superset-frontend/src/filters/components/Select/buildQuery.test.ts

@@ -117,38 +117,6 @@ describe('Select buildQuery', () => {
     ]);
   });
 
-  test('should not sort by the searched column', () => {
-    // Ordering by a high-cardinality column makes the engine sort every match
-    // before applying the row limit; the dropdown re-sorts the page anyway.
-    const queryContext = buildQuery(
-      { ...formData, sortAscending: true },
-      {
-        ownState: {
-          search: 'abc',
-          coltypeMap: { my_col: GenericDataType.String },
-        },
-      },
-    );
-    const [query] = queryContext.queries;
-    expect(query.orderby).toEqual([]);
-  });
-
-  test('should keep the sort metric while searching', () => {
-    // A sort metric decides which rows come back, so dropping it would change
-    // the result set rather than just its order.
-    const queryContext = buildQuery(
-      { ...formData, sortMetric: 'my_metric', sortAscending: false },
-      {
-        ownState: {
-          search: 'abc',
-          coltypeMap: { my_col: GenericDataType.String },
-        },
-      },
-    );
-    const [query] = queryContext.queries;
-    expect(query.orderby).toEqual([['my_metric', false]]);
-  });
-
   test('should add text search parameter for numeric to query filter', () => {
     const queryContext = buildQuery(formData, {
       ownState: {

superset-frontend/src/filters/components/Select/buildQuery.ts

@@ -54,13 +54,6 @@ const buildQuery: BuildQuery<PluginFilterSelectQueryFormData> = (
     }
 
     const sortColumns = sortMetric ? [sortMetric] : columns;
-    // Sorting by the searched column makes the engine scan and sort every
-    // match before applying the row limit, which is the dominant cost of
-    // search-as-you-type on a high-cardinality column. The dropdown re-sorts
-    // the returned page client-side, so the server sort buys nothing here. A
-    // sort metric is different: it selects *which* rows come back, so it has
-    // to stay.
-    const skipOrderBy = !!search && !sortMetric;
     const query: QueryObject[] = [
       {
         ...baseQueryObject,
@@ -68,7 +61,7 @@ const buildQuery: BuildQuery<PluginFilterSelectQueryFormData> = (
         metrics: sortMetric ? [sortMetric] : [],
         filters: filters.concat(extraFilters),
         orderby:
-          !skipOrderBy && (sortMetric || sortAscending !== undefined)
+          sortMetric || sortAscending !== undefined
             ? sortColumns.map(column => [column, !!sortAscending])
             : [],
       },

superset-websocket/.npmrc

@@ -1 +0,0 @@
-../superset-frontend/.npmrc

superset/charts/data/api.py

@@ -585,17 +585,8 @@ class ChartDataRestApi(ChartRestApi):
                     query["timing"] = query_result.timing.as_public_dict()
 
             if security_manager.is_guest_user():
-                # Guests may see the generated SQL only when the role attached to
-                # their guest token has been granted "can view query on Dashboard",
-                # mirroring the permission the frontend uses to expose the
-                # "View query" action. Stacktraces and driver errors stay redacted
-                # regardless, as those leak details of the deployment itself.
-                can_view_query = security_manager.can_access(
-                    "can_view_query", "Dashboard"
-                )
                 for query in queries:
-                    if not can_view_query:
-                        query.pop("query", None)
+                    query.pop("query", None)
                     query.pop("stacktrace", None)
                     if query.get("error"):
                         query["error"] = sanitize_error_message(query["error"])

superset/cli/viz_migrations.py

@@ -160,7 +160,7 @@ def migrate_by_id(ids: tuple[int, ...], is_downgrade: bool = False) -> None:
     """
     Migrate a subset of charts by IDs.
 
-    :param ids: Tuple of chart IDs to migrate
+    :param id: Tuple of chart IDs to migrate
     :param is_downgrade: Whether to downgrade the charts. Default is upgrade.
     """
     slices = db.session.query(Slice).filter(Slice.id.in_(ids))

superset/commands/chart/export.py

@@ -91,10 +91,8 @@ class ExportChartsCommand(ExportModelsCommand):
     def enable_tag_export(cls) -> None:
         cls._include_tags = True
 
-    def run(
-        self, seen: set[str] | None = None
-    ) -> Iterator[tuple[str, Callable[[], str]]]:
-        yield from super().run(seen=seen)
+    def run(self) -> Iterator[tuple[str, Callable[[], str]]]:
+        yield from super().run()
 
         # Tags are exported once for all requested charts (rather than per
         # chart in `_export`) so a multi-chart export doesn't lose tags to
@@ -110,17 +108,12 @@ class ExportChartsCommand(ExportModelsCommand):
 
     @staticmethod
     def _export(
-        model: Slice, export_related: bool = True, seen: set[str] | None = None
+        model: Slice, export_related: bool = True
     ) -> Iterator[tuple[str, Callable[[], str]]]:
-        # Initialize seen set if not provided
-        if seen is None:
-            seen = set()
-
         yield (
             ExportChartsCommand._file_name(model),
             lambda: ExportChartsCommand._file_content(model),
         )
 
         if model.table and export_related:
-            # Pass the shared seen set to the dataset export command
-            yield from ExportDatasetsCommand([model.table.id]).run(seen=seen)
+            yield from ExportDatasetsCommand([model.table.id]).run()

superset/commands/dashboard/export.py

@@ -383,12 +383,8 @@ class ExportDashboardsCommand(ExportModelsCommand):
     @staticmethod
     # ruff: noqa: C901
     def _export(
-        model: Dashboard, export_related: bool = True, seen: set[str] | None = None
+        model: Dashboard, export_related: bool = True
     ) -> Iterator[tuple[str, Callable[[], str]]]:
-        # Initialize seen set if not provided
-        if seen is None:
-            seen = set()
-
         yield (
             ExportDashboardsCommand._file_name(model),
             lambda: ExportDashboardsCommand._file_content(model),
@@ -399,11 +395,8 @@ class ExportDashboardsCommand(ExportModelsCommand):
             dashboard_ids = model.id
             command = ExportChartsCommand(chart_ids)
             command.disable_tag_export()
-            try:
-                # Pass the shared seen set to the chart export command
-                yield from command.run(seen=seen)
-            finally:
-                command.enable_tag_export()
+            yield from command.run()
+            command.enable_tag_export()
             if feature_flag_manager.is_feature_enabled("TAGGING_SYSTEM"):
                 yield from ExportTagsCommand(
                     dashboard_ids=dashboard_ids, chart_ids=chart_ids
@@ -413,8 +406,7 @@ class ExportDashboardsCommand(ExportModelsCommand):
             if model.theme:
                 from superset.commands.theme.export import ExportThemesCommand
 
-                # Pass the shared seen set to the theme export command
-                yield from ExportThemesCommand([model.theme.id]).run(seen=seen)
+                yield from ExportThemesCommand([model.theme.id]).run()
 
         payload = model.export_to_dict(
             recursive=False,
@@ -443,10 +435,7 @@ class ExportDashboardsCommand(ExportModelsCommand):
                     if dataset_id is not None:
                         dataset = DatasetDAO.find_by_id(dataset_id)
                         if dataset:
-                            # Pass the shared seen set to the dataset export command
-                            yield from ExportDatasetsCommand([dataset_id]).run(
-                                seen=seen
-                            )
+                            yield from ExportDatasetsCommand([dataset_id]).run()
 
             # Export datasets referenced by display controls
             for customization in (
@@ -457,7 +446,4 @@ class ExportDashboardsCommand(ExportModelsCommand):
                     if dataset_id is not None:
                         dataset = DatasetDAO.find_by_id(dataset_id)
                         if dataset:
-                            # Pass the shared seen set to the dataset export command
-                            yield from ExportDatasetsCommand([dataset_id]).run(
-                                seen=seen
-                            )
+                            yield from ExportDatasetsCommand([dataset_id]).run()

superset/commands/database/export.py

@@ -113,12 +113,8 @@ class ExportDatabasesCommand(ExportModelsCommand):
 
     @staticmethod
     def _export(
-        model: Database, export_related: bool = True, seen: set[str] | None = None
+        model: Database, export_related: bool = True
     ) -> Iterator[tuple[str, Callable[[], str]]]:
-        # Initialize seen set if not provided
-        if seen is None:
-            seen = set()
-
         yield (
             ExportDatabasesCommand._file_name(model),
             lambda: ExportDatabasesCommand._file_content(model),

superset/commands/database/uploaders/base.py

@@ -219,8 +219,6 @@ class UploadCommand(BaseCommand):
                 database_id=self._model_id,
                 editors=editors,
                 schema=self._schema,
-                # Ensure catalog is set
-                catalog=self._model.get_default_catalog(),
             )
             db.session.add(sqla_table)