fix(explore): stop dashboard permalink key from leaking into chart URL

RESERVED_CHART_URL_PARAMS was missing permalink_key while the analogous RESERVED_DASHBOARD_URL_PARAMS already excluded it. This asymmetry let a dashboard permalink's permalink_key, merged into a chart's form_data via a shared cache keyed only by sliceId, get copied into the chart's own Explore URL when opened from a dashboard. On refresh, Explore forwarded that dashboard-salted key to the explore permalink resolver, which fails key decoding against the wrong salt and falls back to a stub datasource, producing the "missing datasource" error. Add permalink_key to RESERVED_CHART_URL_PARAMS, mirroring the pattern already used correctly on the dashboard side and in FilterBar's EXCLUDED_URL_PARAMS. As an accepted side effect, this also makes Explore's own permalink key (/explore/p/<key>/) drop out of the URL after refresh instead of staying sticky, matching FilterBar's existing behavior for dashboards. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-20 15:11:18 +00:00 · 2026-08-20 05:06:22 +00:00
2 changed files with 32 additions and 0 deletions
@@ -0,0 +1,31 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import {
+  URL_PARAMS,
+  RESERVED_CHART_URL_PARAMS,
+  RESERVED_DASHBOARD_URL_PARAMS,
+} from 'src/constants';
+
+test('permalinkKey is reserved on both the chart and dashboard URL param lists', () => {
+  // Dashboard and explore permalinks resolve against different backend
+  // KV resources/salts, so a key from one must never leak into the other's
+  // URL via the reserved-params passthrough logic.
+  expect(RESERVED_DASHBOARD_URL_PARAMS).toContain(URL_PARAMS.permalinkKey.name);
+  expect(RESERVED_CHART_URL_PARAMS).toContain(URL_PARAMS.permalinkKey.name);
+});
@@ -123,6 +123,7 @@ export const RESERVED_CHART_URL_PARAMS: string[] = [
  URL_PARAMS.datasourceId.name,
  URL_PARAMS.datasourceType.name,
  URL_PARAMS.datasetId.name,
+  URL_PARAMS.permalinkKey.name,
  URL_PARAMS.versionHistory.name,
 ];
 export const RESERVED_DASHBOARD_URL_PARAMS: string[] = [