fix(plugin-chart-ag-grid-table): keep basic conditional formatting aligned after sort (#105973)

The basic (increase/decrease) color formatters were built in the original
query order and read positionally by the displayed AG Grid rowIndex. Once the
table was sorted client-side, the displayed index no longer matched the data
order, so the green/red background and arrow indicators were applied to the
wrong rows.

Attach each row's formatter to its row data object (non-enumerable, so it never
leaks into exports/cross-filters) so it travels with the row through sorting,
and resolve it via getRowBasicColorFormatter in both getCellStyle and
NumericCellRenderer, falling back to the positional lookup. Add unit tests.

.github/CODEOWNERS

@@ -38,7 +38,7 @@
 
 # Notify translation maintainers of changes to translations
 
-/superset/translations/ @sfirke @rusackas @villebro @sadpandajoe @hainenber
+/superset/translations/ @sfirke @rusackas
 
 # Notify PMC members of changes to extension-related files
 

.github/actions/setup-backend/action.yml

@@ -42,7 +42,7 @@ runs:
         fi
         echo "python-version=$RESOLVED_VERSION" >> "$GITHUB_OUTPUT"
     - name: Set up Python ${{ steps.set-python-version.outputs.python-version }}
-      uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
+      uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
       with:
         python-version: ${{ steps.set-python-version.outputs.python-version }}
         cache: ${{ inputs.cache }}

.github/workflows/bump-python-package.yml

@@ -40,7 +40,7 @@ jobs:
         uses: ./.github/actions/setup-supersetbot/
 
       - name: Set up Python ${{ inputs.python-version }}
-        uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
+        uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
         with:
           python-version: "3.10"
 

.github/workflows/scheduled-docker-image-refresh.yml

@@ -1,177 +0,0 @@
-name: Scheduled Docker image refresh
-
-# Re-runs the Docker image build against the latest published release on a
-# weekly cadence. The code being built doesn't change — but the base image
-# layers (python:*-slim-trixie and its OS packages) DO get upstream
-# security patches between Superset releases, and those patches don't
-# reach our published images unless we rebuild.
-#
-# Without this workflow, `apache/superset:<latest>` lags behind upstream
-# Debian/Python base patches by whatever interval falls between Superset
-# releases (typically 3–6 weeks). With it, the lag drops to at most one
-# week regardless of release cadence.
-#
-# This is a security-hygiene cron, not a release. It overwrites the
-# existing tags for the most recent release (e.g. `apache/superset:5.0.0`
-# and `apache/superset:latest`) with bit-for-bit-equivalent contents
-# layered on a refreshed base. Image digests change; everything users
-# actually pin against (image content, code, deps) does not.
-
-on:
-  schedule:
-    # Mondays at 06:00 UTC — gives the weekend for upstream patches to
-    # settle and surfaces failures at the start of the work week so a
-    # human can react.
-    - cron: "0 6 * * 1"
-
-  # Manual trigger so operators can force a refresh on demand (e.g.
-  # immediately after a high-severity base-image CVE drops).
-  workflow_dispatch: {}
-
-permissions:
-  contents: read
-
-# Serialize with itself and with the release publisher (tag-release.yml) —
-# both push to the same Docker Hub tags, so a race could end with stale
-# layers winning. Both workflows must declare this group for the lock to work.
-concurrency:
-  group: docker-publish-latest-release
-  cancel-in-progress: false
-
-jobs:
-  config:
-    runs-on: ubuntu-24.04
-    outputs:
-      has-secrets: ${{ steps.check.outputs.has-secrets }}
-      latest-release: ${{ steps.latest.outputs.tag }}
-      force-latest: ${{ steps.latest.outputs.force-latest }}
-    steps:
-      - name: Check for Docker Hub secrets
-        id: check
-        shell: bash
-        run: |
-          if [ -n "${DOCKERHUB_USER}" ]; then
-            echo "has-secrets=1" >> "$GITHUB_OUTPUT"
-          fi
-        env:
-          DOCKERHUB_USER: ${{ (secrets.DOCKERHUB_USER != '' && secrets.DOCKERHUB_TOKEN != '') || '' }}
-
-      - name: Look up latest published release
-        id: latest
-        shell: bash
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          REPOSITORY: ${{ github.repository }}
-        run: |
-          # `releases/latest` returns the latest non-prerelease, non-draft
-          # release — which is exactly what `apache/superset:latest`
-          # should reflect.
-          TAG=$(gh api "repos/${REPOSITORY}/releases/latest" --jq .tag_name)
-          if [ -z "$TAG" ] || [ "$TAG" = "null" ]; then
-            echo "::error::Could not determine latest release tag"
-            exit 1
-          fi
-          echo "Latest release: $TAG"
-          echo "tag=$TAG" >> "$GITHUB_OUTPUT"
-
-          # Only move `:latest` when the release flagged "latest" is also the
-          # highest semver release. This guards against a mis-click leaving an
-          # older maintenance release (e.g. a 5.x patch shipped after 6.0 GA)
-          # marked latest, which would otherwise roll `:latest` back a major
-          # version on the next cron run. If it isn't the newest, we still
-          # refresh that release's own version tag but leave `:latest` alone.
-          HIGHEST=$(gh api --paginate "repos/${REPOSITORY}/releases" \
-            --jq '.[] | select(.draft|not) | select(.prerelease|not) | .tag_name' \
-            | sed 's/^v//' | sort -V | tail -n1)
-          if [ "${TAG#v}" = "$HIGHEST" ]; then
-            echo "force-latest=1" >> "$GITHUB_OUTPUT"
-          else
-            echo "::warning::Latest-flagged release $TAG is not the highest semver ($HIGHEST); refreshing its version tag but leaving :latest untouched"
-          fi
-
-  docker-rebuild:
-    needs: config
-    if: needs.config.outputs.has-secrets == '1'
-    name: docker-rebuild
-    runs-on: ubuntu-24.04
-    strategy:
-      # Mirror the same matrix the release publisher uses so every variant
-      # operators consume from Docker Hub gets the refreshed base.
-      matrix:
-        build_preset: ["dev", "lean", "py310", "websocket", "dockerize", "py311", "py312"]
-      fail-fast: false
-    steps:
-      - name: "Checkout release tag: ${{ needs.config.outputs.latest-release }}"
-        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
-        with:
-          ref: ${{ needs.config.outputs.latest-release }}
-          fetch-depth: 0
-          persist-credentials: false
-
-      - name: Setup Docker Environment
-        uses: ./.github/actions/setup-docker
-        with:
-          dockerhub-user: ${{ secrets.DOCKERHUB_USER }}
-          dockerhub-token: ${{ secrets.DOCKERHUB_TOKEN }}
-          install-docker-compose: "false"
-          build: "true"
-
-      - name: Use Node.js 20
-        uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
-        with:
-          node-version: 20
-
-      - name: Setup supersetbot
-        uses: ./.github/actions/setup-supersetbot/
-
-      - name: Rebuild and push
-        env:
-          DOCKERHUB_USER: ${{ secrets.DOCKERHUB_USER }}
-          DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          BUILD_PRESET: ${{ matrix.build_preset }}
-          LATEST_RELEASE: ${{ needs.config.outputs.latest-release }}
-          FORCE_LATEST_FLAG: ${{ needs.config.outputs.force-latest == '1' && '--force-latest' || '' }}
-        run: |
-          # Reuses the same supersetbot invocation as the release
-          # publisher (`tag-release.yml`), so the resulting tags are
-          # identical to what a manual release dispatch would produce —
-          # just with a freshly-pulled base image layer underneath.
-          # `--force-latest` is only passed when the config job confirmed the
-          # fetched release is the newest one (see FORCE_LATEST_FLAG above).
-          supersetbot docker \
-            --push \
-            --preset "$BUILD_PRESET" \
-            --context release \
-            --context-ref "$LATEST_RELEASE" \
-            $FORCE_LATEST_FLAG \
-            --platform "linux/arm64" \
-            --platform "linux/amd64"
-
-  # The whole point of this cron is catching base-image CVEs, so a silent
-  # failure is the expensive case — a red X in the Actions tab nobody is
-  # watching on a Monday. File a tracked issue when any rebuild leg fails so
-  # a missed security refresh surfaces instead of sitting unnoticed.
-  notify-on-failure:
-    needs: [config, docker-rebuild]
-    if: failure() && needs.config.outputs.has-secrets == '1'
-    runs-on: ubuntu-24.04
-    permissions:
-      contents: read
-      issues: write
-    steps:
-      - name: Open a tracking issue
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          REPOSITORY: ${{ github.repository }}
-          LATEST_RELEASE: ${{ needs.config.outputs.latest-release }}
-          RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
-        run: |
-          gh issue create \
-            --repo "$REPOSITORY" \
-            --title "Scheduled Docker image refresh failed for ${LATEST_RELEASE}" \
-            --label "infra:container" \
-            --label "bug" \
-            --body "The weekly Docker base-image refresh failed for release \`${LATEST_RELEASE}\`. Published images may be missing upstream base-layer security patches until this is resolved.
-
-          Failed run: ${RUN_URL}"

.github/workflows/tag-release.yml

@@ -24,12 +24,6 @@ on:
 permissions:
   contents: read
 
-# Serialize with the scheduled Docker image refresh — both workflows push
-# to the same Docker Hub tags and must not race on apache/superset:latest.
-concurrency:
-  group: docker-publish-latest-release
-  cancel-in-progress: false
-
 jobs:
   config:
     runs-on: ubuntu-24.04

SIP-DASHBOARD-COMPONENT-CONTRIBUTION-POINT.md

@@ -1,262 +0,0 @@
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements.  See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership.  The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License.  You may obtain a copy of the License at
-
-  http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied.  See the License for the
-specific language governing permissions and limitations
-under the License.
--->
-
-# [SIP] Proposal for a dashboard component Extensions contribution point
-
-> **Companion SIP:** Pairs with [`SIP.md`](SIP.md) (first-class iframe component +
-> runtime CSP allowlist). That SIP is the **reference implementation** that proves
-> this contribution point: the iframe's UI becomes an extension-contributed
-> dashboard component, while its security-sensitive CSP backend stays in core.
->
-> **Status:** Draft — POC tracked in `feat/csp-runtime-allowlist-iframe`.
-
-## Motivation
-
-Adding a new dashboard layout component to Superset today is a **core-only,
-high-friction** operation. The iframe component in the companion SIP had to touch
-~12 files: a type constant, the `componentLookup` map, the builder palette, and
-**seven hardcoded behavior maps** keyed by component-type string
-(`isValidChild`, `componentIsResizable`, `newComponentFactory`,
-`shouldWrapChildInRow`, `getDetailedComponentWidth`, `isDashboardEmpty`, plus the
-prop bundle injected by `DashboardComponent.tsx`). Component types are a **closed
-enum** baked into core.
-
-There is a legacy escape hatch — the `DashboardComponentsRegistry` /
-`DYNAMIC_TYPE` path (`src/visualizations/dashboardComponents/`) — but it is an
-**antique that should be deprecated**:
-
-- It is disconnected from the modern VS Code-style Extensions framework
-  (`@apache-superset/core`, `ENABLE_EXTENSIONS`), which already has contribution
-  points for `commands`, `menus`, `views`, `editors`, and `chat`.
-- Components registered through it are **second-class**: `DynamicComponent`
-  renders them in a generic wrapper that only passes `dashboardData`. They do not
-  receive the first-class layout lifecycle (edit mode, meta editing, resize, DnD)
-  and cannot declare their own layout behavior.
-
-We want a **single, modern way** to contribute a first-class dashboard layout
-component — via the Extensions framework — and to deprecate the legacy registry.
-The iframe component is the ideal pilot because it is self-contained.
-
-## Proposed Change
-
-### 1. A `dashboardComponents` contribution point
-
-Add `dashboardComponents` to the Extensions `Contributions` interface
-(`packages/superset-core/src/contributions/index.ts`), alongside `views`,
-`commands`, etc., with a public registration API mirroring the existing ones
-(`registerDashboardComponent` returning a `Disposable`), exposed on
-`window.superset.dashboardComponents` and wired into `ExtensionsLoader`.
-
-### 2. The Dashboard Component Contract (the heart of this SIP)
-
-The contract has two halves. Getting this right is the real work — it becomes a
-**public API Superset must support indefinitely**.
-
-**(a) Declarative behavior metadata** — replaces the seven hardcoded util maps:
-
-```ts
-interface DashboardComponentContribution {
-  id: string;                 // unique type key, namespaced, e.g. "my-org.iframe"
-  name: string;               // palette label
-  description?: string;
-  icon: string;               // contributed icon id or known icon name
-  resizable?: boolean;        // -> componentIsResizable
-  defaultMeta?: {             // -> newComponentFactory
-    width?: number;
-    height?: number;
-    [key: string]: unknown;
-  };
-  nesting?: {                 // -> isValidChild / shouldWrapChildInRow
-    validParents?: string[];  // e.g. [GRID, ROW, COLUMN, TAB]
-    wrapInRow?: boolean;
-    minWidth?: number;        // -> getDetailedComponentWidth
-  };
-  isUserContent?: boolean;    // -> isDashboardEmpty
-  loadComponent: () => Promise<{ default: ComponentType<DashboardComponentProps> }>;
-}
-```
-
-**(b) Runtime props contract** — a small, stable surface. Crucially, **the host
-owns the chrome** (the `Draggable` + `ResizableContainer` + `HoverMenu`/delete
-wrapper that every current `componentLookup` component re-implements today). The
-extension component renders only its *content* and, optionally, an *editor*:
-
-```ts
-interface DashboardComponentProps {
-  id: string;
-  meta: Record<string, unknown>;
-  editMode: boolean;
-  updateMeta: (patch: Record<string, unknown>) => void; // wraps updateComponents
-  // resize/drag/delete handled by the host wrapper, NOT the component
-}
-```
-
-This is a strict improvement over the status quo: the iframe component in the
-companion PR hand-rolls the Draggable/Resizable/HoverMenu wrapper; under this
-contract that boilerplate moves into the host once, and contributed components
-shrink to "render content + edit meta."
-
-### 3. Registry-driven core
-
-Refactor `componentLookup` and the seven behavior maps to consult a registry,
-with the **built-in leaf components seeded into it** at startup. Structural
-container components (Chart, Tabs, Row, Column, Header) *are* the layout engine
-and stay bespoke; the contribution point targets **leaf/content components**
-(today: Markdown, Divider, Iframe; tomorrow: anything). `DashboardComponent.tsx`
-resolves contributed types through the registry and renders them inside the
-shared host chrome.
-
-### 4. Deprecate `DashboardComponentsRegistry` / `DYNAMIC_TYPE`
-
-Mark the legacy registry and `DYNAMIC_TYPE` deprecated. Provide a shim so existing
-dynamic components keep working, with a migration note pointing at the new
-contribution point. Removal happens in a later major per Superset's deprecation
-policy.
-
-### 5. Graceful fallback for unknown types
-
-A saved dashboard layout stores component **type strings** in its position JSON.
-If a dashboard references a type whose extension is disabled/uninstalled, the host
-must render a non-destructive placeholder ("This component requires the *X*
-extension") and **preserve the meta on save** so re-enabling the extension
-restores it. The layout engine already tolerates unknown types defensively
-(`componentLookup[type]` → null; `isValidChild` → false); this SIP makes that an
-intentional, user-visible contract rather than silent breakage.
-
-### 6. Backend: APIs yes, security policy no
-
-The Extensions framework **already** lets a component contribute a backend REST
-API: the `@api` decorator (`superset-core/.../rest_api/decorators.py`) detects
-extension context and registers the route via `appbuilder.add_api()` at entrypoint
-import, serving it under `/extensions/{publisher}/{name}/...` and auto-creating
-the endpoint's FAB permission. **No new work is required for an extension to ship
-an API.**
-
-What an extension **cannot** do today, and what this SIP explicitly leaves to
-core:
-
-- **Role policy for a permission.** Endpoint permissions are auto-created, but
-  whether a permission is *Admin-only* (e.g. via
-  `SupersetSecurityManager.ADMIN_ONLY_VIEW_MENUS`) is decided in core at
-  `sync_role_definitions` time. The manifest's `permissions: list[str]` field is
-  currently **dormant** (never read), and the `ContributionProcessorRegistry` that
-  would process it is scaffolding that is not wired into the load pipeline.
-- **Security-sensitive request hooks** (e.g. rewriting CSP/Talisman headers).
-
-This is exactly why the companion CSP feature keeps its backend in core: the
-component *UI* is extension-shaped, but punching holes in the CSP and gating it
-admin-only are core security responsibilities.
-
-A **future, optional** extension of this SIP could finish wiring
-`ContributionProcessorRegistry` + a manifest permission-policy schema so
-extensions can declare role policy — but that is itself a security-review-worthy
-change and is out of scope here.
-
-## New or Changed Public Interfaces
-
-- **New contribution point** `dashboardComponents` on the `Contributions`
-  interface; new `registerDashboardComponent(...) -> Disposable` API; new
-  `window.superset.dashboardComponents` namespace.
-- **New public types** `DashboardComponentContribution` and
-  `DashboardComponentProps` (the contract) — these become long-term public API.
-- **Changed (internal → registry-driven)** `componentLookup` and the seven
-  behavior util maps; `DashboardComponent.tsx` resolution path; the host gains a
-  shared component-chrome wrapper.
-- **Deprecated** `DashboardComponentsRegistry`, `DYNAMIC_TYPE`,
-  `NewDynamicComponent`, `setupDashboardComponents`.
-
-## New dependencies
-
-None. Reuses the existing Extensions framework (module federation, manifest
-schema, `@api` decorator) and the existing functional-registry utilities.
-
-## Migration Plan and Compatibility
-
-- **No DB migration.** This is a frontend/framework change plus the (already
-  supported) extension API path.
-- **Layout JSON is unchanged** — component types remain type strings. The new
-  fallback behavior makes *unknown* types degrade gracefully instead of rendering
-  nothing.
-- **Backwards compatible:** built-in components are seeded into the registry, so
-  existing dashboards render identically. Legacy `DYNAMIC_TYPE` components keep
-  working via a deprecation shim.
-- **Rollout:** the contribution point is only active under `ENABLE_EXTENSIONS`;
-  with it off, behavior is identical to today.
-
-## Rejected Alternatives
-
-- **Keep / extend `DashboardComponentsRegistry`.** It is disconnected from the
-  modern Extensions framework and produces second-class components. Deprecating it
-  in favor of one contribution model is the goal, not a side effect.
-- **Require all built-in components to become extensions.** Chart/Tabs/Row/Column
-  are the layout engine; extracting them is high-risk and low-value. The
-  contribution point *adds* leaf components; it does not mandate extraction.
-- **Let the extension component own its own DnD/resize chrome** (as
-  `componentLookup` components do today). Rejected: it bloats the contract,
-  duplicates host logic, and makes the public API fragile. The host owns chrome.
-- **One combined SIP with the CSP feature.** Rejected: the framework change and
-  the security-sensitive feature are distinct discussions with different
-  reviewers and risk profiles, even though they share a POC branch.
-- **Move the CSP permission/role policy into the extension.** Not supported today
-  (dormant manifest `permissions`, unwired contribution processor) and
-  undesirable: admin-only gating and CSP-header rewriting are core security
-  responsibilities.
-
-## Implementation Status (POC)
-
-Implemented on the POC branch (`@apache-superset/core` mirrors the `chat`
-contribution-point pattern from #41000/#41205):
-
-- [x] `DashboardComponentDefinition` + `DashboardComponentProps` contract types
-      (`packages/superset-core/src/dashboardComponents`), added to the
-      `Contributions` interface and the package's subpath exports
-- [x] `dashboardComponents` contribution point: host `DashboardComponentsProvider`
-      registry + public `registerDashboardComponent`/`getDashboardComponents` API
-      (`src/core/dashboardComponents`), exposed on `window.superset` via
-      `ExtensionsStartup` + `Namespaces`
-- [x] Shared host component-chrome wrapper `DashboardExtensionComponent`
-      (owns Draggable/Resizable/HoverMenu/Delete; reads `resizable` from the
-      definition) behind the new `EXTENSION_TYPE`
-- [x] `componentLookup` + builder palette resolve the registry; the seven
-      behavior maps carry `EXTENSION_TYPE` leaf behavior
-- [x] Unknown-type graceful fallback (placeholder + meta preserved on save)
-- [x] Deprecation notices on `DashboardComponentsRegistry` / `DYNAMIC_TYPE`
-      (legacy path still functions)
-- [x] Reference component: the built-in iframe is now delivered **through** the
-      contribution point (`src/dashboard/extensions/iframe`), registered at
-      startup exactly as a third-party extension would; its CSP backend remains
-      in core per the companion SIP
-- [x] Tests: registry lifecycle (register/get/replace/dispose), host-wrapper
-      resolution + fallback + `updateMeta`, iframe content + CSP UX
-
-- [x] Per-component behavior policy honored by the layout engine: `resizable`,
-      `minWidth`, `isUserContent`, `validParents`, and `wrapInRow` are seeded onto
-      instance `meta` at creation and read by `componentIsResizable`,
-      `getDetailedComponentWidth`, `isDashboardEmpty`, `isValidChild`, and
-      `shouldWrapChildInRow` (the pure layout utils stay registry-free; behavior
-      round-trips in the saved layout)
-- [x] Developer docs: `extension-points/dashboard-components.md` + a
-      `contribution-types.md` section + sidebar entry, with an example extension
-
-Remaining (follow-up, not POC-blocking):
-
-- [ ] Manifest `contributions.dashboardComponents` declarative validation in the
-      Python/TS manifest schema (runtime side-effect registration works today,
-      matching how `chat` does it)
-- [ ] Remove the legacy `DashboardComponentsRegistry`/`DYNAMIC_TYPE` (major)

SIP.md

@@ -1,232 +0,0 @@
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements.  See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership.  The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License.  You may obtain a copy of the License at
-
-  http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied.  See the License for the
-specific language governing permissions and limitations
-under the License.
--->
-
-# [SIP] Proposal for a first-class iframe dashboard component with a runtime CSP allowlist
-
-> **Companion SIP:** This proposal pairs with
-> [`SIP-DASHBOARD-COMPONENT-CONTRIBUTION-POINT.md`](SIP-DASHBOARD-COMPONENT-CONTRIBUTION-POINT.md),
-> which proposes the Extensions contribution point that would let this iframe
-> component (and others) be shipped as an extension. The two are deliberately
-> separate discussions: **this** SIP covers the security-sensitive feature
-> (runtime CSP override + permissions); the companion covers the framework
-> change. They share one POC branch so the end-to-end story is demonstrable.
-
-> **Status:** Draft — tracking the implementation in `feat/csp-runtime-allowlist-iframe`.
-> This document follows the SIP issue template and is kept in sync with the branch
-> as the implementation evolves. See SIP-0
-> (<https://github.com/apache/superset/issues/5602>) for the SIP process.
-
-## Motivation
-
-Superset ships a Talisman/Content-Security-Policy (CSP) configuration that, by
-design, prevents users from embedding arbitrary external content in a dashboard.
-The default policy declares `default-src 'self'` and **no** `frame-src`
-directive, so an `<iframe>` pointing at any third-party origin is blocked by the
-browser.
-
-This is correct and secure default behavior, but it creates real friction:
-
-- There is **no first-class "iframe" dashboard component**. Users historically
-  smuggled iframes through Markdown, which is both a footgun and blocked by CSP.
-- When an embed *is* legitimately needed (an internal tool, a status page, a
-  partner widget), the only way to allow it is to **edit `TALISMAN_CONFIG` and
-  restart every Superset process**. That is a deploy-time, ops-team operation —
-  far too heavyweight for "let me embed this one dashboard from our other
-  internal app."
-- There is no in-product signal telling a user *why* their embed is blank, and
-  no path to fix it.
-
-We want to (a) make embedding a real, supported component, and (b) give trusted
-Admins a controlled, audited way to widen the CSP at runtime — without
-abandoning the secure-by-default posture that operators rely on.
-
-## Proposed Change
-
-The change has five parts.
-
-### 1. A first-class `IFRAME` dashboard layout component
-
-A new grid component (`IFRAME_TYPE`) modeled on the existing Markdown/Divider
-components. In edit mode the user pastes a URL; in view mode the component
-renders a sandboxed `<iframe>`. The component is registered through the same
-surface as every other layout element (type constant, `componentLookup`, drag
-palette, nesting/resize/width/wrap util maps).
-
-The iframe is rendered with a restrictive `sandbox` attribute
-(`allow-scripts allow-same-origin allow-popups allow-forms`).
-
-### 2. Domain flagging
-
-When the runtime-allowlist feature is enabled, the component compares the
-embedded URL's **origin** against the current allowlist (fetched from the new
-API). If the origin is not yet allowed, it shows an inline warning explaining
-that the domain is blocked by the CSP.
-
-### 3. "Enable domain in CSP" button
-
-If the current user holds the new permission (Admins by default), the warning
-includes an **Enable domain in CSP** button. Clicking it `POST`s the origin to
-the allowlist API and re-checks. Users without the permission instead see "ask
-an administrator."
-
-### 4. Permission gating
-
-Mutating the allowlist requires `can write on CSPAllowlist`. The `CSPAllowlist`
-view-menu is registered in `SupersetSecurityManager.ADMIN_ONLY_VIEW_MENUS`, so
-the capability is reserved for Admins (or a custom role explicitly granted it),
-consistent with how other trusted, security-sensitive operations are scoped.
-
-### 5. Runtime CSP override ("punched holes")
-
-A new `csp_allowlist` metadata table stores allowlist entries. An `after_request`
-hook — registered **before** flask-talisman so that, because Flask runs
-`after_request` callbacks in reverse registration order, it runs **after**
-Talisman has set the header — merges the operator-curated entries into the
-response CSP header. Entries are cached in-process with a short TTL to avoid a DB
-hit per response; a write through the API invalidates the cache in the handling
-worker, and other workers converge when their cached copy expires.
-
-The entire runtime-override path is inert unless the `CSP_RUNTIME_ALLOWLIST`
-feature flag is enabled, so the static, deploy-time policy remains the default
-and operators opt in explicitly.
-
-```
-Browser ──> Flask request
-                 │
-         Talisman after_request  (sets "Content-Security-Policy: default-src 'self'; …")
-                 │
-   merge_runtime_csp_allowlist   (if flag on: appends allowlist origins to frame-src, …)
-                 │
-            Response ──> Browser  ("…; frame-src 'self' https://embed.example")
-```
-
-#### Design decisions (resolved)
-
-- **Scope: global.** Allowlist entries apply server-wide. CSP is a single
-  per-response header; a global allowlist keeps the merge context-free and
-  avoids per-dashboard request plumbing. (Per-dashboard scoping is a possible
-  future extension.)
-- **Operator control: feature-flagged kill-switch.** The runtime override only
-  functions when `CSP_RUNTIME_ALLOWLIST` is on (default **off**). Operators who
-  want a purely static policy simply leave it off and the table is never
-  consulted.
-
-## New or Changed Public Interfaces
-
-### REST API
-
-- `GET /api/v1/csp_allowlist/` — list entries
-- `GET /api/v1/csp_allowlist/<id>` — get one
-- `POST /api/v1/csp_allowlist/` — create (validates origin + directive)
-- `PUT /api/v1/csp_allowlist/<id>` — update
-- `DELETE /api/v1/csp_allowlist/<id>` — delete
-- `DELETE /api/v1/csp_allowlist/?q=!(...)` — bulk delete
-
-All write methods require `can write on CSPAllowlist` (Admin-only by default).
-Origins are validated server-side: bare `scheme://host[:port]` only — no
-wildcards, paths, query strings, fragments, or credentials. Only a fixed set of
-directives may be widened (`frame-src`, `child-src`, `img-src`, `connect-src`,
-`media-src`, `font-src`); notably **not** `script-src`.
-
-### Model
-
-- `CSPAllowlistEntry` (`superset/models/csp.py`, table `csp_allowlist`):
-  `id`, `uuid`, `domain`, `directive` (default `frame-src`), `description`,
-  audit columns. Unique on `(domain, directive)`.
-
-### Feature flag
-
-- `CSP_RUNTIME_ALLOWLIST` (default `False`) — gates the entire runtime-override
-  path, backend and frontend.
-
-### Config
-
-- `CSP_RUNTIME_ALLOWLIST_CACHE_TTL` (default `30` seconds) — in-process cache TTL
-  for the allowlist; also settable via env var.
-
-### Frontend
-
-- New `IFRAME` dashboard layout component and its registration across the
-  dashboard util maps.
-- New `FeatureFlag.CspRuntimeAllowlist` enum member.
-
-### Security model
-
-- New `CSPAllowlist` view-menu added to `ADMIN_ONLY_VIEW_MENUS`.
-
-## New dependencies
-
-None. The implementation uses existing libraries (flask-talisman,
-Flask-AppBuilder, marshmallow, SQLAlchemy on the backend; existing
-`@superset-ui/core` components on the frontend).
-
-## Migration Plan and Compatibility
-
-- One Alembic migration adds the `csp_allowlist` table
-  (`a1b2c3d4e5f6`, down-revision `78a40c08b4be`). The table is empty on creation.
-- Fully backward compatible: with the feature flag off (the default), behavior is
-  identical to today — the static CSP is authoritative and the new table is never
-  read. No existing dashboards, URLs, or policies change.
-- Rollback: dropping the table and disabling the flag fully reverts the feature.
-
-### Security review notes
-
-This feature deliberately relocates a *capability* (widening the CSP) from a
-purely deploy-time operator control into a runtime, permission-gated, audited
-operation. The mitigations that keep it within Superset's trust model:
-
-- **Off by default** behind a feature flag the operator owns.
-- **Admin-only** write permission (a fully trusted principal per `SECURITY.md`).
-- **Strict origin validation** server-side — no wildcards, no `script-src`.
-- **Audit trail** via the audit mixin (`created_by` / `changed_by`).
-- The iframe is **sandboxed** and the merge can only *widen* a directive to a
-  specific origin, never relax nonce/`strict-dynamic` protections on
-  `script-src`.
-
-## Rejected Alternatives
-
-- **Dynamically reconfiguring flask-talisman at runtime.** Talisman is configured
-  once at app init. Rather than mutate its internals, we add our own
-  `after_request` hook that post-processes the header it already sets. This is
-  simpler, avoids depending on Talisman internals, and rides the same per-request
-  header machinery Talisman already uses for its nonce.
-- **Per-dashboard allowlist scoping.** More precise, but CSP is a per-response
-  header; per-dashboard scoping adds request-context complexity for marginal
-  benefit in the common case. Left as a possible future extension.
-- **"Always on" runtime override (no kill-switch).** Simpler, but moves a
-  security control fully into the app with no operator opt-out. Rejected in favor
-  of the feature-flag kill-switch.
-- **Shared/Redis-backed allowlist cache with cross-worker invalidation.**
-  Correct but heavier. A short-TTL in-process cache is good enough: writes take
-  effect immediately in the handling worker and within the TTL elsewhere, with no
-  new infrastructure dependency.
-
-## Implementation Status
-
-- [x] Feature flag `CSP_RUNTIME_ALLOWLIST` + `CSP_RUNTIME_ALLOWLIST_CACHE_TTL`
-- [x] `CSPAllowlistEntry` model + Alembic migration
-- [x] DAO, marshmallow schemas (with origin/directive validation), REST API
-- [x] Admin-only permission (`CSPAllowlist` view-menu)
-- [x] `after_request` CSP merge hook + in-process TTL cache + invalidation
-- [x] `IFRAME` dashboard component + registration across util maps
-- [x] Domain flagging + permission-gated "Enable domain in CSP" button
-- [x] Tests: backend unit (validation + merge + hook), backend integration (API),
-      frontend unit (util + component)
-- [ ] Docs (`docs/`) + `UPDATING.md` entry
-- [ ] Community/security review feedback

UPDATING.md

@@ -24,22 +24,6 @@ assists people when migrating to a new version.
 
 ## Next
 
-### Guest-token RLS rules reject unknown fields
-
-The `rls` rules passed to `POST /api/v1/security/guest_token/` are now validated strictly: a rule may only contain `dataset` and `clause`. Previously unknown fields were silently dropped, so a mistyped or legacy scope key (most commonly `datasource` instead of `dataset`) produced a rule with no `dataset`, which is treated as a *global* rule applied to every dataset the embedded resource can reach. Such a request now returns HTTP 400 identifying the offending field instead of issuing a token with an unintended global rule. Integrators that were sending extra fields in RLS rules must remove them; valid dataset-scoped (`{"dataset": 41, "clause": "..."}`) and global (`{"clause": "..."}`) rules are unaffected.
-
-### MCP service requires `MCP_JWT_AUDIENCE` when JWT auth is enabled
-
-When the MCP service has JWT auth enabled (`MCP_AUTH_ENABLED = True`), an audience must be configured via `MCP_JWT_AUDIENCE` so issued tokens are bound to this service. The service now fails to start with a clear configuration error when the audience is unset, instead of starting with audience validation skipped. Deployments that enable MCP JWT auth must set `MCP_JWT_AUDIENCE` to the audience value their identity provider issues for the MCP service. API-key-only MCP deployments (JWT auth disabled) are unaffected.
-
-### Swagger UI is opt-in (off by default)
-
-`FAB_API_SWAGGER_UI` now defaults to `False` and is driven by the `SUPERSET_ENABLE_SWAGGER_UI` environment variable. The interactive Swagger UI / OpenAPI documentation endpoints (e.g. `/swagger/v1`) are therefore no longer exposed by default. To enable them, set `SUPERSET_ENABLE_SWAGGER_UI=true` (the bundled Docker development environment sets this) or override `FAB_API_SWAGGER_UI = True` in `superset_config.py`.
-
-### Build details (git SHA / build number) are admin-only by default
-
-The git SHA and build number surfaced in the "About" section, the bootstrap payload, and the public `/version` endpoint are now only included for admin users by default; the release version string is still shown to everyone. To expose the build details to all users (the previous behavior), set the `SUPERSET_EXPOSE_BUILD_DETAILS` environment variable (or `EXPOSE_BUILD_DETAILS_TO_USERS = True` in `superset_config.py`).
-
 ### Pivot table First/Last aggregations follow data order
 
 The pivot table chart's `First` and `Last` aggregations now return the first and last value in data (query result) order, instead of effectively returning the minimum and maximum. Existing pivot tables that use these aggregations for totals/subtotals may show different values after upgrading. For deterministic results, ensure the underlying query has a stable sort order.

docker/.env

@@ -70,8 +70,6 @@ SUPERSET_LOG_LEVEL=info
 
 SUPERSET_APP_ROOT="/"
 SUPERSET_ENV=development
-# Swagger UI is opt-in (off by default); enable it for local development.
-SUPERSET_ENABLE_SWAGGER_UI=true
 SUPERSET_LOAD_EXAMPLES=yes
 CYPRESS_CONFIG=false
 SUPERSET_PORT=8088

docs/admin_docs/configuration/alerts-reports.mdx

@@ -160,7 +160,7 @@ When enabled, Superset rejects webhook configurations that use `http://` URLs.
 
 #### Retry Behavior
 
-Superset automatically retries webhook deliveries on `429 Too Many Requests` and `5xx` server errors using exponential backoff. Retries are bounded to roughly 120 seconds of cumulative wall-clock time (worst case ~210 seconds, because the bound is checked against the time elapsed before each attempt, so the final request can begin just under the limit and still run its full request timeout), after which the delivery is abandoned.
+Superset automatically retries webhook deliveries on `429 Too Many Requests` and `5xx` server errors using exponential backoff.
 
 ### Kubernetes-specific
 

docs/admin_docs/security/securing_superset.mdx

@@ -161,7 +161,6 @@ Here's the documentation section how how to set up Talisman: https://superset.ap
 
   - [ ] Regularly update to the latest major or minor versions of Superset. Those versions receive up-to-date security patches.
   - [ ] Rotate the `SUPERSET_SECRET_KEY` periodically (e.g., quarterly) and after any potential security incident.
-  - [ ] Rotate the other security-critical secrets (guest-token and async-query JWT secrets, SMTP and database credentials) on the cadence in Appendix C, and after any potential security incident.
   - [ ] Conduct quarterly access reviews for all users.
   - [ ] Assuming logging and monitoring is in place, review security monitoring alerts weekly.
 
@@ -174,24 +173,6 @@ Rotating the `SUPERSET_SECRET_KEY` is a critical security procedure. It is manda
 The procedure for safely rotating the SECRET_KEY must be followed precisely to avoid locking yourself out of your instance. The official Apache Superset documentation maintains the correct, up-to-date procedure. Please follow the official guide here:
 https://superset.apache.org/admin-docs/configuration/configuring-superset/#rotating-to-a-newer-secret_key
 
-### **Appendix C: Secrets Register and Rotation Schedule**
-
-`SUPERSET_SECRET_KEY` is not the only security-critical secret in a Superset deployment. Maintain an inventory of all such secrets, store each in a secrets manager (not in `superset_config.py` or version control), assign an owner, and rotate them on a defined cadence as well as after any suspected compromise.
-
-| Secret | Purpose | Risk if leaked | Suggested rotation |
-|---|---|---|---|
-| `SUPERSET_SECRET_KEY` | Signs session cookies; key material for encrypting stored DB credentials (Fernet/AES) | Forged sessions (auth bypass / privilege escalation); decryption of exfiltrated metadata-DB secrets | Quarterly + post-incident |
-| `GUEST_TOKEN_JWT_SECRET` | Signs embedded-dashboard guest tokens | Forged guest tokens → unauthorized dashboard/data access | Quarterly + post-incident |
-| `GLOBAL_ASYNC_QUERIES_JWT_SECRET` | Signs the async-query channel JWT | Forged async-query tokens | Quarterly + post-incident |
-| SMTP password | Outbound email for alerts & reports | Email relay abuse / spoofing | Per organizational policy + post-incident |
-| Database connection passwords | Access to analytical databases and the metadata DB | Direct database access | Per organizational policy + post-incident |
-
-Notes:
-
-- Rotating `GUEST_TOKEN_JWT_SECRET` or `GLOBAL_ASYNC_QUERIES_JWT_SECRET` invalidates outstanding tokens of that type; schedule rotations accordingly.
-- After a suspected compromise, rotate **all** of the above, not only `SUPERSET_SECRET_KEY`.
-- Keep the register under change control so new secrets introduced by future features are added to the rotation schedule.
-
 :::resources
 - [Blog: Running Apache Superset on the Open Internet](https://preset.io/blog/running-apache-superset-on-the-open-internet-a-report-from-the-fireline/)
 - [Blog: How Security Vulnerabilities are Reported & Handled in Apache Superset](https://preset.io/blog/how-security-vulnerabilities-are-reported-and-handled-in-apache-superset/)

docs/developer_docs/extensions/contribution-types.md

@@ -34,14 +34,15 @@ Frontend contribution types allow extensions to extend Superset's user interface
 
 Extensions can add new views or panels to the host application, such as custom SQL Lab panels, dashboards, or other UI components. Contribution areas are uniquely identified (e.g., `sqllab.panels` for SQL Lab panels), enabling seamless integration into specific parts of the application.
 
-```typescript
+```tsx
+import React from 'react';
 import { views } from '@apache-superset/core';
 import MyPanel from './MyPanel';
 
 views.registerView(
   { id: 'my-extension.main', name: 'My Panel Name' },
   'sqllab.panels',
-  MyPanel,
+  () => <MyPanel />,
 );
 ```
 
@@ -111,45 +112,6 @@ editors.registerEditor(
 
 See [Editors Extension Point](./extension-points/editors.md) for implementation details.
 
-### Chat
-
-Extensions can add a chat interface to Superset by registering a trigger component and a panel component. The host owns the layout, open/close state, and display mode — the extension only provides the UI. The panel can be displayed as a floating overlay or docked as a resizable sidebar beside the page content, and the user's preference is persisted across reloads.
-
-```tsx
-import { chat } from '@apache-superset/core';
-import ChatTrigger from './ChatTrigger';
-import ChatPanel from './ChatPanel';
-
-chat.registerChat(
-  { id: 'my-org.my-chat', name: 'My Chat' },
-  ChatTrigger,
-  ChatPanel,
-);
-```
-
-See [Chat](./extension-points/chat.md) for implementation details.
-
-### Dashboard Components
-
-Extensions can add first-class layout components to the dashboard builder — elements that live in the grid alongside charts, Markdown, and tabs. The host owns the drag/resize/delete chrome, so the extension only provides the component that renders the element's content. The built-in iframe component is implemented through this contribution point.
-
-```tsx
-import { dashboardComponents } from '@apache-superset/core';
-import WeatherWidget from './WeatherWidget';
-
-dashboardComponents.registerDashboardComponent(
-  {
-    id: 'my-org.weather',
-    name: 'Weather widget',
-    icon: 'CloudOutlined',
-    defaultMeta: { width: 4, height: 50 },
-  },
-  WeatherWidget,
-);
-```
-
-See [Dashboard Components](./extension-points/dashboard-components.md) for implementation details.
-
 ## Backend
 
 Backend contribution types allow extensions to extend Superset's server-side capabilities. Backend contributions are registered at startup via classes and functions imported from the auto-discovered `entrypoint.py` file.

docs/developer_docs/extensions/extension-points/chat.md

@@ -1,141 +0,0 @@
----
-title: Chat
-sidebar_position: 3
----
-
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements.  See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership.  The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License.  You may obtain a copy of the License at
-
-  http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied.  See the License for the
-specific language governing permissions and limitations
-under the License.
--->
-
-# Chat Contributions
-
-Extensions can add a chat interface to Superset by registering a trigger and a panel. The host owns the layout, open/close state, and display mode — the extension only needs to provide the UI components.
-
-## Overview
-
-A chat registration consists of two React components:
-
-| Component | Role |
-|-----------|------|
-| **Trigger** | Always-visible entry point (e.g., a floating button). Rendered in the bottom-right corner in floating mode, or as a fixed overlay in panel mode. |
-| **Panel** | The chat UI itself (message list, input, etc.). Mounted by the host in the active display mode. |
-
-## Display Modes
-
-The host supports two display modes, switchable by the user or the extension at runtime:
-
-| Mode | Behavior |
-|------|----------|
-| `floating` | Panel floats above page content, anchored to the bottom-right corner. |
-| `panel` | Panel is docked to the right side of the application as a resizable sidebar, sitting beside the page content. |
-
-The user's last selected mode and open/closed state are persisted across page reloads.
-
-## Registering a Chat
-
-Call `chat.registerChat` from your extension's entry point with a descriptor, a trigger factory, and a panel factory:
-
-```tsx
-import { chat } from '@apache-superset/core';
-import ChatTrigger from './ChatTrigger';
-import ChatPanel from './ChatPanel';
-
-chat.registerChat(
-  { id: 'my-org.my-chat', name: 'My Chat' },
-  ChatTrigger,
-  ChatPanel,
-);
-```
-
-Only one chat registration is active at a time. If a second extension calls `registerChat`, it replaces the first and a warning is logged.
-
-## Opening and Closing the Chat
-
-The trigger component is responsible for toggling the panel. Use `chat.isOpen()`, `chat.open()`, and `chat.close()` to control visibility:
-
-```tsx
-import { chat } from '@apache-superset/core';
-
-export default function ChatTrigger() {
-  return (
-    <button onClick={() => (chat.isOpen() ? chat.close() : chat.open())}>
-      💬
-    </button>
-  );
-}
-```
-
-You can also subscribe to open/close events from any component:
-
-```tsx
-useEffect(() => {
-  const { dispose } = chat.onDidOpen(() => console.log('chat opened'));
-  return dispose;
-}, []);
-```
-
-## Changing the Display Mode
-
-Call `chat.setDisplayMode` to switch between `'floating'` and `'panel'` modes. In your panel component, subscribe to `onDidChangeDisplayMode` to react to changes (including those triggered by the user):
-
-```tsx
-import { useState, useEffect } from 'react';
-import { chat } from '@apache-superset/core';
-
-export default function ChatPanel() {
-  const [mode, setMode] = useState(chat.getDisplayMode());
-
-  useEffect(() => {
-    const { dispose } = chat.onDidChangeDisplayMode(m => setMode(m));
-    return dispose;
-  }, []);
-
-  return (
-    <div style={{ height: mode === 'panel' ? '100%' : '80vh' }}>
-      <button onClick={() => chat.setDisplayMode(mode === 'panel' ? 'floating' : 'panel')}>
-        {mode === 'panel' ? 'Float' : 'Dock'}
-      </button>
-      {/* message list and input */}
-    </div>
-  );
-}
-```
-
-## Chat API Reference
-
-All methods are available on the `chat` namespace from `@apache-superset/core`:
-
-| Method / Event | Description |
-|----------------|-------------|
-| `registerChat(descriptor, trigger, panel)` | Register a chat extension. Returns a `Disposable` to unregister. |
-| `open()` | Open the chat panel. No-op if already open or no registration. |
-| `close()` | Close the chat panel. |
-| `isOpen()` | Returns `true` if the panel is currently open. |
-| `getDisplayMode()` | Returns the current display mode (`'floating'` or `'panel'`). |
-| `setDisplayMode(mode)` | Switch between `'floating'` and `'panel'` mode. |
-| `onDidOpen(listener)` | Subscribe to panel open events. Returns a `Disposable`. |
-| `onDidClose(listener)` | Subscribe to panel close events. Returns a `Disposable`. |
-| `onDidChangeDisplayMode(listener)` | Subscribe to display mode changes. Returns a `Disposable`. |
-| `onDidRegisterChat(listener)` | Subscribe to registration events. |
-| `onDidUnregisterChat(listener)` | Subscribe to unregistration events. |
-| `onDidResizePanel(listener)` | Subscribe to panel resize events (panel mode only). Not all hosts provide a resizer — do not rely on this firing. Returns a `Disposable`. |
-
-## Next Steps
-
-- **[Contribution Types](../contribution-types.md)** — Explore other contribution types
-- **[Development](../development.md)** — Set up your development environment

docs/developer_docs/extensions/extension-points/dashboard-components.md

@@ -1,155 +0,0 @@
----
-title: Dashboard Components
-sidebar_position: 4
----
-
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements.  See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership.  The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License.  You may obtain a copy of the License at
-
-  http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied.  See the License for the
-specific language governing permissions and limitations
-under the License.
--->
-
-# Dashboard Component Contributions
-
-Extensions can add first-class **layout components** to the dashboard builder —
-elements that sit in the grid alongside charts, Markdown, and tabs. The built-in
-iframe component is itself implemented through this contribution point.
-
-The host owns the surrounding **chrome** (the drag handle, the resize container,
-and the delete affordance), so your component only renders its content and, in
-edit mode, its own editor affordances. This keeps the contract small and stable.
-
-> This supersedes the legacy `DashboardComponentsRegistry` / `DYNAMIC_TYPE`
-> mechanism, which is deprecated.
-
-## Overview
-
-A dashboard component contribution is:
-
-| Part | Role |
-|------|------|
-| **Definition** | A descriptor declaring the component's id, palette label, icon, and layout behavior (resizable, default size, nesting). |
-| **Component** | A React component that renders the element's content and receives the [`DashboardComponentProps`](#component-contract) contract. |
-
-## The Component Contract
-
-Your component receives a small, stable set of props. It never deals with drag,
-resize, or delete — the host renders it inside that chrome.
-
-```ts
-interface DashboardComponentProps {
-  /** The layout item id of this instance. */
-  id: string;
-  /** This instance's persisted meta (round-trips in the saved layout). */
-  meta: Record<string, unknown>;
-  /** Whether the dashboard is in edit mode. */
-  editMode: boolean;
-  /** Shallow-merge a patch into this instance's persisted meta. */
-  updateMeta: (patch: Record<string, unknown>) => void;
-}
-```
-
-Persist any per-instance state in `meta` via `updateMeta`. It is saved with the
-dashboard and rehydrated on load.
-
-## Registering a Dashboard Component
-
-Call `dashboardComponents.registerDashboardComponent` from your extension's entry
-point with a definition and your component:
-
-```tsx
-import { dashboardComponents } from '@apache-superset/core';
-import WeatherWidget from './WeatherWidget';
-
-dashboardComponents.registerDashboardComponent(
-  {
-    id: 'my-org.weather',
-    name: 'Weather widget',
-    description: 'Shows the current weather for a city',
-    icon: 'CloudOutlined',
-    resizable: true,
-    defaultMeta: { width: 4, height: 50, city: 'Lisbon' },
-  },
-  WeatherWidget,
-);
-```
-
-```tsx
-// WeatherWidget.tsx
-import type { dashboardComponents } from '@apache-superset/core';
-
-type Props = dashboardComponents.DashboardComponentProps;
-
-export default function WeatherWidget({ meta, editMode, updateMeta }: Props) {
-  const city = (meta.city as string) ?? '';
-  return editMode ? (
-    <input
-      value={city}
-      onChange={e => updateMeta({ city: e.target.value })}
-      placeholder="City"
-    />
-  ) : (
-    <Forecast city={city} />
-  );
-}
-```
-
-The component appears in the dashboard builder's **Layout elements** palette and
-can be dragged onto the grid like any built-in element.
-
-## Definition Reference
-
-| Field | Type | Description |
-|-------|------|-------------|
-| `id` | `string` | Namespaced unique id, e.g. `my-org.weather`. Selects the component for each instance. |
-| `name` | `string` | Label shown in the builder palette. |
-| `description` | `string` | Optional longer description. |
-| `icon` | `string` | A known Superset icon name (e.g. `CloudOutlined`). Falls back to a generic icon. |
-| `resizable` | `boolean` | Whether instances can be resized. Defaults to `true`. |
-| `defaultMeta` | `object` | `meta` seeded onto a new instance (e.g. `width`, `height`, and your own keys). |
-| `isUserContent` | `boolean` | Whether an instance counts as content for "is this dashboard empty?" detection. Defaults to `true`. |
-| `minWidth` | `number` | Minimum width in grid columns. Defaults to `1`. |
-| `validParents` | `string[]` | Restrict which container types may hold the component (e.g. `['GRID', 'TAB']`). Defaults to standard content-leaf placement (grid, row, column, tab). |
-| `wrapInRow` | `boolean` | Whether a drop into the grid or a tab auto-wraps the component in a row. Defaults to `true`. |
-
-The layout-relevant behavior fields are seeded onto each instance's `meta` at
-creation, so the dashboard honors them — and they round-trip in the saved layout
-even if the extension later becomes unavailable.
-
-## Graceful Degradation
-
-If a saved dashboard references a component whose extension is disabled or not
-yet loaded, the host renders a non-destructive placeholder in its place and
-preserves the instance's `meta` on save. Re-enabling the extension restores the
-component.
-
-## Dashboard Components API Reference
-
-All methods are available on the `dashboardComponents` namespace from
-`@apache-superset/core`:
-
-| Method / Event | Description |
-|----------------|-------------|
-| `registerDashboardComponent(definition, component)` | Register a component. Returns a `Disposable` to unregister. Registering the same id again replaces the previous registration. |
-| `getDashboardComponent(id)` | Returns the registered component for `id`, or `undefined`. |
-| `getDashboardComponents()` | Returns all registered components. |
-| `onDidRegisterDashboardComponent(listener)` | Subscribe to registration events. Returns a `Disposable`. |
-| `onDidUnregisterDashboardComponent(listener)` | Subscribe to unregistration events. Returns a `Disposable`. |
-
-## Next Steps
-
-- **[Contribution Types](../contribution-types.md)** — Explore other contribution types
-- **[Development](../development.md)** — Set up your development environment

docs/developer_docs/sidebars.js

@@ -47,9 +47,6 @@ module.exports = {
           collapsed: true,
           items: [
             'extensions/extension-points/sqllab',
-            'extensions/extension-points/editors',
-            'extensions/extension-points/chat',
-            'extensions/extension-points/dashboard-components',
           ],
         },
         'extensions/development',

docs/package.json

@@ -72,7 +72,7 @@
     "@superset-ui/core": "^0.20.4",
     "@swc/core": "^1.15.41",
     "antd": "^6.4.4",
-    "baseline-browser-mapping": "^2.10.38",
+    "baseline-browser-mapping": "^2.10.37",
     "caniuse-lite": "^1.0.30001799",
     "docusaurus-plugin-openapi-docs": "^5.0.2",
     "docusaurus-theme-openapi-docs": "^5.0.2",
@@ -134,8 +134,7 @@
     "yaml": "1.10.3",
     "uuid": "11.1.1",
     "serialize-javascript": "7.0.5",
-    "d3-color": "3.1.0",
-    "ws": "^8.21.0"
+    "d3-color": "3.1.0"
   },
   "packageManager": "yarn@1.22.22+sha1.ac34549e6aa8e7ead463a7407e1c7390f61a6610"
 }

docs/static/feature-flags.json

@@ -21,12 +21,6 @@
         "lifecycle": "development",
         "description": "Enables experimental chart plugins"
       },
-      {
-        "name": "CSP_RUNTIME_ALLOWLIST",
-        "default": false,
-        "lifecycle": "development",
-        "description": "Allow users with the \"can write on CSPAllowlist\" permission (Admins by default) to punch holes in the Content Security Policy at runtime, e.g. to allow a new domain to be embedded in a dashboard iframe component. When disabled, the CSP is purely static/deploy-time and the allowlist is ignored."
-      },
       {
         "name": "CSV_UPLOAD_PYARROW_ENGINE",
         "default": false,

docs/yarn.lock

@@ -5698,10 +5698,10 @@ base64-js@^1.3.1, base64-js@^1.5.1:
   resolved "https://registry.npmjs.org/base64-js/-/base64-js-1.5.1.tgz"
   integrity sha512-AKpaYlHn8t4SVbOHCy+b5+KKgvR4vrsD8vbvrbiQJps7fKDTkjkDry6ji0rUJjC0kzbNePLwzxq8iypo41qeWA==
 
-baseline-browser-mapping@^2.10.38, baseline-browser-mapping@^2.9.0, baseline-browser-mapping@^2.9.19:
-  version "2.10.38"
-  resolved "https://registry.yarnpkg.com/baseline-browser-mapping/-/baseline-browser-mapping-2.10.38.tgz#c84d093c4bf7325c5053c279d90f153c66526042"
-  integrity sha512-31/02mVB4yuQU6adKk5SlY6m+mxDwUq5KZkyYgnLrrKl7TEm1+3PyDtDBz2kOv/wxZz41GHsvV1A/u6RmiyBvw==
+baseline-browser-mapping@^2.10.37, baseline-browser-mapping@^2.9.0, baseline-browser-mapping@^2.9.19:
+  version "2.10.37"
+  resolved "https://registry.yarnpkg.com/baseline-browser-mapping/-/baseline-browser-mapping-2.10.37.tgz#3e636475b6b293244e2b23e2c71a2ab9d9e6ba7d"
+  integrity sha512-girxaJ7WZssDOFhzCGZTDKoTa1gk6A1TbflaYTpykLJ4UU9Fz9kx1aREM8JCuoVHbL8X8T/mJg7w2oYSq72Oig==
 
 batch@0.6.1:
   version "0.6.1"
@@ -15246,10 +15246,15 @@ write-file-atomic@^3.0.3:
     signal-exit "^3.0.2"
     typedarray-to-buffer "^3.1.5"
 
-ws@^7.3.1, ws@^8.18.0, ws@^8.2.3, ws@^8.21.0:
-  version "8.21.0"
-  resolved "https://registry.yarnpkg.com/ws/-/ws-8.21.0.tgz#012e413fc07429945121b0c153158c4343086951"
-  integrity sha512-Vsp28b7DRcimFQvrqu2Wek3z1iYxDCWqHYB8Qsnk/S4RfaCQzPGPyBNuVjJV3cd6UiKtUtp6sNM77gWvzcCH+g==
+ws@^7.3.1:
+  version "7.5.10"
+  resolved "https://registry.npmjs.org/ws/-/ws-7.5.10.tgz"
+  integrity sha512-+dbF1tHwZpXcbOJdVOkzLDxZP1ailvSxM6ZweXTegylPny803bFhA+vqBYw4s31NSAk4S2Qz+AKXK9a4wkdjcQ==
+
+ws@^8.18.0, ws@^8.2.3:
+  version "8.20.1"
+  resolved "https://registry.npmjs.org/ws/-/ws-8.20.1.tgz"
+  integrity sha512-It4dO0K5v//JtTXuPkfEOaI3uUN87iYPnqo/ZzqCoG3g8uhA66QUMs/SrM0YK7/NAu+r4LMh/9dq2A7k+rHs+w==
 
 wsl-utils@^0.1.0:
   version "0.1.0"

requirements/base.txt

@@ -315,7 +315,7 @@ pygeohash==3.2.2
     # via apache-superset (pyproject.toml)
 pygments==2.20.0
     # via rich
-pyjwt==2.13.0
+pyjwt==2.12.0
     # via
     #   apache-superset (pyproject.toml)
     #   flask-appbuilder

requirements/development.txt

@@ -769,7 +769,7 @@ pyhive==0.7.0
     # via apache-superset
 pyinstrument==5.1.2
     # via apache-superset
-pyjwt==2.13.0
+pyjwt==2.12.0
     # via
     #   -c requirements/base-constraint.txt
     #   apache-superset

superset-frontend/cypress-base/cypress/e2e/database/modal.test.ts

@@ -0,0 +1,118 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { DATABASE_LIST } from 'cypress/utils/urls';
+
+function closeModal() {
+  cy.get('body').then($body => {
+    if ($body.find('[data-test="database-modal"]').length) {
+      cy.get('[aria-label="Close"]').eq(1).click();
+    }
+  });
+}
+
+describe('Add database', () => {
+  before(() => {
+    cy.visit(DATABASE_LIST);
+  });
+
+  beforeEach(() => {
+    cy.intercept('POST', '**/api/v1/database/validate_parameters/**').as(
+      'validateParams',
+    );
+    cy.intercept('POST', '**/api/v1/database/').as('createDb');
+
+    closeModal();
+    cy.getBySel('btn-create-database').click();
+  });
+
+  it('should open dynamic form', () => {
+    cy.get('.preferred > :nth-child(1)').click();
+
+    cy.get('input[name="host"]').should('have.value', '');
+    cy.get('input[name="port"]').should('have.value', '');
+    cy.get('input[name="database"]').should('have.value', '');
+    cy.get('input[name="username"]').should('have.value', '');
+    cy.get('input[name="password"]').should('have.value', '');
+    cy.get('input[name="database_name"]').should('have.value', '');
+  });
+
+  it('should open sqlalchemy form', () => {
+    cy.get('.preferred > :nth-child(1)').click();
+    cy.getBySel('sqla-connect-btn').click();
+
+    cy.getBySel('database-name-input').should('be.visible');
+    cy.getBySel('sqlalchemy-uri-input').should('be.visible');
+  });
+
+  it('show error alerts on dynamic form for bad host', () => {
+    cy.get('.preferred > :nth-child(1)').click();
+
+    cy.get('input[name="host"]').type('badhost', { force: true });
+    cy.get('input[name="port"]').type('5432', { force: true });
+    cy.get('input[name="username"]').type('testusername', { force: true });
+    cy.get('input[name="database"]').type('testdb', { force: true });
+    cy.get('input[name="password"]').type('testpass', { force: true });
+
+    cy.get('body').click(0, 0);
+
+    cy.wait('@validateParams', { timeout: 30000 });
+
+    cy.getBySel('btn-submit-connection').should('not.be.disabled');
+    cy.getBySel('btn-submit-connection').click({ force: true });
+
+    cy.wait('@validateParams', { timeout: 30000 }).then(() => {
+      cy.wait('@createDb', { timeout: 60000 }).then(() => {
+        cy.contains(
+          '.ant-form-item-explain-error',
+          "The hostname provided can't be resolved",
+        ).should('exist');
+      });
+    });
+  });
+
+  it('show error alerts on dynamic form for bad port', () => {
+    cy.get('.preferred > :nth-child(1)').click();
+
+    cy.get('input[name="host"]').type('localhost', { force: true });
+    cy.get('body').click(0, 0);
+    cy.wait('@validateParams', { timeout: 30000 });
+
+    cy.get('input[name="port"]').type('5430', { force: true });
+    cy.get('input[name="database"]').type('testdb', { force: true });
+    cy.get('input[name="username"]').type('testusername', { force: true });
+
+    cy.wait('@validateParams', { timeout: 30000 });
+
+    cy.get('input[name="password"]').type('testpass', { force: true });
+    cy.wait('@validateParams');
+
+    cy.getBySel('btn-submit-connection').should('not.be.disabled');
+    cy.getBySel('btn-submit-connection').click({ force: true });
+    cy.wait('@validateParams', { timeout: 30000 }).then(() => {
+      cy.get('body').click(0, 0);
+      cy.getBySel('btn-submit-connection').click({ force: true });
+      cy.wait('@createDb', { timeout: 60000 }).then(() => {
+        cy.contains(
+          '.ant-form-item-explain-error',
+          'The port is closed',
+        ).should('exist');
+      });
+    });
+  });
+});

superset-frontend/cypress-base/package-lock.json

@@ -27,6 +27,17 @@
         "tscw-config": "^1.1.2"
       }
     },
+    "node_modules/@ampproject/remapping": {
+      "version": "2.1.2",
+      "resolved": "https://registry.npmjs.org/@ampproject/remapping/-/remapping-2.1.2.tgz",
+      "integrity": "sha512-hoyByceqwKirw7w3Z7gnIIZC3Wx3J484Y3L/cMpXFbr7d9ZQj2mODrirNzcJa+SM3UlpWXYvKV4RlRpFXlWgXg==",
+      "dependencies": {
+        "@jridgewell/trace-mapping": "^0.3.0"
+      },
+      "engines": {
+        "node": ">=6.0.0"
+      }
+    },
     "node_modules/@babel/code-frame": {
       "version": "7.12.11",
       "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.12.11.tgz",
@@ -37,35 +48,33 @@
       }
     },
     "node_modules/@babel/compat-data": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/compat-data/-/compat-data-7.29.7.tgz",
-      "integrity": "sha512-locTkQyKvwIEgBzVrn8693ebc97F2U8ZHjbXwDXJ5Fn2TCpNwTlKcaKLkdHop5c/icOFE7qt7Q9JC5hnKNa6Gg==",
-      "license": "MIT",
+      "version": "7.21.4",
+      "resolved": "https://registry.npmjs.org/@babel/compat-data/-/compat-data-7.21.4.tgz",
+      "integrity": "sha512-/DYyDpeCfaVinT40FPGdkkb+lYSKvsVuMjDAG7jPOWWiM1ibOaB9CXJAlc4d1QpP/U2q2P9jbrSlClKSErd55g==",
       "engines": {
         "node": ">=6.9.0"
       }
     },
     "node_modules/@babel/core": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/core/-/core-7.29.7.tgz",
-      "integrity": "sha512-RgHBCvtjbOK2gXSNBNIkNoEc9qoVEtau3hj8gEqKQuL3HZAibKarWFEI3Lfm6EYKkLalOh8eSrj9b+ch9H/VBA==",
-      "license": "MIT",
+      "version": "7.17.5",
+      "resolved": "https://registry.npmjs.org/@babel/core/-/core-7.17.5.tgz",
+      "integrity": "sha512-/BBMw4EvjmyquN5O+t5eh0+YqB3XXJkYD2cjKpYtWOfFy4lQ4UozNSmxAcWT8r2XtZs0ewG+zrfsqeR15i1ajA==",
       "dependencies": {
-        "@babel/code-frame": "^7.29.7",
-        "@babel/generator": "^7.29.7",
-        "@babel/helper-compilation-targets": "^7.29.7",
-        "@babel/helper-module-transforms": "^7.29.7",
-        "@babel/helpers": "^7.29.7",
-        "@babel/parser": "^7.29.7",
-        "@babel/template": "^7.29.7",
-        "@babel/traverse": "^7.29.7",
-        "@babel/types": "^7.29.7",
-        "@jridgewell/remapping": "^2.3.5",
-        "convert-source-map": "^2.0.0",
+        "@ampproject/remapping": "^2.1.0",
+        "@babel/code-frame": "^7.16.7",
+        "@babel/generator": "^7.17.3",
+        "@babel/helper-compilation-targets": "^7.16.7",
+        "@babel/helper-module-transforms": "^7.16.7",
+        "@babel/helpers": "^7.17.2",
+        "@babel/parser": "^7.17.3",
+        "@babel/template": "^7.16.7",
+        "@babel/traverse": "^7.17.3",
+        "@babel/types": "^7.17.0",
+        "convert-source-map": "^1.7.0",
         "debug": "^4.1.0",
         "gensync": "^1.0.0-beta.2",
-        "json5": "^2.2.3",
-        "semver": "^6.3.1"
+        "json5": "^2.1.2",
+        "semver": "^6.3.0"
       },
       "engines": {
         "node": ">=6.9.0"
@@ -76,94 +85,23 @@
       }
     },
     "node_modules/@babel/core/node_modules/@babel/code-frame": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.29.7.tgz",
-      "integrity": "sha512-Aup7aUOfpbAUg2ROOJN6Iw5f9DMBlzu0mIkm/malLQFN/YQgO48wCj0Kxa3sEHJvPVFg7siR+qRInwXd2qhQKw==",
-      "license": "MIT",
+      "version": "7.16.7",
+      "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.16.7.tgz",
+      "integrity": "sha512-iAXqUn8IIeBTNd72xsFlgaXHkMBMt6y4HJp1tIaK465CWLT/fG1aqB7ykr95gHHmlBdGbFeWWfyB4NJJ0nmeIg==",
       "dependencies": {
-        "@babel/helper-validator-identifier": "^7.29.7",
-        "js-tokens": "^4.0.0",
-        "picocolors": "^1.1.1"
+        "@babel/highlight": "^7.16.7"
       },
       "engines": {
         "node": ">=6.9.0"
       }
     },
-    "node_modules/@babel/core/node_modules/@babel/helper-compilation-targets": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/helper-compilation-targets/-/helper-compilation-targets-7.29.7.tgz",
-      "integrity": "sha512-wem6WaBj4NaVYVdNhLPPVacES6ZJ+KBBfSkTMD3YZxbP3rm3Di85tJU5ljaUNhaOynt+Aj0xruhYuzQBt8n71g==",
-      "license": "MIT",
-      "dependencies": {
-        "@babel/compat-data": "^7.29.7",
-        "@babel/helper-validator-option": "^7.29.7",
-        "browserslist": "^4.24.0",
-        "lru-cache": "^5.1.1",
-        "semver": "^6.3.1"
-      },
-      "engines": {
-        "node": ">=6.9.0"
-      }
-    },
-    "node_modules/@babel/core/node_modules/@babel/helper-module-imports": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/helper-module-imports/-/helper-module-imports-7.29.7.tgz",
-      "integrity": "sha512-ejHwrQQYcm9xnTivShn2IDOlIzInN34AXskvq9QicvCtEzq1Vzclu/tKF8Jq1Cg8JG2GL6/EmjgsCT7lXepE3g==",
-      "license": "MIT",
-      "dependencies": {
-        "@babel/traverse": "^7.29.7",
-        "@babel/types": "^7.29.7"
-      },
-      "engines": {
-        "node": ">=6.9.0"
-      }
-    },
-    "node_modules/@babel/core/node_modules/@babel/helper-module-transforms": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/helper-module-transforms/-/helper-module-transforms-7.29.7.tgz",
-      "integrity": "sha512-UPUVSyXbOh627KiCIGQSgwWzGeBKLkaJ9PJEdrngIwMSzxLR4jS4+f1f1jb7VzBbg8nFLaYotvVPFCTqdrmTAg==",
-      "license": "MIT",
-      "dependencies": {
-        "@babel/helper-module-imports": "^7.29.7",
-        "@babel/helper-validator-identifier": "^7.29.7",
-        "@babel/traverse": "^7.29.7"
-      },
-      "engines": {
-        "node": ">=6.9.0"
-      },
-      "peerDependencies": {
-        "@babel/core": "^7.0.0"
-      }
-    },
-    "node_modules/@babel/core/node_modules/convert-source-map": {
-      "version": "2.0.0",
-      "resolved": "https://registry.npmjs.org/convert-source-map/-/convert-source-map-2.0.0.tgz",
-      "integrity": "sha512-Kvp459HrV2FEJ1CAsi1Ku+MY3kasH19TFykTz2xWmMeq6bk2NU3XXvfJ+Q61m0xktWwt+1HSYf3JZsTms3aRJg==",
-      "license": "MIT"
-    },
-    "node_modules/@babel/core/node_modules/lru-cache": {
-      "version": "5.1.1",
-      "resolved": "https://registry.npmjs.org/lru-cache/-/lru-cache-5.1.1.tgz",
-      "integrity": "sha512-KpNARQA3Iwv+jTA0utUVVbrh+Jlrr1Fv0e56GGzAFOXN7dk/FviaDW8LHmK52DlcH4WP2n6gI8vN1aesBFgo9w==",
-      "license": "ISC",
-      "dependencies": {
-        "yallist": "^3.0.2"
-      }
-    },
-    "node_modules/@babel/core/node_modules/yallist": {
-      "version": "3.1.1",
-      "resolved": "https://registry.npmjs.org/yallist/-/yallist-3.1.1.tgz",
-      "integrity": "sha512-a4UGQaWPH59mOXUYnAG2ewncQS4i4F43Tv3JoAM+s2VDAmS9NsK8GpDMLrCHPksFT7h3K6TOoUNn2pb7RoXx4g==",
-      "license": "ISC"
-    },
     "node_modules/@babel/generator": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/generator/-/generator-7.29.7.tgz",
-      "integrity": "sha512-DkXD5OJQaAQIdZ1bt3UZdEnHAn9Imd3IVBdX03UFe+ony9Ojw5pzr9YVKGDY1jt+Gcn/FnGkNf8r+Vj5NOJWtQ==",
-      "license": "MIT",
+      "version": "7.29.1",
+      "resolved": "https://registry.npmjs.org/@babel/generator/-/generator-7.29.1.tgz",
+      "integrity": "sha512-qsaF+9Qcm2Qv8SRIMMscAvG4O3lJ0F1GuMo5HR/Bp02LopNgnZBC/EkbevHFeGs4ls/oPz9v+Bsmzbkbe+0dUw==",
       "dependencies": {
-        "@babel/parser": "^7.29.7",
-        "@babel/types": "^7.29.7",
+        "@babel/parser": "^7.29.0",
+        "@babel/types": "^7.29.0",
         "@jridgewell/gen-mapping": "^0.3.12",
         "@jridgewell/trace-mapping": "^0.3.28",
         "jsesc": "^3.0.2"
@@ -201,7 +139,6 @@
       "version": "7.21.4",
       "resolved": "https://registry.npmjs.org/@babel/helper-compilation-targets/-/helper-compilation-targets-7.21.4.tgz",
       "integrity": "sha512-Fa0tTuOXZ1iL8IeDFUWCzjZcn+sJGd9RZdH9esYVjEejGmzf+FFYQpMi/kZUk2kPy/q1H3/GPw7np8qar/stfg==",
-      "peer": true,
       "dependencies": {
         "@babel/compat-data": "^7.21.4",
         "@babel/helper-validator-option": "^7.21.0",
@@ -220,7 +157,6 @@
       "version": "5.1.1",
       "resolved": "https://registry.npmjs.org/lru-cache/-/lru-cache-5.1.1.tgz",
       "integrity": "sha512-KpNARQA3Iwv+jTA0utUVVbrh+Jlrr1Fv0e56GGzAFOXN7dk/FviaDW8LHmK52DlcH4WP2n6gI8vN1aesBFgo9w==",
-      "peer": true,
       "dependencies": {
         "yallist": "^3.0.2"
       }
@@ -228,8 +164,7 @@
     "node_modules/@babel/helper-compilation-targets/node_modules/yallist": {
       "version": "3.1.1",
       "resolved": "https://registry.npmjs.org/yallist/-/yallist-3.1.1.tgz",
-      "integrity": "sha512-a4UGQaWPH59mOXUYnAG2ewncQS4i4F43Tv3JoAM+s2VDAmS9NsK8GpDMLrCHPksFT7h3K6TOoUNn2pb7RoXx4g==",
-      "peer": true
+      "integrity": "sha512-a4UGQaWPH59mOXUYnAG2ewncQS4i4F43Tv3JoAM+s2VDAmS9NsK8GpDMLrCHPksFT7h3K6TOoUNn2pb7RoXx4g=="
     },
     "node_modules/@babel/helper-create-class-features-plugin": {
       "version": "7.21.4",
@@ -321,10 +256,9 @@
       }
     },
     "node_modules/@babel/helper-globals": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/helper-globals/-/helper-globals-7.29.7.tgz",
-      "integrity": "sha512-3nQVUAtvkKH9zahfWgw96Jc/uFOmjACE1kQz82E2lqWmHBgjzbNlsC22nuQTfahmWeQtTq5nQ/4Nnd2A1wj4zA==",
-      "license": "MIT",
+      "version": "7.28.0",
+      "resolved": "https://registry.npmjs.org/@babel/helper-globals/-/helper-globals-7.28.0.tgz",
+      "integrity": "sha512-+W6cISkXFa1jXsDEdYA8HeevQT/FULhxzR99pxphltZcVaugps53THCeiWA8SguxxpSp3gKPiuYfSWopkLQ4hw==",
       "engines": {
         "node": ">=6.9.0"
       }
@@ -345,7 +279,6 @@
       "version": "7.28.6",
       "resolved": "https://registry.npmjs.org/@babel/helper-module-imports/-/helper-module-imports-7.28.6.tgz",
       "integrity": "sha512-l5XkZK7r7wa9LucGw9LwZyyCUscb4x37JWTPz7swwFE/0FMQAGpiWUZn8u9DzkSBWEcK25jmvubfpw2dnAMdbw==",
-      "peer": true,
       "dependencies": {
         "@babel/traverse": "^7.28.6",
         "@babel/types": "^7.28.6"
@@ -358,7 +291,6 @@
       "version": "7.28.6",
       "resolved": "https://registry.npmjs.org/@babel/helper-module-transforms/-/helper-module-transforms-7.28.6.tgz",
       "integrity": "sha512-67oXFAYr2cDLDVGLXTEABjdBJZ6drElUSI7WKp70NrpyISso3plG9SAGEF6y7zbha/wOzUByWWTJvEDVNIUGcA==",
-      "peer": true,
       "dependencies": {
         "@babel/helper-module-imports": "^7.28.6",
         "@babel/helper-validator-identifier": "^7.28.5",
@@ -464,28 +396,25 @@
       }
     },
     "node_modules/@babel/helper-string-parser": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/helper-string-parser/-/helper-string-parser-7.29.7.tgz",
-      "integrity": "sha512-Pb5ijPrZ89GDH8223L4UP8i6QApWxs04RbPQJTeWDV0/keR2E36MeKnyr6LYmUUvqRRI+Iv87SuF1W6ErINzYw==",
-      "license": "MIT",
+      "version": "7.27.1",
+      "resolved": "https://registry.npmjs.org/@babel/helper-string-parser/-/helper-string-parser-7.27.1.tgz",
+      "integrity": "sha512-qMlSxKbpRlAridDExk92nSobyDdpPijUq2DW6oDnUqd0iOGxmQjyqhMIihI9+zv4LPyZdRje2cavWPbCbWm3eA==",
       "engines": {
         "node": ">=6.9.0"
       }
     },
     "node_modules/@babel/helper-validator-identifier": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/helper-validator-identifier/-/helper-validator-identifier-7.29.7.tgz",
-      "integrity": "sha512-qehxGkRj55h/ff8EMaJ+cYhyaKlHIxqYDn682wQD7RNp9UujOQsHog2uS0r2vzr4pW+sXf90NeeayjcNaX3fFg==",
-      "license": "MIT",
+      "version": "7.28.5",
+      "resolved": "https://registry.npmjs.org/@babel/helper-validator-identifier/-/helper-validator-identifier-7.28.5.tgz",
+      "integrity": "sha512-qSs4ifwzKJSV39ucNjsvc6WVHs6b7S03sOh2OcHF9UHfVPqWWALUsNUVzhSBiItjRZoLHx7nIarVjqKVusUZ1Q==",
       "engines": {
         "node": ">=6.9.0"
       }
     },
     "node_modules/@babel/helper-validator-option": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/helper-validator-option/-/helper-validator-option-7.29.7.tgz",
-      "integrity": "sha512-N9ZErrD+yW5geCDtBqnOoxmR8+tNKiGuxKlDpuJxfsqpa2dFcexaziGAE/qoHLiDDreVNMupxGmSoNlyvsA3gw==",
-      "license": "MIT",
+      "version": "7.21.0",
+      "resolved": "https://registry.npmjs.org/@babel/helper-validator-option/-/helper-validator-option-7.21.0.tgz",
+      "integrity": "sha512-rmL/B8/f0mKS2baE9ZpyTcTavvEuWhTTW8amjzXNvYG4AwBsqTLikfXsEofsJEfKHf+HQVQbFOHy6o+4cnC/fQ==",
       "engines": {
         "node": ">=6.9.0"
       }
@@ -506,13 +435,13 @@
       }
     },
     "node_modules/@babel/helpers": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/helpers/-/helpers-7.29.7.tgz",
-      "integrity": "sha512-1k2lAGRMfHTcwuNYcCNUmaUffmQv8KWMfh2iJUUeRlwlwH4FdNG7mfPI10NPfLHJFThE4Tyr4mv7kTNZOiPuBg==",
+      "version": "7.26.10",
+      "resolved": "https://registry.npmjs.org/@babel/helpers/-/helpers-7.26.10.tgz",
+      "integrity": "sha512-UPYc3SauzZ3JGgj87GgZ89JVdC5dj0AoetR5Bw6wj4niittNyFh6+eOGonYvJ1ao6B8lEa3Q3klS7ADZ53bc5g==",
       "license": "MIT",
       "dependencies": {
-        "@babel/template": "^7.29.7",
-        "@babel/types": "^7.29.7"
+        "@babel/template": "^7.26.9",
+        "@babel/types": "^7.26.10"
       },
       "engines": {
         "node": ">=6.9.0"
@@ -522,7 +451,6 @@
       "version": "7.22.20",
       "resolved": "https://registry.npmjs.org/@babel/highlight/-/highlight-7.22.20.tgz",
       "integrity": "sha512-dkdMCN3py0+ksCgYmGG8jKeGA/8Tk+gJwSYYlFGxG5lmhfKNoAy004YpLxpS1W2J8m/EK2Ew+yOs9pVRwO89mg==",
-      "peer": true,
       "dependencies": {
         "@babel/helper-validator-identifier": "^7.22.20",
         "chalk": "^2.4.2",
@@ -533,12 +461,11 @@
       }
     },
     "node_modules/@babel/parser": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/parser/-/parser-7.29.7.tgz",
-      "integrity": "sha512-hnORnjP/1P/zFEndoeX+n+t1RwWRJiJpM/jO7FW32Kn9r5+sJB2JWOdYo4L6k78j15eCwY3Gm/7364B1EMwtNg==",
-      "license": "MIT",
+      "version": "7.29.3",
+      "resolved": "https://registry.npmjs.org/@babel/parser/-/parser-7.29.3.tgz",
+      "integrity": "sha512-b3ctpQwp+PROvU/cttc4OYl4MzfJUWy6FZg+PMXfzmt/+39iHVF0sDfqay8TQM3JA2EUOyKcFZt75jWriQijsA==",
       "dependencies": {
-        "@babel/types": "^7.29.7"
+        "@babel/types": "^7.29.0"
       },
       "bin": {
         "parser": "bin/babel-parser.js"
@@ -1666,26 +1593,24 @@
       }
     },
     "node_modules/@babel/template": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/template/-/template-7.29.7.tgz",
-      "integrity": "sha512-puq+Gf35oI24FeN11LkoUQFqv9uwNeWpxXZi/Ji3rRIoKAzKnxRaZ+Gkj0vKS9ZCiTESfng1N9LyOyXvo+m+Gg==",
-      "license": "MIT",
+      "version": "7.28.6",
+      "resolved": "https://registry.npmjs.org/@babel/template/-/template-7.28.6.tgz",
+      "integrity": "sha512-YA6Ma2KsCdGb+WC6UpBVFJGXL58MDA6oyONbjyF/+5sBgxY/dwkhLogbMT2GXXyU84/IhRw/2D1Os1B/giz+BQ==",
       "dependencies": {
-        "@babel/code-frame": "^7.29.7",
-        "@babel/parser": "^7.29.7",
-        "@babel/types": "^7.29.7"
+        "@babel/code-frame": "^7.28.6",
+        "@babel/parser": "^7.28.6",
+        "@babel/types": "^7.28.6"
       },
       "engines": {
         "node": ">=6.9.0"
       }
     },
     "node_modules/@babel/template/node_modules/@babel/code-frame": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.29.7.tgz",
-      "integrity": "sha512-Aup7aUOfpbAUg2ROOJN6Iw5f9DMBlzu0mIkm/malLQFN/YQgO48wCj0Kxa3sEHJvPVFg7siR+qRInwXd2qhQKw==",
-      "license": "MIT",
+      "version": "7.29.0",
+      "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.29.0.tgz",
+      "integrity": "sha512-9NhCeYjq9+3uxgdtp20LSiJXJvN0FeCtNGpJxuMFZ1Kv3cWUNb6DOhJwUvcVCzKGR66cw4njwM6hrJLqgOwbcw==",
       "dependencies": {
-        "@babel/helper-validator-identifier": "^7.29.7",
+        "@babel/helper-validator-identifier": "^7.28.5",
         "js-tokens": "^4.0.0",
         "picocolors": "^1.1.1"
       },
@@ -1694,17 +1619,16 @@
       }
     },
     "node_modules/@babel/traverse": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/traverse/-/traverse-7.29.7.tgz",
-      "integrity": "sha512-EhlfNQtZ+NK22w5BM61ciuiq1m58ed33Wr1Xan//ZRTy6hgjnwyCffRYwzsGXdASJSUJ1guZILsErh1eQcl+zw==",
-      "license": "MIT",
+      "version": "7.29.0",
+      "resolved": "https://registry.npmjs.org/@babel/traverse/-/traverse-7.29.0.tgz",
+      "integrity": "sha512-4HPiQr0X7+waHfyXPZpWPfWL/J7dcN1mx9gL6WdQVMbPnF3+ZhSMs8tCxN7oHddJE9fhNE7+lxdnlyemKfJRuA==",
       "dependencies": {
-        "@babel/code-frame": "^7.29.7",
-        "@babel/generator": "^7.29.7",
-        "@babel/helper-globals": "^7.29.7",
-        "@babel/parser": "^7.29.7",
-        "@babel/template": "^7.29.7",
-        "@babel/types": "^7.29.7",
+        "@babel/code-frame": "^7.29.0",
+        "@babel/generator": "^7.29.0",
+        "@babel/helper-globals": "^7.28.0",
+        "@babel/parser": "^7.29.0",
+        "@babel/template": "^7.28.6",
+        "@babel/types": "^7.29.0",
         "debug": "^4.3.1"
       },
       "engines": {
@@ -1712,12 +1636,11 @@
       }
     },
     "node_modules/@babel/traverse/node_modules/@babel/code-frame": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.29.7.tgz",
-      "integrity": "sha512-Aup7aUOfpbAUg2ROOJN6Iw5f9DMBlzu0mIkm/malLQFN/YQgO48wCj0Kxa3sEHJvPVFg7siR+qRInwXd2qhQKw==",
-      "license": "MIT",
+      "version": "7.29.0",
+      "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.29.0.tgz",
+      "integrity": "sha512-9NhCeYjq9+3uxgdtp20LSiJXJvN0FeCtNGpJxuMFZ1Kv3cWUNb6DOhJwUvcVCzKGR66cw4njwM6hrJLqgOwbcw==",
       "dependencies": {
-        "@babel/helper-validator-identifier": "^7.29.7",
+        "@babel/helper-validator-identifier": "^7.28.5",
         "js-tokens": "^4.0.0",
         "picocolors": "^1.1.1"
       },
@@ -1726,13 +1649,12 @@
       }
     },
     "node_modules/@babel/types": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/types/-/types-7.29.7.tgz",
-      "integrity": "sha512-4zBIxpPzowiZpusoFkyGVwakdRJUyuH5PxQ/PrqghfdFWWasvnCdPfQXHrenDai+gyLARulZjZowCOj6fjT4pA==",
-      "license": "MIT",
+      "version": "7.29.0",
+      "resolved": "https://registry.npmjs.org/@babel/types/-/types-7.29.0.tgz",
+      "integrity": "sha512-LwdZHpScM4Qz8Xw2iKSzS+cfglZzJGvofQICy7W7v4caru4EaAmyUuO6BGrbyQ2mYV11W0U8j5mBhd14dd3B0A==",
       "dependencies": {
-        "@babel/helper-string-parser": "^7.29.7",
-        "@babel/helper-validator-identifier": "^7.29.7"
+        "@babel/helper-string-parser": "^7.27.1",
+        "@babel/helper-validator-identifier": "^7.28.5"
       },
       "engines": {
         "node": ">=6.9.0"
@@ -2171,16 +2093,6 @@
         "@jridgewell/trace-mapping": "^0.3.24"
       }
     },
-    "node_modules/@jridgewell/remapping": {
-      "version": "2.3.5",
-      "resolved": "https://registry.npmjs.org/@jridgewell/remapping/-/remapping-2.3.5.tgz",
-      "integrity": "sha512-LI9u/+laYG4Ds1TDKSJW2YPrIlcVYOwi2fUC6xB43lueCjgxV4lffOCZCtYFiH6TNOX+tQKXx97T4IKHbhyHEQ==",
-      "license": "MIT",
-      "dependencies": {
-        "@jridgewell/gen-mapping": "^0.3.5",
-        "@jridgewell/trace-mapping": "^0.3.24"
-      }
-    },
     "node_modules/@jridgewell/resolve-uri": {
       "version": "3.1.0",
       "resolved": "https://registry.npmjs.org/@jridgewell/resolve-uri/-/resolve-uri-3.1.0.tgz",
@@ -3441,7 +3353,6 @@
       "version": "2.4.2",
       "resolved": "https://registry.npmjs.org/chalk/-/chalk-2.4.2.tgz",
       "integrity": "sha512-Mti+f9lpJNcwF4tWV8/OrTTtF1gZi+f8FqlyAdouralcFWFQWF2+NgCHShjkCb+IFBLq9buZwE1xckQU4peSuQ==",
-      "peer": true,
       "dependencies": {
         "ansi-styles": "^3.2.1",
         "escape-string-regexp": "^1.0.5",
@@ -3455,7 +3366,6 @@
       "version": "3.2.1",
       "resolved": "https://registry.npmjs.org/ansi-styles/-/ansi-styles-3.2.1.tgz",
       "integrity": "sha512-VT0ZI6kZRdTh8YyJw3SMbYm/u+NqfsAxEpWO0Pf9sq8/e94WxxOpPKx9FR1FlyCtOVDNOQ+8ntlqFxiRc+r5qA==",
-      "peer": true,
       "dependencies": {
         "color-convert": "^1.9.0"
       },
@@ -3581,7 +3491,6 @@
       "version": "1.9.3",
       "resolved": "https://registry.npmjs.org/color-convert/-/color-convert-1.9.3.tgz",
       "integrity": "sha512-QfAUtd+vFdAtFQcC8CCyYt1fYWxSqAiK2cSD6zDB8N3cpsEBAvRxp9zOGg6G/SHHJYAT88/az/IuDGALsNVbGg==",
-      "peer": true,
       "dependencies": {
         "color-name": "1.1.3"
       }
@@ -3589,8 +3498,7 @@
     "node_modules/color-name": {
       "version": "1.1.3",
       "resolved": "https://registry.npmjs.org/color-name/-/color-name-1.1.3.tgz",
-      "integrity": "sha1-p9BVi9icQveV3UIyj3QIMcpTvCU=",
-      "peer": true
+      "integrity": "sha1-p9BVi9icQveV3UIyj3QIMcpTvCU="
     },
     "node_modules/colorette": {
       "version": "1.4.0",
@@ -5076,7 +4984,6 @@
       "version": "3.0.0",
       "resolved": "https://registry.npmjs.org/has-flag/-/has-flag-3.0.0.tgz",
       "integrity": "sha1-tdRU3CGZriJWmfNGfloH87lVuv0=",
-      "peer": true,
       "engines": {
         "node": ">=4"
       }
@@ -7971,7 +7878,6 @@
       "version": "5.5.0",
       "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-5.5.0.tgz",
       "integrity": "sha512-QjVjwdXIt408MIiAqCX4oUKsgU2EqAGzs2Ppkm4aQYbjm+ZEWEcW4SfFNTr4uMNZma0ey4f5lgLrkB0aX0QMow==",
-      "peer": true,
       "dependencies": {
         "has-flag": "^3.0.0"
       },
@@ -8864,6 +8770,14 @@
     }
   },
   "dependencies": {
+    "@ampproject/remapping": {
+      "version": "2.1.2",
+      "resolved": "https://registry.npmjs.org/@ampproject/remapping/-/remapping-2.1.2.tgz",
+      "integrity": "sha512-hoyByceqwKirw7w3Z7gnIIZC3Wx3J484Y3L/cMpXFbr7d9ZQj2mODrirNzcJa+SM3UlpWXYvKV4RlRpFXlWgXg==",
+      "requires": {
+        "@jridgewell/trace-mapping": "^0.3.0"
+      }
+    },
     "@babel/code-frame": {
       "version": "7.12.11",
       "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.12.11.tgz",
@@ -8874,100 +8788,49 @@
       }
     },
     "@babel/compat-data": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/compat-data/-/compat-data-7.29.7.tgz",
-      "integrity": "sha512-locTkQyKvwIEgBzVrn8693ebc97F2U8ZHjbXwDXJ5Fn2TCpNwTlKcaKLkdHop5c/icOFE7qt7Q9JC5hnKNa6Gg=="
+      "version": "7.21.4",
+      "resolved": "https://registry.npmjs.org/@babel/compat-data/-/compat-data-7.21.4.tgz",
+      "integrity": "sha512-/DYyDpeCfaVinT40FPGdkkb+lYSKvsVuMjDAG7jPOWWiM1ibOaB9CXJAlc4d1QpP/U2q2P9jbrSlClKSErd55g=="
     },
     "@babel/core": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/core/-/core-7.29.7.tgz",
-      "integrity": "sha512-RgHBCvtjbOK2gXSNBNIkNoEc9qoVEtau3hj8gEqKQuL3HZAibKarWFEI3Lfm6EYKkLalOh8eSrj9b+ch9H/VBA==",
+      "version": "7.17.5",
+      "resolved": "https://registry.npmjs.org/@babel/core/-/core-7.17.5.tgz",
+      "integrity": "sha512-/BBMw4EvjmyquN5O+t5eh0+YqB3XXJkYD2cjKpYtWOfFy4lQ4UozNSmxAcWT8r2XtZs0ewG+zrfsqeR15i1ajA==",
       "requires": {
-        "@babel/code-frame": "^7.29.7",
-        "@babel/generator": "^7.29.7",
-        "@babel/helper-compilation-targets": "^7.29.7",
-        "@babel/helper-module-transforms": "^7.29.7",
-        "@babel/helpers": "^7.29.7",
-        "@babel/parser": "^7.29.7",
-        "@babel/template": "^7.29.7",
-        "@babel/traverse": "^7.29.7",
-        "@babel/types": "^7.29.7",
-        "@jridgewell/remapping": "^2.3.5",
-        "convert-source-map": "^2.0.0",
+        "@ampproject/remapping": "^2.1.0",
+        "@babel/code-frame": "^7.16.7",
+        "@babel/generator": "^7.17.3",
+        "@babel/helper-compilation-targets": "^7.16.7",
+        "@babel/helper-module-transforms": "^7.16.7",
+        "@babel/helpers": "^7.17.2",
+        "@babel/parser": "^7.17.3",
+        "@babel/template": "^7.16.7",
+        "@babel/traverse": "^7.17.3",
+        "@babel/types": "^7.17.0",
+        "convert-source-map": "^1.7.0",
         "debug": "^4.1.0",
         "gensync": "^1.0.0-beta.2",
-        "json5": "^2.2.3",
-        "semver": "^6.3.1"
+        "json5": "^2.1.2",
+        "semver": "^6.3.0"
       },
       "dependencies": {
         "@babel/code-frame": {
-          "version": "7.29.7",
-          "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.29.7.tgz",
-          "integrity": "sha512-Aup7aUOfpbAUg2ROOJN6Iw5f9DMBlzu0mIkm/malLQFN/YQgO48wCj0Kxa3sEHJvPVFg7siR+qRInwXd2qhQKw==",
+          "version": "7.16.7",
+          "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.16.7.tgz",
+          "integrity": "sha512-iAXqUn8IIeBTNd72xsFlgaXHkMBMt6y4HJp1tIaK465CWLT/fG1aqB7ykr95gHHmlBdGbFeWWfyB4NJJ0nmeIg==",
           "requires": {
-            "@babel/helper-validator-identifier": "^7.29.7",
-            "js-tokens": "^4.0.0",
-            "picocolors": "^1.1.1"
+            "@babel/highlight": "^7.16.7"
           }
-        },
-        "@babel/helper-compilation-targets": {
-          "version": "7.29.7",
-          "resolved": "https://registry.npmjs.org/@babel/helper-compilation-targets/-/helper-compilation-targets-7.29.7.tgz",
-          "integrity": "sha512-wem6WaBj4NaVYVdNhLPPVacES6ZJ+KBBfSkTMD3YZxbP3rm3Di85tJU5ljaUNhaOynt+Aj0xruhYuzQBt8n71g==",
-          "requires": {
-            "@babel/compat-data": "^7.29.7",
-            "@babel/helper-validator-option": "^7.29.7",
-            "browserslist": "^4.24.0",
-            "lru-cache": "^5.1.1",
-            "semver": "^6.3.1"
-          }
-        },
-        "@babel/helper-module-imports": {
-          "version": "7.29.7",
-          "resolved": "https://registry.npmjs.org/@babel/helper-module-imports/-/helper-module-imports-7.29.7.tgz",
-          "integrity": "sha512-ejHwrQQYcm9xnTivShn2IDOlIzInN34AXskvq9QicvCtEzq1Vzclu/tKF8Jq1Cg8JG2GL6/EmjgsCT7lXepE3g==",
-          "requires": {
-            "@babel/traverse": "^7.29.7",
-            "@babel/types": "^7.29.7"
-          }
-        },
-        "@babel/helper-module-transforms": {
-          "version": "7.29.7",
-          "resolved": "https://registry.npmjs.org/@babel/helper-module-transforms/-/helper-module-transforms-7.29.7.tgz",
-          "integrity": "sha512-UPUVSyXbOh627KiCIGQSgwWzGeBKLkaJ9PJEdrngIwMSzxLR4jS4+f1f1jb7VzBbg8nFLaYotvVPFCTqdrmTAg==",
-          "requires": {
-            "@babel/helper-module-imports": "^7.29.7",
-            "@babel/helper-validator-identifier": "^7.29.7",
-            "@babel/traverse": "^7.29.7"
-          }
-        },
-        "convert-source-map": {
-          "version": "2.0.0",
-          "resolved": "https://registry.npmjs.org/convert-source-map/-/convert-source-map-2.0.0.tgz",
-          "integrity": "sha512-Kvp459HrV2FEJ1CAsi1Ku+MY3kasH19TFykTz2xWmMeq6bk2NU3XXvfJ+Q61m0xktWwt+1HSYf3JZsTms3aRJg=="
-        },
-        "lru-cache": {
-          "version": "5.1.1",
-          "resolved": "https://registry.npmjs.org/lru-cache/-/lru-cache-5.1.1.tgz",
-          "integrity": "sha512-KpNARQA3Iwv+jTA0utUVVbrh+Jlrr1Fv0e56GGzAFOXN7dk/FviaDW8LHmK52DlcH4WP2n6gI8vN1aesBFgo9w==",
-          "requires": {
-            "yallist": "^3.0.2"
-          }
-        },
-        "yallist": {
-          "version": "3.1.1",
-          "resolved": "https://registry.npmjs.org/yallist/-/yallist-3.1.1.tgz",
-          "integrity": "sha512-a4UGQaWPH59mOXUYnAG2ewncQS4i4F43Tv3JoAM+s2VDAmS9NsK8GpDMLrCHPksFT7h3K6TOoUNn2pb7RoXx4g=="
         }
       }
     },
     "@babel/generator": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/generator/-/generator-7.29.7.tgz",
-      "integrity": "sha512-DkXD5OJQaAQIdZ1bt3UZdEnHAn9Imd3IVBdX03UFe+ony9Ojw5pzr9YVKGDY1jt+Gcn/FnGkNf8r+Vj5NOJWtQ==",
+      "version": "7.29.1",
+      "resolved": "https://registry.npmjs.org/@babel/generator/-/generator-7.29.1.tgz",
+      "integrity": "sha512-qsaF+9Qcm2Qv8SRIMMscAvG4O3lJ0F1GuMo5HR/Bp02LopNgnZBC/EkbevHFeGs4ls/oPz9v+Bsmzbkbe+0dUw==",
       "requires": {
-        "@babel/parser": "^7.29.7",
-        "@babel/types": "^7.29.7",
+        "@babel/parser": "^7.29.0",
+        "@babel/types": "^7.29.0",
         "@jridgewell/gen-mapping": "^0.3.12",
         "@jridgewell/trace-mapping": "^0.3.28",
         "jsesc": "^3.0.2"
@@ -8996,7 +8859,6 @@
       "version": "7.21.4",
       "resolved": "https://registry.npmjs.org/@babel/helper-compilation-targets/-/helper-compilation-targets-7.21.4.tgz",
       "integrity": "sha512-Fa0tTuOXZ1iL8IeDFUWCzjZcn+sJGd9RZdH9esYVjEejGmzf+FFYQpMi/kZUk2kPy/q1H3/GPw7np8qar/stfg==",
-      "peer": true,
       "requires": {
         "@babel/compat-data": "^7.21.4",
         "@babel/helper-validator-option": "^7.21.0",
@@ -9009,7 +8871,6 @@
           "version": "5.1.1",
           "resolved": "https://registry.npmjs.org/lru-cache/-/lru-cache-5.1.1.tgz",
           "integrity": "sha512-KpNARQA3Iwv+jTA0utUVVbrh+Jlrr1Fv0e56GGzAFOXN7dk/FviaDW8LHmK52DlcH4WP2n6gI8vN1aesBFgo9w==",
-          "peer": true,
           "requires": {
             "yallist": "^3.0.2"
           }
@@ -9017,8 +8878,7 @@
         "yallist": {
           "version": "3.1.1",
           "resolved": "https://registry.npmjs.org/yallist/-/yallist-3.1.1.tgz",
-          "integrity": "sha512-a4UGQaWPH59mOXUYnAG2ewncQS4i4F43Tv3JoAM+s2VDAmS9NsK8GpDMLrCHPksFT7h3K6TOoUNn2pb7RoXx4g==",
-          "peer": true
+          "integrity": "sha512-a4UGQaWPH59mOXUYnAG2ewncQS4i4F43Tv3JoAM+s2VDAmS9NsK8GpDMLrCHPksFT7h3K6TOoUNn2pb7RoXx4g=="
         }
       }
     },
@@ -9088,9 +8948,9 @@
       }
     },
     "@babel/helper-globals": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/helper-globals/-/helper-globals-7.29.7.tgz",
-      "integrity": "sha512-3nQVUAtvkKH9zahfWgw96Jc/uFOmjACE1kQz82E2lqWmHBgjzbNlsC22nuQTfahmWeQtTq5nQ/4Nnd2A1wj4zA=="
+      "version": "7.28.0",
+      "resolved": "https://registry.npmjs.org/@babel/helper-globals/-/helper-globals-7.28.0.tgz",
+      "integrity": "sha512-+W6cISkXFa1jXsDEdYA8HeevQT/FULhxzR99pxphltZcVaugps53THCeiWA8SguxxpSp3gKPiuYfSWopkLQ4hw=="
     },
     "@babel/helper-member-expression-to-functions": {
       "version": "7.21.0",
@@ -9105,7 +8965,6 @@
       "version": "7.28.6",
       "resolved": "https://registry.npmjs.org/@babel/helper-module-imports/-/helper-module-imports-7.28.6.tgz",
       "integrity": "sha512-l5XkZK7r7wa9LucGw9LwZyyCUscb4x37JWTPz7swwFE/0FMQAGpiWUZn8u9DzkSBWEcK25jmvubfpw2dnAMdbw==",
-      "peer": true,
       "requires": {
         "@babel/traverse": "^7.28.6",
         "@babel/types": "^7.28.6"
@@ -9115,7 +8974,6 @@
       "version": "7.28.6",
       "resolved": "https://registry.npmjs.org/@babel/helper-module-transforms/-/helper-module-transforms-7.28.6.tgz",
       "integrity": "sha512-67oXFAYr2cDLDVGLXTEABjdBJZ6drElUSI7WKp70NrpyISso3plG9SAGEF6y7zbha/wOzUByWWTJvEDVNIUGcA==",
-      "peer": true,
       "requires": {
         "@babel/helper-module-imports": "^7.28.6",
         "@babel/helper-validator-identifier": "^7.28.5",
@@ -9191,19 +9049,19 @@
       }
     },
     "@babel/helper-string-parser": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/helper-string-parser/-/helper-string-parser-7.29.7.tgz",
-      "integrity": "sha512-Pb5ijPrZ89GDH8223L4UP8i6QApWxs04RbPQJTeWDV0/keR2E36MeKnyr6LYmUUvqRRI+Iv87SuF1W6ErINzYw=="
+      "version": "7.27.1",
+      "resolved": "https://registry.npmjs.org/@babel/helper-string-parser/-/helper-string-parser-7.27.1.tgz",
+      "integrity": "sha512-qMlSxKbpRlAridDExk92nSobyDdpPijUq2DW6oDnUqd0iOGxmQjyqhMIihI9+zv4LPyZdRje2cavWPbCbWm3eA=="
     },
     "@babel/helper-validator-identifier": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/helper-validator-identifier/-/helper-validator-identifier-7.29.7.tgz",
-      "integrity": "sha512-qehxGkRj55h/ff8EMaJ+cYhyaKlHIxqYDn682wQD7RNp9UujOQsHog2uS0r2vzr4pW+sXf90NeeayjcNaX3fFg=="
+      "version": "7.28.5",
+      "resolved": "https://registry.npmjs.org/@babel/helper-validator-identifier/-/helper-validator-identifier-7.28.5.tgz",
+      "integrity": "sha512-qSs4ifwzKJSV39ucNjsvc6WVHs6b7S03sOh2OcHF9UHfVPqWWALUsNUVzhSBiItjRZoLHx7nIarVjqKVusUZ1Q=="
     },
     "@babel/helper-validator-option": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/helper-validator-option/-/helper-validator-option-7.29.7.tgz",
-      "integrity": "sha512-N9ZErrD+yW5geCDtBqnOoxmR8+tNKiGuxKlDpuJxfsqpa2dFcexaziGAE/qoHLiDDreVNMupxGmSoNlyvsA3gw=="
+      "version": "7.21.0",
+      "resolved": "https://registry.npmjs.org/@babel/helper-validator-option/-/helper-validator-option-7.21.0.tgz",
+      "integrity": "sha512-rmL/B8/f0mKS2baE9ZpyTcTavvEuWhTTW8amjzXNvYG4AwBsqTLikfXsEofsJEfKHf+HQVQbFOHy6o+4cnC/fQ=="
     },
     "@babel/helper-wrap-function": {
       "version": "7.20.5",
@@ -9218,19 +9076,18 @@
       }
     },
     "@babel/helpers": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/helpers/-/helpers-7.29.7.tgz",
-      "integrity": "sha512-1k2lAGRMfHTcwuNYcCNUmaUffmQv8KWMfh2iJUUeRlwlwH4FdNG7mfPI10NPfLHJFThE4Tyr4mv7kTNZOiPuBg==",
+      "version": "7.26.10",
+      "resolved": "https://registry.npmjs.org/@babel/helpers/-/helpers-7.26.10.tgz",
+      "integrity": "sha512-UPYc3SauzZ3JGgj87GgZ89JVdC5dj0AoetR5Bw6wj4niittNyFh6+eOGonYvJ1ao6B8lEa3Q3klS7ADZ53bc5g==",
       "requires": {
-        "@babel/template": "^7.29.7",
-        "@babel/types": "^7.29.7"
+        "@babel/template": "^7.26.9",
+        "@babel/types": "^7.26.10"
       }
     },
     "@babel/highlight": {
       "version": "7.22.20",
       "resolved": "https://registry.npmjs.org/@babel/highlight/-/highlight-7.22.20.tgz",
       "integrity": "sha512-dkdMCN3py0+ksCgYmGG8jKeGA/8Tk+gJwSYYlFGxG5lmhfKNoAy004YpLxpS1W2J8m/EK2Ew+yOs9pVRwO89mg==",
-      "peer": true,
       "requires": {
         "@babel/helper-validator-identifier": "^7.22.20",
         "chalk": "^2.4.2",
@@ -9238,11 +9095,11 @@
       }
     },
     "@babel/parser": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/parser/-/parser-7.29.7.tgz",
-      "integrity": "sha512-hnORnjP/1P/zFEndoeX+n+t1RwWRJiJpM/jO7FW32Kn9r5+sJB2JWOdYo4L6k78j15eCwY3Gm/7364B1EMwtNg==",
+      "version": "7.29.3",
+      "resolved": "https://registry.npmjs.org/@babel/parser/-/parser-7.29.3.tgz",
+      "integrity": "sha512-b3ctpQwp+PROvU/cttc4OYl4MzfJUWy6FZg+PMXfzmt/+39iHVF0sDfqay8TQM3JA2EUOyKcFZt75jWriQijsA==",
       "requires": {
-        "@babel/types": "^7.29.7"
+        "@babel/types": "^7.29.0"
       }
     },
     "@babel/plugin-bugfix-safari-id-destructuring-collision-in-function-expression": {
@@ -9994,21 +9851,21 @@
       }
     },
     "@babel/template": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/template/-/template-7.29.7.tgz",
-      "integrity": "sha512-puq+Gf35oI24FeN11LkoUQFqv9uwNeWpxXZi/Ji3rRIoKAzKnxRaZ+Gkj0vKS9ZCiTESfng1N9LyOyXvo+m+Gg==",
+      "version": "7.28.6",
+      "resolved": "https://registry.npmjs.org/@babel/template/-/template-7.28.6.tgz",
+      "integrity": "sha512-YA6Ma2KsCdGb+WC6UpBVFJGXL58MDA6oyONbjyF/+5sBgxY/dwkhLogbMT2GXXyU84/IhRw/2D1Os1B/giz+BQ==",
       "requires": {
-        "@babel/code-frame": "^7.29.7",
-        "@babel/parser": "^7.29.7",
-        "@babel/types": "^7.29.7"
+        "@babel/code-frame": "^7.28.6",
+        "@babel/parser": "^7.28.6",
+        "@babel/types": "^7.28.6"
       },
       "dependencies": {
         "@babel/code-frame": {
-          "version": "7.29.7",
-          "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.29.7.tgz",
-          "integrity": "sha512-Aup7aUOfpbAUg2ROOJN6Iw5f9DMBlzu0mIkm/malLQFN/YQgO48wCj0Kxa3sEHJvPVFg7siR+qRInwXd2qhQKw==",
+          "version": "7.29.0",
+          "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.29.0.tgz",
+          "integrity": "sha512-9NhCeYjq9+3uxgdtp20LSiJXJvN0FeCtNGpJxuMFZ1Kv3cWUNb6DOhJwUvcVCzKGR66cw4njwM6hrJLqgOwbcw==",
           "requires": {
-            "@babel/helper-validator-identifier": "^7.29.7",
+            "@babel/helper-validator-identifier": "^7.28.5",
             "js-tokens": "^4.0.0",
             "picocolors": "^1.1.1"
           }
@@ -10016,25 +9873,25 @@
       }
     },
     "@babel/traverse": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/traverse/-/traverse-7.29.7.tgz",
-      "integrity": "sha512-EhlfNQtZ+NK22w5BM61ciuiq1m58ed33Wr1Xan//ZRTy6hgjnwyCffRYwzsGXdASJSUJ1guZILsErh1eQcl+zw==",
+      "version": "7.29.0",
+      "resolved": "https://registry.npmjs.org/@babel/traverse/-/traverse-7.29.0.tgz",
+      "integrity": "sha512-4HPiQr0X7+waHfyXPZpWPfWL/J7dcN1mx9gL6WdQVMbPnF3+ZhSMs8tCxN7oHddJE9fhNE7+lxdnlyemKfJRuA==",
       "requires": {
-        "@babel/code-frame": "^7.29.7",
-        "@babel/generator": "^7.29.7",
-        "@babel/helper-globals": "^7.29.7",
-        "@babel/parser": "^7.29.7",
-        "@babel/template": "^7.29.7",
-        "@babel/types": "^7.29.7",
+        "@babel/code-frame": "^7.29.0",
+        "@babel/generator": "^7.29.0",
+        "@babel/helper-globals": "^7.28.0",
+        "@babel/parser": "^7.29.0",
+        "@babel/template": "^7.28.6",
+        "@babel/types": "^7.29.0",
         "debug": "^4.3.1"
       },
       "dependencies": {
         "@babel/code-frame": {
-          "version": "7.29.7",
-          "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.29.7.tgz",
-          "integrity": "sha512-Aup7aUOfpbAUg2ROOJN6Iw5f9DMBlzu0mIkm/malLQFN/YQgO48wCj0Kxa3sEHJvPVFg7siR+qRInwXd2qhQKw==",
+          "version": "7.29.0",
+          "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.29.0.tgz",
+          "integrity": "sha512-9NhCeYjq9+3uxgdtp20LSiJXJvN0FeCtNGpJxuMFZ1Kv3cWUNb6DOhJwUvcVCzKGR66cw4njwM6hrJLqgOwbcw==",
           "requires": {
-            "@babel/helper-validator-identifier": "^7.29.7",
+            "@babel/helper-validator-identifier": "^7.28.5",
             "js-tokens": "^4.0.0",
             "picocolors": "^1.1.1"
           }
@@ -10042,12 +9899,12 @@
       }
     },
     "@babel/types": {
-      "version": "7.29.7",
-      "resolved": "https://registry.npmjs.org/@babel/types/-/types-7.29.7.tgz",
-      "integrity": "sha512-4zBIxpPzowiZpusoFkyGVwakdRJUyuH5PxQ/PrqghfdFWWasvnCdPfQXHrenDai+gyLARulZjZowCOj6fjT4pA==",
+      "version": "7.29.0",
+      "resolved": "https://registry.npmjs.org/@babel/types/-/types-7.29.0.tgz",
+      "integrity": "sha512-LwdZHpScM4Qz8Xw2iKSzS+cfglZzJGvofQICy7W7v4caru4EaAmyUuO6BGrbyQ2mYV11W0U8j5mBhd14dd3B0A==",
       "requires": {
-        "@babel/helper-string-parser": "^7.29.7",
-        "@babel/helper-validator-identifier": "^7.29.7"
+        "@babel/helper-string-parser": "^7.27.1",
+        "@babel/helper-validator-identifier": "^7.28.5"
       }
     },
     "@colors/colors": {
@@ -10369,7 +10226,7 @@
         "camelcase": "^5.3.1",
         "find-up": "^4.1.0",
         "get-package-type": "^0.1.0",
-        "js-yaml": "4.1.1",
+        "js-yaml": "^3.13.1",
         "resolve-from": "^5.0.0"
       },
       "dependencies": {
@@ -10379,8 +10236,7 @@
           "integrity": "sha512-8+9WqebbFzpX9OR+Wa6O29asIogeRMzcGtAINdpMHHyAg10f05aSFVBbcEqGf/PXw1EjAZ+q2/bEBg3DvurK3Q=="
         },
         "js-yaml": {
-          "version": "4.1.1",
-          "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-4.1.1.tgz",
+          "version": "https://registry.npmjs.org/js-yaml/-/js-yaml-4.1.1.tgz",
           "integrity": "sha512-qQKT4zQxXl8lLwBtHMWwaTcGfFOZviOJet3Oy/xmGk2gZH677CJM9EvtfdSkgWcATZhj/55JZ0rmy3myCT5lsA==",
           "requires": {
             "argparse": "^2.0.1"
@@ -10402,15 +10258,6 @@
         "@jridgewell/trace-mapping": "^0.3.24"
       }
     },
-    "@jridgewell/remapping": {
-      "version": "2.3.5",
-      "resolved": "https://registry.npmjs.org/@jridgewell/remapping/-/remapping-2.3.5.tgz",
-      "integrity": "sha512-LI9u/+laYG4Ds1TDKSJW2YPrIlcVYOwi2fUC6xB43lueCjgxV4lffOCZCtYFiH6TNOX+tQKXx97T4IKHbhyHEQ==",
-      "requires": {
-        "@jridgewell/gen-mapping": "^0.3.5",
-        "@jridgewell/trace-mapping": "^0.3.24"
-      }
-    },
     "@jridgewell/resolve-uri": {
       "version": "3.1.0",
       "resolved": "https://registry.npmjs.org/@jridgewell/resolve-uri/-/resolve-uri-3.1.0.tgz",
@@ -11470,7 +11317,6 @@
       "version": "2.4.2",
       "resolved": "https://registry.npmjs.org/chalk/-/chalk-2.4.2.tgz",
       "integrity": "sha512-Mti+f9lpJNcwF4tWV8/OrTTtF1gZi+f8FqlyAdouralcFWFQWF2+NgCHShjkCb+IFBLq9buZwE1xckQU4peSuQ==",
-      "peer": true,
       "requires": {
         "ansi-styles": "^3.2.1",
         "escape-string-regexp": "^1.0.5",
@@ -11481,7 +11327,6 @@
           "version": "3.2.1",
           "resolved": "https://registry.npmjs.org/ansi-styles/-/ansi-styles-3.2.1.tgz",
           "integrity": "sha512-VT0ZI6kZRdTh8YyJw3SMbYm/u+NqfsAxEpWO0Pf9sq8/e94WxxOpPKx9FR1FlyCtOVDNOQ+8ntlqFxiRc+r5qA==",
-          "peer": true,
           "requires": {
             "color-convert": "^1.9.0"
           }
@@ -11574,7 +11419,6 @@
       "version": "1.9.3",
       "resolved": "https://registry.npmjs.org/color-convert/-/color-convert-1.9.3.tgz",
       "integrity": "sha512-QfAUtd+vFdAtFQcC8CCyYt1fYWxSqAiK2cSD6zDB8N3cpsEBAvRxp9zOGg6G/SHHJYAT88/az/IuDGALsNVbGg==",
-      "peer": true,
       "requires": {
         "color-name": "1.1.3"
       }
@@ -11582,8 +11426,7 @@
     "color-name": {
       "version": "1.1.3",
       "resolved": "https://registry.npmjs.org/color-name/-/color-name-1.1.3.tgz",
-      "integrity": "sha1-p9BVi9icQveV3UIyj3QIMcpTvCU=",
-      "peer": true
+      "integrity": "sha1-p9BVi9icQveV3UIyj3QIMcpTvCU="
     },
     "colorette": {
       "version": "1.4.0",
@@ -12703,8 +12546,7 @@
     "has-flag": {
       "version": "3.0.0",
       "resolved": "https://registry.npmjs.org/has-flag/-/has-flag-3.0.0.tgz",
-      "integrity": "sha1-tdRU3CGZriJWmfNGfloH87lVuv0=",
-      "peer": true
+      "integrity": "sha1-tdRU3CGZriJWmfNGfloH87lVuv0="
     },
     "has-symbols": {
       "version": "1.1.0",
@@ -13030,7 +12872,7 @@
       "resolved": "https://registry.npmjs.org/istanbul-lib-instrument/-/istanbul-lib-instrument-4.0.3.tgz",
       "integrity": "sha512-BXgQl9kf4WTCPCCpmFGoJkz/+uhvm7h7PFKUYxh7qarQd3ER33vHG//qaE8eN25l07YqZPpHXU9I09l/RD5aGQ==",
       "requires": {
-        "@babel/core": "^7.29.6",
+        "@babel/core": "^7.7.5",
         "@istanbuljs/schema": "^0.1.2",
         "istanbul-lib-coverage": "^3.0.0",
         "semver": "^6.3.0"
@@ -14738,7 +14580,6 @@
       "version": "5.5.0",
       "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-5.5.0.tgz",
       "integrity": "sha512-QjVjwdXIt408MIiAqCX4oUKsgU2EqAGzs2Ppkm4aQYbjm+ZEWEcW4SfFNTr4uMNZma0ey4f5lgLrkB0aX0QMow==",
-      "peer": true,
       "requires": {
         "has-flag": "^3.0.0"
       }

superset-frontend/cypress-base/package.json

@@ -34,7 +34,6 @@
     "tscw-config": "^1.1.2"
   },
   "overrides": {
-    "@babel/core": "^7.29.6",
     "cypress": {
       "form-data": "^2.3.4"
     },

superset-frontend/package.json

@@ -192,13 +192,13 @@
     "json-bigint": "^1.0.0",
     "json-stringify-pretty-compact": "^4.0.0",
     "lodash": "^4.18.1",
-    "mapbox-gl": "^3.25.0",
+    "mapbox-gl": "^3.24.1",
     "markdown-to-jsx": "^9.8.2",
     "match-sorter": "^8.3.0",
     "memoize-one": "^6.0.0",
     "mousetrap": "^1.6.5",
     "mustache": "^4.2.0",
-    "nanoid": "^5.1.14",
+    "nanoid": "^5.1.11",
     "ol": "^10.9.0",
     "query-string": "9.4.0",
     "re-resizable": "^6.11.2",
@@ -303,7 +303,7 @@
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "babel-plugin-jsx-remove-data-test-id": "^3.0.0",
     "babel-plugin-lodash": "^3.3.4",
-    "baseline-browser-mapping": "^2.10.38",
+    "baseline-browser-mapping": "^2.10.37",
     "cheerio": "1.2.0",
     "concurrently": "^10.0.3",
     "copy-webpack-plugin": "^14.0.0",
@@ -350,7 +350,7 @@
     "process": "^0.11.10",
     "react-dnd-test-backend": "^16.0.1",
     "react-refresh": "^0.18.0",
-    "react-resizable": "^4.0.2",
+    "react-resizable": "^4.0.1",
     "redux-mock-store": "^1.5.4",
     "source-map": "^0.7.6",
     "source-map-support": "^0.5.21",
@@ -388,10 +388,6 @@
   "overrides": {
     "uuid": "$uuid",
     "core-js": "^3.38.1",
-    "dompurify": "^3.4.11",
-    "esbuild": "^0.28.1",
-    "http-proxy-middleware": "^2.0.10",
-    "tar": "^7.5.16",
     "puppeteer": "^22.4.1",
     "remark-gfm": "^3.0.1",
     "underscore": "^1.13.7",

superset-frontend/packages/superset-core/package.json

@@ -18,22 +18,10 @@
       "types": "./lib/authentication/index.d.ts",
       "default": "./lib/authentication/index.js"
     },
-    "./chat": {
-      "types": "./lib/chat/index.d.ts",
-      "default": "./lib/chat/index.js"
-    },
-    "./navigation": {
-      "types": "./lib/navigation/index.d.ts",
-      "default": "./lib/navigation/index.js"
-    },
     "./commands": {
       "types": "./lib/commands/index.d.ts",
       "default": "./lib/commands/index.js"
     },
-    "./dashboardComponents": {
-      "types": "./lib/dashboardComponents/index.d.ts",
-      "default": "./lib/dashboardComponents/index.js"
-    },
     "./editors": {
       "types": "./lib/editors/index.d.ts",
       "default": "./lib/editors/index.js"

superset-frontend/packages/superset-core/src/chat/index.ts

@@ -1,156 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * @fileoverview Chat contribution API for Superset extensions.
- *
- * Chat is a dedicated contribution type: an extension registers
- * a chat via {@link registerChat} and the host owns where and how it is
- * mounted. The host applies singleton resolution — multiple chat extensions
- * may register, but exactly one is active at a time.
- *
- * @example
- * ```typescript
- * import { chat } from '@apache-superset/core';
- *
- * chat.registerChat(
- *   { id: 'acme.chat', name: 'Acme Chat' },
- *   AcmeTrigger,
- *   AcmePanel,
- * );
- * ```
- */
-
-import { ComponentType } from 'react';
-import type { Disposable, Event } from '../common';
-
-export interface Chat {
-  /** The unique identifier for the chat. */
-  id: string;
-  /** The display name of the chat. */
-  name: string;
-  /** Optional description of the chat. */
-  description?: string;
-}
-
-export type DisplayMode = 'floating' | 'panel';
-
-/**
- * Registers a chat provider. Only one chat is active at a time; the most
- * recently registered chat wins. Disposing the returned Disposable unregisters
- * the chat.
- *
- * @param chat The chat descriptor (id, name).
- * @param trigger The trigger component — the collapsed bubble entry point.
- *   Owns dynamic state such as unread counts.
- * @param panel The panel component, rendered in either display mode. In
- *   'floating' mode it appears as an overlay; in 'panel' mode it is docked
- *   alongside the main content.
- * @returns A Disposable that unregisters the chat when disposed.
- *
- * @example
- * ```typescript
- * chat.registerChat(
- *   { id: 'acme.chat', name: 'Acme Chat' },
- *   AcmeTrigger,
- *   AcmePanel,
- * );
- * ```
- */
-export declare function registerChat(
-  chat: Chat,
-  trigger: ComponentType,
-  panel: ComponentType,
-): Disposable;
-
-/**
- * Returns the active chat descriptor, or undefined if none is registered.
- */
-export declare function getChat(): Chat | undefined;
-
-/**
- * Event fired when a chat is registered.
- */
-export declare const onDidRegisterChat: Event<Chat>;
-
-/**
- * Event fired when a chat is unregistered.
- */
-export declare const onDidUnregisterChat: Event<Chat>;
-
-/**
- * Opens the active chat's panel.
- *
- * Acts on whichever chat is active, regardless of which extension calls it.
- * No-op when no chat is registered or the panel is already open.
- */
-export declare function open(): void;
-
-/**
- * Closes the active chat's panel.
- *
- * Acts on whichever chat is active, regardless of which extension calls it.
- * No-op when the panel is not open.
- */
-export declare function close(): void;
-
-/**
- * Returns whether the active chat's panel is currently open.
- */
-export declare function isOpen(): boolean;
-
-/**
- * Event fired when the chat panel opens. Also fired by the host's own
- * controls, not only by an extension's open() call.
- */
-export declare const onDidOpen: Event<void>;
-
-/**
- * Event fired when the chat panel closes, whether triggered by an extension
- * or by the host.
- */
-export declare const onDidClose: Event<void>;
-
-/**
- * Returns the current display mode.
- */
-export declare function getDisplayMode(): DisplayMode;
-
-/**
- * Sets the display mode. The mode is host-global and applies to whichever
- * chat is active. Use {@link onDidChangeDisplayMode} to observe all changes,
- * including those triggered by the host.
- */
-export declare function setDisplayMode(displayMode: DisplayMode): void;
-
-/**
- * Event fired when the display mode changes, whether triggered by an
- * extension via setDisplayMode() or by host-provided controls.
- */
-export declare const onDidChangeDisplayMode: Event<DisplayMode>;
-
-/**
- * Event fired when the panel is resized in panel mode. Not all hosts provide
- * a resizer — do not rely on this event firing.
- */
-export declare const onDidResizePanel: Event<{ width: number }>;
-
-// TODO: client actions API — tool availability functions will be added here
-// once the client_actions SIP is finalized. The chat namespace is the
-// intended integration point between the two SIPs.

superset-frontend/packages/superset-core/src/common/index.ts

@@ -223,6 +223,8 @@ export interface Extension {
   dependencies: string[];
   /** Human-readable description of the extension */
   description: string;
+  /** List of other extensions that this extension depends on */
+  extensionDependencies: string[];
   /** Unique identifier for the extension */
   id: string;
   /** Human-readable name of the extension */

superset-frontend/packages/superset-core/src/contributions/index.ts

@@ -23,12 +23,10 @@
  * This module defines the aggregate interfaces used by the extension.json
  * manifest and the `superset-extensions` build command. Individual metadata
  * types are defined in their respective namespace modules (commands, views,
- * menus, editors, chat) and re-exported here for the manifest schema.
+ * menus, editors) and re-exported here for the manifest schema.
  */
 
-import { Chat } from '../chat';
 import { Command } from '../commands';
-import { DashboardComponentDefinition } from '../dashboardComponents';
 import { View } from '../views';
 import { Menu } from '../menus';
 import { Editor } from '../editors';
@@ -73,8 +71,7 @@ export interface MenuContributions {
 }
 
 /**
- * Aggregates all contributions (commands, menus, views, editors, and chat)
- * provided by an extension or module.
+ * Aggregates all contributions (commands, menus, views, and editors) provided by an extension or module.
  */
 export interface Contributions {
   /** List of commands. */
@@ -85,15 +82,4 @@ export interface Contributions {
   views: ViewContributions;
   /** List of editors. */
   editors?: Editor[];
-  /**
-   * The chat contributed by the extension — at most one per extension, since
-   * the host applies singleton resolution and renders exactly one active
-   * chat at a time.
-   */
-  chat?: Chat;
-  /**
-   * Dashboard layout components contributed by the extension. Each becomes a
-   * first-class, draggable element in the dashboard builder palette.
-   */
-  dashboardComponents?: DashboardComponentDefinition[];
 }

superset-frontend/packages/superset-core/src/dashboardComponents/index.ts

@@ -1,158 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * @fileoverview Dashboard component contribution API for Superset extensions.
- *
- * A dashboard component is a first-class dashboard layout element (like the
- * built-in Markdown or iframe) contributed by an extension. The extension
- * provides a single React component that renders the element's *content*; the
- * host owns the surrounding chrome (drag handle, resize, delete) so the
- * contributed component stays small and the contract stable.
- *
- * This replaces the legacy `DashboardComponentsRegistry` / `DYNAMIC_TYPE`
- * mechanism, which is deprecated.
- *
- * @example
- * ```typescript
- * import { dashboardComponents } from '@apache-superset/core';
- *
- * dashboardComponents.registerDashboardComponent(
- *   {
- *     id: 'acme.weather',
- *     name: 'Weather widget',
- *     icon: 'CloudOutlined',
- *     resizable: true,
- *     defaultMeta: { width: 4, height: 50 },
- *   },
- *   WeatherWidget,
- * );
- * ```
- */
-
-import { ComponentType } from 'react';
-import type { Disposable, Event } from '../common';
-
-/**
- * Props passed by the host to a contributed dashboard component. The host
- * renders this component inside its own drag/resize/delete chrome, so the
- * component only needs to render content (and, in edit mode, its own editor
- * affordances). Persisted state lives in `meta`; mutate it via `updateMeta`.
- */
-export interface DashboardComponentProps {
-  /** The layout item id of this component instance. */
-  id: string;
-  /** The component instance's persisted meta (round-trips in the layout). */
-  meta: Record<string, unknown>;
-  /** Whether the dashboard is in edit mode. */
-  editMode: boolean;
-  /** Shallow-merge a patch into this component's persisted meta. */
-  updateMeta: (patch: Record<string, unknown>) => void;
-}
-
-/**
- * Declarative descriptor for a contributed dashboard component. The behavior
- * fields replace what was historically hardcoded in the dashboard util maps
- * (resizability, default sizing, nesting, etc.).
- */
-export interface DashboardComponentDefinition {
-  /** Namespaced unique id, e.g. "acme.weather" or "superset.iframe". */
-  id: string;
-  /** Human-readable label shown in the builder palette. */
-  name: string;
-  /** Optional longer description. */
-  description?: string;
-  /** Icon id (a known Superset icon name) shown in the palette. */
-  icon?: string;
-  /** Whether instances can be resized. Defaults to true. */
-  resizable?: boolean;
-  /** Default `meta` seeded onto a newly created instance (e.g. width/height). */
-  defaultMeta?: Record<string, unknown>;
-  /**
-   * Whether an instance counts as user content for "is this dashboard empty?"
-   * detection. Defaults to true.
-   */
-  isUserContent?: boolean;
-  /** Minimum width in grid columns. Defaults to 1. */
-  minWidth?: number;
-  /**
-   * Restrict which container types may hold this component (e.g.
-   * `['GRID', 'TAB']`). When omitted, the component is allowed wherever a
-   * standard content leaf is allowed (grid, row, column, tab).
-   */
-  validParents?: string[];
-  /**
-   * Whether a drop into the grid or a tab auto-wraps the component in a row.
-   * Defaults to true (matching built-in content components).
-   */
-  wrapInRow?: boolean;
-}
-
-/**
- * The subset of a definition's behavior that is seeded onto each instance's
- * `meta` at creation, so the dashboard layout engine can honor it (and so it
- * round-trips in the saved layout even if the extension later becomes
- * unavailable). Read by the dashboard util maps; not part of the rendered
- * component's concern.
- */
-export interface DashboardComponentBehaviorMeta {
-  extensionComponentId: string;
-  resizable?: boolean;
-  isUserContent?: boolean;
-  minWidth?: number;
-  validParents?: string[];
-  wrapInRow?: boolean;
-}
-
-/**
- * A registered dashboard component: its definition plus the React component
- * the host renders.
- */
-export interface RegisteredDashboardComponent {
-  definition: DashboardComponentDefinition;
-  Component: ComponentType<DashboardComponentProps>;
-}
-
-/**
- * Registers a dashboard component. Disposing the returned Disposable
- * unregisters it. Registering a second component with the same id replaces the
- * first.
- *
- * @param definition The component descriptor (id, name, behavior).
- * @param component The React component rendering the element's content.
- * @returns A Disposable that unregisters the component when disposed.
- */
-export declare function registerDashboardComponent(
-  definition: DashboardComponentDefinition,
-  component: ComponentType<DashboardComponentProps>,
-): Disposable;
-
-/** Returns the registered component for `id`, or undefined. */
-export declare function getDashboardComponent(
-  id: string,
-): RegisteredDashboardComponent | undefined;
-
-/** Returns all registered dashboard components. */
-export declare function getDashboardComponents(): RegisteredDashboardComponent[];
-
-/** Event fired when a dashboard component is registered. */
-export declare const onDidRegisterDashboardComponent: Event<DashboardComponentDefinition>;
-
-/** Event fired when a dashboard component is unregistered. */
-export declare const onDidUnregisterDashboardComponent: Event<DashboardComponentDefinition>;

superset-frontend/packages/superset-core/src/index.ts

@@ -18,13 +18,10 @@
  */
 export * as common from './common';
 export * as authentication from './authentication';
-export * as chat from './chat';
 export * as commands from './commands';
-export * as dashboardComponents from './dashboardComponents';
 export * as editors from './editors';
 export * as extensions from './extensions';
 export * as menus from './menus';
-export * as navigation from './navigation';
 export * as sqlLab from './sqlLab';
 export * as views from './views';
 export * as contributions from './contributions';

superset-frontend/packages/superset-core/src/navigation/index.ts

@@ -1,81 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * @fileoverview Navigation namespace for Superset extensions.
- *
- * Exposes the current application surface so extensions can react to route
- * changes without polling. Entity-level context (chart, dashboard, dataset)
- * is intentionally not included here — surface-specific namespaces that
- * resolve entity payloads are introduced in later phases.
- */
-
-import { Event } from '../common';
-
-/**
- * The set of top-level application surfaces.
- *
- * `'explore'`, `'dashboard'` and `'dataset'` are the single-entity
- * editing/viewing surfaces. `'chart_list'`, `'dashboard_list'` and
- * `'dataset_list'` are the browse/list surfaces, distinct from those because no
- * single entity is active. `'sqllab'` is the SQL editor where
- * `sqlLab.getCurrentTab()` resolves; `'query_history'` and `'saved_queries'`
- * are the related SQL Lab browse pages, which are not the editor. `'home'` is
- * the welcome surface and the fallback for any route not explicitly enumerated.
- */
-export type Page =
-  | 'dashboard'
-  | 'dashboard_list'
-  | 'explore'
-  | 'chart_list'
-  | 'sqllab'
-  | 'query_history'
-  | 'saved_queries'
-  | 'dataset'
-  | 'dataset_list'
-  | 'home';
-
-/**
- * Returns the current page surface.
- *
- * @example
- * ```typescript
- * const page = navigation.getPage();
- * if (page === 'dashboard') {
- *   // react to being on a dashboard surface
- * }
- * ```
- */
-export declare function getPage(): Page;
-
-/**
- * Event fired whenever the user navigates to a different surface.
- *
- * @example
- * ```typescript
- * const sub = navigation.onDidChangePage(page => {
- *   if (page === 'dashboard') {
- *     // react to navigating onto a dashboard surface
- *   }
- * });
- * // later:
- * sub.dispose();
- * ```
- */
-export declare const onDidChangePage: Event<Page>;

superset-frontend/packages/superset-core/src/views/index.ts

@@ -30,12 +30,12 @@
  *
  * views.registerView(
  *   { id: 'my_ext.result_stats', name: 'Result Stats', location: 'sqllab.panels' },
- *   ResultStatsPanel,
+ *   () => <ResultStatsPanel />,
  * );
  * ```
  */
 
-import { ComponentType } from 'react';
+import { ReactElement } from 'react';
 import { Disposable, Event } from '../common';
 
 /**
@@ -58,7 +58,7 @@ export interface View {
  *
  * @param view The view descriptor (id and name).
  * @param location The location where this view should appear (e.g. "sqllab.panels").
- * @param component The React component to render at that location.
+ * @param provider A function that returns the React element to render.
  * @returns A Disposable that unregisters the view when disposed.
  *
  * @example
@@ -66,14 +66,14 @@ export interface View {
  * views.registerView(
  *   { id: 'my_ext.result_stats', name: 'Result Stats' },
  *   'sqllab.panels',
- *   ResultStatsPanel,
+ *   () => <ResultStatsPanel />,
  * );
  * ```
  */
 export declare function registerView(
   view: View,
   location: string,
-  component: ComponentType,
+  provider: () => ReactElement,
 ): Disposable;
 
 /**

superset-frontend/packages/superset-ui-chart-controls/src/sections/advancedAnalytics.tsx

@@ -132,26 +132,6 @@ export const advancedAnalyticsControls: ControlPanelSectionConfig = {
         },
       },
     ],
-    [
-      {
-        name: 'time_compare_full_range',
-        config: {
-          type: 'CheckboxControl',
-          label: t('Show full range for time shift'),
-          default: false,
-          description: t(
-            'Plot each time-shifted series across its full time range instead ' +
-              'of truncating it to the main series. Useful for comparing a ' +
-              'partial current period (e.g. today so far) against complete ' +
-              'prior periods (e.g. all of yesterday).',
-          ),
-          visibility: ({ controls }) =>
-            Boolean(controls?.time_compare?.value) &&
-            (!Array.isArray(controls?.time_compare?.value) ||
-              controls.time_compare.value.length > 0),
-        },
-      },
-    ],
     [
       {
         name: 'comparison_type',

superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/components/RadioButtonControl.tsx

@@ -60,7 +60,7 @@ export default function RadioButtonControl({
   ...props
 }: RadioButtonControlProps) {
   const normalizedOptions = options.map(normalizeOption);
-  const currentValue = initialValue ?? normalizedOptions[0]?.value;
+  const currentValue = initialValue || normalizedOptions[0].value;
 
   return (
     <div>

superset-frontend/packages/superset-ui-chart-controls/test/shared-controls/components/RadioButtonControl.test.tsx

@@ -359,51 +359,6 @@ test('handles empty options array gracefully', () => {
   expect(container.querySelector('[role="tablist"]')).toBeInTheDocument();
 });
 
-test('currentValue is undefined when options are empty and no value is provided', () => {
-  expect(() => setup({ options: [] })).not.toThrow();
-  const { container } = setup({ options: [] });
-  expect(container.querySelectorAll('[id^="tab-"]').length).toBe(0);
-});
-
-test('preserves falsy numeric value 0 instead of falling back to first option', () => {
-  const { container } = setup({
-    options: [
-      [0, 'Zero'],
-      [1, 'One'],
-      [2, 'Two'],
-    ],
-    value: 0,
-  });
-
-  expect(container.querySelector('#tab-0')).toHaveAttribute(
-    'aria-selected',
-    'true',
-  );
-  expect(container.querySelector('#tab-1')).toHaveAttribute(
-    'aria-selected',
-    'false',
-  );
-});
-
-test('preserves falsy boolean value false instead of falling back to first option', () => {
-  const { container } = setup({
-    options: [
-      [true, 'True'],
-      [false, 'False'],
-    ],
-    value: false,
-  });
-
-  expect(container.querySelector('#tab-true')).toHaveAttribute(
-    'aria-selected',
-    'false',
-  );
-  expect(container.querySelector('#tab-false')).toHaveAttribute(
-    'aria-selected',
-    'true',
-  );
-});
-
 test('renders with hovered prop', () => {
   const { container } = setup({
     label: 'Test',

superset-frontend/packages/superset-ui-core/package.json

@@ -52,7 +52,7 @@
     "parse-ms": "^4.0.0",
     "re-resizable": "^6.11.2",
     "react-ace": "^14.0.1",
-    "react-draggable": "^4.7.0",
+    "react-draggable": "^4.6.0",
     "react-error-boundary": "6.0.0",
     "react-js-cron": "^5.2.0",
     "react-markdown": "^8.0.7",

superset-frontend/packages/superset-ui-core/src/components/SafeMarkdown/SafeMarkdown.tsx

@@ -22,7 +22,7 @@ import rehypeSanitize, { defaultSchema } from 'rehype-sanitize';
 // remark-gfm v4+ requires react-markdown v9+, which requires React 18.
 // Currently pinned to v3.0.1 for compatibility with react-markdown v8 and React 17.
 import remarkGfm from 'remark-gfm';
-import { cloneDeep, mergeWith } from 'lodash';
+import { mergeWith } from 'lodash';
 import { FeatureFlag, isFeatureEnabled } from '../../utils';
 
 interface SafeMarkdownProps {
@@ -85,15 +85,8 @@ export function getOverrideHtmlSchema(
   originalSchema: typeof defaultSchema,
   htmlSchemaOverrides: SafeMarkdownProps['htmlSchemaOverrides'],
 ) {
-  // Merge into a fresh clone: mergeWith mutates its first argument, and the
-  // array customizer concatenates, so merging into the shared defaultSchema
-  // import would progressively widen the sanitization allowlist for every
-  // SafeMarkdown instance app-wide.
-  return mergeWith(
-    cloneDeep(originalSchema),
-    htmlSchemaOverrides,
-    (objValue, srcValue) =>
-      Array.isArray(objValue) ? objValue.concat(srcValue) : undefined,
+  return mergeWith(originalSchema, htmlSchemaOverrides, (objValue, srcValue) =>
+    Array.isArray(objValue) ? objValue.concat(srcValue) : undefined,
   );
 }
 

superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.tsx

@@ -113,7 +113,7 @@ const AsyncSelect = forwardRef(
       allowClear,
       allowNewOptions = false,
       ariaLabel,
-      autoClearSearchValue = true,
+      autoClearSearchValue = false,
       fetchOnlyOnSearch,
       filterOption = true,
       header = null,
@@ -267,12 +267,6 @@ const AsyncSelect = forwardRef(
         });
         fireOnChange();
       }
-      if (autoClearSearchValue) {
-        setInputValue('');
-        if (fetchOnlyOnSearch) {
-          setSelectOptions([]);
-        }
-      }
       onSelect?.(selectedItem, option);
     };
 

superset-frontend/packages/superset-ui-core/src/components/Select/Select.stories.tsx

@@ -404,7 +404,7 @@ AdvancedPlayground.args = {
   autoFocus: true,
   allowNewOptions: false,
   allowClear: false,
-  autoClearSearchValue: true,
+  autoClearSearchValue: false,
   allowSelectAll: true,
   disabled: false,
   invertSelection: false,

superset-frontend/packages/superset-ui-core/src/components/Select/Select.test.tsx

@@ -1146,127 +1146,6 @@ test('pasting an non-existent option should not add it if allowNewOptions is fal
   expect(await findAllSelectOptions()).toHaveLength(0);
 });
 
-// Reference for the bug this tests: https://github.com/apache/superset/issues/32645
-// Dashboard filters with "Dynamically search all filter values" only load a
-// page of options client-side, so a pasted value outside that page used to be
-// silently dropped. allowNewOptionsOnPaste keeps such values so the filter can
-// still apply them.
-test('keeps pasted values outside loaded options when allowNewOptionsOnPaste is true', async () => {
-  const onChange = jest.fn();
-  render(
-    <Select
-      {...defaultProps}
-      mode="multiple"
-      allowNewOptions={false}
-      allowNewOptionsOnPaste
-      onChange={onChange}
-    />,
-  );
-  const input = getElementByClassName('.ant-select-selection-search-input');
-  const paste = createEvent.paste(input, {
-    clipboardData: {
-      // Liam is a loaded option; OutsideValue is not in the loaded page.
-      getData: () => 'Liam,OutsideValue',
-    },
-  });
-  fireEvent(input, paste);
-  await waitFor(() => {
-    const values = [
-      ...getElementsByClassName('.ant-select-selection-item'),
-    ].map(value => value.textContent);
-    // The paste handler appends, so the loaded option resolves first.
-    expect(values).toEqual(['Liam', 'OutsideValue']);
-  });
-  // Assert the unloaded value actually reaches the change handler (the value
-  // that gets applied to the filter query), not just the rendered label.
-  expect(onChange).toHaveBeenCalledWith(
-    expect.arrayContaining([
-      expect.objectContaining({ value: 'OutsideValue' }),
-    ]),
-    expect.anything(),
-  );
-});
-
-test('trims whitespace around pasted comma-separated values', async () => {
-  const onChange = jest.fn();
-  render(
-    <Select
-      {...defaultProps}
-      mode="multiple"
-      allowNewOptions={false}
-      allowNewOptionsOnPaste
-      onChange={onChange}
-    />,
-  );
-  const input = getElementByClassName('.ant-select-selection-search-input');
-  const paste = createEvent.paste(input, {
-    clipboardData: {
-      // Note the space after the comma — it must not leak into the value.
-      getData: () => 'Liam, OutsideValue',
-    },
-  });
-  fireEvent(input, paste);
-  await waitFor(() => {
-    const values = [
-      ...getElementsByClassName('.ant-select-selection-item'),
-    ].map(value => value.textContent);
-    expect(values).toEqual(['Liam', 'OutsideValue']);
-  });
-  expect(onChange).toHaveBeenCalledWith(
-    expect.arrayContaining([
-      expect.objectContaining({ value: 'OutsideValue' }),
-    ]),
-    expect.anything(),
-  );
-});
-
-test('does not create an empty option when pasting blank text', async () => {
-  const onChange = jest.fn();
-  render(
-    <Select
-      {...defaultProps}
-      mode="multiple"
-      allowNewOptions={false}
-      allowNewOptionsOnPaste
-      onChange={onChange}
-    />,
-  );
-  const input = getElementByClassName('.ant-select-selection-search-input');
-  const paste = createEvent.paste(input, {
-    clipboardData: {
-      getData: () => '   ',
-    },
-  });
-  fireEvent(input, paste);
-  await waitFor(() => {
-    const values = [
-      ...getElementsByClassName('.ant-select-selection-item'),
-    ].map(value => value.textContent);
-    expect(values).toEqual([]);
-  });
-  // No empty-string value should ever reach the handler.
-  onChange.mock.calls.forEach(([value]) => {
-    expect(value).not.toContain('');
-  });
-});
-
-test('drops pasted values outside loaded options when allowNewOptionsOnPaste is false', async () => {
-  render(<Select {...defaultProps} mode="multiple" allowNewOptions={false} />);
-  const input = getElementByClassName('.ant-select-selection-search-input');
-  const paste = createEvent.paste(input, {
-    clipboardData: {
-      getData: () => 'Liam,OutsideValue',
-    },
-  });
-  fireEvent(input, paste);
-  await waitFor(() => {
-    const values = [
-      ...getElementsByClassName('.ant-select-selection-item'),
-    ].map(value => value.textContent);
-    expect(values).toEqual(['Liam']);
-  });
-});
-
 test('does not fire onChange if the same value is selected in single mode', async () => {
   const onChange = jest.fn();
   render(<Select {...defaultProps} onChange={onChange} />);

superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx

@@ -91,10 +91,9 @@ const Select = forwardRef(
       className,
       allowClear,
       allowNewOptions = false,
-      allowNewOptionsOnPaste = false,
       allowSelectAll = true,
       ariaLabel,
-      autoClearSearchValue = true,
+      autoClearSearchValue = false,
       filterOption = true,
       header = null,
       headerPosition = 'top',
@@ -334,11 +333,6 @@ const Select = forwardRef(
         });
         fireOnChange();
       }
-      if (autoClearSearchValue) {
-        setInputValue('');
-        setIsSearching(false);
-        setVisibleOptions(fullSelectOptions);
-      }
       onSelect?.(selectedItem, option);
     };
 
@@ -698,34 +692,20 @@ const Select = forwardRef(
         }
       } else {
         const token = tokenSeparators.find(token => pastedText.includes(token));
-        const array = token
-          ? uniq(
-              pastedText
-                .split(token)
-                .map(item => item.trim())
-                .filter(Boolean),
-            )
-          : [pastedText.trim()].filter(Boolean);
+        const array = token ? uniq(pastedText.split(token)) : [pastedText];
 
         const newOptions: SelectOptionsType = [];
-        // When `allowNewOptionsOnPaste` is set, accept pasted values that are
-        // not in the loaded options even if `allowNewOptions` is false. The
-        // full option set is searched server-side and only partially loaded
-        // client-side, so a pasted value can legitimately exist in the dataset
-        // but fall outside the loaded page.
-        const keepUnknownValues = allowNewOptions || allowNewOptionsOnPaste;
 
         const values = array
           .map(item => {
             const option = getOption(item, fullSelectOptions, true);
-            if (!option && keepUnknownValues) {
+            if (!option && allowNewOptions) {
               const newOption = {
                 label: item,
                 value: item,
                 isNewOption: true,
               };
               newOptions.push(newOption);
-              return labelInValue ? { label: item, value: item } : item;
             }
             return getPastedTextValue(item);
           })

superset-frontend/packages/superset-ui-core/src/components/Select/types.ts

@@ -88,18 +88,6 @@ export interface BaseSelectProps extends AntdExposedProps {
    * False by default.
    * */
   allowNewOptions?: boolean;
-  /**
-   * Accept values pasted into the Select even when they are not part of the
-   * currently loaded options and `allowNewOptions` is false. Useful for
-   * selects whose full option set is searched server-side and only partially
-   * loaded on the client (e.g. dashboard filters with "Dynamically search all
-   * filter values"), where a pasted value can legitimately exist in the
-   * dataset but fall outside the loaded page.
-   * Only applies to multi-select paste; single-select paste resolves through
-   * `allowNewOptions` and ignores this flag.
-   * False by default.
-   * */
-  allowNewOptionsOnPaste?: boolean;
   /**
    * It adds the aria-label tag for accessibility standards.
    * Must be plain English and localized.

superset-frontend/packages/superset-ui-core/src/connection/SupersetClient.ts

@@ -52,7 +52,6 @@ const SupersetClient: SupersetClientInterface = {
   request: request => getInstance().request(request),
   getCSRFToken: () => getInstance().getCSRFToken(),
   getUrl: (...args) => getInstance().getUrl(...args),
-  postBlob: (endpoint, payload) => getInstance().postBlob(endpoint, payload),
   get guestTokenHeaderName() {
     try {
       return getInstance().guestTokenHeaderName;

superset-frontend/packages/superset-ui-core/src/connection/SupersetClientClass.ts

@@ -150,26 +150,6 @@ export default class SupersetClientClass {
     }
   }
 
-  /**
-   * POST request that returns a blob for file downloads.
-   * Unlike postForm, this uses AJAX so errors can be caught and handled.
-   * @param endpoint - API endpoint
-   * @param payload - Request payload
-   * @returns Promise resolving to Response with blob
-   */
-  async postBlob(
-    endpoint: string,
-    payload: Record<string, any>,
-  ): Promise<Response> {
-    await this.ensureAuth();
-    return this.post({
-      endpoint,
-      postPayload: payload,
-      parseMethod: 'raw',
-      stringify: false,
-    });
-  }
-
   async reAuthenticate() {
     return this.init(true);
   }

superset-frontend/packages/superset-ui-core/src/connection/types.ts

@@ -152,7 +152,6 @@ export interface SupersetClientInterface extends Pick<
   | 'get'
   | 'post'
   | 'postForm'
-  | 'postBlob'
   | 'put'
   | 'request'
   | 'init'

superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts

@@ -32,7 +32,6 @@ export enum FeatureFlag {
   AvoidColorsCollision = 'AVOID_COLORS_COLLISION',
   ChartPluginsExperimental = 'CHART_PLUGINS_EXPERIMENTAL',
   ConfirmDashboardDiff = 'CONFIRM_DASHBOARD_DIFF',
-  CspRuntimeAllowlist = 'CSP_RUNTIME_ALLOWLIST',
   CssTemplates = 'CSS_TEMPLATES',
   DashboardVirtualization = 'DASHBOARD_VIRTUALIZATION',
   DashboardVirtualizationDeferData = 'DASHBOARD_VIRTUALIZATION_DEFER_DATA',

superset-frontend/packages/superset-ui-core/test/components/SafeMarkdown.test.tsx

@@ -17,8 +17,6 @@
  * under the License.
  */
 import { render } from '@testing-library/react';
-import { cloneDeep } from 'lodash';
-import { defaultSchema } from 'rehype-sanitize';
 import {
   getOverrideHtmlSchema,
   SafeMarkdown,
@@ -53,36 +51,6 @@ describe('getOverrideHtmlSchema', () => {
     expect(result.attributes).toEqual({ '*': ['size', 'src'], h1: ['style'] });
     expect(result.tagNames).toEqual(['h1', 'h2', 'h3', 'iframe']);
   });
-
-  test('should not mutate the original schema', () => {
-    const original = {
-      attributes: { '*': ['size'] },
-      tagNames: ['h1'],
-    };
-    getOverrideHtmlSchema(original, {
-      attributes: { '*': ['src'] },
-      tagNames: ['iframe'],
-    });
-    // The original passed in is left untouched.
-    expect(original.attributes).toEqual({ '*': ['size'] });
-    expect(original.tagNames).toEqual(['h1']);
-  });
-
-  test('should not mutate the shared defaultSchema import or accumulate across calls', () => {
-    const snapshot = cloneDeep(defaultSchema);
-    const overrides = { tagNames: ['iframe'] };
-
-    const first = getOverrideHtmlSchema(defaultSchema, overrides);
-    const second = getOverrideHtmlSchema(defaultSchema, overrides);
-
-    // The shared singleton is never modified...
-    expect(defaultSchema).toEqual(snapshot);
-    // ...and repeated calls do not accumulate the override (no growing arrays).
-    expect(first.tagNames).toEqual(second.tagNames);
-    expect(
-      (second.tagNames ?? []).filter(name => name === 'iframe'),
-    ).toHaveLength(1);
-  });
 });
 
 describe('transformLinkUri', () => {

superset-frontend/packages/superset-ui-core/test/connection/SupersetClient.test.ts

@@ -36,13 +36,12 @@ describe('SupersetClient', () => {
     getUrl: (...args: unknown[]) => string;
   };
 
-  test('exposes configure, init, get, post, postForm, postBlob, delete, put, request, reset, getGuestToken, getCSRFToken, getUrl, isAuthenticated, and reAuthenticate methods', () => {
+  test('exposes configure, init, get, post, postForm, delete, put, request, reset, getGuestToken, getCSRFToken, getUrl, isAuthenticated, and reAuthenticate methods', () => {
     expect(typeof SupersetClient.configure).toBe('function');
     expect(typeof SupersetClient.init).toBe('function');
     expect(typeof SupersetClient.get).toBe('function');
     expect(typeof SupersetClient.post).toBe('function');
     expect(typeof SupersetClient.postForm).toBe('function');
-    expect(typeof SupersetClient.postBlob).toBe('function');
     expect(typeof SupersetClient.delete).toBe('function');
     expect(typeof SupersetClient.put).toBe('function');
     expect(typeof SupersetClient.request).toBe('function');
@@ -54,12 +53,11 @@ describe('SupersetClient', () => {
     expect(typeof SupersetClient.reAuthenticate).toBe('function');
   });
 
-  test('throws if you call init, get, post, postForm, postBlob, delete, put, request, getGuestToken, getCSRFToken, getUrl, isAuthenticated, or reAuthenticate before configure', () => {
+  test('throws if you call init, get, post, postForm, delete, put, request, getGuestToken, getCSRFToken, getUrl, isAuthenticated, or reAuthenticate before configure', () => {
     expect(SupersetClient.init).toThrow();
     expect(SupersetClient.get).toThrow();
     expect(SupersetClient.post).toThrow();
     expect(SupersetClient.postForm).toThrow();
-    expect(SupersetClient.postBlob).toThrow();
     expect(SupersetClient.delete).toThrow();
     expect(SupersetClient.put).toThrow();
     expect(SupersetClient.request).toThrow();

superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts

@@ -780,75 +780,4 @@ describe('SupersetClientClass', () => {
       expect(authSpy).toHaveBeenCalledTimes(0);
     });
   });
-
-  describe('.postBlob()', () => {
-    const protocol = 'https:';
-    const host = 'host';
-    const mockPostBlobEndpoint = '/api/v1/chart/data';
-    const mockPostBlobUrl = `${protocol}//${host}${mockPostBlobEndpoint}`;
-    const postBlobPayload = { form_data: '{"viz_type":"table"}' };
-
-    let authSpy: jest.SpyInstance;
-    let client: SupersetClientClass;
-
-    beforeEach(async () => {
-      fetchMock.removeRoute(LOGIN_GLOB);
-      fetchMock.get(LOGIN_GLOB, { result: 1234 }, { name: LOGIN_GLOB });
-
-      client = new SupersetClientClass({ protocol, host });
-      await client.init();
-      authSpy = jest.spyOn(SupersetClientClass.prototype, 'ensureAuth');
-    });
-
-    afterEach(() => {
-      jest.restoreAllMocks();
-    });
-
-    test('calls ensureAuth and delegates to post with raw parseMethod', async () => {
-      const mockResponse = new Response('csv data', { status: 200 });
-      const postSpy = jest
-        .spyOn(client, 'post')
-        .mockResolvedValue(mockResponse);
-
-      const response = await client.postBlob(
-        mockPostBlobEndpoint,
-        postBlobPayload,
-      );
-
-      expect(authSpy).toHaveBeenCalledTimes(1);
-      expect(postSpy).toHaveBeenCalledWith({
-        endpoint: mockPostBlobEndpoint,
-        postPayload: postBlobPayload,
-        parseMethod: 'raw',
-        stringify: false,
-      });
-      expect(response).toBe(mockResponse);
-    });
-
-    test('passes payload in request body', async () => {
-      fetchMock.post(mockPostBlobUrl, {
-        status: 200,
-        body: 'csv data',
-      });
-
-      await client.postBlob(mockPostBlobEndpoint, postBlobPayload);
-
-      const fetchRequest = fetchMock.callHistory.calls(mockPostBlobUrl)[0]
-        .options as CallApi;
-      const formData = fetchRequest.body as FormData;
-
-      expect(formData.get('form_data')).toBe(postBlobPayload.form_data);
-    });
-
-    test('rejects when response is not ok', async () => {
-      fetchMock.post(mockPostBlobUrl, {
-        status: 413,
-        body: 'Payload Too Large',
-      });
-
-      await expect(
-        client.postBlob(mockPostBlobEndpoint, postBlobPayload),
-      ).rejects.toMatchObject({ status: 413 });
-    });
-  });
 });

superset-frontend/plugins/legacy-plugin-chart-world-map/src/WorldMap.ts

@@ -305,16 +305,36 @@ function WorldMap(element: HTMLElement, props: WorldMapProps): void {
       key: JSON.stringify,
     },
     done: datamap => {
-      // Hover highlighting and its reset are handled entirely by Datamaps'
-      // built-in highlightOnHover, which saves each country's original fill on
-      // mouseover and restores it on mouseout. Adding our own mouseover/mouseout
-      // fill handlers here creates a second, competing restore path whose
-      // execution order is browser-timing-dependent, which left the highlight
-      // stuck on Chrome/Edge (see #37761).
       datamap.svg
         .selectAll('.datamaps-subunit')
         .on('contextmenu', handleContextMenu)
-        .on('click', handleClick);
+        .on('click', handleClick)
+        // Use namespaced events to avoid overriding Datamaps' default tooltip handlers
+        .on('mouseover.fillPreserve', function onMouseOver() {
+          if (inContextMenu) {
+            return;
+          }
+          const element = d3.select(this);
+          const classes = element.attr('class') || '';
+          const countryId = classes.split(' ')[1];
+          const countryData = mapData[countryId];
+          const originalFill =
+            (countryData && countryData.fillColor) || theme.colorBorder;
+          // Store original fill color for restoration
+          element.attr('data-original-fill', originalFill);
+        })
+        .on('mouseout.fillPreserve', function onMouseOut() {
+          if (inContextMenu) {
+            return;
+          }
+          const element = d3.select(this);
+          const originalFill = element.attr('data-original-fill');
+          // Restore the original fill color (data-based or default no-data color)
+          if (originalFill) {
+            element.style('fill', originalFill);
+            element.attr('data-original-fill', null);
+          }
+        });
     },
   });
 

superset-frontend/plugins/legacy-plugin-chart-world-map/test/WorldMap.test.ts

@@ -58,6 +58,15 @@ interface WorldMapProps {
   formatter: ValueFormatter;
 }
 
+type MouseEventHandler = (this: HTMLElement) => void;
+
+interface MockD3Selection {
+  attr: jest.Mock;
+  style: jest.Mock;
+  classed: jest.Mock;
+  selectAll: jest.Mock;
+}
+
 // Mock Datamap
 const mockBubbles = jest.fn();
 const mockUpdateChoropleth = jest.fn();
@@ -148,36 +157,244 @@ afterEach(() => {
   document.body.removeChild(container);
 });
 
-test('relies on Datamaps highlightOnHover without adding conflicting fill handlers', () => {
-  // Regression test for #37761. The hover highlight got stuck on Chrome/Edge
-  // because hand-written mouseover/mouseout handlers competed with Datamaps'
-  // built-in highlightOnHover restore path, and the winning path was
-  // browser-timing-dependent. The chart should rely on the single built-in
-  // path and register no custom fill-restoring hover handlers on the countries.
+test('sets up mouseover and mouseout handlers on countries', () => {
   WorldMap(container, baseProps);
 
-  const geographyConfig = lastDatamapConfig?.geographyConfig as Record<
-    string,
-    unknown
-  >;
-  expect(geographyConfig?.highlightOnHover).toBe(true);
+  expect(mockSvg.selectAll).toHaveBeenCalledWith('.datamaps-subunit');
+  const onCalls = mockSvg.on.mock.calls;
 
-  const hoverHandlers = mockSvg.on.mock.calls.filter((call: [string]) =>
-    /^mouse(over|out)/.test(call[0]),
+  // Find mouseover and mouseout handler registrations (namespaced events)
+  const hasMouseover = onCalls.some(
+    call => call[0] === 'mouseover.fillPreserve',
   );
-  expect(hoverHandlers).toEqual([]);
+  const hasMouseout = onCalls.some(call => call[0] === 'mouseout.fillPreserve');
+
+  expect(hasMouseover).toBe(true);
+  expect(hasMouseout).toBe(true);
 });
 
-test('disables Datamaps highlightOnHover while the context menu is open', () => {
-  // Companion to the regression guard above: when the context menu is open we
-  // pass highlightOnHover: false so hover highlighting is suppressed at init.
-  WorldMap(container, { ...baseProps, inContextMenu: true });
+test('stores original fill color on mouseover', () => {
+  // Create a mock DOM element with d3 selection capabilities
+  const mockElement = document.createElement('path');
+  mockElement.setAttribute('class', 'datamaps-subunit USA');
+  mockElement.style.fill = 'rgb(100, 150, 200)';
+  container.appendChild(mockElement);
 
-  const geographyConfig = lastDatamapConfig?.geographyConfig as Record<
-    string,
-    unknown
-  >;
-  expect(geographyConfig?.highlightOnHover).toBe(false);
+  let mouseoverHandler: MouseEventHandler | null = null;
+
+  // Mock d3.select to return the mock element
+  const mockD3Selection: MockD3Selection = {
+    attr: jest.fn((attrName: string, value?: string) => {
+      if (value !== undefined) {
+        mockElement.setAttribute(attrName, value);
+      } else {
+        return mockElement.getAttribute(attrName);
+      }
+      return mockD3Selection;
+    }),
+    style: jest.fn((styleName: string, value?: string) => {
+      if (value !== undefined) {
+        mockElement.style[styleName as any] = value;
+      } else {
+        return mockElement.style[styleName as any];
+      }
+      return mockD3Selection;
+    }),
+    classed: jest.fn().mockReturnThis(),
+    selectAll: jest.fn().mockReturnValue({ remove: jest.fn() }),
+  };
+
+  jest.spyOn(d3 as any, 'select').mockReturnValue(mockD3Selection as any);
+
+  // Capture the mouseover handler (namespaced event)
+  mockSvg.on.mockImplementation((event: string, handler: MouseEventHandler) => {
+    if (event === 'mouseover.fillPreserve') {
+      mouseoverHandler = handler;
+    }
+    return mockSvg;
+  });
+
+  WorldMap(container, baseProps);
+
+  // Simulate mouseover
+  if (mouseoverHandler) {
+    (mouseoverHandler as MouseEventHandler).call(mockElement);
+  }
+
+  // Verify that data-original-fill attribute was set
+  expect(mockD3Selection.attr).toHaveBeenCalledWith(
+    'data-original-fill',
+    expect.any(String),
+  );
+});
+
+test('restores original fill color on mouseout for country with data', () => {
+  const mockElement = document.createElement('path');
+  mockElement.setAttribute('class', 'datamaps-subunit USA');
+  mockElement.style.fill = 'rgb(100, 150, 200)';
+  mockElement.setAttribute('data-original-fill', 'rgb(100, 150, 200)');
+  container.appendChild(mockElement);
+
+  let mouseoutHandler: MouseEventHandler | null = null;
+
+  const mockD3Selection: MockD3Selection = {
+    attr: jest.fn((attrName: string, value?: string | null) => {
+      if (value !== undefined) {
+        if (value === null) {
+          mockElement.removeAttribute(attrName);
+        } else {
+          mockElement.setAttribute(attrName, value);
+        }
+        return mockD3Selection;
+      }
+      return mockElement.getAttribute(attrName);
+    }),
+    style: jest.fn((styleName: string, value?: string) => {
+      if (value !== undefined) {
+        mockElement.style[styleName as any] = value;
+      }
+      return mockElement.style[styleName as any] || mockD3Selection;
+    }),
+    classed: jest.fn().mockReturnThis(),
+    selectAll: jest.fn().mockReturnValue({ remove: jest.fn() }),
+  };
+
+  jest.spyOn(d3 as any, 'select').mockReturnValue(mockD3Selection as any);
+
+  // Capture the mouseout handler (namespaced event)
+  mockSvg.on.mockImplementation((event: string, handler: MouseEventHandler) => {
+    if (event === 'mouseout.fillPreserve') {
+      mouseoutHandler = handler;
+    }
+    return mockSvg;
+  });
+
+  WorldMap(container, baseProps);
+
+  // Simulate mouseout
+  if (mouseoutHandler) {
+    (mouseoutHandler as MouseEventHandler).call(mockElement);
+  }
+
+  // Verify that original fill was restored
+  expect(mockD3Selection.style).toHaveBeenCalledWith(
+    'fill',
+    'rgb(100, 150, 200)',
+  );
+  expect(mockD3Selection.attr).toHaveBeenCalledWith('data-original-fill', null);
+});
+
+test('restores default fill color on mouseout for country with no data', () => {
+  const mockElement = document.createElement('path');
+  mockElement.setAttribute('class', 'datamaps-subunit XXX');
+  mockElement.style.fill = '#e0e0e0'; // Default border color
+  mockElement.setAttribute('data-original-fill', '#e0e0e0');
+  container.appendChild(mockElement);
+
+  let mouseoutHandler: MouseEventHandler | null = null;
+
+  const mockD3Selection: MockD3Selection = {
+    attr: jest.fn((attrName: string, value?: string | null) => {
+      if (value !== undefined) {
+        if (value === null) {
+          mockElement.removeAttribute(attrName);
+        } else {
+          mockElement.setAttribute(attrName, value);
+        }
+        return mockD3Selection;
+      }
+      return mockElement.getAttribute(attrName);
+    }),
+    style: jest.fn((styleName: string, value?: string) => {
+      if (value !== undefined) {
+        mockElement.style[styleName as any] = value;
+      }
+      return mockElement.style[styleName as any] || mockD3Selection;
+    }),
+    classed: jest.fn().mockReturnThis(),
+    selectAll: jest.fn().mockReturnValue({ remove: jest.fn() }),
+  };
+
+  jest.spyOn(d3 as any, 'select').mockReturnValue(mockD3Selection as any);
+
+  // Capture the mouseout handler (namespaced event)
+  mockSvg.on.mockImplementation((event: string, handler: MouseEventHandler) => {
+    if (event === 'mouseout.fillPreserve') {
+      mouseoutHandler = handler;
+    }
+    return mockSvg;
+  });
+
+  WorldMap(container, baseProps);
+
+  // Simulate mouseout
+  if (mouseoutHandler) {
+    (mouseoutHandler as MouseEventHandler).call(mockElement);
+  }
+
+  // Verify that default fill was restored (no-data color)
+  expect(mockD3Selection.style).toHaveBeenCalledWith('fill', '#e0e0e0');
+  expect(mockD3Selection.attr).toHaveBeenCalledWith('data-original-fill', null);
+});
+
+test('does not handle mouse events when inContextMenu is true', () => {
+  const propsWithContextMenu = {
+    ...baseProps,
+    inContextMenu: true,
+  };
+
+  const mockElement = document.createElement('path');
+  mockElement.setAttribute('class', 'datamaps-subunit USA');
+  mockElement.style.fill = 'rgb(100, 150, 200)';
+  container.appendChild(mockElement);
+
+  let mouseoverHandler: MouseEventHandler | null = null;
+  let mouseoutHandler: MouseEventHandler | null = null;
+
+  const mockD3Selection: MockD3Selection = {
+    attr: jest.fn(() => mockD3Selection),
+    style: jest.fn(() => mockD3Selection),
+    classed: jest.fn().mockReturnThis(),
+    selectAll: jest.fn().mockReturnValue({ remove: jest.fn() }),
+  };
+
+  jest.spyOn(d3 as any, 'select').mockReturnValue(mockD3Selection as any);
+
+  // Capture namespaced event handlers
+  mockSvg.on.mockImplementation((event: string, handler: MouseEventHandler) => {
+    if (event === 'mouseover.fillPreserve') {
+      mouseoverHandler = handler;
+    }
+    if (event === 'mouseout.fillPreserve') {
+      mouseoutHandler = handler;
+    }
+    return mockSvg;
+  });
+
+  WorldMap(container, propsWithContextMenu);
+
+  // Simulate mouseover and mouseout
+  if (mouseoverHandler) {
+    (mouseoverHandler as MouseEventHandler).call(mockElement);
+  }
+  if (mouseoutHandler) {
+    (mouseoutHandler as MouseEventHandler).call(mockElement);
+  }
+
+  // When inContextMenu is true, handlers should exit early without modifying anything
+  // We verify this by checking that attr and style weren't called to change fill
+  const attrCalls = mockD3Selection.attr.mock.calls;
+  const fillChangeCalls = attrCalls.filter(
+    (call: [string, unknown]) =>
+      call[0] === 'data-original-fill' && call[1] !== undefined,
+  );
+  const styleCalls = mockD3Selection.style.mock.calls;
+  const fillStyleChangeCalls = styleCalls.filter(
+    (call: [string, unknown]) => call[0] === 'fill' && call[1] !== undefined,
+  );
+  // The handlers should return early, so no state changes
+  expect(fillChangeCalls.length).toBe(0);
+  expect(fillStyleChangeCalls.length).toBe(0);
 });
 
 test('does not throw error when onContextMenu is undefined', () => {

superset-frontend/plugins/plugin-chart-ag-grid-table/src/buildQuery.ts

@@ -90,13 +90,6 @@ const buildQuery: BuildQuery<TableChartFormData> = (
     let { metrics, orderby = [], columns = [] } = baseQueryObject;
     const { extras = {} } = baseQueryObject;
     let postProcessing: PostProcessingRule[] = [];
-    // Capture the percent-metric `contribution` rule so it can be reused for
-    // the totals query below. The totals query must rename percent-metric
-    // columns the same way (`metric` -> `%metric`) so the footer can look them
-    // up; without it the totals row renders 0.000%. We deliberately reuse only
-    // this rule and not the full `postProcessing` array, which may also contain
-    // a time-comparison operator that must not run on the single totals row.
-    let contributionPostProcessing: PostProcessingRule | undefined;
     const nonCustomNorInheritShifts = ensureIsArray(
       formData.time_compare,
     ).filter((shift: string) => shift !== 'custom' && shift !== 'inherit');
@@ -164,14 +157,15 @@ const buildQuery: BuildQuery<TableChartFormData> = (
           metrics.concat(percentMetrics),
           getMetricLabel,
         );
-        contributionPostProcessing = {
-          operation: 'contribution',
-          options: {
-            columns: percentMetricLabels,
-            rename_columns: percentMetricLabels.map(x => `%${x}`),
+        postProcessing = [
+          {
+            operation: 'contribution',
+            options: {
+              columns: percentMetricLabels,
+              rename_columns: percentMetricLabels.map(x => `%${x}`),
+            },
           },
-        };
-        postProcessing = [contributionPostProcessing];
+        ];
       }
       // Add the operator for the time comparison if some is selected
       if (!isEmpty(timeOffsets)) {
@@ -664,13 +658,7 @@ const buildQuery: BuildQuery<TableChartFormData> = (
         extras: totalsExtras, // Use extras with AG Grid WHERE removed
         row_limit: 0,
         row_offset: 0,
-        // Reapply only the percent-metric contribution rule so the totals row
-        // exposes `%metric` keys (value/value = 100% on the single aggregated
-        // row). The time-comparison operator from the main query is omitted on
-        // purpose; it must not run against the single-row totals query.
-        post_processing: contributionPostProcessing
-          ? [contributionPostProcessing]
-          : [],
+        post_processing: [],
         order_desc: undefined, // we don't need orderby stuff here,
         orderby: undefined, // because this query will be used for get total aggregation.
       });

superset-frontend/plugins/plugin-chart-ag-grid-table/src/consts.ts

@@ -44,3 +44,8 @@ export const FILTER_CONDITION_BODY_INDEX = {
 } as const;
 
 export const ROW_NUMBER_COL_ID = '__row_number__';
+
+// Non-enumerable key used to attach a row's basic (increase/decrease) color
+// formatter to the row data object so it travels with the row through AG Grid
+// client-side sorting (#105973).
+export const BASIC_COLOR_FORMATTERS_ROW_KEY = '__basicColorFormatters__';

superset-frontend/plugins/plugin-chart-ag-grid-table/src/renderers/NumericCellRenderer.tsx

@@ -24,6 +24,7 @@ import {
 import { CustomCellRendererProps } from '@superset-ui/core/components/ThemedAgGridReact';
 import { BasicColorFormatterType, InputColumn, ValueRange } from '../types';
 import { useIsDark } from '../utils/useTableTheme';
+import getRowBasicColorFormatter from '../utils/getRowBasicColorFormatter';
 
 const StyledTotalCell = styled.div`
   ${() => `
@@ -163,13 +164,13 @@ export const NumericCellRenderer = (
   let arrow = '';
   let arrowColor = '';
   if (hasBasicColorFormatters && col?.metricName) {
-    arrow =
-      basicColorFormatters?.[node?.rowIndex as number]?.[col.metricName]
-        ?.mainArrow;
-    arrowColor =
-      basicColorFormatters?.[node?.rowIndex as number]?.[
-        col.metricName
-      ]?.arrowColor?.toLowerCase();
+    const rowFormatter = getRowBasicColorFormatter(
+      node,
+      node?.rowIndex,
+      basicColorFormatters,
+    )?.[col.metricName];
+    arrow = rowFormatter?.mainArrow;
+    arrowColor = rowFormatter?.arrowColor?.toLowerCase();
   }
 
   const alignment =

superset-frontend/plugins/plugin-chart-ag-grid-table/src/transformProps.ts

@@ -46,6 +46,7 @@ import {
 } from '@superset-ui/chart-controls';
 import isEqualColumns from './utils/isEqualColumns';
 import DateWithFormatter from './utils/DateWithFormatter';
+import { BASIC_COLOR_FORMATTERS_ROW_KEY } from './consts';
 import {
   DataColumnMeta,
   TableChartProps,
@@ -703,6 +704,23 @@ const transformProps = (
 
   const basicColorFormatters =
     comparisonColorEnabled && getBasicColorFormatter(baseQuery?.data, columns);
+
+  // Attach each row's basic (increase/decrease) color formatter to the row data
+  // object so it travels with the row through AG Grid client-side sorting.
+  // basicColorFormatters is built in the original query order and was previously
+  // read positionally by the displayed rowIndex, which applied colors to the
+  // wrong rows once the table was sorted (#105973). The property is
+  // non-enumerable so it never leaks into exports, cross-filters or spreads.
+  if (basicColorFormatters) {
+    passedData.forEach((row, index) => {
+      Object.defineProperty(row, BASIC_COLOR_FORMATTERS_ROW_KEY, {
+        value: basicColorFormatters[index],
+        enumerable: false,
+        configurable: true,
+        writable: true,
+      });
+    });
+  }
   const columnColorFormatters =
     getColorFormatters(conditionalFormatting, passedData, theme) ?? [];
 

superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/getCellStyle.ts

@@ -24,6 +24,7 @@ import {
 } from '@superset-ui/chart-controls';
 import { CellClassParams } from '@superset-ui/core/components/ThemedAgGridReact';
 import { BasicColorFormatterType, InputColumn } from '../types';
+import getRowBasicColorFormatter from './getRowBasicColorFormatter';
 
 type CellStyleParams = CellClassParams & {
   hasColumnColorFormatters: boolean | undefined;
@@ -84,8 +85,11 @@ const getCellStyle = (params: CellStyleParams) => {
     col?.metricName &&
     node?.rowPinned !== 'bottom'
   ) {
-    backgroundColor =
-      basicColorFormatters?.[rowIndex]?.[col.metricName]?.backgroundColor;
+    backgroundColor = getRowBasicColorFormatter(
+      node,
+      rowIndex,
+      basicColorFormatters,
+    )?.[col.metricName]?.backgroundColor;
   }
 
   const textAlign =

superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/getRowBasicColorFormatter.ts

@@ -0,0 +1,51 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { BASIC_COLOR_FORMATTERS_ROW_KEY } from '../consts';
+import { BasicColorFormatterType } from '../types';
+
+type RowFormatters = { [key: string]: BasicColorFormatterType };
+
+/**
+ * Resolves the basic (increase/decrease) color formatters for a given AG Grid
+ * row node.
+ *
+ * The formatter is attached to the row data object itself (see transformProps),
+ * so it follows the row through client-side sorting. Looking it up positionally
+ * by the displayed `rowIndex` was wrong once the user sorted the table, because
+ * the displayed index no longer matched the original data order (#105973).
+ *
+ * Falls back to the positional array for safety when no attached formatter is
+ * present.
+ */
+export default function getRowBasicColorFormatter(
+  node: { data?: Record<string, unknown> } | undefined,
+  rowIndex: number | null | undefined,
+  basicColorFormatters: RowFormatters[] | undefined,
+): RowFormatters | undefined {
+  const attached = node?.data?.[BASIC_COLOR_FORMATTERS_ROW_KEY] as
+    | RowFormatters
+    | undefined;
+  if (attached) {
+    return attached;
+  }
+  if (rowIndex == null) {
+    return undefined;
+  }
+  return basicColorFormatters?.[rowIndex];
+}

superset-frontend/plugins/plugin-chart-ag-grid-table/test/buildQuery.test.ts

@@ -852,75 +852,6 @@ describe('plugin-chart-ag-grid-table', () => {
         expect(totalsQuery.columns).toEqual([]);
         expect(totalsQuery.row_limit).toBe(0);
       });
-
-      test('should reapply percent-metric contribution op to totals query', () => {
-        // Regression test for #37627: when a percent metric is configured and
-        // Show Summary (show_totals) is enabled, the totals query must rename
-        // percent-metric columns (`metric` -> `%metric`) so the footer can
-        // look them up. Otherwise the totals row renders 0.000%.
-        const { queries } = buildQuery({
-          ...basicFormData,
-          metrics: ['count'],
-          percent_metrics: ['count'],
-          show_totals: true,
-          query_mode: QueryMode.Aggregate,
-        });
-
-        // No server pagination -> queries[1] is the totals query.
-        const totalsQuery = queries[1];
-        const contributionRule = {
-          operation: 'contribution',
-          options: {
-            columns: ['count'],
-            rename_columns: ['%count'],
-          },
-        };
-
-        expect(queries[0].post_processing).toContainEqual(contributionRule);
-        expect(totalsQuery.post_processing).toEqual([contributionRule]);
-      });
-
-      test('should omit time-comparison op from totals post_processing', () => {
-        // The totals query must reuse ONLY the contribution rule; the
-        // time-comparison operator from the main query must not run against
-        // the single-row totals query.
-        const { queries } = buildQuery({
-          ...basicFormData,
-          metrics: ['count'],
-          percent_metrics: ['count'],
-          show_totals: true,
-          query_mode: QueryMode.Aggregate,
-          time_compare: ['1 year ago'],
-          comparison_type: 'values',
-        });
-
-        const totalsQuery = queries[1];
-
-        // Exactly one op (contribution) — the time-comparison operator from the
-        // main query must not be carried over to the single-row totals query.
-        expect(totalsQuery.post_processing).toHaveLength(1);
-        expect(totalsQuery.post_processing?.[0]).toMatchObject({
-          operation: 'contribution',
-        });
-        // The reused rule matches the main query's contribution rule verbatim.
-        expect(totalsQuery.post_processing?.[0]).toEqual(
-          queries[0].post_processing?.find(
-            op => op?.operation === 'contribution',
-          ),
-        );
-      });
-
-      test('should leave totals post_processing empty without percent metrics', () => {
-        const { queries } = buildQuery({
-          ...basicFormData,
-          metrics: ['count'],
-          show_totals: true,
-          query_mode: QueryMode.Aggregate,
-        });
-
-        const totalsQuery = queries[1];
-        expect(totalsQuery.post_processing).toEqual([]);
-      });
     });
 
     describe('Integration - all filter types together', () => {

superset-frontend/plugins/plugin-chart-ag-grid-table/test/utils/getRowBasicColorFormatter.test.ts

@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import getRowBasicColorFormatter from '../../src/utils/getRowBasicColorFormatter';
+import { BASIC_COLOR_FORMATTERS_ROW_KEY } from '../../src/consts';
+
+const red = { sales: { backgroundColor: 'red', mainArrow: '↓', arrowColor: 'red' } };
+const green = {
+  sales: { backgroundColor: 'green', mainArrow: '↑', arrowColor: 'green' },
+};
+
+// Positional array in the original (unsorted) query order: row 0 -> green, row 1 -> red.
+const positional = [green, red] as any;
+
+test('uses the formatter attached to the row, not the displayed rowIndex (#105973)', () => {
+  // After sorting, the row whose original formatter is `red` is displayed first
+  // (rowIndex 0). The positional lookup would wrongly return `green`.
+  const rowData: Record<string, unknown> = { sales: 5 };
+  Object.defineProperty(rowData, BASIC_COLOR_FORMATTERS_ROW_KEY, {
+    value: red,
+    enumerable: false,
+  });
+  const node = { data: rowData };
+
+  expect(getRowBasicColorFormatter(node, 0, positional)).toBe(red);
+  expect(
+    getRowBasicColorFormatter(node, 0, positional)?.sales.backgroundColor,
+  ).toBe('red');
+});
+
+test('falls back to positional lookup when no formatter is attached', () => {
+  const node = { data: { sales: 5 } };
+  expect(getRowBasicColorFormatter(node, 1, positional)).toBe(red);
+});
+
+test('returns undefined when nothing matches', () => {
+  expect(getRowBasicColorFormatter(undefined, null, positional)).toBeUndefined();
+  expect(
+    getRowBasicColorFormatter({ data: {} }, null, positional),
+  ).toBeUndefined();
+});
+
+test('attached formatter is non-enumerable so it does not leak into the row', () => {
+  const rowData: Record<string, unknown> = { sales: 5 };
+  Object.defineProperty(rowData, BASIC_COLOR_FORMATTERS_ROW_KEY, {
+    value: green,
+    enumerable: false,
+  });
+  expect(Object.keys(rowData)).toEqual(['sales']);
+});

superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx

@@ -318,25 +318,14 @@ function createAdvancedAnalyticsSection(
 ): ControlPanelSectionConfig {
   const aaWithSuffix = cloneDeep(sections.advancedAnalyticsControls);
   aaWithSuffix.label = label;
-  // `time_compare_full_range` is only wired into the regular timeseries query
-  // builder, not the mixed-timeseries one, so drop it here to avoid showing a
-  // control that has no effect.
-  aaWithSuffix.controlSetRows = aaWithSuffix.controlSetRows
-    .map(row =>
-      row.filter(
-        control =>
-          (control as CustomControlItem)?.name !== 'time_compare_full_range',
-      ),
-    )
-    .filter(row => row.length > 0);
   if (!controlSuffix) {
     return aaWithSuffix;
   }
   aaWithSuffix.controlSetRows.forEach(row =>
-    row.forEach(control => {
-      const item = control as CustomControlItem;
-      if (item?.name) {
-        item.name = `${item.name}${controlSuffix}`;
+    row.forEach((control: CustomControlItem) => {
+      if (control?.name) {
+        // eslint-disable-next-line no-param-reassign
+        control.name = `${control.name}${controlSuffix}`;
       }
     }),
   );

superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/controlPanel.tsx

@@ -92,20 +92,6 @@ const config: ControlPanelConfig = {
             },
           },
         ],
-        [
-          {
-            name: 'show_null_values',
-            config: {
-              type: 'CheckboxControl',
-              label: t('Show Null Values'),
-              default: true,
-              renderTrigger: true,
-              description: t(
-                'Whether to display entries with null values in the hierarchy',
-              ),
-            },
-          },
-        ],
         [
           {
             name: 'label_type',

superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts

@@ -186,9 +186,6 @@ export default function transformProps(
     showLabels,
     showLabelsThreshold,
     showTotal,
-    // Default to true so charts saved before this control existed keep
-    // showing null values instead of silently hiding them on upgrade.
-    showNullValues = true,
     sliceId,
   } = formData;
   const {
@@ -254,7 +251,6 @@ export default function transformProps(
     columnLabels,
     metricLabel,
     secondaryMetricLabel,
-    !showNullValues,
   );
   const totalValue = treeData.reduce(
     (result, treeNode) => result + treeNode.value,

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/buildQuery.ts

@@ -82,11 +82,6 @@ export default function buildQuery(formData: QueryFormData) {
       ? formData.time_compare
       : [];
 
-    // When comparing against prior periods, optionally keep each shifted series at
-    // its full time range instead of truncating it to the main series' range.
-    const time_compare_full_range =
-      time_offsets.length > 0 && Boolean(formData.time_compare_full_range);
-
     return [
       {
         ...baseQueryObject,
@@ -97,7 +92,6 @@ export default function buildQuery(formData: QueryFormData) {
         // todo: move `normalizeOrderBy to extractQueryFields`
         orderby: normalizeOrderBy(baseQueryObject).orderby,
         time_offsets,
-        time_compare_full_range,
         /* Note that:
           1. The resample, rolling, cum, timeCompare operators should be after pivot.
           2. Resample must come before rolling so that imputed values are

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts

@@ -381,15 +381,6 @@ export default function transformProps(
   const array = ensureIsArray(chartProps.rawFormData?.time_compare);
   const inverted = invert(verboseMap);
 
-  // With the "full range" time-shift option, offset series are outer-joined onto
-  // the main series, which inserts null rows into the main series wherever the
-  // comparison period has data the current period lacks. Connect nulls so the
-  // main line stays continuous (matching the default left-join appearance) rather
-  // than fragmenting at every inserted gap.
-  const timeCompareFullRange = Boolean(
-    chartProps.rawFormData?.time_compare_full_range,
-  );
-
   const offsetLineWidths: { [key: string]: number } = {};
 
   // For horizontal bar charts, calculate min/max from data to avoid cutting off labels
@@ -487,7 +478,7 @@ export default function transformProps(
       colorScaleKey,
       {
         area,
-        connectNulls: derivedSeries || timeCompareFullRange,
+        connectNulls: derivedSeries,
         filterState,
         seriesContexts,
         markerEnabled,

superset-frontend/plugins/plugin-chart-echarts/src/utils/treeBuilder.ts

@@ -36,11 +36,10 @@ export function treeBuilder(
   groupBy: string[],
   metric: string,
   secondaryMetric?: string,
-  filterNullNames?: boolean,
 ): TreeNode[] {
   const [curGroupBy, ...restGroupby] = groupBy;
   const curData = _groupBy(data, curGroupBy);
-  const nodes = transform(
+  return transform(
     curData,
     (result, value, key) => {
       const name = curData[key][0][curGroupBy]!;
@@ -59,15 +58,11 @@ export function treeBuilder(
           result.push(item);
         });
       } else {
-        // Children are already null-filtered by the recursive call, so the
-        // parent's value/secondaryValue exclude hidden nulls. This keeps the
-        // parent arc sized to its visible children (no empty gap).
         const children = treeBuilder(
           value,
           restGroupby,
           metric,
           secondaryMetric,
-          filterNullNames,
         );
         const metricValue = children.reduce(
           (prev, cur) => prev + (cur.value as number),
@@ -90,13 +85,4 @@ export function treeBuilder(
     },
     [] as TreeNode[],
   );
-  // Filter at every level so single-level charts and root nodes are covered,
-  // not just nested children. A parent whose children were all null-filtered
-  // is dropped too: keeping it would leave a zero-value arc that yields a NaN
-  // secondaryValue/value ratio for coloring and tooltips.
-  return filterNullNames
-    ? nodes.filter(
-        node => node.name !== null && node.children?.length !== 0,
-      )
-    : nodes;
 }

superset-frontend/plugins/plugin-chart-echarts/test/Sunburst/transformProps.test.ts

@@ -21,13 +21,6 @@ import { supersetTheme } from '@apache-superset/core/theme';
 import { EchartsSunburstChartProps } from '../../src/Sunburst/types';
 import transformProps from '../../src/Sunburst/transformProps';
 
-type SunburstSeries = {
-  label?: Record<string, unknown>;
-  data: { value: number }[];
-};
-const firstSeries = (echartOptions: unknown) =>
-  (echartOptions as { series: SunburstSeries[] }).series[0];
-
 const formData = {
   colorScheme: 'bnbColors',
   datasource: '3__table',
@@ -54,52 +47,7 @@ test('series label has no textBorderColor or textBorderWidth', () => {
   const { echartOptions } = transformProps(
     chartProps as EchartsSunburstChartProps,
   );
-  const series = firstSeries(echartOptions);
+  const series = (echartOptions as any).series[0];
   expect(series.label).not.toHaveProperty('textBorderColor');
   expect(series.label).not.toHaveProperty('textBorderWidth');
 });
-
-const nullValueProps = (showNullValues?: boolean) =>
-  new ChartProps({
-    formData: {
-      colorScheme: 'bnbColors',
-      datasource: '3__table',
-      columns: ['category'],
-      metric: 'sum__value',
-      ...(showNullValues === undefined ? {} : { showNullValues }),
-    },
-    width: 800,
-    height: 600,
-    queriesData: [
-      {
-        data: [
-          { category: 'A', sum__value: 10 },
-          { category: 'B', sum__value: 20 },
-          { category: null, sum__value: 5 },
-        ],
-      },
-    ],
-    theme: supersetTheme,
-  });
-
-const seriesValues = (props: ChartProps) => {
-  const { echartOptions } = transformProps(props as EchartsSunburstChartProps);
-  return firstSeries(echartOptions)
-    .data.map(node => node.value)
-    .sort((a, b) => a - b);
-};
-
-// Charts saved before the "Show Null Values" control existed have no
-// `showNullValues` in form data; they must keep showing nulls (non-breaking).
-test('keeps null values when showNullValues is unset (legacy charts)', () => {
-  expect(seriesValues(nullValueProps(undefined))).toEqual([5, 10, 20]);
-});
-
-test('keeps null values when showNullValues is true', () => {
-  expect(seriesValues(nullValueProps(true))).toEqual([5, 10, 20]);
-});
-
-// Single-column sunburst: the toggle must actually drop the null node.
-test('removes null values when showNullValues is false', () => {
-  expect(seriesValues(nullValueProps(false))).toEqual([10, 20]);
-});

superset-frontend/plugins/plugin-chart-echarts/test/utils/treeBuilder.test.ts

@@ -271,379 +271,4 @@ describe('test treeBuilder', () => {
       },
     ]);
   });
-
-  test('include null values', () => {
-    const tree = treeBuilder(
-      [
-        ...data,
-        {
-          foo: 'a-2',
-          bar: null,
-          count: 2,
-          count2: 3,
-        },
-      ],
-      ['foo', 'bar'],
-      'count',
-    );
-    expect(tree).toEqual([
-      {
-        children: [
-          {
-            groupBy: 'bar',
-            name: 'a',
-            secondaryValue: 2,
-            value: 2,
-          },
-        ],
-        groupBy: 'foo',
-        name: 'a-1',
-        secondaryValue: 2,
-        value: 2,
-      },
-      {
-        children: [
-          {
-            groupBy: 'bar',
-            name: 'a',
-            secondaryValue: 2,
-            value: 2,
-          },
-          {
-            groupBy: 'bar',
-            name: null,
-            secondaryValue: 2,
-            value: 2,
-          },
-        ],
-        groupBy: 'foo',
-        name: 'a-2',
-        secondaryValue: 4,
-        value: 4,
-      },
-      {
-        children: [
-          {
-            groupBy: 'bar',
-            name: 'b',
-            secondaryValue: 2,
-            value: 2,
-          },
-        ],
-        groupBy: 'foo',
-        name: 'b-1',
-        secondaryValue: 2,
-        value: 2,
-      },
-      {
-        children: [
-          {
-            groupBy: 'bar',
-            name: 'b',
-            secondaryValue: 2,
-            value: 2,
-          },
-        ],
-        groupBy: 'foo',
-        name: 'b-2',
-        secondaryValue: 2,
-        value: 2,
-      },
-      {
-        children: [
-          {
-            groupBy: 'bar',
-            name: 'c',
-            secondaryValue: 2,
-            value: 2,
-          },
-        ],
-        groupBy: 'foo',
-        name: 'c-1',
-        secondaryValue: 2,
-        value: 2,
-      },
-      {
-        children: [
-          {
-            groupBy: 'bar',
-            name: 'c',
-            secondaryValue: 2,
-            value: 2,
-          },
-        ],
-        groupBy: 'foo',
-        name: 'c-2',
-        secondaryValue: 2,
-        value: 2,
-      },
-      {
-        children: [
-          {
-            groupBy: 'bar',
-            name: 'd',
-            secondaryValue: 2,
-            value: 2,
-          },
-        ],
-        groupBy: 'foo',
-        name: 'd-1',
-        secondaryValue: 2,
-        value: 2,
-      },
-    ]);
-  });
-
-  test('filter null values in a nested layer (parent total excludes hidden nulls)', () => {
-    const tree = treeBuilder(
-      [
-        ...data,
-        {
-          foo: 'a-2',
-          bar: null,
-          count: 2,
-          count2: 3,
-        },
-      ],
-      ['foo', 'bar'],
-      'count',
-      undefined,
-      true,
-    );
-    expect(tree).toEqual([
-      {
-        children: [
-          {
-            groupBy: 'bar',
-            name: 'a',
-            secondaryValue: 2,
-            value: 2,
-          },
-        ],
-        groupBy: 'foo',
-        name: 'a-1',
-        secondaryValue: 2,
-        value: 2,
-      },
-      {
-        // The null `bar` child is removed AND its value is excluded from the
-        // parent total, so the arc stays sized to its visible children (no gap).
-        children: [
-          {
-            groupBy: 'bar',
-            name: 'a',
-            secondaryValue: 2,
-            value: 2,
-          },
-        ],
-        groupBy: 'foo',
-        name: 'a-2',
-        secondaryValue: 2,
-        value: 2,
-      },
-      {
-        children: [
-          {
-            groupBy: 'bar',
-            name: 'b',
-            secondaryValue: 2,
-            value: 2,
-          },
-        ],
-        groupBy: 'foo',
-        name: 'b-1',
-        secondaryValue: 2,
-        value: 2,
-      },
-      {
-        children: [
-          {
-            groupBy: 'bar',
-            name: 'b',
-            secondaryValue: 2,
-            value: 2,
-          },
-        ],
-        groupBy: 'foo',
-        name: 'b-2',
-        secondaryValue: 2,
-        value: 2,
-      },
-      {
-        children: [
-          {
-            groupBy: 'bar',
-            name: 'c',
-            secondaryValue: 2,
-            value: 2,
-          },
-        ],
-        groupBy: 'foo',
-        name: 'c-1',
-        secondaryValue: 2,
-        value: 2,
-      },
-      {
-        children: [
-          {
-            groupBy: 'bar',
-            name: 'c',
-            secondaryValue: 2,
-            value: 2,
-          },
-        ],
-        groupBy: 'foo',
-        name: 'c-2',
-        secondaryValue: 2,
-        value: 2,
-      },
-      {
-        children: [
-          {
-            groupBy: 'bar',
-            name: 'd',
-            secondaryValue: 2,
-            value: 2,
-          },
-        ],
-        groupBy: 'foo',
-        name: 'd-1',
-        secondaryValue: 2,
-        value: 2,
-      },
-    ]);
-  });
-
-  // Regression: a single-level (single column) sunburst previously never
-  // filtered, because filtering only happened in the multi-level branch.
-  test('single-level: shows null nodes when filtering is off', () => {
-    const tree = treeBuilder(
-      [
-        { foo: 'a', count: 2, count2: 3 },
-        { foo: null, count: 5, count2: 7 },
-      ],
-      ['foo'],
-      'count',
-    );
-    expect(tree).toEqual([
-      { groupBy: 'foo', name: 'a', secondaryValue: 2, value: 2 },
-      { groupBy: 'foo', name: null, secondaryValue: 5, value: 5 },
-    ]);
-  });
-
-  test('single-level: removes null nodes when filtering is on', () => {
-    const tree = treeBuilder(
-      [
-        { foo: 'a', count: 2, count2: 3 },
-        { foo: null, count: 5, count2: 7 },
-      ],
-      ['foo'],
-      'count',
-      undefined,
-      true,
-    );
-    expect(tree).toEqual([
-      { groupBy: 'foo', name: 'a', secondaryValue: 2, value: 2 },
-    ]);
-  });
-
-  // Regression: a null in the *root* (first) column previously slipped through
-  // because the top-level result array was never filtered.
-  test('multi-level: shows null root node when filtering is off', () => {
-    const tree = treeBuilder(
-      [
-        { foo: 'a-1', bar: 'a', count: 2, count2: 3 },
-        { foo: null, bar: 'x', count: 5, count2: 7 },
-      ],
-      ['foo', 'bar'],
-      'count',
-    );
-    expect(tree).toEqual([
-      {
-        children: [{ groupBy: 'bar', name: 'a', secondaryValue: 2, value: 2 }],
-        groupBy: 'foo',
-        name: 'a-1',
-        secondaryValue: 2,
-        value: 2,
-      },
-      {
-        children: [{ groupBy: 'bar', name: 'x', secondaryValue: 5, value: 5 }],
-        groupBy: 'foo',
-        name: null,
-        secondaryValue: 5,
-        value: 5,
-      },
-    ]);
-  });
-
-  test('multi-level: removes null root node (and its subtree) when filtering is on', () => {
-    const tree = treeBuilder(
-      [
-        { foo: 'a-1', bar: 'a', count: 2, count2: 3 },
-        { foo: null, bar: 'x', count: 5, count2: 7 },
-      ],
-      ['foo', 'bar'],
-      'count',
-      undefined,
-      true,
-    );
-    expect(tree).toEqual([
-      {
-        children: [{ groupBy: 'bar', name: 'a', secondaryValue: 2, value: 2 }],
-        groupBy: 'foo',
-        name: 'a-1',
-        secondaryValue: 2,
-        value: 2,
-      },
-    ]);
-  });
-
-  // With a secondary metric, the parent's secondaryValue must also exclude the
-  // hidden null child rather than leaving a stale (inflated) total.
-  test('filtering excludes hidden nulls from secondary-metric totals', () => {
-    const tree = treeBuilder(
-      [
-        { foo: 'p', bar: 'a', count: 2, count2: 3 },
-        { foo: 'p', bar: null, count: 2, count2: 7 },
-      ],
-      ['foo', 'bar'],
-      'count',
-      'count2',
-      true,
-    );
-    expect(tree).toEqual([
-      {
-        children: [{ groupBy: 'bar', name: 'a', secondaryValue: 3, value: 2 }],
-        groupBy: 'foo',
-        name: 'p',
-        secondaryValue: 3,
-        value: 2,
-      },
-    ]);
-  });
-
-  // A parent whose children are all null must be dropped, not kept as a
-  // zero-value arc: a retained `value: 0` node yields NaN for the
-  // secondaryValue/value ratio used in linear coloring and tooltips.
-  test('filtering drops parents left with no children', () => {
-    const tree = treeBuilder(
-      [
-        { foo: 'keep', bar: 'a', count: 2, count2: 3 },
-        { foo: 'drop', bar: null, count: 5, count2: 7 },
-      ],
-      ['foo', 'bar'],
-      'count',
-      'count2',
-      true,
-    );
-    expect(tree).toEqual([
-      {
-        children: [{ groupBy: 'bar', name: 'a', secondaryValue: 3, value: 2 }],
-        groupBy: 'foo',
-        name: 'keep',
-        secondaryValue: 3,
-        value: 2,
-      },
-    ]);
-  });
 });

superset-frontend/plugins/plugin-chart-point-cluster-map/package.json

@@ -27,7 +27,7 @@
   ],
   "dependencies": {
     "@math.gl/web-mercator": "^4.1.0",
-    "mapbox-gl": "^3.25.0",
+    "mapbox-gl": "^3.24.1",
     "maplibre-gl": "^5.24.0",
     "react-map-gl": "^8.1.1",
     "supercluster": "^8.0.1"

superset-frontend/plugins/plugin-chart-table/src/buildQuery.ts

@@ -86,13 +86,6 @@ export const buildQuery: BuildQuery<TableChartFormData> = (
     let { metrics, orderby = [], columns = [] } = baseQueryObject;
     const { extras = {} } = baseQueryObject;
     const postProcessing: PostProcessingRule[] = [];
-    // Capture the percent-metric `contribution` rule so it can be reused for
-    // the totals query below. Without it the totals row's percent-metric
-    // columns are keyed `metric` instead of `%metric`, so the footer renders
-    // 0.000%. We reuse only this rule and not the full `postProcessing` array,
-    // which may also contain a time-comparison operator that must not run on
-    // the single totals row.
-    let contributionPostProcessing: PostProcessingRule | undefined;
     const nonCustomNorInheritShifts = ensureIsArray(
       formData.time_compare,
     ).filter((shift: string) => shift !== 'custom' && shift !== 'inherit');
@@ -144,6 +137,12 @@ export const buildQuery: BuildQuery<TableChartFormData> = (
         orderby = [[metrics[0], false]];
       }
       // add postprocessing for percent metrics only when in aggregation mode
+      type PercentMetricCalculationMode = 'row_limit' | 'all_records';
+
+      const calculationMode: PercentMetricCalculationMode =
+        (formData.percent_metric_calculation as PercentMetricCalculationMode) ||
+        'row_limit';
+
       if (percentMetrics && percentMetrics.length > 0) {
         const percentMetricsLabelsWithTimeComparison = isTimeComparison(
           formData,
@@ -163,14 +162,23 @@ export const buildQuery: BuildQuery<TableChartFormData> = (
           getMetricLabel,
         );
 
-        contributionPostProcessing = {
-          operation: 'contribution',
-          options: {
-            columns: percentMetricLabels,
-            rename_columns: percentMetricLabels.map(m => `%${m}`),
-          },
-        };
-        postProcessing.push(contributionPostProcessing);
+        if (calculationMode === 'all_records') {
+          postProcessing.push({
+            operation: 'contribution',
+            options: {
+              columns: percentMetricLabels,
+              rename_columns: percentMetricLabels.map(m => `%${m}`),
+            },
+          });
+        } else {
+          postProcessing.push({
+            operation: 'contribution',
+            options: {
+              columns: percentMetricLabels,
+              rename_columns: percentMetricLabels.map(m => `%${m}`),
+            },
+          });
+        }
       }
 
       // Add the operator for the time comparison if some is selected
@@ -349,13 +357,7 @@ export const buildQuery: BuildQuery<TableChartFormData> = (
         columns: [],
         row_limit: 0,
         row_offset: 0,
-        // Reapply only the percent-metric contribution rule so the totals row
-        // exposes `%metric` keys (value/value = 100% on the single aggregated
-        // row). The time-comparison operator from the main query is omitted on
-        // purpose; it must not run against the single-row totals query.
-        post_processing: contributionPostProcessing
-          ? [contributionPostProcessing]
-          : [],
+        post_processing: [],
         order_desc: undefined,
         orderby: undefined,
       });

superset-frontend/plugins/plugin-chart-table/test/buildQuery.test.ts

@@ -236,83 +236,6 @@ describe('plugin-chart-table', () => {
         expect(queries).toHaveLength(1);
         expect(queries[0].post_processing).toEqual([]);
       });
-
-      test('should reapply contribution op to totals query in row_limit mode', () => {
-        // Regression test for #37627: with a percent metric and Show Summary
-        // (show_totals) enabled, the totals query must rename percent-metric
-        // columns (`metric` -> `%metric`) so the footer can look them up.
-        // Otherwise the totals row renders 0.000%.
-        const formData = {
-          ...baseFormDataWithPercents,
-          show_totals: true,
-        };
-
-        const { queries } = buildQuery(formData);
-
-        // row_limit mode + show_totals -> [main, totals].
-        expect(queries).toHaveLength(2);
-
-        const contributionRule = {
-          operation: 'contribution',
-          options: {
-            columns: ['sum_sales'],
-            rename_columns: ['%sum_sales'],
-          },
-        };
-
-        expect(queries[1]).toMatchObject({
-          columns: [],
-          post_processing: [contributionRule],
-        });
-      });
-
-      test('should omit time-comparison op from totals post_processing', () => {
-        // The totals query must reuse ONLY the contribution rule; the
-        // time-comparison operator from the main query must not run against
-        // the single-row totals query.
-        const formData = {
-          ...baseFormDataWithPercents,
-          show_totals: true,
-          time_compare: ['1 year ago'],
-          comparison_type: 'values',
-        };
-
-        const { queries } = buildQuery(formData);
-
-        // row_limit mode + show_totals -> [main, totals].
-        expect(queries).toHaveLength(2);
-
-        const totalsQuery = queries[1];
-
-        // Exactly one op (contribution) — the time-comparison operator from the
-        // main query must not be carried over to the single-row totals query.
-        expect(totalsQuery.post_processing).toHaveLength(1);
-        expect(totalsQuery.post_processing?.[0]).toMatchObject({
-          operation: 'contribution',
-        });
-        // The reused rule matches the main query's contribution rule verbatim.
-        expect(totalsQuery.post_processing?.[0]).toEqual(
-          queries[0].post_processing?.find(
-            op => op?.operation === 'contribution',
-          ),
-        );
-      });
-
-      test('should leave totals post_processing empty without percent metrics', () => {
-        const formData = {
-          ...basicFormData,
-          query_mode: QueryMode.Aggregate,
-          metrics: ['count'],
-          percent_metrics: [],
-          groupby: ['category'],
-          show_totals: true,
-        };
-
-        const { queries } = buildQuery(formData);
-
-        expect(queries).toHaveLength(2);
-        expect(queries[1].post_processing).toEqual([]);
-      });
     });
 
     describe('Testing for server pagination with search filter', () => {

superset-frontend/plugins/preset-chart-deckgl/src/components/Legend.test.tsx

@@ -1,71 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-// eslint-disable-next-line import/no-extraneous-dependencies
-import { render, screen } from '@testing-library/react';
-// eslint-disable-next-line import/no-extraneous-dependencies
-import '@testing-library/jest-dom';
-import { supersetTheme, ThemeProvider } from '@apache-superset/core/theme';
-import type { ReactElement } from 'react';
-import Legend from './Legend';
-
-const renderWithTheme = (component: ReactElement) =>
-  render(<ThemeProvider theme={supersetTheme}>{component}</ThemeProvider>);
-
-test('formats interval-notation labels while preserving brackets', () => {
-  renderWithTheme(
-    <Legend
-      format=",.2f"
-      categories={{
-        '[1, 81)': { enabled: true, color: [0, 0, 0] },
-        '[81, 212)': { enabled: true, color: [0, 0, 0] },
-        '[212, 369]': { enabled: true, color: [0, 0, 0] },
-      }}
-    />,
-  );
-
-  expect(screen.getByText('[1.00, 81.00)')).toBeInTheDocument();
-  expect(screen.getByText('[81.00, 212.00)')).toBeInTheDocument();
-  expect(screen.getByText('[212.00, 369.00]')).toBeInTheDocument();
-});
-
-test('still formats legacy "a - b" delimiter labels', () => {
-  renderWithTheme(
-    <Legend
-      format=",.1f"
-      categories={{
-        '0 - 100000': { enabled: true, color: [0, 0, 0] },
-        '100001 - 200000': { enabled: true, color: [0, 0, 0] },
-      }}
-    />,
-  );
-
-  expect(screen.getByText('0.0 - 100,000.0')).toBeInTheDocument();
-  expect(screen.getByText('100,001.0 - 200,000.0')).toBeInTheDocument();
-});
-
-test('leaves labels untouched when no format is provided', () => {
-  renderWithTheme(
-    <Legend
-      format={null}
-      categories={{ '[1, 81)': { enabled: true, color: [0, 0, 0] } }}
-    />,
-  );
-
-  expect(screen.getByText('[1, 81)')).toBeInTheDocument();
-});

superset-frontend/plugins/preset-chart-deckgl/src/components/Legend.tsx

@@ -59,33 +59,6 @@ const StyledLegend = styled.div`
 
 const categoryDelimiter = ' - ';
 
-const OPENING_BRACKETS = '[(';
-const CLOSING_BRACKETS = '])';
-
-// Recognize half-open interval labels like "[1, 81)" or "[81, 212]" emitted by
-// getBuckets: brackets on the ends, two comma-separated bounds in between.
-// Returns the parsed pieces, or null when the label isn't interval notation.
-const parseInterval = (label: string) => {
-  const open = label[0];
-  const close = label[label.length - 1];
-  if (!OPENING_BRACKETS.includes(open) || !CLOSING_BRACKETS.includes(close)) {
-    return null;
-  }
-
-  const bounds = label.slice(1, -1).split(',');
-  if (bounds.length !== 2) {
-    return null;
-  }
-
-  const lower = bounds[0].trim();
-  const upper = bounds[1].trim();
-  if (!lower || !upper) {
-    return null;
-  }
-
-  return { open, lower, upper, close };
-};
-
 export type LegendProps = {
   format: string | null;
   forceCategorical?: boolean;
@@ -118,15 +91,6 @@ const Legend = ({
       return k;
     }
 
-    // Format each numeric bound of an interval label while preserving the
-    // brackets and separator, e.g. "[1, 81)" -> "[1.00, 81.00)".
-    const interval = parseInterval(k);
-    if (interval) {
-      const { open, lower, upper, close } = interval;
-
-      return `${open}${format(lower)}, ${format(upper)}${close}`;
-    }
-
     if (k.includes(categoryDelimiter)) {
       const values = k.split(categoryDelimiter);
 
@@ -141,22 +105,8 @@ const Legend = ({
   }
 
   const categories = Object.entries(categoriesObject).map(([k, v]) => {
-    const color = `rgba(${v.color?.join(', ')})`;
-    // Render the swatch as a real coloured box rather than a colour-tinted
-    // text glyph. U+25FC/U+25FB are in Unicode's Emoji set but lack
-    // Emoji_Presentation, so Chromium resolves them to a colour-emoji font
-    // whose glyphs carry baked-in colour and ignore the CSS `color` property,
-    // producing a black square regardless of the category colour. A bordered
-    // box has no such dependency: filled when enabled, hollow when disabled.
-    const swatchStyle = {
-      display: 'inline-block',
-      width: '12px',
-      height: '12px',
-      border: `1px solid ${color}`,
-      backgroundColor: v.enabled ? color : 'transparent',
-      alignSelf: 'center',
-      flex: '0 0 auto',
-    };
+    const style = { color: `rgba(${v.color?.join(', ')})` };
+    const icon = v.enabled ? '\u25FC' : '\u25FB';
 
     return (
       <li key={k}>
@@ -172,7 +122,7 @@ const Legend = ({
             showSingleCategory(k);
           }}
         >
-          <span aria-hidden style={swatchStyle} /> {formatCategoryLabel(k)}
+          <span style={style}>{icon}</span> {formatCategoryLabel(k)}
         </a>
       </li>
     );
@@ -187,7 +137,7 @@ const Legend = ({
   };
 
   return (
-    <StyledLegend style={style}>
+    <StyledLegend className="dupa" style={style}>
       <ul>{categories}</ul>
     </StyledLegend>
   );

superset-frontend/plugins/preset-chart-deckgl/src/utils.test.ts

@@ -16,13 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { JsonObject, QueryFormData } from '@superset-ui/core';
-import {
-  getColorBreakpointsBuckets,
-  getBreakPoints,
-  getBuckets,
-  BucketsWithColorScale,
-} from './utils';
+import { getColorBreakpointsBuckets, getBreakPoints } from './utils';
 import { ColorBreakpointType } from './types';
 
 describe('getColorBreakpointsBuckets', () => {
@@ -494,42 +488,3 @@ describe('getBreakPoints', () => {
     });
   });
 });
-
-describe('getBuckets', () => {
-  const accessor = (d: JsonObject) => d.value;
-
-  const buildFeatures = (values: number[]) => values.map(value => ({ value }));
-
-  test('produces non-overlapping bucket labels (no shared endpoints)', () => {
-    // With break points [1, 81, 212, 369] the legacy behavior produced
-    // "1 - 81", "81 - 212", "212 - 369" where each interior breakpoint
-    // (81, 212) appeared in two adjacent labels, reading as overlapping
-    // ranges. Labels should instead form a clean, non-overlapping partition.
-    const fd: QueryFormData & BucketsWithColorScale = {
-      datasource: '1__table',
-      viz_type: 'deck_polygon',
-      break_points: ['1', '81', '212', '369'],
-      num_buckets: '3',
-      linear_color_scheme: ['#000000', '#ffffff'],
-      opacity: 100,
-      metric: 'count',
-    };
-    const features = buildFeatures([1, 50, 100, 200, 300, 369]);
-
-    const buckets = getBuckets(fd, features, accessor);
-    const labels = Object.keys(buckets);
-
-    // Three buckets for four breakpoints
-    expect(labels).toHaveLength(3);
-
-    // Interval notation: half-open everywhere except the last bucket, which
-    // is closed so the maximum value is included.
-    expect(labels).toEqual(['[1, 81)', '[81, 212)', '[212, 369]']);
-
-    // No numeric endpoint should appear as both an upper bound of one bucket
-    // and a lower bound of the next in an ambiguous "a - b" form.
-    labels.forEach(label => {
-      expect(label).not.toMatch(/^\d+(\.\d+)?\s-\s\d+(\.\d+)?$/);
-    });
-  });
-});

superset-frontend/plugins/preset-chart-deckgl/src/utils.ts

@@ -200,15 +200,8 @@ export function getBuckets(
     string,
     { color: Color | undefined; enabled: boolean }
   > = {};
-  const lastBucketIndex = breakPoints.length - 2;
   breakPoints.slice(1).forEach((_, i) => {
-    // Use half-open interval notation so adjacent buckets don't share an
-    // ambiguous endpoint. This mirrors the d3 `scaleThreshold` binning used
-    // for coloring, where each breakpoint is a half-open cut point. The final
-    // bucket is closed on the right so the maximum value is included.
-    const isLastBucket = i === lastBucketIndex;
-    const closingBracket = isLastBucket ? ']' : ')';
-    const range = `[${breakPoints[i]}, ${breakPoints[i + 1]}${closingBracket}`;
+    const range = `${breakPoints[i]} - ${breakPoints[i + 1]}`;
     const mid =
       0.5 * (parseFloat(breakPoints[i]) + parseFloat(breakPoints[i + 1]));
     // fix polygon doesn't show

superset-frontend/scripts/check-custom-rules.js

@@ -632,35 +632,6 @@ function processFile(filepath) {
   }
 }
 
-/**
- * Application source trees that must be authored in TypeScript. Matches the
- * top-level `src/` directory as well as each package/plugin `src/` directory.
- */
-const TS_ONLY_SOURCE_PATTERN =
-  /^(src|packages\/[^/]+\/src|plugins\/[^/]+\/src)\//;
-
-/**
- * Enforce the TypeScript-only frontend convention: no `.js`/`.jsx` files may be
- * added under the application source trees (including test files). Build
- * artifacts and root-level config files (e.g. `.storybook/preview.jsx`,
- * `webpack.config.js`) live outside these trees and are intentionally allowed.
- *
- * @param {string[]} candidateFiles paths relative to `superset-frontend/`
- */
-function checkTypeScriptOnlySource(candidateFiles) {
-  candidateFiles.forEach(file => {
-    if (TS_ONLY_SOURCE_PATTERN.test(file) && /\.(js|jsx)$/.test(file)) {
-      // eslint-disable-next-line no-console
-      console.error(
-        `${RED}✗${RESET} ${file}: frontend source must be TypeScript. ` +
-          `Rename to .ts/.tsx (the codebase is mid-migration to full ` +
-          `TypeScript; no new .js/.jsx files in src/).`,
-      );
-      errorCount += 1;
-    }
-  });
-}
-
 /**
  * Main function
  */
@@ -695,22 +666,6 @@ function main() {
     /packages\/superset-ui-core\/src\/color\/index\.ts/, // Core brand color constants
   ];
 
-  // Enforce TypeScript-only source. Run this on the raw file list (before the
-  // ignore patterns below strip out tests/stories) so that e.g. a new
-  // `*.test.jsx` is still rejected.
-  const tsOnlyCandidates =
-    args.length === 0
-      ? glob.sync('{src,packages/*/src,plugins/*/src}/**/*.{js,jsx}', {
-          ignore: [
-            '**/node_modules/**',
-            '**/esm/**',
-            '**/lib/**',
-            '**/dist/**',
-          ],
-        })
-      : args.map(f => f.replace(/^superset-frontend\//, ''));
-  checkTypeScriptOnlySource(tsOnlyCandidates);
-
   // If no files specified, check all
   if (files.length === 0) {
     files = glob.sync('src/**/*.{ts,tsx,js,jsx}', {
@@ -751,23 +706,22 @@ function main() {
   if (files.length === 0) {
     // eslint-disable-next-line no-console
     console.log('No files to check.');
-  } else {
-    // eslint-disable-next-line no-console
-    console.log(
-      `Checking ${files.length} files for Superset custom rules...\n`,
-    );
-
-    files.forEach(file => {
-      // Resolve the file path
-      const resolvedPath = path.resolve(file);
-      if (fs.existsSync(resolvedPath)) {
-        processFile(resolvedPath);
-      } else if (fs.existsSync(file)) {
-        processFile(file);
-      }
-    });
+    return;
   }
 
+  // eslint-disable-next-line no-console
+  console.log(`Checking ${files.length} files for Superset custom rules...\n`);
+
+  files.forEach(file => {
+    // Resolve the file path
+    const resolvedPath = path.resolve(file);
+    if (fs.existsSync(resolvedPath)) {
+      processFile(resolvedPath);
+    } else if (fs.existsSync(file)) {
+      processFile(file);
+    }
+  });
+
   // eslint-disable-next-line no-console
   console.log(`\n${errorCount} errors, ${warningCount} warnings`);
 
@@ -786,5 +740,4 @@ module.exports = {
   checkNoFaIcons,
   checkI18nTemplates,
   checkUntranslatedStrings,
-  checkTypeScriptOnlySource,
 };

superset-frontend/src/SqlLab/components/SqlEditor/index.tsx

@@ -891,7 +891,7 @@ const SqlEditor: FC<Props> = ({
     callback(currentSQL.current);
   };
   const renderCopyQueryButton = () => (
-    <Button type="primary">{t('Copy query')}</Button>
+    <Button type="primary">{t('COPY QUERY')}</Button>
   );
 
   const renderDatasetWarning = () => (

superset-frontend/src/SqlLab/components/SqlEditorTabHeader/SqlEditorTabHeader.test.tsx

@@ -135,17 +135,14 @@ describe('SqlEditorTabHeader', () => {
 
     test('should dispatch queryEditorSetTitle action', async () => {
       await waitFor(() =>
-        expect(
-          screen.getByTestId('rename-tab-menu-option'),
-        ).toBeInTheDocument(),
+        expect(screen.getByTestId('close-tab-menu-option')).toBeInTheDocument(),
       );
       const expectedTitle = 'typed text';
+      const mockPrompt = jest
+        .spyOn(window, 'prompt')
+        .mockImplementation(() => expectedTitle);
       fireEvent.click(screen.getByTestId('rename-tab-menu-option'));
 
-      const input = await screen.findByTestId('rename-tab-input');
-      fireEvent.change(input, { target: { value: expectedTitle } });
-      fireEvent.click(screen.getByRole('button', { name: 'Save' }));
-
       const actions = store.getActions();
       await waitFor(() =>
         expect(actions[0]).toEqual({
@@ -156,127 +153,7 @@ describe('SqlEditorTabHeader', () => {
           }),
         }),
       );
-    });
-
-    test('prefills the rename input with the current tab name', async () => {
-      await waitFor(() =>
-        expect(
-          screen.getByTestId('rename-tab-menu-option'),
-        ).toBeInTheDocument(),
-      );
-      fireEvent.click(screen.getByTestId('rename-tab-menu-option'));
-
-      const input = await screen.findByTestId('rename-tab-input');
-      expect(input).toHaveValue(defaultQueryEditor.name);
-    });
-
-    test('focuses the rename input when the modal opens', async () => {
-      await waitFor(() =>
-        expect(
-          screen.getByTestId('rename-tab-menu-option'),
-        ).toBeInTheDocument(),
-      );
-      fireEvent.click(screen.getByTestId('rename-tab-menu-option'));
-
-      const input = await screen.findByTestId('rename-tab-input');
-      await waitFor(() => expect(input).toHaveFocus());
-    });
-
-    test('disables Save when the input is empty or whitespace', async () => {
-      await waitFor(() =>
-        expect(
-          screen.getByTestId('rename-tab-menu-option'),
-        ).toBeInTheDocument(),
-      );
-      fireEvent.click(screen.getByTestId('rename-tab-menu-option'));
-
-      const input = await screen.findByTestId('rename-tab-input');
-      fireEvent.change(input, { target: { value: '   ' } });
-      expect(screen.getByRole('button', { name: 'Save' })).toBeDisabled();
-    });
-
-    test('does not dispatch or dismiss on Enter when the input is empty', async () => {
-      await waitFor(() =>
-        expect(
-          screen.getByTestId('rename-tab-menu-option'),
-        ).toBeInTheDocument(),
-      );
-      fireEvent.click(screen.getByTestId('rename-tab-menu-option'));
-
-      const input = await screen.findByTestId('rename-tab-input');
-      fireEvent.change(input, { target: { value: '   ' } });
-      fireEvent.keyDown(input, { key: 'Enter', keyCode: 13, charCode: 13 });
-
-      const dispatchedTitleChange = store
-        .getActions()
-        .some(action => action.type === QUERY_EDITOR_SET_TITLE);
-      expect(dispatchedTitleChange).toBe(false);
-      // the modal must stay open so the user can correct the name,
-      // mirroring the disabled Save button rather than dismissing like Escape
-      expect(screen.queryByRole('dialog')).toBeInTheDocument();
-    });
-
-    test('does not dispatch a title change when the modal is cancelled', async () => {
-      await waitFor(() =>
-        expect(
-          screen.getByTestId('rename-tab-menu-option'),
-        ).toBeInTheDocument(),
-      );
-      fireEvent.click(screen.getByTestId('rename-tab-menu-option'));
-
-      const input = await screen.findByTestId('rename-tab-input');
-      fireEvent.change(input, { target: { value: 'discarded text' } });
-      fireEvent.click(screen.getByRole('button', { name: 'Cancel' }));
-
-      expect(store.getActions()).toEqual([]);
-    });
-
-    test('does not dispatch a title change when dismissed with the close button', async () => {
-      await waitFor(() =>
-        expect(
-          screen.getByTestId('rename-tab-menu-option'),
-        ).toBeInTheDocument(),
-      );
-      fireEvent.click(screen.getByTestId('rename-tab-menu-option'));
-
-      const input = await screen.findByTestId('rename-tab-input');
-      fireEvent.change(input, { target: { value: 'discarded text' } });
-      fireEvent.click(screen.getByTestId('close-modal-btn'));
-
-      expect(store.getActions()).toEqual([]);
-    });
-
-    test('returns focus to the tab header after the modal is cancelled', async () => {
-      await waitFor(() =>
-        expect(
-          screen.getByTestId('rename-tab-menu-option'),
-        ).toBeInTheDocument(),
-      );
-      fireEvent.click(screen.getByTestId('rename-tab-menu-option'));
-
-      await screen.findByTestId('rename-tab-input');
-      fireEvent.click(screen.getByRole('button', { name: 'Cancel' }));
-
-      await waitFor(() =>
-        expect(screen.getByTestId('sql-editor-tab-header')).toHaveFocus(),
-      );
-    });
-
-    test('returns focus to the tab header after a successful rename', async () => {
-      await waitFor(() =>
-        expect(
-          screen.getByTestId('rename-tab-menu-option'),
-        ).toBeInTheDocument(),
-      );
-      fireEvent.click(screen.getByTestId('rename-tab-menu-option'));
-
-      const input = await screen.findByTestId('rename-tab-input');
-      fireEvent.change(input, { target: { value: 'renamed tab' } });
-      fireEvent.click(screen.getByRole('button', { name: 'Save' }));
-
-      await waitFor(() =>
-        expect(screen.getByTestId('sql-editor-tab-header')).toHaveFocus(),
-      );
+      mockPrompt.mockClear();
     });
 
     test('should dispatch removeAllOtherQueryEditors action', async () => {
@@ -319,42 +196,4 @@ describe('SqlEditorTabHeader', () => {
       );
     });
   });
-
-  test('does not leak tab-editing keystrokes from the rename input to the surrounding tabs', async () => {
-    const onContainerKeyDown = jest.fn();
-    const store = mockStore(initialState);
-    render(
-      <div onKeyDown={onContainerKeyDown}>
-        <SqlEditorTabHeader queryEditor={defaultQueryEditor} />
-      </div>,
-      { useRedux: true, store },
-    );
-
-    userEvent.click(screen.getByTestId('dropdown-trigger'));
-    await waitFor(() =>
-      expect(screen.getByTestId('rename-tab-menu-option')).toBeInTheDocument(),
-    );
-    fireEvent.click(screen.getByTestId('rename-tab-menu-option'));
-    const input = await screen.findByTestId('rename-tab-input');
-
-    // The modal portals over the editable-card tabs, whose keyboard handler would
-    // otherwise remove, navigate, or activate a tab (and swallow Space). None of
-    // these keys should escape the modal to the surrounding container.
-    [
-      'Delete',
-      'Backspace',
-      'ArrowLeft',
-      'ArrowRight',
-      'Home',
-      'End',
-      ' ',
-    ].forEach(key => fireEvent.keyDown(input, { key }));
-    expect(onContainerKeyDown).not.toHaveBeenCalled();
-
-    // Escape (close) and Tab (focus trap) must still reach the Modal.
-    fireEvent.keyDown(input, { key: 'Tab' });
-    fireEvent.keyDown(input, { key: 'Escape' });
-    const reached = onContainerKeyDown.mock.calls.map(call => call[0].key);
-    expect(reached).toEqual(expect.arrayContaining(['Tab', 'Escape']));
-  });
 });

superset-frontend/src/SqlLab/components/SqlEditorTabHeader/index.tsx

@@ -16,17 +16,12 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { useEffect, useMemo, useRef, useState, FC } from 'react';
+import { useMemo, FC } from 'react';
 
 import { bindActionCreators } from 'redux';
 import { useSelector, shallowEqual } from 'react-redux';
 import { useAppDispatch } from 'src/SqlLab/hooks/useAppDispatch';
-import {
-  MenuDotsDropdown,
-  Modal,
-  Input,
-  InputRef,
-} from '@superset-ui/core/components';
+import { MenuDotsDropdown } from '@superset-ui/core/components';
 import { Menu, MenuItemType } from '@superset-ui/core/components/Menu';
 import { t } from '@apache-superset/core/translation';
 import { QueryState } from '@superset-ui/core';
@@ -112,35 +107,13 @@ const SqlEditorTabHeader: FC<Props> = ({ queryEditor }) => {
     [dispatch],
   );
 
-  const [isRenameModalOpen, setIsRenameModalOpen] = useState(false);
-  const [newTitle, setNewTitle] = useState('');
-  const renameInputRef = useRef<InputRef>(null);
-  const tabHeaderRef = useRef<HTMLDivElement>(null);
-  const trimmedTitle = newTitle.trim();
-
-  function openRenameModal() {
-    setNewTitle(qe.name);
-    setIsRenameModalOpen(true);
-  }
-
-  // antd's Modal moves focus to the dialog container on open, which overrides
-  // the Input's autoFocus, so focus and select the field via a ref once the
-  // modal is open (select lets the prefilled name be overtyped, like prompt()).
-  useEffect(() => {
-    if (isRenameModalOpen) {
-      renameInputRef.current?.focus();
-      renameInputRef.current?.select();
+  function renameTab() {
+    // TODO: Replace native prompt with a proper modal dialog
+    // eslint-disable-next-line no-alert
+    const newTitle = prompt(t('Enter a new title for the tab'));
+    if (newTitle) {
+      actions.queryEditorSetTitle(qe, newTitle, qe.id);
     }
-  }, [isRenameModalOpen]);
-
-  function handleRenameTab() {
-    if (trimmedTitle) {
-      actions.queryEditorSetTitle(qe, trimmedTitle, qe.id);
-    }
-    setIsRenameModalOpen(false);
-    // Save closes via the show prop rather than the Modal's onHide, so return
-    // focus to the tab header here, matching what openerRef does on dismiss.
-    tabHeaderRef.current?.focus();
   }
   const getStatusColor = (state: QueryState, theme: SupersetTheme): string => {
     const statusColors: Record<QueryState, string> = {
@@ -158,11 +131,7 @@ const SqlEditorTabHeader: FC<Props> = ({ queryEditor }) => {
     return statusColors[state] || theme.colorIcon;
   };
   return (
-    <TabTitleWrapper
-      ref={tabHeaderRef}
-      tabIndex={-1}
-      data-test="sql-editor-tab-header"
-    >
+    <TabTitleWrapper>
       <MenuDotsDropdown
         trigger={['click']}
         overlay={
@@ -189,7 +158,7 @@ const SqlEditorTabHeader: FC<Props> = ({ queryEditor }) => {
               } as MenuItemType,
               {
                 key: '2',
-                onClick: openRenameModal,
+                onClick: renameTab,
                 'data-test': 'rename-tab-menu-option',
                 label: (
                   <>
@@ -251,37 +220,6 @@ const SqlEditorTabHeader: FC<Props> = ({ queryEditor }) => {
         iconSize="m"
         iconColor={getStatusColor(queryState, theme)}
       />{' '}
-      <Modal
-        show={isRenameModalOpen}
-        onHide={() => setIsRenameModalOpen(false)}
-        title={t('Rename tab')}
-        onHandledPrimaryAction={handleRenameTab}
-        primaryButtonName={t('Save')}
-        disablePrimaryButton={!trimmedTitle}
-        openerRef={tabHeaderRef}
-      >
-        <Input
-          ref={renameInputRef}
-          data-test="rename-tab-input"
-          aria-label={t('Tab name')}
-          value={newTitle}
-          onChange={e => setNewTitle(e.target.value)}
-          onPressEnter={() => {
-            if (trimmedTitle) {
-              handleRenameTab();
-            }
-          }}
-          onKeyDown={e => {
-            // The modal portals over the editable-card tabs; without this, keys
-            // bubble to their handler and remove, navigate, or activate a tab
-            // (Space included). Escape and Tab are left to bubble so the Modal
-            // can close and trap focus.
-            if (e.key !== 'Escape' && e.key !== 'Tab') {
-              e.stopPropagation();
-            }
-          }}
-        />
-      </Modal>
     </TabTitleWrapper>
   );
 };

superset-frontend/src/components/GridTable/Header.test.tsx

@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import type { Column, GridApi, IHeaderParams } from 'ag-grid-community';
+import type { Column, GridApi } from 'ag-grid-community';
 import { act, fireEvent, render } from 'spec/helpers/testing-library';
 import { Header } from './Header';
 import { PIVOT_COL_ID } from './constants';
@@ -38,70 +38,9 @@ jest.mock('@superset-ui/core/components/Icons', () => {
   };
 });
 
-class MockColumn {
-  private colListeners = new Map<string, Set<Function>>();
-
-  sortValue: string | null = 'asc';
-
-  sortIndexValue: number | null = null;
-
-  getColId() {
-    return '123';
-  }
-
-  isPinnedLeft() {
-    return true;
-  }
-
-  isPinnedRight() {
-    return false;
-  }
-
-  isVisible() {
-    return true;
-  }
-
-  getSort() {
-    return this.sortValue;
-  }
-
-  getSortIndex() {
-    return this.sortIndexValue;
-  }
-
-  addEventListener(eventType: string, listener: Function) {
-    if (!this.colListeners.has(eventType)) {
-      this.colListeners.set(eventType, new Set());
-    }
-    this.colListeners.get(eventType)!.add(listener);
-  }
-
-  removeEventListener(eventType: string, listener: Function) {
-    this.colListeners.get(eventType)?.delete(listener);
-  }
-
-  triggerEvent(eventType: string) {
-    this.colListeners.get(eventType)?.forEach(listener => listener({}));
-  }
-}
-
-class MockOtherColumn extends MockColumn {
-  getColId() {
-    return 'other-col';
-  }
-}
-
-class MockApi {
-  mockColumn = new MockColumn();
-
-  otherColumn = new MockOtherColumn();
-
+class MockApi extends EventTarget {
   getAllDisplayedColumns() {
-    return [this.mockColumn, this.otherColumn];
-  }
-
-  getColumns() {
-    return [this.mockColumn, this.otherColumn];
+    return [];
   }
 
   isDestroyed() {
@@ -109,76 +48,48 @@ class MockApi {
   }
 }
 
-const mockApi = new MockApi();
-
 const mockedProps = {
   displayName: 'test column',
-  progressSort: jest.fn(),
+  setSort: jest.fn(),
   enableSorting: true,
-  column: mockApi.mockColumn as any as Column,
-  api: mockApi as any as GridApi,
-} as unknown as IHeaderParams;
+  column: {
+    getColId: () => '123',
+    isPinnedLeft: () => true,
+    isPinnedRight: () => false,
+    getSort: () => 'asc',
+    getSortIndex: () => null,
+  } as any as Column,
+  api: new MockApi() as any as GridApi,
+};
 
 test('renders display name for the column', () => {
   const { queryByText } = render(<Header {...mockedProps} />);
   expect(queryByText(mockedProps.displayName)).toBeInTheDocument();
 });
 
-test('calls progressSort without shiftKey on click', () => {
-  const { getByText } = render(<Header {...mockedProps} />);
+test('sorts by clicking a column header', () => {
+  const { getByText, queryByTestId } = render(<Header {...mockedProps} />);
   fireEvent.click(getByText(mockedProps.displayName));
-  expect(mockedProps.progressSort).toHaveBeenCalledWith(false);
-});
-
-test('calls progressSort with shiftKey on shift-click', () => {
-  const { getByText } = render(<Header {...mockedProps} />);
-  fireEvent.click(getByText(mockedProps.displayName), { shiftKey: true });
-  expect(mockedProps.progressSort).toHaveBeenCalledWith(true);
-});
-
-test('synchronizes sort icon when columnStateUpdated fires on column', async () => {
-  const { findByTestId, queryByTestId } = render(<Header {...mockedProps} />);
+  expect(mockedProps.setSort).toHaveBeenCalledWith('asc', false);
+  expect(queryByTestId('mock-sort-asc')).toBeInTheDocument();
+  fireEvent.click(getByText(mockedProps.displayName));
+  expect(mockedProps.setSort).toHaveBeenCalledWith('desc', false);
+  expect(queryByTestId('mock-sort-desc')).toBeInTheDocument();
+  fireEvent.click(getByText(mockedProps.displayName));
+  expect(mockedProps.setSort).toHaveBeenCalledWith(null, false);
   expect(queryByTestId('mock-sort-asc')).not.toBeInTheDocument();
+  expect(queryByTestId('mock-sort-desc')).not.toBeInTheDocument();
+});
 
+test('synchronizes the current sort when sortChanged event occurred', async () => {
+  const { findByTestId } = render(<Header {...mockedProps} />);
   act(() => {
-    mockApi.mockColumn.triggerEvent('columnStateUpdated');
+    mockedProps.api.dispatchEvent(new Event('sortChanged'));
   });
-
   const sortAsc = await findByTestId('mock-sort-asc');
   expect(sortAsc).toBeInTheDocument();
 });
 
-test('shows sortIndex label when multi-sort is active', async () => {
-  const { findByText } = render(<Header {...mockedProps} />);
-
-  act(() => {
-    mockApi.mockColumn.sortIndexValue = 1;
-    mockApi.otherColumn.sortValue = 'desc';
-    mockApi.mockColumn.triggerEvent('columnStateUpdated');
-  });
-
-  const label = await findByText('2');
-  expect(label).toBeInTheDocument();
-});
-
-test('hides sortIndex label when multi-sort is cleared', async () => {
-  const { queryByText } = render(<Header {...mockedProps} />);
-
-  act(() => {
-    mockApi.mockColumn.sortIndexValue = 1;
-    mockApi.otherColumn.sortValue = 'desc';
-    mockApi.mockColumn.triggerEvent('columnStateUpdated');
-  });
-
-  act(() => {
-    mockApi.mockColumn.sortIndexValue = null;
-    mockApi.otherColumn.sortValue = null;
-    mockApi.mockColumn.triggerEvent('columnStateUpdated');
-  });
-
-  expect(queryByText('2')).not.toBeInTheDocument();
-});
-
 test('disable menu when enableFilterButton is false', () => {
   const { queryByText, queryByTestId } = render(
     <Header {...mockedProps} enableFilterButton={false} />,
@@ -188,39 +99,18 @@ test('disable menu when enableFilterButton is false', () => {
 });
 
 test('hide display name for PIVOT_COL_ID', () => {
-  const pivotColumn = new MockColumn();
-  (pivotColumn as any).getColId = () => PIVOT_COL_ID;
-
   const { queryByText } = render(
-    <Header {...mockedProps} column={pivotColumn as any as Column} />,
+    <Header
+      {...mockedProps}
+      column={
+        {
+          getColId: () => PIVOT_COL_ID,
+          isPinnedLeft: () => true,
+          isPinnedRight: () => false,
+          getSortIndex: () => null,
+        } as any as Column
+      }
+    />,
   );
   expect(queryByText(mockedProps.displayName)).not.toBeInTheDocument();
 });
-
-test('does not attach click handler when enableSorting is false', () => {
-  const { getByText } = render(
-    <Header {...mockedProps} enableSorting={false} />,
-  );
-  const cell = getByText(mockedProps.displayName).closest(
-    '.ag-header-cell-label',
-  );
-  expect(cell).not.toHaveAttribute('role', 'button');
-});
-
-test('does not call progressSort on click when enableSorting is false', () => {
-  const progressSort = jest.fn();
-  const { getByText } = render(
-    <Header {...mockedProps} enableSorting={false} progressSort={progressSort} />,
-  );
-  fireEvent.click(getByText(mockedProps.displayName));
-  expect(progressSort).not.toHaveBeenCalled();
-});
-
-test('does not render sort icons when enableSorting is false', () => {
-  const { queryByTestId } = render(
-    <Header {...mockedProps} enableSorting={false} />,
-  );
-  expect(queryByTestId('mock-sort')).not.toBeInTheDocument();
-  expect(queryByTestId('mock-sort-asc')).not.toBeInTheDocument();
-  expect(queryByTestId('mock-sort-desc')).not.toBeInTheDocument();
-});

superset-frontend/src/components/GridTable/Header.tsx

@@ -16,16 +16,32 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { useCallback, useEffect, useState } from 'react';
-import type { IHeaderParams, Column, SortDirection } from 'ag-grid-community';
-
+import {
+  type MouseEvent,
+  useCallback,
+  useEffect,
+  useRef,
+  useState,
+} from 'react';
 import { t } from '@apache-superset/core/translation';
 import { styled, useTheme } from '@apache-superset/core/theme';
-import { Icons } from '@superset-ui/core/components/Icons';
+import type { Column, GridApi } from 'ag-grid-community';
 
+import { Icons } from '@superset-ui/core/components/Icons';
 import { PIVOT_COL_ID } from './constants';
 import { HeaderMenu } from './HeaderMenu';
 
+interface Params {
+  enableFilterButton?: boolean;
+  enableSorting?: boolean;
+  displayName: string;
+  column: Column;
+  api: GridApi;
+  setSort: (sort: string | null, multiSort: boolean) => void;
+}
+
+const SORT_DIRECTION = [null, 'asc', 'desc'];
+
 const HeaderCell = styled.div`
   display: flex;
   flex: 1;
@@ -71,26 +87,30 @@ const IconPlaceholder = styled.div`
   top: 0;
 `;
 
-export const Header: React.FC<IHeaderParams> = ({
+export const Header: React.FC<Params> = ({
   enableFilterButton,
   enableSorting,
   displayName,
-  progressSort,
+  setSort,
   column,
   api,
-}: IHeaderParams) => {
+}: Params) => {
   const theme = useTheme();
   const colId = column.getColId();
   const pinnedLeft = column.isPinnedLeft();
   const pinnedRight = column.isPinnedRight();
+  const sortOption = useRef<number>(0);
   const [invisibleColumns, setInvisibleColumns] = useState<Column[]>([]);
-  const [currentSort, setCurrentSort] = useState<SortDirection>(null);
+  const [currentSort, setCurrentSort] = useState<string | null>(null);
   const [sortIndex, setSortIndex] = useState<number | null>();
   const onSort = useCallback(
-    (event: React.MouseEvent) => {
-      progressSort(event.shiftKey);
+    (event: MouseEvent) => {
+      sortOption.current = (sortOption.current + 1) % SORT_DIRECTION.length;
+      const sort = SORT_DIRECTION[sortOption.current];
+      setSort(sort, event.shiftKey);
+      setCurrentSort(sort);
     },
-    [progressSort],
+    [setSort],
   );
   const onVisibleChange = useCallback(
     (isVisible: boolean) => {
@@ -103,22 +123,24 @@ export const Header: React.FC<IHeaderParams> = ({
     [api],
   );
 
-  const syncSortState = useCallback(() => {
+  const onSortChanged = useCallback(() => {
     const hasMultiSort = api
       .getAllDisplayedColumns()
-      .some(c => c.getColId() !== colId && c.getSort() !== null);
+      .some(c => c.getSortIndex());
+    const updatedSortIndex = column.getSortIndex();
+    sortOption.current = SORT_DIRECTION.indexOf(column.getSort() ?? null);
     setCurrentSort(column.getSort() ?? null);
-    setSortIndex(hasMultiSort ? column.getSortIndex() : null);
-  }, [api, column, colId]);
+    setSortIndex(hasMultiSort ? updatedSortIndex : null);
+  }, [api, column]);
 
   useEffect(() => {
-    column.addEventListener('columnStateUpdated', syncSortState);
+    api.addEventListener('sortChanged', onSortChanged);
 
     return () => {
       if (api.isDestroyed()) return;
-      column.removeEventListener('columnStateUpdated', syncSortState);
+      api.removeEventListener('sortChanged', onSortChanged);
     };
-  }, [column, syncSortState]);
+  }, [api, onSortChanged]);
 
   return (
     <>

superset-frontend/src/core/chat/ChatHost.test.tsx

@@ -1,277 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import { act, render, screen } from 'spec/helpers/testing-library';
-import { chat } from 'src/core/chat';
-import ChatProvider from './ChatProvider';
-import { ChatFloatingHost as ChatHost, ChatPanelHost } from './ChatHost';
-
-beforeEach(() => {
-  ChatProvider.getInstance().reset();
-});
-
-test('renders nothing when no chat extension is registered', () => {
-  render(<ChatHost />);
-
-  expect(screen.queryByTestId('chat-mount')).not.toBeInTheDocument();
-});
-
-test('renders the trigger bubble of the registered chat', () => {
-  chat.registerChat(
-    { id: 'acme.chat', name: 'Acme Chat' },
-    () => <button type="button">Acme Bubble</button>,
-    () => <div>Acme Panel</div>,
-  );
-
-  render(<ChatHost />);
-
-  expect(screen.getByTestId('chat-mount')).toBeInTheDocument();
-  expect(screen.getByText('Acme Bubble')).toBeInTheDocument();
-  // The panel stays unmounted until the chat is opened.
-  expect(screen.queryByText('Acme Panel')).not.toBeInTheDocument();
-});
-
-test('mounts the panel when the chat opens and unmounts it on close', () => {
-  chat.registerChat(
-    { id: 'acme.chat', name: 'Acme Chat' },
-    () => <button type="button">Acme Bubble</button>,
-    () => <div>Acme Panel</div>,
-  );
-
-  render(<ChatHost />);
-
-  act(() => chat.open());
-
-  expect(screen.getByText('Acme Panel')).toBeInTheDocument();
-  // In floating mode the trigger stays mounted alongside the open panel.
-  expect(screen.getByText('Acme Bubble')).toBeInTheDocument();
-
-  act(() => chat.close());
-
-  expect(screen.queryByText('Acme Panel')).not.toBeInTheDocument();
-});
-
-test('renders the last-registered chat when several are installed', () => {
-  jest.spyOn(console, 'warn').mockImplementation(() => {});
-
-  chat.registerChat(
-    { id: 'first.chat', name: 'First Chat' },
-    () => <div>First Bubble</div>,
-    () => <div>First Panel</div>,
-  );
-  chat.registerChat(
-    { id: 'second.chat', name: 'Second Chat' },
-    () => <div>Second Bubble</div>,
-    () => <div>Second Panel</div>,
-  );
-
-  jest.restoreAllMocks();
-  render(<ChatHost />);
-
-  // Last-loaded wins: the second registration takes over the singleton slot.
-  expect(screen.getByText('Second Bubble')).toBeInTheDocument();
-  expect(screen.queryByText('First Bubble')).not.toBeInTheDocument();
-});
-
-test('reacts to a chat registering after the initial render', () => {
-  render(<ChatHost />);
-
-  expect(screen.queryByTestId('chat-mount')).not.toBeInTheDocument();
-
-  act(() => {
-    chat.registerChat(
-      { id: 'acme.chat', name: 'Acme Chat' },
-      () => <button type="button">Acme Bubble</button>,
-      () => <div>Acme Panel</div>,
-    );
-  });
-
-  expect(screen.getByText('Acme Bubble')).toBeInTheDocument();
-});
-
-test('a takeover mounts the incoming chat closed', () => {
-  chat.registerChat(
-    { id: 'first.chat', name: 'First Chat' },
-    () => <div>First Bubble</div>,
-    () => <div>First Panel</div>,
-  );
-
-  render(<ChatHost />);
-  act(() => chat.open());
-  expect(screen.getByText('First Panel')).toBeInTheDocument();
-
-  act(() => {
-    jest.spyOn(console, 'warn').mockImplementation(() => {});
-    chat.registerChat(
-      { id: 'second.chat', name: 'Second Chat' },
-      () => <div>Second Bubble</div>,
-      () => <div>Second Panel</div>,
-    );
-    jest.restoreAllMocks();
-  });
-
-  // The displaced chat's open state must not leak into the winner.
-  expect(screen.getByText('Second Bubble')).toBeInTheDocument();
-  expect(screen.queryByText('Second Panel')).not.toBeInTheDocument();
-  expect(screen.queryByText('First Panel')).not.toBeInTheDocument();
-});
-
-test('ChatPanelHost renders the panel when open in panel mode', () => {
-  chat.registerChat(
-    { id: 'acme.chat', name: 'Acme Chat' },
-    () => <button type="button">Acme Bubble</button>,
-    () => <div>Acme Panel</div>,
-  );
-
-  render(<ChatPanelHost />);
-
-  act(() => {
-    chat.setDisplayMode('panel');
-    chat.open();
-  });
-
-  expect(screen.getByText('Acme Panel')).toBeInTheDocument();
-});
-
-test('ChatFloatingHost suppresses the floating panel in panel mode but keeps the trigger', () => {
-  chat.registerChat(
-    { id: 'acme.chat', name: 'Acme Chat' },
-    () => <button type="button">Acme Bubble</button>,
-    () => <div>Acme Panel</div>,
-  );
-
-  render(<ChatHost />);
-
-  act(() => {
-    chat.setDisplayMode('panel');
-    chat.open();
-  });
-
-  // In panel mode the floating panel is suppressed (ChatPanelHost owns that slot).
-  expect(screen.queryByText('Acme Panel')).not.toBeInTheDocument();
-  // The trigger stays rendered so the user can reopen after collapsing.
-  expect(screen.getByText('Acme Bubble')).toBeInTheDocument();
-
-  act(() => chat.close());
-
-  // Trigger remains visible even when closed — it's the user's only way back.
-  expect(screen.getByText('Acme Bubble')).toBeInTheDocument();
-});
-
-test('a crashing panel does not take the trigger down with it', () => {
-  const FailingPanel = () => {
-    throw new Error('panel blew up');
-  };
-  chat.registerChat(
-    { id: 'acme.chat', name: 'Acme Chat' },
-    () => <button type="button">Acme Bubble</button>,
-    () => <FailingPanel />,
-  );
-
-  render(<ChatHost />);
-  act(() => chat.open());
-
-  // The panel's boundary contains the crash; the trigger keeps rendering so
-  // the user is not stranded without a way back.
-  expect(screen.queryByText('panel blew up')).not.toBeInTheDocument();
-  expect(screen.getByText('Acme Bubble')).toBeInTheDocument();
-});
-
-test('isolates a failing trigger so it does not crash the host', () => {
-  const FailingTrigger = () => {
-    throw new Error('chat blew up');
-  };
-  chat.registerChat(
-    { id: 'acme.chat', name: 'Acme Chat' },
-    () => <FailingTrigger />,
-    () => <div>Acme Panel</div>,
-  );
-
-  // The host-owned error boundary catches the failure; render does not throw.
-  expect(() => render(<ChatHost />)).not.toThrow();
-  // The mount slot still renders (the boundary lives inside it), confirming
-  // the provider was actually exercised and contained.
-  expect(screen.getByTestId('chat-mount')).toBeInTheDocument();
-});
-
-test('isolates a component that throws during render', () => {
-  chat.registerChat(
-    { id: 'acme.chat', name: 'Acme Chat' },
-    () => {
-      throw new Error('provider blew up');
-    },
-    () => <div>Acme Panel</div>,
-  );
-
-  expect(() => render(<ChatHost />)).not.toThrow();
-  expect(screen.getByTestId('chat-mount')).toBeInTheDocument();
-});
-
-test('recovers from a crashed chat when a different chat takes over', () => {
-  const FailingTrigger = () => {
-    throw new Error('first chat blew up');
-  };
-  chat.registerChat(
-    { id: 'first.chat', name: 'First Chat' },
-    () => <FailingTrigger />,
-    () => <div>First Panel</div>,
-  );
-
-  render(<ChatHost />);
-  expect(screen.queryByText('Second Bubble')).not.toBeInTheDocument();
-
-  act(() => {
-    jest.spyOn(console, 'warn').mockImplementation(() => {});
-    chat.registerChat(
-      { id: 'second.chat', name: 'Second Chat' },
-      () => <div>Second Bubble</div>,
-      () => <div>Second Panel</div>,
-    );
-    jest.restoreAllMocks();
-  });
-
-  // The boundary is keyed per registration, so the latched crash from the
-  // first chat does not blank the second one.
-  expect(screen.getByText('Second Bubble')).toBeInTheDocument();
-});
-
-test('recovers from a crashed chat when a different id takes over', () => {
-  const FailingTrigger = () => {
-    throw new Error('broken release');
-  };
-  chat.registerChat(
-    { id: 'acme.chat', name: 'Acme Chat' },
-    () => <FailingTrigger />,
-    () => <div>Acme Panel</div>,
-  );
-
-  render(<ChatHost />);
-
-  act(() => {
-    jest.spyOn(console, 'warn').mockImplementation(() => {});
-    chat.registerChat(
-      { id: 'fixed.chat', name: 'Fixed Chat' },
-      () => <div>Fixed Bubble</div>,
-      () => <div>Fixed Panel</div>,
-    );
-    jest.restoreAllMocks();
-  });
-
-  // Different id: boundary key changes, latch resets, fix renders.
-  expect(screen.getByText('Fixed Bubble')).toBeInTheDocument();
-});

superset-frontend/src/core/chat/ChatHost.tsx

@@ -1,133 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import { type ComponentType, useRef } from 'react';
-import { t } from '@apache-superset/core/translation';
-import { logging } from '@apache-superset/core/utils';
-import { css, useTheme } from '@apache-superset/core/theme';
-import { ErrorBoundary } from 'src/components/ErrorBoundary';
-import { addDangerToast } from 'src/components/MessageToasts/actions';
-import { store } from 'src/views/store';
-import { useChat } from '.';
-
-const CHAT_EDGE_MARGIN = 24;
-
-/**
- * Returns an onError handler that shows a toast on crash, once per chat id.
- */
-function useCrashNotifier(chatId: string | undefined) {
-  const notifiedFor = useRef<string | undefined>(undefined);
-  return (error: Error) => {
-    if (!chatId) return;
-    logging.error('[chat] provider crashed', error);
-    if (notifiedFor.current !== chatId) {
-      notifiedFor.current = chatId;
-      store.dispatch(addDangerToast(t('The chat failed to load.')));
-    }
-  };
-}
-
-/**
- * Wraps a component in an ErrorBoundary, keyed by chat id so the boundary
- * resets when a different chat takes over.
- */
-const ChatBoundary = ({
-  component: Component,
-  onError,
-}: {
-  component: ComponentType;
-  onError: (error: Error) => void;
-}) => (
-  <ErrorBoundary showMessage={false} onError={onError}>
-    <Component />
-  </ErrorBoundary>
-);
-
-/**
- * Renders the chat panel content in panel mode. Fills its container height.
- */
-export const ChatPanelHost = () => {
-  const { chat, panel } = useChat();
-  const onError = useCrashNotifier(chat?.id);
-
-  if (!chat || !panel) {
-    return null;
-  }
-
-  return (
-    <div
-      data-test="chat-mount"
-      css={css`
-        display: flex;
-        flex-direction: column;
-        height: 100%;
-      `}
-    >
-      <ChatBoundary key={chat.id} component={panel} onError={onError} />
-    </div>
-  );
-};
-
-/**
- * Renders the chat trigger and, when the panel is open in floating mode, the
- * floating panel overlay. The trigger is always visible when a chat is
- * registered; the panel overlay is suppressed in panel mode.
- */
-export const ChatFloatingHost = () => {
-  const theme = useTheme();
-  const { open: panelOpen, mode, chat, trigger, panel } = useChat();
-  const onError = useCrashNotifier(chat?.id);
-
-  if (!chat || !trigger || !panel) {
-    return null;
-  }
-
-  return (
-    <div
-      data-test="chat-mount"
-      css={css`
-        position: fixed;
-        right: ${CHAT_EDGE_MARGIN}px;
-        bottom: ${CHAT_EDGE_MARGIN}px;
-        display: flex;
-        flex-direction: column;
-        align-items: flex-end;
-        gap: ${theme.sizeUnit * 2}px;
-        /* Above dashboard content and the toast layer, below modal dialogs. */
-        z-index: ${theme.zIndexPopupBase + 2};
-      `}
-    >
-      {/*
-        Separate boundaries so a crashing panel cannot take the trigger down
-        with it — the trigger is the user's only way back.
-      */}
-      {panelOpen && mode !== 'panel' && (
-        <ChatBoundary
-          key={`panel-${chat.id}`}
-          component={panel}
-          onError={onError}
-        />
-      )}
-      <ChatBoundary
-        key={`trigger-${chat.id}`}
-        component={trigger}
-        onError={onError}
-      />
-    </div>
-  );
-};

superset-frontend/src/core/chat/ChatProvider.test.ts

@@ -1,257 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import { createElement } from 'react';
-import ChatProvider from './ChatProvider';
-
-const trigger = () => createElement('button', null, 'Bubble');
-const panel = () => createElement('div', null, 'Panel');
-
-beforeEach(() => {
-  ChatProvider.getInstance().reset();
-});
-
-test('returns the singleton instance', () => {
-  expect(ChatProvider.getInstance()).toBe(ChatProvider.getInstance());
-});
-
-test('getChat returns undefined when no chat is registered', () => {
-  expect(ChatProvider.getInstance().getChat()).toBeUndefined();
-});
-
-test('registerChat sets the registration and returns the descriptor copy', () => {
-  const provider = ChatProvider.getInstance();
-  const descriptor = { id: 'acme.chat', name: 'Acme Chat' };
-  const disposable = provider.registerChat(descriptor, trigger, panel);
-
-  expect(provider.getChat()).toEqual(descriptor);
-  disposable.dispose();
-});
-
-test('the last-registered chat wins and logs a warning', () => {
-  const provider = ChatProvider.getInstance();
-  const warn = jest.spyOn(console, 'warn').mockImplementation(() => {});
-
-  provider.registerChat({ id: 'first.chat', name: 'First' }, trigger, panel);
-  provider.registerChat({ id: 'second.chat', name: 'Second' }, trigger, panel);
-
-  expect(provider.getChat()?.id).toBe('second.chat');
-  expect(warn).toHaveBeenCalledTimes(1);
-  expect(warn.mock.calls[0][0]).toContain('second.chat');
-  expect(warn.mock.calls[0][0]).toContain('first.chat');
-  warn.mockRestore();
-});
-
-test('re-registering with a different id replaces the active chat', () => {
-  const provider = ChatProvider.getInstance();
-  jest.spyOn(console, 'warn').mockImplementation(() => {});
-
-  provider.registerChat({ id: 'first.chat', name: 'First' }, trigger, panel);
-  expect(provider.getChat()?.id).toBe('first.chat');
-
-  provider.registerChat({ id: 'second.chat', name: 'Second' }, trigger, panel);
-  expect(provider.getChat()?.id).toBe('second.chat');
-
-  jest.restoreAllMocks();
-});
-
-test('disposing the registration clears it', () => {
-  const provider = ChatProvider.getInstance();
-  const disposable = provider.registerChat(
-    { id: 'acme.chat', name: 'Acme' },
-    trigger,
-    panel,
-  );
-
-  disposable.dispose();
-
-  expect(provider.getChat()).toBeUndefined();
-});
-
-test('disposing twice fires unregister only once', () => {
-  const provider = ChatProvider.getInstance();
-  const unregistered = jest.fn();
-  provider.onDidUnregisterChat(unregistered);
-
-  const disposable = provider.registerChat(
-    { id: 'acme.chat', name: 'Acme' },
-    trigger,
-    panel,
-  );
-  disposable.dispose();
-  disposable.dispose();
-
-  expect(unregistered).toHaveBeenCalledTimes(1);
-});
-
-test('onDidRegisterChat and onDidUnregisterChat fire with the descriptor', () => {
-  const provider = ChatProvider.getInstance();
-  const registered = jest.fn();
-  const unregistered = jest.fn();
-  provider.onDidRegisterChat(registered);
-  provider.onDidUnregisterChat(unregistered);
-
-  const descriptor = { id: 'acme.chat', name: 'Acme' };
-  const disposable = provider.registerChat(descriptor, trigger, panel);
-
-  expect(registered).toHaveBeenCalledWith(descriptor);
-  expect(unregistered).not.toHaveBeenCalled();
-
-  disposable.dispose();
-
-  expect(unregistered).toHaveBeenCalledWith(descriptor);
-});
-
-test('open and close toggle the panel state', () => {
-  const provider = ChatProvider.getInstance();
-  provider.registerChat({ id: 'acme.chat', name: 'Acme' }, trigger, panel);
-
-  expect(provider.isOpen()).toBe(false);
-
-  provider.open();
-  expect(provider.isOpen()).toBe(true);
-
-  provider.close();
-  expect(provider.isOpen()).toBe(false);
-});
-
-test('open fires once; duplicate open is a no-op', () => {
-  const provider = ChatProvider.getInstance();
-  const opened = jest.fn();
-  provider.onDidOpen(opened);
-  provider.registerChat({ id: 'acme.chat', name: 'Acme' }, trigger, panel);
-
-  provider.open();
-  provider.open();
-
-  expect(opened).toHaveBeenCalledTimes(1);
-});
-
-test('close fires once; duplicate close is a no-op', () => {
-  const provider = ChatProvider.getInstance();
-  const closed = jest.fn();
-  provider.onDidClose(closed);
-  provider.registerChat({ id: 'acme.chat', name: 'Acme' }, trigger, panel);
-
-  provider.open();
-  provider.close();
-  provider.close();
-
-  expect(closed).toHaveBeenCalledTimes(1);
-});
-
-test('open is a no-op when no chat is registered', () => {
-  const provider = ChatProvider.getInstance();
-  const opened = jest.fn();
-  provider.onDidOpen(opened);
-
-  provider.open();
-
-  expect(provider.isOpen()).toBe(false);
-  expect(opened).not.toHaveBeenCalled();
-});
-
-test('registering a second chat while open closes the panel', () => {
-  const provider = ChatProvider.getInstance();
-  const closed = jest.fn();
-  provider.onDidClose(closed);
-  jest.spyOn(console, 'warn').mockImplementation(() => {});
-
-  provider.registerChat({ id: 'first.chat', name: 'First' }, trigger, panel);
-  provider.open();
-  provider.registerChat({ id: 'second.chat', name: 'Second' }, trigger, panel);
-
-  expect(provider.isOpen()).toBe(false);
-  expect(closed).toHaveBeenCalledTimes(1);
-  jest.restoreAllMocks();
-});
-
-test('disposing the active chat while open closes the panel', () => {
-  const provider = ChatProvider.getInstance();
-  const closed = jest.fn();
-  provider.onDidClose(closed);
-
-  const disposable = provider.registerChat(
-    { id: 'acme.chat', name: 'Acme' },
-    trigger,
-    panel,
-  );
-  provider.open();
-  disposable.dispose();
-
-  expect(provider.isOpen()).toBe(false);
-  expect(closed).toHaveBeenCalledTimes(1);
-});
-
-test('a late registration does not inherit a stale open state', () => {
-  const provider = ChatProvider.getInstance();
-  const disposable = provider.registerChat(
-    { id: 'acme.chat', name: 'Acme' },
-    trigger,
-    panel,
-  );
-  provider.open();
-  disposable.dispose();
-
-  provider.registerChat({ id: 'late.chat', name: 'Late' }, trigger, panel);
-
-  expect(provider.isOpen()).toBe(false);
-});
-
-test('getDisplayMode defaults to floating', () => {
-  expect(ChatProvider.getInstance().getDisplayMode()).toBe('floating');
-});
-
-test('setDisplayMode updates mode and fires event only on change', () => {
-  const provider = ChatProvider.getInstance();
-  const modeChanged = jest.fn();
-  provider.onDidChangeDisplayMode(modeChanged);
-
-  provider.setDisplayMode('floating');
-  expect(modeChanged).not.toHaveBeenCalled();
-
-  provider.setDisplayMode('panel');
-  expect(provider.getDisplayMode()).toBe('panel');
-  expect(modeChanged).toHaveBeenCalledWith('panel');
-});
-
-test('state reflects changes after registration and open', () => {
-  const provider = ChatProvider.getInstance();
-
-  expect(provider.getChat()).toBeUndefined();
-  expect(provider.isOpen()).toBe(false);
-
-  provider.registerChat({ id: 'acme.chat', name: 'Acme' }, trigger, panel);
-  provider.open();
-
-  expect(provider.isOpen()).toBe(true);
-  expect(provider.getChat()?.id).toBe('acme.chat');
-});
-
-test('reset clears all state', () => {
-  const provider = ChatProvider.getInstance();
-  provider.registerChat({ id: 'acme.chat', name: 'Acme' }, trigger, panel);
-  provider.open();
-  provider.setDisplayMode('panel');
-
-  provider.reset();
-
-  expect(provider.getChat()).toBeUndefined();
-  expect(provider.isOpen()).toBe(false);
-  expect(provider.getDisplayMode()).toBe('floating');
-});

superset-frontend/src/core/chat/ChatProvider.ts

@@ -1,209 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { ComponentType } from 'react';
-import type { chat as chatApi } from '@apache-superset/core';
-import {
-  LocalStorageKeys,
-  getItem,
-  setItem,
-} from 'src/utils/localStorageHelpers';
-import { Disposable } from '../models';
-import { createValueEventEmitter, createEventEmitter } from '../utils';
-
-type Chat = chatApi.Chat;
-type DisplayMode = chatApi.DisplayMode;
-
-/**
- * Singleton manager for the chat provider.
- * Handles registration, open/close state, and display mode.
- */
-class ChatProvider {
-  private static instance: ChatProvider;
-
-  private chat: Chat | undefined;
-
-  private trigger: ComponentType | undefined;
-
-  private panel: ComponentType | undefined;
-
-  private opened: boolean;
-
-  private stateSubscribers = new Set<() => void>();
-
-  private registerEmitter = createEventEmitter<Chat>();
-
-  private unregisterEmitter = createEventEmitter<Chat>();
-
-  private openEmitter = createEventEmitter<void>();
-
-  private closeEmitter = createEventEmitter<void>();
-
-  private resizePanelEmitter = createEventEmitter<{ width: number }>();
-
-  private modeEmitter: ReturnType<typeof createValueEventEmitter<DisplayMode>>;
-
-  private constructor() {
-    const persisted = getItem(LocalStorageKeys.ChatState, {
-      open: false,
-      mode: 'floating',
-    });
-    const mode = (
-      persisted.mode === 'panel' ? 'panel' : 'floating'
-    ) as DisplayMode;
-    this.opened = persisted.open === true;
-    this.modeEmitter = createValueEventEmitter<DisplayMode>(mode);
-  }
-
-  public static getInstance(): ChatProvider {
-    if (!ChatProvider.instance) {
-      ChatProvider.instance = new ChatProvider();
-    }
-    return ChatProvider.instance;
-  }
-
-  public subscribe = (listener: () => void): (() => void) => {
-    this.stateSubscribers.add(listener);
-    return () => this.stateSubscribers.delete(listener);
-  };
-
-  private notifyState(): void {
-    setItem(LocalStorageKeys.ChatState, {
-      open: this.opened,
-      mode: this.modeEmitter.getCurrent(),
-    });
-    this.stateSubscribers.forEach(fn => fn());
-  }
-
-  private closePanel(): void {
-    this.opened = false;
-    this.closeEmitter.fire();
-  }
-
-  public registerChat(
-    chat: Chat,
-    trigger: ComponentType,
-    panel: ComponentType,
-  ): Disposable {
-    if (this.chat) {
-      // eslint-disable-next-line no-console
-      console.warn(
-        `[Superset] Multiple chat extensions registered. Using "${chat.id}"; discarding "${this.chat.id}".`,
-      );
-      this.unregisterEmitter.fire(this.chat);
-      if (this.opened) this.closePanel();
-    }
-
-    this.chat = chat;
-    this.trigger = trigger;
-    this.panel = panel;
-    this.registerEmitter.fire(chat);
-    this.notifyState();
-
-    return new Disposable(() => {
-      if (this.chat !== chat) return;
-      this.chat = undefined;
-      this.trigger = undefined;
-      this.panel = undefined;
-      this.unregisterEmitter.fire(chat);
-      if (this.opened) this.closePanel();
-      this.notifyState();
-    });
-  }
-
-  public getChat(): Chat | undefined {
-    return this.chat;
-  }
-
-  public getTrigger(): ComponentType | undefined {
-    return this.trigger;
-  }
-
-  public getPanel(): ComponentType | undefined {
-    return this.panel;
-  }
-
-  public open(): void {
-    if (this.opened || !this.chat) return;
-    this.opened = true;
-    this.openEmitter.fire();
-    this.notifyState();
-  }
-
-  public close(): void {
-    if (!this.opened || !this.chat) return;
-    this.closePanel();
-    this.notifyState();
-  }
-
-  public isOpen(): boolean {
-    return this.opened;
-  }
-
-  public getDisplayMode(): DisplayMode {
-    return this.modeEmitter.getCurrent();
-  }
-
-  public setDisplayMode(displayMode: DisplayMode): void {
-    if (displayMode === this.modeEmitter.getCurrent()) return;
-    this.modeEmitter.fire(displayMode);
-    this.notifyState();
-  }
-
-  public get onDidRegisterChat() {
-    return this.registerEmitter.subscribe;
-  }
-
-  public get onDidUnregisterChat() {
-    return this.unregisterEmitter.subscribe;
-  }
-
-  public get onDidOpen() {
-    return this.openEmitter.subscribe;
-  }
-
-  public get onDidClose() {
-    return this.closeEmitter.subscribe;
-  }
-
-  public get onDidChangeDisplayMode() {
-    return this.modeEmitter.subscribe;
-  }
-
-  public get onDidResizePanel() {
-    return this.resizePanelEmitter.subscribe;
-  }
-
-  public reset(): void {
-    this.chat = undefined;
-    this.trigger = undefined;
-    this.panel = undefined;
-    this.opened = false;
-    this.registerEmitter = createEventEmitter<Chat>();
-    this.unregisterEmitter = createEventEmitter<Chat>();
-    this.openEmitter = createEventEmitter<void>();
-    this.closeEmitter = createEventEmitter<void>();
-    this.resizePanelEmitter = createEventEmitter<{ width: number }>();
-    this.modeEmitter = createValueEventEmitter<DisplayMode>('floating');
-    this.stateSubscribers.clear();
-    setItem(LocalStorageKeys.ChatState, { open: false, mode: 'floating' });
-  }
-}
-
-export default ChatProvider;

superset-frontend/src/core/chat/index.test.ts

@@ -1,68 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import { createElement } from 'react';
-import { chat } from './index';
-import ChatProvider from './ChatProvider';
-
-const trigger = () => createElement('button', null, 'Bubble');
-const panel = () => createElement('div', null, 'Panel');
-
-beforeEach(() => {
-  ChatProvider.getInstance().reset();
-});
-
-test('getChat returns undefined when no chat is registered', () => {
-  expect(chat.getChat()).toBeUndefined();
-});
-
-test('registerChat makes the chat retrievable via getChat', () => {
-  const descriptor = { id: 'acme.chat', name: 'Acme Chat' };
-  chat.registerChat(descriptor, trigger, panel);
-
-  expect(chat.getChat()).toEqual(descriptor);
-});
-
-test('the last-registered chat wins when multiple are registered', () => {
-  jest.spyOn(console, 'warn').mockImplementation(() => {});
-
-  chat.registerChat({ id: 'first.chat', name: 'First' }, trigger, panel);
-  chat.registerChat({ id: 'second.chat', name: 'Second' }, trigger, panel);
-
-  expect(chat.getChat()?.id).toBe('second.chat');
-  jest.restoreAllMocks();
-});
-
-test('open and close toggle isOpen', () => {
-  chat.registerChat({ id: 'acme.chat', name: 'Acme' }, trigger, panel);
-
-  expect(chat.isOpen()).toBe(false);
-  chat.open();
-  expect(chat.isOpen()).toBe(true);
-  chat.close();
-  expect(chat.isOpen()).toBe(false);
-});
-
-test('getDisplayMode defaults to floating', () => {
-  expect(chat.getDisplayMode()).toBe('floating');
-});
-
-test('setDisplayMode updates the display mode', () => {
-  chat.setDisplayMode('panel');
-  expect(chat.getDisplayMode()).toBe('panel');
-});

superset-frontend/src/core/chat/index.ts

@@ -1,82 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * @fileoverview Host implementation of the `chat` contribution type.
- *
- * Extensions register via the public `chat.registerChat()` and the host owns
- * mounting, open/close state, and the display mode. Only the last-registered
- * chat is active at a time.
- *
- * The public namespace (`chat`) is exposed to extensions on `window.superset`.
- * `useChat` is host-internal and NOT part of the public `@apache-superset/core` API.
- */
-
-import { useSyncExternalStore } from 'react';
-import memoizeOne from 'memoize-one';
-import type { chat as chatApi } from '@apache-superset/core';
-import ChatProvider from './ChatProvider';
-
-export { ChatFloatingHost, ChatPanelHost } from './ChatHost';
-
-const provider = ChatProvider.getInstance();
-
-const buildSnapshot = memoizeOne(
-  (
-    open: boolean,
-    mode: chatApi.DisplayMode,
-    chat: chatApi.Chat | undefined,
-    trigger: ReturnType<typeof provider.getTrigger>,
-    panel: ReturnType<typeof provider.getPanel>,
-  ) => ({ open, mode, chat, trigger, panel }),
-);
-
-const getSnapshot = () =>
-  buildSnapshot(
-    provider.isOpen(),
-    provider.getDisplayMode(),
-    provider.getChat(),
-    provider.getTrigger(),
-    provider.getPanel(),
-  );
-
-/**
- * Host-internal hook. Returns the current open/mode state and the active chat
- * (trigger, panel, descriptor).
- */
-export const useChat = () =>
-  useSyncExternalStore(provider.subscribe, getSnapshot);
-
-export const chat: typeof chatApi = {
-  registerChat: provider.registerChat.bind(provider),
-  getChat: provider.getChat.bind(provider),
-  onDidRegisterChat: provider.onDidRegisterChat,
-  onDidUnregisterChat: provider.onDidUnregisterChat,
-  open: provider.open.bind(provider),
-  close: provider.close.bind(provider),
-  isOpen: provider.isOpen.bind(provider),
-  onDidOpen: provider.onDidOpen,
-  onDidClose: provider.onDidClose,
-  getDisplayMode: provider.getDisplayMode.bind(provider),
-  setDisplayMode: provider.setDisplayMode.bind(provider),
-  onDidChangeDisplayMode: provider.onDidChangeDisplayMode,
-  // The host fires this from its panel resizer; until that chrome exists the
-  // event is exposed but never fires.
-  onDidResizePanel: provider.onDidResizePanel,
-};

superset-frontend/src/core/dashboardComponents/DashboardComponentsProvider.ts

@@ -1,106 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { ComponentType } from 'react';
-import type { dashboardComponents as api } from '@apache-superset/core';
-import { Disposable } from '../models';
-import { createEventEmitter } from '../utils';
-
-type Definition = api.DashboardComponentDefinition;
-type Props = api.DashboardComponentProps;
-type Registered = api.RegisteredDashboardComponent;
-
-/**
- * Singleton registry for contributed dashboard components. Unlike the chat
- * provider (one active chat), this holds many components keyed by id. Built-in
- * components register here at startup; extensions register at module-load time.
- */
-class DashboardComponentsProvider {
-  private static instance: DashboardComponentsProvider;
-
-  private components = new Map<string, Registered>();
-
-  // Cached, referentially-stable snapshot for useSyncExternalStore; rebuilt
-  // only when the set of components changes.
-  private snapshot: Registered[] = [];
-
-  private stateSubscribers = new Set<() => void>();
-
-  private registerEmitter = createEventEmitter<Definition>();
-
-  private unregisterEmitter = createEventEmitter<Definition>();
-
-  public static getInstance(): DashboardComponentsProvider {
-    if (!DashboardComponentsProvider.instance) {
-      DashboardComponentsProvider.instance = new DashboardComponentsProvider();
-    }
-    return DashboardComponentsProvider.instance;
-  }
-
-  public subscribe = (listener: () => void): (() => void) => {
-    this.stateSubscribers.add(listener);
-    return () => this.stateSubscribers.delete(listener);
-  };
-
-  private notifyState(): void {
-    this.snapshot = Array.from(this.components.values());
-    this.stateSubscribers.forEach(fn => fn());
-  }
-
-  public registerDashboardComponent = (
-    definition: Definition,
-    component: ComponentType<Props>,
-  ): Disposable => {
-    if (this.components.has(definition.id)) {
-      // eslint-disable-next-line no-console
-      console.warn(
-        `[Superset] A dashboard component "${definition.id}" is already ` +
-          `registered; replacing it.`,
-      );
-    }
-    const entry: Registered = { definition, Component: component };
-    this.components.set(definition.id, entry);
-    this.registerEmitter.fire(definition);
-    this.notifyState();
-
-    return new Disposable(() => {
-      // Only remove if this exact registration is still the active one.
-      if (this.components.get(definition.id) === entry) {
-        this.components.delete(definition.id);
-        this.unregisterEmitter.fire(definition);
-        this.notifyState();
-      }
-    });
-  };
-
-  public getDashboardComponent = (id: string): Registered | undefined =>
-    this.components.get(id);
-
-  public getDashboardComponents = (): Registered[] => this.snapshot;
-
-  public get onDidRegisterDashboardComponent() {
-    return this.registerEmitter.subscribe;
-  }
-
-  public get onDidUnregisterDashboardComponent() {
-    return this.unregisterEmitter.subscribe;
-  }
-}
-
-export default DashboardComponentsProvider;

superset-frontend/src/core/dashboardComponents/index.test.ts

@@ -1,88 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import { dashboardComponents } from './index';
-
-const Noop = () => null;
-const def = (id: string) => ({ id, name: id });
-
-test('registerDashboardComponent makes a component retrievable', () => {
-  const disposable = dashboardComponents.registerDashboardComponent(
-    def('acme.widget'),
-    Noop,
-  );
-  expect(dashboardComponents.getDashboardComponent('acme.widget')).toEqual({
-    definition: def('acme.widget'),
-    Component: Noop,
-  });
-  expect(
-    dashboardComponents
-      .getDashboardComponents()
-      .some(r => r.definition.id === 'acme.widget'),
-  ).toBe(true);
-  disposable.dispose();
-});
-
-test('disposing the registration unregisters the component', () => {
-  const disposable = dashboardComponents.registerDashboardComponent(
-    def('acme.temp'),
-    Noop,
-  );
-  expect(dashboardComponents.getDashboardComponent('acme.temp')).toBeDefined();
-  disposable.dispose();
-  expect(
-    dashboardComponents.getDashboardComponent('acme.temp'),
-  ).toBeUndefined();
-});
-
-test('registering the same id twice replaces the first', () => {
-  jest.spyOn(console, 'warn').mockImplementation(() => {});
-  const A = () => null;
-  const B = () => null;
-  dashboardComponents.registerDashboardComponent(def('acme.dup'), A);
-  const second = dashboardComponents.registerDashboardComponent(
-    def('acme.dup'),
-    B,
-  );
-  expect(dashboardComponents.getDashboardComponent('acme.dup')?.Component).toBe(
-    B,
-  );
-  jest.restoreAllMocks();
-  second.dispose();
-});
-
-test('disposing a stale registration does not remove the active one', () => {
-  jest.spyOn(console, 'warn').mockImplementation(() => {});
-  const A = () => null;
-  const B = () => null;
-  const first = dashboardComponents.registerDashboardComponent(
-    def('acme.stale'),
-    A,
-  );
-  const second = dashboardComponents.registerDashboardComponent(
-    def('acme.stale'),
-    B,
-  );
-  // Disposing the superseded registration is a no-op.
-  first.dispose();
-  expect(
-    dashboardComponents.getDashboardComponent('acme.stale')?.Component,
-  ).toBe(B);
-  jest.restoreAllMocks();
-  second.dispose();
-});

superset-frontend/src/core/dashboardComponents/index.ts

@@ -1,49 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * @fileoverview Host implementation of the `dashboardComponents` contribution
- * type. Extensions register via `dashboardComponents.registerDashboardComponent()`
- * and the host renders contributed components inside its own dashboard chrome.
- *
- * The public namespace (`dashboardComponents`) is exposed to extensions on
- * `window.superset`. `useDashboardComponents` is host-internal and NOT part of
- * the public `@apache-superset/core` API.
- */
-
-import { useSyncExternalStore } from 'react';
-import type { dashboardComponents as api } from '@apache-superset/core';
-import DashboardComponentsProvider from './DashboardComponentsProvider';
-
-const provider = DashboardComponentsProvider.getInstance();
-
-/**
- * Host-internal hook returning all registered dashboard components, re-rendering
- * when the set changes.
- */
-export const useDashboardComponents = () =>
-  useSyncExternalStore(provider.subscribe, provider.getDashboardComponents);
-
-export const dashboardComponents: typeof api = {
-  registerDashboardComponent: provider.registerDashboardComponent,
-  getDashboardComponent: provider.getDashboardComponent,
-  getDashboardComponents: provider.getDashboardComponents,
-  onDidRegisterDashboardComponent: provider.onDidRegisterDashboardComponent,
-  onDidUnregisterDashboardComponent: provider.onDidUnregisterDashboardComponent,
-};

superset-frontend/src/core/editors/EditorProviders.test.ts

@@ -254,6 +254,33 @@ test('event listeners can be disposed', () => {
   expect(listener).toHaveBeenCalledTimes(1); // Still only 1 call
 });
 
+test('handles errors in event listeners gracefully', () => {
+  const manager = EditorProviders.getInstance();
+  const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation();
+
+  const errorListener = jest.fn(() => {
+    throw new Error('Listener error');
+  });
+  const successListener = jest.fn();
+
+  manager.onDidRegister(errorListener);
+  manager.onDidRegister(successListener);
+
+  manager.registerProvider(createMockEditor(), createMockEditorComponent());
+
+  // Both listeners should have been called
+  expect(errorListener).toHaveBeenCalledTimes(1);
+  expect(successListener).toHaveBeenCalledTimes(1);
+
+  // Error should have been logged
+  expect(consoleErrorSpy).toHaveBeenCalledWith(
+    'Error in event listener:',
+    expect.any(Error),
+  );
+
+  consoleErrorSpy.mockRestore();
+});
+
 test('reset clears all providers and language mappings', () => {
   const manager = EditorProviders.getInstance();
 

superset-frontend/src/core/editors/EditorProviders.ts

@@ -19,7 +19,6 @@
 
 import type { editors } from '@apache-superset/core';
 import { Disposable } from '../models';
-import { createEventEmitter } from '../utils';
 
 type EditorLanguage = editors.EditorLanguage;
 type EditorProvider = editors.EditorProvider;
@@ -28,8 +27,45 @@ type EditorComponent = editors.EditorComponent;
 type EditorRegisteredEvent = editors.EditorRegisteredEvent;
 type EditorUnregisteredEvent = editors.EditorUnregisteredEvent;
 
+/**
+ * Listener function type for events.
+ */
 type Listener<T> = (e: T) => void;
 
+/**
+ * Simple event emitter for editor provider lifecycle events.
+ */
+class EventEmitter<T> {
+  private listeners: Set<Listener<T>> = new Set();
+
+  /**
+   * Subscribe to this event.
+   * @param listener The listener function to call when the event is fired.
+   * @returns A Disposable to unsubscribe from the event.
+   */
+  subscribe(listener: Listener<T>): Disposable {
+    this.listeners.add(listener);
+    return new Disposable(() => {
+      this.listeners.delete(listener);
+    });
+  }
+
+  /**
+   * Fire the event with the given data.
+   * @param data The event data to pass to listeners.
+   */
+  fire(data: T): void {
+    this.listeners.forEach(listener => {
+      try {
+        listener(data);
+      } catch (error) {
+        // eslint-disable-next-line no-console
+        console.error('Error in event listener:', error);
+      }
+    });
+  }
+}
+
 /**
  * Singleton manager for editor providers.
  * Handles registration, resolution, and lifecycle of custom editor implementations.
@@ -47,9 +83,15 @@ class EditorProviders {
    */
   private languageToProvider: Map<EditorLanguage, string> = new Map();
 
-  private registerEmitter = createEventEmitter<EditorRegisteredEvent>();
+  /**
+   * Event emitter for provider registration events.
+   */
+  private registerEmitter = new EventEmitter<EditorRegisteredEvent>();
 
-  private unregisterEmitter = createEventEmitter<EditorUnregisteredEvent>();
+  /**
+   * Event emitter for provider unregistration events.
+   */
+  private unregisterEmitter = new EventEmitter<EditorUnregisteredEvent>();
 
   private syncListeners: Set<() => void> = new Set();
 
@@ -184,11 +226,8 @@ class EditorProviders {
    * @param listener The listener function.
    * @returns A Disposable to unsubscribe.
    */
-  public onDidRegister(
-    listener: Listener<EditorRegisteredEvent>,
-    thisArgs?: unknown,
-  ): Disposable {
-    return this.registerEmitter.subscribe(listener, thisArgs);
+  public onDidRegister(listener: Listener<EditorRegisteredEvent>): Disposable {
+    return this.registerEmitter.subscribe(listener);
   }
 
   /**
@@ -198,9 +237,8 @@ class EditorProviders {
    */
   public onDidUnregister(
     listener: Listener<EditorUnregisteredEvent>,
-    thisArgs?: unknown,
   ): Disposable {
-    return this.unregisterEmitter.subscribe(listener, thisArgs);
+    return this.unregisterEmitter.subscribe(listener);
   }
 
   /**
@@ -210,8 +248,6 @@ class EditorProviders {
     this.providers.clear();
     this.languageToProvider.clear();
     this.syncListeners.clear();
-    this.registerEmitter = createEventEmitter<EditorRegisteredEvent>();
-    this.unregisterEmitter = createEventEmitter<EditorUnregisteredEvent>();
   }
 }
 

superset-frontend/src/core/editors/index.ts

@@ -18,39 +18,130 @@
  */
 
 /**
- * @fileoverview Host implementation of the `editors` contribution type.
+ * @fileoverview Implementation of the editors API for Superset.
  *
- * Extensions register via the public `editors.registerEditor()` and the host
- * resolves the appropriate provider per language, falling back to the built-in
- * AceEditorProvider when no extension is registered.
- *
- * The public namespace (`editors`) is exposed to extensions on `window.superset`.
- * `EditorHost` is the host-internal component for rendering editors and is NOT
- * part of the public `@apache-superset/core` API.
+ * This module provides the runtime implementation of the editor registration
+ * and resolution functions declared in the API types.
  */
 
 import { useSyncExternalStore } from 'react';
 import { editors as editorsApi } from '@apache-superset/core';
+import { Disposable } from '../models';
 import EditorProviders from './EditorProviders';
 
-export type { EditorHostProps } from './EditorHost';
-export { default as EditorHost } from './EditorHost';
-export { default as AceEditorProvider } from './AceEditorProvider';
+type EditorLanguage = editorsApi.EditorLanguage;
+type Editor = editorsApi.Editor;
+type EditorProvider = editorsApi.EditorProvider;
+type EditorComponent = editorsApi.EditorComponent;
+type EditorRegisteredEvent = editorsApi.EditorRegisteredEvent;
+type EditorUnregisteredEvent = editorsApi.EditorUnregisteredEvent;
 
-const provider = EditorProviders.getInstance();
+/**
+ * Register an editor provider as a module-level side effect.
+ * Takes the editor descriptor directly rather than looking it up
+ * from a manifest by ID.
+ *
+ * @param editor The editor descriptor.
+ * @param component The React component implementing the editor.
+ * @returns A Disposable to unregister the provider.
+ */
+export const registerEditor = (
+  editor: Editor,
+  component: EditorComponent,
+): Disposable => {
+  const providers = EditorProviders.getInstance();
+  return providers.registerProvider(editor, component);
+};
 
-export const useEditor = (language: editorsApi.EditorLanguage) =>
-  useSyncExternalStore(
-    provider.subscribe,
-    () => provider.getProvider(language),
+/**
+ * Get the editor provider for a specific language.
+ * Returns the extension's editor if registered, otherwise undefined.
+ *
+ * @param language The language to get an editor for
+ * @returns The editor provider or undefined if no extension provides one
+ */
+export const getEditor = (
+  language: EditorLanguage,
+): EditorProvider | undefined => {
+  const manager = EditorProviders.getInstance();
+  return manager.getProvider(language);
+};
+
+/**
+ * Check if an extension has registered an editor for a language.
+ *
+ * @param language The language to check
+ * @returns True if an extension provides an editor for this language
+ */
+export const hasEditor = (language: EditorLanguage): boolean => {
+  const manager = EditorProviders.getInstance();
+  return manager.hasProvider(language);
+};
+
+/**
+ * Get all registered editor providers.
+ *
+ * @returns Array of all registered editor providers
+ */
+export const getAllEditors = (): EditorProvider[] => {
+  const manager = EditorProviders.getInstance();
+  return manager.getAllProviders();
+};
+
+/**
+ * Event fired when an editor is registered.
+ * Subscribe to this event to react when extensions register new editors.
+ */
+export const onDidRegisterEditor = (
+  listener: (e: EditorRegisteredEvent) => void,
+): Disposable => {
+  const manager = EditorProviders.getInstance();
+  return manager.onDidRegister(listener);
+};
+
+/**
+ * Event fired when an editor is unregistered.
+ * Subscribe to this event to react when extensions unregister editors.
+ */
+export const onDidUnregisterEditor = (
+  listener: (e: EditorUnregisteredEvent) => void,
+): Disposable => {
+  const manager = EditorProviders.getInstance();
+  return manager.onDidUnregister(listener);
+};
+
+/**
+ * Hook that returns the editor provider for a specific language and re-renders when it changes.
+ *
+ * @param language The language to get an editor for
+ * @returns The editor provider or undefined if no extension provides one
+ */
+export const useEditor = (
+  language: EditorLanguage,
+): EditorProvider | undefined => {
+  const manager = EditorProviders.getInstance();
+  return useSyncExternalStore(
+    manager.subscribe,
+    () => manager.getProvider(language),
     () => undefined,
   );
-
-export const editors: typeof editorsApi = {
-  registerEditor: provider.registerProvider.bind(provider),
-  getEditor: provider.getProvider.bind(provider),
-  hasEditor: provider.hasProvider.bind(provider),
-  getAllEditors: provider.getAllProviders.bind(provider),
-  onDidRegisterEditor: provider.onDidRegister.bind(provider),
-  onDidUnregisterEditor: provider.onDidUnregister.bind(provider),
 };
+
+/**
+ * Editors API object for use in the extension system.
+ */
+export const editors: typeof editorsApi = {
+  registerEditor,
+  getEditor,
+  hasEditor,
+  getAllEditors,
+  onDidRegisterEditor,
+  onDidUnregisterEditor,
+};
+
+export { EditorProviders };
+
+// Component exports
+export { default as EditorHost } from './EditorHost';
+export type { EditorHostProps } from './EditorHost';
+export { default as AceEditorProvider } from './AceEditorProvider';

superset-frontend/src/core/index.ts

@@ -27,14 +27,11 @@ export const core: typeof coreType = {
 };
 
 export * from './authentication';
-export * from './chat';
 export * from './commands';
-export * from './dashboardComponents';
 export * from './editors';
 export * from './extensions';
 export * from './menus';
 export * from './models';
-export * from './navigation';
 export * from './sqlLab';
 export * from './utils';
 export * from './views';

superset-frontend/src/core/menus/index.ts

@@ -27,7 +27,6 @@
 import { useSyncExternalStore } from 'react';
 import type { menus as menusApi } from '@apache-superset/core';
 import { Disposable } from '../models';
-import { createEventEmitter } from '../utils';
 
 type MenuItem = menusApi.MenuItem;
 type Menu = menusApi.Menu;
@@ -48,19 +47,19 @@ const subscribe = (listener: () => void) => {
   return () => syncListeners.delete(listener);
 };
 
-const registerEmitter = createEventEmitter<MenuItemRegisteredEvent>();
-const unregisterEmitter = createEventEmitter<MenuItemUnregisteredEvent>();
+const registerListeners = new Set<(e: MenuItemRegisteredEvent) => void>();
+const unregisterListeners = new Set<(e: MenuItemUnregisteredEvent) => void>();
 
 const menuCache = new Map<string, Menu | undefined>();
 const notifyRegister = (event: MenuItemRegisteredEvent) => {
   menuCache.clear();
   syncListeners.forEach(l => l());
-  registerEmitter.fire(event);
+  registerListeners.forEach(l => l(event));
 };
 const notifyUnregister = (event: MenuItemUnregisteredEvent) => {
   menuCache.clear();
   syncListeners.forEach(l => l());
-  unregisterEmitter.fire(event);
+  unregisterListeners.forEach(l => l(event));
 };
 
 const registerMenuItem: typeof menusApi.registerMenuItem = (
@@ -118,14 +117,16 @@ export const useMenu = (location: string): Menu | undefined =>
 
 export const onDidRegisterMenuItem: typeof menusApi.onDidRegisterMenuItem = (
   listener: (e: MenuItemRegisteredEvent) => void,
-  thisArgs?: unknown,
-): Disposable => registerEmitter.subscribe(listener, thisArgs);
+): Disposable => {
+  registerListeners.add(listener);
+  return new Disposable(() => registerListeners.delete(listener));
+};
 
 export const onDidUnregisterMenuItem: typeof menusApi.onDidUnregisterMenuItem =
-  (
-    listener: (e: MenuItemUnregisteredEvent) => void,
-    thisArgs?: unknown,
-  ): Disposable => unregisterEmitter.subscribe(listener, thisArgs);
+  (listener: (e: MenuItemUnregisteredEvent) => void): Disposable => {
+    unregisterListeners.add(listener);
+    return new Disposable(() => unregisterListeners.delete(listener));
+  };
 
 export const menus: typeof menusApi = {
   registerMenuItem,

superset-frontend/src/core/navigation/index.test.ts

@@ -1,124 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-// Reset module state between tests so currentPage is re-initialized.
-beforeEach(() => {
-  jest.resetModules();
-  Object.defineProperty(window, 'location', {
-    writable: true,
-    value: { pathname: '/' },
-  });
-});
-
-async function importNavigation() {
-  const mod = await import('./index');
-  return mod;
-}
-
-test('getPage falls back to "home" for the welcome page and unknown pathnames', async () => {
-  const { navigation, notifyLocationChanged } = await importNavigation();
-  // The default pathname ('/') is not enumerated and falls back to home.
-  expect(navigation.getPage()).toBe('home');
-  notifyLocationChanged('/superset/welcome/');
-  expect(navigation.getPage()).toBe('home');
-});
-
-test('getPage derives the page from window.location.pathname', async () => {
-  window.location.pathname = '/superset/dashboard/42/';
-  const { navigation } = await importNavigation();
-  expect(navigation.getPage()).toBe('dashboard');
-});
-
-test('notifyLocationChanged updates the current page type', async () => {
-  const { navigation, notifyLocationChanged } = await importNavigation();
-  notifyLocationChanged('/explore/?form_data={}');
-  expect(navigation.getPage()).toBe('explore');
-});
-
-test('notifyLocationChanged fires listeners on page type change', async () => {
-  const { navigation, notifyLocationChanged } = await importNavigation();
-  const listener = jest.fn();
-  const disposable = navigation.onDidChangePage(listener);
-
-  notifyLocationChanged('/superset/dashboard/1/');
-  expect(listener).toHaveBeenCalledWith('dashboard');
-
-  disposable.dispose();
-});
-
-test('notifyLocationChanged does not fire listeners when page type is unchanged', async () => {
-  window.location.pathname = '/superset/dashboard/1/';
-  const { navigation, notifyLocationChanged } = await importNavigation();
-  const listener = jest.fn();
-  navigation.onDidChangePage(listener);
-
-  notifyLocationChanged('/superset/dashboard/2/');
-  expect(listener).not.toHaveBeenCalled();
-});
-
-test('onDidChangePage listener is removed after dispose', async () => {
-  const { navigation, notifyLocationChanged } = await importNavigation();
-  const listener = jest.fn();
-  const disposable = navigation.onDidChangePage(listener);
-
-  disposable.dispose();
-  notifyLocationChanged('/superset/dashboard/1/');
-  expect(listener).not.toHaveBeenCalled();
-});
-
-test('sqllab path is matched with and without trailing slash', async () => {
-  const { notifyLocationChanged, navigation } = await importNavigation();
-  notifyLocationChanged('/sqllab');
-  expect(navigation.getPage()).toBe('sqllab');
-  notifyLocationChanged('/explore/');
-  notifyLocationChanged('/sqllab/');
-  expect(navigation.getPage()).toBe('sqllab');
-});
-
-test('chart and dashboard list pages get their own page types', async () => {
-  const { notifyLocationChanged, navigation } = await importNavigation();
-  notifyLocationChanged('/chart/list/');
-  expect(navigation.getPage()).toBe('chart_list');
-  notifyLocationChanged('/dashboard/list/');
-  expect(navigation.getPage()).toBe('dashboard_list');
-});
-
-test('dataset list and single-dataset pages get distinct page types', async () => {
-  const { notifyLocationChanged, navigation } = await importNavigation();
-  notifyLocationChanged('/tablemodelview/list/');
-  expect(navigation.getPage()).toBe('dataset_list');
-  notifyLocationChanged('/dataset/42');
-  expect(navigation.getPage()).toBe('dataset');
-});
-
-test('sqllab editor, query history, and saved queries get distinct page types', async () => {
-  const { notifyLocationChanged, navigation } = await importNavigation();
-  notifyLocationChanged('/sqllab/');
-  expect(navigation.getPage()).toBe('sqllab');
-  notifyLocationChanged('/sqllab/history/');
-  expect(navigation.getPage()).toBe('query_history');
-  notifyLocationChanged('/savedqueryview/list/');
-  expect(navigation.getPage()).toBe('saved_queries');
-});
-
-test('chart/add resolves to explore, not chart_list', async () => {
-  const { notifyLocationChanged, navigation } = await importNavigation();
-  notifyLocationChanged('/chart/add');
-  expect(navigation.getPage()).toBe('explore');
-});

superset-frontend/src/core/navigation/index.ts

@@ -1,94 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * @fileoverview Host-internal implementation of the `navigation` namespace.
- *
- * Derives the current {@link Page} from the browser location by matching
- * against {@link RoutePaths}. Call {@link useNavigationTracker} once in the
- * app shell to keep the page in sync with React Router.
- */
-
-import { useEffect, useRef } from 'react';
-import { useLocation, matchPath } from 'react-router-dom';
-import type { navigation as navigationApi } from '@apache-superset/core';
-import { RoutePaths } from '../../views/routePaths';
-import { Disposable } from '../models';
-import { createValueEventEmitter } from '../utils';
-
-type Page = navigationApi.Page;
-
-/** Maps route path patterns to their corresponding Page type. */
-const PAGE_ROUTES: { path: string; page: Page }[] = [
-  { path: RoutePaths.DASHBOARD, page: 'dashboard' },
-  { path: RoutePaths.DASHBOARD_LIST, page: 'dashboard_list' },
-  { path: RoutePaths.QUERY_HISTORY, page: 'query_history' },
-  { path: RoutePaths.SAVED_QUERIES, page: 'saved_queries' },
-  { path: RoutePaths.SQLLAB, page: 'sqllab' },
-  { path: RoutePaths.CHART_ADD, page: 'explore' },
-  { path: RoutePaths.CHART_LIST, page: 'chart_list' },
-  { path: RoutePaths.EXPLORE, page: 'explore' },
-  { path: RoutePaths.EXPLORE_PERMALINK, page: 'explore' },
-  { path: RoutePaths.DATASET_LIST, page: 'dataset_list' },
-  { path: RoutePaths.DATASET_ADD, page: 'dataset' },
-  { path: RoutePaths.DATASET, page: 'dataset' },
-];
-
-function derivePage(pathname: string): Page {
-  for (const { path, page } of PAGE_ROUTES) {
-    if (matchPath(pathname, { path, exact: false })) return page;
-  }
-  return 'home';
-}
-
-const pageEmitter = createValueEventEmitter<Page>(
-  derivePage(window.location.pathname),
-);
-
-/** Updates the current page from a pathname. No-op when the page is unchanged. */
-export const notifyLocationChanged = (pathname: string): void => {
-  const next = derivePage(pathname);
-  if (next === pageEmitter.getCurrent()) return;
-  pageEmitter.fire(next);
-};
-
-const getPage: typeof navigationApi.getPage = () => pageEmitter.getCurrent();
-
-const onDidChangePage: typeof navigationApi.onDidChangePage = (
-  listener: (page: Page) => void,
-  thisArgs?: unknown,
-): Disposable => pageEmitter.subscribe(listener, thisArgs);
-
-/** Synchronizes the navigation module with React Router. Call once in the app shell. */
-export const useNavigationTracker = () => {
-  const location = useLocation();
-  const prevPathname = useRef<string | null>(null);
-
-  useEffect(() => {
-    if (prevPathname.current !== location.pathname) {
-      prevPathname.current = location.pathname;
-      notifyLocationChanged(location.pathname);
-    }
-  }, [location.pathname]);
-};
-
-export const navigation: typeof navigationApi = {
-  getPage,
-  onDidChangePage,
-};

superset-frontend/src/core/sqlLab/index.ts

@@ -48,7 +48,7 @@ import { AnyListenerPredicate } from '@reduxjs/toolkit';
 import type { QueryEditor, SqlLabRootState } from 'src/SqlLab/types';
 import { newQueryTabName } from 'src/SqlLab/utils/newQueryTabName';
 import { Database, Disposable } from '../models';
-import { createActionListener } from '../storeUtils';
+import { createActionListener } from '../utils';
 import {
   Panel,
   Tab,