Compare commits

...

101 Commits

Author SHA1 Message Date
Claude Code
f866f25546 Merge branch 'remove-legacy-viz-pipeline' into misc-charts-examples
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-24 02:59:41 -07:00
Claude Code
3392576923 chore(explore): drop comments pointing at the long-gone nvd3_vis.css
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-24 02:59:10 -07:00
Claude Code
e95b37450e chore(viz)!: delete the unregistered preset-chart-nvd3 package
Nothing has registered this package since the Bullet and Time-series
Period Pivot charts moved to ECharts; remove the workspace, its
tsconfig reference, the custom-rules grandfather entry, and its
lockfile entries (which also sweeps the nvd3-only fast-safe-stringify
dependency). The nvd3-fork library itself remains a dependency of
plugin-chart-rose, whose legend and tooltip still use it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-24 02:57:52 -07:00
Claude Code
ff73f2c070 Merge branch 'remove-legacy-viz-pipeline' into misc-charts-examples
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-24 00:21:13 -07:00
Claude Code
612fd0ac5d Merge branch 'master' into remove-legacy-viz-pipeline
Master's #41996 relocated legacy filter sanitization out of viz.py and
utils/core.py into the legacy explore path this branch removes; the
remaining utils signature change merges cleanly, viz.py stays deleted,
and the new test file importing superset.viz is removed with it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-24 00:20:12 -07:00
Claude Code
83dbdfa355 Merge remote-tracking branch 'origin/misc-charts-examples'
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 22:38:53 -07:00
Claude Code
fc3872fe9e Merge branch 'remove-legacy-viz-pipeline' into misc-charts-examples
Brings in the rose dark-theme text fix and the master sync.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 22:38:04 -07:00
Claude Code
0946df50a1 chore(viz): recapture all gallery thumbnails on dashboard-context backgrounds
Every thumbnail regenerated from the tuned example charts on the
white/dark card background users actually see, including the restored
generic handlebars logo and a predictive-forecast generic time-series
thumbnail.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 22:37:48 -07:00
Claude Code
d9c3a2cf4c feat(examples): purpose-built thumbnail charts for the viz gallery
Nineteen additional Misc Charts examples modeling each chart type at
its most recognizable: simpler chord, YoY big number, triangular
funnel, multi-range gauge, compact heatmap grid, bell-curve histogram,
dual-axis bar+line mixed chart, labeled donut, video-game-sales radar,
sunburst with total, stacked area and bars, low-series marker lines
(straight, smooth, stepped), high-cardinality treemap, quarterly
waterfall, multi-metric table and a cell-highlighted pivot. Also tunes
existing examples: monthly-grain period pivot, sales-based time table,
tighter parallel coordinates, recentered point cluster map, and
deck.gl hexagon/scatter viewports pinned (autozoom off) for the
downtown 3D view.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 22:37:46 -07:00
Claude Code
f84d7c664e feat(playwright): dashboard-context backgrounds, hover captures, curated slice picks
Captures now paint the dashboard card background (white or dark) over
explore's gray layout background, hover a populated cell before the
still for charts whose identity benefits from a visible tooltip
(calendar heatmap), and prefer the purpose-built thumbnail examples for
every tuned viz type. Handlebars is intentionally unmapped so its
generic logo survives.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 22:37:38 -07:00
Claude Code
45fd4117a9 fix(rose): use the theme text color for chart and legend text
The nvd3-fork legend and axis labels render SVG text with the default
black fill, which is unreadable against a dark theme background.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 22:36:32 -07:00
Jean Massucatto
4ee500e47b fix(explore): render Jinja before validating legacy chart filters (#41996) 2026-07-23 22:05:14 -07:00
Evan Rusackas
79acc3a712 Merge branch 'remove-legacy-viz-pipeline' into misc-charts-examples 2026-07-23 21:09:22 -07:00
Ujjwal Jain
3ff5dbfe81 fix(native-filters): use FILTER_STATE_CACHE_CONFIG timeout for dynamic filter option queries (#38910) 2026-07-23 21:01:54 -07:00
dependabot[bot]
cfb04a6e79 chore(deps-dev): bump databricks-sql-connector from 4.2.6 to 4.3.0 (#42347)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joe Li <joe@preset.io>
Co-authored-by: Evan Rusackas <evan@preset.io>
2026-07-23 20:57:58 -07:00
Claude Code
62d0cfb6d3 Merge branch 'master' into remove-legacy-viz-pipeline
Resolves StatefulChart/chartAction conflicts by keeping master's async
(202) handling and staleness guards with the legacy explore_json paths
stripped: the endpoint is always /api/v1/chart/data, the async handler
loses its useLegacyApi parameter, and the legacy body-wrapping branch
and its test are removed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 19:45:23 -07:00
dependabot[bot]
49f4e84b48 chore(deps): bump flask-compress from 1.17 to 1.24 (#42346)
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joe Li <joe@preset.io>
2026-07-23 19:21:29 -07:00
dependabot[bot]
921f75d544 chore(deps): bump pillow from 12.2.0 to 12.3.0 (#42348)
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joe Li <joe@preset.io>
2026-07-23 19:21:17 -07:00
Ramachandran A G
bcf0361a91 feat(KustoKQL): Add support for NULL / IS NOT NULL operator (#37890)
Co-authored-by: ag-ramachandran <ramacg@microsoft.com>
Co-authored-by: Joe Li <joe@preset.io>
2026-07-23 18:28:37 -07:00
jenwitteng
5776aff50a fix(charts): handle async (202) chart-data responses in StatefulChart (#42157)
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
2026-07-23 18:01:05 -07:00
Hans Yu
14c96761e5 chore: SQLAlchemy User cascade backref warnings are irrelevant (#42360) 2026-07-23 17:16:38 -07:00
Abdul Rehman
d41f0febae fix(api): add example to get_export_ids_schema so Swagger "Try it out" pre-fills a valid array (#42265) 2026-07-23 17:15:24 -07:00
jesperct
c43effa4a3 fix(explore): show the beginning date on time-series x-axis line charts (#42046) 2026-07-23 17:14:30 -07:00
Evan Rusackas
b885657ad0 Merge branch 'master' into remove-legacy-viz-pipeline 2026-07-23 16:40:39 -07:00
Claude Code
a191f72698 fix(playwright): treat AG Grid and period-over-period KPI as markup-only captures
Both render without svg/canvas/table, so the crawler needs the looser
rendered signal when capturing them from a flag-enabled environment.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 16:35:04 -07:00
Claude Code
498400e974 chore(viz): delete dead thumbnailLarge images and capture art for newly exemplified types
Removes 30 thumbnailLarge.png files no plugin imports, and captures
live thumbnails (light and dark) for the generic/smooth/step time
series, handlebars, deck.gl contour and heatmap, and point cluster map
from their new example charts.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 16:35:03 -07:00
Claude Code
b9a8321802 feat(examples): example charts for every remaining unexemplified viz type
Adds Misc Charts examples for the generic, smooth and stepped
time-series lines, handlebars, deck.gl contour and heatmap layers, and
the point cluster map (on the keyless maplibre renderer). Flag-gated
types (pop_kpi behind ChartPluginsExperimental, ag-grid-table behind
AgGridTableEnabled) are deliberately excluded: their plugins are
unregistered on default deployments, where their charts would render as
errors.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 16:34:49 -07:00
Claude Code
902ebcdf72 chore(viz): refresh viz-picker gallery art from live example charts
Regenerates thumbnails (light and dark) for every viz type on the
example dashboards via the thumbnail crawler, replaces the obsolete
nvd3-era Bullet/TimePivot/TimeTable example gallery screenshots, and
adds a percent-change example (Line3) to the Line chart gallery.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 15:06:25 -07:00
Claude Code
f76471f30f fix(playwright): harden the thumbnail crawler against hangs and text-only charts
Adds an explicit navigation timeout so one hung load cannot stall the
crawl until the test timeout, raises the overall budget to 90 minutes,
and gives markup-only charts (big_number_total, handlebars) a looser
rendered signal since they produce no svg/canvas/table for the default
selector to match.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 15:06:12 -07:00
Claude Code
b671356748 fix(chart): guard the percent-change baseline against an unapplied chart option
On warm explore navigations getOption() can be undefined or empty when
the baseline effect first runs, crashing the chart render with 'Cannot
read properties of undefined (reading series)'. Guard the read and retry
installation once the chart finishes rendering.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 15:05:32 -07:00
Claude Code
ff273478ff docs(playwright): update thumbnail crawler header for dark-variant capture
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 10:29:30 -07:00
Claude Code
f1cc9367de feat(playwright): capture dark variants and obsolete gallery examples in the thumbnail crawler
Every capture now also renders a dark version via prefers-color-scheme
emulation when the plugin ships a -dark sibling (or the image is new),
skipping the write when the app ignores the emulation so real dark art
is never clobbered with light captures. The Bullet, TimePivot and
TimeTable example.jpg gallery images — still screenshots of the removed
nvd3 renderers — are refreshed as wide extra captures.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 10:28:55 -07:00
Claude Code
02e4b4be7d feat(playwright): turn the thumbnail capture tool into a dashboard crawler
Instead of enumerating charts, the tool discovers every chart on every
dashboard via the API and captures one representative per viz type, so
it keeps working as example dashboards evolve. The only static piece is
the viz-type-to-image-path map (one line per plugin); unmapped viz types
are reported without failing. Supports VIZ_TYPES=a,b filtering, a
preferred-slice override per type, and named extra captures for gallery
images like the Line percent-change example.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 10:19:48 -07:00
Claude Code
ecb4aa93f6 feat(playwright): add a viz-picker thumbnail capture tool
A CAPTURE_THUMBNAILS-gated Playwright spec that renders each migrated
legacy chart's example standalone at 512x512 and overwrites the plugin's
gallery thumbnail, plus an npm run playwright:thumbnails entry point.
Covers the Misc Charts examples and the existing chord, horizon,
parallel coordinates, country map and world map examples; the Line
percent-change capture lands as a new gallery image to be registered in
the plugin metadata after capture.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-22 22:53:57 -07:00
Claude Code
4e1913d436 feat(examples): add migrated legacy chart examples to the Misc Charts dashboard
Adds example charts for every migrated legacy visualization that had no
example instance: calendar heatmap, nightingale rose, partition, paired
t-test, bullet, time-series period pivot, a percent-change line, and a
time table. Country map, parallel coordinates, chord, horizon and world
map already have examples in other dashboards.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-22 22:51:56 -07:00
Claude Code
b6ae8fb25d test(timeseries): cover the percent-change flag end-to-end from migrated params
Adds transformProps-level coverage for rebase_percent_change: series
rebased from the first point with a forced percent axis format, and the
snake_case key the compare-chart migration stores read through real
ChartProps camelization. Also guards the rebase against form data with
no explicit x-axis by falling back to the temporal alias, matching
extractSeries.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-22 19:11:42 -07:00
Claude Code
10f2461b5f fix(bullet): range labels inside their bands, always-on tooltip, legend-aware grid
Range labels move from mid-bar scatter points onto the markArea bands
(insideTopRight), so each label sits inside the range it names and the
rightmost label no longer clips at the chart edge. The tooltip stays
enabled regardless of the Show labels/legend toggles and the measure bar
tooltip names the range the value falls within. The grid top now
estimates wrapped legend rows from item text widths instead of assuming
a single row.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-22 18:56:12 -07:00
Claude Code
4e715f66dc chore(migrations): re-id compare-chart migration and re-point bubble migration after rebase
Master's add_extension_storage_table migration landed with revision id
e5f6a7b8c9d0, colliding with the compare-chart migration's id; re-id it
to 88360afb61ed and chain the bubble migration off master's head.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-22 17:52:46 -07:00
Claude Code
6dfae09cc5 chore: drop unused feature_flag_manager import after rebase
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-22 17:50:45 -07:00
Claude Code
a4f74b09bb docs(embedded): document the iframe session cookie race in the pivot spec
Also retriggers CI so the merge ref picks up the master fix from #42274
(an empty commit does not trigger the path-gated workflows).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-22 17:50:44 -07:00
Claude Code
9f39fe3e10 test(embedded): store a query_context on the pivot collapse fixture chart
The spec's fixture chart was created with params only. Real charts saved
through Explore always persist a query_context, and guest (embedded)
chart data requests are validated against the stored chart: with no
stored query_context and no columns/groupby params keys, the pivot
payload's query columns read as tampering and every request 403s.

The suite previously passed only when the embedded iframe happened to
ride the admin session from storageState instead of the guest token (a
cookie race between the /embedded response's anonymous session and the
SDK's csrf/guest-token fetches), which masked the 403 on master.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-22 17:50:44 -07:00
Claude Code
c6f8706aa1 test(charts): update warm-up cache assertions for the actionable message
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:44 -07:00
Claude Code
07a6406d97 style: prettier formatting for UPDATING.md and SavedQueries test
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:44 -07:00
Claude Code
a585a0901e fix(time-table): escape backslashes in flattened labels; actionable null-query-context errors
Escaping only commas let group tuples like (a\\, b) and (a-comma, b)
flatten to identical column keys; backslashes are now escaped first, with
a regression test pinning the collision pair. The cache warm-up error for
charts whose query context has not been generated yet tells the operator
how to resolve it, and UPDATING.md documents the one-time lazy generation
for charts migrated in place.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:44 -07:00
Evan Rusackas
fff5351a33 feat(bullet): rebuild the Bullet Chart on ECharts (#42225)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:44 -07:00
Evan Rusackas
b4f8d87a49 feat(time-pivot): rebuild Time-series Period Pivot on ECharts (#42245)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:44 -07:00
Evan Rusackas
3256ee4fbb feat(timeseries): percent-change rebasing with a draggable baseline (#42247)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:44 -07:00
Evan
e5b3ba9efc fix: cast Arc test color accessors through unknown for tsc
lint-frontend's tsc build failed with TS2352 on the direct Accessor ->
ColorAccessor cast; go through unknown first as the compiler suggests.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-22 17:50:43 -07:00
Evan
ae93dc2041 fix: repair type errors from removed useLegacyApi metadata field
Three plugin tests still asserted on ChartMetadata.useLegacyApi, which
this PR drops entirely, and the Arc layer test called deck.gl color
accessors without narrowing their Accessor union type. Both broke
lint-frontend's tsc check.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-22 17:50:43 -07:00
Claude Code
792d0fd2b6 fix(deck-arc): default missing layer colors instead of crashing
The Arc layer read color_picker/target_color_picker straight off form data
and dereferenced .r/.g/.b, so a saved chart without those controls crashed
the ArcLayer on init ("Cannot read properties of undefined (reading 'r')").
This surfaced in deck.gl Multiple Layers, where sub-slices arrive as raw
saved form data without control-default hydration and the Arc example never
persisted target_color_picker. Fall back to the control-panel default color
(PRIMARY_COLOR) when a picker is absent, matching how Path and Scatter
already guard, and harden Polygon's fill/stroke pickers the same way. Adds
Arc color-accessor tests for the missing and present cases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:43 -07:00
Claude Code
8dcb83fd3c feat(deck-multi): surface layer load failures in the chart
When a deck.gl Multiple Layers sub-layer fails to load (e.g. it is bound to
a dataset that lacks the columns it needs), the error previously only threw
to the browser console, leaving the map looking silently empty. Capture the
per-slice failure and render a warning Alert over the map, normalized via
getClientErrorObject so the server message (e.g. "Columns missing in
dataset") is shown. Errors reset on each reload.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:43 -07:00
Claude Code
8f07ab4840 test(plugins): cover the migrated calendar/chord/country-map registration
Codecov flagged the calendar transformProps and the calendar/chord/
country-map plugin index modules as uncovered. Add plugin-registration
tests (instantiate the plugin, assert v1 metadata and the buildQuery
loader), a calendar transformProps test (v1 reshape plus display-option
passthrough, and the non-array passthrough branch), and a calendar
buildQuery case for an unrecognized subdomain granularity falling back to
minutes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:43 -07:00
Claude Code
89d64b89b8 fix(deck-multi): query layers against their real datasource, not stale params
Each deck.gl Multiple Layers sub-layer is an independent saved chart with
its own dataset, and its layer query must hit that dataset. fetchSubslices
rebuilt the layer form_data from the saved params, whose `datasource`
string can be stale -- example charts hardcode a datasource id that does
not match the imported dataset's real id. The layer query then went to the
wrong dataset and the server rejected it with 400 "Columns missing in
dataset" (e.g. LON/LAT), so no layer rendered. Standalone the chart works
because it resolves its datasource from the slice relationship, not params.

Use the chart's authoritative datasource_id/datasource_type from the chart
API to build the layer datasource, falling back to params only when absent.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:43 -07:00
Claude Code
4ce589dcda fix(deck-multi): correct the points-collection typing to unblock tsc
The GET_POINTS_BY_VIZ_TYPE map annotated its values as
(features: JsonObject[]) => [number, number][], but the per-layer
getPoints helpers have looser, inconsistent signatures (getPointsGeojson
takes Point[]), so the map failed tsc. Replace it with an explicit-spread
collectPoints(features) mirroring the original getAdjustedViewport, which
type-checks and works for both the payload and the per-layer accumulator.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:43 -07:00
Claude Code
a31210df08 fix(deck-multi): autozoom to layer data in the v1 fetch path
deck.gl Multiple Layers computed its viewport once, from
props.payload.data.features, and never again. In the v1 path that payload
is empty (each layer is fetched client-side after mount), so autozoom had
no points to fit and the camera stayed at the default location while the
layers rendered off-screen -- the map showed but appeared to have no data.

Accumulate each layer's features as it is fetched and refit the viewport
to the combined points (when autozoom is enabled), mirroring what the
legacy pre-merged payload allowed. Also factor the per-viz_type point
collection into a shared helper. Adds a v1-path test covering both layer
rendering and the viewport refit, which the existing suite (all legacy
payload.data.slices) did not exercise.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:43 -07:00
Claude Code
00e95dcb87 chore(paired-t-test): drop the unused prop-types dependency
Nothing in the plugin imports prop-types since the class components were
migrated to function components. Remove it and its lockfile reference.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:42 -07:00
Claude Code
c9960002f1 fix(paired-t-test): bound the scroll container to the chart height
The container relied on height: 100%, which does not resolve because the
chart's parent is not height-bounded in the v1 render path, so tall output
(many groups across multiple metrics) still clipped without scrolling.
Thread the explicit height SuperChart passes via chartProps through
transformProps and apply it to the scroll container, matching the pattern
used by the pivot-table chart.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:42 -07:00
Claude Code
dbac244857 refactor(paired-t-test): use the antd Table and drop the reactable dependency
Replace the interim plain-table rendering with the design-system antd Table
from @superset-ui/core/components: native column sorting via the ported
comparators, per-cell lift/p-value/significance coloring through semantic
theme tokens (no bespoke CSS classes), and row-click control selection via
onRow. Removes the reactable dependency entirely (its fragile, React-18-
incompatible rendering was the production bug) and the leftover reactable-*
styling. Also drops the now-stale distributions/cephes lockfile entries.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:42 -07:00
Claude Code
4483cb09f0 fix(paired-t-test): scroll the chart when tables overflow its height
The container styled the non-existent .scrollbar-container class, so the
chart never scrolled and tall output (many groups across multiple metrics)
was clipped with no way to reach the rest. Make the chart root fill its
allotted height and scroll on overflow.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:42 -07:00
Claude Code
28d977bc0c fix(paired-t-test): render the table without the reactable dependency
The migrated chart returned correct data (verified end-to-end) yet showed
table headers with no body rows in production builds, while every jest
path rendered rows. The common factor was reactable, an unmaintained 2016
library that relies on React-18-incompatible legacy lifecycles
(componentWillMount/componentWillReceiveProps) and identifies its row
children by stringifying components -- fragile in a production bundle.

Replace it with a plain semantic table that reproduces every behavior
(control-row selection, per-cell lift/p-value/significance coloring, and
the same column sort comparators), reusing the existing CSS class hooks so
the surrounding styles are unchanged. Rendering is now deterministic and
fully unit-testable.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:42 -07:00
Evan
b248c4d7c0 fix(tests): drop removed useLegacyApi prop from ChartRenderer test metadata
The legacy-pipeline removal deleted useLegacyApi from ChartMetadataConfig;
the enableNoResults test still passed it, breaking tsc in lint-frontend.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-22 17:50:42 -07:00
Claude Code
3e9fdc4cdf test(paired-t-test): prove the v1 pipeline renders table rows end-to-end
Guards the "headers render but no body rows" failure mode by driving the
real transformProps -> PairedTTest pipeline with a realistic flat
/api/v1/chart/data timeseries response (main.birth_names shape): asserts
transformProps keys the reshaped data by metric label with one series per
group tuple, and that the rendered tables contain a body row per group,
including when optional precision/significance controls are absent.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:42 -07:00
Claude Code
387b742303 fix(explore): honor chart enableNoResults metadata in ChartRenderer
ChartRenderer computed the SuperChart enableNoResults prop purely from
server-pagination + AG Grid filter state (bypassNoResult) and never read
the chart plugin's own enableNoResults metadata. Charts that fetch their
own data and issue no top-level query, like deck.gl Multiple Layers, set
enableNoResults: false but still hit the "No results were returned for
this query" empty state in explore, which pre-empts their self-fetching
renderer from ever mounting.

AND the chart's enableNoResults metadata (defaulting to true) into
bypassNoResult so deck_multi and similar self-fetching charts render.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:41 -07:00
Evan Rusackas
533f90e4c6 test(plugins): regression guards from the migration bug sweep
Adds low-risk import-and-assert tests across migrated plugins, guarding the
classes of bugs found while testing this branch:
- is_timeseries charts must expose a datetime control (calendar, horizon, rose,
  partition). Partition genuinely lacked one, so add sections.legacyTimeseriesTime
  to its control panel (same 500 as paired-t-test otherwise).
- deck.gl Multiple Layers must issue an empty query (self-fetches its layers).
- deck.gl Arc is timeseries only when time_grain_sqla is set.
- Time Pivot's numeric x-axis format must render a number, not the literal
  SMART_NUMBER string.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:41 -07:00
Evan Rusackas
b887c30573 test(paired-t-test): mock the statistics module instead of removed distributions
Removing the distributions dependency left TTestTable.test.tsx mocking a module
the component no longer imports, so the p-value/significance tests failed. Mock
./statistics.studentTwoSidedPValue to a deterministic 0.02 instead.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:41 -07:00
Evan Rusackas
2cd369d02a fix(nvd3,controls): time-pivot x-axis number format + single-line async multiselect
- Time Pivot's x-axis is a numeric offset within the period (its x_axis_format
  defaults to SMART_NUMBER), but NVD3Vis ran it through getTimeFormatter, which
  made d3 print the literal string "SMART_NUMBER" on every tick. Format it as a
  number instead. (Pre-existing bug, bycatch.)
- SelectAsyncControl never forwarded the Select 'oneLine' prop, so many selected
  tags wrapped outside the control's fixed-height box (visible on deck.gl
  Multiple Layers). Pass oneLine for multi mode so tags collapse to a '+N' tag.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:41 -07:00
Evan Rusackas
4b3bbe19f6 fix(paired-t-test): compute p-values without the Node-only distributions dep
The chart imported 'distributions' to compute the Student's t p-value, but that
package references Node's Buffer global, which is only polyfilled in dev builds
-- so the chart rendered in dev and threw "ReferenceError: Buffer is not
defined" in production. Replace it with a self-contained, browser-safe
two-sided p-value via the regularized incomplete beta function, verified
against standard t-table critical values, and drop the dependency.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:41 -07:00
Evan Rusackas
28eae5956e fix(deck-multi): render the map instead of the no-results empty state
deck.gl Multiple Layers issues no query of its own -- each layer is a saved
chart that fetches its data client-side, so buildQuery is intentionally empty.
Dropping useLegacyApi exposed the default enableNoResults=true, so the empty
query response now shows "No results were returned for this query" and the map
never renders. Set enableNoResults: false, matching the other self-fetching
charts (Select filter, DeckglLayerVisibility).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:41 -07:00
Evan Rusackas
239e3a4323 fix(paired-t-test): restore the datetime column control
The paired t-test chart's buildQuery sends is_timeseries, so the backend
requires a datetime column, but its migrated control panel has no time
section. Creating the chart fails with "Datetime column not provided as part
table configuration and is required by this type of chart" with no way to
supply one. Add the shared legacyTimeseriesTime section, matching its sibling
timeseries charts (rose, horizon), so a granularity column can be selected.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 17:50:41 -07:00
Evan
573054346f fix: rebase bubble-chart migration onto master's current alembic head
master added strip_metricsqlexpressions_from_ag_grid_params (d24e6b0a9c7f)
on top of shadow_live_row_indexes (8f3a1b2c4d5e) after this branch's
bubble-chart migration was last pointed at 8f3a1b2c4d5e, producing two
alembic heads and failing `db upgrade` across every integration/E2E job.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-22 17:50:41 -07:00
Evan
a42c7e3be0 fix: resolve oxlint unused-var/param errors and remove orphaned legacy test
Drops the dead `method` param from getChartDataRequest (the legacy
GET/POST branching it supported no longer exists now that chart data
always POSTs to /api/v1/chart/data), removes bubble-only NVD3Vis props
(entity/maxBubbleSize/xField/yField/sizeField) and the unused module-level
`formatter` left over from the bubble->bubble_v2 migration, and deletes
plugins/legacy-preset-chart-nvd3/test/TimePivot/controlPanel.test.ts, an
orphaned test for a src/ directory that no longer exists after the
rename to preset-chart-nvd3 (superseded by
plugins/preset-chart-nvd3/test/TimePivot.test.ts).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-22 17:50:40 -07:00
Evan
935b4acdbd fix: point bubble-chart migration at master's actual alembic head
down_revision on d4e5f6a7b8c9 pointed at b1c2d3e4f5a6
(add_subjects_tables), which already has a child on master
(56cd24c07170 -> 8f3a1b2c4d5e). That left two alembic heads and
broke `superset db upgrade` in every DB-backed CI job. Chain the
migration after 8f3a1b2c4d5e, master's real current head, instead.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-22 17:50:40 -07:00
Evan
bba2d5f812 fix: resolve alembic multiple-heads conflict in migration chain
down_revision on d4e5f6a7b8c9 still pointed at 3a8e6f2c1b95, which
master's add_subjects_tables migration (b1c2d3e4f5a6) also forked
from, leaving two alembic heads and breaking `superset db upgrade`
in every DB-backed CI job.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-22 17:50:40 -07:00
Evan
7d45b8ae7e fix: format Multi.tsx and update Multi.color.test.tsx for registry-based layer loading
Multi.tsx now resolves sublayer buildQuery/transformProps via the chart
plugin registries instead of the removed legacy explore.ts helper; update
the color test's mocks to register deck_scatter/deck_arc stubs and mock
SupersetClient.post (matching the new fetch call) instead of .get.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-22 17:50:40 -07:00
Evan
5942d570c3 fix: repair stale package-lock.json and alembic migration branch
- Remove dangling package-lock.json link entries for the removed
  legacy-* plugin workspaces and regenerate entries for their
  renamed plugin-chart-* counterparts; npm ci was failing with
  EUSAGE because the lockfile referenced workspace paths that no
  longer exist on disk.
- Re-parent the bubble-chart-to-echarts migration
  (d4e5f6a7b8c9) onto the current single migration head
  (3a8e6f2c1b95) instead of a now-superseded ancestor, resolving
  the "Multiple head revisions" alembic error that was failing
  test-sqlite/test-postgres/test-mysql/cypress/playwright.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-22 17:50:40 -07:00
Evan
45adb8429d fix: restore OAuth2RedirectError import after rebase
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-22 17:50:39 -07:00
Claude Code
3a03f0a820 docs: add UPDATING.md entries for the legacy viz pipeline removal and drop the working trackers
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-22 17:50:39 -07:00
Evan Rusackas
105f6d0bc7 chore(viz)!: remove explore_json endpoints, viz.py and the legacy chart data pipeline (#41750)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:39 -07:00
Evan Rusackas
c8d6faf7e8 chore(viz): drop the legacy- prefix from migrated chart plugin packages (#41751)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:35 -07:00
Claude Code
ae15dd883d chore(viz): update SCOPE tracker — all charts migrated, phases 2-3 in review
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-22 17:50:34 -07:00
Evan Rusackas
2afa775db5 feat(compare): migrate compare charts to echarts_timeseries_line and drop the legacy plugin (#41738)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:34 -07:00
Evan Rusackas
e17d49bec0 feat(deck-multi): migrate deck_multi chart to the v1 chart data API (#41730)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:34 -07:00
Evan Rusackas
68324050cd feat(bubble): migrate saved bubble charts to bubble_v2 and drop the legacy plugin (#41728)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:34 -07:00
Evan Rusackas
2a55ad77f4 fix(legacy-viz): restore line-engine default ordering for horizon and rose (#41732)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:34 -07:00
Evan Rusackas
cd535f89e2 feat(partition): migrate partition chart to v1 chart data API (#41729)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:34 -07:00
Claude Code
8b2c07f5f3 chore(viz): update SCOPE tracker after tier 2 completion
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-22 17:50:34 -07:00
Evan Rusackas
a9045296d9 feat(time-pivot): migrate time_pivot chart to v1 chart data API (#41727)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:34 -07:00
Evan Rusackas
32cbc4a7a6 feat(rose): migrate rose chart to v1 chart data API (#41726)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:33 -07:00
Evan Rusackas
4f47eda5de feat(horizon): migrate horizon chart to v1 chart data API (#41725)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:33 -07:00
Claude Code
ba2b0d6ea3 chore(viz): update SCOPE tracker after tier 1-2 merges
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-22 17:50:33 -07:00
Evan Rusackas
df176cfa57 feat(time-table): migrate time_table chart to v1 chart data API (#41723)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:33 -07:00
Evan Rusackas
66e911eeea feat(world-map): migrate world_map chart to v1 chart data API (#41720)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:33 -07:00
Evan Rusackas
759457264d feat(calendar): migrate cal_heatmap chart to v1 chart data API (#41724)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:33 -07:00
Evan Rusackas
5722b96280 feat(paired-t-test): migrate paired_ttest chart to v1 chart data API (#41721)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:33 -07:00
Evan Rusackas
deb6cacea7 feat(chord): migrate chord chart to v1 chart data API (#41719)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:33 -07:00
Claude Code
0f8e2a274d chore(viz): update SCOPE tracker after phase 0 + tier 1 merges
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-22 17:50:33 -07:00
Evan Rusackas
7e0de356d4 feat(bullet): migrate bullet chart to v1 chart data API (#41718)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:33 -07:00
Evan Rusackas
4e93b58a61 feat(parallel-coordinates): migrate para chart to v1 chart data API (#41716)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:32 -07:00
Evan Rusackas
45b232cba0 feat(country-map): migrate country_map chart to v1 chart data API (#41717)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:32 -07:00
Evan Rusackas
bcc58d27f8 chore(viz): phase 0 — remove orphaned viz.py classes and nvd3 BoxPlot leftovers (#41715)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-07-22 17:50:32 -07:00
Claude Code
b5df673d21 chore(viz): add SCOPE/UPDATES trackers for legacy viz pipeline removal
Working documents for the remove-legacy-viz-pipeline feature branch;
stripped before final merge.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-22 17:50:32 -07:00
780 changed files with 14857 additions and 15147 deletions

2
.github/CODEOWNERS vendored
View File

@@ -34,7 +34,7 @@
**/*.geojson @villebro @rusackas
**/*.ipynb @villebro @rusackas
/superset-frontend/plugins/legacy-plugin-chart-country-map/ @villebro @rusackas
/superset-frontend/plugins/plugin-chart-country-map/ @villebro @rusackas
# Notify translation maintainers of changes to translations

1
.gitignore vendored
View File

@@ -137,6 +137,7 @@ PROJECT.md
.aider*
.claude_rc*
.claude/settings.local.json
.claude/worktrees/
.env.local
oxc-custom-build/
*.code-workspace

View File

@@ -193,6 +193,10 @@ are the intended model going forward; deprecating and removing implicit viewersh
in a later major version.
- [41044](https://github.com/apache/superset/issues/41044): Removes the deprecated `AVOID_COLORS_COLLISION` feature flag (it defaulted to `True`). Color-collision avoidance is now permanently enabled; any config override setting it to `False` is ignored.
- [41714](https://github.com/apache/superset/pull/41714): **Breaking — the legacy `explore_json` chart-data pipeline is removed** at its long-declared `5.0.0` EOL. The `/superset/explore_json/` and `/superset/explore_json/data/<cache_key>` endpoints, `superset/viz.py`, the `Slice.viz` property, the `get_viz` factory, the `load_explore_json_into_cache` celery task and the `viz=` overload of `security_manager.raise_for_access` are gone. Anything importing `superset.viz` must migrate to the QueryContext / `pandas_postprocessing` pipeline behind `/api/v1/chart/data`. All 15 remaining legacy charts were migrated first: most keep their `viz_type` and renderer (no action needed for saved charts), while saved nvd3 Bubble charts are auto-migrated to the ECharts Bubble Chart (`bubble_v2`) and saved "Time-series Percent Change" (`compare`) charts to the ECharts Line Chart — the nvd3 renderer's interactive percent re-basing is not preserved. The deck.gl Multiple Layers chart now fetches its layers entirely client-side; its initial autozoom falls back to the saved viewport, and dashboard filter badges no longer aggregate child-layer filter metadata.
- [41714](https://github.com/apache/superset/pull/41714): Charts migrated in place keep a `NULL` saved query context until they are next opened in Explore (which regenerates it automatically) or re-saved. Until then, cache warm-up and annotation layers referencing such a chart report an actionable error rather than warming/rendering; opening the chart once resolves it.
- [41714](https://github.com/apache/superset/pull/41714): **Breaking for third-party viz plugins** — the `useLegacyApi` field of `ChartMetadata` in `@superset-ui/core` is removed. Plugins that set it must provide a `buildQuery` and consume `/api/v1/chart/data`. The migrated first-party packages also drop their `legacy-` prefix: `@superset-ui/legacy-plugin-chart-{calendar,chord,country-map,horizon,paired-t-test,parallel-coordinates,partition,rose,world-map}``@superset-ui/plugin-chart-*`, and `@superset-ui/legacy-preset-chart-nvd3``@superset-ui/preset-chart-nvd3`. The `can_explore_json` permission is no longer created or granted; custom roles referencing it should switch to the `can_read` permissions on `Chart`.
- [41813](https://github.com/apache/superset/pull/41813): `redis` (the Python client, `redis-py`) is bumped from 5.3.1 to 8.0.1. redis-py 8 changes several connection defaults; Superset's own Redis-backed features (`GLOBAL_ASYNC_QUERIES_CACHE_BACKEND`, `DISTRIBUTED_COORDINATION_CONFIG`, and the MCP Redis store) explicitly pin the pre-upgrade behavior so this bump is a no-op for them: the wire protocol stays RESP2 (not the new RESP3 default, which requires Redis/Sentinel 6+ to speak `HELLO`) and there is still no socket timeout by default (redis-py 8 defaults to 5s, which could otherwise newly time out large cached payloads or slow networks). The no-timeout default can now be overridden via two new config keys, `CACHE_REDIS_SOCKET_TIMEOUT` / `CACHE_REDIS_SOCKET_CONNECT_TIMEOUT`, on any `CacheConfig` dict using `CACHE_TYPE: RedisCache` or `RedisSentinelCache`. Separately, redis-py 6+ changed the default for `ssl_check_hostname` from `False` to `True` for SSL connections using `ssl_cert_reqs="required"` (the default) — this is a security improvement, so it has **not** been reverted; deployments with `CACHE_REDIS_SSL=True` whose certificates lack a hostname matching the connection address should set `CACHE_REDIS_SSL_CERT_REQS="none"` (disables cert verification entirely, matching hostname-check bypass) or replace the certificate. General-purpose cache/results backends configured via `CACHE_CONFIG` / `DATA_CACHE_CONFIG` / `RESULTS_BACKEND` with `CACHE_TYPE: RedisCache` go through `flask-caching`'s own Redis backend (outside Superset's code) and are subject to the same new defaults; pass `socket_timeout` / `protocol` via `CACHE_OPTIONS` there if needed. Celery broker and result-backend connections (built by `kombu`, also outside Superset's code) keep their no-socket-timeout behavior (`kombu` passes `socket_timeout=None` explicitly) but do **not** pin the wire protocol, so they follow redis-py's RESP3 default — which requires a Redis server new enough to speak `HELLO` (Redis 6+). Deployments using a pre-6.0 Redis server (EOL) as a Celery broker should upgrade the server before taking this bump.
@@ -212,7 +216,7 @@ in a later major version.
- **`SqlaTable.sql_url` query-string format.** `SqlaTable.sql_url` now URL-encodes `table_name` and joins it as a query parameter rather than concatenating a second `?`. Previously, with `Database.sql_url` returning `/sqllab/?dbid=<id>`, the concatenation produced `/sqllab/?dbid=<id>?table_name=<raw>` — a malformed second `?` that broke the query parser. External code that parsed the legacy `<base>?table_name=<raw>` shape now sees properly percent-encoded values (e.g. `/``%2F`, ` ``+` or `%20`); decode with `urllib.parse.parse_qsl`.
- **New config flag `EMBEDDED_DISABLE_PERMALINK_ORIGIN_REWRITE` (default `False`).** Share/permalink URLs now substitute `window.location.origin` for the backend-supplied origin so a proxied or subdirectory-deployed Superset never hands the user an unreachable internal hostname. Operators whose reverse proxy correctly forwards `X-Forwarded-Host` *and* who want permalinks to carry the backend's literal origin can opt out by setting `EMBEDDED_DISABLE_PERMALINK_ORIGIN_REWRITE = True` in `superset_config.py`. Default `False` (rewrite is on); flipping the default would regress the dominant proxied/subdir deployment to an unreachable host.
- **New config flag `EMBEDDED_DISABLE_PERMALINK_ORIGIN_REWRITE` (default `False`).** Share/permalink URLs now substitute `window.location.origin` for the backend-supplied origin so a proxied or subdirectory-deployed Superset never hands the user an unreachable internal hostname. Operators whose reverse proxy correctly forwards `X-Forwarded-Host` _and_ who want permalinks to carry the backend's literal origin can opt out by setting `EMBEDDED_DISABLE_PERMALINK_ORIGIN_REWRITE = True` in `superset_config.py`. Default `False` (rewrite is on); flipping the default would regress the dominant proxied/subdir deployment to an unreachable host.
- [41651](https://github.com/apache/superset/pull/41651): **New do-not-translate standard for translation catalogs.** Strings that must stay identical to the source — icon names (e.g. `bolt`), enum/option values (`step-after`), SQL keywords, API field names (`error_message`), code constants, and example placeholders — are now marked with a `#. do-not-translate` extracted comment. The list lives in the `superset/translations/do-not-translate.txt` registry; `scripts/translations/apply_do_not_translate.py` stamps the marker onto `messages.pot` during `babel_update.sh`, and `pybabel update` propagates it to every `.po`, so the status is consistent across all languages. The AI backfill (`backfill_po.py`) and translators leave these entries untranslated (source fallback). The legacy per-catalog convention (a `# Не переводить` translator comment in the `ru` catalog) is still honored for back-compat but is superseded by this standard; contributors adding new machine-read strings should add the msgid to the registry rather than annotating individual catalogs.
@@ -249,7 +253,7 @@ Theme tokens are unaffected — antd 6 removed none of the tokens Superset expos
### Guest-token RLS rules reject unknown fields
The `rls` rules passed to `POST /api/v1/security/guest_token/` are now validated strictly: a rule may only contain `dataset` and `clause`. Previously unknown fields were silently dropped, so a mistyped or legacy scope key (most commonly `datasource` instead of `dataset`) produced a rule with no `dataset`, which is treated as a *global* rule applied to every dataset the embedded resource can reach. Such a request now returns HTTP 400 identifying the offending field instead of issuing a token with an unintended global rule. Integrators that were sending extra fields in RLS rules must remove them; valid dataset-scoped (`{"dataset": 41, "clause": "..."}`) and global (`{"clause": "..."}`) rules are unaffected.
The `rls` rules passed to `POST /api/v1/security/guest_token/` are now validated strictly: a rule may only contain `dataset` and `clause`. Previously unknown fields were silently dropped, so a mistyped or legacy scope key (most commonly `datasource` instead of `dataset`) produced a rule with no `dataset`, which is treated as a _global_ rule applied to every dataset the embedded resource can reach. Such a request now returns HTTP 400 identifying the offending field instead of issuing a token with an unintended global rule. Integrators that were sending extra fields in RLS rules must remove them; valid dataset-scoped (`{"dataset": 41, "clause": "..."}`) and global (`{"clause": "..."}`) rules are unaffected.
### MCP service requires `MCP_JWT_AUDIENCE` when JWT auth is enabled
@@ -333,6 +337,7 @@ ALTER TABLE tagged_object DROP CONSTRAINT <constraint_name>;
-- MySQL: find names via `SHOW CREATE TABLE tagged_object;`
ALTER TABLE tagged_object DROP FOREIGN KEY <constraint_name>;
```
### Entity version-history infrastructure (gated off by default)
Introduces the schema and SQLAlchemy-Continuum wiring that captures version history for charts, dashboards, and datasets, plus read-only `GET /api/v1/{chart,dashboard,dataset}/<uuid>/versions/` endpoints. This ships **inert**: a new config flag `ENABLE_VERSIONING_CAPTURE` defaults to `False`, so no save writes any version rows and the endpoints return empty. It is an operational kill-switch (a release toggle that becomes a permanent ops switch), not a feature flag — set it to `True` to enable capture once validated. The migration is additive; existing entity `PUT` responses gain `old_version_uuid` / `new_version_uuid` body fields and an `ETag` header (both null/absent when capture is off).
@@ -349,12 +354,12 @@ These are behavior changes that take effect on upgrade regardless of `ENABLE_VER
A read-only companion to the version-history endpoints: each entity type gains a `GET /api/v1/{chart,dashboard,dataset}/<uuid>/activity/` endpoint returning a chronological, access-filtered stream of edits — the entity's own edits plus, for charts and dashboards, transitive edits to related entities during their association windows. Datasets have no related layer in V2, so `include=related` returns an empty stream for a dataset and `include=all` reduces to the dataset's own edits.
| Param | Type | Default | Purpose |
|---|---|---|---|
| `since` / `until` | ISO 8601 | — | Bound `issued_at` |
| `include` | `self` \| `related` \| `all` | `all` | Own edits, related edits, or both |
| `q` | string | — | Case-insensitive search over the full history, applied before pagination (so `count` reflects matches) |
| `page` / `page_size` | integer | `0` / `25` | Pagination (`page_size` clamped to 200) |
| Param | Type | Default | Purpose |
| -------------------- | ---------------------------- | ---------- | ------------------------------------------------------------------------------------------------------ |
| `since` / `until` | ISO 8601 | — | Bound `issued_at` |
| `include` | `self` \| `related` \| `all` | `all` | Own edits, related edits, or both |
| `q` | string | — | Case-insensitive search over the full history, applied before pagination (so `count` reflects matches) |
| `page` / `page_size` | integer | `0` / `25` | Pagination (`page_size` clamped to 200) |
Authorization reuses the resource's `can_read` permission and per-object `raise_for_access`; related-entity rows are visibility-filtered to what the caller may see. The stream is empty unless version capture is on (`ENABLE_VERSIONING_CAPTURE`).
@@ -405,6 +410,7 @@ Operators can tune or disable the policy via config:
### Data uploads bounded by UPLOAD_MAX_FILE_SIZE_BYTES
Single data-file uploads (CSV, Excel, columnar) are now bounded by the `UPLOAD_MAX_FILE_SIZE_BYTES` config option, which defaults to `100 * 1024 * 1024` (100 MB). Files larger than this are rejected with a `413` before their contents are buffered into memory. Set `UPLOAD_MAX_FILE_SIZE_BYTES = None` to disable the check and restore unbounded uploads.
### Currency symbol position follows the locale when unset
When a chart's currency control leaves the **Prefix or suffix** field empty, the currency symbol position is now derived from the deployment locale's own convention via `Intl.NumberFormat` instead of always defaulting to a suffix. For example, under the default `en-US` locale `USD`, `GBP`, and `EUR` render as a prefix (`$ 1,000`), while eurozone locales such as `fr-FR` render `EUR` as a suffix (`1 000 €`). An explicit Prefix/Suffix selection is always honored and is unaffected.
@@ -530,7 +536,7 @@ SQLALCHEMY_ENCRYPTED_FIELD_ENGINE = "aes"
```bash
superset re-encrypt-secrets --engine aes-gcm
```
A live instance keeps writing *new* secrets as AES-CBC during the window between step 2 and the restart in step 4; this second pass sweeps those up (it is idempotent, so already-migrated values are skipped).
A live instance keeps writing _new_ secrets as AES-CBC during the window between step 2 and the restart in step 4; this second pass sweeps those up (it is idempotent, so already-migrated values are skipped).
Schedule the cutover in a quiet window. Runtime reads use only the single configured engine, so in a multi-worker deployment there is an unavoidable brief decrypt-outage between the migration commit and the last worker restarting with the new config — each migrator run is transactional, but the fleet-wide cutover is not zero-downtime.
@@ -558,11 +564,11 @@ With the flag enabled: `DELETE /api/v1/dataset/<id>` no longer hard-deletes the
**Schema migration:** the migration adds a nullable `deleted_at` column and an index on it (`ix_tables_deleted_at`) to the `tables` table. The column add is instant; the index build runs inline (no `CONCURRENTLY`) and may briefly block writes on the `tables` table (INSERT/UPDATE/DELETE are queued while the index builds; reads are unaffected) on large Postgres deployments. MySQL InnoDB builds the index online (no blocking). Production deployments with many thousands of datasets should run this migration during a maintenance window.
**Rollback note:** if the application code is rolled back after datasets have been soft-deleted, the older code path's visibility filter no longer applies and previously hidden rows become visible to the older code. Pair the rollback with a data decision (restore the rows, hard-delete them, or also downgrade the migration) rather than assuming the old hard-delete semantics still hold. **Downgrading the migration destroys the deletion markers**: `downgrade()` drops the `deleted_at` column, so any not-yet-restored soft-deleted datasets silently become live, active datasets with no record they were ever deleted. Reconcile the trash (restore or hard-delete each row) *before* downgrading, and disable the `SOFT_DELETE` flag first so no new soft deletes land mid-rollback.
**Rollback note:** if the application code is rolled back after datasets have been soft-deleted, the older code path's visibility filter no longer applies and previously hidden rows become visible to the older code. Pair the rollback with a data decision (restore the rows, hard-delete them, or also downgrade the migration) rather than assuming the old hard-delete semantics still hold. **Downgrading the migration destroys the deletion markers**: `downgrade()` drops the `deleted_at` column, so any not-yet-restored soft-deleted datasets silently become live, active datasets with no record they were ever deleted. Reconcile the trash (restore or hard-delete each row) _before_ downgrading, and disable the `SOFT_DELETE` flag first so no new soft deletes land mid-rollback.
**SQL Lab / dataset-creation flows:** creating a dataset over a table whose dataset sits in the trash is refused. The SQL Lab "save as dataset" flow (`get_or_create_dataset`) and file uploads return a **422 naming the hidden twin and the restore endpoint**; the plain create, update, and duplicate paths currently fail with the generic "already exists" 422. In all cases the remediation is the same: restore the hidden dataset (or use a different table name). Perm-string maintenance also covers hidden rows: renaming a database rewrites `perm`/`schema_perm`/`catalog_perm` on soft-deleted datasets and their charts, so a later restore does not resurrect stale permission strings.
**Importer behavior:** importing a dataset YAML whose UUID matches an existing **soft-deleted** dataset is treated as an implicit restore-with-update — **and this happens even when `overwrite` is not set**. This is a deliberate asymmetry with active rows: an active dataset imported without `overwrite=true` is returned unchanged, but a soft-deleted UUID match is restored *and* has the upload's contents applied regardless of the `overwrite` argument, on the reasoning that re-importing a deleted dataset's exact UUID is an explicit request to bring it back. The restore preserves the original PK, the chart back-reference, `table_columns`, and `sql_metrics`. Non-editors get `ImportFailedError`. Callers without `can_write` get `ImportFailedError` instead of silently receiving the soft-deleted row.
**Importer behavior:** importing a dataset YAML whose UUID matches an existing **soft-deleted** dataset is treated as an implicit restore-with-update — **and this happens even when `overwrite` is not set**. This is a deliberate asymmetry with active rows: an active dataset imported without `overwrite=true` is returned unchanged, but a soft-deleted UUID match is restored _and_ has the upload's contents applied regardless of the `overwrite` argument, on the reasoning that re-importing a deleted dataset's exact UUID is an explicit request to bring it back. The restore preserves the original PK, the chart back-reference, `table_columns`, and `sql_metrics`. Non-editors get `ImportFailedError`. Callers without `can_write` get `ImportFailedError` instead of silently receiving the soft-deleted row.
**Uniqueness-validation changes that apply regardless of the feature flag:** two dataset uniqueness checks were tightened alongside this work and are active even with `SOFT_DELETE` off. (1) Create/update uniqueness treats a dataset whose `catalog` is `NULL` as belonging to the database's default catalog, so a legacy twin pair (`catalog=NULL` vs. `catalog=<default>`, same database/schema/name) that older versions allowed now fails validation with "already exists" when either row is edited — resolve by renaming or removing one of the twins. (2) Duplicating a dataset now checks name collisions scoped to the target (database, catalog, schema) instead of globally by name alone: duplicates into other databases that were previously blocked are now allowed.
@@ -582,9 +588,9 @@ With the flag enabled: `DELETE /api/v1/chart/<id>` no longer hard-deletes the ch
**Schema migration:** the migration adds a nullable `deleted_at` column and an index on it (`ix_slices_deleted_at`) to the `slices` table. The column add is instant; the index build runs inline (no `CONCURRENTLY`) and may briefly block writes on the `slices` table (INSERT/UPDATE/DELETE are queued while the index builds; reads are unaffected) on large Postgres deployments. MySQL InnoDB builds the index online (no blocking).
**Rollback note:** if the application code is rolled back after charts have been soft-deleted, the older code path's visibility filter no longer applies and previously hidden rows become visible to the older code. Pair the rollback with a data decision (restore the rows, hard-delete them, or also downgrade the migration) rather than assuming the old hard-delete semantics still hold. **Downgrading the migration destroys the deletion markers**: `downgrade()` drops the `deleted_at` column, so any not-yet-restored soft-deleted charts silently become live, active charts with no record they were ever deleted. Reconcile the trash (restore or hard-delete each row) *before* downgrading, and disable the `SOFT_DELETE` flag first so no new soft deletes land mid-rollback.
**Rollback note:** if the application code is rolled back after charts have been soft-deleted, the older code path's visibility filter no longer applies and previously hidden rows become visible to the older code. Pair the rollback with a data decision (restore the rows, hard-delete them, or also downgrade the migration) rather than assuming the old hard-delete semantics still hold. **Downgrading the migration destroys the deletion markers**: `downgrade()` drops the `deleted_at` column, so any not-yet-restored soft-deleted charts silently become live, active charts with no record they were ever deleted. Reconcile the trash (restore or hard-delete each row) _before_ downgrading, and disable the `SOFT_DELETE` flag first so no new soft deletes land mid-rollback.
**Importer behavior:** importing a chart YAML whose UUID matches an existing **soft-deleted** chart is treated as an implicit restore-with-update — **and this happens even when `overwrite` is not set**. This is a deliberate asymmetry with active rows: an active chart imported without `overwrite=true` is returned unchanged, but a soft-deleted UUID match is restored *and* has the upload's contents applied regardless of the `overwrite` argument, on the reasoning that re-importing a deleted chart's exact UUID is an explicit request to bring it back. The restore preserves the original PK and all out-of-archive references (`dashboard_slices` junctions, `report.chart_id`, tag rows). The operation is permission-gated: non-editors get `ImportFailedError`, and callers without `can_write` get `ImportFailedError` instead of silently receiving the soft-deleted row.
**Importer behavior:** importing a chart YAML whose UUID matches an existing **soft-deleted** chart is treated as an implicit restore-with-update — **and this happens even when `overwrite` is not set**. This is a deliberate asymmetry with active rows: an active chart imported without `overwrite=true` is returned unchanged, but a soft-deleted UUID match is restored _and_ has the upload's contents applied regardless of the `overwrite` argument, on the reasoning that re-importing a deleted chart's exact UUID is an explicit request to bring it back. The restore preserves the original PK and all out-of-archive references (`dashboard_slices` junctions, `report.chart_id`, tag rows). The operation is permission-gated: non-editors get `ImportFailedError`, and callers without `can_write` get `ImportFailedError` instead of silently receiving the soft-deleted row.
- [39914](https://github.com/apache/superset/pull/39914) `ALERT_REPORT_SLACK_V2` now defaults to `True` and the legacy Slack v1 integration (`Slack` recipient type, `files.upload` API) is deprecated for removal in the next major. Slack blocked new apps from `files.upload` in May 2024 and fully retired the method for all apps on November 12, 2025; because the v1 path sends files through `files.upload`, v1 file-bearing sends now fail at the API level — only text-only `chat_postMessage` still works via the legacy path. Grant your Slack bot the `channels:read` and `groups:read` scopes so existing `Slack` recipients can be auto-upgraded to `SlackV2` on next send. Operators who explicitly override the flag to `False`, or whose Slack bot is missing those scopes, will see deprecation warnings while text-only sends continue through the legacy path.
@@ -608,7 +614,7 @@ The partial-index replacement is dialect-dependent: PostgreSQL uses a native `WH
**Slug semantics:** on PostgreSQL and MySQL 8.0.13+, the slug of a soft-deleted dashboard is **free for reuse**. A new active dashboard can claim it immediately. Restoring a soft-deleted dashboard whose slug has since been claimed returns **422 with a clean error** (`DashboardSlugConflictError`) — rename one of the dashboards and retry; the restore is not silently rejected by a database-level constraint violation.
**Importer behavior:** importing a dashboard YAML whose UUID matches an existing **soft-deleted** dashboard is treated as an implicit restore-with-update — **and this happens even when `overwrite` is not set**. This is a deliberate asymmetry with active rows: an active dashboard imported without `overwrite=true` is returned unchanged (the import never mutates it), but a soft-deleted UUID match is restored *and* has the upload's contents applied regardless of the `overwrite` argument, on the reasoning that re-importing a deleted dashboard's exact UUID is an explicit request to bring it back. The restore preserves the original PK and all pre-deletion relationship rows (`dashboard_slices` junctions, editor/viewer subjects, tags). Callers whose imports must never mutate existing state should treat bundles that may contain previously deleted UUIDs accordingly. The operation is permission-gated: it requires `can_write` and editorship of the deleted row (or admin) — non-editors get `ImportFailedError`, and callers without `can_write` get `ImportFailedError` instead of silently receiving the soft-deleted row.
**Importer behavior:** importing a dashboard YAML whose UUID matches an existing **soft-deleted** dashboard is treated as an implicit restore-with-update — **and this happens even when `overwrite` is not set**. This is a deliberate asymmetry with active rows: an active dashboard imported without `overwrite=true` is returned unchanged (the import never mutates it), but a soft-deleted UUID match is restored _and_ has the upload's contents applied regardless of the `overwrite` argument, on the reasoning that re-importing a deleted dashboard's exact UUID is an explicit request to bring it back. The restore preserves the original PK and all pre-deletion relationship rows (`dashboard_slices` junctions, editor/viewer subjects, tags). Callers whose imports must never mutate existing state should treat bundles that may contain previously deleted UUIDs accordingly. The operation is permission-gated: it requires `can_write` and editorship of the deleted row (or admin) — non-editors get `ImportFailedError`, and callers without `can_write` get `ImportFailedError` instead of silently receiving the soft-deleted row.
### Engine spec capability flag: `supports_offset`
@@ -620,10 +626,10 @@ A new `BaseEngineSpec.supports_offset` attribute (default `True`) indicates whet
A new feature flag `GRANULAR_EXPORT_CONTROLS` introduces three fine-grained permissions that replace the legacy `can_csv` permission:
| Permission | Controls |
|---|---|
| `can_export_data` | CSV, Excel, JSON exports |
| `can_export_image` | Screenshot/PDF exports |
| Permission | Controls |
| -------------------- | ---------------------------- |
| `can_export_data` | CSV, Excel, JSON exports |
| `can_export_image` | Screenshot/PDF exports |
| `can_copy_clipboard` | Copy-to-clipboard operations |
When the feature flag is enabled, these permissions are enforced on both the frontend (disabled buttons with tooltips) and backend (403 responses from API endpoints). When disabled, legacy `can_csv` behavior is preserved.
@@ -661,14 +667,17 @@ The Kenya country map has been updated to reflect the 47 counties established un
MCP (Model Context Protocol) tools now include enhanced observability instrumentation for monitoring and debugging:
**Two-layer instrumentation:**
1. **Middleware layer** (`LoggingMiddleware`): Automatically logs all MCP tool calls with `duration_ms` and `success` status in the audit log (Action Log UI, logs table)
2. **Sub-operation tracking**: All 19 MCP tools include granular `event_logger.log_context()` blocks for tracking individual operations like validation, database writes, and query execution
**Action naming convention:**
- Tool-level logs: `mcp_tool_call` (via middleware)
- Sub-operation logs: `mcp.{tool_name}.{operation}` (e.g., `mcp.generate_chart.validation`, `mcp.execute_sql.query_execution`)
**Querying MCP logs:**
```sql
-- Top slowest MCP operations
SELECT action, COUNT(*) as calls, AVG(duration_ms) as avg_ms
@@ -703,6 +712,7 @@ A new `DISTRIBUTED_COORDINATION_CONFIG` configuration provides a unified Redis-b
The distributed coordination is used by the Global Task Framework (GTF) for abort notifications and task completion signaling, and will eventually replace `GLOBAL_ASYNC_QUERIES_CACHE_BACKEND` as the standard signaling backend. Configuring this is recommended for Redis enabled production deployments.
Example configuration in `superset_config.py`:
```python
DISTRIBUTED_COORDINATION_CONFIG = {
"CACHE_TYPE": "RedisCache",
@@ -717,9 +727,11 @@ See `superset/config.py` for complete configuration options.
### WebSocket config for GAQ with Docker
[35896](https://github.com/apache/superset/pull/35896) and [37624](https://github.com/apache/superset/pull/37624) updated documentation on how to run and configure Superset with Docker. Specifically for the WebSocket configuration, a new `docker/superset-websocket/config.example.json` was added to the repo, so that users could copy it to create a `docker/superset-websocket/config.json` file. The existing `docker/superset-websocket/config.json` was removed and git-ignored, so if you're using GAQ / WebSocket make sure to:
- Stash/backup your existing `config.json` file, to re-apply it after (will get git-ignored going forward)
- Update the `volumes` configuration for the `superset-websocket` service in your `docker-compose.override.yml` file, to include the `docker/superset-websocket/config.json` file. For example:
``` yaml
```yaml
services:
superset-websocket:
volumes:
@@ -732,7 +744,9 @@ services:
### Example Data Loading Improvements
#### New Directory Structure
Examples are now organized by name with data and configs co-located:
```
superset/examples/
├── _shared/ # Shared database & metadata configs
@@ -745,12 +759,14 @@ superset/examples/
```
#### Simplified Parquet-based Loading
- Auto-discovery: create `superset/examples/my_dataset/data.parquet` to add a new example
- Parquet is an Apache project format: compressed (~27% smaller), self-describing schema
- YAML configs define datasets, charts, and dashboards declaratively
- Removed Python-based data generation from individual example files
#### Test Data Reorganization
- Moved `big_data.py` to `superset/cli/test_loaders.py` - better reflects its purpose as a test utility
- Fixed inverted logic for `--load-test-data` flag (now correctly includes .test.yaml files when flag is set)
- Clarified CLI flags:
@@ -760,6 +776,7 @@ superset/examples/
- `--load-big-data` / `-b`: Generate synthetic stress-test data
#### Bug Fixes
- Fixed numpy array serialization for PostgreSQL (converts complex types to JSON strings)
- Fixed KeyError for `allow_csv_upload` field in database configs (now optional with default)
- Fixed test data loading logic that was incorrectly filtering files
@@ -769,6 +786,7 @@ superset/examples/
The MCP (Model Context Protocol) service enables AI assistants and automation tools to interact programmatically with Superset.
#### New Features
- MCP service infrastructure with FastMCP framework
- Tools for dashboards, charts, datasets, SQL Lab, and instance metadata
- Optional dependency: install with `pip install apache-superset[fastmcp]`
@@ -778,6 +796,7 @@ The MCP (Model Context Protocol) service enables AI assistants and automation to
#### New Configuration Options
**Development** (single-user, local testing):
```python
# superset_config.py
MCP_DEV_USERNAME = "admin" # User for MCP authentication
@@ -786,6 +805,7 @@ MCP_SERVICE_PORT = 5008
```
**Production** (JWT-based, multi-user):
```python
# superset_config.py
MCP_AUTH_ENABLED = True
@@ -831,12 +851,14 @@ superset mcp run --port 5008 --use-factory-config
The MCP service runs as a **separate process** from the Superset web server.
**Important**:
- Requires same Python environment and configuration as Superset
- Shares database connections with main Superset app
- Can be scaled independently from web server
- Requires `fastmcp` package (optional dependency)
**Installation**:
```bash
# Install with MCP support
pip install apache-superset[fastmcp]
@@ -850,6 +872,7 @@ Use systemd, supervisord, or Kubernetes to manage the MCP service process.
See `superset/mcp_service/PRODUCTION.md` for deployment guides.
**Security**:
- Development: Uses `MCP_DEV_USERNAME` for single-user access
- Production: **MUST** configure JWT authentication
- See `superset/mcp_service/SECURITY.md` for details
@@ -869,8 +892,10 @@ See `superset/mcp_service/PRODUCTION.md` for deployment guides.
- [35062](https://github.com/apache/superset/pull/35062): Changed the function signature of `setupExtensions` to `setupCodeOverrides` with options as arguments.
### Breaking Changes
- [37370](https://github.com/apache/superset/pull/37370): The `APP_NAME` configuration variable no longer controls the browser window/tab title or other frontend branding. Application names should now be configured using the theme system with the `brandAppName` token. The `APP_NAME` config is still used for backend contexts (MCP service, logs, etc.) and serves as a fallback if `brandAppName` is not set.
- **Migration:**
```python
# Before (Superset 5.x)
APP_NAME = "My Custom App"
@@ -914,16 +939,16 @@ See `superset/mcp_service/PRODUCTION.md` for deployment guides.
Eight M:N association tables move from a synthetic `id INTEGER PRIMARY KEY` to a composite `PRIMARY KEY (fk1, fk2)` on their two foreign-key columns. The surrogate `id` is dropped, and the redundant `UNIQUE (fk1, fk2)` on the two tables that carried one is removed (now subsumed by the PK).
| Table | Composite PK |
|---|---|
| `dashboard_roles` | `(dashboard_id, role_id)` |
| `dashboard_slices` | `(dashboard_id, slice_id)` |
| `dashboard_user` | `(user_id, dashboard_id)` |
| Table | Composite PK |
| ---------------------- | ------------------------------- |
| `dashboard_roles` | `(dashboard_id, role_id)` |
| `dashboard_slices` | `(dashboard_id, slice_id)` |
| `dashboard_user` | `(user_id, dashboard_id)` |
| `report_schedule_user` | `(user_id, report_schedule_id)` |
| `rls_filter_roles` | `(role_id, rls_filter_id)` |
| `rls_filter_tables` | `(table_id, rls_filter_id)` |
| `slice_user` | `(user_id, slice_id)` |
| `sqlatable_user` | `(user_id, table_id)` |
| `rls_filter_roles` | `(role_id, rls_filter_id)` |
| `rls_filter_tables` | `(table_id, rls_filter_id)` |
| `slice_user` | `(user_id, slice_id)` |
| `sqlatable_user` | `(user_id, table_id)` |
**Before upgrading:**
@@ -934,6 +959,7 @@ Eight M:N association tables move from a synthetic `id INTEGER PRIMARY KEY` to a
For large `dashboard_slices` / `report_schedule_user` tables, see the operator runbook in [#39859](https://github.com/apache/superset/pull/39859) — pre-flight inventory queries, per-dialect lock-window sizing, and the duplicate / NULL-FK roll-up — to plan the maintenance window.
## 6.0.0
- [33055](https://github.com/apache/superset/pull/33055): Upgrades Flask-AppBuilder to 5.0.0. The AUTH_OID authentication type has been deprecated and is no longer available as an option in Flask-AppBuilder. OpenID (OID) is considered a deprecated authentication protocol - if you are using AUTH_OID, you will need to migrate to an alternative authentication method such as OAuth, LDAP, or database authentication before upgrading.
- [34871](https://github.com/apache/superset/pull/34871): Fixed Jest test hanging issue from Ant Design v5 upgrade. MessageChannel is now mocked in test environment to prevent rc-overflow from causing Jest to hang. Test environment only - no production impact.
- [34782](https://github.com/apache/superset/pull/34782): Dataset exports now include the dataset ID in their file name (similar to charts and dashboards). If managing assets as code, make sure to rename existing dataset YAMLs to include the ID (and avoid duplicated files).
@@ -942,8 +968,8 @@ For large `dashboard_slices` / `report_schedule_user` tables, see the operator r
- Change any hex color values to one of: `"success"`, `"processing"`, `"error"`, `"warning"`, `"default"`
- Custom colors are no longer supported to maintain consistency with Ant Design components
- [34561](https://github.com/apache/superset/pull/34561) Added tiled screenshot functionality for Playwright-based reports to handle large dashboards more efficiently. When enabled (default: `SCREENSHOT_TILED_ENABLED = True`), dashboards with 20+ charts or height exceeding 5000px will be captured using multiple viewport-sized tiles and combined into a single image. This improves report generation performance and reliability for large dashboards.
Note: Pillow is now a required dependency (previously optional) to support image processing for tiled screenshots.
`thumbnails` optional dependency is now deprecated and will be removed in the next major release (7.0).
Note: Pillow is now a required dependency (previously optional) to support image processing for tiled screenshots.
`thumbnails` optional dependency is now deprecated and will be removed in the next major release (7.0).
- [33084](https://github.com/apache/superset/pull/33084) The DISALLOWED_SQL_FUNCTIONS configuration now includes additional potentially sensitive database functions across PostgreSQL, MySQL, SQLite, MS SQL Server, and ClickHouse. Existing queries using these functions may now be blocked. Review your SQL Lab queries and dashboards if you encounter "disallowed function" errors after upgrading
- [34235](https://github.com/apache/superset/pull/34235) CSV exports now use `utf-8-sig` encoding by default to include a UTF-8 BOM, improving compatibility with Excel.
- [34258](https://github.com/apache/superset/pull/34258) changing the default in Dockerfile to INCLUDE_CHROMIUM="false" (from "true") in the past. This ensures the `lean` layer is lean by default, and people can opt-in to the `chromium` layer by setting the build arg `INCLUDE_CHROMIUM=true`. This is a breaking change for anyone using the `lean` layer, as it will no longer include Chromium by default.

View File

@@ -18,7 +18,7 @@ code is less ambiguous and is unique to all regions in the world.
## Included Maps
The current list of countries can be found in the src
[legacy-plugin-chart-country-map/src/countries.ts](https://github.com/apache/superset/blob/master/superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries.ts)
[plugin-chart-country-map/src/countries.ts](https://github.com/apache/superset/blob/master/superset-frontend/plugins/plugin-chart-country-map/src/countries.ts)
The Country Maps visualization already ships with the maps for the following countries:
@@ -31,10 +31,10 @@ The Country Maps visualization already ships with the maps for the following cou
## Adding a New Country
To add a new country to the list, you'd have to edit files in
[@superset-ui/legacy-plugin-chart-country-map](https://github.com/apache/superset/tree/master/superset-frontend/plugins/legacy-plugin-chart-country-map).
[@superset-ui/plugin-chart-country-map](https://github.com/apache/superset/tree/master/superset-frontend/plugins/plugin-chart-country-map).
1. Generate a new GeoJSON file for your country following the guide in [this Jupyter notebook](https://github.com/apache/superset/blob/master/superset-frontend/plugins/legacy-plugin-chart-country-map/scripts/Country%20Map%20GeoJSON%20Generator.ipynb).
2. Edit the countries list in [legacy-plugin-chart-country-map/src/countries.ts](https://github.com/apache/superset/blob/master/superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries.ts).
1. Generate a new GeoJSON file for your country following the guide in [this Jupyter notebook](https://github.com/apache/superset/blob/master/superset-frontend/plugins/plugin-chart-country-map/scripts/Country%20Map%20GeoJSON%20Generator.ipynb).
2. Edit the countries list in [plugin-chart-country-map/src/countries.ts](https://github.com/apache/superset/blob/master/superset-frontend/plugins/plugin-chart-country-map/src/countries.ts).
3. Install superset-frontend dependencies: `cd superset-frontend && npm install`
4. Verify your countries in Superset plugins storybook: `npm run plugins:storybook`.
5. Build and install Superset from source code.

View File

@@ -139,7 +139,7 @@ d1 = [
]
databend = ["databend-sqlalchemy>=0.5.5, <1.0"]
databricks = [
"databricks-sql-connector==4.2.6",
"databricks-sql-connector>=4.2.6, <4.4.0",
"databricks-sqlalchemy==1.0.5",
]
db2 = ["ibm-db-sa>0.3.8, <=0.4.4"]

View File

@@ -36,11 +36,9 @@ filterwarnings =
error:"TableColumn" object is being merged into a Session:sqlalchemy.exc.RemovedIn20Warning
error:"TaggedObject" object is being merged into a Session:sqlalchemy.exc.RemovedIn20Warning
error:The autoload parameter is deprecated:sqlalchemy.exc.RemovedIn20Warning
error:The current statement is being autocommitted using implicit autocommit:sqlalchemy.exc.RemovedIn20Warning
error:The connection.execute\(\) method:sqlalchemy.exc.RemovedIn20Warning
# error:The current statement is being autocommitted using implicit autocommit:sqlalchemy.exc.RemovedIn20Warning
error:The current statement is being autocommitted using implicit autocommit:sqlalchemy.exc.RemovedIn20Warning
error:The ``declarative_base\(\)`` function is now available:sqlalchemy.exc.RemovedIn20Warning
error:The Engine.execute\(\) method is considered legacy:sqlalchemy.exc.RemovedIn20Warning
error:The legacy calling style of select\(\) is deprecated:sqlalchemy.exc.RemovedIn20Warning
error:The "whens" argument to case:sqlalchemy.exc.RemovedIn20Warning
# error:"User" object is being merged into a Session:sqlalchemy.exc.RemovedIn20Warning

View File

@@ -28,6 +28,8 @@ babel==2.17.0
# via flask-babel
backoff==2.2.1
# via apache-superset (pyproject.toml)
backports-zstd==1.6.0
# via flask-compress
bcrypt==4.3.0
# via paramiko
billiard==4.2.1
@@ -130,7 +132,7 @@ flask-babel==3.1.0
# via flask-appbuilder
flask-caching==2.3.1
# via apache-superset (pyproject.toml)
flask-compress==1.17
flask-compress==1.24
# via apache-superset (pyproject.toml)
flask-cors==6.0.5
# via apache-superset (pyproject.toml)
@@ -285,7 +287,7 @@ parsedatetime==2.6
# via apache-superset (pyproject.toml)
pgsanity==0.2.9
# via apache-superset (pyproject.toml)
pillow==12.2.0
pillow==12.3.0
# via apache-superset (pyproject.toml)
platformdirs==4.3.8
# via requests-cache
@@ -496,5 +498,3 @@ xlsxwriter==3.2.9
# via
# apache-superset (pyproject.toml)
# pandas
zstandard==0.23.0
# via flask-compress

View File

@@ -64,6 +64,10 @@ backoff==2.2.1
# apache-superset
backports-tarfile==1.2.0
# via jaraco-context
backports-zstd==1.6.0
# via
# -c requirements/base-constraint.txt
# flask-compress
bcrypt==4.3.0
# via
# -c requirements/base-constraint.txt
@@ -276,7 +280,7 @@ flask-caching==2.3.1
# via
# -c requirements/base-constraint.txt
# apache-superset
flask-compress==1.17
flask-compress==1.24
# via
# -c requirements/base-constraint.txt
# apache-superset
@@ -665,7 +669,7 @@ pgsanity==0.2.9
# via
# -c requirements/base-constraint.txt
# apache-superset
pillow==12.2.0
pillow==12.3.0
# via
# -c requirements/base-constraint.txt
# apache-superset
@@ -1168,7 +1172,4 @@ zope-event==5.0
zope-interface==5.4.0
# via gevent
zstandard==0.23.0
# via
# -c requirements/base-constraint.txt
# flask-compress
# trino
# via trino

View File

@@ -51,24 +51,23 @@
"@scarf/scarf": "^1.4.0",
"@superset-ui/chart-controls": "file:./packages/superset-ui-chart-controls",
"@superset-ui/core": "file:./packages/superset-ui-core",
"@superset-ui/legacy-plugin-chart-calendar": "file:./plugins/legacy-plugin-chart-calendar",
"@superset-ui/legacy-plugin-chart-chord": "file:./plugins/legacy-plugin-chart-chord",
"@superset-ui/legacy-plugin-chart-country-map": "file:./plugins/legacy-plugin-chart-country-map",
"@superset-ui/legacy-plugin-chart-horizon": "file:./plugins/legacy-plugin-chart-horizon",
"@superset-ui/legacy-plugin-chart-paired-t-test": "file:./plugins/legacy-plugin-chart-paired-t-test",
"@superset-ui/legacy-plugin-chart-parallel-coordinates": "file:./plugins/legacy-plugin-chart-parallel-coordinates",
"@superset-ui/legacy-plugin-chart-partition": "file:./plugins/legacy-plugin-chart-partition",
"@superset-ui/legacy-plugin-chart-rose": "file:./plugins/legacy-plugin-chart-rose",
"@superset-ui/legacy-plugin-chart-world-map": "file:./plugins/legacy-plugin-chart-world-map",
"@superset-ui/legacy-preset-chart-nvd3": "file:./plugins/legacy-preset-chart-nvd3",
"@superset-ui/plugin-chart-ag-grid-table": "file:./plugins/plugin-chart-ag-grid-table",
"@superset-ui/plugin-chart-calendar": "file:./plugins/plugin-chart-calendar",
"@superset-ui/plugin-chart-cartodiagram": "file:./plugins/plugin-chart-cartodiagram",
"@superset-ui/plugin-chart-chord": "file:./plugins/plugin-chart-chord",
"@superset-ui/plugin-chart-country-map": "file:./plugins/plugin-chart-country-map",
"@superset-ui/plugin-chart-echarts": "file:./plugins/plugin-chart-echarts",
"@superset-ui/plugin-chart-handlebars": "file:./plugins/plugin-chart-handlebars",
"@superset-ui/plugin-chart-horizon": "file:./plugins/plugin-chart-horizon",
"@superset-ui/plugin-chart-paired-t-test": "file:./plugins/plugin-chart-paired-t-test",
"@superset-ui/plugin-chart-parallel-coordinates": "file:./plugins/plugin-chart-parallel-coordinates",
"@superset-ui/plugin-chart-partition": "file:./plugins/plugin-chart-partition",
"@superset-ui/plugin-chart-pivot-table": "file:./plugins/plugin-chart-pivot-table",
"@superset-ui/plugin-chart-point-cluster-map": "file:./plugins/plugin-chart-point-cluster-map",
"@superset-ui/plugin-chart-rose": "file:./plugins/plugin-chart-rose",
"@superset-ui/plugin-chart-table": "file:./plugins/plugin-chart-table",
"@superset-ui/plugin-chart-word-cloud": "file:./plugins/plugin-chart-word-cloud",
"@superset-ui/plugin-chart-world-map": "file:./plugins/plugin-chart-world-map",
"@superset-ui/preset-chart-deckgl": "file:./plugins/preset-chart-deckgl",
"@superset-ui/switchboard": "file:./packages/superset-ui-switchboard",
"@types/d3-format": "^3.0.1",
@@ -10760,54 +10759,26 @@
"resolved": "packages/generator-superset",
"link": true
},
"node_modules/@superset-ui/legacy-plugin-chart-calendar": {
"resolved": "plugins/legacy-plugin-chart-calendar",
"link": true
},
"node_modules/@superset-ui/legacy-plugin-chart-chord": {
"resolved": "plugins/legacy-plugin-chart-chord",
"link": true
},
"node_modules/@superset-ui/legacy-plugin-chart-country-map": {
"resolved": "plugins/legacy-plugin-chart-country-map",
"link": true
},
"node_modules/@superset-ui/legacy-plugin-chart-horizon": {
"resolved": "plugins/legacy-plugin-chart-horizon",
"link": true
},
"node_modules/@superset-ui/legacy-plugin-chart-paired-t-test": {
"resolved": "plugins/legacy-plugin-chart-paired-t-test",
"link": true
},
"node_modules/@superset-ui/legacy-plugin-chart-parallel-coordinates": {
"resolved": "plugins/legacy-plugin-chart-parallel-coordinates",
"link": true
},
"node_modules/@superset-ui/legacy-plugin-chart-partition": {
"resolved": "plugins/legacy-plugin-chart-partition",
"link": true
},
"node_modules/@superset-ui/legacy-plugin-chart-rose": {
"resolved": "plugins/legacy-plugin-chart-rose",
"link": true
},
"node_modules/@superset-ui/legacy-plugin-chart-world-map": {
"resolved": "plugins/legacy-plugin-chart-world-map",
"link": true
},
"node_modules/@superset-ui/legacy-preset-chart-nvd3": {
"resolved": "plugins/legacy-preset-chart-nvd3",
"link": true
},
"node_modules/@superset-ui/plugin-chart-ag-grid-table": {
"resolved": "plugins/plugin-chart-ag-grid-table",
"link": true
},
"node_modules/@superset-ui/plugin-chart-calendar": {
"resolved": "plugins/plugin-chart-calendar",
"link": true
},
"node_modules/@superset-ui/plugin-chart-cartodiagram": {
"resolved": "plugins/plugin-chart-cartodiagram",
"link": true
},
"node_modules/@superset-ui/plugin-chart-chord": {
"resolved": "plugins/plugin-chart-chord",
"link": true
},
"node_modules/@superset-ui/plugin-chart-country-map": {
"resolved": "plugins/plugin-chart-country-map",
"link": true
},
"node_modules/@superset-ui/plugin-chart-echarts": {
"resolved": "plugins/plugin-chart-echarts",
"link": true
@@ -10816,6 +10787,22 @@
"resolved": "plugins/plugin-chart-handlebars",
"link": true
},
"node_modules/@superset-ui/plugin-chart-horizon": {
"resolved": "plugins/plugin-chart-horizon",
"link": true
},
"node_modules/@superset-ui/plugin-chart-paired-t-test": {
"resolved": "plugins/plugin-chart-paired-t-test",
"link": true
},
"node_modules/@superset-ui/plugin-chart-parallel-coordinates": {
"resolved": "plugins/plugin-chart-parallel-coordinates",
"link": true
},
"node_modules/@superset-ui/plugin-chart-partition": {
"resolved": "plugins/plugin-chart-partition",
"link": true
},
"node_modules/@superset-ui/plugin-chart-pivot-table": {
"resolved": "plugins/plugin-chart-pivot-table",
"link": true
@@ -10824,6 +10811,10 @@
"resolved": "plugins/plugin-chart-point-cluster-map",
"link": true
},
"node_modules/@superset-ui/plugin-chart-rose": {
"resolved": "plugins/plugin-chart-rose",
"link": true
},
"node_modules/@superset-ui/plugin-chart-table": {
"resolved": "plugins/plugin-chart-table",
"link": true
@@ -10832,6 +10823,10 @@
"resolved": "plugins/plugin-chart-word-cloud",
"link": true
},
"node_modules/@superset-ui/plugin-chart-world-map": {
"resolved": "plugins/plugin-chart-world-map",
"link": true
},
"node_modules/@superset-ui/preset-chart-deckgl": {
"resolved": "plugins/preset-chart-deckgl",
"link": true
@@ -16496,12 +16491,6 @@
"url": "https://github.com/sponsors/wooorm"
}
},
"node_modules/cephes": {
"version": "2.0.0",
"resolved": "https://registry.npmjs.org/cephes/-/cephes-2.0.0.tgz",
"integrity": "sha512-4GMUzkcXHZ0HMZ3gZdBrv8pQs1/zkJh2Q9rQOF8NJZHanM359y3XOSdeqmDBPfxQKYQpJt58R3dUpofrIXJ2mg==",
"license": "BSD-3-Clause"
},
"node_modules/chai": {
"version": "5.3.3",
"resolved": "https://registry.npmjs.org/chai/-/chai-5.3.3.tgz",
@@ -18919,15 +18908,6 @@
"readable-stream": "^3.1.1"
}
},
"node_modules/distributions": {
"version": "2.2.0",
"resolved": "https://registry.npmjs.org/distributions/-/distributions-2.2.0.tgz",
"integrity": "sha512-n7ybud+CRAOZlpg+ETuA0PTiSBfyVNt8Okns5gSK4NvHwj7RamQoufptOucvVcTn9CV4DZ38p1k6TgwMexUNkQ==",
"license": "MIT",
"dependencies": {
"cephes": "^2.0.0"
}
},
"node_modules/dnd-core": {
"version": "11.1.3",
"resolved": "https://registry.npmjs.org/dnd-core/-/dnd-core-11.1.3.tgz",
@@ -20782,12 +20762,6 @@
"integrity": "sha512-w+eufiZ1WuJYgPXbV/PO3NCMEc3xqylkKHzp8bxp1uW4qaSNQUkwmLLEc3kKsfz8lpV1F8Ht3U1Cm+9Srog2ug==",
"license": "(MIT AND Zlib)"
},
"node_modules/fast-safe-stringify": {
"version": "2.1.1",
"resolved": "https://registry.npmjs.org/fast-safe-stringify/-/fast-safe-stringify-2.1.1.tgz",
"integrity": "sha512-W+KJc2dmILlPplD/H4K9l9LcAHAfPtP6BY84uVLXQ6Evcz9Lcg33Y2z1IVblT6xdY54PXYVHEv+0Wpq8Io6zkA==",
"license": "MIT"
},
"node_modules/fast-uri": {
"version": "3.1.4",
"resolved": "https://registry.npmjs.org/fast-uri/-/fast-uri-3.1.4.tgz",
@@ -36001,15 +35975,6 @@
"integrity": "sha512-zYiwtZUcYyXKo/np96AGZAckk+FWWsUdJ3cHGGmld7+AhvcWmQyGCYUh1hc4Q/pkOhb65dQR/pqCyK0cOaHz4Q==",
"license": "MIT"
},
"node_modules/reactable": {
"version": "1.1.0",
"resolved": "https://registry.npmjs.org/reactable/-/reactable-1.1.0.tgz",
"integrity": "sha512-SnvZ3CXyFFxGotw9cqNiVUGb2oW16UlIypGQZRJGgPiJuFqW22jO7A+Y/Tvv8no8F/bZoLdZ+QJP7eZfcc9kCw==",
"license": "MIT",
"peerDependencies": {
"react": "* || ^0.14.0"
}
},
"node_modules/read": {
"version": "4.1.0",
"resolved": "https://registry.npmjs.org/read/-/read-4.1.0.tgz",
@@ -44134,245 +44099,6 @@
"version": "0.20.3",
"license": "Apache-2.0"
},
"plugins/legacy-plugin-chart-calendar": {
"name": "@superset-ui/legacy-plugin-chart-calendar",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3-array": "^3.2.4",
"d3-selection": "^3.0.0",
"d3-tip": "^0.9.1",
"prop-types": "^15.8.1"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@emotion/react": "^11.4.1",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"react": "^18.3.0"
}
},
"plugins/legacy-plugin-chart-calendar/node_modules/d3-array": {
"version": "3.2.4",
"resolved": "https://registry.npmjs.org/d3-array/-/d3-array-3.2.4.tgz",
"integrity": "sha512-tdQAmyA18i4J7wprpYq8ClcxZy3SC31QMeByyCFyRt7BVHdREQZ5lpzoe5mFEYZUWe+oq8HBvk9JjpibyEV4Jg==",
"license": "ISC",
"dependencies": {
"internmap": "1 - 2"
},
"engines": {
"node": ">=12"
}
},
"plugins/legacy-plugin-chart-calendar/node_modules/d3-selection": {
"version": "3.0.0",
"resolved": "https://registry.npmjs.org/d3-selection/-/d3-selection-3.0.0.tgz",
"integrity": "sha512-fmTRWbNMmsmWq6xJV8D19U/gw/bwrHfNXxrIN+HfZgnzqTHp9jOmKMhsTUjXOJnZOdZY9Q28y4yebKzqDKlxlQ==",
"license": "ISC",
"engines": {
"node": ">=12"
}
},
"plugins/legacy-plugin-chart-chord": {
"name": "@superset-ui/legacy-plugin-chart-chord",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3": "^3.5.17",
"prop-types": "^15.8.1",
"react": "^19.2.7"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*"
}
},
"plugins/legacy-plugin-chart-chord/node_modules/react": {
"version": "19.2.7",
"resolved": "https://registry.npmjs.org/react/-/react-19.2.7.tgz",
"integrity": "sha512-HNe9WslTbXmFK8o8cmwgAeJFSBvt1bPdHCVKtaaV+WlAN36mpT4hcRpwbf3fY56ar2oIXzsBpOAiIRHAdY0OlQ==",
"license": "MIT",
"engines": {
"node": ">=0.10.0"
}
},
"plugins/legacy-plugin-chart-country-map": {
"name": "@superset-ui/legacy-plugin-chart-country-map",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3": "^3.5.17",
"d3-array": "^3.2.4",
"prop-types": "^15.8.1"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"react": "^18.3.0"
}
},
"plugins/legacy-plugin-chart-country-map/node_modules/d3-array": {
"version": "3.2.4",
"resolved": "https://registry.npmjs.org/d3-array/-/d3-array-3.2.4.tgz",
"integrity": "sha512-tdQAmyA18i4J7wprpYq8ClcxZy3SC31QMeByyCFyRt7BVHdREQZ5lpzoe5mFEYZUWe+oq8HBvk9JjpibyEV4Jg==",
"license": "ISC",
"dependencies": {
"internmap": "1 - 2"
},
"engines": {
"node": ">=12"
}
},
"plugins/legacy-plugin-chart-horizon": {
"name": "@superset-ui/legacy-plugin-chart-horizon",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3-array": "^3.2.4",
"d3-scale": "^4.0.2",
"prop-types": "^15.8.1"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"react": "^18.3.0"
}
},
"plugins/legacy-plugin-chart-horizon/node_modules/d3-array": {
"version": "3.2.4",
"resolved": "https://registry.npmjs.org/d3-array/-/d3-array-3.2.4.tgz",
"integrity": "sha512-tdQAmyA18i4J7wprpYq8ClcxZy3SC31QMeByyCFyRt7BVHdREQZ5lpzoe5mFEYZUWe+oq8HBvk9JjpibyEV4Jg==",
"license": "ISC",
"dependencies": {
"internmap": "1 - 2"
},
"engines": {
"node": ">=12"
}
},
"plugins/legacy-plugin-chart-paired-t-test": {
"name": "@superset-ui/legacy-plugin-chart-paired-t-test",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"distributions": "^2.2.0",
"prop-types": "^15.8.1",
"reactable": "^1.1.0"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"react": "^18.3.0"
}
},
"plugins/legacy-plugin-chart-parallel-coordinates": {
"name": "@superset-ui/legacy-plugin-chart-parallel-coordinates",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3v3": "npm:d3@3.5.17",
"prop-types": "^15.8.1"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"react": "^18.3.0"
}
},
"plugins/legacy-plugin-chart-partition": {
"name": "@superset-ui/legacy-plugin-chart-partition",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3": "^3.5.17",
"d3-hierarchy": "^3.1.2",
"prop-types": "^15.8.1"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"@testing-library/jest-dom": "*",
"@testing-library/react": "^14.0.0",
"react": "^18.3.0",
"react-dom": "^18.3.0"
}
},
"plugins/legacy-plugin-chart-rose": {
"name": "@superset-ui/legacy-plugin-chart-rose",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3": "^3.5.17",
"nvd3-fork": "^2.0.5",
"prop-types": "^15.8.1"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@emotion/react": "^11.4.1",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"react": "^18.3.0"
}
},
"plugins/legacy-plugin-chart-world-map": {
"name": "@superset-ui/legacy-plugin-chart-world-map",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3": "^3.5.17",
"d3-array": "^3.2.4",
"datamaps": "^0.5.10",
"prop-types": "^15.8.1",
"tinycolor2": "^1.6.0"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"react": "^18.3.0"
}
},
"plugins/legacy-plugin-chart-world-map/node_modules/d3-array": {
"version": "3.2.4",
"resolved": "https://registry.npmjs.org/d3-array/-/d3-array-3.2.4.tgz",
"integrity": "sha512-tdQAmyA18i4J7wprpYq8ClcxZy3SC31QMeByyCFyRt7BVHdREQZ5lpzoe5mFEYZUWe+oq8HBvk9JjpibyEV4Jg==",
"license": "ISC",
"dependencies": {
"internmap": "1 - 2"
},
"engines": {
"node": ">=12"
}
},
"plugins/legacy-preset-chart-nvd3": {
"name": "@superset-ui/legacy-preset-chart-nvd3",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3": "^3.5.17",
"d3-tip": "^0.9.1",
"dompurify": "^3.4.12",
"fast-safe-stringify": "^2.1.1",
"lodash": "^4.18.1",
"lodash-es": "^4.18.1",
"nvd3-fork": "^2.0.5",
"prop-types": "^15.8.1",
"urijs": "^1.19.11"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"dayjs": "^1.11.21",
"react": "^18.3.0"
}
},
"plugins/plugin-chart-ag-grid-table": {
"name": "@superset-ui/plugin-chart-ag-grid-table",
"version": "0.20.3",
@@ -44415,6 +44141,45 @@
"node": ">=12"
}
},
"plugins/plugin-chart-calendar": {
"name": "@superset-ui/plugin-chart-calendar",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3-array": "^3.2.4",
"d3-selection": "^3.0.0",
"d3-tip": "^0.9.1",
"prop-types": "^15.8.1"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@emotion/react": "^11.4.1",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"react": "^18.3.0"
}
},
"plugins/plugin-chart-calendar/node_modules/d3-array": {
"version": "3.2.4",
"resolved": "https://registry.npmjs.org/d3-array/-/d3-array-3.2.4.tgz",
"integrity": "sha512-tdQAmyA18i4J7wprpYq8ClcxZy3SC31QMeByyCFyRt7BVHdREQZ5lpzoe5mFEYZUWe+oq8HBvk9JjpibyEV4Jg==",
"license": "ISC",
"dependencies": {
"internmap": "1 - 2"
},
"engines": {
"node": ">=12"
}
},
"plugins/plugin-chart-calendar/node_modules/d3-selection": {
"version": "3.0.0",
"resolved": "https://registry.npmjs.org/d3-selection/-/d3-selection-3.0.0.tgz",
"integrity": "sha512-fmTRWbNMmsmWq6xJV8D19U/gw/bwrHfNXxrIN+HfZgnzqTHp9jOmKMhsTUjXOJnZOdZY9Q28y4yebKzqDKlxlQ==",
"license": "ISC",
"engines": {
"node": ">=12"
}
},
"plugins/plugin-chart-cartodiagram": {
"name": "@superset-ui/plugin-chart-cartodiagram",
"version": "0.0.1",
@@ -44443,6 +44208,58 @@
"react-dom": "^18.3.0"
}
},
"plugins/plugin-chart-chord": {
"name": "@superset-ui/plugin-chart-chord",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3": "^3.5.17",
"prop-types": "^15.8.1",
"react": "^19.2.7"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*"
}
},
"plugins/plugin-chart-chord/node_modules/react": {
"version": "19.2.7",
"resolved": "https://registry.npmjs.org/react/-/react-19.2.7.tgz",
"integrity": "sha512-HNe9WslTbXmFK8o8cmwgAeJFSBvt1bPdHCVKtaaV+WlAN36mpT4hcRpwbf3fY56ar2oIXzsBpOAiIRHAdY0OlQ==",
"license": "MIT",
"engines": {
"node": ">=0.10.0"
}
},
"plugins/plugin-chart-country-map": {
"name": "@superset-ui/plugin-chart-country-map",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3": "^3.5.17",
"d3-array": "^3.2.4",
"prop-types": "^15.8.1"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"react": "^18.3.0"
}
},
"plugins/plugin-chart-country-map/node_modules/d3-array": {
"version": "3.2.4",
"resolved": "https://registry.npmjs.org/d3-array/-/d3-array-3.2.4.tgz",
"integrity": "sha512-tdQAmyA18i4J7wprpYq8ClcxZy3SC31QMeByyCFyRt7BVHdREQZ5lpzoe5mFEYZUWe+oq8HBvk9JjpibyEV4Jg==",
"license": "ISC",
"dependencies": {
"internmap": "1 - 2"
},
"engines": {
"node": ">=12"
}
},
"plugins/plugin-chart-echarts": {
"name": "@superset-ui/plugin-chart-echarts",
"version": "0.20.3",
@@ -44530,6 +44347,79 @@
"sprintf-js": ">= 1.1.1 < 2"
}
},
"plugins/plugin-chart-horizon": {
"name": "@superset-ui/plugin-chart-horizon",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3-array": "^3.2.4",
"d3-scale": "^4.0.2",
"prop-types": "^15.8.1"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"react": "^18.3.0"
}
},
"plugins/plugin-chart-horizon/node_modules/d3-array": {
"version": "3.2.4",
"resolved": "https://registry.npmjs.org/d3-array/-/d3-array-3.2.4.tgz",
"integrity": "sha512-tdQAmyA18i4J7wprpYq8ClcxZy3SC31QMeByyCFyRt7BVHdREQZ5lpzoe5mFEYZUWe+oq8HBvk9JjpibyEV4Jg==",
"license": "ISC",
"dependencies": {
"internmap": "1 - 2"
},
"engines": {
"node": ">=12"
}
},
"plugins/plugin-chart-paired-t-test": {
"name": "@superset-ui/plugin-chart-paired-t-test",
"version": "0.20.3",
"license": "Apache-2.0",
"peerDependencies": {
"@apache-superset/core": "*",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"react": "^18.3.0"
}
},
"plugins/plugin-chart-parallel-coordinates": {
"name": "@superset-ui/plugin-chart-parallel-coordinates",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3v3": "npm:d3@3.5.17",
"prop-types": "^15.8.1"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"react": "^18.3.0"
}
},
"plugins/plugin-chart-partition": {
"name": "@superset-ui/plugin-chart-partition",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3": "^3.5.17",
"d3-hierarchy": "^3.1.2",
"prop-types": "^15.8.1"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"@testing-library/jest-dom": "*",
"@testing-library/react": "^14.0.0",
"react": "^18.3.0",
"react-dom": "^18.3.0"
}
},
"plugins/plugin-chart-pivot-table": {
"name": "@superset-ui/plugin-chart-pivot-table",
"version": "0.20.3",
@@ -44573,6 +44463,23 @@
"react-dom": "^18.3.0"
}
},
"plugins/plugin-chart-rose": {
"name": "@superset-ui/plugin-chart-rose",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3": "^3.5.17",
"nvd3-fork": "^2.0.5",
"prop-types": "^15.8.1"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@emotion/react": "^11.4.1",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"react": "^18.3.0"
}
},
"plugins/plugin-chart-table": {
"name": "@superset-ui/plugin-chart-table",
"version": "0.20.3",
@@ -44638,6 +44545,36 @@
"react": "^18.3.0"
}
},
"plugins/plugin-chart-world-map": {
"name": "@superset-ui/plugin-chart-world-map",
"version": "0.20.3",
"license": "Apache-2.0",
"dependencies": {
"d3": "^3.5.17",
"d3-array": "^3.2.4",
"datamaps": "^0.5.10",
"prop-types": "^15.8.1",
"tinycolor2": "^1.6.0"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"react": "^18.3.0"
}
},
"plugins/plugin-chart-world-map/node_modules/d3-array": {
"version": "3.2.4",
"resolved": "https://registry.npmjs.org/d3-array/-/d3-array-3.2.4.tgz",
"integrity": "sha512-tdQAmyA18i4J7wprpYq8ClcxZy3SC31QMeByyCFyRt7BVHdREQZ5lpzoe5mFEYZUWe+oq8HBvk9JjpibyEV4Jg==",
"license": "ISC",
"dependencies": {
"internmap": "1 - 2"
},
"engines": {
"node": ">=12"
}
},
"plugins/preset-chart-deckgl": {
"name": "@superset-ui/preset-chart-deckgl",
"version": "1.0.0",

View File

@@ -78,6 +78,7 @@
"playwright:debug": "playwright test --debug",
"playwright:report": "playwright show-report",
"docs:screenshots": "playwright test --config=playwright/generators/playwright.config.ts docs/",
"playwright:thumbnails": "CAPTURE_THUMBNAILS=1 playwright test tests/tools/capture-viz-thumbnails.spec.ts --project chromium",
"prettier": "npm run _prettier -- --write",
"prettier-check": "npm run _prettier -- --check",
"prod": "npm run build",
@@ -89,7 +90,7 @@
"test": "cross-env NODE_ENV=test NODE_OPTIONS=\"--max-old-space-size=8192\" jest --max-workers=80% --silent",
"test-loud": "cross-env NODE_ENV=test NODE_OPTIONS=\"--max-old-space-size=8192\" jest --max-workers=80%",
"type": "cross-env NODE_OPTIONS=\"--max-old-space-size=8192\" tsc --noEmit",
"update-maps": "cd plugins/legacy-plugin-chart-country-map/scripts && jupyter nbconvert --to notebook --execute --inplace --allow-errors --ExecutePreprocessor.timeout=1200 'Country Map GeoJSON Generator.ipynb'",
"update-maps": "cd plugins/plugin-chart-country-map/scripts && jupyter nbconvert --to notebook --execute --inplace --allow-errors --ExecutePreprocessor.timeout=1200 'Country Map GeoJSON Generator.ipynb'",
"validate-release": "../RELEASING/validate_this_release.sh"
},
"browserslist": [
@@ -136,16 +137,15 @@
"@scarf/scarf": "^1.4.0",
"@superset-ui/chart-controls": "file:./packages/superset-ui-chart-controls",
"@superset-ui/core": "file:./packages/superset-ui-core",
"@superset-ui/legacy-plugin-chart-calendar": "file:./plugins/legacy-plugin-chart-calendar",
"@superset-ui/legacy-plugin-chart-chord": "file:./plugins/legacy-plugin-chart-chord",
"@superset-ui/legacy-plugin-chart-country-map": "file:./plugins/legacy-plugin-chart-country-map",
"@superset-ui/legacy-plugin-chart-horizon": "file:./plugins/legacy-plugin-chart-horizon",
"@superset-ui/legacy-plugin-chart-paired-t-test": "file:./plugins/legacy-plugin-chart-paired-t-test",
"@superset-ui/legacy-plugin-chart-parallel-coordinates": "file:./plugins/legacy-plugin-chart-parallel-coordinates",
"@superset-ui/legacy-plugin-chart-partition": "file:./plugins/legacy-plugin-chart-partition",
"@superset-ui/legacy-plugin-chart-rose": "file:./plugins/legacy-plugin-chart-rose",
"@superset-ui/legacy-plugin-chart-world-map": "file:./plugins/legacy-plugin-chart-world-map",
"@superset-ui/legacy-preset-chart-nvd3": "file:./plugins/legacy-preset-chart-nvd3",
"@superset-ui/plugin-chart-calendar": "file:./plugins/plugin-chart-calendar",
"@superset-ui/plugin-chart-chord": "file:./plugins/plugin-chart-chord",
"@superset-ui/plugin-chart-country-map": "file:./plugins/plugin-chart-country-map",
"@superset-ui/plugin-chart-horizon": "file:./plugins/plugin-chart-horizon",
"@superset-ui/plugin-chart-paired-t-test": "file:./plugins/plugin-chart-paired-t-test",
"@superset-ui/plugin-chart-parallel-coordinates": "file:./plugins/plugin-chart-parallel-coordinates",
"@superset-ui/plugin-chart-partition": "file:./plugins/plugin-chart-partition",
"@superset-ui/plugin-chart-rose": "file:./plugins/plugin-chart-rose",
"@superset-ui/plugin-chart-world-map": "file:./plugins/plugin-chart-world-map",
"@superset-ui/plugin-chart-ag-grid-table": "file:./plugins/plugin-chart-ag-grid-table",
"@superset-ui/plugin-chart-cartodiagram": "file:./plugins/plugin-chart-cartodiagram",
"@superset-ui/plugin-chart-echarts": "file:./plugins/plugin-chart-echarts",

View File

@@ -104,24 +104,15 @@ export default class ChartClient {
const buildQueryRegistry = getChartBuildQueryRegistry();
if (metaDataRegistry.has(visType)) {
const { useLegacyApi } = metaDataRegistry.get(visType)!;
const buildQuery =
(await buildQueryRegistry.get(visType)) ?? (() => formData);
const requestConfig: RequestConfig = useLegacyApi
? {
endpoint: '/explore_json/',
postPayload: {
form_data: buildQuery(formData),
},
...options,
}
: {
endpoint: '/api/v1/chart/data',
jsonPayload: {
query_context: buildQuery(formData),
},
...options,
};
const requestConfig: RequestConfig = {
endpoint: '/api/v1/chart/data',
jsonPayload: {
query_context: buildQuery(formData),
},
...options,
};
return this.client
.post(requestConfig)

View File

@@ -17,7 +17,7 @@
* under the License.
*/
import { render, waitFor, configure } from '@testing-library/react';
import { render, waitFor, configure, act } from '@testing-library/react';
import '@testing-library/jest-dom';
import StatefulChart from './StatefulChart';
import getChartControlPanelRegistry from '../registries/ChartControlPanelRegistrySingleton';
@@ -67,19 +67,17 @@ beforeEach(() => {
jest.clearAllMocks();
// Setup default registry mocks
(getChartMetadataRegistry as any).mockReturnValue({
get: jest.fn().mockReturnValue({
useLegacyApi: false,
}),
});
jest.mocked(getChartMetadataRegistry).mockReturnValue({
get: jest.fn().mockReturnValue({}),
} as unknown as ReturnType<typeof getChartMetadataRegistry>);
(getChartBuildQueryRegistry as any).mockReturnValue({
jest.mocked(getChartBuildQueryRegistry).mockReturnValue({
get: jest.fn().mockResolvedValue(null),
});
} as unknown as ReturnType<typeof getChartBuildQueryRegistry>);
(getChartControlPanelRegistry as any).mockReturnValue({
jest.mocked(getChartControlPanelRegistry).mockReturnValue({
get: jest.fn().mockReturnValue(null),
});
} as unknown as ReturnType<typeof getChartControlPanelRegistry>);
// Mock ChartClient constructor
// eslint-disable-next-line global-require, @typescript-eslint/no-var-requires
@@ -113,9 +111,9 @@ test('should refetch data when non-renderTrigger control changes', async () => {
],
};
(getChartControlPanelRegistry as any).mockReturnValue({
jest.mocked(getChartControlPanelRegistry).mockReturnValue({
get: jest.fn().mockReturnValue(controlPanelConfig),
});
} as unknown as ReturnType<typeof getChartControlPanelRegistry>);
const { rerender } = render(
<StatefulChart formData={mockFormData} chartType="test_chart" />,
@@ -165,9 +163,9 @@ test('should NOT refetch data when only renderTrigger controls change', async ()
],
};
(getChartControlPanelRegistry as any).mockReturnValue({
jest.mocked(getChartControlPanelRegistry).mockReturnValue({
get: jest.fn().mockReturnValue(controlPanelConfig),
});
} as unknown as ReturnType<typeof getChartControlPanelRegistry>);
const { rerender, getByTestId } = render(
<StatefulChart formData={mockFormData} chartType="test_chart" />,
@@ -201,9 +199,9 @@ test('should NOT refetch data when only renderTrigger controls change', async ()
test('should refetch when control panel config is not available', async () => {
// No control panel config available
(getChartControlPanelRegistry as any).mockReturnValue({
jest.mocked(getChartControlPanelRegistry).mockReturnValue({
get: jest.fn().mockReturnValue(null),
});
} as unknown as ReturnType<typeof getChartControlPanelRegistry>);
const { rerender } = render(
<StatefulChart formData={mockFormData} chartType="test_chart" />,
@@ -245,9 +243,9 @@ test('should refetch when viz_type changes', async () => {
],
};
(getChartControlPanelRegistry as any).mockReturnValue({
jest.mocked(getChartControlPanelRegistry).mockReturnValue({
get: jest.fn().mockReturnValue(controlPanelConfig),
});
} as unknown as ReturnType<typeof getChartControlPanelRegistry>);
const { rerender } = render(
<StatefulChart formData={mockFormData} chartType="test_chart" />,
@@ -299,9 +297,9 @@ test('should handle mixed renderTrigger and non-renderTrigger changes', async ()
],
};
(getChartControlPanelRegistry as any).mockReturnValue({
jest.mocked(getChartControlPanelRegistry).mockReturnValue({
get: jest.fn().mockReturnValue(controlPanelConfig),
});
} as unknown as ReturnType<typeof getChartControlPanelRegistry>);
const { rerender } = render(
<StatefulChart formData={mockFormData} chartType="test_chart" />,
@@ -352,9 +350,9 @@ test('should handle controls with complex structure', async () => {
],
};
(getChartControlPanelRegistry as any).mockReturnValue({
jest.mocked(getChartControlPanelRegistry).mockReturnValue({
get: jest.fn().mockReturnValue(controlPanelConfig),
});
} as unknown as ReturnType<typeof getChartControlPanelRegistry>);
const { rerender, getByTestId } = render(
<StatefulChart formData={mockFormData} chartType="test_chart" />,
@@ -404,11 +402,11 @@ test('should not refetch when formData has not changed', async () => {
test('should handle errors gracefully when accessing registry', async () => {
// Mock registry to throw an error
(getChartControlPanelRegistry as any).mockReturnValue({
jest.mocked(getChartControlPanelRegistry).mockReturnValue({
get: jest.fn().mockImplementation(() => {
throw new Error('Registry error');
}),
});
} as unknown as ReturnType<typeof getChartControlPanelRegistry>);
const { rerender } = render(
<StatefulChart formData={mockFormData} chartType="test_chart" />,
@@ -492,9 +490,9 @@ test('should NOT refetch data when string-based renderTrigger control (zoomable)
],
};
(getChartControlPanelRegistry as any).mockReturnValue({
jest.mocked(getChartControlPanelRegistry).mockReturnValue({
get: jest.fn().mockReturnValue(controlPanelConfig),
});
} as unknown as ReturnType<typeof getChartControlPanelRegistry>);
const formDataWithZoom = {
...mockFormData,
@@ -542,9 +540,9 @@ test('should NOT refetch data when other string-based renderTrigger controls cha
],
};
(getChartControlPanelRegistry as any).mockReturnValue({
jest.mocked(getChartControlPanelRegistry).mockReturnValue({
get: jest.fn().mockReturnValue(controlPanelConfig),
});
} as unknown as ReturnType<typeof getChartControlPanelRegistry>);
const { rerender, getByTestId } = render(
<StatefulChart formData={mockFormData} chartType="test_chart" />,
@@ -585,9 +583,9 @@ test('should refetch when string control is NOT in RENDER_TRIGGER_SHARED_CONTROL
],
};
(getChartControlPanelRegistry as any).mockReturnValue({
jest.mocked(getChartControlPanelRegistry).mockReturnValue({
get: jest.fn().mockReturnValue(controlPanelConfig),
});
} as unknown as ReturnType<typeof getChartControlPanelRegistry>);
const { rerender } = render(
<StatefulChart formData={mockFormData} chartType="test_chart" />,
@@ -631,9 +629,9 @@ test('should handle mixed string and object controls correctly', async () => {
],
};
(getChartControlPanelRegistry as any).mockReturnValue({
jest.mocked(getChartControlPanelRegistry).mockReturnValue({
get: jest.fn().mockReturnValue(controlPanelConfig),
});
} as unknown as ReturnType<typeof getChartControlPanelRegistry>);
const formDataWithControls = {
...mockFormData,
@@ -687,9 +685,9 @@ test('should refetch when mixing renderTrigger string control with non-renderTri
],
};
(getChartControlPanelRegistry as any).mockReturnValue({
jest.mocked(getChartControlPanelRegistry).mockReturnValue({
get: jest.fn().mockReturnValue(controlPanelConfig),
});
} as unknown as ReturnType<typeof getChartControlPanelRegistry>);
const formDataWithZoom = {
...mockFormData,
@@ -720,6 +718,397 @@ test('should refetch when mixing renderTrigger string control with non-renderTri
});
});
test('resolves async (202) responses via the injected handleAsyncChartData hook', async () => {
const asyncJob = {
channel_id: 'c1',
job_id: 'j1',
status: 'running',
result_url: '/api/v1/chart/data/abc',
};
mockChartClient.client.post.mockResolvedValue({
response: { status: 202 } as Response,
json: asyncJob,
});
const handleAsyncChartData = jest
.fn()
.mockResolvedValue([{ data: 'async result' }]);
const { getByTestId } = render(
<StatefulChart
formData={mockFormData}
chartType="test_chart"
hooks={{ handleAsyncChartData }}
/>,
);
await waitFor(() => {
expect(handleAsyncChartData).toHaveBeenCalledTimes(1);
});
// Delegates the raw response + job metadata (and the abort signal)
expect(handleAsyncChartData).toHaveBeenCalledWith(
{ status: 202 },
asyncJob,
expect.any(AbortSignal),
);
// Chart renders once the async data resolves
await waitFor(() => {
expect(getByTestId('super-chart')).toBeInTheDocument();
});
});
test('errors on async (202) response when no async handler is provided', async () => {
mockChartClient.client.post.mockResolvedValue({
response: { status: 202 } as Response,
json: { job_id: 'j1', channel_id: 'c1', status: 'running' },
});
const onError = jest.fn();
const { findByText } = render(
<StatefulChart
formData={mockFormData}
chartType="test_chart"
onError={onError}
/>,
);
// Fails loudly instead of rendering the job metadata as empty data
expect(await findByText(/async handler/i)).toBeInTheDocument();
await waitFor(() => {
expect(onError).toHaveBeenCalledTimes(1);
});
});
test('renders synchronous (200) responses that include a response object', async () => {
mockChartClient.client.post.mockResolvedValue({
response: { status: 200 } as Response,
json: [{ result: [{ data: 'sync result' }] }],
});
const { getByTestId } = render(
<StatefulChart formData={mockFormData} chartType="test_chart" />,
);
await waitFor(() => {
expect(getByTestId('super-chart')).toBeInTheDocument();
});
// Synchronous path: no async handler needed, single request
expect(mockChartClient.client.post).toHaveBeenCalledTimes(1);
});
test('does not apply a superseded async response over a newer one', async () => {
mockChartClient.client.post.mockResolvedValue({
response: { status: 202 } as Response,
json: { job_id: 'j', channel_id: 'c' },
});
let resolveFirst: (data: unknown) => void = () => {};
let resolveSecond: (data: unknown) => void = () => {};
const handleAsyncChartData = jest
.fn()
.mockImplementationOnce(
() =>
new Promise(resolve => {
resolveFirst = resolve;
}),
)
.mockImplementationOnce(
() =>
new Promise(resolve => {
resolveSecond = resolve;
}),
);
const onLoad = jest.fn();
const { rerender } = render(
<StatefulChart
formData={mockFormData}
chartType="test_chart"
hooks={{ handleAsyncChartData }}
onLoad={onLoad}
/>,
);
await waitFor(() => {
expect(handleAsyncChartData).toHaveBeenCalledTimes(1);
});
// A newer request supersedes the first (viz_type change forces a refetch)
const newFormData = { ...mockFormData, viz_type: 'different_chart' };
rerender(
<StatefulChart
formData={newFormData}
chartType="different_chart"
hooks={{ handleAsyncChartData }}
onLoad={onLoad}
/>,
);
await waitFor(() => {
expect(handleAsyncChartData).toHaveBeenCalledTimes(2);
});
// Resolve the newer request first, then the stale one
await act(async () => {
resolveSecond([{ data: 'B' }]);
});
await act(async () => {
resolveFirst([{ data: 'A' }]);
});
await waitFor(() => {
expect(onLoad).toHaveBeenCalledWith([{ data: 'B' }]);
});
// The stale (superseded) response must not overwrite the newer one
expect(onLoad).not.toHaveBeenCalledWith([{ data: 'A' }]);
expect(onLoad).toHaveBeenCalledTimes(1);
});
test('preserves the detailed message from an async (array) rejection', async () => {
mockChartClient.client.post.mockResolvedValue({
response: { status: 202 } as Response,
json: { job_id: 'j', channel_id: 'c' },
});
const handleAsyncChartData = jest
.fn()
.mockRejectedValue([{ error: 'Async query failed: table not found' }]);
const onError = jest.fn();
const { findByText } = render(
<StatefulChart
formData={mockFormData}
chartType="test_chart"
hooks={{ handleAsyncChartData }}
onError={onError}
/>,
);
// The detailed message survives instead of collapsing to the generic one
expect(await findByText(/table not found/i)).toBeInTheDocument();
await waitFor(() => {
expect(onError).toHaveBeenCalledTimes(1);
expect(onError.mock.calls[0][0].message).toContain('table not found');
});
});
test('refetches with the latest formData rather than the initial props', async () => {
mockChartClient.client.post.mockResolvedValue({
response: { status: 200 } as Response,
json: [{ result: [{ data: 'x' }] }],
});
const { rerender } = render(
<StatefulChart
formData={{ ...mockFormData, metrics: ['metric_v1'] }}
chartType="test_chart"
/>,
);
await waitFor(() => {
expect(mockChartClient.client.post).toHaveBeenCalledTimes(1);
});
// Change a data-affecting control -> triggers a refetch
rerender(
<StatefulChart
formData={{ ...mockFormData, metrics: ['metric_v2'] }}
chartType="test_chart"
/>,
);
await waitFor(() => {
expect(mockChartClient.client.post).toHaveBeenCalledTimes(2);
});
// The second request must carry the updated formData, not the initial props
const secondRequestConfig = mockChartClient.client.post.mock.calls[1][0];
expect(JSON.stringify(secondRequestConfig)).toContain('metric_v2');
expect(JSON.stringify(secondRequestConfig)).not.toContain('metric_v1');
});
test('does not revert a render-only change when a slow async request resolves', async () => {
mockChartClient.client.post.mockResolvedValue({
response: { status: 202 } as Response,
json: { job_id: 'j', channel_id: 'c' },
});
// color_scheme is a renderTrigger control -> its change does not refetch
jest.mocked(getChartControlPanelRegistry).mockReturnValue({
get: jest.fn().mockReturnValue({
controlPanelSections: [
{
controlSetRows: [
[{ name: 'color_scheme', config: { renderTrigger: true } }],
],
},
],
}),
} as unknown as ReturnType<typeof getChartControlPanelRegistry>);
let resolveAsync: (data: unknown) => void = () => {};
const handleAsyncChartData = jest.fn(
() =>
new Promise(resolve => {
resolveAsync = resolve;
}),
);
const { rerender, getByTestId } = render(
<StatefulChart
formData={{ ...mockFormData, color_scheme: 'scheme_one' }}
chartType="test_chart"
hooks={{ handleAsyncChartData }}
/>,
);
await waitFor(() => {
expect(handleAsyncChartData).toHaveBeenCalledTimes(1);
});
// Render-only change while the async request is still pending (no refetch)
rerender(
<StatefulChart
formData={{ ...mockFormData, color_scheme: 'scheme_two' }}
chartType="test_chart"
hooks={{ handleAsyncChartData }}
/>,
);
expect(handleAsyncChartData).toHaveBeenCalledTimes(1);
// The stale request resolves; it must not revert color_scheme back
await act(async () => {
resolveAsync([{ data: 'd' }]);
});
await waitFor(() => {
expect(getByTestId('super-chart')).toHaveTextContent('scheme_two');
});
expect(getByTestId('super-chart')).not.toHaveTextContent('scheme_one');
});
test('passes an abort signal to the async handler and aborts it on unmount', async () => {
mockChartClient.client.post.mockResolvedValue({
response: { status: 202 } as Response,
json: { job_id: 'j', channel_id: 'c' },
});
// Typed with a rest param so mock.calls is indexable (the 4th arg is the signal)
const handleAsyncChartData = jest.fn(
(..._args: unknown[]) => new Promise<never>(() => {}), // never resolves
);
const { unmount } = render(
<StatefulChart
formData={mockFormData}
chartType="test_chart"
hooks={{ handleAsyncChartData }}
/>,
);
await waitFor(() => {
expect(handleAsyncChartData).toHaveBeenCalledTimes(1);
});
const signal = handleAsyncChartData.mock.calls[0][2] as AbortSignal;
expect(signal).toBeInstanceOf(AbortSignal);
expect(signal.aborted).toBe(false);
// Unmounting aborts the signal so a signal-aware handler can stop polling
unmount();
expect(signal.aborted).toBe(true);
});
test('suppresses stale error state from a superseded request', async () => {
mockChartClient.client.post.mockResolvedValue({
response: { status: 202 } as Response,
json: { job_id: 'j', channel_id: 'c' },
});
let rejectFirst: (err: unknown) => void = () => {};
const handleAsyncChartData = jest
.fn()
.mockImplementationOnce(
() =>
new Promise((_resolve, reject) => {
rejectFirst = reject;
}),
)
.mockImplementationOnce(() => new Promise(() => {})); // newer request stays pending
const onError = jest.fn();
const { rerender } = render(
<StatefulChart
formData={mockFormData}
chartType="test_chart"
hooks={{ handleAsyncChartData }}
onError={onError}
/>,
);
await waitFor(() => {
expect(handleAsyncChartData).toHaveBeenCalledTimes(1);
});
// Supersede the first request (aborts its controller)
rerender(
<StatefulChart
formData={{ ...mockFormData, viz_type: 'different_chart' }}
chartType="different_chart"
hooks={{ handleAsyncChartData }}
onError={onError}
/>,
);
await waitFor(() => {
expect(handleAsyncChartData).toHaveBeenCalledTimes(2);
});
// The stale request now fails; its error must not surface
await act(async () => {
rejectFirst(new Error('stale failure'));
});
expect(onError).not.toHaveBeenCalled();
});
test('does not publish stale data when switching from chartId to formData mode', async () => {
mockChartClient.loadFormData.mockResolvedValue({ ...mockFormData });
mockChartClient.client.post.mockResolvedValue({
response: { status: 202 } as Response,
json: { job_id: 'j', channel_id: 'c' },
});
let resolveFirst: (data: unknown) => void = () => {};
const handleAsyncChartData = jest
.fn()
.mockImplementationOnce(
() =>
new Promise(resolve => {
resolveFirst = resolve;
}),
)
.mockImplementationOnce(() => new Promise(() => {}));
const onLoad = jest.fn();
// Start in chartId mode
const { rerender } = render(
<StatefulChart
chartId={1}
chartType="test_chart"
hooks={{ handleAsyncChartData }}
onLoad={onLoad}
/>,
);
await waitFor(() => {
expect(handleAsyncChartData).toHaveBeenCalledTimes(1);
});
// Switch to direct-formData mode
rerender(
<StatefulChart
formData={{ ...mockFormData, metrics: ['m'] }}
chartType="test_chart"
hooks={{ handleAsyncChartData }}
onLoad={onLoad}
/>,
);
await waitFor(() => {
expect(handleAsyncChartData).toHaveBeenCalledTimes(2);
});
// The stale chartId-mode request resolves; its data must not be published
await act(async () => {
resolveFirst([{ data: 'stale' }]);
});
expect(onLoad).not.toHaveBeenCalledWith([{ data: 'stale' }]);
});
test('should display error message when HTTP request fails with Response object', async () => {
const errorBody = JSON.stringify({ message: 'Error: division by zero' });
const mockResponse = new Response(errorBody, {

View File

@@ -18,21 +18,22 @@
*/
import { useState, useEffect, useRef, useCallback } from 'react';
import { isEqual } from 'lodash';
import { ParentSize } from '@visx/responsive';
import { t } from '@apache-superset/core/translation';
import {
QueryFormData,
QueryData,
JsonObject,
SupersetClientInterface,
buildQueryContext,
RequestConfig,
getClientErrorObject,
ensureIsArray,
} from '../..';
import type { HandlerFunction } from '../types/Base';
import { Loading } from '../../components/Loading';
import ChartClient from '../clients/ChartClient';
import getChartBuildQueryRegistry from '../registries/ChartBuildQueryRegistrySingleton';
import getChartMetadataRegistry from '../registries/ChartMetadataRegistrySingleton';
import getChartControlPanelRegistry from '../registries/ChartControlPanelRegistrySingleton';
import SuperChart from './SuperChart';
@@ -189,6 +190,12 @@ export default function StatefulChart(props: StatefulChartProps) {
const chartClientRef = useRef<ChartClient>();
const abortControllerRef = useRef<AbortController>();
// fetchData is memoized with an empty dep list, so it would otherwise close
// over the first render's props. Keep the latest props in a ref so refetches
// (triggered by updated filters/formData/overrides) use current values.
const propsRef = useRef(props);
propsRef.current = props;
// Initialize chart client
if (!chartClientRef.current) {
chartClientRef.current = new ChartClient({ client: props.client });
@@ -199,20 +206,48 @@ export default function StatefulChart(props: StatefulChartProps) {
chartId,
formData: propsFormData,
formDataOverrides,
onError,
onLoad,
chartType,
force,
timeout,
} = props;
hooks,
} = propsRef.current;
// Cancel any in-flight requests
if (abortControllerRef.current) {
abortControllerRef.current.abort();
}
// Create new abort controller
abortControllerRef.current = new AbortController();
// Create new abort controller (kept in a local so we can detect when this
// request has been superseded by a newer one, even across async awaits).
const controller = new AbortController();
abortControllerRef.current = controller;
// A request is superseded if it was aborted, or if the props changed in a
// data-affecting way since it began - including switching between chartId
// and direct-formData modes. Props are captured during render but the abort
// happens in a passive effect, so the abort signal alone can let a stale
// success or error slip through in the render->effect gap. This mirrors the
// effect's own refetch decision; render-only changes are intentionally not
// treated as superseding.
const isSuperseded = () => {
if (controller.signal.aborted) {
return true;
}
const latest = propsRef.current;
const vizTypeForCompare = latest.formData?.viz_type || latest.chartType;
return (
latest.chartId !== chartId ||
// Deep compare overrides: callers commonly pass a fresh object with the
// same contents each render, which should not count as superseding.
!isEqual(latest.formDataOverrides, formDataOverrides) ||
latest.force !== force ||
Boolean(propsFormData) !== Boolean(latest.formData) ||
(!!propsFormData &&
!!latest.formData &&
latest.formData !== propsFormData &&
shouldRefetchData(propsFormData, latest.formData, vizTypeForCompare))
);
};
setStatus('loading');
setError(undefined);
@@ -224,7 +259,7 @@ export default function StatefulChart(props: StatefulChartProps) {
// Load formData from chartId
finalFormData = await chartClientRef.current!.loadFormData(
{ sliceId: chartId },
{ signal: abortControllerRef.current.signal } as RequestConfig,
{ signal: controller.signal } as RequestConfig,
);
} else if (propsFormData) {
// Use provided formData
@@ -245,9 +280,6 @@ export default function StatefulChart(props: StatefulChartProps) {
}
finalFormData.viz_type = vizType;
// Get chart metadata
const { useLegacyApi } = getChartMetadataRegistry().get(vizType) || {};
// Build query using the chart's buildQuery function
const buildQuery = await getChartBuildQueryRegistry().get(vizType);
let queryContext;
@@ -259,65 +291,141 @@ export default function StatefulChart(props: StatefulChartProps) {
queryContext = buildQueryContext(finalFormData);
}
// Ensure query_context is properly formatted for new API
if (!useLegacyApi && !queryContext.queries) {
// Ensure query_context is properly formatted for the API
if (!queryContext.queries) {
queryContext = { queries: [queryContext] };
}
const endpoint = useLegacyApi ? '/explore_json/' : '/api/v1/chart/data';
const requestConfig: RequestConfig = {
endpoint,
signal: abortControllerRef.current.signal,
endpoint: '/api/v1/chart/data',
signal: controller.signal,
...(timeout && { timeout: timeout * 1000 }),
};
if (useLegacyApi) {
requestConfig.postPayload = {
form_data: {
...finalFormData,
...(force && { force: true }),
},
};
} else {
requestConfig.jsonPayload = {
jsonPayload: {
...queryContext,
...(force && { force: true }),
};
}
},
};
const response = await chartClientRef.current!.client.post(requestConfig);
let responseData = Array.isArray(response.json)
? response.json
: [response.json];
const clientResponse =
await chartClientRef.current!.client.post(requestConfig);
// Handle the nested result structure from the new API
if (!useLegacyApi && responseData[0]?.result) {
responseData = responseData[0].result;
}
setStatus('loaded');
setData(responseData);
setFormData(finalFormData);
if (onLoad) {
onLoad(responseData);
}
} catch (err) {
// Ignore abort errors
if ((err as Error).name === 'AbortError') {
// A newer request may have started while the POST was in flight; discard
// this stale response so it can't overwrite the newer chart data.
if (isSuperseded()) {
return;
}
const parsedError = await getClientErrorObject(
err as Parameters<typeof getClientErrorObject>[0],
);
const errorMessage =
parsedError.error || parsedError.message || 'An error occurred';
const rawResponse = clientResponse.response as Response | undefined;
let responseData: QueryData[];
if (rawResponse?.status === 202) {
// With GLOBAL_ASYNC_QUERIES the query is dispatched to a Celery worker
// and the 202 body is job metadata (channel_id, job_id, result_url),
// not chart data. Delegate to the injected handler, which polls the
// async event channel and resolves the cached results. Without a
// handler we fail loudly rather than rendering the job metadata as if
// it were an (empty) result set.
if (!hooks?.handleAsyncChartData) {
throw new Error(
'Received an async chart data response (HTTP 202) but no async ' +
'handler was provided, so results cannot be retrieved. Wire up ' +
'the async handler or disable GLOBAL_ASYNC_QUERIES for this chart.',
);
}
responseData = ensureIsArray(
await hooks.handleAsyncChartData(
rawResponse,
clientResponse.json as JsonObject,
controller.signal,
),
);
// Async results can resolve well after a newer request began polling.
if (isSuperseded()) {
return;
}
} else {
const rows = (
Array.isArray(clientResponse.json)
? clientResponse.json
: [clientResponse.json]
) as JsonObject[];
// Handle the nested result structure from the API
responseData = (rows[0]?.result ? rows[0].result : rows) as QueryData[];
}
// Don't pair this request's data with newer props or fire a stale onLoad
// if it has been superseded (see isSuperseded).
if (isSuperseded()) {
return;
}
const latestProps = propsRef.current;
setStatus('loaded');
setData(responseData);
// Render the resolved data with the latest formData so a render-only
// change made while the request was in flight isn't reverted.
setFormData(
latestProps.formData
? {
...latestProps.formData,
...latestProps.formDataOverrides,
viz_type: finalFormData.viz_type,
}
: finalFormData,
);
// Read onLoad from the latest props (like setFormData above) so a stale
// callback captured at request start isn't invoked.
if (latestProps.onLoad) {
latestProps.onLoad(responseData);
}
} catch (err) {
// Ignore aborted requests, whether they threw AbortError or were
// superseded by a newer request (including the render->effect gap).
if ((err as Error)?.name === 'AbortError' || isSuperseded()) {
return;
}
// waitForAsyncData rejects with an array of already-parsed client-error
// objects; unwrap the first element so its detailed message survives.
const rawError = Array.isArray(err) ? err[0] : err;
let errorMessage: string | undefined;
if (
rawError &&
typeof rawError === 'object' &&
!(rawError instanceof Error) &&
!(rawError instanceof Response) &&
typeof (rawError as { error?: unknown }).error === 'string'
) {
// Already a parsed client-error object (e.g. from the async handler);
// getClientErrorObject would discard its `error` field, so read it here.
const parsed = rawError as { error?: string; message?: string };
errorMessage = parsed.error || parsed.message;
} else {
const parsedError = await getClientErrorObject(
rawError as Parameters<typeof getClientErrorObject>[0],
);
errorMessage = parsedError.error || parsedError.message;
}
const errorObj = new Error(errorMessage || 'An error occurred');
// The request may have been superseded while its error response was being
// parsed above (or in the render->effect gap before its abort ran); don't
// set stale error state or call onError in that case.
if (isSuperseded()) {
return;
}
const errorObj = new Error(errorMessage);
setStatus('error');
setError(errorObj);
// Read onError from the latest props so a stale callback captured at
// request start isn't invoked.
const { onError } = propsRef.current;
if (onError) {
onError(errorObj);
}
@@ -481,7 +589,7 @@ export default function StatefulChart(props: StatefulChartProps) {
enableNoResults={enableNoResults}
noResults={NoDataComponent && <NoDataComponent />}
onRenderSuccess={onRenderSuccess}
onRenderFailure={onRenderFailure as HandlerFunction | undefined}
onRenderFailure={onRenderFailure}
hooks={hooks}
/>
);

View File

@@ -40,7 +40,6 @@ export interface ChartMetadataConfig {
supportedAnnotationTypes?: string[];
thumbnail: string;
thumbnailDark?: string;
useLegacyApi?: boolean;
behaviors?: Behavior[];
exampleGallery?: ExampleImage[];
tags?: string[];
@@ -75,8 +74,6 @@ export default class ChartMetadata {
thumbnailDark?: string;
useLegacyApi: boolean;
behaviors: Behavior[];
datasourceCount: number;
@@ -112,7 +109,6 @@ export default class ChartMetadata {
supportedAnnotationTypes = [],
thumbnail,
thumbnailDark,
useLegacyApi = false,
behaviors = [],
datasourceCount = 1,
enableNoResults = true,
@@ -144,7 +140,6 @@ export default class ChartMetadata {
this.supportedAnnotationTypes = supportedAnnotationTypes;
this.thumbnail = thumbnail;
this.thumbnailDark = thumbnailDark;
this.useLegacyApi = useLegacyApi;
this.behaviors = behaviors;
this.datasourceCount = datasourceCount;
this.enableNoResults = enableNoResults;

View File

@@ -66,6 +66,17 @@ type Hooks = {
setTooltip?: HandlerFunction;
/* handle legend scroll changes */
onLegendScroll?: HandlerFunction;
/**
* Resolve an async chart-data response (HTTP 202 from GLOBAL_ASYNC_QUERIES).
* Injected by the app so components in this package (e.g. Matrixify's
* StatefulChart) can await async results without importing app-level
* async-event middleware. Returns the resolved query results.
*/
handleAsyncChartData?: (
response: Response,
json: JsonObject,
signal?: AbortSignal,
) => Promise<QueryData[]> | QueryData[];
} & PlainObject;
/**

View File

@@ -160,42 +160,6 @@ describe('ChartClient', () => {
datasource: '1__table',
}),
).rejects.toEqual(new Error('Unknown chart type: rainbow_3d_pie')));
test('fetches data from the legacy API if ChartMetadata has useLegacyApi=true,', () => {
// note legacy charts do not register a buildQuery function in the registry
getChartMetadataRegistry().registerValue(
'word_cloud_legacy',
new ChartMetadata({
name: 'Legacy Word Cloud',
thumbnail: '.png',
useLegacyApi: true,
}),
);
fetchMock.post('glob:*/api/v1/chart/data', () =>
Promise.reject(new Error('Unexpected all to v1 API')),
);
// post `Superset.route_base = ""`, the legacy endpoint
// collapsed from `/superset/explore_json/` to `/explore_json/`.
fetchMock.post('glob:*/explore_json/', {
field1: 'abc',
field2: 'def',
});
return expect(
chartClient.loadQueryData({
granularity: 'minute',
viz_type: 'word_cloud_legacy',
datasource: '1__table',
}),
).resolves.toEqual([
{
field1: 'abc',
field2: 'def',
},
]);
});
});
describe('.loadDatasource(datasourceKey, options)', () => {

View File

@@ -38,6 +38,14 @@
*
* NOTE: the embedded suite only runs when the embedded SDK bundle is built and
* INCLUDE_EMBEDDED=true (CI sets both). It is skipped otherwise.
*
* NOTE: the embedded project runs with admin storageState, and the session
* cookie the iframe ends up with is racy: the /embedded/<uuid> response
* rotates it to an anonymous session while the SDK's parallel csrf and
* guest-token fetches rewrite the admin one, so chart data requests are
* evaluated as either admin or guest depending on which response lands last.
* Fixture charts must therefore hold up under GUEST evaluation — see the
* query_context note below — or the suite only passes when admin wins.
*/
import { test, expect, Browser, BrowserContext, Page } from '@playwright/test';
import { createServer, IncomingMessage, ServerResponse, Server } from 'http';
@@ -182,12 +190,43 @@ test.describe('Embedded Pivot Table collapse state (#33406)', () => {
row_limit: 1000,
order_desc: true,
};
// Charts saved through Explore always persist a query_context alongside
// params. Store one here too: guest (embedded) requests are validated
// against the stored chart, and a params-only chart makes the guest
// payload look tampered (its query `columns` aren't found on the chart),
// failing every chart data request with a 403.
const queryContext = {
datasource: { id: datasetId, type: 'table' },
force: false,
queries: [
{
filters: [],
extras: { having: '', where: '' },
applied_time_extras: {},
columns: ['state', 'name'],
metrics: ['count'],
orderby: [['count', false]],
annotation_layers: [],
row_limit: 1000,
series_limit: 0,
order_desc: true,
url_params: {},
custom_params: {},
custom_form_data: {},
},
],
form_data: params,
result_format: 'json',
result_type: 'full',
};
const chartResp = await apiPost(setupPage, 'api/v1/chart/', {
slice_name: `pivot_collapse_repro_${Date.now()}`,
viz_type: 'pivot_table_v2',
datasource_id: datasetId,
datasource_type: 'table',
params: JSON.stringify(params),
query_context: JSON.stringify(queryContext),
query_context_generation: true,
});
chartId = (await chartResp.json()).id;

View File

@@ -0,0 +1,461 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
/**
* Crawls every dashboard on the target instance and refreshes viz-picker
* gallery thumbnails from live example charts.
*
* This is a maintenance tool, not a test: charts are DISCOVERED via the
* API (dashboards -> charts), so it keeps working as example dashboards
* evolve. For each viz type found, one representative chart is rendered
* standalone at 512x512 and the plugin's `thumbnail.png` is overwritten.
* The only static piece is the viz type -> image path map below, which
* changes when plugins are added or moved — never when examples change.
* Viz types found on dashboards but missing from the map are reported at
* the end without failing the run.
*
* It only runs when CAPTURE_THUMBNAILS=1 is set, so the regular
* Playwright suites never execute it.
*
* Usage (requires a running Superset with examples loaded):
* npm run playwright:thumbnails
* VIZ_TYPES=bullet,rose npm run playwright:thumbnails # subset
*
* Notes:
* - Dark variants (`thumbnail-dark.png`, `example-dark.jpg`) are captured
* via prefers-color-scheme emulation whenever the sibling file exists;
* if the app ignores the emulation (dark theming disabled) the dark
* file is left untouched.
* - New gallery images (e.g. the Line percent-change example) still need
* to be registered in the plugin's metadata before they render in the
* gallery; the capture logs a reminder for any new image.
*/
import * as fs from 'fs';
import * as path from 'path';
import { test, expect, Page } from '@playwright/test';
const THUMBNAIL_SIZE = 512;
const RENDERED_CHART_SELECTOR =
'[data-test="chart-container"]:has(svg, canvas, table):not(:has([data-test="loading-indicator"]))';
/**
* Charts that render plain markup — no svg/canvas/table for the rendered
* selector to key on — get a looser signal plus a longer settle.
*/
const TEXT_ONLY_VIZ_TYPES = new Set([
'ag-grid-table',
'big_number_total',
'handlebars',
'pop_kpi',
]);
/**
* Hover this element just before the screenshot, so charts whose identity
* benefits from an interaction (a visible tooltip) capture mid-hover.
*/
const HOVER_BEFORE_CAPTURE: Record<string, string> = {
cal_heatmap: '[data-test="chart-container"] svg rect[class*=" r"]',
};
const TEXT_RENDERED_CHART_SELECTOR =
'[data-test="chart-container"]:not(:has([data-test="loading-indicator"]))';
/** superset-frontend root, resolved from this spec's location. */
const FRONTEND_ROOT = path.resolve(__dirname, '..', '..', '..');
const ECHARTS = 'plugins/plugin-chart-echarts/src';
const DECKGL = 'plugins/preset-chart-deckgl/src/layers';
/**
* Where each viz type's gallery thumbnail lives, relative to
* superset-frontend. One entry per registered viz type with a thumbnail;
* add a line when a new plugin ships.
*/
const VIZ_TYPE_THUMBNAILS: Record<string, string> = {
'ag-grid-table':
'plugins/plugin-chart-ag-grid-table/src/images/thumbnail.png',
big_number: `${ECHARTS}/BigNumber/BigNumberWithTrendline/images/thumbnail.png`,
big_number_total: `${ECHARTS}/BigNumber/BigNumberTotal/images/thumbnail.png`,
box_plot: `${ECHARTS}/BoxPlot/images/thumbnail.png`,
bubble_v2: `${ECHARTS}/Bubble/images/thumbnail.png`,
bullet: `${ECHARTS}/Bullet/images/thumbnail.png`,
cal_heatmap: 'plugins/plugin-chart-calendar/src/images/thumbnail.png',
cartodiagram: 'plugins/plugin-chart-cartodiagram/src/images/thumbnail.png',
chord: 'plugins/plugin-chart-chord/src/images/thumbnail.png',
country_map: 'plugins/plugin-chart-country-map/src/images/thumbnail.png',
deck_arc: `${DECKGL}/Arc/images/thumbnail.png`,
deck_contour: `${DECKGL}/Contour/images/thumbnail.png`,
deck_geojson: `${DECKGL}/Geojson/images/thumbnail.png`,
deck_grid: `${DECKGL}/Grid/images/thumbnail.png`,
deck_heatmap: `${DECKGL}/Heatmap/images/thumbnail.png`,
deck_hex: `${DECKGL}/Hex/images/thumbnail.png`,
deck_multi: 'plugins/preset-chart-deckgl/src/Multi/images/thumbnail.png',
deck_path: `${DECKGL}/Path/images/thumbnail.png`,
deck_polygon: `${DECKGL}/Polygon/images/thumbnail.png`,
deck_scatter: `${DECKGL}/Scatter/images/thumbnail.png`,
deck_screengrid: `${DECKGL}/Screengrid/images/thumbnail.png`,
echarts_area: `${ECHARTS}/Timeseries/Area/images/thumbnail.png`,
echarts_timeseries: `${ECHARTS}/Timeseries/images/thumbnail.png`,
echarts_timeseries_bar: `${ECHARTS}/Timeseries/Regular/Bar/images/thumbnail.png`,
echarts_timeseries_line: `${ECHARTS}/Timeseries/Regular/Line/images/thumbnail.png`,
echarts_timeseries_scatter: `${ECHARTS}/Timeseries/Regular/Scatter/images/thumbnail.png`,
echarts_timeseries_smooth: `${ECHARTS}/Timeseries/Regular/SmoothLine/images/thumbnail.png`,
echarts_timeseries_step: `${ECHARTS}/Timeseries/Step/images/thumbnail.png`,
funnel: `${ECHARTS}/Funnel/images/thumbnail.png`,
gantt_chart: `${ECHARTS}/Gantt/images/thumbnail.png`,
gauge_chart: `${ECHARTS}/Gauge/images/thumbnail.png`,
graph_chart: `${ECHARTS}/Graph/images/thumbnail.png`,
// handlebars intentionally unmapped: its generic logo represents the
// template-anything nature of the chart better than any one example.
heatmap_v2: `${ECHARTS}/Heatmap/images/thumbnail.png`,
histogram_v2: `${ECHARTS}/Histogram/images/thumbnail.png`,
horizon: 'plugins/plugin-chart-horizon/src/images/thumbnail.png',
mixed_timeseries: `${ECHARTS}/MixedTimeseries/images/thumbnail.png`,
paired_ttest: 'plugins/plugin-chart-paired-t-test/src/images/thumbnail.png',
para: 'plugins/plugin-chart-parallel-coordinates/src/images/thumbnail.png',
partition: 'plugins/plugin-chart-partition/src/images/thumbnail.png',
pie: `${ECHARTS}/Pie/images/thumbnail.png`,
pivot_table_v2: 'plugins/plugin-chart-pivot-table/src/images/thumbnail.png',
point_cluster_map:
'plugins/plugin-chart-point-cluster-map/src/images/thumbnail.png',
pop_kpi: `${ECHARTS}/BigNumber/BigNumberPeriodOverPeriod/images/thumbnail.png`,
radar: `${ECHARTS}/Radar/images/thumbnail.png`,
rose: 'plugins/plugin-chart-rose/src/images/thumbnail.png',
sankey_v2: `${ECHARTS}/Sankey/images/thumbnail.png`,
sunburst_v2: `${ECHARTS}/Sunburst/images/thumbnail.png`,
table: 'plugins/plugin-chart-table/src/images/thumbnail.png',
time_pivot: `${ECHARTS}/TimePivot/images/thumbnail.png`,
time_table: 'src/visualizations/TimeTable/images/thumbnail.png',
tree_chart: `${ECHARTS}/Tree/images/thumbnail.png`,
treemap_v2: `${ECHARTS}/Treemap/images/thumbnail.png`,
waterfall: `${ECHARTS}/Waterfall/images/thumbnail.png`,
word_cloud: 'plugins/plugin-chart-word-cloud/src/images/thumbnail.png',
world_map: 'plugins/plugin-chart-world-map/src/images/thumbnail.png',
};
/**
* When several example charts share a viz type, prefer these slices over
* the default alphabetically-first pick. Missing slices fall back to the
* default, so stale entries degrade gracefully.
*/
const PREFERRED_SLICES: Record<string, string> = {
big_number: 'Sales Year over Year',
bubble_v2: 'Life Expectancy VS Rural %',
bullet: 'Total Sales Bullet',
cal_heatmap: 'Sales Calendar Heatmap',
chord: 'Product Line Chord',
echarts_area: 'Sales Stacked Area',
echarts_timeseries_bar: 'Sales Stacked Bars',
echarts_timeseries_line: 'Monthly Sales Line',
echarts_timeseries_smooth: 'Monthly Sales Smooth',
echarts_timeseries_step: 'Quarterly Sales Steps',
funnel: 'Population Funnel',
gauge_chart: 'Rural Population Gauge',
heatmap_v2: 'Sales Grid Heatmap',
histogram_v2: 'Life Expectancy Histogram',
mixed_timeseries: 'Sales Mixed Chart',
paired_ttest: 'Population Paired t-Test',
partition: 'Population Partition',
pie: 'Product Line Donut',
pivot_table_v2: 'Sales Pivot Highlights',
radar: 'Game Sales Radar',
rose: 'Population Nightingale Rose',
sunburst_v2: 'Population Sunburst',
table: 'Sales Summary Table',
time_pivot: 'Sales Period Pivot',
time_table: 'Product Line Time Table',
treemap_v2: 'Population Treemap',
waterfall: 'Monthly Sales Waterfall',
};
/** Gallery example images use a wide aspect, matching the existing art. */
const EXAMPLE_WIDTH = 800;
const EXAMPLE_HEIGHT = 460;
interface ExtraCapture {
sliceName: string;
output: string;
width: number;
height: number;
}
/**
* Extra captures beyond the per-viz-type thumbnail: gallery example
* images that are obsolete (the Bullet/TimePivot/TimeTable examples
* still show the removed nvd3 renderers) and brand-new gallery images.
* Register new images in the plugin metadata after capturing.
*/
const EXTRA_CAPTURES: ExtraCapture[] = [
{
sliceName: 'Population Percent Change',
output: `${ECHARTS}/Timeseries/Regular/Line/images/Line3.png`,
width: EXAMPLE_WIDTH,
height: EXAMPLE_HEIGHT,
},
{
sliceName: 'Total Sales Bullet',
output: `${ECHARTS}/Bullet/images/example.jpg`,
width: EXAMPLE_WIDTH,
height: EXAMPLE_HEIGHT,
},
{
sliceName: 'Sales Period Pivot',
output: `${ECHARTS}/TimePivot/images/example.jpg`,
width: EXAMPLE_WIDTH,
height: EXAMPLE_HEIGHT,
},
{
sliceName: 'Product Line Time Table',
output: 'src/visualizations/TimeTable/images/example.jpg',
width: EXAMPLE_WIDTH,
height: EXAMPLE_HEIGHT,
},
];
interface ExampleChart {
id: number;
sliceName: string;
vizType: string;
}
interface DashboardRow {
id: number;
}
interface DashboardChartRow {
id?: number;
slice_name?: string;
form_data?: { viz_type?: string };
}
/** Pages through a list endpoint, returning every result row. */
async function fetchAllPages<T>(page: Page, endpoint: string): Promise<T[]> {
const rows: T[] = [];
const pageSize = 100;
for (let pageNum = 0; ; pageNum += 1) {
const q = encodeURIComponent(
`(page_size:${pageSize},page:${pageNum},order_direction:asc)`,
);
const response = await page.request.get(`${endpoint}?q=${q}`);
expect(response.ok(), `GET ${endpoint} page ${pageNum}`).toBeTruthy();
const { result }: { result: T[] } = await response.json();
rows.push(...result);
if (result.length < pageSize) return rows;
}
}
/** Discovers every chart placed on any dashboard. */
async function discoverDashboardCharts(page: Page): Promise<ExampleChart[]> {
const dashboards = await fetchAllPages<DashboardRow>(
page,
'/api/v1/dashboard/',
);
const chartsById = new Map<number, ExampleChart>();
for (const dashboard of dashboards) {
const response = await page.request.get(
`/api/v1/dashboard/${dashboard.id}/charts`,
);
if (!response.ok()) continue;
const { result }: { result: DashboardChartRow[] } = await response.json();
for (const chart of result) {
const vizType = chart.form_data?.viz_type;
if (chart.id && chart.slice_name && vizType) {
chartsById.set(chart.id, {
id: chart.id,
sliceName: chart.slice_name,
vizType,
});
}
}
}
return [...chartsById.values()];
}
/** thumbnail.png -> thumbnail-dark.png, example.jpg -> example-dark.jpg */
function darkSibling(output: string): string {
return output.replace(/\.(png|jpg)$/, '-dark.$1');
}
async function renderAndShoot(
page: Page,
chart: ExampleChart,
colorScheme: 'light' | 'dark',
): Promise<Buffer> {
// An explicit navigation timeout keeps one hung load from stalling the
// whole crawl until the test timeout.
await page.goto(`/explore/?slice_id=${chart.id}&standalone=1`, {
timeout: 60_000,
});
// Dashboards render charts on colorBgContainer cards, but the standalone
// explore page paints the gray colorBgLayout (via the antd Layout
// wrapper); match the dashboard context so thumbnails look like charts
// do where users see them.
await page
.addStyleTag({
content: `body, .ant-layout { background: ${
colorScheme === 'dark' ? '#141414' : '#ffffff'
} !important; }`,
})
.catch(() => {});
const textOnly = TEXT_ONLY_VIZ_TYPES.has(chart.vizType);
await page
.locator(textOnly ? TEXT_RENDERED_CHART_SELECTOR : RENDERED_CHART_SELECTOR)
.first()
.waitFor({ state: 'visible', timeout: 60_000 });
// Give animations/map tiles (or text-only chart data) time to settle
await page.waitForTimeout(textOnly ? 4_000 : 2_000);
// Some thumbnails read better mid-interaction (e.g. the calendar heatmap
// showing its tooltip); hover the configured element before the still.
const hoverSelector = HOVER_BEFORE_CAPTURE[chart.vizType];
if (hoverSelector) {
// Hover a mid-chart element rather than the first (often an empty
// corner cell), falling back to the first when there are few.
const cells = page.locator(hoverSelector);
const count = await cells.count().catch(() => 0);
await cells
.nth(Math.floor(count / 2))
.hover({ timeout: 5_000 })
.catch(() => {});
await page.waitForTimeout(500);
}
return page.screenshot();
}
/**
* Captures a chart light and (when a dark variant is wanted) dark. Dark
* rendering relies on the app following prefers-color-scheme (theme mode
* SYSTEM); if the dark render is byte-identical to the light one the app
* ignored the emulation, and the dark file is left untouched rather than
* overwritten with light-theme art.
*/
async function captureChart(
page: Page,
chart: ExampleChart,
output: string,
size: { width: number; height: number },
): Promise<void> {
const outputPath = path.join(FRONTEND_ROOT, output);
const darkPath = path.join(FRONTEND_ROOT, darkSibling(output));
const isNewImage = !fs.existsSync(outputPath);
const wantDark = fs.existsSync(darkPath) || isNewImage;
await page.setViewportSize(size);
await page.emulateMedia({ colorScheme: 'light' });
const lightShot = await renderAndShoot(page, chart, 'light');
fs.mkdirSync(path.dirname(outputPath), { recursive: true });
fs.writeFileSync(outputPath, lightShot);
// eslint-disable-next-line no-console
console.log(`captured ${chart.sliceName} (${chart.vizType}) -> ${output}`);
if (wantDark) {
await page.emulateMedia({ colorScheme: 'dark' });
const darkShot = await renderAndShoot(page, chart, 'dark');
if (darkShot.equals(lightShot)) {
// eslint-disable-next-line no-console
console.log(
`SKIPPED dark variant for ${chart.sliceName}: the app ignored the dark color-scheme emulation (is dark theming enabled?)`,
);
} else {
fs.writeFileSync(darkPath, darkShot);
// eslint-disable-next-line no-console
console.log(
`captured ${chart.sliceName} (dark) -> ${darkSibling(output)}`,
);
}
}
if (isNewImage) {
// eslint-disable-next-line no-console
console.log(
`NOTE: ${output} is a new gallery image — register it in the plugin metadata (exampleGallery) to surface it.`,
);
}
}
test.describe('capture viz thumbnails', () => {
test.skip(
!process.env.CAPTURE_THUMBNAILS,
'Thumbnail capture only runs with CAPTURE_THUMBNAILS=1',
);
test('crawls example dashboards and refreshes gallery thumbnails', async ({
page,
}) => {
test.setTimeout(90 * 60_000);
const vizTypeFilter = process.env.VIZ_TYPES
? new Set(process.env.VIZ_TYPES.split(',').map(v => v.trim()))
: null;
const charts = await discoverDashboardCharts(page);
expect(
charts.length,
'no dashboard charts found — are examples loaded?',
).toBeGreaterThan(0);
// One representative chart per viz type: the preferred slice when
// present, else the alphabetically-first slice for determinism.
const byVizType = new Map<string, ExampleChart[]>();
for (const chart of charts) {
const group = byVizType.get(chart.vizType) ?? [];
group.push(chart);
byVizType.set(chart.vizType, group);
}
const thumbnailSize = { width: THUMBNAIL_SIZE, height: THUMBNAIL_SIZE };
const unmapped: string[] = [];
const failures: string[] = [];
for (const [vizType, group] of [...byVizType.entries()].sort()) {
if (vizTypeFilter && !vizTypeFilter.has(vizType)) continue;
const output = VIZ_TYPE_THUMBNAILS[vizType];
if (!output) {
unmapped.push(vizType);
continue;
}
group.sort((a, b) => a.sliceName.localeCompare(b.sliceName));
const chart =
group.find(c => c.sliceName === PREFERRED_SLICES[vizType]) ?? group[0];
try {
await captureChart(page, chart, output, thumbnailSize);
} catch (error) {
failures.push(`${vizType} (${chart.sliceName}): ${error}`);
}
}
for (const extra of EXTRA_CAPTURES) {
const chart = charts.find(c => c.sliceName === extra.sliceName);
if (!chart || (vizTypeFilter && !vizTypeFilter.has(chart.vizType))) {
continue;
}
try {
await captureChart(page, chart, extra.output, {
width: extra.width,
height: extra.height,
});
} catch (error) {
failures.push(`${extra.sliceName}: ${error}`);
}
}
if (unmapped.length) {
// eslint-disable-next-line no-console
console.log(
`viz types on dashboards with no thumbnail mapping (add to VIZ_TYPE_THUMBNAILS if wanted): ${unmapped.join(', ')}`,
);
}
expect(failures, failures.join('\n')).toEqual([]);
});
});

Binary file not shown.

Before

Width:  |  Height:  |  Size: 20 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 9.1 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 4.6 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 106 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 38 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 103 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 65 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 23 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 59 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 52 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 22 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 44 KiB

View File

@@ -1,143 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
/* eslint-disable react/no-array-index-key */
import { memo } from 'react';
import { styled } from '@apache-superset/core/theme';
import TTestTable, { DataEntry } from './TTestTable';
interface PairedTTestProps {
alpha?: number;
className?: string;
data: Record<string, DataEntry[]>;
groups: string[];
liftValPrec?: number;
metrics: string[];
pValPrec?: number;
}
const StyledDiv = styled.div`
${({ theme }) => `
.superset-legacy-chart-paired-t-test .scrollbar-container {
overflow: auto;
}
.paired-ttest-table .scrollbar-content {
padding-left: ${theme.sizeUnit}px;
padding-right: ${theme.sizeUnit}px;
margin-bottom: 0;
}
.paired-ttest-table table {
margin-bottom: 0;
}
.paired-ttest-table h1 {
margin-left: ${theme.sizeUnit}px;
}
.reactable-data tr {
font-feature-settings: 'tnum' 1;
}
.reactable-data tr,
.reactable-header-sortable {
-webkit-transition: ease-in-out 0.1s;
transition: ease-in-out 0.1s;
}
.reactable-data tr:hover {
background-color: ${theme.colorFillTertiary};
}
.reactable-data tr .false {
color: ${theme.colorError};
}
.reactable-data tr .true {
color: ${theme.colorSuccess};
}
.reactable-data tr .control {
color: ${theme.colorPrimary};
}
.reactable-data tr .invalid {
color: ${theme.colorWarning};
}
.reactable-data .control td {
background-color: ${theme.colorFillTertiary};
}
.reactable-header-sortable:hover,
.reactable-header-sortable:focus,
.reactable-header-sort-asc,
.reactable-header-sort-desc {
background-color: ${theme.colorFillTertiary};
position: relative;
}
.reactable-header-sort-asc:after {
content: '\\25bc';
position: absolute;
right: ${theme.sizeUnit * 3}px;
}
.reactable-header-sort-desc:after {
content: '\\25b2';
position: absolute;
right: ${theme.sizeUnit * 3}px;
}
`}
`;
function PairedTTest({
alpha = 0.05,
className = '',
data,
groups,
liftValPrec = 4,
metrics,
pValPrec = 6,
}: PairedTTestProps) {
return (
<StyledDiv>
<div className={`superset-legacy-chart-paired-t-test ${className}`}>
<div className="paired-ttest-table">
<div className="scrollbar-content">
{metrics.map((metric, i) => (
<TTestTable
key={i}
metric={metric}
groups={groups}
data={data[metric]}
alpha={alpha}
pValPrec={Math.min(pValPrec, 32)}
liftValPrec={Math.min(liftValPrec, 32)}
/>
))}
</div>
</div>
</div>
</StyledDiv>
);
}
// memo preserves the shallow-prop render bailout of the PureComponent original
export default memo(PairedTTest);

Binary file not shown.

Before

Width:  |  Height:  |  Size: 59 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 17 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 123 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 44 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 143 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 26 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 9.7 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 31 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 81 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 27 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 78 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 64 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 22 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 60 KiB

View File

@@ -1,113 +0,0 @@
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
# Change Log
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
# [0.20.0](https://github.com/apache/superset/compare/v2021.41.0...v0.20.0) (2024-09-09)
### Bug Fixes
- adding missing examples for bubble chart, bullet chart, calendar heatmap chart and country map chart in the gallery ([#22523](https://github.com/apache/superset/issues/22523)) ([839ec7c](https://github.com/apache/superset/commit/839ec7ceacc66c65928fd0ddead2b014db3d5563))
- Adds the Deprecated label to Time-series Percent Change chart ([#30148](https://github.com/apache/superset/issues/30148)) ([5e42d7a](https://github.com/apache/superset/commit/5e42d7aed0d11c7aac91ab19088d2632e49da614))
- **area chart legacy:** tool tip shows actual value rather than y axi… ([#23469](https://github.com/apache/superset/issues/23469)) ([db9ca20](https://github.com/apache/superset/commit/db9ca20737fecda8eee342b34d62d3b700ef3687))
- **Dashboard:** Color inconsistency on refreshes and conflicts ([#27439](https://github.com/apache/superset/issues/27439)) ([313ee59](https://github.com/apache/superset/commit/313ee596f5435894f857d72be7269d5070c8c964))
- **explore:** Fix chart standalone URL for report/thumbnail generation ([#20673](https://github.com/apache/superset/issues/20673)) ([84d4302](https://github.com/apache/superset/commit/84d4302628d18aa19c13cc5322e68abbc690ea4d))
- **explore:** make SORT-Descending visible if Sort-by has value ([#17726](https://github.com/apache/superset/issues/17726)) ([d5768ab](https://github.com/apache/superset/commit/d5768ab649a70fd4f541ad4982498f622160b220))
- **explore:** Prevent shared controls from checking feature flags outside React render ([#21315](https://github.com/apache/superset/issues/21315)) ([2285ebe](https://github.com/apache/superset/commit/2285ebe72ec4edded6d195052740b7f9f13d1f1b))
- **legacy-chart:** corrupted raw chart data ([#24850](https://github.com/apache/superset/issues/24850)) ([1c5971d](https://github.com/apache/superset/commit/1c5971d3afb70a338444c41943ff90c3a9c03ec3))
- Rename legacy line and area charts ([#28113](https://github.com/apache/superset/issues/28113)) ([b4c4ab7](https://github.com/apache/superset/commit/b4c4ab7790cbeb8d65ec7c1084482c21932e755b))
- Reset sorting bar issue in Barchart ([#19371](https://github.com/apache/superset/issues/19371)) ([94e06c2](https://github.com/apache/superset/commit/94e06c2b6a1f782133bb9ef85a1d46ce7eacf9ba))
- **storybook:** fix broken Storybook stories during development ([#29587](https://github.com/apache/superset/issues/29587)) ([462cda4](https://github.com/apache/superset/commit/462cda400baa00b3bcc4a7f8aded362ca55e18a5))
- Tooltip of area chart shows undefined total ([#24916](https://github.com/apache/superset/issues/24916)) ([ec9e9a4](https://github.com/apache/superset/commit/ec9e9a46f2f092ce56d3ed5a8a9a3ea0214db88a))
- warning of nth-child ([#23638](https://github.com/apache/superset/issues/23638)) ([16cc089](https://github.com/apache/superset/commit/16cc089b198dcdebc2422845aa08d18233c6b3a4))
- Zero values on Dual Line axis bounds ([#23649](https://github.com/apache/superset/issues/23649)) ([d66e6e6](https://github.com/apache/superset/commit/d66e6e6d400db0fee35d73cd43e610cd1c491f4b))
### Features
- Adds the ECharts Bubble chart ([#22107](https://github.com/apache/superset/issues/22107)) ([c81c60c](https://github.com/apache/superset/commit/c81c60c91fbcb09dd63c05f050e18ee09ceebfd6))
- apply standardized form data to tier 2 charts ([#20530](https://github.com/apache/superset/issues/20530)) ([de524bc](https://github.com/apache/superset/commit/de524bc59f011fd361dcdb7d35c2cb51f7eba442))
- **chart & legend:** make to enable show legend by default ([#19927](https://github.com/apache/superset/issues/19927)) ([7b3d0f0](https://github.com/apache/superset/commit/7b3d0f040b050905f7d0901d0227f1cd6b761b56))
- **explore:** Apply denormalization to tier 2 charts form data ([#20524](https://github.com/apache/superset/issues/20524)) ([e12ee59](https://github.com/apache/superset/commit/e12ee59b13822241dca8d8015f1222c477edd4f3))
- **explore:** Denormalize form data in echarts, world map and nvd3 bar and line charts ([#20313](https://github.com/apache/superset/issues/20313)) ([354a899](https://github.com/apache/superset/commit/354a89950c4d001da3e107f60788cea873bd6bf6))
- **explore:** improve UI in the control panel ([#19748](https://github.com/apache/superset/issues/19748)) ([e3a54aa](https://github.com/apache/superset/commit/e3a54aa3c15bdd0c970aa73f898288a408205c97))
- **explore:** standardized controls for time pivot chart ([#21321](https://github.com/apache/superset/issues/21321)) ([79525df](https://github.com/apache/superset/commit/79525dfaf29b810af668e3b6c5a56cd866370d92))
- **formatters:** Add custom d3-time-format locale ([#24263](https://github.com/apache/superset/issues/24263)) ([024cfd8](https://github.com/apache/superset/commit/024cfd86e408ec5f7ddf49a9e90908e2fb2e6b70))
- improve color consistency (save all labels) ([#19038](https://github.com/apache/superset/issues/19038)) ([dc57508](https://github.com/apache/superset/commit/dc575080d7e43d40b1734bb8f44fdc291cb95b11))
- **legacy-preset-chart-nvd3:** add richtooltip in nvd3 bar chart ([#17615](https://github.com/apache/superset/issues/17615)) ([72f3215](https://github.com/apache/superset/commit/72f3215ffc74ead33dba57196aeaf4e1db63fd6c))
- Migrates Dual Line Chart to Mixed Chart ([#23910](https://github.com/apache/superset/issues/23910)) ([f5148ef](https://github.com/apache/superset/commit/f5148ef728ce649697c10fb7aa65982d7dd05638))
- Removes the Multiple Line Charts ([#23933](https://github.com/apache/superset/issues/23933)) ([6ce8592](https://github.com/apache/superset/commit/6ce85921fc103ba0e93b437d473003e6f1b4a42b))
- update time comparison choices (again) ([#17968](https://github.com/apache/superset/issues/17968)) ([05d9cde](https://github.com/apache/superset/commit/05d9cde203b99f8c63106446f0be58668cc9f0c9))
- update time comparison choices (again) ([#22458](https://github.com/apache/superset/issues/22458)) ([9e81c3a](https://github.com/apache/superset/commit/9e81c3a1192a18226d505178d16e1e395917a719))
- **viz picker:** Remove some tags, refactor Recommended section ([#27708](https://github.com/apache/superset/issues/27708)) ([c314999](https://github.com/apache/superset/commit/c3149994ac0d4392e0462421b62cd0c034142082))
# [0.19.0](https://github.com/apache/superset/compare/v2021.41.0...v0.19.0) (2024-09-07)
### Bug Fixes
- adding missing examples for bubble chart, bullet chart, calendar heatmap chart and country map chart in the gallery ([#22523](https://github.com/apache/superset/issues/22523)) ([839ec7c](https://github.com/apache/superset/commit/839ec7ceacc66c65928fd0ddead2b014db3d5563))
- Adds the Deprecated label to Time-series Percent Change chart ([#30148](https://github.com/apache/superset/issues/30148)) ([5e42d7a](https://github.com/apache/superset/commit/5e42d7aed0d11c7aac91ab19088d2632e49da614))
- **area chart legacy:** tool tip shows actual value rather than y axi… ([#23469](https://github.com/apache/superset/issues/23469)) ([db9ca20](https://github.com/apache/superset/commit/db9ca20737fecda8eee342b34d62d3b700ef3687))
- **Dashboard:** Color inconsistency on refreshes and conflicts ([#27439](https://github.com/apache/superset/issues/27439)) ([313ee59](https://github.com/apache/superset/commit/313ee596f5435894f857d72be7269d5070c8c964))
- **explore:** Fix chart standalone URL for report/thumbnail generation ([#20673](https://github.com/apache/superset/issues/20673)) ([84d4302](https://github.com/apache/superset/commit/84d4302628d18aa19c13cc5322e68abbc690ea4d))
- **explore:** make SORT-Descending visible if Sort-by has value ([#17726](https://github.com/apache/superset/issues/17726)) ([d5768ab](https://github.com/apache/superset/commit/d5768ab649a70fd4f541ad4982498f622160b220))
- **explore:** Prevent shared controls from checking feature flags outside React render ([#21315](https://github.com/apache/superset/issues/21315)) ([2285ebe](https://github.com/apache/superset/commit/2285ebe72ec4edded6d195052740b7f9f13d1f1b))
- **legacy-chart:** corrupted raw chart data ([#24850](https://github.com/apache/superset/issues/24850)) ([1c5971d](https://github.com/apache/superset/commit/1c5971d3afb70a338444c41943ff90c3a9c03ec3))
- Rename legacy line and area charts ([#28113](https://github.com/apache/superset/issues/28113)) ([b4c4ab7](https://github.com/apache/superset/commit/b4c4ab7790cbeb8d65ec7c1084482c21932e755b))
- Reset sorting bar issue in Barchart ([#19371](https://github.com/apache/superset/issues/19371)) ([94e06c2](https://github.com/apache/superset/commit/94e06c2b6a1f782133bb9ef85a1d46ce7eacf9ba))
- **storybook:** fix broken Storybook stories during development ([#29587](https://github.com/apache/superset/issues/29587)) ([462cda4](https://github.com/apache/superset/commit/462cda400baa00b3bcc4a7f8aded362ca55e18a5))
- Tooltip of area chart shows undefined total ([#24916](https://github.com/apache/superset/issues/24916)) ([ec9e9a4](https://github.com/apache/superset/commit/ec9e9a46f2f092ce56d3ed5a8a9a3ea0214db88a))
- warning of nth-child ([#23638](https://github.com/apache/superset/issues/23638)) ([16cc089](https://github.com/apache/superset/commit/16cc089b198dcdebc2422845aa08d18233c6b3a4))
- Zero values on Dual Line axis bounds ([#23649](https://github.com/apache/superset/issues/23649)) ([d66e6e6](https://github.com/apache/superset/commit/d66e6e6d400db0fee35d73cd43e610cd1c491f4b))
### Features
- Adds the ECharts Bubble chart ([#22107](https://github.com/apache/superset/issues/22107)) ([c81c60c](https://github.com/apache/superset/commit/c81c60c91fbcb09dd63c05f050e18ee09ceebfd6))
- apply standardized form data to tier 2 charts ([#20530](https://github.com/apache/superset/issues/20530)) ([de524bc](https://github.com/apache/superset/commit/de524bc59f011fd361dcdb7d35c2cb51f7eba442))
- **chart & legend:** make to enable show legend by default ([#19927](https://github.com/apache/superset/issues/19927)) ([7b3d0f0](https://github.com/apache/superset/commit/7b3d0f040b050905f7d0901d0227f1cd6b761b56))
- **explore:** Apply denormalization to tier 2 charts form data ([#20524](https://github.com/apache/superset/issues/20524)) ([e12ee59](https://github.com/apache/superset/commit/e12ee59b13822241dca8d8015f1222c477edd4f3))
- **explore:** Denormalize form data in echarts, world map and nvd3 bar and line charts ([#20313](https://github.com/apache/superset/issues/20313)) ([354a899](https://github.com/apache/superset/commit/354a89950c4d001da3e107f60788cea873bd6bf6))
- **explore:** improve UI in the control panel ([#19748](https://github.com/apache/superset/issues/19748)) ([e3a54aa](https://github.com/apache/superset/commit/e3a54aa3c15bdd0c970aa73f898288a408205c97))
- **explore:** standardized controls for time pivot chart ([#21321](https://github.com/apache/superset/issues/21321)) ([79525df](https://github.com/apache/superset/commit/79525dfaf29b810af668e3b6c5a56cd866370d92))
- **formatters:** Add custom d3-time-format locale ([#24263](https://github.com/apache/superset/issues/24263)) ([024cfd8](https://github.com/apache/superset/commit/024cfd86e408ec5f7ddf49a9e90908e2fb2e6b70))
- improve color consistency (save all labels) ([#19038](https://github.com/apache/superset/issues/19038)) ([dc57508](https://github.com/apache/superset/commit/dc575080d7e43d40b1734bb8f44fdc291cb95b11))
- **legacy-preset-chart-nvd3:** add richtooltip in nvd3 bar chart ([#17615](https://github.com/apache/superset/issues/17615)) ([72f3215](https://github.com/apache/superset/commit/72f3215ffc74ead33dba57196aeaf4e1db63fd6c))
- Migrates Dual Line Chart to Mixed Chart ([#23910](https://github.com/apache/superset/issues/23910)) ([f5148ef](https://github.com/apache/superset/commit/f5148ef728ce649697c10fb7aa65982d7dd05638))
- Removes the Multiple Line Charts ([#23933](https://github.com/apache/superset/issues/23933)) ([6ce8592](https://github.com/apache/superset/commit/6ce85921fc103ba0e93b437d473003e6f1b4a42b))
- update time comparison choices (again) ([#17968](https://github.com/apache/superset/issues/17968)) ([05d9cde](https://github.com/apache/superset/commit/05d9cde203b99f8c63106446f0be58668cc9f0c9))
- update time comparison choices (again) ([#22458](https://github.com/apache/superset/issues/22458)) ([9e81c3a](https://github.com/apache/superset/commit/9e81c3a1192a18226d505178d16e1e395917a719))
- **viz picker:** Remove some tags, refactor Recommended section ([#27708](https://github.com/apache/superset/issues/27708)) ([c314999](https://github.com/apache/superset/commit/c3149994ac0d4392e0462421b62cd0c034142082))
# [0.18.0](https://github.com/apache-superset/superset-ui/compare/v0.17.87...v0.18.0) (2021-08-30)
**Note:** Version bump only for package @superset-ui/legacy-preset-chart-nvd3
## [0.17.63](https://github.com/apache-superset/superset-ui/compare/v0.17.62...v0.17.63) (2021-07-02)
**Note:** Version bump only for package @superset-ui/legacy-preset-chart-nvd3
## [0.17.62](https://github.com/apache-superset/superset-ui/compare/v0.17.61...v0.17.62) (2021-07-02)
**Note:** Version bump only for package @superset-ui/legacy-preset-chart-nvd3
## [0.17.61](https://github.com/apache-superset/superset-ui/compare/v0.17.60...v0.17.61) (2021-07-02)
**Note:** Version bump only for package @superset-ui/legacy-preset-chart-nvd3

View File

@@ -1,64 +0,0 @@
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
## @superset-ui/legacy-preset-chart-nvd3
[![Version](https://img.shields.io/npm/v/@superset-ui/legacy-preset-chart-nvd3.svg?style=flat)](https://www.npmjs.com/package/@superset-ui/legacy-preset-chart-nvd3)
[![Libraries.io](https://img.shields.io/librariesio/release/npm/%40superset-ui%2Flegacy-preset-chart-nvd3?style=flat)](https://libraries.io/npm/@superset-ui%2Flegacy-preset-chart-nvd3)
This plugin provides Big Number for Superset.
### Usage
Import the preset and register. This will register all the chart plugins under nvd3.
```js
import { NVD3ChartPreset } from '@superset-ui/legacy-preset-chart-nvd3';
new NVD3ChartPreset().register();
```
or register charts one by one. Configure `key`, which can be any `string`, and register the plugin.
This `key` will be used to lookup this chart throughout the app.
```js
import {
AreaChartPlugin,
LineChartPlugin,
} from '@superset-ui/legacy-preset-chart-nvd3';
new AreaChartPlugin().configure({ key: 'area' }).register();
new LineChartPlugin().configure({ key: 'line' }).register();
```
Then use it via `SuperChart`. See
[storybook](https://apache-superset.github.io/superset-ui-plugins/?selectedKind=plugin-chart-nvd3)
for more details.
```js
<SuperChart
chartType="line"
width={600}
height={600}
formData={...}
queriesData={[{
data: {...},
}]}
/>
```

View File

@@ -1,49 +0,0 @@
{
"name": "@superset-ui/legacy-preset-chart-nvd3",
"version": "0.20.3",
"description": "Superset Legacy Chart - NVD3",
"sideEffects": [
"*.css"
],
"main": "lib/index.js",
"module": "esm/index.js",
"files": [
"esm",
"lib"
],
"repository": {
"type": "git",
"url": "https://github.com/apache/superset.git",
"directory": "superset-frontend/packages/legacy-preset-chart-nvd3"
},
"keywords": [
"superset"
],
"author": "Superset",
"license": "Apache-2.0",
"bugs": {
"url": "https://github.com/apache/superset/issues"
},
"homepage": "https://github.com/apache/superset/tree/master/superset-frontend/plugins/legacy-preset-chart-nvd3#readme",
"publishConfig": {
"access": "public"
},
"dependencies": {
"d3": "^3.5.17",
"d3-tip": "^0.9.1",
"fast-safe-stringify": "^2.1.1",
"lodash": "^4.18.1",
"nvd3-fork": "^2.0.5",
"dompurify": "^3.4.12",
"prop-types": "^15.8.1",
"urijs": "^1.19.11",
"lodash-es": "^4.18.1"
},
"peerDependencies": {
"@apache-superset/core": "*",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"dayjs": "^1.11.21",
"react": "^18.3.0"
}
}

View File

@@ -1,81 +0,0 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { SuperChart, VizType } from '@superset-ui/core';
import { EchartsBoxPlotChartPlugin } from '@superset-ui/plugin-chart-echarts';
import { dummyDatasource, withResizableChartDemo } from '@storybook-shared';
import data from './data';
new EchartsBoxPlotChartPlugin().configure({ key: 'box-plot' }).register();
export default {
title: 'Legacy Chart Plugins/legacy-preset-chart-nvd3/BoxPlot',
decorators: [withResizableChartDemo],
args: {
colorScheme: 'd3Category10',
whiskerOptions: 'Min/max (no outliers)',
},
argTypes: {
colorScheme: {
control: 'select',
options: [
'supersetColors',
'd3Category10',
'bnbColors',
'googleCategory20c',
],
},
whiskerOptions: {
control: 'select',
options: [
'Tukey',
'Min/max (no outliers)',
'2/98 percentiles',
'9/91 percentiles',
],
},
},
};
export const Basic = ({
colorScheme,
whiskerOptions,
width,
height,
}: {
colorScheme: string;
whiskerOptions: string;
width: number;
height: number;
}) => (
<SuperChart
chartType="box-plot"
width={width}
height={height}
datasource={dummyDatasource}
queriesData={[{ data }]}
formData={{
color_scheme: colorScheme,
viz_type: VizType.BoxPlot,
whisker_options: whiskerOptions,
groupby: ['region'],
metrics: ['sum__SP_POP_TOTL'],
}}
/>
);

View File

@@ -1,78 +0,0 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
/* eslint-disable sort-keys, no-magic-numbers */
// Data format for ECharts BoxPlot - requires metric__min, metric__q1, metric__median, etc.
export default [
{
region: 'East Asia & Pacific',
sum__SP_POP_TOTL__min: 1031863394.0,
sum__SP_POP_TOTL__q1: 1384725172.5,
sum__SP_POP_TOTL__median: 1717904169.0,
sum__SP_POP_TOTL__q3: 2032724922.5,
sum__SP_POP_TOTL__max: 2240687901.0,
sum__SP_POP_TOTL__mean: 1681000000.0,
sum__SP_POP_TOTL__count: 50,
sum__SP_POP_TOTL__outliers: [],
},
{
region: 'Europe & Central Asia',
sum__SP_POP_TOTL__min: 660881033.0,
sum__SP_POP_TOTL__q1: 751386460.5,
sum__SP_POP_TOTL__median: 820716895.0,
sum__SP_POP_TOTL__q3: 862814192.5,
sum__SP_POP_TOTL__max: 903095786.0,
sum__SP_POP_TOTL__mean: 799778873.0,
sum__SP_POP_TOTL__count: 50,
sum__SP_POP_TOTL__outliers: [],
},
{
region: 'Latin America & Caribbean',
sum__SP_POP_TOTL__min: 220564224.0,
sum__SP_POP_TOTL__q1: 313690832.5,
sum__SP_POP_TOTL__median: 421490233.0,
sum__SP_POP_TOTL__q3: 529668114.5,
sum__SP_POP_TOTL__max: 626270167.0,
sum__SP_POP_TOTL__mean: 422336714.0,
sum__SP_POP_TOTL__count: 50,
sum__SP_POP_TOTL__outliers: [],
},
{
region: 'South Asia',
sum__SP_POP_TOTL__min: 572036107.0,
sum__SP_POP_TOTL__q1: 772373036.5,
sum__SP_POP_TOTL__median: 1059570231.0,
sum__SP_POP_TOTL__q3: 1398841234.0,
sum__SP_POP_TOTL__max: 1720976995.0,
sum__SP_POP_TOTL__mean: 1104759521.0,
sum__SP_POP_TOTL__count: 50,
sum__SP_POP_TOTL__outliers: [],
},
{
region: 'Sub-Saharan Africa',
sum__SP_POP_TOTL__min: 228268752.0,
sum__SP_POP_TOTL__q1: 320037758.0,
sum__SP_POP_TOTL__median: 467337821.0,
sum__SP_POP_TOTL__q3: 676768689.0,
sum__SP_POP_TOTL__max: 974315323.0,
sum__SP_POP_TOTL__mean: 533345669.0,
sum__SP_POP_TOTL__count: 50,
sum__SP_POP_TOTL__outliers: [1100000000, 1200000000],
},
];

View File

@@ -1,140 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { t } from '@apache-superset/core/translation';
import {
ControlPanelConfig,
formatSelectOptions,
D3_FORMAT_OPTIONS,
getStandardizedControls,
} from '@superset-ui/chart-controls';
import {
showLegend,
xAxisLabel,
yAxisLabel,
bottomMargin,
xTicksLayout,
xAxisFormat,
yLogScale,
xAxisShowMinmax,
yAxisShowMinmax,
leftMargin,
yAxisBounds,
} from '../NVD3Controls';
const config: ControlPanelConfig = {
controlPanelSections: [
{
label: t('Query'),
expanded: true,
controlSetRows: [
['series'],
['entity'],
['x'],
['y'],
['adhoc_filters'],
['size'],
[
{
name: 'max_bubble_size',
config: {
type: 'SelectControl',
freeForm: true,
label: t('Max Bubble Size'),
default: '25',
choices: formatSelectOptions([
'5',
'10',
'15',
'25',
'50',
'75',
'100',
]),
},
},
],
['limit', null],
],
},
{
label: t('Chart Options'),
expanded: true,
tabOverride: 'customize',
controlSetRows: [['color_scheme'], [showLegend, null]],
},
{
label: t('X Axis'),
expanded: true,
tabOverride: 'customize',
controlSetRows: [
[xAxisLabel, leftMargin],
[
{
name: xAxisFormat.name,
config: {
...xAxisFormat.config,
default: 'SMART_NUMBER',
choices: D3_FORMAT_OPTIONS,
},
},
xTicksLayout,
],
[
{
name: 'x_log_scale',
config: {
type: 'CheckboxControl',
label: t('X Log Scale'),
default: false,
renderTrigger: true,
description: t('Use a log scale for the X-axis'),
},
},
xAxisShowMinmax,
],
],
},
{
label: t('Y Axis'),
expanded: true,
tabOverride: 'customize',
controlSetRows: [
[yAxisLabel, bottomMargin],
['y_axis_format', null],
[yLogScale, yAxisShowMinmax],
[yAxisBounds],
],
},
],
controlOverrides: {
color_scheme: {
renderTrigger: false,
},
},
formDataOverrides: formData => ({
...formData,
series: getStandardizedControls().shiftColumn(),
entity: getStandardizedControls().shiftColumn(),
x: getStandardizedControls().shiftMetric(),
y: getStandardizedControls().shiftMetric(),
size: getStandardizedControls().shiftMetric(),
}),
};
export default config;

Binary file not shown.

Before

Width:  |  Height:  |  Size: 55 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 60 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 59 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 20 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 44 KiB

View File

@@ -1,103 +0,0 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { SuperChart, VizType } from '@superset-ui/core';
import { BubbleChartPlugin } from '@superset-ui/legacy-preset-chart-nvd3';
import { dummyDatasource, withResizableChartDemo } from '@storybook-shared';
import data from './data';
new BubbleChartPlugin().configure({ key: VizType.LegacyBubble }).register();
export default {
title: 'Legacy Chart Plugins/legacy-preset-chart-nvd3/Bubble',
decorators: [withResizableChartDemo],
args: {
colorScheme: 'd3Category10',
maxBubbleSize: 50,
showLegend: true,
xLogScale: false,
yLogScale: false,
},
argTypes: {
colorScheme: {
control: 'select',
options: [
'supersetColors',
'd3Category10',
'bnbColors',
'googleCategory20c',
],
},
maxBubbleSize: {
control: { type: 'range', min: 10, max: 100, step: 5 },
},
showLegend: { control: 'boolean' },
xLogScale: { control: 'boolean' },
yLogScale: { control: 'boolean' },
},
};
export const Basic = ({
colorScheme,
maxBubbleSize,
showLegend,
xLogScale,
yLogScale,
width,
height,
}: {
colorScheme: string;
maxBubbleSize: number;
showLegend: boolean;
xLogScale: boolean;
yLogScale: boolean;
width: number;
height: number;
}) => (
<SuperChart
chartType={VizType.LegacyBubble}
width={width}
height={height}
datasource={dummyDatasource}
queriesData={[{ data }]}
formData={{
annotation_data: {},
bottom_margin: 'auto',
color_scheme: colorScheme,
entity: 'country_name',
left_margin: 'auto',
max_bubble_size: String(maxBubbleSize),
series: 'region',
show_legend: showLegend,
size: 'sum__SP_POP_TOTL',
viz_type: VizType.LegacyBubble,
x: 'sum__SP_RUR_TOTL_ZS',
x_axis_format: '.3s',
x_axis_label: 'Rural Population %',
x_axis_showminmax: false,
x_log_scale: xLogScale,
x_ticks_layout: 'auto',
y: 'sum__SP_DYN_LE00_IN',
y_axis_format: '.3s',
y_axis_label: 'Life Expectancy',
y_axis_showminmax: false,
y_log_scale: yLogScale,
}}
/>
);

View File

@@ -1,357 +0,0 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
/* eslint-disable sort-keys, no-magic-numbers */
export default [
{
key: 'East Asia & Pacific',
values: [
{
country_name: 'China',
region: 'East Asia & Pacific',
sum__SP_POP_TOTL: 1344130000.0,
sum__SP_RUR_TOTL_ZS: 49.427,
sum__SP_DYN_LE00_IN: 75.042,
x: 49.427,
y: 75.042,
size: 1344130000.0,
shape: 'circle',
group: 'East Asia & Pacific',
},
{
country_name: 'Indonesia',
region: 'East Asia & Pacific',
sum__SP_POP_TOTL: 244808254.0,
sum__SP_RUR_TOTL_ZS: 49.288,
sum__SP_DYN_LE00_IN: 70.3915609756,
x: 49.288,
y: 70.3915609756,
size: 244808254.0,
shape: 'circle',
group: 'East Asia & Pacific',
},
{
country_name: 'Japan',
region: 'East Asia & Pacific',
sum__SP_POP_TOTL: 127817277.0,
sum__SP_RUR_TOTL_ZS: 8.752,
sum__SP_DYN_LE00_IN: 82.5912195122,
x: 8.752,
y: 82.5912195122,
size: 127817277.0,
shape: 'circle',
group: 'East Asia & Pacific',
},
{
country_name: 'Philippines',
region: 'East Asia & Pacific',
sum__SP_POP_TOTL: 94501233.0,
sum__SP_RUR_TOTL_ZS: 54.983,
sum__SP_DYN_LE00_IN: 68.3914878049,
x: 54.983,
y: 68.3914878049,
size: 94501233.0,
shape: 'circle',
group: 'East Asia & Pacific',
},
{
country_name: 'Vietnam',
region: 'East Asia & Pacific',
sum__SP_POP_TOTL: 87840000.0,
sum__SP_RUR_TOTL_ZS: 68.971,
sum__SP_DYN_LE00_IN: 75.457902439,
x: 68.971,
y: 75.457902439,
size: 87840000.0,
shape: 'circle',
group: 'East Asia & Pacific',
},
{
country_name: 'Thailand',
region: 'East Asia & Pacific',
sum__SP_POP_TOTL: 66902958.0,
sum__SP_RUR_TOTL_ZS: 54.606,
sum__SP_DYN_LE00_IN: 74.008902439,
x: 54.606,
y: 74.008902439,
size: 66902958.0,
shape: 'circle',
group: 'East Asia & Pacific',
},
{
country_name: 'Myanmar',
region: 'East Asia & Pacific',
sum__SP_POP_TOTL: 52125411.0,
sum__SP_RUR_TOTL_ZS: 68.065,
sum__SP_DYN_LE00_IN: 64.7612439024,
x: 68.065,
y: 64.7612439024,
size: 52125411.0,
shape: 'circle',
group: 'East Asia & Pacific',
},
],
},
{
key: 'South Asia',
values: [
{
country_name: 'India',
region: 'South Asia',
sum__SP_POP_TOTL: 1247446011.0,
sum__SP_RUR_TOTL_ZS: 68.724,
sum__SP_DYN_LE00_IN: 65.9584878049,
x: 68.724,
y: 65.9584878049,
size: 1247446011.0,
shape: 'circle',
group: 'South Asia',
},
{
country_name: 'Pakistan',
region: 'South Asia',
sum__SP_POP_TOTL: 173669648.0,
sum__SP_RUR_TOTL_ZS: 62.993,
sum__SP_DYN_LE00_IN: 66.2838780488,
x: 62.993,
y: 66.2838780488,
size: 173669648.0,
shape: 'circle',
group: 'South Asia',
},
{
country_name: 'Bangladesh',
region: 'South Asia',
sum__SP_POP_TOTL: 153405612.0,
sum__SP_RUR_TOTL_ZS: 68.775,
sum__SP_DYN_LE00_IN: 69.891804878,
x: 68.775,
y: 69.891804878,
size: 153405612.0,
shape: 'circle',
group: 'South Asia',
},
],
},
{
key: 'North America',
values: [
{
country_name: 'United States',
region: 'North America',
sum__SP_POP_TOTL: 311721632.0,
sum__SP_RUR_TOTL_ZS: 19.06,
sum__SP_DYN_LE00_IN: 78.6414634146,
x: 19.06,
y: 78.6414634146,
size: 311721632.0,
shape: 'circle',
group: 'North America',
},
],
},
{
key: 'Latin America & Caribbean',
values: [
{
country_name: 'Brazil',
region: 'Latin America & Caribbean',
sum__SP_POP_TOTL: 200517584.0,
sum__SP_RUR_TOTL_ZS: 15.377,
sum__SP_DYN_LE00_IN: 73.3473658537,
x: 15.377,
y: 73.3473658537,
size: 200517584.0,
shape: 'circle',
group: 'Latin America & Caribbean',
},
{
country_name: 'Mexico',
region: 'Latin America & Caribbean',
sum__SP_POP_TOTL: 120365271.0,
sum__SP_RUR_TOTL_ZS: 21.882,
sum__SP_DYN_LE00_IN: 76.9141707317,
x: 21.882,
y: 76.9141707317,
size: 120365271.0,
shape: 'circle',
group: 'Latin America & Caribbean',
},
],
},
{
key: 'Sub-Saharan Africa',
values: [
{
country_name: 'Nigeria',
region: 'Sub-Saharan Africa',
sum__SP_POP_TOTL: 163770669.0,
sum__SP_RUR_TOTL_ZS: 55.638,
sum__SP_DYN_LE00_IN: 51.7102439024,
x: 55.638,
y: 51.7102439024,
size: 163770669.0,
shape: 'circle',
group: 'Sub-Saharan Africa',
},
{
country_name: 'Ethiopia',
region: 'Sub-Saharan Africa',
sum__SP_POP_TOTL: 89858696.0,
sum__SP_RUR_TOTL_ZS: 82.265,
sum__SP_DYN_LE00_IN: 62.2528536585,
x: 82.265,
y: 62.2528536585,
size: 89858696.0,
shape: 'circle',
group: 'Sub-Saharan Africa',
},
{
country_name: 'Congo, Dem. Rep.',
region: 'Sub-Saharan Africa',
sum__SP_POP_TOTL: 68087376.0,
sum__SP_RUR_TOTL_ZS: 59.558,
sum__SP_DYN_LE00_IN: 49.3007073171,
x: 59.558,
y: 49.3007073171,
size: 68087376.0,
shape: 'circle',
group: 'Sub-Saharan Africa',
},
{
country_name: 'South Africa',
region: 'Sub-Saharan Africa',
sum__SP_POP_TOTL: 51553479.0,
sum__SP_RUR_TOTL_ZS: 37.254,
sum__SP_DYN_LE00_IN: 55.2956585366,
x: 37.254,
y: 55.2956585366,
size: 51553479.0,
shape: 'circle',
group: 'Sub-Saharan Africa',
},
],
},
{
key: 'Europe & Central Asia',
values: [
{
country_name: 'Russian Federation',
region: 'Europe & Central Asia',
sum__SP_POP_TOTL: 142960868.0,
sum__SP_RUR_TOTL_ZS: 26.268,
sum__SP_DYN_LE00_IN: 69.6585365854,
x: 26.268,
y: 69.6585365854,
size: 142960868.0,
shape: 'circle',
group: 'Europe & Central Asia',
},
{
country_name: 'Germany',
region: 'Europe & Central Asia',
sum__SP_POP_TOTL: 81797673.0,
sum__SP_RUR_TOTL_ZS: 25.512,
sum__SP_DYN_LE00_IN: 80.7414634146,
x: 25.512,
y: 80.7414634146,
size: 81797673.0,
shape: 'circle',
group: 'Europe & Central Asia',
},
{
country_name: 'Turkey',
region: 'Europe & Central Asia',
sum__SP_POP_TOTL: 73199372.0,
sum__SP_RUR_TOTL_ZS: 28.718,
sum__SP_DYN_LE00_IN: 74.5404878049,
x: 28.718,
y: 74.5404878049,
size: 73199372.0,
shape: 'circle',
group: 'Europe & Central Asia',
},
{
country_name: 'France',
region: 'Europe & Central Asia',
sum__SP_POP_TOTL: 65342776.0,
sum__SP_RUR_TOTL_ZS: 21.416,
sum__SP_DYN_LE00_IN: 82.1146341463,
x: 21.416,
y: 82.1146341463,
size: 65342776.0,
shape: 'circle',
group: 'Europe & Central Asia',
},
{
country_name: 'United Kingdom',
region: 'Europe & Central Asia',
sum__SP_POP_TOTL: 63258918.0,
sum__SP_RUR_TOTL_ZS: 18.43,
sum__SP_DYN_LE00_IN: 80.9512195122,
x: 18.43,
y: 80.9512195122,
size: 63258918.0,
shape: 'circle',
group: 'Europe & Central Asia',
},
{
country_name: 'Italy',
region: 'Europe & Central Asia',
sum__SP_POP_TOTL: 59379449.0,
sum__SP_RUR_TOTL_ZS: 31.556,
sum__SP_DYN_LE00_IN: 82.187804878,
x: 31.556,
y: 82.187804878,
size: 59379449.0,
shape: 'circle',
group: 'Europe & Central Asia',
},
],
},
{
key: 'Middle East & North Africa',
values: [
{
country_name: 'Egypt, Arab Rep.',
region: 'Middle East & North Africa',
sum__SP_POP_TOTL: 83787634.0,
sum__SP_RUR_TOTL_ZS: 57.0,
sum__SP_DYN_LE00_IN: 70.6785609756,
x: 57.0,
y: 70.6785609756,
size: 83787634.0,
shape: 'circle',
group: 'Middle East & North Africa',
},
{
country_name: 'Iran, Islamic Rep.',
region: 'Middle East & North Africa',
sum__SP_POP_TOTL: 75184322.0,
sum__SP_RUR_TOTL_ZS: 28.8,
sum__SP_DYN_LE00_IN: 73.4493170732,
x: 28.8,
y: 73.4493170732,
size: 75184322.0,
shape: 'circle',
group: 'Middle East & North Africa',
},
],
},
];

Binary file not shown.

Before

Width:  |  Height:  |  Size: 22 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 22 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 3.6 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 978 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 2.3 KiB

View File

@@ -1,51 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { t } from '@apache-superset/core/translation';
import { ChartMetadata, ChartPlugin } from '@superset-ui/core';
import transformProps from '../transformProps';
import example from './images/example.jpg';
import exampleDark from './images/example-dark.jpg';
import thumbnail from './images/thumbnail.png';
import thumbnailDark from './images/thumbnail-dark.png';
import controlPanel from './controlPanel';
const metadata = new ChartMetadata({
category: t('KPI'),
credits: ['http://nvd3.org'],
description: t(
'Showcases the progress of a single metric against a given target. The higher the fill, the closer the metric is to the target.',
),
exampleGallery: [{ url: example, urlDark: exampleDark }],
name: t('Bullet Chart'),
tags: [t('Business'), t('Legacy'), t('Report'), t('nvd3')],
thumbnail,
thumbnailDark,
useLegacyApi: true,
});
export default class BulletChartPlugin extends ChartPlugin {
constructor() {
super({
loadChart: () => import('../ReactNVD3'),
metadata,
transformProps,
controlPanel,
});
}
}

View File

@@ -1,87 +0,0 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { SuperChart, VizType } from '@superset-ui/core';
import { BulletChartPlugin } from '@superset-ui/legacy-preset-chart-nvd3';
import { dummyDatasource, withResizableChartDemo } from '@storybook-shared';
import data from './data';
new BulletChartPlugin().configure({ key: VizType.Bullet }).register();
export default {
title: 'Legacy Chart Plugins/legacy-preset-chart-nvd3/Bullet',
decorators: [withResizableChartDemo],
args: {
ranges: '0, 50, 75, 100',
rangeLabels: 'Low, Medium, High',
markers: '65',
markerLabels: 'Target',
},
argTypes: {
ranges: {
control: 'text',
description: 'Comma-separated range values',
},
rangeLabels: {
control: 'text',
description: 'Comma-separated range labels',
},
markers: {
control: 'text',
description: 'Comma-separated marker values',
},
markerLabels: {
control: 'text',
description: 'Comma-separated marker labels',
},
},
};
export const Basic = ({
ranges,
rangeLabels,
markers,
markerLabels,
width,
height,
}: {
ranges: string;
rangeLabels: string;
markers: string;
markerLabels: string;
width: number;
height: number;
}) => (
<SuperChart
chartType={VizType.Bullet}
width={width}
height={height}
datasource={dummyDatasource}
queriesData={[{ data }]}
formData={{
marker_labels: markerLabels,
marker_line_labels: '',
marker_lines: '',
markers,
range_labels: rangeLabels,
ranges,
viz_type: VizType.Bullet,
}}
/>
);

View File

@@ -1,76 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { t } from '@apache-superset/core/translation';
import {
ControlPanelConfig,
getStandardizedControls,
sections,
} from '@superset-ui/chart-controls';
import {
xAxisLabel,
yAxisLabel,
bottomMargin,
xTicksLayout,
xAxisFormat,
yLogScale,
yAxisBounds,
xAxisShowMinmax,
yAxisShowMinmax,
leftMargin,
timeSeriesSection,
} from '../NVD3Controls';
const config: ControlPanelConfig = {
controlPanelSections: [
sections.legacyTimeseriesTime,
timeSeriesSection[0],
{
label: t('Chart Options'),
expanded: true,
controlSetRows: [['color_scheme']],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
[xAxisLabel, bottomMargin],
[xTicksLayout, xAxisFormat],
[xAxisShowMinmax, null],
],
},
{
label: t('Y Axis'),
expanded: true,
controlSetRows: [
[yAxisLabel, leftMargin],
[yAxisShowMinmax, yLogScale],
['y_axis_format', yAxisBounds],
],
},
timeSeriesSection[1],
sections.annotations,
],
formDataOverrides: formData => ({
...formData,
groupby: getStandardizedControls().popAllColumns(),
metrics: getStandardizedControls().popAllMetrics(),
}),
};
export default config;

Binary file not shown.

Before

Width:  |  Height:  |  Size: 62 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 65 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 88 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 31 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 88 KiB

View File

@@ -1,62 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { t } from '@apache-superset/core/translation';
import { ChartMetadata, ChartPlugin, ChartLabel } from '@superset-ui/core';
import transformProps from '../transformProps';
import thumbnail from './images/thumbnail.png';
import thumbnailDark from './images/thumbnail-dark.png';
import example from './images/example.jpg';
import exampleDark from './images/example-dark.jpg';
import controlPanel from './controlPanel';
const metadata = new ChartMetadata({
category: t('Evolution'),
credits: ['http://nvd3.org'],
description: t(
'Visualizes many different time-series objects in a single chart. This chart is being deprecated and we recommend using the Time-series Chart instead.',
),
exampleGallery: [{ url: example, urlDark: exampleDark }],
label: ChartLabel.Deprecated,
name: t('Time-series Percent Change'),
tags: [
t('Legacy'),
t('Time'),
t('nvd3'),
t('Advanced-Analytics'),
t('Comparison'),
t('Line'),
t('Percentages'),
t('Predictive'),
t('Trend'),
],
thumbnail,
thumbnailDark,
useLegacyApi: true,
});
export default class CompareChartPlugin extends ChartPlugin {
constructor() {
super({
loadChart: () => import('../ReactNVD3'),
metadata,
transformProps,
controlPanel,
});
}
}

View File

@@ -1,208 +0,0 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { SuperChart, VizType } from '@superset-ui/core';
import { CompareChartPlugin } from '@superset-ui/legacy-preset-chart-nvd3';
import { dummyDatasource, withResizableChartDemo } from '@storybook-shared';
import data from './data';
new CompareChartPlugin().configure({ key: VizType.Compare }).register();
export default {
title: 'Legacy Chart Plugins/legacy-preset-chart-nvd3/Compare',
decorators: [withResizableChartDemo],
args: {
colorScheme: 'd3Category10',
contribution: false,
yLogScale: false,
},
argTypes: {
colorScheme: {
control: 'select',
options: [
'supersetColors',
'd3Category10',
'bnbColors',
'googleCategory20c',
],
},
contribution: {
control: 'boolean',
description: 'Compute contribution to total',
},
yLogScale: { control: 'boolean' },
},
};
export const Basic = ({
colorScheme,
contribution,
yLogScale,
width,
height,
}: {
colorScheme: string;
contribution: boolean;
yLogScale: boolean;
width: number;
height: number;
}) => (
<SuperChart
chartType="compare"
width={width}
height={height}
datasource={dummyDatasource}
queriesData={[{ data }]}
formData={{
bottom_margin: 'auto',
color_scheme: colorScheme,
contribution,
left_margin: 'auto',
viz_type: VizType.Compare,
x_axis_format: 'smart_date',
x_axis_label: '',
x_axis_showminmax: false,
x_ticks_layout: 'auto',
y_axis_bounds: [null, null],
y_axis_format: '.3s',
y_axis_label: '',
y_axis_showminmax: false,
y_log_scale: yLogScale,
}}
/>
);
/* eslint-disable no-magic-numbers */
const timeFormatData = [
{
key: ['Africa and Middle East'],
values: [
{ x: 1606348800000, y: 3985 },
{ x: 1606435200000, y: 5882 },
{ x: 1606521600000, y: 7983 },
{ x: 1606608000000, y: 16462 },
{ x: 1606694400000, y: 5542 },
{ x: 1606780800000, y: 2825 },
],
},
{
key: ['Asia'],
values: [
{ x: 1606348800000, y: 34837 },
{ x: 1606435200000, y: 40718 },
{ x: 1606521600000, y: 58507 },
{ x: 1606608000000, y: 110120 },
{ x: 1606694400000, y: 43443 },
{ x: 1606780800000, y: 33538 },
],
},
{
key: ['Australia'],
values: [
{ x: 1606348800000, y: 12975 },
{ x: 1606435200000, y: 18471 },
{ x: 1606521600000, y: 17880 },
{ x: 1606608000000, y: 52204 },
{ x: 1606694400000, y: 26690 },
{ x: 1606780800000, y: 16423 },
],
},
{
key: ['Europe'],
values: [
{ x: 1606348800000, y: 127029 },
{ x: 1606435200000, y: 177637 },
{ x: 1606521600000, y: 172653 },
{ x: 1606608000000, y: 203654 },
{ x: 1606694400000, y: 79200 },
{ x: 1606780800000, y: 45238 },
],
},
{
key: ['LatAm'],
values: [
{ x: 1606348800000, y: 22513 },
{ x: 1606435200000, y: 24594 },
{ x: 1606521600000, y: 32578 },
{ x: 1606608000000, y: 34733 },
{ x: 1606694400000, y: 71696 },
{ x: 1606780800000, y: 166611 },
],
},
{
key: ['North America'],
values: [
{ x: 1606348800000, y: 104596 },
{ x: 1606435200000, y: 109850 },
{ x: 1606521600000, y: 136873 },
{ x: 1606608000000, y: 133243 },
{ x: 1606694400000, y: 327739 },
{ x: 1606780800000, y: 162711 },
],
},
];
export const timeFormat = () => (
<SuperChart
chartType="compare"
width={400}
height={400}
datasource={dummyDatasource}
queriesData={[{ data: timeFormatData }]}
formData={{
datasource: '24771__table',
vizType: VizType.Compare,
urlParams: {},
timeRangeEndpoints: ['inclusive', 'exclusive'],
granularitySqla: '__time',
timeGrainSqla: 'P1D',
timeRange: 'Last week',
metrics: ['random_metric'],
adhocFilters: [],
groupby: ['dim_origin_region'],
timeseriesLimitMetric: null,
orderDesc: true,
contribution: false,
rowLimit: 10000,
colorScheme: 'd3Category10',
labelColors: {},
xAxisLabel: '',
bottomMargin: 'auto',
xTicksLayout: 'auto',
xAxisFormat: 'smart_date',
xAxisShowminmax: false,
yAxisLabel: '',
leftMargin: 'auto',
yAxisShowminmax: false,
yLogScale: false,
yAxisFormat: 'SMART_NUMBER',
yAxisBounds: [null, null],
rollingType: 'None',
comparisonType: 'values',
resampleRule: null,
resampleMethod: null,
annotationLayers: [],
appliedTimeExtras: {},
where: '',
having: '',
havingFilters: [],
filters: [],
}}
/>
);

View File

@@ -1,927 +0,0 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
/* eslint-disable sort-keys, no-magic-numbers */
export default [
{
key: ['Christopher'],
values: [
{
x: -157766400000.0,
y: 24703,
},
{
x: -126230400000.0,
y: 27861,
},
{
x: -94694400000.0,
y: 29436,
},
{
x: -63158400000.0,
y: 31463,
},
{
x: -31536000000.0,
y: 35718,
},
{
x: 0.0,
y: 41758,
},
{
x: 31536000000.0,
y: 48172,
},
{
x: 63072000000.0,
y: 52092,
},
{
x: 94694400000.0,
y: 48217,
},
{
x: 126230400000.0,
y: 48476,
},
{
x: 157766400000.0,
y: 46438,
},
{
x: 189302400000.0,
y: 45086,
},
{
x: 220924800000.0,
y: 46610,
},
{
x: 252460800000.0,
y: 47107,
},
{
x: 283996800000.0,
y: 50514,
},
{
x: 315532800000.0,
y: 48969,
},
{
x: 347155200000.0,
y: 50108,
},
{
x: 378691200000.0,
y: 59055,
},
{
x: 410227200000.0,
y: 59188,
},
{
x: 441763200000.0,
y: 59859,
},
{
x: 473385600000.0,
y: 59516,
},
{
x: 504921600000.0,
y: 56633,
},
{
x: 536457600000.0,
y: 54466,
},
{
x: 567993600000.0,
y: 52996,
},
{
x: 599616000000.0,
y: 53205,
},
{
x: 631152000000.0,
y: 52322,
},
{
x: 662688000000.0,
y: 47109,
},
{
x: 694224000000.0,
y: 42470,
},
{
x: 725846400000.0,
y: 38257,
},
{
x: 757382400000.0,
y: 34823,
},
{
x: 788918400000.0,
y: 32728,
},
{
x: 820454400000.0,
y: 30988,
},
{
x: 852076800000.0,
y: 29179,
},
{
x: 883612800000.0,
y: 27083,
},
{
x: 915148800000.0,
y: 25700,
},
{
x: 946684800000.0,
y: 24959,
},
{
x: 978307200000.0,
y: 23180,
},
{
x: 1009843200000.0,
y: 21731,
},
{
x: 1041379200000.0,
y: 20793,
},
{
x: 1072915200000.0,
y: 19739,
},
{
x: 1104537600000.0,
y: 19190,
},
{
x: 1136073600000.0,
y: 19674,
},
{
x: 1167609600000.0,
y: 19986,
},
{
x: 1199145600000.0,
y: 17771,
},
],
},
{
key: ['David'],
values: [
{
x: -157766400000.0,
y: 67646,
},
{
x: -126230400000.0,
y: 66207,
},
{
x: -94694400000.0,
y: 66581,
},
{
x: -63158400000.0,
y: 63531,
},
{
x: -31536000000.0,
y: 63502,
},
{
x: 0.0,
y: 61570,
},
{
x: 31536000000.0,
y: 52948,
},
{
x: 63072000000.0,
y: 46218,
},
{
x: 94694400000.0,
y: 40968,
},
{
x: 126230400000.0,
y: 41654,
},
{
x: 157766400000.0,
y: 39019,
},
{
x: 189302400000.0,
y: 39165,
},
{
x: 220924800000.0,
y: 40407,
},
{
x: 252460800000.0,
y: 40533,
},
{
x: 283996800000.0,
y: 41898,
},
{
x: 315532800000.0,
y: 41743,
},
{
x: 347155200000.0,
y: 40486,
},
{
x: 378691200000.0,
y: 40283,
},
{
x: 410227200000.0,
y: 39048,
},
{
x: 441763200000.0,
y: 38346,
},
{
x: 473385600000.0,
y: 38395,
},
{
x: 504921600000.0,
y: 37021,
},
{
x: 536457600000.0,
y: 36672,
},
{
x: 567993600000.0,
y: 35214,
},
{
x: 599616000000.0,
y: 35139,
},
{
x: 631152000000.0,
y: 33661,
},
{
x: 662688000000.0,
y: 30347,
},
{
x: 694224000000.0,
y: 28344,
},
{
x: 725846400000.0,
y: 26947,
},
{
x: 757382400000.0,
y: 24784,
},
{
x: 788918400000.0,
y: 22967,
},
{
x: 820454400000.0,
y: 22941,
},
{
x: 852076800000.0,
y: 21824,
},
{
x: 883612800000.0,
y: 20816,
},
{
x: 915148800000.0,
y: 20267,
},
{
x: 946684800000.0,
y: 19695,
},
{
x: 978307200000.0,
y: 19281,
},
{
x: 1009843200000.0,
y: 18600,
},
{
x: 1041379200000.0,
y: 18557,
},
{
x: 1072915200000.0,
y: 18315,
},
{
x: 1104537600000.0,
y: 18017,
},
{
x: 1136073600000.0,
y: 17510,
},
{
x: 1167609600000.0,
y: 17400,
},
{
x: 1199145600000.0,
y: 16049,
},
],
},
{
key: ['James'],
values: [
{
x: -157766400000.0,
y: 67506,
},
{
x: -126230400000.0,
y: 65036,
},
{
x: -94694400000.0,
y: 61554,
},
{
x: -63158400000.0,
y: 60584,
},
{
x: -31536000000.0,
y: 59824,
},
{
x: 0.0,
y: 61597,
},
{
x: 31536000000.0,
y: 54463,
},
{
x: 63072000000.0,
y: 46960,
},
{
x: 94694400000.0,
y: 42782,
},
{
x: 126230400000.0,
y: 41258,
},
{
x: 157766400000.0,
y: 39471,
},
{
x: 189302400000.0,
y: 38203,
},
{
x: 220924800000.0,
y: 39916,
},
{
x: 252460800000.0,
y: 39783,
},
{
x: 283996800000.0,
y: 39237,
},
{
x: 315532800000.0,
y: 39185,
},
{
x: 347155200000.0,
y: 38176,
},
{
x: 378691200000.0,
y: 38750,
},
{
x: 410227200000.0,
y: 36228,
},
{
x: 441763200000.0,
y: 35728,
},
{
x: 473385600000.0,
y: 35750,
},
{
x: 504921600000.0,
y: 33955,
},
{
x: 536457600000.0,
y: 32552,
},
{
x: 567993600000.0,
y: 32418,
},
{
x: 599616000000.0,
y: 32658,
},
{
x: 631152000000.0,
y: 32288,
},
{
x: 662688000000.0,
y: 30460,
},
{
x: 694224000000.0,
y: 28450,
},
{
x: 725846400000.0,
y: 26193,
},
{
x: 757382400000.0,
y: 24706,
},
{
x: 788918400000.0,
y: 22691,
},
{
x: 820454400000.0,
y: 21122,
},
{
x: 852076800000.0,
y: 20368,
},
{
x: 883612800000.0,
y: 19651,
},
{
x: 915148800000.0,
y: 18508,
},
{
x: 946684800000.0,
y: 17939,
},
{
x: 978307200000.0,
y: 17023,
},
{
x: 1009843200000.0,
y: 16905,
},
{
x: 1041379200000.0,
y: 16832,
},
{
x: 1072915200000.0,
y: 16459,
},
{
x: 1104537600000.0,
y: 16046,
},
{
x: 1136073600000.0,
y: 16139,
},
{
x: 1167609600000.0,
y: 15821,
},
{
x: 1199145600000.0,
y: 14920,
},
],
},
{
key: ['John'],
values: [
{
x: -157766400000.0,
y: 71390,
},
{
x: -126230400000.0,
y: 64858,
},
{
x: -94694400000.0,
y: 61480,
},
{
x: -63158400000.0,
y: 60754,
},
{
x: -31536000000.0,
y: 58644,
},
{
x: 0.0,
y: 58348,
},
{
x: 31536000000.0,
y: 51382,
},
{
x: 63072000000.0,
y: 43028,
},
{
x: 94694400000.0,
y: 39061,
},
{
x: 126230400000.0,
y: 37553,
},
{
x: 157766400000.0,
y: 34970,
},
{
x: 189302400000.0,
y: 33876,
},
{
x: 220924800000.0,
y: 34103,
},
{
x: 252460800000.0,
y: 33895,
},
{
x: 283996800000.0,
y: 35305,
},
{
x: 315532800000.0,
y: 35131,
},
{
x: 347155200000.0,
y: 34761,
},
{
x: 378691200000.0,
y: 34560,
},
{
x: 410227200000.0,
y: 33047,
},
{
x: 441763200000.0,
y: 32484,
},
{
x: 473385600000.0,
y: 31397,
},
{
x: 504921600000.0,
y: 30103,
},
{
x: 536457600000.0,
y: 29462,
},
{
x: 567993600000.0,
y: 29301,
},
{
x: 599616000000.0,
y: 29751,
},
{
x: 631152000000.0,
y: 29011,
},
{
x: 662688000000.0,
y: 27727,
},
{
x: 694224000000.0,
y: 26156,
},
{
x: 725846400000.0,
y: 24918,
},
{
x: 757382400000.0,
y: 24119,
},
{
x: 788918400000.0,
y: 23174,
},
{
x: 820454400000.0,
y: 22104,
},
{
x: 852076800000.0,
y: 21330,
},
{
x: 883612800000.0,
y: 20556,
},
{
x: 915148800000.0,
y: 20280,
},
{
x: 946684800000.0,
y: 20032,
},
{
x: 978307200000.0,
y: 18839,
},
{
x: 1009843200000.0,
y: 17400,
},
{
x: 1041379200000.0,
y: 17170,
},
{
x: 1072915200000.0,
y: 16381,
},
{
x: 1104537600000.0,
y: 15692,
},
{
x: 1136073600000.0,
y: 15083,
},
{
x: 1167609600000.0,
y: 14348,
},
{
x: 1199145600000.0,
y: 13110,
},
],
},
{
key: ['Michael'],
values: [
{
x: -157766400000.0,
y: 80812,
},
{
x: -126230400000.0,
y: 79709,
},
{
x: -94694400000.0,
y: 82204,
},
{
x: -63158400000.0,
y: 81785,
},
{
x: -31536000000.0,
y: 84893,
},
{
x: 0.0,
y: 85015,
},
{
x: 31536000000.0,
y: 77321,
},
{
x: 63072000000.0,
y: 71197,
},
{
x: 94694400000.0,
y: 67598,
},
{
x: 126230400000.0,
y: 67304,
},
{
x: 157766400000.0,
y: 68149,
},
{
x: 189302400000.0,
y: 66686,
},
{
x: 220924800000.0,
y: 67344,
},
{
x: 252460800000.0,
y: 66875,
},
{
x: 283996800000.0,
y: 67473,
},
{
x: 315532800000.0,
y: 68375,
},
{
x: 347155200000.0,
y: 68467,
},
{
x: 378691200000.0,
y: 67904,
},
{
x: 410227200000.0,
y: 67708,
},
{
x: 441763200000.0,
y: 67457,
},
{
x: 473385600000.0,
y: 64667,
},
{
x: 504921600000.0,
y: 63959,
},
{
x: 536457600000.0,
y: 63442,
},
{
x: 567993600000.0,
y: 63924,
},
{
x: 599616000000.0,
y: 65233,
},
{
x: 631152000000.0,
y: 65138,
},
{
x: 662688000000.0,
y: 60646,
},
{
x: 694224000000.0,
y: 54216,
},
{
x: 725846400000.0,
y: 49443,
},
{
x: 757382400000.0,
y: 44361,
},
{
x: 788918400000.0,
y: 41311,
},
{
x: 820454400000.0,
y: 38284,
},
{
x: 852076800000.0,
y: 37459,
},
{
x: 883612800000.0,
y: 36525,
},
{
x: 915148800000.0,
y: 33820,
},
{
x: 946684800000.0,
y: 31956,
},
{
x: 978307200000.0,
y: 29612,
},
{
x: 1009843200000.0,
y: 28156,
},
{
x: 1041379200000.0,
y: 27031,
},
{
x: 1072915200000.0,
y: 25418,
},
{
x: 1104537600000.0,
y: 23678,
},
{
x: 1136073600000.0,
y: 22498,
},
{
x: 1167609600000.0,
y: 21805,
},
{
x: 1199145600000.0,
y: 20271,
},
],
},
];

View File

@@ -1,549 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
/* eslint-disable react/jsx-key */
import { t } from '@apache-superset/core/translation';
import {
ControlPanelSectionConfig,
ControlSubSectionHeader,
CustomControlItem,
D3_TIME_FORMAT_OPTIONS,
D3_FORMAT_DOCS,
D3_FORMAT_OPTIONS,
DEFAULT_TIME_FORMAT,
} from '@superset-ui/chart-controls';
/*
Plugins in question:
AreaChartPlugin,
BarChartPlugin,
BubbleChartPlugin,
BulletChartPlugin,
CompareChartPlugin,
DistBarChartPlugin,
DualLineChartPlugin,
LineChartPlugin,
LineMultiChartPlugin,
PieChartPlugin,
TimePivotChartPlugin,
*/
export const yAxis2Format: CustomControlItem = {
name: 'y_axis_2_format',
config: {
type: 'SelectControl',
freeForm: true,
label: t('Right Axis Format'),
default: 'SMART_NUMBER',
choices: D3_FORMAT_OPTIONS,
description: D3_FORMAT_DOCS,
},
};
export const showMarkers: CustomControlItem = {
name: 'show_markers',
config: {
type: 'CheckboxControl',
label: t('Show Markers'),
renderTrigger: true,
default: false,
description: t('Show data points as circle markers on the lines'),
},
};
export const leftMargin: CustomControlItem = {
name: 'left_margin',
config: {
type: 'SelectControl',
freeForm: true,
clearable: false,
label: t('Left Margin'),
choices: [
['auto', t('auto')],
[50, '50'],
[75, '75'],
[100, '100'],
[125, '125'],
[150, '150'],
[200, '200'],
],
default: 'auto',
renderTrigger: true,
description: t(
'Left margin, in pixels, allowing for more room for axis labels',
),
},
};
export const yAxisShowMinmax: CustomControlItem = {
name: 'y_axis_showminmax',
config: {
type: 'CheckboxControl',
label: t('Y bounds'),
renderTrigger: true,
default: false,
description: t('Whether to display the min and max values of the Y-axis'),
},
};
export const yAxis2ShowMinmax: CustomControlItem = {
name: 'y_axis_2_showminmax',
config: {
type: 'CheckboxControl',
label: t('Y 2 bounds'),
renderTrigger: true,
default: false,
description: t('Whether to display the min and max values of the Y-axis'),
},
};
export const lineInterpolation: CustomControlItem = {
name: 'line_interpolation',
config: {
type: 'SelectControl',
label: t('Line Style'),
renderTrigger: true,
choices: [
['linear', t('linear')],
['basis', t('basis')],
['cardinal', t('cardinal')],
['monotone', t('monotone')],
['step-before', t('step-before')],
['step-after', t('step-after')],
],
default: 'linear',
description: t('Line interpolation as defined by d3.js'),
},
};
export const showBrush: CustomControlItem = {
name: 'show_brush',
config: {
type: 'SelectControl',
label: t('Show Range Filter'),
renderTrigger: true,
clearable: false,
default: 'auto',
choices: [
['yes', t('Yes')],
['no', t('No')],
['auto', t('Auto')],
],
description: t('Whether to display the time range interactive selector'),
},
};
export const showLegend: CustomControlItem = {
name: 'show_legend',
config: {
type: 'CheckboxControl',
label: t('Legend'),
renderTrigger: true,
default: true,
description: t('Whether to display the legend (toggles)'),
},
};
export const showControls: CustomControlItem = {
name: 'show_controls',
config: {
type: 'CheckboxControl',
label: t('Extra Controls'),
renderTrigger: true,
default: false,
description: t(
'Whether to show extra controls or not. Extra controls ' +
'include things like making multiBar charts stacked ' +
'or side by side.',
),
},
};
export const xAxisLabel: CustomControlItem = {
name: 'x_axis_label',
config: {
type: 'TextControl',
label: t('X Axis Label'),
renderTrigger: true,
default: '',
},
};
export const bottomMargin: CustomControlItem = {
name: 'bottom_margin',
config: {
type: 'SelectControl',
clearable: false,
freeForm: true,
label: t('Bottom Margin'),
choices: [
['auto', t('auto')],
[50, '50'],
[75, '75'],
[100, '100'],
[125, '125'],
[150, '150'],
[200, '200'],
],
default: 'auto',
renderTrigger: true,
description: t(
'Bottom margin, in pixels, allowing for more room for axis labels',
),
},
};
export const xTicksLayout: CustomControlItem = {
name: 'x_ticks_layout',
config: {
type: 'SelectControl',
label: t('X Tick Layout'),
choices: [
['auto', t('auto')],
['flat', t('flat')],
['45°', '45°'],
['staggered', t('staggered')],
],
default: 'auto',
clearable: false,
renderTrigger: true,
description: t('The way the ticks are laid out on the X-axis'),
},
};
export const xAxisFormat: CustomControlItem = {
name: 'x_axis_format',
config: {
type: 'SelectControl',
freeForm: true,
label: t('X Axis Format'),
renderTrigger: true,
choices: D3_TIME_FORMAT_OPTIONS,
default: DEFAULT_TIME_FORMAT,
description: D3_FORMAT_DOCS,
},
};
export const yLogScale: CustomControlItem = {
name: 'y_log_scale',
config: {
type: 'CheckboxControl',
label: t('Y Log Scale'),
default: false,
renderTrigger: true,
description: t('Use a log scale for the Y-axis'),
},
};
export const yAxisBounds: CustomControlItem = {
name: 'y_axis_bounds',
config: {
type: 'BoundsControl',
label: t('Y Axis Bounds'),
renderTrigger: true,
default: [null, null],
description: t(
'Bounds for the Y-axis. When left empty, the bounds are ' +
'dynamically defined based on the min/max of the data. Note that ' +
"this feature will only expand the axis range. It won't " +
"narrow the data's extent.",
),
},
};
export const yAxis2Bounds: CustomControlItem = {
name: 'y_axis_2_bounds',
config: {
type: 'BoundsControl',
label: t('Y Axis 2 Bounds'),
renderTrigger: true,
default: [null, null],
description: t(
'Bounds for the Y-axis. When left empty, the bounds are ' +
'dynamically defined based on the min/max of the data. Note that ' +
"this feature will only expand the axis range. It won't " +
"narrow the data's extent.",
),
},
};
export const xAxisShowMinmax: CustomControlItem = {
name: 'x_axis_showminmax',
config: {
type: 'CheckboxControl',
label: t('X bounds'),
renderTrigger: true,
default: false,
description: t('Whether to display the min and max values of the X-axis'),
},
};
export const richTooltip: CustomControlItem = {
name: 'rich_tooltip',
config: {
type: 'CheckboxControl',
label: t('Rich Tooltip'),
renderTrigger: true,
default: true,
description: t(
'The rich tooltip shows a list of all series for that point in time',
),
},
};
export const showBarValue: CustomControlItem = {
name: 'show_bar_value',
config: {
type: 'CheckboxControl',
label: t('Bar Values'),
default: false,
renderTrigger: true,
description: t('Show the value on top of the bar'),
},
};
export const barStacked: CustomControlItem = {
name: 'bar_stacked',
config: {
type: 'CheckboxControl',
label: t('Stacked Bars'),
renderTrigger: true,
default: false,
description: null,
},
};
export const reduceXTicks: CustomControlItem = {
name: 'reduce_x_ticks',
config: {
type: 'CheckboxControl',
label: t('Reduce X ticks'),
renderTrigger: true,
default: false,
description: t(
'Reduces the number of X-axis ticks to be rendered. ' +
'If true, the x-axis will not overflow and labels may be ' +
'missing. If false, a minimum width will be applied ' +
'to columns and the width may overflow into an ' +
'horizontal scroll.',
),
},
};
export const yAxisLabel: CustomControlItem = {
name: 'y_axis_label',
config: {
type: 'TextControl',
label: t('Y Axis Label'),
renderTrigger: true,
default: '',
},
};
export const timeSeriesSection: ControlPanelSectionConfig[] = [
{
label: t('Query'),
expanded: true,
controlSetRows: [
['metrics'],
['adhoc_filters'],
['groupby'],
['limit'],
['timeseries_limit_metric'],
['order_desc'],
[
{
name: 'contribution',
config: {
type: 'CheckboxControl',
label: t('Contribution'),
default: false,
description: t('Compute the contribution to the total'),
},
},
],
['row_limit', null],
],
},
{
label: t('Advanced Analytics'),
tabOverride: 'data',
description: t(
'This section contains options ' +
'that allow for advanced analytical post processing ' +
'of query results',
),
controlSetRows: [
[
<ControlSubSectionHeader>
{t('Rolling Window')}
</ControlSubSectionHeader>,
],
[
{
name: 'rolling_type',
config: {
type: 'SelectControl',
label: t('Rolling Function'),
default: 'None',
choices: [
['None', t('None')],
['mean', t('mean')],
['sum', t('sum')],
['std', t('std')],
['cumsum', t('cumsum')],
],
description: t(
'Defines a rolling window function to apply, works along ' +
'with the [Periods] text box',
),
},
},
],
[
{
name: 'rolling_periods',
config: {
type: 'TextControl',
label: t('Periods'),
isInt: true,
description: t(
'Defines the size of the rolling window function, ' +
'relative to the time granularity selected',
),
},
},
],
[
{
name: 'min_periods',
config: {
type: 'TextControl',
label: t('Min Periods'),
isInt: true,
description: t(
'The minimum number of rolling periods required to show ' +
'a value. For instance if you do a cumulative sum on 7 days ' +
'you may want your "Min Period" to be 7, so that all data points ' +
'shown are the total of 7 periods. This will hide the "ramp up" ' +
'taking place over the first 7 periods',
),
},
},
],
[
<ControlSubSectionHeader>
{t('Time Comparison')}
</ControlSubSectionHeader>,
],
[
{
name: 'time_compare',
config: {
type: 'SelectControl',
multi: true,
freeForm: true,
label: t('Time Shift'),
choices: [
['1 day', t('1 day')],
['1 week', t('1 week')],
['28 days', t('28 days')],
['30 days', t('30 days')],
['52 weeks', t('52 weeks')],
['1 year', t('1 year')],
['104 weeks', t('104 weeks')],
['2 years', t('2 years')],
['156 weeks', t('156 weeks')],
['3 years', t('3 years')],
],
description: t(
'Overlay one or more timeseries from a ' +
'relative time period. Expects relative time deltas ' +
'in natural language (example: 24 hours, 7 days, ' +
'52 weeks, 365 days). Free text is supported.',
),
},
},
],
[
{
name: 'comparison_type',
config: {
type: 'SelectControl',
label: t('Calculation type'),
default: 'values',
choices: [
['values', t('Actual Values')],
['absolute', t('Difference')],
['percentage', t('Percentage change')],
['ratio', t('Ratio')],
],
description: t(
'How to display time shifts: as individual lines; as the ' +
'difference between the main time series and each time shift; ' +
'as the percentage change; or as the ratio between series and time shifts.',
),
},
},
],
[<ControlSubSectionHeader>{t('Resample')}</ControlSubSectionHeader>],
[
{
name: 'resample_rule',
config: {
type: 'SelectControl',
freeForm: true,
label: t('Rule'),
default: null,
choices: [
['1T', t('1T')],
['1H', t('1H')],
['1D', t('1D')],
['7D', t('7D')],
['1M', t('1M')],
['1AS', t('1AS')],
],
description: t('Pandas resample rule'),
},
},
],
[
{
name: 'resample_method',
config: {
type: 'SelectControl',
freeForm: true,
label: t('Method'),
default: null,
choices: [
['asfreq', t('asfreq')],
['bfill', t('bfill')],
['ffill', t('ffill')],
['median', t('median')],
['mean', t('mean')],
['sum', t('sum')],
],
description: t('Pandas resample method'),
},
},
],
],
},
];

View File

@@ -1,82 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
/* eslint-disable react/sort-prop-types */
import PropTypes from 'prop-types';
import { ANNOTATION_TYPES } from './vendor/superset/AnnotationTypes';
export const numberOrAutoType = PropTypes.oneOfType([
PropTypes.number,
PropTypes.oneOf(['auto']),
]);
export const stringOrObjectWithLabelType = PropTypes.oneOfType([
PropTypes.string,
PropTypes.shape({
label: PropTypes.string,
}),
]);
export const rgbObjectType = PropTypes.shape({
r: PropTypes.number.isRequired,
g: PropTypes.number.isRequired,
b: PropTypes.number.isRequired,
});
export const numericXYType = PropTypes.shape({
x: PropTypes.number,
y: PropTypes.number,
});
export const categoryAndValueXYType = PropTypes.shape({
x: PropTypes.string,
y: PropTypes.number,
});
export const boxPlotValueType = PropTypes.shape({
outliers: PropTypes.arrayOf(PropTypes.number),
Q1: PropTypes.number,
Q2: PropTypes.number,
Q3: PropTypes.number,
whisker_high: PropTypes.number,
whisker_low: PropTypes.number,
});
export const bulletDataType = PropTypes.shape({
markerLabels: PropTypes.arrayOf(PropTypes.string),
markerLineLabels: PropTypes.arrayOf(PropTypes.string),
markerLines: PropTypes.arrayOf(PropTypes.number),
markers: PropTypes.arrayOf(PropTypes.number),
measures: PropTypes.arrayOf(PropTypes.number),
rangeLabels: PropTypes.arrayOf(PropTypes.string),
ranges: PropTypes.arrayOf(PropTypes.number),
});
export const annotationLayerType = PropTypes.shape({
annotationType: PropTypes.oneOf(Object.keys(ANNOTATION_TYPES)),
color: PropTypes.string,
hideLine: PropTypes.bool,
name: PropTypes.string,
opacity: PropTypes.string,
show: PropTypes.bool,
showMarkers: PropTypes.bool,
sourceType: PropTypes.string,
style: PropTypes.string,
value: PropTypes.oneOfType([PropTypes.number, PropTypes.string]),
width: PropTypes.number,
});

View File

@@ -1,189 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
// @ts-nocheck -- legacy reactified component with untyped `this` context from reactify callbacks
import { reactify } from '@superset-ui/core';
import { styled } from '@apache-superset/core/theme';
import PropTypes from 'prop-types';
import Component from './NVD3Vis';
import { hideTooltips, removeTooltip } from './utils';
function componentWillUnmount() {
const { id } = this.props;
if (id !== null && id !== undefined) {
removeTooltip(id);
} else {
hideTooltips(true);
}
}
const ReactNVD3 = reactify(Component, { componentWillUnmount });
const NVD3 = ({ className, ...otherProps }) => (
<div className={className}>
<ReactNVD3 {...otherProps} />
</div>
);
NVD3.propTypes = {
className: PropTypes.string.isRequired,
};
export default styled(NVD3)`
.superset-legacy-chart-nvd3-dist-bar,
.superset-legacy-chart-nvd3-bar {
overflow-x: auto !important;
svg {
&.nvd3-svg {
width: auto;
font-size: ${({ theme }) => theme.fontSize};
}
}
}
.superset-legacy-chart-nvd3 {
nv-x text {
font-size: ${({ theme }) => theme.fontSize};
}
g.superset path {
stroke-dasharray: 5, 5;
}
.nvtooltip {
table td {
font-size: @font-size-s !important;
}
}
.nvtooltip tr.highlight td {
font-weight: ${({ theme }) => theme.fontWeightStrong};
font-size: ${({ theme }) => theme.fontSize}px !important;
}
text.nv-axislabel {
font-size: ${({ theme }) => theme.fontSize} !important;
}
g.nv-axis text {
fill: ${({ theme }) => theme.colorText};
}
g.nv-series text {
fill: ${({ theme }) => theme.colorText};
}
g.solid path,
line.solid {
stroke-dasharray: unset;
}
g.dashed path,
line.dashed {
stroke-dasharray: 5, 5;
}
g.longDashed path,
line.dotted {
stroke-dasharray: 1, 1;
}
g.opacityLow path,
line.opacityLow {
stroke-opacity: 0.2;
}
g.opacityMedium path,
line.opacityMedium {
stroke-opacity: 0.5;
}
g.opacityHigh path,
line.opacityHigh {
stroke-opacity: 0.8;
}
g.time-shift-0 path,
line.time-shift-0 {
stroke-dasharray: 5, 5;
}
g.time-shift-1 path,
line.time-shift-1 {
stroke-dasharray: 1, 5;
}
g.time-shift-2 path,
line.time-shift-3 {
stroke-dasharray: 5, 1;
}
g.time-shift-3 path,
line.time-shift-3 {
stroke-dasharray: 5, 1;
}
g.time-shift-4 path,
line.time-shift-4 {
stroke-dasharray: 5, 10;
}
g.time-shift-5 path,
line.time-shift-5 {
stroke-dasharray: 0.9;
}
g.time-shift-6 path,
line.time-shift-6 {
stroke-dasharray: 15, 10, 5;
}
g.time-shift-7 path,
line.time-shift-7 {
stroke-dasharray: 15, 10, 5, 10;
}
g.time-shift-8 path,
line.time-shift-8 {
stroke-dasharray: 15, 10, 5, 10, 15;
}
g.time-shift-9 path,
line.time-shift-9 {
stroke-dasharray: 5, 5, 1, 5;
}
.nv-noData.body {
font-size: ${({ theme }) => theme.fontSize};
font-weight: ${({ theme }) => theme.fontWeightNormal};
}
}
.superset-legacy-chart-nvd3-tr-highlight {
border-top: 1px solid;
border-bottom: 1px solid;
font-weight: ${({ theme }) => theme.fontWeightStrong};
}
.superset-legacy-chart-nvd3-tr-total {
font-weight: ${({ theme }) => theme.fontWeightStrong};
}
.nvtooltip {
.tooltip-header {
white-space: nowrap;
font-weight: ${({ theme }) => theme.fontWeightStrong};
}
tbody tr:not(.tooltip-header) td:nth-of-type(2) {
word-break: break-word;
}
}
.d3-tip.nv-event-annotation-layer-table,
.d3-tip.nv-event-annotation-layer-NATIVE {
width: 200px;
border-radius: 2px;
background-color: ${({ theme }) => theme.colorBgContainer};
fill-opacity: 0.6;
margin: ${({ theme }) => theme.sizeUnit * 2}px;
padding: ${({ theme }) => theme.sizeUnit * 2}px;
color: ${({ theme }) => theme.colorTextLightSolid};
&:after {
content: '\\25BC';
font-size: ${({ theme }) => theme.fontSize};
color: ${({ theme }) => theme.colorText};
position: absolute;
bottom: -14px;
left: 94px;
}
}
`;

View File

@@ -1,134 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { t } from '@apache-superset/core/translation';
import { QueryFormData } from '@superset-ui/core';
import {
ControlPanelConfig,
D3_FORMAT_OPTIONS,
getStandardizedControls,
sections,
} from '@superset-ui/chart-controls';
import {
lineInterpolation,
showLegend,
xAxisLabel,
bottomMargin,
xAxisFormat,
yLogScale,
yAxisBounds,
xAxisShowMinmax,
yAxisShowMinmax,
yAxisLabel,
leftMargin,
} from '../NVD3Controls';
const config: ControlPanelConfig = {
controlPanelSections: [
sections.legacyTimeseriesTime,
{
label: t('Query'),
expanded: true,
controlSetRows: [
['metric'],
['adhoc_filters'],
[
{
name: 'freq',
config: {
type: 'SelectControl',
label: t('Frequency'),
default: 'W-MON',
freeForm: true,
clearable: false,
choices: [
['AS', t('Year (freq=AS)')],
['52W-MON', t('52 weeks starting Monday (freq=52W-MON)')],
['W-SUN', t('1 week starting Sunday (freq=W-SUN)')],
['W-MON', t('1 week starting Monday (freq=W-MON)')],
['D', t('Day (freq=D)')],
['4W-MON', t('4 weeks (freq=4W-MON)')],
],
description: t(
`The periodicity over which to pivot time. Users can provide
"Pandas" offset alias.
Click on the info bubble for more details on accepted "freq" expressions.`,
),
tooltipOnClick: () => {
window.open(
'https://pandas.pydata.org/pandas-docs/stable/timeseries.html#offset-aliases',
);
},
},
},
],
],
},
{
label: t('Chart Options'),
expanded: true,
controlSetRows: [
[showLegend],
[lineInterpolation],
['color_picker', null],
],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
[xAxisLabel],
[bottomMargin],
[xAxisShowMinmax],
[
{
name: xAxisFormat.name,
config: {
...xAxisFormat.config,
default: 'SMART_NUMBER',
choices: D3_FORMAT_OPTIONS,
},
},
],
],
},
{
label: t('Y Axis'),
expanded: true,
controlSetRows: [
[yAxisLabel],
[leftMargin],
[yAxisShowMinmax],
[yLogScale],
['y_axis_format'],
[yAxisBounds],
],
},
],
controlOverrides: {
metric: {
clearable: false,
},
},
formDataOverrides: (formData: QueryFormData) => ({
...formData,
metric: getStandardizedControls().shiftMetric(),
}),
};
export default config;

Binary file not shown.

Before

Width:  |  Height:  |  Size: 134 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 129 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 25 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 11 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 26 KiB

View File

@@ -1,51 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { t } from '@apache-superset/core/translation';
import { ChartMetadata, ChartPlugin } from '@superset-ui/core';
import transformProps from '../transformProps';
import thumbnail from './images/thumbnail.png';
import thumbnailDark from './images/thumbnail-dark.png';
import example from './images/example.jpg';
import exampleDark from './images/example-dark.jpg';
import controlPanel from './controlPanel';
const metadata = new ChartMetadata({
category: t('Evolution'),
credits: ['http://nvd3.org'],
description: t(
'Compares metrics between different time periods. Displays time series data across multiple periods (like weeks or months) to show period-over-period trends and patterns.',
),
exampleGallery: [{ url: example, urlDark: exampleDark }],
name: t('Time-series Period Pivot'),
tags: [t('Legacy'), t('Time'), t('nvd3')],
thumbnail,
thumbnailDark,
useLegacyApi: true,
});
export default class TimePivotChartPlugin extends ChartPlugin {
constructor() {
super({
loadChart: () => import('../ReactNVD3'),
metadata,
transformProps,
controlPanel,
});
}
}

View File

@@ -1,37 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { Preset, VizType } from '@superset-ui/core';
import BubbleChartPlugin from './Bubble';
import BulletChartPlugin from './Bullet';
import CompareChartPlugin from './Compare';
import TimePivotChartPlugin from './TimePivot';
export default class NVD3ChartPreset extends Preset {
constructor() {
super({
name: 'NVD3 charts',
plugins: [
new BubbleChartPlugin().configure({ key: VizType.LegacyBubble }),
new BulletChartPlugin().configure({ key: VizType.Bullet }),
new CompareChartPlugin().configure({ key: VizType.Compare }),
new TimePivotChartPlugin().configure({ key: VizType.TimePivot }),
],
});
}
}

View File

@@ -1,206 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
// @ts-nocheck -- legacy transformProps with loosely-typed formData from ChartProps
import { ChartProps, VizType } from '@superset-ui/core';
import isTruthy from './utils/isTruthy';
import {
tokenizeToNumericArray,
tokenizeToStringArray,
} from './utils/tokenize';
import { formatLabel } from './utils';
const NOOP = () => {};
interface DatasourceMetric {
d3format?: string;
metric_name?: string;
}
interface NVD3Datasource {
metrics?: DatasourceMetric[];
verboseMap?: Record<string, string>;
}
const grabD3Format = (
datasource: NVD3Datasource | undefined,
targetMetric: string,
): string | undefined => {
let foundFormatter: string | undefined;
const { metrics = [] } = datasource || {};
metrics.forEach(metric => {
if (metric.d3format && metric.metric_name === targetMetric) {
foundFormatter = metric.d3format;
}
});
return foundFormatter;
};
export default function transformProps(chartProps: ChartProps) {
const {
width,
height,
annotationData,
datasource,
formData,
hooks,
queriesData,
} = chartProps;
const { onAddFilter = NOOP, onError = NOOP } = hooks;
const {
annotationLayers,
barStacked,
bottomMargin,
colorPicker,
colorScheme,
comparisonType,
contribution,
donut,
entity,
labelsOutside,
leftMargin,
lineInterpolation,
maxBubbleSize,
metric,
orderBars,
pieLabelType,
reduceXTicks,
richTooltip,
sendTimeRange,
showBarValue,
showBrush,
showControls,
showLabels,
showLegend,
showMarkers,
size,
stackedStyle,
vizType,
x,
xAxisFormat,
xAxisLabel,
xAxisShowminmax,
xLogScale,
xTicksLayout,
y,
yAxisBounds,
yAxis2Bounds,
yAxisLabel,
yAxisFormat,
yAxisShowminmax,
yAxis2Showminmax,
yLogScale,
sliceId,
} = formData;
let {
markerLabels,
markerLines,
markerLineLabels,
markers,
numberFormat,
rangeLabels,
ranges,
} = formData;
const rawData = queriesData[0].data || [];
const data = Array.isArray(rawData)
? rawData.map(row => ({
...row,
values: Array.isArray(row.values)
? row.values.map(value => ({ ...value }))
: row.values,
key: formatLabel(row.key, datasource.verboseMap),
}))
: rawData;
if (vizType === VizType.Pie) {
numberFormat = numberFormat || grabD3Format(datasource, metric);
} else if (vizType === VizType.Bullet) {
ranges = tokenizeToNumericArray(ranges) || [0, data.measures * 1.1];
rangeLabels = tokenizeToStringArray(rangeLabels);
markerLabels = tokenizeToStringArray(markerLabels);
markerLines = tokenizeToNumericArray(markerLines);
markerLineLabels = tokenizeToStringArray(markerLineLabels);
markers = tokenizeToNumericArray(markers);
}
return {
width,
height,
data,
annotationData,
annotationLayers,
areaStackedStyle: stackedStyle,
baseColor: colorPicker,
bottomMargin,
colorScheme,
comparisonType,
contribution,
entity,
isBarStacked: barStacked,
isDonut: donut,
isPieLabelOutside: labelsOutside,
leftMargin,
lineInterpolation,
markerLabels,
markerLines,
markerLineLabels,
markers,
maxBubbleSize: parseInt(maxBubbleSize, 10),
numberFormat,
onBrushEnd: isTruthy(sendTimeRange)
? timeRange => {
onAddFilter('__time_range', timeRange, false, true);
}
: undefined,
onError,
orderBars,
pieLabelType,
rangeLabels,
ranges,
reduceXTicks,
showBarValue,
showBrush,
showControls,
showLabels,
showLegend,
showMarkers,
sizeField: size,
useRichTooltip: richTooltip,
vizType,
xAxisFormat,
xAxisLabel,
xAxisShowMinMax: xAxisShowminmax,
xField: x,
xIsLogScale: xLogScale,
xTicksLayout,
yAxisFormat,
yAxisBounds,
yAxis2Bounds,
yAxisLabel,
yAxisShowMinMax: yAxisShowminmax,
yAxis2ShowMinMax: yAxis2Showminmax,
yField: y,
yIsLogScale: yLogScale,
sliceId,
};
}

View File

@@ -1,354 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
// @ts-nocheck -- legacy file heavily dependent on untyped d3 v3 and nvd3 APIs
import d3 from 'd3';
import d3tip from 'd3-tip';
import dompurify from 'dompurify';
import {
SMART_DATE_ID,
getTimeFormatter,
getNumberFormatter,
} from '@superset-ui/core';
// Regexp for the label added to time shifted series
// (1 hour offset, 2 days offset, etc.)
const TIME_SHIFT_PATTERN = /\d+ \w+ offset/;
const ANIMATION_TIME = 1000;
export function cleanColorInput(value) {
// for superset series that should have the same color
return String(value)
.trim()
.replace(' (right axis)', '')
.split(', ')
.filter(k => !TIME_SHIFT_PATTERN.test(k))
.join(', ');
}
/**
* If format is smart_date, format date
* Otherwise, format number with the given format name
* @param {*} format
*/
export function getTimeOrNumberFormatter(format) {
return format === SMART_DATE_ID
? getTimeFormatter(SMART_DATE_ID)
: getNumberFormatter(format);
}
export function drawBarValues(svg, data, stacked, axisFormat) {
const format = getNumberFormatter(axisFormat);
const countSeriesDisplayed = data.filter(d => !d.disabled).length;
const totalStackedValues =
stacked && data.length !== 0
? data[0].values.map((bar, iBar) => {
const bars = data
.filter(series => !series.disabled)
.map(series => series.values[iBar]);
return d3.sum(bars, d => d.y);
})
: [];
svg.selectAll('.bar-chart-label-group').remove();
setTimeout(() => {
svg.selectAll('.bar-chart-label-group').remove();
const groupLabels = svg
.select('g.nv-barsWrap')
.append('g')
.attr('class', 'bar-chart-label-group');
svg
.selectAll('g.nv-group')
.filter((d, i) => !stacked || i === countSeriesDisplayed - 1)
.selectAll('rect')
.each(function each(d, index) {
const rectObj = d3.select(this);
const transformAttr = rectObj.attr('transform');
const xPos = parseFloat(rectObj.attr('x'));
const yPos = parseFloat(rectObj.attr('y'));
const rectWidth = parseFloat(rectObj.attr('width'));
const rectHeight = parseFloat(rectObj.attr('height'));
const textEls = groupLabels
.append('text')
.text(format(stacked ? totalStackedValues[index] : d.y))
.attr('transform', transformAttr)
.attr('class', 'bar-chart-label');
// fine tune text position
const bbox = textEls.node().getBBox();
const labelWidth = bbox.width;
const labelHeight = bbox.height;
textEls.attr('x', xPos + rectWidth / 2 - labelWidth / 2);
if (rectObj.attr('class').includes('positive')) {
textEls.attr('y', yPos - 5);
} else {
textEls.attr('y', yPos + rectHeight + labelHeight);
}
});
}, ANIMATION_TIME);
}
// Formats the series key to account for a possible NULL value
function getFormattedKey(seriesKey, shouldDompurify) {
if (seriesKey === '<NULL>') {
return `&lt;${seriesKey.slice(1, -1)}&gt;`;
}
return shouldDompurify ? dompurify.sanitize(seriesKey) : seriesKey;
}
export function generateCompareTooltipContent(d, valueFormatter) {
let tooltip = '';
tooltip +=
"<table><thead><tr><td colspan='3'>" +
`<strong class='x-value'>${d.value}</strong>` +
'</td></tr></thead><tbody>';
d.series.sort((a, b) => (a.value >= b.value ? -1 : 1));
d.series.forEach(series => {
const key = getFormattedKey(series.key, true);
tooltip +=
`<tr class="${series.highlight ? 'emph' : ''}">` +
`<td class='legend-color-guide' style="opacity: ${
series.highlight ? '1' : '0.75'
};"">` +
'<div ' +
`style="border: 2px solid ${
series.highlight ? 'black' : 'transparent'
}; background-color: ${series.color};"` +
'></div>' +
'</td>' +
`<td>${key}</td>` +
`<td>${valueFormatter(series.value)}</td>` +
'</tr>';
});
tooltip += '</tbody></table>';
return dompurify.sanitize(tooltip);
}
export function generateMultiLineTooltipContent(d, xFormatter, yFormatters) {
const tooltipTitle = xFormatter(d.value);
let tooltip = '';
tooltip +=
"<table><thead><tr><td colspan='3'>" +
`<strong class='x-value'>${tooltipTitle}</strong>` +
'</td></tr></thead><tbody>';
d.series.forEach((series, i) => {
const yFormatter = yFormatters[i];
const key = getFormattedKey(series.key, true);
tooltip +=
"<tr><td class='legend-color-guide'>" +
`<div style="background-color: ${series.color};"></div></td>` +
`<td class='key'>${key}</td>` +
`<td class='value'>${yFormatter(series.value)}</td></tr>`;
});
tooltip += '</tbody></table>';
return dompurify.sanitize(tooltip);
}
export function generateTimePivotTooltip(d, xFormatter, yFormatter) {
const tooltipTitle = xFormatter(d.value);
let tooltip = '';
tooltip +=
"<table><thead><tr><td colspan='3'>" +
`<strong class='x-value'>${tooltipTitle}</strong>` +
'</td></tr></thead><tbody>';
d.series.forEach(series => {
if (series.highlight) {
let label = '';
if (series.key === 'current') {
label = series.key;
} else {
label = `${series.key} of the selected frequency:`;
}
tooltip +=
"<tr><td class='legend-color-guide'>" +
`<div style="background-color: ${series.color};"></div></td>` +
`<td class='key'>${label}</td>` +
`<td class='value'>${yFormatter(series.value)}</td></tr>`;
}
});
tooltip += '</tbody></table>';
return dompurify.sanitize(tooltip);
}
function getLabel(stringOrObjectWithLabel) {
return stringOrObjectWithLabel.label || stringOrObjectWithLabel;
}
function createHTMLRow(col1, col2) {
return `<tr><td>${col1}</td><td>${col2}</td></tr>`;
}
export function generateBubbleTooltipContent({
point,
entity,
xField,
yField,
sizeField,
xFormatter,
yFormatter,
sizeFormatter,
}) {
let s = '<table>';
s +=
`<tr><td style="color: ${point.color};">` +
`<strong>${point[entity]}</strong> (${point.group})` +
'</td></tr>';
s += createHTMLRow(getLabel(xField), xFormatter(point.x));
s += createHTMLRow(getLabel(yField), yFormatter(point.y));
s += createHTMLRow(getLabel(sizeField), sizeFormatter(point.size));
s += '</table>';
return dompurify.sanitize(s);
}
// shouldRemove indicates whether the nvtooltips should be removed from the DOM
export function hideTooltips(shouldRemove) {
const targets = document.querySelectorAll('.nvtooltip');
if (targets.length > 0) {
// Only set opacity to 0 when hiding tooltips so they would reappear
// on hover, which sets the opacity to 1
targets.forEach(t => {
if (shouldRemove) {
t.remove();
} else {
// eslint-disable-next-line no-param-reassign
t.style.opacity = 0;
}
});
}
}
export function generateTooltipClassName(uuid) {
return `tooltip-${uuid}`;
}
export function removeTooltip(uuid) {
const classSelector = `.${generateTooltipClassName(uuid)}`;
const target = document.querySelector(classSelector);
if (target) {
target.remove();
}
}
export function wrapTooltip(chart) {
const tooltipLayer =
chart.useInteractiveGuideline && chart.useInteractiveGuideline()
? chart.interactiveLayer
: chart;
const tooltipGeneratorFunc = tooltipLayer.tooltip.contentGenerator();
tooltipLayer.tooltip.contentGenerator(d => {
// The nvd3-fork default contentGenerator builds tooltip HTML with
// unescaped series keys (and feeds them into the tooltip's `.html()`
// sink at render time). Run the final string through DOMPurify so
// charts that do NOT install a custom contentGenerator (Line, Bar,
// Area, Pie, BoxPlot, etc.) cannot execute stored payloads in
// column or series names. Custom contentGenerators set elsewhere in
// this module already return sanitized output, making this a
// belt-and-braces wrap.
const tooltip = `<div>${tooltipGeneratorFunc(d)}</div>`;
return dompurify.sanitize(tooltip);
});
}
// Builds the sanitized HTML for an annotation layer's tooltip. Title and
// description values come from the annotation data source, so the output is
// run through dompurify before being inserted into the DOM by d3-tip.
export function generateAnnotationTooltipContent(layer, d) {
const title =
d[layer.titleColumn] && d[layer.titleColumn].length > 0
? `${d[layer.titleColumn]} - ${layer.name}`
: layer.name;
const body = Array.isArray(layer.descriptionColumns)
? layer.descriptionColumns.map(c => d[c])
: Object.values(d);
return dompurify.sanitize(
`<div><strong>${title}</strong></div><br/><div>${body.join(', ')}</div>`,
);
}
export function tipFactory(layer) {
return d3tip()
.attr('class', `d3-tip ${layer.annotationTipClass || ''}`)
.direction('n')
.offset([-5, 0])
.html(d => (d ? generateAnnotationTooltipContent(layer, d) : ''));
}
export function getMaxLabelSize(svg, axisClass) {
// axis class = .nv-y2 // second y axis on dual line chart
// axis class = .nv-x // x axis on time series line chart
const tickTexts = svg.selectAll(`.${axisClass} g.tick text`);
if (tickTexts.length > 0) {
const lengths = tickTexts[0].map(text => text.getComputedTextLength());
return Math.ceil(Math.max(0, ...lengths));
}
return 0;
}
export function formatLabel(input, verboseMap = {}) {
// The input for label may be a string or an array of string
// When using the time shift feature, the label contains a '---' in the array
const verboseLookup = s => verboseMap[s] || s;
return Array.isArray(input) && input.length > 0
? input
.map(l => (TIME_SHIFT_PATTERN.test(l) ? l : verboseLookup(l)))
.join(', ')
: verboseLookup(input);
}
export function stringifyTimeRange(extent) {
if (extent.some(d => d.toISOString === undefined)) {
return null;
}
return extent.map(d => d.toISOString().slice(0, -1)).join(' : ');
}
export function setAxisShowMaxMin(axis, showminmax) {
if (axis && axis.showMaxMin && showminmax !== undefined) {
axis.showMaxMin(showminmax);
}
}
export function computeYDomain(data) {
if (Array.isArray(data) && data.length > 0 && Array.isArray(data[0].values)) {
const extents = data
.filter(d => !d.disabled)
.map(row => d3.extent(row.values, v => v.y));
const minOfMin = d3.min(extents, ([min]) => min);
const maxOfMax = d3.max(extents, ([, max]) => max);
return [minOfMin, maxOfMax];
}
return [0, 1];
}

View File

@@ -1,86 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
// @ts-nocheck -- vendor file; not fully typed
import { t } from '@apache-superset/core/translation';
function extractTypes(metadata) {
return Object.keys(metadata).reduce((prev, key) => {
const result = prev;
result[key] = key;
return result;
}, {});
}
export const ANNOTATION_TYPES_METADATA = {
FORMULA: {
value: 'FORMULA',
label: t('Formula'),
},
EVENT: {
value: 'EVENT',
label: t('Event'),
supportNativeSource: true,
},
INTERVAL: {
value: 'INTERVAL',
label: t('Interval'),
supportNativeSource: true,
},
TIME_SERIES: {
value: 'TIME_SERIES',
label: t('Time Series'),
},
};
export const ANNOTATION_TYPES = extractTypes(ANNOTATION_TYPES_METADATA);
export const DEFAULT_ANNOTATION_TYPE = ANNOTATION_TYPES.FORMULA;
export const ANNOTATION_SOURCE_TYPES_METADATA = {
NATIVE: {
value: 'NATIVE',
label: 'Superset annotation',
},
};
export const ANNOTATION_SOURCE_TYPES = extractTypes(
ANNOTATION_SOURCE_TYPES_METADATA,
);
export function requiresQuery(annotationSourceType) {
return !!annotationSourceType;
}
const NATIVE_COLUMN_NAMES = {
descriptionColumns: ['long_descr'],
intervalEndColumn: 'end_dttm',
timeColumn: 'start_dttm',
titleColumn: 'short_descr',
};
export function applyNativeColumns(annotation) {
if (annotation.sourceType === ANNOTATION_SOURCE_TYPES.NATIVE) {
return { ...annotation, ...NATIVE_COLUMN_NAMES };
}
return annotation;
}
export default ANNOTATION_TYPES;

View File

@@ -1,69 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
// @ts-nocheck -- vendor file; not fully typed
/* eslint camelcase: 0 */
import URI from 'urijs';
import safeStringify from 'fast-safe-stringify';
const MAX_URL_LENGTH = 8000;
export function getURIDirectory(formData, endpointType = 'base') {
// Building the directory part of the URI
let directory = '/explore/';
if (['json', 'csv', 'query', 'results', 'samples'].includes(endpointType)) {
directory = '/superset/explore_json/';
}
return directory;
}
export function getExploreLongUrl(
formData,
endpointType,
allowOverflow = true,
extraSearch = {},
) {
if (!formData.datasource) {
return null;
}
const uri = new URI('/');
const directory = getURIDirectory(formData, endpointType);
const search = uri.search(true);
Object.keys(extraSearch).forEach(key => {
search[key] = extraSearch[key];
});
search.form_data = safeStringify(formData);
if (endpointType === 'standalone') {
search.standalone = 'true';
}
const url = uri.directory(directory).search(search).toString();
if (!allowOverflow && url.length > MAX_URL_LENGTH) {
const minimalFormData = {
datasource: formData.datasource,
viz_type: formData.viz_type,
};
return getExploreLongUrl(minimalFormData, endpointType, false, {
URL_IS_TOO_LONG_TO_SHARE: null,
});
}
return url;
}

View File

@@ -1,57 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { SqlaFormData } from '@superset-ui/core';
import * as ChartControls from '@superset-ui/chart-controls';
import controlPanel from '../../src/TimePivot/controlPanel';
const { __mockShiftMetric } = ChartControls as typeof ChartControls & {
__mockShiftMetric: jest.Mock;
};
jest.mock('@superset-ui/core', () => ({
...jest.requireActual('@superset-ui/core'),
t: (str: string) => str,
}));
jest.mock('@superset-ui/chart-controls', () => {
const original = jest.requireActual('@superset-ui/chart-controls');
const mockShiftMetric = jest.fn(() => 'shiftedMetric');
return {
...original,
getStandardizedControls: () => ({
shiftMetric: mockShiftMetric,
}),
__mockShiftMetric: mockShiftMetric,
};
});
describe('TimePivot Control Panel Config', () => {
test('should override formData metric using getStandardizedControls', () => {
const dummyFormData = { someProp: 'test' } as unknown as SqlaFormData;
const newFormData = controlPanel.formDataOverrides!(dummyFormData);
// The original properties are spread correctly.
expect(newFormData.someProp).toBe('test');
// The metric property should be replaced by the output of shiftMetric.
expect(newFormData.metric).toBe('shiftedMetric');
// Ensure that the mockShiftMetric function was called.
expect(__mockShiftMetric).toHaveBeenCalled();
});
});

View File

@@ -1,358 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import {
getTimeFormatterRegistry,
SMART_DATE_ID,
createSmartDateFormatter,
} from '@superset-ui/core';
import {
computeYDomain,
generateAnnotationTooltipContent,
generateBubbleTooltipContent,
generateMultiLineTooltipContent,
getTimeOrNumberFormatter,
formatLabel,
tipFactory,
} from '../src/utils';
const DATA = [
{
key: ['East Asia & Pacific'],
values: [
{
x: -315619200000.0,
y: 1031863394.0,
},
{
x: -283996800000.0,
y: 1034767718.0,
},
],
},
{
key: ['South Asia'],
values: [
{
x: -315619200000.0,
y: 572036107.0,
},
{
x: -283996800000.0,
y: 584143236.0,
},
],
},
{
key: ['Europe & Central Asia'],
values: [
{
x: -315619200000.0,
y: 660881033.0,
},
{
x: -283996800000.0,
y: 668526708.0,
},
],
},
];
const DATA_WITH_DISABLED_SERIES = [
{
disabled: true,
key: ['East Asia & Pacific'],
values: [
{
x: -315619200000.0,
y: 1031863394.0,
},
{
x: -283996800000.0,
y: 1034767718.0,
},
],
},
{
disabled: true,
key: ['South Asia'],
values: [
{
x: -315619200000.0,
y: 572036107.0,
},
{
x: -283996800000.0,
y: 584143236.0,
},
],
},
{
key: ['Europe & Central Asia'],
values: [
{
x: -315619200000.0,
y: 660881033.0,
},
{
x: -283996800000.0,
y: 668526708.0,
},
],
},
];
describe('nvd3/utils', () => {
beforeEach(() => {
getTimeFormatterRegistry().registerValue(
SMART_DATE_ID,
createSmartDateFormatter(),
);
});
describe('generateMultiLineTooltipContent()', () => {
const identity = (value: any) => value;
test('renders the series key in the tooltip markup', () => {
const tooltip = generateMultiLineTooltipContent(
{
value: 'x-value',
series: [{ key: 'Region A', color: '#fff', value: 1 }],
},
identity,
[identity],
);
expect(tooltip).toContain('Region A');
});
test('strips a script payload from a malicious series key', () => {
const tooltip = generateMultiLineTooltipContent(
{
value: 'x-value',
series: [
{
key: '<img src=x onerror="alert(1)">',
color: '#fff',
value: 1,
},
],
},
identity,
[identity],
);
// DOMPurify removes the event handler that would execute on render.
expect(tooltip).not.toContain('onerror');
expect(tooltip).not.toContain('alert(1)');
});
});
describe('getTimeOrNumberFormatter(format)', () => {
test('is a function', () => {
expect(typeof getTimeOrNumberFormatter).toBe('function');
});
test('returns a date formatter if format is smart_date', () => {
const time = new Date(Date.UTC(2018, 10, 21, 22, 11));
// @ts-expect-error -- getTimeOrNumberFormatter doesn't distinguish return types; accepts Date at runtime
expect(getTimeOrNumberFormatter('smart_date')(time)).toBe('10:11');
});
test('returns a number formatter otherwise', () => {
expect(getTimeOrNumberFormatter('.3s')(3000000)).toBe('3.00M');
expect(getTimeOrNumberFormatter(undefined)(3000100)).toBe('3M');
});
});
describe('formatLabel()', () => {
const verboseMap = {
foo: 'Foo',
bar: 'Bar',
};
test('formats simple labels', () => {
expect(formatLabel('foo')).toBe('foo');
expect(formatLabel(['foo'])).toBe('foo');
expect(formatLabel(['foo', 'bar'])).toBe('foo, bar');
});
test('formats simple labels with lookups', () => {
expect(formatLabel('foo', verboseMap)).toBe('Foo');
expect(formatLabel('baz', verboseMap)).toBe('baz');
expect(formatLabel(['foo'], verboseMap)).toBe('Foo');
expect(formatLabel(['foo', 'bar', 'baz'], verboseMap)).toBe(
'Foo, Bar, baz',
);
});
test('deals with time shift properly', () => {
expect(formatLabel(['foo', '1 hour offset'], verboseMap)).toBe(
'Foo, 1 hour offset',
);
expect(
formatLabel(['foo', 'bar', 'baz', '2 hours offset'], verboseMap),
).toBe('Foo, Bar, baz, 2 hours offset');
});
});
describe('computeYDomain()', () => {
test('works with invalid data', () => {
expect(computeYDomain('foo')).toEqual([0, 1]);
});
test('works with all series enabled', () => {
expect(computeYDomain(DATA)).toEqual([572036107.0, 1034767718.0]);
});
test('works with some series disabled', () => {
expect(computeYDomain(DATA_WITH_DISABLED_SERIES)).toEqual([
660881033.0, 668526708.0,
]);
});
});
// ------------------------------------------------------------------
// Tooltip HTML sanitisation (XSS regression).
// Each helper below feeds user-controlled column values into a
// d3 / nvd3 .html() sink; the sanitised return must strip dangerous
// markup so a stored payload cannot execute on hover.
// ------------------------------------------------------------------
describe('generateBubbleTooltipContent() sanitises user input', () => {
test('strips <script> from the entity column', () => {
const html = generateBubbleTooltipContent({
point: {
color: 'red',
group: 'g',
entity: '<script>alert(1)</script>',
x: 1,
y: 2,
size: 3,
},
entity: 'entity',
xField: 'x',
yField: 'y',
sizeField: 'size',
xFormatter: (v: number) => String(v),
yFormatter: (v: number) => String(v),
sizeFormatter: (v: number) => String(v),
});
expect(html).not.toMatch(/<script/i);
expect(html).not.toMatch(/onerror=/i);
});
test('strips <img onerror> injected via the group column', () => {
const html = generateBubbleTooltipContent({
point: {
color: 'red',
group: '<img src=x onerror=alert(1)>',
entity: 'safe',
x: 1,
y: 2,
size: 3,
},
entity: 'entity',
xField: 'x',
yField: 'y',
sizeField: 'size',
xFormatter: (v: number) => String(v),
yFormatter: (v: number) => String(v),
sizeFormatter: (v: number) => String(v),
});
expect(html).not.toMatch(/onerror/i);
});
});
describe('generateMultiLineTooltipContent() sanitises user input', () => {
test('strips <script> from a series key', () => {
const html = generateMultiLineTooltipContent(
{
value: 0,
series: [
{
key: '<script>alert(1)</script>',
color: 'red',
value: 1,
},
],
},
(v: number) => String(v),
[(v: number) => String(v)],
);
expect(html).not.toMatch(/<script/i);
});
});
describe('tipFactory() sanitises annotation columns', () => {
test('strips <script> from a description column value', () => {
const tip = tipFactory({
annotationTipClass: 'foo',
titleColumn: 'title',
descriptionColumns: ['desc'],
name: 'layer',
});
// d3-tip's .html(fn) stores the callback as the renderer; invoke
// it directly to assert the sanitised output.
const datum = {
title: 'normal',
desc: '<script>alert(1)</script>payload',
};
const html = tip.html()(datum);
expect(html).not.toMatch(/<script/i);
expect(html).toContain('payload');
});
});
describe('generateAnnotationTooltipContent()', () => {
const layer = {
name: 'My annotations',
titleColumn: 'title',
descriptionColumns: ['description'],
};
test('renders the annotation title and description', () => {
const html = generateAnnotationTooltipContent(layer, {
title: 'Release',
description: 'Shipped v1',
});
expect(html).toContain('Release - My annotations');
expect(html).toContain('Shipped v1');
});
test('falls back to the layer name when the title column is empty', () => {
const html = generateAnnotationTooltipContent(layer, {
title: '',
description: 'Shipped v1',
});
expect(html).toContain('My annotations');
});
test('strips an event-handler payload from the title column', () => {
const html = generateAnnotationTooltipContent(layer, {
title: '<img src=x onerror="alert(1)">',
description: 'ok',
});
expect(html).not.toContain('onerror');
expect(html).not.toContain('alert(1)');
});
test('strips a script payload from a description column', () => {
const html = generateAnnotationTooltipContent(layer, {
title: 'Release',
description: '<script>alert(document.cookie)</script>',
});
expect(html).not.toContain('<script>');
});
});
});

View File

@@ -1,57 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import isTruthy from '../../src/utils/isTruthy';
describe('isTruthy', () => {
test('evals false-looking strings properly', () => {
expect(isTruthy('f')).toBe(false);
expect(isTruthy('false')).toBe(false);
expect(isTruthy('no')).toBe(false);
expect(isTruthy('n')).toBe(false);
expect(isTruthy('F')).toBe(false);
expect(isTruthy('False')).toBe(false);
expect(isTruthy('NO')).toBe(false);
expect(isTruthy('N')).toBe(false);
});
test('evals true-looking strings properly', () => {
expect(isTruthy('t')).toBe(true);
expect(isTruthy('true')).toBe(true);
expect(isTruthy('yes')).toBe(true);
expect(isTruthy('y')).toBe(true);
expect(isTruthy('Y')).toBe(true);
expect(isTruthy('True')).toBe(true);
expect(isTruthy('Yes')).toBe(true);
expect(isTruthy('YES')).toBe(true);
});
test('evals bools properly', () => {
expect(isTruthy(false)).toBe(false);
expect(isTruthy(true)).toBe(true);
});
test('evals ints properly', () => {
expect(isTruthy(0)).toBe(false);
expect(isTruthy(1)).toBe(true);
});
test('evals constants properly', () => {
expect(isTruthy(null)).toBe(false);
expect(isTruthy(undefined)).toBe(false);
});
test('string auto is false', () => {
expect(isTruthy('false')).toBe(false);
});
});

View File

@@ -1,76 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import {
tokenizeToNumericArray,
tokenizeToStringArray,
} from '../../src/utils/tokenize';
describe('tokenizeToNumericArray', () => {
test('evals numeric strings properly', () => {
expect(tokenizeToNumericArray('1')).toStrictEqual([1]);
expect(tokenizeToNumericArray('1,2,3,4')).toStrictEqual([1, 2, 3, 4]);
expect(tokenizeToNumericArray('1.1,2.2,3.0,4')).toStrictEqual([
1.1, 2.2, 3, 4,
]);
expect(tokenizeToNumericArray(' 1, 2, 3, 4 ')).toStrictEqual([
1, 2, 3, 4,
]);
});
test('evals undefined to null', () => {
expect(tokenizeToNumericArray(undefined)).toBeNull();
});
test('evals empty strings to null', () => {
expect(tokenizeToNumericArray('')).toBeNull();
expect(tokenizeToNumericArray(' ')).toBeNull();
});
test('throws error on incorrect string', () => {
expect(() => tokenizeToNumericArray('qwerty,1,2,3')).toThrow(Error);
});
});
describe('tokenizeToStringArray', () => {
test('evals numeric strings properly', () => {
expect(tokenizeToStringArray('a')).toStrictEqual(['a']);
expect(tokenizeToStringArray('1.1 , 2.2, 3.0 ,4')).toStrictEqual([
'1.1',
'2.2',
'3.0',
'4',
]);
expect(tokenizeToStringArray('1.1,a,3, bc ,d')).toStrictEqual([
'1.1',
'a',
'3',
'bc',
'd',
]);
});
test('evals undefined to null', () => {
expect(tokenizeToStringArray(undefined)).toBeNull();
});
test('evals empty string to null', () => {
expect(tokenizeToStringArray('')).toBeNull();
expect(tokenizeToStringArray(' ')).toBeNull();
});
});

View File

@@ -1,21 +0,0 @@
{
"extends": "../../tsconfig.json",
"compilerOptions": {
// Path Resolution: Override baseUrl to maintain correct path mappings from parent config
// (e.g., "@apache-superset/core" -> "./packages/superset-core/src")
"baseUrl": "../..",
// Directory Overrides: Parent config paths are relative to frontend root,
// but packages need paths relative to their own directory
"outDir": "lib",
"rootDir": "src",
"declarationDir": "lib"
},
"include": ["src/**/*", "types/**/*"],
"exclude": ["src/**/*.test.*", "src/**/*.stories.*"],
"references": [
{ "path": "../../packages/superset-core" },
{ "path": "../../packages/superset-ui-core" },
{ "path": "../../packages/superset-ui-chart-controls" }
]
}

Binary file not shown.

Before

Width:  |  Height:  |  Size: 32 KiB

View File

@@ -17,10 +17,10 @@ specific language governing permissions and limitations
under the License.
-->
## @superset-ui/legacy-plugin-chart-calendar
## @superset-ui/plugin-chart-calendar
[![Version](https://img.shields.io/npm/v/@superset-ui/legacy-plugin-chart-calendar.svg?style=flat)](https://www.npmjs.com/package/@superset-ui/legacy-plugin-chart-calendar)
[![Libraries.io](https://img.shields.io/librariesio/release/npm/%40superset-ui%2Flegacy-plugin-chart-calendar?style=flat)](https://libraries.io/npm/@superset-ui%2Flegacy-plugin-chart-calendar)
[![Version](https://img.shields.io/npm/v/@superset-ui/plugin-chart-calendar.svg?style=flat)](https://www.npmjs.com/package/@superset-ui/plugin-chart-calendar)
[![Libraries.io](https://img.shields.io/librariesio/release/npm/%40superset-ui%2Fplugin-chart-calendar?style=flat)](https://libraries.io/npm/@superset-ui%2Fplugin-chart-calendar)
This plugin provides Calendar Heatmap for Superset.
@@ -30,7 +30,7 @@ Configure `key`, which can be any `string`, and register the plugin. This `key`
lookup this chart throughout the app.
```js
import CalendarChartPlugin from '@superset-ui/legacy-plugin-chart-calendar';
import CalendarChartPlugin from '@superset-ui/plugin-chart-calendar';
new CalendarChartPlugin().configure({ key: 'calendar' }).register();
```

View File

@@ -1,18 +1,18 @@
{
"name": "@superset-ui/legacy-plugin-chart-calendar",
"name": "@superset-ui/plugin-chart-calendar",
"version": "0.20.3",
"description": "Superset Legacy Chart - Calendar Heatmap",
"keywords": [
"superset"
],
"homepage": "https://github.com/apache/superset/tree/master/superset-frontend/plugins/legacy-plugin-chart-calendar#readme",
"homepage": "https://github.com/apache/superset/tree/master/superset-frontend/plugins/plugin-chart-calendar#readme",
"bugs": {
"url": "https://github.com/apache/superset/issues"
},
"repository": {
"type": "git",
"url": "https://github.com/apache/superset.git",
"directory": "superset-frontend/plugins/legacy-plugin-chart-calendar"
"directory": "superset-frontend/plugins/plugin-chart-calendar"
},
"license": "Apache-2.0",
"author": "Superset",

Some files were not shown because too many files have changed in this diff Show More