Compare commits

...
Author SHA1 Message Date
Elizabeth Thompson b6088ee86c fix(examples): replace deprecated groupby field with columns in birth_names/world_bank
DEPRECATED_FIELDS maps groupby -> columns (superset/common/query_object.py).
#43422/#43432 already migrated timeseries_limit_metric and granularity_sqla
in these same fixtures but missed the sibling groupby field, on both the
.py slice-creation defaults and the exported .yaml chart configs.
2026-08-24 16:11:34 +00:00
21 changed files with 36 additions and 36 deletions
+11 -11
View File
@@ -177,7 +177,7 @@ def create_slices(tbl: SqlaTable) -> tuple[list[Slice], list[Slice]]:
"compare_suffix": "o10Y",
"limit": "25",
"granularity_sqla": "ds",
"groupby": [],
"columns": [],
"row_limit": current_app.config["ROW_LIMIT"],
"time_range": "100 years ago : now",
"viz_type": "table",
@@ -225,7 +225,7 @@ def create_slices(tbl: SqlaTable) -> tuple[list[Slice], list[Slice]]:
slice_name="Genders",
viz_type="pie",
params=get_slice_json(
defaults, viz_type="pie", groupby=["gender"], metric=metric
defaults, viz_type="pie", columns=["gender"], metric=metric
),
editors=[],
),
@@ -236,7 +236,7 @@ def create_slices(tbl: SqlaTable) -> tuple[list[Slice], list[Slice]]:
params=get_slice_json(
defaults,
viz_type="echarts_timeseries_line",
groupby=["name"],
columns=["name"],
granularity_sqla="ds",
rich_tooltip=True,
show_legend=True,
@@ -277,7 +277,7 @@ def create_slices(tbl: SqlaTable) -> tuple[list[Slice], list[Slice]]:
"optionName": "metric_12",
},
],
groupby=["state"],
columns=["state"],
),
editors=[],
),
@@ -287,7 +287,7 @@ def create_slices(tbl: SqlaTable) -> tuple[list[Slice], list[Slice]]:
viz_type="table",
params=get_slice_json(
defaults,
groupby=["name"],
columns=["name"],
adhoc_filters=[gen_filter("gender", "girl")],
row_limit=50,
series_limit_metric=metric,
@@ -318,7 +318,7 @@ def create_slices(tbl: SqlaTable) -> tuple[list[Slice], list[Slice]]:
viz_type="table",
params=get_slice_json(
defaults,
groupby=["name"],
columns=["name"],
adhoc_filters=[gen_filter("gender", "boy")],
row_limit=50,
series_limit_metric=metric,
@@ -351,7 +351,7 @@ def create_slices(tbl: SqlaTable) -> tuple[list[Slice], list[Slice]]:
defaults,
adhoc_filters=[gen_filter("gender", "girl")],
comparison_type="values",
groupby=["name"],
columns=["name"],
limit=10,
stacked_style="expand",
time_grain_sqla="P1D",
@@ -369,7 +369,7 @@ def create_slices(tbl: SqlaTable) -> tuple[list[Slice], list[Slice]]:
defaults,
adhoc_filters=[gen_filter("gender", "boy")],
comparison_type="values",
groupby=["name"],
columns=["name"],
limit=10,
stacked_style="expand",
time_grain_sqla="P1D",
@@ -441,7 +441,7 @@ def create_slices(tbl: SqlaTable) -> tuple[list[Slice], list[Slice]]:
viz_type="table",
params=get_slice_json(
defaults,
groupby=["ds"],
columns=["ds"],
time_range="1983 : 2023",
viz_type="table",
metrics=metrics,
@@ -497,7 +497,7 @@ def create_slices(tbl: SqlaTable) -> tuple[list[Slice], list[Slice]]:
],
viz_type="echarts_timeseries_line",
granularity_sqla="ds",
groupby=["name"],
columns=["name"],
series_limit_metric={
"expressionType": "SIMPLE",
"column": {
@@ -520,7 +520,7 @@ def create_slices(tbl: SqlaTable) -> tuple[list[Slice], list[Slice]]:
params=get_slice_json(
defaults,
metrics=metrics,
groupby=["name"],
columns=["name"],
row_limit=50,
series_limit_metric={
"expressionType": "SIMPLE",
@@ -29,7 +29,7 @@ params:
compare_lag: '10'
compare_suffix: o10Y
granularity_sqla: ds
groupby: []
columns: []
limit: '100'
markup_type: markdown
metric: sum__num
@@ -29,7 +29,7 @@ params:
compare_lag: '10'
compare_suffix: o10Y
granularity_sqla: ds
groupby:
columns:
- name
limit: '25'
markup_type: markdown
@@ -23,7 +23,7 @@ params:
compare_lag: '10'
compare_suffix: o10Y
granularity_sqla: ds
groupby:
columns:
- gender
limit: '25'
markup_type: markdown
@@ -31,7 +31,7 @@ params:
compare_lag: '10'
compare_suffix: o10Y
granularity_sqla: ds
groupby:
columns:
- state
limit: '25'
markup_type: markdown
@@ -29,7 +29,7 @@ params:
compare_lag: '10'
compare_suffix: o10Y
granularity_sqla: ds
groupby: []
columns: []
limit: '100'
markup_type: markdown
metric: sum__num
@@ -29,7 +29,7 @@ params:
compare_lag: '10'
compare_suffix: o10Y
granularity_sqla: ds
groupby:
columns:
- name
limit: '25'
markup_type: markdown
@@ -23,7 +23,7 @@ params:
compare_lag: '5'
compare_suffix: over 5Y
granularity_sqla: ds
groupby: []
columns: []
limit: '25'
markup_type: markdown
metric: sum__num
@@ -23,7 +23,7 @@ params:
compare_lag: '10'
compare_suffix: o10Y
granularity_sqla: ds
groupby: []
columns: []
groupbyColumns:
- state
groupbyRows:
@@ -30,7 +30,7 @@ params:
compare_suffix: o10Y
comparison_type: values
granularity_sqla: ds
groupby:
columns:
- name
limit: 10
markup_type: markdown
@@ -30,7 +30,7 @@ params:
compare_suffix: o10Y
comparison_type: values
granularity_sqla: ds
groupby:
columns:
- name
limit: 10
markup_type: markdown
@@ -23,7 +23,7 @@ params:
compare_lag: '10'
compare_suffix: o10Y
granularity_sqla: ds
groupby:
columns:
- name
limit: '25'
markup_type: markdown
+6 -6
View File
@@ -155,7 +155,7 @@ def create_slices(tbl: BaseDatasource) -> list[Slice]:
"compare_suffix": "o10Y",
"limit": "25",
"granularity_sqla": "year",
"groupby": [],
"columns": [],
"row_limit": current_app.config["ROW_LIMIT"],
"since": "2014-01-01",
"until": "2014-01-02",
@@ -190,7 +190,7 @@ def create_slices(tbl: BaseDatasource) -> list[Slice]:
defaults,
viz_type="table",
metrics=["sum__SP_POP_TOTL"],
groupby=["country_name"],
columns=["country_name"],
),
),
Slice(
@@ -204,7 +204,7 @@ def create_slices(tbl: BaseDatasource) -> list[Slice]:
since="1960-01-01",
metrics=["sum__SP_POP_TOTL"],
num_period_compare="10",
groupby=["country_name"],
columns=["country_name"],
),
),
Slice(
@@ -289,7 +289,7 @@ def create_slices(tbl: BaseDatasource) -> list[Slice]:
since="1960-01-01",
until="now",
viz_type="echarts_area",
groupby=["region"],
columns=["region"],
metrics=metrics,
),
),
@@ -305,7 +305,7 @@ def create_slices(tbl: BaseDatasource) -> list[Slice]:
whisker_options="Min/max (no outliers)",
x_ticks_layout="staggered",
viz_type="box_plot",
groupby=["region"],
columns=["region"],
metrics=metrics,
),
),
@@ -320,7 +320,7 @@ def create_slices(tbl: BaseDatasource) -> list[Slice]:
until="now",
viz_type="treemap_v2",
metric="sum__SP_POP_TOTL",
groupby=["region", "country_code"],
columns=["region", "country_code"],
),
),
Slice(
@@ -25,7 +25,7 @@ params:
country_fieldtype: cca3
entity: country_code
granularity_sqla: year
groupby:
columns:
- region
limit: '25'
markup_type: markdown
@@ -25,7 +25,7 @@ params:
country_fieldtype: cca3
entity: country_code
granularity_sqla: year
groupby:
columns:
- country_name
limit: '25'
markup_type: markdown
@@ -25,7 +25,7 @@ params:
country_fieldtype: cca3
entity: country_code
granularity_sqla: year
groupby:
columns:
- country_name
limit: '25'
markup_type: markdown
@@ -25,7 +25,7 @@ params:
country_fieldtype: cca3
entity: country_code
granularity_sqla: year
groupby: []
columns: []
limit: '25'
markup_type: markdown
metric: sum__SP_RUR_TOTL_ZS
@@ -28,7 +28,7 @@ params:
country_fieldtype: cca3
entity: country_code
granularity_sqla: year
groupby: []
columns: []
limit: '25'
markup_type: markdown
metric: sum__SP_POP_TOTL
@@ -25,7 +25,7 @@ params:
country_fieldtype: cca3
entity: country_code
granularity_sqla: year
groupby:
columns:
- region
- country_code
limit: '25'
@@ -25,7 +25,7 @@ params:
country_fieldtype: cca3
entity: country_code
granularity_sqla: year
groupby:
columns:
- region
limit: '25'
markup_type: markdown
@@ -25,7 +25,7 @@ params:
country_fieldtype: cca3
entity: country_code
granularity_sqla: year
groupby: []
columns: []
limit: '25'
markup_type: markdown
metric: sum__SP_POP_TOTL