fix(filters): preserve backend metric-based sorting in select filters (#35130)

Co-authored-by: Claude <noreply@anthropic.com>

.github/workflows/bashlib.sh

@@ -182,76 +182,6 @@ cypress-run-all() {
   kill $flaskProcessId
 }
 
-playwright-install() {
-  cd "$GITHUB_WORKSPACE/superset-frontend"
-
-  say "::group::Install Playwright browsers"
-  npx playwright install --with-deps chromium
-  # Create output directories for test results and debugging
-  mkdir -p playwright-results
-  mkdir -p test-results
-  say "::endgroup::"
-}
-
-playwright-run() {
-  local APP_ROOT=$1
-
-  # Start Flask from the project root (same as Cypress)
-  cd "$GITHUB_WORKSPACE"
-  local flasklog="${HOME}/flask-playwright.log"
-  local port=8081
-  PLAYWRIGHT_BASE_URL="http://localhost:${port}"
-  if [ -n "$APP_ROOT" ]; then
-    export SUPERSET_APP_ROOT=$APP_ROOT
-    PLAYWRIGHT_BASE_URL=${PLAYWRIGHT_BASE_URL}${APP_ROOT}/
-  fi
-  export PLAYWRIGHT_BASE_URL
-
-  nohup flask run --no-debugger -p $port >"$flasklog" 2>&1 </dev/null &
-  local flaskProcessId=$!
-
-  # Ensure cleanup on exit
-  trap "kill $flaskProcessId 2>/dev/null || true" EXIT
-
-  # Wait for server to be ready with health check
-  local timeout=60
-  say "Waiting for Flask server to start on port $port..."
-  while [ $timeout -gt 0 ]; do
-    if curl -f ${PLAYWRIGHT_BASE_URL}/health >/dev/null 2>&1; then
-      say "Flask server is ready"
-      break
-    fi
-    sleep 1
-    timeout=$((timeout - 1))
-  done
-
-  if [ $timeout -eq 0 ]; then
-    echo "::error::Flask server failed to start within 60 seconds"
-    echo "::group::Flask startup log"
-    cat "$flasklog"
-    echo "::endgroup::"
-    return 1
-  fi
-
-  # Change to frontend directory for Playwright execution
-  cd "$GITHUB_WORKSPACE/superset-frontend"
-
-  say "::group::Run Playwright tests"
-  echo "Running Playwright with baseURL: ${PLAYWRIGHT_BASE_URL}"
-  npx playwright test auth/login --reporter=github --output=playwright-results
-  local status=$?
-  say "::endgroup::"
-
-  # After job is done, print out Flask log for debugging
-  echo "::group::Flask log for Playwright run"
-  cat "$flasklog"
-  echo "::endgroup::"
-  # make sure the program exits
-  kill $flaskProcessId
-
-  return $status
-}
-
 eyes-storybook-dependencies() {
   say "::group::install eyes-storyook dependencies"
   sudo apt-get update -y && sudo apt-get -y install gconf-service ca-certificates libxshmfence-dev fonts-liberation libappindicator3-1 libasound2 libatk-bridge2.0-0 libatk1.0-0 libc6 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgbm1 libgcc1 libgconf-2-4 libglib2.0-0 libgdk-pixbuf2.0-0 libgtk-3-0 libnspr4 libnss3 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 lsb-release xdg-utils libappindicator1

.github/workflows/showtime-trigger.yml

@@ -61,8 +61,17 @@ jobs:
             console.log(`📊 Permission level for ${actor}: ${permission.permission}`);
             const authorized = ['write', 'admin'].includes(permission.permission);
 
-            // If this is a synchronize event from unauthorized user, check if Showtime is active and set blocked label
-            if (!authorized && context.eventName === 'pull_request_target' && context.payload.action === 'synchronize') {
+            if (!authorized) {
+              console.log(`🚨 Unauthorized user ${actor} - skipping all operations`);
+              core.setOutput('authorized', 'false');
+              return;
+            }
+
+            console.log(`✅ Authorized maintainer: ${actor}`);
+            core.setOutput('authorized', 'true');
+
+            // If this is a synchronize event, check if Showtime is active and set blocked label
+            if (context.eventName === 'pull_request_target' && context.payload.action === 'synchronize') {
               console.log(`🔒 Synchronize event detected - checking if Showtime is active`);
 
               // Check if PR has any circus tent labels (Showtime is in use)
@@ -90,15 +99,6 @@ jobs:
               }
             }
 
-            if (!authorized) {
-              console.log(`🚨 Unauthorized user ${actor} - skipping all operations`);
-              core.setOutput('authorized', 'false');
-              return;
-            }
-
-            console.log(`✅ Authorized maintainer: ${actor}`);
-            core.setOutput('authorized', 'true');
-
       - name: Install Superset Showtime
         if: steps.auth.outputs.authorized == 'true'
         run: |

.github/workflows/superset-frontend.yml

@@ -143,7 +143,7 @@ jobs:
       - name: tsc
         run: |
           docker run --rm $TAG bash -c \
-          "npm run plugins:build && npm run type"
+          "npm run type"
 
   validate-frontend:
     needs: frontend-build

.github/workflows/superset-playwright.yml

@@ -1,141 +0,0 @@
-name: Playwright E2E Tests
-
-on:
-  push:
-    branches:
-      - "master"
-      - "[0-9].[0-9]*"
-  pull_request:
-    types: [synchronize, opened, reopened, ready_for_review]
-  workflow_dispatch:
-    inputs:
-      ref:
-        description: 'The branch or tag to checkout'
-        required: false
-        default: ''
-      pr_id:
-        description: 'The pull request ID to checkout'
-        required: false
-        default: ''
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
-  cancel-in-progress: true
-
-jobs:
-  playwright-tests:
-    runs-on: ubuntu-22.04
-    # Allow workflow to succeed even if tests fail during shadow mode
-    continue-on-error: true
-    permissions:
-      contents: read
-      pull-requests: read
-    strategy:
-      fail-fast: false
-      matrix:
-        browser: ["chromium"]
-        app_root: ["", "/app/prefix"]
-    env:
-      SUPERSET_ENV: development
-      SUPERSET_CONFIG: tests.integration_tests.superset_test_config
-      SUPERSET__SQLALCHEMY_DATABASE_URI: postgresql+psycopg2://superset:superset@127.0.0.1:15432/superset
-      PYTHONPATH: ${{ github.workspace }}
-      REDIS_PORT: 16379
-      GITHUB_TOKEN: ${{ github.token }}
-    services:
-      postgres:
-        image: postgres:16-alpine
-        env:
-          POSTGRES_USER: superset
-          POSTGRES_PASSWORD: superset
-        ports:
-          - 15432:5432
-      redis:
-        image: redis:7-alpine
-        ports:
-          - 16379:6379
-    steps:
-      # -------------------------------------------------------
-      # Conditional checkout based on context (same as Cypress workflow)
-      - name: Checkout for push or pull_request event
-        if: github.event_name == 'push' || github.event_name == 'pull_request'
-        uses: actions/checkout@v5
-        with:
-          persist-credentials: false
-          submodules: recursive
-          ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
-      - name: Checkout using ref (workflow_dispatch)
-        if: github.event_name == 'workflow_dispatch' && github.event.inputs.ref != ''
-        uses: actions/checkout@v5
-        with:
-          persist-credentials: false
-          ref: ${{ github.event.inputs.ref }}
-          submodules: recursive
-      - name: Checkout using PR ID (workflow_dispatch)
-        if: github.event_name == 'workflow_dispatch' && github.event.inputs.pr_id != ''
-        uses: actions/checkout@v5
-        with:
-          persist-credentials: false
-          ref: refs/pull/${{ github.event.inputs.pr_id }}/merge
-          submodules: recursive
-      # -------------------------------------------------------
-      - name: Check for file changes
-        id: check
-        uses: ./.github/actions/change-detector/
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
-      - name: Setup Python
-        uses: ./.github/actions/setup-backend/
-        if: steps.check.outputs.python || steps.check.outputs.frontend
-      - name: Setup postgres
-        if: steps.check.outputs.python || steps.check.outputs.frontend
-        uses: ./.github/actions/cached-dependencies
-        with:
-          run: setup-postgres
-      - name: Import test data
-        if: steps.check.outputs.python || steps.check.outputs.frontend
-        uses: ./.github/actions/cached-dependencies
-        with:
-          run: testdata
-      - name: Setup Node.js
-        if: steps.check.outputs.python || steps.check.outputs.frontend
-        uses: actions/setup-node@v4
-        with:
-          node-version-file: './superset-frontend/.nvmrc'
-      - name: Install npm dependencies
-        if: steps.check.outputs.python || steps.check.outputs.frontend
-        uses: ./.github/actions/cached-dependencies
-        with:
-          run: npm-install
-      - name: Build javascript packages
-        if: steps.check.outputs.python || steps.check.outputs.frontend
-        uses: ./.github/actions/cached-dependencies
-        with:
-          run: build-instrumented-assets
-      - name: Install Playwright
-        if: steps.check.outputs.python || steps.check.outputs.frontend
-        uses: ./.github/actions/cached-dependencies
-        with:
-          run: playwright-install
-      - name: Run Playwright
-        if: steps.check.outputs.python || steps.check.outputs.frontend
-        uses: ./.github/actions/cached-dependencies
-        env:
-          NODE_OPTIONS: "--max-old-space-size=4096"
-        with:
-          run: playwright-run ${{ matrix.app_root }}
-      - name: Set safe app root
-        if: failure()
-        id: set-safe-app-root
-        run: |
-          APP_ROOT="${{ matrix.app_root }}"
-          SAFE_APP_ROOT=${APP_ROOT//\//_}
-          echo "safe_app_root=$SAFE_APP_ROOT" >> $GITHUB_OUTPUT
-      - name: Upload Playwright Artifacts
-        uses: actions/upload-artifact@v4
-        if: failure()
-        with:
-          path: |
-            ${{ github.workspace }}/superset-frontend/playwright-results/
-            ${{ github.workspace }}/superset-frontend/test-results/
-          name: playwright-artifact-${{ github.run_id }}-${{ github.job }}-${{ matrix.browser }}--${{ steps.set-safe-app-root.outputs.safe_app_root }}

LLMS.md

@@ -15,9 +15,8 @@ Apache Superset is a data visualization platform with Flask/Python backend and R
 
 ### Testing Strategy Migration
 - **Prefer unit tests** over integration tests
-- **Prefer integration tests** over end-to-end tests
-- **Use Playwright for E2E tests** - Migrating from Cypress
-- **Cypress is deprecated** - Will be removed once migration is completed
+- **Prefer integration tests** over Cypress end-to-end tests
+- **Cypress is last resort** - Actively moving away from Cypress
 - **Use Jest + React Testing Library** for component testing
 - **Use `test()` instead of `describe()`** - Follow [avoid nesting when testing](https://kentcdodds.com/blog/avoid-nesting-when-youre-testing) principles
 
@@ -108,18 +107,6 @@ superset/
 npm run test                           # All tests
 npm run test -- filename.test.tsx     # Single file
 
-# E2E Tests (Playwright - NEW)
-npm run playwright:test                # All Playwright tests
-npm run playwright:ui                  # Interactive UI mode
-npm run playwright:headed              # See browser during tests
-npx playwright test tests/auth/login.spec.ts  # Single file
-npm run playwright:debug tests/auth/login.spec.ts  # Debug specific file
-
-# E2E Tests (Cypress - DEPRECATED)
-cd superset-frontend/cypress-base
-npm run cypress-run-chrome             # All Cypress tests (headless)
-npm run cypress-debug                  # Interactive Cypress UI
-
 # Backend  
 pytest                                 # All tests
 pytest tests/unit_tests/specific_test.py  # Single file
@@ -149,19 +136,6 @@ curl -f http://localhost:8088/health || echo "❌ Setup required - see https://s
 - **Use negation operator**: `~Model.field` instead of `== False` to avoid ruff E712 errors
 - **Example**: `~Model.is_active` instead of `Model.is_active == False`
 
-## Pull Request Guidelines
-
-**When creating pull requests:**
-
-1. **Read the current PR template**: Always check `.github/PULL_REQUEST_TEMPLATE.md` for the latest format
-2. **Use the template sections**: Include all sections from the template (SUMMARY, BEFORE/AFTER, TESTING INSTRUCTIONS, ADDITIONAL INFORMATION)
-3. **Follow PR title conventions**: Use [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/)
-   - Format: `type(scope): description`
-   - Example: `fix(dashboard): load charts correctly`
-   - Types: `fix`, `feat`, `docs`, `style`, `refactor`, `perf`, `test`, `chore`
-
-**Important**: Always reference the actual template file at `.github/PULL_REQUEST_TEMPLATE.md` instead of using cached content, as the template may be updated over time.
-
 ## Pre-commit Validation
 
 **Use pre-commit hooks for quality validation:**

docker-compose-light.yml

@@ -162,11 +162,8 @@ services:
       SCARF_ANALYTICS: "${SCARF_ANALYTICS:-}"
       # configuring the dev-server to use the host.docker.internal to connect to the backend
       superset: "http://superset-light:8088"
-      # Webpack dev server configuration
-      WEBPACK_DEVSERVER_HOST: "${WEBPACK_DEVSERVER_HOST:-0.0.0.0}"
-      WEBPACK_DEVSERVER_PORT: "${WEBPACK_DEVSERVER_PORT:-9000}"
     ports:
-      - "${NODE_PORT:-9001}:9000"  # Parameterized port, accessible on all interfaces
+      - "127.0.0.1:${NODE_PORT:-9001}:9000"  # Parameterized port
     command: ["/app/docker/docker-frontend.sh"]
     env_file:
       - path: docker/.env # default

docker/pythonpath_dev/superset_config.py

@@ -138,7 +138,7 @@ try:
     from superset_config_docker import *  # noqa: F403
 
     logger.info(
-        "Loaded your Docker configuration at [%s]", superset_config_docker.__file__
+        f"Loaded your Docker configuration at [{superset_config_docker.__file__}]"
     )
 except ImportError:
     logger.info("Using default Docker config...")

docs/docs/configuration/sql-templating.mdx

@@ -10,15 +10,8 @@ version: 1
 ## Jinja Templates
 
 SQL Lab and Explore supports [Jinja templating](https://jinja.palletsprojects.com/en/2.11.x/) in queries.
-To enable templating, the `ENABLE_TEMPLATE_PROCESSING` [feature flag](/docs/configuration/configuring-superset#feature-flags) needs to be enabled in `superset_config.py`.
-
-> #### ⚠️ Security Warning
->
-> While powerful, this feature executes template code on the server. Within the Superset security model, this is **intended functionality**, as users with permissions to edit charts and virtual datasets are considered **trusted users**.
->
-> If you grant these permissions to untrusted users, this feature can be exploited as a **Server-Side Template Injection (SSTI)** vulnerability. Do not enable `ENABLE_TEMPLATE_PROCESSING` unless you fully understand and accept the associated security risks.
-
-When templating is enabled, python code can be embedded in virtual datasets and
+To enable templating, the `ENABLE_TEMPLATE_PROCESSING` [feature flag](/docs/configuration/configuring-superset#feature-flags) needs to be enabled in
+`superset_config.py`. When templating is enabled, python code can be embedded in virtual datasets and
 in Custom SQL in the filter and metric controls in Explore. By default, the following variables are
 made available in the Jinja context:
 

docs/docs/configuration/theming.mdx

@@ -165,206 +165,6 @@ Or in the CRUD interface theme JSON:
 
 This feature works with the stock Docker image - no custom build required!
 
-## ECharts Configuration Overrides
-
-:::note
-Available since Superset 6.0
-:::
-
-Superset provides fine-grained control over ECharts visualizations through theme-level configuration overrides. This allows you to customize the appearance and behavior of all ECharts-based charts without modifying individual chart configurations.
-
-### Global ECharts Overrides
-
-Apply settings to all ECharts visualizations using `echartsOptionsOverrides`:
-
-```python
-THEME_DEFAULT = {
-    "token": {
-        "colorPrimary": "#2893B3",
-        # ... other Ant Design tokens
-    },
-    "echartsOptionsOverrides": {
-        "grid": {
-            "left": "10%",
-            "right": "10%",
-            "top": "15%",
-            "bottom": "15%"
-        },
-        "tooltip": {
-            "backgroundColor": "rgba(0, 0, 0, 0.8)",
-            "borderColor": "#ccc",
-            "textStyle": {
-                "color": "#fff"
-            }
-        },
-        "legend": {
-            "textStyle": {
-                "fontSize": 14,
-                "fontWeight": "bold"
-            }
-        }
-    }
-}
-```
-
-### Chart-Specific Overrides
-
-Target specific chart types using `echartsOptionsOverridesByChartType`:
-
-```python
-THEME_DEFAULT = {
-    "token": {
-        "colorPrimary": "#2893B3",
-        # ... other tokens
-    },
-    "echartsOptionsOverridesByChartType": {
-        "echarts_pie": {
-            "legend": {
-                "orient": "vertical",
-                "right": 10,
-                "top": "center"
-            }
-        },
-        "echarts_timeseries": {
-            "xAxis": {
-                "axisLabel": {
-                    "rotate": 45,
-                    "fontSize": 12
-                }
-            },
-            "dataZoom": [{
-                "type": "slider",
-                "show": True,
-                "start": 0,
-                "end": 100
-            }]
-        },
-        "echarts_bubble": {
-            "grid": {
-                "left": "15%",
-                "bottom": "20%"
-            }
-        }
-    }
-}
-```
-
-### UI Configuration
-
-You can also configure ECharts overrides through the theme CRUD interface:
-
-```json
-{
-  "token": {
-    "colorPrimary": "#2893B3"
-  },
-  "echartsOptionsOverrides": {
-    "grid": {
-      "left": "10%",
-      "right": "10%"
-    },
-    "tooltip": {
-      "backgroundColor": "rgba(0, 0, 0, 0.8)"
-    }
-  },
-  "echartsOptionsOverridesByChartType": {
-    "echarts_pie": {
-      "legend": {
-        "orient": "vertical",
-        "right": 10
-      }
-    }
-  }
-}
-```
-
-### Override Precedence
-
-The system applies overrides in the following order (last wins):
-
-1. **Base ECharts theme** - Default Superset styling
-2. **Plugin options** - Chart-specific configurations
-3. **Global overrides** - `echartsOptionsOverrides`
-4. **Chart-specific overrides** - `echartsOptionsOverridesByChartType[chartType]`
-
-This ensures chart-specific overrides take precedence over global ones.
-
-### Common Chart Types
-
-Available chart types for `echartsOptionsOverridesByChartType`:
-
-- `echarts_timeseries` - Time series/line charts
-- `echarts_pie` - Pie and donut charts
-- `echarts_bubble` - Bubble/scatter charts
-- `echarts_funnel` - Funnel charts
-- `echarts_gauge` - Gauge charts
-- `echarts_radar` - Radar charts
-- `echarts_boxplot` - Box plot charts
-- `echarts_treemap` - Treemap charts
-- `echarts_sunburst` - Sunburst charts
-- `echarts_graph` - Network/graph charts
-- `echarts_sankey` - Sankey diagrams
-- `echarts_heatmap` - Heatmaps
-- `echarts_mixed_timeseries` - Mixed time series
-
-### Best Practices
-
-1. **Start with global overrides** for consistent styling across all charts
-2. **Use chart-specific overrides** for unique requirements per visualization type
-3. **Test thoroughly** as overrides use deep merge - nested objects are combined, but arrays are completely replaced
-4. **Document your overrides** to help team members understand custom styling
-5. **Consider performance** - complex overrides may impact chart rendering speed
-
-### Example: Corporate Branding
-
-```python
-# Complete corporate theme with ECharts customization
-THEME_DEFAULT = {
-    "token": {
-        "colorPrimary": "#1B4D3E",
-        "fontFamily": "Corporate Sans, Arial, sans-serif"
-    },
-    "echartsOptionsOverrides": {
-        "grid": {
-            "left": "8%",
-            "right": "8%",
-            "top": "12%",
-            "bottom": "12%"
-        },
-        "textStyle": {
-            "fontFamily": "Corporate Sans, Arial, sans-serif"
-        },
-        "title": {
-            "textStyle": {
-                "color": "#1B4D3E",
-                "fontSize": 18,
-                "fontWeight": "bold"
-            }
-        }
-    },
-    "echartsOptionsOverridesByChartType": {
-        "echarts_timeseries": {
-            "xAxis": {
-                "axisLabel": {
-                    "color": "#666",
-                    "fontSize": 11
-                }
-            }
-        },
-        "echarts_pie": {
-            "legend": {
-                "textStyle": {
-                    "fontSize": 12
-                },
-                "itemGap": 20
-            }
-        }
-    }
-}
-```
-
-This feature provides powerful theming capabilities while maintaining the flexibility of ECharts' extensive configuration options.
-
 ## Advanced Features
 
 - **System Themes**: Manage system-wide default and dark themes via UI or configuration

docs/docs/contributing/development.mdx

@@ -631,7 +631,7 @@ can find all of the workflows and other assets under the `.github/` folder. This
 
 - running the backend unit test suites (`tests/`)
 - running the frontend test suites (`superset-frontend/src/**.*.test.*`)
-- running our Playwright end-to-end tests (`superset-frontend/playwright/`) and legacy Cypress tests (`superset-frontend/cypress-base/`)
+- running our Cypress end-to-end tests (`superset-frontend/cypress-base/`)
 - linting the codebase, including all Python, Typescript and Javascript, yaml and beyond
 - checking for all sorts of other rules conventions
 

docs/docs/contributing/howtos.mdx

@@ -225,57 +225,21 @@ npm run test -- path/to/file.js
 
 ### E2E Integration Testing
 
-**Note: We are migrating from Cypress to Playwright. Use Playwright for new tests.**
-
-#### Playwright (Recommended - NEW)
-
-For E2E testing with Playwright, use the same `docker compose` backend:
+For E2E testing, we recommend that you use a `docker compose` backend
 
 ```bash
 CYPRESS_CONFIG=true docker compose up --build
 ```
+`docker compose` will get to work and expose a Cypress-ready Superset app.
+This app uses a different database schema (`superset_cypress`) to keep it isolated from
+your other dev environment(s), a specific set of examples, and a set of configurations that
+aligns with the expectations within the end-to-end tests.  Also note that it's served on a
+different port than the default port for the backend (`8088`).
 
-The backend setup is identical - this exposes a test-ready Superset app on port 8081 with isolated database schema (`superset_cypress`), test data, and configurations.
+Now in another terminal, let's get ready to execute some Cypress commands. First, tell cypress
+to connect to the Cypress-ready Superset backend.
 
-Now in another terminal, run Playwright tests:
-
-```bash
-# Navigate to frontend directory (Playwright config is here)
-cd superset-frontend
-
-# Run all Playwright tests
-npm run playwright:test
-# or: npx playwright test
-
-# Run with interactive UI for debugging
-npm run playwright:ui
-# or: npx playwright test --ui
-
-# Run in headed mode (see browser)
-npm run playwright:headed
-# or: npx playwright test --headed
-
-# Run specific test file
-npx playwright test tests/auth/login.spec.ts
-
-# Run with debug mode (step through tests)
-npm run playwright:debug tests/auth/login.spec.ts
-# or: npx playwright test --debug tests/auth/login.spec.ts
-
-# Generate test report
-npx playwright show-report
 ```
-
-Configuration is in `superset-frontend/playwright.config.ts`. Base URL is automatically set to `http://localhost:8088` but will use `PLAYWRIGHT_BASE_URL` if provided.
-
-#### Cypress (DEPRECATED - will be removed in Phase 5)
-
-:::warning
-Cypress is being phased out in favor of Playwright. Use Playwright for all new tests.
-:::
-
-```bash
-# Set base URL for Cypress
 CYPRESS_BASE_URL=http://localhost:8081
 ```
 

docs/yarn.lock

@@ -4766,9 +4766,9 @@ available-typed-arrays@^1.0.7:
     possible-typed-array-names "^1.0.0"
 
 axios@^1.9.0:
-  version "1.12.0"
-  resolved "https://registry.yarnpkg.com/axios/-/axios-1.12.0.tgz#11248459be05a5ee493485628fa0e4323d0abfc3"
-  integrity sha512-oXTDccv8PcfjZmPGlWsPSwtOJCZ/b6W5jAMCNcfwJbCzDckwG0jrYJFaWH1yvivfCXjVzV/SPDEhMB3Q+DSurg==
+  version "1.11.0"
+  resolved "https://registry.yarnpkg.com/axios/-/axios-1.11.0.tgz#c2ec219e35e414c025b2095e8b8280278478fdb6"
+  integrity sha512-1Lx3WLFQWm3ooKDYZD1eXmoGO9fxYQjrycfHFC8P0sCfQVXyROp0p9PFWBehewBOdCwHc+f/b8I0fMto5eSfwA==
   dependencies:
     follow-redirects "^1.15.6"
     form-data "^4.0.4"

pyproject.toml

@@ -76,7 +76,7 @@ dependencies = [
     "packaging",
     # --------------------------
     # pandas and related (wanting pandas[performance] without numba as it's 100+MB and not needed)
-    "pandas[excel]>=2.0.3, <2.2",
+    "pandas[excel]>=2.0.3, <2.1",
     "bottleneck", # recommended performance dependency for pandas, see https://pandas.pydata.org/docs/getting_started/install.html#performance-dependencies-recommended
     # --------------------------
     "parsedatetime",
@@ -84,7 +84,6 @@ dependencies = [
     "pgsanity",
     "Pillow>=11.0.0, <12",
     "polyline>=2.0.0, <3.0",
-    "pydantic>=2.8.0",
     "pyparsing>=3.0.6, <4",
     "python-dateutil",
     "python-dotenv", # optional dependencies for Flask but required for Superset, see https://flask.palletsprojects.com/en/stable/installation/#optional-dependencies
@@ -314,7 +313,6 @@ select = [
     "E",
     "F",
     "F",
-    "G",
     "I",
     "N",
     "PT",
@@ -330,7 +328,6 @@ ignore = [
     "PT006",
     "T201",
     "N999",
-    "G201",
 ]
 extend-select = ["I"]
 

requirements/base.txt

@@ -6,8 +6,6 @@ alembic==1.15.2
     # via flask-migrate
 amqp==5.3.1
     # via kombu
-annotated-types==0.7.0
-    # via pydantic
 apispec==6.6.1
     # via
     #   -r requirements/base.in
@@ -117,9 +115,7 @@ flask==2.3.3
     #   flask-sqlalchemy
     #   flask-wtf
 flask-appbuilder==5.0.0
-    # via
-    #   apache-superset (pyproject.toml)
-    #   apache-superset-core
+    # via apache-superset (pyproject.toml)
 flask-babel==3.1.0
     # via flask-appbuilder
 flask-caching==2.3.1
@@ -160,7 +156,6 @@ greenlet==3.1.1
     # via
     #   apache-superset (pyproject.toml)
     #   shillelagh
-    #   sqlalchemy
 gunicorn==23.0.0
     # via apache-superset (pyproject.toml)
 h11==0.16.0
@@ -267,7 +262,7 @@ packaging==25.0
     #   limits
     #   marshmallow
     #   shillelagh
-pandas==2.1.4
+pandas==2.0.3
     # via apache-superset (pyproject.toml)
 paramiko==3.5.1
     # via
@@ -299,10 +294,6 @@ pyasn1-modules==0.4.2
     # via google-auth
 pycparser==2.22
     # via cffi
-pydantic==2.11.7
-    # via apache-superset (pyproject.toml)
-pydantic-core==2.33.2
-    # via pydantic
 pygments==2.19.1
     # via rich
 pyjwt==2.10.1
@@ -413,15 +404,10 @@ typing-extensions==4.14.0
     #   alembic
     #   cattrs
     #   limits
-    #   pydantic
-    #   pydantic-core
     #   pyopenssl
     #   referencing
     #   selenium
     #   shillelagh
-    #   typing-inspection
-typing-inspection==0.4.1
-    # via pydantic
 tzdata==2025.2
     # via
     #   kombu

requirements/development.txt

@@ -18,10 +18,6 @@ amqp==5.3.1
     # via
     #   -c requirements/base-constraint.txt
     #   kombu
-annotated-types==0.7.0
-    # via
-    #   -c requirements/base-constraint.txt
-    #   pydantic
 apispec==6.6.1
     # via
     #   -c requirements/base-constraint.txt
@@ -216,7 +212,6 @@ flask-appbuilder==5.0.0
     # via
     #   -c requirements/base-constraint.txt
     #   apache-superset
-    #   apache-superset-core
 flask-babel==3.1.0
     # via
     #   -c requirements/base-constraint.txt
@@ -331,7 +326,6 @@ greenlet==3.1.1
     #   apache-superset
     #   gevent
     #   shillelagh
-    #   sqlalchemy
 grpcio==1.71.0
     # via
     #   apache-superset
@@ -537,7 +531,7 @@ packaging==25.0
     #   pytest
     #   shillelagh
     #   sqlalchemy-bigquery
-pandas==2.1.4
+pandas==2.0.3
     # via
     #   -c requirements/base-constraint.txt
     #   apache-superset
@@ -637,14 +631,6 @@ pycparser==2.22
     # via
     #   -c requirements/base-constraint.txt
     #   cffi
-pydantic==2.11.7
-    # via
-    #   -c requirements/base-constraint.txt
-    #   apache-superset
-pydantic-core==2.33.2
-    # via
-    #   -c requirements/base-constraint.txt
-    #   pydantic
 pydata-google-auth==1.9.0
     # via pandas-gbq
 pydruid==0.6.9
@@ -888,17 +874,10 @@ typing-extensions==4.14.0
     #   apache-superset
     #   cattrs
     #   limits
-    #   pydantic
-    #   pydantic-core
     #   pyopenssl
     #   referencing
     #   selenium
     #   shillelagh
-    #   typing-inspection
-typing-inspection==0.4.1
-    # via
-    #   -c requirements/base-constraint.txt
-    #   pydantic
 tzdata==2025.2
     # via
     #   -c requirements/base-constraint.txt

superset-extensions-cli/tests/test_cli_validate.py

@@ -160,9 +160,7 @@ def test_validate_npm_handles_file_not_found_exception(mock_run, mock_which):
 def test_validate_npm_does_not_catch_other_subprocess_exceptions(
     mock_run, mock_which, exception_type
 ):
-    """
-    Test validate_npm does not catch OSError and PermissionError (they propagate up).
-    """
+    """Test validate_npm does not catch OSError and PermissionError (they propagate up)."""
     mock_which.return_value = "/usr/bin/npm"
     mock_run.side_effect = exception_type("Test error")
 

superset-frontend/.eslintrc.js

@@ -323,7 +323,6 @@ module.exports = {
         '*.stories.tsx',
         '*.stories.jsx',
         'fixtures.*',
-        'playwright/**/*',
       ],
       excludedFiles: 'cypress-base/cypress/**/*',
       plugins: ['jest', 'jest-dom', 'no-only-tests', 'testing-library'],
@@ -398,13 +397,6 @@ module.exports = {
         'react/no-void-elements': 0,
       },
     },
-    {
-      files: ['playwright/**/*'],
-      rules: {
-        'import/no-unresolved': 0, // Playwright is not installed in main build
-        'import/no-extraneous-dependencies': 0, // Playwright is not installed in main build
-      },
-    },
   ],
   // eslint-disable-next-line no-dupe-keys
   rules: {

superset-frontend/cypress-base/cypress/e2e/chart_list/list.test.ts

@@ -175,7 +175,7 @@ describe('Charts list', () => {
       interceptDelete();
       cy.getBySel('sort-header').contains('Name').click();
 
-      // Modal closes immediately without this
+      // Modal closes immediatly without this
       cy.wait(2000);
 
       cy.getBySel('table-row').eq(0).contains('3 - Sample chart');

superset-frontend/cypress-base/cypress/e2e/explore/control.test.ts

@@ -0,0 +1,186 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+// ***********************************************
+// Tests for setting controls in the UI
+// ***********************************************
+import { interceptChart, setSelectSearchInput } from 'cypress/utils';
+
+describe('Datasource control', () => {
+  const newMetricName = `abc${Date.now()}`;
+
+  it('should allow edit dataset', () => {
+    interceptChart({ legacy: false }).as('chartData');
+
+    cy.visitChartByName('Num Births Trend');
+    cy.verifySliceSuccess({ waitAlias: '@chartData' });
+
+    cy.get('[data-test="datasource-menu-trigger"]').click();
+
+    cy.get('[data-test="edit-dataset"]').click();
+
+    cy.get('[data-test="edit-dataset-tabs"]').within(() => {
+      cy.contains('Metrics').click();
+    });
+    // create new metric
+    cy.get('[data-test="crud-add-table-item"]', { timeout: 10000 }).click();
+    cy.wait(1000);
+    cy.get('.ant-table-body [data-test="textarea-editable-title-input"]')
+      .first()
+      .click();
+
+    cy.get('.ant-table-body [data-test="textarea-editable-title-input"]')
+      .first()
+      .focus();
+    cy.focused().clear({ force: true });
+    cy.focused().type(`${newMetricName}{enter}`, { force: true });
+
+    cy.get('[data-test="datasource-modal-save"]').click();
+    cy.get('.ant-modal-confirm-btns button').contains('OK').click();
+    // select new metric
+    cy.get('[data-test=metrics]')
+      .contains('Drop columns/metrics here or click')
+      .click();
+
+    cy.get('input[aria-label="Select saved metrics"]')
+      .should('exist')
+      .then($input => {
+        setSelectSearchInput($input, newMetricName);
+      });
+
+    // delete metric
+    cy.get('[data-test="datasource-menu-trigger"]').click();
+    cy.get('[data-test="edit-dataset"]').click();
+    cy.get('.ant-modal-content').within(() => {
+      cy.get('[data-test="collection-tab-Metrics"]')
+        .contains('Metrics')
+        .click();
+    });
+    cy.get(`[data-test="textarea-editable-title-input"]`)
+      .contains(newMetricName)
+      .closest('tr')
+      .find('[data-test="crud-delete-icon"]')
+      .click();
+    cy.get('[data-test="datasource-modal-save"]').click();
+    cy.get('.ant-modal-confirm-btns button').contains('OK').click();
+    cy.get('[data-test="metrics"]').contains(newMetricName).should('not.exist');
+  });
+});
+
+describe('Color scheme control', () => {
+  beforeEach(() => {
+    interceptChart({ legacy: false }).as('chartData');
+
+    cy.visitChartByName('Num Births Trend');
+    cy.verifySliceSuccess({ waitAlias: '@chartData' });
+  });
+
+  it('should show color options with and without tooltips', () => {
+    cy.get('#controlSections-tab-CUSTOMIZE').click();
+    cy.get('.ant-select-selection-item .color-scheme-label').contains(
+      'Superset Colors',
+    );
+    cy.get('.ant-select-selection-item .color-scheme-label').trigger(
+      'mouseover',
+    );
+    cy.get('.color-scheme-tooltip').should('be.visible');
+    cy.get('.color-scheme-tooltip').contains('Superset Colors');
+    cy.get('.Control[data-test="color_scheme"]').scrollIntoView();
+    cy.get('.Control[data-test="color_scheme"] input[type="search"]').focus();
+
+    cy.get('.color-scheme-label')
+      .contains('Superset Colors')
+      .trigger('mouseover');
+
+    cy.get('.color-scheme-label')
+      .contains('Superset Colors')
+      .trigger('mouseout');
+
+    cy.focused().type('lyftColors');
+    cy.getBySel('lyftColors').should('exist');
+    cy.getBySel('lyftColors').trigger('mouseover', { force: true });
+    cy.get('.color-scheme-tooltip').should('not.be.visible');
+  });
+});
+describe('VizType control', () => {
+  beforeEach(() => {
+    interceptChart({ legacy: false }).as('tableChartData');
+    interceptChart({ legacy: false }).as('bigNumberChartData');
+  });
+
+  it('Can change vizType', () => {
+    cy.visitChartByName('Daily Totals');
+    cy.verifySliceSuccess({ waitAlias: '@tableChartData' });
+
+    cy.contains('View all charts').click();
+
+    cy.get('.ant-modal-content').within(() => {
+      cy.get('button').contains('KPI').click(); // change categories
+      cy.get('[role="button"]').contains('Big Number').click();
+      cy.get('button').contains('Select').click();
+    });
+
+    cy.get('button[data-test="run-query-button"]').click();
+    cy.verifySliceSuccess({
+      waitAlias: '@bigNumberChartData',
+    });
+  });
+});
+
+describe('Test datatable', () => {
+  beforeEach(() => {
+    interceptChart({ legacy: false }).as('tableChartData');
+    interceptChart({ legacy: false }).as('lineChartData');
+    cy.visitChartByName('Daily Totals');
+  });
+  it('Data Pane opens and loads results', () => {
+    cy.contains('Results').click();
+    cy.get('[data-test="row-count-label"]').contains('26 rows');
+    cy.get('.ant-empty-description').should('not.exist');
+  });
+  it('Datapane loads view samples', () => {
+    cy.intercept(
+      '**/datasource/samples?force=false&datasource_type=table&datasource_id=*',
+    ).as('Samples');
+    cy.contains('Samples').click();
+    cy.wait('@Samples');
+    cy.get('.ant-tabs-tab-active').contains('Samples');
+    cy.get('[data-test="row-count-label"]').contains('1k rows');
+    cy.get('.ant-empty-description').should('not.exist');
+  });
+});
+
+describe('Groupby control', () => {
+  it('Set groupby', () => {
+    interceptChart({ legacy: false }).as('chartData');
+
+    cy.visitChartByName('Num Births Trend');
+    cy.verifySliceSuccess({ waitAlias: '@chartData' });
+
+    cy.get('[data-test=groupby]')
+      .contains('Drop columns here or click')
+      .click();
+    cy.get('[id="adhoc-metric-edit-tabs-tab-simple"]').click();
+    cy.get('input[aria-label="Column"]').click();
+    cy.get('input[aria-label="Column"]').type('state{enter}');
+    cy.get('[data-test="ColumnEdit#save"]').contains('Save').click();
+
+    cy.get('button[data-test="run-query-button"]').click();
+    cy.verifySliceSuccess({ waitAlias: '@chartData' });
+  });
+});

superset-frontend/jest.config.js

@@ -33,7 +33,6 @@ module.exports = {
     '^@superset-ui/([^/]+)$': '<rootDir>/node_modules/@superset-ui/$1/src',
     // mapping @apache-superset/core to local package
     '^@apache-superset/core$': '<rootDir>/packages/superset-core/src',
-    '^@apache-superset/core/(.*)$': '<rootDir>/packages/superset-core/src/$1',
   },
   testEnvironment: '<rootDir>/spec/helpers/jsDomWithFetchAPI.ts',
   modulePathIgnorePatterns: ['<rootDir>/packages/generator-superset'],

superset-frontend/package-lock.json

@@ -54,8 +54,6 @@
         "@visx/scale": "^3.5.0",
         "@visx/tooltip": "^3.0.0",
         "@visx/xychart": "^3.5.1",
-        "ag-grid-community": "34.2.0",
-        "ag-grid-react": "34.2.0",
         "antd": "^5.24.6",
         "chrono-node": "^2.7.8",
         "classnames": "^2.2.5",
@@ -66,6 +64,7 @@
         "dom-to-image-more": "^3.6.0",
         "dom-to-pdf": "^0.3.2",
         "echarts": "^5.6.0",
+        "emotion-rgba": "0.0.12",
         "eslint-plugin-i18n-strings": "file:eslint-rules/eslint-plugin-i18n-strings",
         "fast-glob": "^3.3.2",
         "fs-extra": "^11.2.0",
@@ -161,7 +160,6 @@
         "@hot-loader/react-dom": "^17.0.2",
         "@istanbuljs/nyc-config-typescript": "^1.0.1",
         "@mihkeleidast/storybook-addon-source": "^1.0.1",
-        "@playwright/test": "^1.49.1",
         "@storybook/addon-actions": "8.1.11",
         "@storybook/addon-controls": "8.1.11",
         "@storybook/addon-essentials": "8.1.11",
@@ -10112,22 +10110,6 @@
         "url": "https://opencollective.com/unts"
       }
     },
-    "node_modules/@playwright/test": {
-      "version": "1.55.0",
-      "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.55.0.tgz",
-      "integrity": "sha512-04IXzPwHrW69XusN/SIdDdKZBzMfOT9UNT/YiJit/xpy2VuAoB8NHc8Aplb96zsWDddLnbkPL3TsmrS04ZU2xQ==",
-      "dev": true,
-      "license": "Apache-2.0",
-      "dependencies": {
-        "playwright": "1.55.0"
-      },
-      "bin": {
-        "playwright": "cli.js"
-      },
-      "engines": {
-        "node": ">=18"
-      }
-    },
     "node_modules/@pnpm/config.env-replace": {
       "version": "1.1.0",
       "resolved": "https://registry.npmjs.org/@pnpm/config.env-replace/-/config.env-replace-1.1.0.tgz",
@@ -18715,27 +18697,27 @@
       }
     },
     "node_modules/ag-charts-types": {
-      "version": "12.2.0",
-      "resolved": "https://registry.npmjs.org/ag-charts-types/-/ag-charts-types-12.2.0.tgz",
-      "integrity": "sha512-d2qQrQirt9wP36YW5HPuOvXsiajyiFnr1CTsoCbs02bavPDz7Lk2jHp64+waM4YKgXb3GN7gafbBI9Qgk33BmQ==",
+      "version": "12.0.2",
+      "resolved": "https://registry.npmjs.org/ag-charts-types/-/ag-charts-types-12.0.2.tgz",
+      "integrity": "sha512-AWM1Y+XW+9VMmV3AbzdVEnreh/I2C9Pmqpc2iLmtId3Xbvmv7O56DqnuDb9EXjK5uPxmyUerTP+utL13UGcztw==",
       "license": "MIT"
     },
     "node_modules/ag-grid-community": {
-      "version": "34.2.0",
-      "resolved": "https://registry.npmjs.org/ag-grid-community/-/ag-grid-community-34.2.0.tgz",
-      "integrity": "sha512-peS7THEMYwpIrwLQHmkRxw/TlOnddD/F5A88RqlBxf8j+WqVYRWMOOhU5TqymGcha7z2oZ8IoL9ROl3gvtdEjg==",
+      "version": "34.0.2",
+      "resolved": "https://registry.npmjs.org/ag-grid-community/-/ag-grid-community-34.0.2.tgz",
+      "integrity": "sha512-hVJp5vrmwHRB10YjfSOVni5YJkO/v+asLjT72S4YnIFSx8lAgyPmByNJgtojk1aJ5h6Up93jTEmGDJeuKiWWLA==",
       "license": "MIT",
       "dependencies": {
-        "ag-charts-types": "12.2.0"
+        "ag-charts-types": "12.0.2"
       }
     },
     "node_modules/ag-grid-react": {
-      "version": "34.2.0",
-      "resolved": "https://registry.npmjs.org/ag-grid-react/-/ag-grid-react-34.2.0.tgz",
-      "integrity": "sha512-dLKFw6hz75S0HLuZvtcwjm+gyiI4gXVzHEu7lWNafWAX0mb8DhogEOP5wbzAlsN6iCfi7bK/cgZImZFjenlqwg==",
+      "version": "34.0.2",
+      "resolved": "https://registry.npmjs.org/ag-grid-react/-/ag-grid-react-34.0.2.tgz",
+      "integrity": "sha512-1KBXkTvwtZiYVlSuDzBkiqfHjZgsATOmpLZdAtdmsCSOOOEWai0F9zHHgBuHfyciAE4nrbQWfojkx8IdnwsKFw==",
       "license": "MIT",
       "dependencies": {
-        "ag-grid-community": "34.2.0",
+        "ag-grid-community": "34.0.2",
         "prop-types": "^15.8.1"
       },
       "peerDependencies": {
@@ -24484,6 +24466,12 @@
         "node": ">= 4"
       }
     },
+    "node_modules/emotion-rgba": {
+      "version": "0.0.12",
+      "resolved": "https://registry.npmjs.org/emotion-rgba/-/emotion-rgba-0.0.12.tgz",
+      "integrity": "sha512-lvtZ52BWisYDtis+HctQMkxcHwmFbzTiZhgMJGFfWXLsBYEzthfKE7nlysOiUwmmAdTM/8YBAPfwQ4MEDwiaWw==",
+      "license": "MIT"
+    },
     "node_modules/encodable": {
       "version": "0.7.8",
       "resolved": "https://registry.npmjs.org/encodable/-/encodable-0.7.8.tgz",
@@ -45536,53 +45524,6 @@
       "dev": true,
       "license": "MIT"
     },
-    "node_modules/playwright": {
-      "version": "1.55.0",
-      "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.55.0.tgz",
-      "integrity": "sha512-sdCWStblvV1YU909Xqx0DhOjPZE4/5lJsIS84IfN9dAZfcl/CIZ5O8l3o0j7hPMjDvqoTF8ZUcc+i/GL5erstA==",
-      "dev": true,
-      "license": "Apache-2.0",
-      "dependencies": {
-        "playwright-core": "1.55.0"
-      },
-      "bin": {
-        "playwright": "cli.js"
-      },
-      "engines": {
-        "node": ">=18"
-      },
-      "optionalDependencies": {
-        "fsevents": "2.3.2"
-      }
-    },
-    "node_modules/playwright-core": {
-      "version": "1.55.0",
-      "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.55.0.tgz",
-      "integrity": "sha512-GvZs4vU3U5ro2nZpeiwyb0zuFaqb9sUiAJuyrWpcGouD8y9/HLgGbNRjIph7zU9D3hnPaisMl9zG9CgFi/biIg==",
-      "dev": true,
-      "license": "Apache-2.0",
-      "bin": {
-        "playwright-core": "cli.js"
-      },
-      "engines": {
-        "node": ">=18"
-      }
-    },
-    "node_modules/playwright/node_modules/fsevents": {
-      "version": "2.3.2",
-      "resolved": "https://registry.npmjs.org/fsevents/-/fsevents-2.3.2.tgz",
-      "integrity": "sha512-xiqMQR4xAeHTuB9uWm+fFRcIOgKBMiOBP+eXiyT7jsgVCq1bkVygt00oASowB7EdtpOHaaPgKt812P9ab+DDKA==",
-      "dev": true,
-      "hasInstallScript": true,
-      "license": "MIT",
-      "optional": true,
-      "os": [
-        "darwin"
-      ],
-      "engines": {
-        "node": "^8.16.0 || ^10.6.0 || >=11.0.0"
-      }
-    },
     "node_modules/png-async": {
       "version": "0.9.4",
       "resolved": "https://registry.npmjs.org/png-async/-/png-async-0.9.4.tgz",
@@ -60690,7 +60631,7 @@
     },
     "packages/superset-core": {
       "name": "@apache-superset/core",
-      "version": "0.0.1-rc4",
+      "version": "0.0.1-rc3",
       "license": "ISC",
       "devDependencies": {
         "@babel/cli": "^7.26.4",
@@ -63387,10 +63328,10 @@
       "version": "0.20.3",
       "license": "Apache-2.0",
       "dependencies": {
-        "@apache-superset/core": "*",
         "@react-icons/all-files": "^4.1.0",
         "@types/react": "*",
-        "lodash": "^4.17.21"
+        "lodash": "^4.17.21",
+        "prop-types": "^15.8.1"
       },
       "peerDependencies": {
         "@ant-design/icons": "^5.2.6",
@@ -63415,15 +63356,14 @@
       "license": "Apache-2.0",
       "dependencies": {
         "@ant-design/icons": "^5.2.6",
-        "@apache-superset/core": "*",
         "@babel/runtime": "^7.28.2",
         "@fontsource/fira-code": "^5.2.6",
         "@fontsource/inter": "^5.2.6",
         "@types/json-bigint": "^1.0.4",
         "@visx/responsive": "^3.12.0",
         "ace-builds": "^1.43.1",
-        "ag-grid-community": "34.2.0",
-        "ag-grid-react": "34.2.0",
+        "ag-grid-community": "^34.0.2",
+        "ag-grid-react": "34.0.2",
         "brace": "^0.11.1",
         "classnames": "^2.2.5",
         "core-js": "^3.38.1",
@@ -65294,8 +65234,6 @@
         "d3-array": "^1.2.4",
         "d3-color": "^1.4.1",
         "d3-scale": "^3.0.0",
-        "dayjs": "^1.11.13",
-        "handlebars": "^4.7.8",
         "lodash": "^4.17.21",
         "mousetrap": "^1.6.5",
         "ngeohash": "^0.6.3",
@@ -65462,7 +65400,6 @@
       },
       "peerDependencies": {
         "@ant-design/icons": "^5.2.6",
-        "@apache-superset/core": "*",
         "@superset-ui/chart-controls": "*",
         "@superset-ui/core": "*",
         "@testing-library/dom": "^8.20.1",
@@ -65514,7 +65451,6 @@
         "lodash": "^4.17.21"
       },
       "peerDependencies": {
-        "@apache-superset/core": "*",
         "@superset-ui/chart-controls": "*",
         "@superset-ui/core": "*",
         "echarts": "*",
@@ -66692,7 +66628,6 @@
       },
       "peerDependencies": {
         "@ant-design/icons": "^5.2.6",
-        "@apache-superset/core": "*",
         "@superset-ui/chart-controls": "*",
         "@superset-ui/core": "*",
         "lodash": "^4.17.11",
@@ -67824,7 +67759,6 @@
       },
       "peerDependencies": {
         "@ant-design/icons": "^5.2.6",
-        "@apache-superset/core": "*",
         "@superset-ui/chart-controls": "*",
         "@superset-ui/core": "*",
         "@testing-library/dom": "^8.20.1",

superset-frontend/package.json

@@ -63,11 +63,6 @@
     "plugins:release-conventional": "npm run prune && npm run plugins:build && lerna publish --conventional-commits --create-release github --yes",
     "plugins:release-from-tag": "npm run prune && npm run plugins:build && lerna publish from-package --yes",
     "plugins:storybook": "cd packages/superset-ui-demo && npm run storybook",
-    "playwright:test": "playwright test",
-    "playwright:ui": "playwright test --ui",
-    "playwright:headed": "playwright test --headed",
-    "playwright:debug": "playwright test --debug",
-    "playwright:report": "playwright show-report",
     "prettier": "npm run _prettier -- --write",
     "prettier-check": "npm run _prettier -- --check",
     "prod": "npm run build",
@@ -127,8 +122,6 @@
     "@visx/scale": "^3.5.0",
     "@visx/tooltip": "^3.0.0",
     "@visx/xychart": "^3.5.1",
-    "ag-grid-community": "34.2.0",
-    "ag-grid-react": "34.2.0",
     "antd": "^5.24.6",
     "chrono-node": "^2.7.8",
     "classnames": "^2.2.5",
@@ -139,6 +132,7 @@
     "dom-to-image-more": "^3.6.0",
     "dom-to-pdf": "^0.3.2",
     "echarts": "^5.6.0",
+    "emotion-rgba": "0.0.12",
     "eslint-plugin-i18n-strings": "file:eslint-rules/eslint-plugin-i18n-strings",
     "fast-glob": "^3.3.2",
     "fs-extra": "^11.2.0",
@@ -234,7 +228,6 @@
     "@hot-loader/react-dom": "^17.0.2",
     "@istanbuljs/nyc-config-typescript": "^1.0.1",
     "@mihkeleidast/storybook-addon-source": "^1.0.1",
-    "@playwright/test": "^1.49.1",
     "@storybook/addon-actions": "8.1.11",
     "@storybook/addon-controls": "8.1.11",
     "@storybook/addon-essentials": "8.1.11",

superset-frontend/packages/generator-superset/generators/plugin-chart/templates/README.erb

@@ -22,6 +22,19 @@ To add the package to Superset, go to the `superset-frontend` subdirectory in yo
 npm i -S ../../<%= packageName %>
 ```
 
+If your Superset plugin exists in the `superset-frontend` directory and you wish to resolve TypeScript errors about `@superset-ui/core` not being resolved correctly, add the following to your `tsconfig.json` file:
+
+```
+"references": [
+  {
+    "path": "../../packages/superset-ui-chart-controls"
+  },
+  {
+    "path": "../../packages/superset-ui-core"
+  }
+]
+```
+
 You may also wish to add the following to the `include` array in `tsconfig.json` to make Superset types available to your plugin:
 
 ```

superset-frontend/packages/generator-superset/generators/plugin-chart/templates/tsconfig.json

@@ -1,19 +1,44 @@
 {
-  "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "baseUrl": "../..",
-    "outDir": "lib"
+    "allowSyntheticDefaultImports": true,
+    "declaration": true,
+    "declarationDir": "lib",
+    "esModuleInterop": true,
+    "forceConsistentCasingInFileNames": true,
+    "isolatedModules": false,
+    "jsx": "react",
+    "lib": [
+      "dom",
+      "esnext"
+    ],
+    "module": "esnext",
+    "moduleResolution": "node",
+    "noEmitOnError": true,
+    "noImplicitReturns": true,
+    "noUnusedLocals": true,
+    "outDir": "lib",
+    "pretty": true,
+    "removeComments": false,
+    "strict": true,
+    "target": "es2015",
+    "useDefineForClassFields": false,
+    "composite": true,
+    "declarationMap": true,
+    "rootDir": "src",
+    "skipLibCheck": true,
+    "emitDeclarationOnly": true,
+    "resolveJsonModule": true,
+    "types": ["jest"],
+    "typeRoots": [
+      "./node_modules/@types"
+    ]
   },
-  "include": ["src/**/*.ts", "src/**/*.tsx", "types/**/*"],
   "exclude": [
-    "src/**/*.js",
-    "src/**/*.jsx",
-    "src/**/*.test.*",
-    "src/**/*.stories.*"
+    "lib",
+    "test"
   ],
-  "references": [
-    { "path": "../../packages/superset-core" },
-    { "path": "../../packages/superset-ui-core" },
-    { "path": "../../packages/superset-ui-chart-controls" }
+  "include": [
+    "src/**/*",
+    "types/**/*"
   ]
 }

superset-frontend/packages/superset-core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@apache-superset/core",
-  "version": "0.0.1-rc4",
+  "version": "0.0.1-rc3",
   "description": "This package contains UI elements, APIs, and utility functions used by Superset.",
   "sideEffects": false,
   "main": "lib/index.js",

superset-frontend/packages/superset-core/tsconfig.json

@@ -1,9 +1,19 @@
 {
-  "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "baseUrl": "../..",
-    "outDir": "lib"
+    "allowSyntheticDefaultImports": true,
+    "declaration": true,
+    "declarationDir": "lib",
+    "outDir": "lib",
+    "strict": true,
+    "rootDir": "src",
+    "jsx": "preserve",
+    "baseUrl": ".",
+    "module": "esnext",
+    "moduleResolution": "node",
+    "skipLibCheck": true,
+    "target": "es2020",
+    "esModuleInterop": true
   },
-  "include": ["src/**/*", "types/**/*"],
-  "exclude": ["src/**/*.test.*", "src/**/*.stories.*"]
+  "include": ["src/**/*.ts*"],
+  "exclude": ["lib"]
 }

superset-frontend/packages/superset-ui-chart-controls/package.json

@@ -24,10 +24,10 @@
     "lib"
   ],
   "dependencies": {
-    "@apache-superset/core": "*",
     "@react-icons/all-files": "^4.1.0",
     "@types/react": "*",
-    "lodash": "^4.17.21"
+    "lodash": "^4.17.21",
+    "prop-types": "^15.8.1"
   },
   "peerDependencies": {
     "@ant-design/icons": "^5.2.6",

superset-frontend/packages/superset-ui-chart-controls/src/sections/matrixify.tsx

@@ -20,32 +20,20 @@ import { t } from '@superset-ui/core';
 import { ControlPanelSectionConfig } from '../types';
 
 export const matrixifyEnableSection: ControlPanelSectionConfig = {
-  label: t('Matrixify'),
+  label: t('Enable matrixify'),
   expanded: true,
   controlSetRows: [
     [
       {
-        name: 'matrixify_enable_horizontal_layout',
+        name: 'matrixify_enabled',
         config: {
           type: 'CheckboxControl',
-          label: t('Enable horizontal layout (columns)'),
+          label: t('Enable matrixify'),
+          default: false,
+          renderTrigger: true,
           description: t(
-            'Create matrix columns by placing charts side-by-side',
+            'Transform this chart into a matrix/grid of charts based on dimensions or metrics',
           ),
-          default: false,
-          renderTrigger: true,
-        },
-      },
-    ],
-    [
-      {
-        name: 'matrixify_enable_vertical_layout',
-        config: {
-          type: 'CheckboxControl',
-          label: t('Enable vertical layout (rows)'),
-          description: t('Create matrix rows by stacking charts vertically'),
-          default: false,
-          renderTrigger: true,
         },
       },
     ],
@@ -54,11 +42,9 @@ export const matrixifyEnableSection: ControlPanelSectionConfig = {
 };
 
 export const matrixifySection: ControlPanelSectionConfig = {
-  label: t('Cell layout & styling'),
+  label: t('Matrixify'),
   expanded: false,
-  visibility: ({ controls }) =>
-    controls?.matrixify_enable_vertical_layout?.value === true ||
-    controls?.matrixify_enable_horizontal_layout?.value === true,
+  visibility: ({ controls }) => controls?.matrixify_enabled?.value === true,
   controlSetRows: [
     [
       {
@@ -119,10 +105,9 @@ export const matrixifySection: ControlPanelSectionConfig = {
 };
 
 export const matrixifyRowSection: ControlPanelSectionConfig = {
-  label: t('Vertical layout (rows)'),
+  label: t('Vertical layout'),
   expanded: false,
-  visibility: ({ controls }) =>
-    controls?.matrixify_enable_vertical_layout?.value === true,
+  visibility: ({ controls }) => controls?.matrixify_enabled?.value === true,
   controlSetRows: [
     ['matrixify_show_row_labels'],
     ['matrixify_mode_rows'],
@@ -133,14 +118,13 @@ export const matrixifyRowSection: ControlPanelSectionConfig = {
     ['matrixify_topn_metric_rows'],
     ['matrixify_topn_order_rows'],
   ],
-  tabOverride: 'matrixify',
+  tabOverride: 'data',
 };
 
 export const matrixifyColumnSection: ControlPanelSectionConfig = {
-  label: t('Horizontal layout (columns)'),
+  label: t('Horizontal layout'),
   expanded: false,
-  visibility: ({ controls }) =>
-    controls?.matrixify_enable_horizontal_layout?.value === true,
+  visibility: ({ controls }) => controls?.matrixify_enabled?.value === true,
   controlSetRows: [
     ['matrixify_show_column_headers'],
     ['matrixify_mode_columns'],
@@ -151,5 +135,5 @@ export const matrixifyColumnSection: ControlPanelSectionConfig = {
     ['matrixify_topn_metric_columns'],
     ['matrixify_topn_order_columns'],
   ],
-  tabOverride: 'matrixify',
+  tabOverride: 'data',
 };

superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/matrixifyControls.tsx

@@ -18,49 +18,21 @@
  * under the License.
  */
 
-import { t, validateNonEmpty } from '@superset-ui/core';
+import { t } from '@superset-ui/core';
 import { SharedControlConfig } from '../types';
 import { dndAdhocMetricControl } from './dndControls';
-import { defineSavedMetrics } from '../utils';
 
 /**
  * Matrixify control definitions
  * Controls for transforming charts into matrix/grid layouts
  */
 
-// Utility function to check if matrixify controls should be visible
-const isMatrixifyVisible = (
-  controls: any,
-  axis: 'rows' | 'columns',
-  mode?: 'metrics' | 'dimensions',
-  selectionMode?: 'members' | 'topn',
-) => {
-  const layoutControl = `matrixify_enable_${axis === 'rows' ? 'vertical' : 'horizontal'}_layout`;
-  const modeControl = `matrixify_mode_${axis}`;
-  const selectionModeControl = `matrixify_dimension_selection_mode_${axis}`;
-
-  const isLayoutEnabled = controls?.[layoutControl]?.value === true;
-
-  if (!isLayoutEnabled) return false;
-
-  if (mode) {
-    const isModeMatch = controls?.[modeControl]?.value === mode;
-    if (!isModeMatch) return false;
-
-    if (selectionMode && mode === 'dimensions') {
-      return controls?.[selectionModeControl]?.value === selectionMode;
-    }
-  }
-
-  return true;
-};
-
 // Initialize the controls object that will be populated dynamically
 const matrixifyControls: Record<string, SharedControlConfig<any>> = {};
 
 // Dynamically add axis-specific controls (rows and columns)
-(['columns', 'rows'] as const).forEach(axisParam => {
-  const axis: 'rows' | 'columns' = axisParam;
+['columns', 'rows'].forEach(axisParam => {
+  const axis = axisParam; // Capture the value in a local variable
 
   matrixifyControls[`matrixify_mode_${axis}`] = {
     type: 'RadioButtonControl',
@@ -71,18 +43,17 @@ const matrixifyControls: Record<string, SharedControlConfig<any>> = {};
       ['dimensions', t('Dimension members')],
     ],
     renderTrigger: true,
-    tabOverride: 'matrixify',
-    visibility: ({ controls }) => isMatrixifyVisible(controls, axis),
   };
 
   matrixifyControls[`matrixify_${axis}`] = {
     ...dndAdhocMetricControl,
     label: t(`Metrics`),
     multi: true,
-    validators: [], // No validation - rely on visibility
+    validators: [], // Not required
+    // description: t(`Select metrics for ${axis}`),
     renderTrigger: true,
-    tabOverride: 'matrixify',
-    visibility: ({ controls }) => isMatrixifyVisible(controls, axis, 'metrics'),
+    visibility: ({ controls }) =>
+      controls?.[`matrixify_mode_${axis}`]?.value === 'metrics',
   };
 
   // Combined dimension and values control
@@ -91,9 +62,8 @@ const matrixifyControls: Record<string, SharedControlConfig<any>> = {};
     label: t(`Dimension selection`),
     description: t(`Select dimension and values`),
     default: { dimension: '', values: [] },
-    validators: [], // No validation - rely on visibility
+    validators: [], // Not required
     renderTrigger: true,
-    tabOverride: 'matrixify',
     shouldMapStateToProps: (prevState, state) => {
       // Recalculate when any relevant form_data field changes
       const fieldsToCheck = [
@@ -112,40 +82,24 @@ const matrixifyControls: Record<string, SharedControlConfig<any>> = {};
       const getValue = (key: string, defaultValue?: any) =>
         form_data?.[key] ?? controls?.[key]?.value ?? defaultValue;
 
-      const selectionMode = getValue(
-        `matrixify_dimension_selection_mode_${axis}`,
-        'members',
-      );
-
-      const isVisible = isMatrixifyVisible(controls, axis, 'dimensions');
-
-      // Validate dimension is selected when visible
-      const dimensionValidator = (value: any) => {
-        if (!value?.dimension) {
-          return t('Dimension is required');
-        }
-        return false;
-      };
-
-      // Additional validation for topN mode
-      const validators = isVisible
-        ? [dimensionValidator, validateNonEmpty]
-        : [];
-
       return {
         datasource,
-        selectionMode,
+        selectionMode: getValue(
+          `matrixify_dimension_selection_mode_${axis}`,
+          'members',
+        ),
         topNMetric: getValue(`matrixify_topn_metric_${axis}`),
         topNValue: getValue(`matrixify_topn_value_${axis}`),
         topNOrder: getValue(`matrixify_topn_order_${axis}`),
         formData: form_data,
-        validators,
       };
     },
     visibility: ({ controls }) =>
-      isMatrixifyVisible(controls, axis, 'dimensions'),
+      controls?.[`matrixify_mode_${axis}`]?.value === 'dimensions',
   };
 
+  // Dimension picker for TopN mode (just dimension, no values)
+  // NOTE: This is now handled by matrixify_dimension control, so hiding it
   matrixifyControls[`matrixify_topn_dimension_${axis}`] = {
     type: 'SelectControl',
     label: t('Dimension'),
@@ -173,67 +127,33 @@ const matrixifyControls: Record<string, SharedControlConfig<any>> = {};
       ['topn', t('Top n')],
     ],
     renderTrigger: true,
-    tabOverride: 'matrixify',
     visibility: ({ controls }) =>
-      isMatrixifyVisible(controls, axis, 'dimensions'),
+      controls?.[`matrixify_mode_${axis}`]?.value === 'dimensions',
   };
 
   // TopN controls
   matrixifyControls[`matrixify_topn_value_${axis}`] = {
-    type: 'NumberControl',
+    type: 'TextControl',
     label: t(`Number of top values`),
     description: t(`How many top values to select`),
     default: 10,
     isInt: true,
-    validators: [],
-    renderTrigger: true,
-    tabOverride: 'matrixify',
     visibility: ({ controls }) =>
-      isMatrixifyVisible(controls, axis, 'dimensions', 'topn'),
-    mapStateToProps: ({ controls }) => {
-      const isVisible = isMatrixifyVisible(
-        controls,
-        axis,
-        'dimensions',
+      controls?.[`matrixify_mode_${axis}`]?.value === 'dimensions' &&
+      controls?.[`matrixify_dimension_selection_mode_${axis}`]?.value ===
         'topn',
-      );
-
-      return {
-        validators: isVisible ? [validateNonEmpty] : [],
-      };
-    },
   };
 
   matrixifyControls[`matrixify_topn_metric_${axis}`] = {
     ...dndAdhocMetricControl,
     label: t(`Metric for ordering`),
     multi: false,
-    validators: [],
+    validators: [], // Not required
     description: t(`Metric to use for ordering Top N values`),
-    tabOverride: 'matrixify',
     visibility: ({ controls }) =>
-      isMatrixifyVisible(controls, axis, 'dimensions', 'topn'),
-    mapStateToProps: (state, controlState) => {
-      const { controls, datasource } = state;
-      const isVisible = isMatrixifyVisible(
-        controls,
-        axis,
-        'dimensions',
+      controls?.[`matrixify_mode_${axis}`]?.value === 'dimensions' &&
+      controls?.[`matrixify_dimension_selection_mode_${axis}`]?.value ===
         'topn',
-      );
-
-      const originalProps =
-        dndAdhocMetricControl.mapStateToProps?.(state, controlState) || {};
-
-      return {
-        ...originalProps,
-        columns: datasource?.columns || [],
-        savedMetrics: defineSavedMetrics(datasource),
-        datasource,
-        datasourceType: datasource?.type,
-        validators: isVisible ? [validateNonEmpty] : [],
-      };
-    },
   };
 
   matrixifyControls[`matrixify_topn_order_${axis}`] = {
@@ -244,10 +164,10 @@ const matrixifyControls: Record<string, SharedControlConfig<any>> = {};
       ['asc', t('Ascending')],
       ['desc', t('Descending')],
     ],
-    renderTrigger: true,
-    tabOverride: 'matrixify',
     visibility: ({ controls }) =>
-      isMatrixifyVisible(controls, axis, 'dimensions', 'topn'),
+      controls?.[`matrixify_mode_${axis}`]?.value === 'dimensions' &&
+      controls?.[`matrixify_dimension_selection_mode_${axis}`]?.value ===
+        'topn',
   };
 });
 
@@ -293,22 +213,15 @@ matrixifyControls.matrixify_charts_per_row = {
     !controls?.matrixify_fit_columns_dynamically?.value,
 };
 
-matrixifyControls.matrixify_enable_vertical_layout = {
+// Main enable control
+matrixifyControls.matrixify_enabled = {
   type: 'CheckboxControl',
-  label: t('Enable vertical layout (rows)'),
-  description: t('Create matrix rows by stacking charts vertically'),
+  label: t('Enable matrixify'),
+  description: t(
+    'Transform this chart into a matrix/grid of charts based on dimensions or metrics',
+  ),
   default: false,
   renderTrigger: true,
-  tabOverride: 'matrixify',
-};
-
-matrixifyControls.matrixify_enable_horizontal_layout = {
-  type: 'CheckboxControl',
-  label: t('Enable horizontal layout (columns)'),
-  description: t('Create matrix columns by placing charts side-by-side'),
-  default: false,
-  renderTrigger: true,
-  tabOverride: 'matrixify',
 };
 
 // Cell title control for Matrixify
@@ -321,8 +234,8 @@ matrixifyControls.matrixify_cell_title_template = {
   default: '',
   renderTrigger: true,
   visibility: ({ controls }) =>
-    controls?.matrixify_enable_vertical_layout?.value === true ||
-    controls?.matrixify_enable_horizontal_layout?.value === true,
+    (controls?.matrixify_mode_rows?.value ||
+      controls?.matrixify_mode_columns?.value) !== undefined,
 };
 
 // Matrix display controls
@@ -332,9 +245,9 @@ matrixifyControls.matrixify_show_row_labels = {
   description: t('Display labels for each row on the left side of the matrix'),
   default: true,
   renderTrigger: true,
-  tabOverride: 'matrixify',
   visibility: ({ controls }) =>
-    controls?.matrixify_enable_vertical_layout?.value === true,
+    (controls?.matrixify_mode_rows?.value ||
+      controls?.matrixify_mode_columns?.value) !== undefined,
 };
 
 matrixifyControls.matrixify_show_column_headers = {
@@ -343,9 +256,9 @@ matrixifyControls.matrixify_show_column_headers = {
   description: t('Display headers for each column at the top of the matrix'),
   default: true,
   renderTrigger: true,
-  tabOverride: 'matrixify',
   visibility: ({ controls }) =>
-    controls?.matrixify_enable_horizontal_layout?.value === true,
+    (controls?.matrixify_mode_rows?.value ||
+      controls?.matrixify_mode_columns?.value) !== undefined,
 };
 
 export { matrixifyControls };

superset-frontend/packages/superset-ui-chart-controls/src/utils/checkColumnType.ts

@@ -17,7 +17,11 @@
  * under the License.
  */
 import { ensureIsArray, GenericDataType, ValueOf } from '@superset-ui/core';
-import { ControlPanelState, isDataset, isQueryResponse } from '../types';
+import {
+  ControlPanelState,
+  isDataset,
+  isQueryResponse,
+} from '@superset-ui/chart-controls';
 
 export function checkColumnType(
   columnName: string,

superset-frontend/packages/superset-ui-chart-controls/test/tsconfig.json

@@ -2,8 +2,18 @@
   "compilerOptions": {
     "composite": false,
     "emitDeclarationOnly": false,
+    "noEmit": true,
     "rootDir": "."
   },
   "extends": "../../../tsconfig.json",
-  "include": ["**/*", "../types/**/*", "../../../types/**/*"]
+  "include": [
+    "**/*",
+    "../types/**/*",
+    "../../../types/**/*"
+  ],
+  "references": [
+    {
+      "path": ".."
+    }
+  ]
 }

superset-frontend/packages/superset-ui-chart-controls/tsconfig.json

@@ -1,13 +1,22 @@
 {
-  "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "baseUrl": "../..",
-    "outDir": "lib"
+    "declarationDir": "lib",
+    "outDir": "lib",
+    "rootDir": "src"
   },
-  "include": ["src/**/*", "types/**/*"],
-  "exclude": ["src/**/*.test.*", "src/**/*.stories.*"],
+  "exclude": [
+    "lib",
+    "test"
+  ],
+  "extends": "../../tsconfig.json",
+  "include": [
+    "src/**/*",
+    "types/**/*",
+    "../../types/**/*"
+  ],
   "references": [
-    { "path": "../superset-core" },
-    { "path": "../superset-ui-core" }
+    {
+      "path": "../superset-ui-core"
+    }
   ]
 }

superset-frontend/packages/superset-ui-core/package.json

@@ -24,15 +24,14 @@
     "lib"
   ],
   "dependencies": {
-    "@apache-superset/core": "*",
     "@ant-design/icons": "^5.2.6",
     "@babel/runtime": "^7.28.2",
     "@fontsource/fira-code": "^5.2.6",
     "@fontsource/inter": "^5.2.6",
     "@types/json-bigint": "^1.0.4",
     "ace-builds": "^1.43.1",
-    "ag-grid-community": "34.2.0",
-    "ag-grid-react": "34.2.0",
+    "ag-grid-community": "^34.0.2",
+    "ag-grid-react": "34.0.2",
     "brace": "^0.11.1",
     "classnames": "^2.2.5",
     "csstype": "^3.1.3",

superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridGenerator.ts

@@ -276,10 +276,10 @@ export function generateMatrixifyGrid(
 
       const cellFormData = generateCellFormData(
         formData,
-        rowCount > 0 ? config.rows : null,
-        colCount > 0 ? config.columns : null,
-        rowCount > 0 ? row : null,
-        colCount > 0 ? col : null,
+        rowCount > 1 ? config.rows : null,
+        colCount > 1 ? config.columns : null,
+        rowCount > 1 ? row : null,
+        colCount > 1 ? col : null,
       );
 
       // Generate title using template if provided

superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridRenderer.test.tsx

@@ -74,8 +74,7 @@ test('should create single group when fitting columns dynamically', () => {
 
   const formData = {
     viz_type: 'test_chart',
-    matrixify_enable_vertical_layout: true,
-    matrixify_enable_horizontal_layout: true,
+    matrixify_enabled: true,
     matrixify_fit_columns_dynamically: true,
     matrixify_charts_per_row: 3,
     matrixify_show_row_labels: true,
@@ -124,8 +123,7 @@ test('should create multiple groups when not fitting columns dynamically', () =>
 
   const formData = {
     viz_type: 'test_chart',
-    matrixify_enable_vertical_layout: true,
-    matrixify_enable_horizontal_layout: true,
+    matrixify_enabled: true,
     matrixify_fit_columns_dynamically: false,
     matrixify_charts_per_row: 3,
     matrixify_show_row_labels: true,
@@ -160,8 +158,7 @@ test('should handle exact division of columns', () => {
 
   const formData = {
     viz_type: 'test_chart',
-    matrixify_enable_vertical_layout: true,
-    matrixify_enable_horizontal_layout: true,
+    matrixify_enabled: true,
     matrixify_fit_columns_dynamically: false,
     matrixify_charts_per_row: 2,
     matrixify_show_row_labels: true,
@@ -189,8 +186,7 @@ test('should handle case where charts_per_row exceeds total columns', () => {
 
   const formData = {
     viz_type: 'test_chart',
-    matrixify_enable_vertical_layout: true,
-    matrixify_enable_horizontal_layout: true,
+    matrixify_enabled: true,
     matrixify_fit_columns_dynamically: false,
     matrixify_charts_per_row: 5,
     matrixify_show_row_labels: true,
@@ -220,8 +216,7 @@ test('should show headers for each group when wrapping occurs', () => {
 
   const formData = {
     viz_type: 'test_chart',
-    matrixify_enable_vertical_layout: true,
-    matrixify_enable_horizontal_layout: true,
+    matrixify_enabled: true,
     matrixify_fit_columns_dynamically: false,
     matrixify_charts_per_row: 2,
     matrixify_show_row_labels: true,
@@ -255,8 +250,7 @@ test('should show headers only on first row when not wrapping', () => {
 
   const formData = {
     viz_type: 'test_chart',
-    matrixify_enable_vertical_layout: true,
-    matrixify_enable_horizontal_layout: true,
+    matrixify_enabled: true,
     matrixify_fit_columns_dynamically: true, // No wrapping
     matrixify_show_row_labels: true,
     matrixify_show_column_headers: true,
@@ -285,8 +279,7 @@ test('should hide headers when disabled', () => {
 
   const formData = {
     viz_type: 'test_chart',
-    matrixify_enable_vertical_layout: true,
-    matrixify_enable_horizontal_layout: true,
+    matrixify_enabled: true,
     matrixify_show_row_labels: false,
     matrixify_show_column_headers: false,
   };
@@ -313,8 +306,7 @@ test('should place cells correctly in wrapped layout', () => {
 
   const formData = {
     viz_type: 'test_chart',
-    matrixify_enable_vertical_layout: true,
-    matrixify_enable_horizontal_layout: true,
+    matrixify_enabled: true,
     matrixify_fit_columns_dynamically: false,
     matrixify_charts_per_row: 2,
     matrixify_show_row_labels: true,
@@ -344,8 +336,7 @@ test('should handle null grid gracefully', () => {
 
   const formData = {
     viz_type: 'test_chart',
-    matrixify_enable_vertical_layout: true,
-    matrixify_enable_horizontal_layout: true,
+    matrixify_enabled: true,
   };
 
   const { container } = renderWithTheme(
@@ -366,8 +357,7 @@ test('should handle empty grid gracefully', () => {
 
   const formData = {
     viz_type: 'test_chart',
-    matrixify_enable_vertical_layout: true,
-    matrixify_enable_horizontal_layout: true,
+    matrixify_enabled: true,
   };
 
   const { container } = renderWithTheme(
@@ -391,8 +381,7 @@ test('should use default values for missing configuration', () => {
 
   const formData = {
     viz_type: 'test_chart',
-    matrixify_enable_vertical_layout: true,
-    matrixify_enable_horizontal_layout: true,
+    matrixify_enabled: true,
     // Missing optional configurations
   };
 

superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridRenderer.tsx

@@ -128,13 +128,9 @@ function MatrixifyGridRenderer({
     [formData],
   );
 
-  // Determine layout parameters - only show headers/labels if layout is enabled
-  const showRowLabels =
-    formData.matrixify_enable_vertical_layout === true &&
-    (formData.matrixify_show_row_labels ?? true);
-  const showColumnHeaders =
-    formData.matrixify_enable_horizontal_layout === true &&
-    (formData.matrixify_show_column_headers ?? true);
+  // Determine layout parameters
+  const showRowLabels = formData.matrixify_show_row_labels ?? true;
+  const showColumnHeaders = formData.matrixify_show_column_headers ?? true;
   const rowHeight = formData.matrixify_row_height || DEFAULT_ROW_HEIGHT;
   const fitColumnsDynamically =
     formData.matrixify_fit_columns_dynamically ?? true;

superset-frontend/packages/superset-ui-core/src/chart/models/ChartMetadata.ts

@@ -26,7 +26,6 @@ interface LookupTable {
 
 export interface ExampleImage {
   url: string;
-  urlDark?: string;
   caption?: string;
 }
 
@@ -39,7 +38,6 @@ export interface ChartMetadataConfig {
   enableNoResults?: boolean;
   supportedAnnotationTypes?: string[];
   thumbnail: string;
-  thumbnailDark?: string;
   useLegacyApi?: boolean;
   behaviors?: Behavior[];
   exampleGallery?: ExampleImage[];
@@ -73,8 +71,6 @@ export default class ChartMetadata {
 
   thumbnail: string;
 
-  thumbnailDark?: string;
-
   useLegacyApi: boolean;
 
   behaviors: Behavior[];
@@ -111,7 +107,6 @@ export default class ChartMetadata {
       description = '',
       supportedAnnotationTypes = [],
       thumbnail,
-      thumbnailDark,
       useLegacyApi = false,
       behaviors = [],
       datasourceCount = 1,
@@ -143,7 +138,6 @@ export default class ChartMetadata {
     );
     this.supportedAnnotationTypes = supportedAnnotationTypes;
     this.thumbnail = thumbnail;
-    this.thumbnailDark = thumbnailDark;
     this.useLegacyApi = useLegacyApi;
     this.behaviors = behaviors;
     this.datasourceCount = datasourceCount;

superset-frontend/packages/superset-ui-core/src/chart/types/matrixify.test.ts

@@ -37,11 +37,10 @@ test('isMatrixifyEnabled should return false when no matrixify configuration exi
   expect(isMatrixifyEnabled(formData)).toBe(false);
 });
 
-test('isMatrixifyEnabled should return false when layout controls are false', () => {
+test('isMatrixifyEnabled should return false when matrixify_enabled is false', () => {
   const formData = {
     viz_type: 'table',
-    matrixify_enable_vertical_layout: false,
-    matrixify_enable_horizontal_layout: false,
+    matrixify_enabled: false,
     matrixify_mode_rows: 'metrics',
     matrixify_rows: [createMetric('Revenue')],
   } as MatrixifyFormData;
@@ -52,7 +51,7 @@ test('isMatrixifyEnabled should return false when layout controls are false', ()
 test('isMatrixifyEnabled should return true for valid metrics mode configuration', () => {
   const formData = {
     viz_type: 'table',
-    matrixify_enable_vertical_layout: true,
+    matrixify_enabled: true,
     matrixify_mode_rows: 'metrics',
     matrixify_mode_columns: 'metrics',
     matrixify_rows: [createMetric('Revenue')],
@@ -65,7 +64,7 @@ test('isMatrixifyEnabled should return true for valid metrics mode configuration
 test('isMatrixifyEnabled should return true for valid dimensions mode configuration', () => {
   const formData = {
     viz_type: 'table',
-    matrixify_enable_vertical_layout: true,
+    matrixify_enabled: true,
     matrixify_mode_rows: 'dimensions',
     matrixify_mode_columns: 'dimensions',
     matrixify_dimension_rows: { dimension: 'country', values: ['USA'] },
@@ -78,7 +77,7 @@ test('isMatrixifyEnabled should return true for valid dimensions mode configurat
 test('isMatrixifyEnabled should return true for mixed mode configuration', () => {
   const formData = {
     viz_type: 'table',
-    matrixify_enable_vertical_layout: true,
+    matrixify_enabled: true,
     matrixify_mode_rows: 'metrics',
     matrixify_mode_columns: 'dimensions',
     matrixify_rows: [createMetric('Revenue')],
@@ -91,7 +90,7 @@ test('isMatrixifyEnabled should return true for mixed mode configuration', () =>
 test('isMatrixifyEnabled should return true for topn dimension selection mode', () => {
   const formData = {
     viz_type: 'table',
-    matrixify_enable_vertical_layout: true,
+    matrixify_enabled: true,
     matrixify_mode_rows: 'dimensions',
     matrixify_mode_columns: 'dimensions',
     matrixify_dimension_rows: {
@@ -110,7 +109,7 @@ test('isMatrixifyEnabled should return true for topn dimension selection mode',
 test('isMatrixifyEnabled should return false when both axes have empty metrics arrays', () => {
   const formData = {
     viz_type: 'table',
-    matrixify_enable_vertical_layout: true,
+    matrixify_enabled: true,
     matrixify_mode_rows: 'metrics',
     matrixify_mode_columns: 'metrics',
     matrixify_rows: [],
@@ -123,7 +122,7 @@ test('isMatrixifyEnabled should return false when both axes have empty metrics a
 test('isMatrixifyEnabled should return false when both dimensions have empty values and no topn mode', () => {
   const formData = {
     viz_type: 'table',
-    matrixify_enable_vertical_layout: true,
+    matrixify_enabled: true,
     matrixify_mode_rows: 'dimensions',
     matrixify_mode_columns: 'dimensions',
     matrixify_dimension_rows: { dimension: 'country', values: [] },
@@ -141,7 +140,7 @@ test('getMatrixifyConfig should return null when no matrixify configuration exis
 test('getMatrixifyConfig should return valid config for metrics mode', () => {
   const formData = {
     viz_type: 'table',
-    matrixify_enable_vertical_layout: true,
+    matrixify_enabled: true,
     matrixify_mode_rows: 'metrics',
     matrixify_mode_columns: 'metrics',
     matrixify_rows: [createMetric('Revenue')],
@@ -159,7 +158,7 @@ test('getMatrixifyConfig should return valid config for metrics mode', () => {
 test('getMatrixifyConfig should return valid config for dimensions mode', () => {
   const formData = {
     viz_type: 'table',
-    matrixify_enable_vertical_layout: true,
+    matrixify_enabled: true,
     matrixify_mode_rows: 'dimensions',
     matrixify_mode_columns: 'dimensions',
     matrixify_dimension_rows: { dimension: 'country', values: ['USA'] },
@@ -183,7 +182,7 @@ test('getMatrixifyConfig should return valid config for dimensions mode', () =>
 test('getMatrixifyConfig should handle topn selection mode', () => {
   const formData = {
     viz_type: 'table',
-    matrixify_enable_vertical_layout: true,
+    matrixify_enabled: true,
     matrixify_mode_rows: 'dimensions',
     matrixify_mode_columns: 'dimensions',
     matrixify_dimension_rows: {
@@ -204,8 +203,7 @@ test('getMatrixifyConfig should handle topn selection mode', () => {
 test('getMatrixifyValidationErrors should return empty array when matrixify is not enabled', () => {
   const formData = {
     viz_type: 'table',
-    matrixify_enable_vertical_layout: false,
-    matrixify_enable_horizontal_layout: false,
+    matrixify_enabled: false,
   } as MatrixifyFormData;
 
   expect(getMatrixifyValidationErrors(formData)).toEqual([]);
@@ -214,7 +212,7 @@ test('getMatrixifyValidationErrors should return empty array when matrixify is n
 test('getMatrixifyValidationErrors should return empty array when properly configured', () => {
   const formData = {
     viz_type: 'table',
-    matrixify_enable_vertical_layout: true,
+    matrixify_enabled: true,
     matrixify_mode_rows: 'metrics',
     matrixify_mode_columns: 'metrics',
     matrixify_rows: [createMetric('Revenue')],
@@ -227,7 +225,7 @@ test('getMatrixifyValidationErrors should return empty array when properly confi
 test('getMatrixifyValidationErrors should return error when enabled but no configuration exists', () => {
   const formData = {
     viz_type: 'table',
-    matrixify_enable_vertical_layout: true,
+    matrixify_enabled: true,
   } as MatrixifyFormData;
 
   const errors = getMatrixifyValidationErrors(formData);
@@ -237,7 +235,7 @@ test('getMatrixifyValidationErrors should return error when enabled but no confi
 test('getMatrixifyValidationErrors should return error when metrics mode has no metrics', () => {
   const formData = {
     viz_type: 'table',
-    matrixify_enable_vertical_layout: true,
+    matrixify_enabled: true,
     matrixify_mode_rows: 'metrics',
     matrixify_rows: [],
     matrixify_columns: [],
@@ -263,7 +261,7 @@ test('should handle empty form data object', () => {
 test('should handle partial configuration with one axis only', () => {
   const formData = {
     viz_type: 'table',
-    matrixify_enable_vertical_layout: true,
+    matrixify_enabled: true,
     matrixify_mode_rows: 'metrics',
     matrixify_rows: [createMetric('Revenue')],
     // No columns configuration

superset-frontend/packages/superset-ui-core/src/chart/types/matrixify.ts

@@ -96,9 +96,8 @@ export interface MatrixifyAxisConfig {
  * Complete Matrixify configuration in form data
  */
 export interface MatrixifyFormData {
-  // Layout enable controls
-  matrixify_enable_vertical_layout?: boolean;
-  matrixify_enable_horizontal_layout?: boolean;
+  // Enable/disable matrixify functionality
+  matrixify_enabled?: boolean;
 
   // Row axis configuration
   matrixify_mode_rows?: MatrixifyMode;
@@ -178,12 +177,8 @@ export function getMatrixifyConfig(
  * Check if Matrixify is enabled and properly configured
  */
 export function isMatrixifyEnabled(formData: MatrixifyFormData): boolean {
-  // Check if either vertical or horizontal layout is enabled
-  const hasVerticalLayout = formData.matrixify_enable_vertical_layout === true;
-  const hasHorizontalLayout =
-    formData.matrixify_enable_horizontal_layout === true;
-
-  if (!hasVerticalLayout && !hasHorizontalLayout) {
+  // First check if matrixify is explicitly enabled via checkbox
+  if (!formData.matrixify_enabled) {
     return false;
   }
 
@@ -221,11 +216,7 @@ export function getMatrixifyValidationErrors(
   const errors: string[] = [];
 
   // Only validate if matrixify is enabled
-  const hasVerticalLayout = formData.matrixify_enable_vertical_layout === true;
-  const hasHorizontalLayout =
-    formData.matrixify_enable_horizontal_layout === true;
-
-  if (!hasVerticalLayout && !hasHorizontalLayout) {
+  if (!formData.matrixify_enabled) {
     return errors;
   }
 

superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/index.tsx

@@ -123,33 +123,21 @@ export function AsyncAceEditor(
     const cssWorkerUrlPromise = import(
       'ace-builds/src-min-noconflict/worker-css'
     );
-    const javascriptWorkerUrlPromise = import(
-      'ace-builds/src-min-noconflict/worker-javascript'
-    );
-    const htmlWorkerUrlPromise = import(
-      'ace-builds/src-min-noconflict/worker-html'
-    );
     const acequirePromise = import('ace-builds/src-min-noconflict/ace');
 
     const [
       { default: ReactAceEditor },
       { config },
       { default: cssWorkerUrl },
-      { default: javascriptWorkerUrl },
-      { default: htmlWorkerUrl },
       { require: acequire },
     ] = await Promise.all([
       reactAcePromise,
       aceBuildsConfigPromise,
       cssWorkerUrlPromise,
-      javascriptWorkerUrlPromise,
-      htmlWorkerUrlPromise,
       acequirePromise,
     ]);
 
     config.setModuleUrl('ace/mode/css_worker', cssWorkerUrl);
-    config.setModuleUrl('ace/mode/javascript_worker', javascriptWorkerUrl);
-    config.setModuleUrl('ace/mode/html_worker', htmlWorkerUrl);
 
     await Promise.all(aceModules.map(x => aceModuleLoaders[x]()));
 

superset-frontend/packages/superset-ui-core/src/components/CodeEditor/index.tsx

@@ -1,106 +0,0 @@
-/* eslint-disable import/first */
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { FC } from 'react';
-import AceEditor, { IAceEditorProps } from 'react-ace';
-import ace from 'ace-builds/src-noconflict/ace';
-
-// Disable workers to avoid localhost loading issues
-ace.config.set('useWorker', false);
-
-// Import required modes and themes after ace is loaded
-import 'ace-builds/src-min-noconflict/mode-handlebars';
-import 'ace-builds/src-min-noconflict/mode-css';
-import 'ace-builds/src-min-noconflict/mode-json';
-import 'ace-builds/src-min-noconflict/mode-sql';
-import 'ace-builds/src-min-noconflict/mode-markdown';
-import 'ace-builds/src-min-noconflict/mode-javascript';
-import 'ace-builds/src-min-noconflict/mode-html';
-import 'ace-builds/src-noconflict/theme-github';
-import 'ace-builds/src-noconflict/theme-monokai';
-
-export type CodeEditorMode =
-  | 'handlebars'
-  | 'css'
-  | 'json'
-  | 'sql'
-  | 'markdown'
-  | 'javascript'
-  | 'html';
-
-export type CodeEditorTheme = 'light' | 'dark';
-
-export interface CodeEditorProps
-  extends Omit<IAceEditorProps, 'mode' | 'theme'> {
-  mode?: CodeEditorMode;
-  theme?: CodeEditorTheme;
-  name?: string;
-}
-
-export const CodeEditor: FC<CodeEditorProps> = ({
-  mode = 'handlebars',
-  theme = 'dark',
-  name,
-  width = '100%',
-  height = '300px',
-  value,
-  fontSize = 14,
-  showPrintMargin = true,
-  focus = true,
-  wrapEnabled = true,
-  highlightActiveLine = true,
-  editorProps = { $blockScrolling: true },
-  setOptions,
-  ...rest
-}: CodeEditorProps) => {
-  const editorName = name || Math.random().toString(36).substring(7);
-  const aceTheme = theme === 'light' ? 'github' : 'monokai';
-
-  return (
-    <AceEditor
-      mode={mode}
-      theme={aceTheme}
-      name={editorName}
-      height={height}
-      width={width}
-      value={value}
-      fontSize={fontSize}
-      showPrintMargin={showPrintMargin}
-      focus={focus}
-      editorProps={editorProps}
-      wrapEnabled={wrapEnabled}
-      highlightActiveLine={highlightActiveLine}
-      setOptions={{
-        enableBasicAutocompletion: true,
-        enableLiveAutocompletion: true,
-        enableSnippets: true,
-        showLineNumbers: true,
-        tabSize: 2,
-        showGutter: true,
-        fontFamily:
-          'Menlo, Consolas, Courier New, Ubuntu Mono, source-code-pro, Lucida Console, monospace',
-        ...setOptions,
-      }}
-      {...rest}
-    />
-  );
-};
-
-export default CodeEditor;

superset-frontend/packages/superset-ui-core/src/components/LastUpdated/index.tsx

@@ -19,10 +19,8 @@
 import { useEffect, useState, FunctionComponent } from 'react';
 
 import { t, styled, css, useTheme } from '@superset-ui/core';
-import { Dayjs } from 'dayjs';
+import dayjs from 'dayjs';
 import { extendedDayjs } from '../../utils/dates';
-import 'dayjs/plugin/updateLocale';
-import 'dayjs/plugin/calendar';
 import { Icons } from '../Icons';
 import type { LastUpdatedProps } from './types';
 
@@ -48,7 +46,9 @@ export const LastUpdated: FunctionComponent<LastUpdatedProps> = ({
   update,
 }) => {
   const theme = useTheme();
-  const [timeSince, setTimeSince] = useState<Dayjs>(extendedDayjs(updatedAt));
+  const [timeSince, setTimeSince] = useState<dayjs.Dayjs>(
+    extendedDayjs(updatedAt),
+  );
 
   useEffect(() => {
     setTimeSince(() => extendedDayjs(updatedAt));

superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx

@@ -368,9 +368,13 @@ const CustomModal = ({
 };
 CustomModal.displayName = 'Modal';
 
+// Theme-aware confirmation modal - now inherits theme through App wrapper in SupersetThemeProvider
+const themedConfirm = (props: Parameters<typeof AntdModal.confirm>[0]) =>
+  AntdModal.confirm(props);
+
 export const Modal = Object.assign(CustomModal, {
   error: AntdModal.error,
   warning: AntdModal.warning,
-  confirm: AntdModal.confirm,
+  confirm: themedConfirm,
   useModal: AntdModal.useModal,
 });

superset-frontend/packages/superset-ui-core/src/components/index.ts

@@ -181,9 +181,3 @@ export {
   type ThemedAgGridReactProps,
   setupAGGridModules,
 } from './ThemedAgGridReact';
-export {
-  CodeEditor,
-  type CodeEditorProps,
-  type CodeEditorMode,
-  type CodeEditorTheme,
-} from './CodeEditor';

superset-frontend/packages/superset-ui-core/src/theme/Theme.tsx

@@ -19,7 +19,7 @@
 /* eslint-disable react-prefer-function-component/react-prefer-function-component */
 // eslint-disable-next-line no-restricted-syntax
 import React from 'react';
-import { theme as antdThemeImport, ConfigProvider } from 'antd';
+import { theme as antdThemeImport, ConfigProvider, App } from 'antd';
 
 // @fontsource/* v5.1+ doesn't play nice with eslint-import plugin v2.31+
 /* eslint-disable import/extensions */
@@ -243,7 +243,7 @@ export class Theme {
         <ThemeProvider theme={themeState.theme}>
           <GlobalStyles />
           <ConfigProvider theme={themeState.antdConfig}>
-            {children}
+            <App>{children}</App>
           </ConfigProvider>
         </ThemeProvider>
       </EmotionCacheProvider>

superset-frontend/packages/superset-ui-core/src/theme/index.tsx

@@ -60,7 +60,10 @@ export function useTheme() {
 
 const styled: CreateStyled = emotionStyled;
 
-const themeObject: Theme = Theme.fromConfig();
+// launching in in dark mode for now while iterating
+const themeObject: Theme = Theme.fromConfig({
+  algorithm: ThemeAlgorithm.DEFAULT,
+});
 
 const { theme } = themeObject;
 const supersetTheme = theme;

superset-frontend/packages/superset-ui-core/src/theme/types.ts

@@ -127,15 +127,6 @@ export interface SupersetSpecificTokens {
   // Spinner-related
   brandSpinnerUrl?: string;
   brandSpinnerSvg?: string;
-
-  // ECharts-related
-  /** Global ECharts configuration overrides applied to all chart types */
-  echartsOptionsOverrides?: any;
-
-  /** Chart-specific ECharts configuration overrides keyed by viz_type */
-  echartsOptionsOverridesByChartType?: {
-    [chartType: string]: any;
-  };
 }
 
 /**

superset-frontend/packages/superset-ui-core/src/utils/dates.ts

@@ -43,7 +43,6 @@ dayjs.updateLocale('en', {
 });
 
 export const extendedDayjs = dayjs;
-export type { Dayjs };
 
 export const fDuration = function (
   t1: number,

superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts

@@ -26,7 +26,6 @@ export enum FeatureFlag {
   AlertReports = 'ALERT_REPORTS',
   AlertReportTabs = 'ALERT_REPORT_TABS',
   AlertReportSlackV2 = 'ALERT_REPORT_SLACK_V2',
-  AlertReportsFilter = 'ALERT_REPORTS_FILTER',
   AllowFullCsvExport = 'ALLOW_FULL_CSV_EXPORT',
   AvoidColorsCollision = 'AVOID_COLORS_COLLISION',
   ChartPluginsExperimental = 'CHART_PLUGINS_EXPERIMENTAL',

superset-frontend/packages/superset-ui-core/src/utils/index.ts

@@ -33,4 +33,3 @@ export * from './random';
 export * from './typedMemo';
 export * from './html';
 export * from './tooltip';
-export * from './merge';

superset-frontend/packages/superset-ui-core/src/utils/merge.test.ts

@@ -1,61 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { mergeReplaceArrays } from './merge';
-
-describe('lodash utilities', () => {
-  describe('mergeReplaceArrays', () => {
-    it('should merge objects and replace arrays', () => {
-      const obj1 = { a: [1, 2], b: { c: 3 } };
-      const obj2 = { a: [4, 5], b: { d: 6 } };
-
-      const result = mergeReplaceArrays(obj1, obj2);
-
-      expect(result).toEqual({
-        a: [4, 5], // array replaced
-        b: { c: 3, d: 6 }, // objects merged
-      });
-    });
-
-    it('should handle precedence with multiple sources', () => {
-      const base = { x: { y: 1 }, z: [1] };
-      const override1 = { x: { y: 2 }, z: [2, 3] };
-      const override2 = { x: { y: 3 }, z: [4] };
-
-      const result = mergeReplaceArrays(base, override1, override2);
-
-      expect(result).toEqual({
-        x: { y: 3 }, // last wins
-        z: [4], // array replaced by last
-      });
-    });
-
-    it('should handle empty and null values', () => {
-      const base = { a: [1], b: { x: 1 } };
-      const override = { a: [], b: { x: null } };
-
-      const result = mergeReplaceArrays(base, override);
-
-      expect(result).toEqual({
-        a: [], // empty array replaces
-        b: { x: null }, // null overrides
-      });
-    });
-  });
-});

superset-frontend/packages/superset-ui-core/src/utils/merge.ts

@@ -1,52 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { mergeWith } from 'lodash';
-
-/**
- * Merges objects using lodash.mergeWith, but replaces arrays instead of concatenating them.
- * This is useful for configuration objects where you want to completely override array values
- * rather than merge them by index.
- *
- * @example
- * const obj1 = { a: [1, 2], b: { c: 3 } };
- * const obj2 = { a: [4, 5], b: { d: 6 } };
- * mergeReplaceArrays(obj1, obj2);
- * // Result: { a: [4, 5], b: { c: 3, d: 6 } }
- *
- * @example
- * // ECharts configuration merging
- * const baseConfig = { series: [{ type: 'line' }], grid: { left: '10%' } };
- * const overrides = { series: [{ type: 'bar' }], grid: { right: '10%' } };
- * mergeReplaceArrays(baseConfig, overrides);
- * // Result: { series: [{ type: 'bar' }], grid: { left: '10%', right: '10%' } }
- *
- * @param sources - Objects to merge (rightmost wins for arrays, deep merge for objects)
- * @returns Merged object with arrays replaced, not concatenated
- */
-export function mergeReplaceArrays<T = any>(...sources: any[]): T {
-  const replaceArrays = (objValue: any, srcValue: any) => {
-    if (Array.isArray(srcValue)) {
-      return srcValue; // Replace arrays entirely
-    }
-    return undefined; // Let lodash handle object merging for non-arrays
-  };
-
-  return mergeWith({}, ...sources, replaceArrays);
-}

superset-frontend/packages/superset-ui-core/test/tsconfig.json

@@ -2,8 +2,14 @@
   "compilerOptions": {
     "composite": false,
     "emitDeclarationOnly": false,
+    "noEmit": true,
     "rootDir": "."
   },
   "extends": "../../../tsconfig.json",
-  "include": ["**/*", "../types/**/*", "../../../types/**/*"]
+  "include": ["**/*", "../types/**/*", "../../../types/**/*"],
+  "references": [
+    {
+      "path": ".."
+    }
+  ]
 }

superset-frontend/packages/superset-ui-core/tsconfig.json

@@ -1,10 +1,24 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "baseUrl": "../..",
-    "outDir": "lib"
+    "declarationDir": "lib",
+    "outDir": "lib",
+    "rootDir": "src",
+    "baseUrl": ".",
+    "paths": {
+      "src/*": ["./src/*"],
+      "@superset-ui/core": ["src"],
+      "@superset-ui/core/*": ["src/*"]
+    }
   },
-  "include": ["src/**/*", "types/**/*"],
-  "exclude": ["src/**/*.test.*", "src/**/*.stories.*"],
-  "references": [{ "path": "../superset-core" }]
+  "exclude": [
+    "lib",
+    "test"
+  ],
+  "include": [
+    "src/**/*",
+    "spec/**/*",
+    "types/**/*"
+  ],
+  "references": []
 }

superset-frontend/packages/superset-ui-core/types/ace-builds.d.ts

@@ -17,6 +17,4 @@
  * under the License.
  */
 declare module 'ace-builds/src-min-noconflict/worker-css';
-declare module 'ace-builds/src-min-noconflict/worker-javascript';
-declare module 'ace-builds/src-min-noconflict/worker-html';
 declare module 'ace-builds/src-min-noconflict/ace';

superset-frontend/packages/superset-ui-core/types/assets.d.ts

@@ -19,5 +19,3 @@
 declare module '*.gif';
 declare module '*.svg';
 declare module '*.png';
-declare module '*.jpg';
-declare module '*.jpeg';

superset-frontend/packages/superset-ui-switchboard/tsconfig.json

@@ -1,9 +1,18 @@
 {
-  "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "baseUrl": "../..",
-    "outDir": "lib"
+    "declarationDir": "lib",
+    "outDir": "lib",
+    "rootDir": "src"
   },
-  "include": ["src/**/*", "types/**/*"],
-  "exclude": ["src/**/*.test.*", "src/**/*.stories.*"]
+  "exclude": [
+    "lib",
+    "src/**/*.test.ts"
+  ],
+  "extends": "../../tsconfig.json",
+  "include": [
+    "src/**/*",
+    "types/**/*",
+    "../../types/**/*"
+  ],
+  "references": []
 }

superset-frontend/playwright.config.ts

@@ -1,90 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/// <reference types="node" />
-
-// eslint-disable-next-line import/no-extraneous-dependencies
-import { defineConfig } from '@playwright/test';
-
-export default defineConfig({
-  // Test directory
-  testDir: './playwright/tests',
-
-  // Timeout settings
-  timeout: 30000,
-  expect: { timeout: 8000 },
-
-  // Parallel execution
-  fullyParallel: true,
-  workers: process.env.CI ? 2 : 1,
-
-  // Retry logic - 2 retries in CI, 0 locally
-  retries: process.env.CI ? 2 : 0,
-
-  // Reporter configuration - multiple reporters for better visibility
-  reporter: process.env.CI
-    ? [
-        ['github'], // GitHub Actions annotations
-        ['list'], // Detailed output with summary table
-        ['html', { outputFolder: 'playwright-report', open: 'never' }], // Interactive report
-        ['json', { outputFile: 'test-results/results.json' }], // Machine-readable
-      ]
-    : [
-        ['list'], // Shows summary table locally
-        ['html', { outputFolder: 'playwright-report', open: 'on-failure' }], // Auto-open on failure
-      ],
-
-  // Global test setup
-  use: {
-    // Use environment variable for base URL in CI, default to localhost:8088 for local
-    baseURL: process.env.PLAYWRIGHT_BASE_URL || 'http://localhost:8088',
-
-    // Browser settings
-    headless: !!process.env.CI,
-
-    viewport: { width: 1280, height: 1024 },
-
-    // Screenshots and videos on failure
-    screenshot: 'only-on-failure',
-    video: 'retain-on-failure',
-
-    // Trace collection for debugging
-    trace: 'retain-on-failure',
-  },
-
-  projects: [
-    {
-      name: 'chromium',
-      use: {
-        browserName: 'chromium',
-        testIdAttribute: 'data-test',
-      },
-    },
-  ],
-
-  // Web server setup - disabled in CI (Flask started separately in workflow)
-  webServer: process.env.CI
-    ? undefined
-    : {
-        command: 'curl -f http://localhost:8088/health',
-        url: 'http://localhost:8088/health',
-        reuseExistingServer: true,
-        timeout: 5000,
-      },
-});

superset-frontend/playwright/README.md

@@ -1,218 +0,0 @@
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements.  See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership.  The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License.  You may obtain a copy of the License at
-
-  http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied.  See the License for the
-specific language governing permissions and limitations
-under the License.
--->
-
-# Playwright E2E Tests for Superset
-
-This directory contains Playwright end-to-end tests for Apache Superset, designed as a replacement for the existing Cypress tests during the migration to Playwright.
-
-## Architecture
-
-```
-playwright/
-├── components/core/     # Reusable UI components
-├── pages/              # Page Object Models  
-├── tests/              # Test files organized by feature
-├── utils/              # Shared constants and utilities
-└── README.md           # This file
-```
-
-## Design Principles
-
-We follow **YAGNI** (You Aren't Gonna Need It), **DRY** (Don't Repeat Yourself), and **KISS** (Keep It Simple, Stupid) principles:
-
-- Build only what's needed now
-- Reuse existing patterns and components
-- Keep solutions simple and maintainable
-
-## Component Architecture
-
-### Core Components (`components/core/`)
-
-Reusable UI interaction classes for common elements:
-
-- **Form**: Container with properly scoped child element access
-- **Input**: Supports `fill()`, `type()`, and `pressSequentially()` methods
-- **Button**: Standard click, hover, focus interactions
-
-**Usage Example:**
-```typescript
-import { Form } from '../components/core';
-
-const loginForm = new Form(page, '[data-test="login-form"]');
-const usernameInput = loginForm.getInput('[data-test="username-input"]');
-await usernameInput.fill('admin');
-```
-
-### Page Objects (`pages/`)
-
-Each page object encapsulates:
-- **Actions**: What you can do on the page
-- **Queries**: Information you can get from the page  
-- **Selectors**: Centralized in private static SELECTORS constant
-- **NO Assertions**: Keep assertions in test files
-
-**Page Object Pattern:**
-```typescript
-export class AuthPage {
-  // Selectors centralized in the page object
-  private static readonly SELECTORS = {
-    LOGIN_FORM: '[data-test="login-form"]',
-    USERNAME_INPUT: '[data-test="username-input"]',
-  } as const;
-
-  // Actions - what you can do
-  async loginWithCredentials(username: string, password: string) { }
-
-  // Queries - information you can get  
-  async getCurrentUrl(): Promise<string> { }
-
-  // NO assertions - those belong in tests
-}
-```
-
-### Tests (`tests/`)
-
-Organized by feature/area (auth, dashboard, charts, etc.):
-- Use page objects for actions
-- Keep assertions in test files  
-- Import shared constants from `utils/`
-
-**Test Pattern:**
-```typescript
-import { test, expect } from '@playwright/test';
-import { AuthPage } from '../../pages/AuthPage';
-import { LOGIN } from '../../utils/urls';
-
-test('should login with correct credentials', async ({ page }) => {
-  const authPage = new AuthPage(page);
-  await authPage.goto();
-  await authPage.loginWithCredentials('admin', 'general');
-
-  // Assertions belong in tests, not page objects
-  expect(await authPage.getCurrentUrl()).not.toContain(LOGIN);
-});
-```
-
-### Utilities (`utils/`)
-
-Shared constants and utilities:
-- **urls.ts**: URL paths and request patterns
-- Keep flat exports (no premature namespacing)
-
-## Contributing Guidelines
-
-### Adding New Tests
-
-1. **Check existing components** before creating new ones
-2. **Use page objects** for page interactions  
-3. **Keep assertions in tests**, not page objects
-4. **Follow naming conventions**: `feature.spec.ts`
-
-### Adding New Components
-
-1. **Follow YAGNI**: Only build what's immediately needed
-2. **Use Locator-based scoping** for proper element isolation
-3. **Support both string selectors and Locator objects** via constructor overloads
-4. **Add to `components/core/index.ts`** for easy importing
-
-### Adding New Page Objects
-
-1. **Centralize selectors** in private static SELECTORS constant
-2. **Import shared constants** from `utils/urls.ts`
-3. **Actions and queries only** - no assertions
-4. **Use existing components** for DOM interactions
-
-## Running Tests
-
-```bash
-# Run all tests
-npm run playwright:test
-# or: npx playwright test
-
-# Run specific test file
-npx playwright test tests/auth/login.spec.ts
-
-# Run with UI mode for debugging
-npm run playwright:ui
-# or: npx playwright test --ui
-
-# Run in headed mode (see browser)
-npm run playwright:headed
-# or: npx playwright test --headed
-
-# Debug specific test file
-npm run playwright:debug tests/auth/login.spec.ts
-# or: npx playwright test --debug tests/auth/login.spec.ts
-```
-
-## Test Reports
-
-Playwright generates multiple reports for better visibility:
-
-```bash
-# View interactive HTML report (opens automatically on failure)
-npm run playwright:report
-# or: npx playwright show-report
-
-# View test trace for debugging failures
-npx playwright show-trace test-results/[test-name]/trace.zip
-```
-
-### Report Types
-
-- **List Reporter**: Shows progress and summary table in terminal
-- **HTML Report**: Interactive web interface with screenshots, videos, and traces
-- **JSON Report**: Machine-readable format in `test-results/results.json`
-- **GitHub Actions**: Annotations in CI for failed tests
-
-### Debugging Failed Tests
-
-When tests fail, Playwright automatically captures:
-- **Screenshots** at the point of failure
-- **Videos** of the entire test run
-- **Traces** with timeline and network activity
-- **Error context** with detailed debugging information
-
-All debugging artifacts are available in the HTML report for easy analysis.
-
-## Configuration
-
-- **Config**: `playwright.config.ts` - matches Cypress settings
-- **Base URL**: `http://localhost:8088` (assumes Superset running)
-- **Browsers**: Chrome only for Phase 1 (YAGNI)
-- **Retries**: 2 in CI, 0 locally (matches Cypress)
-
-## Migration from Cypress
-
-When porting Cypress tests:
-
-1. **Port the logic**, not the implementation
-2. **Use page objects** instead of inline selectors
-3. **Replace `cy.intercept/cy.wait`** with `page.waitForRequest()`
-4. **Use shared constants** from `utils/urls.ts`
-5. **Follow the established patterns** shown in `tests/auth/login.spec.ts`
-
-## Best Practices
-
-- **Centralize selectors** in page objects
-- **Centralize URLs** in `utils/urls.ts`  
-- **Use meaningful test descriptions**
-- **Keep page objects action-focused**
-- **Put assertions in tests, not page objects**
-- **Follow the existing patterns** for consistency

superset-frontend/playwright/components/core/Button.ts

@@ -1,119 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { Locator, Page } from '@playwright/test';
-
-export class Button {
-  private readonly locator: Locator;
-
-  constructor(page: Page, selector: string);
-
-  constructor(page: Page, locator: Locator);
-
-  constructor(page: Page, selectorOrLocator: string | Locator) {
-    if (typeof selectorOrLocator === 'string') {
-      this.locator = page.locator(selectorOrLocator);
-    } else {
-      this.locator = selectorOrLocator;
-    }
-  }
-
-  /**
-   * Gets the button element locator
-   */
-  get element(): Locator {
-    return this.locator;
-  }
-
-  /**
-   * Clicks the button
-   * @param options - Optional click options
-   */
-  async click(options?: {
-    timeout?: number;
-    force?: boolean;
-    delay?: number;
-    button?: 'left' | 'right' | 'middle';
-  }): Promise<void> {
-    await this.element.click(options);
-  }
-
-  /**
-   * Gets the button text content
-   */
-  async getText(): Promise<string> {
-    return (await this.element.textContent()) ?? '';
-  }
-
-  /**
-   * Gets a specific attribute value from the button
-   * @param attribute - The attribute name to retrieve
-   */
-  async getAttribute(attribute: string): Promise<string | null> {
-    return this.element.getAttribute(attribute);
-  }
-
-  /**
-   * Checks if the button is visible
-   */
-  async isVisible(): Promise<boolean> {
-    return this.element.isVisible();
-  }
-
-  /**
-   * Checks if the button is enabled
-   */
-  async isEnabled(): Promise<boolean> {
-    return this.element.isEnabled();
-  }
-
-  /**
-   * Checks if the button is disabled
-   */
-  async isDisabled(): Promise<boolean> {
-    return this.element.isDisabled();
-  }
-
-  /**
-   * Hovers over the button
-   * @param options - Optional hover options
-   */
-  async hover(options?: { timeout?: number; force?: boolean }): Promise<void> {
-    await this.element.hover(options);
-  }
-
-  /**
-   * Focuses on the button
-   */
-  async focus(): Promise<void> {
-    await this.element.focus();
-  }
-
-  /**
-   * Double clicks the button
-   * @param options - Optional click options
-   */
-  async doubleClick(options?: {
-    timeout?: number;
-    force?: boolean;
-    delay?: number;
-  }): Promise<void> {
-    await this.element.dblclick(options);
-  }
-}

superset-frontend/playwright/components/core/Form.ts

@@ -1,110 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { Locator, Page } from '@playwright/test';
-import { Input } from './Input';
-import { Button } from './Button';
-
-export class Form {
-  private readonly page: Page;
-
-  private readonly locator: Locator;
-
-  constructor(page: Page, selector: string);
-
-  constructor(page: Page, locator: Locator);
-
-  constructor(page: Page, selectorOrLocator: string | Locator) {
-    this.page = page;
-    if (typeof selectorOrLocator === 'string') {
-      this.locator = page.locator(selectorOrLocator);
-    } else {
-      this.locator = selectorOrLocator;
-    }
-  }
-
-  /**
-   * Gets the form element locator
-   */
-  get element(): Locator {
-    return this.locator;
-  }
-
-  /**
-   * Gets an input field within the form (properly scoped)
-   * @param inputSelector - Selector for the input field
-   */
-  getInput(inputSelector: string): Input {
-    const scopedLocator = this.locator.locator(inputSelector);
-    return new Input(this.page, scopedLocator);
-  }
-
-  /**
-   * Gets a button within the form (properly scoped)
-   * @param buttonSelector - Selector for the button
-   */
-  getButton(buttonSelector: string): Button {
-    const scopedLocator = this.locator.locator(buttonSelector);
-    return new Button(this.page, scopedLocator);
-  }
-
-  /**
-   * Checks if the form is visible
-   */
-  async isVisible(): Promise<boolean> {
-    return this.locator.isVisible();
-  }
-
-  /**
-   * Submits the form (triggers submit event)
-   */
-  async submit(): Promise<void> {
-    await this.locator.evaluate((form: HTMLElement) => {
-      if (form instanceof HTMLFormElement) {
-        form.submit();
-      }
-    });
-  }
-
-  /**
-   * Waits for the form to be visible
-   * @param options - Optional wait options
-   */
-  async waitForVisible(options?: { timeout?: number }): Promise<void> {
-    await this.locator.waitFor({ state: 'visible', ...options });
-  }
-
-  /**
-   * Gets all form data as key-value pairs
-   * Useful for validation and debugging
-   */
-  async getFormData(): Promise<Record<string, string>> {
-    return this.locator.evaluate((form: HTMLElement) => {
-      if (form instanceof HTMLFormElement) {
-        const formData = new FormData(form);
-        const result: Record<string, string> = {};
-        formData.forEach((value, key) => {
-          result[key] = value.toString();
-        });
-        return result;
-      }
-      return {};
-    });
-  }
-}

superset-frontend/playwright/components/core/Input.ts

@@ -1,111 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { Locator, Page } from '@playwright/test';
-
-export class Input {
-  private readonly locator: Locator;
-
-  constructor(page: Page, selector: string);
-
-  constructor(page: Page, locator: Locator);
-
-  constructor(page: Page, selectorOrLocator: string | Locator) {
-    if (typeof selectorOrLocator === 'string') {
-      this.locator = page.locator(selectorOrLocator);
-    } else {
-      this.locator = selectorOrLocator;
-    }
-  }
-
-  /**
-   * Gets the input element locator
-   */
-  get element(): Locator {
-    return this.locator;
-  }
-
-  /**
-   * Fast fill - clears the input and sets the value directly
-   * @param value - The value to fill
-   * @param options - Optional fill options
-   */
-  async fill(
-    value: string,
-    options?: { timeout?: number; force?: boolean },
-  ): Promise<void> {
-    await this.element.fill(value, options);
-  }
-
-  /**
-   * Types text character by character (simulates real typing)
-   * @param text - The text to type
-   * @param options - Optional typing options
-   */
-  async type(text: string, options?: { delay?: number }): Promise<void> {
-    await this.element.type(text, options);
-  }
-
-  /**
-   * Types text sequentially with more control over timing
-   * @param text - The text to type
-   * @param options - Optional sequential typing options
-   */
-  async pressSequentially(
-    text: string,
-    options?: { delay?: number },
-  ): Promise<void> {
-    await this.element.pressSequentially(text, options);
-  }
-
-  /**
-   * Gets the current value of the input
-   */
-  async getValue(): Promise<string> {
-    return this.element.inputValue();
-  }
-
-  /**
-   * Clears the input field
-   */
-  async clear(): Promise<void> {
-    await this.element.clear();
-  }
-
-  /**
-   * Checks if the input is visible
-   */
-  async isVisible(): Promise<boolean> {
-    return this.element.isVisible();
-  }
-
-  /**
-   * Checks if the input is enabled
-   */
-  async isEnabled(): Promise<boolean> {
-    return this.element.isEnabled();
-  }
-
-  /**
-   * Focuses on the input field
-   */
-  async focus(): Promise<void> {
-    await this.element.focus();
-  }
-}

superset-frontend/playwright/components/core/index.ts

@@ -1,23 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-// Core Playwright Components for Superset
-export { Button } from './Button';
-export { Form } from './Form';
-export { Input } from './Input';

superset-frontend/playwright/pages/AuthPage.ts

@@ -1,122 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { Page, Response } from '@playwright/test';
-import { Form } from '../components/core';
-import { URL } from '../utils/urls';
-
-export class AuthPage {
-  private readonly page: Page;
-
-  private readonly loginForm: Form;
-
-  // Selectors specific to the auth/login page
-  private static readonly SELECTORS = {
-    LOGIN_FORM: '[data-test="login-form"]',
-    USERNAME_INPUT: '[data-test="username-input"]',
-    PASSWORD_INPUT: '[data-test="password-input"]',
-    LOGIN_BUTTON: '[data-test="login-button"]',
-    ERROR_SELECTORS: [
-      '[role="alert"]',
-      '.ant-form-item-explain-error',
-      '.ant-form-item-explain.ant-form-item-explain-error',
-      '.alert-danger',
-    ],
-  } as const;
-
-  constructor(page: Page) {
-    this.page = page;
-    this.loginForm = new Form(page, AuthPage.SELECTORS.LOGIN_FORM);
-  }
-
-  /**
-   * Navigate to the login page
-   */
-  async goto(): Promise<void> {
-    await this.page.goto(URL.LOGIN);
-  }
-
-  /**
-   * Wait for login form to be visible
-   */
-  async waitForLoginForm(): Promise<void> {
-    await this.loginForm.waitForVisible({ timeout: 5000 });
-  }
-
-  /**
-   * Login with provided credentials
-   * @param username - Username to enter
-   * @param password - Password to enter
-   */
-  async loginWithCredentials(
-    username: string,
-    password: string,
-  ): Promise<void> {
-    const usernameInput = this.loginForm.getInput(
-      AuthPage.SELECTORS.USERNAME_INPUT,
-    );
-    const passwordInput = this.loginForm.getInput(
-      AuthPage.SELECTORS.PASSWORD_INPUT,
-    );
-    const loginButton = this.loginForm.getButton(
-      AuthPage.SELECTORS.LOGIN_BUTTON,
-    );
-
-    await usernameInput.fill(username);
-    await passwordInput.fill(password);
-    await loginButton.click();
-  }
-
-  /**
-   * Get current page URL
-   */
-  async getCurrentUrl(): Promise<string> {
-    return this.page.url();
-  }
-
-  /**
-   * Get the session cookie specifically
-   */
-  async getSessionCookie(): Promise<{ name: string; value: string } | null> {
-    const cookies = await this.page.context().cookies();
-    return cookies.find((c: any) => c.name === 'session') || null;
-  }
-
-  /**
-   * Check if login form has validation errors
-   */
-  async hasLoginError(): Promise<boolean> {
-    const visibilityPromises = AuthPage.SELECTORS.ERROR_SELECTORS.map(
-      selector => this.page.locator(selector).isVisible(),
-    );
-    const visibilityResults = await Promise.all(visibilityPromises);
-    return visibilityResults.some((isVisible: any) => isVisible);
-  }
-
-  /**
-   * Wait for a login request to be made and return the response
-   */
-  async waitForLoginRequest(): Promise<Response> {
-    return this.page.waitForResponse(
-      (response: any) =>
-        response.url().includes('/login/') &&
-        response.request().method() === 'POST',
-    );
-  }
-}

superset-frontend/playwright/tests/auth/login.spec.ts

@@ -1,88 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { test, expect } from '@playwright/test';
-import { AuthPage } from '../../pages/AuthPage';
-import { URL } from '../../utils/urls';
-
-test.describe('Login view', () => {
-  let authPage: AuthPage;
-
-  test.beforeEach(async ({ page }: any) => {
-    authPage = new AuthPage(page);
-    await authPage.goto();
-    await authPage.waitForLoginForm();
-  });
-
-  test('should redirect to login with incorrect username and password', async ({
-    page,
-  }: any) => {
-    // Setup request interception before login attempt
-    const loginRequestPromise = authPage.waitForLoginRequest();
-
-    // Attempt login with incorrect credentials
-    await authPage.loginWithCredentials('admin', 'wrongpassword');
-
-    // Wait for login request and verify response
-    const loginResponse = await loginRequestPromise;
-    // Failed login returns 401 Unauthorized or 302 redirect to login
-    expect([401, 302]).toContain(loginResponse.status());
-
-    // Wait for redirect to complete before checking URL
-    await page.waitForURL((url: any) => url.pathname.endsWith('login/'), {
-      timeout: 10000,
-    });
-
-    // Verify we stay on login page
-    const currentUrl = await authPage.getCurrentUrl();
-    expect(currentUrl).toContain(URL.LOGIN);
-
-    // Verify error message is shown
-    const hasError = await authPage.hasLoginError();
-    expect(hasError).toBe(true);
-  });
-
-  test('should login with correct username and password', async ({
-    page,
-  }: any) => {
-    // Setup request interception before login attempt
-    const loginRequestPromise = authPage.waitForLoginRequest();
-
-    // Login with correct credentials
-    await authPage.loginWithCredentials('admin', 'general');
-
-    // Wait for login request and verify response
-    const loginResponse = await loginRequestPromise;
-    // Successful login returns 302 redirect
-    expect(loginResponse.status()).toBe(302);
-
-    // Wait for successful redirect to welcome page
-    await page.waitForURL(
-      (url: any) => url.pathname.endsWith('superset/welcome/'),
-      {
-        timeout: 10000,
-      },
-    );
-
-    // Verify specific session cookie exists
-    const sessionCookie = await authPage.getSessionCookie();
-    expect(sessionCookie).not.toBeNull();
-    expect(sessionCookie?.value).toBeTruthy();
-  });
-});

superset-frontend/playwright/utils/urls.ts

@@ -1,23 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-export const URL = {
-  LOGIN: 'login/',
-  WELCOME: 'superset/welcome/',
-} as const;

superset-frontend/plugins/legacy-plugin-chart-calendar/src/index.js

@@ -19,10 +19,8 @@
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import transformProps from './transformProps';
 import example from './images/example.jpg';
-import exampleDark from './images/example-dark.jpg';
 import controlPanel from './controlPanel';
 import thumbnail from './images/thumbnail.png';
-import thumbnailDark from './images/thumbnail-dark.png';
 
 const metadata = new ChartMetadata({
   category: t('Correlation'),
@@ -30,7 +28,7 @@ const metadata = new ChartMetadata({
   description: t(
     "Visualizes how a metric has changed over a time using a color scale and a calendar view. Gray values are used to indicate missing values and the linear color scheme is used to encode the magnitude of each day's value.",
   ),
-  exampleGallery: [{ url: example, urlDark: exampleDark }],
+  exampleGallery: [{ url: example }],
   name: t('Calendar Heatmap'),
   tags: [
     t('Business'),
@@ -41,7 +39,6 @@ const metadata = new ChartMetadata({
     t('Trend'),
   ],
   thumbnail,
-  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-plugin-chart-calendar/tsconfig.json

@@ -1,18 +1,14 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "baseUrl": "../..",
-    "outDir": "lib"
+    "composite": true,
+    "rootDir": "src",
+    "outDir": "lib",
+    "baseUrl": "."
   },
-  "include": ["src/**/*.ts", "src/**/*.tsx", "types/**/*"],
-  "exclude": [
-    "src/**/*.js",
-    "src/**/*.jsx",
-    "src/**/*.test.*",
-    "src/**/*.stories.*"
-  ],
+  "include": ["src/**/*", "types/**/*"],
+  "exclude": ["lib", "test"],
   "references": [
-    { "path": "../../packages/superset-core" },
     { "path": "../../packages/superset-ui-core" },
     { "path": "../../packages/superset-ui-chart-controls" }
   ]

superset-frontend/plugins/legacy-plugin-chart-chord/src/index.js

@@ -19,9 +19,7 @@
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import transformProps from './transformProps';
 import example from './images/chord.jpg';
-import exampleDark from './images/chord-dark.jpg';
 import thumbnail from './images/thumbnail.png';
-import thumbnailDark from './images/thumbnail-dark.png';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -31,16 +29,11 @@ const metadata = new ChartMetadata({
     'Showcases the flow or link between categories using thickness of chords. The value and corresponding thickness can be different for each side.',
   ),
   exampleGallery: [
-    {
-      url: example,
-      urlDark: exampleDark,
-      caption: t('Relationships between community channels'),
-    },
+    { url: example, caption: t('Relationships between community channels') },
   ],
   name: t('Chord Diagram'),
   tags: [t('Circular'), t('Legacy'), t('Proportional'), t('Relational')],
   thumbnail,
-  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-plugin-chart-chord/tsconfig.json

@@ -1,18 +1,14 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "baseUrl": "../..",
-    "outDir": "lib"
+    "composite": true,
+    "rootDir": "src",
+    "outDir": "lib",
+    "baseUrl": "."
   },
-  "include": ["src/**/*.ts", "src/**/*.tsx", "types/**/*"],
-  "exclude": [
-    "src/**/*.js",
-    "src/**/*.jsx",
-    "src/**/*.test.*",
-    "src/**/*.stories.*"
-  ],
+  "include": ["src/**/*", "types/**/*"],
+  "exclude": ["lib", "test"],
   "references": [
-    { "path": "../../packages/superset-core" },
     { "path": "../../packages/superset-ui-core" },
     { "path": "../../packages/superset-ui-chart-controls" }
   ]

superset-frontend/plugins/legacy-plugin-chart-country-map/src/index.js

@@ -19,11 +19,8 @@
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import transformProps from './transformProps';
 import exampleUsa from './images/exampleUsa.jpg';
-import exampleUsaDark from './images/exampleUsa-dark.jpg';
 import exampleGermany from './images/exampleGermany.jpg';
-import exampleGermanyDark from './images/exampleGermany-dark.jpg';
 import thumbnail from './images/thumbnail.png';
-import thumbnailDark from './images/thumbnail-dark.png';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -32,10 +29,7 @@ const metadata = new ChartMetadata({
   description: t(
     "Visualizes how a single metric varies across a country's principal subdivisions (states, provinces, etc) on a choropleth map. Each subdivision's value is elevated when you hover over the corresponding geographic boundary.",
   ),
-  exampleGallery: [
-    { url: exampleUsa, urlDark: exampleUsaDark },
-    { url: exampleGermany, urlDark: exampleGermanyDark },
-  ],
+  exampleGallery: [{ url: exampleUsa }, { url: exampleGermany }],
   name: t('Country Map'),
   tags: [
     t('2D'),
@@ -46,7 +40,6 @@ const metadata = new ChartMetadata({
     t('Stacked'),
   ],
   thumbnail,
-  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-plugin-chart-country-map/tsconfig.json

@@ -1,18 +1,14 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "baseUrl": "../..",
-    "outDir": "lib"
+    "composite": true,
+    "rootDir": "src",
+    "outDir": "lib",
+    "baseUrl": "."
   },
-  "include": ["src/**/*.ts", "src/**/*.tsx", "types/**/*"],
-  "exclude": [
-    "src/**/*.js",
-    "src/**/*.jsx",
-    "src/**/*.test.*",
-    "src/**/*.stories.*"
-  ],
+  "include": ["src/**/*", "types/**/*"],
+  "exclude": ["lib", "test"],
   "references": [
-    { "path": "../../packages/superset-core" },
     { "path": "../../packages/superset-ui-core" },
     { "path": "../../packages/superset-ui-chart-controls" }
   ]

superset-frontend/plugins/legacy-plugin-chart-horizon/src/index.js

@@ -19,9 +19,7 @@
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import transformProps from './transformProps';
 import example from './images/Horizon_Chart.jpg';
-import exampleDark from './images/Horizon_Chart-dark.jpg';
 import thumbnail from './images/thumbnail.png';
-import thumbnailDark from './images/thumbnail-dark.png';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -30,11 +28,10 @@ const metadata = new ChartMetadata({
   description: t(
     'Compares how a metric changes over time between different groups. Each group is mapped to a row and change over time is visualized bar lengths and color.',
   ),
-  exampleGallery: [{ url: example, urlDark: exampleDark }],
+  exampleGallery: [{ url: example }],
   name: t('Horizon Chart'),
   tags: [t('Legacy')],
   thumbnail,
-  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-plugin-chart-horizon/tsconfig.json

@@ -1,18 +1,14 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "baseUrl": "../..",
-    "outDir": "lib"
+    "composite": true,
+    "rootDir": "src",
+    "outDir": "lib",
+    "baseUrl": "."
   },
-  "include": ["src/**/*.ts", "src/**/*.tsx", "types/**/*"],
-  "exclude": [
-    "src/**/*.js",
-    "src/**/*.jsx",
-    "src/**/*.test.*",
-    "src/**/*.stories.*"
-  ],
+  "include": ["src/**/*", "types/**/*"],
+  "exclude": ["lib", "test"],
   "references": [
-    { "path": "../../packages/superset-core" },
     { "path": "../../packages/superset-ui-core" },
     { "path": "../../packages/superset-ui-chart-controls" }
   ]

superset-frontend/plugins/legacy-plugin-chart-map-box/src/index.js

@@ -18,11 +18,8 @@
  */
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import thumbnail from './images/thumbnail.png';
-import thumbnailDark from './images/thumbnail-dark.png';
 import example1 from './images/MapBox.jpg';
-import example1Dark from './images/MapBox-dark.jpg';
 import example2 from './images/MapBox2.jpg';
-import example2Dark from './images/MapBox2-dark.jpg';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -30,8 +27,8 @@ const metadata = new ChartMetadata({
   credits: ['https://www.mapbox.com/mapbox-gl-js/api/'],
   description: '',
   exampleGallery: [
-    { url: example1, urlDark: example1Dark, description: t('Light mode') },
-    { url: example2, urlDark: example2Dark, description: t('Dark mode') },
+    { url: example1, description: t('Light mode') },
+    { url: example2, description: t('Dark mode') },
   ],
   name: t('MapBox'),
   tags: [
@@ -43,7 +40,6 @@ const metadata = new ChartMetadata({
     t('Transformable'),
   ],
   thumbnail,
-  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-plugin-chart-map-box/test/tsconfig.json

@@ -2,8 +2,18 @@
   "compilerOptions": {
     "composite": false,
     "emitDeclarationOnly": false,
+    "noEmit": true,
     "rootDir": "."
   },
   "extends": "../../../tsconfig.json",
-  "include": ["**/*", "../types/**/*", "../../../types/**/*"]
+  "include": [
+    "**/*",
+    "../types/**/*",
+    "../../../types/**/*"
+  ],
+  "references": [
+    {
+      "path": ".."
+    }
+  ]
 }

superset-frontend/plugins/legacy-plugin-chart-map-box/tsconfig.json

@@ -1,18 +1,14 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "baseUrl": "../..",
-    "outDir": "lib"
+    "composite": true,
+    "rootDir": "src",
+    "outDir": "lib",
+    "baseUrl": "."
   },
-  "include": ["src/**/*.ts", "src/**/*.tsx", "types/**/*"],
-  "exclude": [
-    "src/**/*.js",
-    "src/**/*.jsx",
-    "src/**/*.test.*",
-    "src/**/*.stories.*"
-  ],
+  "include": ["src/**/*", "types/**/*"],
+  "exclude": ["lib", "test"],
   "references": [
-    { "path": "../../packages/superset-core" },
     { "path": "../../packages/superset-ui-core" },
     { "path": "../../packages/superset-ui-chart-controls" }
   ]

superset-frontend/plugins/legacy-plugin-chart-paired-t-test/src/index.js

@@ -18,10 +18,7 @@
  */
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import transformProps from './transformProps';
-import example from './images/example.jpg';
-import exampleDark from './images/example-dark.jpg';
 import thumbnail from './images/thumbnail.png';
-import thumbnailDark from './images/thumbnail-dark.png';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -29,11 +26,9 @@ const metadata = new ChartMetadata({
   description: t(
     'Table that visualizes paired t-tests, which are used to understand statistical differences between groups.',
   ),
-  exampleGallery: [{ url: example, urlDark: exampleDark }],
   name: t('Paired t-test Table'),
   tags: [t('Legacy'), t('Statistical'), t('Tabular')],
   thumbnail,
-  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-plugin-chart-paired-t-test/tsconfig.json

@@ -1,18 +1,14 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "baseUrl": "../..",
-    "outDir": "lib"
+    "composite": true,
+    "rootDir": "src",
+    "outDir": "lib",
+    "baseUrl": "."
   },
-  "include": ["src/**/*.ts", "src/**/*.tsx", "types/**/*"],
-  "exclude": [
-    "src/**/*.js",
-    "src/**/*.jsx",
-    "src/**/*.test.*",
-    "src/**/*.stories.*"
-  ],
+  "include": ["src/**/*", "types/**/*"],
+  "exclude": ["lib", "test"],
   "references": [
-    { "path": "../../packages/superset-core" },
     { "path": "../../packages/superset-ui-core" },
     { "path": "../../packages/superset-ui-chart-controls" }
   ]

superset-frontend/plugins/legacy-plugin-chart-parallel-coordinates/src/index.js

@@ -19,11 +19,8 @@
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import transformProps from './transformProps';
 import thumbnail from './images/thumbnail.png';
-import thumbnailDark from './images/thumbnail-dark.png';
 import example1 from './images/example1.jpg';
-import example1Dark from './images/example1-dark.jpg';
 import example2 from './images/example2.jpg';
-import example2Dark from './images/example2-dark.jpg';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -32,14 +29,10 @@ const metadata = new ChartMetadata({
   description: t(
     'Plots the individual metrics for each row in the data vertically and links them together as a line. This chart is useful for comparing multiple metrics across all of the samples or rows in the data.',
   ),
-  exampleGallery: [
-    { url: example1, urlDark: example1Dark },
-    { url: example2, urlDark: example2Dark },
-  ],
+  exampleGallery: [{ url: example1 }, { url: example2 }],
   name: t('Parallel Coordinates'),
   tags: [t('Directional'), t('Legacy'), t('Relational')],
   thumbnail,
-  thumbnailDark,
   useLegacyApi: true,
 });