Compare commits

...

10 Commits

Author SHA1 Message Date
Evan Rusackas
54faf84527 address review: drop ineffective props useMemo with restProps spread
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-23 08:12:23 -07:00
Evan Rusackas
e3eae59568 address review: import ReactElement type and assert onContextMenu call 2026-04-23 02:34:12 -07:00
Evan Rusackas
67502b2292 address review: drop invalid role="columnheader button" attribute 2026-04-23 02:33:41 -07:00
Evan Rusackas
2e9094ee2c address review: guard clickHeaderHandler against missing filter values 2026-04-23 02:33:16 -07:00
Evan Rusackas
d9b15c3f4c address review: move sort cache clear to structural-deps effect 2026-04-23 02:32:30 -07:00
Evan Rusackas
1dde65f901 address review: coerce numeric timestamp strings before dateFormatters 2026-04-23 02:32:07 -07:00
Evan Rusackas
b947381f5f address review: include target column key in sort cache 2026-04-23 02:31:45 -07:00
Evan Rusackas
27feb46107 fix(pivot-table): restore getCellColor helper + column/row header styling
The previous commit dropped the getCellColor() helper, collapsing cell
color handling to background-only for value cells and removing it from
column/row header cells entirely. This regresses TEXT_COLOR formatters,
CELL_BAR exclusions, contrast-aware text color, and active-header
highlighting.

- Re-import ColorFormatters / getTextColorForBackground /
  ObjectFormattingEnum / ResolvedColorFormatterResult and supersetTheme.
- Restore getCellColor() with full semantics (text-color formatters,
  CELL_BAR skip, contrast-adjusted text color).
- Restore cellBackgroundColor / cellTextColor / activeHeaderBackgroundColor
  options on TableOptions.
- Apply getCellColor() at all three original call sites: column
  headers, row headers, and value cells (including subtotal color).
2026-04-22 16:12:40 -07:00
Evan Rusackas
3cd9b7233d fix(imports): rewrite stale @apache-superset/core/ui to current subpaths
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-22 16:00:24 -07:00
Evan Rusackas
922befa831 chore(lint): convert react-pivottable components to function components
Converts PivotTable and TableRenderers in the plugin-chart-pivot-table
react-pivottable fork from class components to function components.
Updates associated unit test.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-22 16:00:24 -07:00
3 changed files with 1417 additions and 2132 deletions

View File

@@ -17,16 +17,14 @@
* under the License.
*/
import { PureComponent } from 'react';
import { memo } from 'react';
import { TableRenderer } from './TableRenderers';
import type { ComponentProps } from 'react';
type PivotTableProps = ComponentProps<typeof TableRenderer>;
class PivotTable extends PureComponent<PivotTableProps> {
render() {
return <TableRenderer {...this.props} />;
}
function PivotTable(props: PivotTableProps) {
return <TableRenderer {...props} />;
}
export default PivotTable;
export default memo(PivotTable);