fix(reports): commit permalink before Playwright navigates to tab URL

CreateDashboardPermalinkCommand only flushes the INSERT when invoked inside an outer @transaction() (the nesting guard skips the commit). The row is therefore not visible to Playwright's separate DB connection, causing dashboard_permalink to return a 404, the <body class="standalone"> element to never appear, and the screenshot to time out after 600s. Commit immediately after CreateDashboardPermalinkCommand.run() returns, matching the pattern already used by create_log() in the same class. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-16 21:19:18 +00:00 · 2026-06-15 23:50:30 +00:00
11 changed files with 12 additions and 63 deletions
--- a/docs/admin_docs/installation/docker-compose.mdx
+++ b/docs/admin_docs/installation/docker-compose.mdx
@@ -223,9 +223,8 @@ compose based installation, edit the `x-superset-image:` line in your `docker-co
 `docker-compose-non-dev.yml` files, replacing `apachesuperset.docker.scarf.sh/apache/superset` with
 `apache/superset` to pull the image directly from Docker Hub.

-To disable the Scarf telemetry pixel, set the `SCARF_ANALYTICS` environment variable to `false` in
-your `docker/.env` file. This is read at runtime, so it disables the pixel on the pre-built image
-without rebuilding the frontend.
+To disable the Scarf telemetry pixel, set the `SCARF_ANALYTICS` environment variable to `False` in
+your terminal and/or in your `docker/.env` file.
 :::

 ## 3. Log in to Superset
--- a/docs/admin_docs/installation/kubernetes.mdx
+++ b/docs/admin_docs/installation/kubernetes.mdx
@@ -136,17 +136,7 @@ init:
 :::note
 Superset uses [Scarf Gateway](https://about.scarf.sh/scarf-gateway) to collect telemetry data.  Knowing the installation counts for different Superset versions informs the  project's decisions about patching and long-term support. Scarf purges personally identifiable information (PII) and provides only aggregated statistics.

-There are two independent telemetry channels:
-
- **Image pulls** (Scarf Gateway): to opt out, edit the `repository:` line in your `helm/superset/values.yaml` file, replacing `apachesuperset.docker.scarf.sh/apache/superset` with `apache/superset` to pull the image directly from Docker Hub.
- **The analytics pixel** rendered in the UI: to opt out, set the `SCARF_ANALYTICS` environment variable to `false` on the Superset containers via `extraEnv` in your `values.yaml`:
-
-  ```yaml
-  extraEnv:
-    SCARF_ANALYTICS: "false"
-  ```
-
-  This is read at runtime, so it takes effect on the pre-built images without rebuilding the frontend.
+To opt-out of this data collection in your Helm-based installation, edit the `repository:` line in your `helm/superset/values.yaml` file, replacing `apachesuperset.docker.scarf.sh/apache/superset` with `apache/superset` to pull the image directly from Docker Hub.
 :::

 ### Dependencies
--- a/docs/docs/faq.mdx
+++ b/docs/docs/faq.mdx
@@ -321,8 +321,8 @@ This can be used, for example, to convert UTC time to local time.
 Superset uses [Scarf](https://about.scarf.sh/) by default to collect basic telemetry data upon installing and/or running Superset. This data helps the maintainers of Superset better understand which versions of Superset are being used, in order to prioritize patch/minor releases and security fixes.
 We use the [Scarf Gateway](https://docs.scarf.sh/gateway/) to sit in front of container registries, the [scarf-js](https://about.scarf.sh/package-sdks) package to track `npm` installations, and a Scarf pixel to gather anonymous analytics on Superset page views.
 Scarf purges PII and provides aggregated statistics. Superset users can easily opt out of analytics in various ways documented [here](https://docs.scarf.sh/gateway/#do-not-track) and [here](https://docs.scarf.sh/package-analytics/#as-a-user-of-a-package-using-scarf-js-how-can-i-opt-out-of-analytics).
-You can also opt out of the analytics pixel by setting the `SCARF_ANALYTICS` environment variable to `false`. This is read at runtime, so setting it on the Superset container (for example via `extraEnv` in the Helm chart, or `docker/.env` for Docker Compose) disables the pixel on the pre-built images without rebuilding the frontend.
-Additional opt-out instructions are available on the [Docker Compose](/admin-docs/installation/docker-compose) and [Kubernetes](/admin-docs/installation/kubernetes) installation pages.
+Superset maintainers can also opt out of telemetry data collection by setting the `SCARF_ANALYTICS` environment variable to `false` in the Superset container (or anywhere Superset/webpack are run).
+Additional opt-out instructions for Docker users are available on the [Docker Installation](/admin-docs/installation/docker-compose) page.

 ## Does Superset have an archive panel or trash bin from which a user can recover deleted assets?

--- a/superset-frontend/packages/superset-ui-core/src/components/TelemetryPixel/TelemetryPixel.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/TelemetryPixel/TelemetryPixel.test.tsx
@@ -46,19 +46,3 @@ test('should NOT render the pixel link when FF is off', () => {
  const image = document.querySelector('img[src*="scarf.sh"]');
  expect(image).not.toBeInTheDocument();
 });
-
-test('should NOT render the pixel link when disabled at runtime', () => {
-  process.env.SCARF_ANALYTICS = 'true';
-  render(<TelemetryPixel enabled={false} />);
-
-  const image = document.querySelector('img[src*="scarf.sh"]');
-  expect(image).not.toBeInTheDocument();
-});
-
-test('should render the pixel link when enabled at runtime', () => {
-  process.env.SCARF_ANALYTICS = 'true';
-  render(<TelemetryPixel enabled />);
-
-  const image = document.querySelector('img[src*="scarf.sh"]');
-  expect(image).toBeInTheDocument();
-});
--- a/superset-frontend/packages/superset-ui-core/src/components/TelemetryPixel/index.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/TelemetryPixel/index.tsx
@@ -23,25 +23,17 @@ interface TelemetryPixelProps {
  version?: string;
  sha?: string;
  build?: string;
-  enabled?: boolean;
 }

 /**
 * Renders a telemetry pixel component to capture anonymous, aggregated telemetry via Scarf.
- *
- * Telemetry can be disabled in two ways:
- * - At build time, by setting the SCARF_ANALYTICS environment variable to `false`
- *   (inlined by webpack; only effective when building the frontend yourself).
- * - At runtime, by passing `enabled={false}`, which the app derives from the
- *   `SCARF_ANALYTICS` backend config exposed via the bootstrap payload. This is
- *   what allows opting out in pre-built images, where the build-time flag is fixed.
+ * This can be disabled by setting the SCARF_ANALYTICS environment variable to false.
 *
 * @component
 * @param {TelemetryPixelProps} props - The props for the TelemetryPixel component.
 * @param {string} props.version - The version of  Superset that's currently in use.
 * @param {string} props.sha - The SHA of Superset that's currently in use.
 * @param {string} props.build - The build of Superset that's currently in use.
- * @param {boolean} props.enabled - Runtime opt-out switch; when false the pixel is not rendered.
 * @returns {JSX.Element | null} The rendered TelemetryPixel component.
 */

@@ -51,11 +43,9 @@ export const TelemetryPixel = ({
  version = 'unknownVersion',
  sha = 'unknownSHA',
  build = 'unknownBuild',
-  enabled = true,
 }: TelemetryPixelProps): ReactElement | null => {
  const pixelPath = `https://apachesuperset.gateway.scarf.sh/pixel/${PIXEL_ID}/${version}/${sha}/${build}`;
-  const disabled = !enabled || process.env.SCARF_ANALYTICS === 'false';
-  return disabled ? null : (
+  return process.env.SCARF_ANALYTICS === 'false' ? null : (
    <img
      referrerPolicy="no-referrer-when-downgrade"
      src={pixelPath}
--- a/superset-frontend/src/features/home/RightMenu.tsx
+++ b/superset-frontend/src/features/home/RightMenu.tsx
@@ -133,7 +133,6 @@ const RightMenu = ({
    EXCEL_EXTENSIONS,
    ALLOWED_EXTENSIONS,
    HAS_GSHEETS_INSTALLED,
-    SCARF_ANALYTICS,
  } = useSelector<any, ExtensionConfigs>(state => state.common.conf);
  const [showDatabaseModal, setShowDatabaseModal] = useState<boolean>(false);
  const [showCSVUploadModal, setShowCSVUploadModal] = useState<boolean>(false);
@@ -770,7 +769,6 @@ const RightMenu = ({
        version={navbarRight.version_string}
        sha={navbarRight.version_sha}
        build={navbarRight.build_number}
-        enabled={SCARF_ANALYTICS !== false}
      />
    </StyledDiv>
  );
--- a/superset-frontend/src/features/home/types.ts
+++ b/superset-frontend/src/features/home/types.ts
@@ -36,7 +36,6 @@ export interface ExtensionConfigs {
  COLUMNAR_EXTENSIONS: Array<any>;
  EXCEL_EXTENSIONS: Array<any>;
  HAS_GSHEETS_INSTALLED: boolean;
-  SCARF_ANALYTICS?: boolean;
 }
 export interface RightMenuProps {
  align: 'flex-start' | 'flex-end';
--- a/superset/commands/report/execute.py
+++ b/superset/commands/report/execute.py
@@ -358,6 +358,11 @@ class BaseReportState:
            dashboard_id=str(self._report_schedule.dashboard.uuid),
            state=dashboard_state,
        ).run()
+        # Commit the permalink immediately so Playwright's separate DB connection
+        # can resolve the URL. CreateDashboardPermalinkCommand only flushes when
+        # called inside an outer @transaction(), leaving the row invisible to
+        # other connections until we explicitly commit here.
+        db.session.commit()  # pylint: disable=consider-using-transaction

        return get_url_path(
            "Superset.dashboard_permalink",
--- a/superset/config.py
+++ b/superset/config.py
@@ -2257,13 +2257,6 @@ DATABASE_OAUTH2_TIMEOUT = timedelta(seconds=30)
 # Enable/disable CSP warning
 CONTENT_SECURITY_POLICY_WARNING = True

-# Superset uses Scarf (https://about.scarf.sh/) to collect anonymous, aggregated
-# telemetry via a pixel rendered in the UI. Set the SCARF_ANALYTICS environment
-# variable to "false" to opt out. This value is exposed to the frontend through
-# the bootstrap payload so it takes effect at runtime, including in pre-built
-# images where the webpack build-time flag of the same name cannot be changed.
-SCARF_ANALYTICS = utils.cast_to_boolean(os.environ.get("SCARF_ANALYTICS", True))
-
 # Do you want Talisman enabled?
 TALISMAN_ENABLED = utils.cast_to_boolean(os.environ.get("TALISMAN_ENABLED", True))

--- a/superset/views/base.py
+++ b/superset/views/base.py
@@ -124,7 +124,6 @@ FRONTEND_CONF_KEYS = (
    "MAPBOX_API_KEY",
    "DEFAULT_MAP_RENDERER",
    "CSV_STREAMING_ROW_THRESHOLD",
-    "SCARF_ANALYTICS",
 )

 logger = logging.getLogger(__name__)
--- a/tests/unit_tests/views/test_base.py
+++ b/tests/unit_tests/views/test_base.py
@@ -75,14 +75,6 @@ def test_default_map_renderer_is_exposed_to_frontend_config() -> None:
    assert "DEFAULT_MAP_RENDERER" in FRONTEND_CONF_KEYS


-def test_scarf_analytics_is_exposed_to_frontend_config() -> None:
-    # Exposed at runtime so pre-built images can opt out via the SCARF_ANALYTICS
-    # config/env var (the webpack build-time flag cannot be changed there).
-    from superset.views.base import FRONTEND_CONF_KEYS
-
-    assert "SCARF_ANALYTICS" in FRONTEND_CONF_KEYS
-
-
 def _extract_language(
    locale_str: str | None,
    languages: dict[str, dict[str, object]] | None = None,