test: Add comprehensive SQL Lab tab state validation tests

Add test suite to validate SQL Lab tab state management and backend
persistence behavior, particularly around the interaction between
frontend-generated string IDs and backend integer ID expectations.

Related to issue #34997: These tests reproduce metadata update
failures when users modify queries in newly created tabs.

Test files:
- sqlLab.tabStateValidation.test.js: 8 tests for tab state edge cases
- sqlLab.immediateBackendPersistence.test.js: 6 tests for persistence

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

LLMS.md

@@ -136,6 +136,19 @@ curl -f http://localhost:8088/health || echo "❌ Setup required - see https://s
 - **Use negation operator**: `~Model.field` instead of `== False` to avoid ruff E712 errors
 - **Example**: `~Model.is_active` instead of `Model.is_active == False`
 
+## Pull Request Guidelines
+
+**When creating pull requests:**
+
+1. **Read the current PR template**: Always check `.github/PULL_REQUEST_TEMPLATE.md` for the latest format
+2. **Use the template sections**: Include all sections from the template (SUMMARY, BEFORE/AFTER, TESTING INSTRUCTIONS, ADDITIONAL INFORMATION)
+3. **Follow PR title conventions**: Use [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/)
+   - Format: `type(scope): description`
+   - Example: `fix(dashboard): load charts correctly`
+   - Types: `fix`, `feat`, `docs`, `style`, `refactor`, `perf`, `test`, `chore`
+
+**Important**: Always reference the actual template file at `.github/PULL_REQUEST_TEMPLATE.md` instead of using cached content, as the template may be updated over time.
+
 ## Pre-commit Validation
 
 **Use pre-commit hooks for quality validation:**

docker-compose-light.yml

@@ -162,8 +162,11 @@ services:
       SCARF_ANALYTICS: "${SCARF_ANALYTICS:-}"
       # configuring the dev-server to use the host.docker.internal to connect to the backend
       superset: "http://superset-light:8088"
+      # Webpack dev server configuration
+      WEBPACK_DEVSERVER_HOST: "${WEBPACK_DEVSERVER_HOST:-127.0.0.1}"
+      WEBPACK_DEVSERVER_PORT: "${WEBPACK_DEVSERVER_PORT:-9000}"
     ports:
-      - "127.0.0.1:${NODE_PORT:-9001}:9000"  # Parameterized port
+      - "${NODE_PORT:-9001}:9000"  # Parameterized port, accessible on all interfaces
     command: ["/app/docker/docker-frontend.sh"]
     env_file:
       - path: docker/.env # default

docker/pythonpath_dev/superset_config.py

@@ -138,7 +138,7 @@ try:
     from superset_config_docker import *  # noqa: F403
 
     logger.info(
-        f"Loaded your Docker configuration at [{superset_config_docker.__file__}]"
+        "Loaded your Docker configuration at [%s]", superset_config_docker.__file__
     )
 except ImportError:
     logger.info("Using default Docker config...")

docs/docs/configuration/theming.mdx

@@ -165,6 +165,206 @@ Or in the CRUD interface theme JSON:
 
 This feature works with the stock Docker image - no custom build required!
 
+## ECharts Configuration Overrides
+
+:::note
+Available since Superset 6.0
+:::
+
+Superset provides fine-grained control over ECharts visualizations through theme-level configuration overrides. This allows you to customize the appearance and behavior of all ECharts-based charts without modifying individual chart configurations.
+
+### Global ECharts Overrides
+
+Apply settings to all ECharts visualizations using `echartsOptionsOverrides`:
+
+```python
+THEME_DEFAULT = {
+    "token": {
+        "colorPrimary": "#2893B3",
+        # ... other Ant Design tokens
+    },
+    "echartsOptionsOverrides": {
+        "grid": {
+            "left": "10%",
+            "right": "10%",
+            "top": "15%",
+            "bottom": "15%"
+        },
+        "tooltip": {
+            "backgroundColor": "rgba(0, 0, 0, 0.8)",
+            "borderColor": "#ccc",
+            "textStyle": {
+                "color": "#fff"
+            }
+        },
+        "legend": {
+            "textStyle": {
+                "fontSize": 14,
+                "fontWeight": "bold"
+            }
+        }
+    }
+}
+```
+
+### Chart-Specific Overrides
+
+Target specific chart types using `echartsOptionsOverridesByChartType`:
+
+```python
+THEME_DEFAULT = {
+    "token": {
+        "colorPrimary": "#2893B3",
+        # ... other tokens
+    },
+    "echartsOptionsOverridesByChartType": {
+        "echarts_pie": {
+            "legend": {
+                "orient": "vertical",
+                "right": 10,
+                "top": "center"
+            }
+        },
+        "echarts_timeseries": {
+            "xAxis": {
+                "axisLabel": {
+                    "rotate": 45,
+                    "fontSize": 12
+                }
+            },
+            "dataZoom": [{
+                "type": "slider",
+                "show": True,
+                "start": 0,
+                "end": 100
+            }]
+        },
+        "echarts_bubble": {
+            "grid": {
+                "left": "15%",
+                "bottom": "20%"
+            }
+        }
+    }
+}
+```
+
+### UI Configuration
+
+You can also configure ECharts overrides through the theme CRUD interface:
+
+```json
+{
+  "token": {
+    "colorPrimary": "#2893B3"
+  },
+  "echartsOptionsOverrides": {
+    "grid": {
+      "left": "10%",
+      "right": "10%"
+    },
+    "tooltip": {
+      "backgroundColor": "rgba(0, 0, 0, 0.8)"
+    }
+  },
+  "echartsOptionsOverridesByChartType": {
+    "echarts_pie": {
+      "legend": {
+        "orient": "vertical",
+        "right": 10
+      }
+    }
+  }
+}
+```
+
+### Override Precedence
+
+The system applies overrides in the following order (last wins):
+
+1. **Base ECharts theme** - Default Superset styling
+2. **Plugin options** - Chart-specific configurations
+3. **Global overrides** - `echartsOptionsOverrides`
+4. **Chart-specific overrides** - `echartsOptionsOverridesByChartType[chartType]`
+
+This ensures chart-specific overrides take precedence over global ones.
+
+### Common Chart Types
+
+Available chart types for `echartsOptionsOverridesByChartType`:
+
+- `echarts_timeseries` - Time series/line charts
+- `echarts_pie` - Pie and donut charts
+- `echarts_bubble` - Bubble/scatter charts
+- `echarts_funnel` - Funnel charts
+- `echarts_gauge` - Gauge charts
+- `echarts_radar` - Radar charts
+- `echarts_boxplot` - Box plot charts
+- `echarts_treemap` - Treemap charts
+- `echarts_sunburst` - Sunburst charts
+- `echarts_graph` - Network/graph charts
+- `echarts_sankey` - Sankey diagrams
+- `echarts_heatmap` - Heatmaps
+- `echarts_mixed_timeseries` - Mixed time series
+
+### Best Practices
+
+1. **Start with global overrides** for consistent styling across all charts
+2. **Use chart-specific overrides** for unique requirements per visualization type
+3. **Test thoroughly** as overrides use deep merge - nested objects are combined, but arrays are completely replaced
+4. **Document your overrides** to help team members understand custom styling
+5. **Consider performance** - complex overrides may impact chart rendering speed
+
+### Example: Corporate Branding
+
+```python
+# Complete corporate theme with ECharts customization
+THEME_DEFAULT = {
+    "token": {
+        "colorPrimary": "#1B4D3E",
+        "fontFamily": "Corporate Sans, Arial, sans-serif"
+    },
+    "echartsOptionsOverrides": {
+        "grid": {
+            "left": "8%",
+            "right": "8%",
+            "top": "12%",
+            "bottom": "12%"
+        },
+        "textStyle": {
+            "fontFamily": "Corporate Sans, Arial, sans-serif"
+        },
+        "title": {
+            "textStyle": {
+                "color": "#1B4D3E",
+                "fontSize": 18,
+                "fontWeight": "bold"
+            }
+        }
+    },
+    "echartsOptionsOverridesByChartType": {
+        "echarts_timeseries": {
+            "xAxis": {
+                "axisLabel": {
+                    "color": "#666",
+                    "fontSize": 11
+                }
+            }
+        },
+        "echarts_pie": {
+            "legend": {
+                "textStyle": {
+                    "fontSize": 12
+                },
+                "itemGap": 20
+            }
+        }
+    }
+}
+```
+
+This feature provides powerful theming capabilities while maintaining the flexibility of ECharts' extensive configuration options.
+
 ## Advanced Features
 
 - **System Themes**: Manage system-wide default and dark themes via UI or configuration

docs/yarn.lock

@@ -4766,9 +4766,9 @@ available-typed-arrays@^1.0.7:
     possible-typed-array-names "^1.0.0"
 
 axios@^1.9.0:
-  version "1.11.0"
-  resolved "https://registry.yarnpkg.com/axios/-/axios-1.11.0.tgz#c2ec219e35e414c025b2095e8b8280278478fdb6"
-  integrity sha512-1Lx3WLFQWm3ooKDYZD1eXmoGO9fxYQjrycfHFC8P0sCfQVXyROp0p9PFWBehewBOdCwHc+f/b8I0fMto5eSfwA==
+  version "1.12.0"
+  resolved "https://registry.yarnpkg.com/axios/-/axios-1.12.0.tgz#11248459be05a5ee493485628fa0e4323d0abfc3"
+  integrity sha512-oXTDccv8PcfjZmPGlWsPSwtOJCZ/b6W5jAMCNcfwJbCzDckwG0jrYJFaWH1yvivfCXjVzV/SPDEhMB3Q+DSurg==
   dependencies:
     follow-redirects "^1.15.6"
     form-data "^4.0.4"

pyproject.toml

@@ -313,6 +313,7 @@ select = [
     "E",
     "F",
     "F",
+    "G",
     "I",
     "N",
     "PT",
@@ -328,6 +329,7 @@ ignore = [
     "PT006",
     "T201",
     "N999",
+    "G201",
 ]
 extend-select = ["I"]
 

superset-extensions-cli/tests/test_cli_validate.py

@@ -160,7 +160,9 @@ def test_validate_npm_handles_file_not_found_exception(mock_run, mock_which):
 def test_validate_npm_does_not_catch_other_subprocess_exceptions(
     mock_run, mock_which, exception_type
 ):
-    """Test validate_npm does not catch OSError and PermissionError (they propagate up)."""
+    """
+    Test validate_npm does not catch OSError and PermissionError (they propagate up).
+    """
     mock_which.return_value = "/usr/bin/npm"
     mock_run.side_effect = exception_type("Test error")
 

superset-frontend/package-lock.json

@@ -64,7 +64,6 @@
         "dom-to-image-more": "^3.6.0",
         "dom-to-pdf": "^0.3.2",
         "echarts": "^5.6.0",
-        "emotion-rgba": "0.0.12",
         "eslint-plugin-i18n-strings": "file:eslint-rules/eslint-plugin-i18n-strings",
         "fast-glob": "^3.3.2",
         "fs-extra": "^11.2.0",
@@ -24466,12 +24465,6 @@
         "node": ">= 4"
       }
     },
-    "node_modules/emotion-rgba": {
-      "version": "0.0.12",
-      "resolved": "https://registry.npmjs.org/emotion-rgba/-/emotion-rgba-0.0.12.tgz",
-      "integrity": "sha512-lvtZ52BWisYDtis+HctQMkxcHwmFbzTiZhgMJGFfWXLsBYEzthfKE7nlysOiUwmmAdTM/8YBAPfwQ4MEDwiaWw==",
-      "license": "MIT"
-    },
     "node_modules/encodable": {
       "version": "0.7.8",
       "resolved": "https://registry.npmjs.org/encodable/-/encodable-0.7.8.tgz",

superset-frontend/package.json

@@ -132,7 +132,6 @@
     "dom-to-image-more": "^3.6.0",
     "dom-to-pdf": "^0.3.2",
     "echarts": "^5.6.0",
-    "emotion-rgba": "0.0.12",
     "eslint-plugin-i18n-strings": "file:eslint-rules/eslint-plugin-i18n-strings",
     "fast-glob": "^3.3.2",
     "fs-extra": "^11.2.0",

superset-frontend/packages/superset-ui-core/src/chart/models/ChartMetadata.ts

@@ -26,6 +26,7 @@ interface LookupTable {
 
 export interface ExampleImage {
   url: string;
+  urlDark?: string;
   caption?: string;
 }
 
@@ -38,6 +39,7 @@ export interface ChartMetadataConfig {
   enableNoResults?: boolean;
   supportedAnnotationTypes?: string[];
   thumbnail: string;
+  thumbnailDark?: string;
   useLegacyApi?: boolean;
   behaviors?: Behavior[];
   exampleGallery?: ExampleImage[];
@@ -71,6 +73,8 @@ export default class ChartMetadata {
 
   thumbnail: string;
 
+  thumbnailDark?: string;
+
   useLegacyApi: boolean;
 
   behaviors: Behavior[];
@@ -107,6 +111,7 @@ export default class ChartMetadata {
       description = '',
       supportedAnnotationTypes = [],
       thumbnail,
+      thumbnailDark,
       useLegacyApi = false,
       behaviors = [],
       datasourceCount = 1,
@@ -138,6 +143,7 @@ export default class ChartMetadata {
     );
     this.supportedAnnotationTypes = supportedAnnotationTypes;
     this.thumbnail = thumbnail;
+    this.thumbnailDark = thumbnailDark;
     this.useLegacyApi = useLegacyApi;
     this.behaviors = behaviors;
     this.datasourceCount = datasourceCount;

superset-frontend/packages/superset-ui-core/src/theme/index.tsx

@@ -60,10 +60,7 @@ export function useTheme() {
 
 const styled: CreateStyled = emotionStyled;
 
-// launching in in dark mode for now while iterating
-const themeObject: Theme = Theme.fromConfig({
-  algorithm: ThemeAlgorithm.DEFAULT,
-});
+const themeObject: Theme = Theme.fromConfig();
 
 const { theme } = themeObject;
 const supersetTheme = theme;

superset-frontend/packages/superset-ui-core/src/theme/types.ts

@@ -127,6 +127,15 @@ export interface SupersetSpecificTokens {
   // Spinner-related
   brandSpinnerUrl?: string;
   brandSpinnerSvg?: string;
+
+  // ECharts-related
+  /** Global ECharts configuration overrides applied to all chart types */
+  echartsOptionsOverrides?: any;
+
+  /** Chart-specific ECharts configuration overrides keyed by viz_type */
+  echartsOptionsOverridesByChartType?: {
+    [chartType: string]: any;
+  };
 }
 
 /**

superset-frontend/packages/superset-ui-core/src/utils/index.ts

@@ -33,3 +33,4 @@ export * from './random';
 export * from './typedMemo';
 export * from './html';
 export * from './tooltip';
+export * from './merge';

superset-frontend/packages/superset-ui-core/src/utils/merge.test.ts

@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { mergeReplaceArrays } from './merge';
+
+describe('lodash utilities', () => {
+  describe('mergeReplaceArrays', () => {
+    it('should merge objects and replace arrays', () => {
+      const obj1 = { a: [1, 2], b: { c: 3 } };
+      const obj2 = { a: [4, 5], b: { d: 6 } };
+
+      const result = mergeReplaceArrays(obj1, obj2);
+
+      expect(result).toEqual({
+        a: [4, 5], // array replaced
+        b: { c: 3, d: 6 }, // objects merged
+      });
+    });
+
+    it('should handle precedence with multiple sources', () => {
+      const base = { x: { y: 1 }, z: [1] };
+      const override1 = { x: { y: 2 }, z: [2, 3] };
+      const override2 = { x: { y: 3 }, z: [4] };
+
+      const result = mergeReplaceArrays(base, override1, override2);
+
+      expect(result).toEqual({
+        x: { y: 3 }, // last wins
+        z: [4], // array replaced by last
+      });
+    });
+
+    it('should handle empty and null values', () => {
+      const base = { a: [1], b: { x: 1 } };
+      const override = { a: [], b: { x: null } };
+
+      const result = mergeReplaceArrays(base, override);
+
+      expect(result).toEqual({
+        a: [], // empty array replaces
+        b: { x: null }, // null overrides
+      });
+    });
+  });
+});

superset-frontend/packages/superset-ui-core/src/utils/merge.ts

@@ -0,0 +1,52 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { mergeWith } from 'lodash';
+
+/**
+ * Merges objects using lodash.mergeWith, but replaces arrays instead of concatenating them.
+ * This is useful for configuration objects where you want to completely override array values
+ * rather than merge them by index.
+ *
+ * @example
+ * const obj1 = { a: [1, 2], b: { c: 3 } };
+ * const obj2 = { a: [4, 5], b: { d: 6 } };
+ * mergeReplaceArrays(obj1, obj2);
+ * // Result: { a: [4, 5], b: { c: 3, d: 6 } }
+ *
+ * @example
+ * // ECharts configuration merging
+ * const baseConfig = { series: [{ type: 'line' }], grid: { left: '10%' } };
+ * const overrides = { series: [{ type: 'bar' }], grid: { right: '10%' } };
+ * mergeReplaceArrays(baseConfig, overrides);
+ * // Result: { series: [{ type: 'bar' }], grid: { left: '10%', right: '10%' } }
+ *
+ * @param sources - Objects to merge (rightmost wins for arrays, deep merge for objects)
+ * @returns Merged object with arrays replaced, not concatenated
+ */
+export function mergeReplaceArrays<T = any>(...sources: any[]): T {
+  const replaceArrays = (objValue: any, srcValue: any) => {
+    if (Array.isArray(srcValue)) {
+      return srcValue; // Replace arrays entirely
+    }
+    return undefined; // Let lodash handle object merging for non-arrays
+  };
+
+  return mergeWith({}, ...sources, replaceArrays);
+}

superset-frontend/plugins/legacy-plugin-chart-calendar/src/index.js

@@ -19,8 +19,10 @@
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import transformProps from './transformProps';
 import example from './images/example.jpg';
+import exampleDark from './images/example-dark.jpg';
 import controlPanel from './controlPanel';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 
 const metadata = new ChartMetadata({
   category: t('Correlation'),
@@ -28,7 +30,7 @@ const metadata = new ChartMetadata({
   description: t(
     "Visualizes how a metric has changed over a time using a color scale and a calendar view. Gray values are used to indicate missing values and the linear color scheme is used to encode the magnitude of each day's value.",
   ),
-  exampleGallery: [{ url: example }],
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   name: t('Calendar Heatmap'),
   tags: [
     t('Business'),
@@ -39,6 +41,7 @@ const metadata = new ChartMetadata({
     t('Trend'),
   ],
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-plugin-chart-chord/src/index.js

@@ -19,7 +19,9 @@
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import transformProps from './transformProps';
 import example from './images/chord.jpg';
+import exampleDark from './images/chord-dark.jpg';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -29,11 +31,16 @@ const metadata = new ChartMetadata({
     'Showcases the flow or link between categories using thickness of chords. The value and corresponding thickness can be different for each side.',
   ),
   exampleGallery: [
-    { url: example, caption: t('Relationships between community channels') },
+    {
+      url: example,
+      urlDark: exampleDark,
+      caption: t('Relationships between community channels'),
+    },
   ],
   name: t('Chord Diagram'),
   tags: [t('Circular'), t('Legacy'), t('Proportional'), t('Relational')],
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-plugin-chart-country-map/src/index.js

@@ -19,8 +19,11 @@
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import transformProps from './transformProps';
 import exampleUsa from './images/exampleUsa.jpg';
+import exampleUsaDark from './images/exampleUsa-dark.jpg';
 import exampleGermany from './images/exampleGermany.jpg';
+import exampleGermanyDark from './images/exampleGermany-dark.jpg';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -29,7 +32,10 @@ const metadata = new ChartMetadata({
   description: t(
     "Visualizes how a single metric varies across a country's principal subdivisions (states, provinces, etc) on a choropleth map. Each subdivision's value is elevated when you hover over the corresponding geographic boundary.",
   ),
-  exampleGallery: [{ url: exampleUsa }, { url: exampleGermany }],
+  exampleGallery: [
+    { url: exampleUsa, urlDark: exampleUsaDark },
+    { url: exampleGermany, urlDark: exampleGermanyDark },
+  ],
   name: t('Country Map'),
   tags: [
     t('2D'),
@@ -40,6 +46,7 @@ const metadata = new ChartMetadata({
     t('Stacked'),
   ],
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-plugin-chart-horizon/src/index.js

@@ -19,7 +19,9 @@
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import transformProps from './transformProps';
 import example from './images/Horizon_Chart.jpg';
+import exampleDark from './images/Horizon_Chart-dark.jpg';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -28,10 +30,11 @@ const metadata = new ChartMetadata({
   description: t(
     'Compares how a metric changes over time between different groups. Each group is mapped to a row and change over time is visualized bar lengths and color.',
   ),
-  exampleGallery: [{ url: example }],
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   name: t('Horizon Chart'),
   tags: [t('Legacy')],
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-plugin-chart-map-box/src/index.js

@@ -18,8 +18,11 @@
  */
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example1 from './images/MapBox.jpg';
+import example1Dark from './images/MapBox-dark.jpg';
 import example2 from './images/MapBox2.jpg';
+import example2Dark from './images/MapBox2-dark.jpg';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -27,8 +30,8 @@ const metadata = new ChartMetadata({
   credits: ['https://www.mapbox.com/mapbox-gl-js/api/'],
   description: '',
   exampleGallery: [
-    { url: example1, description: t('Light mode') },
-    { url: example2, description: t('Dark mode') },
+    { url: example1, urlDark: example1Dark, description: t('Light mode') },
+    { url: example2, urlDark: example2Dark, description: t('Dark mode') },
   ],
   name: t('MapBox'),
   tags: [
@@ -40,6 +43,7 @@ const metadata = new ChartMetadata({
     t('Transformable'),
   ],
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-plugin-chart-paired-t-test/src/index.js

@@ -18,7 +18,10 @@
  */
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import transformProps from './transformProps';
+import example from './images/example.jpg';
+import exampleDark from './images/example-dark.jpg';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -26,9 +29,11 @@ const metadata = new ChartMetadata({
   description: t(
     'Table that visualizes paired t-tests, which are used to understand statistical differences between groups.',
   ),
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   name: t('Paired t-test Table'),
   tags: [t('Legacy'), t('Statistical'), t('Tabular')],
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-plugin-chart-parallel-coordinates/src/index.js

@@ -19,8 +19,11 @@
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import transformProps from './transformProps';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example1 from './images/example1.jpg';
+import example1Dark from './images/example1-dark.jpg';
 import example2 from './images/example2.jpg';
+import example2Dark from './images/example2-dark.jpg';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -29,10 +32,14 @@ const metadata = new ChartMetadata({
   description: t(
     'Plots the individual metrics for each row in the data vertically and links them together as a line. This chart is useful for comparing multiple metrics across all of the samples or rows in the data.',
   ),
-  exampleGallery: [{ url: example1 }, { url: example2 }],
+  exampleGallery: [
+    { url: example1, urlDark: example1Dark },
+    { url: example2, urlDark: example2Dark },
+  ],
   name: t('Parallel Coordinates'),
   tags: [t('Directional'), t('Legacy'), t('Relational')],
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-plugin-chart-partition/src/index.js

@@ -19,16 +19,19 @@
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import transformProps from './transformProps';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example from './images/example.jpg';
+import exampleDark from './images/example-dark.jpg';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
   category: t('Part of a Whole'),
   description: t('Compare the same summarized metric across multiple groups.'),
-  exampleGallery: [{ url: example }],
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   name: t('Partition Chart'),
   tags: [t('Categorical'), t('Comparison'), t('Legacy'), t('Proportional')],
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-plugin-chart-rose/src/index.js

@@ -19,8 +19,11 @@
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import transformProps from './transformProps';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example1 from './images/example1.jpg';
+import example1Dark from './images/example1-dark.jpg';
 import example2 from './images/example2.jpg';
+import example2Dark from './images/example2-dark.jpg';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -28,7 +31,10 @@ const metadata = new ChartMetadata({
   description: t(
     'A polar coordinate chart where the circle is broken into wedges of equal angle, and the value represented by any wedge is illustrated by its area, rather than its radius or sweep angle.',
   ),
-  exampleGallery: [{ url: example1 }, { url: example2 }],
+  exampleGallery: [
+    { url: example1, urlDark: example1Dark },
+    { url: example2, urlDark: example2Dark },
+  ],
   name: t('Nightingale Rose Chart'),
   tags: [
     t('Legacy'),
@@ -40,6 +46,7 @@ const metadata = new ChartMetadata({
     t('Trend'),
   ],
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-plugin-chart-world-map/src/index.js

@@ -19,8 +19,11 @@
 import { t, ChartMetadata, ChartPlugin, Behavior } from '@superset-ui/core';
 import transformProps from './transformProps';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example1 from './images/WorldMap1.jpg';
+import example1Dark from './images/WorldMap1-dark.jpg';
 import example2 from './images/WorldMap2.jpg';
+import example2Dark from './images/WorldMap2-dark.jpg';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -29,7 +32,10 @@ const metadata = new ChartMetadata({
   description: t(
     'A map of the world, that can indicate values in different countries.',
   ),
-  exampleGallery: [{ url: example1 }, { url: example2 }],
+  exampleGallery: [
+    { url: example1, urlDark: example1Dark },
+    { url: example2, urlDark: example2Dark },
+  ],
   name: t('World Map'),
   tags: [
     t('2D'),
@@ -43,6 +49,7 @@ const metadata = new ChartMetadata({
     t('Featured'),
   ],
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
   behaviors: [
     Behavior.InteractiveChart,

superset-frontend/plugins/legacy-preset-chart-deckgl/src/Multi/index.ts

@@ -18,7 +18,9 @@
  */
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example from './images/example.png';
+import exampleDark from './images/example-dark.png';
 import transformProps from '../transformProps';
 import controlPanel from './controlPanel';
 
@@ -26,9 +28,10 @@ const metadata = new ChartMetadata({
   category: t('Map'),
   credits: ['https://uber.github.io/deck.gl'],
   description: t('Compose multiple layers together to form complex visuals.'),
-  exampleGallery: [{ url: example }],
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   name: t('deck.gl Multiple Layers'),
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
   tags: [t('deckGL'), t('Multi-Layers')],
 });

superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Arc/index.ts

@@ -18,7 +18,9 @@
  */
 import { t, ChartMetadata, ChartPlugin, Behavior } from '@superset-ui/core';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example from './images/example.png';
+import exampleDark from './images/example-dark.png';
 import transformProps from '../../transformProps';
 import controlPanel from './controlPanel';
 
@@ -35,7 +37,8 @@ const metadata = new ChartMetadata({
   ),
   name: t('deck.gl Arc'),
   thumbnail,
-  exampleGallery: [{ url: example }],
+  thumbnailDark,
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   useLegacyApi: true,
   tags: [t('deckGL'), t('Geo'), t('3D'), t('Relational'), t('Web')],
 });

superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Contour/index.ts

@@ -20,7 +20,9 @@ import { t, ChartMetadata, ChartPlugin, Behavior } from '@superset-ui/core';
 import transformProps from '../../transformProps';
 import controlPanel from './controlPanel';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example from './images/example.png';
+import exampleDark from './images/example-dark.png';
 
 const metadata = new ChartMetadata({
   category: t('Map'),
@@ -28,9 +30,10 @@ const metadata = new ChartMetadata({
   description: t(
     'Uses Gaussian Kernel Density Estimation to visualize spatial distribution of data',
   ),
-  exampleGallery: [{ url: example }],
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   name: t('deck.gl Contour'),
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
   tags: [t('deckGL'), t('Spatial'), t('Comparison')],
   behaviors: [Behavior.InteractiveChart],

superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Geojson/index.ts

@@ -18,7 +18,9 @@
  */
 import { t, ChartMetadata, ChartPlugin, Behavior } from '@superset-ui/core';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example from './images/example.png';
+import exampleDark from './images/example-dark.png';
 import transformProps from '../../transformProps';
 import controlPanel from './controlPanel';
 
@@ -28,9 +30,10 @@ const metadata = new ChartMetadata({
   description: t(
     'The GeoJsonLayer takes in GeoJSON formatted data and renders it as interactive polygons, lines and points (circles, icons and/or texts).',
   ),
-  exampleGallery: [{ url: example }],
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   name: t('deck.gl Geojson'),
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
   tags: [t('deckGL'), t('2D')],
   behaviors: [Behavior.InteractiveChart],

superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Grid/index.ts

@@ -18,7 +18,9 @@
  */
 import { t, ChartMetadata, ChartPlugin, Behavior } from '@superset-ui/core';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example from './images/example.png';
+import exampleDark from './images/example-dark.png';
 import transformProps from '../../transformProps';
 import controlPanel from './controlPanel';
 
@@ -30,7 +32,8 @@ const metadata = new ChartMetadata({
   ),
   name: t('deck.gl Grid'),
   thumbnail,
-  exampleGallery: [{ url: example }],
+  thumbnailDark,
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   useLegacyApi: true,
   tags: [t('deckGL'), t('3D'), t('Comparison')],
   behaviors: [Behavior.InteractiveChart],

superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Heatmap/index.ts

@@ -20,7 +20,9 @@ import { t, ChartMetadata, ChartPlugin, Behavior } from '@superset-ui/core';
 import transformProps from '../../transformProps';
 import controlPanel from './controlPanel';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example from './images/example.png';
+import exampleDark from './images/example-dark.png';
 
 const metadata = new ChartMetadata({
   category: t('Map'),
@@ -28,9 +30,10 @@ const metadata = new ChartMetadata({
   description: t(
     'Uses Gaussian Kernel Density Estimation to visualize spatial distribution of data',
   ),
-  exampleGallery: [{ url: example }],
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   name: t('deck.gl Heatmap'),
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
   tags: [t('deckGL'), t('Spatial'), t('Comparison')],
   behaviors: [Behavior.InteractiveChart],

superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Hex/index.ts

@@ -18,7 +18,9 @@
  */
 import { t, ChartMetadata, ChartPlugin, Behavior } from '@superset-ui/core';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example from './images/example.png';
+import exampleDark from './images/example-dark.png';
 import transformProps from '../../transformProps';
 import controlPanel from './controlPanel';
 
@@ -28,9 +30,10 @@ const metadata = new ChartMetadata({
   description: t(
     'Overlays a hexagonal grid on a map, and aggregates data within the boundary of each cell.',
   ),
-  exampleGallery: [{ url: example }],
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   name: t('deck.gl 3D Hexagon'),
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
   tags: [t('deckGL'), t('3D'), t('Geo'), t('Comparison')],
   behaviors: [Behavior.InteractiveChart],

superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Path/index.ts

@@ -18,7 +18,9 @@
  */
 import { t, ChartMetadata, ChartPlugin, Behavior } from '@superset-ui/core';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example from './images/example.png';
+import exampleDark from './images/example-dark.png';
 import transformProps from '../../transformProps';
 import controlPanel from './controlPanel';
 
@@ -28,7 +30,8 @@ const metadata = new ChartMetadata({
   description: t('Visualizes connected points, which form a path, on a map.'),
   name: t('deck.gl Path'),
   thumbnail,
-  exampleGallery: [{ url: example }],
+  thumbnailDark,
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   useLegacyApi: true,
   tags: [t('deckGL'), t('Web')],
   behaviors: [Behavior.InteractiveChart],

superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Polygon/index.ts

@@ -18,7 +18,9 @@
  */
 import { t, ChartMetadata, ChartPlugin, Behavior } from '@superset-ui/core';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example from './images/example.png';
+import exampleDark from './images/example-dark.png';
 import transformProps from '../../transformProps';
 import controlPanel from './controlPanel';
 
@@ -30,7 +32,8 @@ const metadata = new ChartMetadata({
   ),
   name: t('deck.gl Polygon'),
   thumbnail,
-  exampleGallery: [{ url: example }],
+  thumbnailDark,
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   useLegacyApi: true,
   tags: [t('deckGL'), t('3D'), t('Multi-Dimensions'), t('Geo')],
   behaviors: [Behavior.InteractiveChart],

superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Scatter/index.ts

@@ -18,7 +18,9 @@
  */
 import { t, ChartMetadata, ChartPlugin, Behavior } from '@superset-ui/core';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example from './images/example.png';
+import exampleDark from './images/example-dark.png';
 import transformProps from '../../transformProps';
 import controlPanel from './controlPanel';
 
@@ -30,7 +32,8 @@ const metadata = new ChartMetadata({
   ),
   name: t('deck.gl Scatterplot'),
   thumbnail,
-  exampleGallery: [{ url: example }],
+  thumbnailDark,
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   useLegacyApi: true,
   tags: [
     t('deckGL'),

superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Screengrid/index.ts

@@ -18,7 +18,9 @@
  */
 import { t, ChartMetadata, ChartPlugin, Behavior } from '@superset-ui/core';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example from './images/example.png';
+import exampleDark from './images/example-dark.png';
 import transformProps from '../../transformProps';
 import controlPanel from './controlPanel';
 
@@ -30,7 +32,8 @@ const metadata = new ChartMetadata({
   ),
   name: t('deck.gl Screen Grid'),
   thumbnail,
-  exampleGallery: [{ url: example }],
+  thumbnailDark,
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   useLegacyApi: true,
   tags: [t('deckGL'), t('Comparison'), t('Intensity'), t('Density')],
   behaviors: [Behavior.InteractiveChart],

superset-frontend/plugins/legacy-preset-chart-nvd3/src/Bubble/index.js

@@ -19,7 +19,9 @@
 import { t, ChartMetadata, ChartPlugin, ChartLabel } from '@superset-ui/core';
 import transformProps from '../transformProps';
 import example from './images/example.jpg';
+import exampleDark from './images/example-dark.jpg';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -28,7 +30,7 @@ const metadata = new ChartMetadata({
   description: t(
     'Visualizes a metric across three dimensions of data in a single chart (X axis, Y axis, and bubble size). Bubbles from the same group can be showcased using bubble color.',
   ),
-  exampleGallery: [{ url: example }],
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   label: ChartLabel.Deprecated,
   name: t('Bubble Chart (legacy)'),
   tags: [
@@ -41,6 +43,7 @@ const metadata = new ChartMetadata({
     t('nvd3'),
   ],
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-preset-chart-nvd3/src/Bullet/index.js

@@ -19,7 +19,9 @@
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import transformProps from '../transformProps';
 import example from './images/example.jpg';
+import exampleDark from './images/example-dark.jpg';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -28,10 +30,11 @@ const metadata = new ChartMetadata({
   description: t(
     'Showcases the progress of a single metric against a given target. The higher the fill, the closer the metric is to the target.',
   ),
-  exampleGallery: [{ url: example }],
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   name: t('Bullet Chart'),
   tags: [t('Business'), t('Legacy'), t('Report'), t('nvd3')],
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
 });
 

superset-frontend/plugins/legacy-preset-chart-nvd3/src/Compare/index.js

@@ -19,7 +19,9 @@
 import { t, ChartMetadata, ChartPlugin, ChartLabel } from '@superset-ui/core';
 import transformProps from '../transformProps';
 import thumbnail from './images/thumbnail.png';
+import thumbnailDark from './images/thumbnail-dark.png';
 import example from './images/example.jpg';
+import exampleDark from './images/example-dark.jpg';
 import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
@@ -28,7 +30,7 @@ const metadata = new ChartMetadata({
   description: t(
     'Visualizes many different time-series objects in a single chart. This chart is being deprecated and we recommend using the Time-series Chart instead.',
   ),
-  exampleGallery: [{ url: example }],
+  exampleGallery: [{ url: example, urlDark: exampleDark }],
   label: ChartLabel.Deprecated,
   name: t('Time-series Percent Change'),
   tags: [
@@ -43,6 +45,7 @@ const metadata = new ChartMetadata({
     t('Trend'),
   ],
   thumbnail,
+  thumbnailDark,
   useLegacyApi: true,
 });