Evan Rusackas 014bca8eea address review: wait for webpack in nginx, probe manifest.json ...

Move the wait-for-dev-server logic out of a superset-node healthcheck
and into an nginx startup wait loop, and probe manifest.json (served
directly by webpack) instead of / (which proxies to the backend).

- Healthcheck on / was passing on backend-driven redirects and failing
  when the backend wasn't up yet; manifest.json is served by webpack
  itself at its devMiddleware publicPath and only exists after the
  first compile, which is exactly the signal we want.
- Waiting in nginx (via curl to host.docker.internal:9000) works for
  both BUILD_SUPERSET_FRONTEND_IN_DOCKER=true (dev server inside the
  superset-node container) and =false (dev server run on the host),
  so the "skip" workflow is preserved — no breaking change.
- Drops the superset-node healthcheck and the service_healthy gate
  on nginx, since nginx now polls the upstream directly.

2026-04-22 12:28:10 -07:00

9.4 KiB

Raw Blame History

View Raw