mirror of
https://github.com/apache/superset.git
synced 2026-04-24 18:44:53 +00:00
9029701f24
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
124 lines
3.4 KiB
JavaScript
124 lines
3.4 KiB
JavaScript
/* eslint-disable no-unused-expressions */
|
|
import sinon from 'sinon';
|
|
import $ from 'jquery';
|
|
import * as actions from '../../../src/SqlLab/actions';
|
|
import { query } from './fixtures';
|
|
|
|
describe('async actions', () => {
|
|
let ajaxStub;
|
|
let dispatch;
|
|
|
|
beforeEach(() => {
|
|
dispatch = sinon.spy();
|
|
ajaxStub = sinon.stub($, 'ajax');
|
|
});
|
|
afterEach(() => {
|
|
ajaxStub.restore();
|
|
});
|
|
|
|
describe('saveQuery', () => {
|
|
it('makes the ajax request', () => {
|
|
const thunk = actions.saveQuery(query);
|
|
thunk((/* mockDispatch */) => {});
|
|
expect(ajaxStub.calledOnce).toBe(true);
|
|
});
|
|
|
|
it('calls correct url', () => {
|
|
const url = '/savedqueryviewapi/api/create';
|
|
const thunk = actions.saveQuery(query);
|
|
thunk((/* mockDispatch */) => {});
|
|
expect(ajaxStub.getCall(0).args[0].url).toBe(url);
|
|
});
|
|
});
|
|
|
|
describe('fetchQueryResults', () => {
|
|
const makeRequest = () => {
|
|
const request = actions.fetchQueryResults(query);
|
|
request(dispatch);
|
|
};
|
|
|
|
it('makes the ajax request', () => {
|
|
makeRequest();
|
|
expect(ajaxStub.calledOnce).toBe(true);
|
|
});
|
|
|
|
it('calls correct url', () => {
|
|
const url = `/superset/results/${query.resultsKey}/`;
|
|
makeRequest();
|
|
expect(ajaxStub.getCall(0).args[0].url).toBe(url);
|
|
});
|
|
|
|
it('calls requestQueryResults', () => {
|
|
makeRequest();
|
|
expect(dispatch.args[0][0].type).toBe(actions.REQUEST_QUERY_RESULTS);
|
|
});
|
|
|
|
it('calls querySuccess on ajax success', () => {
|
|
ajaxStub.yieldsTo('success', '{ "data": "" }');
|
|
makeRequest();
|
|
expect(dispatch.callCount).toBe(2);
|
|
expect(dispatch.getCall(1).args[0].type).toBe(actions.QUERY_SUCCESS);
|
|
});
|
|
|
|
it('calls queryFailed on ajax error', () => {
|
|
ajaxStub.yieldsTo('error', { responseJSON: { error: 'error text' } });
|
|
makeRequest();
|
|
expect(dispatch.callCount).toBe(2);
|
|
expect(dispatch.getCall(1).args[0].type).toBe(actions.QUERY_FAILED);
|
|
});
|
|
});
|
|
|
|
describe('runQuery', () => {
|
|
const makeRequest = () => {
|
|
const request = actions.runQuery(query);
|
|
request(dispatch);
|
|
};
|
|
|
|
it('makes the ajax request', () => {
|
|
makeRequest();
|
|
expect(ajaxStub.calledOnce).toBe(true);
|
|
});
|
|
|
|
it('calls startQuery', () => {
|
|
makeRequest();
|
|
expect(dispatch.args[0][0].type).toBe(actions.START_QUERY);
|
|
});
|
|
|
|
it('calls queryFailed on ajax error', () => {
|
|
ajaxStub.yieldsTo('error', { responseJSON: { error: 'error text' } });
|
|
makeRequest();
|
|
expect(dispatch.callCount).toBe(2);
|
|
expect(dispatch.getCall(1).args[0].type).toBe(actions.QUERY_FAILED);
|
|
});
|
|
});
|
|
|
|
describe('postStopQuery', () => {
|
|
const makeRequest = () => {
|
|
const request = actions.postStopQuery(query);
|
|
request(dispatch);
|
|
};
|
|
|
|
it('makes the ajax request', () => {
|
|
makeRequest();
|
|
expect(ajaxStub.calledOnce).toBe(true);
|
|
});
|
|
|
|
it('calls stopQuery', () => {
|
|
makeRequest();
|
|
expect(dispatch.args[0][0].type).toBe(actions.STOP_QUERY);
|
|
});
|
|
|
|
it('calls the correct url', () => {
|
|
const url = '/superset/stop_query/';
|
|
makeRequest();
|
|
expect(ajaxStub.getCall(0).args[0].url).toBe(url);
|
|
});
|
|
|
|
it('sends the correct data', () => {
|
|
const data = { client_id: query.id };
|
|
makeRequest();
|
|
expect(ajaxStub.getCall(0).args[0].data).toEqual(data);
|
|
});
|
|
});
|
|
});
|