superset2

mirror of https://github.com/apache/superset.git synced 2026-06-10 18:19:28 +00:00

Files

Mike Bridge cc20fe7cae fix(migration): always run NULL-FK cleanup; correct RLS test parent name

Two cleanups from PR review:

1. ``dashboard_roles.dashboard_id`` was created nullable in revision
   e11ccdd12658 but was missing from ``TABLES_WITH_NULLABLE_FKS``. A
   production database with a stray NULL ``dashboard_id`` row would have
   failed the PK-add with a cryptic constraint violation. Fix by running
   the NULL-FK cleanup on every affected table — it is a no-op DELETE on
   tables whose FK columns are already NOT NULL, and it eliminates the
   risk of further drift in the hardcoded set. ``dashboard_roles`` is
   added to the documentation set; the runtime now does not consult it.

2. The unit-test parent-table name for ``rls_filter_roles`` and
   ``rls_filter_tables`` was ``rls_filter`` (does not exist) instead of
   the real parent ``row_level_security_filters``. Test passes either
   way (the in-memory FK is self-consistent), but the parameter is now
   accurate.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-19 18:42:05 -06:00

common

refactor: Enable G logging rules and comprehensive ruff improvements (#35081 )

2025-09-15 12:42:49 -07:00

consts

…

example_data

chore: enforce more ruff rules (#31447 )

2024-12-18 17:41:34 -08:00

fixtures

chore: enforce more ruff rules (#31447 )

2024-12-18 17:41:34 -08:00