mirror of
https://github.com/apache/superset.git
synced 2026-05-12 11:25:56 +00:00
This comprehensive architectural transformation removes all static theme imports (supersetTheme, themeObject) across the entire codebase, replacing them with proper dynamic theme access patterns that support real-time theme switching. ## What Changed **Static Exports Eliminated:** - Removed `supersetTheme` and `themeObject` exports from core theme module - Eliminated static theme dependencies across 47 files - Updated ESLint rules to reflect removed exports **Dynamic Theme Architecture:** - Functional components: Use `useTheme()` hook for reactive theme access - Class components: Use `withTheme()` HOC for theme injection - Transform functions: Access `theme` from chartProps parameter - Test infrastructure: Use `Theme.fromConfig()` for isolated testing - Singleton pattern: `DEFAULT_THEME` for efficient fallbacks **Test Architecture Cleanup:** - Removed unnecessary theme setup from 30+ test files - Eliminated legacy `dynamicTheme` cruft from logic tests - Simplified theme assertions to focus on behavior vs implementation details - Maintained theme testing only where legitimately needed **Core Infrastructure:** - ThemeController uses dynamic theme creation instead of static imports - ChartProps uses singleton DEFAULT_THEME for efficient fallbacks - Theme providers only at app root and isolated contexts (tests, storybook) ## Why This Was Needed The previous architecture had static theme imports that: - Always returned light theme values regardless of current theme mode - Broke dark mode compatibility in visualizations (fixed in previous commit) - Created performance overhead with redundant theme instance creation - Prevented real-time theme switching across components - Led to inconsistent theme access patterns ## Benefits - ✅ Perfect dark mode support - no static dependencies to break theming - ✅ True dynamic theming - all components react to theme changes - ✅ Clean architecture - minimal providers, consistent patterns - ✅ Better performance - singleton pattern eliminates waste - ✅ Future-proof - ready for theme customization and user preferences - ✅ Developer experience - clear patterns for every context This transformation enables the next generation of Superset theming with complete dynamic theme support and perfect dark mode compatibility. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
168 lines
4.9 KiB
TypeScript
168 lines
4.9 KiB
TypeScript
/**
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing,
|
|
* software distributed under the License is distributed on an
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
* KIND, either express or implied. See the License for the
|
|
* specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
import { ChartProps, getNumberFormatter } from '@superset-ui/core';
|
|
import transformProps, { parseParams } from '../../src/Funnel/transformProps';
|
|
import {
|
|
EchartsFunnelChartProps,
|
|
PercentCalcType,
|
|
} from '../../src/Funnel/types';
|
|
|
|
const formData = {
|
|
colorScheme: 'bnbColors',
|
|
datasource: '3__table',
|
|
granularity_sqla: 'ds',
|
|
metric: 'sum__num',
|
|
groupby: ['foo', 'bar'],
|
|
};
|
|
const queriesData = [
|
|
{
|
|
data: [
|
|
{ foo: 'Sylvester', bar: 1, sum__num: 10 },
|
|
{ foo: 'Arnold', bar: 2, sum__num: 2.5 },
|
|
],
|
|
},
|
|
];
|
|
const chartProps = new ChartProps({
|
|
formData,
|
|
width: 800,
|
|
height: 600,
|
|
queriesData,
|
|
});
|
|
|
|
describe('Funnel transformProps', () => {
|
|
it('should transform chart props for viz', () => {
|
|
expect(transformProps(chartProps as EchartsFunnelChartProps)).toEqual(
|
|
expect.objectContaining({
|
|
width: 800,
|
|
height: 600,
|
|
echartOptions: expect.objectContaining({
|
|
series: [
|
|
expect.objectContaining({
|
|
data: expect.arrayContaining([
|
|
expect.objectContaining({
|
|
name: 'Arnold, 2',
|
|
value: 2.5,
|
|
}),
|
|
expect.objectContaining({
|
|
name: 'Sylvester, 1',
|
|
value: 10,
|
|
}),
|
|
]),
|
|
}),
|
|
],
|
|
}),
|
|
}),
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('formatFunnelLabel', () => {
|
|
it('should generate a valid funnel chart label', () => {
|
|
const numberFormatter = getNumberFormatter();
|
|
const params = {
|
|
name: 'My Label',
|
|
value: 1234,
|
|
percent: 12.34,
|
|
data: { firstStepPercent: 0.5, prevStepPercent: 0.85 },
|
|
};
|
|
expect(
|
|
parseParams({
|
|
params,
|
|
numberFormatter,
|
|
percentCalculationType: PercentCalcType.Total,
|
|
}),
|
|
).toEqual(['My Label', '1.23k', '12.34%']);
|
|
expect(
|
|
parseParams({
|
|
params,
|
|
numberFormatter,
|
|
percentCalculationType: PercentCalcType.FirstStep,
|
|
}),
|
|
).toEqual(['My Label', '1.23k', '50.00%']);
|
|
expect(
|
|
parseParams({
|
|
params,
|
|
numberFormatter,
|
|
percentCalculationType: PercentCalcType.PreviousStep,
|
|
}),
|
|
).toEqual(['My Label', '1.23k', '85.00%']);
|
|
expect(
|
|
parseParams({
|
|
params: { ...params, name: '<NULL>' },
|
|
numberFormatter,
|
|
percentCalculationType: PercentCalcType.Total,
|
|
}),
|
|
).toEqual(['<NULL>', '1.23k', '12.34%']);
|
|
expect(
|
|
parseParams({
|
|
params: { ...params, name: '<NULL>' },
|
|
numberFormatter,
|
|
percentCalculationType: PercentCalcType.Total,
|
|
sanitizeName: true,
|
|
}),
|
|
).toEqual(['<NULL>', '1.23k', '12.34%']);
|
|
});
|
|
});
|
|
|
|
describe('legend sorting', () => {
|
|
const legendQueriesData = [
|
|
{
|
|
data: [
|
|
{ foo: 'Sylvester', sum__num: 10 },
|
|
{ foo: 'Arnold', sum__num: 2.5 },
|
|
{ foo: 'Mark', sum__num: 13 },
|
|
],
|
|
},
|
|
];
|
|
const createChartProps = (overrides = {}) =>
|
|
new ChartProps({
|
|
...chartProps,
|
|
formData: {
|
|
...formData,
|
|
groupby: ['foo'],
|
|
...overrides,
|
|
},
|
|
queriesData: legendQueriesData,
|
|
});
|
|
|
|
it('preserves original data order when no sort specified', () => {
|
|
const props = createChartProps({ legendSort: null });
|
|
const result = transformProps(props as EchartsFunnelChartProps);
|
|
|
|
const legendData = (result.echartOptions.legend as any).data;
|
|
expect(legendData).toEqual(['Sylvester', 'Arnold', 'Mark']);
|
|
});
|
|
|
|
it('sorts alphabetically ascending when legendSort is "asc"', () => {
|
|
const props = createChartProps({ legendSort: 'asc' });
|
|
const result = transformProps(props as EchartsFunnelChartProps);
|
|
|
|
const legendData = (result.echartOptions.legend as any).data;
|
|
expect(legendData).toEqual(['Arnold', 'Mark', 'Sylvester']);
|
|
});
|
|
|
|
it('sorts alphabetically descending when legendSort is "desc"', () => {
|
|
const props = createChartProps({ legendSort: 'desc' });
|
|
const result = transformProps(props as EchartsFunnelChartProps);
|
|
|
|
const legendData = (result.echartOptions.legend as any).data;
|
|
expect(legendData).toEqual(['Sylvester', 'Mark', 'Arnold']);
|
|
});
|
|
});
|