mirror of
https://github.com/apache/superset.git
synced 2026-04-09 03:16:07 +00:00
9029701f24
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
83 lines
2.7 KiB
JavaScript
83 lines
2.7 KiB
JavaScript
import React from 'react';
|
|
import { shallow } from 'enzyme';
|
|
|
|
import ColumnOption from '../../../src/components/ColumnOption';
|
|
import ColumnTypeLabel from '../../../src/components/ColumnTypeLabel';
|
|
import InfoTooltipWithTrigger from '../../../src/components/InfoTooltipWithTrigger';
|
|
|
|
describe('ColumnOption', () => {
|
|
const defaultProps = {
|
|
column: {
|
|
column_name: 'foo',
|
|
verbose_name: 'Foo',
|
|
expression: 'SUM(foo)',
|
|
description: 'Foo is the greatest column of all',
|
|
},
|
|
showType: false,
|
|
};
|
|
|
|
let wrapper;
|
|
let props;
|
|
const factory = o => <ColumnOption {...o} />;
|
|
beforeEach(() => {
|
|
wrapper = shallow(factory(defaultProps));
|
|
props = Object.assign({}, defaultProps);
|
|
});
|
|
it('is a valid element', () => {
|
|
expect(React.isValidElement(<ColumnOption {...defaultProps} />)).toBe(true);
|
|
});
|
|
it('shows a label with verbose_name', () => {
|
|
const lbl = wrapper.find('.option-label');
|
|
expect(lbl).toHaveLength(1);
|
|
expect(lbl.first().text()).toBe('Foo');
|
|
});
|
|
it('shows 2 InfoTooltipWithTrigger', () => {
|
|
expect(wrapper.find(InfoTooltipWithTrigger)).toHaveLength(2);
|
|
});
|
|
it('shows only 1 InfoTooltipWithTrigger when no descr', () => {
|
|
props.column.description = null;
|
|
wrapper = shallow(factory(props));
|
|
expect(wrapper.find(InfoTooltipWithTrigger)).toHaveLength(1);
|
|
});
|
|
it('shows a label with column_name when no verbose_name', () => {
|
|
props.column.verbose_name = null;
|
|
wrapper = shallow(factory(props));
|
|
expect(wrapper.find('.option-label').first().text()).toBe('foo');
|
|
});
|
|
it('shows a column type label when showType is true', () => {
|
|
wrapper = shallow(factory({
|
|
...props,
|
|
showType: true,
|
|
column: {
|
|
expression: null,
|
|
type: 'str',
|
|
},
|
|
}));
|
|
expect(wrapper.find(ColumnTypeLabel)).toHaveLength(1);
|
|
});
|
|
it('column with expression has correct column label if showType is true', () => {
|
|
props.showType = true;
|
|
wrapper = shallow(factory(props));
|
|
expect(wrapper.find(ColumnTypeLabel)).toHaveLength(1);
|
|
expect(wrapper.find(ColumnTypeLabel).props().type).toBe('expression');
|
|
});
|
|
it('shows no column type label when type is null', () => {
|
|
wrapper = shallow(factory({
|
|
...props,
|
|
showType: true,
|
|
column: {
|
|
expression: null,
|
|
type: null,
|
|
},
|
|
}));
|
|
expect(wrapper.find(ColumnTypeLabel)).toHaveLength(0);
|
|
});
|
|
it('dttm column has correct column label if showType is true', () => {
|
|
props.showType = true;
|
|
props.column.is_dttm = true;
|
|
wrapper = shallow(factory(props));
|
|
expect(wrapper.find(ColumnTypeLabel)).toHaveLength(1);
|
|
expect(wrapper.find(ColumnTypeLabel).props().type).toBe('time');
|
|
});
|
|
});
|