mirror of
https://github.com/apache/superset.git
synced 2026-04-09 11:25:23 +00:00
9029701f24
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
97 lines
3.2 KiB
JavaScript
97 lines
3.2 KiB
JavaScript
/* eslint-disable no-unused-expressions */
|
|
import React from 'react';
|
|
import sinon from 'sinon';
|
|
import PropTypes from 'prop-types';
|
|
import { shallow } from 'enzyme';
|
|
|
|
import VirtualizedRendererWrap from '../../../src/components/VirtualizedRendererWrap';
|
|
|
|
const defaultProps = {
|
|
focusedOption: { label: 'focusedOn', value: 'focusedOn' },
|
|
focusOption: sinon.spy(),
|
|
key: 'key1',
|
|
option: { label: 'option1', value: 'option1' },
|
|
selectValue: sinon.spy(),
|
|
valueArray: [],
|
|
};
|
|
|
|
function TestOption({ option }) {
|
|
return (
|
|
<span>{option.label}</span>
|
|
);
|
|
}
|
|
TestOption.propTypes = {
|
|
option: PropTypes.object.isRequired,
|
|
};
|
|
|
|
const defaultRenderer = opt => <TestOption option={opt} />;
|
|
const RendererWrap = VirtualizedRendererWrap(defaultRenderer);
|
|
|
|
describe('VirtualizedRendererWrap', () => {
|
|
let wrapper;
|
|
let props;
|
|
beforeEach(() => {
|
|
wrapper = shallow(<RendererWrap {...defaultProps} />);
|
|
props = Object.assign({}, defaultProps);
|
|
});
|
|
|
|
it('uses the provided renderer', () => {
|
|
const option = wrapper.find(TestOption);
|
|
expect(option).toHaveLength(1);
|
|
});
|
|
|
|
it('renders nothing when no option is provided', () => {
|
|
props.option = null;
|
|
wrapper = shallow(<RendererWrap {...props} />);
|
|
const option = wrapper.find(TestOption);
|
|
expect(option).toHaveLength(0);
|
|
});
|
|
|
|
it('renders unfocused, unselected options with the default class', () => {
|
|
const optionDiv = wrapper.find('div');
|
|
expect(optionDiv).toHaveLength(1);
|
|
expect(optionDiv.props().className).toBe('VirtualizedSelectOption');
|
|
});
|
|
|
|
it('renders focused option with the correct class', () => {
|
|
props.option = props.focusedOption;
|
|
wrapper = shallow(<RendererWrap {...props} />);
|
|
const optionDiv = wrapper.find('div');
|
|
expect(optionDiv.props().className).toBe('VirtualizedSelectOption VirtualizedSelectFocusedOption');
|
|
});
|
|
|
|
it('renders disabled option with the correct class', () => {
|
|
props.option.disabled = true;
|
|
wrapper = shallow(<RendererWrap {...props} />);
|
|
const optionDiv = wrapper.find('div');
|
|
expect(optionDiv.props().className).toBe('VirtualizedSelectOption VirtualizedSelectDisabledOption');
|
|
props.option.disabled = false;
|
|
});
|
|
|
|
it('renders selected option with the correct class', () => {
|
|
props.valueArray = [props.option, props.focusedOption];
|
|
wrapper = shallow(<RendererWrap {...props} />);
|
|
const optionDiv = wrapper.find('div');
|
|
expect(optionDiv.props().className).toBe('VirtualizedSelectOption VirtualizedSelectSelectedOption');
|
|
});
|
|
|
|
it('renders options with custom classes', () => {
|
|
props.option.className = 'CustomClass';
|
|
wrapper = shallow(<RendererWrap {...props} />);
|
|
const optionDiv = wrapper.find('div');
|
|
expect(optionDiv.props().className).toBe('VirtualizedSelectOption CustomClass');
|
|
});
|
|
|
|
it('calls focusedOption on its own option onMouseEnter', () => {
|
|
const optionDiv = wrapper.find('div');
|
|
optionDiv.simulate('mouseEnter');
|
|
expect(props.focusOption.calledWith(props.option)).toBe(true);
|
|
});
|
|
|
|
it('calls selectValue on its own option onClick', () => {
|
|
const optionDiv = wrapper.find('div');
|
|
optionDiv.simulate('click');
|
|
expect(props.selectValue.calledWith(props.option)).toBe(true);
|
|
});
|
|
});
|