QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-05-24 21:14:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(i18n): extract hardcoded English strings to locale files (#1806)

Browse Source 
* Extract hardcoded strings to i18n

Replace numerous hardcoded English strings with I18n lookups (t / I18n.t) across controllers, views, helpers, and components, and convert model validation error messages to symbol keys. Added multiple locale files under config/locales for models and views. This centralizes user-facing notices/alerts, UI text, import/validation messages, and prepares the app for localization and easier translation maintenance.

* Update en.yml

* Update preview-cleanup.yml

* Revert "Update preview-cleanup.yml"

This reverts commit 1ba6d3c34c.

* test: align i18n assertions with translated messages

* Standardize balance error key and tweak locales

Replace SophtronAccount's :requires_balance error key with :no_balance and update related locale strings for sophtron, plaid, and simplefin accounts to use the new key and clearer copy. Also switch the QIF upload redirect notice to use a relative translation key (t('.qif_uploaded')), remove an unused SSO providers help line, and fix a trailing-newline/whitespace issue in the subscriptions locale. These changes standardize validation keys and improve translation consistency and messaging.

---------

Co-authored-by: KiloClaw <kiloclaw@openclaw.ai>
This commit is contained in:
Brendon Scheiber
2026-05-17 09:52:49 +02:00
committed by GitHub
parent d74b1b2a11
commit 0c126b1674
201 changed files with 1845 additions and 835 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/controllers/subscriptions_controller.rb
View File

@@ -8,7 +8,7 @@ class SubscriptionsController < ApplicationController
# Upgrade page for unsubscribed users
def upgrade
if Current.family.subscription&.active?
redirect_to root_path, notice: "You are already contributing. Thank you!"
redirect_to root_path, notice: t(".already_contributing")
else
@plan = params[:plan] || "annual"
render layout: "onboardings"
@@ -33,9 +33,9 @@ class SubscriptionsController < ApplicationController
def create
if Current.family.can_start_trial?
Current.family.start_trial_subscription!
redirect_to root_path, notice: "Welcome to Sure!"
redirect_to root_path, notice: t(".welcome")
else
redirect_to root_path, alert: "You have already started or completed a trial. Please upgrade to continue."
redirect_to root_path, alert: t(".trial_already_used")
end
end
@@ -54,9 +54,9 @@ class SubscriptionsController < ApplicationController
if checkout_result.success?
Current.family.start_subscription!(checkout_result.subscription_id)
redirect_to root_path, notice: "Welcome to Sure! Your contribution is appreciated."
redirect_to root_path, notice: t(".welcome_with_contribution")
else
redirect_to root_path, alert: "Something went wrong processing your contribution. Please try again."
redirect_to root_path, alert: t(".contribution_failed")
end
end