QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-04-19 03:54:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Missing translation fallback for account subtypes (#1325)

Browse Source 
* Fix missing translation fallback for account subtypes in LunchFlow and Mercury

The translate_subtypes lambda called t() without a default: fallback, causing
"Translation missing" for the ~39 investment subtypes not in the locale files.
Now falls back to the :long label from the model's SUBTYPES hash (e.g. "457(b)",
"SEP IRA", "UGMA Custodial Account"), matching the pattern used by Accountable#subtype_label_for.

https://claude.ai/code/session_01HBJzNkvpky8mKrLkzv83Mm

* Default to single-column dashboard

---------

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Juan José Mata
2026-03-31 17:22:49 +02:00
committed by GitHub
parent 8970211476
commit 43d617661f
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/lunchflow_items_controller.rb
View File

@@ -535,7 +535,7 @@ class LunchflowItemsController < ApplicationController
# Helper to translate subtype options
translate_subtypes = ->(type_key, subtypes_hash) {
subtypes_hash.keys.map { |k| [ t(".subtypes.#{type_key}.#{k}"), k ] }
subtypes_hash.map { |k, v| [ t(".subtypes.#{type_key}.#{k}", default: v[:long] || k.humanize), k ] }
}
# Subtype options for each account type (only include supported types)

2
app/controllers/mercury_items_controller.rb
View File

@@ -539,7 +539,7 @@ class MercuryItemsController < ApplicationController
# Helper to translate subtype options
translate_subtypes = ->(type_key, subtypes_hash) {
subtypes_hash.keys.map { |k| [ t(".subtypes.#{type_key}.#{k}"), k ] }
subtypes_hash.map { |k, v| [ t(".subtypes.#{type_key}.#{k}", default: v[:long] || k.humanize), k ] }
}
# Subtype options for each account type (only include supported types)