QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-04-19 03:54:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only update account balance if changed (#1676)

Browse Source 
* Only update balance if changed

* Update test assertions
This commit is contained in:
Zach Gollwitzer
2025-01-23 21:14:01 -05:00
committed by GitHub
parent 61321f6b16
commit 43dd16e3fb
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/account.rb
View File

@@ -135,9 +135,11 @@ class Account < ApplicationRecord
end
def update_with_sync!(attributes)
should_update_balance = attributes[:balance] && attributes[:balance].to_d != balance
transaction do
update!(attributes)
update_balance!(attributes[:balance]) if attributes[:balance]
update_balance!(attributes[:balance]) if should_update_balance
end
sync_later

6
test/interfaces/accountable_resource_interface_test.rb
View File

@@ -61,11 +61,11 @@ module AccountableResourceInterfaceTest
assert_equal "#{@account.accountable_name.humanize} account created", flash[:notice]
end
test "updates account balance by creating new valuation" do
test "updates account balance by creating new valuation if balance has changed" do
assert_difference [ "Account::Entry.count", "Account::Valuation.count" ], 1 do
patch account_url(@account), params: {
account: {
balance: 10000
balance: 12000
}
}
end
@@ -81,7 +81,7 @@ module AccountableResourceInterfaceTest
assert_no_difference [ "Account::Entry.count", "Account::Valuation.count" ] do
patch account_url(@account), params: {
account: {
balance: 10000
balance: 12000
}
}
end