QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-04-19 12:04:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Properly compute credit card balance for Enable Banking accounts (#663)

Browse Source 
* fix: Properly compute credit card balance for Enable Banking accounts

* fix: Use right balance type codes

* fix: Update comment
This commit is contained in:
Alessio Cappa
2026-01-18 15:11:34 +01:00
committed by GitHub
parent f97ff419e8
commit 6ec03e93f4
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/models/enable_banking_account/processor.rb
View File

@@ -38,8 +38,12 @@ class EnableBankingAccount::Processor
account = enable_banking_account.current_account
balance = enable_banking_account.current_balance || 0
# For credit cards, compute balance based on credit limit
if account.accountable_type == "CreditCard"
available_credit = account.accountable.available_credit || 0
balance = available_credit - balance
# For liability accounts, ensure positive balances
if account.accountable_type == "CreditCard" || account.accountable_type == "Loan"
elsif account.accountable_type == "Loan"
balance = -balance
end

8
app/models/enable_banking_item/importer.rb
View File

@@ -134,9 +134,11 @@ class EnableBankingItem::Importer
balances = balance_data[:balances] || []
return if balances.empty?
# Find the most relevant balance (prefer "closingBooked" or "expected")
balance = balances.find { |b| b[:balance_type] == "closingBooked" } ||
balances.find { |b| b[:balance_type] == "expected" } ||
# Find the most relevant balance (prefer "ITAV" or "CLAV" types)
balance = balances.find { |b| b[:balance_type] == "ITAV" } ||
balances.find { |b| b[:balance_type] == "CLAV" } ||
balances.find { |b| b[:balance_type] == "ITBD" } ||
balances.find { |b| b[:balance_type] == "CLBD" } ||
balances.first
if balance.present?