Do not raise on Plaid item not found exceptions for item deletions (#1646)

app/models/plaid_item.rb

@@ -131,5 +131,7 @@ class PlaidItem < ApplicationRecord
 
     def remove_plaid_item
       plaid_provider.remove_item(access_token)
+    rescue StandardError => e
+      Rails.logger.warn("Failed to remove Plaid item #{id}: #{e.message}")
     end
 end

test/models/plaid_item_test.rb

@@ -18,4 +18,16 @@ class PlaidItemTest < ActiveSupport::TestCase
       @plaid_item.destroy
     end
   end
+
+  test "if plaid item not found, silently continues with deletion" do
+    @plaid_provider = mock
+
+    PlaidItem.stubs(:plaid_provider).returns(@plaid_provider)
+
+    @plaid_provider.expects(:remove_item).with(@plaid_item.access_token).raises(Plaid::ApiError.new("Item not found"))
+
+    assert_difference "PlaidItem.count", -1 do
+      @plaid_item.destroy
+    end
+  end
 end