QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-07-20 00:35:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Plaid sync failure for loan subtypes missing from Loan::SUBTYPES (#2298)

Browse Source 
PlaidAccount::TypeMappable maps the Plaid loan subtypes "home equity",
"line of credit", and "business" to home_equity, line_of_credit, and
business — but Loan::SUBTYPES never defined them. Linking any such
account (e.g. a HELOC reported by the institution as loan/"line of
credit") makes the item's sync fail with:

    Validation failed: Accountable subtype is not included in the list

and, because Link itself succeeded, the failure is silent in the UI
(same UX gap as #1792).

Add the three subtypes to Loan::SUBTYPES, and add a regression test
asserting every subtype emitted by TYPE_MAPPING is valid for its
accountable so the mapper and models can't drift apart again.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
BeltaKoda
2026-06-11 14:26:40 -04:00
committed by GitHub
parent 65efcbab59
commit 749d54dd96
2 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/models/loan.rb
View File

@@ -5,6 +5,9 @@ class Loan < ApplicationRecord
"mortgage" => { short: "Mortgage", long: "Mortgage" },
"student" => { short: "Student Loan", long: "Student Loan" },
"auto" => { short: "Auto Loan", long: "Auto Loan" },
"home_equity" => { short: "Home Equity", long: "Home Equity Loan" },
"line_of_credit" => { short: "Line of Credit", long: "Line of Credit" },
"business" => { short: "Business Loan", long: "Business Loan" },
"other" => { short: "Other Loan", long: "Other Loan" }
}.freeze

14
test/models/plaid_account/type_mappable_test.rb
View File

@@ -32,4 +32,18 @@ class PlaidAccount::TypeMappableTest < ActiveSupport::TestCase
assert_equal "other", @mock_processor.map_subtype("depository", nil)
assert_equal "other", @mock_processor.map_subtype("depository", "unknown")
end
test "every mapped subtype is a valid subtype of its accountable" do
PlaidAccount::TypeMappable::TYPE_MAPPING.each do |plaid_type, config|
accountable_class = config[:accountable]
next unless accountable_class.const_defined?(:SUBTYPES)
config[:subtype_mapping].each do |plaid_subtype, subtype|
assert_includes accountable_class::SUBTYPES.keys, subtype,
"TYPE_MAPPING maps #{plaid_type}/#{plaid_subtype.inspect} to #{subtype.inspect}, " \
"which is not a valid #{accountable_class} subtype — syncing such an account fails " \
"with 'Validation failed: Accountable subtype is not included in the list'"
end
end
end
end