Add transaction fee support to trades (#1248)

Add an optional fee field (decimal, precision: 19, scale: 4) to trades.
Fee is included in the total amount calculation (qty * price + fee) for
both create and update flows. The fee field appears on both the create
and edit forms, defaults to 0, and auto-submits like other trade fields.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

test/controllers/trades_controller_test.rb

@@ -111,6 +111,89 @@ class TradesControllerTest < ActionDispatch::IntegrationTest
     assert_redirected_to @entry.account
   end
 
+  test "creates trade buy entry with fee" do
+    assert_difference [ "Entry.count", "Trade.count" ], 1 do
+      post trades_url(account_id: @entry.account_id), params: {
+        model: {
+          type: "buy",
+          date: Date.current,
+          ticker: "NVDA (NASDAQ)",
+          qty: 10,
+          price: 20,
+          fee: 9.95,
+          currency: "USD"
+        }
+      }
+    end
+
+    created_entry = Entry.order(created_at: :desc).first
+
+    assert_in_delta 209.95, created_entry.amount.to_f, 0.001
+    assert_in_delta 9.95, created_entry.trade.fee.to_f, 0.001
+    assert_redirected_to account_url(created_entry.account)
+  end
+
+  test "creates trade sell entry with fee" do
+    assert_difference [ "Entry.count", "Trade.count" ], 1 do
+      post trades_url(account_id: @entry.account_id), params: {
+        model: {
+          type: "sell",
+          date: Date.current,
+          ticker: "AAPL (NYSE)",
+          qty: 10,
+          price: 20,
+          fee: 9.95,
+          currency: "USD"
+        }
+      }
+    end
+
+    created_entry = Entry.order(created_at: :desc).first
+
+    # sell: signed_amount = -10 * 20 + 9.95 = -190.05
+    assert_in_delta(-190.05, created_entry.amount.to_f, 0.001)
+    assert_in_delta 9.95, created_entry.trade.fee.to_f, 0.001
+    assert_redirected_to account_url(created_entry.account)
+  end
+
+  test "creates trade buy entry without fee defaults to zero" do
+    post trades_url(account_id: @entry.account_id), params: {
+      model: {
+        type: "buy",
+        date: Date.current,
+        ticker: "NVDA (NASDAQ)",
+        qty: 10,
+        price: 20,
+        currency: "USD"
+      }
+    }
+
+    created_entry = Entry.order(created_at: :desc).first
+
+    assert_in_delta 200, created_entry.amount.to_f, 0.001
+    assert_equal 0, created_entry.trade.fee.to_f
+  end
+
+  test "update includes fee in amount" do
+    patch trade_url(@entry), params: {
+      entry: {
+        currency: "USD",
+        nature: "outflow",
+        entryable_attributes: {
+          id: @entry.entryable_id,
+          qty: 10,
+          price: 20,
+          fee: 9.95
+        }
+      }
+    }
+
+    @entry.reload
+
+    assert_in_delta 209.95, @entry.amount.to_f, 0.001
+    assert_in_delta 9.95, @entry.trade.fee.to_f, 0.001
+  end
+
   test "creates trade buy entry" do
     assert_difference [ "Entry.count", "Trade.count", "Security.count" ], 1 do
       post trades_url(account_id: @entry.account_id), params: {

test/models/trade_test.rb

@@ -39,6 +39,19 @@ class TradeTest < ActiveSupport::TestCase
     assert_equal precise_price, trade.price
   end
 
+  test "fee defaults to 0" do
+    security = Security.create!(ticker: "FEETEST", exchange_operating_mic: "XNAS")
+    trade = Trade.create!(
+      security: security,
+      price: 100,
+      qty: 10,
+      currency: "USD",
+      investment_activity_label: "Buy"
+    )
+
+    assert_equal 0, trade.fee
+  end
+
   test "price is rounded to 10 decimal places" do
     security = Security.create!(ticker: "TEST", exchange_operating_mic: "XNAS")