QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-04-14 01:24:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move money market tickers and patterns to configuration (#712)

Browse Source 
Co-authored-by: luckyPipewrench <luckypipewrench@proton.me>
This commit is contained in:
LPW
2026-01-20 01:44:12 -05:00
committed by GitHub
parent 650f02ee2d
commit da9148c8be
2 changed files with 29 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
app/models/simplefin_account/investments/balance_calculator.rb
View File

@@ -1,22 +1,6 @@
# SimpleFin Investment balance calculator
# SimpleFin provides clear balance and holdings data, so calculations are simpler than Plaid
class SimplefinAccount::Investments::BalanceCalculator
# Common money market fund tickers that should be treated as cash equivalents
# These are settlement funds that users consider "cash available to invest"
MONEY_MARKET_TICKERS = %w[
VMFXX VMMXX VMRXX VUSXX
SPAXX FDRXX SPRXX FZFXX FDLXX
SWVXX SNVXX SNOXX
TTTXX PRTXX
].freeze
# Patterns that indicate money market funds (case-insensitive)
MONEY_MARKET_PATTERNS = [
/money\s*market/i,
/settlement\s*fund/i,
/cash\s*reserve/i
].freeze
def initialize(simplefin_account)
@simplefin_account = simplefin_account
end
@@ -67,11 +51,19 @@ class SimplefinAccount::Investments::BalanceCalculator
symbol = holding["symbol"].to_s.upcase.strip
description = holding["description"].to_s
# Check known money market tickers
return true if MONEY_MARKET_TICKERS.include?(symbol)
# Check known money market tickers (configured in config/initializers/simplefin.rb)
return true if money_market_tickers.include?(symbol)
# Check description patterns
MONEY_MARKET_PATTERNS.any? { |pattern| description.match?(pattern) }
money_market_patterns.any? { |pattern| description.match?(pattern) }
end
def money_market_tickers
Rails.configuration.x.simplefin.money_market_tickers || []
end
def money_market_patterns
Rails.configuration.x.simplefin.money_market_patterns || []
end
def parse_market_value(market_value)

18
config/initializers/simplefin.rb
View File

@@ -12,4 +12,22 @@ Rails.application.configure do
pending_env = ENV["SIMPLEFIN_INCLUDE_PENDING"].to_s.strip.downcase
config.x.simplefin.include_pending = pending_env.blank? ? true : !falsy.include?(pending_env)
config.x.simplefin.debug_raw = truthy.include?(ENV["SIMPLEFIN_DEBUG_RAW"].to_s.strip.downcase)
# Common money market fund tickers that should be treated as cash equivalents
# These are settlement funds that users consider "cash available to invest"
# SimpleFIN doesn't provide is_cash_equivalent metadata like Plaid does,
# so we detect by ticker symbol and description patterns
config.x.simplefin.money_market_tickers = %w[
VMFXX VMMXX VMRXX VUSXX
SPAXX FDRXX SPRXX FZFXX FDLXX
SWVXX SNVXX SNOXX
TTTXX PRTXX
].freeze
# Patterns that indicate money market funds (case-insensitive)
config.x.simplefin.money_market_patterns = [
/money\s*market/i,
/settlement\s*fund/i,
/cash\s*reserve/i
].freeze
end