fix(sparklines): prevent crash when trend is nil for empty series (#3171)

* fix(sparklines): prevent crash when trend is nil for empty series

* Test sparklines without trend data

---------

Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com>
Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>

app/views/accountable_sparklines/show.html.erb

@@ -5,7 +5,7 @@
     </div>
 
     <%# A previous value of zero makes the percentage infinite, with nothing useful to print %>
-    <% if @series.trend.percent.finite? %>
+    <% if @series.trend && @series.trend.percent.finite? %>
       <%= tag.p @series.trend.percent_formatted,
                   style: "color: #{@series.trend.color}",
                   class: "font-mono text-right text-xs font-medium text-primary" %>

app/views/accounts/sparkline.html.erb

@@ -5,7 +5,7 @@
     </div>
 
     <%# A previous value of zero makes the percentage infinite, with nothing useful to print %>
-    <% if @sparkline_series.trend.percent.finite? %>
+    <% if @sparkline_series.trend && @sparkline_series.trend.percent.finite? %>
       <%= tag.p @sparkline_series.trend.percent_formatted,
                   style: "color: #{@sparkline_series.trend.color}",
                   class: "font-mono text-right text-xs font-medium text-primary" %>

test/controllers/accountable_sparklines_controller_test.rb

@@ -10,6 +10,22 @@ class AccountableSparklinesControllerTest < ActionDispatch::IntegrationTest
     assert_response :success
   end
 
+  test "show renders an empty series without a trend" do
+    empty_series = Series.new(
+      start_date: 1.day.ago.to_date,
+      end_date: Date.current,
+      interval: "1 day",
+      values: []
+    )
+    Rails.cache.clear
+    Balance::ChartSeriesBuilder.any_instance.expects(:balance_series).returns(empty_series)
+
+    get accountable_sparkline_url("depository")
+
+    assert_response :success
+    assert_select "p.font-mono", count: 0
+  end
+
   test "linked investment sparkline does not load full account records" do
     AccountProvider.create!(
       account: accounts(:investment),

test/controllers/accounts_controller_test.rb

@@ -345,6 +345,21 @@ class AccountsControllerTest < ActionDispatch::IntegrationTest
     assert_response :success
   end
 
+  test "sparkline renders an empty series without a trend" do
+    empty_series = Series.new(
+      start_date: 1.day.ago.to_date,
+      end_date: Date.current,
+      interval: "1 day",
+      values: []
+    )
+    Account.any_instance.expects(:sparkline_series).returns(empty_series)
+
+    get sparkline_account_url(@account)
+
+    assert_response :success
+    assert_select "p.font-mono", count: 0
+  end
+
   test "destroys account" do
     delete account_url(@account)
     assert_redirected_to accounts_path