mirror of
https://github.com/we-promise/sure.git
synced 2026-04-12 16:47:22 +00:00
Localization for an accountable group and sidebar (#257)
* Providers factory (#250) * Implement providers factory * Multiple providers sync support - Proper Multi-Provider Syncing: When you click sync on an account with multiple providers (e.g., both Plaid and SimpleFin), all provider items are synced - Better API: The existing account.providers method already returns all providers, and account.provider returns the first one for backward compatibility - Correct Holdings Deletion Logic: Holdings can only be deleted if ALL providers allow it, preventing accidental deletions that would be recreated on next sync TODO: validate this is the way we want to go? We would need to check holdings belong to which account, and then check provider allows deletion. More complex - Database Constraints: The existing validations ensure an account can have at most one provider of each type (one PlaidAccount, one SimplefinAccount, etc.) * Add generic provider_import_adapter * Finish unified import strategy * Update app/models/plaid_account.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Update app/models/provider/factory.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Fix account linked by plaid_id instead of external_id * Parse numerics to BigDecimal Parse numerics to BigDecimal before computing amount; guard nils. Avoid String * String and float drift; also normalize date. * Fix incorrect usage of assert_raises. * Fix linter * Fix processor test. * Update current_balance_manager.rb * Test fixes * Fix plaid linked account test * Add support for holding per account_provider * Fix proper account access Also fix account deletion for simpefin too * FIX match tests for consistency * Some more factory updates * Fix account schema for multipe providers Can do: - Account #1 → PlaidAccount + SimplefinAccount (multiple different providers) - Account #2 → PlaidAccount only - Account #3 → SimplefinAccount only Cannot do: - Account #1 → PlaidAccount + PlaidAccount (duplicate provider type) - PlaidAccount #123 → Account #1 + Account #2 (provider linked to multiple accounts) * Fix account setup - An account CAN have multiple providers (the schema shows account_providers with unique index on [account_id, provider_type]) - Each provider should maintain its own separate entries - We should NOT update one provider's entry when another provider syncs * Fix linter and guard migration * FIX linter issues. * Fixes - Remove duplicated index - Pass account_provider_id - Guard holdings call to avoid NoMethodError * Update schema and provider import fix * Plaid doesn't allow holdings deletion * Use ClimateControl for proper env setup * No need for this in .git --------- Signed-off-by: soky srm <sokysrm@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com> * Update pages/dashboard locales (#255) * Localization for an accountable group and sidebar - Added localization for account types - Updated account localization for en and ca --------- Signed-off-by: soky srm <sokysrm@gmail.com> Co-authored-by: soky srm <sokysrm@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
This commit is contained in:
Albert Solà
@@ -34,7 +34,7 @@ class BalanceSheet::ClassificationGroup
|
||||
.transform_keys { |at| Accountable.from_type(at) }
|
||||
.map do |accountable, account_rows|
|
||||
BalanceSheet::AccountGroup.new(
|
||||
name: accountable.display_name,
|
||||
name: I18n.t("accounts.types.#{accountable.name.underscore}", default: accountable.display_name),
|
||||
color: accountable.color,
|
||||
accountable_type: accountable,
|
||||
accounts: account_rows,
|
||||
|
||||
@@ -6,16 +6,15 @@
|
||||
<summary class="flex items-center justify-between gap-2">
|
||||
<div class="flex items-center gap-2">
|
||||
<%= icon "triangle-alert", size: "sm", color: "warning" %>
|
||||
<p class="font-medium">Missing historical data</p>
|
||||
<p class="font-medium"><%= t("accounts.sidebar.missing_data") %></p>
|
||||
</div>
|
||||
|
||||
<%= icon("chevron-down", color: "warning", class: "group-open:transform group-open:rotate-180") %>
|
||||
</summary>
|
||||
<div class="text-xs py-2 space-y-2">
|
||||
<p><%= product_name %> uses third party providers to fetch historical exchange rates, security prices, and more. This data is required to calculate accurate historical account balances.</p>
|
||||
|
||||
<p><%= t("accounts.sidebar.missing_data_description", product: product_name) %></p>
|
||||
<p>
|
||||
<%= link_to "Configure your providers here.", settings_hosting_path, class: "text-yellow-600 underline" %>
|
||||
<%= link_to t("accounts.sidebar.configure_providers"), settings_hosting_path, class: "text-yellow-600 underline" %>
|
||||
</p>
|
||||
</div>
|
||||
</details>
|
||||
@@ -23,15 +22,15 @@
|
||||
|
||||
<%= render DS::Tabs.new(active_tab: active_tab, session_key: "account_sidebar_tab", testid: "account-sidebar-tabs") do |tabs| %>
|
||||
<% tabs.with_nav do |nav| %>
|
||||
<% nav.with_btn(id: "all", label: "All") %>
|
||||
<% nav.with_btn(id: "asset", label: "Assets") %>
|
||||
<% nav.with_btn(id: "liability", label: "Debts") %>
|
||||
<% nav.with_btn(id: "all", label: t("accounts.sidebar.tabs.all")) %>
|
||||
<% nav.with_btn(id: "asset", label: t("accounts.sidebar.tabs.assets")) %>
|
||||
<% nav.with_btn(id: "liability", label: t("accounts.sidebar.tabs.debts")) %>
|
||||
<% end %>
|
||||
|
||||
<% tabs.with_panel(tab_id: "asset") do %>
|
||||
<div class="space-y-2">
|
||||
<%= render DS::Link.new(
|
||||
text: "New asset",
|
||||
text: t("accounts.sidebar.new_asset"),
|
||||
variant: "ghost",
|
||||
href: new_account_path(step: "method_select", classification: "asset"),
|
||||
icon: "plus",
|
||||
@@ -51,7 +50,7 @@
|
||||
<% tabs.with_panel(tab_id: "liability") do %>
|
||||
<div class="space-y-2">
|
||||
<%= render DS::Link.new(
|
||||
text: "New debt",
|
||||
text: t("accounts.sidebar.new_debt"),
|
||||
variant: "ghost",
|
||||
href: new_account_path(step: "method_select", classification: "liability"),
|
||||
icon: "plus",
|
||||
@@ -71,7 +70,7 @@
|
||||
<% tabs.with_panel(tab_id: "all") do %>
|
||||
<div class="space-y-2">
|
||||
<%= render DS::Link.new(
|
||||
text: "New account",
|
||||
text: t("accounts.sidebar.new_account"),
|
||||
variant: "ghost",
|
||||
full_width: true,
|
||||
href: new_account_path(step: "method_select"),
|
||||
|
||||
@@ -53,7 +53,7 @@
|
||||
<div class="my-2">
|
||||
<%= render DS::Link.new(
|
||||
href: new_polymorphic_path(account_group.key, step: "method_select"),
|
||||
text: "New #{account_group.name.downcase.singularize}",
|
||||
text: t("accounts.sidebar.new_account_group", account_group: account_group.name.downcase.singularize),
|
||||
icon: "plus",
|
||||
full_width: true,
|
||||
variant: "ghost",
|
||||
|
||||
@@ -60,6 +60,28 @@ ca:
|
||||
manage: Gestiona els comptes
|
||||
update:
|
||||
success: "Compte %{type} actualitzat"
|
||||
sidebar:
|
||||
missing_data: Falten dades històriques
|
||||
missing_data_description: "%{product} utilitza proveïdors externs per obtenir tipus de canvi històrics, preus de valors i més. Aquestes dades són necessàries per calcular saldos històrics precisos dels comptes."
|
||||
configure_providers: Configura els teus proveïdors aquí.
|
||||
tabs:
|
||||
all: Tots
|
||||
assets: Actius
|
||||
debts: Deutes
|
||||
new_asset: Nou actiu
|
||||
new_debt: Nou deute
|
||||
new_account: Nou compte
|
||||
new_account_group: "Nou %{account_group}"
|
||||
types:
|
||||
depository: Efectiu
|
||||
investment: Inversió
|
||||
crypto: Cripto
|
||||
property: Propietat
|
||||
vehicle: Vehicle
|
||||
other_asset: Altre actiu
|
||||
credit_card: Targeta de crèdit
|
||||
loan: Préstec
|
||||
other_liability: Altra passiu
|
||||
email_confirmations:
|
||||
new:
|
||||
invalid_token: L'enllaç de confirmació no és vàlid o ha caducat.
|
||||
|
||||
@@ -63,6 +63,29 @@ en:
|
||||
manage: Manage accounts
|
||||
update:
|
||||
success: "%{type} account updated"
|
||||
sidebar:
|
||||
missing_data: Missing historical data
|
||||
missing_data_description: "%{product} uses third party providers to fetch historical exchange rates, security prices, and more. This data is required to calculate accurate historical account balances."
|
||||
configure_providers: Configure your providers here.
|
||||
tabs:
|
||||
all: All
|
||||
assets: Assets
|
||||
debts: Debts
|
||||
new_asset: New asset
|
||||
new_debt: New debt
|
||||
new_account: New account
|
||||
new_account_group: "New %{account_group}"
|
||||
types:
|
||||
depository: Cash
|
||||
investment: Investment
|
||||
crypto: Crypto
|
||||
property: Property
|
||||
vehicle: Vehicle
|
||||
other_asset: Other Asset
|
||||
credit_card: Credit Card
|
||||
loan: Loan
|
||||
other_liability: Other Liability
|
||||
|
||||
email_confirmations:
|
||||
new:
|
||||
invalid_token: Invalid or expired confirmation link.
|
||||
|
||||
@@ -56,9 +56,9 @@ class BalanceSheetTest < ActiveSupport::TestCase
|
||||
asset_groups = BalanceSheet.new(@family).assets.account_groups
|
||||
|
||||
assert_equal 3, asset_groups.size
|
||||
assert_equal 1000 + 2000, asset_groups.find { |ag| ag.name == "Cash" }.total
|
||||
assert_equal 3000, asset_groups.find { |ag| ag.name == "Investments" }.total
|
||||
assert_equal 5000, asset_groups.find { |ag| ag.name == "Other Assets" }.total
|
||||
assert_equal 1000 + 2000, asset_groups.find { |ag| ag.name == I18n.t("accounts.types.depository") }.total
|
||||
assert_equal 3000, asset_groups.find { |ag| ag.name == I18n.t("accounts.types.investment") }.total
|
||||
assert_equal 5000, asset_groups.find { |ag| ag.name == I18n.t("accounts.types.other_asset") }.total
|
||||
end
|
||||
|
||||
test "calculates liability group totals" do
|
||||
@@ -71,8 +71,8 @@ class BalanceSheetTest < ActiveSupport::TestCase
|
||||
liability_groups = BalanceSheet.new(@family).liabilities.account_groups
|
||||
|
||||
assert_equal 2, liability_groups.size
|
||||
assert_equal 1000 + 2000, liability_groups.find { |ag| ag.name == "Credit Cards" }.total
|
||||
assert_equal 3000 + 5000, liability_groups.find { |ag| ag.name == "Other Liabilities" }.total
|
||||
assert_equal 1000 + 2000, liability_groups.find { |ag| ag.name == I18n.t("accounts.types.credit_card") }.total
|
||||
assert_equal 3000 + 5000, liability_groups.find { |ag| ag.name == I18n.t("accounts.types.other_liability") }.total
|
||||
end
|
||||
|
||||
private
|
||||
|
||||
Reference in New Issue
Block a user