Localization for an accountable group and sidebar (#257)

* Providers factory (#250)

* Implement providers factory

* Multiple providers sync support

- Proper Multi-Provider Syncing: When you click sync on an account with multiple providers (e.g., both Plaid and SimpleFin), all provider items are synced
- Better API: The existing account.providers method already returns all providers, and account.provider returns the first one for backward compatibility
- Correct Holdings Deletion Logic: Holdings can only be deleted if ALL providers allow it, preventing accidental deletions that would be recreated on next sync
TODO: validate this is the way we want to go? We would need to check holdings belong to which account, and then check provider allows deletion. More complex
- Database Constraints: The existing validations ensure an account can have at most one provider of each type (one PlaidAccount, one SimplefinAccount, etc.)

* Add generic provider_import_adapter

* Finish unified import strategy

* Update app/models/plaid_account.rb

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: soky srm <sokysrm@gmail.com>

* Update app/models/provider/factory.rb

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: soky srm <sokysrm@gmail.com>

* Fix account linked by plaid_id instead of external_id

* Parse numerics to BigDecimal

Parse numerics to BigDecimal before computing amount; guard nils.

Avoid String * String and float drift; also normalize date.

* Fix incorrect usage of assert_raises.

* Fix linter

* Fix processor test.

* Update current_balance_manager.rb

* Test fixes

* Fix plaid linked account test

* Add support for holding per account_provider

* Fix proper account access

Also fix account deletion for simpefin too

* FIX match tests for consistency

* Some more factory updates

* Fix account schema for multipe providers

  Can do:
  - Account #1 → PlaidAccount + SimplefinAccount (multiple different providers)
  - Account #2 → PlaidAccount only
  - Account #3 → SimplefinAccount only

  Cannot do:
  - Account #1 → PlaidAccount + PlaidAccount (duplicate provider type)
  - PlaidAccount #123 → Account #1 + Account #2 (provider linked to multiple accounts)

* Fix account setup

- An account CAN have multiple providers (the schema shows account_providers with unique index on [account_id, provider_type])
  - Each provider should maintain its own separate entries
  - We should NOT update one provider's entry when another provider syncs

* Fix linter and guard migration

* FIX linter issues.

* Fixes

- Remove duplicated index
- Pass account_provider_id
- Guard holdings call to avoid NoMethodError

* Update schema and provider import fix

* Plaid doesn't allow holdings deletion

* Use ClimateControl for proper env setup

* No need for this in .git

---------

Signed-off-by: soky srm <sokysrm@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>

* Update pages/dashboard locales (#255)

* Localization for an accountable group and sidebar

- Added localization for account types
- Updated account localization for en and ca

---------

Signed-off-by: soky srm <sokysrm@gmail.com>
Co-authored-by: soky srm <sokysrm@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
This commit is contained in:
Albert Solà
2025-11-01 09:15:33 +00:00
committed by GitHub
parent e290e3d4a1
commit dfe60fa07d
6 changed files with 61 additions and 17 deletions

View File

@@ -60,6 +60,28 @@ ca:
manage: Gestiona els comptes
update:
success: "Compte %{type} actualitzat"
sidebar:
missing_data: Falten dades històriques
missing_data_description: "%{product} utilitza proveïdors externs per obtenir tipus de canvi històrics, preus de valors i més. Aquestes dades són necessàries per calcular saldos històrics precisos dels comptes."
configure_providers: Configura els teus proveïdors aquí.
tabs:
all: Tots
assets: Actius
debts: Deutes
new_asset: Nou actiu
new_debt: Nou deute
new_account: Nou compte
new_account_group: "Nou %{account_group}"
types:
depository: Efectiu
investment: Inversió
crypto: Cripto
property: Propietat
vehicle: Vehicle
other_asset: Altre actiu
credit_card: Targeta de crèdit
loan: Préstec
other_liability: Altra passiu
email_confirmations:
new:
invalid_token: L'enllaç de confirmació no és vàlid o ha caducat.

View File

@@ -63,6 +63,29 @@ en:
manage: Manage accounts
update:
success: "%{type} account updated"
sidebar:
missing_data: Missing historical data
missing_data_description: "%{product} uses third party providers to fetch historical exchange rates, security prices, and more. This data is required to calculate accurate historical account balances."
configure_providers: Configure your providers here.
tabs:
all: All
assets: Assets
debts: Debts
new_asset: New asset
new_debt: New debt
new_account: New account
new_account_group: "New %{account_group}"
types:
depository: Cash
investment: Investment
crypto: Crypto
property: Property
vehicle: Vehicle
other_asset: Other Asset
credit_card: Credit Card
loan: Loan
other_liability: Other Liability
email_confirmations:
new:
invalid_token: Invalid or expired confirmation link.