Revert "Make bin/rails test pass in Dev Container" to avoid side-effects (#302)

* Revert "Add dummy PLAID_CLIENT_ID and PLAID_SECRET to env (#165)"

This reverts commit 617876f140.

* Make sure Plaid tests pass withtout ENV requirements

.devcontainer/devcontainer.json

@@ -10,9 +10,7 @@
   "containerEnv": {
     "GIT_EDITOR": "code --wait",
     "GITHUB_TOKEN": "${localEnv:GITHUB_TOKEN}",
-    "GITHUB_USER": "${localEnv:GITHUB_USER}",
-    "PLAID_CLIENT_ID": "foo",
-    "PLAID_SECRET": "bar"
+    "GITHUB_USER": "${localEnv:GITHUB_USER}"
   },
   "remoteEnv": {
     "PATH": "/workspace/bin:${containerEnv:PATH}"

test/models/provider/plaid_test.rb

@@ -5,10 +5,21 @@ class Provider::PlaidTest < ActiveSupport::TestCase
     # Do not change, this is whitelisted in the Plaid Dashboard for local dev
     @redirect_url = "http://localhost:3000/accounts"
 
+    with_env_overrides(
+      "PLAID_CLIENT_ID" => "foo",
+      "PLAID_SECRET" => "bar"
+    ) do
+      Provider::PlaidAdapter.reload_configuration
+    end
+
     # A specialization of Plaid client with sandbox-only extensions
     @plaid = Provider::PlaidSandbox.new
   end
 
+  teardown do
+    Provider::PlaidAdapter.reload_configuration
+  end
+
   test "gets link token" do
     VCR.use_cassette("plaid/link_token") do
       link_token = @plaid.get_link_token(