2729 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Guillem Arias Fauste	699b0d59da	feat(ds): extract DS::ProgressRing primitive; migrate goal card (#1899) (#2112) ... * feat(savings): add savings goals Adds a standalone Savings goals feature: a piggy-bank style tracker that lets a family set a target, link one or more Depository accounts as funding sources, and log manual contributions over time. Supersedes #1569 (closed) — same intent, redesigned per reviewer + Discord feedback. What this adds: - New `/savings_goals` sidebar entry (piggy-bank icon) with index, show, state-filtered tabs (all/active/paused/completed/archived), and a 2-step modal stepper for creation (Identity → Review). - Multi-account funding via a `SavingsGoalAccount` join: a goal requires ≥1 linked Depository account (checking/savings/HSA/CD/money-market), and all linked accounts must share the goal's currency. - Tracker balance model: goal balance = SUM(contributions.amount). No auto-flow from account balances. Contributions are pure logical records and don't move money between accounts. - Manual contributions modal scoped to the goal's linked accounts. Initial contributions seeded at creation can't be deleted; manual ones can. - AASM lifecycle: active / paused / completed / archived. Hard-delete only after archive. - Status pills (On track / Behind / Reached / No date) derived from pace vs target_date. - AI Assistant tool `create_savings_goal` lets the sidebar chat create a goal end-to-end from a natural-language prompt; soft errors carry the available-accounts list back to the LLM (mirrors the existing `import_bank_statement` pattern). - Family-scoped throughout (`Current.family`-only access, account family-scoping enforced both in controllers and the AI tool). - Demo data seed wires up 4 sample goals across the Depository accounts. Intentionally out of scope (separate PRs / v1.1): - Auto-fund from budget surplus + Sidekiq cron + budget-show card. - Dashboard "Savings goals" widget. - "Behind pace" projection chart on the detail page. - `evaluate_savings_goal_feasibility` LLM tool (level-setting before create_savings_goal). - Spend-less goals inside Budgets. - Family-member-private goals (deferred investigation). * fix(savings): DS conformance pass on stepper, ring, card, status pill - StatusPill: use functional `text-success` / `text-warning` tokens with matching icon colors and `px-2 py-1`, mirroring `app/views/budget_categories/_budget_category.html.erb:29-43`. - ProgressRing: rework center text to match `_budget_donut.html.erb` (small "Saved" label, `text-3xl font-medium` headline, "of $X" underline). Stroke color now derives from goal.status (yellow when behind, blue on track, green reached, gray for no-date). - GoalCard bar: track height + transition match budget category bar (`h-1.5`, `transition-all duration-500`, `inline-size`). - Index/show layouts: render page header inline (`<h1>` + actions). The default application layout doesn't yield `:page_actions`, so the CTA + kebab menu wouldn't appear when emitted via `content_for`. - Stepper review summary: target the actual form inputs by `name` rather than relying on the `data-target` Stimulus attribute, since `money_field` puts the attribute on the wrapper. Step 1 validation scoped to the step 1 panel. - Demo generator: filter Depository accounts via `where(accountable_type: "Depository")` — Rails delegated_type generates the `depository?` predicate, not a `.depository` scope. * feat(savings): rebuild UI to match Claude Design + adopt shared donut-chart Previous savings goals UI looked nothing like the Claude Design output (see sure-design-context/design/savings-goals/project/goals/*.jsx) and the hand-rolled ring did not match the segmented D3 donut used at app/views/budgets/_budget_donut.html.erb. This rewires the surface end to end. Donut chart: - SavingsGoal#to_donut_segments_json returns the same segment shape as Budget#to_donut_segments_json: filled portion in goal color, unused remainder as `var(--budget-unallocated-fill)`. Visual identity is now the same: segmented arc with cornerRadius and gap, courtesy of the shared `donut-chart` Stimulus controller and D3. - ProgressRingComponent renders a `data-controller="donut-chart"` div with the same default-content/inner-text pattern as `_budget_donut`. Index page (matches GoalsIndex.jsx): - Page header: title + "Save toward what matters." subtitle + "New goal" primary CTA right-aligned. - Summary strip card: total saved / target, overall bar, active goals, on-track ratio, behind count. - State filter rendered as DS::Tabs-style pill nav (`bg-surface-inset p-1 rounded-lg`, white-pill active state). - Cards rebuilt: avatar (44px, rounded-xl, white initial on goal color) + name + secondary line ("N days left · by date" / "No target date" / "Completed" / "Past due"), status pill with leading dot, big $current/$target line + percent, bar in status colour, AccountStack (overlapping initials) + "N accounts" + "to go". Goal detail (matches GoalDetail.jsx): - Header: 64px avatar + h1 name + status pill + "Target $X by date · N days left" subline + Edit (outline) + Add contribution (primary) + kebab (DS::Menu for AASM transitions). - Donut-chart ring card with stats overlay. - 4-col stat row (Avg monthly, Total contributions, Target date, Started) with mono numerals and "Needs $X/mo" / "Above target pace" sub-captions where relevant. - Two-col bottom: contributions list (avatar + account · date · source · green +$amount) and funding accounts breakdown (stacked bar + per-account row with $ and % of saved). New components: Savings::AccountStackComponent (overlapping account initials with ring-2 ring-container). StatusPillComponent now uses a leading colored dot instead of an icon. GoalAvatarComponent radii match Claude Design (rounded-md/lg/xl/2xl) and white initial. Locale: new keys under savings_goals.{index.subtitle, index.summary.*, goal_card.{accounts,days_left,completed,past_due,no_target_date}, show.header.*, show.ring.{of,to_go}, show.stats.*, show.funding_balance, show.of_saved, show.notes}. * feat(savings): match Claude Design — projection chart, target-icon modal, grouped funding accounts Brings the savings goals UI closer to the Claude Design reference shared by the user. Changes: - Sidebar nav label: "Savings goals" → "Savings". - Status pill copy: "Behind" → "Behind pace" (matches Pill component from GoalsCommon.jsx). - Empty state rewritten with a large target icon, "No goals yet" heading, and the descriptive body copy from the design. Goal detail page (matches GoalDetail.jsx): - New "← All goals" back link above the header. - 2-column hero: ring card on the left (320px column), Projection card on the right. - Projection card uses a new D3 Stimulus controller (`savings-goal-projection-chart`) that draws: · saved area + line from goal creation → today (solid, primary) · dashed projection segment from today → target date (yellow when behind, green when on track) · horizontal dashed target line with label · today marker (vertical dashed line + dot) Data shape comes from `SavingsGoal#projection_payload`. - Card subtitle generates a contextual sentence ("At $X/mo you'll fall short. Bump to $Y/mo to hit it on time." / "At your current pace you'll reach this goal around Month YYYY." / "Goal reached. Nice work.") with a strong tag highlighting the actionable figure. - Stat row now shows Linked balance (sum across linked accounts) + "N accounts" sub-caption instead of duplicate "Target date" stat. New goal modal (matches the design images 2 + 3): - DS::Dialog custom header: DS::FilledIcon target glyph + title + step subtitle ("Step 1 of 2 · Goal details" / "Step 2 of 2 · Review & start") that updates as the user advances. - Connected stepper at top of body: numbered circles connected by a bar, step-1 circle flips to ✓ when complete. - Step 1 heading "What are you saving for?" + supporting copy. - Name field paired with a target glyph affordance on its left. - Target amount + Target date in a 2-col grid. - Funding accounts list now grouped by account subtype with uppercase section headers (CHECKING / SAVINGS / HSA / CD / MONEY MARKET / OTHER), each row showing avatar + name + subtype + balance. - Step 2 heading "Looks good?" + Review card (goal target + funding accounts summary + suggested monthly = target/months_remaining), and a disclosure for the optional initial contribution. - Footer: "Cancel" left text-button (closes modal) / "Back" left text when on step 2; "Continue →" or "Create goal →" right arrow button. Demo generator: Depository accounts now set `subtype` ("checking" / "savings") on the accountable so they group correctly in the modal. Tests: all green, 35 runs in the savings suite, 92 assertions. * feat(savings): rebuild index to match Claude Design - Page header: title "Savings" + "Your savings accounts and the goals you're working toward." Removed the top-right New goal button (moves into the Goals section). - Hero card: "Total in savings" with sum-of-savings-subtype balance, 30-day delta vs last 30 days (Family#savings_balance_30d_delta), 3-stat sub-row (Accounts / Active goals / Saved toward goals), and a D3 sparkline area chart on the right (new `savings-sparkline` Stimulus controller, sourced from Family#savings_balance_series). - Accounts section: lists Depository accounts with subtype = "savings" as cards (blue avatar, name, subtype, balance, "Funds N goals"). New Savings::AccountCardComponent. - Goals section header: "Goals" + "Save toward what matters." + "New goal" button right-aligned to the section (not the page header). - Removed state-filter pill nav. Active goals render in the main grid; Completed goals get a "Completed · N" divider w/ check-circle icon and their own grid below. - Goal card layout reworked: horizontal bar replaced with a 64px donut ring on the right side of the card header (ring colour tracks goal.status — yellow=behind, primary=on-track, green=reached). Pill is inline with the goal name. - Status pill copy: "Behind pace" → "Behind". - Filter bar (copied from settings/providers): search input + status chips (All / On track / Behind / No date). Hidden when ≤ 6 active goals. Powered by `savings-goals-filter` Stimulus controller — toggles `.hidden` on cards by goal name + status. - Family#savings_subtype_accounts, total_savings_balance, savings_balance_series, savings_balance_30d_delta helpers; controller computes hero payload + account-goal counts for the cards. * fix(savings): refine hero spacing, goal/account card padding, sparkline negative range - Sparkline (`savings-sparkline` controller): dropped the `Math.max(0, yMin)` clamp on the y-axis domain so negative balances (or any series that dips into negative territory) render fully instead of being cropped off the canvas. - Hero card: padding `p-6` → `p-7`, column ratio `[minmax(0,1fr)_minmax(0,1.6fr)]` so the chart breathes, min height bumped to 220px, sparkline container `h-full min-h-[200px]` so it fills the card vertically. Stats row now sits at the bottom of the text column via `mt-auto pt-6`; labels promoted to `text-xs`, values to `text-lg`. - Section vertical rhythm: outer `space-y-6` → `space-y-8`. - Goal card: padding `p-[18px]` → `p-6`. Internal gap from header row to amount line `mt-3.5` → `mt-5`. Account-row gap `mt-3` → `mt-4`. - Account card: padding `p-5` → `p-6`. - Status pill "Behind" dot: `bg-yellow-500` → `bg-yellow-600` for a warmer/ambery tone matching the Claude Design reference. - Goal card donut "behind" stroke: `var(--color-yellow-500)` → `var(--color-yellow-600)` to match the pill. * fix(savings): add bottom padding so last card clears the mobile fixed bottom-nav * feat(savings): add "ONGOING · N" + "COMPLETED · N" section dividers Same pattern as the bank-providers page's `AVAILABLE · 3` header (see `app/views/settings/providers/_search_filters.html.erb` references): small uppercase tracking-wide secondary label, separator dot, tabular count. Replaces the prior "Completed · 1" inline label with a more consistent treatment and adds an "Ongoing · N" header above the active goals grid. Name choice: "Ongoing" rather than "Active" because the grid includes both `active` and `paused` AASM states; "ongoing" reads as still-in- progress for both. Parallel to the existing "Completed" sibling. * fix(savings): bump space between ONGOING/COMPLETED header and goal grid * fix(savings): rebalance spacing — moves the gap onto the grid, not the header Previous attempt put `mb-5` on the section header so the goal grid sat ~20px below it, but that also pushed the "No goals match" empty card down because it shares the same header. Margin collapse meant the empty card's own `mt-3` was getting added to the new big header `mb`. Rework: header back to `mb-2.5`, grid gets `mt-3` of its own. Empty card keeps its `mt-3`. Both children collapse to ~12px below the header now, which matches the breathing room the empty card had before this thread of edits. * fix(savings_goals): equalize ONGOING/COMPLETED header spacing across cards and empty state Move section gap from per-child mt-3 to a single mb-4 on the header, and toggle the grid wrapper hidden when no cards are visible. The previous markup gave inconsistent ONGOING-tag-to-content distance because the empty card sat below a 0-height grid, stacking margins differently than the cards layout. * fix(savings_goals): update ONGOING count when filtering by status or search The "ONGOING · N" badge was server-rendered with @active_goals.size and never re-synced when the Stimulus filter hid cards. Add a count target and update it alongside the existing empty/grid toggles. * feat(savings_goals): replace hero card with KPI strip + differentiate empty states P1: drop the sparkline + the single mixed hero. Hero became 3 separate KPI cards (Contributed last 30d, Needs this month, Goals on track), matching the Transactions page pattern. Each KPI answers a question the user opens the page asking — saving rate, this-month action, overall health. P3: empty state copy + CTA now reflect the reason it is empty. Search returns 0 → "No goals match X" + Clear search. Chip set to non-all → "No goals match this filter" + Show all. Both → both reasons + both buttons. Drop: total_savings_balance, savings_balance_series, savings_balance_30d_delta on Family (no other consumers). Add: Family#contribution_velocity(range:). * feat(savings_goals): status pill icons + paused variant, attention-first sort, paused chip, rename "No date" to "Open-ended" P4: status pills now carry an icon alongside the colored tint (circle-check / triangle-alert / star / infinity / pause), so color is no longer the sole signal. Drop the redundant dot. P4: default sort on the active goals list becomes attention-first — behind → on_track → no_target_date → paused, alphabetical within bucket. The user opens the page and lands on the goals that need them. P5: add a Paused filter chip + render paused goal cards with opacity-75 so they read as inactive at a glance. Rename "No date" chip to "Open-ended" — clearer to non-jargon readers. * feat(savings_goals): goal card pace + status-driven footer Each card now answers "what's my next move" without clicking into the detail page. Under the amount/target row, a pace line shows actual avg contributions vs the monthly target. The footer (previously "$X left") switches by status: - behind → "Save $Y/mo to catch up" - on_track → "Last contribution Nd ago" (or "today" / "No contributions yet") - reached / completed → "Goal reached" - no_target_date → "No deadline set" - paused → "Paused" Add SavingsGoal#last_contribution_at and #last_contribution_days_ago. Both these methods and average_monthly_contribution now respect a loaded :savings_contributions association so the index page doesn't N+1. Controller eager-loads :savings_contributions + :linked_accounts. * feat(savings_goals): drop Accounts section from index The Accounts grid duplicated the sidebar account list. Removing it gives the Goals section more breathing room and the page a tighter narrative: header → KPIs → Goals. Delete Savings::AccountCardComponent, Family#savings_subtype_accounts, the @savings_accounts / @account_goal_counts controller refs, and the related locale keys. Sidebar still shows the savings-subtype Depository accounts under "Cash" — no information is lost. * feat(savings_goals/new): drop required asterisks, hide currency, collapse notes, clean footer P1 of modal refactor — visual fidelity baseline against the Claude Design reference and refactoring-ui rules. Drop required: true on name + target_amount (suppresses both the red `*` indicator and the browser-default HTML5 validation tooltip). Client-side validation moves into the Stimulus stepper in a follow-up commit. Pass hide_currency: true on the money_field so single-currency families don't see a redundant inline currency dropdown. Wrap the Notes textarea in a <details> disclosure ("Add notes (optional)" summary) so step 1 isn't padded with rarely-used fields. Drop the footer top border-subdued divider so the action row floats against the dialog's existing padding boundary. Drop the view-layer SavingsGoal::COLORS.sample fallback on hidden color field — the controller already seeds @savings_goal.color. * feat(savings_goals/new): live previewable name avatar + ghost cancel + circular header icon Replace the big square DS::FilledIcon next to the name input with a small Savings::GoalAvatarComponent that previews the goal's avatar (seeded color + first character of the typed name, updates live via new stepper#nameChanged action). Switch the modal header's target avatar from FilledIcon(size: lg, rounded: false) → (size: md, rounded: true) — matches the goal-avatar shape used elsewhere on the page. Replace the hand-rolled <button> for Cancel/Back with DS::Button variant: "ghost". Stepper now drills into the button's inner span to swap the label, same pattern already used for the Continue/Create button on the right. Drop the now-unused footerLeftLabel target. * feat(savings_goals/new): deterministic account avatar color via name hash Replace the hardcoded var(--color-blue-500) on every funding-account row's avatar with a deterministic pick from Category::COLORS based on the account name's hash. Rows now read at a glance instead of melting into one blue column. * feat(savings_goals/new): inline per-field error state in stepper Drop the top-of-form server-error banner (kept only when model.errors on :base, which is rare) and stop relying on input.reportValidity() browser-default tooltips. Stepper validates step 1 manually when Continue is clicked: - name empty → red ring on input + "Please give your goal a name." below - target_amount ≤ 0 → red ring + "Set a target amount greater than zero." - no funding account checked → "Select at least one funding account." Each error clears as soon as the user fixes the field — typing in the name field clears the name error, entering an amount > 0 clears the amount error, checking any account clears the accounts error. Drop the now-unused flashLinkedAccountsRequired() shake; replaced by the per-field error pattern. * feat(savings_goals/new): checkbox styling, visible stepper, DS::Disclosure for notes, drop redundant cancel Use Sure's .checkbox checkbox--light classes on the funding-account check_box_tag — matches transactions / entries / settings pages. Stepper line: 2px tall bg-secondary in resting state (was 1px bg-subdued which disappeared in dark mode). Step 2 inactive circle: border-secondary outline instead of bg-container-inset fill — visible in both themes. Notes collapse switches from raw <details> to DS::Disclosure for consistency with the rest of Sure's DS. Drop the footer Cancel button — the close X in the modal header already handles that, and double cancel was redundant. The footer-left slot now only renders Back (with arrow-left icon) and only on step 2. * fix(savings_goals): status pill icons inherit pill's semantic color Pass color: "current" to the icon helper so triangle-alert / circle-check / star / infinity / pause render in the same color as the pill's text (text-success / text-warning / text-secondary). The icon helper defaults to text-secondary, which made all icons grey regardless of pill variant. * fix(savings_goals/new): name field uses .form-field wrapper for floating label Drop the outer <label>Name</label> heading + label: false on the text_field, and pass label: t(...) + container_class: "flex-1" so styled_form_builder wraps the name input in Sure's standard .form-field component. Label now sits inside the input box, matching the new transaction modal pattern (and every other styled_form_with form across Sure). The avatar still sits as a sibling outside the box, flex-aligned center. * fix(savings_goals/new): stepper line uses border-secondary token bg-secondary is not a registered Sure utility, so the previous h-0.5 bg-secondary div rendered with no background — the line was just a transparent slot, barely visible in either theme. Replace with border-t-2 border-secondary on the connector div, and toggle border-inverse / border-secondary on step transition. Both classes are real Sure tokens with proper light/dark variants (alpha-black-200 / alpha-white-300 for border-secondary). * fix(savings_goals/new): notes textarea uses .form-field wrapper Passing label: false to f.text_area stripped the .form-field container, leaving a naked textarea with no border or visible label inside the DS::Disclosure. Pass a real label ("Notes (optional)") so styled_form_with wraps it like every other textarea in Sure (transactions/_form.html.erb, trades/show.html.erb, etc.). Bump rows to 3. * fix(savings_goals/new): step 2 back button inline + form-field wrappers on initial-contribution inputs DS::Button treats "hidden" as a display override class — adding class: "hidden" stripped the base inline-flex display, so when Stimulus later removed the hidden class the icon and text stacked vertically. Wrap the Back button in a hidden <div> and toggle the wrapper instead; the button keeps its inline-flex base. The Amount + From-account inputs in step 2 used label_tag + number_field_tag / select_tag directly with no .form-field wrapper, so they rendered as bare inputs (same issue Name had in step 1). Wrap each in .form-field > .form-field__body with form-field__label and form-field__input classes — matches the styled_form_with pattern used by Target amount / Target date in step 1. * feat(savings_goals/new): step 2 initial-contribution amount uses money_field Add virtual attr_accessors for initial_contribution_amount and initial_contribution_account_id on SavingsGoal so the form builder can bind to them without the model needing real columns. Replace the raw number_field_tag with f.money_field hide_currency: true so the field shows the currency symbol prefix and step-aware precision, matching the Target amount field in step 1. * feat(savings_goals/show): cleanup — drop misleading stats, hide add-contrib when reached, last-contribution recency D1 — Drop the "Linked balance" stat. It summed the linked accounts' total balances (e.g. $204K) rather than the amount saved toward the goal ($1K), so it overstated progress by ~200x. Replace with a "Target pace" card showing required $/mo. D2 — Drop the redundant "← All goals" link. The breadcrumb nav above the header already shows Home › Savings Goals. D3 — Hide the Add-contribution button on reached / completed goals. Logically you don't keep contributing after the goal is done. D5 — Add last-contribution recency to the header sub ("Last contribution 3d ago"), matching the goal card footer pattern from the index refactor. D11 — Stat row now 3 cards instead of 4 (avg monthly, total contributions, target pace). Drop the "Started" card — low-signal for new users. * feat(savings_goals/show): catch-up callout for behind goals For behind (non-paused) goals with a target_date, render a DS::Alert warning under the header surfacing the actionable insight from the index card: "Save $X/mo to catch up · Bump your monthly contribution to stay on track for <date> · [+ Add $X]". The CTA prefills the contribution flow with the target monthly amount in the button label so the user sees exactly what to commit to. Mirrors the goal-card footer pattern shipped during the index refactor — the detail page now carries the pace narrative forward instead of hiding it inside the projection paragraph. * feat(savings_goals/show): status-specific hero card + paused/archived banners D6 — Paused goals render a top info banner ("This goal is paused" + [Resume goal]) before the hero. Archived goals get the same treatment with a Restore CTA when applicable. D8 — No-target-date goals replace the empty projection chart with a focused prompt card: calendar-plus icon, "Add a target date" heading, short copy, and a "Set target date" CTA that opens the edit modal. Stops wasting the right half of the hero on an unrenderable chart. D9 — Reached / completed goals replace the projection chart with a celebration card: party-popper green icon, "Goal reached. Nice work." heading, target-hit confirmation copy, and an "Archive goal" CTA when the state machine allows it. The original projection chart still renders for behind / on_track goals with a real target_date — that's the only case where it adds value. * feat(savings_goals/show): combo monthly-pace stat card D7 — Merge the separate Avg-monthly and Target-pace cards into one wider "Monthly pace" card spanning 2/3 of the stat row. Shows actual $/mo + target $/mo inline, with a delta line below: - behind → "Behind by $X/mo" (text-warning) - on/ahead → "Above target pace" (text-success) - no target_date → "No required pace" Total contributions stays as a separate, smaller card at 1/3 width. The action pyramid finally points at the actionable stat — pace is visually primary, raw count secondary. * feat(savings_goals/show): scrollable contributions list + hide pace card for reached goals D10 — Drop the silent .limit(50) on the contributions query and put the list in a max-h-[480px] scrollable container. Goals with many contributions now show all of them without truncation, but the page stays compact via the inner scroll. Polish — reached / completed goals no longer render the combo monthly- pace card. After the goal is hit, comparing actual vs required pace is moot (and target $0/mo · Above target pace was awkward filler). Only the Total contributions card remains in the stat row. D12 (clickable contribution rows) deferred — adding a dedicated contribution detail/edit route adds enough scope to warrant its own ticket. The per-row delete X already covers the only mutation people need from this view. * fix(savings_goals/show): chart contrast, breadcrumbs, contributions list polish Chart — Sure's "text-X" / "border-X" tokens are Tailwind utility classes, not CSS custom properties, so var(--text-secondary) etc. resolved to empty inside SVG attributes. Read data-theme on draw and pass real hex colors (textPrimary, textSecondary, borderSubdued, containerBg) into d3 fills/strokes. "Target · $X" label and axis tick labels now have proper contrast in both themes. Breadcrumbs — set @breadcrumbs in the show action so the layout renders Home › Savings › <goal name> with the middle entry clickable back to the index. Matches the convention used by imports / reports / family exports. Contributions list — drop the broken divide-y divide-subdued (Tailwind divide- utilities don't pick up Sure's semantic border tokens). Switch to space-y-3 rows matching the funding-accounts breakdown component. Drop the border-b separator under the heading; the card now reads as one continuous panel. Move the delete X to hover-revealed and reserve an inert spacer for non-manual rows so the right column stays aligned. * feat(savings_goals): demo variety, breadcrumb naming, ring token, list pattern, header split, tone down behind noise Demo — extend generate_savings_goals! with three more goals to exercise status-specific UX: Wedding fund (on_track w/ 6 months of contributions matching required pace), Sabbatical (paused), Old laptop fund (archived). House downpayment gains 12 contributions so the scrollable list has real density. Total now 7 demo goals covering behind / on_track / no_date / paused / archived / reached. Breadcrumbs — set @breadcrumbs on index too (it was relying on the Rails-derived "Savings goals" label). Both views now read "Home → Savings → ..." consistently, matching the sidebar nav text and H1. Ring token — goal-card ring stroke switched from var(--color-gray-200) (a hard light color identical in both themes) to var(--budget-unallocated-fill) which is gray-50 light / gray-700 dark, matching the detail page's progress ring. Contributions list — replace the inline hover-revealed delete-X with DS::Menu kebab, matching tags/_tag.html.erb and categories/_category. Each row also gets hover:bg-surface-hover with a px-3 -mx-3 negative margin to extend the hover area across the card padding. Non-manual contributions render a 9x9 spacer so the right column stays aligned. Header sub split — drop the long "·" chain into two lines: primary fact (target / days left) in text-secondary, recency note in text-subdued underneath. Less wall-of-text. Behind noise — pill, ring, catch-up alert and projection chart already signal "behind". The Monthly-pace combo card's "Behind by $X/mo" delta no longer renders in text-warning — it switches to text-subdued so the warning palette doesn't repeat across the page. The catch-up alert stays loud because it's the primary action; the rest stays informational. CustomConfirm wired with destructive: true on the contribution delete so the confirm button gets the outline-destructive treatment. * fix(savings_goals): ring on_track color, contributions horizontal scroll, modal restored on back, chart saved fill Ring on on_track / no_target_date goal cards rendered with no progress arc — ring_color returned var(--text-primary) / var(--text-subdued) which aren't real CSS custom properties (Sure's text tokens are Tailwind utilities). Switch to var(--color-green-500) / var(--color-gray-400) which ARE CSS vars from the Tailwind palette and resolve at SVG fill time. Contributions list had a horizontal scrollbar because the rows used -mx-3 px-3 to extend the hover background, which pushed content beyond the card padding. Drop the negative-margin trick and add overflow-x-hidden to the scroll container. Rows still hover-highlight inside the card bounds. Modal cache restoration — Turbo cached pages with open <dialog> elements inside <turbo-frame id="modal">. After dismissing the new-goal modal and navigating to a goal detail page, browser back restored the cached index page WITH the dialog still in the modal frame; the dialog's Stimulus controller then ran auto-open and reopened it. Now the dialog close handler empties the parent modal turbo-frame so the cache snapshot is clean. Chart saved-fill — bump area gradient stop-opacity 0.10 → 0.22 so the contribution history is more visible against the dark canvas. Chart was rendering correctly but the white-at-10%-opacity gradient was too faint to read on top of the dashed projection. * fix(savings_goals/show): chart axis includes backdated contributions, legend uses real colors projection_payload's start_date was created_at, but demo seeds (and manual imports) can have contributions backdated before created_at — those points were getting clipped/pushed left of the chart's x-domain and the saved-series line couldn't render. Use min(created_at, earliest contribution date) so the axis spans the full history. Legend "saved" line stroke was var(--text-primary) which doesn't resolve (Tailwind utility, not CSS var) → invisible swatch. Wrap in text-primary span + stroke="currentColor". Legend "projection" line was hardcoded yellow — chart paints green for on_track goals → mismatch. Pick legend color based on goal status so it matches what the chart actually draws. * fix(savings_goals): neutral ring percent, chart start vertical-line, contribution select wrapper, deterministic account colors Ring percentage no longer takes the warning yellow tint when behind — the colored ring stroke + status pill + catch-up alert already signal the state, doubling it on the percent number was noise. Reached stays green (celebratory), everything else uses text-primary (white/dark). Chart vertical line at the left edge was the (start_date, $0) point the controller prepended to the saved series. When start_date equals the first contribution date (now common after the earlier earliest- contribution fix), this drew a vertical jump from $0 to first contribution at x=start. Skip the prepend when there's no temporal gap so the line starts at the first real point. Add Contribution modal — wrap the source-account select in the styled form-field via f.select instead of label_tag + bare select_tag. Match the rest of Sure's form controls. Also pass hide_currency on the amount field so single-currency families don't see a redundant USD dropdown. Account avatar colors — replace Ruby String#hash (randomized per process by Ruby for DoS protection) with a deterministic MD5-based pick from Savings::GoalAvatarComponent::PALETTE. Same account name now resolves to the same color across processes and across components. Apply via a new Savings::GoalAvatarComponent.color_for helper used by both the form stepper account list and the goal-card AccountStackComponent (which was hardcoding blue-500 for every avatar in the stack, hence Chase + Ally looking identical on the wedding card). * fix(savings_goals/show): contributions list + funding accounts breakdown use per-account deterministic color Both used goal.color for every account avatar, so every linked account ended up the same color as the goal. Sure's convention elsewhere (accounts/_logo.html.erb) is accountable.color (type color: Depository → purple) — but savings goals only link Depository accounts, so that would still collapse to one color. Reuse the deterministic Savings::GoalAvatarComponent.color_for(name) helper from the index card stack instead. Same account always resolves to the same color across processes, and multiple accounts on the same goal read as distinct. Funding-accounts breakdown bar at the top now also colors each segment by account so the proportions are visibly typed (not a single goal- color block). * fix(savings_goals): projection chart redraws when container resizes (Turbo navigation) After submitting a new contribution, Turbo's redirect-replace stream swaps the page; the chart's data-controller reconnects but the container's clientWidth can momentarily be 0 (parent grid hasn't laid out yet). The early-bail in _draw left the SVG empty and nothing triggered another draw, so the chart stayed blank. Add a ResizeObserver to the controller. The observer fires once the container settles into a real size and re-runs _draw, which now paints the chart correctly after the post-submit navigation. * perf(savings_goals/show): preload + memoize cut show from 17 to 5 queries - set_savings_goal: with_current_balance + includes(savings_contributions: :account, linked_accounts: []) so contributions / accounts / current balance don't re-query inside helpers and view partials - SavingsGoal#status + #average_monthly_contribution: defined?(@ivar) memoization so the 5+ callsites per show (header banner, projection_summary, donut, goal-card pace, stats_for) don't recompute the exists?/MIN/SUM triplet each time - SavingsGoal#projection_payload: sort loaded contributions in Ruby instead of running a fresh ORDER BY - SavingsGoalsController#show: replace .chronological re-query with in-memory sort over the preloaded association - funding_breakdown_for: group_by + transform_values off the loaded collection instead of an extra GROUP BY SQL - stats_for: contributions_count uses .size to read the loaded cache instead of issuing COUNT(*) * a11y(savings_goals): ARIA semantics + unique IDs + h2 hierarchy - Projection chart SVG: role=img + <title> + <desc> wired through new ariaLabelValue / ariaDescriptionValue Stimulus values. Show.html.erb passes a localized chart label and a strip_tags'd projection summary. - Progress ring container: role=progressbar + aria-valuenow/min/max + aria-label so screen readers announce "Goal 27% complete. $13,250 of $50,000 saved." instead of four disjoint spans. - Funding-account checkboxes (stepper step 1): explicit per-account id ("savings_goal_account_ids_<id>") so each row has a unique DOM id; duplicate-id HTML violation gone. - show.html.erb: <h3> -> <h2> at six section headings (celebration, no-target-date, projection, contributions, funding accounts, notes) so the heading hierarchy is h1 -> h2, not h1 -> h3. - goal_avatar + account_stack components: aria-hidden=true on the decorative wrappers; the textual goal/account name beside them is always read separately so the SR no longer prefixes every entry with the avatar initial. - New locale keys: savings_goals.show.ring.aria_label and savings_goals.show.projection.aria_label. * fix(savings_goals/new): trap Enter on step 1; add funding-accounts hint - Pressing Enter inside a step-1 input (Name, Target amount, Target date) used to fire the form-implicit-submission against the sr-only submit button, jumping straight to POST /savings_goals and skipping step 2 entirely (no initial contribution, no review). - New blockEnter action on the form re-routes Enter to next() when currentStep === 1, mirroring the Continue button. Notes textarea is exempt so newlines work. - Add an inline hint under the funding-accounts label so users know up front what the field controls; previously the only feedback was a tiny "must pick one" error after Continue. * feat(savings_goals/chart): theme-follow palette, axis format, Today + ETA labels - MutationObserver on <html>[data-theme] re-runs _draw() when the user toggles theme so the chart's hex-resolved-at-draw-time colors follow the surrounding dark/light card surface (previously stuck on initial palette until a full page reload). - Axis tick format: "%b %y" → "%b '%y" (Jan '26) to disambiguate from a day-of-month; tick divisor 110 → 80 so 375-wide mobile gets enough ticks; post-process to drop adjacent equal labels for short windows. - Today vertical line: small "Today" label above it on widths >= 320. - Projection segment: end dot in the projection color + a short-format label ("$42K" or "Short $7.9K"). Labels suppressed at < 320 width to avoid colliding with the Target line label. - New _fmtMoneyShort helper: K/M shorthand. Plain prefix; full i18n / Intl.NumberFormat tracked as a long-term follow-up. * chore(savings_goals/stepper): use Number.parseFloat / Number.NaN per Biome biome lint --write picked these up while auditing the chart changes. Pure rename, no behaviour change. * fix(savings_goals/show): dedupe ring labels, DS::Button banners, status-pill contrast - progress_ring_component: drop the in-ring "$saved / of $target" lines. The same money pair already renders directly below the ring in show.html.erb (now the single source). Inside the ring keeps only "Saved" + percent. - show.html.erb: replace 3 hand-rolled button_to CTAs (Paused banner "Resume goal", Archived banner "Restore goal", celebration card "Archive goal") with DS::Button so focus/hover/disabled match the rest of the app. variant: primary/outline, size: sm, method: :patch. - status_pill_component: swap text-success / text-warning / text-secondary to text-green-700 / text-yellow-700 / text-gray-700 so all 5 light-mode pill variants pass WCAG 4.5:1. Local override pending the upstream DS token fix tracked at we-promise/sure#1736. * fix(savings_goals/empty_state): pass return_to so user lands back on /savings_goals after adding an account The "Add an account" CTA on the no-depository-accounts empty state now appends ?return_to=/savings_goals. StoreLocation already stashes the param into session via the global before_action; the consuming side (subtype #create actions) honouring it is tracked at we-promise/sure#1766. * fix(savings_goals): use display_status for inactive goals; hide pace + projection - SavingsGoal#display_status returns :archived / :paused before falling through to the visualization status. Memoized like #status. The plain #status method keeps its meaning (visualization vs. target/pace) so callers that genuinely want "is this on track" — KPI sort, goal-card ring color, projection_payload — keep working unchanged. - Savings::StatusPillComponent: status_key uses display_status; new :archived variant (bg-surface-inset / text-gray-700 / archive icon). Previously an archived goal showed "Behind" on the detail page while the archived banner said the goal was archived — conflicting signal. - show.html.erb: paused/archived goals render a static recap card (current saved vs target) instead of the projection chart. Pace stat (avg vs required monthly) is also hidden — extrapolating "Behind by $X/mo" against a goal that isn't accepting contributions is misleading. - New locale keys: savings_goals.status.archived, savings_goals.show.inactive.{heading_paused, heading_archived, body}. - Tests cover display_status for archived / paused / active goals. * fix(savings_goals/show): stack header on mobile so long names + actions don't collide - header: flex-col on <sm (stacks title block + action group), flex-row from sm up. Action group keeps its row on desktop, wraps below the title block on phones. - Title row: flex-wrap so the status pill drops to a second line on narrow widths instead of squeezing the h1. - h1: drop truncate, use break-words + min-w-0 inside the flex chain so long names like "Investment property downpayment" wrap legibly instead of clipping to "House …" on 375px. - Action group: flex-wrap + sm:shrink-0 keeps Edit / Add contribution / kebab readable when they have to share a line with the title block at the sm breakpoint. * fix(savings_goals/show): drop row hover so the kebab's own hover registers Both the row and the kebab carried hover backgrounds (bg-surface-hover on the row, bg-container-inset-hover on the icon button). The two are near-identical shades, so the button's hover state was visually invisible on top of the row's. Removing the row hover lets the kebab be the sole affordance. * feat(savings_goals/index): collapsed Archived section + archived-aware card - Controller: @archived_goals exposes state=archived rows already pulled by the all_goals load. No extra query (sliced from the existing array). - Index template: <details> disclosure under "Completed" so archived goals are reachable from the list without cluttering the active / completed sections. Collapsed by default. - GoalCardComponent: uses display_status for the data attribute (so the card on the index reads as Archived instead of Behind), opacity-75 applies to archived too, footer_line short-circuits to "Archived" and pace_line returns nil. Matches the show-page archived semantics shipped earlier. - Locale: new savings_goals.index.archived_section.heading and savings_goals.goal_card.footer_archived. * refactor: rename Savings Goals feature to Goals User-facing rename + structural rename. Feature is now called just "Goals" everywhere — page title, sidebar nav, modal headings, flash messages, AI assistant tool. Code identifiers follow: - Models: SavingsGoal → Goal, SavingsContribution → GoalContribution, SavingsGoalAccount → GoalAccount. - Tables: savings_goals → goals, savings_contributions → goal_contributions, savings_goal_accounts → goal_accounts. FK columns savings_goal_id → goal_id. New migration db/migrate/20260511100003_rename_savings_to_goals.rb uses rename_table + rename_column; PG handles index renaming and FK redirection automatically. - Controllers: SavingsGoalsController → GoalsController, SavingsContributionsController → GoalContributionsController. - Routes: /savings_goals → /goals, nested /goals/:id/contributions (resource name shifts; old route name aliases dropped). - ViewComponent namespace: Savings::* → Goals::*. Component class names drop their redundant "Goal" prefix where the namespace already carries it: Savings::GoalCardComponent → Goals::CardComponent, Savings::GoalAvatarComponent → Goals::AvatarComponent. Others keep their names (Goals::ProgressRingComponent, Goals::StatusPillComponent, Goals::AccountStackComponent, Goals::FundingAccountsBreakdownComponent). - Stimulus controllers: savings_goal_* → goal_*, savings_goals_filter → goals_filter. Stimulus identifiers in data-controller / data-* attributes follow. - Locale keys: savings_goals: → goals: (top level), savings_contributions: → goal_contributions: (top level). All t() callers updated. - AI assistant tool: Assistant::Function::CreateSavingsGoal → Assistant::Function::CreateGoal, tool name "create_savings_goal" → "create_goal", description / response text updated. - Sidebar nav label "Savings" → "Goals". Goals/show + index page title "Savings" → "Goals". Empty goals_section heading/subtitle dropped (duplicated the page title post-rename). Original migrations create_savings_goals / create_savings_goal_accounts / create_savings_contributions remain untouched so historical replay still works; the rename migration runs on top. * perf+ux(goals): grouped state-count + friendly 404 for stale/cross-family deep links - index: STATE_FILTERS count loop replaced with single Current.family.goals.group(:state).count + per-state lookup. 5 SQL queries -> 1. - GoalsController + GoalContributionsController: rescue_from ActiveRecord::RecordNotFound -> redirect_to goals_path with a flash. Affects stale deep links AND cross-family access (previously bare 404 -> Chrome error page). Test for cross-family access updated to assert the redirect + flash key. - New locale key goals.errors.not_found. * ux(goals): unify "Open" for no-target-date status across all surfaces One status, four phrasings before this commit: - status pill: "No date" - filter chip: "Open-ended" - goal-card secondary line: "No target date" - goal-card footer: "No deadline set" Plus KPI strip sub-count: "open-ended". Pick "Open" everywhere so the status reads identically wherever it surfaces. * ux(goals/show): catch-up consolidation + confirm dialogs on archive / mark complete A — Catch-up math triple-encoding. The catch-up amount (e.g. $1,531/mo) was rendered verbatim in three places: the banner title, the projection card subtitle, and the pace stat ("target $X/mo"). Only new information anywhere was the buried "Behind by $Y/mo" delta in pace-card subtext. - Banner body now carries the delta: "...currently $Y/mo behind." - Projection sentence drops the "Bump to %{required}/mo" restatement; reduces to "At %{current}/mo you'll miss your target date." Chart aria-description benefits from the simpler phrasing too. - Pace stat drops the "· target $X/mo" sub-line. Pair becomes "$avg/mo" + "Behind by $delta/mo" — same delta now in the banner, surfaced twice intentionally (alert vs at-a-glance stat). K — Destructive transition confirms. Pause / Resume stay no-confirm (recoverable). Mark complete (irreversible via UI; no may_uncomplete? event exists) and Archive (goal disappears from active list) now wear CustomConfirm. New locale keys: goals.show.confirm_{complete,archive}_ {title,body,cta}. Locale catch_up body strings now interpolate %{delta} alongside %{date}; projection.behind drops %{required}. Controller#projection_summary still passes both keys — extras are ignored by I18n. * a11y(goals/card): scope link accessible name to title + status summary Whole card was wrapped in <%= link_to ... %>, so screen readers concatenated every nested text node into one accessible name (~60 words on a typical card: avatar initial + name + status pill + percent + balance + target + pace + accounts + footer). - Outer wrapper now <div> carrying the filter-target + goal-name + goal-status data attrs. - Inner <a> wraps only the goal name. aria-label = "<name>, <status>, <percent>% of <target>" — concise SR sentence. - `before:absolute before:inset-0` makes the inner link's hit area span the whole card so sighted users keep the existing click affordance. - Ring SVG + percent overlay marked aria-hidden (decorative — same info already in the aria-label). - New locale key goals.goal_card.aria_progress. * feat(goal_contributions/new): live impact preview below amount field Add-contribution modal previously offered zero feedback on what the typed amount would do to goal progress. Now renders "Currently X% saved (Y of Z)." at rest and updates on each keystroke to "Will bring you to X% saved (Y of Z)." or "Will reach your Z target." when the contribution would close the gap. - New goal_contribution_preview_controller.js consumes current balance + target + currency + three localized template strings as Stimulus values. Intl.NumberFormat for currency formatting (locale-correct out of the box; fallback to currencyValue prefix on environments that don't support it). - ERB form-level data-controller wires the values; amount input uses amount_data: to thread the Stimulus target / action through the money_field helper. - Locale: goal_contributions.new.preview_{zero,nonzero,reached} with {percent}, {current}, {newTotal}, {target} placeholders. * feat(goals/edit): funding-accounts editor in the edit modal Previously a user who linked the wrong account at creation had to delete + recreate the goal. Now the edit modal carries the same funding-accounts checkbox group as Step 1 of the stepper, pre-checked with the goal's current links. - GoalsController#edit loads @linkable_accounts + @currently_linked_account_ids. - #update accepts account_ids; when supplied, runs the create / update inside a Goal.transaction and syncs linked accounts via sync_linked_accounts! (set-diff: destroy_all unselected goal_accounts, create the new ones). Validates at least one account before touching goal_accounts so the user gets a clean re-render. - Removing an account preserves the goal's existing contributions — GoalContribution#account_must_be_linked_to_goal only fires on save, so historical rows stay valid. - _form_edit partial accepts new locals; edit.html.erb threads them through. - 3 new controller tests: identity-only patch leaves links intact; account_ids patch replaces the link set; empty account_ids re-renders with error. * fix(goal_contributions/preview): rename templateNonZero -> templateNonzero so Stimulus matches the data attribute Stimulus converts the JS value name templateNonZero to a kebab-cased attribute by splitting on each capital letter, giving data-...-template-non-zero-value. Rails' dataset helper converts the Ruby key :goal_contribution_preview_template_nonzero_value to data-...-template-nonzero-value (no hyphen between non and zero). Result: the Stimulus controller resolved templateNonzeroValue to "" and the preview pane went blank as soon as the user typed an amount. Renaming the JS value to templateNonzero closes the conversion gap. Verified live via Playwright: at $500 the preview reads "Will bring you to 28% saved ($13,750 of $50,000)."; at $40,000 it flips to "Will reach your $50,000 target." * feat(goals/chart): y-axis labels + horizontal gridlines Chart had no value anchor on the y-axis; users had to read the target line label to know what amount the saved line represented. Add 3 right-aligned y-ticks ($0, $25K, $50K-style K/M shorthand) plus faint borderSubdued gridlines at the same y values. Left margin widens to 44 when room allows. Mobile (<320px chart inner-width) keeps the original tight 16px left margin and skips the y-axis entirely so the short-window readout stays uncluttered. Verified live: desktop reads $0/$20K/$40K + Target $50,000; 375px viewport drops the y-axis text + keeps target line + x-ticks only. * feat(goals/show): status-aware chart variants for empty + no-target-date Empty state (goal with zero contributions) was rendering a flat-at-$0 saved series and a flat-at-$0 projection that looked broken to anyone opening a freshly created goal. Now show.html.erb branches on @goal.goal_contributions.empty? and renders a piggy-bank + "Add a contribution" CTA card before the chart card. Brand-new goals get a clean inline call-to-action instead of a misleading line at zero. No-target-date goals (target_amount set, target_date null) used to render a standalone "Set a target date" prompt card and hide history entirely. Now they render the chart with the saved history + the target horizontal line (no projection segment, no projection legend item), plus a secondary "Set target date" callout below the chart linking into the edit modal. History is informative even without a deadline. Locale: new goals.show.empty.{heading,body,cta}. * feat(goals/chart): hover crosshair + dot + tooltip Chart had no way to read the value at a specific date — users had to infer Saved amounts from line position relative to the y-axis labels added in the previous commit. - Transparent <rect> overlay covers the plot area + catches pointer. - pointermove uses d3.bisector to snap to the nearest saved series point, draws a dashed crosshair + a saved-line dot + a projection-line dot (linearly interpolated between today and target). - HTML tooltip lives inside the chart root (cleared on next _draw) showing "date / Saved: $X / Projected: $Y". Clamps to viewport so it doesn't overflow the card. - pointerleave hides everything. Pointer events unify mouse + touch — single handler covers both desktop hover and mobile tap-and-drag. No keyboard nav yet; tracked as follow-up (Stimulus controller is the right home but won't ship in this round). * feat(goals/stepper+chart): Step 2 derived projection + JS i18n + Intl.NumberFormat B — Step 2 of the create stepper used to echo Step 1 fields back at the user in three labelled rows (Funding accounts: 2 · $123,456 balance; Suggested monthly: $1,003/mo over 12 months). Replaces those rows with a single derived sentence: "Save $1,003/mo across 2 accounts to hit it on time." If no target date is set: "Set a target date to project a finish line." The previous "Suggested monthly" + "Funding accounts" rows are dropped; review block shows only Name, "$12,000 by May 11 2027", and the derived insight sentence. L — All hard-coded English templates + currency symbols in the JS controllers go through Stimulus values now: - goal_stepper_controller: new {currency, summaryWithDate, summaryNoDate, accountCountOne, accountCountOther, suggestedWithDate, suggestedNoDate} values. Money formatted via Intl.NumberFormat(undefined, { style: "currency", currency: this.currencyValue, maximumFractionDigits: 0 }). - goal_projection_chart_controller: _fmtMoney upgraded to Intl.NumberFormat (was $/€/£ ternary fallback that lost JPY/INR/CHF/...). Locale: new goals.form_stepper.step2.review.{summary_*,account_count, suggested_*}. Old funding_accounts / suggested_monthly keys retained (unused by the new ERB) so any translator paths in flight don't break. Verified live via Playwright: step-2 review reads "Save $1,003/mo across 2 accounts to hit it on time." for a $12,000 / 12-month / 2- account goal. * feat(goals/new): standalone page render when not in a Turbo frame Direct nav to /goals/new used to render the index page with an empty modal frame because the entire template was wrapped in DS::Dialog. The URL was effectively un-shareable. Branch on turbo_frame_request? — Turbo Frame requests still render the DS::Dialog wrapper (the existing in-modal flow on the index page keeps working). Non-frame requests render a standalone page-level header (h1 + subtitle + icon) followed by the form_stepper partial. Same Stimulus controller, same data-goal-stepper-modal-subtitle selector, so the stepper's subtitle update path works identically. Controller sets @breadcrumbs so the standalone variant gets the Home > Goals > New goal trail. Verified both paths via Playwright: direct GET renders standalone form with h1 "New goal" + no dialog; click-from-index opens the DS::Dialog with the stepper inside. * fix(goals/chart): drop title-tooltip, step projection cursor, dot follows projection line, collision-aware y-ticks, clean tooltip Four chart fixes in one pass. 1) Browser was rendering the <title> child as a native hover tooltip that fought with the custom crosshair tooltip. Drop <title>; use aria-label on the <svg role="img"> instead — same SR accessible name, no native tooltip side-effect. 2/3) The hover crosshair clamped at today: bisector ran the saved series, which ends at today, so future hovers stuck the dot at the last saved point. Now the controller forks: - Past hover: snap to nearest contribution via bisector. - Future hover: snap to whole-week intervals along the projection segment ([today, target_date]) and place the dot at the interpolated y on the dashed line. Movement steps cleanly week by week instead of pixel-by-pixel jitter. 4) Tooltip drops the redundant line: - Past: "<date> · Saved: $X" (no Projected — there isn't one). - Future: "<date> · Projected: $X" (no Saved — it's the future). 5) Y-axis tick label suppressed when its value falls within 5% of the target line so "$2.5K" and "Target · $2,400" stop overlapping near the right edge. Gridline stays; only the y-axis label drops. Verified live via Playwright on House downpayment goal: <title> absent, aria-label populated, past tooltip "Feb 10, 2026 · Saved: $11,750", future tooltip "Nov 29, 2027 · Projected: $32,235", neighbouring future x snaps to "Dec 13, 2027 · $32,704" (2-week jump across the snapping boundary). * ux(goals): catch-up rework, dark-mode pill contrast, color disclosure, stepper continue-right - catch_up alert: title now leads with the new info (delta) and body states the required rate. Was "Save $1,000/mo to catch up" + "Currently $750/mo behind" — confusingly double-stated. Now "Behind by $750/mo" + "Save $1,000/mo to stay on track for {date}." Locale keys swap the %{amount}/%{delta} placement. - Goals::StatusPillComponent: each variant carries a theme-dark: text override so the dark-700 text doesn't disappear against the dark-mode tinted surface. Verified in dark mode: Paused pill text is now rgb(231,231,231) (gray-200) instead of rgb(54,54,54) (gray-700). Pre-existing token contrast fix tracked at we-promise/sure#1736 stays the long-term path; this is the local workaround that doesn't drop 4.5:1 in either theme. - New goals/_color_picker.html.erb partial: <details> disclosure with current-color preview in the summary + swatch grid in the popover. Mirrors the categories form's pen-icon-overlay pattern in spirit (collapsed by default; user clicks to expand). Both _form_edit and _form_stepper render the partial; the stepper's hidden color field is replaced by the visible disclosure. - Stepper footer: change `justify-between` to `flex items-center` plus `ml-auto` on the Continue wrapper. Continue now sits right-aligned in step 1 (where Back is hidden) and stays right in step 2 with Back taking the left edge. * ux(goals/show): catch-up alert anchors all three numbers + scoped scrollbar on contributions list Alert previous pass led with delta ("Behind by $750/mo") but the user still had to reconcile that with the $1,000/mo CTA — the relationship between current pace, gap, and required rate was implicit. Make every number visible in the sentence: - Title: "Save $1,000/mo to stay on track" — leads with the action + required rate. Reduces decision load: the headline is what to do. - Body: "You're saving $250/mo today — $750/mo short of the pace to finish by September 11, 2026." — current pace + gap + deadline. User can now mentally verify: $250 + $750 = $1,000. The catch-up amount in title + body + CTA is no longer disconnected from the current pace number; the body is the bridge. Adds `scrollbar` utility (defined in app/assets/tailwind/application.css as 4px gray-300 thumb) to the contributions list container. Browser- default scrollbar was rendering as a thick dark bar in light mode on some OSes; the in-house utility renders a thin gray thumb consistently across themes. * ux(goals): color picker uses Sure's inline-disclosure pattern; drop em-dash in catch-up body Found the actual Sure pattern in app/views/accounts/_form.html.erb:27-47 ("Additional details" section in the account-creation flow): <details class="group"> <summary class="cursor-pointer text-sm text-secondary hover:text-primary flex items-center gap-1 py-2"> <%= icon "chevron-right", class: "group-open:rotate-90 transition-transform" %> ... </summary> <div class="space-y-2 mt-2 pl-4 border-l border-primary">...</div> </details> It's an inline expand (no absolute popup), chevron rotates 90° on open, body indented with a vertical primary-color rule. My previous partial was an absolute-positioned popover lifted from categories/_form.html.erb — not what Sure uses for collapsible form sections. Rewrite _color_picker.html.erb to match: chevron + color-preview disc + "Color" label in the summary; swatches in an inline indented body. Catch-up body also drops the em-dash. Was: "You're saving $X/mo today — $Y/mo short of the pace to finish by $date." Now two sentences: "Your current pace is $X/mo. You need an extra $Y/mo to finish by $date." Two short clauses, no compound separator, each conveys a single number. Frames the gap as "extra" rather than "short", which behavioral-econ research suggests reads as more attainable. * ux(goals/show): catch-up CTA pre-fills + secondary "Adjust your target" link The "Add $1,531.25" CTA used to open the contribution modal with an empty amount field — label was a hint, not a default. Now passes the catch-up amount via ?amount= and the contributions controller seeds @contribution.amount from params. One click brings the user to the modal already populated. Adds a secondary text link below the primary CTA: "Or adjust your target" → opens the edit modal (Turbo frame). Behavioural-econ choice architecture: gives the rebaseline path explicitly so users who can't realistically catch up don't feel forced into the contribution. Trade-off: lets the alert respect autonomy — commit or recalibrate, both fine. Action paralysis kept low by visual hierarchy (primary button vs muted text link). * ux(goals/show): balance-sheet-style funding widget; drop redundant stat row Lower half of the goal detail used to be: (stat row: monthly pace + total contributions) + (bottom row: contributions list + funding breakdown card). Two of those four pieces were redundant: - Total Contributions stat duplicated the count badge that already sits beside the Contributions heading below. - Monthly Pace stat repeated the same numbers the catch-up alert surfaces above and the chart subtitle reads. Adopt the dashboard Balance Sheet pattern (app/views/pages/dashboard/_ balance_sheet.html.erb) for the funding widget: inline header with total ("Funding accounts · $13,250"), thin gap-separated segment bar, color-dot legend with percent, and a bg-container-inset table with the shared `pages/dashboard/group_weight` 5-stick weight indicator + value column. New show.html.erb bottom: just two full-width sections — funding widget, then chronological contributions list. Both rendered only when the goal has contributions (matches the empty-state branch added earlier). Locale: goals.show.funding_table.{name, weight, value}. * feat(goals): extract shared color_icon_picker controller; add icon to goals; tinted avatar User requested replacing the in-house color disclosure with the categories color+icon popover. Done as a controller extraction so categories and goals share one Stimulus controller (user's option: "Extract a shared color_icon_picker_controller.js"). - `git mv` app/javascript/controllers/category_controller.js to color_icon_picker_controller.js. Categories form + color_avatar partial updated to use the new identifier (data-controller= "color-icon-picker", target/action selectors renamed). - Goal model gains an icon column (migration 20260511190000_add_icon_to_goals.rb) + ICONS = Category.icon_codes + inclusion validation. GoalsController permits :icon in goal_params + goal_update_params. - Goals::AvatarComponent now renders icon when present (falls back to first-letter initial), and adopts the Categories tinted-bg + colored -content style (bg = `color-mix(in oklab, COLOR 10%, transparent)`, text/icon = COLOR). Matches the picker's live preview so what the user sees during selection equals the saved state. - New goals/_color_picker.html.erb mirrors categories/_form's popover: avatar + pen overlay summary + popup with color row (+ rainbow custom-hex trigger) + icon grid. Pickr / contrast validation / auto- adjust all inherited from the shared controller. - Stepper step 1 layout: drop the inline letter-avatar (data-goal- stepper-target="avatarPreview") in favour of the picker avatar next to the name input. Step 1's tail no longer renders a separate color partial. Edit form passes icons local through. Verified live: new goal modal renders 11 color radios (10 presets + custom) + 141 icon radios + pen-summary; categories form still operational (no console errors) under the renamed controller. * chore: drop session-artefact audit-shots + audit markdown from branch These local-only audit screenshots + the report draft were staged inadvertently in the previous commit. They belong to the development session, not the feature branch. * ux(goals): picker stacked above name field (stepper + edit) Previously sat next to the name input via `flex items-start gap-3` so the picker avatar competed with the input for horizontal space. Move to its own row, centered (`flex justify-center`), positioned just before the name field. Mirrors the categories form layout where the avatar is the focal element above the name input. Same change applied to the edit form: picker comes first, then name. Stepper step 1 order is now: heading · picker · name · amount/date · funding accounts · notes. * fix(goals): theme-aware avatar text contrast; compact picker popup Avatar letter/icon now uses `--avatar-color` CSS variable + the new `.goal-avatar` class. Light mode darkens the text to 55% color + 45% black so pale palette entries (cyan-300, green-300) stay readable on the 10%-mix tint over white (~4.5:1). Dark mode reverts to the full brand color via [data-theme="dark"] .goal-avatar override so the text doesn't disappear against the near-black tinted surface. Verified live: #805dee renders as a darker oklab in light mode and full rgb(128,93,238) in dark mode. Picker popup compacted: - 80 (320px) wide, max-h-[60vh] overflow-y-auto so it never spills off-screen. - Anchored below the avatar + horizontally centered to it (top-full left-1/2 -translate-x-1/2) so it doesn't drift off to the right edge of the form on narrow modals. - Icon grid max-h-40 (160px, ~5 rows) with the in-house `scrollbar` utility for a thin gray thumb that works in both themes. - Section headers (Color / Icon) styled `uppercase tracking-wide` for visual hierarchy. Verified popup at 320x310px in edit modal, no vertical overflow. * fix(goals/avatar): icon helper clash crashed show after saving an icon Goals::AvatarComponent had `attr_reader :icon` which shadowed the global `icon` view helper. Template called `icon(icon, size:, color:)` which Ruby resolved against the attr-reader (zero-arity), throwing "wrong number of arguments (given 2, expected 0)" the moment a goal had a saved icon and the show page tried to render its avatar. - Drop `:icon` from attr_reader; expose as `icon_name` instead. - Template uses `helpers.icon(icon_name, ...)` matching the Goals::StatusPillComponent pattern (other Goals VCs already use `helpers.icon`). Reproduced + verified live via Playwright: edit modal → pick an icon → save → show page renders the new avatar with the SVG. Same for create flow (new modal → pick icon → step 2 → submit → show renders). * fix(goals/chart): suppress projection-end label when it collides with target Issue: an on-track goal whose projected end is just above the target showed two right-anchored labels stacked on top of each other — "Target · $2,400" and the projection-end short value "$2.4K". The projection dot already conveys "you'll hit the target on time"; the extra label adds noise. Now: when willHit AND |projDotY - y(targetAmount)| < 18px, skip the projection-end label entirely. The colored dot at the target_date keeps the visual cue. Also refactor the y-axis label collision check from value-based (within 5% of yMax) to pixel-based (within 18px of target's y), matching the projection-end logic. When a y-tick is close to target, the Target label drops into the y-axis column at that row (short format) instead of right-edge full format. Either way, no two labels ever stack within 18 vertical px. Verified live: Wedding fund (on_track, projection ≈ target) → just "Target · $2,400" + y-ticks, no "$2.4K". House downpayment (behind) → "Target · $50,000" + "Short $12.3K" both retained (well separated). * fix(goals/chart): redraw on turbo:render so the chart survives morph navigation Repro: index -> goal show (chart drawn) -> open edit modal in turbo frame -> pick a new icon -> submit. Server responds with turbo_stream.action(:redirect, goal_path). Turbo morphs the show page, wiping the chart container's children, but Stimulus' connect() isn't re-run on the morphed element so _draw never fires again. The ResizeObserver doesn't help — the container's box dimensions are unchanged. Listen for turbo:render and turbo:frame-load on document and re-draw when the container's SVG is missing. Cheap idempotent check (querySelector('svg')) — no-op if the chart is already there. Listeners cleaned up in disconnect(). Verified: same flow now lands on the show page with the chart fully rendered (23 SVG children). * docs(goals): add architecture decision discussion note Captures the open question on the data model behind Goals (account-linked vs free-form ledger vs tag-based) for community review before PR #1757 merges. * docs(goals): split architecture note into user-facing + mechanics The user-facing note focuses on how a Goal's balance gets computed and what changes for the user. The mechanics doc covers the schema, pro-rata math, pace window, and the operational details engineers need but most readers don't. * docs(goals): final architecture cut after 5-iteration expert review User-facing doc and mechanics companion converged on an account-linked model with a pledge layer. Surfaces the pledge-with-7-day-match mechanic, proportional-to-remaining-need split default, "Reserved beyond balance" framing, in-chart pending segment, two-clock rate limit, archive-in-place account handling, months-of-runway for open-ended goals, and the pre-launch user tests + day-one pledge instrumentation. * docs(goals): expand matrix coverage + ground mechanics in current code User-facing doc gains explicit 1xM (one goal, multiple accounts), N goals on shared accounts, and overlap (NxM) sections, plus the reallocation flow and "why is this goal behind?" diagnostic. Mechanics doc is rewritten against the actual code on the branch: file:line citations for current state, accurate corrections to the prior draft (Sure uses Account AASM status not archived_at, no Account#balance_at method, balance history via Balance::ChartSeriesBuilder CTE, Transaction::TRANSFER_KINDS for pace exclusion, advisory-lock pattern lifted from IdentifyRecurringTransactionsJob, partial-unique index precedent from entries[external_id, source]), concrete migration plan with seven steps, surface-by-surface STAY/CHANGE/DELETE verdict on every component, view, and Stimulus controller, day-one instrumentation events, and four pre-launch user tests. * feat(goals): v2 architecture — drop ledger, derive balance, add pledge Reshape the goals feature to live on top of linked-account balances. A goal's balance is now the live balance of every depository account linked to it — no parallel ledger, no "log a contribution" step. The "Add contribution" affordance is replaced by a 7-day GoalPledge (kind: transfer | manual_save). GoalPledge::Reconciler matches incoming Transactions (via Account::ProviderImportAdapter) and Valuations (via Account::ReconciliationManager) against open pledges within ±5 days, ±$0.50, or ±1% — single hook covers every provider (Plaid, SimpleFIN, Lunchflow, Enable Banking, Brex, IBKR, Kraken, SnapTrade) plus manual balance edits. A 15-minute Sidekiq cron sweeps expired pledges. Goal model: balance derived from linked_accounts.sum(&:balance), new pace (90-day net non-transfer inflow), months_of_runway, last_matched_pledge_*, pledge_action_label_key (the "I just transferred…" vs "I just saved…" verb switch). UI: - Index gets a 3-card KPI strip (Contributed last 30d / Needs this month / On track) plus a pending-pledges callout. - Show page swaps the "Add contribution" CTA for the pledge modal, replaces the contribution list with a pending-pledge banner, and rebuilds the funding widget into per-account rows with a 12-bucket weekly sparkline and last-30 inflow. - Projection chart adds a required-line (dashed light from today → target) and a translucent pending-pledge bump at today's X. Schema (3 migrations): 1. goal_pledges table with PG enums (goal_pledge_kind, goal_pledge_status), open-by-expiry index, and unique-when-not-null matched_transaction_id. 2. Drop goal_contributions. 3. Partial unique index on transactions ((extra -> 'goal' ->> 'pledge_id')) built CONCURRENTLY so it doesn't block prod. After pulling: run bin/rails db:migrate, then commit the schema.rb sync separately (or let CI regenerate). Deferred to v1.1: allocation columns, contention/archived banners, "why is this behind?" diagnostic, reallocate flow, refresh-sync + Plaid throttle, unallocated-cash chip, joint-account approval, goal_activities log, polymorphic matched_entry_id/type for manual pledge audit. * fix(goals): CI green — schema, brakeman, pledge modal, error class Regenerate schema.rb after the three v2 migrations so CI's db:schema:load picks up goal_pledges, the dropped goal_contributions, and the partial unique pledge_id index. Brakeman: - Drop :account_id and :kind from goal_pledge permit; look the account up via @goal.linked_accounts.find_by(id:) instead and set kind server-side from goal.any_connected_account?. - Rename goals.show.projection.on_track to .on_track_html so I18n marks the result html_safe automatically; drop the unconditional .html_safe call in show.html.erb. Pledge modal: rewrite app/views/goal_pledges/new.html.erb to use DS::Dialog (the Sure convention for create modals — matches categories/transfers). Error handling: replace `raise ActiveRecord::RecordInvalid, "string"` in GoalPledge#extend!/cancel! with a dedicated GoalPledge::NotOpenError; the controller rescues that specifically. Tests: rewrite the "pace is zero" test to create a fresh account with no entries (the fixture's depository accounts carry transaction history that produces a non-zero pace). All goal tests now green (73 runs, 157 assertions, 0 failures). * fix(goals/pledge): drop find_each-incompatible order in reconciler The explicit .order(created_at: :asc).find_each emitted an AR warning that broke the strict logger mock in BrexEntry::ProcessorTest. find_each forces its own primary-key order anyway. * ux(goals/index): restore prior-30d comparison + multi-part on-track subtitle The v2 rewrite dropped the velocity_delta_percent / velocity_direction keys that powered the 'Contributed last 30d' card's '↑ 27.2% vs. prior 30d' line and the 'Goals on track' multi-part subtitle ('1 behind · 1 paused'). Restore both, sourcing velocity from Family#savings_inflow_velocity with explicit current-window and prior-window ranges. * fix(goals): pledge lifecycle + connected-account detection Behavioural fixes touching Goal, GoalPledge, the reconciler and the goals controller. No schema change. B5 — connected-account detection covered only Plaid. SimpleFIN, Brex, Enable Banking, IBKR, Kraken, SnapTrade and Lunchflow users got "manual_save" pledges by default; their auto-synced Transactions then failed to match (reconciler matches Transactions to "transfer" pledges only). Pledges sat in the yellow banner until expiry. Switch the detection to !Account#manual?, which mirrors the existing `Account.manual` scope (no account_providers, no plaid_account_id, no simplefin_account_id). Add `Account#manual?` so the per-instance and per-query checks can't drift. B7 — `extend!` widens `expires_at` but `matches?` was anchored on `created_at ± 5d`, so an extension that pushed the expiry past day 5 didn't actually buy any match runway. Widen the upper bound to `max(created_at + 5d, expires_at)`. The lower bound stays at `created_at − 5d`. B8 — `Goal#open_pledges` returned `status: open` regardless of expiry. Between a pledge timing out (day 7) and the 15-min sweep job marking it `expired`, the show page rendered a ghost yellow banner with "0 days left" that the reconciler would no longer touch. Add `expires_at >= NOW` to the scope so the visible state matches the match-eligible state. B9 — Double-click on Record pledge produced two identical open pledges, which then stacked as two yellow banners. Add a create-time validation rejecting duplicates against (goal_id, account_id, amount, status=open, expires_at >= NOW). B10 — The reconciler used `transaction.with_lock` but didn't lock the pledge. Two concurrent reconcile attempts on different transactions could both target the same pledge; one would lose to the partial unique index on `transactions.extra->'goal'->>'pledge_id'` and the RecordNotUnique was caught by the outer StandardError rescue, which silently dropped the other transaction's match attempt entirely. Lock the pledge first, re-check `status_open?` inside the lock, and catch RecordNotUnique alongside RecordInvalid/NotOpenError in the reconciler — so on a lost race we fall through to the next candidate pledge instead of exiting the loop. Extract the Valuation-match path to `GoalPledge#resolve_with_valuation!` so it goes through the same locked status-recheck. B12 — When a goal is destroyed, `dependent: :destroy` reaped pledges but left `transactions.extra["goal"]["pledge_id"]` pointing at the now-deleted UUIDs. The partial unique index on that JSON path then indexed stale references. Add a `before_destroy` on GoalPledge that clears the matching transaction's `extra` if it still points back to the pledge. B6 — `last_matched_pledge_at` used `goal_pledges.maximum(:updated_at)` on matched rows. Any backfill or sync-resync that touches a matched pledge bumped `updated_at`, so a single resync set every goal's "Last saved N days ago" header back to "today". Switch to the entry's `date` via a join through `matched_transaction_id`, which reflects the date the money actually moved. B22 — `scope :chronological` ordered DESC, the opposite of what the name promises. Rename to `:reverse_chronological` and update the one caller in `goals#show`. (Other models' `chronological` scopes are unrelated and ordered correctly.) Also: preload `account_providers` on `linked_accounts` in the index and show controllers so `Account#manual?` walks the in-memory collection instead of triggering N queries. Tests: add fixture-backed coverage for extend-widens-match-window, post-extend rejection beyond expiry, and the duplicate-pledge validation. Existing assertions still hold against the new `matches?` window math. * fix(goals): pace counts transfers, family rollup currency-scoped Two semantic shifts in V2 that drove the worst on-screen confusion. B3/B4 — `Goal#pace` excluded `Transaction::TRANSFER_KINDS`. When a user tapped "I just transferred…" and the deposit landed, the linked account's balance went up but pace did not: pace ignored transfer- kind entries, so the goal stayed `:behind` against `monthly_target` and the catch-up callout kept demanding $X/mo even though the user had just moved the money in. Same root cause hit any long-time saver whose 90-day net was zero — pace=0, status=:behind, projection says "At $0.00/mo you'll miss your target date" while the ring sits at 80%. Drop the transfer-kind exclusion. Pace is now net inflow into linked accounts over 90 days. Transfers between linked accounts already net out (both legs land inside the same account set); transfers from outside (checking → linked savings) net positive, which is exactly the case the pledge flow records. B19 — `Family#savings_inflow_velocity` summed entry amounts across every depository account linked to any goal regardless of currency, then rendered the result in the family's primary currency. A family with one USD goal and one EUR goal saw `usd_inflow + eur_inflow` reported as USD with no FX conversion. Scope the account set to the family's primary currency until proper FX-conversion lands. Also let the result go negative (net outflow) — clamping to ≥0 lost signal; the controller decides how to render the sign. V20 (controller) — `velocity_30d_sign` was wired off the *delta* direction, so a $1,234 down-month rendered as "−$1,234 ↓ 27% vs prior 30d". The minus read as a loss but $1,234 was the (positive) contribution. Re-wire the headline sign off the headline value itself; the delta-direction stays on the subline as ↑/↓ N%. With the family-rollup change above, the headline can now legitimately be negative — UI now says "−$200 ↓ 50% vs prior 30d" when the family had net outflow. B21 — KPI tile `on_track_count` lumped `:reached` goals into "on track", inflating the numerator while the sort order placed reached goals at the bottom of the list. Split `reached_count` out and render it as its own segment in the on-track subline ("1 reached · 1 behind · 1 paused"). Test: rename the pace=zero test to match its new premise (no transactions vs. no non-transfer entries). The fixture still has no entries, so the assertion holds. * fix(goals/ds): replace hand-rolled yellow banners with DS::Alert The pending-pledge banner on goals#show and the pending-pledge callout on goals#index were inlined yellow divs: bg-yellow-50 dark:bg-yellow-950/30 border-yellow-200 \ dark:border-yellow-800 Raw color tokens violate the "functional tokens only" rule in CLAUDE.md ("`text-primary` not `text-white`, `bg-container` not `bg-white`"), drift from the DS warning palette (`bg-warning/10` + `border-warning/20`), and miss accessibility plumbing (aria role, sr-only variant label) that DS::Alert provides for free. Swap both surfaces for `DS::Alert.new(variant: "warning", live: :polite)`: - Index callout: a one-line message variant (no title). - Show banner: title + body + footer with DS::Button (outline Extend, ghost Cancel). Cancel button gets a CustomConfirm dialog — the V2 affordance destroyed the pledge on a single click with no second-chance prompt; one accidental click and the user lost the record. The Extend / Cancel buttons drop the hand-built `text-xs px-2.5 py-1 rounded-md shadow-border-xs bg-container` styling, picking up DS::Button's `outline` / `ghost` variants and `size: "sm"` instead. Locale: tighten the title from "Pending: $200 into Savings" + separate body line "… $0.50 or ±1%) · 6 days left." to "Watching for $200 into Savings · 6 days left" with a short body ("Auto-confirms when Sure spots a matching deposit on the next sync"). The old copy was ~130 chars and wrapped 2-3 lines inside the banner flexbox, pushing the catch-up callout below the fold on common viewports. Drop the hardcoded "$0.50" from the body (currency-aware copy lands in Commit I). Add `confirm_cancel_{title,body,cta}` strings for the CustomConfirm dialog. * fix(goals/funding-widget): restore DS-aligned per-account breakdown V2 rebuilt the funding widget around per-account rows + a custom SVG sparkline, but cut visible signal and DS adherence in the process. This rebuild restores the V1 affordances and folds in the V2 sparkline as an enhancement. - Heading regression: `text-lg font-medium` (with total in `text-lg`) → `text-sm font-medium` (total inheriting `text-sm`). The section heading collapsed to body-copy size and no longer matched the Projection heading beside it. Restore both to `text-lg`. - Avatar regression: V2 hand-rolled `w-10 h-10 rounded-full … style="color: white"`. That box (40px) matches no `Goals::AvatarComponent` size (sm=24px, md=36px, lg=44px), uses `rounded-full` where the DS uses `rounded-md/lg/xl/2xl`, and hardcodes white text instead of the `text-inverse` token. Render `Goals::AvatarComponent` directly at `size: "sm"`. - Privacy regression: `row[:balance_money]` subline ("Depository · $3,000") wasn't wrapped in `privacy-sensitive`. Blur mode no longer hid the balance, while heading total and last-30d value on the same row both had the class. Add `privacy-sensitive` to the subline. - Untranslated leak: `<%= account.accountable_type %>` printed the raw "Depository" / "Investment" / "Crypto" class string with no i18n. Add `accountable_label(account)` on the component that prefers the depository subtype ("Savings", "HSA"…) via `goals.form_stepper.step1.subtypes.*`, falling back through `accounts.types.*` and finally a `titleize`. - Lost weight signal: V1 had a stacked distribution bar across the top, colored legend dots, and a 5-bar weight pill per row. Users could see "Account A contributes 60% of balance" at a glance. V2 deleted all three. Restore the distribution bar + legend + the existing `pages/dashboard/group_weight` partial in a `weight` column (skipped when only one account is linked). - Lost container framing: V1 wrapped rows in `bg-container-inset rounded-xl p-1` with `shared/ruler` dividers between rows. V2 used `space-y-3` with no container and no dividers, leaving rows floating. Restore both. - Empty state regression: V2's fallback rendered the section heading as a body paragraph (`<p>Funding accounts</p>`) inside a `p-5 rounded-xl` card — looked like an unfinished widget. Replace with a real empty state via `goals.show.funding_accounts. empty.heading` + `body` ("Edit the goal to link the depository accounts you save into."). - Row order: V2 sorted by 30-day inflow (which can flatten to ties at $0 across rows). Sort by balance instead — the column the user is comparing against anyway. - Pace alignment: drop the transfer-kind exclusion from the component's `last_30_inflow_for` and `sparkline_for` so the widget reads the same flow as `Goal#pace` (commit B). Internal transfers between linked accounts net out per-account here too, external transfers count as inflow on the receiving account. The 12-bucket sparkline still runs 12 queries per account; that N+1 lands in a follow-up commit alongside the component-level query collapse. * fix(goals/pledge-modal): use StyledFormBuilder + restore live preview V2 rebuilt the pledge create modal but bypassed the DS form helpers inherited from `StyledFormBuilder`, lost the inline impact preview from V1's contribution form, and shipped a goal-level "transfer vs manual_save" toggle that broke on mixed-funding goals. - Manual `form-field/__body/__label/__input` div-wrapping for the account select → idiomatic `f.select :account_id, choices, { label: t(".account_label") }`. The builder applies the required marker, error state, and inline-label handling automatically; the hand-built version drifted from that path and applied `form-field__input` directly onto the select element, where the builder picks the correct input class per field type. - Hand-rolled `<div class="form-error">` + `<p>` loop for errors → `render "shared/form_errors", model: @pledge` (the shared partial with the destructive-icon prefix). Matches V1's contribution modal and the rest of the codebase. - Drop `class: "btn btn--primary"` on `f.submit` → bare `f.submit t(".submit")`. The builder's `submit` is wired to `DS::Button.new(text:, full_width: true)`; the explicit class was redundant. - Drop the duplicate "Cancel" button. DS::Dialog already renders an X in the header; the in-form ghost Cancel was a second close affordance with no analogue in the new-goal stepper or V1's contribution form. - Drop `data: { turbo_frame: "_top" }` on submit. Success already flows through the controller's `turbo_stream.action(:redirect, …)` and on 422 the modal frame is the right swap target; the explicit `_top` was at best redundant and at worst a future Turbo footgun. - Wire `data-controller="goal-pledge-preview"` on the form and add an inline preview `<p>` below the amount field. As the user types the amount, the line updates to "Reaches 75% — $3,750 of $5,000." or "Hits your $5,000 target — goal reached." Mirrors V1's contribution preview that V2 dropped on the floor. - Rename `goal_contribution_preview_controller.js` → `goal_pledge_preview_controller.js`. Pure rename; the controller was already domain-neutral. - Per-account pledge kind. The controller's `default_kind_for(goal)` picked `transfer` whenever the goal had ANY connected account — meaning a goal that linked a Plaid checking account AND a manual cash envelope routed every pledge as `transfer`, including those the user submitted against the manual account. The reconciler would then watch for a Transaction that never arrives. Replace with `kind_for_account(account)` that picks per-account: manual → `manual_save`, anything else → `transfer`. - `new` action now respects `?account_id=…` query params and preselects that account (helpful for the catch-up callout's inline "Save $X/mo" CTA, which can target a specific account). Locale: drop the hardcoded "(±5 days, ±$0.50 or ±1%)" tolerance copy from the helper text — that detail belongs in docs, not in a modal that fires on every pledge create. Currency-aware copy lands in commit I. Drop the now-unused `cancel:` key. Add the three preview templates (`preview_zero`, `preview_nonzero`, `preview_reached`) consumed by the Stimulus controller. * refactor(goals/show): move projection_summary + catch_up_delta to model The show template carried a 17-line `if/elsif` chain computing `projection_summary` inline, plus a `Money.new([…, 0].max, …)` expression building the catch-up delta on the fly. CLAUDE.md's "skinny controllers, fat models" convention pushes both onto Goal. - `Goal#projection_summary`: returns the localized, `html_safe`-aware string for the chart subtitle and the chart's `aria-description`. Memoized so the two callsites in show.html.erb share one computation. - `Goal#catch_up_delta_money`: clamped-at-zero monthly delta between pace and the required monthly target. Used by the catch-up callout body. Previously the view computed `Money.new([req - pace, 0].max, currency)` — same math, but duplicated inline. show.html.erb drops both blocks and reads `@goal.projection_summary` / `@goal.catch_up_delta_money` directly. Also: V15 — the celebration card used `bg-green-500/10` directly. Swap to `bg-success/10` (DS semantic token, same Tailwind-4 alpha syntax DS::Alert already uses) so the celebration palette tracks the rest of the success surface. * perf(goals/funding-widget): collapse N+1 sparkline + last-30 queries V2's funding widget ran (12 + 1) queries per linked account on the goals#show render: - one `last_30_inflow_for(account)` summed over a 30-day range, - twelve separate `sparkline_for(account)` sums, one per 8-day bucket inside a 90-day window. For 3 linked accounts, that's 39 SQL queries from this component alone before the projection chart's Balance::ChartSeriesBuilder runs. Replace with two grouped queries that scan once across all linked accounts: - `last_30_inflow_map`: a `GROUP BY account_id` over the 30-day window, returning a hash `{ account_id => clamped_inflow }`. One query, no matter how many accounts are linked. - `sparkline_map`: a `GROUP BY account_id, LEAST(GREATEST((CURRENT_DATE - entries.date) / bucket_days, 0), 11)` over the 90-day window. One query covers every account × every bucket. Each per-account array is filled in oldest → newest order so the SVG path reads left → right naturally. Net query count for the funding widget drops from 13 × N to 2. Both helpers fall through to safe defaults (`0`, all-zeros array) on missing keys so the row loop stays branch-free. * chore(goals): drop dead V1 hooks + surface chart errors Loose ends from the V1 → V2 refactor that the architecture commit didn't sweep. - Demo generator (B14): the `goal_spec[:contributions]` arrays + the `wedding_contribs` / `house_contribs` builders still shipped in the file, but the seeding loop that consumed them was deleted alongside `GoalContribution`. Dead data. Strip both the per-goal arrays and the two locals. Goal balance/pace in the demo family now derives from the linked depository accounts' own seeded entries elsewhere in the generator. - Goal stepper controller (B16): the `static targets` declaration still listed `initialContributionAmount` and `initialContributionAccountSelect`, and `refreshAccountSelect` + its two callsites still ran every time a linked-account checkbox flipped. The HTML targets disappeared with the V2 stepper rebuild, so `has*Target` guards short-circuited and the method was a no-op — but it was still dispatched on every change. Drop the targets, the method, and the two callsites. - Chart series rescue (B25): `Goal#balance_series_values` and `FundingAccountsBreakdownComponent#sparkline_map` both swallowed `StandardError` with a `Rails.logger.warn(…)`. The chart then degraded to "target line only" silently. Promote the log to `error` level and forward to Sentry when present (matching the pattern in `Account::Syncer`, `Sync`, `PlaidItem`). Fallback to empty result still preserved so the surface degrades instead of 500-ing. * fix(goals): header CTA + projection-chart required-line color V6 — three "Record pledge" affordances on goals#show (header, empty state, catch-up callout) all rendered as `t(@goal.pledge_action_ label_key)` + `icon: "arrow-up-right"`. That dropped the user into a button labelled "I just transferred…" or "I just saved…" with a trailing ellipsis — past-tense as a CTA reads as a status declaration, the ellipsis suggests an unresolved action, and `arrow-up-right` is the icon Sure reserves elsewhere for external-link affordances. Switch the on-page CTA to a single new locale key, `goals.show.record_pledge_cta: "Record pledge"`, with `icon: "plus"` matching the other "new resource" buttons across the app (new goal, new account, new rule). The modal title keeps using `pledge_action_label_key`, so the past-tense "I just transferred…" framing still anchors the dialog's confirm step. V8 — the projection chart's "required" dashed line was hardcoded to `var(--color-green-600)`. When the goal status is `:on_track` the projection line is also green-dashed, and the two stroked the same hue and dash pattern — they overlapped visually. Re-stroke the required line in `textSecondary` (the chart's neutral foreground) so it reads as a reference path independent of status. * fix(goals/show): add Required line to projection legend The dashed neutral line for "the rate needed to hit the target by the target date" was rendered on the chart but absent from the legend. Adds a third legend chip ("Required") that renders only when the line itself renders — i.e. when target_date is set, monthly_target_amount is positive, and there's still ground to cover (remaining_amount > 0). Stroke matches the JS: `text-secondary` currentColor, dasharray 2/4, 0.5 opacity. * fix(goals/funding-widget): switch sparkline to bars + shared scale The shared-scale fix alone wasn't enough — a single outlier bucket on one account compressed every other row to invisibility, and the interpolated line between sparse non-zero buckets painted fake "event triangles" between actual data points. Switch from a stroked path to per-bucket bars: - 12 rects per row, x = `i * 8 + 1`, width 6, 2px gap between. - Bar height = `(value / shared_max) * 24`, floored at 1 unit so a non-zero bucket is always visible even when an outlier elsewhere dominates the scale. - Empty buckets render nothing — no fake baseline, no interpolated trough. - Bars grounded at `y = 28` (bottom of viewBox), so "zero" is implicit and the eye reads upward from a stable floor. - Shared `spark_max` across every account's bars (the component method introduced for the line version stays — that part of the diagnosis was right, it just needed a chart type that handled the scale honestly). Net read: the column-chart-on-each-row layout matches "12 weeks of deposits into this account" much more directly than a sparkline ever did, and outlier-vs-modest-but-steady contributions are both legible at a glance. * fix(goals/pledge-modal): helper text reacts to selected account The helper paragraph above the amount field was painted off `@goal.any_connected_account?` — a goal-level decision that fires once at modal render and never updates. On a mixed-funding goal (one connected + one manual account linked), the helper read the "transfer" copy regardless of which account the user picked from the dropdown, even though the saved pledge's `kind` is decided per-account by `kind_for_account` in the controller. Stale UI vs. correct data. Render both helper paragraphs hidden, then toggle the right one visible via Stimulus on `change->goal-pledge-preview#accountChanged`. The select renders its `<option>` tags with `data-manual="true|false"` from `Account#manual?`; the controller reads that attribute off the currently-selected option and flips `hidden` on the two helper targets. `connect()` also calls `accountChanged()` so the initial paint matches the preselected account from `?account_id=…` (the catch-up callout's amount-specific deep link). Switch from `options_from_collection_for_select` to `options_for_select` with the `[label, value, { data: { manual: } }]` 3-tuple form — Rails supports per-option data attributes there but not on the collection helper. * fix(goals/funding-widget): per-account balance trajectory area chart Bars communicated "events," not "where the account level sits." A sparse-deposit account painted three thin bars at the bottom and looked dead. An account with a single big deposit dominated every other row's scale. Swap to the same visual language as the projection chart on goals#show — filled area below a stroked line — but one chart per linked account, rendering that account's actual balance trajectory over the last 90 days. Mechanics: - New `trajectory_map` on the component pulls every `balances` row for every linked account in one query (`Balance.where(account_id: account_ids, date: 90d..today)`). Result is grouped per account and resampled to 24 points by a single-pass forward walk that carry-forwards the most-recent balance at-or-before each anchor date. O(rows + samples), not O(rows × samples). - Per-row Y-scale: baseline 0 (when the account has ever held a positive balance), ceiling = max balance × 1.05. The chart reads as "how full was this account over time" rather than "how dramatic is the shape." Flat-at-$5k accounts paint near the top; growing $200 → $500 accounts climb from 40% to top. - Filled area at `opacity: 0.18` in the account color + stroked line at full opacity on top — same treatment as the projection chart's saved series. - Grid track for the chart column widened from `minmax(60px, 1fr)` to `minmax(80px, 1fr)` so the curve has enough horizontal room to read. Removed `shared_spark_max` + `sparkline_map` + the bucketed inflow sparkline machinery. Per-row scale is correct here — magnitude already lives in the weight pill on the left and the "$X last 30d" column on the right; the chart's job is shape. * fix(goals/funding-widget): chart shows cumulative inflow, not balance level Balance trajectory rendered every account as "near the top with a gentle wobble" — pink ($1830/30d), orange ($0/30d), blue ($300/30d) all looked nearly identical because each was a positive balance with mild growth, and per-row 0-baseline scaling pushed all lines toward the ceiling. The chart and the "$X last 30d" column on the right were telling completely different stories on the same row. Switch the metric the chart plots: - Data: 31 daily samples (today − 30 … today) of *cumulative inflow* per account, fetched in one `GROUP BY (account_id, date)` over the 30-day window. Each per-account array is a monotonic non-decreasing prefix sum starting at 0. - Scale: per-row, anchored at 0, ceiling = `max(values) × 1.05`. - The chart's rightmost point now equals the "$X last 30d" column value by construction — chart and column tell the same story. - `last_30_money` is read off the cumulative array's last element, no separate aggregation query. Visual shapes after the swap: - Steady-inflow account → smooth diagonal climb - Bumpy/episodic account → step pattern with flat plateaus - No-inflow account → flat line at the bottom, no filled area Removed `balances` query path entirely; trajectory_for is gone. * fix(goals/funding-widget): non-scaling-stroke for trajectory line `preserveAspectRatio="none"` stretched the viewBox's 100×28 to the container's natural width (≈600px) while leaving the Y axis at 1×. With anisotropic scaling, SVG strokes inherit the path's local scale — horizontal segments rendered ~6px wide, vertical segments ~1.5px wide, diagonals in between. The line read as visibly fatter on the flat top run than on the climbing/dropping segments. Add `vector-effect="non-scaling-stroke"` to the line path so the stroke width stays a constant 1.5 CSS px regardless of how the viewBox is scaled. Filled area is unaffected (no stroke). * fix(goals/funding-widget): replace chart with last 30d + last 90d totals The cumulative-inflow chart kept producing readings that didn't match user mental models — chart endpoint = 90-day cumulative, right-hand column = 30-day total, and the visual line didn't carry the "this is per-week deposit activity" intuition that a sparkline implies. After iterating through bars, balance trajectory, and filled-area cumulative, simplest is best. Drop the chart. Each row now shows two right-aligned totals stacked vertically: - Primary line: "$X last 30d" — text-sm, text-primary, the "this month so far" headline answer. - Secondary line: "$Y last 90d" — text-xs, text-secondary, the quarterly-trend reference. Tells the user whether this account contributes regularly without forcing them to read a chart. Both numbers compute in one query — pluck (account_id, date, amount) over 90 days, sum per account into two buckets based on whether the entry's date falls inside the 30-day cutoff. Grid shrinks from 5 columns (avatar / name / weight / chart / total) to 4 (avatar / name / weight / two-totals), with the two-totals column getting 120px so both numbers fit right-aligned with their labels. Drop `funding_accounts_subtitle` and the chart-window plumbing (`TRAJECTORY_SAMPLES`, `cumulative_inflow_map`, `column_total_from`, SVG markup, `vector-effect`, etc.). * fix(goals/show): strip redundancy + sharpen catch-up framing The show page repeated the same data multiple times across surfaces that should each say one thing once. Per-screen counts before this commit: - Account % distribution: 4 places (distribution bar + dot-legend strip + 5-bar weight pill + % column) - Current balance: 3 places (ring, funding heading total, ring "of $X" subline) - Target amount: 3 places (header, ring subline, catch-up body) - Target date: 3 places (header, catch-up body, chart axis) - Pace: 2 places (catch-up body, projection subtitle) - ".00" cents: every monetary string This pass: - Funding widget drops the dot-legend strip (color/name/% triplet redundant with the distribution bar's color + the per-row avatar color) and the 5-bar weight pill (rendered as "1-of-5 sliver" for low-weight accounts — read as a glitch; the % number next to it covered the same fact). Row grid shrinks from 5 to 4 columns. - Funding section heading drops `· $187,031` — the ring card already carries the total balance. - Catch-up alert reframes: Title was "Save $26,621/mo to stay on track" (the *full* required rate, with the misleading "stay on track" while the pill says "Behind"). Now "Save $20,002/mo more to catch up" using `catch_up_delta_money` — the user's actual delta over current pace. Body collapsed from two with-date / no-date variants to a single "Current pace $X/mo · required $Y/mo to hit your target." Drops the target date duplication since the header already says it. Pledge CTA pre-fills with the *delta*, not the full required — so accepting it once funds the gap instead of stacking the full required rate on top of existing pace. Secondary link "Or adjust your target" → "Adjust target instead" (less defeatist framing). - Projection chart subtitle "At $X/mo you'll miss your target date." drops the pace duplication (catch-up above already states pace). New: "Falling short at current pace." Diagnostic only. - All money on the show page uses `format(precision: 0)`. The ".00" cents added no information at goal-tracking scale. - Header `Record pledge` demotes to `outline` variant when status is `:behind` — the catch-up alert below owns the primary action. One primary action per surface. Also adjacent fixes: - Funding widget keys avatar / distribution color off `account.id`, not `account.name`. Renaming an account no longer recolors it retroactively; two accounts with name-hash collisions no longer share a color (Ruby idiom audit finding). - `Goals::StatusPillComponent`: add `:completed` variant with `circle-check-big` icon. `Goal#display_status` now returns `:completed` when `goal.completed?` so a manually-completed goal (e.g. user stopped at 80%) reads "Completed" rather than falling through to `:on_track`/`:behind` and lying on the index. Locale: drop `body_with_date` (folded into `body`), `projection.behind` no longer carries interpolation args (caller doesn't pass them either), `projection.no_pace` plain-language rewrite ("inflow" → "deposits"), add `status.completed: "Completed"`. * fix(goals): align card + banner copy/numbers with show-page changes Tail of the redundancy + clarity pass: - Goal card on the index drops ".00" cents from every Money.format call (now `format(precision: 0)`). The card uses the same visual rhythm as the show page; cents add zero info at this scale. - Card's "behind"-status footer now reads "Save $X/mo to catch up" with X = `catch_up_delta_money` (the delta the user must add), not the full `monthly_target_amount` (which read as a total monthly burn). Same fix as the show-page banner. - Pending-pledge banner title becomes pluralized: drops "0 days left" / "1 days left" grammatical bugs. New locale tree: title.zero → "Pending: $X into Y · expires today" title.one → "Pending: $X into Y · 1 day left" title.other → "Pending: $X into Y · N days left" Also drops the "Watching for" phrasing (system-talk) for "Pending:" (state-talk) and drops cents from the amount. - `confirm_cancel_body` likewise renders amount without cents. Cards and banner now read consistently with the show page; one voice across the surfaces. * fix(goals): exclude pending transactions from pace + mobile-stack funding rows Two audit fixes that pair well. PF audit B20: pace, family velocity, and the funding widget's 30/90-day totals all summed Entry amounts over the linked accounts *including provider-pending transactions*. A pending Plaid/SimpleFIN deposit inflated pace today; the next sync that reversed or dropped it silently shrunk pace tomorrow, with no signal to the user. Worse, the reconciler could match a pending transaction and flip the pledge to "matched" before the underlying entry vanished. `.merge(Transaction.excluding_pending)` on the three Entry queries (Goal#pace, Family#savings_inflow_velocity, the funding widget's `inflow_totals_map`) brings the existing `Transaction::PENDING_PROVIDERS`-aware scope into play. Single-line fix across the three call sites. UX audit: funding-account rows used `grid-cols-[24px_1fr_48px_120px]` at every breakpoint. On a 375pt iPhone viewport that left ~50px for the name column after `p-5` padding + container chrome — name truncated to "Ban…" and the per-row % column squeezed against the weight/totals stack. The percent number is also already encoded in the distribution bar above the rows; on mobile it can disappear without losing signal. Drop the % column at < sm: - mobile grid: `grid-cols-[24px_minmax(0,1fr)_auto]` (avatar / name / totals) - sm+: original 4-column layout with the per-row % - per-row balance subline + accountable label now also drops `.00` cents (consistency with the rest of the page). * fix(goals/show): past-due target reads "was due" not "by" Copy audit edge case. When `target_date < Date.current` and the goal isn't completed/reached, the header rendered "Target $X by Jan 1, 2024" — present-tense "by" framing a past deadline. The card already has `goal_card.past_due` for this; the show header had no equivalent. Add `header.target_by_past: "Target %{amount} · was due %{date}"` and switch the header when `days < 0`. Skips the trailing "N days left" subpart since it'd render negative or stale. * fix(goals/index): persist filter + search in URL across reloads UX audit finding. The filter chip state and search input lived only in Stimulus values — a Behind-filter selection survived turbo morphs but vanished on F5, browser back from a goal's show page, and any deeplink share. For a family with 10+ goals filtering by "behind", every navigation reset to "all". Hydrate on `connect()`: - read `?filter=behind` → statusValue - read `?q=…` → input target Sync on every `filter()` call via `history.replaceState`: - filter=all → drop key - q empty → drop key - else preserve both Uses `replaceState` (not `pushState`) so each keystroke / chip click doesn't bloat the back-history. The page URL becomes shareable for the filtered view. * fix(goals/show): ring subtitle drops the target restatement The ring card's secondary line read "of $400,000 · $212,969 to go" — the "of $400,000" half duplicates the header's "Target $400,000 by Jan 10, 2027". Same number, two places, ~80px apart vertically. Drop the "of $target" half. Subtitle now reads "$212,969 to go" — single new fact, complementary to the header. * fix(goals/copy): pluralization, casing, voice cleanup Copy audit quick wins. - `needs_this_month_sub` dropped "across" preposition that read grammatically wrong at count=1 ("across 1 goal behind pace"). New: "1 goal behind pace" / "N goals behind pace" — count + noun matches the working sibling subtitles. - `on_track_sub_parts.no_date` was "1 open" / "N open" — collided with the chip and status pill labels "Open" (titlecase) on the same screen. New: "1 without a deadline" / "N without a deadline" — descriptive, lowercase, unambiguous. - `pledge_just_transferred` / `pledge_just_saved` dropped the past-tense + trailing-ellipsis form ("I just transferred…"). Modal title is "Log a transfer you made" / "Log money you set aside" — present-tense, resolved, clear about what the dialog does. - `goals.show.empty.heading` "Nothing's flowed in yet" → "No deposits yet". "Flowed" was novel jargon nowhere else in the vocabulary; "deposits" matches the surrounding copy. - `form_stepper.errors.amount_required` / `accounts_required` added "Please" prefix to match `name_required` — three errors with one voice. * fix(goals): reconciler logs to Sentry + rename :extend route to :renew Two Ruby idiom audit fixes. The Reconciler's outer `rescue StandardError` was logging at error level and moving on. Pipeline-protective (we don't want a Goal reconcile failure to break the Plaid/SimpleFIN/etc importer it's hooked into) but invisible — real bugs hid behind a warn log forever. Add `Sentry.capture_exception(e) if defined?(Sentry)` alongside the log, matching the pattern in `Account::Syncer`, `Sync`, `PlaidItem`, and the chart-series rescues this branch already added. Keep the rescue's protective function. `member do patch :extend end` shadows `Module#extend` — the controller action name competes with Ruby's most-common mixin entry point. `before_action :foo, only: %i[extend destroy]` reads as "extend this controller with :foo, only: …" to a casual reader, and stack traces against `def extend` look misleading. Rename to `:renew` (matches the existing copy: the button says "Extend 7 days," but the API verb is "renew the watching window"): - config/routes.rb: `patch :renew` - GoalPledgesController#extend → #renew - locale `goal_pledges.extend` → `goal_pledges.renew` - banner `extend_goal_pledge_path` → `renew_goal_pledge_path` - test refs updated The user-facing button text is unchanged. * fix(goals): months_remaining uses day-precision PF audit edge case. Calendar-month math undercounted near the deadline: May 30 with a June 1 target returned `1` ("save $5k this month"), then June 1 morning returned `0` (falls through to `remaining_amount` charged as one-month-required). Users saw a $5k/mo required rate for a 2-day window, then $5k flat on deadline day — a cliff that doesn't match reality. Replace calendar-month delta with `(target_date - Date.current) / 30.0` so a 2-day-out deadline reports ~0.07 months and `monthly_target_amount` scales proportionally. `[..., 0.0].max` keeps the past-due case zero-clamped. * fix(goals/stepper): inactive connector line uses border-subdued RUI audit: form-stepper progress line used `border-secondary` for the inactive state — same weight as the active step's border, so the active-step circle didn't visually pop against the line connecting it to the inactive step. Recede passive states. Swap to `border-subdued` (the DS's quieter divider) for the inactive (step 1) line state. The active state stays `border-inverse`. JS toggle in `goal_stepper_controller.js#updateStepperState` follows. * fix(goals): clarify "last saved" + add pledge timestamp to banner UX audit pair. Header "Last saved N days ago" was rendered from `Goal#last_matched_pledge_at` — date of the most recent *pledge-matched* entry — but the funding column on the same page shows "$X last 30d" computed off *all* entries. A user who deposited cash without recording a pledge saw "Funding · last 30d: $200" while the header still read "Last saved 47 days ago." Two adjacent figures contradicted each other. Rename the locale strings (used on both the index card and the show header) to reflect the actual data source: - footer_no_pledges: "No matched pledges yet" - footer_last_today: "Last pledge matched today" - footer_last_days: "Last pledge matched N days ago" Two open pledges into the same account previously rendered as two near-identical yellow banners with no way to tell which one the Cancel button targeted. Add a relative-time line below the body — "Pledged 2 hours ago" / "Pledged about a minute ago" — using `time_ago_in_words(pledge.created_at)`. Discriminator without changing the title or the action surface. * fix(goals): catch-up subtracts pending pledges from the demand UX audit finding. The catch-up alert demanded $X/mo without accounting for pledges the user had already recorded. The user recorded a $20k pledge → catch-up still demanded a fresh $20k → double-counting → stacked yellow CTAs telling them to do the thing they'd just done. Goal#catch_up_delta_money now subtracts `open_pledges.sum(amount)` from the demand: delta = max(monthly_target − pace − sum(open_pledges), 0) Uses the in-memory preloaded `open_pledges` collection (controllers already eager-load it), so no extra query. The clamp at zero keeps "$0/mo more" from rendering when pending pledges fully cover the gap. Alert branch in show.html.erb now also gates on `@goal.catch_up_delta_money.amount.positive?` — when the demand zeroes out via pending pledges, suppress the alert entirely. Status pill stays `:behind` (because `pace < required`), but the action surface goes quiet because the user already took it. * fix(goals/chart): full money format on "Short" annotation + 4-digit year on x-axis Two screenshot-driven audit fixes. The chart's "Short $160.6K" annotation used `_fmtMoneyShort`'s K/M shorthand while the page's other monetary readouts ("$26,621 to catch up", "$187,031 saved", "$1,830 last 30d") were full `Intl.NumberFormat` output. Inconsistent units in the same viewport. Switch the annotation to `_fmtMoney` ("$160,634 short") + reword to put the money first ("$X short" reads more naturally than "Short $X"). Y-axis tick labels keep the K/M shorthand — that column is space-constrained and the same convention is already understood as "axis abbreviation." The x-axis terminal tick rendered `"Jan '27"` from the `"%b '%y"` time-format string. A glance read it as January 27th of the year, not January 2027 — and the target-date tick is the single one users navigate the chart for. Switch to `"%b %Y"` → "Jan 2027." Slightly wider per tick; the existing adjacent- duplicate-removal logic keeps the count sane. * fix(goals): Mark complete confirm warns at sub-100% progress Behavioural audit edge case. A user clicking "Mark complete" at 80% saw the same generic confirm body as at 105% ("It leaves the Ongoing list…"). Sunk-cost-fallacy inversion + premature closure: once labelled complete, the goal anchors success on the truncated amount; future similar goals get smaller targets (regression to the lower aspiration). When `progress_percent < 100`, swap the confirm body to a specific one — "You're at 80% — $X of $Y. Marking complete records this as your achievement instead of the original target. Continue, or close this and adjust the target instead?" Doesn't block the action (some "stop short" cases are healthy — CFP literature explicitly endorses changing your mind), but makes the trade-off visible. Keep the original copy for the ≥ 100% case. `confirm_complete_body_short` is a new locale key; the kebab-menu builder picks between it and `confirm_complete_body` per-render. * fix(goals/pledge): redirect non-turbo-frame GET to goal show UX audit: `app/views/goal_pledges/new.html.erb` unconditionally renders the form in a DS::Dialog wrapper — when the user lands on `/goals/:id/pledges/new` directly (F5, bookmark, stale deep-link), the dialog renders as a freestanding modal over an otherwise-empty page. Compare to `goals/new.html.erb` which has a `turbo_frame_request?` branch with a full-page fallback. Pledges aren't usefully standalone — the modal only makes sense in goal context. Redirect non-frame GETs back to the goal show page instead of rendering the broken-looking standalone dialog. If we want a deep-linkable "open the pledge modal" experience later, that lands as a `?open=pledge` query on the show page that auto-fires the modal — out of scope here. * fix(goals): current_balance guards against linked-account currency drift Ruby idiom audit edge case. `linked_accounts.sum { |a| a.balance.to_d }` trusted the model's validation that all linked accounts share the goal's currency. The invariant holds at write-time, but direct DB writes, an account-currency edit outside goal validation, or future code that bypasses the validation chain could drift it. The naive sum would silently add raw EUR + USD numbers and surface the result as goal.currency. Filter `linked_accounts.select { |a| a.currency == currency }` and log/report-to-Sentry when the filtered count differs. The sum stays correct (no FX, no mixing) and the operator gets visibility into the drift. Same pattern as `Family#savings_inflow_velocity` already uses for the family-level rollup. * fix(goals/new): avatar default icon + restore .goal-avatar color-mix Two interlocking bugs on the new-goal modal's color/icon preview. 1. Avatar fell back to a literal "?" when icon + name were both blank — `form.object.name.to_s.strip.first&.upcase || "?"`. User reported the avatar looked empty on a fresh modal because the "?" disappears against many palette tints. Categories handle this by always showing the category icon. Replace the "?" fallback chain with a default `target` icon (matches the goal creation header's iconography): • icon present → render that icon • icon blank, name → render first letter • icon blank, no name → render default "target" icon 2. Picking a color via the Pickr color picker called `updateAvatarColors(color)` which inlined `style.backgroundColor` + `style.color = color` — overriding the `.goal-avatar` class's `color-mix(in oklab, var(--avatar-color) 55%, black)` rule. The class handles theme-aware contrast (darken text in light mode, full color in dark mode); the inline override killed it and text rendered at the same lightness as the 10% tint background. Update only the `--avatar-color` CSS variable; let the class continue computing the resolved colors. Wire the avatar to the goal-stepper controller properly: `_color_picker.html.erb` gains `data-goal-stepper-target="avatarPreview"` on the span. `nameChanged` now updates the avatar directly (the previous selector queried `[data-testid="goal-avatar"]` which doesn't exist on the color_picker span) and: - swaps to the first letter as the user types, - restores the default-icon HTML (captured at connect) when the name is cleared, - bails when the user has explicitly checked an icon radio (don't undo their choice). * fix(goals): demote Behind pill to neutral surface + drop em-dashes Behavioural + RUI audit follow-ups. The yellow overload finding flagged three concurrent yellow surfaces on the show page: the "Behind" status pill, the catch-up alert, and the open-pledge banner(s). Demoting the alert to outline ownership of the primary CTA addressed one layer, but the pill kept fighting the alert for hue attention. "Behind" is a state, not a call to action; the alert owns the action signal. Switch the pill's classes from `bg-yellow-500/10 text-yellow-700` to `bg-surface-inset text-yellow-700` (with the same dark-mode override). Background goes neutral (matches paused/archived chips); the text keeps the warning hue and the triangle-alert icon stays. Signal preserved, weight reduced. The yellow alert below now reads as the primary nudge instead of one of three matching tones. Also: copy/em-dash sweep across goal surfaces. User-facing strings that contained em-dashes ("Reaches 70% — $X of $Y", "into your linked account — Sure will catch it", "You're at 80% — $X of $Y") read as a stylistic tic; replace with comma/period/period respectively. Form-stepper review placeholders "—" become "…" (ellipsis reads as "not yet set" without the typographic weight). Code comments + log messages also scrubbed for consistency; awkward sed artifacts (//. its...) restored to readable English. No locale-key shape changes; pure string-content edits + one component-style tweak. * fix(goals/copy): apply stylistic pass from copy expert Second pass on user-facing strings after the em-dash sweep and yellow-pill demotion. Voice/abbreviation/edge-value parity. Voice consistency: - `index.pending_pledges_callout` reframed from "Sure is watching your linked accounts" (system-as-watcher voice) to "You have pending pledges. Sure will confirm them on the next sync." (user-actor, system-action). Matches the surrounding user-centric voice on the KPI strip and the helper-text pattern ("Sure will look for…", "Sure will catch it") used elsewhere. - `goal_pledges.new.helper_manual` flipped pronoun "We'll record" to "Sure will record" so the modal's two helper lines share a single narrator. The transfer-helper already says "Sure will look for"; this matches. - `form_stepper.errors.*` dropped the apologetic "Please …" voice ("Please give your goal a name.") for the terse imperative the rest of the feature uses ("Give your goal a name." / "Set a target above zero." / "Pick at least one funding account."). Parallelism: - `kpi.velocity_delta_zero_base` was the only `velocity_delta_*` string spelling out "30 days" while siblings used `30d`. Switch to "First 30d of activity" so the sub-tile reads in one unit. - `Depository` titlecase in `at_least_one_linked_account_required`, `must_be_depository`, and `no_depository_accounts` collapsed to lowercase. Common noun, not a UI label. Matches the empty-state body in `funding_accounts.empty.body` which was already lowercase. Test fixture for `must_be_depository` updated. - `projection.reached` was the same string as `celebration.heading` ("Goal reached. Nice work."), making the celebration moment feel templated. The projection slot is the chart's empty state when there's nothing to project; rephrase to "You've hit the target. No projection needed." Celebration keeps the warm tone. Edge value: - `celebration.body` was "You hit your $X target." When the user marks a goal complete at sub-100% (a flow the new `confirm_complete_body_short` already warns about), this lied about the achievement. Rewrite to "Goal closed at %{saved} of %{target}. Keep it as a record, or archive it now." Interpolation now passes both `saved` and `target` from the show template, so the celebration card honors the actual saved amount whether the user hit, overshot, or stopped short. Notes deferred (verify-only, not string changes): - `goal_card.footer_catch_up` is interpolated with `catch_up_delta_money` in `CardComponent#footer_line`; the show- page guard `.amount.positive?` already lives there. No copy change needed. - `pending_pledge.title.zero` bucket fires only when `count: 0` reaches the I18n call; `GoalPledge#days_left` clamps at 0, so the friendlier "expires today" copy is reachable. - `paused_banner.title` / `inactive.heading_paused` duplicate strings noted but left in place; consolidation is a separate refactor. * fix(goals): scale up card/widget/chart text, fix chart continuity, ease ring focal point Five small audit follow-ups bundled because they were each one-line swaps and individually wouldn't earn their own commit. Card text scale (vs Sure house style — budget_category h3 ≈ text-base, budget _actuals_summary value text-xl, account row text-sm subtype): - goal card title text-sm → text-base - goal card balance text-lg → text-xl - goal card pace/footer/subtitle text-[11px] → text-xs - funding row subtype subtitle text-xs → text-sm - funding row "last 30d / last 90d" labels text-[10px] → text-xs Chart label scale (projection chart was an outlier at font-size: 10 while time_series_chart_controller uses 12): - every `font-size: 10` in goal_projection_chart_controller.js → 12 - tooltip cssText font-size: 11 → 12 Color-picker pen toggle on the new-goal avatar was w-6 h-6 (24px circle, ~55% of the lg 44px avatar). Shrink to w-5 h-5 + add a w-3 h-3 class on the inner icon so it scales down with it. Graph continuity bug: the saved-line endpoint and the projection-line start point could disagree by tens of $thousands. Saved came from `Balance::ChartSeriesBuilder` (daily snapshot in `balances`), projection started at `currentAmount = goal.current_balance.to_f` (live `linked_accounts.sum(:balance)`). When the snapshot lagged the live read, the chart showed a vertical gap at the "today" marker. Filter any same-day-or-later points out of the raw saved series, always extend the saved series to `(today, currentAmount)`. Saved line now closes at exactly the projection's start. The recent balance-drop story is still honestly shown (the line dips toward the live value rather than ending at the stale snapshot). Ring card focal-point (RUI audit): the left ring card on goals#show sat at the same `shadow-border-xs` elevation as the projection chart and funding card. "When every card is raised, nothing's primary." Drop the shadow + container background — the ring now reads as a status panel sitting on the page surface, not a content card competing with its neighbours. Paused/archived/celebration/empty right-slot variants keep elevation since they ARE content cards. Deferred: light-mode pink distribution-bar contrast. The fix needs a DS token decision (hairline outline vs darker step on the palette entries); rolling it into a polish PR risks dragging in DS changes unrelated to goals. Logged for a follow-up. * fix(goals): unified per-goal account color map + smaller pen toggle User flagged two regressions: account colors didn't match between the goal preview-card avatar stack on the index and the funding-widget rows on the show page, and the color-picker pen toggle on the new-goal modal still felt too big. Color matching: - `AccountStackComponent` (index card) used `Goals::AvatarComponent.color_for(account.name)` — MD5-of-name into the 10-color palette. - `FundingAccountsBreakdownComponent` (show page) recently switched to `color_for(account.id.to_s)` — MD5-of-id. - Same account, two surfaces, two different palette picks. Plus either hashing scheme can collide within a multi-account goal (palette has 10 colors). Move ownership to the Goal model: `Goal#account_color_map` returns `{ account_id => palette_hex }` for the goal's linked accounts. Sort by `id` for a stable order across reloads, then assign `palette[i % palette.size]`. Stable + collision-free up to 10 accounts in a single goal (a realistic upper bound — most goals link 1-3). Both consumers now read off the same source: - `AccountStackComponent.new(accounts:, color_map:)` accepts a hash and falls back to the name-hash if no map provided (kept for callers that don't have a goal in scope yet). - `FundingAccountsBreakdownComponent#color_for` reads `goal.account_color_map[account.id]`. - Goal card on index passes `goal.account_color_map` to the stack. Pen toggle: The new-goal color-picker pen sat in a `w-5 h-5` circle with a `border` ring + `text-secondary` icon. The border + secondary text weight kept it loud against the avatar even at 20px. Drop the border, drop the size another step (`w-4 h-4`), recolor the icon `text-subdued` + `hover:text-secondary` so the affordance recedes when not interacted with. Position shifts from `-bottom-1 -right-1` (8px overhang) to `-bottom-0.5 -right-0.5` (2px overhang) since the smaller circle doesn't need the larger float. Icon swaps "pen" for "pencil" (the more conventional edit indicator across Sure). * fix(goals/show): move Edit into kebab, match house style User clarification on the "too big edit icon" finding: the header Edit button itself (not its icon) is what felt wrong. Investigation showed the wider Sure pattern. Every other "Edit" affordance in Sure lives inside a DS::Menu kebab: - app/views/categories/_category.html.erb - app/views/rules/_rule.html.erb - app/views/family_merchants/_family_merchant.html.erb - app/views/chats/_chat_nav.html.erb - app/views/accounts/show/_menu.html.erb - app/views/transactions/show.html.erb Header rows reserve top-level buttons for primary actions (e.g. "New transaction", "Record pledge"). The goal show page was the outlier — Edit as an outline button next to Record pledge, which left two competing CTAs in the header. Move `menu.with_item(text: t(".edit"), icon: "pencil", ...)` to the top of the kebab list. Header now has a single primary CTA (Record pledge, demoted to outline when status is :behind) + the kebab. Matches every other Sure resource page; eliminates the "button-too-big" framing entirely without resorting to ad-hoc icon-size overrides (the `[&>svg]:w-4 [&>svg]:h-4` arbitrary selector hack would have been a one-off, nobody else uses it). Avatar pen toggle on the new-goal color picker stays reverted to its original w-6 h-6 + border-2 form, per the user. * feat(goals/demo): seed full state-coverage matrix + sample pledges User asked for demo seed variety so every goal state surfaces on at least one card. Previous seed only spanned 4 AASM states; the computed status (:reached / :on_track / :behind / :no_target_date) and the edge-state copy paths (past-due target_date, open pledge banner, "Last pledge matched") were absent. New seed coverage matrix: AASM states (column): active → Vacation in Italy, Wedding fund, Emergency fund, House downpayment, Coffee gear, Tax prep buffer paused → Sabbatical completed → Paid-off car archived → Old laptop fund Computed status (active goals): :behind → Vacation in Italy, House downpayment, Tax prep buffer :on_track-ish → Wedding fund (12-month timeline + small target) :no_target_date → Emergency fund :reached → Coffee gear (target 150 below any plausible account balance — progress hits 100% live) Edge surfaces: Past-due active → Tax prep buffer (target_date 2.months.ago, exercises "was due" header copy and the months_remaining = 0 branch in monthly_target_amount) Open pledge banner → Vacation in Italy + House downpayment each ship a single open pledge. The show-page banner renders; the index pending-pledges callout renders because @any_pending_pledge flips true. Matched pledge → Wedding fund: after the main seed loop, find_by(name: "Wedding fund") + locate the most recent non-claimed primary-account inflow Transaction (>= 30 days, amount < 0 per Sure's sign convention), create a matched-status pledge against it, stamp the Transaction's extra->goal->pledge_id per the partial-unique-index invariant. The show-header then renders "Last pledge matched N days ago" via Goal#last_matched_pledge_at. Implementation notes: - Pledges spec embeds inside each goal_spec as an optional `pledges:` array. The loop creates them after goal.save! using the goal's linked_accounts as the default account; the GoalPledge# account_must_be_linked_to_goal validation passes because every spec's account is one of the goal's linked accounts. - The matched-pledge seed is split into a dedicated helper (`seed_matched_pledge_demo_for_wedding!`) because it depends on Transactions seeded earlier in the demo flow. Both no-Wedding- goal and no-recent-inflow guards bail cleanly so older demo variants still work. - All seed targets are intentional. Goal#status reads the live linked-account balance + 90-day inflow at render time, so the demo statuses adapt to whatever the rest of the demo seeded. The targets are sized so the *intended* status is the most likely one for typical demo data. Local DB unaffected: this is the demo-family generator only, run via `Demo::Generator.new.generate_default_data!` against a fresh family. * chore(goals): drop architecture notes from the repo Pulls the two early design notes out of git tracking. They covered the V1 ledger-based design and the engineering mechanics that led to the V2 rewrite. With V2 shipped, the notes have served their purpose and the design-of-record now lives in the code + this PR. Files stay on disk locally (added to .git/info/exclude so future git status doesn't re-surface them as untracked). Anyone who wants the V1 reference can pull from the source branch where this work started. * fix(goals): test pledge new across both turbo-frame and full-page paths CI failure on the prior commit: `GoalPledgesControllerTest# test_new_renders_the_pledge_form` expected 200 but got a 302 to the goal show page. The recently-added non-frame guard on `GoalPledgesController#new` redirects direct GETs (F5, bookmark) back to the goal so the dialog doesn't render standalone, and the test wasn't sending the `Turbo-Frame` header that the modal flow uses in production. Split the test into the two paths the controller actually serves: - `new renders the pledge form inside a turbo frame` passes a `Turbo-Frame: modal` header and asserts 200 — the real modal flow. - `new redirects to the goal show page on a non-frame GET` asserts the 302 to `goal_path(@goal)` — the guard's intended branch. Together they cover the controller's actual contract. * docs(goals): add llm-guide reference for the goals feature Captures the architecture, key files, data model, status semantics, pledge match policy, connected-vs-manual account detection, color map convention, common tasks, and known gotchas. Matches the existing llm-guides pattern (architecture diagram + file inventory + task-oriented sections + reproducible commands). The doc is forward-looking: it covers how to add a new field to Goal, a new status branch, a new pledge kind, and how to safely touch the reconciler. The "Gotchas" section catalogues the known-incomplete-but-shipping items so a future audit doesn't re-derive them from scratch. Demo data regeneration command is included for anyone who needs to refresh the seed. * fix(goals/index): completed goals join the chip-filterable grid Completed goals previously lived in a dedicated section below the active grid that was always visible regardless of which chip the user selected. They were the only state without chip filter representation. Fold completed into the main grid in controller-side order: active goals first (sorted by status rank), completed after (alphabetical). Drop the separate "Completed" section. The `data-goal-status="completed"` on each card (from `Goal#display_status`) makes them filter naturally when the new `completed` chip is selected. Archived stays in its own collapsed-by-default `<details>` section below — the visual-hide-by-default is the point there and a chip wouldn't preserve that. `@active_goals` keeps its meaning (active-only) for the KPI strip, the pending-pledges callout, and the search-visibility check needs `@grid_goals` so search shows up at six combined cards. Section heading: "Ongoing" → "Goals". The heading now covers the combined active + completed list, and "Ongoing" misrepresented what's below it. * fix(goals): address AI review on PR #1798 (CodeRabbit + Codex) Correctness: - GoalPledge#matches? rejects outflows on transfer pledges so a +$200 purchase no longer satisfies a $200 deposit pledge after .abs - GoalsController#sync_linked_accounts! saves through the goal so currency/depository/family validations actually run on update - AlreadyClaimedError replaces empty RecordInvalid in resolve_with! and reconciler rescues the dedicated class - SweepExpiredGoalPledgesJob wraps each expire! in a per-record rescue - Assistant::Function::CreateGoal disambiguates duplicate account names and returns an absolute URL via mailer host config - Family#savings_inflow_velocity defensively scopes from the family's accounts (was Account.joins(:goal_accounts).where(goal_id: ...)) - GoalPledgesController#set_goal preloads linked_accounts + providers to drop the N+1 on any_connected_account? - Stepper subtitle update walks to the enclosing dialog before querySelector so two stepper instances don't fight over one header - categories/_form.html.erb data-action targets color-icon-picker, not the non-existent "category" controller UX / visual: - Projection chart drops preserveAspectRatio="none" and pins endDate at today for past-due goals so the today marker stays in-domain - _color_picker / categories form swap non-standard border-1 for border - Goals index search input uses ring-alpha-black-100 (was raw gray-500) Refactors: - Goal#header_summary extracts the multi-line ERB header block - Goal#catch_up_delta_money sums open_pledges in SQL - Goal#projection_summary uses I18n.l for the on-track month label - Account#default_pledge_kind moves the manual/transfer decision out of GoalPledgesController - GoalPledge::Reconciler iterates ordered (created_at, id) so first-claim wins is deterministic under non-sequential PKs - Goals::FundingAccountsBreakdownComponent + Goals::AccountStackComponent use clamp(0..) instead of Float::INFINITY / [x, 0].max - Goals::StatusPillComponent#label provides a titleize fallback - Goal projection chart skips the redundant initial _draw and reuses the snapped point in the past branch (no double-bisect) - Goal pledge preview drops maximumFractionDigits: 0 so USD/EUR show cents while JPY/KRW stay whole-unit - Demo generator captures the Wedding fund goal in the seed loop instead of looking it up by hardcoded name Tests: - GoalPledgeTest: outflow rejection - GoalsControllerTest: cross-currency attachment rejected on update - SweepExpiredGoalPledgesJobTest: cancelled coverage + per-record rescue - GoalTest: pledge_action_label_key flips to manual_save without an unconditional guard * fix(goals): address second AI review round on PR #1798 - Parse "YYYY-MM-DD" date-only strings as local midnight in the projection chart so users west of UTC stop seeing the today marker and hover dates land one calendar day back - Order the demo-generator depository pickup by (created_at, id) so primary/secondary roles stay stable across reseeds and the state matrix (behind / on_track / reached / no_target_date / past-due) surfaces the same goals every time - Drop the brittle " · "-split on goals.goal_card.days_left in Goal#header_summary (the translation has no separator suffix) - Goal#projection_payload ships pre-formatted strings for the static chart annotations (target_amount_label / short, projection_end_label, projection_shortfall_label, pending_pledge_label_short) and the controller now renders those instead of running Intl.NumberFormat on each draw. Y-axis tick labels stay JS-side because they depend on D3's dynamically-chosen tick values. * fix(goals): round-3 review polish on PR #1798 - Demo seed_matched_pledge tie-breaks `entries.date DESC` with `entries.id DESC` so dense-same-day inflows pick the same row on every reseed - projection_payload exposes the family-currency symbol via Money.new(0, currency).symbol; the chart's `_fmtMoneyShort` / fallback now reads it instead of the hardcoded $/€/£ map, so JPY/KRW/CHF goals get the correct glyph * fix(goals/chart): use optional chain for currency_symbol fallback Biome lint flagged `(this.dataValue && this.dataValue.x) || fallback` as `lint/complexity/useOptionalChain`. Same behaviour with `this.dataValue?.x || fallback`, lint clean. * ux(goals): polish detail page + unbreak render - Fix render-blocker: Money#symbol doesn't exist (use #currency.symbol). - Sanitize projection_summary so the _html locale renders <strong> markup instead of escaping it. - Switch donut + card ring track to --budget-unused-fill; --budget-unallocated-fill resolves to the same gray as bg-surface in light mode so the unfilled arc was invisible on the detail page. - Mobile detail: drop avatar, right-align action buttons, stack projection header (subtitle + legend) so the subtitle reads on one line; bump legend gap on mobile. - Nowrap the projected reach-date so e.g. "Jul 2026" stays together. * ux(goals): redesign show page — one CTA, calm banners Header collapses to title + kebab. The status pill and the `Record pledge` button leave the title row. Status moves into a one-line callout below the subtitle that doubles as the catch-up demand when behind, the reach-date when on track, or a prompt for a target date when missing. `Record pledge` is now the only pledge entry point on the page and lives under the ring. Behind goals pre-fill it with the catch-up delta. The standalone catch-up alert card is gone — its title is the callout, its pace breakdown moves into the projection chart's subtitle, and its CTA is the ring-adjacent button. The "Adjust target instead" link is absorbed into the kebab's existing Edit item. Pending-pledge banner switches from a warning Alert to a neutral container chip. It is informational state, not a warning. Title carries the relative pledged-at meta inline; verbose auto-confirms body stays but in subdued size. Projection chart drops the today-line pending stub (vertical line + dashed marker + "+ pending $X" text). That data already lives in the pending banner above the chart; the duplicate annotation clutters the today line, the small dashed circle reads as misaligned at small pending amounts, and the label overlaps the projection trajectory. Shortfall label gets a paint-order halo so it stays legible across the dashed projection line. * Pipelock noise * fix(goals): jjmata review — reconciler guard, chart i18n, pace test Three issues raised on PR #1798 review: - ProviderImportAdapter now memoizes account.goal_accounts.exists? per-account so a bulk historical import on an unlinked account short-circuits the reconciler instead of paying one SELECT per row. Linked accounts still hit the per-row reconciler with no change. - goal_projection_chart_controller.js reads Today / Projected / Saved labels via Stimulus values fed from goals.show.projection.* locale keys instead of inlining English. - goal_test.rb now covers Goal#pace with real inflows, asserting the 90-day window cutoff plus the Transaction.excluding_pending and entries.excluded = false filters. * fix(preview): replace PR preview cleanly on redeploy (#1819) * fix(preview): delete stale container app before redeploy (#1820) * fix(preview): run preview container in development (#1821) * ux(goals): fix "0 of N · N reached" KPI weirdness When every active goal already hit its target, the "Goals on track" tile read "0 of 2 · 2 reached" — logically correct but emotionally upside-down. Reached goals aren't being tracked toward pace anymore; they belong in the trophy column, not in the fraction. - New `tracked_total` excludes reached and paused goals from the denominator. Paused stops the pace clock on purpose; reached has already cleared it. - When `tracked_total` hits zero and at least one goal is reached, the tile swaps to a celebratory empty state ("All caught up · N reached") instead of trying to render a fraction with no denominator. - Drop "reached" from the subline when the fraction is calculable. The fraction is a needle, "N reached" is a trophy — surfacing them together muddied the message. Reached only appears in the all-caught- up empty state from here on. Active-first / reached-last grid order already drops out of the existing ACTIVE_STATUS_RANK sort (reached defaults to the lowest rank so it naturally lands after behind / on_track / no_target_date / paused). * feat(goals): gate Goals v2 behind beta features toggle Add require_beta_features! to GoalsController and GoalPledgesController, hide the Goals nav item for non-beta users, and tag index/show headers with the Beta pill marker. Update controller tests to enable the preference in setup and assert the redirect for users without access. * feat(goals): add Beta dot marker on sidebar nav rail Pass beta: true on gated nav items so the nav_item partial renders a violet dot-only pill in the top-right of the icon. The doc covers the dot_only usage; the nav itself was never wired up before merge. * fix(DS::Pill): readable contrast in light mode + drop pill from Goal detail - Bind CSS `color-scheme` to Sure's `data-theme` attribute so the pill's `light-dark()` resolves to the side that matches the active theme. In the dark theme it was previously falling back to the light branch. - Darken light-mode pill text 30% with black on top of the 700 stop so the 10–11px uppercase label reads against the violet-50 background. - Drop the Beta pill from the Goal detail page header. A single goal is not the feature; the pill belongs on the feature index, not on each record. * docs(beta-gating): document main-nav dot marker via beta: local The nav-item partial already supports a `beta: true` local that overlays the DS::Pill dot on the icon, but the gating guide didn't show how to wire a gated nav entry through it. Add a short "Gating the main nav" section with the compact-array pattern, and mention the flag in the GA removal checklist. * feat(beta-gating): beta_gated_nav_item helper auto-marks gated entries Wraps the conditional + dot wiring into a single call so adding a new beta nav entry doesn't require remembering to set `beta: true` by hand or duplicating the `beta_features_enabled?` check. Naming mirrors the existing `BetaGateable` concern. * refactor(css): move .goal-avatar rules out of application.css Goals-specific styling doesn't belong in the global stylesheet. Extract the avatar tint + theme-aware text color into a topical goals.css and @import it alongside the other feature CSS files. * fix(goals): validate color format + restore cascade on drop migration - Add hex-format validation on Goal#color so submissions can't smuggle arbitrary CSS into the style attribute on the avatar / picker preview. The picker accepts custom hexes, so format validation (not inclusion) is the right shape — anything not matching #RRGGBB is rejected at the model boundary. - Fix the on_delete in the down block of drop_goal_contributions to match the original cascade. Restoring with restrict was a schema drift that would have shifted referential behavior after a rollback. * fix(goals): clear state-dependent caches on AASM transition + harden sweep job - Goal: `display_status` and `projection_summary` memoize a value that depends on the AASM state column. Without resetting them after a transition the same instance keeps returning the pre-transition value. Hook `after_all_transitions :reset_state_dependent_caches!` undoes the memos so post-`archive!` / post-`pause!` reads see the new state. - SweepExpiredGoalPledgesJob: the inner rescue covered per-pledge failures but not cursor-phase failures (DB blip, OOM mid-batch). Add an outer rescue that reports + re-raises so Sentry sees the failure and Sidekiq retries the job. * i18n + a11y(goals): extract picker strings + drop redundant status-pill aria-label - Color picker had four hardcoded English strings ("Color", "Icon", "Poor contrast, choose darker color or", "auto-adjust."). Move them under `goals.color_picker.*` and call them through `t()`. CLAUDE.md requires every user-facing string go through i18n. - Status pill duplicated its visible label in `aria-label`, which makes screen readers ignore the visible text. Drop the override so the visible label is the accessible name. * fix(goals JS): listener cleanup on color/icon picker + debounce filter URL sync - color_icon_picker: listeners were attached in initialize() with inline arrows, so they had no removable reference and no disconnect() cleanup. Every Turbo navigation that re-rendered the picker stacked another listener on the same node and left the Pickr instance alive. Move attachment to connect(), store bound references, and clean up in disconnect() (including destroyAndRemove on the Pickr). - goals_filter: replaceState fired on every keystroke. Debounce the URL sync 200 ms so a typing burst collapses into a single update. The visible filtering stays real-time. Clear the timer in disconnect() so a pending sync doesn't fire on an unmounted controller. * fix(a11y): focus trap + returnFocus on DS::Dialog Native <dialog>.showModal() moves focus inside the dialog on open but doesn't trap Tab / Shift+Tab, and focus restoration on close is inconsistent across engines. Add three things to the dialog controller: - Capture document.activeElement before showModal() so the trigger is recoverable when the dialog closes (ESC, backdrop click, explicit close button, programmatic close all route through the native close event). - Wrap Tab inside the dialog so a keyboard user can't tab out into the scrim-covered page behind. - Restore focus to the captured trigger on the close event. If the trigger has been detached (Turbo morphed it out), skip silently rather than throw. Verified manually: opening the new-goal modal moves focus to the name input; ESC restores focus to the "New goal" link; Tab wraps from the last focusable back to the first. * perf + tests(goals): share account-ids across velocity windows + cover gaps - Family#savings_inflow_windows wraps the current/prior 30d sums in a single helper that memoizes the linked-account-id lookup. The KPI tile on the goals index used to run the join+pluck twice per request. - Replace two instance_variable_set pokes and one any_instance.stubs in the goal/controller tests. Refetching the goal exercises the real request lifecycle and stops the tests from leaning on implementation details. The 'All caught up' assertion now relies on a real reached state (target 1 vs the depository fixture's 5000 balance) rather than stubbing :status. - Add tests covering: hex format validation on Goal#color, AASM cache reset (display_status reads the new state on the same instance after pause!), negative pledge amount rejection, expire! no-op on already- expired pledge, cancel! NotOpenError on non-open pledge, sweep job idempotency on a second pass, and strong-params rejection of state / family_id on goal create. * fix(goals): apply CodeRabbit findings - Switch the goal_accounts → accounts FK from on_delete: :cascade to :restrict. `Goal#must_have_at_least_one_linked_account` is enforced at write time; the cascade let a raw DELETE silently orphan a Goal whose only link pointed at the deleted account. Normal Rails Account#destroy still cleans up via `dependent: :destroy`, but the restrict guarantees the DB rejects any path that bypasses the association. - projection_payload: required_monthly is now monthly_target_amount&.to_f so open-ended (no-target-date) goals serialize required_monthly: null instead of 0, matching the absence of a required pace. - index page + sidebar nav-rail dot now read the Beta label via t("shared.beta") (and a new shared.beta locale key) instead of the hardcoded "Beta" literal. - _status_callout uses the view-helper t(...) instead of I18n.t(...) for the status label so it follows the same convention as the rest of the goals views. - goal_projection_chart: read the computed style before stamping position: relative so a stylesheet-defined position (fixed/sticky/ absolute) isn't clobbered. - preview-deploy: add `set -euo pipefail` around the wrangler container lookup so a curl/jq failure fails the job instead of producing an empty CONTAINER_ID and silently skipping cleanup. * revert(goals): move .goal-avatar back into application.css Sure's convention for one-off custom classes (.combobox, .scrollbar, .windows, .prose variants, .table-divider, .turbo-progress-bar) is to define them directly in application.css. Topical files (privacy-mode, date-picker-dark-mode, print-report) are reserved for coherent feature namespaces with multiple rules. A single .goal-avatar rule belongs with the other custom classes. * fix(goals): goal status pill uses DS::Pill outline (consolidate + survive hover bg) The status pill on the goal card used a 10%-alpha fill (bg-warning/10, bg-green-500/10). On the card's hover state (bg-surface-hover) the fill blended into the new background and the pill lost its tint outline. Extend DS::Pill with a green tone and an optional icon: param (renders a Lucide icon in place of the dot) so the same primitive can carry both the beta marker and the goal status badges. Map Goals::StatusPillComponent to DS::Pill outline style — transparent fill + colored border + colored text + glyph — which is immune to any change in the surrounding card bg. One badge primitive, light-mode contrast already fixed (the color-mix 30% darkening on text), and the card hover state no longer washes out the status. * fix(goals): drop hover bg on card, use subtle shadow lift instead The card was the only place in Sure setting hover:bg-surface-hover on a bg-container card; every other static card (settings, recurring transactions, ai_prompts, etc.) stays still. The hover bg (gray-100) landed almost exactly on top of the ring track (gray-200) and washed out the pill fill, fighting the very signals the card was trying to show. Swap to hover:shadow-sm — the lift matches the transaction-tabs precedent already in Sure, the bg stays white, and ring track + status pill keep their contrast. * fix(goals): drop no-target-date goals from the on-track denominator The KPI tile reads 'X of Y on track'. Y was every active goal minus reached + paused, which included open-ended goals (no target_date). But an open-ended goal has no required monthly pace to compare against — by definition it can be neither on track nor behind. Counting it in the denominator dragged the ratio down and never improved as the user kept saving (the fraction stays stuck because the open-ended goal is never a hit). Exclude :no_target_date from tracked_total. Numerator unchanged. The subline still surfaces 'N without a deadline' as informational so the user knows those goals exist. * fix(goals): keep archived cards out of the filter loop entirely The earlier 'filter archived too' attempts kept toggling the archived section based on chip state, which produced more confusion than value (filter shows partial counts, archived hides on some chips, etc.). Step back: archived stays in its own collapsed-by-default section, always visible, never reacts to the chip / search filter. Render the cards with filterable: false so they don't add a filter target in the first place — no JS handling needed, and the active grid + chips behave exactly like they did before this whole thread. * feat(goals): pending-pledge dot on card avatar Goals with open + unexpired pledges now carry a small amber DS::Pill dot at the top-right of the avatar on the index card. Same primitive + position pattern as the beta gate dot on the sidebar nav, so the 'small marker' affordance reads consistently across the app. Pledges are preloaded via the existing .includes(:open_pledges, ...) on the index query, so the indicator is free at request time. * fix(goals): swap pending-pledge avatar dot for inline clock glyph The amber DS::Pill dot on the avatar collided visually with the amber 'Behind' status pill on the same card — two amber signals in the same eye-line. Move the indicator to a text-subdued clock icon between the goal name and the status pill: quieter, semantically clearer (clock = pending sync / time-bound), no tone collision with the status palette. Same accessibility hook (aria-label + title). * feat(goals): footer 'N pending' on cards + drop warning tone from top callout - Pending pledges surface in the card footer as '· N pending' tacked on after the existing footer line (text-subdued). Quiet, semantic, doesn't compete with the status pill or the avatar. - The top-of-page 'You have pending pledges' callout was using the amber DS::Alert warning variant. Pending isn't a warning — it's a passive 'we're waiting on a sync' state. Switch to the info variant so the visual weight matches the meaning. * fix(goals/demo): seed goals in generate_new_user_data_for! Cloudflare preview entrypoint, FamilyResetJob, and the Settings "Reset + load sample data" flow all go through generate_new_user_data_for!, which seeded categories/accounts/transactions/budget but not goals. Move generate_goals! inside this method (alongside the same call already in generate_default_data!) so every sample-data surface gets the full state-coverage matrix. * fix(goals): card hover uses bg-container-hover (gray-50) instead of shadow lift Mirror the affordance used in the accounts/select_provider screen and the bank-sync flows: a near-imperceptible gray-50 fill swap rather than a shadow. Lighter than the previous shadow lift, doesn't introduce elevation noise inside the grid, and the ring track (gray-200) + status pill outline still keep enough separation against the gray-50 hover bg that we don't reintroduce the original contrast issue. * fix(preview): surface demo data failure logs (#1865) * refactor(goals): use semantic color tokens for ring + status callout `Goals::CardComponent#ring_color` and `goals/_status_callout` reached into the Tailwind palette directly (`text-yellow-700`, `var(--color-green-600)`, etc.) for status-coded colors. The sure-design-system already exposes the matching semantic tokens (`text-warning`, `text-success`, `--color-success`, `--color-warning`), which theme-swap correctly in dark mode and survive palette renames without view edits. - `ring_color`: collapse `:reached` / `:on_track` to `--color-success` (the status pill already differentiates them via icon — completed star vs check) and `:behind` to `--color-warning`. The `:no_target_date` fallback keeps `--color-gray-400` for now since there's no semantic neutral token; that gets cleaned up alongside the DS::ProgressRing extraction. - `_status_callout`: drop `text-yellow-700 theme-dark:text-yellow-300` and `text-green-700 theme-dark:text-green-300` for the equivalent semantic `text-warning` / `text-success` utilities. No visual regression in light mode (success collapses two adjacent greens into one); dark mode now properly inverts via the design system's theme variants instead of hand-rolled overrides. The `stroke="var(--budget-unused-fill)"` track on the inline card ring stays for now — that's a token-rename refactor that touches budget code outside this PR's scope and lands cleanest with the DS::ProgressRing primitive that consolidates the three ring implementations. * fix(goals): replace ring-gray-500 with semantic ring-alpha-black-500 token The colour-picker swatches were using the raw Tailwind palette utility `peer-checked:ring-gray-500`. Swap for the design-system functional token `peer-checked:ring-alpha-black-500` so the focus ring inherits the same alpha-on-surface treatment used elsewhere in the system and respects dark mode. Flagged by sure-design's DS Drift Patrol on #1798. * refactor(goals): migrate index search field to DS::SearchInput #1853 just landed on `main` (`8e444ff9`), so the goals index search input can move off the hand-rolled markup and onto the new `DS::SearchInput` primitive. Behaviour unchanged — the `data-goals-filter-target="input"` and `data-action="input->goals-filter#filter"` hooks pass through via the component's `data:` option, and the wrapper's `flex-1 min-w-[200px]` carries through via the component's `class:` arg. Drops the broken `focus:ring-gray-500` lookalike (the hand-rolled class used `focus:ring-alpha-black-100` which is fine, but the new primitive uses the canonical `focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-gray-900` pattern from DS::Button — same focus contract everywhere). Addresses sure-design's DS Drift Patrol finding on #1798. * refactor(goals): migrate archived <details> to DS::Disclosure :inline #1858's :inline variant landed (commit 8de14ed2), so the goals index archived-section toggle can move off the raw <details> and onto the shared primitive. Behaviour and look unchanged — the custom summary content (chevron + uppercase heading + tabular count) passes through the `summary_content` slot; the `:inline` variant adds nothing on top besides the focus-visible ring shared with the other DS::Disclosure variants. Addresses the third sure-design DS Drift finding on #1798 (the other two — DS::SearchInput + ring-gray-500 — already landed earlier). * fix(goals): cover money displays with privacy-sensitive Audit-driven sweep. The class was already on the obvious surfaces (KPI strip, ring center, card balance, funding-accounts breakdown); these were the secondary surfaces missed in the initial PR — money interpolated into descriptive prose, account-picker balances, live previews, and the projection chart tooltip. - card_component: target divisor next to the masked balance, pace line, and behind-status footer (`footer_has_money?` helper keeps non-money branches unmasked so paused / archived / "Goal reached" copy stays readable in privacy mode). - show: header_summary (target + date subtitle), to_go remaining, inactive recap body, celebration body, catch_up body. - _status_callout: conditional on `goal.status == :behind` — only that branch carries an amount; on_track / no_target_date have date or static copy. - _form_edit + _form_stepper: account balance shown in the linked- account picker rows. - _form_stepper review section: reviewSummary + reviewSuggested ps (Stimulus injects target / suggested $X/mo into both). - _pending_pledge_banner: banner title span (amount + account + days). - goal_pledges/new: live preview p (Stimulus injects "Reaches X%, $A of $B" / "Hits your $B target"). - goal_projection_chart_controller: tooltip was inline-styled with hard-coded gray-900 + white (DS drift) and had no privacy class. Replaced cssText with className using bg-container + text-primary + border-secondary + rounded-lg + privacy-sensitive — mirrors the pattern in time_series_chart_controller and the post-#1996 sankey fix. Tooltip now respects theme and privacy mode. * fix(ds): DS::Disclosure summary_class override; migrate color picker Resolves sure-design DS drift patrol findings (raw <details> on goals/_color_picker and categories/_form). The color-icon-picker's <summary> is a 24/28px pencil button absolutely positioned next to the avatar — none of DS::Disclosure's existing variants (default / card / card_inset / inline) match that trigger shape, so the bot's suggested swap would regress the visual. - DS::Disclosure: add optional `summary_class:` kwarg. When set, the caller's class string replaces the variant's hard-coded summary chrome; otherwise the existing variant logic is preserved (verified against the 8 existing callsites — none pass summary_class, all fall through to current behavior). - goals/_color_picker + categories/_form: swap raw <details> for DS::Disclosure with summary_class carrying the pencil-button positioning. Stimulus data attributes (`color-icon-picker-target` and the outside-click handler) forwarded via **opts to tag.details so the controller still finds its target. The DS::Disclosure-rendered popover content now sits inside the component's `<div class="mt-2">` wrapper, but the popups themselves are `position: absolute` / `position: fixed`, so the wrapper is out-of-flow neutral. * fix(goals): drop new-goal stepper, unify create + edit form The 2-step stepper on the create modal carried a review step whose only real signal was a derived "Save $X/mo to hit it on time" hint. Name, amount, and date are all visible in step 1, so the review step was re-displaying form values the user just typed. Collapses both flows into a single panel: - `_form_stepper.html.erb` + `_form_edit.html.erb` → single `_form.html.erb` driven by `goal.persisted?` for URL / method / submit label. - `goal_stepper_controller.js` → `goal_form_controller.js`. Drops the step1Panel / step2Panel / step1Indicator / step2Indicator / step1Circle / step2Circle / stepperLine / reviewName / reviewSummary / reviewSuggested / footerLeftButton / footerRightButton / submitButton target plumbing and the next / back / blockEnter / updateStepperState / updateFooter / updateReview methods. Keeps name-validation, amount-validation, accounts-required validation, avatar-preview-from- name, and the suggested-pace computation — that one now writes into an inline `<p data-goal-form-target="suggested">` below the target_date field instead of the review card. - `new.html.erb`: drops the `Step 1 of 2 · Goal details` subtitle target. New `goals.new.subtitle` replaces the two step subtitles. - `edit.html.erb`: renders the same `form` partial. - `_color_picker.html.erb`: `data-goal-stepper-target="avatarPreview"` → `data-goal-form-target="avatarPreview"` (same Stimulus target, renamed for the new controller scope). - `funding_accounts_breakdown_component.rb`: i18n key path moves to `goals.form.subtypes.*` matching the locale restructure. - `en.yml`: `goals.form_stepper.step1.fields.*` → `goals.form.fields.*`. `step2.*` and the `back` / `continue` / `cancel` keys drop. New `goals.form.create` ("Create goal") + `goals.form.save` ("Save changes") drive the submit-button label. UX delta: the user no longer sees a "Step 1 of 2 / Step 2 of 2" beat. The form is short enough that everything fits in one panel; the only value-add from the old step 2 — the suggested-pace hint — now updates live inline as the amount / date / account-count changes. All 20 `test/controllers/goals_controller_test.rb` tests still pass. `bundle exec erb_lint` clean on the touched templates. * fix(ci): extract github.event refs into job env in preview-deploy Pulls `github.event.pull_request.number` and `github.event.pull_request.head.sha` out of every shell `run:` block and `actions/github-script` body into job-level env vars. The PR number is nominally an integer (no immediate injection risk), but the *pattern* of inlining a `github.event.*` expression into a privileged workflow's shell scripts is what the SAST finding wants to eliminate: - The workflow holds `CLOUDFLARE_API_TOKEN` and `CLOUDFLARE_ACCOUNT_ID`. - A future copy/paste of one of these step bodies onto a user- controlled string (branch name, PR title, commit message) would silently become an arbitrary command-injection path. Touches: - Job-level `env: { PR_NUMBER, HEAD_SHA }` so every step inherits. - "Configure preview files": `sed` substitution now reads `${PR_NUMBER}` from the shell env (the literal-placeholder side stays escaped as `\${PR_NUMBER}`). - "Delete existing preview container app" + "Delete existing preview Worker": shell var assignments use `${PR_NUMBER}`. - "Create GitHub Deployment" github-script: `process.env.PR_NUMBER` inside the JS template literal instead of GHA template interpolation. - "Deploy to Cloudflare Containers": `${PR_NUMBER}` in the shell; `CLOUDFLARE_WORKERS_SUBDOMAIN` also lifted into the step's `env:` block so the URL template uses `${CLOUDFLARE_WORKERS_SUBDOMAIN}`, not a templated secret expression in the shell command. - "Comment on PR" github-script: replaces the four `${{ github.event.pull_request.* }}` interpolations with `process.env.PR_NUMBER` / `process.env.HEAD_SHA` and lifts the preview URL via step env. `issue_number` is `Number(...)`-coerced since env values are strings. - "Store cleanup metadata" artifact name: uses `${{ env.PR_NUMBER }}` (template context, not shell). YAML still validates (`ruby -ryaml -e 'YAML.load_file(...)'`). The only remaining `github.event.pull_request.*` references are the job- gate `if:` condition and the env-extraction definitions themselves — both safe contexts. * fix(goals): Number.NaN over global NaN in goal_form_controller Biome's lint/style/useNumberNamespace rule. Same semantics — Number.NaN is the explicit namespace form post-ES2015. CI lint_js was failing on this line. * fix(ci): drop leftover preview pre-delete steps after isolation merge The preview isolation refactor (#2025) removed the "Delete existing preview container/Worker" steps. Merging main into this branch auto-kept this branch's copies, leaving two steps that run `npx wrangler` from `workers/preview` with Cloudflare secrets in scope. That trips bin/preview_deploy_security_check.rb (PR-controlled working-directory, npx wrangler, secrets outside the deploy step), failing scan_ruby and, in turn, the preview deploy gate. Removing them realigns the workflow with main's isolated model. * Update preview-deploy.yml Signed-off-by: Guillem Arias Fauste <accounts@gariasf.com> * refactor(goals): squash migrations into single create_goals Collapse the 9 churned goals migrations (create savings_* tables, rename to goals, add icon, add pledges + enums, drop contributions, restrict the goal_accounts->accounts FK) into one create_goals migration that builds the final schema directly. Schema is unchanged. The concurrent transactions pledge-id index stays a separate migration because CREATE INDEX CONCURRENTLY cannot run inside a transactional migration. * fix(goals): use functional ring token in color picker The custom-color swatch used a raw ring-blue-500 palette utility while the preset swatches use ring-alpha-black-500. Switch to the functional token for design-system consistency. * feat(ds): extract DS::ProgressRing primitive; migrate goal card (#1899) Adds a DS::ProgressRing ViewComponent + Lookbook preview: a single-arc circular progress ring decoupled from any model (percent, size, stroke_width, tone, label, show_percent). It owns the geometry (radius / circumference / dash offset) and the accessible progressbar markup that callers were hand-rolling. Migrates Goals::CardComponent's inline <svg> to it (geometry methods removed from the component; status now maps to a tone). Rendered output is identical — same track token, success/warning/neutral arc colors, ±2 geometry. Scope (stacked on #1798, which is where the goal surfaces live): - Deferred: folding the goals/show ring (Goals::ProgressRingComponent) — it's rendered via the donut-chart D3 controller (segmented), a different shape, so it stays for now. - Deferred: the loan-overview ring (arrives with #1775) and the --budget-unused-fill → --color-progress-track-fill token rename (touches the budget donut surfaces + DS token source). DS::ProgressRing reuses the existing track token for now via DEFAULT_TRACK. --------- Signed-off-by: Guillem Arias Fauste <accounts@gariasf.com> Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Sure Admin (bot) <sure-admin@splashblot.com>	2026-06-03 00:05:44 +02:00
Guillem Arias Fauste	c274c5d8bb	fix(recurring): match transfer pairs so Cleaner stops mis-retiring transfers (#2110) ... Closes #1590. Implements Option A (the proper fix), replacing the interim skip. A recurring transfer's name is seeded as "Transfer to {dest}", but future occurrences carry arbitrary names (user free-text, importer wording, the auto-matcher), so the name-based matching_transactions returned [] and the Cleaner retired still-active transfers at the 6-month threshold. main worked around this by skipping transfer rows entirely (Option B) — which also meant a genuinely-stopped transfer never got retired. matching_transactions now detects the Transfer *pair* for transfer rows: an outflow on the source account paired with an inflow on the destination account, within the usual amount/cadence window. The Cleaner no longer skips transfers: - a transfer whose pair still occurs keeps surfacing recent matches → stays active - a transfer whose pair has stopped → correctly retired The amount / day-of-month scopes are extracted and shared between the name-based and pair-based paths. The Identifier's separate transfer skip (auto-identifying pairs from history) is intentionally untouched — that's the out-of-scope feature the issue defers.	2026-06-03 00:04:32 +02:00
Guillem Arias Fauste	e232818e97	chore(ds-pill): migrate budget-category status badges to DS::Pill (#1751) (#2111) ... A bounded slice of #1751: the three over/near-limit/good status badges in budget_categories/_budget_category were hand-rolled pill spans using raw palette colors (bg-red-500/10 text-red-500, bg-yellow-500/10, bg-green-500/10), breaking the design-token rule. Their icon(color: "red"/"yellow"/"green") args were also no-ops — the icon helper has no such keys, so the glyphs just inherited the span's text color. Replace all three with DS::Pill(marker: false, tone:, icon:), which renders the icon + label on a semantic soft-tone background using DS tokens (AA contrast). Scoped to one budget file on purpose — avoids the transactions / providers / transfer_match callsites covered by in-flight pill-migration work.	2026-06-03 00:03:15 +02:00
Guillem Arias Fauste	d22ffe5994	fix(ds-pill): default show_dot per mode (badges clean, markers keep dot) (#2107) ... Closes #2001. DS::Pill defaulted show_dot: true for both modes, so every status/category badge got a leading dot by default — redundant with the pill shape + tone + label already carrying the signal, and noisy in dense lists. More than half the marker:false callsites were already passing show_dot: false to fight it. The default is now mode-aware: marker: true keeps the dot (stage markers), marker: false (badges) is dot-less. An explicit show_dot: still wins. Only one in-tree callsite relied on the old default without an icon and wants the dot: settings/providers/_status_pill (live connection state) — pinned with show_dot: true. The enable_banking "Beta" badge loses its dot, which is the desired outcome (ref #1997). Icon-bearing transaction badges are unaffected (an icon already suppresses the dot). Left the now-redundant show_dot: false overrides in place to avoid churn and conflicts with in-flight pill-migration branches; they're harmless (explicit false == new default). Adds tests pinning the per-mode default resolution; updates the Lookbook preview to show the opt-in dot vs the clean default.	2026-06-03 00:01:38 +02:00
Guillem Arias Fauste	998cfd61d6	refactor(charts): extract shared chart-tooltip className to one source (#2106) ... Closes #2011. time-series and sankey each created their cursor-following tooltip with a duplicated className literal that had already drifted apart: time-series was missing `text-primary` and `z-50`. Move the visual contract into app/javascript/utils/chart_tooltip.js as CHART_TOOLTIP_CLASSES and have both controllers reference it. Each keeps its own behavioural classes (time-series its initial `opacity-0`; both `top-0`; sankey toggles opacity via inline style). `privacy-sensitive` stays bundled so future copies can't drop it. Also exports a createChartTooltip factory for the raw-DOM idiom. goal_projection_chart_controller is not in main yet (it lands with the goals work in #1798); it migrates to the same symbol there.	2026-06-02 23:59:55 +02:00
Kelvinchen03	e15ae5b23a	fix: replace hand-rolled badges with DS::Pill in admin users view (#1988)	2026-06-02 22:08:10 +02:00
Juan José Mata	b70d4744cc	Bump versions by hand	2026-06-02 21:47:51 +02:00
Brad	1b8b21760b	feat(provider): Akahu integration (#1921) ... * First pass of Akahu * fix up sync all * conflicts * fix db migration issue? - fix auto selection of akahu account type * Address Akahu PR feedback * Complete provider metadata * Fix PR 1921 CI tests * PR feedback * PR feedback * post merge --------- Co-authored-by: failing <failing@users.noreply.github.com> Co-authored-by: Juan José Mata <jjmata@jjmata.com> Co-authored-by: sure-admin <sure-admin@splashblot.com>	2026-06-02 21:44:57 +02:00
ghost	53e831039d	perf(sparklines): avoid full account loads for linked charts (#2128) v0.7.2-alpha.2	2026-06-02 18:47:09 +02:00
Jeff	1e818e5c6d	fix(migrations): scope admin-backfill to a MigrationUser model (#1716) (#1871) ... * fix(migrations): scope admin-backfill to a MigrationUser model (#1716) `bin/rails db:migrate` on an empty database aborts at `20240520074309_add_admin_role_to_current_users.rb` because `User.update_all` loads the production User class, which declares `enum :ui_layout` for a column added by a much later migration (`20251030140000_add_ui_layout_to_users`). The enum macro then raises `Undeclared attribute type for enum 'ui_layout' in User` and every subsequent migration is skipped, leaving the DB in a partial state. Apply the same MigrationUser pattern already used by `AddUiLayoutToUsers` — a migration-scoped subclass of `ApplicationRecord` with only the table name set, so it doesn't load the production enum declarations. Closes #1716 * fix(migrations): inherit MigrationUser from ActiveRecord::Base, not ApplicationRecord (#1716) @jjmata + @JSONbored both flagged that the nested MigrationUser inherited from ApplicationRecord, which can pull in concerns / callbacks / default scopes added to ApplicationRecord in the future and re-introduce the exact loading problem this migration is meant to avoid. Switch to ActiveRecord::Base — the idiomatic Rails pattern for migration-only models — and extend the inline comment to record the rationale. --------- Co-authored-by: jeffrey701 <jeffrey701@users.noreply.github.com>	2026-06-02 15:55:05 +02:00
Guillem Arias Fauste	3508f70582	feat(goals): balance-derived + pledges (#1798) ... * feat(savings): add savings goals Adds a standalone Savings goals feature: a piggy-bank style tracker that lets a family set a target, link one or more Depository accounts as funding sources, and log manual contributions over time. Supersedes #1569 (closed) — same intent, redesigned per reviewer + Discord feedback. What this adds: - New `/savings_goals` sidebar entry (piggy-bank icon) with index, show, state-filtered tabs (all/active/paused/completed/archived), and a 2-step modal stepper for creation (Identity → Review). - Multi-account funding via a `SavingsGoalAccount` join: a goal requires ≥1 linked Depository account (checking/savings/HSA/CD/money-market), and all linked accounts must share the goal's currency. - Tracker balance model: goal balance = SUM(contributions.amount). No auto-flow from account balances. Contributions are pure logical records and don't move money between accounts. - Manual contributions modal scoped to the goal's linked accounts. Initial contributions seeded at creation can't be deleted; manual ones can. - AASM lifecycle: active / paused / completed / archived. Hard-delete only after archive. - Status pills (On track / Behind / Reached / No date) derived from pace vs target_date. - AI Assistant tool `create_savings_goal` lets the sidebar chat create a goal end-to-end from a natural-language prompt; soft errors carry the available-accounts list back to the LLM (mirrors the existing `import_bank_statement` pattern). - Family-scoped throughout (`Current.family`-only access, account family-scoping enforced both in controllers and the AI tool). - Demo data seed wires up 4 sample goals across the Depository accounts. Intentionally out of scope (separate PRs / v1.1): - Auto-fund from budget surplus + Sidekiq cron + budget-show card. - Dashboard "Savings goals" widget. - "Behind pace" projection chart on the detail page. - `evaluate_savings_goal_feasibility` LLM tool (level-setting before create_savings_goal). - Spend-less goals inside Budgets. - Family-member-private goals (deferred investigation). * fix(savings): DS conformance pass on stepper, ring, card, status pill - StatusPill: use functional `text-success` / `text-warning` tokens with matching icon colors and `px-2 py-1`, mirroring `app/views/budget_categories/_budget_category.html.erb:29-43`. - ProgressRing: rework center text to match `_budget_donut.html.erb` (small "Saved" label, `text-3xl font-medium` headline, "of $X" underline). Stroke color now derives from goal.status (yellow when behind, blue on track, green reached, gray for no-date). - GoalCard bar: track height + transition match budget category bar (`h-1.5`, `transition-all duration-500`, `inline-size`). - Index/show layouts: render page header inline (`<h1>` + actions). The default application layout doesn't yield `:page_actions`, so the CTA + kebab menu wouldn't appear when emitted via `content_for`. - Stepper review summary: target the actual form inputs by `name` rather than relying on the `data-target` Stimulus attribute, since `money_field` puts the attribute on the wrapper. Step 1 validation scoped to the step 1 panel. - Demo generator: filter Depository accounts via `where(accountable_type: "Depository")` — Rails delegated_type generates the `depository?` predicate, not a `.depository` scope. * feat(savings): rebuild UI to match Claude Design + adopt shared donut-chart Previous savings goals UI looked nothing like the Claude Design output (see sure-design-context/design/savings-goals/project/goals/*.jsx) and the hand-rolled ring did not match the segmented D3 donut used at app/views/budgets/_budget_donut.html.erb. This rewires the surface end to end. Donut chart: - SavingsGoal#to_donut_segments_json returns the same segment shape as Budget#to_donut_segments_json: filled portion in goal color, unused remainder as `var(--budget-unallocated-fill)`. Visual identity is now the same: segmented arc with cornerRadius and gap, courtesy of the shared `donut-chart` Stimulus controller and D3. - ProgressRingComponent renders a `data-controller="donut-chart"` div with the same default-content/inner-text pattern as `_budget_donut`. Index page (matches GoalsIndex.jsx): - Page header: title + "Save toward what matters." subtitle + "New goal" primary CTA right-aligned. - Summary strip card: total saved / target, overall bar, active goals, on-track ratio, behind count. - State filter rendered as DS::Tabs-style pill nav (`bg-surface-inset p-1 rounded-lg`, white-pill active state). - Cards rebuilt: avatar (44px, rounded-xl, white initial on goal color) + name + secondary line ("N days left · by date" / "No target date" / "Completed" / "Past due"), status pill with leading dot, big $current/$target line + percent, bar in status colour, AccountStack (overlapping initials) + "N accounts" + "to go". Goal detail (matches GoalDetail.jsx): - Header: 64px avatar + h1 name + status pill + "Target $X by date · N days left" subline + Edit (outline) + Add contribution (primary) + kebab (DS::Menu for AASM transitions). - Donut-chart ring card with stats overlay. - 4-col stat row (Avg monthly, Total contributions, Target date, Started) with mono numerals and "Needs $X/mo" / "Above target pace" sub-captions where relevant. - Two-col bottom: contributions list (avatar + account · date · source · green +$amount) and funding accounts breakdown (stacked bar + per-account row with $ and % of saved). New components: Savings::AccountStackComponent (overlapping account initials with ring-2 ring-container). StatusPillComponent now uses a leading colored dot instead of an icon. GoalAvatarComponent radii match Claude Design (rounded-md/lg/xl/2xl) and white initial. Locale: new keys under savings_goals.{index.subtitle, index.summary.*, goal_card.{accounts,days_left,completed,past_due,no_target_date}, show.header.*, show.ring.{of,to_go}, show.stats.*, show.funding_balance, show.of_saved, show.notes}. * feat(savings): match Claude Design — projection chart, target-icon modal, grouped funding accounts Brings the savings goals UI closer to the Claude Design reference shared by the user. Changes: - Sidebar nav label: "Savings goals" → "Savings". - Status pill copy: "Behind" → "Behind pace" (matches Pill component from GoalsCommon.jsx). - Empty state rewritten with a large target icon, "No goals yet" heading, and the descriptive body copy from the design. Goal detail page (matches GoalDetail.jsx): - New "← All goals" back link above the header. - 2-column hero: ring card on the left (320px column), Projection card on the right. - Projection card uses a new D3 Stimulus controller (`savings-goal-projection-chart`) that draws: · saved area + line from goal creation → today (solid, primary) · dashed projection segment from today → target date (yellow when behind, green when on track) · horizontal dashed target line with label · today marker (vertical dashed line + dot) Data shape comes from `SavingsGoal#projection_payload`. - Card subtitle generates a contextual sentence ("At $X/mo you'll fall short. Bump to $Y/mo to hit it on time." / "At your current pace you'll reach this goal around Month YYYY." / "Goal reached. Nice work.") with a strong tag highlighting the actionable figure. - Stat row now shows Linked balance (sum across linked accounts) + "N accounts" sub-caption instead of duplicate "Target date" stat. New goal modal (matches the design images 2 + 3): - DS::Dialog custom header: DS::FilledIcon target glyph + title + step subtitle ("Step 1 of 2 · Goal details" / "Step 2 of 2 · Review & start") that updates as the user advances. - Connected stepper at top of body: numbered circles connected by a bar, step-1 circle flips to ✓ when complete. - Step 1 heading "What are you saving for?" + supporting copy. - Name field paired with a target glyph affordance on its left. - Target amount + Target date in a 2-col grid. - Funding accounts list now grouped by account subtype with uppercase section headers (CHECKING / SAVINGS / HSA / CD / MONEY MARKET / OTHER), each row showing avatar + name + subtype + balance. - Step 2 heading "Looks good?" + Review card (goal target + funding accounts summary + suggested monthly = target/months_remaining), and a disclosure for the optional initial contribution. - Footer: "Cancel" left text-button (closes modal) / "Back" left text when on step 2; "Continue →" or "Create goal →" right arrow button. Demo generator: Depository accounts now set `subtype` ("checking" / "savings") on the accountable so they group correctly in the modal. Tests: all green, 35 runs in the savings suite, 92 assertions. * feat(savings): rebuild index to match Claude Design - Page header: title "Savings" + "Your savings accounts and the goals you're working toward." Removed the top-right New goal button (moves into the Goals section). - Hero card: "Total in savings" with sum-of-savings-subtype balance, 30-day delta vs last 30 days (Family#savings_balance_30d_delta), 3-stat sub-row (Accounts / Active goals / Saved toward goals), and a D3 sparkline area chart on the right (new `savings-sparkline` Stimulus controller, sourced from Family#savings_balance_series). - Accounts section: lists Depository accounts with subtype = "savings" as cards (blue avatar, name, subtype, balance, "Funds N goals"). New Savings::AccountCardComponent. - Goals section header: "Goals" + "Save toward what matters." + "New goal" button right-aligned to the section (not the page header). - Removed state-filter pill nav. Active goals render in the main grid; Completed goals get a "Completed · N" divider w/ check-circle icon and their own grid below. - Goal card layout reworked: horizontal bar replaced with a 64px donut ring on the right side of the card header (ring colour tracks goal.status — yellow=behind, primary=on-track, green=reached). Pill is inline with the goal name. - Status pill copy: "Behind pace" → "Behind". - Filter bar (copied from settings/providers): search input + status chips (All / On track / Behind / No date). Hidden when ≤ 6 active goals. Powered by `savings-goals-filter` Stimulus controller — toggles `.hidden` on cards by goal name + status. - Family#savings_subtype_accounts, total_savings_balance, savings_balance_series, savings_balance_30d_delta helpers; controller computes hero payload + account-goal counts for the cards. * fix(savings): refine hero spacing, goal/account card padding, sparkline negative range - Sparkline (`savings-sparkline` controller): dropped the `Math.max(0, yMin)` clamp on the y-axis domain so negative balances (or any series that dips into negative territory) render fully instead of being cropped off the canvas. - Hero card: padding `p-6` → `p-7`, column ratio `[minmax(0,1fr)_minmax(0,1.6fr)]` so the chart breathes, min height bumped to 220px, sparkline container `h-full min-h-[200px]` so it fills the card vertically. Stats row now sits at the bottom of the text column via `mt-auto pt-6`; labels promoted to `text-xs`, values to `text-lg`. - Section vertical rhythm: outer `space-y-6` → `space-y-8`. - Goal card: padding `p-[18px]` → `p-6`. Internal gap from header row to amount line `mt-3.5` → `mt-5`. Account-row gap `mt-3` → `mt-4`. - Account card: padding `p-5` → `p-6`. - Status pill "Behind" dot: `bg-yellow-500` → `bg-yellow-600` for a warmer/ambery tone matching the Claude Design reference. - Goal card donut "behind" stroke: `var(--color-yellow-500)` → `var(--color-yellow-600)` to match the pill. * fix(savings): add bottom padding so last card clears the mobile fixed bottom-nav * feat(savings): add "ONGOING · N" + "COMPLETED · N" section dividers Same pattern as the bank-providers page's `AVAILABLE · 3` header (see `app/views/settings/providers/_search_filters.html.erb` references): small uppercase tracking-wide secondary label, separator dot, tabular count. Replaces the prior "Completed · 1" inline label with a more consistent treatment and adds an "Ongoing · N" header above the active goals grid. Name choice: "Ongoing" rather than "Active" because the grid includes both `active` and `paused` AASM states; "ongoing" reads as still-in- progress for both. Parallel to the existing "Completed" sibling. * fix(savings): bump space between ONGOING/COMPLETED header and goal grid * fix(savings): rebalance spacing — moves the gap onto the grid, not the header Previous attempt put `mb-5` on the section header so the goal grid sat ~20px below it, but that also pushed the "No goals match" empty card down because it shares the same header. Margin collapse meant the empty card's own `mt-3` was getting added to the new big header `mb`. Rework: header back to `mb-2.5`, grid gets `mt-3` of its own. Empty card keeps its `mt-3`. Both children collapse to ~12px below the header now, which matches the breathing room the empty card had before this thread of edits. * fix(savings_goals): equalize ONGOING/COMPLETED header spacing across cards and empty state Move section gap from per-child mt-3 to a single mb-4 on the header, and toggle the grid wrapper hidden when no cards are visible. The previous markup gave inconsistent ONGOING-tag-to-content distance because the empty card sat below a 0-height grid, stacking margins differently than the cards layout. * fix(savings_goals): update ONGOING count when filtering by status or search The "ONGOING · N" badge was server-rendered with @active_goals.size and never re-synced when the Stimulus filter hid cards. Add a count target and update it alongside the existing empty/grid toggles. * feat(savings_goals): replace hero card with KPI strip + differentiate empty states P1: drop the sparkline + the single mixed hero. Hero became 3 separate KPI cards (Contributed last 30d, Needs this month, Goals on track), matching the Transactions page pattern. Each KPI answers a question the user opens the page asking — saving rate, this-month action, overall health. P3: empty state copy + CTA now reflect the reason it is empty. Search returns 0 → "No goals match X" + Clear search. Chip set to non-all → "No goals match this filter" + Show all. Both → both reasons + both buttons. Drop: total_savings_balance, savings_balance_series, savings_balance_30d_delta on Family (no other consumers). Add: Family#contribution_velocity(range:). * feat(savings_goals): status pill icons + paused variant, attention-first sort, paused chip, rename "No date" to "Open-ended" P4: status pills now carry an icon alongside the colored tint (circle-check / triangle-alert / star / infinity / pause), so color is no longer the sole signal. Drop the redundant dot. P4: default sort on the active goals list becomes attention-first — behind → on_track → no_target_date → paused, alphabetical within bucket. The user opens the page and lands on the goals that need them. P5: add a Paused filter chip + render paused goal cards with opacity-75 so they read as inactive at a glance. Rename "No date" chip to "Open-ended" — clearer to non-jargon readers. * feat(savings_goals): goal card pace + status-driven footer Each card now answers "what's my next move" without clicking into the detail page. Under the amount/target row, a pace line shows actual avg contributions vs the monthly target. The footer (previously "$X left") switches by status: - behind → "Save $Y/mo to catch up" - on_track → "Last contribution Nd ago" (or "today" / "No contributions yet") - reached / completed → "Goal reached" - no_target_date → "No deadline set" - paused → "Paused" Add SavingsGoal#last_contribution_at and #last_contribution_days_ago. Both these methods and average_monthly_contribution now respect a loaded :savings_contributions association so the index page doesn't N+1. Controller eager-loads :savings_contributions + :linked_accounts. * feat(savings_goals): drop Accounts section from index The Accounts grid duplicated the sidebar account list. Removing it gives the Goals section more breathing room and the page a tighter narrative: header → KPIs → Goals. Delete Savings::AccountCardComponent, Family#savings_subtype_accounts, the @savings_accounts / @account_goal_counts controller refs, and the related locale keys. Sidebar still shows the savings-subtype Depository accounts under "Cash" — no information is lost. * feat(savings_goals/new): drop required asterisks, hide currency, collapse notes, clean footer P1 of modal refactor — visual fidelity baseline against the Claude Design reference and refactoring-ui rules. Drop required: true on name + target_amount (suppresses both the red `*` indicator and the browser-default HTML5 validation tooltip). Client-side validation moves into the Stimulus stepper in a follow-up commit. Pass hide_currency: true on the money_field so single-currency families don't see a redundant inline currency dropdown. Wrap the Notes textarea in a <details> disclosure ("Add notes (optional)" summary) so step 1 isn't padded with rarely-used fields. Drop the footer top border-subdued divider so the action row floats against the dialog's existing padding boundary. Drop the view-layer SavingsGoal::COLORS.sample fallback on hidden color field — the controller already seeds @savings_goal.color. * feat(savings_goals/new): live previewable name avatar + ghost cancel + circular header icon Replace the big square DS::FilledIcon next to the name input with a small Savings::GoalAvatarComponent that previews the goal's avatar (seeded color + first character of the typed name, updates live via new stepper#nameChanged action). Switch the modal header's target avatar from FilledIcon(size: lg, rounded: false) → (size: md, rounded: true) — matches the goal-avatar shape used elsewhere on the page. Replace the hand-rolled <button> for Cancel/Back with DS::Button variant: "ghost". Stepper now drills into the button's inner span to swap the label, same pattern already used for the Continue/Create button on the right. Drop the now-unused footerLeftLabel target. * feat(savings_goals/new): deterministic account avatar color via name hash Replace the hardcoded var(--color-blue-500) on every funding-account row's avatar with a deterministic pick from Category::COLORS based on the account name's hash. Rows now read at a glance instead of melting into one blue column. * feat(savings_goals/new): inline per-field error state in stepper Drop the top-of-form server-error banner (kept only when model.errors on :base, which is rare) and stop relying on input.reportValidity() browser-default tooltips. Stepper validates step 1 manually when Continue is clicked: - name empty → red ring on input + "Please give your goal a name." below - target_amount ≤ 0 → red ring + "Set a target amount greater than zero." - no funding account checked → "Select at least one funding account." Each error clears as soon as the user fixes the field — typing in the name field clears the name error, entering an amount > 0 clears the amount error, checking any account clears the accounts error. Drop the now-unused flashLinkedAccountsRequired() shake; replaced by the per-field error pattern. * feat(savings_goals/new): checkbox styling, visible stepper, DS::Disclosure for notes, drop redundant cancel Use Sure's .checkbox checkbox--light classes on the funding-account check_box_tag — matches transactions / entries / settings pages. Stepper line: 2px tall bg-secondary in resting state (was 1px bg-subdued which disappeared in dark mode). Step 2 inactive circle: border-secondary outline instead of bg-container-inset fill — visible in both themes. Notes collapse switches from raw <details> to DS::Disclosure for consistency with the rest of Sure's DS. Drop the footer Cancel button — the close X in the modal header already handles that, and double cancel was redundant. The footer-left slot now only renders Back (with arrow-left icon) and only on step 2. * fix(savings_goals): status pill icons inherit pill's semantic color Pass color: "current" to the icon helper so triangle-alert / circle-check / star / infinity / pause render in the same color as the pill's text (text-success / text-warning / text-secondary). The icon helper defaults to text-secondary, which made all icons grey regardless of pill variant. * fix(savings_goals/new): name field uses .form-field wrapper for floating label Drop the outer <label>Name</label> heading + label: false on the text_field, and pass label: t(...) + container_class: "flex-1" so styled_form_builder wraps the name input in Sure's standard .form-field component. Label now sits inside the input box, matching the new transaction modal pattern (and every other styled_form_with form across Sure). The avatar still sits as a sibling outside the box, flex-aligned center. * fix(savings_goals/new): stepper line uses border-secondary token bg-secondary is not a registered Sure utility, so the previous h-0.5 bg-secondary div rendered with no background — the line was just a transparent slot, barely visible in either theme. Replace with border-t-2 border-secondary on the connector div, and toggle border-inverse / border-secondary on step transition. Both classes are real Sure tokens with proper light/dark variants (alpha-black-200 / alpha-white-300 for border-secondary). * fix(savings_goals/new): notes textarea uses .form-field wrapper Passing label: false to f.text_area stripped the .form-field container, leaving a naked textarea with no border or visible label inside the DS::Disclosure. Pass a real label ("Notes (optional)") so styled_form_with wraps it like every other textarea in Sure (transactions/_form.html.erb, trades/show.html.erb, etc.). Bump rows to 3. * fix(savings_goals/new): step 2 back button inline + form-field wrappers on initial-contribution inputs DS::Button treats "hidden" as a display override class — adding class: "hidden" stripped the base inline-flex display, so when Stimulus later removed the hidden class the icon and text stacked vertically. Wrap the Back button in a hidden <div> and toggle the wrapper instead; the button keeps its inline-flex base. The Amount + From-account inputs in step 2 used label_tag + number_field_tag / select_tag directly with no .form-field wrapper, so they rendered as bare inputs (same issue Name had in step 1). Wrap each in .form-field > .form-field__body with form-field__label and form-field__input classes — matches the styled_form_with pattern used by Target amount / Target date in step 1. * feat(savings_goals/new): step 2 initial-contribution amount uses money_field Add virtual attr_accessors for initial_contribution_amount and initial_contribution_account_id on SavingsGoal so the form builder can bind to them without the model needing real columns. Replace the raw number_field_tag with f.money_field hide_currency: true so the field shows the currency symbol prefix and step-aware precision, matching the Target amount field in step 1. * feat(savings_goals/show): cleanup — drop misleading stats, hide add-contrib when reached, last-contribution recency D1 — Drop the "Linked balance" stat. It summed the linked accounts' total balances (e.g. $204K) rather than the amount saved toward the goal ($1K), so it overstated progress by ~200x. Replace with a "Target pace" card showing required $/mo. D2 — Drop the redundant "← All goals" link. The breadcrumb nav above the header already shows Home › Savings Goals. D3 — Hide the Add-contribution button on reached / completed goals. Logically you don't keep contributing after the goal is done. D5 — Add last-contribution recency to the header sub ("Last contribution 3d ago"), matching the goal card footer pattern from the index refactor. D11 — Stat row now 3 cards instead of 4 (avg monthly, total contributions, target pace). Drop the "Started" card — low-signal for new users. * feat(savings_goals/show): catch-up callout for behind goals For behind (non-paused) goals with a target_date, render a DS::Alert warning under the header surfacing the actionable insight from the index card: "Save $X/mo to catch up · Bump your monthly contribution to stay on track for <date> · [+ Add $X]". The CTA prefills the contribution flow with the target monthly amount in the button label so the user sees exactly what to commit to. Mirrors the goal-card footer pattern shipped during the index refactor — the detail page now carries the pace narrative forward instead of hiding it inside the projection paragraph. * feat(savings_goals/show): status-specific hero card + paused/archived banners D6 — Paused goals render a top info banner ("This goal is paused" + [Resume goal]) before the hero. Archived goals get the same treatment with a Restore CTA when applicable. D8 — No-target-date goals replace the empty projection chart with a focused prompt card: calendar-plus icon, "Add a target date" heading, short copy, and a "Set target date" CTA that opens the edit modal. Stops wasting the right half of the hero on an unrenderable chart. D9 — Reached / completed goals replace the projection chart with a celebration card: party-popper green icon, "Goal reached. Nice work." heading, target-hit confirmation copy, and an "Archive goal" CTA when the state machine allows it. The original projection chart still renders for behind / on_track goals with a real target_date — that's the only case where it adds value. * feat(savings_goals/show): combo monthly-pace stat card D7 — Merge the separate Avg-monthly and Target-pace cards into one wider "Monthly pace" card spanning 2/3 of the stat row. Shows actual $/mo + target $/mo inline, with a delta line below: - behind → "Behind by $X/mo" (text-warning) - on/ahead → "Above target pace" (text-success) - no target_date → "No required pace" Total contributions stays as a separate, smaller card at 1/3 width. The action pyramid finally points at the actionable stat — pace is visually primary, raw count secondary. * feat(savings_goals/show): scrollable contributions list + hide pace card for reached goals D10 — Drop the silent .limit(50) on the contributions query and put the list in a max-h-[480px] scrollable container. Goals with many contributions now show all of them without truncation, but the page stays compact via the inner scroll. Polish — reached / completed goals no longer render the combo monthly- pace card. After the goal is hit, comparing actual vs required pace is moot (and target $0/mo · Above target pace was awkward filler). Only the Total contributions card remains in the stat row. D12 (clickable contribution rows) deferred — adding a dedicated contribution detail/edit route adds enough scope to warrant its own ticket. The per-row delete X already covers the only mutation people need from this view. * fix(savings_goals/show): chart contrast, breadcrumbs, contributions list polish Chart — Sure's "text-X" / "border-X" tokens are Tailwind utility classes, not CSS custom properties, so var(--text-secondary) etc. resolved to empty inside SVG attributes. Read data-theme on draw and pass real hex colors (textPrimary, textSecondary, borderSubdued, containerBg) into d3 fills/strokes. "Target · $X" label and axis tick labels now have proper contrast in both themes. Breadcrumbs — set @breadcrumbs in the show action so the layout renders Home › Savings › <goal name> with the middle entry clickable back to the index. Matches the convention used by imports / reports / family exports. Contributions list — drop the broken divide-y divide-subdued (Tailwind divide- utilities don't pick up Sure's semantic border tokens). Switch to space-y-3 rows matching the funding-accounts breakdown component. Drop the border-b separator under the heading; the card now reads as one continuous panel. Move the delete X to hover-revealed and reserve an inert spacer for non-manual rows so the right column stays aligned. * feat(savings_goals): demo variety, breadcrumb naming, ring token, list pattern, header split, tone down behind noise Demo — extend generate_savings_goals! with three more goals to exercise status-specific UX: Wedding fund (on_track w/ 6 months of contributions matching required pace), Sabbatical (paused), Old laptop fund (archived). House downpayment gains 12 contributions so the scrollable list has real density. Total now 7 demo goals covering behind / on_track / no_date / paused / archived / reached. Breadcrumbs — set @breadcrumbs on index too (it was relying on the Rails-derived "Savings goals" label). Both views now read "Home → Savings → ..." consistently, matching the sidebar nav text and H1. Ring token — goal-card ring stroke switched from var(--color-gray-200) (a hard light color identical in both themes) to var(--budget-unallocated-fill) which is gray-50 light / gray-700 dark, matching the detail page's progress ring. Contributions list — replace the inline hover-revealed delete-X with DS::Menu kebab, matching tags/_tag.html.erb and categories/_category. Each row also gets hover:bg-surface-hover with a px-3 -mx-3 negative margin to extend the hover area across the card padding. Non-manual contributions render a 9x9 spacer so the right column stays aligned. Header sub split — drop the long "·" chain into two lines: primary fact (target / days left) in text-secondary, recency note in text-subdued underneath. Less wall-of-text. Behind noise — pill, ring, catch-up alert and projection chart already signal "behind". The Monthly-pace combo card's "Behind by $X/mo" delta no longer renders in text-warning — it switches to text-subdued so the warning palette doesn't repeat across the page. The catch-up alert stays loud because it's the primary action; the rest stays informational. CustomConfirm wired with destructive: true on the contribution delete so the confirm button gets the outline-destructive treatment. * fix(savings_goals): ring on_track color, contributions horizontal scroll, modal restored on back, chart saved fill Ring on on_track / no_target_date goal cards rendered with no progress arc — ring_color returned var(--text-primary) / var(--text-subdued) which aren't real CSS custom properties (Sure's text tokens are Tailwind utilities). Switch to var(--color-green-500) / var(--color-gray-400) which ARE CSS vars from the Tailwind palette and resolve at SVG fill time. Contributions list had a horizontal scrollbar because the rows used -mx-3 px-3 to extend the hover background, which pushed content beyond the card padding. Drop the negative-margin trick and add overflow-x-hidden to the scroll container. Rows still hover-highlight inside the card bounds. Modal cache restoration — Turbo cached pages with open <dialog> elements inside <turbo-frame id="modal">. After dismissing the new-goal modal and navigating to a goal detail page, browser back restored the cached index page WITH the dialog still in the modal frame; the dialog's Stimulus controller then ran auto-open and reopened it. Now the dialog close handler empties the parent modal turbo-frame so the cache snapshot is clean. Chart saved-fill — bump area gradient stop-opacity 0.10 → 0.22 so the contribution history is more visible against the dark canvas. Chart was rendering correctly but the white-at-10%-opacity gradient was too faint to read on top of the dashed projection. * fix(savings_goals/show): chart axis includes backdated contributions, legend uses real colors projection_payload's start_date was created_at, but demo seeds (and manual imports) can have contributions backdated before created_at — those points were getting clipped/pushed left of the chart's x-domain and the saved-series line couldn't render. Use min(created_at, earliest contribution date) so the axis spans the full history. Legend "saved" line stroke was var(--text-primary) which doesn't resolve (Tailwind utility, not CSS var) → invisible swatch. Wrap in text-primary span + stroke="currentColor". Legend "projection" line was hardcoded yellow — chart paints green for on_track goals → mismatch. Pick legend color based on goal status so it matches what the chart actually draws. * fix(savings_goals): neutral ring percent, chart start vertical-line, contribution select wrapper, deterministic account colors Ring percentage no longer takes the warning yellow tint when behind — the colored ring stroke + status pill + catch-up alert already signal the state, doubling it on the percent number was noise. Reached stays green (celebratory), everything else uses text-primary (white/dark). Chart vertical line at the left edge was the (start_date, $0) point the controller prepended to the saved series. When start_date equals the first contribution date (now common after the earlier earliest- contribution fix), this drew a vertical jump from $0 to first contribution at x=start. Skip the prepend when there's no temporal gap so the line starts at the first real point. Add Contribution modal — wrap the source-account select in the styled form-field via f.select instead of label_tag + bare select_tag. Match the rest of Sure's form controls. Also pass hide_currency on the amount field so single-currency families don't see a redundant USD dropdown. Account avatar colors — replace Ruby String#hash (randomized per process by Ruby for DoS protection) with a deterministic MD5-based pick from Savings::GoalAvatarComponent::PALETTE. Same account name now resolves to the same color across processes and across components. Apply via a new Savings::GoalAvatarComponent.color_for helper used by both the form stepper account list and the goal-card AccountStackComponent (which was hardcoding blue-500 for every avatar in the stack, hence Chase + Ally looking identical on the wedding card). * fix(savings_goals/show): contributions list + funding accounts breakdown use per-account deterministic color Both used goal.color for every account avatar, so every linked account ended up the same color as the goal. Sure's convention elsewhere (accounts/_logo.html.erb) is accountable.color (type color: Depository → purple) — but savings goals only link Depository accounts, so that would still collapse to one color. Reuse the deterministic Savings::GoalAvatarComponent.color_for(name) helper from the index card stack instead. Same account always resolves to the same color across processes, and multiple accounts on the same goal read as distinct. Funding-accounts breakdown bar at the top now also colors each segment by account so the proportions are visibly typed (not a single goal- color block). * fix(savings_goals): projection chart redraws when container resizes (Turbo navigation) After submitting a new contribution, Turbo's redirect-replace stream swaps the page; the chart's data-controller reconnects but the container's clientWidth can momentarily be 0 (parent grid hasn't laid out yet). The early-bail in _draw left the SVG empty and nothing triggered another draw, so the chart stayed blank. Add a ResizeObserver to the controller. The observer fires once the container settles into a real size and re-runs _draw, which now paints the chart correctly after the post-submit navigation. * perf(savings_goals/show): preload + memoize cut show from 17 to 5 queries - set_savings_goal: with_current_balance + includes(savings_contributions: :account, linked_accounts: []) so contributions / accounts / current balance don't re-query inside helpers and view partials - SavingsGoal#status + #average_monthly_contribution: defined?(@ivar) memoization so the 5+ callsites per show (header banner, projection_summary, donut, goal-card pace, stats_for) don't recompute the exists?/MIN/SUM triplet each time - SavingsGoal#projection_payload: sort loaded contributions in Ruby instead of running a fresh ORDER BY - SavingsGoalsController#show: replace .chronological re-query with in-memory sort over the preloaded association - funding_breakdown_for: group_by + transform_values off the loaded collection instead of an extra GROUP BY SQL - stats_for: contributions_count uses .size to read the loaded cache instead of issuing COUNT(*) * a11y(savings_goals): ARIA semantics + unique IDs + h2 hierarchy - Projection chart SVG: role=img + <title> + <desc> wired through new ariaLabelValue / ariaDescriptionValue Stimulus values. Show.html.erb passes a localized chart label and a strip_tags'd projection summary. - Progress ring container: role=progressbar + aria-valuenow/min/max + aria-label so screen readers announce "Goal 27% complete. $13,250 of $50,000 saved." instead of four disjoint spans. - Funding-account checkboxes (stepper step 1): explicit per-account id ("savings_goal_account_ids_<id>") so each row has a unique DOM id; duplicate-id HTML violation gone. - show.html.erb: <h3> -> <h2> at six section headings (celebration, no-target-date, projection, contributions, funding accounts, notes) so the heading hierarchy is h1 -> h2, not h1 -> h3. - goal_avatar + account_stack components: aria-hidden=true on the decorative wrappers; the textual goal/account name beside them is always read separately so the SR no longer prefixes every entry with the avatar initial. - New locale keys: savings_goals.show.ring.aria_label and savings_goals.show.projection.aria_label. * fix(savings_goals/new): trap Enter on step 1; add funding-accounts hint - Pressing Enter inside a step-1 input (Name, Target amount, Target date) used to fire the form-implicit-submission against the sr-only submit button, jumping straight to POST /savings_goals and skipping step 2 entirely (no initial contribution, no review). - New blockEnter action on the form re-routes Enter to next() when currentStep === 1, mirroring the Continue button. Notes textarea is exempt so newlines work. - Add an inline hint under the funding-accounts label so users know up front what the field controls; previously the only feedback was a tiny "must pick one" error after Continue. * feat(savings_goals/chart): theme-follow palette, axis format, Today + ETA labels - MutationObserver on <html>[data-theme] re-runs _draw() when the user toggles theme so the chart's hex-resolved-at-draw-time colors follow the surrounding dark/light card surface (previously stuck on initial palette until a full page reload). - Axis tick format: "%b %y" → "%b '%y" (Jan '26) to disambiguate from a day-of-month; tick divisor 110 → 80 so 375-wide mobile gets enough ticks; post-process to drop adjacent equal labels for short windows. - Today vertical line: small "Today" label above it on widths >= 320. - Projection segment: end dot in the projection color + a short-format label ("$42K" or "Short $7.9K"). Labels suppressed at < 320 width to avoid colliding with the Target line label. - New _fmtMoneyShort helper: K/M shorthand. Plain prefix; full i18n / Intl.NumberFormat tracked as a long-term follow-up. * chore(savings_goals/stepper): use Number.parseFloat / Number.NaN per Biome biome lint --write picked these up while auditing the chart changes. Pure rename, no behaviour change. * fix(savings_goals/show): dedupe ring labels, DS::Button banners, status-pill contrast - progress_ring_component: drop the in-ring "$saved / of $target" lines. The same money pair already renders directly below the ring in show.html.erb (now the single source). Inside the ring keeps only "Saved" + percent. - show.html.erb: replace 3 hand-rolled button_to CTAs (Paused banner "Resume goal", Archived banner "Restore goal", celebration card "Archive goal") with DS::Button so focus/hover/disabled match the rest of the app. variant: primary/outline, size: sm, method: :patch. - status_pill_component: swap text-success / text-warning / text-secondary to text-green-700 / text-yellow-700 / text-gray-700 so all 5 light-mode pill variants pass WCAG 4.5:1. Local override pending the upstream DS token fix tracked at we-promise/sure#1736. * fix(savings_goals/empty_state): pass return_to so user lands back on /savings_goals after adding an account The "Add an account" CTA on the no-depository-accounts empty state now appends ?return_to=/savings_goals. StoreLocation already stashes the param into session via the global before_action; the consuming side (subtype #create actions) honouring it is tracked at we-promise/sure#1766. * fix(savings_goals): use display_status for inactive goals; hide pace + projection - SavingsGoal#display_status returns :archived / :paused before falling through to the visualization status. Memoized like #status. The plain #status method keeps its meaning (visualization vs. target/pace) so callers that genuinely want "is this on track" — KPI sort, goal-card ring color, projection_payload — keep working unchanged. - Savings::StatusPillComponent: status_key uses display_status; new :archived variant (bg-surface-inset / text-gray-700 / archive icon). Previously an archived goal showed "Behind" on the detail page while the archived banner said the goal was archived — conflicting signal. - show.html.erb: paused/archived goals render a static recap card (current saved vs target) instead of the projection chart. Pace stat (avg vs required monthly) is also hidden — extrapolating "Behind by $X/mo" against a goal that isn't accepting contributions is misleading. - New locale keys: savings_goals.status.archived, savings_goals.show.inactive.{heading_paused, heading_archived, body}. - Tests cover display_status for archived / paused / active goals. * fix(savings_goals/show): stack header on mobile so long names + actions don't collide - header: flex-col on <sm (stacks title block + action group), flex-row from sm up. Action group keeps its row on desktop, wraps below the title block on phones. - Title row: flex-wrap so the status pill drops to a second line on narrow widths instead of squeezing the h1. - h1: drop truncate, use break-words + min-w-0 inside the flex chain so long names like "Investment property downpayment" wrap legibly instead of clipping to "House …" on 375px. - Action group: flex-wrap + sm:shrink-0 keeps Edit / Add contribution / kebab readable when they have to share a line with the title block at the sm breakpoint. * fix(savings_goals/show): drop row hover so the kebab's own hover registers Both the row and the kebab carried hover backgrounds (bg-surface-hover on the row, bg-container-inset-hover on the icon button). The two are near-identical shades, so the button's hover state was visually invisible on top of the row's. Removing the row hover lets the kebab be the sole affordance. * feat(savings_goals/index): collapsed Archived section + archived-aware card - Controller: @archived_goals exposes state=archived rows already pulled by the all_goals load. No extra query (sliced from the existing array). - Index template: <details> disclosure under "Completed" so archived goals are reachable from the list without cluttering the active / completed sections. Collapsed by default. - GoalCardComponent: uses display_status for the data attribute (so the card on the index reads as Archived instead of Behind), opacity-75 applies to archived too, footer_line short-circuits to "Archived" and pace_line returns nil. Matches the show-page archived semantics shipped earlier. - Locale: new savings_goals.index.archived_section.heading and savings_goals.goal_card.footer_archived. * refactor: rename Savings Goals feature to Goals User-facing rename + structural rename. Feature is now called just "Goals" everywhere — page title, sidebar nav, modal headings, flash messages, AI assistant tool. Code identifiers follow: - Models: SavingsGoal → Goal, SavingsContribution → GoalContribution, SavingsGoalAccount → GoalAccount. - Tables: savings_goals → goals, savings_contributions → goal_contributions, savings_goal_accounts → goal_accounts. FK columns savings_goal_id → goal_id. New migration db/migrate/20260511100003_rename_savings_to_goals.rb uses rename_table + rename_column; PG handles index renaming and FK redirection automatically. - Controllers: SavingsGoalsController → GoalsController, SavingsContributionsController → GoalContributionsController. - Routes: /savings_goals → /goals, nested /goals/:id/contributions (resource name shifts; old route name aliases dropped). - ViewComponent namespace: Savings::* → Goals::*. Component class names drop their redundant "Goal" prefix where the namespace already carries it: Savings::GoalCardComponent → Goals::CardComponent, Savings::GoalAvatarComponent → Goals::AvatarComponent. Others keep their names (Goals::ProgressRingComponent, Goals::StatusPillComponent, Goals::AccountStackComponent, Goals::FundingAccountsBreakdownComponent). - Stimulus controllers: savings_goal_* → goal_*, savings_goals_filter → goals_filter. Stimulus identifiers in data-controller / data-* attributes follow. - Locale keys: savings_goals: → goals: (top level), savings_contributions: → goal_contributions: (top level). All t() callers updated. - AI assistant tool: Assistant::Function::CreateSavingsGoal → Assistant::Function::CreateGoal, tool name "create_savings_goal" → "create_goal", description / response text updated. - Sidebar nav label "Savings" → "Goals". Goals/show + index page title "Savings" → "Goals". Empty goals_section heading/subtitle dropped (duplicated the page title post-rename). Original migrations create_savings_goals / create_savings_goal_accounts / create_savings_contributions remain untouched so historical replay still works; the rename migration runs on top. * perf+ux(goals): grouped state-count + friendly 404 for stale/cross-family deep links - index: STATE_FILTERS count loop replaced with single Current.family.goals.group(:state).count + per-state lookup. 5 SQL queries -> 1. - GoalsController + GoalContributionsController: rescue_from ActiveRecord::RecordNotFound -> redirect_to goals_path with a flash. Affects stale deep links AND cross-family access (previously bare 404 -> Chrome error page). Test for cross-family access updated to assert the redirect + flash key. - New locale key goals.errors.not_found. * ux(goals): unify "Open" for no-target-date status across all surfaces One status, four phrasings before this commit: - status pill: "No date" - filter chip: "Open-ended" - goal-card secondary line: "No target date" - goal-card footer: "No deadline set" Plus KPI strip sub-count: "open-ended". Pick "Open" everywhere so the status reads identically wherever it surfaces. * ux(goals/show): catch-up consolidation + confirm dialogs on archive / mark complete A — Catch-up math triple-encoding. The catch-up amount (e.g. $1,531/mo) was rendered verbatim in three places: the banner title, the projection card subtitle, and the pace stat ("target $X/mo"). Only new information anywhere was the buried "Behind by $Y/mo" delta in pace-card subtext. - Banner body now carries the delta: "...currently $Y/mo behind." - Projection sentence drops the "Bump to %{required}/mo" restatement; reduces to "At %{current}/mo you'll miss your target date." Chart aria-description benefits from the simpler phrasing too. - Pace stat drops the "· target $X/mo" sub-line. Pair becomes "$avg/mo" + "Behind by $delta/mo" — same delta now in the banner, surfaced twice intentionally (alert vs at-a-glance stat). K — Destructive transition confirms. Pause / Resume stay no-confirm (recoverable). Mark complete (irreversible via UI; no may_uncomplete? event exists) and Archive (goal disappears from active list) now wear CustomConfirm. New locale keys: goals.show.confirm_{complete,archive}_ {title,body,cta}. Locale catch_up body strings now interpolate %{delta} alongside %{date}; projection.behind drops %{required}. Controller#projection_summary still passes both keys — extras are ignored by I18n. * a11y(goals/card): scope link accessible name to title + status summary Whole card was wrapped in <%= link_to ... %>, so screen readers concatenated every nested text node into one accessible name (~60 words on a typical card: avatar initial + name + status pill + percent + balance + target + pace + accounts + footer). - Outer wrapper now <div> carrying the filter-target + goal-name + goal-status data attrs. - Inner <a> wraps only the goal name. aria-label = "<name>, <status>, <percent>% of <target>" — concise SR sentence. - `before:absolute before:inset-0` makes the inner link's hit area span the whole card so sighted users keep the existing click affordance. - Ring SVG + percent overlay marked aria-hidden (decorative — same info already in the aria-label). - New locale key goals.goal_card.aria_progress. * feat(goal_contributions/new): live impact preview below amount field Add-contribution modal previously offered zero feedback on what the typed amount would do to goal progress. Now renders "Currently X% saved (Y of Z)." at rest and updates on each keystroke to "Will bring you to X% saved (Y of Z)." or "Will reach your Z target." when the contribution would close the gap. - New goal_contribution_preview_controller.js consumes current balance + target + currency + three localized template strings as Stimulus values. Intl.NumberFormat for currency formatting (locale-correct out of the box; fallback to currencyValue prefix on environments that don't support it). - ERB form-level data-controller wires the values; amount input uses amount_data: to thread the Stimulus target / action through the money_field helper. - Locale: goal_contributions.new.preview_{zero,nonzero,reached} with {percent}, {current}, {newTotal}, {target} placeholders. * feat(goals/edit): funding-accounts editor in the edit modal Previously a user who linked the wrong account at creation had to delete + recreate the goal. Now the edit modal carries the same funding-accounts checkbox group as Step 1 of the stepper, pre-checked with the goal's current links. - GoalsController#edit loads @linkable_accounts + @currently_linked_account_ids. - #update accepts account_ids; when supplied, runs the create / update inside a Goal.transaction and syncs linked accounts via sync_linked_accounts! (set-diff: destroy_all unselected goal_accounts, create the new ones). Validates at least one account before touching goal_accounts so the user gets a clean re-render. - Removing an account preserves the goal's existing contributions — GoalContribution#account_must_be_linked_to_goal only fires on save, so historical rows stay valid. - _form_edit partial accepts new locals; edit.html.erb threads them through. - 3 new controller tests: identity-only patch leaves links intact; account_ids patch replaces the link set; empty account_ids re-renders with error. * fix(goal_contributions/preview): rename templateNonZero -> templateNonzero so Stimulus matches the data attribute Stimulus converts the JS value name templateNonZero to a kebab-cased attribute by splitting on each capital letter, giving data-...-template-non-zero-value. Rails' dataset helper converts the Ruby key :goal_contribution_preview_template_nonzero_value to data-...-template-nonzero-value (no hyphen between non and zero). Result: the Stimulus controller resolved templateNonzeroValue to "" and the preview pane went blank as soon as the user typed an amount. Renaming the JS value to templateNonzero closes the conversion gap. Verified live via Playwright: at $500 the preview reads "Will bring you to 28% saved ($13,750 of $50,000)."; at $40,000 it flips to "Will reach your $50,000 target." * feat(goals/chart): y-axis labels + horizontal gridlines Chart had no value anchor on the y-axis; users had to read the target line label to know what amount the saved line represented. Add 3 right-aligned y-ticks ($0, $25K, $50K-style K/M shorthand) plus faint borderSubdued gridlines at the same y values. Left margin widens to 44 when room allows. Mobile (<320px chart inner-width) keeps the original tight 16px left margin and skips the y-axis entirely so the short-window readout stays uncluttered. Verified live: desktop reads $0/$20K/$40K + Target $50,000; 375px viewport drops the y-axis text + keeps target line + x-ticks only. * feat(goals/show): status-aware chart variants for empty + no-target-date Empty state (goal with zero contributions) was rendering a flat-at-$0 saved series and a flat-at-$0 projection that looked broken to anyone opening a freshly created goal. Now show.html.erb branches on @goal.goal_contributions.empty? and renders a piggy-bank + "Add a contribution" CTA card before the chart card. Brand-new goals get a clean inline call-to-action instead of a misleading line at zero. No-target-date goals (target_amount set, target_date null) used to render a standalone "Set a target date" prompt card and hide history entirely. Now they render the chart with the saved history + the target horizontal line (no projection segment, no projection legend item), plus a secondary "Set target date" callout below the chart linking into the edit modal. History is informative even without a deadline. Locale: new goals.show.empty.{heading,body,cta}. * feat(goals/chart): hover crosshair + dot + tooltip Chart had no way to read the value at a specific date — users had to infer Saved amounts from line position relative to the y-axis labels added in the previous commit. - Transparent <rect> overlay covers the plot area + catches pointer. - pointermove uses d3.bisector to snap to the nearest saved series point, draws a dashed crosshair + a saved-line dot + a projection-line dot (linearly interpolated between today and target). - HTML tooltip lives inside the chart root (cleared on next _draw) showing "date / Saved: $X / Projected: $Y". Clamps to viewport so it doesn't overflow the card. - pointerleave hides everything. Pointer events unify mouse + touch — single handler covers both desktop hover and mobile tap-and-drag. No keyboard nav yet; tracked as follow-up (Stimulus controller is the right home but won't ship in this round). * feat(goals/stepper+chart): Step 2 derived projection + JS i18n + Intl.NumberFormat B — Step 2 of the create stepper used to echo Step 1 fields back at the user in three labelled rows (Funding accounts: 2 · $123,456 balance; Suggested monthly: $1,003/mo over 12 months). Replaces those rows with a single derived sentence: "Save $1,003/mo across 2 accounts to hit it on time." If no target date is set: "Set a target date to project a finish line." The previous "Suggested monthly" + "Funding accounts" rows are dropped; review block shows only Name, "$12,000 by May 11 2027", and the derived insight sentence. L — All hard-coded English templates + currency symbols in the JS controllers go through Stimulus values now: - goal_stepper_controller: new {currency, summaryWithDate, summaryNoDate, accountCountOne, accountCountOther, suggestedWithDate, suggestedNoDate} values. Money formatted via Intl.NumberFormat(undefined, { style: "currency", currency: this.currencyValue, maximumFractionDigits: 0 }). - goal_projection_chart_controller: _fmtMoney upgraded to Intl.NumberFormat (was $/€/£ ternary fallback that lost JPY/INR/CHF/...). Locale: new goals.form_stepper.step2.review.{summary_*,account_count, suggested_*}. Old funding_accounts / suggested_monthly keys retained (unused by the new ERB) so any translator paths in flight don't break. Verified live via Playwright: step-2 review reads "Save $1,003/mo across 2 accounts to hit it on time." for a $12,000 / 12-month / 2- account goal. * feat(goals/new): standalone page render when not in a Turbo frame Direct nav to /goals/new used to render the index page with an empty modal frame because the entire template was wrapped in DS::Dialog. The URL was effectively un-shareable. Branch on turbo_frame_request? — Turbo Frame requests still render the DS::Dialog wrapper (the existing in-modal flow on the index page keeps working). Non-frame requests render a standalone page-level header (h1 + subtitle + icon) followed by the form_stepper partial. Same Stimulus controller, same data-goal-stepper-modal-subtitle selector, so the stepper's subtitle update path works identically. Controller sets @breadcrumbs so the standalone variant gets the Home > Goals > New goal trail. Verified both paths via Playwright: direct GET renders standalone form with h1 "New goal" + no dialog; click-from-index opens the DS::Dialog with the stepper inside. * fix(goals/chart): drop title-tooltip, step projection cursor, dot follows projection line, collision-aware y-ticks, clean tooltip Four chart fixes in one pass. 1) Browser was rendering the <title> child as a native hover tooltip that fought with the custom crosshair tooltip. Drop <title>; use aria-label on the <svg role="img"> instead — same SR accessible name, no native tooltip side-effect. 2/3) The hover crosshair clamped at today: bisector ran the saved series, which ends at today, so future hovers stuck the dot at the last saved point. Now the controller forks: - Past hover: snap to nearest contribution via bisector. - Future hover: snap to whole-week intervals along the projection segment ([today, target_date]) and place the dot at the interpolated y on the dashed line. Movement steps cleanly week by week instead of pixel-by-pixel jitter. 4) Tooltip drops the redundant line: - Past: "<date> · Saved: $X" (no Projected — there isn't one). - Future: "<date> · Projected: $X" (no Saved — it's the future). 5) Y-axis tick label suppressed when its value falls within 5% of the target line so "$2.5K" and "Target · $2,400" stop overlapping near the right edge. Gridline stays; only the y-axis label drops. Verified live via Playwright on House downpayment goal: <title> absent, aria-label populated, past tooltip "Feb 10, 2026 · Saved: $11,750", future tooltip "Nov 29, 2027 · Projected: $32,235", neighbouring future x snaps to "Dec 13, 2027 · $32,704" (2-week jump across the snapping boundary). * ux(goals): catch-up rework, dark-mode pill contrast, color disclosure, stepper continue-right - catch_up alert: title now leads with the new info (delta) and body states the required rate. Was "Save $1,000/mo to catch up" + "Currently $750/mo behind" — confusingly double-stated. Now "Behind by $750/mo" + "Save $1,000/mo to stay on track for {date}." Locale keys swap the %{amount}/%{delta} placement. - Goals::StatusPillComponent: each variant carries a theme-dark: text override so the dark-700 text doesn't disappear against the dark-mode tinted surface. Verified in dark mode: Paused pill text is now rgb(231,231,231) (gray-200) instead of rgb(54,54,54) (gray-700). Pre-existing token contrast fix tracked at we-promise/sure#1736 stays the long-term path; this is the local workaround that doesn't drop 4.5:1 in either theme. - New goals/_color_picker.html.erb partial: <details> disclosure with current-color preview in the summary + swatch grid in the popover. Mirrors the categories form's pen-icon-overlay pattern in spirit (collapsed by default; user clicks to expand). Both _form_edit and _form_stepper render the partial; the stepper's hidden color field is replaced by the visible disclosure. - Stepper footer: change `justify-between` to `flex items-center` plus `ml-auto` on the Continue wrapper. Continue now sits right-aligned in step 1 (where Back is hidden) and stays right in step 2 with Back taking the left edge. * ux(goals/show): catch-up alert anchors all three numbers + scoped scrollbar on contributions list Alert previous pass led with delta ("Behind by $750/mo") but the user still had to reconcile that with the $1,000/mo CTA — the relationship between current pace, gap, and required rate was implicit. Make every number visible in the sentence: - Title: "Save $1,000/mo to stay on track" — leads with the action + required rate. Reduces decision load: the headline is what to do. - Body: "You're saving $250/mo today — $750/mo short of the pace to finish by September 11, 2026." — current pace + gap + deadline. User can now mentally verify: $250 + $750 = $1,000. The catch-up amount in title + body + CTA is no longer disconnected from the current pace number; the body is the bridge. Adds `scrollbar` utility (defined in app/assets/tailwind/application.css as 4px gray-300 thumb) to the contributions list container. Browser- default scrollbar was rendering as a thick dark bar in light mode on some OSes; the in-house utility renders a thin gray thumb consistently across themes. * ux(goals): color picker uses Sure's inline-disclosure pattern; drop em-dash in catch-up body Found the actual Sure pattern in app/views/accounts/_form.html.erb:27-47 ("Additional details" section in the account-creation flow): <details class="group"> <summary class="cursor-pointer text-sm text-secondary hover:text-primary flex items-center gap-1 py-2"> <%= icon "chevron-right", class: "group-open:rotate-90 transition-transform" %> ... </summary> <div class="space-y-2 mt-2 pl-4 border-l border-primary">...</div> </details> It's an inline expand (no absolute popup), chevron rotates 90° on open, body indented with a vertical primary-color rule. My previous partial was an absolute-positioned popover lifted from categories/_form.html.erb — not what Sure uses for collapsible form sections. Rewrite _color_picker.html.erb to match: chevron + color-preview disc + "Color" label in the summary; swatches in an inline indented body. Catch-up body also drops the em-dash. Was: "You're saving $X/mo today — $Y/mo short of the pace to finish by $date." Now two sentences: "Your current pace is $X/mo. You need an extra $Y/mo to finish by $date." Two short clauses, no compound separator, each conveys a single number. Frames the gap as "extra" rather than "short", which behavioral-econ research suggests reads as more attainable. * ux(goals/show): catch-up CTA pre-fills + secondary "Adjust your target" link The "Add $1,531.25" CTA used to open the contribution modal with an empty amount field — label was a hint, not a default. Now passes the catch-up amount via ?amount= and the contributions controller seeds @contribution.amount from params. One click brings the user to the modal already populated. Adds a secondary text link below the primary CTA: "Or adjust your target" → opens the edit modal (Turbo frame). Behavioural-econ choice architecture: gives the rebaseline path explicitly so users who can't realistically catch up don't feel forced into the contribution. Trade-off: lets the alert respect autonomy — commit or recalibrate, both fine. Action paralysis kept low by visual hierarchy (primary button vs muted text link). * ux(goals/show): balance-sheet-style funding widget; drop redundant stat row Lower half of the goal detail used to be: (stat row: monthly pace + total contributions) + (bottom row: contributions list + funding breakdown card). Two of those four pieces were redundant: - Total Contributions stat duplicated the count badge that already sits beside the Contributions heading below. - Monthly Pace stat repeated the same numbers the catch-up alert surfaces above and the chart subtitle reads. Adopt the dashboard Balance Sheet pattern (app/views/pages/dashboard/_ balance_sheet.html.erb) for the funding widget: inline header with total ("Funding accounts · $13,250"), thin gap-separated segment bar, color-dot legend with percent, and a bg-container-inset table with the shared `pages/dashboard/group_weight` 5-stick weight indicator + value column. New show.html.erb bottom: just two full-width sections — funding widget, then chronological contributions list. Both rendered only when the goal has contributions (matches the empty-state branch added earlier). Locale: goals.show.funding_table.{name, weight, value}. * feat(goals): extract shared color_icon_picker controller; add icon to goals; tinted avatar User requested replacing the in-house color disclosure with the categories color+icon popover. Done as a controller extraction so categories and goals share one Stimulus controller (user's option: "Extract a shared color_icon_picker_controller.js"). - `git mv` app/javascript/controllers/category_controller.js to color_icon_picker_controller.js. Categories form + color_avatar partial updated to use the new identifier (data-controller= "color-icon-picker", target/action selectors renamed). - Goal model gains an icon column (migration 20260511190000_add_icon_to_goals.rb) + ICONS = Category.icon_codes + inclusion validation. GoalsController permits :icon in goal_params + goal_update_params. - Goals::AvatarComponent now renders icon when present (falls back to first-letter initial), and adopts the Categories tinted-bg + colored -content style (bg = `color-mix(in oklab, COLOR 10%, transparent)`, text/icon = COLOR). Matches the picker's live preview so what the user sees during selection equals the saved state. - New goals/_color_picker.html.erb mirrors categories/_form's popover: avatar + pen overlay summary + popup with color row (+ rainbow custom-hex trigger) + icon grid. Pickr / contrast validation / auto- adjust all inherited from the shared controller. - Stepper step 1 layout: drop the inline letter-avatar (data-goal- stepper-target="avatarPreview") in favour of the picker avatar next to the name input. Step 1's tail no longer renders a separate color partial. Edit form passes icons local through. Verified live: new goal modal renders 11 color radios (10 presets + custom) + 141 icon radios + pen-summary; categories form still operational (no console errors) under the renamed controller. * chore: drop session-artefact audit-shots + audit markdown from branch These local-only audit screenshots + the report draft were staged inadvertently in the previous commit. They belong to the development session, not the feature branch. * ux(goals): picker stacked above name field (stepper + edit) Previously sat next to the name input via `flex items-start gap-3` so the picker avatar competed with the input for horizontal space. Move to its own row, centered (`flex justify-center`), positioned just before the name field. Mirrors the categories form layout where the avatar is the focal element above the name input. Same change applied to the edit form: picker comes first, then name. Stepper step 1 order is now: heading · picker · name · amount/date · funding accounts · notes. * fix(goals): theme-aware avatar text contrast; compact picker popup Avatar letter/icon now uses `--avatar-color` CSS variable + the new `.goal-avatar` class. Light mode darkens the text to 55% color + 45% black so pale palette entries (cyan-300, green-300) stay readable on the 10%-mix tint over white (~4.5:1). Dark mode reverts to the full brand color via [data-theme="dark"] .goal-avatar override so the text doesn't disappear against the near-black tinted surface. Verified live: #805dee renders as a darker oklab in light mode and full rgb(128,93,238) in dark mode. Picker popup compacted: - 80 (320px) wide, max-h-[60vh] overflow-y-auto so it never spills off-screen. - Anchored below the avatar + horizontally centered to it (top-full left-1/2 -translate-x-1/2) so it doesn't drift off to the right edge of the form on narrow modals. - Icon grid max-h-40 (160px, ~5 rows) with the in-house `scrollbar` utility for a thin gray thumb that works in both themes. - Section headers (Color / Icon) styled `uppercase tracking-wide` for visual hierarchy. Verified popup at 320x310px in edit modal, no vertical overflow. * fix(goals/avatar): icon helper clash crashed show after saving an icon Goals::AvatarComponent had `attr_reader :icon` which shadowed the global `icon` view helper. Template called `icon(icon, size:, color:)` which Ruby resolved against the attr-reader (zero-arity), throwing "wrong number of arguments (given 2, expected 0)" the moment a goal had a saved icon and the show page tried to render its avatar. - Drop `:icon` from attr_reader; expose as `icon_name` instead. - Template uses `helpers.icon(icon_name, ...)` matching the Goals::StatusPillComponent pattern (other Goals VCs already use `helpers.icon`). Reproduced + verified live via Playwright: edit modal → pick an icon → save → show page renders the new avatar with the SVG. Same for create flow (new modal → pick icon → step 2 → submit → show renders). * fix(goals/chart): suppress projection-end label when it collides with target Issue: an on-track goal whose projected end is just above the target showed two right-anchored labels stacked on top of each other — "Target · $2,400" and the projection-end short value "$2.4K". The projection dot already conveys "you'll hit the target on time"; the extra label adds noise. Now: when willHit AND |projDotY - y(targetAmount)| < 18px, skip the projection-end label entirely. The colored dot at the target_date keeps the visual cue. Also refactor the y-axis label collision check from value-based (within 5% of yMax) to pixel-based (within 18px of target's y), matching the projection-end logic. When a y-tick is close to target, the Target label drops into the y-axis column at that row (short format) instead of right-edge full format. Either way, no two labels ever stack within 18 vertical px. Verified live: Wedding fund (on_track, projection ≈ target) → just "Target · $2,400" + y-ticks, no "$2.4K". House downpayment (behind) → "Target · $50,000" + "Short $12.3K" both retained (well separated). * fix(goals/chart): redraw on turbo:render so the chart survives morph navigation Repro: index -> goal show (chart drawn) -> open edit modal in turbo frame -> pick a new icon -> submit. Server responds with turbo_stream.action(:redirect, goal_path). Turbo morphs the show page, wiping the chart container's children, but Stimulus' connect() isn't re-run on the morphed element so _draw never fires again. The ResizeObserver doesn't help — the container's box dimensions are unchanged. Listen for turbo:render and turbo:frame-load on document and re-draw when the container's SVG is missing. Cheap idempotent check (querySelector('svg')) — no-op if the chart is already there. Listeners cleaned up in disconnect(). Verified: same flow now lands on the show page with the chart fully rendered (23 SVG children). * docs(goals): add architecture decision discussion note Captures the open question on the data model behind Goals (account-linked vs free-form ledger vs tag-based) for community review before PR #1757 merges. * docs(goals): split architecture note into user-facing + mechanics The user-facing note focuses on how a Goal's balance gets computed and what changes for the user. The mechanics doc covers the schema, pro-rata math, pace window, and the operational details engineers need but most readers don't. * docs(goals): final architecture cut after 5-iteration expert review User-facing doc and mechanics companion converged on an account-linked model with a pledge layer. Surfaces the pledge-with-7-day-match mechanic, proportional-to-remaining-need split default, "Reserved beyond balance" framing, in-chart pending segment, two-clock rate limit, archive-in-place account handling, months-of-runway for open-ended goals, and the pre-launch user tests + day-one pledge instrumentation. * docs(goals): expand matrix coverage + ground mechanics in current code User-facing doc gains explicit 1xM (one goal, multiple accounts), N goals on shared accounts, and overlap (NxM) sections, plus the reallocation flow and "why is this goal behind?" diagnostic. Mechanics doc is rewritten against the actual code on the branch: file:line citations for current state, accurate corrections to the prior draft (Sure uses Account AASM status not archived_at, no Account#balance_at method, balance history via Balance::ChartSeriesBuilder CTE, Transaction::TRANSFER_KINDS for pace exclusion, advisory-lock pattern lifted from IdentifyRecurringTransactionsJob, partial-unique index precedent from entries[external_id, source]), concrete migration plan with seven steps, surface-by-surface STAY/CHANGE/DELETE verdict on every component, view, and Stimulus controller, day-one instrumentation events, and four pre-launch user tests. * feat(goals): v2 architecture — drop ledger, derive balance, add pledge Reshape the goals feature to live on top of linked-account balances. A goal's balance is now the live balance of every depository account linked to it — no parallel ledger, no "log a contribution" step. The "Add contribution" affordance is replaced by a 7-day GoalPledge (kind: transfer | manual_save). GoalPledge::Reconciler matches incoming Transactions (via Account::ProviderImportAdapter) and Valuations (via Account::ReconciliationManager) against open pledges within ±5 days, ±$0.50, or ±1% — single hook covers every provider (Plaid, SimpleFIN, Lunchflow, Enable Banking, Brex, IBKR, Kraken, SnapTrade) plus manual balance edits. A 15-minute Sidekiq cron sweeps expired pledges. Goal model: balance derived from linked_accounts.sum(&:balance), new pace (90-day net non-transfer inflow), months_of_runway, last_matched_pledge_*, pledge_action_label_key (the "I just transferred…" vs "I just saved…" verb switch). UI: - Index gets a 3-card KPI strip (Contributed last 30d / Needs this month / On track) plus a pending-pledges callout. - Show page swaps the "Add contribution" CTA for the pledge modal, replaces the contribution list with a pending-pledge banner, and rebuilds the funding widget into per-account rows with a 12-bucket weekly sparkline and last-30 inflow. - Projection chart adds a required-line (dashed light from today → target) and a translucent pending-pledge bump at today's X. Schema (3 migrations): 1. goal_pledges table with PG enums (goal_pledge_kind, goal_pledge_status), open-by-expiry index, and unique-when-not-null matched_transaction_id. 2. Drop goal_contributions. 3. Partial unique index on transactions ((extra -> 'goal' ->> 'pledge_id')) built CONCURRENTLY so it doesn't block prod. After pulling: run bin/rails db:migrate, then commit the schema.rb sync separately (or let CI regenerate). Deferred to v1.1: allocation columns, contention/archived banners, "why is this behind?" diagnostic, reallocate flow, refresh-sync + Plaid throttle, unallocated-cash chip, joint-account approval, goal_activities log, polymorphic matched_entry_id/type for manual pledge audit. * fix(goals): CI green — schema, brakeman, pledge modal, error class Regenerate schema.rb after the three v2 migrations so CI's db:schema:load picks up goal_pledges, the dropped goal_contributions, and the partial unique pledge_id index. Brakeman: - Drop :account_id and :kind from goal_pledge permit; look the account up via @goal.linked_accounts.find_by(id:) instead and set kind server-side from goal.any_connected_account?. - Rename goals.show.projection.on_track to .on_track_html so I18n marks the result html_safe automatically; drop the unconditional .html_safe call in show.html.erb. Pledge modal: rewrite app/views/goal_pledges/new.html.erb to use DS::Dialog (the Sure convention for create modals — matches categories/transfers). Error handling: replace `raise ActiveRecord::RecordInvalid, "string"` in GoalPledge#extend!/cancel! with a dedicated GoalPledge::NotOpenError; the controller rescues that specifically. Tests: rewrite the "pace is zero" test to create a fresh account with no entries (the fixture's depository accounts carry transaction history that produces a non-zero pace). All goal tests now green (73 runs, 157 assertions, 0 failures). * fix(goals/pledge): drop find_each-incompatible order in reconciler The explicit .order(created_at: :asc).find_each emitted an AR warning that broke the strict logger mock in BrexEntry::ProcessorTest. find_each forces its own primary-key order anyway. * ux(goals/index): restore prior-30d comparison + multi-part on-track subtitle The v2 rewrite dropped the velocity_delta_percent / velocity_direction keys that powered the 'Contributed last 30d' card's '↑ 27.2% vs. prior 30d' line and the 'Goals on track' multi-part subtitle ('1 behind · 1 paused'). Restore both, sourcing velocity from Family#savings_inflow_velocity with explicit current-window and prior-window ranges. * fix(goals): pledge lifecycle + connected-account detection Behavioural fixes touching Goal, GoalPledge, the reconciler and the goals controller. No schema change. B5 — connected-account detection covered only Plaid. SimpleFIN, Brex, Enable Banking, IBKR, Kraken, SnapTrade and Lunchflow users got "manual_save" pledges by default; their auto-synced Transactions then failed to match (reconciler matches Transactions to "transfer" pledges only). Pledges sat in the yellow banner until expiry. Switch the detection to !Account#manual?, which mirrors the existing `Account.manual` scope (no account_providers, no plaid_account_id, no simplefin_account_id). Add `Account#manual?` so the per-instance and per-query checks can't drift. B7 — `extend!` widens `expires_at` but `matches?` was anchored on `created_at ± 5d`, so an extension that pushed the expiry past day 5 didn't actually buy any match runway. Widen the upper bound to `max(created_at + 5d, expires_at)`. The lower bound stays at `created_at − 5d`. B8 — `Goal#open_pledges` returned `status: open` regardless of expiry. Between a pledge timing out (day 7) and the 15-min sweep job marking it `expired`, the show page rendered a ghost yellow banner with "0 days left" that the reconciler would no longer touch. Add `expires_at >= NOW` to the scope so the visible state matches the match-eligible state. B9 — Double-click on Record pledge produced two identical open pledges, which then stacked as two yellow banners. Add a create-time validation rejecting duplicates against (goal_id, account_id, amount, status=open, expires_at >= NOW). B10 — The reconciler used `transaction.with_lock` but didn't lock the pledge. Two concurrent reconcile attempts on different transactions could both target the same pledge; one would lose to the partial unique index on `transactions.extra->'goal'->>'pledge_id'` and the RecordNotUnique was caught by the outer StandardError rescue, which silently dropped the other transaction's match attempt entirely. Lock the pledge first, re-check `status_open?` inside the lock, and catch RecordNotUnique alongside RecordInvalid/NotOpenError in the reconciler — so on a lost race we fall through to the next candidate pledge instead of exiting the loop. Extract the Valuation-match path to `GoalPledge#resolve_with_valuation!` so it goes through the same locked status-recheck. B12 — When a goal is destroyed, `dependent: :destroy` reaped pledges but left `transactions.extra["goal"]["pledge_id"]` pointing at the now-deleted UUIDs. The partial unique index on that JSON path then indexed stale references. Add a `before_destroy` on GoalPledge that clears the matching transaction's `extra` if it still points back to the pledge. B6 — `last_matched_pledge_at` used `goal_pledges.maximum(:updated_at)` on matched rows. Any backfill or sync-resync that touches a matched pledge bumped `updated_at`, so a single resync set every goal's "Last saved N days ago" header back to "today". Switch to the entry's `date` via a join through `matched_transaction_id`, which reflects the date the money actually moved. B22 — `scope :chronological` ordered DESC, the opposite of what the name promises. Rename to `:reverse_chronological` and update the one caller in `goals#show`. (Other models' `chronological` scopes are unrelated and ordered correctly.) Also: preload `account_providers` on `linked_accounts` in the index and show controllers so `Account#manual?` walks the in-memory collection instead of triggering N queries. Tests: add fixture-backed coverage for extend-widens-match-window, post-extend rejection beyond expiry, and the duplicate-pledge validation. Existing assertions still hold against the new `matches?` window math. * fix(goals): pace counts transfers, family rollup currency-scoped Two semantic shifts in V2 that drove the worst on-screen confusion. B3/B4 — `Goal#pace` excluded `Transaction::TRANSFER_KINDS`. When a user tapped "I just transferred…" and the deposit landed, the linked account's balance went up but pace did not: pace ignored transfer- kind entries, so the goal stayed `:behind` against `monthly_target` and the catch-up callout kept demanding $X/mo even though the user had just moved the money in. Same root cause hit any long-time saver whose 90-day net was zero — pace=0, status=:behind, projection says "At $0.00/mo you'll miss your target date" while the ring sits at 80%. Drop the transfer-kind exclusion. Pace is now net inflow into linked accounts over 90 days. Transfers between linked accounts already net out (both legs land inside the same account set); transfers from outside (checking → linked savings) net positive, which is exactly the case the pledge flow records. B19 — `Family#savings_inflow_velocity` summed entry amounts across every depository account linked to any goal regardless of currency, then rendered the result in the family's primary currency. A family with one USD goal and one EUR goal saw `usd_inflow + eur_inflow` reported as USD with no FX conversion. Scope the account set to the family's primary currency until proper FX-conversion lands. Also let the result go negative (net outflow) — clamping to ≥0 lost signal; the controller decides how to render the sign. V20 (controller) — `velocity_30d_sign` was wired off the *delta* direction, so a $1,234 down-month rendered as "−$1,234 ↓ 27% vs prior 30d". The minus read as a loss but $1,234 was the (positive) contribution. Re-wire the headline sign off the headline value itself; the delta-direction stays on the subline as ↑/↓ N%. With the family-rollup change above, the headline can now legitimately be negative — UI now says "−$200 ↓ 50% vs prior 30d" when the family had net outflow. B21 — KPI tile `on_track_count` lumped `:reached` goals into "on track", inflating the numerator while the sort order placed reached goals at the bottom of the list. Split `reached_count` out and render it as its own segment in the on-track subline ("1 reached · 1 behind · 1 paused"). Test: rename the pace=zero test to match its new premise (no transactions vs. no non-transfer entries). The fixture still has no entries, so the assertion holds. * fix(goals/ds): replace hand-rolled yellow banners with DS::Alert The pending-pledge banner on goals#show and the pending-pledge callout on goals#index were inlined yellow divs: bg-yellow-50 dark:bg-yellow-950/30 border-yellow-200 \ dark:border-yellow-800 Raw color tokens violate the "functional tokens only" rule in CLAUDE.md ("`text-primary` not `text-white`, `bg-container` not `bg-white`"), drift from the DS warning palette (`bg-warning/10` + `border-warning/20`), and miss accessibility plumbing (aria role, sr-only variant label) that DS::Alert provides for free. Swap both surfaces for `DS::Alert.new(variant: "warning", live: :polite)`: - Index callout: a one-line message variant (no title). - Show banner: title + body + footer with DS::Button (outline Extend, ghost Cancel). Cancel button gets a CustomConfirm dialog — the V2 affordance destroyed the pledge on a single click with no second-chance prompt; one accidental click and the user lost the record. The Extend / Cancel buttons drop the hand-built `text-xs px-2.5 py-1 rounded-md shadow-border-xs bg-container` styling, picking up DS::Button's `outline` / `ghost` variants and `size: "sm"` instead. Locale: tighten the title from "Pending: $200 into Savings" + separate body line "… $0.50 or ±1%) · 6 days left." to "Watching for $200 into Savings · 6 days left" with a short body ("Auto-confirms when Sure spots a matching deposit on the next sync"). The old copy was ~130 chars and wrapped 2-3 lines inside the banner flexbox, pushing the catch-up callout below the fold on common viewports. Drop the hardcoded "$0.50" from the body (currency-aware copy lands in Commit I). Add `confirm_cancel_{title,body,cta}` strings for the CustomConfirm dialog. * fix(goals/funding-widget): restore DS-aligned per-account breakdown V2 rebuilt the funding widget around per-account rows + a custom SVG sparkline, but cut visible signal and DS adherence in the process. This rebuild restores the V1 affordances and folds in the V2 sparkline as an enhancement. - Heading regression: `text-lg font-medium` (with total in `text-lg`) → `text-sm font-medium` (total inheriting `text-sm`). The section heading collapsed to body-copy size and no longer matched the Projection heading beside it. Restore both to `text-lg`. - Avatar regression: V2 hand-rolled `w-10 h-10 rounded-full … style="color: white"`. That box (40px) matches no `Goals::AvatarComponent` size (sm=24px, md=36px, lg=44px), uses `rounded-full` where the DS uses `rounded-md/lg/xl/2xl`, and hardcodes white text instead of the `text-inverse` token. Render `Goals::AvatarComponent` directly at `size: "sm"`. - Privacy regression: `row[:balance_money]` subline ("Depository · $3,000") wasn't wrapped in `privacy-sensitive`. Blur mode no longer hid the balance, while heading total and last-30d value on the same row both had the class. Add `privacy-sensitive` to the subline. - Untranslated leak: `<%= account.accountable_type %>` printed the raw "Depository" / "Investment" / "Crypto" class string with no i18n. Add `accountable_label(account)` on the component that prefers the depository subtype ("Savings", "HSA"…) via `goals.form_stepper.step1.subtypes.*`, falling back through `accounts.types.*` and finally a `titleize`. - Lost weight signal: V1 had a stacked distribution bar across the top, colored legend dots, and a 5-bar weight pill per row. Users could see "Account A contributes 60% of balance" at a glance. V2 deleted all three. Restore the distribution bar + legend + the existing `pages/dashboard/group_weight` partial in a `weight` column (skipped when only one account is linked). - Lost container framing: V1 wrapped rows in `bg-container-inset rounded-xl p-1` with `shared/ruler` dividers between rows. V2 used `space-y-3` with no container and no dividers, leaving rows floating. Restore both. - Empty state regression: V2's fallback rendered the section heading as a body paragraph (`<p>Funding accounts</p>`) inside a `p-5 rounded-xl` card — looked like an unfinished widget. Replace with a real empty state via `goals.show.funding_accounts. empty.heading` + `body` ("Edit the goal to link the depository accounts you save into."). - Row order: V2 sorted by 30-day inflow (which can flatten to ties at $0 across rows). Sort by balance instead — the column the user is comparing against anyway. - Pace alignment: drop the transfer-kind exclusion from the component's `last_30_inflow_for` and `sparkline_for` so the widget reads the same flow as `Goal#pace` (commit B). Internal transfers between linked accounts net out per-account here too, external transfers count as inflow on the receiving account. The 12-bucket sparkline still runs 12 queries per account; that N+1 lands in a follow-up commit alongside the component-level query collapse. * fix(goals/pledge-modal): use StyledFormBuilder + restore live preview V2 rebuilt the pledge create modal but bypassed the DS form helpers inherited from `StyledFormBuilder`, lost the inline impact preview from V1's contribution form, and shipped a goal-level "transfer vs manual_save" toggle that broke on mixed-funding goals. - Manual `form-field/__body/__label/__input` div-wrapping for the account select → idiomatic `f.select :account_id, choices, { label: t(".account_label") }`. The builder applies the required marker, error state, and inline-label handling automatically; the hand-built version drifted from that path and applied `form-field__input` directly onto the select element, where the builder picks the correct input class per field type. - Hand-rolled `<div class="form-error">` + `<p>` loop for errors → `render "shared/form_errors", model: @pledge` (the shared partial with the destructive-icon prefix). Matches V1's contribution modal and the rest of the codebase. - Drop `class: "btn btn--primary"` on `f.submit` → bare `f.submit t(".submit")`. The builder's `submit` is wired to `DS::Button.new(text:, full_width: true)`; the explicit class was redundant. - Drop the duplicate "Cancel" button. DS::Dialog already renders an X in the header; the in-form ghost Cancel was a second close affordance with no analogue in the new-goal stepper or V1's contribution form. - Drop `data: { turbo_frame: "_top" }` on submit. Success already flows through the controller's `turbo_stream.action(:redirect, …)` and on 422 the modal frame is the right swap target; the explicit `_top` was at best redundant and at worst a future Turbo footgun. - Wire `data-controller="goal-pledge-preview"` on the form and add an inline preview `<p>` below the amount field. As the user types the amount, the line updates to "Reaches 75% — $3,750 of $5,000." or "Hits your $5,000 target — goal reached." Mirrors V1's contribution preview that V2 dropped on the floor. - Rename `goal_contribution_preview_controller.js` → `goal_pledge_preview_controller.js`. Pure rename; the controller was already domain-neutral. - Per-account pledge kind. The controller's `default_kind_for(goal)` picked `transfer` whenever the goal had ANY connected account — meaning a goal that linked a Plaid checking account AND a manual cash envelope routed every pledge as `transfer`, including those the user submitted against the manual account. The reconciler would then watch for a Transaction that never arrives. Replace with `kind_for_account(account)` that picks per-account: manual → `manual_save`, anything else → `transfer`. - `new` action now respects `?account_id=…` query params and preselects that account (helpful for the catch-up callout's inline "Save $X/mo" CTA, which can target a specific account). Locale: drop the hardcoded "(±5 days, ±$0.50 or ±1%)" tolerance copy from the helper text — that detail belongs in docs, not in a modal that fires on every pledge create. Currency-aware copy lands in commit I. Drop the now-unused `cancel:` key. Add the three preview templates (`preview_zero`, `preview_nonzero`, `preview_reached`) consumed by the Stimulus controller. * refactor(goals/show): move projection_summary + catch_up_delta to model The show template carried a 17-line `if/elsif` chain computing `projection_summary` inline, plus a `Money.new([…, 0].max, …)` expression building the catch-up delta on the fly. CLAUDE.md's "skinny controllers, fat models" convention pushes both onto Goal. - `Goal#projection_summary`: returns the localized, `html_safe`-aware string for the chart subtitle and the chart's `aria-description`. Memoized so the two callsites in show.html.erb share one computation. - `Goal#catch_up_delta_money`: clamped-at-zero monthly delta between pace and the required monthly target. Used by the catch-up callout body. Previously the view computed `Money.new([req - pace, 0].max, currency)` — same math, but duplicated inline. show.html.erb drops both blocks and reads `@goal.projection_summary` / `@goal.catch_up_delta_money` directly. Also: V15 — the celebration card used `bg-green-500/10` directly. Swap to `bg-success/10` (DS semantic token, same Tailwind-4 alpha syntax DS::Alert already uses) so the celebration palette tracks the rest of the success surface. * perf(goals/funding-widget): collapse N+1 sparkline + last-30 queries V2's funding widget ran (12 + 1) queries per linked account on the goals#show render: - one `last_30_inflow_for(account)` summed over a 30-day range, - twelve separate `sparkline_for(account)` sums, one per 8-day bucket inside a 90-day window. For 3 linked accounts, that's 39 SQL queries from this component alone before the projection chart's Balance::ChartSeriesBuilder runs. Replace with two grouped queries that scan once across all linked accounts: - `last_30_inflow_map`: a `GROUP BY account_id` over the 30-day window, returning a hash `{ account_id => clamped_inflow }`. One query, no matter how many accounts are linked. - `sparkline_map`: a `GROUP BY account_id, LEAST(GREATEST((CURRENT_DATE - entries.date) / bucket_days, 0), 11)` over the 90-day window. One query covers every account × every bucket. Each per-account array is filled in oldest → newest order so the SVG path reads left → right naturally. Net query count for the funding widget drops from 13 × N to 2. Both helpers fall through to safe defaults (`0`, all-zeros array) on missing keys so the row loop stays branch-free. * chore(goals): drop dead V1 hooks + surface chart errors Loose ends from the V1 → V2 refactor that the architecture commit didn't sweep. - Demo generator (B14): the `goal_spec[:contributions]` arrays + the `wedding_contribs` / `house_contribs` builders still shipped in the file, but the seeding loop that consumed them was deleted alongside `GoalContribution`. Dead data. Strip both the per-goal arrays and the two locals. Goal balance/pace in the demo family now derives from the linked depository accounts' own seeded entries elsewhere in the generator. - Goal stepper controller (B16): the `static targets` declaration still listed `initialContributionAmount` and `initialContributionAccountSelect`, and `refreshAccountSelect` + its two callsites still ran every time a linked-account checkbox flipped. The HTML targets disappeared with the V2 stepper rebuild, so `has*Target` guards short-circuited and the method was a no-op — but it was still dispatched on every change. Drop the targets, the method, and the two callsites. - Chart series rescue (B25): `Goal#balance_series_values` and `FundingAccountsBreakdownComponent#sparkline_map` both swallowed `StandardError` with a `Rails.logger.warn(…)`. The chart then degraded to "target line only" silently. Promote the log to `error` level and forward to Sentry when present (matching the pattern in `Account::Syncer`, `Sync`, `PlaidItem`). Fallback to empty result still preserved so the surface degrades instead of 500-ing. * fix(goals): header CTA + projection-chart required-line color V6 — three "Record pledge" affordances on goals#show (header, empty state, catch-up callout) all rendered as `t(@goal.pledge_action_ label_key)` + `icon: "arrow-up-right"`. That dropped the user into a button labelled "I just transferred…" or "I just saved…" with a trailing ellipsis — past-tense as a CTA reads as a status declaration, the ellipsis suggests an unresolved action, and `arrow-up-right` is the icon Sure reserves elsewhere for external-link affordances. Switch the on-page CTA to a single new locale key, `goals.show.record_pledge_cta: "Record pledge"`, with `icon: "plus"` matching the other "new resource" buttons across the app (new goal, new account, new rule). The modal title keeps using `pledge_action_label_key`, so the past-tense "I just transferred…" framing still anchors the dialog's confirm step. V8 — the projection chart's "required" dashed line was hardcoded to `var(--color-green-600)`. When the goal status is `:on_track` the projection line is also green-dashed, and the two stroked the same hue and dash pattern — they overlapped visually. Re-stroke the required line in `textSecondary` (the chart's neutral foreground) so it reads as a reference path independent of status. * fix(goals/show): add Required line to projection legend The dashed neutral line for "the rate needed to hit the target by the target date" was rendered on the chart but absent from the legend. Adds a third legend chip ("Required") that renders only when the line itself renders — i.e. when target_date is set, monthly_target_amount is positive, and there's still ground to cover (remaining_amount > 0). Stroke matches the JS: `text-secondary` currentColor, dasharray 2/4, 0.5 opacity. * fix(goals/funding-widget): switch sparkline to bars + shared scale The shared-scale fix alone wasn't enough — a single outlier bucket on one account compressed every other row to invisibility, and the interpolated line between sparse non-zero buckets painted fake "event triangles" between actual data points. Switch from a stroked path to per-bucket bars: - 12 rects per row, x = `i * 8 + 1`, width 6, 2px gap between. - Bar height = `(value / shared_max) * 24`, floored at 1 unit so a non-zero bucket is always visible even when an outlier elsewhere dominates the scale. - Empty buckets render nothing — no fake baseline, no interpolated trough. - Bars grounded at `y = 28` (bottom of viewBox), so "zero" is implicit and the eye reads upward from a stable floor. - Shared `spark_max` across every account's bars (the component method introduced for the line version stays — that part of the diagnosis was right, it just needed a chart type that handled the scale honestly). Net read: the column-chart-on-each-row layout matches "12 weeks of deposits into this account" much more directly than a sparkline ever did, and outlier-vs-modest-but-steady contributions are both legible at a glance. * fix(goals/pledge-modal): helper text reacts to selected account The helper paragraph above the amount field was painted off `@goal.any_connected_account?` — a goal-level decision that fires once at modal render and never updates. On a mixed-funding goal (one connected + one manual account linked), the helper read the "transfer" copy regardless of which account the user picked from the dropdown, even though the saved pledge's `kind` is decided per-account by `kind_for_account` in the controller. Stale UI vs. correct data. Render both helper paragraphs hidden, then toggle the right one visible via Stimulus on `change->goal-pledge-preview#accountChanged`. The select renders its `<option>` tags with `data-manual="true|false"` from `Account#manual?`; the controller reads that attribute off the currently-selected option and flips `hidden` on the two helper targets. `connect()` also calls `accountChanged()` so the initial paint matches the preselected account from `?account_id=…` (the catch-up callout's amount-specific deep link). Switch from `options_from_collection_for_select` to `options_for_select` with the `[label, value, { data: { manual: } }]` 3-tuple form — Rails supports per-option data attributes there but not on the collection helper. * fix(goals/funding-widget): per-account balance trajectory area chart Bars communicated "events," not "where the account level sits." A sparse-deposit account painted three thin bars at the bottom and looked dead. An account with a single big deposit dominated every other row's scale. Swap to the same visual language as the projection chart on goals#show — filled area below a stroked line — but one chart per linked account, rendering that account's actual balance trajectory over the last 90 days. Mechanics: - New `trajectory_map` on the component pulls every `balances` row for every linked account in one query (`Balance.where(account_id: account_ids, date: 90d..today)`). Result is grouped per account and resampled to 24 points by a single-pass forward walk that carry-forwards the most-recent balance at-or-before each anchor date. O(rows + samples), not O(rows × samples). - Per-row Y-scale: baseline 0 (when the account has ever held a positive balance), ceiling = max balance × 1.05. The chart reads as "how full was this account over time" rather than "how dramatic is the shape." Flat-at-$5k accounts paint near the top; growing $200 → $500 accounts climb from 40% to top. - Filled area at `opacity: 0.18` in the account color + stroked line at full opacity on top — same treatment as the projection chart's saved series. - Grid track for the chart column widened from `minmax(60px, 1fr)` to `minmax(80px, 1fr)` so the curve has enough horizontal room to read. Removed `shared_spark_max` + `sparkline_map` + the bucketed inflow sparkline machinery. Per-row scale is correct here — magnitude already lives in the weight pill on the left and the "$X last 30d" column on the right; the chart's job is shape. * fix(goals/funding-widget): chart shows cumulative inflow, not balance level Balance trajectory rendered every account as "near the top with a gentle wobble" — pink ($1830/30d), orange ($0/30d), blue ($300/30d) all looked nearly identical because each was a positive balance with mild growth, and per-row 0-baseline scaling pushed all lines toward the ceiling. The chart and the "$X last 30d" column on the right were telling completely different stories on the same row. Switch the metric the chart plots: - Data: 31 daily samples (today − 30 … today) of *cumulative inflow* per account, fetched in one `GROUP BY (account_id, date)` over the 30-day window. Each per-account array is a monotonic non-decreasing prefix sum starting at 0. - Scale: per-row, anchored at 0, ceiling = `max(values) × 1.05`. - The chart's rightmost point now equals the "$X last 30d" column value by construction — chart and column tell the same story. - `last_30_money` is read off the cumulative array's last element, no separate aggregation query. Visual shapes after the swap: - Steady-inflow account → smooth diagonal climb - Bumpy/episodic account → step pattern with flat plateaus - No-inflow account → flat line at the bottom, no filled area Removed `balances` query path entirely; trajectory_for is gone. * fix(goals/funding-widget): non-scaling-stroke for trajectory line `preserveAspectRatio="none"` stretched the viewBox's 100×28 to the container's natural width (≈600px) while leaving the Y axis at 1×. With anisotropic scaling, SVG strokes inherit the path's local scale — horizontal segments rendered ~6px wide, vertical segments ~1.5px wide, diagonals in between. The line read as visibly fatter on the flat top run than on the climbing/dropping segments. Add `vector-effect="non-scaling-stroke"` to the line path so the stroke width stays a constant 1.5 CSS px regardless of how the viewBox is scaled. Filled area is unaffected (no stroke). * fix(goals/funding-widget): replace chart with last 30d + last 90d totals The cumulative-inflow chart kept producing readings that didn't match user mental models — chart endpoint = 90-day cumulative, right-hand column = 30-day total, and the visual line didn't carry the "this is per-week deposit activity" intuition that a sparkline implies. After iterating through bars, balance trajectory, and filled-area cumulative, simplest is best. Drop the chart. Each row now shows two right-aligned totals stacked vertically: - Primary line: "$X last 30d" — text-sm, text-primary, the "this month so far" headline answer. - Secondary line: "$Y last 90d" — text-xs, text-secondary, the quarterly-trend reference. Tells the user whether this account contributes regularly without forcing them to read a chart. Both numbers compute in one query — pluck (account_id, date, amount) over 90 days, sum per account into two buckets based on whether the entry's date falls inside the 30-day cutoff. Grid shrinks from 5 columns (avatar / name / weight / chart / total) to 4 (avatar / name / weight / two-totals), with the two-totals column getting 120px so both numbers fit right-aligned with their labels. Drop `funding_accounts_subtitle` and the chart-window plumbing (`TRAJECTORY_SAMPLES`, `cumulative_inflow_map`, `column_total_from`, SVG markup, `vector-effect`, etc.). * fix(goals/show): strip redundancy + sharpen catch-up framing The show page repeated the same data multiple times across surfaces that should each say one thing once. Per-screen counts before this commit: - Account % distribution: 4 places (distribution bar + dot-legend strip + 5-bar weight pill + % column) - Current balance: 3 places (ring, funding heading total, ring "of $X" subline) - Target amount: 3 places (header, ring subline, catch-up body) - Target date: 3 places (header, catch-up body, chart axis) - Pace: 2 places (catch-up body, projection subtitle) - ".00" cents: every monetary string This pass: - Funding widget drops the dot-legend strip (color/name/% triplet redundant with the distribution bar's color + the per-row avatar color) and the 5-bar weight pill (rendered as "1-of-5 sliver" for low-weight accounts — read as a glitch; the % number next to it covered the same fact). Row grid shrinks from 5 to 4 columns. - Funding section heading drops `· $187,031` — the ring card already carries the total balance. - Catch-up alert reframes: Title was "Save $26,621/mo to stay on track" (the *full* required rate, with the misleading "stay on track" while the pill says "Behind"). Now "Save $20,002/mo more to catch up" using `catch_up_delta_money` — the user's actual delta over current pace. Body collapsed from two with-date / no-date variants to a single "Current pace $X/mo · required $Y/mo to hit your target." Drops the target date duplication since the header already says it. Pledge CTA pre-fills with the *delta*, not the full required — so accepting it once funds the gap instead of stacking the full required rate on top of existing pace. Secondary link "Or adjust your target" → "Adjust target instead" (less defeatist framing). - Projection chart subtitle "At $X/mo you'll miss your target date." drops the pace duplication (catch-up above already states pace). New: "Falling short at current pace." Diagnostic only. - All money on the show page uses `format(precision: 0)`. The ".00" cents added no information at goal-tracking scale. - Header `Record pledge` demotes to `outline` variant when status is `:behind` — the catch-up alert below owns the primary action. One primary action per surface. Also adjacent fixes: - Funding widget keys avatar / distribution color off `account.id`, not `account.name`. Renaming an account no longer recolors it retroactively; two accounts with name-hash collisions no longer share a color (Ruby idiom audit finding). - `Goals::StatusPillComponent`: add `:completed` variant with `circle-check-big` icon. `Goal#display_status` now returns `:completed` when `goal.completed?` so a manually-completed goal (e.g. user stopped at 80%) reads "Completed" rather than falling through to `:on_track`/`:behind` and lying on the index. Locale: drop `body_with_date` (folded into `body`), `projection.behind` no longer carries interpolation args (caller doesn't pass them either), `projection.no_pace` plain-language rewrite ("inflow" → "deposits"), add `status.completed: "Completed"`. * fix(goals): align card + banner copy/numbers with show-page changes Tail of the redundancy + clarity pass: - Goal card on the index drops ".00" cents from every Money.format call (now `format(precision: 0)`). The card uses the same visual rhythm as the show page; cents add zero info at this scale. - Card's "behind"-status footer now reads "Save $X/mo to catch up" with X = `catch_up_delta_money` (the delta the user must add), not the full `monthly_target_amount` (which read as a total monthly burn). Same fix as the show-page banner. - Pending-pledge banner title becomes pluralized: drops "0 days left" / "1 days left" grammatical bugs. New locale tree: title.zero → "Pending: $X into Y · expires today" title.one → "Pending: $X into Y · 1 day left" title.other → "Pending: $X into Y · N days left" Also drops the "Watching for" phrasing (system-talk) for "Pending:" (state-talk) and drops cents from the amount. - `confirm_cancel_body` likewise renders amount without cents. Cards and banner now read consistently with the show page; one voice across the surfaces. * fix(goals): exclude pending transactions from pace + mobile-stack funding rows Two audit fixes that pair well. PF audit B20: pace, family velocity, and the funding widget's 30/90-day totals all summed Entry amounts over the linked accounts *including provider-pending transactions*. A pending Plaid/SimpleFIN deposit inflated pace today; the next sync that reversed or dropped it silently shrunk pace tomorrow, with no signal to the user. Worse, the reconciler could match a pending transaction and flip the pledge to "matched" before the underlying entry vanished. `.merge(Transaction.excluding_pending)` on the three Entry queries (Goal#pace, Family#savings_inflow_velocity, the funding widget's `inflow_totals_map`) brings the existing `Transaction::PENDING_PROVIDERS`-aware scope into play. Single-line fix across the three call sites. UX audit: funding-account rows used `grid-cols-[24px_1fr_48px_120px]` at every breakpoint. On a 375pt iPhone viewport that left ~50px for the name column after `p-5` padding + container chrome — name truncated to "Ban…" and the per-row % column squeezed against the weight/totals stack. The percent number is also already encoded in the distribution bar above the rows; on mobile it can disappear without losing signal. Drop the % column at < sm: - mobile grid: `grid-cols-[24px_minmax(0,1fr)_auto]` (avatar / name / totals) - sm+: original 4-column layout with the per-row % - per-row balance subline + accountable label now also drops `.00` cents (consistency with the rest of the page). * fix(goals/show): past-due target reads "was due" not "by" Copy audit edge case. When `target_date < Date.current` and the goal isn't completed/reached, the header rendered "Target $X by Jan 1, 2024" — present-tense "by" framing a past deadline. The card already has `goal_card.past_due` for this; the show header had no equivalent. Add `header.target_by_past: "Target %{amount} · was due %{date}"` and switch the header when `days < 0`. Skips the trailing "N days left" subpart since it'd render negative or stale. * fix(goals/index): persist filter + search in URL across reloads UX audit finding. The filter chip state and search input lived only in Stimulus values — a Behind-filter selection survived turbo morphs but vanished on F5, browser back from a goal's show page, and any deeplink share. For a family with 10+ goals filtering by "behind", every navigation reset to "all". Hydrate on `connect()`: - read `?filter=behind` → statusValue - read `?q=…` → input target Sync on every `filter()` call via `history.replaceState`: - filter=all → drop key - q empty → drop key - else preserve both Uses `replaceState` (not `pushState`) so each keystroke / chip click doesn't bloat the back-history. The page URL becomes shareable for the filtered view. * fix(goals/show): ring subtitle drops the target restatement The ring card's secondary line read "of $400,000 · $212,969 to go" — the "of $400,000" half duplicates the header's "Target $400,000 by Jan 10, 2027". Same number, two places, ~80px apart vertically. Drop the "of $target" half. Subtitle now reads "$212,969 to go" — single new fact, complementary to the header. * fix(goals/copy): pluralization, casing, voice cleanup Copy audit quick wins. - `needs_this_month_sub` dropped "across" preposition that read grammatically wrong at count=1 ("across 1 goal behind pace"). New: "1 goal behind pace" / "N goals behind pace" — count + noun matches the working sibling subtitles. - `on_track_sub_parts.no_date` was "1 open" / "N open" — collided with the chip and status pill labels "Open" (titlecase) on the same screen. New: "1 without a deadline" / "N without a deadline" — descriptive, lowercase, unambiguous. - `pledge_just_transferred` / `pledge_just_saved` dropped the past-tense + trailing-ellipsis form ("I just transferred…"). Modal title is "Log a transfer you made" / "Log money you set aside" — present-tense, resolved, clear about what the dialog does. - `goals.show.empty.heading` "Nothing's flowed in yet" → "No deposits yet". "Flowed" was novel jargon nowhere else in the vocabulary; "deposits" matches the surrounding copy. - `form_stepper.errors.amount_required` / `accounts_required` added "Please" prefix to match `name_required` — three errors with one voice. * fix(goals): reconciler logs to Sentry + rename :extend route to :renew Two Ruby idiom audit fixes. The Reconciler's outer `rescue StandardError` was logging at error level and moving on. Pipeline-protective (we don't want a Goal reconcile failure to break the Plaid/SimpleFIN/etc importer it's hooked into) but invisible — real bugs hid behind a warn log forever. Add `Sentry.capture_exception(e) if defined?(Sentry)` alongside the log, matching the pattern in `Account::Syncer`, `Sync`, `PlaidItem`, and the chart-series rescues this branch already added. Keep the rescue's protective function. `member do patch :extend end` shadows `Module#extend` — the controller action name competes with Ruby's most-common mixin entry point. `before_action :foo, only: %i[extend destroy]` reads as "extend this controller with :foo, only: …" to a casual reader, and stack traces against `def extend` look misleading. Rename to `:renew` (matches the existing copy: the button says "Extend 7 days," but the API verb is "renew the watching window"): - config/routes.rb: `patch :renew` - GoalPledgesController#extend → #renew - locale `goal_pledges.extend` → `goal_pledges.renew` - banner `extend_goal_pledge_path` → `renew_goal_pledge_path` - test refs updated The user-facing button text is unchanged. * fix(goals): months_remaining uses day-precision PF audit edge case. Calendar-month math undercounted near the deadline: May 30 with a June 1 target returned `1` ("save $5k this month"), then June 1 morning returned `0` (falls through to `remaining_amount` charged as one-month-required). Users saw a $5k/mo required rate for a 2-day window, then $5k flat on deadline day — a cliff that doesn't match reality. Replace calendar-month delta with `(target_date - Date.current) / 30.0` so a 2-day-out deadline reports ~0.07 months and `monthly_target_amount` scales proportionally. `[..., 0.0].max` keeps the past-due case zero-clamped. * fix(goals/stepper): inactive connector line uses border-subdued RUI audit: form-stepper progress line used `border-secondary` for the inactive state — same weight as the active step's border, so the active-step circle didn't visually pop against the line connecting it to the inactive step. Recede passive states. Swap to `border-subdued` (the DS's quieter divider) for the inactive (step 1) line state. The active state stays `border-inverse`. JS toggle in `goal_stepper_controller.js#updateStepperState` follows. * fix(goals): clarify "last saved" + add pledge timestamp to banner UX audit pair. Header "Last saved N days ago" was rendered from `Goal#last_matched_pledge_at` — date of the most recent *pledge-matched* entry — but the funding column on the same page shows "$X last 30d" computed off *all* entries. A user who deposited cash without recording a pledge saw "Funding · last 30d: $200" while the header still read "Last saved 47 days ago." Two adjacent figures contradicted each other. Rename the locale strings (used on both the index card and the show header) to reflect the actual data source: - footer_no_pledges: "No matched pledges yet" - footer_last_today: "Last pledge matched today" - footer_last_days: "Last pledge matched N days ago" Two open pledges into the same account previously rendered as two near-identical yellow banners with no way to tell which one the Cancel button targeted. Add a relative-time line below the body — "Pledged 2 hours ago" / "Pledged about a minute ago" — using `time_ago_in_words(pledge.created_at)`. Discriminator without changing the title or the action surface. * fix(goals): catch-up subtracts pending pledges from the demand UX audit finding. The catch-up alert demanded $X/mo without accounting for pledges the user had already recorded. The user recorded a $20k pledge → catch-up still demanded a fresh $20k → double-counting → stacked yellow CTAs telling them to do the thing they'd just done. Goal#catch_up_delta_money now subtracts `open_pledges.sum(amount)` from the demand: delta = max(monthly_target − pace − sum(open_pledges), 0) Uses the in-memory preloaded `open_pledges` collection (controllers already eager-load it), so no extra query. The clamp at zero keeps "$0/mo more" from rendering when pending pledges fully cover the gap. Alert branch in show.html.erb now also gates on `@goal.catch_up_delta_money.amount.positive?` — when the demand zeroes out via pending pledges, suppress the alert entirely. Status pill stays `:behind` (because `pace < required`), but the action surface goes quiet because the user already took it. * fix(goals/chart): full money format on "Short" annotation + 4-digit year on x-axis Two screenshot-driven audit fixes. The chart's "Short $160.6K" annotation used `_fmtMoneyShort`'s K/M shorthand while the page's other monetary readouts ("$26,621 to catch up", "$187,031 saved", "$1,830 last 30d") were full `Intl.NumberFormat` output. Inconsistent units in the same viewport. Switch the annotation to `_fmtMoney` ("$160,634 short") + reword to put the money first ("$X short" reads more naturally than "Short $X"). Y-axis tick labels keep the K/M shorthand — that column is space-constrained and the same convention is already understood as "axis abbreviation." The x-axis terminal tick rendered `"Jan '27"` from the `"%b '%y"` time-format string. A glance read it as January 27th of the year, not January 2027 — and the target-date tick is the single one users navigate the chart for. Switch to `"%b %Y"` → "Jan 2027." Slightly wider per tick; the existing adjacent- duplicate-removal logic keeps the count sane. * fix(goals): Mark complete confirm warns at sub-100% progress Behavioural audit edge case. A user clicking "Mark complete" at 80% saw the same generic confirm body as at 105% ("It leaves the Ongoing list…"). Sunk-cost-fallacy inversion + premature closure: once labelled complete, the goal anchors success on the truncated amount; future similar goals get smaller targets (regression to the lower aspiration). When `progress_percent < 100`, swap the confirm body to a specific one — "You're at 80% — $X of $Y. Marking complete records this as your achievement instead of the original target. Continue, or close this and adjust the target instead?" Doesn't block the action (some "stop short" cases are healthy — CFP literature explicitly endorses changing your mind), but makes the trade-off visible. Keep the original copy for the ≥ 100% case. `confirm_complete_body_short` is a new locale key; the kebab-menu builder picks between it and `confirm_complete_body` per-render. * fix(goals/pledge): redirect non-turbo-frame GET to goal show UX audit: `app/views/goal_pledges/new.html.erb` unconditionally renders the form in a DS::Dialog wrapper — when the user lands on `/goals/:id/pledges/new` directly (F5, bookmark, stale deep-link), the dialog renders as a freestanding modal over an otherwise-empty page. Compare to `goals/new.html.erb` which has a `turbo_frame_request?` branch with a full-page fallback. Pledges aren't usefully standalone — the modal only makes sense in goal context. Redirect non-frame GETs back to the goal show page instead of rendering the broken-looking standalone dialog. If we want a deep-linkable "open the pledge modal" experience later, that lands as a `?open=pledge` query on the show page that auto-fires the modal — out of scope here. * fix(goals): current_balance guards against linked-account currency drift Ruby idiom audit edge case. `linked_accounts.sum { |a| a.balance.to_d }` trusted the model's validation that all linked accounts share the goal's currency. The invariant holds at write-time, but direct DB writes, an account-currency edit outside goal validation, or future code that bypasses the validation chain could drift it. The naive sum would silently add raw EUR + USD numbers and surface the result as goal.currency. Filter `linked_accounts.select { |a| a.currency == currency }` and log/report-to-Sentry when the filtered count differs. The sum stays correct (no FX, no mixing) and the operator gets visibility into the drift. Same pattern as `Family#savings_inflow_velocity` already uses for the family-level rollup. * fix(goals/new): avatar default icon + restore .goal-avatar color-mix Two interlocking bugs on the new-goal modal's color/icon preview. 1. Avatar fell back to a literal "?" when icon + name were both blank — `form.object.name.to_s.strip.first&.upcase || "?"`. User reported the avatar looked empty on a fresh modal because the "?" disappears against many palette tints. Categories handle this by always showing the category icon. Replace the "?" fallback chain with a default `target` icon (matches the goal creation header's iconography): • icon present → render that icon • icon blank, name → render first letter • icon blank, no name → render default "target" icon 2. Picking a color via the Pickr color picker called `updateAvatarColors(color)` which inlined `style.backgroundColor` + `style.color = color` — overriding the `.goal-avatar` class's `color-mix(in oklab, var(--avatar-color) 55%, black)` rule. The class handles theme-aware contrast (darken text in light mode, full color in dark mode); the inline override killed it and text rendered at the same lightness as the 10% tint background. Update only the `--avatar-color` CSS variable; let the class continue computing the resolved colors. Wire the avatar to the goal-stepper controller properly: `_color_picker.html.erb` gains `data-goal-stepper-target="avatarPreview"` on the span. `nameChanged` now updates the avatar directly (the previous selector queried `[data-testid="goal-avatar"]` which doesn't exist on the color_picker span) and: - swaps to the first letter as the user types, - restores the default-icon HTML (captured at connect) when the name is cleared, - bails when the user has explicitly checked an icon radio (don't undo their choice). * fix(goals): demote Behind pill to neutral surface + drop em-dashes Behavioural + RUI audit follow-ups. The yellow overload finding flagged three concurrent yellow surfaces on the show page: the "Behind" status pill, the catch-up alert, and the open-pledge banner(s). Demoting the alert to outline ownership of the primary CTA addressed one layer, but the pill kept fighting the alert for hue attention. "Behind" is a state, not a call to action; the alert owns the action signal. Switch the pill's classes from `bg-yellow-500/10 text-yellow-700` to `bg-surface-inset text-yellow-700` (with the same dark-mode override). Background goes neutral (matches paused/archived chips); the text keeps the warning hue and the triangle-alert icon stays. Signal preserved, weight reduced. The yellow alert below now reads as the primary nudge instead of one of three matching tones. Also: copy/em-dash sweep across goal surfaces. User-facing strings that contained em-dashes ("Reaches 70% — $X of $Y", "into your linked account — Sure will catch it", "You're at 80% — $X of $Y") read as a stylistic tic; replace with comma/period/period respectively. Form-stepper review placeholders "—" become "…" (ellipsis reads as "not yet set" without the typographic weight). Code comments + log messages also scrubbed for consistency; awkward sed artifacts (//. its...) restored to readable English. No locale-key shape changes; pure string-content edits + one component-style tweak. * fix(goals/copy): apply stylistic pass from copy expert Second pass on user-facing strings after the em-dash sweep and yellow-pill demotion. Voice/abbreviation/edge-value parity. Voice consistency: - `index.pending_pledges_callout` reframed from "Sure is watching your linked accounts" (system-as-watcher voice) to "You have pending pledges. Sure will confirm them on the next sync." (user-actor, system-action). Matches the surrounding user-centric voice on the KPI strip and the helper-text pattern ("Sure will look for…", "Sure will catch it") used elsewhere. - `goal_pledges.new.helper_manual` flipped pronoun "We'll record" to "Sure will record" so the modal's two helper lines share a single narrator. The transfer-helper already says "Sure will look for"; this matches. - `form_stepper.errors.*` dropped the apologetic "Please …" voice ("Please give your goal a name.") for the terse imperative the rest of the feature uses ("Give your goal a name." / "Set a target above zero." / "Pick at least one funding account."). Parallelism: - `kpi.velocity_delta_zero_base` was the only `velocity_delta_*` string spelling out "30 days" while siblings used `30d`. Switch to "First 30d of activity" so the sub-tile reads in one unit. - `Depository` titlecase in `at_least_one_linked_account_required`, `must_be_depository`, and `no_depository_accounts` collapsed to lowercase. Common noun, not a UI label. Matches the empty-state body in `funding_accounts.empty.body` which was already lowercase. Test fixture for `must_be_depository` updated. - `projection.reached` was the same string as `celebration.heading` ("Goal reached. Nice work."), making the celebration moment feel templated. The projection slot is the chart's empty state when there's nothing to project; rephrase to "You've hit the target. No projection needed." Celebration keeps the warm tone. Edge value: - `celebration.body` was "You hit your $X target." When the user marks a goal complete at sub-100% (a flow the new `confirm_complete_body_short` already warns about), this lied about the achievement. Rewrite to "Goal closed at %{saved} of %{target}. Keep it as a record, or archive it now." Interpolation now passes both `saved` and `target` from the show template, so the celebration card honors the actual saved amount whether the user hit, overshot, or stopped short. Notes deferred (verify-only, not string changes): - `goal_card.footer_catch_up` is interpolated with `catch_up_delta_money` in `CardComponent#footer_line`; the show- page guard `.amount.positive?` already lives there. No copy change needed. - `pending_pledge.title.zero` bucket fires only when `count: 0` reaches the I18n call; `GoalPledge#days_left` clamps at 0, so the friendlier "expires today" copy is reachable. - `paused_banner.title` / `inactive.heading_paused` duplicate strings noted but left in place; consolidation is a separate refactor. * fix(goals): scale up card/widget/chart text, fix chart continuity, ease ring focal point Five small audit follow-ups bundled because they were each one-line swaps and individually wouldn't earn their own commit. Card text scale (vs Sure house style — budget_category h3 ≈ text-base, budget _actuals_summary value text-xl, account row text-sm subtype): - goal card title text-sm → text-base - goal card balance text-lg → text-xl - goal card pace/footer/subtitle text-[11px] → text-xs - funding row subtype subtitle text-xs → text-sm - funding row "last 30d / last 90d" labels text-[10px] → text-xs Chart label scale (projection chart was an outlier at font-size: 10 while time_series_chart_controller uses 12): - every `font-size: 10` in goal_projection_chart_controller.js → 12 - tooltip cssText font-size: 11 → 12 Color-picker pen toggle on the new-goal avatar was w-6 h-6 (24px circle, ~55% of the lg 44px avatar). Shrink to w-5 h-5 + add a w-3 h-3 class on the inner icon so it scales down with it. Graph continuity bug: the saved-line endpoint and the projection-line start point could disagree by tens of $thousands. Saved came from `Balance::ChartSeriesBuilder` (daily snapshot in `balances`), projection started at `currentAmount = goal.current_balance.to_f` (live `linked_accounts.sum(:balance)`). When the snapshot lagged the live read, the chart showed a vertical gap at the "today" marker. Filter any same-day-or-later points out of the raw saved series, always extend the saved series to `(today, currentAmount)`. Saved line now closes at exactly the projection's start. The recent balance-drop story is still honestly shown (the line dips toward the live value rather than ending at the stale snapshot). Ring card focal-point (RUI audit): the left ring card on goals#show sat at the same `shadow-border-xs` elevation as the projection chart and funding card. "When every card is raised, nothing's primary." Drop the shadow + container background — the ring now reads as a status panel sitting on the page surface, not a content card competing with its neighbours. Paused/archived/celebration/empty right-slot variants keep elevation since they ARE content cards. Deferred: light-mode pink distribution-bar contrast. The fix needs a DS token decision (hairline outline vs darker step on the palette entries); rolling it into a polish PR risks dragging in DS changes unrelated to goals. Logged for a follow-up. * fix(goals): unified per-goal account color map + smaller pen toggle User flagged two regressions: account colors didn't match between the goal preview-card avatar stack on the index and the funding-widget rows on the show page, and the color-picker pen toggle on the new-goal modal still felt too big. Color matching: - `AccountStackComponent` (index card) used `Goals::AvatarComponent.color_for(account.name)` — MD5-of-name into the 10-color palette. - `FundingAccountsBreakdownComponent` (show page) recently switched to `color_for(account.id.to_s)` — MD5-of-id. - Same account, two surfaces, two different palette picks. Plus either hashing scheme can collide within a multi-account goal (palette has 10 colors). Move ownership to the Goal model: `Goal#account_color_map` returns `{ account_id => palette_hex }` for the goal's linked accounts. Sort by `id` for a stable order across reloads, then assign `palette[i % palette.size]`. Stable + collision-free up to 10 accounts in a single goal (a realistic upper bound — most goals link 1-3). Both consumers now read off the same source: - `AccountStackComponent.new(accounts:, color_map:)` accepts a hash and falls back to the name-hash if no map provided (kept for callers that don't have a goal in scope yet). - `FundingAccountsBreakdownComponent#color_for` reads `goal.account_color_map[account.id]`. - Goal card on index passes `goal.account_color_map` to the stack. Pen toggle: The new-goal color-picker pen sat in a `w-5 h-5` circle with a `border` ring + `text-secondary` icon. The border + secondary text weight kept it loud against the avatar even at 20px. Drop the border, drop the size another step (`w-4 h-4`), recolor the icon `text-subdued` + `hover:text-secondary` so the affordance recedes when not interacted with. Position shifts from `-bottom-1 -right-1` (8px overhang) to `-bottom-0.5 -right-0.5` (2px overhang) since the smaller circle doesn't need the larger float. Icon swaps "pen" for "pencil" (the more conventional edit indicator across Sure). * fix(goals/show): move Edit into kebab, match house style User clarification on the "too big edit icon" finding: the header Edit button itself (not its icon) is what felt wrong. Investigation showed the wider Sure pattern. Every other "Edit" affordance in Sure lives inside a DS::Menu kebab: - app/views/categories/_category.html.erb - app/views/rules/_rule.html.erb - app/views/family_merchants/_family_merchant.html.erb - app/views/chats/_chat_nav.html.erb - app/views/accounts/show/_menu.html.erb - app/views/transactions/show.html.erb Header rows reserve top-level buttons for primary actions (e.g. "New transaction", "Record pledge"). The goal show page was the outlier — Edit as an outline button next to Record pledge, which left two competing CTAs in the header. Move `menu.with_item(text: t(".edit"), icon: "pencil", ...)` to the top of the kebab list. Header now has a single primary CTA (Record pledge, demoted to outline when status is :behind) + the kebab. Matches every other Sure resource page; eliminates the "button-too-big" framing entirely without resorting to ad-hoc icon-size overrides (the `[&>svg]:w-4 [&>svg]:h-4` arbitrary selector hack would have been a one-off, nobody else uses it). Avatar pen toggle on the new-goal color picker stays reverted to its original w-6 h-6 + border-2 form, per the user. * feat(goals/demo): seed full state-coverage matrix + sample pledges User asked for demo seed variety so every goal state surfaces on at least one card. Previous seed only spanned 4 AASM states; the computed status (:reached / :on_track / :behind / :no_target_date) and the edge-state copy paths (past-due target_date, open pledge banner, "Last pledge matched") were absent. New seed coverage matrix: AASM states (column): active → Vacation in Italy, Wedding fund, Emergency fund, House downpayment, Coffee gear, Tax prep buffer paused → Sabbatical completed → Paid-off car archived → Old laptop fund Computed status (active goals): :behind → Vacation in Italy, House downpayment, Tax prep buffer :on_track-ish → Wedding fund (12-month timeline + small target) :no_target_date → Emergency fund :reached → Coffee gear (target 150 below any plausible account balance — progress hits 100% live) Edge surfaces: Past-due active → Tax prep buffer (target_date 2.months.ago, exercises "was due" header copy and the months_remaining = 0 branch in monthly_target_amount) Open pledge banner → Vacation in Italy + House downpayment each ship a single open pledge. The show-page banner renders; the index pending-pledges callout renders because @any_pending_pledge flips true. Matched pledge → Wedding fund: after the main seed loop, find_by(name: "Wedding fund") + locate the most recent non-claimed primary-account inflow Transaction (>= 30 days, amount < 0 per Sure's sign convention), create a matched-status pledge against it, stamp the Transaction's extra->goal->pledge_id per the partial-unique-index invariant. The show-header then renders "Last pledge matched N days ago" via Goal#last_matched_pledge_at. Implementation notes: - Pledges spec embeds inside each goal_spec as an optional `pledges:` array. The loop creates them after goal.save! using the goal's linked_accounts as the default account; the GoalPledge# account_must_be_linked_to_goal validation passes because every spec's account is one of the goal's linked accounts. - The matched-pledge seed is split into a dedicated helper (`seed_matched_pledge_demo_for_wedding!`) because it depends on Transactions seeded earlier in the demo flow. Both no-Wedding- goal and no-recent-inflow guards bail cleanly so older demo variants still work. - All seed targets are intentional. Goal#status reads the live linked-account balance + 90-day inflow at render time, so the demo statuses adapt to whatever the rest of the demo seeded. The targets are sized so the *intended* status is the most likely one for typical demo data. Local DB unaffected: this is the demo-family generator only, run via `Demo::Generator.new.generate_default_data!` against a fresh family. * chore(goals): drop architecture notes from the repo Pulls the two early design notes out of git tracking. They covered the V1 ledger-based design and the engineering mechanics that led to the V2 rewrite. With V2 shipped, the notes have served their purpose and the design-of-record now lives in the code + this PR. Files stay on disk locally (added to .git/info/exclude so future git status doesn't re-surface them as untracked). Anyone who wants the V1 reference can pull from the source branch where this work started. * fix(goals): test pledge new across both turbo-frame and full-page paths CI failure on the prior commit: `GoalPledgesControllerTest# test_new_renders_the_pledge_form` expected 200 but got a 302 to the goal show page. The recently-added non-frame guard on `GoalPledgesController#new` redirects direct GETs (F5, bookmark) back to the goal so the dialog doesn't render standalone, and the test wasn't sending the `Turbo-Frame` header that the modal flow uses in production. Split the test into the two paths the controller actually serves: - `new renders the pledge form inside a turbo frame` passes a `Turbo-Frame: modal` header and asserts 200 — the real modal flow. - `new redirects to the goal show page on a non-frame GET` asserts the 302 to `goal_path(@goal)` — the guard's intended branch. Together they cover the controller's actual contract. * docs(goals): add llm-guide reference for the goals feature Captures the architecture, key files, data model, status semantics, pledge match policy, connected-vs-manual account detection, color map convention, common tasks, and known gotchas. Matches the existing llm-guides pattern (architecture diagram + file inventory + task-oriented sections + reproducible commands). The doc is forward-looking: it covers how to add a new field to Goal, a new status branch, a new pledge kind, and how to safely touch the reconciler. The "Gotchas" section catalogues the known-incomplete-but-shipping items so a future audit doesn't re-derive them from scratch. Demo data regeneration command is included for anyone who needs to refresh the seed. * fix(goals/index): completed goals join the chip-filterable grid Completed goals previously lived in a dedicated section below the active grid that was always visible regardless of which chip the user selected. They were the only state without chip filter representation. Fold completed into the main grid in controller-side order: active goals first (sorted by status rank), completed after (alphabetical). Drop the separate "Completed" section. The `data-goal-status="completed"` on each card (from `Goal#display_status`) makes them filter naturally when the new `completed` chip is selected. Archived stays in its own collapsed-by-default `<details>` section below — the visual-hide-by-default is the point there and a chip wouldn't preserve that. `@active_goals` keeps its meaning (active-only) for the KPI strip, the pending-pledges callout, and the search-visibility check needs `@grid_goals` so search shows up at six combined cards. Section heading: "Ongoing" → "Goals". The heading now covers the combined active + completed list, and "Ongoing" misrepresented what's below it. * fix(goals): address AI review on PR #1798 (CodeRabbit + Codex) Correctness: - GoalPledge#matches? rejects outflows on transfer pledges so a +$200 purchase no longer satisfies a $200 deposit pledge after .abs - GoalsController#sync_linked_accounts! saves through the goal so currency/depository/family validations actually run on update - AlreadyClaimedError replaces empty RecordInvalid in resolve_with! and reconciler rescues the dedicated class - SweepExpiredGoalPledgesJob wraps each expire! in a per-record rescue - Assistant::Function::CreateGoal disambiguates duplicate account names and returns an absolute URL via mailer host config - Family#savings_inflow_velocity defensively scopes from the family's accounts (was Account.joins(:goal_accounts).where(goal_id: ...)) - GoalPledgesController#set_goal preloads linked_accounts + providers to drop the N+1 on any_connected_account? - Stepper subtitle update walks to the enclosing dialog before querySelector so two stepper instances don't fight over one header - categories/_form.html.erb data-action targets color-icon-picker, not the non-existent "category" controller UX / visual: - Projection chart drops preserveAspectRatio="none" and pins endDate at today for past-due goals so the today marker stays in-domain - _color_picker / categories form swap non-standard border-1 for border - Goals index search input uses ring-alpha-black-100 (was raw gray-500) Refactors: - Goal#header_summary extracts the multi-line ERB header block - Goal#catch_up_delta_money sums open_pledges in SQL - Goal#projection_summary uses I18n.l for the on-track month label - Account#default_pledge_kind moves the manual/transfer decision out of GoalPledgesController - GoalPledge::Reconciler iterates ordered (created_at, id) so first-claim wins is deterministic under non-sequential PKs - Goals::FundingAccountsBreakdownComponent + Goals::AccountStackComponent use clamp(0..) instead of Float::INFINITY / [x, 0].max - Goals::StatusPillComponent#label provides a titleize fallback - Goal projection chart skips the redundant initial _draw and reuses the snapped point in the past branch (no double-bisect) - Goal pledge preview drops maximumFractionDigits: 0 so USD/EUR show cents while JPY/KRW stay whole-unit - Demo generator captures the Wedding fund goal in the seed loop instead of looking it up by hardcoded name Tests: - GoalPledgeTest: outflow rejection - GoalsControllerTest: cross-currency attachment rejected on update - SweepExpiredGoalPledgesJobTest: cancelled coverage + per-record rescue - GoalTest: pledge_action_label_key flips to manual_save without an unconditional guard * fix(goals): address second AI review round on PR #1798 - Parse "YYYY-MM-DD" date-only strings as local midnight in the projection chart so users west of UTC stop seeing the today marker and hover dates land one calendar day back - Order the demo-generator depository pickup by (created_at, id) so primary/secondary roles stay stable across reseeds and the state matrix (behind / on_track / reached / no_target_date / past-due) surfaces the same goals every time - Drop the brittle " · "-split on goals.goal_card.days_left in Goal#header_summary (the translation has no separator suffix) - Goal#projection_payload ships pre-formatted strings for the static chart annotations (target_amount_label / short, projection_end_label, projection_shortfall_label, pending_pledge_label_short) and the controller now renders those instead of running Intl.NumberFormat on each draw. Y-axis tick labels stay JS-side because they depend on D3's dynamically-chosen tick values. * fix(goals): round-3 review polish on PR #1798 - Demo seed_matched_pledge tie-breaks `entries.date DESC` with `entries.id DESC` so dense-same-day inflows pick the same row on every reseed - projection_payload exposes the family-currency symbol via Money.new(0, currency).symbol; the chart's `_fmtMoneyShort` / fallback now reads it instead of the hardcoded $/€/£ map, so JPY/KRW/CHF goals get the correct glyph * fix(goals/chart): use optional chain for currency_symbol fallback Biome lint flagged `(this.dataValue && this.dataValue.x) || fallback` as `lint/complexity/useOptionalChain`. Same behaviour with `this.dataValue?.x || fallback`, lint clean. * ux(goals): polish detail page + unbreak render - Fix render-blocker: Money#symbol doesn't exist (use #currency.symbol). - Sanitize projection_summary so the _html locale renders <strong> markup instead of escaping it. - Switch donut + card ring track to --budget-unused-fill; --budget-unallocated-fill resolves to the same gray as bg-surface in light mode so the unfilled arc was invisible on the detail page. - Mobile detail: drop avatar, right-align action buttons, stack projection header (subtitle + legend) so the subtitle reads on one line; bump legend gap on mobile. - Nowrap the projected reach-date so e.g. "Jul 2026" stays together. * ux(goals): redesign show page — one CTA, calm banners Header collapses to title + kebab. The status pill and the `Record pledge` button leave the title row. Status moves into a one-line callout below the subtitle that doubles as the catch-up demand when behind, the reach-date when on track, or a prompt for a target date when missing. `Record pledge` is now the only pledge entry point on the page and lives under the ring. Behind goals pre-fill it with the catch-up delta. The standalone catch-up alert card is gone — its title is the callout, its pace breakdown moves into the projection chart's subtitle, and its CTA is the ring-adjacent button. The "Adjust target instead" link is absorbed into the kebab's existing Edit item. Pending-pledge banner switches from a warning Alert to a neutral container chip. It is informational state, not a warning. Title carries the relative pledged-at meta inline; verbose auto-confirms body stays but in subdued size. Projection chart drops the today-line pending stub (vertical line + dashed marker + "+ pending $X" text). That data already lives in the pending banner above the chart; the duplicate annotation clutters the today line, the small dashed circle reads as misaligned at small pending amounts, and the label overlaps the projection trajectory. Shortfall label gets a paint-order halo so it stays legible across the dashed projection line. * Pipelock noise * fix(goals): jjmata review — reconciler guard, chart i18n, pace test Three issues raised on PR #1798 review: - ProviderImportAdapter now memoizes account.goal_accounts.exists? per-account so a bulk historical import on an unlinked account short-circuits the reconciler instead of paying one SELECT per row. Linked accounts still hit the per-row reconciler with no change. - goal_projection_chart_controller.js reads Today / Projected / Saved labels via Stimulus values fed from goals.show.projection.* locale keys instead of inlining English. - goal_test.rb now covers Goal#pace with real inflows, asserting the 90-day window cutoff plus the Transaction.excluding_pending and entries.excluded = false filters. * fix(preview): replace PR preview cleanly on redeploy (#1819) * fix(preview): delete stale container app before redeploy (#1820) * fix(preview): run preview container in development (#1821) * ux(goals): fix "0 of N · N reached" KPI weirdness When every active goal already hit its target, the "Goals on track" tile read "0 of 2 · 2 reached" — logically correct but emotionally upside-down. Reached goals aren't being tracked toward pace anymore; they belong in the trophy column, not in the fraction. - New `tracked_total` excludes reached and paused goals from the denominator. Paused stops the pace clock on purpose; reached has already cleared it. - When `tracked_total` hits zero and at least one goal is reached, the tile swaps to a celebratory empty state ("All caught up · N reached") instead of trying to render a fraction with no denominator. - Drop "reached" from the subline when the fraction is calculable. The fraction is a needle, "N reached" is a trophy — surfacing them together muddied the message. Reached only appears in the all-caught- up empty state from here on. Active-first / reached-last grid order already drops out of the existing ACTIVE_STATUS_RANK sort (reached defaults to the lowest rank so it naturally lands after behind / on_track / no_target_date / paused). * feat(goals): gate Goals v2 behind beta features toggle Add require_beta_features! to GoalsController and GoalPledgesController, hide the Goals nav item for non-beta users, and tag index/show headers with the Beta pill marker. Update controller tests to enable the preference in setup and assert the redirect for users without access. * feat(goals): add Beta dot marker on sidebar nav rail Pass beta: true on gated nav items so the nav_item partial renders a violet dot-only pill in the top-right of the icon. The doc covers the dot_only usage; the nav itself was never wired up before merge. * fix(DS::Pill): readable contrast in light mode + drop pill from Goal detail - Bind CSS `color-scheme` to Sure's `data-theme` attribute so the pill's `light-dark()` resolves to the side that matches the active theme. In the dark theme it was previously falling back to the light branch. - Darken light-mode pill text 30% with black on top of the 700 stop so the 10–11px uppercase label reads against the violet-50 background. - Drop the Beta pill from the Goal detail page header. A single goal is not the feature; the pill belongs on the feature index, not on each record. * docs(beta-gating): document main-nav dot marker via beta: local The nav-item partial already supports a `beta: true` local that overlays the DS::Pill dot on the icon, but the gating guide didn't show how to wire a gated nav entry through it. Add a short "Gating the main nav" section with the compact-array pattern, and mention the flag in the GA removal checklist. * feat(beta-gating): beta_gated_nav_item helper auto-marks gated entries Wraps the conditional + dot wiring into a single call so adding a new beta nav entry doesn't require remembering to set `beta: true` by hand or duplicating the `beta_features_enabled?` check. Naming mirrors the existing `BetaGateable` concern. * refactor(css): move .goal-avatar rules out of application.css Goals-specific styling doesn't belong in the global stylesheet. Extract the avatar tint + theme-aware text color into a topical goals.css and @import it alongside the other feature CSS files. * fix(goals): validate color format + restore cascade on drop migration - Add hex-format validation on Goal#color so submissions can't smuggle arbitrary CSS into the style attribute on the avatar / picker preview. The picker accepts custom hexes, so format validation (not inclusion) is the right shape — anything not matching #RRGGBB is rejected at the model boundary. - Fix the on_delete in the down block of drop_goal_contributions to match the original cascade. Restoring with restrict was a schema drift that would have shifted referential behavior after a rollback. * fix(goals): clear state-dependent caches on AASM transition + harden sweep job - Goal: `display_status` and `projection_summary` memoize a value that depends on the AASM state column. Without resetting them after a transition the same instance keeps returning the pre-transition value. Hook `after_all_transitions :reset_state_dependent_caches!` undoes the memos so post-`archive!` / post-`pause!` reads see the new state. - SweepExpiredGoalPledgesJob: the inner rescue covered per-pledge failures but not cursor-phase failures (DB blip, OOM mid-batch). Add an outer rescue that reports + re-raises so Sentry sees the failure and Sidekiq retries the job. * i18n + a11y(goals): extract picker strings + drop redundant status-pill aria-label - Color picker had four hardcoded English strings ("Color", "Icon", "Poor contrast, choose darker color or", "auto-adjust."). Move them under `goals.color_picker.*` and call them through `t()`. CLAUDE.md requires every user-facing string go through i18n. - Status pill duplicated its visible label in `aria-label`, which makes screen readers ignore the visible text. Drop the override so the visible label is the accessible name. * fix(goals JS): listener cleanup on color/icon picker + debounce filter URL sync - color_icon_picker: listeners were attached in initialize() with inline arrows, so they had no removable reference and no disconnect() cleanup. Every Turbo navigation that re-rendered the picker stacked another listener on the same node and left the Pickr instance alive. Move attachment to connect(), store bound references, and clean up in disconnect() (including destroyAndRemove on the Pickr). - goals_filter: replaceState fired on every keystroke. Debounce the URL sync 200 ms so a typing burst collapses into a single update. The visible filtering stays real-time. Clear the timer in disconnect() so a pending sync doesn't fire on an unmounted controller. * fix(a11y): focus trap + returnFocus on DS::Dialog Native <dialog>.showModal() moves focus inside the dialog on open but doesn't trap Tab / Shift+Tab, and focus restoration on close is inconsistent across engines. Add three things to the dialog controller: - Capture document.activeElement before showModal() so the trigger is recoverable when the dialog closes (ESC, backdrop click, explicit close button, programmatic close all route through the native close event). - Wrap Tab inside the dialog so a keyboard user can't tab out into the scrim-covered page behind. - Restore focus to the captured trigger on the close event. If the trigger has been detached (Turbo morphed it out), skip silently rather than throw. Verified manually: opening the new-goal modal moves focus to the name input; ESC restores focus to the "New goal" link; Tab wraps from the last focusable back to the first. * perf + tests(goals): share account-ids across velocity windows + cover gaps - Family#savings_inflow_windows wraps the current/prior 30d sums in a single helper that memoizes the linked-account-id lookup. The KPI tile on the goals index used to run the join+pluck twice per request. - Replace two instance_variable_set pokes and one any_instance.stubs in the goal/controller tests. Refetching the goal exercises the real request lifecycle and stops the tests from leaning on implementation details. The 'All caught up' assertion now relies on a real reached state (target 1 vs the depository fixture's 5000 balance) rather than stubbing :status. - Add tests covering: hex format validation on Goal#color, AASM cache reset (display_status reads the new state on the same instance after pause!), negative pledge amount rejection, expire! no-op on already- expired pledge, cancel! NotOpenError on non-open pledge, sweep job idempotency on a second pass, and strong-params rejection of state / family_id on goal create. * fix(goals): apply CodeRabbit findings - Switch the goal_accounts → accounts FK from on_delete: :cascade to :restrict. `Goal#must_have_at_least_one_linked_account` is enforced at write time; the cascade let a raw DELETE silently orphan a Goal whose only link pointed at the deleted account. Normal Rails Account#destroy still cleans up via `dependent: :destroy`, but the restrict guarantees the DB rejects any path that bypasses the association. - projection_payload: required_monthly is now monthly_target_amount&.to_f so open-ended (no-target-date) goals serialize required_monthly: null instead of 0, matching the absence of a required pace. - index page + sidebar nav-rail dot now read the Beta label via t("shared.beta") (and a new shared.beta locale key) instead of the hardcoded "Beta" literal. - _status_callout uses the view-helper t(...) instead of I18n.t(...) for the status label so it follows the same convention as the rest of the goals views. - goal_projection_chart: read the computed style before stamping position: relative so a stylesheet-defined position (fixed/sticky/ absolute) isn't clobbered. - preview-deploy: add `set -euo pipefail` around the wrangler container lookup so a curl/jq failure fails the job instead of producing an empty CONTAINER_ID and silently skipping cleanup. * revert(goals): move .goal-avatar back into application.css Sure's convention for one-off custom classes (.combobox, .scrollbar, .windows, .prose variants, .table-divider, .turbo-progress-bar) is to define them directly in application.css. Topical files (privacy-mode, date-picker-dark-mode, print-report) are reserved for coherent feature namespaces with multiple rules. A single .goal-avatar rule belongs with the other custom classes. * fix(goals): goal status pill uses DS::Pill outline (consolidate + survive hover bg) The status pill on the goal card used a 10%-alpha fill (bg-warning/10, bg-green-500/10). On the card's hover state (bg-surface-hover) the fill blended into the new background and the pill lost its tint outline. Extend DS::Pill with a green tone and an optional icon: param (renders a Lucide icon in place of the dot) so the same primitive can carry both the beta marker and the goal status badges. Map Goals::StatusPillComponent to DS::Pill outline style — transparent fill + colored border + colored text + glyph — which is immune to any change in the surrounding card bg. One badge primitive, light-mode contrast already fixed (the color-mix 30% darkening on text), and the card hover state no longer washes out the status. * fix(goals): drop hover bg on card, use subtle shadow lift instead The card was the only place in Sure setting hover:bg-surface-hover on a bg-container card; every other static card (settings, recurring transactions, ai_prompts, etc.) stays still. The hover bg (gray-100) landed almost exactly on top of the ring track (gray-200) and washed out the pill fill, fighting the very signals the card was trying to show. Swap to hover:shadow-sm — the lift matches the transaction-tabs precedent already in Sure, the bg stays white, and ring track + status pill keep their contrast. * fix(goals): drop no-target-date goals from the on-track denominator The KPI tile reads 'X of Y on track'. Y was every active goal minus reached + paused, which included open-ended goals (no target_date). But an open-ended goal has no required monthly pace to compare against — by definition it can be neither on track nor behind. Counting it in the denominator dragged the ratio down and never improved as the user kept saving (the fraction stays stuck because the open-ended goal is never a hit). Exclude :no_target_date from tracked_total. Numerator unchanged. The subline still surfaces 'N without a deadline' as informational so the user knows those goals exist. * fix(goals): keep archived cards out of the filter loop entirely The earlier 'filter archived too' attempts kept toggling the archived section based on chip state, which produced more confusion than value (filter shows partial counts, archived hides on some chips, etc.). Step back: archived stays in its own collapsed-by-default section, always visible, never reacts to the chip / search filter. Render the cards with filterable: false so they don't add a filter target in the first place — no JS handling needed, and the active grid + chips behave exactly like they did before this whole thread. * feat(goals): pending-pledge dot on card avatar Goals with open + unexpired pledges now carry a small amber DS::Pill dot at the top-right of the avatar on the index card. Same primitive + position pattern as the beta gate dot on the sidebar nav, so the 'small marker' affordance reads consistently across the app. Pledges are preloaded via the existing .includes(:open_pledges, ...) on the index query, so the indicator is free at request time. * fix(goals): swap pending-pledge avatar dot for inline clock glyph The amber DS::Pill dot on the avatar collided visually with the amber 'Behind' status pill on the same card — two amber signals in the same eye-line. Move the indicator to a text-subdued clock icon between the goal name and the status pill: quieter, semantically clearer (clock = pending sync / time-bound), no tone collision with the status palette. Same accessibility hook (aria-label + title). * feat(goals): footer 'N pending' on cards + drop warning tone from top callout - Pending pledges surface in the card footer as '· N pending' tacked on after the existing footer line (text-subdued). Quiet, semantic, doesn't compete with the status pill or the avatar. - The top-of-page 'You have pending pledges' callout was using the amber DS::Alert warning variant. Pending isn't a warning — it's a passive 'we're waiting on a sync' state. Switch to the info variant so the visual weight matches the meaning. * fix(goals/demo): seed goals in generate_new_user_data_for! Cloudflare preview entrypoint, FamilyResetJob, and the Settings "Reset + load sample data" flow all go through generate_new_user_data_for!, which seeded categories/accounts/transactions/budget but not goals. Move generate_goals! inside this method (alongside the same call already in generate_default_data!) so every sample-data surface gets the full state-coverage matrix. * fix(goals): card hover uses bg-container-hover (gray-50) instead of shadow lift Mirror the affordance used in the accounts/select_provider screen and the bank-sync flows: a near-imperceptible gray-50 fill swap rather than a shadow. Lighter than the previous shadow lift, doesn't introduce elevation noise inside the grid, and the ring track (gray-200) + status pill outline still keep enough separation against the gray-50 hover bg that we don't reintroduce the original contrast issue. * fix(preview): surface demo data failure logs (#1865) * refactor(goals): use semantic color tokens for ring + status callout `Goals::CardComponent#ring_color` and `goals/_status_callout` reached into the Tailwind palette directly (`text-yellow-700`, `var(--color-green-600)`, etc.) for status-coded colors. The sure-design-system already exposes the matching semantic tokens (`text-warning`, `text-success`, `--color-success`, `--color-warning`), which theme-swap correctly in dark mode and survive palette renames without view edits. - `ring_color`: collapse `:reached` / `:on_track` to `--color-success` (the status pill already differentiates them via icon — completed star vs check) and `:behind` to `--color-warning`. The `:no_target_date` fallback keeps `--color-gray-400` for now since there's no semantic neutral token; that gets cleaned up alongside the DS::ProgressRing extraction. - `_status_callout`: drop `text-yellow-700 theme-dark:text-yellow-300` and `text-green-700 theme-dark:text-green-300` for the equivalent semantic `text-warning` / `text-success` utilities. No visual regression in light mode (success collapses two adjacent greens into one); dark mode now properly inverts via the design system's theme variants instead of hand-rolled overrides. The `stroke="var(--budget-unused-fill)"` track on the inline card ring stays for now — that's a token-rename refactor that touches budget code outside this PR's scope and lands cleanest with the DS::ProgressRing primitive that consolidates the three ring implementations. * fix(goals): replace ring-gray-500 with semantic ring-alpha-black-500 token The colour-picker swatches were using the raw Tailwind palette utility `peer-checked:ring-gray-500`. Swap for the design-system functional token `peer-checked:ring-alpha-black-500` so the focus ring inherits the same alpha-on-surface treatment used elsewhere in the system and respects dark mode. Flagged by sure-design's DS Drift Patrol on #1798. * refactor(goals): migrate index search field to DS::SearchInput #1853 just landed on `main` (`8e444ff9`), so the goals index search input can move off the hand-rolled markup and onto the new `DS::SearchInput` primitive. Behaviour unchanged — the `data-goals-filter-target="input"` and `data-action="input->goals-filter#filter"` hooks pass through via the component's `data:` option, and the wrapper's `flex-1 min-w-[200px]` carries through via the component's `class:` arg. Drops the broken `focus:ring-gray-500` lookalike (the hand-rolled class used `focus:ring-alpha-black-100` which is fine, but the new primitive uses the canonical `focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-gray-900` pattern from DS::Button — same focus contract everywhere). Addresses sure-design's DS Drift Patrol finding on #1798. * refactor(goals): migrate archived <details> to DS::Disclosure :inline #1858's :inline variant landed (commit 8de14ed2), so the goals index archived-section toggle can move off the raw <details> and onto the shared primitive. Behaviour and look unchanged — the custom summary content (chevron + uppercase heading + tabular count) passes through the `summary_content` slot; the `:inline` variant adds nothing on top besides the focus-visible ring shared with the other DS::Disclosure variants. Addresses the third sure-design DS Drift finding on #1798 (the other two — DS::SearchInput + ring-gray-500 — already landed earlier). * fix(goals): cover money displays with privacy-sensitive Audit-driven sweep. The class was already on the obvious surfaces (KPI strip, ring center, card balance, funding-accounts breakdown); these were the secondary surfaces missed in the initial PR — money interpolated into descriptive prose, account-picker balances, live previews, and the projection chart tooltip. - card_component: target divisor next to the masked balance, pace line, and behind-status footer (`footer_has_money?` helper keeps non-money branches unmasked so paused / archived / "Goal reached" copy stays readable in privacy mode). - show: header_summary (target + date subtitle), to_go remaining, inactive recap body, celebration body, catch_up body. - _status_callout: conditional on `goal.status == :behind` — only that branch carries an amount; on_track / no_target_date have date or static copy. - _form_edit + _form_stepper: account balance shown in the linked- account picker rows. - _form_stepper review section: reviewSummary + reviewSuggested ps (Stimulus injects target / suggested $X/mo into both). - _pending_pledge_banner: banner title span (amount + account + days). - goal_pledges/new: live preview p (Stimulus injects "Reaches X%, $A of $B" / "Hits your $B target"). - goal_projection_chart_controller: tooltip was inline-styled with hard-coded gray-900 + white (DS drift) and had no privacy class. Replaced cssText with className using bg-container + text-primary + border-secondary + rounded-lg + privacy-sensitive — mirrors the pattern in time_series_chart_controller and the post-#1996 sankey fix. Tooltip now respects theme and privacy mode. * fix(ds): DS::Disclosure summary_class override; migrate color picker Resolves sure-design DS drift patrol findings (raw <details> on goals/_color_picker and categories/_form). The color-icon-picker's <summary> is a 24/28px pencil button absolutely positioned next to the avatar — none of DS::Disclosure's existing variants (default / card / card_inset / inline) match that trigger shape, so the bot's suggested swap would regress the visual. - DS::Disclosure: add optional `summary_class:` kwarg. When set, the caller's class string replaces the variant's hard-coded summary chrome; otherwise the existing variant logic is preserved (verified against the 8 existing callsites — none pass summary_class, all fall through to current behavior). - goals/_color_picker + categories/_form: swap raw <details> for DS::Disclosure with summary_class carrying the pencil-button positioning. Stimulus data attributes (`color-icon-picker-target` and the outside-click handler) forwarded via **opts to tag.details so the controller still finds its target. The DS::Disclosure-rendered popover content now sits inside the component's `<div class="mt-2">` wrapper, but the popups themselves are `position: absolute` / `position: fixed`, so the wrapper is out-of-flow neutral. * fix(goals): drop new-goal stepper, unify create + edit form The 2-step stepper on the create modal carried a review step whose only real signal was a derived "Save $X/mo to hit it on time" hint. Name, amount, and date are all visible in step 1, so the review step was re-displaying form values the user just typed. Collapses both flows into a single panel: - `_form_stepper.html.erb` + `_form_edit.html.erb` → single `_form.html.erb` driven by `goal.persisted?` for URL / method / submit label. - `goal_stepper_controller.js` → `goal_form_controller.js`. Drops the step1Panel / step2Panel / step1Indicator / step2Indicator / step1Circle / step2Circle / stepperLine / reviewName / reviewSummary / reviewSuggested / footerLeftButton / footerRightButton / submitButton target plumbing and the next / back / blockEnter / updateStepperState / updateFooter / updateReview methods. Keeps name-validation, amount-validation, accounts-required validation, avatar-preview-from- name, and the suggested-pace computation — that one now writes into an inline `<p data-goal-form-target="suggested">` below the target_date field instead of the review card. - `new.html.erb`: drops the `Step 1 of 2 · Goal details` subtitle target. New `goals.new.subtitle` replaces the two step subtitles. - `edit.html.erb`: renders the same `form` partial. - `_color_picker.html.erb`: `data-goal-stepper-target="avatarPreview"` → `data-goal-form-target="avatarPreview"` (same Stimulus target, renamed for the new controller scope). - `funding_accounts_breakdown_component.rb`: i18n key path moves to `goals.form.subtypes.*` matching the locale restructure. - `en.yml`: `goals.form_stepper.step1.fields.*` → `goals.form.fields.*`. `step2.*` and the `back` / `continue` / `cancel` keys drop. New `goals.form.create` ("Create goal") + `goals.form.save` ("Save changes") drive the submit-button label. UX delta: the user no longer sees a "Step 1 of 2 / Step 2 of 2" beat. The form is short enough that everything fits in one panel; the only value-add from the old step 2 — the suggested-pace hint — now updates live inline as the amount / date / account-count changes. All 20 `test/controllers/goals_controller_test.rb` tests still pass. `bundle exec erb_lint` clean on the touched templates. * fix(ci): extract github.event refs into job env in preview-deploy Pulls `github.event.pull_request.number` and `github.event.pull_request.head.sha` out of every shell `run:` block and `actions/github-script` body into job-level env vars. The PR number is nominally an integer (no immediate injection risk), but the *pattern* of inlining a `github.event.*` expression into a privileged workflow's shell scripts is what the SAST finding wants to eliminate: - The workflow holds `CLOUDFLARE_API_TOKEN` and `CLOUDFLARE_ACCOUNT_ID`. - A future copy/paste of one of these step bodies onto a user- controlled string (branch name, PR title, commit message) would silently become an arbitrary command-injection path. Touches: - Job-level `env: { PR_NUMBER, HEAD_SHA }` so every step inherits. - "Configure preview files": `sed` substitution now reads `${PR_NUMBER}` from the shell env (the literal-placeholder side stays escaped as `\${PR_NUMBER}`). - "Delete existing preview container app" + "Delete existing preview Worker": shell var assignments use `${PR_NUMBER}`. - "Create GitHub Deployment" github-script: `process.env.PR_NUMBER` inside the JS template literal instead of GHA template interpolation. - "Deploy to Cloudflare Containers": `${PR_NUMBER}` in the shell; `CLOUDFLARE_WORKERS_SUBDOMAIN` also lifted into the step's `env:` block so the URL template uses `${CLOUDFLARE_WORKERS_SUBDOMAIN}`, not a templated secret expression in the shell command. - "Comment on PR" github-script: replaces the four `${{ github.event.pull_request.* }}` interpolations with `process.env.PR_NUMBER` / `process.env.HEAD_SHA` and lifts the preview URL via step env. `issue_number` is `Number(...)`-coerced since env values are strings. - "Store cleanup metadata" artifact name: uses `${{ env.PR_NUMBER }}` (template context, not shell). YAML still validates (`ruby -ryaml -e 'YAML.load_file(...)'`). The only remaining `github.event.pull_request.*` references are the job- gate `if:` condition and the env-extraction definitions themselves — both safe contexts. * fix(goals): Number.NaN over global NaN in goal_form_controller Biome's lint/style/useNumberNamespace rule. Same semantics — Number.NaN is the explicit namespace form post-ES2015. CI lint_js was failing on this line. * fix(ci): drop leftover preview pre-delete steps after isolation merge The preview isolation refactor (#2025) removed the "Delete existing preview container/Worker" steps. Merging main into this branch auto-kept this branch's copies, leaving two steps that run `npx wrangler` from `workers/preview` with Cloudflare secrets in scope. That trips bin/preview_deploy_security_check.rb (PR-controlled working-directory, npx wrangler, secrets outside the deploy step), failing scan_ruby and, in turn, the preview deploy gate. Removing them realigns the workflow with main's isolated model. * Update preview-deploy.yml Signed-off-by: Guillem Arias Fauste <accounts@gariasf.com> * refactor(goals): squash migrations into single create_goals Collapse the 9 churned goals migrations (create savings_* tables, rename to goals, add icon, add pledges + enums, drop contributions, restrict the goal_accounts->accounts FK) into one create_goals migration that builds the final schema directly. Schema is unchanged. The concurrent transactions pledge-id index stays a separate migration because CREATE INDEX CONCURRENTLY cannot run inside a transactional migration. * fix(goals): use functional ring token in color picker The custom-color swatch used a raw ring-blue-500 palette utility while the preset swatches use ring-alpha-black-500. Switch to the functional token for design-system consistency. --------- Signed-off-by: Guillem Arias Fauste <accounts@gariasf.com> Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Sure Admin (bot) <sure-admin@splashblot.com>	2026-06-02 14:00:16 +02:00
ghost	2fb7962d6e	perf(transfers): narrow auto-transfer candidate search (#2080) ... * perf(transfers): narrow auto-transfer candidate search * perf(transfers): preload auto-match transactions * perf(transfers): tighten auto-match candidate handling * fix(transfers): reject negative match tolerance * test(statements): stabilize coverage status dates --------- Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>	2026-06-01 22:02:01 +02:00
Alessio Cappa	5d7b6a9052	feat: Move "Merge" action for merchants/categories in sub menu (#2114) ... * feat: move merge merchants and merge categories in sub menù * Update app/views/family_merchants/index.html.erb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Alessio Cappa <104093777+alessiocappa@users.noreply.github.com> * fix: typo in view --------- Signed-off-by: Alessio Cappa <104093777+alessiocappa@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>	2026-06-01 22:01:39 +02:00
Guillem Arias Fauste	991cb959c1	feat(ai): Anthropic batch ops + LLM cost ledger (2/5) (#1984) ... * feat(ai): add Anthropic provider with chat parity (1/5) Introduces Provider::Anthropic alongside Provider::Openai, implementing the LlmConcept chat_response contract over the official anthropic Ruby SDK. Batch ops, PDF, and RAG land in follow-up PRs. - Provider::Anthropic uses Messages API for sync and streaming responses - ChatConfig builds requests with ephemeral prompt-cache markers on the system prompt and the last tool definition - MessageFormatter reconstructs multi-turn history (text + tool_use + tool_result blocks) from raw Message records, including the paired user-role tool_result turn Anthropic requires after every tool_use - ChatParser maps Anthropic Message into the shared ChatResponse Data - Registry, Setting, User, Chat default model wired for ANTHROPIC_* envs and Setting.anthropic_*; LLM_PROVIDER selects between providers - Responder forwards raw conversation_history (Array<Message>) so providers without hosted conversation state can rebuild context - OpenAI provider accepts and ignores the new kwarg (no behavior change) Tests cover provider init, model gating, MessageFormatter for all turn shapes, ChatConfig request building (max_tokens, system cache, tool conversion), ChatParser for text / tool_use / mixed blocks, Registry discovery, and mocked chat_response success / error / function_request paths. Live VCR cassettes recorded in a follow-up with a real key. Stacked PRs: 2/5 batch ops + cost ledger, 3/5 PDF, 4/5 pgvector RAG, 5/5 settings UI + disclosure. * fix(ai): address PR review on Anthropic provider foundation Surface fixes raised by Codex + CodeRabbit on PR 1/5: - Provider::Anthropic#chat_response now accepts (and ignores) a `messages:` kwarg. Assistant::Responder passes both `messages:` (OpenAI-shape) and `conversation_history:` (raw Message records) for cross-provider parity, so the previous signature raised ArgumentError on the first chat turn through the Anthropic provider. - Provider::Anthropic#supports_model? bypasses the `claude` prefix gate when a custom base_url is configured, mirroring the OpenAI provider. Bedrock-shaped IDs like `anthropic.claude-sonnet-4-5-20250929-v1:0` and `claude-opus-4@20250514` are otherwise rejected by Assistant::Provided#get_model_provider and the chat dies. - Setting.anthropic_access_token is now in EncryptedSettingFields::ENCRYPTED_FIELDS so the Anthropic API key is encrypted at rest like every other provider secret. Previously plaintext while siblings (openai_access_token, twelve_data_api_key, external_assistant_token) were ciphertext. - Chat.default_model falls back to whichever provider is actually configured. Previously, with LLM_PROVIDER=anthropic but no Anthropic credentials, the default model resolved to a Claude ID that no registered provider supported, so chats failed even when OpenAI was fully configured. Adds Provider::{Anthropic,Openai}#configured? class methods for the readable callsite. - Provider::Anthropic.effective_model uses `ENV["ANTHROPIC_MODEL"].presence || Setting.anthropic_model` so the Setting lookup is only performed when the env var is absent — the previous `ENV.fetch(KEY, default)` evaluated the default arg eagerly on every call. - Provider::Anthropic::ChatConfig#anthropic_input_schema strips both `:strict` and `"strict"` keys so JSON-decoded schemas with string keys cannot leak the OpenAI-only flag through to Anthropic. Test coverage added: supports_model? bypass on custom endpoints, chat_response messages: kwarg compatibility, default_model fallback in the three credential combinations, configured? against ENV + Setting, strict-flag stripping for both key types, and a `Setting.expects(:anthropic_model).never` assertion proving the ENV-precedence test now exercises the lazy path. All 4365 tests pass (1 pre-existing libvips env error unrelated). * test(chat): make default_model tests resilient to ENV model overrides CodeRabbit flagged on PR review: the new default_model tests asserted against Provider::*::DEFAULT_MODEL, but Chat.default_model actually returns Provider::*.effective_model.presence (which reads OPENAI_MODEL / ANTHROPIC_MODEL from the environment). With either env var set, the tests would fail intermittently even though routing was correct. - New default_model tests now assert against the provider's effective_model directly, so they verify the routing decision (which provider's value wins) without coupling to the constant. - Pre-existing "creates with default model" assertions had the same brittleness; switch them to compare against Chat.default_model so the chosen model is whatever the env / Setting cascade resolves to. Verified by running `ANTHROPIC_MODEL=claude-haiku-4-5 OPENAI_MODEL=gpt-4o bin/rails test test/models/chat_test.rb` — 16 runs, 0 failures (previously 2 pre-existing failures + 0 from the new tests). * fix(ai): address local review on Anthropic foundation - Provider::Anthropic#supports_pdf_processing? bypasses prefix gate for custom endpoints, mirroring supports_model? - Provider::Anthropic#initialize raises Error when custom_endpoint? AND model.blank?, parity with Provider::Openai - stream_chat_response captures partial usage on mid-stream errors and records it via the new on_partial callback so chat_response can skip the duplicate error row in the outer rescue - safe_accumulated_message swallows the secondary failure when the SDK cannot reconstruct a snapshot - langfuse_client memoizes properly (||= instead of =) so repeated calls don't churn Langfuse instances - MessageFormatter sorts tool_calls by created_at then id so the message array is deterministic across replays; skips tool_calls missing both provider_call_id and provider_id rather than sending `id: nil` and getting rejected by Anthropic - Setting.anthropic_access_token default falls back through ENV["ANTHROPIC_API_KEY"].presence (was missing .presence, so an empty-string env value bled through) - User#openai_configured? / #anthropic_configured? delegate to the Provider::* class methods — single source of truth - Assistant::Responder renames the OpenAI-shape history builder conversation_history → openai_messages_payload so the kwarg name matches the local method name (messages: openai_messages_payload, conversation_history: chat_message_records) - Assistant::Builtin stale-history comment updated to reference both builders Adds a streaming chat_response test using ad-hoc subclasses of the SDK event types so the case/when dispatch matches via is_a? without stubbing class-level === behavior. * test(ai): add Anthropic tool_use round-trip + multi-tool turn coverage Addresses @jjmata's "worth confirming" note on PR #1983: tool-use turns from prior assistant messages must round-trip correctly when retrieved from the database. - New `ChatParser → ToolCall::Function → MessageFormatter` test walks the full path: Anthropic response with a tool_use block → ChatFunctionRequest → ToolCall::Function.from_function_request → persisted on the AssistantMessage → MessageFormatter rebuild on the next turn. Asserts the original `tool_use.id` is preserved end-to-end as both `tool_use.id` and the paired `tool_result.tool_use_id`, and that the original `input` hash and serialized result content survive. - New multi-tool assistant turn test confirms two tool_use blocks on a single assistant message render as two tool_use blocks followed by two paired tool_result blocks in a single user-role follow-up, matching Anthropic's required alternation. Both tests exercise the existing PR1 code without behavior changes. * test(ai): require "ostruct" explicitly in Anthropic provider tests OpenStruct is moving out of Ruby's default load path (warning in 3.4+, removed in 3.5+). Tests work today because ActiveSupport transitively loads it, but that's incidental. Match the existing convention in test/controllers/settings/hostings_controller_test.rb which explicitly requires ostruct for the same reason. * fix(ai): sanitize Langfuse warn logs, normalize tool_use.input, dedup history fetch Addresses three open CodeRabbit findings on PR #1983. - Provider::Anthropic Langfuse rescue branches no longer include `e.full_message` in `Rails.logger.warn`. `full_message` bundles the backtrace + cause chain and on some SDK error types includes the serialized request/response payload (prompt, model output). Logs now report `#{e.class}: #{e.message}` only. Three sites: create_langfuse_trace, log_langfuse_generation, upsert_langfuse_trace. Note: Provider::Openai has the same pattern (copy-pasted source) — harmonization deferred to a follow-up cleanup PR; this commit fixes only the Anthropic provider to keep PR scope tight. - MessageFormatter#parse_arguments now coerces any non-Hash parsed result to `{}`. Anthropic's Messages API requires `tool_use.input` to be a JSON object (map); a stored ToolCall::Function record whose arguments parse to a scalar, bool, or array (corrupt row, legacy data, cross-provider bleed) would otherwise produce a payload the API rejects. Normal flow stores Hash arguments end-to-end so the fix is defensive — adds 2 tests covering scalar/array JSON strings and non-String non-Hash inputs. - Assistant::Responder dedups the chat-history fetch. The previous layout fired two near-identical `chat.messages.where(...).includes( :tool_calls).ordered` queries per LLM turn (one for the OpenAI-shape payload, one for the raw-records kwarg). A new memoized `complete_chat_messages` fetches once; `chat_message_records` filters out the current message via `Array#reject`, `openai_messages_payload` iterates the cached array unchanged. One SQL query per turn instead of two. Memoization scope = single Responder instance (per LLM call), so cache invalidation is not a concern. All 4370 tests pass (1 pre-existing libvips env error unrelated). Rubocop + brakeman clean. * fix(ci): replace sk-ant- prefixed test placeholders Pipelock secret scanner pattern-matches `sk-ant-*` as a real Anthropic API key and fails the PR security-scan check. Test stubs and ClimateControl env values used `sk-ant-test`, `sk-ant-from-setting`, `sk-ant-x`, `sk-ant-y` as obvious placeholders, but the scanner does not care about value entropy. Switched to `fake-anthropic-key-*` / `fake-token-*` strings so the scanner stops flagging them. No production code touched, no behavior change — Provider::Anthropic still accepts any non-blank token. * feat(ai): add Anthropic batch ops + LLM cost ledger (2/5) Implements auto_categorize, auto_detect_merchants, and enhance_provider_merchants on Provider::Anthropic via forced tool calls, plus the cost-ledger plumbing they need. - Provider::Anthropic::AutoCategorizer, AutoMerchantDetector, ProviderMerchantEnhancer each define a single output tool whose input_schema mirrors the desired output, then force the model to call it via tool_choice: { type: "tool", name: ..., disable_parallel_tool_use: true }. Anthropic guarantees the tool_use.input matches the schema, so there is no JSON parsing fragility, no <think> tag stripping, and no json_object/json_schema fallback ladders. - Concerns::UsageRecorder mirrors the OpenAI sibling but persists cache_creation_input_tokens / cache_read_input_tokens to dedicated columns instead of metadata. - Migration adds cache_creation_tokens, cache_read_tokens (nullable integers) to llm_usages. OpenAI rows leave them null. - LlmUsage::PRICING gains Claude 4.x rows (opus-4-7 $15/$75, sonnet-4-6 $3/$15, haiku-4-5 $1/$5 per MTok). infer_provider returns "anthropic" for claude-* via the existing exact/prefix lookup. - Provider::Anthropic#chat_response now persists cache columns directly rather than stashing them in metadata. - 25-transaction batch cap mirrors the OpenAI provider so the cost ledger sees the same shape regardless of which provider ran a batch. Tests cover the forced-tool-call path, null/None normalization, case-insensitive merchant matching, the missing-tool_use error path, and Anthropic-specific pricing + provider inference on LlmUsage. Stacked on #1983 (PR 1/5). 3/5 PDF + vision next. * fix(ai): attribute Bedrock model IDs to anthropic + clean nil enum - LlmUsage.infer_provider now returns "anthropic" for Bedrock / Vertex shaped IDs (anthropic.* and anthropic/*), so cost-ledger filtering by provider stays correct even when no per-MTok rate is stored. Previously these IDs fell through to the "openai" default. - AutoCategorizer drops the redundant nil sentinel from the category_name enum — the union type [string, null] already permits null, and some JSON Schema validators reject nil literals inside enum arrays. * test(ai): require "ostruct" in Anthropic batch op tests Same rationale as the PR1 ostruct fix — explicit require so the tests don't depend on ActiveSupport's transitive load when Ruby 3.5+ removes OpenStruct from the default load path. * fix(llm-usage): include Anthropic cache tokens in estimated_cost calculate_cost only priced prompt + completion tokens, so estimated_cost under-reported every cached call — the cache_creation/cache_read columns this PR added were tracked but never billed. Verified against the Anthropic dashboard: a cached chat turn billed $0.05 but the ledger recorded $0.038; the gap was exactly the unpriced cache tokens. Price them relative to the input rate (Anthropic: cache write 1.25x, read 0.1x) and thread the cache counts from both recorders (chat + batch). OpenAI rows leave the columns null (treated as 0), so they're unaffected. Ledger now reproduces the dashboard ($0.054 for the test turn). * chore(ai): guard chat usage double-record; flag deferred Anthropic batch wiring - Hardening: guard the success-path record_llm_usage with `unless partial_usage_recorded` so a future change that emits partial usage on a normal stream can't silently double-bill (the symptom investigated in the #1984 review). No behavior change today — on_partial only fires from the mid-stream-error rescue, which re-raises past this line. - Notice: the family auto-categorize / merchant-detect / merchant-enhance flows still hardcode get_provider(:openai). Provider::Anthropic now implements those batch ops but they aren't wired into the family flows yet — documented with TODOs at each site for the follow-up. * chore(ai): point family-flow TODOs at tracking issue #2113 * fix(ai): address review findings on cost ledger + categorizer schema Three AI-review findings on #1984: - category_name enum omitted null (codex + coderabbit): the prompt + type allow Claude to abstain on uncertain transactions, but JSON Schema `enum` restricted the value to category names, so null was invalid — forcing miscategorization. Append nil to the enum (the consumer already normalizes null -> uncategorized). - Cache pricing applied to all providers (coderabbit): the 1.25x/0.1x cache multipliers are Anthropic-specific. Gate them on provider == "anthropic" so a non-Anthropic caller passing cache counts isn't billed with the wrong rates. - Negative cache-token counts (coderabbit): add DB check constraints (cache_*_tokens IS NULL OR >= 0), per the repo's DB-level-validation convention. Tests: enum includes nil; non-Anthropic cache tokens aren't priced.	2026-06-01 22:00:48 +02:00
ghost	01d7361477	fix(categories): avoid index N+1 queries (#2089) ... * fix(categories): avoid index N+1 queries Precompute category hierarchy groups and transaction membership for the categories settings index so the view no longer checks subcategories and transaction existence per rendered row. Add a regression test for the query shape and stabilize a date-sensitive account statement coverage test that blocked the full suite on month-end-adjacent dates. * fix(categories): preserve partial transaction fallback Keep category list rendering compatible with callers that omit precomputed transaction membership data. Passing nil now lets the category row partial use its existing transaction existence fallback instead of forcing direct delete actions. Add a view regression test for the fallback path. * test(categories): cover parent deletion child transactions * Bad merge confilict fix --------- Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Juan José Mata <jjmata@jjmata.com>	2026-06-01 21:59:46 +02:00
Ang Wei Feng (Ted)	5e558fa3ab	feat(transactions): add inline tag creation and search in txn form (#1719) ... * feat(transactions): add inline tag creation and search in transaction forms * fix(transactions): add tag-only update endpoint for edit drawer * feat(transactions): implement TagSelectComponent for improved tag selection and management * feat(tag-select): refactor tag selection component for improved functionality and accessibility * feat(tag-select): implement inline tag rendering and error handling in tag selection component * refactor(tag-select): remove unused list target from tag select controller * fix: return forbidden JSON for denied tag updates * fix: lock transaction tags when clearing them * refactor: move tag select into DS namespace * refactor: add multiselect trigger form field style * fix: auto-position tag select dropdowns * feat: add keyboard navigation to tag select * feat: add create tag and search placeholder to transaction forms in multiple languages * style: tighten tag select option spacing * fix: align tag select spacing and focus behavior * refactor: render tag badges with DS pill --------- Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>	2026-06-01 21:46:32 +02:00
Alessio Cappa	f4eb58d5d6	fix: do not show pagination if no merchants are available (#2115)	2026-06-01 21:39:11 +02:00
Sure Admin (bot)	e62e0d6b26	fix(tests): avoid coverage rollover fixture collision (#2102)	2026-06-01 14:58:18 +02:00
ghost	1af880aa2a	ci(preview): stabilize image push and readiness diagnostics (#2084) ... * ci(preview): rewrite image config before registry push Point the trusted preview deploy config at the loaded CI image before Wrangler validates the worker config for the Cloudflare registry push. This keeps the existing trusted deploy boundary intact while fixing the post-2062 image-push ordering regression. * ci(preview): require trusted readiness diagnostics * ci(preview): use nonce for diagnostics events * ci(preview): retain diagnostics timing anchors	2026-06-01 10:51:29 +02:00
web-dev0521	3311759ec2	fix(transactions): include enable_banking in pending/confirmed status filter (#1885) ... * fix(transactions): include enable_banking in pending/confirmed status filter (#1668) The transaction status filter hardcoded only simplefin/plaid/lunchflow in its pending/confirmed SQL, even though Transaction::PENDING_PROVIDERS also includes enable_banking. As a result, Enable Banking pending transactions returned 0 results under the "Pending" filter and leaked into "Confirmed". Source the provider list from the existing constant-driven helpers instead: - Transaction::Search delegates to the `pending` / `excluding_pending` model scopes. - EntrySearch interpolates Transaction::PENDING_CHECK_SQL into its EXISTS subqueries. This keeps every status-filter path in sync with PENDING_PROVIDERS so adding a future provider can't reintroduce the bug. Fixes #1668 * test(entry): cover EntrySearch status filter across all pending providers Adds a regression test for the EntrySearch#apply_status_filter path, asserting pending transactions for every PENDING_PROVIDERS entry are matched by the "pending" filter and excluded from "confirmed". Mirrors the existing Transaction::Search coverage so both filter paths are exercised.	2026-05-31 22:17:56 +02:00
joaocbatista	b101708409	Fix Start month on Last 6 Months report off by 1 (#2070) ... * Bump version to next iteration after v0.7.1-rc.1.1 release * fix: correct last_6_months period to show exactly 6 months Default start date was snapping to beginning_of_month 6 months ago, producing a 7-month window (e.g. Nov 1 – May 31). Fix computes the start as (end_of_month + 1 day - 6 months).beginning_of_month so the default window is consistent with the navigation arrows and Today button. * improved test --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	2026-05-31 16:35:38 +02:00
galuis116	61a235f765	fix(family): include HSA depository accounts in tax-advantaged exclusion (#2004) ... * fix(family): include HSA depository accounts in tax-advantaged exclusion `Family#tax_advantaged_account_ids` is the ID set the budget engine uses to exclude tax-advantaged account activity from income / expense / cashflow totals. PR #724 originated this method and explicitly listed HSA in scope ("401k, IRA, HSA, Roth IRA, etc."), but the implementation only joined `investments` and `cryptos`. `Depository::SUBTYPES["hsa"]` already exists and Plaid routes `depository.hsa` accounts to `Depository` (not `Investment`) via `PlaidAccount::TypeMappable`, so HSA cash accounts were silently absent from the filter and HSA contributions/withdrawals showed up in household expense totals. - Add `Depository::TAX_ADVANTAGED_SUBTYPES = %w[hsa]` + a `tax_treatment` instance method (mirrors `Investment#tax_treatment`). `TaxTreatable#tax_advantaged?` picks it up via the existing `respond_to?` check, so `Account#tax_advantaged?` now flips to true for HSA depositories without touching the concern. - Extract `Family#tax_advantaged_depository_account_ids` (private) that joins `depositories` and filters by `Depository::TAX_ADVANTAGED_SUBTYPES`, mirroring the existing `investment_ids` / `crypto_ids` extraction style. Append it to the union in `tax_advantaged_account_ids`. Behavior change is scoped: HSA depositories now exit the budget engine via the same path as 401k / IRA / Roth IRA. Non-HSA depositories continue to report `tax_treatment: :taxable` (was `nil`), so `Account#taxable?` returns true for them via the existing `== :taxable` clause — no expense-total change for Checking / Savings / CD / Money Market. Tests: - `test/models/account_test.rb` — rewrite "tax_treatment returns nil for non-investment accounts" (was implicitly testing the bug) into two tests: one asserting `:taxable` for non-HSA depositories and a new sibling asserting `nil` for accountables that genuinely lack `tax_treatment` (CreditCard). Add an HSA-depository test asserting `tax_advantaged?`. - `test/models/income_statement_test.rb` — new test asserting an HSA depository is included in `tax_advantaged_account_ids` and a `savings` depository is not. No schema migration, no controller change, no provider integration change. * [200~fix(family): return nil for non-HSA depository tax_treatment	2026-05-31 16:24:01 +02:00
Guillem Arias Fauste	8251b7e4d6	feat(ai): add Anthropic provider with chat parity (1/5) (#1983) ... * feat(ai): add Anthropic provider with chat parity (1/5) Introduces Provider::Anthropic alongside Provider::Openai, implementing the LlmConcept chat_response contract over the official anthropic Ruby SDK. Batch ops, PDF, and RAG land in follow-up PRs. - Provider::Anthropic uses Messages API for sync and streaming responses - ChatConfig builds requests with ephemeral prompt-cache markers on the system prompt and the last tool definition - MessageFormatter reconstructs multi-turn history (text + tool_use + tool_result blocks) from raw Message records, including the paired user-role tool_result turn Anthropic requires after every tool_use - ChatParser maps Anthropic Message into the shared ChatResponse Data - Registry, Setting, User, Chat default model wired for ANTHROPIC_* envs and Setting.anthropic_*; LLM_PROVIDER selects between providers - Responder forwards raw conversation_history (Array<Message>) so providers without hosted conversation state can rebuild context - OpenAI provider accepts and ignores the new kwarg (no behavior change) Tests cover provider init, model gating, MessageFormatter for all turn shapes, ChatConfig request building (max_tokens, system cache, tool conversion), ChatParser for text / tool_use / mixed blocks, Registry discovery, and mocked chat_response success / error / function_request paths. Live VCR cassettes recorded in a follow-up with a real key. Stacked PRs: 2/5 batch ops + cost ledger, 3/5 PDF, 4/5 pgvector RAG, 5/5 settings UI + disclosure. * fix(ai): address PR review on Anthropic provider foundation Surface fixes raised by Codex + CodeRabbit on PR 1/5: - Provider::Anthropic#chat_response now accepts (and ignores) a `messages:` kwarg. Assistant::Responder passes both `messages:` (OpenAI-shape) and `conversation_history:` (raw Message records) for cross-provider parity, so the previous signature raised ArgumentError on the first chat turn through the Anthropic provider. - Provider::Anthropic#supports_model? bypasses the `claude` prefix gate when a custom base_url is configured, mirroring the OpenAI provider. Bedrock-shaped IDs like `anthropic.claude-sonnet-4-5-20250929-v1:0` and `claude-opus-4@20250514` are otherwise rejected by Assistant::Provided#get_model_provider and the chat dies. - Setting.anthropic_access_token is now in EncryptedSettingFields::ENCRYPTED_FIELDS so the Anthropic API key is encrypted at rest like every other provider secret. Previously plaintext while siblings (openai_access_token, twelve_data_api_key, external_assistant_token) were ciphertext. - Chat.default_model falls back to whichever provider is actually configured. Previously, with LLM_PROVIDER=anthropic but no Anthropic credentials, the default model resolved to a Claude ID that no registered provider supported, so chats failed even when OpenAI was fully configured. Adds Provider::{Anthropic,Openai}#configured? class methods for the readable callsite. - Provider::Anthropic.effective_model uses `ENV["ANTHROPIC_MODEL"].presence || Setting.anthropic_model` so the Setting lookup is only performed when the env var is absent — the previous `ENV.fetch(KEY, default)` evaluated the default arg eagerly on every call. - Provider::Anthropic::ChatConfig#anthropic_input_schema strips both `:strict` and `"strict"` keys so JSON-decoded schemas with string keys cannot leak the OpenAI-only flag through to Anthropic. Test coverage added: supports_model? bypass on custom endpoints, chat_response messages: kwarg compatibility, default_model fallback in the three credential combinations, configured? against ENV + Setting, strict-flag stripping for both key types, and a `Setting.expects(:anthropic_model).never` assertion proving the ENV-precedence test now exercises the lazy path. All 4365 tests pass (1 pre-existing libvips env error unrelated). * test(chat): make default_model tests resilient to ENV model overrides CodeRabbit flagged on PR review: the new default_model tests asserted against Provider::*::DEFAULT_MODEL, but Chat.default_model actually returns Provider::*.effective_model.presence (which reads OPENAI_MODEL / ANTHROPIC_MODEL from the environment). With either env var set, the tests would fail intermittently even though routing was correct. - New default_model tests now assert against the provider's effective_model directly, so they verify the routing decision (which provider's value wins) without coupling to the constant. - Pre-existing "creates with default model" assertions had the same brittleness; switch them to compare against Chat.default_model so the chosen model is whatever the env / Setting cascade resolves to. Verified by running `ANTHROPIC_MODEL=claude-haiku-4-5 OPENAI_MODEL=gpt-4o bin/rails test test/models/chat_test.rb` — 16 runs, 0 failures (previously 2 pre-existing failures + 0 from the new tests). * fix(ai): address local review on Anthropic foundation - Provider::Anthropic#supports_pdf_processing? bypasses prefix gate for custom endpoints, mirroring supports_model? - Provider::Anthropic#initialize raises Error when custom_endpoint? AND model.blank?, parity with Provider::Openai - stream_chat_response captures partial usage on mid-stream errors and records it via the new on_partial callback so chat_response can skip the duplicate error row in the outer rescue - safe_accumulated_message swallows the secondary failure when the SDK cannot reconstruct a snapshot - langfuse_client memoizes properly (||= instead of =) so repeated calls don't churn Langfuse instances - MessageFormatter sorts tool_calls by created_at then id so the message array is deterministic across replays; skips tool_calls missing both provider_call_id and provider_id rather than sending `id: nil` and getting rejected by Anthropic - Setting.anthropic_access_token default falls back through ENV["ANTHROPIC_API_KEY"].presence (was missing .presence, so an empty-string env value bled through) - User#openai_configured? / #anthropic_configured? delegate to the Provider::* class methods — single source of truth - Assistant::Responder renames the OpenAI-shape history builder conversation_history → openai_messages_payload so the kwarg name matches the local method name (messages: openai_messages_payload, conversation_history: chat_message_records) - Assistant::Builtin stale-history comment updated to reference both builders Adds a streaming chat_response test using ad-hoc subclasses of the SDK event types so the case/when dispatch matches via is_a? without stubbing class-level === behavior. * test(ai): add Anthropic tool_use round-trip + multi-tool turn coverage Addresses @jjmata's "worth confirming" note on PR #1983: tool-use turns from prior assistant messages must round-trip correctly when retrieved from the database. - New `ChatParser → ToolCall::Function → MessageFormatter` test walks the full path: Anthropic response with a tool_use block → ChatFunctionRequest → ToolCall::Function.from_function_request → persisted on the AssistantMessage → MessageFormatter rebuild on the next turn. Asserts the original `tool_use.id` is preserved end-to-end as both `tool_use.id` and the paired `tool_result.tool_use_id`, and that the original `input` hash and serialized result content survive. - New multi-tool assistant turn test confirms two tool_use blocks on a single assistant message render as two tool_use blocks followed by two paired tool_result blocks in a single user-role follow-up, matching Anthropic's required alternation. Both tests exercise the existing PR1 code without behavior changes. * test(ai): require "ostruct" explicitly in Anthropic provider tests OpenStruct is moving out of Ruby's default load path (warning in 3.4+, removed in 3.5+). Tests work today because ActiveSupport transitively loads it, but that's incidental. Match the existing convention in test/controllers/settings/hostings_controller_test.rb which explicitly requires ostruct for the same reason. * fix(ai): sanitize Langfuse warn logs, normalize tool_use.input, dedup history fetch Addresses three open CodeRabbit findings on PR #1983. - Provider::Anthropic Langfuse rescue branches no longer include `e.full_message` in `Rails.logger.warn`. `full_message` bundles the backtrace + cause chain and on some SDK error types includes the serialized request/response payload (prompt, model output). Logs now report `#{e.class}: #{e.message}` only. Three sites: create_langfuse_trace, log_langfuse_generation, upsert_langfuse_trace. Note: Provider::Openai has the same pattern (copy-pasted source) — harmonization deferred to a follow-up cleanup PR; this commit fixes only the Anthropic provider to keep PR scope tight. - MessageFormatter#parse_arguments now coerces any non-Hash parsed result to `{}`. Anthropic's Messages API requires `tool_use.input` to be a JSON object (map); a stored ToolCall::Function record whose arguments parse to a scalar, bool, or array (corrupt row, legacy data, cross-provider bleed) would otherwise produce a payload the API rejects. Normal flow stores Hash arguments end-to-end so the fix is defensive — adds 2 tests covering scalar/array JSON strings and non-String non-Hash inputs. - Assistant::Responder dedups the chat-history fetch. The previous layout fired two near-identical `chat.messages.where(...).includes( :tool_calls).ordered` queries per LLM turn (one for the OpenAI-shape payload, one for the raw-records kwarg). A new memoized `complete_chat_messages` fetches once; `chat_message_records` filters out the current message via `Array#reject`, `openai_messages_payload` iterates the cached array unchanged. One SQL query per turn instead of two. Memoization scope = single Responder instance (per LLM call), so cache invalidation is not a concern. All 4370 tests pass (1 pre-existing libvips env error unrelated). Rubocop + brakeman clean. * fix(ci): replace sk-ant- prefixed test placeholders Pipelock secret scanner pattern-matches `sk-ant-*` as a real Anthropic API key and fails the PR security-scan check. Test stubs and ClimateControl env values used `sk-ant-test`, `sk-ant-from-setting`, `sk-ant-x`, `sk-ant-y` as obvious placeholders, but the scanner does not care about value entropy. Switched to `fake-anthropic-key-*` / `fake-token-*` strings so the scanner stops flagging them. No production code touched, no behavior change — Provider::Anthropic still accepts any non-blank token.	2026-05-31 16:11:28 +02:00
Abhinav Dhiman	cc070853b7	fix: Replace platform-wide broadcast_refresh with sync toast (#1964) ... * fix: Replace platform-wide broadcast_refresh with sync toast Instead of calling family.broadcast_refresh on every sync completion (which reloads the page for all connected family members), broadcast a lightweight static toast to the existing notification-tray. A new sync-toast Stimulus controller handles two cases: - User is idle (no focused form): auto-reloads after 500ms - User is mid-form: toast stays visible with a manual Refresh button This prevents in-progress form state from being wiped when a background sync fires (e.g. adding a transaction, filling an import form). The toast partial contains no user-scoped data, so the Current.user nil constraint in background jobs is no longer a concern. * fix(a11y): add explicit button types and aria-label to sync toast controls * fix(sync-toast): improve interaction detection and replace broadcast strategy - Increase auto-refresh delay from 500ms to 2000ms - Expand interaction detection to include contentEditable, dialogs, and role="dialog" elements - Switch from broadcast_append_to to broadcast_replace_to with dedicated #sync-toast target - Add explicit id="sync-toast" to partial for targeted replacement - Move sync_toast i18n keys from defaults/en.yml to views/shared/en.yml * fix(sync-toast): replace hardcoded white icon color with inverse token	2026-05-31 16:05:54 +02:00
Juan José Mata	9ccc2719c1	Forcing myself to bump by hand	2026-05-31 15:48:51 +02:00
Juan José Mata	bfe91cd881	New alpha train! v0.7.2-alpha.1	2026-05-31 14:13:41 +02:00
ghost	5f8452d63b	ci(preview): stabilize Cloudflare preview deployments (#2062) ... * ci(preview): stabilize Cloudflare preview deployments * ci(preview): bound diagnostics and cover artifact fallback * ci(preview): isolate artifact deploy permissions * ci(preview): tidy deployment comment rendering * ci(preview): harden preview manifest generation * ci(preview): fail on preview diagnostics failure	2026-05-31 13:30:03 +02:00
Guillem Arias Fauste	ca8cbaa201	fix(dashboard): make Outflows widget responsive to its container, not the viewport (#2059) ... * fix(dashboard): make Outflows widget responsive to its container, not the viewport The Outflows widget switched to its two-column (donut + category list) layout on the `lg:` viewport breakpoint, but the card's real width is set by the account sidebar and AI panel — and the two-column dashboard setting. With those open the viewport stays >= lg while the card is only ~500px, so the desktop layout was forced into a narrow card: the donut clipped and the category list overflowed with names truncated to icons. Switch the widget to container queries (`@container` + `@2xl:`) so it responds to its own width: side-by-side when the card is wide, stacked (the existing mobile layout) when narrow — regardless of sidebars, viewport, or the dashboard column setting. Mobile/PWA is unchanged (already stacked) and it degrades to always-stacked on browsers without container-query support. Closes #2058 * fix(dashboard): keep w-16 base on Outflows categories header label Restore the w-16 base width on the categories-header label column so all eight responsive classes are uniform lg:->@2xl: swaps. The label now matches its value/weight siblings and the narrow-width layout is identical to main's current mobile rendering (zero regression). Addresses review feedback on the asymmetric width drop.	2026-05-31 09:14:46 +02:00
ghost	7580325418	fix(reset): scope family financial data resets (#1835) ... Centralize family financial reset cleanup behind an explicitly scoped service, update reset status docs, and add two-family regression coverage for destructive reset behavior.	2026-05-31 00:21:34 +02:00
William Wei Ming	bc7e16ff16	Perf/dashboard endpoint optimization (#1897) ... * optimize net_category_totals() by using memoized cache * fix issue - net_category_totals cache is never populated - suggested by coderabbitAI * fix 422 error for service-worker * remove warning of [assigned but unused variables] - income_statement.rb * remove warnings of [assigned but unused] from Prism - income_statement_test.rb * add some measurements to improve docstring coverage, follow CodeRabbit recommendation * attach Skylight monitoring for dev env as well - use my own Skylight auth token * integrate Skylight with my own account auth token for local benchmark * fix PR review suggestion - Move fallback release-note copy to i18n keys * follow PR review - Fix changelog GitHub fetch timeout bounding * FIX - Variable shadowing; Prefer stubbing the specific instance over any_instance.expects * fix CodeRabbit feedback - Reusing the same stub for both classifications hides a contract mismatch * fix CodeRabbit FEEDBACK - Reconsider enabling Skylight by default in development * fix CodeRabbitAI FEEDBACK - reconsider unconditionally enabling Skylight in development * fix Security scan FEEDBACK before PR merge * fix jjmata feedback	2026-05-31 00:09:38 +02:00
William Wei Ming	f653fec96f	Add HTTP timeout config to Provider::Github Octokit client (#2061)	2026-05-30 23:58:32 +02:00
Jeff	956c27df6b	chore(ci): pin GitHub Actions to commit SHAs (#1811) (#1870) ... * chore(ci): pin GitHub Actions to commit SHAs (#1811) Follow-up to #1810. The Node-24 upgrade left every workflow on mutable tag refs (`actions/checkout@v5`, `actions/download-artifact@v7`, etc.) which superagent-security[bot] flagged on the ci.yml + publish.yml reviews. Pin all 18 external actions to the commit SHA they currently resolve to and add a trailing `# vMAJOR.MINOR.PATCH` comment so reviewers can see the version. Local reusable-workflow refs (`uses: ./.github/...`) are left alone — pinning those would defeat the point. Closes #1811 * chore(ci): address review — persist-credentials + setup-node consistency (#1811) Two pieces of follow-up feedback on the SHA-pinning PR: - @coderabbitai (P1 nitpicks) + @JSONbored: add 'persist-credentials: false' to checkout steps in jobs that don't perform authenticated git operations. Adds the line to 17 read-only checkouts across 9 workflows (chart-ci, ci, flutter-build, helm-publish, ios-testflight, llm-evals, preview-cleanup, preview-deploy, publish:build). Checkouts inside jobs that 'git push' (chart-release, mobile-build, mobile-release, helm-publish:second-checkout, publish:bump-pre_release) are intentionally left alone so they keep their token. - @jjmata: preview-deploy.yml was the only workflow on actions/setup-node v6.4.0; everywhere else pinned v5.0.0. Standardise on v5.0.0 to match. Dependabot config already has a github-actions ecosystem entry with a weekly schedule, so no addition needed for that point. * chore(ci): document intentional setup-node v6→5 normalization (#1811) @superagent-security flagged the v6.4.0 -> v5.0.0 change in preview-deploy.yml as a possible unintended downgrade. The downgrade was deliberate, per @jjmata's review request to normalize setup-node across all workflows. Add an inline YAML comment next to the line so future scans don't re-flag it. --------- Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: jeffrey701 <jeffrey701@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>	2026-05-30 23:35:19 +02:00
dripsmvcp	f7df709e6d	fix(snaptrade): import non-primary-currency cash as cash holdings (#1979) ... * fix(snaptrade): import non-primary-currency cash as cash holdings Fixes #1809. SnaptradeAccount#upsert_balances! picked a single cash entry (account currency -> USD -> first) and stored only that in cash_balance; every other currency's cash was discarded. A moomoo Canada account with CAD $500 + USD $1000 imported only the CAD. Persist the full balances snapshot (new raw_balances_payload column) and surface each non-primary-currency cash entry as a synthetic per-currency cash holding (Security.cash_for(account, currency:)), mirroring the existing cash-security pattern. The primary currency stays in cash_balance. HoldingsProcessor now also runs for cash-only balances, and the Processor invokes it when there are holdings OR non-primary cash. Cash holdings use a stable external_id so repeated syncs update rather than duplicate. * fix(snaptrade): encrypt raw_balances_payload and drop cash amount from log Addresses PR #1979 review: Codex P1 (encrypt the newly persisted balances snapshot at rest, matching the other raw provider payloads) and CodeRabbit nitpick (do not log monetary amounts at info level). * refactor(snaptrade): extract primary_cash_entry and harden balances test PR #1979 review: extract the shared account-currency->USD->first cash selection into a private helper (CodeRabbit DRY nitpick); reorder the upsert_balances! test so the primary currency is not first, proving dig(:currency,:code) resolves it on string-keyed payloads rather than the entries.first fallback (jjmata).	2026-05-30 23:29:37 +02:00
dripsmvcp	ea316b4277	fix(merchants): preserve manual merchant edits across provider sync (#1981) ... * fix(merchants): preserve manual merchant edits across provider sync Fixes #1977. Merging merchants, converting a synced (provider) merchant to a family merchant, and unlinking a merchant all reassign transactions.merchant_id via update_all without flagging the entries as user_modified. The next provider sync sees the entries as unmodified and reverts the change. Add Entry.mark_user_modified_for_transactions! and call it (before the merchant_id update, so the scope still matches) in Merchant::Merger#merge!, ProviderMerchant#convert_to_family_merchant_for, and #unlink_from_family. The sync skip-guard already honours user_modified, so flagged entries are left untouched on subsequent syncs. * fix(merchants): pass transaction relation to bulk user_modified helper Addresses PR #1981 review (CodeRabbit): mark_user_modified_for_transactions! now accepts an ActiveRecord::Relation and selects ids via subquery, so large merges/unlinks don't materialize ids or hit SQL parameter limits. Array of ids still supported. Callers pass the scope relation directly.	2026-05-30 23:27:18 +02:00
Rene Arredondo	a002920bfb	fix(charts): auto-fit donut center text to inner ring (#2002) (#2017) ... * fix(charts): auto-fit donut center text to inner ring (#2002) * fix(charts): use Number.parseFloat for biome lint * fix(charts): use rendered donut diameter and destructive token	2026-05-30 16:20:21 +02:00
ghost	e28b883107	ci(preview): split PR image builds from trusted deploys (#2057) ... * ci(preview): split PR image builds from trusted deploys * ci(preview): harden preview artifact handoff Move the preview image artifact into the trusted preview workflow as a no-secret build job, gate deployment on base-trusted workflow definitions, and keep Cloudflare credentials isolated to the deploy-only job. Also fail closed when the pushed image reference is not written into wrangler.toml and expand the preview deploy guard to enforce the same-run artifact and permission boundaries. * ci(preview): move preview builds out of privileged trigger * ci(preview): avoid secret-shaped wrangler env assignments * ci(preview): keep wrangler credential env explicit	2026-05-30 15:45:43 +02:00
Tân Một Nắng	7ad287c4db	feat(i18n): add Vietnamese (vi) locale (#2043) ... * feat(i18n): add Vietnamese (vi) locale - Add "vi" to SUPPORTED_LOCALES in LanguagesHelper - Create 110 vi.yml translation files across all locale directories: breadcrumbs, models (27 files), views (75+ files), mailers, doorkeeper - All files validated as valid YAML with no interpolation mismatches - Fallback to English for any untranslated keys via existing fallbacks config * fix(i18n): apply CodeRabbit review fixes to Vietnamese locale - breadcrumbs: securities → Chứng khoán (was duplicate of security/Bảo mật) - period label_short: distinguish years from days (5Năm/10Năm/NĐN vs N for days) - imports: localize "Hover" → "Di chuột" in error hint - recurring_transactions: transfer_feature_disabled uses "Chuyển khoản" not "Giao dịch" - reports: YTD period labels "NNN %{year}" → "Từ đầu năm %{year}" - sso_identities: explicit unlink success message instead of generic "Thành công" - simplefin_items: standardize branding SimpleFin → SimpleFIN (4 occurrences) - transactions: rename duplicate YAML key merge_duplicate → merge_duplicate_button	2026-05-30 01:32:30 +02:00
Jeff	84ad60d541	fix(ai-chat): disable submit on empty input instead of surfacing 'Content missing' (#1697) (#1872) ... * fix(ai-chat): disable submit on empty input instead of surfacing 'Content missing' (#1697) Empty-input clicks on the chat send button posted the form, which then failed Message's `validates :content, presence: true` and surfaced `Content missing` to the user. The right shape per ChatGPT / Claude UX is to prevent the submission entirely until the input contains non-whitespace content. Add a `submit` target on the icon button and have the existing chat Stimulus controller: - Initialise the button to `disabled` when no `message_hint` is set. - Toggle disabled on every input event (re-using the existing `autoResize` handler) based on `input.value.trim().length > 0`. - Pre-clear disabled when a sample question is injected. - Short-circuit the Enter-key submit path on empty content so keyboard users hit the same gate. Closes #1697 * fix(ai-chat): drop server-rendered disabled attr, keep JS-driven gate (#1697) Codex review (P1) + @JSONbored + @jjmata called out that rendering the submit button with `disabled: message_hint.blank?` would lock the form out for users without working JS (asset failure, exception during Stimulus init, etc.). Server-side validation already catches empty submits with a real error message — server-disabling the button on top of that turns a soft fail into a hard one. Remove the server-render `disabled:` attribute. The chat Stimulus controller still runs `#updateSubmitState()` on connect, on every input event, and after sample-question injection, and `handleInputKeyDown` still short-circuits empty Enter submits. With JS the UX is identical; without JS the form keeps its fallback path. --------- Co-authored-by: jeffrey701 <jeffrey701@users.noreply.github.com>	2026-05-30 01:30:11 +02:00
Meng	f397b1a722	chore(i18n): complete Chinese locale coverage (#2010) ... * i18n: expand Chinese locale batch 1 * i18n: expand Chinese locale batch 2 * i18n: expand Chinese locale batch 3 * i18n: expand Chinese locale batch 4 * i18n: expand Chinese locale batch 5 * i18n: expand Chinese locale batch 6 * i18n: expand Chinese locale batch 7 * i18n: expand Chinese locale batch 8 * i18n: expand Chinese locale batch 9 * i18n: expand Chinese locale batch 10 * i18n: expand Chinese locale batch 11 * i18n: expand Chinese locale batch 12 * i18n: expand Chinese locale batch 13 * i18n: expand Chinese locale batch 14 * i18n: expand Chinese locale batch 15 * i18n: finish Chinese locale coverage * fix(i18n): quote zh-CN interpolation scalars * fix(i18n): refine zh-CN locale wording * fix(i18n): normalize Indexa Capital zh-CN copy * fix(i18n): address zh-CN review feedback * fix(i18n): resolve remaining zh-CN review items * fix(i18n): refine remaining zh-CN copy --------- Co-authored-by: Meng <19986978+ashanzzz@users.noreply.github.com> Co-authored-by: Hermes Agent <hermes@local>	2026-05-30 01:06:43 +02:00
ghost	adabc55937	ci(preview): isolate preview deployment tooling (#2025) ... * ci(preview): isolate deployment tooling Keep PR preview source separate from the deployment toolchain by building a temporary deploy workspace from base-revision preview metadata and PR-owned source. Add a focused CI guard so future preview workflow edits preserve the trusted tooling split. * ci(preview): harden workflow guard checks Address CodeRabbit feedback by making the preview deploy guard assertions collision-proof and more resilient to equivalent GitHub Actions expression and workspace path forms. * ci(preview): normalize workflow guard paths * ci(preview): defer workflow guard validation * revert(preview): restore workflow guard validation * ci(preview): gate preview deployments	2026-05-30 00:54:20 +02:00
Wes	7685650e63	feat(assistant): add get_budget function for budget tracking (#1966) ... * feat(assistant): add get_budget function for budget tracking Exposes the existing Budget / BudgetCategory pacing data to the AI assistant as a `get_budget` function. Supports a target month and an optional `prior_months` window for trend comparison, with the response shape matching the budget UI (totals, income, per-category status, suggested daily spend on the current month). Honors custom month_start_day by matching `Budget.param_to_date` semantics for explicit slug input, so `month` round-trips with the response's `month` field. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * test(assistant): use fixture reference for Food & Drink lookup Replace fragile string match on `bc.category.name == "Food & Drink"` with the `categories(:food_and_drink)` fixture so the test setup isn't sensitive to category-name translations. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(assistant): enforce strict month format in get_budget `Date.strptime` is lenient about trailing characters, so inputs like `"2026-05-01"` or `"may-2026foo"` were parsing successfully and being silently truncated to May 2026. Pre-validate the raw string with anchored regex patterns for the documented YYYY-MM and MMM-YYYY shapes so malformed tool arguments raise Assistant::Error instead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(budgets): suggested_daily_spending handles custom-month periods The helper compared `budget.start_date.month/year` against `Date.current.month/year` and returned nil whenever the current period straddled two calendar months — common for families with `month_start_day != 1` (e.g., May 15–Jun 14 viewed on Jun 1). Replace the calendar-month check with `budget.current?` and compute remaining days from `budget.end_date` so the helper works for both standard and custom periods. This also restores the daily pacing row in the budget UI for custom-month families. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(assistant): make get_budget read-only for prior months `prior_months: N` was calling `Budget.find_or_bootstrap` for every month, which created empty `Budget` rows (and synced `BudgetCategory` children) as a side effect of an AI query. Only the explicit target month now bootstraps; prior months use `Budget.find_by` and are dropped from the response if they don't exist. The response now includes `months_unavailable: N` so the LLM can phrase a sensible answer when fewer months come back than requested. Extract `Budget.period_for(date, family:)` to share the date-bracket math between `find_or_bootstrap`, `budget_date_valid?`, and the new read-only path in `get_budget`. Adds two tests covering the no-bootstrap behavior for prior months and the `prior_months` clamp at `MAX_PRIOR_MONTHS`. Updates the existing N+1 sorted-months test to seed prior budgets explicitly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: wolstad <wesleyolstad@protonmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-30 00:51:16 +02:00
glorydavid03023	208b3dec9d	fix(transactions): migrate transaction filter searches to DS::SearchInput (#1998) ... * fix(transactions): migrate filter sidebar searches to DS::SearchInput Replace hand-rolled search fields that used invalid focus:ring-gray-500 with DS::SearchInput (:embedded). Align date filter focus styles with the DS focus ring pattern. Refs #1715 * fix(transactions): localize filter search copy and align date focus ring Address validator feedback by replacing hardcoded filter input labels with i18n keys and updating date filter focus classes to the current design-system ring pattern. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>	2026-05-30 00:48:17 +02:00
ghost	3bcc86f4a8	refactor(imports): back PDF imports with statements (#1786)	2026-05-30 00:22:25 +02:00
ghost	92549bb82a	feat(settings): add reviewed category merge flow (#1754)	2026-05-30 00:12:54 +02:00
Rene Arredondo	d7f51c3c3c	fix(currencies): add DOGE entry to config/currencies.yml (#2008) (#2030)	2026-05-29 23:47:40 +02:00
CrossDrain	2620653b2a	fix(balance): derive waypoint start from day's flows to prevent double-counting and phantom bumps (#2031) ... * fix(balance): fix double-counting on reconciliation waypoints with same-day transactions Waypoint branch was setting start = end = waypoint and passing real flows to build_balance. Since end_balance is a PG generated column that recomputes from flows, transactions were double-counted on waypoint days and the prior gap day inherited a phantom jump. Fix: pin only the end to the API value, derive start from the day's own flows (same as current_anchor). Transaction attributed once, gap day correct, investment cash/holdings split correct. Adds regression test + GUI breakdown test verified against real PG columns through UI::Account::BalanceReconciliation. Fixes #2007. * test(balance): add investment waypoint regression test Covers reconciliation waypoint + same-day trade on investment accounts: end_balance must match API-reported total (not double-count trade flows), cash/non-cash flows must be preserved, and gap day total must be correct.	2026-05-28 19:37:57 +02:00
Rene Arredondo	be2d3aa3bb	fix(plaid): surface configuration/product-access errors from the Link flow (#1792) (#1991) ... * fix(plaid): surface configuration/product-access errors from Link flow (#1792) * fix(plaid): harden Plaid Link onExit guard + nil-body JSON parse (#1792 review) * fix lint check issue * fix test unit check	2026-05-28 14:55:21 +02:00
glorydavid03023	e13683c389	fix(enable_banking): migrate select_bank UI to DS primitives (#1997) ... Replace hand-rolled Beta pill and secondary cancel link with DS::Pill and DS::Link on the bank picker dialog. Refs #1971	2026-05-28 14:50:49 +02:00
CrossDrain	52083d5774	feat(reports): add Period Return card to Investment Performance (#1962) ... * feat(reports): add Period Return card to Investment Performance tab Surfaces market-only return (absolute + %) for the selected period using net_market_flows from the balances table, excluding contributions and withdrawals. Appears in both the interactive report and the print view. * docs: remove TODOS.md; fold FX fallback caveat into PR description The single V2 item (Period Return's 1:1 FX fallback on missing rates) is now documented under Known Limitations in the PR description, so a tracked file in the repo root is redundant. * fix(investment_statement): align start_value denominator scope and FX handling Add status filter to match absolute_return, and move FX conversion into SQL so pre-period balances are found even when an account's currency was changed after balances were recorded.	2026-05-28 14:49:04 +02:00
glorydavid03023	79ad3e764f	fix(views): DS drift — sankey tooltip tokens (#1996) ... * fix(views): DS drift sankey tooltip and imports icon token Replace raw palette classes on the cashflow Sankey tooltip with functional tokens (aligned with time_series_chart). Use bg-surface for the YNAB import option icon background. Refs #1971, #1951 * fix(views): add privacy-sensitive sankey tooltip class Align the sankey tooltip with privacy mode masking by appending privacy-sensitive while keeping the DS tokenized tooltip styling. --------- Signed-off-by: glorydavid03023 <glorydavid03023@gmail.com>	2026-05-28 00:17:47 +02:00