mirror of
https://github.com/we-promise/sure.git
synced 2026-04-08 06:44:52 +00:00
* Add pending transaction handling and duplicate reconciliation logic - Implemented logic to exclude pending transactions from budgets and analytics calculations. - Introduced mechanisms for reconciling pending transactions with posted versions. - Added duplicate detection with support for merging or dismissing matches. - Updated transaction search filters to include a `status_filter` for pending/confirmed transactions. - Introduced UI elements for reviewing and resolving duplicates. - Enhanced `ProviderSyncSummary` with stats for reconciled and stale pending transactions. * Refactor translation handling and enhance transaction and sync logic - Moved hardcoded strings to locale files for improved translation support. - Refined styling for duplicate transaction indicators and sync summaries. - Improved logic for excluding stale pending transactions and updating timestamps on batch exclusion. - Added unique IDs to status filters for better element targeting in UI. - Optimized database queries to avoid N+1 issues in stale pending calculations. * Add sync settings and enhance pending transaction handling - Introduced a new "Sync Settings" section in hosting settings with UI to toggle inclusion of pending transactions. - Updated handling of pending transactions with improved inference logic for `posted=0` and `transacted_at` in processors. - Added priority order for pending transaction inclusion: explicit argument > environment variable > runtime configurable setting. - Refactored settings and controllers to store updated sync preferences. * Refactor sync settings and pending transaction reconciliation - Extracted logic for pending transaction reconciliation, stale exclusion, and unmatched tracking into dedicated methods for better maintainability. - Updated sync settings to infer defaults from multiple provider environment variables (`SIMPLEFIN_INCLUDE_PENDING`, `PLAID_INCLUDE_PENDING`). - Refined UI and messaging to handle multi-provider configurations in sync settings. # Conflicts: # app/models/simplefin_item/importer.rb * Debounce transaction reconciliation during imports - Added per-run reconciliation debouncing to prevent repeated scans for the same account during chunked history imports. - Trimmed size of reconciliation stats to retain recent details only. - Introduced error tracking for reconciliation steps to improve UI visibility of issues. * Apply ABS() in pending transaction queries and improve error handling - Updated pending transaction logic to use ABS() for consistent handling of negative amounts. - Adjusted amount bounds calculations to ensure accuracy for both positive and negative values. - Refined exception handling in `merge_duplicate` to log failures and update user alert. - Replaced `Date.today` with `Date.current` in tests to ensure timezone consistency. - Minor optimization to avoid COUNT queries by loading limited records directly. * Improve error handling in duplicate suggestion and dismissal logic - Added exception handling for `store_duplicate_suggestion` to log failures and prevent crashes during fuzzy/low-confidence matches. - Enhanced `dismiss_duplicate` action to handle `ActiveRecord::RecordInvalid` and display appropriate user alerts. --------- Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com>
85 lines
2.2 KiB
Ruby
85 lines
2.2 KiB
Ruby
class PlaidEntry::Processor
|
|
# plaid_transaction is the raw hash fetched from Plaid API and converted to JSONB
|
|
def initialize(plaid_transaction, plaid_account:, category_matcher:)
|
|
@plaid_transaction = plaid_transaction
|
|
@plaid_account = plaid_account
|
|
@category_matcher = category_matcher
|
|
end
|
|
|
|
def process
|
|
import_adapter.import_transaction(
|
|
external_id: external_id,
|
|
amount: amount,
|
|
currency: currency,
|
|
date: date,
|
|
name: name,
|
|
source: "plaid",
|
|
category_id: matched_category&.id,
|
|
merchant: merchant,
|
|
pending_transaction_id: pending_transaction_id, # Plaid's linking ID for pending→posted
|
|
extra: {
|
|
plaid: {
|
|
pending: plaid_transaction["pending"],
|
|
pending_transaction_id: pending_transaction_id # Also store for reference
|
|
}
|
|
}
|
|
)
|
|
end
|
|
|
|
private
|
|
attr_reader :plaid_transaction, :plaid_account, :category_matcher
|
|
|
|
def import_adapter
|
|
@import_adapter ||= Account::ProviderImportAdapter.new(account)
|
|
end
|
|
|
|
def account
|
|
plaid_account.current_account
|
|
end
|
|
|
|
def external_id
|
|
plaid_transaction["transaction_id"]
|
|
end
|
|
|
|
def name
|
|
plaid_transaction["merchant_name"] || plaid_transaction["original_description"]
|
|
end
|
|
|
|
def amount
|
|
plaid_transaction["amount"]
|
|
end
|
|
|
|
def currency
|
|
plaid_transaction["iso_currency_code"]
|
|
end
|
|
|
|
def date
|
|
plaid_transaction["date"]
|
|
end
|
|
|
|
# Plaid provides this linking ID when a posted transaction matches a pending one
|
|
# This is the most reliable way to reconcile pending→posted
|
|
def pending_transaction_id
|
|
plaid_transaction["pending_transaction_id"]
|
|
end
|
|
|
|
def detailed_category
|
|
plaid_transaction.dig("personal_finance_category", "detailed")
|
|
end
|
|
|
|
def matched_category
|
|
return nil unless detailed_category
|
|
@matched_category ||= category_matcher.match(detailed_category)
|
|
end
|
|
|
|
def merchant
|
|
@merchant ||= import_adapter.find_or_create_merchant(
|
|
provider_merchant_id: plaid_transaction["merchant_entity_id"],
|
|
name: plaid_transaction["merchant_name"],
|
|
source: "plaid",
|
|
website_url: plaid_transaction["website"],
|
|
logo_url: plaid_transaction["logo_url"]
|
|
)
|
|
end
|
|
end
|