mirror of
https://github.com/we-promise/sure.git
synced 2026-07-12 12:55:20 +00:00
169fd139b5
* fix(chat): surface and recover from undelivered assistant responses When the background worker that runs AssistantResponseJob is down or not polling the high_priority queue, the eager "pending" assistant message had no safeguard: chat hung on "Thinking…" forever with no error, timeout, or retry, and the LLM provider was never even called. Add three layers of resilience: - Client watchdog (chat_controller.js): a pending "Thinking…" bubble that waits past a threshold (default 90s) with no response asks the server to fail it. Keyed on the pending marker — which disappears the instant a real response streams — so a slow-but-working response is never falsely timed out. - Server failure capture (Chat#handle_undelivered_response! + MessagesController#report_timeout): clears the dead bubble, records a friendly "the assistant didn't respond" error with Retry, and writes a DebugLogEntry so support can see it in /settings/debug. - Worker liveness signal (BackgroundJobHealth + warning banner): reads Sidekiq's process/queue state directly from Redis in the web process — so a down worker is detectable even though the worker is the thing that's broken — and warns self-hosted users when no worker polls high_priority or it's badly backed up. Fails open so a Sidekiq/Redis blip never blocks chat. Tests: Chat model (3), MessagesController (2), BackgroundJobHealth (5). * fix(chat): address review — server-side timeout guard + watchdog retry safety - Chat#handle_undelivered_response!: gate the state change behind a row lock and a server-side minimum age (UNDELIVERED_RESPONSE_TIMEOUT = 60s). The browser watchdog is untrusted, so re-read the row under lock and only fail a bubble that is still pending AND has genuinely waited past the timeout — never racing a worker that is finishing a slow response. (Codex P2 + CodeRabbit) - chat_controller.js: only mark a report URL as reported on response.ok (fetch resolves on HTTP 4xx/5xx, rejecting only on network errors), and guard concurrent duplicate POSTs with an in-flight set, so a failed report retries instead of stranding the bubble. (CodeRabbit) - _worker_health_warning: drop the unused `chat:` local + its render arg. (CodeRabbit)
46 lines
1.4 KiB
Ruby
46 lines
1.4 KiB
Ruby
require "test_helper"
|
|
|
|
class MessagesControllerTest < ActionDispatch::IntegrationTest
|
|
setup do
|
|
sign_in @user = users(:family_admin)
|
|
@chat = @user.chats.first
|
|
end
|
|
|
|
test "can create a message" do
|
|
post chat_messages_url(@chat), params: { message: { content: "Hello", ai_model: "gpt-4.1" } }
|
|
|
|
assert_redirected_to chat_path(@chat, thinking: true)
|
|
end
|
|
|
|
test "cannot create a message if AI is disabled" do
|
|
@user.update!(ai_enabled: false)
|
|
|
|
post chat_messages_url(@chat), params: { message: { content: "Hello", ai_model: "gpt-4.1" } }
|
|
|
|
assert_response :forbidden
|
|
end
|
|
|
|
test "report_timeout fails an undelivered assistant message" do
|
|
BackgroundJobHealth.stubs(:snapshot).returns({})
|
|
BackgroundJobHealth.stubs(:summary).returns("")
|
|
|
|
pending = @chat.messages.create!(type: "AssistantMessage", content: "", ai_model: "gpt-4.1", status: :pending, created_at: 5.minutes.ago)
|
|
|
|
post report_timeout_chat_message_url(@chat, pending)
|
|
|
|
assert_response :ok
|
|
assert_not Message.exists?(pending.id)
|
|
assert @chat.reload.error.present?
|
|
end
|
|
|
|
test "report_timeout cannot touch another user's chat" do
|
|
other_chat = users(:family_member).chats.first
|
|
pending = other_chat.messages.create!(type: "AssistantMessage", content: "", ai_model: "gpt-4.1", status: :pending)
|
|
|
|
post report_timeout_chat_message_url(other_chat, pending)
|
|
|
|
assert_response :not_found
|
|
assert Message.exists?(pending.id)
|
|
end
|
|
end
|