mirror of
https://github.com/we-promise/sure.git
synced 2026-07-27 20:22:16 +00:00
b613d107be
* Fix N+1 queries on categories index by batching lookups and removing partial fallbacks * resolve Codex review suggestion about Guard subcategory against missing parents * resolve coderabbitai review suggestion - Guard against empty categories when computing category_ids_with_transactions * resolve coderabbitai review suggestion - Redundant pb-4 makes the conditional dead code * resolve coderabbitai caution on PR review * resolve sure-design review - DS Drift Patrol * fix conflicting hidden/flex classes * resolve jjmata review suggestion - schema.rb noise * fix conflict and adjust related parts * Ignore Brakeman EOLRails warning for Rails 7.2 Restore ignore entry lost during merge from main; documents upgrade tracking and matches brakeman 7.1.2 in Gemfile.lock. * db migration executed * Remove deprecated focus-ring override from goals color picker. The summary_class override was reintroduced during merge conflict resolution and clobbered DS::Disclosure's canonical focus styling. * fix merge conflict on disclosure.rb * Restore parent-based semantics while keeping the performance win for root categories * fix(ci): skip scheduled preview cleanup on forks Only run the hourly Cloudflare preview cleanup on we-promise/sure, where the required secrets exist. * Revert schema.rb dump noise unrelated to categories N+1 fix Restore db/schema.rb from main so PostgreSQL check-constraint and column-order churn does not obscure the real PR changes. Co-authored-by: Cursor <cursoragent@cursor.com> * Remove obsolete Rails 7.2 EOLRails Brakeman ignore Main is already on Rails 8.1, so the 7.2.3.1 ignore entry is no longer needed. Co-authored-by: Cursor <cursoragent@cursor.com> * Address review: bare disclosure docs, category picker aria label * fix(test): wait for async exchange rate updates in system test * fix(test): retry account edit submit around Turbo morph races --------- Co-authored-by: Cursor <cursoragent@cursor.com>
40 lines
1.4 KiB
Ruby
40 lines
1.4 KiB
Ruby
require "test_helper"
|
|
|
|
class DS::DisclosureTest < ViewComponent::TestCase
|
|
test "bare variant yields panel content without mt-2 wrapper" do
|
|
render_inline(DS::Disclosure.new(variant: :bare, summary_class: "cursor-pointer")) do |disclosure|
|
|
disclosure.with_summary_content { "Toggle" }
|
|
"Panel"
|
|
end
|
|
|
|
assert page.has_css?("details.group")
|
|
assert page.has_text?("Panel")
|
|
assert_no_match(/<div class="mt-2">/, rendered_content)
|
|
end
|
|
|
|
test "body wrapper defaults to an mt-2 margin" do
|
|
render_inline(DS::Disclosure.new(title: "More", open: true)) { "body text" }
|
|
|
|
assert_selector "details > div.mt-2", text: "body text"
|
|
end
|
|
|
|
test "body_class: nil drops the body margin wrapper" do
|
|
render_inline(DS::Disclosure.new(title: "More", open: true, body_class: nil)) { "body text" }
|
|
|
|
assert_no_selector "details > div.mt-2"
|
|
assert_selector "details > div", text: "body text"
|
|
end
|
|
|
|
test "forwards data attributes and a summary_class override" do
|
|
render_inline(DS::Disclosure.new(
|
|
summary_class: "custom-summary",
|
|
data: { controller: "color-icon-picker", action: "mousedown->color-icon-picker#handleOutsideClick" }
|
|
)) do |disclosure|
|
|
disclosure.with_summary_content { "trigger" }
|
|
end
|
|
|
|
assert_selector "details[data-controller='color-icon-picker']"
|
|
assert_selector "summary.custom-summary", text: "trigger"
|
|
end
|
|
end
|